Page MenuHomePhabricator

sheredom (Neil Henning)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2013, 2:54 AM (280 w, 1 d)

All things performance at AMD: current focus - Vulkan!

Recent Activity

Fri, Apr 12

sheredom created D60600: [InstCombine] Fix a vector-of-pointers instcombine undef bug..
Fri, Apr 12, 1:59 AM · Restricted Project

Mon, Apr 1

sheredom committed rG0a30f33ce21d: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure. (authored by sheredom).
[AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure.
Mon, Apr 1, 8:19 AM
sheredom committed rL357400: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
[AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure.
Mon, Apr 1, 8:19 AM
sheredom closed D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mon, Apr 1, 8:19 AM · Restricted Project, Restricted Project

Fri, Mar 29

sheredom added a reviewer for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure.: tpr.
Fri, Mar 29, 9:00 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Found a fun little bug whereby the phys vgprs were being coalesced onto previous instructions, and then shouldClusterMemOps was assuming only virt regs. Added a workaround for that.

Fri, Mar 29, 9:00 AM · Restricted Project, Restricted Project

Fri, Mar 22

sheredom accepted D59698: AMDGPU: Preserve LiveIntervals in WQM.
Fri, Mar 22, 1:59 PM
sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Update for two reasons:

Fri, Mar 22, 5:49 AM · Restricted Project, Restricted Project

Mar 21 2019

sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Fix review comments.

Mar 21 2019, 2:14 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 21 2019, 2:11 AM · Restricted Project, Restricted Project

Mar 19 2019

sheredom added a reviewer for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure.: arsenm.
Mar 19 2019, 10:15 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 19 2019, 10:14 AM · Restricted Project, Restricted Project
sheredom committed rG47c2bd2b349f: [AMDGPU] Add convergent attribute to WWM. (authored by sheredom).
[AMDGPU] Add convergent attribute to WWM.
Mar 19 2019, 9:31 AM
sheredom committed rL356470: [AMDGPU] Add convergent attribute to WWM..
[AMDGPU] Add convergent attribute to WWM.
Mar 19 2019, 9:31 AM
sheredom closed D59536: [AMDGPU] Add convergent attribute to WWM..
Mar 19 2019, 9:31 AM · Restricted Project, Restricted Project
sheredom committed rGe85f6bd64fbe: [AMDGPU] Ban i8 min3 promotion. (authored by sheredom).
[AMDGPU] Ban i8 min3 promotion.
Mar 19 2019, 8:50 AM
sheredom committed rL356464: [AMDGPU] Ban i8 min3 promotion..
[AMDGPU] Ban i8 min3 promotion.
Mar 19 2019, 8:50 AM
sheredom closed D59543: [AMDGPU] Ban non-supported min3/max3 promotions..
Mar 19 2019, 8:49 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59543: [AMDGPU] Ban non-supported min3/max3 promotions..
Mar 19 2019, 7:42 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59543: [AMDGPU] Ban non-supported min3/max3 promotions..

Added the max3 cases too.

Mar 19 2019, 7:42 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59543: [AMDGPU] Ban non-supported min3/max3 promotions..
Mar 19 2019, 7:26 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59543: [AMDGPU] Ban non-supported min3/max3 promotions..

Changed it to a whitelist of types rather than a blacklist (much better idea).

Mar 19 2019, 7:26 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59543: [AMDGPU] Ban non-supported min3/max3 promotions..

Fixed review comments by Matt and added the extra test cases that were a great idea!

Mar 19 2019, 7:17 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59543: [AMDGPU] Ban non-supported min3/max3 promotions..
Mar 19 2019, 7:00 AM · Restricted Project, Restricted Project
sheredom created D59543: [AMDGPU] Ban non-supported min3/max3 promotions..
Mar 19 2019, 6:29 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 19 2019, 1:45 AM · Restricted Project, Restricted Project
sheredom created D59536: [AMDGPU] Add convergent attribute to WWM..
Mar 19 2019, 1:45 AM · Restricted Project, Restricted Project

Mar 18 2019

sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 18 2019, 8:39 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Reduce the number of DPP calls in the test for cleanliness, and reintroduce the convergent on WWM. The CFG test contains the bug that was exposed by the lack of convergent on WWM, LLVM will sink the WWM statement out of the branch which totally messes up all calculations.

Mar 18 2019, 8:39 AM · Restricted Project, Restricted Project
sheredom committed rG523dab07887f: [AMDGPU] Add an experimental buffer fat pointer address space. (authored by sheredom).
[AMDGPU] Add an experimental buffer fat pointer address space.
Mar 18 2019, 7:46 AM
sheredom committed rL356373: [AMDGPU] Add an experimental buffer fat pointer address space..
[AMDGPU] Add an experimental buffer fat pointer address space.
Mar 18 2019, 7:43 AM
sheredom closed D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 18 2019, 7:43 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 18 2019, 7:37 AM · Restricted Project, Restricted Project
sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 18 2019, 6:48 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Remove the explicit pass name.

Mar 18 2019, 6:44 AM · Restricted Project, Restricted Project
sheredom added inline comments to D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 18 2019, 6:44 AM · Restricted Project, Restricted Project
sheredom updated the diff for D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..

Addressed all review comments.

Mar 18 2019, 6:23 AM · Restricted Project, Restricted Project

Mar 13 2019

sheredom created D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure..
Mar 13 2019, 6:29 AM · Restricted Project, Restricted Project

Mar 7 2019

sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 7 2019, 1:45 AM · Restricted Project, Restricted Project
sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 7 2019, 12:58 AM · Restricted Project, Restricted Project

Mar 6 2019

sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 6 2019, 9:41 AM · Restricted Project, Restricted Project
sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 6 2019, 8:49 AM · Restricted Project, Restricted Project
sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 6 2019, 6:22 AM · Restricted Project, Restricted Project
sheredom updated the diff for D58957: [AMDGPU] Add an experimental buffer fat pointer address space..

Add a test case that triggers the target transform info code path.

Mar 6 2019, 6:22 AM · Restricted Project, Restricted Project

Mar 5 2019

sheredom added inline comments to D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 5 2019, 8:22 AM · Restricted Project, Restricted Project
sheredom accepted D58697: AMDGPU: Don't add unnecessary convergent attributes.

LGTM.

Mar 5 2019, 3:08 AM
sheredom created D58957: [AMDGPU] Add an experimental buffer fat pointer address space..
Mar 5 2019, 3:08 AM · Restricted Project, Restricted Project
sheredom accepted D58900: [AMDGPU] Fix DPP operand order in atomic optimizer.

LGTM.

Mar 5 2019, 3:05 AM · Restricted Project

Feb 11 2019

sheredom committed rG8c10fa1a903f: [AMDGPU] Fix DPP sequence in atomic optimizer. (authored by sheredom).
[AMDGPU] Fix DPP sequence in atomic optimizer.
Feb 11 2019, 6:44 AM
sheredom committed rL353703: [AMDGPU] Fix DPP sequence in atomic optimizer..
[AMDGPU] Fix DPP sequence in atomic optimizer.
Feb 11 2019, 6:43 AM
sheredom closed D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Feb 11 2019, 6:43 AM · Restricted Project, Restricted Project
sheredom added a comment to D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
In D57737#1392667, @tpr wrote:

But I still don't understand it:

  1. Why do you want an exclusive scan? Surely what you're trying to do is just "sum" up all lanes into lane 63, which is an inclusive scan.
Feb 11 2019, 3:49 AM · Restricted Project, Restricted Project
sheredom added inline comments to D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Feb 11 2019, 3:26 AM · Restricted Project, Restricted Project
sheredom updated the diff for D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..

Fix comment that should now say exclusive scan instead of inclusive scan.

Feb 11 2019, 2:50 AM · Restricted Project, Restricted Project

Feb 8 2019

sheredom updated the diff for D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..

Make the final readlane be in the WWM section too as per the review comments.

Feb 8 2019, 2:06 AM · Restricted Project, Restricted Project

Feb 7 2019

sheredom added inline comments to D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Feb 7 2019, 5:02 AM · Restricted Project, Restricted Project

Feb 6 2019

sheredom updated the diff for D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..

Updated to bring in an additional fix to remove read_register exec and replace it with a ballot.

Feb 6 2019, 1:46 AM · Restricted Project, Restricted Project

Feb 5 2019

sheredom created D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Feb 5 2019, 1:42 AM · Restricted Project, Restricted Project

Jan 29 2019

sheredom committed rL352500: [AMDGPU] Fix a weird WWM intrinsic issue..
[AMDGPU] Fix a weird WWM intrinsic issue.
Jan 29 2019, 6:28 AM
sheredom closed D56002: [AMDGPU] Fix a weird WWM intrinsic issue..
Jan 29 2019, 6:28 AM · Restricted Project

Jan 28 2019

sheredom updated the diff for D56002: [AMDGPU] Fix a weird WWM intrinsic issue..

Fixed review comments.

Jan 28 2019, 4:10 AM · Restricted Project

Jan 18 2019

sheredom committed rL351562: [AMDGPU] Add some missing always-uniform values..
[AMDGPU] Add some missing always-uniform values.
Jan 18 2019, 8:44 AM
sheredom closed D56845: [AMDGPU] Add some missing always-uniform values..
Jan 18 2019, 8:44 AM · Restricted Project
sheredom updated the diff for D56845: [AMDGPU] Add some missing always-uniform values..

Fix review comments.

Jan 18 2019, 8:44 AM · Restricted Project

Jan 17 2019

sheredom updated the diff for D56845: [AMDGPU] Add some missing always-uniform values..

Review comments.

Jan 17 2019, 9:52 AM · Restricted Project
sheredom updated the diff for D56845: [AMDGPU] Add some missing always-uniform values..

Also tag s.getpc as scalar, and add tests in the Analysis folder like suggested.

Jan 17 2019, 8:18 AM · Restricted Project
sheredom added a comment to D56845: [AMDGPU] Add some missing always-uniform values..

@arsenm agreed - not quite sure how to do tests for this? I started to look at how we test alias analysis, and they have a cl::opt to force print the debug info for that pass, and that is how our amdgpu-alias-analysis.ll tests the aliasing rules. How exactly to test that divergence analysis did something here?

Jan 17 2019, 5:57 AM · Restricted Project
sheredom created D56845: [AMDGPU] Add some missing always-uniform values..
Jan 17 2019, 4:10 AM · Restricted Project

Jan 10 2019

sheredom committed rL350838: [AMDGPU] Fix dwordx3/southern-islands failures..
[AMDGPU] Fix dwordx3/southern-islands failures.
Jan 10 2019, 8:25 AM
sheredom closed D56434: [AMDGPU] Fix dwordx3/southern-islands failures..
Jan 10 2019, 8:24 AM · Restricted Project
sheredom added a comment to D55444: AMDGPU: Fix DPP combiner.

@cwabbott I planned to do a followup once this DPP change had landed to add the missing dpp/codegen patterns to the atomic optimizer - so watch this space!

Jan 10 2019, 6:16 AM · Restricted Project, Restricted Project

Jan 9 2019

sheredom added inline comments to D56434: [AMDGPU] Fix dwordx3/southern-islands failures..
Jan 9 2019, 5:06 AM · Restricted Project
sheredom updated the diff for D56434: [AMDGPU] Fix dwordx3/southern-islands failures..

Fix review comment.

Jan 9 2019, 5:06 AM · Restricted Project

Jan 8 2019

sheredom added inline comments to D56434: [AMDGPU] Fix dwordx3/southern-islands failures..
Jan 8 2019, 5:37 AM · Restricted Project
sheredom updated the diff for D56434: [AMDGPU] Fix dwordx3/southern-islands failures..

Fix review comments.

Jan 8 2019, 5:32 AM · Restricted Project
sheredom created D56434: [AMDGPU] Fix dwordx3/southern-islands failures..
Jan 8 2019, 4:44 AM · Restricted Project

Jan 7 2019

sheredom added a comment to D56002: [AMDGPU] Fix a weird WWM intrinsic issue..

@nhaehnle I've removed canReadVGPR as it only had the single callsite - but given @arsenm's comment I did not change getOpRegClass. I also don't feel super comfortable doing the change you suggested to addUsersToMoveToVALUWorklist as I'm worried that there will be non-LLVM-tested paths that I could trip up on with ease. I'd rather ship the commit as is if y'all are ok with it.

Jan 7 2019, 4:52 AM · Restricted Project
sheredom updated the diff for D56002: [AMDGPU] Fix a weird WWM intrinsic issue..

Removed canReadVGPR as it had only a single callsite.

Jan 7 2019, 4:50 AM · Restricted Project

Dec 21 2018

sheredom created D56002: [AMDGPU] Fix a weird WWM intrinsic issue..
Dec 21 2018, 7:08 AM · Restricted Project

Dec 12 2018

sheredom committed rL348937: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..
[AMDGPU] Extend the SI Load/Store optimizer to combine more things.
Dec 12 2018, 8:18 AM
sheredom closed D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..
Dec 12 2018, 8:18 AM · Restricted Project

Dec 10 2018

sheredom committed rL348771: [AMDGPU] Change the l1 flush instruction for AMDPAL/MESA3D..
[AMDGPU] Change the l1 flush instruction for AMDPAL/MESA3D.
Dec 10 2018, 8:42 AM
sheredom closed D55367: [AMDGPU] Change the l1 flush instruction for AMDPAL/MESA3D..
Dec 10 2018, 8:42 AM · Restricted Project
sheredom updated the diff for D55367: [AMDGPU] Change the l1 flush instruction for AMDPAL/MESA3D..

Made the l1 flush change happen for MESA3D too (like Nicolai asked for).

Dec 10 2018, 3:37 AM · Restricted Project

Dec 6 2018

sheredom created D55367: [AMDGPU] Change the l1 flush instruction for AMDPAL/MESA3D..
Dec 6 2018, 5:47 AM · Restricted Project

Dec 4 2018

sheredom updated the diff for D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..

Fixed review comments:

Dec 4 2018, 2:12 AM · Restricted Project

Nov 8 2018

sheredom added inline comments to D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..
Nov 8 2018, 9:25 AM · Restricted Project

Nov 6 2018

sheredom updated the diff for D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..

We discussed this on an internal AMD meeting Monday 5th November 2018, and came to the conclusion that even though I do want the scalar load combining to be brought upstream, it would be better as a separate change so that we can get broader testing across the users of our AMDGPU backend.

Nov 6 2018, 2:39 AM · Restricted Project

Nov 5 2018

sheredom committed rL346128: [AMDGPU] Fix the new atomic optimizer in pixel shaders..
[AMDGPU] Fix the new atomic optimizer in pixel shaders.
Nov 5 2018, 4:07 AM
sheredom closed D53930: [AMDGPU] Fix the new atomic optimizer in pixel shaders..
Nov 5 2018, 4:07 AM · Restricted Project
sheredom added inline comments to D53930: [AMDGPU] Fix the new atomic optimizer in pixel shaders..
Nov 5 2018, 4:05 AM · Restricted Project
sheredom updated the diff for D53930: [AMDGPU] Fix the new atomic optimizer in pixel shaders..

Fix review comments made by @nhaehnle

Nov 5 2018, 4:05 AM · Restricted Project

Nov 2 2018

sheredom created D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things..
Nov 2 2018, 11:27 AM · Restricted Project
sheredom committed rL345962: [AMDGPU] UBSan bug fix for r345710.
[AMDGPU] UBSan bug fix for r345710
Nov 2 2018, 3:27 AM

Nov 1 2018

sheredom updated the diff for D53930: [AMDGPU] Fix the new atomic optimizer in pixel shaders..

Review fixes.

Nov 1 2018, 3:25 AM · Restricted Project

Oct 31 2018

sheredom created D53930: [AMDGPU] Fix the new atomic optimizer in pixel shaders..
Oct 31 2018, 6:46 AM · Restricted Project
sheredom committed rL345710: [AMDGPU] support image load/store a16.
[AMDGPU] support image load/store a16
Oct 31 2018, 3:38 AM
sheredom closed D53750: [AMDGPU] support image load/store a16.
Oct 31 2018, 3:38 AM · Restricted Project

Oct 29 2018

sheredom updated the diff for D53750: [AMDGPU] support image load/store a16.

Added an additional lit test for the dim variants (including the 2darraymsaa requested by @nhaehnle), and change the naming of the a16.d16 tests to vNf16.

Oct 29 2018, 2:43 AM · Restricted Project

Oct 26 2018

sheredom created D53750: [AMDGPU] support image load/store a16.
Oct 26 2018, 2:24 AM · Restricted Project