Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (131 w, 3 d)

Recent Activity

Tue, Aug 13

tstellar updated the diff for D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

Another attempt to fix this that depends less on the build directory.

Tue, Aug 13, 4:05 PM · Restricted Project
tstellar created D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Tue, Aug 13, 3:17 PM · Restricted Project

Thu, Aug 8

tstellar added a child revision for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Thu, Aug 8, 12:55 PM · Restricted Project
tstellar added a parent revision for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Aug 8, 12:55 PM · Restricted Project
tstellar created D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Thu, Aug 8, 12:50 PM · Restricted Project
tstellar added parent revisions for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo, D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics, D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Thu, Aug 8, 12:36 PM · Restricted Project
tstellar added a child revision for D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Aug 8, 12:36 PM · Restricted Project
tstellar added a child revision for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Aug 8, 12:36 PM · Restricted Project
tstellar added a child revision for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Aug 8, 12:36 PM · Restricted Project
tstellar committed rG87e2c9147e6d: lit: Bump version to 0.10.0 (authored by tstellar).
lit: Bump version to 0.10.0
Thu, Aug 8, 12:23 PM
tstellar committed rL368329: lit: Bump version to 0.10.0.
lit: Bump version to 0.10.0
Thu, Aug 8, 12:22 PM
tstellar closed D65763: lit: Bump version to 0.10.0.
Thu, Aug 8, 12:22 PM · Restricted Project
tstellar added a comment to D65763: lit: Bump version to 0.10.0.

We also need to bump the version in the release/9.x branch to 0.9.0.

Done in r367992, and I've made a note for myself to include it in the major version bump next time.

What made you notice this, i.e. where does this version number matter?

Thu, Aug 8, 11:55 AM · Restricted Project
tstellar created D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Aug 8, 10:39 AM · Restricted Project
tstellar committed rGe77eb50f6d66: lit: Use a License classifier that pypi will accept (authored by tstellar).
lit: Use a License classifier that pypi will accept
Thu, Aug 8, 10:25 AM
tstellar committed rL368315: lit: Use a License classifier that pypi will accept.
lit: Use a License classifier that pypi will accept
Thu, Aug 8, 10:25 AM
tstellar closed D65762: lit: Use a License classifier that pypi will accept.
Thu, Aug 8, 10:25 AM · Restricted Project

Wed, Aug 7

tstellar updated the diff for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.

Make helper function members of CombineInfo class.

Wed, Aug 7, 2:59 PM · Restricted Project
tstellar created D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Wed, Aug 7, 1:30 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Address review comments.

Wed, Aug 7, 10:26 AM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Update offsets for the raw and struct intrinsic variants.

Wed, Aug 7, 10:15 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Add missing comma.

Wed, Aug 7, 8:49 AM · Restricted Project
tstellar updated the summary of D65762: lit: Use a License classifier that pypi will accept.
Wed, Aug 7, 8:45 AM · Restricted Project
tstellar added a reviewer for D65762: lit: Use a License classifier that pypi will accept: joerg.
Wed, Aug 7, 8:40 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Change license classifier to: OSI Approved :: Apache Software License
as suggested by Joerg on IRC.

Wed, Aug 7, 8:40 AM · Restricted Project

Tue, Aug 6

tstellar committed rL368047: Add 8.0.1 clang-tools-extra docs.
Add 8.0.1 clang-tools-extra docs
Tue, Aug 6, 7:50 AM
tstellar committed rL368046: Add 8.0.1 libcxx docs.
Add 8.0.1 libcxx docs
Tue, Aug 6, 7:47 AM
tstellar committed rL368045: Add 8.0.1 lld docs.
Add 8.0.1 lld docs
Tue, Aug 6, 7:46 AM
tstellar committed rL368040: Update latest release to 8.0.1.
Update latest release to 8.0.1
Tue, Aug 6, 7:13 AM
tstellar committed rL368039: Add 8.0.1 clang docs.
Add 8.0.1 clang docs
Tue, Aug 6, 7:10 AM
tstellar committed rL368037: Add 8.0.1 LLVM docs.
Add 8.0.1 LLVM docs
Tue, Aug 6, 6:50 AM

Mon, Aug 5

tstellar added a comment to D65763: lit: Bump version to 0.10.0.

We also need to bump the version in the release/9.x branch to 0.9.0.

Mon, Aug 5, 11:34 AM · Restricted Project
tstellar created D65763: lit: Bump version to 0.10.0.
Mon, Aug 5, 11:34 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Remove accidental version bump.

Mon, Aug 5, 11:31 AM · Restricted Project
tstellar created D65762: lit: Use a License classifier that pypi will accept.
Mon, Aug 5, 11:29 AM · Restricted Project
tstellar committed rGe15d95a987d5: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs (authored by tstellar).
AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs
Mon, Aug 5, 9:11 AM
tstellar committed rL367881: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs
Mon, Aug 5, 9:08 AM
tstellar closed D65557: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
Mon, Aug 5, 9:08 AM · Restricted Project

Thu, Aug 1

tstellar committed rL367621: Add links to 8.0.1 binaries.
Add links to 8.0.1 binaries
Thu, Aug 1, 2:56 PM
tstellar added inline comments to D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
Thu, Aug 1, 9:07 AM · Restricted Project

Wed, Jul 31

tstellar committed rG7a2958bc20bc: AMDGPU/SILoadStoreOptimizer: Make some functions const (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Make some functions const
Wed, Jul 31, 10:40 PM
tstellar committed rL367517: AMDGPU/SILoadStoreOptimizer: Make some functions const.
AMDGPU/SILoadStoreOptimizer: Make some functions const
Wed, Jul 31, 10:40 PM
tstellar closed D65316: AMDGPU/SILoadStoreOptimizer: Make some functions const.
Wed, Jul 31, 10:40 PM · Restricted Project
tstellar created D65557: AMDGPU/LoadStoreOptimizer: Set the correct offset whem merging MMOs.
Wed, Jul 31, 10:17 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Add support for the raw and struct intrinsics.

Wed, Jul 31, 9:21 PM · Restricted Project

Tue, Jul 30

tstellar created D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
Tue, Jul 30, 8:46 PM · Restricted Project

Mon, Jul 29

tstellar committed rGcc0bc941d4eb: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions (authored by tstellar).
AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions
Mon, Jul 29, 9:43 AM
tstellar committed rL367237: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions
Mon, Jul 29, 9:42 AM
tstellar closed D65036: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
Mon, Jul 29, 9:42 AM · Restricted Project

Thu, Jul 25

tstellar abandoned D65288: AMDGPU: Disable the load and store cluster mutations for the schedulers.

Ok, thanks for the info. I will drop this patch.

Thu, Jul 25, 8:41 PM · Restricted Project
tstellar created D65316: AMDGPU/SILoadStoreOptimizer: Make some functions const.
Thu, Jul 25, 8:20 PM · Restricted Project
tstellar accepted D65002: AMDGPU/GlobalISel: Handle most function return types.

LGTM.

Thu, Jul 25, 2:17 PM
tstellar created D65288: AMDGPU: Disable the load and store cluster mutations for the schedulers.
Thu, Jul 25, 9:13 AM · Restricted Project

Wed, Jul 24

tstellar committed rGf181dd99cf1c: github-upload-release.py: Fix script name in examples (authored by tstellar).
github-upload-release.py: Fix script name in examples
Wed, Jul 24, 6:54 PM
tstellar committed rL366978: github-upload-release.py: Fix script name in examples.
github-upload-release.py: Fix script name in examples
Wed, Jul 24, 6:50 PM
tstellar committed rG925ccdbfd758: Add github-release.py script (authored by tstellar).
Add github-release.py script
Wed, Jul 24, 6:45 PM
tstellar committed rL366977: Add github-release.py script.
Add github-release.py script
Wed, Jul 24, 6:44 PM
tstellar closed D64841: Add github-release.py script.
Wed, Jul 24, 6:44 PM · Restricted Project
tstellar added inline comments to D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
Wed, Jul 24, 4:15 PM · Restricted Project

Tue, Jul 23

tstellar committed rL366812: Add 8.0.1 to the release page.
Add 8.0.1 to the release page
Tue, Jul 23, 7:32 AM

Mon, Jul 22

tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Rename test.

Mon, Jul 22, 11:03 AM · Restricted Project
tstellar added a comment to D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

We could do the same for the raw and struct variants of the intrinsics, but I wasn't sure exactly what conditions had to be met in order to guarantee that we had a constant offset.

Mon, Jul 22, 9:23 AM · Restricted Project
tstellar created D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
Mon, Jul 22, 9:23 AM · Restricted Project
tstellar accepted D65084: AMDGPU/GlobalISel: Remove manual store select code.

Ok, this seems fine. Those types aren't really use much.

Mon, Jul 22, 7:46 AM
tstellar accepted D65091: AMDGPU/GlobalISel: Select simple local stores.

LGTM.

Mon, Jul 22, 7:22 AM
tstellar accepted D65090: AMDGPU/GlobalISel: Select local loads.

LGTM.

Mon, Jul 22, 7:18 AM
tstellar accepted D65085: AMDGPU/GlobalISel: Fix flat load/store of pointer types.

LGTM.

Mon, Jul 22, 7:17 AM
tstellar accepted D65086: AMDGPU/GlobalISel: RegBankSelect struct buffer load/store.

LGTM.

Mon, Jul 22, 7:17 AM
tstellar added a comment to D65084: AMDGPU/GlobalISel: Remove manual store select code.

Which types are regressed?

Mon, Jul 22, 7:17 AM
tstellar accepted D65083: AMDGPU/GlobalISel: Select local atomic cmpxchg.

LGTM.

Mon, Jul 22, 7:17 AM
tstellar accepted D65082: AMDGPU/GlobalISel: Allow selection of DS atomicrmw.

LGTM.

Mon, Jul 22, 7:14 AM

Jul 19 2019

tstellar created D65036: AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions.
Jul 19 2019, 10:11 PM · Restricted Project
tstellar committed rL366604: Add links to 8.0.1 sources.
Add links to 8.0.1 sources
Jul 19 2019, 12:27 PM
tstellar committed rL366583: Add 7.1.0 release to index.html.
Add 7.1.0 release to index.html
Jul 19 2019, 7:26 AM

Jul 17 2019

tstellar added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

I'm in favor of this, but we should make sure there is documentation telling users how to explicitly choose the python version they want. I'm also curious, how does cmake determine which version to use if more than on interpreter is found?

Jul 17 2019, 3:54 PM · Restricted Project, Restricted Project
tstellar added a comment to D64841: Add github-release.py script.

My initial thought when I saw the filename was that this was a github version of test-release.sh. Which we'll need too, but it's not this one :-) What do you think about renaming to github-upload-release.py, or something else that has "upload" in the name to make it more explicit?

This is super cool! I just looked at https://github.com/llvm/llvm-project/releases

Should we be using this to host binaries from now on, and link to them from http://releases.llvm.org/ (ah, I see you did this for 7.1.0 already; I guess I'm not keeping up).

Jul 17 2019, 2:31 PM · Restricted Project
tstellar updated the diff for D64841: Add github-release.py script.

Rename script and add documentation for how to obtain a github token.

Jul 17 2019, 2:26 PM · Restricted Project
tstellar abandoned D64567: AMDGPU/GISel: Add support for vector shader inputs.
Jul 17 2019, 1:56 PM · Restricted Project
tstellar accepted D64877: AMDGPU/GlobalISel: Attempt to RegBankSelect image intrinsics.

LGTM.

Jul 17 2019, 1:56 PM

Jul 16 2019

tstellar created D64841: Add github-release.py script.
Jul 16 2019, 5:11 PM · Restricted Project

Jul 15 2019

tstellar committed rG4422cc4f1a91: [OpenCL] Make TableGen'd builtin tables and helper functions static (authored by tstellar).
[OpenCL] Make TableGen'd builtin tables and helper functions static
Jul 15 2019, 3:35 PM
tstellar committed rL366143: [OpenCL] Make TableGen'd builtin tables and helper functions static.
[OpenCL] Make TableGen'd builtin tables and helper functions static
Jul 15 2019, 3:34 PM
tstellar closed D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static.
Jul 15 2019, 3:34 PM · Restricted Project, Restricted Project
tstellar accepted D64511: AMDGPU/GlobalISel: Allow scalar s1 and/or/xor.

LGTM.

Jul 15 2019, 10:32 AM
tstellar accepted D64529: Add some release notes for 9.0 release.

LGTM.

Jul 15 2019, 10:24 AM
tstellar accepted D64721: AMDGPU/GlobalISel: Rewrite lowerFormalArguments.

LGTM.

Jul 15 2019, 7:49 AM
tstellar accepted D64734: AMDGPU/GlobalISel: Custom legalize G_INSERT_VECTOR_ELT.

LGTM.

Jul 15 2019, 7:47 AM
tstellar accepted D64733: AMDGPU/GlobalISel: Custom legalize G_EXTRACT_VECTOR_ELT.

LGTM.

Jul 15 2019, 7:47 AM
tstellar accepted D64731: AMDGPU/GlobalISel: Handle llvm.amdgcn.if.break.

LGTM.

Jul 15 2019, 7:47 AM
tstellar added inline comments to D64730: AMDGPU/GlobalISel: Select G_AND/G_OR/G_XOR.
Jul 15 2019, 7:47 AM
tstellar accepted D64730: AMDGPU/GlobalISel: Select G_AND/G_OR/G_XOR.

LGTM.

Jul 15 2019, 7:47 AM
tstellar accepted D64728: AMDGPU/GlobalISel: Don't constrain source register of VCC copies.

LGTM, do you think we'll need new register classes for the 32-bit boolean values?

Jul 15 2019, 7:44 AM
tstellar accepted D64727: AMDGPU/GlobalISel: Fix selecting vcc->vcc bank copies.

LGTM.

Jul 15 2019, 7:43 AM
tstellar added a comment to D64725: AMDGPU/GlobalISel: Select G_SHL.

This looks OK to me, but I'm not as familiar with how this will impact SDAG. Might want to have someone else take a look too.

Jul 15 2019, 7:43 AM
tstellar accepted D64724: AMDGPU/GlobalISel: Fix handling of sgpr (not scc bank) s1 to VCC.

LGTM.

Jul 15 2019, 7:40 AM
tstellar accepted D64723: AMDGPU/GlobalISel: Select llvm.amdgcn.end.cf.

LGTM.

Jul 15 2019, 7:38 AM
tstellar accepted D64722: AMDGPU/GlobalISel: Support arguments with multiple registers.

LGTM.

Jul 15 2019, 7:38 AM

Jul 12 2019

tstellar committed rL365928: Fix typo dev -> div.
Fix typo dev -> div
Jul 12 2019, 10:45 AM
tstellar committed rL365927: Add link to GitHub status page.
Add link to GitHub status page
Jul 12 2019, 10:43 AM
tstellar committed rG1d062dae158c: cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON (authored by tstellar).
cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON
Jul 12 2019, 8:12 AM