Page MenuHomePhabricator
People tstellar

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (139 w, 3 d)

Recent Activity
View All

Fri, Oct 11

tstellar committed rG35127d79b908: Merging r372606: (authored by tstellar).
Merging r372606:
Fri, Oct 11, 7:55 PM
tstellar committed rL374633: Merging r372606:.
Merging r372606:
Fri, Oct 11, 7:45 PM
tstellar committed rG171c0c22c464: Merging r373275: (authored by tstellar).
Merging r373275:
Fri, Oct 11, 3:20 PM
tstellar committed rL374605: Merging r373275:.
Merging r373275:
Fri, Oct 11, 3:20 PM

Thu, Oct 10

tstellar committed rGf8f1e8136300: [lldb][cmake] Fix build with GCC 4.8 and wchar-enabled libedit (authored by tstellar).
[lldb][cmake] Fix build with GCC 4.8 and wchar-enabled libedit
Thu, Oct 10, 9:56 PM
tstellar committed rL374511: [lldb][cmake] Fix build with GCC 4.8 and wchar-enabled libedit.
[lldb][cmake] Fix build with GCC 4.8 and wchar-enabled libedit
Thu, Oct 10, 9:56 PM
tstellar committed rG97578b14fca6: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access (authored by tstellar).
docs/DeveloperPolicy: Add instructions for requesting GitHub commit access
Thu, Oct 10, 4:36 PM
tstellar closed D66840: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.
Thu, Oct 10, 4:36 PM · Restricted Project
tstellar committed rL374474: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.
docs/DeveloperPolicy: Add instructions for requesting GitHub commit access
Thu, Oct 10, 4:36 PM
tstellar added inline comments to D68720: Support -fstack-clash-protection for x86.
Thu, Oct 10, 4:07 PM · Restricted Project, Restricted Project
tstellar committed rG1ffbfabf2f1f: [9.0 branch][ARM] VFPv2 only supports 16 D registers. (authored by tstellar).
[9.0 branch][ARM] VFPv2 only supports 16 D registers.
Thu, Oct 10, 12:48 PM
tstellar committed rL374433: [9.0 branch][ARM] VFPv2 only supports 16 D registers..
[9.0 branch][ARM] VFPv2 only supports 16 D registers.
Thu, Oct 10, 12:48 PM

Wed, Oct 9

tstellar committed rG966822b67f28: Bump version to 9.0.1 (authored by tstellar).
Bump version to 9.0.1
Wed, Oct 9, 1:41 PM
tstellar committed rL374218: Bump version to 9.0.1.
Bump version to 9.0.1
Wed, Oct 9, 1:38 PM
tstellar committed rGcbadd0d30ca7: git-llvm: Update for release_90 branch (authored by tstellar).
git-llvm: Update for release_90 branch
Wed, Oct 9, 11:17 AM
tstellar committed rL374193: git-llvm: Update for release_90 branch.
git-llvm: Update for release_90 branch
Wed, Oct 9, 11:17 AM

Tue, Oct 8

tstellar committed rG3a8d80944b77: AMDGPU: Add offsets to MMO when lowering buffer intrinsics (authored by tstellar).
AMDGPU: Add offsets to MMO when lowering buffer intrinsics
Tue, Oct 8, 10:07 AM
tstellar closed D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
Tue, Oct 8, 10:07 AM · Restricted Project
tstellar committed rL374087: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.
AMDGPU: Add offsets to MMO when lowering buffer intrinsics
Tue, Oct 8, 10:07 AM

Mon, Oct 7

tstellar committed rL374001: Update GitHub migration status.
Update GitHub migration status
Mon, Oct 7, 10:25 PM

Fri, Oct 4

tstellar created D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.
Fri, Oct 4, 3:27 PM · Restricted Project
tstellar added a comment to D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON.
In D68071#1695396, @mgorny wrote:

Would it be bad if I said I like mine more? I'm not a fan of implicit logic, and relying on specific filenames.

Fri, Oct 4, 2:47 PM · Restricted Project
tstellar added a reviewer for D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON: mgorny.
Fri, Oct 4, 2:21 PM · Restricted Project
tstellar added a comment to D68456: [lldb] [cmake] Support linking against clang-cpp dylib.

What about this patch: it's much more simple, though maybe I missed something: https://reviews.llvm.org/D68071

Fri, Oct 4, 2:21 PM · Restricted Project

Thu, Oct 3

tstellar added inline comments to D55391: Don't add unnecessary compiler flags to llvm-config output.
Thu, Oct 3, 8:33 PM · Restricted Project
tstellar committed rGe6f51713054f: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions
Thu, Oct 3, 10:11 AM
tstellar committed rL373630: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions
Thu, Oct 3, 10:11 AM
tstellar closed D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Thu, Oct 3, 10:10 AM · Restricted Project

Wed, Oct 2

tstellar accepted D68373: AMDGPU/GlobalISel: Handle RegBankSelect of G_INSERT_VECTOR_ELT.

LGTM.

Wed, Oct 2, 10:18 PM
tstellar accepted D68372: AMDGPU/GlobalISel: Split 64-bit vector extracts during RegBankSelect.

LGTM.

Wed, Oct 2, 10:18 PM
tstellar accepted D68371: AMDGPU/GlobalISel: Allow VGPR to index SGPR register.

LGTM.

Wed, Oct 2, 10:16 PM
tstellar added a comment to D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
In D65961#1675758, @arsenm wrote:

LGTM but I would rather avoid the list usage

Wed, Oct 2, 2:59 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Rebase.

Wed, Oct 2, 2:42 PM · Restricted Project
tstellar added a comment to D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Ping.

Wed, Oct 2, 12:40 PM · Restricted Project

Tue, Oct 1

tstellar committed rG004c79157e83: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo
Tue, Oct 1, 10:58 AM
tstellar committed rL373366: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo
Tue, Oct 1, 10:58 AM
tstellar closed D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.
Tue, Oct 1, 10:58 AM · Restricted Project

Mon, Sep 30

tstellar committed rGf18d747107de: Fix Driver/modules.cpp test to work when build directory name contains '.s' (authored by tstellar).
Fix Driver/modules.cpp test to work when build directory name contains '.s'
Mon, Sep 30, 4:43 PM
tstellar committed rL373275: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Fix Driver/modules.cpp test to work when build directory name contains '.s'
Mon, Sep 30, 4:41 PM
tstellar closed D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Mon, Sep 30, 4:41 PM · Restricted Project, Restricted Project
tstellar updated the diff for D66840: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.

Fix svn commit instructions.

Mon, Sep 30, 3:47 PM · Restricted Project

Fri, Sep 27

tstellar accepted D68175: AMDGPU/GlobalISel: Avoid getting MRI in every function.

LGTM.

Fri, Sep 27, 8:12 PM
tstellar added inline comments to D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Fri, Sep 27, 10:53 AM · Restricted Project, Restricted Project
tstellar updated the diff for D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

Don't check .s suffix.

Fri, Sep 27, 10:53 AM · Restricted Project, Restricted Project

Wed, Sep 25

tstellar created D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON.
Wed, Sep 25, 9:39 PM · Restricted Project

Mon, Sep 23

tstellar added a comment to D67926: Fix endianness handling in AVR MC.

@dylanmckay Why is the byte-swapping need here in the first place?

Mon, Sep 23, 11:15 AM · Restricted Project

Fri, Sep 20

tstellar committed rL372456: Add a note about not sorting the list.
Add a note about not sorting the list
Fri, Sep 20, 10:50 PM

Thu, Sep 19

tstellar created D67772: Update git-llvm script to push to GitHub.
Thu, Sep 19, 12:25 PM · Restricted Project

Wed, Sep 18

tstellar committed rG9f4c7571a1fe: AMDGPU/SILoadStoreOptimizer: Add const to more functions (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Add const to more functions
Wed, Sep 18, 9:39 PM
tstellar committed rL372298: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
AMDGPU/SILoadStoreOptimizer: Add const to more functions
Wed, Sep 18, 9:38 PM
tstellar closed D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Wed, Sep 18, 9:38 PM · Restricted Project
tstellar requested review of D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.

Ping.

Wed, Sep 18, 9:04 PM · Restricted Project

Sep 13 2019

tstellar added inline comments to D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Sep 13 2019, 5:43 PM · Restricted Project

Sep 12 2019

tstellar accepted D67484: test-release.sh: Don't use chrpath on Solaris.

LGTM. I think CMake removes the build RPATH when installing, but we'd have to confirm that before removing this code.

Sep 12 2019, 6:26 AM · Restricted Project

Sep 10 2019

tstellar accepted D66389: AMDGPU/GlobalISel: Legalize constant 32-bit loads.

LGTM.

Sep 10 2019, 8:11 AM

Sep 9 2019

tstellar added reviewers for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test: smeenai, phosek.
Sep 9 2019, 7:01 AM · Restricted Project
tstellar added inline comments to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Sep 9 2019, 7:00 AM · Restricted Project

Aug 28 2019

tstellar committed rG5be949e3d007: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library() (authored by tstellar).
[LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()
Aug 28 2019, 4:02 PM
tstellar committed rL370271: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library().
[LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to llvm_add_library()
Aug 28 2019, 4:02 PM
tstellar accepted D66906: [LLVM-C] Fix omission of INSTALL_WITH_TOOLCHAIN to.

LGTM.

Aug 28 2019, 3:03 PM

Aug 27 2019

tstellar created D66840: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.
Aug 27 2019, 3:57 PM · Restricted Project

Aug 26 2019

tstellar committed rL370009: Add meta directory to store svn/github username mappings.
Add meta directory to store svn/github username mappings
Aug 26 2019, 9:24 PM

Aug 20 2019

tstellar added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.
In D64817#1638283, @hubert.reinterpretcast wrote:
In D64817#1638218, @tstellar wrote:

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

It is possible to build with Clang and libc++ and not use a newer version of binutils for trunk.

Aug 20 2019, 4:10 PM · Restricted Project
tstellar added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

Aug 20 2019, 2:23 PM · Restricted Project
tstellar updated subscribers of D64817: [CMake] Fix LLVM build non-determinism on RHEL.
Aug 20 2019, 9:48 AM · Restricted Project

Aug 19 2019

tstellar accepted D66400: AMDGPU: Remove code address space predicates.

LGTM.

Aug 19 2019, 10:28 PM

Aug 13 2019

tstellar updated the diff for D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

Another attempt to fix this that depends less on the build directory.

Aug 13 2019, 4:05 PM · Restricted Project, Restricted Project
tstellar created D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.
Aug 13 2019, 3:17 PM · Restricted Project, Restricted Project

Aug 8 2019

tstellar added a child revision for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Aug 8 2019, 12:55 PM · Restricted Project
tstellar added a parent revision for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:55 PM · Restricted Project
tstellar created D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Aug 8 2019, 12:50 PM · Restricted Project
tstellar added parent revisions for D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions: D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo, D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics, D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar added a child revision for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo: D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 12:36 PM · Restricted Project
tstellar committed rG87e2c9147e6d: lit: Bump version to 0.10.0 (authored by tstellar).
lit: Bump version to 0.10.0
Aug 8 2019, 12:23 PM
tstellar committed rL368329: lit: Bump version to 0.10.0.
lit: Bump version to 0.10.0
Aug 8 2019, 12:22 PM
tstellar closed D65763: lit: Bump version to 0.10.0.
Aug 8 2019, 12:22 PM · Restricted Project
tstellar added a comment to D65763: lit: Bump version to 0.10.0.
In D65763#1616275, @hans wrote:
In D65763#1615311, @tstellar wrote:

We also need to bump the version in the release/9.x branch to 0.9.0.

Done in r367992, and I've made a note for myself to include it in the major version bump next time.

What made you notice this, i.e. where does this version number matter?

Aug 8 2019, 11:55 AM · Restricted Project
tstellar created D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.
Aug 8 2019, 10:39 AM · Restricted Project
tstellar committed rGe77eb50f6d66: lit: Use a License classifier that pypi will accept (authored by tstellar).
lit: Use a License classifier that pypi will accept
Aug 8 2019, 10:25 AM
tstellar committed rL368315: lit: Use a License classifier that pypi will accept.
lit: Use a License classifier that pypi will accept
Aug 8 2019, 10:25 AM
tstellar closed D65762: lit: Use a License classifier that pypi will accept.
Aug 8 2019, 10:25 AM · Restricted Project

Aug 7 2019

tstellar updated the diff for D65496: AMDGPU/SILoadStoreOptimizer: Add helper functions for working with CombineInfo.

Make helper function members of CombineInfo class.

Aug 7 2019, 2:59 PM · Restricted Project
tstellar created D65901: AMDGPU/SILoadStoreOptimizer: Add const to more functions.
Aug 7 2019, 1:30 PM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Address review comments.

Aug 7 2019, 10:26 AM · Restricted Project
tstellar updated the diff for D65097: AMDGPU: Add offsets to MMO when lowering buffer intrinsics.

Update offsets for the raw and struct intrinsic variants.

Aug 7 2019, 10:15 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Add missing comma.

Aug 7 2019, 8:49 AM · Restricted Project
tstellar updated the summary of D65762: lit: Use a License classifier that pypi will accept.
Aug 7 2019, 8:45 AM · Restricted Project
tstellar added a reviewer for D65762: lit: Use a License classifier that pypi will accept: joerg.
Aug 7 2019, 8:40 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Change license classifier to: OSI Approved :: Apache Software License
as suggested by Joerg on IRC.

Aug 7 2019, 8:40 AM · Restricted Project

Aug 6 2019

tstellar committed rL368047: Add 8.0.1 clang-tools-extra docs.
Add 8.0.1 clang-tools-extra docs
Aug 6 2019, 7:50 AM
tstellar committed rL368046: Add 8.0.1 libcxx docs.
Add 8.0.1 libcxx docs
Aug 6 2019, 7:47 AM
tstellar committed rL368045: Add 8.0.1 lld docs.
Add 8.0.1 lld docs
Aug 6 2019, 7:46 AM
tstellar committed rL368040: Update latest release to 8.0.1.
Update latest release to 8.0.1
Aug 6 2019, 7:13 AM
tstellar committed rL368039: Add 8.0.1 clang docs.
Add 8.0.1 clang docs
Aug 6 2019, 7:10 AM
tstellar committed rL368037: Add 8.0.1 LLVM docs.
Add 8.0.1 LLVM docs
Aug 6 2019, 6:50 AM

Aug 5 2019

tstellar added a comment to D65763: lit: Bump version to 0.10.0.

We also need to bump the version in the release/9.x branch to 0.9.0.

Aug 5 2019, 11:34 AM · Restricted Project
tstellar created D65763: lit: Bump version to 0.10.0.
Aug 5 2019, 11:34 AM · Restricted Project
tstellar updated the diff for D65762: lit: Use a License classifier that pypi will accept.

Remove accidental version bump.

Aug 5 2019, 11:31 AM · Restricted Project