♟ tstellar

Thanks for working on this. Here are some unscientific benchmarks from a pathological case on AMDGPU:

In D60794#1469761, @EricWF wrote:

I don't think this is correct.

The compiler should be linking gcc unwind for us, and there should be no need for users to link it themselves.

Add support for detection of devtoolset-8

Sorry didn't mean to accept the patch with my last comment.

In D59987#1454543, @rpopescu wrote:

In D59987#1454422, @tstellar wrote:

Do you have commit access?

Hi Tom, I don't think that I do. I have created the account just before submitting the patch. Should I request it, or?

AMDGPU/GlobalISel: Implement call lowering for shaders returning values

In D54439#1456019, @hans wrote:

Looks good to me.

Are there any buildbots that will catch if someone forgets to put an LLVM_EXTERNAL_VISIBILITY somewhere that's needed?

Do you have commit access?

Address review comments.

merge-request.sh: Update 8.0 metabug for 8.0.1

Rename macro from LLVM_EXPORT to LLVM_EXTERNAL_VISIBILITY and add documentation
for macro.

git-llvm: Update for release_80 branch

Bump version to 8.0.1

Merge remote-tracking branch 'origin/master' into merge-8.x

PIng. Does anyone else want to take a look at this?

lib/Header: Simplify CMakeLists.txt

In D58537#1415534, @smeenai wrote:

@tstellar are you planning to land this soon? It'll conflict with D58791, but I'm not planning to land that for another few days, so I can rebase on top of this one.

This looks good, but could you also add an entry in the ReleaseNotes for this.

AMDGPU/GlobalISel: Implement select for G_INSERT

AMDGPU/GlobalISel: Implement select for G_EXTRACT

llvm-config: Include -stdlib= in --cxxflags

Fix an issue with the generated arm headers that I discovered after
doing some more testing. Also, remove comment.

Has this change been tested with newer older versions of cmake too? Was there a release note from CMake that announced the deprecation of this kind of escape sequence?

In D58537#1411657, @tstellar wrote:

Use macros instead of functions.

Use macros instead of functions.

In D29342#1406690, @arsenm wrote:

Do we still need this"

AMDGPU/GlobalISel: Move SMRD selection logic to TableGen

Add support for pointer types in patterns

AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir

ELF: Fix typo in --build-id option description

CMake: Fix stand-alone clang builds since r353268

See D42593, I don't think it's good to ignore security flags like this.

I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check).

Updated patch to fix non-standalone builds. There is more refactoring
that could be done, but this at least restores functionality to before
r353268.

cmake: Use 7.1.0 for shared object version instead of 71.0

tstellar (Tom Stellard)
User

Projects

User Details

Recent Activity
View All

Wed, Apr 17

Tue, Apr 16

Mon, Apr 15

Fri, Apr 12

Tue, Apr 9

Mon, Apr 8

Fri, Apr 5

Wed, Apr 3

Tue, Apr 2

Fri, Mar 29

Thu, Mar 28

Mon, Mar 25

Thu, Mar 21

Mar 18 2019

Mar 6 2019

Mar 1 2019

Feb 28 2019

Feb 27 2019

Feb 26 2019

Feb 21 2019

Feb 20 2019

Feb 19 2019

Feb 14 2019

Feb 13 2019

Feb 12 2019

Feb 8 2019

Feb 7 2019

tstellar (Tom Stellard)User