Page MenuHomePhabricator

tstellar (Tom Stellard)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (319 w, 2 d)
Roles
Administrator

Recent Activity

Fri, Mar 24

tstellar added a comment to rG3d65cd405d64: [llvm-objdump] Fix help message for --print-imm-hex.

@bd1976llvm Can you file an issue for this: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches

Fri, Mar 24, 8:21 AM · Restricted Project, Restricted Project

Mon, Mar 20

tstellar requested review of D146491: workflows/release-tasks: Upload lit releases to pypi.
Mon, Mar 20, 7:29 PM · Restricted Project, Restricted Project
tstellar abandoned D131648: workflows/release-tasks: Upload release notes as an artifact.

I think the context got mixed up in the patch, so I have a new version here: https://reviews.llvm.org/D145996

Mon, Mar 20, 3:36 PM · Restricted Project, Restricted Project
tstellar committed rW7daf66fb04c7: Update for 16.0.0 release (authored by tstellar).
Update for 16.0.0 release
Mon, Mar 20, 11:38 AM · Restricted Project

Thu, Mar 16

tstellar committed rW851a7a081fe1: Update 16.x release schedule (authored by tstellar).
Update 16.x release schedule
Thu, Mar 16, 1:36 PM · Restricted Project
tstellar accepted D146235: workflows: Don't try and run llvm-bugs in forks.

LGTM.

Thu, Mar 16, 9:45 AM · Restricted Project, Restricted Project

Wed, Mar 15

tstellar committed rGe6d670dc2b52: lit: Fix formatting in README.rst (authored by tstellar).
lit: Fix formatting in README.rst
Wed, Mar 15, 4:20 AM · Restricted Project, Restricted Project
tstellar closed D143419: lit: Fix formatting in README.rst.
Wed, Mar 15, 4:19 AM · Restricted Project, Restricted Project
tstellar updated the diff for D143419: lit: Fix formatting in README.rst.

Better fix for formatting.

Wed, Mar 15, 3:24 AM · Restricted Project, Restricted Project

Tue, Mar 14

tstellar committed rG68c14f582ce6: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF (authored by tstellar).
JITLink: Add missing EHFrame NULL terminator on aarch64/ELF
Tue, Mar 14, 4:52 PM · Restricted Project, Restricted Project
tstellar closed D146067: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF.
Tue, Mar 14, 4:51 PM · Restricted Project, Restricted Project
tstellar requested review of D146067: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF.
Tue, Mar 14, 10:16 AM · Restricted Project, Restricted Project

Mon, Mar 13

tstellar added a comment to D145997: workflows/release-tasks: Fix missing suffix on doxygen tarballs.

Is the -srcdir option no longer needed?

Mon, Mar 13, 4:19 PM · Restricted Project, Restricted Project
tstellar requested review of D145997: workflows/release-tasks: Fix missing suffix on doxygen tarballs.
Mon, Mar 13, 3:35 PM · Restricted Project, Restricted Project
tstellar requested review of D145996: workflows/release-tasks: Upload release notes as an artifact.
Mon, Mar 13, 3:33 PM · Restricted Project, Restricted Project
tstellar added a comment to D143535: github: Add manual workflow to build and upload release binaries.

ping.

Mon, Mar 13, 3:24 PM · Restricted Project, Restricted Project
tstellar accepted D145964: [lld] Use installed llvm_gtest in standalone builds.

LGTM.

Mon, Mar 13, 10:27 AM · Restricted Project, Restricted Project
tstellar accepted D145946: [third-party] Respect LLVM_INSTALL_GTEST for llvm_gtest_main.

LGTM. Thanks.

Mon, Mar 13, 8:43 AM · Restricted Project, Restricted Project
tstellar added a comment to D110900: Triple: Add RedHat vendor.

We switched to using <arch>-redhat-linux-gnu as the default triple and we patch clang to translate the triple from <arch>-redhat-linux-gnu to <arch>-redhat-linux only when searching for the gcc installation, but not for anything else.

That seems like a valid solution as well.

Switching clang/llvm to treat <arch>-redhat-linux or <arch>-suse-linux as a gnu environment would be better, but that would also cause a behavior change for anyone using those triples.

Do you mean that the triple is treated as GNU, but users might not want that, e.g. because they use a different runtime? I think users would explicitly specify if they wanted a different runtime than GNU on RedHat/SUSE.

Or do you mean a difference in terms of which GCC installation gets picked up? Though I'm wondering why you wouldn't expect the equally named GCC triple.

Mon, Mar 13, 3:18 AM · Restricted Project, Restricted Project

Fri, Mar 10

tstellar committed rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds (authored by tstellar).
clang/cmake: Use installed gtest libraries for stand-alone builds
Fri, Mar 10, 8:01 PM · Restricted Project, Restricted Project
tstellar added a reverting change for rGcb38df4c4d3a: Add install targets for gtest: rGe99ccd8d03c4: Revert "Add install targets for gtest".
Fri, Mar 10, 8:01 PM · Restricted Project, Restricted Project
tstellar committed rGe99ccd8d03c4: Revert "Add install targets for gtest" (authored by tstellar).
Revert "Add install targets for gtest"
Fri, Mar 10, 8:01 PM · Restricted Project, Restricted Project
tstellar closed D138472: clang/cmake: Use installed gtest libraries for stand-alone builds.
Fri, Mar 10, 8:01 PM · Restricted Project, Restricted Project
tstellar added a reverting change for D137890: Add install targets for gtest: rGe99ccd8d03c4: Revert "Add install targets for gtest".
Fri, Mar 10, 8:01 PM · Restricted Project, Restricted Project
tstellar committed rGcb38df4c4d3a: Add install targets for gtest (authored by tstellar).
Add install targets for gtest
Fri, Mar 10, 7:43 PM · Restricted Project, Restricted Project
tstellar committed rG0807986303f5: Add install targets for gtest (authored by tstellar).
Add install targets for gtest
Fri, Mar 10, 5:29 PM · Restricted Project, Restricted Project
tstellar closed D137890: Add install targets for gtest.
Fri, Mar 10, 5:29 PM · Restricted Project, Restricted Project
tstellar committed rGe30ce634f75c: llvm-exegesis: Only run target specfic tests on native hosts (authored by tstellar).
llvm-exegesis: Only run target specfic tests on native hosts
Fri, Mar 10, 11:25 AM · Restricted Project, Restricted Project
tstellar closed D145763: llvm-exegesis: Only run X86 tests on X86 hosts.
Fri, Mar 10, 11:25 AM · Restricted Project, Restricted Project
tstellar added a comment to D145763: llvm-exegesis: Only run X86 tests on X86 hosts.

From what I can tell the problem is not the JIT'd code, but registering the EHFrames. Maybe the endian differences make libgcc not able to read the EHFrames since they are generated for x86. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108994#c14

Fri, Mar 10, 1:37 AM · Restricted Project, Restricted Project

Thu, Mar 9

tstellar updated the diff for D145763: llvm-exegesis: Only run X86 tests on X86 hosts.

Fix PowerPC tests too.

Thu, Mar 9, 10:33 PM · Restricted Project, Restricted Project
tstellar added inline comments to D143535: github: Add manual workflow to build and upload release binaries.
Thu, Mar 9, 10:02 PM · Restricted Project, Restricted Project
tstellar added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main?

Thu, Mar 9, 9:46 PM · Restricted Project, Restricted Project
tstellar abandoned D142174: [OpenMP] Don't set rpath for system paths.

-fopenmp-add-rpath has been removed.

Thu, Mar 9, 9:44 PM · Restricted Project, Restricted Project
tstellar requested review of D145763: llvm-exegesis: Only run X86 tests on X86 hosts.
Thu, Mar 9, 9:11 PM · Restricted Project, Restricted Project
tstellar added a comment to D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".

We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday.

Thu, Mar 9, 8:49 PM · Restricted Project, Restricted Project
tstellar added inline comments to D106129: [ExecutionEngine] Check for libunwind before calling __register_frame.
Thu, Mar 9, 8:28 PM · Restricted Project, Restricted Project
tstellar added a comment to D118493: Set rpath on openmp executables.

Duplicating a comment from the commit thread so it's easier for me to find later.

You've applied this to the release branches going back as far as 14. It's a user facing breaking change. As in people who have a working openmp toolchain and update to the point release which looks like a semantic versioning thing indicating minor bugfixes will experience immediate cessation of function. I consider that very poor user experience and do not agree with the scope of breakage.

Thu, Mar 9, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D139448: [llvm-exegesis] Dry run mode.

As a result of this change, the X86 tests are being run on other hosts e.g. SystemZ. Was this intended?

Thu, Mar 9, 12:17 PM · Restricted Project, Restricted Project
Herald added a project to D106129: [ExecutionEngine] Check for libunwind before calling __register_frame: Restricted Project.
Thu, Mar 9, 12:09 PM · Restricted Project, Restricted Project

Fri, Mar 3

tstellar committed rG829b8912cdd2: feat: harden permissions for all github workflows (authored by Joyce Brum <joycebrum@google.com>).
feat: harden permissions for all github workflows
Fri, Mar 3, 9:35 PM · Restricted Project
tstellar closed D144119: feat: harden permissions for all github workflows.
Fri, Mar 3, 9:34 PM · Restricted Project, Restricted Project

Tue, Feb 28

tstellar added a comment to D110900: Triple: Add RedHat vendor.

Can't speak for RedHat, but on SUSE we have

> gcc -dumpmachine
x86_64-suse-linux
> clang -dumpmachine
x86_64-unknown-linux-gnu

Not anymore. I've switched the default target triple to <arch>-suse-linux some time ago (except for ARM 6 & 7, where we specify the ABI), and haven't gotten any complaints about it.

We switched to using <arch>-redhat-linux-gnu as the default triple and we patch clang to translate the triple from <arch>-redhat-linux-gnu to <arch>-redhat-linux only when searching for the gcc installation, but not for anything else. Switching clang/llvm to treat <arch>-redhat-linux or <arch>-suse-linux as a gnu environment would be better, but that would also cause a behavior change for anyone using those triples.

Tue, Feb 28, 4:47 PM · Restricted Project, Restricted Project
tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Address some more review comments.

Tue, Feb 28, 4:22 PM · Restricted Project, Restricted Project
tstellar added a comment to D144119: feat: harden permissions for all github workflows.

@joycebrum Do you need me to commit this for you?

Tue, Feb 28, 2:40 PM · Restricted Project, Restricted Project
tstellar added inline comments to D137890: Add install targets for gtest.
Tue, Feb 28, 11:08 AM · Restricted Project, Restricted Project

Mon, Feb 27

tstellar updated the diff for D137890: Add install targets for gtest.

Add exports to LLVMExports.cmake instead of a separate file.

Mon, Feb 27, 11:34 PM · Restricted Project, Restricted Project
tstellar added a comment to D144853: [Clang][RISCV] Add CMake options to configure default CPU.

Would this make more sense in a config file rather than a CMake option? @MaskRay

Mon, Feb 27, 11:13 PM · Restricted Project, Restricted Project

Feb 22 2023

tstellar added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

@JonChesterfield I don't think we should be putting any Fedora specific logic into clang's build system or the driver, if that's what you are suggesting. Fedora can always patch the compiler or install a config file to change the default behavior, even though this is something we try really hard to avoid.

Feb 22 2023, 4:36 PM · Restricted Project, Restricted Project
tstellar accepted D144119: feat: harden permissions for all github workflows.

LGTM. I tested this here with our stable branch CI jobs: https://github.com/llvm/llvm-project-release-prs/pull/309

Feb 22 2023, 1:41 PM · Restricted Project, Restricted Project
tstellar added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

This is the point. Specifying a driver option to use libc++/libc++abi/libunwind doesn't magically change DT_RUNPATH. This is exactly the behavior a user wants for a system Clang.
It does make users with a non-system Clang inconvenient but that's the point that such users should specify rpath by themselves.
openmp should not diverge from libc++/libc++abi/libunwind in this regard.

Feb 22 2023, 1:12 PM · Restricted Project, Restricted Project

Feb 21 2023

tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Fix permissions.

Feb 21 2023, 2:27 PM · Restricted Project, Restricted Project
tstellar added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

I don't mind hugely what mechanism is used but would really like clang++ -fopenmp foo.cpp to build a program that runs. How can we preserve that 'works' feature without setting rpath on the binary?

Feb 21 2023, 9:25 AM · Restricted Project, Restricted Project
tstellar added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

FWIW, I'm in favor of this patch. System directory rpaths (e.g. /usr/lib64) are not allowed in Fedora Linux. The current default makes building packages with clang+openmp more difficult.

Feb 21 2023, 9:07 AM · Restricted Project, Restricted Project

Feb 16 2023

tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Update permissions for the action.

Feb 16 2023, 7:47 PM · Restricted Project, Restricted Project

Feb 14 2023

tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Put setup code into a script and make sure to always do the upload.

Feb 14 2023, 9:42 PM · Restricted Project, Restricted Project
tstellar added inline comments to D143535: github: Add manual workflow to build and upload release binaries.
Feb 14 2023, 5:27 PM · Restricted Project, Restricted Project
tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Addresss some review feedback and also make sure the correct ref is checked out.

Feb 14 2023, 5:21 PM · Restricted Project, Restricted Project

Feb 7 2023

tstellar updated subscribers of D143535: github: Add manual workflow to build and upload release binaries.

This patch is from @str4d

Feb 7 2023, 4:41 PM · Restricted Project, Restricted Project
tstellar updated the diff for D143535: github: Add manual workflow to build and upload release binaries.

Rebase on main.

Feb 7 2023, 4:19 PM · Restricted Project, Restricted Project
tstellar requested review of D143535: github: Add manual workflow to build and upload release binaries.
Feb 7 2023, 4:09 PM · Restricted Project, Restricted Project

Feb 6 2023

tstellar requested review of D143419: lit: Fix formatting in README.rst.
Feb 6 2023, 9:57 AM · Restricted Project, Restricted Project
tstellar accepted D143348: [Clang][Doc][OpenCL] Release 16 notes.

LGTM.

Feb 6 2023, 8:29 AM · Restricted Project

Feb 3 2023

tstellar accepted D143249: [Release] Increase test-release.sh verbosity.

LGTM, Thanks, can you open the backport request for release/16.x ?

Feb 3 2023, 12:26 PM · Restricted Project, Restricted Project

Jan 31 2023

tstellar accepted D142873: [libc++][NFC] Update the libc++ release notes for LLVM 16..
Jan 31 2023, 3:31 PM · Restricted Project, Restricted Project
tstellar accepted D143015: [github] update actions and make tweaks.

LGTM. Thank you for doing this.

Jan 31 2023, 2:13 PM · Restricted Project, Restricted Project
tstellar accepted D142987: ReleaseNotes: add SystemZ notes.
Jan 31 2023, 8:19 AM · Restricted Project, Restricted Project

Jan 30 2023

tstellar added a comment to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.

https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches

Jan 30 2023, 3:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 27 2023

tstellar committed rG683b83abaab4: workflows: Fix libclc tests (authored by tstellar).
workflows: Fix libclc tests
Jan 27 2023, 11:24 AM · Restricted Project
tstellar closed D142716: workflows: Fix libclc tests.
Jan 27 2023, 11:23 AM · Restricted Project, Restricted Project
tstellar committed rG8040e3a4deeb: libclc: Fix building against an llvm build directory (authored by tstellar).
libclc: Fix building against an llvm build directory
Jan 27 2023, 11:16 AM · Restricted Project
tstellar closed D142718: libclc: Fix building against an llvm build directory.
Jan 27 2023, 11:16 AM · Restricted Project, Restricted Project
tstellar committed rG9f307a02bebf: workflows: Bump python version on Windows to try to fix lldb failure (authored by tstellar).
workflows: Bump python version on Windows to try to fix lldb failure
Jan 27 2023, 11:07 AM · Restricted Project
tstellar closed D142719: workflows: Bump python version on Windows to try to fix lldb failure.
Jan 27 2023, 11:07 AM · Restricted Project, Restricted Project
tstellar committed rG409f42b10ac6: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm (authored by tstellar).
libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm
Jan 27 2023, 10:51 AM · Restricted Project
tstellar closed D142720: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm.
Jan 27 2023, 10:50 AM · Restricted Project, Restricted Project
tstellar committed rG57b491b5c10a: Workflows: Fix version-check.py script for when there is no RC tag yet (authored by tstellar).
Workflows: Fix version-check.py script for when there is no RC tag yet
Jan 27 2023, 6:59 AM · Restricted Project
tstellar closed D142598: Workflows: Fix version-check.py script for when there is no RC tag yet.
Jan 27 2023, 6:59 AM · Restricted Project, Restricted Project
tstellar added a comment to D142719: workflows: Bump python version on Windows to try to fix lldb failure.

I thought the required version is much less than 3.10? Why is this helping / failing?

Jan 27 2023, 6:41 AM · Restricted Project, Restricted Project
tstellar requested review of D142720: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm.
Jan 27 2023, 6:34 AM · Restricted Project, Restricted Project
tstellar requested review of D142719: workflows: Bump python version on Windows to try to fix lldb failure.
Jan 27 2023, 6:34 AM · Restricted Project, Restricted Project
tstellar requested review of D142718: libclc: Fix building against an llvm build directory.
Jan 27 2023, 6:33 AM · Restricted Project, Restricted Project
tstellar requested review of D142716: workflows: Fix libclc tests.
Jan 27 2023, 6:33 AM · Restricted Project, Restricted Project

Jan 26 2023

tstellar committed rG009048810ac6: test-release.sh: Use parallel xz for packaging the binaries (authored by tstellar).
test-release.sh: Use parallel xz for packaging the binaries
Jan 26 2023, 3:20 PM · Restricted Project, Restricted Project
tstellar closed D142417: test-release.sh: Use parallel xz for packaging the binaries.
Jan 26 2023, 3:19 PM · Restricted Project, Restricted Project
tstellar added a comment to D142606: Lazyly initialize uncommon toolchain detector.

Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile?

That's the goal, yes.

Jan 26 2023, 2:43 PM · Restricted Project, Restricted Project
tstellar added a comment to D142606: Lazyly initialize uncommon toolchain detector.

Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile?

Jan 26 2023, 7:00 AM · Restricted Project, Restricted Project

Jan 25 2023

tstellar requested review of D142598: Workflows: Fix version-check.py script for when there is no RC tag yet.
Jan 25 2023, 7:36 PM · Restricted Project, Restricted Project

Jan 24 2023

tstellar committed rG603c286334b0: Bump the trunk major version to 17 (authored by tstellar).
Bump the trunk major version to 17
Jan 24 2023, 10:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tstellar committed rG19f100e89ad5: test-release.sh: Only build clang for stage1 and stage2 (authored by tstellar).
test-release.sh: Only build clang for stage1 and stage2
Jan 24 2023, 6:11 PM · Restricted Project, Restricted Project
tstellar closed D141552: test-release.sh: Only build clang for stage1 and stage2.
Jan 24 2023, 6:11 PM · Restricted Project, Restricted Project
tstellar accepted D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally.

LGTM. Thank you.

Jan 24 2023, 3:41 PM · Restricted Project, Restricted Project
tstellar added inline comments to D131632: [clang] Enable output of SARIF diagnostics.
Jan 24 2023, 12:16 PM · Restricted Project, Restricted Project
tstellar added inline comments to D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC.
Jan 24 2023, 12:08 PM · Restricted Project, Restricted Project
tstellar accepted D142457: [llvm][docs] Fix indentation of item list. [NFCI].

LGTM.

Jan 24 2023, 6:27 AM · Restricted Project, Restricted Project
tstellar updated subscribers of D142199: [Docs] Replace recommonmark with myst-parser.

@luke You'll need to contact the bot owners so they can update machine. The workers running the publish-sphinx-docs will need to be updated too. @gkistanova should be able to help.

Jan 24 2023, 6:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 23 2023

tstellar requested review of D142417: test-release.sh: Use parallel xz for packaging the binaries.
Jan 23 2023, 4:23 PM · Restricted Project, Restricted Project
tstellar accepted D142403: [build] Fix stand-alone builds of clang..

LGTM. I tested and this fixes the build.

Jan 23 2023, 3:55 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D142403: [build] Fix stand-alone builds of clang..

This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo targets in llvm/cmake/modules/LLVMConfig.cmake.in.

We'll get there! I think I missed the "leave the RISCVTargetParserTableGen in the DEPENDS, sorry about that.

Jan 23 2023, 1:54 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D142403: [build] Fix stand-alone builds of clang..

This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo targets in llvm/cmake/modules/LLVMConfig.cmake.in.

Jan 23 2023, 1:49 PM · Restricted Project, Restricted Project, Restricted Project