Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (105 w, 5 d)

Recent Activity

Today

tstellar committed rG13f45590e349: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir (authored by tstellar).
AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
Wed, Feb 20, 10:44 AM
tstellar committed rL354497: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
Wed, Feb 20, 10:43 AM
tstellar closed D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
Wed, Feb 20, 10:43 AM · Restricted Project

Yesterday

tstellar committed rG20332cc4ea69: ELF: Fix typo in --build-id option description (authored by tstellar).
ELF: Fix typo in --build-id option description
Tue, Feb 19, 5:41 PM
tstellar committed rLLD354422: ELF: Fix typo in --build-id option description.
ELF: Fix typo in --build-id option description
Tue, Feb 19, 5:40 PM
tstellar committed rL354422: ELF: Fix typo in --build-id option description.
ELF: Fix typo in --build-id option description
Tue, Feb 19, 5:40 PM
tstellar closed D58265: ELF: Fix typo in --build-id option description.
Tue, Feb 19, 5:40 PM · Restricted Project
tstellar created D58420: docs/GithubMove.rst: Remove obsolete information.
Tue, Feb 19, 5:19 PM · Restricted Project
tstellar committed rGb8a9fcc602a0: CMake: Fix stand-alone clang builds since r353268 (authored by tstellar).
CMake: Fix stand-alone clang builds since r353268
Tue, Feb 19, 5:11 PM
tstellar committed rC354417: CMake: Fix stand-alone clang builds since r353268.
CMake: Fix stand-alone clang builds since r353268
Tue, Feb 19, 5:11 PM
tstellar committed rL354417: CMake: Fix stand-alone clang builds since r353268.
CMake: Fix stand-alone clang builds since r353268
Tue, Feb 19, 5:11 PM
tstellar closed D58204: CMake: Fix stand-alone clang builds since r353268.
Tue, Feb 19, 5:11 PM · Restricted Project, Restricted Project
Herald added a project to D54880: Ignore gcc's stack-clash-protection flag: Restricted Project.

See D42593, I don't think it's good to ignore security flags like this.

Tue, Feb 19, 2:24 PM · Restricted Project
tstellar abandoned D42593: GCC compatibility: Ignore -fstack-clash-protection.

I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check).

Tue, Feb 19, 2:24 PM · Restricted Project

Thu, Feb 14

tstellar created D58265: ELF: Fix typo in --build-id option description.
Thu, Feb 14, 5:08 PM · Restricted Project

Wed, Feb 13

tstellar added a comment to D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.

Example of test failure: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-f29-pr-pipeline/51/artifact/package-tests/logs/FAIL_str_regression-tests.log

Wed, Feb 13, 4:30 PM · Restricted Project
tstellar created D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
Wed, Feb 13, 4:29 PM · Restricted Project
tstellar accepted D56881: AMDGPU/GlobalISel: Handle split for 64-bit VALU select.

LGTM.

Wed, Feb 13, 4:24 PM
tstellar accepted D57293: AMDGPU/GlobalISel: Fix RegBankSelect for GEP..

LGTM.

Wed, Feb 13, 4:24 PM
tstellar updated the diff for D58204: CMake: Fix stand-alone clang builds since r353268.

Updated patch to fix non-standalone builds. There is more refactoring
that could be done, but this at least restores functionality to before
r353268.

Wed, Feb 13, 4:14 PM · Restricted Project, Restricted Project
tstellar added inline comments to D58204: CMake: Fix stand-alone clang builds since r353268.
Wed, Feb 13, 1:28 PM · Restricted Project, Restricted Project
tstellar created D58204: CMake: Fix stand-alone clang builds since r353268.
Wed, Feb 13, 1:11 PM · Restricted Project, Restricted Project

Tue, Feb 12

tstellar added inline comments to D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS.
Tue, Feb 12, 1:50 PM · Restricted Project, Restricted Project
tstellar added a reviewer for D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS: tstellar.
Tue, Feb 12, 1:36 PM · Restricted Project, Restricted Project

Fri, Feb 8

tstellar added inline comments to D57930: [Driver] Verify GCCInstallation is valid.
Fri, Feb 8, 6:52 PM · Restricted Project
tstellar committed rG4856a9330ee0: cmake: Use 7.1.0 for shared object version instead of 71.0 (authored by tstellar).
cmake: Use 7.1.0 for shared object version instead of 71.0
Fri, Feb 8, 1:03 PM
tstellar committed rL353565: cmake: Use 7.1.0 for shared object version instead of 71.0.
cmake: Use 7.1.0 for shared object version instead of 71.0
Fri, Feb 8, 1:02 PM
tstellar updated the diff for D49714: AMDGPU/GlobalISel: Implement select for G_EXTRACT.

Address comments.

Fri, Feb 8, 12:18 PM · Restricted Project
tstellar accepted D57074: AMDGPU/GlobalISel: Fix shift legalization for non-power-of-2.

LGTM.

Fri, Feb 8, 6:48 AM

Thu, Feb 7

tstellar accepted D57885: AMDGPU: Remove GCN features and predicates.

LGTM.

Thu, Feb 7, 3:46 PM
tstellar accepted D57683: AMDGPU/GlobalISel: Restrict g_implicit_def legality.

LGTM.

Thu, Feb 7, 9:48 AM
tstellar accepted D57034: AMDGPU/GlobalISel: Legalize some f16 operations.

LGTM.

Thu, Feb 7, 9:47 AM

Wed, Feb 6

Herald added projects to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation: Restricted Project, Restricted Project.
Wed, Feb 6, 7:30 PM · Restricted Project, Restricted Project
tstellar created D57859: llvm-config: Include -stdlib= in --cxxflags.
Wed, Feb 6, 3:51 PM · Restricted Project
tstellar committed rGa469976b00b6: cmake: Use 7.1 for SONAME instead of 70 (authored by tstellar).
cmake: Use 7.1 for SONAME instead of 70
Wed, Feb 6, 2:09 PM
tstellar committed rL353348: cmake: Use 7.1 for SONAME instead of 70.
cmake: Use 7.1 for SONAME instead of 70
Wed, Feb 6, 2:08 PM

Tue, Feb 5

tstellar committed rGea20c1e91eb8: Revert "[cmake] Update SOVERSION for the new versioning scheme" (authored by tstellar).
Revert "[cmake] Update SOVERSION for the new versioning scheme"
Tue, Feb 5, 4:13 PM
tstellar committed rL353247: Revert "[cmake] Update SOVERSION for the new versioning scheme".
Revert "[cmake] Update SOVERSION for the new versioning scheme"
Tue, Feb 5, 4:13 PM

Fri, Feb 1

tstellar accepted D57285: AMDGPU/GlobalISel: Legalize constant for pointer types.

OK, LGTM.

Fri, Feb 1, 4:22 PM
tstellar accepted D57284: AMDGPU/GlobalISel: Legalize select for pointer types.

LGTM.

Fri, Feb 1, 4:08 PM
tstellar added inline comments to D57285: AMDGPU/GlobalISel: Legalize constant for pointer types.
Fri, Feb 1, 4:07 PM
tstellar accepted D57286: AMDGPU/GlobalISel: Legalize icmp for pointer types.

LGTM.

Fri, Feb 1, 4:06 PM

Wed, Jan 30

tstellar added a comment to D57406: build: remove use of llvm-config.

I wrote a patch similar to this in LLDB, so I'll chime in a bit.

@mgorny: This doesn't actually *break* the build per se. This change just means you need to do a bit more work to be able to test the lld you just built. Some things that could be done to improve the situation:

  • Users who want to test lld should specify LLVM_BUILD_MAIN_SRC_DIR (and possibly LLVM_LIT_EXE) manually.
Wed, Jan 30, 2:02 PM · Restricted Project
tstellar added a comment to D57406: build: remove use of llvm-config.

This doesn't break the build, we check that the path exists, and find_program will not error out. You can still specify LLVM_LIT_EXE to specify the lit.py to use. Is that not sufficient for your needs?

Wed, Jan 30, 1:17 PM · Restricted Project

Tue, Jan 29

tstellar committed rL352582: Merging r347004:.
Merging r347004:
Tue, Jan 29, 5:14 PM
tstellar committed rL352581: Bump Version to 7.1.0.
Bump Version to 7.1.0
Tue, Jan 29, 5:14 PM
tstellar committed rL352580: Revert "Rename llvm library from libLLVM-X.Y to libLLVM-X".
Revert "Rename llvm library from libLLVM-X.Y to libLLVM-X"
Tue, Jan 29, 5:14 PM
tstellar accepted D57406: build: remove use of llvm-config.

The clang patch was merged a few months ago. LGTM.

Tue, Jan 29, 1:59 PM · Restricted Project
tstellar added a comment to D57406: build: remove use of llvm-config.

I made a similar change to clang: https://reviews.llvm.org/rL346732, and I think this is the right direction to go.

Tue, Jan 29, 11:56 AM · Restricted Project
tstellar added a reviewer for D57383: [CMake] Add install targets for utilities to LLVM exports if LLVM_INSTALL_UTILS=ON: serge-sans-paille.
Tue, Jan 29, 11:44 AM · Restricted Project
tstellar created D57399: AMDGPU/GlobalISel: Add support for wide loads >= 256-bits.
Tue, Jan 29, 10:37 AM

Thu, Jan 24

tstellar created D57166: AMDGPU/GlobalISel: Implement call lowering for shaders returning values.
Thu, Jan 24, 9:50 AM

Wed, Jan 23

tstellar committed rL352028: Add aarch64, arm, ppc64le binaries for 7.0.1.
Add aarch64, arm, ppc64le binaries for 7.0.1
Wed, Jan 23, 11:42 PM
tstellar updated the diff for D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.

Address review comments.

Wed, Jan 23, 9:17 AM
tstellar added a reviewer for D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable: bob.wilson.
Wed, Jan 23, 7:02 AM · Restricted Project

Tue, Jan 22

tstellar updated the diff for D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.

Add TableGen patterns for loads of pointer types.

Tue, Jan 22, 5:14 PM
tstellar accepted D55753: AMDGPU/GlobalISel: RegBankSelect for carry-in.

LGTM.

Tue, Jan 22, 1:44 PM
tstellar updated the diff for D57065: [TableGen][GlobalISel] Add support for pointer types in patterns.

Fix spelling.

Tue, Jan 22, 12:56 PM · Restricted Project
tstellar added a comment to D55914: [GlobalISel][InstructionSelect] Add support for selecting pointer types with TableGen.

You can actually use iPTR types in patterns already, but the GlobalISel backend converts it to a scalar integer when generating the ISel code.

Hmm, I'm not keen on munging the types together. I'd prefer to generate appropriate checks.

Just to give some background on iPTR:
DAGISel patterns are a bit inconsistent on their usage of iPTR. iPTR is just a scalar integer with a dynamically assigned size and as a result the patterns have scalar integers in patterns that should have pointers and pointers in patterns that should have scalar integers. This is mentioned in the iPTR definition (llvm/CodeGen/MachineValueType.h):

// An int value the size of the pointer of the current
// target to any address space. This must only be used internal to
// tblgen. Other than for overloading, we treat iPTRAny the same as iPTR.

and TargetLoweringBase::getPointerTy():

MVT TargetLoweringBase::getPointerTy(const DataLayout &DL, uint32_t AS = 0) const {
  return MVT::getIntegerVT(DL.getPointerSizeInBits(AS));
}

It doesn't matter much for DAGISel as pointers aren't really a concept it deals with but GlobalISel considers pointers and scalars to be different things and as a result iPTR has some context specific behaviour. For ptypeN operands on instructions (e.g. the pointer operand of a G_LOAD) it's a pointer and GlobalISelEmitter emits a different predicate (OperandMatcher::addTypeCheckPredicate()), while all other contexts convert it to a scalar integer like DAGISel did (but only if there's only one choice after applying type constraints, if there's more it will reject the pattern). If you trace it back, it's CodeGenInstruction::isOperandAPointer() that triggers that special behaviour which is looking for TypedOperand.IsPointer in the InOperandList for the instruction.

What opcodes do you need to cover? If they're generic opcodes, does changing typeN to ptypeN have the desired effect? If they're more general things like G_ADD, then this wasn't an issue for AArch64 and our out-of-tree targets. We could potentially add predicates for pointer-sized scalars so that we emit the right checks.

Tue, Jan 22, 12:54 PM
tstellar created D57065: [TableGen][GlobalISel] Add support for pointer types in patterns.
Tue, Jan 22, 12:48 PM · Restricted Project

Jan 18 2019

tstellar added a comment to D55914: [GlobalISel][InstructionSelect] Add support for selecting pointer types with TableGen.

You can actually use iPTR types in patterns already, but the GlobalISel backend converts it to a scalar integer when generating the ISel code.

Jan 18 2019, 7:59 PM
tstellar added a comment to D55914: [GlobalISel][InstructionSelect] Add support for selecting pointer types with TableGen.

Would it be difficult to add ptr types in tablegen's version of MVT, which the table gen backend converts as appropriate?

Jan 18 2019, 6:56 PM
tstellar added a comment to D55914: [GlobalISel][InstructionSelect] Add support for selecting pointer types with TableGen.

Aren't we going to need a way to represent this in tablegen eventually?

Jan 18 2019, 5:58 PM

Jan 17 2019

tstellar accepted D56895: AMDGPU: Legalize more bitcasts.

LGTM.

Jan 17 2019, 6:57 PM
tstellar accepted D56861: AMDGPU/GlobalISel: Cleanup legality for extensions.

LGTM.

Jan 17 2019, 9:46 AM

Jan 15 2019

tstellar committed rL351296: Only promote args when function attributes are compatible.
Only promote args when function attributes are compatible
Jan 15 2019, 9:19 PM
tstellar closed D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Jan 15 2019, 9:19 PM

Jan 14 2019

tstellar added a comment to D53554: [Argument Promotion] Only promote args when function attributes are compatible.

+ I'm still a little confused by the layering of TTI. I tried to move the
implementation out of TargetTransformInfoImplBase and into BasicTTI, but
that breaks the NoTTIImpl class.

For NoTTIImpl you can just return false, or return false except for integer types that DataLayout thinks are legal.

The difference between NoTTIImpl and the "basic" layer inside CodeGen is that the basic layer can reach into common target-independent parts of the code generator (like the type legalization tables) to compute plausible answers, where NoTTIImpl is supposed to only return trivially evident information based on the IR-level input. Further, there is *no* quality bar for NoTTIImpl -- it's more for target-indepndent testing, and not supposed to have any quality per-se.

Jan 14 2019, 1:27 PM
tstellar committed rL351087: cmake: Don't install plugins used for examples or tests.
cmake: Don't install plugins used for examples or tests
Jan 14 2019, 10:29 AM
tstellar closed D55965: cmake: Don't install plugins used for examples or tests.
Jan 14 2019, 10:29 AM

Jan 9 2019

tstellar committed rL350782: Add 7.0.1 links to the download table.
Add 7.0.1 links to the download table
Jan 9 2019, 4:18 PM
tstellar committed rL350780: Add links to Ubuntu and SLES binaires.
Add links to Ubuntu and SLES binaires
Jan 9 2019, 4:14 PM

Jan 8 2019

tstellar committed rL350691: Add Ubuntu/SLES binaries for 7.0.1.
Add Ubuntu/SLES binaries for 7.0.1
Jan 8 2019, 9:20 PM

Jan 7 2019

tstellar added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.

I don't have this in my notes, but my recollection from the GitHub round-table at the Dev Meeting was that the preference was to not have any files to the root directory. I think step 1 would be to discuss the general issue of files in the root directory on llvm-devel.

Jan 7 2019, 5:13 PM
tstellar accepted D56347: AMDGPU/GlobalISel: Start selectively legalizing 16-bit operations.

LGTM.

Jan 7 2019, 9:36 AM
tstellar accepted D56308: AMDGPU/GlobalISel: Really legalize exts from i1.

LGTM.

Jan 7 2019, 9:15 AM
tstellar accepted D55751: AMDGPU/GlobalISel: RegBankSelect for add/sub with carry in.

LGTM.

Jan 7 2019, 9:14 AM
tstellar accepted D55695: AMDGPU/GlobalISel: RegBankSelect for add/sub with carry out.

LGTM.

Jan 7 2019, 9:13 AM
tstellar accepted D56304: AMDGPU/GlobalISel: Fix some crashs in g_unmerge_values/g_merge_values.

LGTM.

Jan 7 2019, 9:12 AM
tstellar added a reviewer for D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors: jvesely.
Jan 7 2019, 9:01 AM
tstellar accepted D56236: AMDGPU/GlobalISel: Legalize concat_vectors.

LGTM.

Jan 7 2019, 8:59 AM

Dec 21 2018

tstellar committed rL349993: Update website for 7.0.1 release.
Update website for 7.0.1 release
Dec 21 2018, 9:06 PM
tstellar committed rL349990: Fix mingw build failures caused by r349839.
Fix mingw build failures caused by r349839
Dec 21 2018, 7:46 PM
tstellar closed D56004: Fix mingw build failures caused by r349839.
Dec 21 2018, 7:46 PM
tstellar added a comment to D56004: Fix mingw build failures caused by r349839.

I will push it, since you confirmed it fixes the build.

Dec 21 2018, 7:24 PM
tstellar committed rL349980: Add Windows and FreeBSD binaries for 7.0.1.
Add Windows and FreeBSD binaries for 7.0.1
Dec 21 2018, 5:06 PM
tstellar committed rL349965: Add 7.0.1 docs for clang, llvm, and lld.
Add 7.0.1 docs for clang, llvm, and lld
Dec 21 2018, 1:56 PM
tstellar added a comment to D51748: cmake: Remove add_llvm_loadable_module().

Maybe add a release note for out-of-tree users of this? We had to adjust our clang plugin build files in Chromium for example.

Dec 21 2018, 8:24 AM
tstellar committed rL349921: ReleaseNotes: Document removal of add_llvm_loadable_module CMake macro.
ReleaseNotes: Document removal of add_llvm_loadable_module CMake macro
Dec 21 2018, 8:24 AM
tstellar added a comment to D55965: cmake: Don't install plugins used for examples or tests.

Module libraries are always treated as LIBRARY targets. via https://cmake.org/cmake/help/v3.0/command/install.html, but D51748 marked as RUNTIME targets when build with mingw

Dec 21 2018, 7:45 AM
tstellar created D56004: Fix mingw build failures caused by r349839.
Dec 21 2018, 7:44 AM

Dec 20 2018

tstellar abandoned D50668: unittests: Don't install TestPlugin.so.

This has been superseded by D55965.

Dec 20 2018, 3:39 PM
tstellar created D55965: cmake: Don't install plugins used for examples or tests.
Dec 20 2018, 3:39 PM
tstellar committed rL349846: Fix Windows build failures caused by r349839.
Fix Windows build failures caused by r349839
Dec 20 2018, 2:39 PM
tstellar committed rL349840: cmake: Remove uses of add_llvm_loadable_module macro.
cmake: Remove uses of add_llvm_loadable_module macro
Dec 20 2018, 2:08 PM
tstellar committed rC349840: cmake: Remove uses of add_llvm_loadable_module macro.
cmake: Remove uses of add_llvm_loadable_module macro
Dec 20 2018, 2:08 PM
tstellar committed rL349839: cmake: Remove add_llvm_loadable_module().
cmake: Remove add_llvm_loadable_module()
Dec 20 2018, 2:07 PM
tstellar closed D51748: cmake: Remove add_llvm_loadable_module().
Dec 20 2018, 2:07 PM

Dec 19 2018

tstellar updated the diff for D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.

Remove unnecessary #include

Dec 19 2018, 8:39 PM
tstellar added inline comments to D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.
Dec 19 2018, 8:37 PM