tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (79 w, 3 d)

Recent Activity

Fri, Aug 17

tstellar added a comment to D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.

@atrick does this look OK to you?

Fri, Aug 17, 10:23 AM

Thu, Aug 16

tstellar added a comment to D50668: unittests: Don't install TestPlugin.so.

I had to revert this, because it broke the Windows build. I am working on a new patch.

Thu, Aug 16, 10:44 AM
tstellar reopened D50668: unittests: Don't install TestPlugin.so.

I had to revert this, because it broke the Windows build. I am working on a new patch.

Thu, Aug 16, 10:30 AM
tstellar committed rL339903: Revert "unittests: Don't install TestPlugin.so".
Revert "unittests: Don't install TestPlugin.so"
Thu, Aug 16, 10:15 AM
tstellar committed rL339897: unittests: Don't install TestPlugin.so.
unittests: Don't install TestPlugin.so
Thu, Aug 16, 9:54 AM
tstellar closed D50668: unittests: Don't install TestPlugin.so.
Thu, Aug 16, 9:53 AM

Tue, Aug 14

tstellar added a comment to D50668: unittests: Don't install TestPlugin.so.

This makes complete sense to me, but I'm wondering whether add_llvm_loadable_module is the right macro to use here in the first place. All it does is call add_llvm_library with a MODULE argument, and set up the install.

So it seems to me that add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY ...) should work just as well, without changing the setup. Does that make sense?

Tue, Aug 14, 11:59 AM
tstellar updated the diff for D50668: unittests: Don't install TestPlugin.so.

Use add_llvm_library() instead of add_llvm_loadable_module()

Tue, Aug 14, 11:59 AM

Mon, Aug 13

tstellar created D50668: unittests: Don't install TestPlugin.so.
Mon, Aug 13, 2:59 PM

Fri, Aug 10

tstellar committed rL339492: [gold] Fix Tests cases on i686.
[gold] Fix Tests cases on i686
Fri, Aug 10, 6:09 PM
tstellar closed D50583: [gold] Fix Tests cases on i686.
Fri, Aug 10, 6:09 PM
tstellar committed rL339491: AMDGPU/GlobalISel: Define instruction mapping for G_INSERT.
AMDGPU/GlobalISel: Define instruction mapping for G_INSERT
Fri, Aug 10, 5:52 PM
tstellar closed D49625: AMDGPU/GlobalISel: Define instruction mapping for G_INSERT.
Fri, Aug 10, 5:52 PM
tstellar created D50583: [gold] Fix Tests cases on i686.
Fri, Aug 10, 3:03 PM
tstellar abandoned D50546: CMake: Fix native arch selection on s390 (32-bit).

OK, that's good to know, I will drop this patch from Fedora.

Fri, Aug 10, 8:28 AM

Thu, Aug 9

tstellar created D50546: CMake: Fix native arch selection on s390 (32-bit).
Thu, Aug 9, 6:32 PM
tstellar added inline comments to rL339367: Fix few g++ 8 warning with non obvious copy object operations.
Thu, Aug 9, 4:43 PM

Wed, Aug 8

tstellar created D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.
Wed, Aug 8, 6:14 PM

Thu, Aug 2

tstellar committed rL338751: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING.
CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
Thu, Aug 2, 11:16 AM
tstellar closed D49835: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING.
Thu, Aug 2, 11:16 AM
tstellar accepted D50053: Release download page: add text about what's in the package.

Looks good to me.

Thu, Aug 2, 7:45 AM

Wed, Aug 1

tstellar created D50151: utils: Add script for listing release blocker bugs.
Wed, Aug 1, 11:05 AM

Tue, Jul 31

tstellar added a comment to D50121: [PowerPC] Do not round values prior to converting to integer.

One questions I had after looking into this bug was why does PPCTargetLowering::LowerFP_TO_INTForReuse() extend f32 values to f64 before creating the FCT* instructions?

Tue, Jul 31, 6:47 PM

Mon, Jul 30

tstellar added a reviewer for D50018: SystemZ: keep AND masks before SHL i128: jonpa.
Mon, Jul 30, 4:53 PM
tstellar added a comment to D50018: SystemZ: keep AND masks before SHL i128.

The transform is wrong whether or not the shift type is legal: ISD::SHL returns poison for out-of-range shifts, just like the IR "shl", and DAGCombine will take advantage of this.

Mon, Jul 30, 3:36 PM

Thu, Jul 26

tstellar committed rL338102: AMDGPU/GlobalISel: Fix crash in regbankselect on non-power-of-2 types.
AMDGPU/GlobalISel: Fix crash in regbankselect on non-power-of-2 types
Thu, Jul 26, 11:05 PM
tstellar closed D49624: AMDGPU/GlobalISel: Fix crash in regbankselect on non-power-of-2 types.
Thu, Jul 26, 11:05 PM

Wed, Jul 25

tstellar created D49835: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING.
Wed, Jul 25, 9:44 PM

Tue, Jul 24

tstellar committed rL337882: [RegisterBankInfo] Ignore InstrMappings that create impossible to repair….
[RegisterBankInfo] Ignore InstrMappings that create impossible to repair…
Tue, Jul 24, 8:08 PM
tstellar closed D49735: [RegisterBankInfo] Ignore InstrMappings that create impossible to repair operands.
Tue, Jul 24, 8:08 PM
tstellar created D49737: AMDGPU/GlobalISel: Define instruction mapping for G_SELECT.
Tue, Jul 24, 8:29 AM
tstellar created D49735: [RegisterBankInfo] Ignore InstrMappings that create impossible to repair operands.
Tue, Jul 24, 8:10 AM

Mon, Jul 23

tstellar committed rL337798: AMDGPU/GlobalISel: Legalize G_INSERT.
AMDGPU/GlobalISel: Legalize G_INSERT
Mon, Jul 23, 7:19 PM
tstellar closed D49601: AMDGPU/GlobalISel: Legalize G_INSERT.
Mon, Jul 23, 7:19 PM
tstellar created D49714: AMDGPU/GlobalISel: Implement select for G_EXTRACT.
Mon, Jul 23, 7:14 PM
tstellar committed rL337794: AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT.
AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT
Mon, Jul 23, 6:44 PM
tstellar closed D49600: AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT.
Mon, Jul 23, 6:44 PM

Jul 20 2018

tstellar created D49625: AMDGPU/GlobalISel: Define instruction mapping for G_INSERT.
Jul 20 2018, 5:03 PM
tstellar created D49624: AMDGPU/GlobalISel: Fix crash in regbankselect on non-power-of-2 types.
Jul 20 2018, 5:02 PM
tstellar created D49601: AMDGPU/GlobalISel: Legalize G_INSERT.
Jul 20 2018, 8:13 AM
tstellar created D49600: AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT.
Jul 20 2018, 8:13 AM
tstellar committed rL337553: Add link to 6.0.1 release announcement.
Add link to 6.0.1 release announcement
Jul 20 2018, 7:23 AM

Jul 19 2018

tstellar committed rL337522: Add links to 6.0.1 downloads.
Add links to 6.0.1 downloads
Jul 19 2018, 8:53 PM

Jul 13 2018

tstellar committed rL337056: AMDGPU/GlobalISel: Implement select() for 32-bit @llvm.minnun and @llvm.maxnum.
AMDGPU/GlobalISel: Implement select() for 32-bit @llvm.minnun and @llvm.maxnum
Jul 13 2018, 3:21 PM
tstellar closed D46172: AMDGPU/GlobalISel: Implement select() for 32-bit @llvm.minnun and @llvm.maxnum.
Jul 13 2018, 3:21 PM
tstellar committed rL337046: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.exp.
AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.exp
Jul 13 2018, 2:10 PM
tstellar closed D45882: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.exp.
Jul 13 2018, 2:10 PM

Jul 11 2018

tstellar committed rL336861: AMDGPU/SI: Initialize InstrInfo before TargetLoweringInfo in GCNSubtarget.
AMDGPU/SI: Initialize InstrInfo before TargetLoweringInfo in GCNSubtarget
Jul 11 2018, 3:20 PM
tstellar committed rL336853: AMDGPU: Remove duplicate call to initializeSubtargetDependencies().
AMDGPU: Remove duplicate call to initializeSubtargetDependencies()
Jul 11 2018, 2:17 PM
tstellar committed rL336851: AMDGPU: Refactor Subtarget classes.
AMDGPU: Refactor Subtarget classes
Jul 11 2018, 2:06 PM
tstellar closed D49037: AMDGPU: Refactor Subtarget classes.
Jul 11 2018, 2:06 PM
tstellar added inline comments to D49037: AMDGPU: Refactor Subtarget classes.
Jul 11 2018, 2:06 PM

Jul 9 2018

tstellar added a comment to D49080: [PowerPC] Don't run BV DAG Combine before legalization if it assumes legal types.

This fixes the crash in the full test case too.

Jul 9 2018, 1:38 PM
tstellar added a comment to D49065: AMDGPU: Stop wasting argument registers with v3i32/v3f32.

Typo in summary v4i32/v4f32 -> v3i32,/v3f32.

Jul 9 2018, 6:56 AM

Jul 6 2018

tstellar created D49037: AMDGPU: Refactor Subtarget classes.
Jul 6 2018, 11:25 AM
tstellar committed rL336448: AMDGPU: Fix UBSan error caused by r335942.
AMDGPU: Fix UBSan error caused by r335942
Jul 6 2018, 10:21 AM
tstellar closed D48979: AMDGPU: Fix UBSan error caused by r335942.
Jul 6 2018, 10:21 AM

Jul 5 2018

tstellar committed rL336394: Update website for 6.0.1 release.
Update website for 6.0.1 release
Jul 5 2018, 3:18 PM
tstellar committed rL336392: Add 6.0.1 LICENSE.TXT.
Add 6.0.1 LICENSE.TXT
Jul 5 2018, 3:15 PM
tstellar committed rL336391: Add links for Ubuntu 14.04 binaries.
Add links for Ubuntu 14.04 binaries
Jul 5 2018, 3:05 PM
tstellar added inline comments to D48979: AMDGPU: Fix UBSan error caused by r335942.
Jul 5 2018, 11:13 AM
tstellar updated the diff for D48979: AMDGPU: Fix UBSan error caused by r335942.

Use subtarget query to get kernel arg offset.

Jul 5 2018, 11:11 AM
tstellar added inline comments to D48979: AMDGPU: Fix UBSan error caused by r335942.
Jul 5 2018, 10:30 AM
tstellar created D48979: AMDGPU: Fix UBSan error caused by r335942.
Jul 5 2018, 10:20 AM

Jul 3 2018

tstellar accepted D48819: AMDGPU/GlobalISel: Implement custom kernel arg lowering.

LGTM.

Jul 3 2018, 4:08 PM

Jul 2 2018

tstellar committed rL336167: Add Ubuntu 14.04 binaries.
Add Ubuntu 14.04 binaries
Jul 2 2018, 9:15 PM
tstellar committed rL336152: Add 6.0.1 docs.
Add 6.0.1 docs
Jul 2 2018, 4:27 PM

Jun 29 2018

tstellar committed rL336041: AMDGPU/GlobalISel: Make IMPLICIT_DEF of all sizes < 512 legal..
AMDGPU/GlobalISel: Make IMPLICIT_DEF of all sizes < 512 legal.
Jun 29 2018, 9:16 PM
tstellar closed D48777: AMDGPU/GlobalISel: Make IMPLICIT_DEF of all sizes < 512 legal..
Jun 29 2018, 9:16 PM
tstellar committed rC336039: Driver: Add an explicit target to testcase from r336037.
Driver: Add an explicit target to testcase from r336037
Jun 29 2018, 8:55 PM
tstellar committed rL336039: Driver: Add an explicit target to testcase from r336037.
Driver: Add an explicit target to testcase from r336037
Jun 29 2018, 8:55 PM
tstellar committed rL336038: Add links to 6.0.1 binaries..
Add links to 6.0.1 binaries.
Jun 29 2018, 8:07 PM
tstellar committed rC336037: Driver: Don't mix system tools with devtoolset tools on RHEL.
Driver: Don't mix system tools with devtoolset tools on RHEL
Jun 29 2018, 8:00 PM
tstellar committed rL336037: Driver: Don't mix system tools with devtoolset tools on RHEL.
Driver: Don't mix system tools with devtoolset tools on RHEL
Jun 29 2018, 8:00 PM
tstellar closed D34848: Driver: Don't mix system tools with devtoolset tools on RHEL.
Jun 29 2018, 8:00 PM
tstellar committed rL336033: Upload 6.0.1 binaries.
Upload 6.0.1 binaries
Jun 29 2018, 6:31 PM
tstellar created D48777: AMDGPU/GlobalISel: Make IMPLICIT_DEF of all sizes < 512 legal..
Jun 29 2018, 10:28 AM

Jun 28 2018

tstellar committed rL335942: AMDGPU: Separate R600 and GCN TableGen files.
AMDGPU: Separate R600 and GCN TableGen files
Jun 28 2018, 4:52 PM
tstellar closed D46365: AMDGPU: Separate R600 and GCN TableGen files.
Jun 28 2018, 4:52 PM
tstellar added inline comments to D46365: AMDGPU: Separate R600 and GCN TableGen files.
Jun 28 2018, 9:19 AM

Jun 27 2018

tstellar updated the diff for D46365: AMDGPU: Separate R600 and GCN TableGen files.

Add missing headers to tablegen files and remove virtual functions
from AMDGPUSubtarget.

Jun 27 2018, 9:07 PM
tstellar added a comment to D46365: AMDGPU: Separate R600 and GCN TableGen files.

Fails to build:
llvm-tblgen: Unknown command line argument '-gen-tgt-intrinsic'. Try: '../../../bin/llvm-tblgen -help'
llvm-tblgen: Did you mean '-gen-tgt-intrinsic-impl'?
make[2]: *** [lib/Target/AMDGPU/CMakeFiles/AMDGPUCommonTableGen.dir/build.make:1730: lib/Target/AMDGPU/R600GenIntrinsics.inc.tmp] Error 1

After fixing the build file as tblgen suggested (and few local fixes in my own patches) it builds OK and there are no piglit regressions on my turks.

Jun 27 2018, 8:55 PM
tstellar updated the diff for D46365: AMDGPU: Separate R600 and GCN TableGen files.

Rebase and stop generating intrinsic info for R600, we don't need this.

Jun 27 2018, 8:53 PM

Jun 26 2018

tstellar updated the diff for D46172: AMDGPU/GlobalISel: Implement select() for 32-bit @llvm.minnun and @llvm.maxnum.

Rebase patch on ToT.

Jun 26 2018, 11:37 PM
tstellar added a comment to D45882: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.exp.

Ping.

Jun 26 2018, 11:32 PM

Jun 25 2018

tstellar committed rL335550: Add 6.0.1 sources.
Add 6.0.1 sources
Jun 25 2018, 4:29 PM
tstellar committed rL335531: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:07 PM
tstellar committed rL335537: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:06 PM
tstellar committed rL335529: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:06 PM
tstellar committed rL335540: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:05 PM
tstellar committed rL335539: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:04 PM
tstellar committed rL335538: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:04 PM
tstellar committed rL335535: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:03 PM
tstellar committed rL335533: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:03 PM
tstellar committed rL335534: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:02 PM
tstellar committed rL335530: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:02 PM
tstellar committed rL335532: Creating release candidate final from release_601 branch.
Creating release candidate final from release_601 branch
Jun 25 2018, 3:00 PM
tstellar accepted D48536: AMDGPU/GlobalISel: Add support for llvm.amdgcn.kernarg.segment.ptr.

LGTM.

Jun 25 2018, 8:51 AM
tstellar added inline comments to D48536: AMDGPU/GlobalISel: Add support for llvm.amdgcn.kernarg.segment.ptr.
Jun 25 2018, 8:24 AM
tstellar accepted D48533: AMDGPU/GlobalISel: Fix G_IMPLICIT_DEF for pointers.

LGTM.

Jun 25 2018, 8:16 AM