Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (153 w, 4 d)

Recent Activity

Fri, Jan 17

tstellar added a comment to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.

I may not quite understand what the verifier is looking for here, but rather than trying to undo the optimization in 2 different places, would it be possible to implement this by having the InstructionSelector emit some kind of Pseudo Instruction for inputs to the comparison? For example, what would normally be selected to:

Fri, Jan 17, 8:21 PM · Restricted Project
tstellar updated the diff for D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
  • Add quotes around ${CMAKE_CURRENT_SOURCE_DIR}
Fri, Jan 17, 3:49 PM · Restricted Project, Restricted Project
tstellar updated the diff for D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
  • Fix indentation.
  • Remove placeholder AttributeReference.rst. The install target was replacing the generated AttributeReference.rst with this which caused the html page to be empty.
  • Tested with stand-alone clang builds: cmake ../clang -G Ninja -DCLANG_INCLUDE_DOCS=ON -DLLVM_BUILD_DOCS=ON -DLLVM_ENABLE_SPHINX=ON -DSPHINX_WARNINGS_AS_ERRORS=OFF
Fri, Jan 17, 2:24 PM · Restricted Project, Restricted Project

Thu, Jan 16

tstellar created D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.
Thu, Jan 16, 1:45 PM · Restricted Project, Restricted Project

Wed, Jan 15

tstellar updated the diff for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.

+ Remove InstsToMove from CombineInfo struct
+ Address other review comments.

Wed, Jan 15, 3:57 PM · Restricted Project

Tue, Jan 14

tstellar committed rG0dbcb3639451: CMake: Make most target symbols hidden by default (authored by tstellar).
CMake: Make most target symbols hidden by default
Tue, Jan 14, 7:51 PM
tstellar closed D54439: CMake: Make most target symbols hidden by default.
Tue, Jan 14, 7:51 PM · Restricted Project

Thu, Jan 9

tstellar added inline comments to D68720: Support -fstack-clash-protection for x86.
Thu, Jan 9, 1:13 PM · Restricted Project, Restricted Project

Tue, Jan 7

tstellar updated the diff for D54439: CMake: Make most target symbols hidden by default.

Rebase.

Tue, Jan 7, 12:20 PM · Restricted Project

Mon, Jan 6

tstellar added a comment to D71942: Update LLVMCallConv.

There is no plan for a 9.0.2 release.

Mon, Jan 6, 7:29 AM · Restricted Project

Dec 19 2019

tstellar updated subscribers of D66428: Change TargetLibraryInfo analysis passes to always require Function.
Dec 19 2019, 11:44 AM · Restricted Project

Dec 17 2019

tstellar committed rGc3bc805f4f99: AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct (authored by tstellar).
AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct
Dec 17 2019, 1:46 PM
tstellar closed D71045: AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct.
Dec 17 2019, 1:46 PM · Restricted Project

Dec 16 2019

tstellar accepted D71534: git-llvm: Add option to push to Github with SSH.

LGTM.

Dec 16 2019, 9:20 AM · Restricted Project

Dec 13 2019

tstellar updated the diff for D54439: CMake: Make most target symbols hidden by default.

Rebase and switch to using default visibility on Mac OS.

Dec 13 2019, 4:49 PM · Restricted Project
tstellar added a reviewer for D68720: Support -fstack-clash-protection for x86: annita.zhang.
Dec 13 2019, 12:14 PM · Restricted Project, Restricted Project

Dec 12 2019

tstellar added a comment to D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.

After thinking about this more, do we want to even try to support the BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support this in llvm.

Dec 12 2019, 2:56 PM · Restricted Project
tstellar added a comment to D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.

After thinking about this more, do we want to even try to support the BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support this in llvm.

Dec 12 2019, 12:26 PM · Restricted Project
tstellar committed rGbf13a71095fd: AMDGPU/SILoadStoreOptimizer: Simplify function (authored by tstellar).
AMDGPU/SILoadStoreOptimizer: Simplify function
Dec 12 2019, 6:58 AM
tstellar closed D71044: AMDGPU/SILoadStoreOptimizer: Simplify function.
Dec 12 2019, 6:58 AM · Restricted Project

Dec 11 2019

tstellar committed rGc1a0a213378a: export.sh: Fetch sources from GitHub instead of SVN (authored by tstellar).
export.sh: Fetch sources from GitHub instead of SVN
Dec 11 2019, 11:19 AM
tstellar committed rGf2c877161290: Merging r372480: (authored by ssarda).
Merging r372480:
Dec 11 2019, 11:10 AM
tstellar committed rGe8e0c077c416: Merging r371557: (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Merging r371557:
Dec 11 2019, 11:00 AM

Dec 10 2019

tstellar added a comment to D59780: Support Intel Control-flow Enforcement Technology.

Hmm, I'm sorry but I'm confused. IIRC I had a discussion in the LLVM dev meeting that we were going to submit a change with a single PLT scheme rather than IPLT, so when I said that I'm going to submit a patch, I meant that I'm going to submit a patch for the 1PLT scheme rather than the 2PLT scheme. But this is for the 2PLT scheme. This is not something I want.

Dec 10 2019, 9:01 PM · Restricted Project

Dec 6 2019

tstellar committed rGedf6717d8d30: export.sh: Fetch sources from GitHub instead of SVN (authored by tstellar).
export.sh: Fetch sources from GitHub instead of SVN
Dec 6 2019, 7:00 PM
tstellar closed D70460: export.sh: Fetch sources from GitHub instead of SVN.
Dec 6 2019, 6:59 PM · Restricted Project
tstellar added a comment to D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.

I think the code would benefit from the refactoring I've mentioned on the other patch, where the lists only hold a structure with information on a single instruction. Maybe call it CandidateInfo (information of one instruction, persistent in lists) vs. CombineInfo (information on a pair, only temporary).

Dec 6 2019, 6:59 PM · Restricted Project
tstellar added a child revision for D71045: AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct: D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Dec 6 2019, 6:59 PM · Restricted Project
tstellar added parent revisions for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets: D71044: AMDGPU/SILoadStoreOptimizer: Simplify function, D71045: AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct.
Dec 6 2019, 6:59 PM · Restricted Project
tstellar added a child revision for D71044: AMDGPU/SILoadStoreOptimizer: Simplify function: D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.
Dec 6 2019, 6:59 PM · Restricted Project
tstellar updated the diff for D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.

Rebase on master and update for a recent refactoring.

Dec 6 2019, 6:50 PM · Restricted Project

Dec 5 2019

tstellar added inline comments to D70026: [cmake] Always build the libLLVM shared library.
Dec 5 2019, 1:40 PM · Restricted Project
tstellar updated the diff for D70026: [cmake] Always build the libLLVM shared library.

Use correct checks for Windows.

Dec 5 2019, 1:34 PM · Restricted Project
tstellar committed rG432bf48c08da: [profile] Fix file contention causing dropped counts on Windows under -fprofile… (authored by hans).
[profile] Fix file contention causing dropped counts on Windows under -fprofile…
Dec 5 2019, 9:05 AM
tstellar added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Dec 5 2019, 6:58 AM · Restricted Project
tstellar added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Dec 5 2019, 6:58 AM · Restricted Project

Dec 4 2019

tstellar created D71045: AMDGPU/SILoadStoreOptimillzer: Refactor CombineInfo struct.
Dec 4 2019, 9:04 PM · Restricted Project
tstellar created D71044: AMDGPU/SILoadStoreOptimizer: Simplify function.
Dec 4 2019, 8:25 PM · Restricted Project
tstellar added a comment to D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.

Hi @tstellar, I'm looking into a case where this patch slowed down a shader by 10%. Before I go too far, was this patch supposed to change the behaviour at all, or was it supposed to be purely a compile time improvement?

The intention was to not change the behavior at all.

In the case I'm looking at it seems to do the same amount of load merging as before, but the merged loads are inserted at different places in the basic block.

Do you have a MIR or .ll dump of the shader I could look at ? Also, does https://reviews.llvm.org/D65966 help?

P8173 is a MIR test case. See the RUN line for how to run it. I see significant differences in the placing of the merged BUFFER_LOAD instructions with/without D65961 (or before/after it was committed).

I tried applying D65966 on top of rGe6f51713054f but it made no difference to the output.

Dec 4 2019, 7:19 PM · Restricted Project
tstellar updated the diff for D70460: export.sh: Fetch sources from GitHub instead of SVN.

Also generate a tarball with all sub-project sources.

Dec 4 2019, 5:19 PM · Restricted Project
tstellar added a comment to D54439: CMake: Make most target symbols hidden by default.

Ping.

Dec 4 2019, 4:50 PM · Restricted Project
tstellar committed rGb9297dcdf2a3: [PowerPC] Do not emit HW loop if the body contains calls to lrint/lround (authored by nemanjai).
[PowerPC] Do not emit HW loop if the body contains calls to lrint/lround
Dec 4 2019, 2:29 PM
tstellar committed rG98b1752888c0: Merging r366572: (authored by thanm).
Merging r366572:
Dec 4 2019, 2:12 PM
tstellar added a comment to D67463: [MS] Warn when shadowing template parameters under -fms-compatibility.
In D67463#1769557, @rnk wrote:
In D67463#1767919, @rnk wrote:

@hans, are we still accepting 9.0.1 patches? I thought we'd already made a release candidate.

I'm still accepting patches until rc2 (which should have been Monday, but was delayed), so I can pull it if you think it is important.

You know, it's a significant change in behavior. This will cause hard errors for users of -fms-extensions who do not use -fms-compatibility. Maybe it's better to release that changes in the 10.0 release.

Dec 4 2019, 2:10 PM · Restricted Project, Restricted Project
tstellar committed rG474037d798d2: Merging r370113: (authored by luismarques).
Merging r370113:
Dec 4 2019, 2:01 PM
tstellar added a comment to D67463: [MS] Warn when shadowing template parameters under -fms-compatibility.
In D67463#1767919, @rnk wrote:

@hans, are we still accepting 9.0.1 patches? I thought we'd already made a release candidate.

Dec 4 2019, 9:23 AM · Restricted Project, Restricted Project

Dec 3 2019

tstellar committed rG64bdd8bc9fbf: [COFF] Don't error if the only inputs are from /wholearchive: (authored by rnk).
[COFF] Don't error if the only inputs are from /wholearchive:
Dec 3 2019, 3:42 PM
tstellar committed rG52ac91476dcf: [PowerPC] Fix crash in peephole optimization (authored by nemanjai).
[PowerPC] Fix crash in peephole optimization
Dec 3 2019, 2:27 PM
tstellar committed rGed3f33f9dca7: [PowerPC] Implementing overflow version for XO-Form instructions (authored by Stefan Pintile <stefanp@kuat.aus.stglabs.ibm.com>).
[PowerPC] Implementing overflow version for XO-Form instructions
Dec 3 2019, 1:49 PM
tstellar committed rG0a64fe568090: [ELF] Fix lld build on Windows/MinGW (authored by aykevl).
[ELF] Fix lld build on Windows/MinGW
Dec 3 2019, 1:21 PM

Dec 2 2019

tstellar updated subscribers of rG7b86188b50bf: [Diagnostic] add a warning which warns about misleading indentation.

I had to revert this in 3c5142597a451a03db21c2ffe8f6520c7eacce59 due to some bot failures. Some parts of the llvm code base hit this warning and fail to build with -Werror.

This is kinda strange, the LLVM code is already passing with gcc's -Wmisleading-indention.

Can you show us a log?

Dec 2 2019, 5:35 AM
tstellar added a comment to D65961: AMDGPU/SILoadStoreOptimizer: Optimize scanning for mergeable instructions.

Hi @tstellar, I'm looking into a case where this patch slowed down a shader by 10%. Before I go too far, was this patch supposed to change the behaviour at all, or was it supposed to be purely a compile time improvement?

Dec 2 2019, 5:34 AM · Restricted Project

Nov 27 2019

tstellar committed rGe99a087fff6c: Merging r373389: (authored by leonardchan).
Merging r373389:
Nov 27 2019, 2:18 PM
tstellar committed rGbead8bf31fb4: Merging r371548: (authored by ABataev).
Merging r371548:
Nov 27 2019, 1:58 PM
tstellar committed rGaf5faf8909f2: [x86] avoid crashing when splitting AVX stores with non-simple type (PR43916) (authored by spatel).
[x86] avoid crashing when splitting AVX stores with non-simple type (PR43916)
Nov 27 2019, 1:38 PM
tstellar committed rG7fc9f129f80f: Merging r372281: (authored by serge-sans-paille).
Merging r372281:
Nov 27 2019, 12:01 PM
tstellar committed rG28f6aac1c102: [CMake] Fix LLVM build non-determinism on RHEL (authored by amyk).
[CMake] Fix LLVM build non-determinism on RHEL
Nov 27 2019, 11:32 AM
tstellar committed rG19c735edfb7e: Merging r372835: (authored by mgorny).
Merging r372835:
Nov 27 2019, 11:14 AM

Nov 25 2019

tstellar committed rG3c5142597a45: Revert "[Diagnostic] add a warning which warns about misleading indentation" (authored by tstellar).
Revert "[Diagnostic] add a warning which warns about misleading indentation"
Nov 25 2019, 1:25 PM
tstellar added a reverting change for rG7b86188b50bf: [Diagnostic] add a warning which warns about misleading indentation: rG3c5142597a45: Revert "[Diagnostic] add a warning which warns about misleading indentation".
Nov 25 2019, 1:25 PM
tstellar committed rG0e12815566b2: Revert "[Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy" (authored by tstellar).
Revert "[Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy"
Nov 25 2019, 1:25 PM
tstellar added a reverting change for rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy: rG0e12815566b2: Revert "[Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy".
Nov 25 2019, 1:25 PM
tstellar added a comment to rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy.

Reverted in 0e12815566b2f8dd2d3bfe2319e55b3ffb9767ae.

Nov 25 2019, 1:23 PM
tstellar added a comment to rG7b86188b50bf: [Diagnostic] add a warning which warns about misleading indentation.

I had to revert this in 3c5142597a451a03db21c2ffe8f6520c7eacce59 due to some bot failures. Some parts of the llvm code base hit this warning and fail to build with -Werror.

Nov 25 2019, 1:23 PM
tstellar added a comment to rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy.

I'm planning to revert this patch along with the zorg patch, and then we can discussion the next steps.

Nov 25 2019, 12:37 PM
tstellar added a comment to rG9353c5dd0664: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy.
Nov 25 2019, 12:00 PM
tstellar committed rG62a16ca77d68: Merging r373655: (authored by nickdesaulniers).
Merging r373655:
Nov 25 2019, 10:46 AM
tstellar committed rG293a245241d3: Merging r372178: (authored by rnk).
Merging r372178:
Nov 25 2019, 9:11 AM

Nov 22 2019

tstellar requested review of D70026: [cmake] Always build the libLLVM shared library.
Nov 22 2019, 10:25 PM · Restricted Project
tstellar committed rGaa0ed8dac77b: test-release.sh: Update to fetch source from GitHub (authored by tstellar).
test-release.sh: Update to fetch source from GitHub
Nov 22 2019, 10:11 PM
tstellar accepted D70026: [cmake] Always build the libLLVM shared library.

Ping. All the prerequisite patches have been committed now.

Nov 22 2019, 9:03 AM · Restricted Project

Nov 21 2019

tstellar added a comment to D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.

Ping.

Nov 21 2019, 10:12 PM · Restricted Project
tstellar committed rG28c1f51f14ff: Merging r373220: (authored by probinson).
Merging r373220:
Nov 21 2019, 4:01 PM
tstellar committed rG76817ab1e104: Merging r373219: (authored by probinson).
Merging r373219:
Nov 21 2019, 4:01 PM
tstellar committed rGc1d76f45b497: Merging r373216: (authored by probinson).
Merging r373216:
Nov 21 2019, 3:25 PM
tstellar added a reverting change for rGf29366b1f594: StackProtector: Use PointerMayBeCaptured: rGc1d76f45b497: Merging r373216:.
Nov 21 2019, 3:25 PM
tstellar added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 21 2019, 1:17 PM · Restricted Project
tstellar committed rGab411801b827: [cmake] Explicitly mark libraries defined in lib/ as "Component Libraries" (authored by tstellar).
[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"
Nov 21 2019, 10:50 AM
tstellar closed D70179: [cmake] Explicitly mark libraries defined in lib/ as "Component Libraries".
Nov 21 2019, 10:50 AM · Restricted Project

Nov 20 2019

tstellar committed rGd1f4d6a49343: Merging r370547: (authored by wmi).
Merging r370547:
Nov 20 2019, 7:39 PM
tstellar updated subscribers of D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 20 2019, 4:07 PM · Restricted Project
tstellar added a comment to D70511: [BPF] Fix a bug in peephole optimization.

Should we backport this to the release/9.x branch?

Nov 20 2019, 2:52 PM · Restricted Project
tstellar committed rGe5b2493947f3: Merging r373148: (authored by aaronpuchert).
Merging r373148:
Nov 20 2019, 2:25 PM
tstellar committed rG7185aa61a7aa: [WebAssembly] Fix miscompile of select with and (authored by tlively).
[WebAssembly] Fix miscompile of select with and
Nov 20 2019, 1:33 PM
tstellar committed rG5bb85aeecac1: GitHub Actions: Pull source code from current repo when dumping the ABI (authored by tstellar).
GitHub Actions: Pull source code from current repo when dumping the ABI
Nov 20 2019, 1:09 PM
tstellar committed rGd24c8dde9103: GitHub Actions: Only run tests on pushes to release/** branches (authored by tstellar).
GitHub Actions: Only run tests on pushes to release/** branches
Nov 20 2019, 1:09 PM
tstellar added a reviewer for D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc: dlj.
Nov 20 2019, 11:25 AM · Restricted Project
tstellar added a reviewer for D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc: rsmith.
Nov 20 2019, 11:25 AM · Restricted Project

Nov 19 2019

tstellar committed rG0f34f1b9318e: Merging r367981: (authored by MaskRay).
Merging r367981:
Nov 19 2019, 7:00 PM
tstellar added a comment to D54439: CMake: Make most target symbols hidden by default.
In D54439#1744353, @rnk wrote:

I've confirmed that this change does fix the warning. How do we we want to proceed with this patch? The warnings will still be present on existing Mac OS installs. Should we disable this change on Mac OS for now or should we keep it and live with the warnings?

I'd be in favor of letting Mac use default visibility for now. One way to make this more palatable would be to have a CMake option that allows users to override the default and get hidden visibility if they really want it.

Nov 19 2019, 4:59 PM · Restricted Project
tstellar created D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 19 2019, 1:20 PM · Restricted Project
tstellar committed rGc97f303880c2: test-release.sh: Update to fetch source from GitHub (authored by tstellar).
test-release.sh: Update to fetch source from GitHub
Nov 19 2019, 11:20 AM
tstellar closed D70353: test-release.sh: Update to fetch source from GitHub.
Nov 19 2019, 11:20 AM · Restricted Project

Nov 18 2019

tstellar updated the summary of D70353: test-release.sh: Update to fetch source from GitHub.
Nov 18 2019, 11:35 AM · Restricted Project
tstellar added inline comments to D70353: test-release.sh: Update to fetch source from GitHub.
Nov 18 2019, 11:35 AM · Restricted Project
tstellar updated the diff for D70353: test-release.sh: Update to fetch source from GitHub.

Address some review comments.

Nov 18 2019, 11:26 AM · Restricted Project
tstellar committed rG6c86aa62d502: Add yaml defintions for CI tests with GitHub Actions (authored by tstellar).
Add yaml defintions for CI tests with GitHub Actions
Nov 18 2019, 9:47 AM

Nov 15 2019

tstellar created D70353: test-release.sh: Update to fetch source from GitHub.
Nov 15 2019, 6:28 PM · Restricted Project
tstellar committed rG8af4ee9ff003: Merging r375403: (authored by lenary).
Merging r375403:
Nov 15 2019, 5:53 PM
tstellar committed rG0ec4a87c38da: Fix build since b288f7d (authored by tstellar).
Fix build since b288f7d
Nov 15 2019, 9:47 AM