Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (226 w, 1 d)

Recent Activity

Wed, Jun 9

tstellar committed rGb6f983dd842e: [Utils][vim] Highlight 'ptr' type (authored by tstellar).
[Utils][vim] Highlight 'ptr' type
Wed, Jun 9, 9:40 PM
tstellar closed D102460: [Utils][vim] Highlight 'ptr' type.
Wed, Jun 9, 9:40 PM · Restricted Project
tstellar committed rWe83520da1e35: Fix formating in release schedule (authored by tstellar).
Fix formating in release schedule
Wed, Jun 9, 10:55 AM
tstellar committed rW312341770668: Add 12.0.1 and 13.0.0 release schedules (authored by tstellar).
Add 12.0.1 and 13.0.0 release schedules
Wed, Jun 9, 8:15 AM

Fri, Jun 4

tstellar added a comment to D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.

What is the status of this patch? It fixes a blocking bug for the 12.0.1 release.

Fri, Jun 4, 2:13 PM · Restricted Project

Thu, May 27

tstellar accepted D101864: [Release] Add LLDB in release binaries by default.

LGTM.

Thu, May 27, 4:38 PM · Restricted Project

Wed, May 26

tstellar added a comment to D85278: [lld] Support building shared libLLD.so.

I think this could be simplified by using object libraries like this patch: https://reviews.llvm.org/D95727 does for libLLVM.so

Wed, May 26, 9:47 PM · lld
tstellar added a comment to D85278: [lld] Support building shared libLLD.so.

From what I understand, linking lld as a shared library is an explicit non-goal of lld. It trusts inputs and crashes on bad inputs, since it's designed to be run as a separate process.

Can you say more about what you want this for? It seems like something we don't want to do.

Wed, May 26, 9:44 PM · lld
tstellar updated subscribers of D103154: [lit][test] Improve testing of use_llvm_tool.
Wed, May 26, 5:10 PM · Restricted Project
tstellar updated subscribers of D103156: [lit] Fix testing of standalone clang and lld builds.
Wed, May 26, 5:10 PM · Restricted Project
tstellar added a comment to D103156: [lit] Fix testing of standalone clang and lld builds.

D103154 seems to be making a lot of the same changes as this patch.

Wed, May 26, 3:38 PM · Restricted Project

Fri, May 21

tstellar added a comment to D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag llvmorg-12.0.0 from llvm-project). We tend to only use release tagged versions.

Fri, May 21, 7:51 AM · Restricted Project
tstellar added a comment to D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Are you still seeing failures in the main branch? I thought I had fixed this with Revision: https://reviews.llvm.org/D96367.

Fri, May 21, 7:32 AM · Restricted Project

Thu, May 13

tstellar requested review of D102460: [Utils][vim] Highlight 'ptr' type.
Thu, May 13, 8:57 PM · Restricted Project

May 12 2021

tstellar added a comment to D100674: Add ziglang builder.

How long do these tests take to run?

Generally about an hour on my server

Could you add this to the list of release builders too?

I am not quite sure how to do that;

May 12 2021, 6:15 PM
tstellar abandoned D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.
May 12 2021, 10:30 AM · Restricted Project

May 11 2021

tstellar added a comment to D101972: Force visibility of llvm::Any to external.

FWIW, I was originally against adding LLVM_EXTERNAL_VISIBILITY to the class, because I thought it was just working around a fundamental flaw in -fvisiblity=hidden, but based on the discussion here, I've fine with the proposed solution.

May 11 2021, 9:14 PM · Restricted Project
tstellar added a comment to D102193: Fix branch coverage merging across function instantiations .

I saw this fix was backported to the release/12.x branch, was there a bug for this?

I did not file an official bug for this issue -- should I have? My original commit on 12.x also needed to be fixed, but if I missed something in the process for updating release branches, let me know. Thanks!

May 11 2021, 5:47 PM · Restricted Project
tstellar added a comment to D100674: Add ziglang builder.

How long do these tests take to run? Could you add this to the list of release builders too?

May 11 2021, 5:45 PM
tstellar added a comment to D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions.

I was originally skeptical of this change, because of some negative feedback about these flags in the past on the Fedora development list. However, the people I've talked to more recently seem to be in favor of this change, so no objection from me.

May 11 2021, 5:41 PM · Restricted Project, Restricted Project
tstellar added a comment to D102193: Fix branch coverage merging across function instantiations .

I saw this fix was backported to the release/12.x branch, was there a bug for this?

May 11 2021, 5:29 PM · Restricted Project

May 10 2021

tstellar added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

I'm fine with the concept of having an option for generating a snapshot tarball. I understand that it may not be useful to everyone, but we already ship tarballs as part of our releases and if we were to do official snapshots for the project, we would want to generate the tarballs in the same way. I do agree with Hans that it would be nice if there was some way to uniquely identify the tarball (e.g. with the git hash) otherwise if you do multiple tarballs a day, they would all have the same name.

May 10 2021, 5:52 PM · Restricted Project

May 7 2021

tstellar updated subscribers of D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions.
May 7 2021, 1:56 PM · Restricted Project, Restricted Project
tstellar added a comment to D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions.

Does this change mean that LD_PRELOAD will no longer work? Are there any other downsides to adding these flags?

May 7 2021, 1:50 PM · Restricted Project, Restricted Project

May 6 2021

tstellar added a comment to D101972: Force visibility of llvm::Any to external.

@rnk Even if we were to commit this patch, do you think we would still need to fix/remove llvm:Any?

May 6 2021, 2:33 PM · Restricted Project
tstellar added a comment to D101972: Force visibility of llvm::Any to external.

@rnk I agree with

May 6 2021, 9:35 AM · Restricted Project
tstellar added a comment to D101972: Force visibility of llvm::Any to external.

Adding @rnk, who reviewed the original patch for awareness...

May 6 2021, 7:07 AM · Restricted Project
tstellar updated subscribers of D101972: Force visibility of llvm::Any to external.
May 6 2021, 7:02 AM · Restricted Project
tstellar added a comment to D101890: [LLD] Improve --strip-all help text.

Can you file a bug for this?

May 6 2021, 6:16 AM · Restricted Project

Apr 26 2021

tstellar added a comment to D101104: [X86][AVX] foldShuffleOfHorizOp - don't attempt to handle 256-bit X86ISD::VBROADCAST (PR49971).

Can you file a bug for this?

Apr 26 2021, 8:46 AM · Restricted Project

Apr 15 2021

tstellar committed rW74f9214498ad: Update for 12.0.0 release (authored by tstellar).
Update for 12.0.0 release
Apr 15 2021, 10:53 PM

Apr 14 2021

tstellar updated subscribers of D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned.
Apr 14 2021, 7:46 PM · Restricted Project

Apr 8 2021

tstellar added a reviewer for D99780: workflows: Add GitHub action for automating some release tasks: kwk.
Apr 8 2021, 2:08 PM · Restricted Project
tstellar added a reviewer for D99353: [driver] Make `clang` warn rather then error on `flang` options: tbaeder.
Apr 8 2021, 8:09 AM · Restricted Project, Restricted Project

Apr 7 2021

tstellar added a comment to D99780: workflows: Add GitHub action for automating some release tasks.

I'm not familiar with github actions so I'm just skimming the code, but it looks good as far as I can tell.

Any reason not to upload the docs also for release candidates? I think it's useful for people to be able to see the current state of release notes (usually to suggest they need improvement).

Apr 7 2021, 8:52 AM · Restricted Project

Apr 6 2021

tstellar requested review of D100021: cmake: Remove unused property on some targets: LLVM_LINK_LIBS.
Apr 6 2021, 11:10 PM · Restricted Project
tstellar updated the diff for D95727: llvm-shlib: Create object libraries for each component and link against them.

Updated patch with fixes for z3 and libffi build failures

Apr 6 2021, 10:48 PM · Restricted Project
tstellar reopened D95727: llvm-shlib: Create object libraries for each component and link against them.
Apr 6 2021, 10:46 PM · Restricted Project
Herald added a reviewer for D77574: [OpenMP] Fix layering problem with FrontendOpenMP: bollu.
Apr 6 2021, 4:59 PM · Restricted Project, Restricted Project

Apr 5 2021

tstellar added a reverting change for rG43ceb74eb1a5: llvm-shlib: Create object libraries for each component and link against them: rGe07e08f3662a: Revert "llvm-shlib: Create object libraries for each component and link against….
Apr 5 2021, 10:47 AM
tstellar committed rGe07e08f3662a: Revert "llvm-shlib: Create object libraries for each component and link against… (authored by tstellar).
Revert "llvm-shlib: Create object libraries for each component and link against…
Apr 5 2021, 10:47 AM
tstellar added a reverting change for rGd66f9c4f1e83: Fix build rules for LLVM_WITH_Z3 after D95727: rG982396ddd7df: Revert "Fix build rules for LLVM_WITH_Z3 after D95727".
Apr 5 2021, 10:47 AM
tstellar committed rG982396ddd7df: Revert "Fix build rules for LLVM_WITH_Z3 after D95727" (authored by tstellar).
Revert "Fix build rules for LLVM_WITH_Z3 after D95727"
Apr 5 2021, 10:47 AM
tstellar added a reverting change for D95727: llvm-shlib: Create object libraries for each component and link against them: rGe07e08f3662a: Revert "llvm-shlib: Create object libraries for each component and link against….
Apr 5 2021, 10:47 AM · Restricted Project
tstellar added a comment to D99886: [CMake] Propagate static extensions to LLVMExtensions object library.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

Apr 5 2021, 9:09 AM · Restricted Project
tstellar added a comment to D95114: HowToReleaseLLVM: Add annual release schedule template.

It's helpful for the release managers to have at least have a target date for creating the release branch and also to know how much time to wait between -rc1 and -rc2. I think we should have this information at a minimum, but I agree after -rc2 the release schedule does become unpredictable. I'll try to rework this, so it is less specific.

Apr 5 2021, 8:39 AM · Restricted Project
tstellar added a comment to D95727: llvm-shlib: Create object libraries for each component and link against them.

I pushed my workaround for Z3 here: https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357
Hopefully that will make our bots happy again.

I don't mind if someone wants to do a post-commit review of my workaround.

Apr 5 2021, 8:27 AM · Restricted Project

Apr 1 2021

tstellar requested review of D99780: workflows: Add GitHub action for automating some release tasks.
Apr 1 2021, 5:30 PM · Restricted Project
tstellar updated the diff for D95284: utils/release: Add script for building release documentation.

Address review comments.

Apr 1 2021, 5:23 PM · Restricted Project
tstellar committed rG43ceb74eb1a5: llvm-shlib: Create object libraries for each component and link against them (authored by tstellar).
llvm-shlib: Create object libraries for each component and link against them
Apr 1 2021, 3:02 PM
tstellar closed D95727: llvm-shlib: Create object libraries for each component and link against them.
Apr 1 2021, 3:02 PM · Restricted Project

Mar 30 2021

tstellar added a comment to D99620: [CMake][Compiler-rt] Compute LLVM_MAIN_SRC_DIR assuming the monorepo layout..

@delcypher Ok, thanks. So my question for for @phosek is what if we replaced the usage of llvm-config with find_package(LLVM) would that change also enable the clean ups you are talking about? Or does relying on any kind of out-of-tree files make the build more complicated?

Mar 30 2021, 5:22 PM · Restricted Project
tstellar added a comment to D99620: [CMake][Compiler-rt] Compute LLVM_MAIN_SRC_DIR assuming the monorepo layout..

We still build compiler-rt in non-monorepo configuration for Fedora. Which files from the llvm directory (or other directories in the monorepo) does compiler-rt depend on?

Mar 30 2021, 3:37 PM · Restricted Project

Mar 29 2021

tstellar added a comment to D99155: [CMake] Support building libLLVM.a archive.

I have this uncommitted change: D95727 which updates libLLVM.so to use object libraries, would you be able to also use object libraries to avoid adding this python script?

Mar 29 2021, 4:12 PM · Restricted Project

Feb 25 2021

tstellar committed rW42bc07d6d9a7: Update for 11.1.0 release (authored by tstellar).
Update for 11.1.0 release
Feb 25 2021, 9:46 PM

Feb 23 2021

tstellar added a comment to D97272: [12.0.0][llvm-symbolizer][test] Fix test broken after cherry-pick.

I've merged this.

Feb 23 2021, 11:13 AM · Restricted Project
tstellar accepted D97272: [12.0.0][llvm-symbolizer][test] Fix test broken after cherry-pick.

You can go ahead and push it directly to the branch.

Feb 23 2021, 9:26 AM · Restricted Project

Feb 17 2021

tstellar added a comment to rGac6c13bfc49f: [sanitizers] Pass CMAKE_C_FLAGS into TSan buildgo script.

This seems OK to backport, can you file a bug for it?

Feb 17 2021, 8:45 AM

Feb 12 2021

tstellar added a comment to D96259: [AArch64] Use '//' as comment string for MSVC assembly.

Can you file a bug for the backport request?

Feb 12 2021, 8:53 AM · Restricted Project

Feb 11 2021

tstellar committed rGe3cd3a3c9152: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript… (authored by tstellar).
Partially Revert "scan-view: Remove Reporter.py and associated AppleScript…
Feb 11 2021, 7:12 PM
tstellar closed D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files".
Feb 11 2021, 7:11 PM · Restricted Project
tstellar added a comment to D96498: Fix exegesis build on aarch64-windows-msvc host.

@tstellar

Hi Tom,

OK to backport to release/12.x branch once this is merged to master? This will unblock RC builds for aarch64-windows-msvc (Windows on Arm).

Feb 11 2021, 6:35 AM · Restricted Project

Feb 10 2021

tstellar added a comment to D96448: BPF: Implement TTI.IntImmCost() properly.

I get concerned when I see us having to disable optimizations to fix bugs. Is there any kind of long-term plan to make the kernel verifier able to accept what LLVM produces or will we always be chasing after failures like this?

Feb 10 2021, 1:16 PM · Restricted Project
tstellar added inline comments to D94013: [libclc] Add clspv target for libclc.
Feb 10 2021, 11:25 AM · Restricted Project
tstellar added inline comments to D94013: [libclc] Add clspv target for libclc.
Feb 10 2021, 10:58 AM · Restricted Project
tstellar committed rG997f6b6f8e06: [CMake] Remove some dead code in llvm_install_library_symlink() (authored by tstellar).
[CMake] Remove some dead code in llvm_install_library_symlink()
Feb 10 2021, 10:13 AM
tstellar closed D95666: [CMake] Remove some dead code in llvm_install_library_symlink().
Feb 10 2021, 10:13 AM · Restricted Project
tstellar added inline comments to D94013: [libclc] Add clspv target for libclc.
Feb 10 2021, 8:24 AM · Restricted Project
tstellar added a comment to D94013: [libclc] Add clspv target for libclc.

Is the fma.cl file mostly copied from another file that is already in the tree?

Feb 10 2021, 7:24 AM · Restricted Project

Feb 9 2021

tstellar added reviewers for D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files": NoQ, krememek, vsavchenko.
Feb 9 2021, 1:51 PM · Restricted Project
tstellar requested review of D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files".
Feb 9 2021, 1:50 PM · Restricted Project

Feb 8 2021

tstellar added a comment to D95055: [clang] Don't look into <sysroot> for C++ headers if they are found alongside the toolchain.

Sorry, it's too late for 11.1.0.

Feb 8 2021, 11:58 AM · Restricted Project
tstellar added a comment to D96213: Fix compiler-rt build on musl.

Can you file a bug for this and mark it as a blocker for release-12.0.0?

Feb 8 2021, 9:21 AM · Restricted Project

Feb 5 2021

tstellar added a comment to D96163: [analyzer] Add 12.0.0. release notes.

You can push this directly to the release/12.x branch when it's ready.

Feb 5 2021, 11:13 AM · Restricted Project

Feb 4 2021

tstellar added a comment to D96070: [clang] [driver] Enable static linking to libc++.

The goal here is for distributions to be able to build libc++ one way and then have it work with clang without requiring that users add additional linker flags besides -static or -stdlib=libc++. Is there a combination of CMake arguments we can use when building libc++ to make all static and shared linking with libc++ work out of the box?

Feb 4 2021, 2:23 PM · Restricted Project
tstellar accepted D96063: [🍒]Disable CFI in __get_elem to allow casting a pointer to uninitialized memory.

LGTM.

Feb 4 2021, 10:39 AM · Restricted Project
tstellar accepted D96062: [🍒][libc++] Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

LGTM.

Feb 4 2021, 10:36 AM · Restricted Project
tstellar accepted D96059: [🍒][libc++] Rename include/support to include/__support.

Please go ahead and merge this to the release/12.x branch.

Feb 4 2021, 10:33 AM · Restricted Project, Restricted Project
tstellar updated the diff for D96046: Enable some builders on the release branch.

Fix typo.

Feb 4 2021, 9:05 AM
tstellar requested review of D96046: Enable some builders on the release branch.
Feb 4 2021, 8:29 AM
tstellar accepted D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch).

Yes, go ahead and push this.

Feb 4 2021, 7:03 AM · Restricted Project

Feb 2 2021

tstellar added a comment to D95380: Turn on the new pass manager by default.

Is this something we want to try to pull into the release/12.x branch?

Feb 2 2021, 8:51 PM · Restricted Project

Jan 29 2021

tstellar requested review of D95727: llvm-shlib: Create object libraries for each component and link against them.
Jan 29 2021, 9:36 PM · Restricted Project
tstellar added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Oh, I see. I made this change in the master branch and then ported it to the release/11.x branch. It changed the signature of a virtual method, which had a couple more overrides in the release/11.x branch, and when I ported the change I didn't realize those other overrides existed. So now the release/11.x builds that include those overrides (btw, what build flags are needed to include those?) are broken. I'm not sure what the options are now that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, thoughts?

I have a fix for this ready, I can push it to 11.0.1.

Jan 29 2021, 8:53 AM · Restricted Project
tstellar added a comment to D95666: [CMake] Remove some dead code in llvm_install_library_symlink().

I'm 100% in favor of removing code, but can you explain why it's dead?

Jan 29 2021, 8:49 AM · Restricted Project

Jan 28 2021

tstellar requested review of D95666: [CMake] Remove some dead code in llvm_install_library_symlink().
Jan 28 2021, 11:00 PM · Restricted Project

Jan 26 2021

tstellar committed rG5369517d20dd: Bump the trunk major version to 13 (authored by tstellar).
Bump the trunk major version to 13
Jan 26 2021, 7:39 PM

Jan 25 2021

tstellar added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@brainstorm , @tonic , @tstellar , thank you very much for your help!

I support and improve Xtensa backend now, current version of the backend is rebased on release 11.0.0 https://github.com/espressif/llvm-project/tree/xtensa_release_11.0.0 .

@tstellar , so I can just update these 10 patches according to latest changes in LLVM, add myself as code owner in the first patch and send patches again to list (I will recheck outstanding issues)?

Jan 25 2021, 7:09 AM · Restricted Project

Jan 22 2021

tstellar requested review of D95284: utils/release: Add script for building release documentation.
Jan 22 2021, 8:54 PM · Restricted Project

Jan 21 2021

tstellar added a comment to D94451: Proposal for adding Bazel build configuration in-tree with peripheral support.

Thanks for the updates. I think this proposal is ready to send to Chris (Step 4).

Jan 21 2021, 7:08 PM
tstellar added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

@andreisfr I don't seen any major issues being raised with this backend. It would be great if there was a public official ISA document, but I don't think the lack of one is a blocker. Please make a last check of the reviews in phabricato to see if there are any outstanding issues. Then, I would recommend you take a look at the documentation @tonic posted. Specifically the 5 bullet points under the "The basic rules for a back-end to be upstreamed in experimental mode are:" header. If you think you meet those requirements, please re-send the RFC to the list, so we can discuss getting this added.

Jan 21 2021, 6:53 PM · Restricted Project
tstellar added a comment to D95114: HowToReleaseLLVM: Add annual release schedule template.

I think "Week number" is too ambiguous to be a guide. If January starts on the last day of the week, does that still count as week#1? What day does the week start on, anyway--much of the world starts the week on Sunday, much of the world starts the week on Monday.
"Fourth Tuesday in January/July" is unambiguous and makes everything easier to plan. Using "Start + N weeks" for the rest of the target dates is fine.

Jan 21 2021, 7:58 AM · Restricted Project

Jan 20 2021

tstellar requested review of D95114: HowToReleaseLLVM: Add annual release schedule template.
Jan 20 2021, 9:54 PM · Restricted Project
tstellar updated the diff for D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.

Fix shared object symlinks.

Jan 20 2021, 2:07 PM · Restricted Project
tstellar added inline comments to D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.
Jan 20 2021, 2:02 PM · Restricted Project
tstellar added inline comments to D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.
Jan 20 2021, 1:50 PM · Restricted Project
tstellar added a comment to D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.

I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself?

Jan 20 2021, 8:17 AM · Restricted Project

Jan 19 2021

tstellar added reviewers for D94941: Add minor version to libclang.so and libclang-cpp.so SONAME: serge-sans-paille, cuviper.
Jan 19 2021, 9:34 AM · Restricted Project
tstellar added inline comments to D94387: Add new LLVMComponents CMake module..
Jan 19 2021, 7:28 AM · Restricted Project
tstellar added inline comments to D94387: Add new LLVMComponents CMake module..
Jan 19 2021, 7:28 AM · Restricted Project