Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (114 w, 1 d)

Recent Activity

Wed, Apr 17

tstellar added a comment to D60839: [ScheduleDAGInstrs] Compute topological ordering on demand..

Thanks for working on this. Here are some unscientific benchmarks from a pathological case on AMDGPU:

Wed, Apr 17, 9:24 PM · Restricted Project
tstellar added a comment to D60794: [libcxx][CMake] Add an option to include -lgcc_s in the linker script.

I don't think this is correct.

The compiler should be linking gcc unwind for us, and there should be no need for users to link it themselves.

Wed, Apr 17, 10:28 AM · Restricted Project
tstellar committed rL358599: Fix typo.
Fix typo
Wed, Apr 17, 10:10 AM
tstellar committed rL358580: Add 7.1.0 sources.
Add 7.1.0 sources
Wed, Apr 17, 7:34 AM

Tue, Apr 16

tstellar created D60794: [libcxx][CMake] Add an option to include -lgcc_s in the linker script.
Tue, Apr 16, 1:21 PM · Restricted Project
tstellar added inline comments to D60750: [libc++][CMake] Clean up logic for choosing which unwinder lib to link with tests.
Tue, Apr 16, 12:58 PM · Restricted Project

Mon, Apr 15

tstellar created D60750: [libc++][CMake] Clean up logic for choosing which unwinder lib to link with tests.
Mon, Apr 15, 9:15 PM · Restricted Project

Fri, Apr 12

tstellar created D60640: AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT.
Fri, Apr 12, 3:36 PM · Restricted Project

Tue, Apr 9

tstellar committed rG32b65345c576: Add support for detection of devtoolset-8 (authored by tstellar).
Add support for detection of devtoolset-8
Tue, Apr 9, 6:25 AM
tstellar committed rC358002: Add support for detection of devtoolset-8.
Add support for detection of devtoolset-8
Tue, Apr 9, 6:25 AM
tstellar committed rL358002: Add support for detection of devtoolset-8.
Add support for detection of devtoolset-8
Tue, Apr 9, 6:25 AM
tstellar closed D59987: Add support for detection of devtoolset-8.
Tue, Apr 9, 6:25 AM · Restricted Project, Restricted Project

Mon, Apr 8

tstellar requested changes to D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions.

Sorry didn't mean to accept the patch with my last comment.

Mon, Apr 8, 8:42 PM · Restricted Project
tstellar accepted D60434: Add a default for LLVM_CXX_STD in HandleLLVMOptions.
Mon, Apr 8, 7:43 PM · Restricted Project
tstellar added a comment to D59987: Add support for detection of devtoolset-8.

Do you have commit access?

Hi Tom, I don't think that I do. I have created the account just before submitting the patch. Should I request it, or?

Mon, Apr 8, 7:27 PM · Restricted Project, Restricted Project
tstellar committed rG206b9927f836: AMDGPU/GlobalISel: Implement call lowering for shaders returning values (authored by tstellar).
AMDGPU/GlobalISel: Implement call lowering for shaders returning values
Mon, Apr 8, 7:25 PM
tstellar committed rL357964: AMDGPU/GlobalISel: Implement call lowering for shaders returning values.
AMDGPU/GlobalISel: Implement call lowering for shaders returning values
Mon, Apr 8, 7:24 PM
tstellar closed D57166: AMDGPU/GlobalISel: Implement call lowering for shaders returning values.
Mon, Apr 8, 7:24 PM · Restricted Project

Fri, Apr 5

tstellar added a comment to D54439: CMake: Make most target symbols hidden by default.

Looks good to me.

Are there any buildbots that will catch if someone forgets to put an LLVM_EXTERNAL_VISIBILITY somewhere that's needed?

Fri, Apr 5, 4:02 PM · Restricted Project

Wed, Apr 3

tstellar added a comment to D54439: CMake: Make most target symbols hidden by default.

Ping.

Wed, Apr 3, 8:49 PM · Restricted Project
tstellar added a comment to D59987: Add support for detection of devtoolset-8.

Do you have commit access?

Wed, Apr 3, 8:43 PM · Restricted Project, Restricted Project
tstellar added inline comments to D57166: AMDGPU/GlobalISel: Implement call lowering for shaders returning values.
Wed, Apr 3, 8:43 PM · Restricted Project
tstellar updated the diff for D57166: AMDGPU/GlobalISel: Implement call lowering for shaders returning values.

Address review comments.

Wed, Apr 3, 8:39 PM · Restricted Project
tstellar updated the diff for D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD.

Clean up test

Wed, Apr 3, 7:34 PM · Restricted Project
tstellar added inline comments to D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD.
Wed, Apr 3, 7:34 PM · Restricted Project

Tue, Apr 2

tstellar accepted D60149: AMDGPU: Consolidate some getGeneration checks.

LGTM.

Tue, Apr 2, 2:15 PM

Fri, Mar 29

tstellar accepted D59987: Add support for detection of devtoolset-8.

LGTM.

Fri, Mar 29, 6:24 AM · Restricted Project, Restricted Project

Thu, Mar 28

tstellar committed rG25895ad2836e: Merging r356924: (authored by tstellar).
Merging r356924:
Thu, Mar 28, 8:36 PM
tstellar committed rL357234: Merging r356924:.
Merging r356924:
Thu, Mar 28, 8:36 PM

Mon, Mar 25

tstellar committed rG2224181dad5a: merge-request.sh: Update 8.0 metabug for 8.0.1 (authored by tstellar).
merge-request.sh: Update 8.0 metabug for 8.0.1
Mon, Mar 25, 10:00 AM
tstellar committed rL356924: merge-request.sh: Update 8.0 metabug for 8.0.1.
merge-request.sh: Update 8.0 metabug for 8.0.1
Mon, Mar 25, 10:00 AM

Thu, Mar 21

tstellar updated the summary of D54439: CMake: Make most target symbols hidden by default.
Thu, Mar 21, 3:13 PM · Restricted Project
tstellar updated the diff for D54439: CMake: Make most target symbols hidden by default.

Rename macro from LLVM_EXPORT to LLVM_EXTERNAL_VISIBILITY and add documentation
for macro.

Thu, Mar 21, 3:10 PM · Restricted Project
tstellar committed rGbf2f5abb8e3c: git-llvm: Update for release_80 branch (authored by tstellar).
git-llvm: Update for release_80 branch
Thu, Mar 21, 1:50 PM
tstellar committed rL356714: git-llvm: Update for release_80 branch.
git-llvm: Update for release_80 branch
Thu, Mar 21, 1:44 PM
tstellar committed rGdb4cf6bdbf2a: Bump version to 8.0.1 (authored by tstellar).
Bump version to 8.0.1
Thu, Mar 21, 1:32 PM
tstellar committed rL356708: Bump version to 8.0.1.
Bump version to 8.0.1
Thu, Mar 21, 1:32 PM

Mar 18 2019

tstellar committed rG336e58cb58e3: Merge remote-tracking branch 'origin/master' into merge-8.x (authored by tstellar).
Merge remote-tracking branch 'origin/master' into merge-8.x
Mar 18 2019, 1:27 PM

Mar 6 2019

tstellar added a comment to D58420: docs/GithubMove.rst: Remove obsolete information.

PIng. Does anyone else want to take a look at this?

Mar 6 2019, 11:18 AM · Restricted Project

Mar 1 2019

tstellar committed rG4f076000c608: lib/Header: Simplify CMakeLists.txt (authored by tstellar).
lib/Header: Simplify CMakeLists.txt
Mar 1 2019, 4:50 PM
tstellar committed rC355253: lib/Header: Simplify CMakeLists.txt.
lib/Header: Simplify CMakeLists.txt
Mar 1 2019, 4:50 PM
tstellar committed rL355253: lib/Header: Simplify CMakeLists.txt.
lib/Header: Simplify CMakeLists.txt
Mar 1 2019, 4:50 PM
tstellar closed D58537: lib/Header: Simplify CMakeLists.txt.
Mar 1 2019, 4:49 PM · Restricted Project, Restricted Project
tstellar added a comment to D58537: lib/Header: Simplify CMakeLists.txt.

@tstellar are you planning to land this soon? It'll conflict with D58791, but I'm not planning to land that for another few days, so I can rebase on top of this one.

Mar 1 2019, 1:27 PM · Restricted Project, Restricted Project
tstellar added a comment to D58791: [build] Rename clang-headers to clang-resource-headers.

This looks good, but could you also add an entry in the ReleaseNotes for this.

Mar 1 2019, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 28 2019

tstellar created D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD.
Feb 28 2019, 5:31 PM · Restricted Project
tstellar committed rG33634d1b2585: AMDGPU/GlobalISel: Implement select for G_INSERT (authored by tstellar).
AMDGPU/GlobalISel: Implement select for G_INSERT
Feb 28 2019, 4:51 PM
tstellar committed rL355159: AMDGPU/GlobalISel: Implement select for G_INSERT.
AMDGPU/GlobalISel: Implement select for G_INSERT
Feb 28 2019, 4:49 PM
tstellar committed rG41f32196a0b3: AMDGPU/GlobalISel: Implement select for G_EXTRACT (authored by tstellar).
AMDGPU/GlobalISel: Implement select for G_EXTRACT
Feb 28 2019, 3:38 PM
tstellar committed rL355156: AMDGPU/GlobalISel: Implement select for G_EXTRACT.
AMDGPU/GlobalISel: Implement select for G_EXTRACT
Feb 28 2019, 3:37 PM
tstellar closed D49714: AMDGPU/GlobalISel: Implement select for G_EXTRACT.
Feb 28 2019, 3:37 PM · Restricted Project
tstellar committed rGd20073f47b14: llvm-config: Include -stdlib= in --cxxflags (authored by tstellar).
llvm-config: Include -stdlib= in --cxxflags
Feb 28 2019, 9:32 AM
tstellar committed rL355107: llvm-config: Include -stdlib= in --cxxflags.
llvm-config: Include -stdlib= in --cxxflags
Feb 28 2019, 9:32 AM
tstellar closed D57859: llvm-config: Include -stdlib= in --cxxflags.
Feb 28 2019, 9:32 AM · Restricted Project
tstellar updated the diff for D58537: lib/Header: Simplify CMakeLists.txt.

Fix an issue with the generated arm headers that I discovered after
doing some more testing. Also, remove comment.

Feb 28 2019, 9:04 AM · Restricted Project, Restricted Project

Feb 27 2019

tstellar added a comment to D58619: [NFC][cmake] Build fix in tools/llvm-config/CMakeLists.txt.

Has this change been tested with newer older versions of cmake too? Was there a release note from CMake that announced the deprecation of this kind of escape sequence?

Feb 27 2019, 6:39 AM · Restricted Project

Feb 26 2019

tstellar added a comment to D58537: lib/Header: Simplify CMakeLists.txt.

Use macros instead of functions.

Feb 26 2019, 9:33 PM · Restricted Project, Restricted Project
tstellar updated the diff for D58537: lib/Header: Simplify CMakeLists.txt.

Use macros instead of functions.

Feb 26 2019, 9:32 PM · Restricted Project, Restricted Project

Feb 21 2019

tstellar abandoned D29342: TableGen: Add support for intrinsic patterns with vAny.
Feb 21 2019, 6:48 PM
tstellar commandeered D29342: TableGen: Add support for intrinsic patterns with vAny.
Feb 21 2019, 6:47 PM
tstellar added a comment to D29342: TableGen: Add support for intrinsic patterns with vAny.

Do we still need this"

Feb 21 2019, 6:47 PM
tstellar created D58537: lib/Header: Simplify CMakeLists.txt.
Feb 21 2019, 6:39 PM · Restricted Project, Restricted Project

Feb 20 2019

tstellar committed rG79b5c3842b68: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen (authored by tstellar).
AMDGPU/GlobalISel: Move SMRD selection logic to TableGen
Feb 20 2019, 1:03 PM
tstellar committed rL354516: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.
AMDGPU/GlobalISel: Move SMRD selection logic to TableGen
Feb 20 2019, 1:02 PM
tstellar closed D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.
Feb 20 2019, 1:02 PM · Restricted Project
tstellar committed rG9ad714f7d1a9: Add support for pointer types in patterns (authored by tstellar).
Add support for pointer types in patterns
Feb 20 2019, 11:44 AM
tstellar committed rL354510: Add support for pointer types in patterns.
Add support for pointer types in patterns
Feb 20 2019, 11:43 AM
tstellar closed D57065: [TableGen][GlobalISel] Add support for pointer types in patterns.
Feb 20 2019, 11:43 AM · Restricted Project
tstellar committed rG13f45590e349: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir (authored by tstellar).
AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
Feb 20 2019, 10:44 AM
tstellar committed rL354497: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir
Feb 20 2019, 10:43 AM
tstellar closed D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
Feb 20 2019, 10:43 AM · Restricted Project

Feb 19 2019

tstellar committed rG20332cc4ea69: ELF: Fix typo in --build-id option description (authored by tstellar).
ELF: Fix typo in --build-id option description
Feb 19 2019, 5:41 PM
tstellar committed rLLD354422: ELF: Fix typo in --build-id option description.
ELF: Fix typo in --build-id option description
Feb 19 2019, 5:40 PM
tstellar committed rL354422: ELF: Fix typo in --build-id option description.
ELF: Fix typo in --build-id option description
Feb 19 2019, 5:40 PM
tstellar closed D58265: ELF: Fix typo in --build-id option description.
Feb 19 2019, 5:40 PM · Restricted Project
tstellar created D58420: docs/GithubMove.rst: Remove obsolete information.
Feb 19 2019, 5:19 PM · Restricted Project
tstellar committed rGb8a9fcc602a0: CMake: Fix stand-alone clang builds since r353268 (authored by tstellar).
CMake: Fix stand-alone clang builds since r353268
Feb 19 2019, 5:11 PM
tstellar committed rC354417: CMake: Fix stand-alone clang builds since r353268.
CMake: Fix stand-alone clang builds since r353268
Feb 19 2019, 5:11 PM
tstellar committed rL354417: CMake: Fix stand-alone clang builds since r353268.
CMake: Fix stand-alone clang builds since r353268
Feb 19 2019, 5:11 PM
tstellar closed D58204: CMake: Fix stand-alone clang builds since r353268.
Feb 19 2019, 5:11 PM · Restricted Project, Restricted Project
Herald added a project to D54880: Ignore gcc's stack-clash-protection flag: Restricted Project.

See D42593, I don't think it's good to ignore security flags like this.

Feb 19 2019, 2:24 PM · Restricted Project
tstellar abandoned D42593: GCC compatibility: Ignore -fstack-clash-protection.

I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check).

Feb 19 2019, 2:24 PM · Restricted Project

Feb 14 2019

tstellar created D58265: ELF: Fix typo in --build-id option description.
Feb 14 2019, 5:08 PM · Restricted Project

Feb 13 2019

tstellar added a comment to D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.

Example of test failure: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-f29-pr-pipeline/51/artifact/package-tests/logs/FAIL_str_regression-tests.log

Feb 13 2019, 4:30 PM · Restricted Project
tstellar created D58217: AArch64/test: Add check for function name to machine-outliner-bad-adrp.mir.
Feb 13 2019, 4:29 PM · Restricted Project
tstellar accepted D56881: AMDGPU/GlobalISel: Handle split for 64-bit VALU select.

LGTM.

Feb 13 2019, 4:24 PM
tstellar accepted D57293: AMDGPU/GlobalISel: Fix RegBankSelect for GEP..

LGTM.

Feb 13 2019, 4:24 PM
tstellar updated the diff for D58204: CMake: Fix stand-alone clang builds since r353268.

Updated patch to fix non-standalone builds. There is more refactoring
that could be done, but this at least restores functionality to before
r353268.

Feb 13 2019, 4:14 PM · Restricted Project, Restricted Project
tstellar added inline comments to D58204: CMake: Fix stand-alone clang builds since r353268.
Feb 13 2019, 1:28 PM · Restricted Project, Restricted Project
tstellar created D58204: CMake: Fix stand-alone clang builds since r353268.
Feb 13 2019, 1:11 PM · Restricted Project, Restricted Project

Feb 12 2019

tstellar added inline comments to D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS.
Feb 12 2019, 1:50 PM · Restricted Project, Restricted Project
tstellar added a reviewer for D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS: tstellar.
Feb 12 2019, 1:36 PM · Restricted Project, Restricted Project

Feb 8 2019

tstellar added inline comments to D57930: [Driver] Verify GCCInstallation is valid.
Feb 8 2019, 6:52 PM · Restricted Project
tstellar committed rG4856a9330ee0: cmake: Use 7.1.0 for shared object version instead of 71.0 (authored by tstellar).
cmake: Use 7.1.0 for shared object version instead of 71.0
Feb 8 2019, 1:03 PM
tstellar committed rL353565: cmake: Use 7.1.0 for shared object version instead of 71.0.
cmake: Use 7.1.0 for shared object version instead of 71.0
Feb 8 2019, 1:02 PM
tstellar updated the diff for D49714: AMDGPU/GlobalISel: Implement select for G_EXTRACT.

Address comments.

Feb 8 2019, 12:18 PM · Restricted Project
tstellar accepted D57074: AMDGPU/GlobalISel: Fix shift legalization for non-power-of-2.

LGTM.

Feb 8 2019, 6:48 AM

Feb 7 2019

tstellar accepted D57885: AMDGPU: Remove GCN features and predicates.

LGTM.

Feb 7 2019, 3:46 PM
tstellar accepted D57683: AMDGPU/GlobalISel: Restrict g_implicit_def legality.

LGTM.

Feb 7 2019, 9:48 AM
tstellar accepted D57034: AMDGPU/GlobalISel: Legalize some f16 operations.

LGTM.

Feb 7 2019, 9:47 AM