tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (70 w, 4 d)

Recent Activity

Thu, Jun 14

tstellar committed rL334789: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:27 PM
tstellar committed rL334795: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:24 PM
tstellar committed rL334798: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:22 PM
tstellar committed rL334787: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:22 PM
tstellar committed rL334797: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:22 PM
tstellar committed rL334796: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:21 PM
tstellar committed rL334793: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:20 PM
tstellar committed rL334792: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:20 PM
tstellar committed rL334788: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:19 PM
tstellar committed rL334791: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:19 PM
tstellar committed rL334790: Creating release candidate rc3 from release_601 branch.
Creating release candidate rc3 from release_601 branch
Thu, Jun 14, 10:16 PM
tstellar committed rL334776: Merging r333213:.
Merging r333213:
Thu, Jun 14, 3:38 PM
tstellar created D48198: AMDGPU/GlobalISel: Default to using TableGen'd instruction selector.
Thu, Jun 14, 2:28 PM
tstellar updated the diff for D46172: AMDGPU/GlobalISel: Implement select() for 32-bit @llvm.minnun and @llvm.maxnum.

Add f64 patterns

Thu, Jun 14, 2:24 PM
tstellar created D48196: AMDGPU/GlobalISel: legalize and select 32-bit G_ASHR.
Thu, Jun 14, 1:59 PM
tstellar created D48195: AMDGPU/GlobalISel: legalize and select 32-bit G_SITOFP.
Thu, Jun 14, 1:35 PM
tstellar committed rL334757: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.cvt.pkrtz.
AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.cvt.pkrtz
Thu, Jun 14, 12:31 PM
tstellar closed D45907: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.cvt.pkrtz.
Thu, Jun 14, 12:30 PM
tstellar added a comment to D46365: AMDGPU: Separate R600 and GCN TableGen files.

I've tried the updated version of the patch, although it did not apply cleanly. It also causes GPU hangs on my turks in piglit tests.

Thu, Jun 14, 8:17 AM

Wed, Jun 13

tstellar added a comment to D45907: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.cvt.pkrtz.

Ping.

Wed, Jun 13, 9:40 PM
tstellar added a comment to D46150: AMDGPU/GlobalISel: Implement select() for G_IMPLICIT_DEF.

Is the default implementation really unable to do this? That seems a bit silly...

Wed, Jun 13, 8:33 PM
tstellar updated the diff for D46150: AMDGPU/GlobalISel: Implement select() for G_IMPLICIT_DEF.

We also need to constrain the register class when we select G_IMPLICIT_DEF.

Wed, Jun 13, 8:31 PM
tstellar updated the diff for D46365: AMDGPU: Separate R600 and GCN TableGen files.

Rebase patch on latest ToT.

Wed, Jun 13, 4:05 PM
tstellar committed rL334665: AMDGPU/GlobalISel: Implement select() for 32-bit G_FADD and G_FMUL.
AMDGPU/GlobalISel: Implement select() for 32-bit G_FADD and G_FMUL
Wed, Jun 13, 3:35 PM
tstellar closed D46171: AMDGPU/GlobalISel: Implement select() for 32-bit G_FADD and G_FMUL.
Wed, Jun 13, 3:35 PM
tstellar committed rL334621: Merging r323390:.
Merging r323390:
Wed, Jun 13, 10:01 AM
tstellar committed rL334607: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.
AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering
Wed, Jun 13, 8:13 AM
tstellar closed D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.
Wed, Jun 13, 8:13 AM

Tue, Jun 12

tstellar committed rL334568: utils/release: Add merge-git.sh.
utils/release: Add merge-git.sh
Tue, Jun 12, 10:18 PM
tstellar closed D47760: utils/release: Add merge-git.sh.
Tue, Jun 12, 10:18 PM

Mon, Jun 11

tstellar retitled D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering from AMDGPU: Remove deadcode in isSDNodeSourceOfDivergence() to AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.
Mon, Jun 11, 9:44 PM
tstellar updated the diff for D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.

Move isSDNodeSourceOfDivergence() implementation from AMDGPUTargetLowering
to SITargetLowering.

Mon, Jun 11, 9:42 PM
tstellar committed rL334464: Merging r326394:.
Merging r326394:
Mon, Jun 11, 6:43 PM
tstellar added a comment to D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.

Ping.

Mon, Jun 11, 12:14 PM

Thu, Jun 7

tstellar committed rL334230: Put documentation links before binaries for 5.0.2 to match other releases.
Put documentation links before binaries for 5.0.2 to match other releases
Thu, Jun 7, 1:39 PM
tstellar committed rL334229: Add gpg key for 5.0.2.
Add gpg key for 5.0.2
Thu, Jun 7, 1:37 PM

Wed, Jun 6

tstellar updated the diff for D47760: utils/release: Add merge-git.sh.

Remove unused options and document how to use the script.

Wed, Jun 6, 8:38 PM

Mon, Jun 4

tstellar created D47760: utils/release: Add merge-git.sh.
Mon, Jun 4, 9:45 PM
tstellar updated the diff for D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.

Completely disable isSDNodeSourceOfDivergence() for r600.

Mon, Jun 4, 9:52 AM
tstellar committed rL333913: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:10 AM
tstellar committed rL333911: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:08 AM
tstellar committed rL333919: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:08 AM
tstellar committed rL333922: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:07 AM
tstellar committed rL333921: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:07 AM
tstellar committed rL333920: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:07 AM
tstellar committed rL333912: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:05 AM
tstellar committed rL333917: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:04 AM
tstellar committed rL333916: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:03 AM
tstellar committed rL333915: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:03 AM
tstellar committed rL333914: Creating release candidate rc2 from release_601 branch.
Creating release candidate rc2 from release_601 branch
Mon, Jun 4, 9:00 AM
tstellar committed rL333910: Merging r333467:.
Merging r333467:
Mon, Jun 4, 8:53 AM

Thu, May 31

tstellar committed rL333720: AMDGPU/R600: Move intrinsics to IntrinsicsAMDGPU.td.
AMDGPU/R600: Move intrinsics to IntrinsicsAMDGPU.td
Thu, May 31, 7:23 PM
tstellar closed D47487: AMDGPU/R600: Move intrinsics to IntrinsicsAMDGPU.td.
Thu, May 31, 7:23 PM
tstellar updated the diff for D46365: AMDGPU: Separate R600 and GCN TableGen files.

Rebase patch after splitting some of the changes requested
into separate patches.

Thu, May 31, 11:56 AM
tstellar added inline comments to D46365: AMDGPU: Separate R600 and GCN TableGen files.
Thu, May 31, 11:55 AM

Wed, May 30

tstellar committed rL333623: Merging r322030:.
Merging r322030:
Wed, May 30, 9:19 PM
tstellar added a comment to D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.

I agree isVGPR should be illegal to call for R600

So, how would you handle the bunch of r600 tests then?
We could claim the support of DA related stuff for GCN only but it should be explicitly agreed and documented somehow.

Disable this for r600. It doesn't have the SGPR/VGPR split issue we want this for, so it doesn't really matter

Wed, May 30, 4:01 PM
tstellar committed rL333605: AMDGPU: Split AMDGPUTTI into GCNTTI and R600TTI.
AMDGPU: Split AMDGPUTTI into GCNTTI and R600TTI
Wed, May 30, 3:59 PM
tstellar closed D47359: AMDGPU: Split AMDGPUTTI into GCNTTI and R600TTI.
Wed, May 30, 3:59 PM
tstellar committed rL333579: Merging r326358:.
Merging r326358:
Wed, May 30, 12:08 PM
tstellar committed rL333577: Merging r328798:.
Merging r328798:
Wed, May 30, 11:54 AM
tstellar committed rL333575: Merging r333497:.
Merging r333497:
Wed, May 30, 11:40 AM
tstellar committed rL333571: Merging r326476:.
Merging r326476:
Wed, May 30, 11:24 AM
tstellar committed rL333569: Merging r326173:.
Merging r326173:
Wed, May 30, 11:10 AM
tstellar committed rL333566: Merging r326235:.
Merging r326235:
Wed, May 30, 11:00 AM
tstellar committed rL333564: Merging r329300:.
Merging r329300:
Wed, May 30, 10:37 AM
tstellar committed rL333561: Merging r330345:.
Merging r330345:
Wed, May 30, 9:56 AM

Tue, May 29

tstellar committed rL333511: Merging r330331:.
Merging r330331:
Tue, May 29, 11:06 PM
tstellar committed rL333507: Merging r327863:.
Merging r327863:
Tue, May 29, 10:26 PM
tstellar committed rL333477: Merging r332302:.
Merging r332302:
Tue, May 29, 4:20 PM
tstellar committed rL333475: Merging r328885:.
Merging r328885:
Tue, May 29, 4:07 PM
tstellar committed rL333474: Merging r328884:.
Merging r328884:
Tue, May 29, 3:59 PM
tstellar committed rL333470: Merging r332682 and r332694:.
Merging r332682 and r332694:
Tue, May 29, 3:43 PM
tstellar committed rL333469: Merging r332680:.
Merging r332680:
Tue, May 29, 3:43 PM
tstellar committed rL333439: AMDGPU: Split R600 MCInst lowering into its own class.
AMDGPU: Split R600 MCInst lowering into its own class
Tue, May 29, 10:46 AM
tstellar closed D47307: AMDGPU: Split R600 MCInst lowering into its own class.
Tue, May 29, 10:46 AM
tstellar created D47487: AMDGPU/R600: Move intrinsics to IntrinsicsAMDGPU.td.
Tue, May 29, 10:33 AM

Fri, May 25

tstellar updated the diff for D47359: AMDGPU: Split AMDGPUTTI into GCNTTI and R600TTI.

Move getTargetTransforInfo to TargetMachine sub-classes.

Fri, May 25, 6:50 PM

Thu, May 24

tstellar created D47359: AMDGPU: Split AMDGPUTTI into GCNTTI and R600TTI.
Thu, May 24, 10:37 PM
tstellar committed rL333254: AMDGPU: Remove AMDGPUMCInstLower.h.
AMDGPU: Remove AMDGPUMCInstLower.h
Thu, May 24, 10:01 PM
tstellar closed D47264: AMDGPU: Remove AMDGPUMCInstLower.h.
Thu, May 24, 10:01 PM
tstellar committed rL333219: AMDGPU: Split R600 AsmPrinter code into its own class.
AMDGPU: Split R600 AsmPrinter code into its own class
Thu, May 24, 1:08 PM
tstellar closed D47245: AMDGPU: Split R600 AsmPrinter code into its own class.
Thu, May 24, 1:08 PM

Wed, May 23

tstellar committed rL333153: AMDGPU/R600: Remove code for handling AMDGPUISD::CLAMP.
AMDGPU/R600: Remove code for handling AMDGPUISD::CLAMP
Wed, May 23, 10:32 PM
tstellar closed D47181: AMDGPU/R600: Remove code for handling AMDGPUISD::CLAMP.
Wed, May 23, 10:32 PM
tstellar updated the diff for D46365: AMDGPU: Separate R600 and GCN TableGen files.

Removed unused Processors.td file and made all AMDGPUCommonSubtarget
functions non-virtual.

Wed, May 23, 8:52 PM
tstellar created D47307: AMDGPU: Split R600 MCInst lowering into its own class.
Wed, May 23, 8:50 PM
tstellar added a comment to D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.

Could you please clarify - why do you consider that check meaningless for r600?
I see that this line : " const SISubtarget &ST = MF->getSubtarget<SISubtarget>(); " is misleading and in fact is not correct.
I'd better check and choose the R600Subtarget or SISubtarget.
If I understand right we need just check which subtarget to retrieve for physregs check.

Since we consider any VGPR formal argument as divergent it does not matter R600 or SI at all.
We need to choose right TargetRegisterInfo (r600 or SI again)

So, for virtual register : if (MRI.isLiveIn(Reg) && TRI.isVGPR(Reg) ) return true

Or I maybe don't know something substantial? :)

Wed, May 23, 8:39 PM
tstellar created D47264: AMDGPU: Remove AMDGPUMCInstLower.h.
Wed, May 23, 8:41 AM

Tue, May 22

tstellar created D47245: AMDGPU: Split R600 AsmPrinter code into its own class.
Tue, May 22, 9:37 PM
tstellar committed rL333016: AMDGPU: Move AMDGPUTargetLowering::isFPExtFoldable() into SITargetLowering.
AMDGPU: Move AMDGPUTargetLowering::isFPExtFoldable() into SITargetLowering
Tue, May 22, 12:42 PM
tstellar closed D47180: AMDGPU: Move AMDGPUTargetLowering::isFPExtFoldable() into SITargetLowering.
Tue, May 22, 12:42 PM

Mon, May 21

tstellar created D47181: AMDGPU/R600: Remove code for handling AMDGPUISD::CLAMP.
Mon, May 21, 10:56 PM
tstellar created D47180: AMDGPU: Move AMDGPUTargetLowering::isFPExtFoldable() into SITargetLowering.
Mon, May 21, 10:55 PM
tstellar committed rL332930: AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers.
AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers
Mon, May 21, 7:07 PM
tstellar closed D46272: AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers.
Mon, May 21, 7:07 PM
tstellar committed rL332856: AMDGPU/GlobalISel: Address post-commit review comments for r332379.
AMDGPU/GlobalISel: Address post-commit review comments for r332379
Mon, May 21, 10:53 AM

May 18 2018

tstellar committed rL332782: Merging r330037:.
Merging r330037:
May 18 2018, 4:28 PM
tstellar committed rL332778: Merging r329268:.
Merging r329268:
May 18 2018, 3:11 PM
tstellar committed rL332776: Merging r324885:.
Merging r324885:
May 18 2018, 3:02 PM