Page MenuHomePhabricator

tstellar (Tom Stellard)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (276 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

tstellar added inline comments to D126506: workflows: Use new custom runners from github.
Fri, May 27, 4:39 PM · Restricted Project, Restricted Project

Thu, May 26

tstellar accepted D123657: [workflow] Don't fail workflow if we already have a PR for an issue.

Sorry for the delay, I though this was merged already. LGTM.

Thu, May 26, 10:43 PM · Restricted Project, Restricted Project
tstellar added a comment to D125499: Enabling the detection of devtoolset-11 toolchain..

I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../

Thu, May 26, 9:38 PM · Restricted Project, Restricted Project
tstellar requested review of D126506: workflows: Use new custom runners from github.
Thu, May 26, 4:16 PM · Restricted Project, Restricted Project

Wed, May 25

tstellar requested review of D126423: github: Automatically assign reviewers for backport requests.
Wed, May 25, 2:15 PM · Restricted Project, Restricted Project
tstellar added inline comments to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.
Wed, May 25, 12:20 PM · Restricted Project, Restricted Project
tstellar added a comment to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.

This

Wed, May 25, 11:52 AM · Restricted Project, Restricted Project

Mon, May 23

tstellar committed rG21c060c497fd: github: Switch release PR repository to llvm/llvm-project-release-prs (authored by tstellar).
github: Switch release PR repository to llvm/llvm-project-release-prs
Mon, May 23, 3:11 PM · Restricted Project, Restricted Project
tstellar closed D125851: github: Switch release PR repository to llvm/llvm-project-release-prs.
Mon, May 23, 3:10 PM · Restricted Project, Restricted Project
tstellar added inline comments to D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs.
Mon, May 23, 9:09 AM · Restricted Project, Restricted Project

Thu, May 19

tstellar updated the diff for D116995: [gold] Ignore bitcode from sections inside object files.

Updated documentation in BitCodeFormat.rst.

Thu, May 19, 4:17 PM · Restricted Project, Restricted Project
tstellar added a comment to D116995: [gold] Ignore bitcode from sections inside object files.

@tejohnson Are you OK with this change?

Thu, May 19, 10:18 AM · Restricted Project, Restricted Project
tstellar updated the diff for D116995: [gold] Ignore bitcode from sections inside object files.

Update comments and documentation.

Thu, May 19, 10:16 AM · Restricted Project, Restricted Project

Wed, May 18

tstellar accepted D125798: [release] Add cmake as an extra tarball and not bundle it.
Wed, May 18, 9:10 PM · Restricted Project, Restricted Project

Tue, May 17

tstellar requested review of D125851: github: Switch release PR repository to llvm/llvm-project-release-prs.
Tue, May 17, 10:27 PM · Restricted Project, Restricted Project
tstellar updated the diff for D116995: [gold] Ignore bitcode from sections inside object files.

Add documentation about the change.

Tue, May 17, 1:45 PM · Restricted Project, Restricted Project
tstellar added a reviewer for D116995: [gold] Ignore bitcode from sections inside object files: MaskRay.
Tue, May 17, 1:34 PM · Restricted Project, Restricted Project
tstellar abandoned D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.
Tue, May 17, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
tstellar closed D124539: workflows: Add a test to ensure that the LLVM version is correct.
Tue, May 17, 1:18 PM · Restricted Project, Restricted Project
tstellar added a comment to D124539: workflows: Add a test to ensure that the LLVM version is correct.

This was committed to the release/14.x branch: 2e7e14177186dc417a49dbf88493dabde0572e22

Tue, May 17, 1:18 PM · Restricted Project, Restricted Project
tstellar added inline comments to D125499: Enabling the detection of devtoolset-11 toolchain..
Tue, May 17, 8:14 AM · Restricted Project, Restricted Project

Mon, May 16

tstellar requested review of D125744: github: Add a helpful message for issues without milestones.
Mon, May 16, 10:32 PM · Restricted Project, Restricted Project

Thu, May 12

tstellar added inline comments to D125499: Enabling the detection of devtoolset-11 toolchain..
Thu, May 12, 4:50 PM · Restricted Project, Restricted Project

Wed, May 11

tstellar accepted D125005: Make standalone-build-x86_64 a standalone builder.
Wed, May 11, 9:08 AM · Restricted Project

Tue, May 10

tstellar added a comment to D125165: [Clang] Introduce clang-offload-packager tool to bundle device files.

LGTM in principle.

Given that we're introducing a new tool dependency we may want to get a stamp from someone dealing with build and release.
@tstellar -- do we need to change anything else for the new binary to ship with clang releases?

Tue, May 10, 1:06 PM · Restricted Project, Restricted Project

Mon, May 9

tstellar accepted D125197: [github] format and refactor GitHub workflows.

This looks OK to me.

Mon, May 9, 5:05 PM · Restricted Project, Restricted Project
tstellar added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:20 PM · Restricted Project
tstellar added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:15 PM · Restricted Project
tstellar added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:03 PM · Restricted Project
tstellar added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 9:30 AM · Restricted Project

Thu, Apr 28

Herald added a project to D116995: [gold] Ignore bitcode from sections inside object files: Restricted Project.

@jyknight You commented here that -fembed-bitcode was not intended for LTO, but the llvm documentation says the .llvmbc section is useful for LTO. Do you have any more background on the history of the .llvmbc section and do you think the gold plugin should try to use it for LTO?

Thu, Apr 28, 7:30 PM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

With this I suggest we should go ahead and:

  • Improve documentation - Please help out in the review posted above.
  • Make omitting CMAKE_BUILD_TYPE an error and link to the improved documentation.

This seems like a good compromise +1.

Thu, Apr 28, 5:38 PM · Restricted Project, Restricted Project
tstellar added a comment to D124539: workflows: Add a test to ensure that the LLVM version is correct.

I think this is fine. But I wonder if we should split out the version into a separate file that can be easier to parse and so we don't have to edit the version in several different places. In my last job we usually had a single VERSION file in the root that we read from CMake and all other places that needed the current version.

Thu, Apr 28, 5:06 PM · Restricted Project, Restricted Project
tstellar added a comment to D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

I think for now what I'll do for now is just update D124405 to list libunwind as a required sub-directory for lld stand-alone builds. This will get me unblocked and make it possible to set up the CI.

Thu, Apr 28, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

tstellar added a comment to D123897: [X86] Unbreak LIT/FileCheck.

@lebedev.ri are you still working on this or should someone else commandeer the revision?

Apr 27 2022, 2:02 PM · Restricted Project, Restricted Project
tstellar requested review of D124539: workflows: Add a test to ensure that the LLVM version is correct.
Apr 27 2022, 10:33 AM · Restricted Project, Restricted Project

Apr 25 2022

tstellar added a comment to D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

@int3 @MaskRay The kind of stand-alone builds we are trying to support are documented here: D123968

Apr 25 2022, 11:10 AM · Restricted Project, Restricted Project, Restricted Project
tstellar requested review of D124405: docs: add instructions for stand-alone builds of lld.
Apr 25 2022, 10:04 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

One thing we all seem to agree on is that documentation could be better - so I took a stab at that here - I think it's connected to this discussion, but I don't think it's the only fix, please see the doc suggestions here: https://reviews.llvm.org/D124367

I am currently leaning towards:

  • Improve documentation
  • Make omitting CMAKE_BUILD_TYPE a error. I am also fine with changing it to Release, but I don't have a strong opinion either way. I do think keeping Debug is worse than both options. But it can be made better by point 3 here:
Apr 25 2022, 8:50 AM · Restricted Project, Restricted Project

Apr 22 2022

tstellar committed rW3ada3b5fedef: Fix 14.0.x release schedule formatting (authored by tstellar).
Fix 14.0.x release schedule formatting
Apr 22 2022, 10:37 PM · Restricted Project
tstellar committed rWb40b359e0934: Add 14.0.x release schedule (authored by tstellar).
Add 14.0.x release schedule
Apr 22 2022, 10:27 PM · Restricted Project
tstellar added a comment to D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

To be clear, this is to support a build scenario where you only have the source tree under lld available?

Yes, that's correct.

Ah, I'd missed that part of the definition in https://discourse.llvm.org/t/rfc-stand-alone-build-support/61291. Thanks for confirming.

The duplication here is really unfortunate, especially cos the burden of keeping the copied header up-to-date will fall on non-standalone build users. On the other hand, this header hasn't seen actual (non-license) update since 2016, so I imagine it'll remain pretty stable going forward.

Apr 22 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

To be clear, this is to support a build scenario where you only have the source tree under lld available?

Apr 22 2022, 6:28 PM · Restricted Project, Restricted Project, Restricted Project
tstellar updated the diff for D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

Remove debug message.

Apr 22 2022, 6:28 PM · Restricted Project, Restricted Project, Restricted Project
tstellar requested review of D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.
Apr 22 2022, 6:00 PM · Restricted Project, Restricted Project, Restricted Project
tstellar requested review of D124314: lldb: Disable unittests if llvm_gtest target does not exist.
Apr 22 2022, 5:59 PM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

If you want a 'right' default, it has to be 'the one that most users of cmake WANT'. I posit that is 'default' or 'release with debug info + asserts', since MOST direct users of our cmake scripts are going to be developers. I'd find 'no default' to be a vast improvement over 'give me the wrong one'.

Apr 22 2022, 12:14 PM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I think we pretty much agree on everything here, except I do think build mode will actually help reduce this problem a lot.

Apr 22 2022, 11:25 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

@aaron.ballman There's some people that can't build in debug mode at all because there machine is not powerful enough. For me, this is enough to disqualify it from being the default, because it's creating a barrier of entry for new users/developers.

The same is true for making release builds; you can OOM a machine trivially when linking. To me, the barrier to entry isn't that the default build mode is wrong, it's that we've not done a good job of making our project buildable without a build farm or super computer. I think changing the default build mode to release is a bit like using a teaspoon to bail out a leaking boat; it's incrementally better than nothing, but it's really not addressing the problem or likely to make a significant difference.

Apr 22 2022, 11:18 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

We have some pieces of data though: the number of people who complain about the build filling up their disk and the link taking forever (or OOM). On the other hand the people who "know" are already setting up an explicit value...
That said I tend to think that the audience is heterogeneous enough that I agree it seems hard to make sure we "pick a default that's "right" " in the absolute (hence my proposal to not pick any).

Apr 22 2022, 11:12 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

@aaron.ballman There's some people that can't build in debug mode at all because there machine is not powerful enough. For me, this is enough to disqualify it from being the default, because it's creating a barrier of entry for new users/developers.

Apr 22 2022, 11:03 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

The target audience for the default configuration should be people who are new to the project, it could be users or it could be developers. It also could be people with very little experience programming or building from code from source. We want to keep the barrier for entry as low as possible for this group of people. We can have the best documentation or have verbose error messages to help guide them in the right direction, but the best way to communicate to new users about how to build the project is to have a sensible default configuration.

I agree with almost every point, right up until "have a sensible default configuration"; I don't think it's possible to have a default configuration that is sensible to both users and developers. Well, I take that back. I think it *is* possible, but I think we would have to invest significant effort in improving the LLVM compilation performance issues so that you don't need a super computer to build the project. My understanding is *that* is what's most off-putting to new folks, whether they're users or developers, and that's somewhat (but not entirely) orthogonal to the default build mode.

Apr 22 2022, 10:02 AM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

The target audience for the default configuration should be people who are new to the project, it could be users or it could be developers. It also could be people with very little experience programming or building from code from source. We want to keep the barrier for entry as low as possible for this group of people. We can have the best documentation or have verbose error messages to help guide them in the right direction, but the best way to communicate to new users about how to build the project is to have a sensible default configuration.

Apr 22 2022, 9:20 AM · Restricted Project, Restricted Project

Apr 21 2022

tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I disagree about erroring out when CMAKE_BUILD_TYPE is undefined. We want to make the build easy for new users, so I think it's important that the default build (cmake with no arguments) just works.

Why isn’t it easy to copy/paste one option clearly presented by the cmake invocation? That seems like a good user experience to me: there is a fairly simple choice to be made and we expose it concisely and directly, it’s not like there is an obscure error and the user needs to read a doc…
It’s not like every command line tool works without mandatory options.

Apr 21 2022, 9:01 PM · Restricted Project, Restricted Project
tstellar added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I disagree about erroring out when CMAKE_BUILD_TYPE is undefined. We want to make the build easy for new users, so I think it's important that the default build (cmake with no arguments) just works.

Apr 21 2022, 7:22 PM · Restricted Project, Restricted Project
tstellar added inline comments to D124172: Added worker and placeholder for standalone-build-x86_64 builder.
Apr 21 2022, 7:13 PM · Restricted Project

Apr 20 2022

tstellar updated the diff for D123967: Disable update_cc_test_checks.py tests in stand-alone builds.

Address review comments.

Apr 20 2022, 2:54 PM · Restricted Project, Restricted Project

Apr 18 2022

tstellar requested review of D123968: docs: Add instructions for stand-alone builds of clang.
Apr 18 2022, 4:52 PM · Restricted Project, Restricted Project
tstellar requested review of D123967: Disable update_cc_test_checks.py tests in stand-alone builds.
Apr 18 2022, 4:51 PM · Restricted Project, Restricted Project
tstellar accepted D123957: Update the developer policy to mention release notes.

LGTM.

Apr 18 2022, 4:25 PM · Restricted Project, Restricted Project
tstellar added a comment to D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1.

@tstellar I wasn't sure what the procedure was for backporting fixes, so I made a PR. I think your suggestion of keeping the old signature works well.
This also modifies the serialized AST, is that an issue for backports? (If it is, I'm not sure i see a way to move forward with this!)

Apr 18 2022, 10:48 AM · Restricted Project, Restricted Project
tstellar added a reviewer for D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1: rsmith.
Apr 18 2022, 10:46 AM · Restricted Project, Restricted Project
tstellar requested changes to D123897: [X86] Unbreak LIT/FileCheck.

I will try to be more specific:

Apr 18 2022, 9:22 AM · Restricted Project, Restricted Project
tstellar added a comment to D123897: [X86] Unbreak LIT/FileCheck.

@lebedev.ri This commit message is not appropriate. Please change it in before committing to the repo and also update this review with something else.

Apr 18 2022, 6:56 AM · Restricted Project, Restricted Project

Apr 14 2022

tstellar added a comment to D123601: [clang][AArch64] Split neon tests into 2 files.

Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather than having to go through the code and split tests every time they get too long. It sounds like the maintainers have been contacted about this, but haven't responded?

Apr 14 2022, 12:50 PM · Restricted Project, Restricted Project
tstellar added a comment to D123776: [Support] Optimize (.*) regex matches.

Is there some reason we can't use the c++11 regex library for this?

Apr 14 2022, 12:34 PM · Restricted Project, Restricted Project

Apr 13 2022

tstellar added inline comments to D123657: [workflow] Don't fail workflow if we already have a PR for an issue.
Apr 13 2022, 10:23 AM · Restricted Project, Restricted Project

Apr 12 2022

Herald added a project to D120293: [Buildbot] Updated configuration for Armv7/Aarch64 Win-x-Linux cross builders.: Restricted Project.

Hi, I think this change caused the llvm-clang-win-x-aarch64-release builder to fail. I'm seeing the following error in the logs which seems to be related to this change:

Apr 12 2022, 10:10 PM · Restricted Project
tstellar added a comment to D123601: [clang][AArch64] Split neon tests into 2 files.

Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test.

Apr 12 2022, 7:07 AM · Restricted Project, Restricted Project

Apr 11 2022

tstellar accepted D123365: workflow: When updating the issueXX branch, use force push.

This looks good, thank you.

Apr 11 2022, 3:05 PM · Restricted Project, Restricted Project

Apr 6 2022

tstellar added a comment to D121838: Generalize "check-all" umbrella targets, use for check-clang-tools.

Can you elaborate more on the problem this is solving? Also, what are the user visible changes? Will check-all and check-clang run the same set of tests as before?

Apr 6 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D122372: [lld][COFF] Fix TypeServerSource lookup on GUID collisions.

@aganea I think it's OK to land D123185 and then backport both patches.

Apr 6 2022, 7:03 AM · Restricted Project, Restricted Project

Apr 4 2022

tstellar closed D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86.

@mstorsjo Ok, so is this patch no longer needed?

Indeed, this one was superseded by D109493, so this one can be closed.

Apr 4 2022, 7:14 AM · Restricted Project, Restricted Project

Apr 1 2022

tstellar added a comment to D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86.

@mstorsjo Ok, so is this patch no longer needed?

Apr 1 2022, 4:10 PM · Restricted Project, Restricted Project
Herald added a project to D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86: Restricted Project.

Why is i686-pc-windows-msvc is correct triple?

Apr 1 2022, 3:01 PM · Restricted Project, Restricted Project

Mar 30 2022

tstellar added a reverting change for rG815a1207bfe1: [ELF] Remove ignored options that likely nobody uses: D122784: Add back ignored option --no-add-needed.
Mar 30 2022, 11:57 PM
tstellar requested review of D122784: Add back ignored option --no-add-needed.
Mar 30 2022, 11:56 PM · Restricted Project, Restricted Project
tstellar accepted D122146: [test-release] Added -silent-log flag to test-release.sh.

LGTM.

Mar 30 2022, 9:25 AM · Restricted Project, Restricted Project
tstellar updated the diff for D120872: workflows: Consolidate tests to reduce the number of build jobs.

Reference correct repository for the workflow definitions.

Mar 30 2022, 9:17 AM · Restricted Project, Restricted Project
tstellar added inline comments to D120872: workflows: Consolidate tests to reduce the number of build jobs.
Mar 30 2022, 9:11 AM · Restricted Project, Restricted Project

Mar 29 2022

tstellar added reviewers for D122686: [InstCombine] Fold calls to strnlen (PR46455): jdoerfert, nikic.
Mar 29 2022, 3:14 PM · Restricted Project, Restricted Project

Mar 28 2022

tstellar added a reviewer for D120454: clang/www: Add links to tracking issues for C++20 features: erichkeane.
Mar 28 2022, 7:04 AM · Restricted Project, Restricted Project

Mar 25 2022

tstellar accepted D122487: [ARM] Make testcase warning pattern match more specific.
In D122487#3408425, @rs wrote:

@tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again.

Mar 25 2022, 11:02 AM · Restricted Project, Restricted Project
tstellar committed rW1b51709bfb59: Update for 14.0.0 release (authored by tstellar).
Update for 14.0.0 release
Mar 25 2022, 10:44 AM · Restricted Project
tstellar added a comment to D122487: [ARM] Make testcase warning pattern match more specific.

The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useless (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

Mar 25 2022, 9:04 AM · Restricted Project, Restricted Project
tstellar committed rG3929f9139715: Release Workflow: Remove cherry-pick-failed label when pull request is created (authored by tstellar).
Release Workflow: Remove cherry-pick-failed label when pull request is created
Mar 25 2022, 12:46 AM · Restricted Project, Restricted Project
tstellar closed D121032: Release Workflow: Remove cherry-pick-failed label when pull request is created.
Mar 25 2022, 12:46 AM · Restricted Project, Restricted Project

Mar 24 2022

tstellar committed rGfed96f31bb5b: Re-commit: Driver: Don't warn on -mbranch-protection when linking (authored by tstellar).
Re-commit: Driver: Don't warn on -mbranch-protection when linking
Mar 24 2022, 4:58 PM · Restricted Project, Restricted Project

Mar 23 2022

tstellar added a comment to D122082: Add DXIL Bitcode Writer and DXIL testing.

@xbolva00 Don't think the board has any relation to this, but I do agree that having some central documentation would be great. While many of the ongoing migration efforts are well-documented by themselves, there's currently no central place that collects them. I've created https://reviews.llvm.org/D122122 as a starting point, feedback welcome.

@nikic, even that document doesn't say support for opaque pointers is a "hard requirement" for new contributions.

Given that there is no documentation or clear community consensus anywhere that I can find that it should be a hard requirement, and that this code is going into an experimental backend, which (as documented in the support policy: https://llvm.org/docs/SupportPolicy.html) means "you break it, I fix it". Would you revise your "needs revision" feedback?

Mar 23 2022, 10:00 AM · Restricted Project, Restricted Project

Mar 22 2022

tstellar added a reverting change for rG98fd3b359866: Driver: Don't warn on -mbranch-protection when linking: rG1089cdda776b: Revert "Driver: Don't warn on -mbranch-protection when linking".
Mar 22 2022, 11:37 PM · Restricted Project
tstellar committed rG1089cdda776b: Revert "Driver: Don't warn on -mbranch-protection when linking" (authored by tstellar).
Revert "Driver: Don't warn on -mbranch-protection when linking"
Mar 22 2022, 11:37 PM · Restricted Project
tstellar added a reverting change for D121983: Driver: Don't warn on -mbranch-protection when linking: rG1089cdda776b: Revert "Driver: Don't warn on -mbranch-protection when linking".
Mar 22 2022, 11:37 PM · Restricted Project, Restricted Project
tstellar committed rG98fd3b359866: Driver: Don't warn on -mbranch-protection when linking (authored by tstellar).
Driver: Don't warn on -mbranch-protection when linking
Mar 22 2022, 11:18 PM · Restricted Project
tstellar closed D121983: Driver: Don't warn on -mbranch-protection when linking.
Mar 22 2022, 11:18 PM · Restricted Project, Restricted Project
tstellar added a comment to D118493: Set rpath on openmp executables.

It lets applications run with the libomp and libomptarget built with the toolchain. For users, they don't have to be root. For compiler devs, we test our work instead of whatever the distro had installed.

There's no info at that link. What's 'broken rpath'? If they mean runpath, then it's really on fedora to have Wl,--rpath set rpath instead of runpath. Setting the default in the linker to the one your own build tools reject will break everything, not just llvm openmp.

Edit: https://fedoraproject.org/wiki/Changes/Broken_RPATH_will_fail_rpmbuild
Doesn't mean runpath. There's a list of strings Fedora (IBM?) have decided they don't like, named 'broken' or 'invalid', and declared shall not be present. Page doesn't go into the rpath/runpath distinction, maybe they mean for the string restrictions to apply to both.

Mar 22 2022, 9:24 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D122004: [lld] Add generic helloworld test program.

@XiaodongLoong You may be interested in the toolchain integration test suite which has multi-project tests like this.

Mar 22 2022, 2:54 PM · Restricted Project, Restricted Project

Mar 21 2022

Herald added a project to D118493: Set rpath on openmp executables: Restricted Project.

Fedora recently banned RUNPATH, so packages built with clang and -fopenmp are rejected by the build system with this change. Can you elaborate more about the intended use case that this change will fix? Is it just meant for when libomp.so is installed outside of /usr/lib64 ?

Mar 21 2022, 4:50 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

tstellar requested review of D121983: Driver: Don't warn on -mbranch-protection when linking.
Mar 18 2022, 12:56 AM · Restricted Project, Restricted Project

Mar 17 2022

tstellar added a comment to D121972: Add cmake/ to release tarballs via concatenation.

Would it be easier just to package the cmake directory in a separate tarball?

Mar 17 2022, 9:56 PM · Restricted Project, Restricted Project

Mar 15 2022

tstellar added a comment to D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.

@xbolva00 I've removed your comment due to inappropriate language and tone. Please find a more constructive way to communicate your point.

Mar 15 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project