Page MenuHomePhabricator
People tstellar

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (96 w, 2 d)

Recent Activity
View All

Yesterday

tstellar committed rL349253: Add 7.0.1-final sources.
Add 7.0.1-final sources
Fri, Dec 14, 9:55 PM
tstellar committed rL349246: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:42 PM
tstellar committed rL349239: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:42 PM
tstellar committed rL349250: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:41 PM
tstellar committed rL349249: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:41 PM
tstellar committed rL349248: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:41 PM
tstellar committed rL349242: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:41 PM
tstellar committed rL349247: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:40 PM
tstellar committed rL349238: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:40 PM
tstellar committed rL349244: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:39 PM
tstellar committed rL349243: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:38 PM
tstellar committed rL349241: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:38 PM
tstellar committed rL349240: Creating release candidate final from release_701 branch.
Creating release candidate final from release_701 branch
Fri, Dec 14, 8:37 PM
tstellar accepted D55693: AMDGPU/GlobalISel: Fix ValueMapping tables for i1.

LGTM.

Fri, Dec 14, 6:48 AM

Thu, Dec 13

tstellar committed rL349068: Don't add unnecessary compiler flags to llvm-config output.
Don't add unnecessary compiler flags to llvm-config output
Thu, Dec 13, 10:24 AM
tstellar closed D55391: Don't add unnecessary compiler flags to llvm-config output.
Thu, Dec 13, 10:24 AM

Wed, Dec 12

tstellar updated the diff for D53554: [Argument Promotion] Only promote args when function attributes are compatible.

Some small updates:

Wed, Dec 12, 8:35 PM
tstellar updated the summary of D55391: Don't add unnecessary compiler flags to llvm-config output.
Wed, Dec 12, 6:41 PM
tstellar updated the diff for D55391: Don't add unnecessary compiler flags to llvm-config output.

Make sure llvm-config reports the c/c++ language standard used.

Wed, Dec 12, 6:36 PM
tstellar added a comment to D51748: cmake: Remove add_llvm_loadable_module().

Ping.

Wed, Dec 12, 5:26 PM

Fri, Dec 7

tstellar committed rL348696: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:30 PM
tstellar committed rL348692: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:30 PM
tstellar committed rL348700: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:29 PM
tstellar committed rL348698: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:29 PM
tstellar committed rL348699: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:29 PM
tstellar committed rL348689: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:29 PM
tstellar committed rL348697: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:29 PM
tstellar committed rL348694: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:28 PM
tstellar committed rL348688: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:28 PM
tstellar committed rL348693: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:28 PM
tstellar committed rL348690: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:27 PM
tstellar committed rL348691: Creating release candidate rc3 from release_701 branch.
Creating release candidate rc3 from release_701 branch
Fri, Dec 7, 9:27 PM
tstellar committed rL348686: Merging r345839:.
Merging r345839:
Fri, Dec 7, 9:10 PM
tstellar committed rL348684: Merging r345838:.
Merging r345838:
Fri, Dec 7, 8:57 PM
tstellar committed rL348682: Merging r345826:.
Merging r345826:
Fri, Dec 7, 8:45 PM
tstellar committed rL348681: Merging r342152:.
Merging r342152:
Fri, Dec 7, 8:32 PM
tstellar committed rL348642: Merging r348444:.
Merging r348444:
Fri, Dec 7, 12:45 PM
tstellar committed rL348636: Merging r346203:.
Merging r346203:
Fri, Dec 7, 12:25 PM
tstellar added inline comments to D55391: Don't add unnecessary compiler flags to llvm-config output.
Fri, Dec 7, 9:01 AM

Thu, Dec 6

tstellar committed rL348555: Merging r340125:.
Merging r340125:
Thu, Dec 6, 4:27 PM
tstellar committed rL348554: Merging r340386 and r344190:.
Merging r340386 and r344190:
Thu, Dec 6, 4:19 PM
tstellar added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.
In D55174#1321973, @sylvestre.ledru wrote:

@tstellar will you accept this patch if I remove -std?
thanks

Thu, Dec 6, 3:29 PM
tstellar created D55391: Don't add unnecessary compiler flags to llvm-config output.
Thu, Dec 6, 3:28 PM
tstellar committed rL348538: Merging r348462:.
Merging r348462:
Thu, Dec 6, 2:39 PM
tstellar committed rL348535: Merging r348461:.
Merging r348461:
Thu, Dec 6, 2:24 PM
tstellar committed rL348528: Merging r348181:.
Merging r348181:
Thu, Dec 6, 1:40 PM

Wed, Dec 5

tstellar added a comment to D55258: Python 2/3 compat - socket server.

Is there a particular reason why this and https://reviews.llvm.org/D55259 are separate patches?

Wed, Dec 5, 9:34 PM
tstellar added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

I only mentioned -fno-rtti specifically because this is something that llvm-config already knows about. I also don't have knowledge of all the possible flags that might need to be filtered.

Wed, Dec 5, 9:20 PM
tstellar committed rL348453: Merging r343369:.
Merging r343369:
Wed, Dec 5, 7:18 PM
tstellar committed rL348452: Merging r343369:.
Merging r343369:
Wed, Dec 5, 7:17 PM
tstellar committed rL348451: Merging r343369:.
Merging r343369:
Wed, Dec 5, 7:17 PM
tstellar committed rL348450: Merging r343369:.
Merging r343369:
Wed, Dec 5, 7:17 PM
tstellar committed rL348405: Merging r345470:.
Merging r345470:
Wed, Dec 5, 11:52 AM

Tue, Dec 4

tstellar committed rL348322: Merging r343753:.
Merging r343753:
Tue, Dec 4, 4:19 PM
tstellar added a comment to D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -std for --cflags, --cxxflags & --ldflags.

Don't we need to leave -fno-rtti here if LLVM was complied without rtti? Also, rather than filtering out, would it be possible to explicitly add the flags that users need to successfully link/build against this install of LLVM?

Tue, Dec 4, 8:47 AM

Fri, Nov 30

tstellar committed rL348012: Merging r344100:.
Merging r344100:
Fri, Nov 30, 10:18 AM
tstellar committed rL348011: Merging r344589:.
Merging r344589:
Fri, Nov 30, 9:58 AM

Thu, Nov 29

tstellar committed rL347957: Merging r339260:.
Merging r339260:
Thu, Nov 29, 8:55 PM
tstellar committed rL347935: Merging r347556:.
Merging r347556:
Thu, Nov 29, 4:12 PM
tstellar committed rL347931: Merging r347431:.
Merging r347431:
Thu, Nov 29, 3:44 PM
tstellar committed rL347921: Merging r344444 and r344445:.
Merging r344444 and r344445:
Thu, Nov 29, 1:30 PM

Wed, Nov 28

tstellar committed rL347834: Merging r345497:.
Merging r345497:
Wed, Nov 28, 8:41 PM
tstellar committed rL347829: Merging r343105:.
Merging r343105:
Wed, Nov 28, 6:57 PM
tstellar committed rL347822: Merging r347179:.
Merging r347179:
Wed, Nov 28, 4:34 PM
tstellar committed rL347811: Merging r342865:.
Merging r342865:
Wed, Nov 28, 1:49 PM
tstellar committed rL347798: Merging r347262:.
Merging r347262:
Wed, Nov 28, 12:07 PM
tstellar committed rL347797: Merging r347261:.
Merging r347261:
Wed, Nov 28, 11:52 AM

Mon, Nov 26

tstellar committed rL347634: Update 7.0.1 release schedule.
Update 7.0.1 release schedule
Mon, Nov 26, 8:19 PM
tstellar added a comment to rL346732: CMake: Deprecate using llvm-config to detect llvm installation.

My idea was to stop using llvm-config during the clang (and other sub-project) builds only. I don't have any plans to remove the llvm-config tool from llvm.

Mon, Nov 26, 8:09 AM

Mon, Nov 19

tstellar committed rL347285: Merging r345353:.
Merging r345353:
Mon, Nov 19, 7:45 PM
tstellar committed rL347276: Merging r341697:.
Merging r341697:
Mon, Nov 19, 4:39 PM

Nov 15 2018

tstellar committed rL347030: Merging r344605:.
Merging r344605:
Nov 15 2018, 10:07 PM
tstellar committed rL347028: Merging r344591:.
Merging r344591:
Nov 15 2018, 9:19 PM
tstellar committed rL347024: Merging r343212:.
Merging r343212:
Nov 15 2018, 8:27 PM
tstellar committed rL347023: Merging r344516:.
Merging r344516:
Nov 15 2018, 8:25 PM
tstellar committed rL347004: Re-apply r346985: [ADT] Drop llvm::Optional clang-specific optimization for….
Re-apply r346985: [ADT] Drop llvm::Optional clang-specific optimization for…
Nov 15 2018, 4:50 PM
tstellar committed rL346990: Revert "[ADT] Drop llvm::Optional clang-specific optmization for trivially….
Revert "[ADT] Drop llvm::Optional clang-specific optmization for trivially…
Nov 15 2018, 12:29 PM
tstellar committed rL346985: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable….
[ADT] Drop llvm::Optional clang-specific optmization for trivially copyable…
Nov 15 2018, 11:35 AM
tstellar closed D54540: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable types.
Nov 15 2018, 11:35 AM

Nov 14 2018

tstellar created D54540: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable types.
Nov 14 2018, 1:49 PM

Nov 13 2018

tstellar added inline comments to D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Nov 13 2018, 7:09 PM

Nov 12 2018

tstellar committed rL346742: Merging r342946:.
Merging r342946:
Nov 12 2018, 10:09 PM
tstellar committed rL346741: Merging r342884:.
Merging r342884:
Nov 12 2018, 10:00 PM
tstellar committed rL346739: Merging r341919:.
Merging r341919:
Nov 12 2018, 9:45 PM
tstellar committed rL346737: Merging r341221:.
Merging r341221:
Nov 12 2018, 9:31 PM
tstellar committed rL346736: Merging r340932:.
Merging r340932:
Nov 12 2018, 9:21 PM
tstellar committed rL346735: Merging r340931:.
Merging r340931:
Nov 12 2018, 9:04 PM
tstellar committed rL346734: Merging r340927:.
Merging r340927:
Nov 12 2018, 8:52 PM
tstellar committed rL346732: CMake: Deprecate using llvm-config to detect llvm installation.
CMake: Deprecate using llvm-config to detect llvm installation
Nov 12 2018, 7:45 PM
tstellar committed rC346732: CMake: Deprecate using llvm-config to detect llvm installation.
CMake: Deprecate using llvm-config to detect llvm installation
Nov 12 2018, 7:45 PM
tstellar closed D51714: CMake: Deprecate using llvm-config to detect llvm installation.
Nov 12 2018, 7:45 PM
tstellar committed rC346731: CMake: Replace open-coded find_package.
CMake: Replace open-coded find_package
Nov 12 2018, 7:19 PM
tstellar committed rL346731: CMake: Replace open-coded find_package.
CMake: Replace open-coded find_package
Nov 12 2018, 7:19 PM
tstellar closed D32577: CMake: Replace open-coded find_package.
Nov 12 2018, 7:19 PM
tstellar updated the diff for D53554: [Argument Promotion] Only promote args when function attributes are compatible.

Add a new callback function areFunctionArgsABICompatible for the ArgumentPromotion
pass to use. @echristo I'm still a little confused about what to do with
functionsHaveCompatibleAttributes, should I just leave it as is, or use this new
callback?

Nov 12 2018, 5:06 PM
tstellar created D54439: CMake: Make most target symbols hidden by default.
Nov 12 2018, 12:07 PM

Nov 9 2018

tstellar retitled D51748: cmake: Remove add_llvm_loadable_module() from cmake: Refactor add_llvm_loadable_module() to cmake: Remove add_llvm_loadable_module().
Nov 9 2018, 9:20 PM
tstellar added a comment to D51748: cmake: Remove add_llvm_loadable_module().

Some of the clang examples use the add_llvm_loadable_module() macro, so I will need to update those too in a separate patch.

Nov 9 2018, 9:18 PM
tstellar updated the diff for D51748: cmake: Remove add_llvm_loadable_module().

Remove add_llvm_loadable_module() completely.

Nov 9 2018, 9:17 PM
tstellar added inline comments to D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Nov 9 2018, 6:53 PM