User Details
- User Since
- Feb 9 2017, 1:53 PM (206 w, 2 d)
Yesterday
Thu, Jan 21
Thanks for the updates. I think this proposal is ready to send to Chris (Step 4).
@andreisfr I don't seen any major issues being raised with this backend. It would be great if there was a public official ISA document, but I don't think the lack of one is a blocker. Please make a last check of the reviews in phabricato to see if there are any outstanding issues. Then, I would recommend you take a look at the documentation @tonic posted. Specifically the 5 bullet points under the "The basic rules for a back-end to be upstreamed in experimental mode are:" header. If you think you meet those requirements, please re-send the RFC to the list, so we can discuss getting this added.
Wed, Jan 20
Fix shared object symlinks.
Tue, Jan 19
Mon, Jan 18
Fri, Jan 15
Thu, Jan 14
This makes sense to me.
Wed, Jan 13
Mon, Jan 11
If this pitch is accepted, then what are the next steps required in order for bazel or another build system to be added to tree? For example, can they automatically be added if they meet the support policy requirements or does there need to be some kind of community ack for? I think the pitch needs to be more clear about what this process is.
Mon, Jan 4
Dec 21 2020
Dec 18 2020
Dec 17 2020
Dec 15 2020
Dec 14 2020
@jhenderson What's your opinion on backporting this?
Dec 9 2020
In my opinion , it would be better to to build against an installed version of the library, rather than fetching the git source. But I don't have any objections to this specific patch, because it is updating something that is already in tree.
Dec 4 2020
Looking for feedback on if we want this kind of workaround in tree.
Dec 3 2020
Dec 2 2020
Could you add some more information to the commit message to better describe the powerpcle target. It's not clear from the target name exactly what it is for.
Nov 24 2020
Thanks for the explanation. Doing a git clone as part of the build is usually discouraged, though I see Lang approved the original patch. Is this code disabled by default?
Can you explain more about what llorg is and why this change is needed?
Nov 20 2020
Nov 19 2020
Nov 17 2020
Can you give an example of how this would be used to select the gcc-toolchain?
@sylvestre.ledru Can you drop the picture?
Nov 16 2020
This is fine with me.
I'm not sure if I'm going to be able to restrict commits to the branch to only the GitHub Actions bot, so I may need to swap out github.token for a github secret that uses the llvmbot token. If necessary, I will make this change as a follow up commit after I've done some testing.
Nov 13 2020
I know this fixes a bug, but I don't think this is quite correct. It's really only the test that depends on the library not the tool. You could add LLVMFrontendOpenACC as a dependency to the check target, but it's pretty uncommon for an LLVM library to not have any tests. I think it would be better to fix this by adding a test case for LLVMFrontendOpenACC.
Nov 11 2020
Nov 9 2020
This code could be improved, but I don't think adding a specific environment variable for this a good solution. You can use the existing CCC_OVERRIDE_OPTIONS to get the same effect. e.g. CCC_OVERRIDE_OPTIONS=^--gcc-toolchain=/path/to/gcc
Nov 6 2020
Nov 2 2020
Oct 30 2020
LGTM.
Oct 26 2020
LGTM.
Oct 22 2020
Aug 17 2020
This is fine with me.
Aug 12 2020
LGTM. Thanks.
Aug 11 2020
Reverting this patch seems to fix the error for me. Are you still seeing this same error in trunk?
This commit appears to be causing an error when I run CMake:
Aug 7 2020
I can confirm that this patch also fixes the full test case.
Aug 6 2020
Aug 3 2020
Jul 28 2020
Add volatile test.
Jul 27 2020
Here is the assembly comparison for the 64-bit test I added between gcc and clang trunk + patch: https://reviews.llvm.org/P8227
This is the test driver I used for testing. I compared the clang 11 + this patch with gcc 10 and saw no differences: https://gist.github.com/tstellar/80dae2ab8a18d810b10b8e42777f4fe4
Add 64-bit test.
Jul 23 2020
Remove stray comment.
Jul 22 2020
Add example for tagging the -init tag.
Jul 10 2020
Jul 9 2020
LGTM.
Jul 7 2020
Jul 6 2020
Jun 29 2020
LGTM.