tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (87 w, 5 d)

Recent Activity

Thu, Oct 11

tstellar committed rL344317: Revert "AMDGPU/GlobalISel: Implement select for G_INSERT".
Revert "AMDGPU/GlobalISel: Implement select for G_INSERT"
Thu, Oct 11, 4:39 PM
tstellar committed rL344310: AMDGPU/GlobalISel: Implement select for G_INSERT.
AMDGPU/GlobalISel: Implement select for G_INSERT
Thu, Oct 11, 3:52 PM
tstellar closed D53116: AMDGPU/GlobalISel: Implement select for G_INSERT.
Thu, Oct 11, 3:52 PM

Wed, Oct 10

tstellar created D53116: AMDGPU/GlobalISel: Implement select for G_INSERT.
Wed, Oct 10, 4:51 PM
tstellar added inline comments to D52923: AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD.
Wed, Oct 10, 12:39 PM

Tue, Oct 9

tstellar added a comment to D52900: [PowerPC]Disable randomized address space on Linux ppc64le.

Do you have more information about the change in Ubuntu that caused this to stop working?

Tue, Oct 9, 10:35 AM

Mon, Oct 8

tstellar committed rL343985: AMDGPU/GlobalISel: Select amdgcn.cvt.pkrtz to 64-bit instructions.
AMDGPU/GlobalISel: Select amdgcn.cvt.pkrtz to 64-bit instructions
Mon, Oct 8, 10:52 AM
tstellar closed D52958: AMDGPU/GlobalISel: Select amdgcn.cvt.pkrtz to 64-bit instructions.
Mon, Oct 8, 10:52 AM

Fri, Oct 5

tstellar committed rL343909: AMDGPU: Consolidate SMRD TableGen patterns.
AMDGPU: Consolidate SMRD TableGen patterns
Fri, Oct 5, 8:34 PM
tstellar closed D52557: AMDGPU: Consolidate SMRD TableGen patterns.
Fri, Oct 5, 8:34 PM
tstellar created D52958: AMDGPU/GlobalISel: Select amdgcn.cvt.pkrtz to 64-bit instructions.
Fri, Oct 5, 7:24 PM
tstellar added a comment to D31359: [GlobalISel]: Allow backends to custom legalize Intrinsics.

Here is an AMDGPU patch that uses legalizeIntrinsic() https://reviews.llvm.org/D52923

Fri, Oct 5, 7:22 PM

Thu, Oct 4

tstellar committed rL343839: AMDGPU/GlobalISel: Add support for G_INTTOPTR.
AMDGPU/GlobalISel: Add support for G_INTTOPTR
Thu, Oct 4, 9:35 PM
tstellar closed D52916: AMDGPU/GlobalISel: Add support for G_INTTOPTR.
Thu, Oct 4, 9:35 PM
tstellar retitled D52923: AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD from AMDGPU/GlobalIsel: Legalize SI.const by lowering to G_LOAD to AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD.
Thu, Oct 4, 9:10 PM
tstellar created D52923: AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD.
Thu, Oct 4, 9:04 PM
tstellar created D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen.
Thu, Oct 4, 7:54 PM
tstellar created D52916: AMDGPU/GlobalISel: Add support for G_INTTOPTR.
Thu, Oct 4, 4:36 PM

Wed, Oct 3

tstellar added a comment to D42608: Driver: Prefer vendor supplied gcc toolchain.

I've implemented an alternative solution here that I think is a little more robust: https://reviews.llvm.org/D52861

Wed, Oct 3, 9:32 PM
tstellar created D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc.
Wed, Oct 3, 9:32 PM

Fri, Sep 28

tstellar added a comment to D51714: CMake: Deprecate using llvm-config to detect llvm installation.

Is there anything holding this up?

Fri, Sep 28, 9:43 PM

Thu, Sep 27

tstellar committed rL343290: merge-request.sh: Add 7.0 metabug.
merge-request.sh: Add 7.0 metabug
Thu, Sep 27, 7:32 PM
tstellar added a comment to rC343105: [analyzer] scan-build: if --status-bugs is passed, don't forget about the exit….

I've created the 7.0.1 metabug, updated the merge-request.sh script. and created a merge request for this: https://llvm.org/PR39107

Thu, Sep 27, 7:15 PM
tstellar updated the diff for D51714: CMake: Deprecate using llvm-config to detect llvm installation.

Use cmake's DEPRECATION message.

Thu, Sep 27, 4:19 PM

Wed, Sep 26

tstellar committed rL343125: AMDGPU/SI: Change predicate to isCIOnly for 32-bit imm s_buffer_load* patterns.
AMDGPU/SI: Change predicate to isCIOnly for 32-bit imm s_buffer_load* patterns
Wed, Sep 26, 9:57 AM
tstellar closed D52469: AMDGPU/SI: Change predicate to isCIOnly for 32-bit imm s_buffer_load* patterns.
Wed, Sep 26, 9:57 AM
tstellar created D52557: AMDGPU: Consolidate SMRD TableGen patterns.
Wed, Sep 26, 9:20 AM
tstellar committed rL343115: lit: Make sure the builtin_commands directory is packaged by setup.py.
lit: Make sure the builtin_commands directory is packaged by setup.py
Wed, Sep 26, 8:00 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Sep 26, 8:00 AM

Tue, Sep 25

tstellar created D52469: AMDGPU/SI: Change predicate to isCIOnly for 32-bit imm s_buffer_load* patterns.
Tue, Sep 25, 6:57 AM

Sep 12 2018

tstellar retitled D51944: Fix affinity mask usage on big-endian CPUs from openmp: Use glibc wrappers for accessing cpu affinity mask to Fix affinity mask usage on big-endian CPUs.
Sep 12 2018, 8:59 PM
tstellar updated the diff for D51944: Fix affinity mask usage on big-endian CPUs.

Is this more what you had in mind?

Sep 12 2018, 8:58 PM

Sep 11 2018

tstellar created D51944: Fix affinity mask usage on big-endian CPUs.
Sep 11 2018, 11:03 AM

Sep 7 2018

tstellar added a comment to D51552: Libraries added with add_llvm_loadable_module macro to have their component name.

Updated. If you have any more feedback you can leave it on the review for the other patch.

Sep 7 2018, 6:55 PM
tstellar updated the diff for D51748: cmake: Refactor add_llvm_loadable_module().

Add custom install targets for modules.

Sep 7 2018, 6:55 PM
tstellar added a comment to D51552: Libraries added with add_llvm_loadable_module macro to have their component name.

I've just updated the patch with some fixes, can you try again?

Sep 7 2018, 4:57 PM
tstellar updated the diff for D51748: cmake: Refactor add_llvm_loadable_module().

Fix cmake failure with -DLLVM_LINK_LLVM_DYLIB=OFF

Sep 7 2018, 4:57 PM
tstellar added a comment to D51552: Libraries added with add_llvm_loadable_module macro to have their component name.

What CMake arguments were you using?

Sep 7 2018, 3:51 PM
tstellar added a comment to D51552: Libraries added with add_llvm_loadable_module macro to have their component name.

D51748 proposes refactoring this whole function and effectively makes the same change. Would you be able to test this to see if it helps your uses case?

Sep 7 2018, 1:13 PM
tstellar committed rL341672: MachO: Change getString16() back to inline function.
MachO: Change getString16() back to inline function
Sep 7 2018, 8:53 AM
tstellar committed rLLD341672: MachO: Change getString16() back to inline function.
MachO: Change getString16() back to inline function
Sep 7 2018, 8:53 AM
tstellar committed rLLD341670: MachO: Fix out-of-bounds memory access in getString16.
MachO: Fix out-of-bounds memory access in getString16
Sep 7 2018, 8:46 AM
tstellar committed rL341670: MachO: Fix out-of-bounds memory access in getString16.
MachO: Fix out-of-bounds memory access in getString16
Sep 7 2018, 8:45 AM
tstellar closed D51547: MachO: Fix out-of-bounds memory access in getString16.
Sep 7 2018, 8:45 AM

Sep 6 2018

tstellar abandoned D51755: cmake: Only require python if COMPILER_RT_INCLUDE_TESTS is enabled.

Ok, my mistake.

Sep 6 2018, 3:28 PM
tstellar created D51755: cmake: Only require python if COMPILER_RT_INCLUDE_TESTS is enabled.
Sep 6 2018, 3:22 PM
tstellar added inline comments to D51748: cmake: Refactor add_llvm_loadable_module().
Sep 6 2018, 3:03 PM
tstellar added a comment to D50668: unittests: Don't install TestPlugin.so.

There are a few other modules in the tree that are unnecessarily installed. So I made an attempt to fix this in a more generic way: D51748.

Sep 6 2018, 1:27 PM
tstellar created D51748: cmake: Refactor add_llvm_loadable_module().
Sep 6 2018, 1:24 PM
tstellar added a comment to D51714: CMake: Deprecate using llvm-config to detect llvm installation.

Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for everyone who has LLVM configured.

Sep 6 2018, 9:25 AM

Sep 5 2018

tstellar created D51714: CMake: Deprecate using llvm-config to detect llvm installation.
Sep 5 2018, 8:14 PM
tstellar updated the diff for D32577: CMake: Replace open-coded find_package.

Rebase on trunk.

Sep 5 2018, 8:10 PM

Sep 4 2018

tstellar created D51670: lit: Make sure the builtin_commands directory is packaged by setup.py.
Sep 4 2018, 6:50 PM
tstellar committed rL341429: Add link to correct sles11.3 binary.
Add link to correct sles11.3 binary
Sep 4 2018, 4:32 PM
tstellar committed rL341427: Add 6.0.1 binary for sles11.3.
Add 6.0.1 binary for sles11.3
Sep 4 2018, 4:26 PM
tstellar added a comment to D51567: CMake: Consolidate gtest detection code.

I mean, sure.

I really don't know that supporting this ever expanding diversity of build strategies is worth its cost, but I don't see a specific reason to not take this patch....

Sep 4 2018, 11:51 AM
tstellar abandoned D51548: lld: Add missing REQUIRES to tests.

My mistake. I had been working on the release_70 branch and did not realize the REQUIRES had been added to trunk when I rebased. Looks like this was fixed in r339253. I'll ask Hans to backport that to the stable branch.

Sep 4 2018, 7:04 AM

Aug 31 2018

tstellar created D51567: CMake: Consolidate gtest detection code.
Aug 31 2018, 10:47 PM
tstellar committed rL341271: AMDGPU/GlobalISel: Define instruction mapping for G_SELECT.
AMDGPU/GlobalISel: Define instruction mapping for G_SELECT
Aug 31 2018, 7:43 PM
tstellar closed D49737: AMDGPU/GlobalISel: Define instruction mapping for G_SELECT.
Aug 31 2018, 7:43 PM
tstellar committed rL341244: lit: Use sys.executable for executing builtin commands.
lit: Use sys.executable for executing builtin commands
Aug 31 2018, 1:16 PM
tstellar closed D51511: lit: Use sys.executable for executing builtin commands.
Aug 31 2018, 1:16 PM
tstellar created D51548: lld: Add missing REQUIRES to tests.
Aug 31 2018, 10:30 AM
tstellar created D51547: MachO: Fix out-of-bounds memory access in getString16.
Aug 31 2018, 10:27 AM

Aug 30 2018

tstellar created D51511: lit: Use sys.executable for executing builtin commands.
Aug 30 2018, 2:47 PM

Aug 28 2018

tstellar committed rL340897: Remove link to clang+llvm-6.0.1-x86_64-linux-sles11.3.tar.xz.
Remove link to clang+llvm-6.0.1-x86_64-linux-sles11.3.tar.xz
Aug 28 2018, 9:17 PM
tstellar committed rL340895: Remove clang+llvm-6.0.1-x86_64-linux-sles11.3.tar.xz, the name does not match….
Remove clang+llvm-6.0.1-x86_64-linux-sles11.3.tar.xz, the name does not match…
Aug 28 2018, 9:13 PM

Aug 21 2018

tstellar committed rL340346: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.
MachineScheduler: Refactor setPolicy() to limit computing remaining latency
Aug 21 2018, 2:49 PM
tstellar closed D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.
Aug 21 2018, 2:49 PM
tstellar committed rT340322: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp.
ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp
Aug 21 2018, 12:23 PM
tstellar committed rL340322: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp.
ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp
Aug 21 2018, 12:23 PM
tstellar closed D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp.
Aug 21 2018, 12:23 PM
tstellar committed rT340320: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++.
MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++
Aug 21 2018, 12:14 PM
tstellar committed rL340320: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++.
MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++
Aug 21 2018, 12:14 PM
tstellar closed D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++.
Aug 21 2018, 12:13 PM

Aug 20 2018

tstellar created D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp.
Aug 20 2018, 7:06 PM
tstellar created D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++.
Aug 20 2018, 7:01 PM

Aug 17 2018

tstellar added a comment to D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.

@atrick does this look OK to you?

Aug 17 2018, 10:23 AM

Aug 16 2018

tstellar added a comment to D50668: unittests: Don't install TestPlugin.so.

I had to revert this, because it broke the Windows build. I am working on a new patch.

Aug 16 2018, 10:44 AM
tstellar reopened D50668: unittests: Don't install TestPlugin.so.

I had to revert this, because it broke the Windows build. I am working on a new patch.

Aug 16 2018, 10:30 AM
tstellar committed rL339903: Revert "unittests: Don't install TestPlugin.so".
Revert "unittests: Don't install TestPlugin.so"
Aug 16 2018, 10:15 AM
tstellar committed rL339897: unittests: Don't install TestPlugin.so.
unittests: Don't install TestPlugin.so
Aug 16 2018, 9:54 AM
tstellar closed D50668: unittests: Don't install TestPlugin.so.
Aug 16 2018, 9:53 AM

Aug 14 2018

tstellar added a comment to D50668: unittests: Don't install TestPlugin.so.

This makes complete sense to me, but I'm wondering whether add_llvm_loadable_module is the right macro to use here in the first place. All it does is call add_llvm_library with a MODULE argument, and set up the install.

So it seems to me that add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY ...) should work just as well, without changing the setup. Does that make sense?

Aug 14 2018, 11:59 AM
tstellar updated the diff for D50668: unittests: Don't install TestPlugin.so.

Use add_llvm_library() instead of add_llvm_loadable_module()

Aug 14 2018, 11:59 AM

Aug 13 2018

tstellar created D50668: unittests: Don't install TestPlugin.so.
Aug 13 2018, 2:59 PM

Aug 10 2018

tstellar committed rL339492: [gold] Fix Tests cases on i686.
[gold] Fix Tests cases on i686
Aug 10 2018, 6:09 PM
tstellar closed D50583: [gold] Fix Tests cases on i686.
Aug 10 2018, 6:09 PM
tstellar committed rL339491: AMDGPU/GlobalISel: Define instruction mapping for G_INSERT.
AMDGPU/GlobalISel: Define instruction mapping for G_INSERT
Aug 10 2018, 5:52 PM
tstellar closed D49625: AMDGPU/GlobalISel: Define instruction mapping for G_INSERT.
Aug 10 2018, 5:52 PM
tstellar created D50583: [gold] Fix Tests cases on i686.
Aug 10 2018, 3:03 PM
tstellar abandoned D50546: CMake: Fix native arch selection on s390 (32-bit).

OK, that's good to know, I will drop this patch from Fedora.

Aug 10 2018, 8:28 AM

Aug 9 2018

tstellar created D50546: CMake: Fix native arch selection on s390 (32-bit).
Aug 9 2018, 6:32 PM
tstellar added inline comments to rL339367: Fix few g++ 8 warning with non obvious copy object operations.
Aug 9 2018, 4:43 PM

Aug 8 2018

tstellar created D50486: MachineScheduler: Refactor setPolicy() to limit computing remaining latency.
Aug 8 2018, 6:14 PM

Aug 2 2018

tstellar committed rL338751: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING.
CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
Aug 2 2018, 11:16 AM
tstellar closed D49835: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING.
Aug 2 2018, 11:16 AM
tstellar accepted D50053: Release download page: add text about what's in the package.

Looks good to me.

Aug 2 2018, 7:45 AM

Aug 1 2018

tstellar created D50151: utils: Add script for listing release blocker bugs.
Aug 1 2018, 11:05 AM

Jul 31 2018

tstellar added a comment to D50121: [PowerPC] Do not round values prior to converting to integer.

One questions I had after looking into this bug was why does PPCTargetLowering::LowerFP_TO_INTForReuse() extend f32 values to f64 before creating the FCT* instructions?

Jul 31 2018, 6:47 PM