User Details
- User Since
- Jun 2 2014, 4:46 PM (359 w, 2 d)
Dec 2 2020
LGTM. Thanks for doing this!
Sep 3 2020
LGTM
Aug 18 2020
Seems reasonable to me too.
Aug 17 2020
LGTM
Mar 4 2020
LGTM
Feb 10 2020
This shouldn't affect the final binary size as the linker is going to probably recreate the relocations and symbol table anyway, but seems fine to align this more in the object files.
Dec 16 2019
LGTM.
Nov 15 2019
LGTM
LGTM
Oct 29 2019
Sep 19 2019
LGTM
Sep 3 2019
Aug 22 2019
LGTM.
Aug 7 2019
Looks like the tests are extremely comprehensive. LGTM.
Jun 5 2019
LGTM.
May 30 2019
I'm trusting the binary blobs are good. Phab doesn't have a built in mach-o parser :)
LGTM.
May 17 2019
Looks good. That’s nice to see more lines removed than added :)
Apr 24 2019
Wow. That must be a huge test case for this to be a problem!
Apr 19 2019
LGTM.
Mar 20 2019
Mar 9 2019
LGTM.
Mar 7 2019
LGTM.
Mar 6 2019
LGTM. Thanks!
Feb 22 2019
Feb 11 2019
Looks like we can have print_protocol_list64_t also call the new print_protocol_64_t, but that can be done in a later NFC commit.
Jan 30 2019
LGTM. Thanks for fixing this!
Jan 22 2019
LGTM
Jan 2 2019
Thanks for the review. Submitted as r350284.
Dec 21 2018
Thanks for all the feedback so far. Is there anything else you'd like me to change before I can land this?
Dec 20 2018
Dec 19 2018
Dec 18 2018
Dec 17 2018
Dec 7 2018
Added test for integer argument and updated code to only accept pointer types to allocWithZone.
I added the other objc* intrinsics used by ARC in r348646.
Thanks for the review. Have fixed the comments as suggested.
Dec 6 2018
Dec 5 2018
Discovered that objc_storeStrong is actually wrong in the documentation. Changing it from returning id to returning void. Will also update the docs.
Dec 4 2018
Dec 3 2018
Updated to add a comment to Intrinsics.td, remove the ReturnedValue<> and added all of the ARC methods from https://clang.llvm.org/docs/AutomaticReferenceCounting.html#runtime-support
Jul 2 2018
Sorry for the delay. LGTM.
May 31 2018
Nice catch. This LGTM.
Apr 23 2018
Mar 9 2018
This all looks reasonable. Its a nice localized change to this pass. LGTM.
May 10 2017
Good catch! LGTM.
May 3 2017
This is a great improvement over what we had. LGTM.
Apr 10 2017
Sorry for forgetting to review this.
Mar 20 2017
I scrolled through fairly quickly, but everything looked fine. Looks like basically renaming and fixing formatting along the way.
Mar 13 2017
Mar 8 2017
Good point. Never thought of that. Wouldn't be surprised if there's a whole bunch of users who never use arrays and could benefit, but still something to think about more.
Very cool. Justin and I looked at ASan on BumpPtrAllocator a while ago and I think this would have been useful then too. I think the reason you didn't find issues is that he fixed many of them already.
Sep 30 2016
Whats the behavior here in terms of implicit conversions and overloading?