User Details
- User Since
- Jun 2 2014, 4:46 PM (458 w, 6 d)
Thu, Mar 16
LGTM
Mon, Feb 20
Feb 17 2023
LGTM
Looks great! I didn't see anything to fix/change.
Feb 13 2023
Updated to fix calling the correct setjmp
Jan 20 2023
LGTM
Dec 12 2022
LGTM
Oct 26 2022
Matches the other lto methods, which do the same error check. LGTM!
Oct 3 2022
Thanks for doing this! From a quick look at ld64, there are no sleb's anywhere in the Export Trie logic so LGTM.
Sep 23 2022
Sep 20 2022
LGTM. Thanks for doing this!
Yep, exactly the same contents.
Aug 24 2022
Aug 23 2022
Aug 15 2022
Jun 14 2022
LGTM
Jun 6 2022
May 24 2022
This looks good to me.
Apr 5 2022
Mar 19 2022
Overall LGTM. I don’t have a strong opinion on opaque pointers so nothing to add there.
LGTM
LGTM
LGTM
All seems very reasonable to me.
Mar 18 2022
LGTM
Mar 7 2022
Wonder if we'll find other tools with the same issue. But for now its good to fix the one we know about.
Dec 8 2021
Sep 27 2021
I forgot that field in dyld. Its implicit due to the uint64_t salt, but no harm in having it here. I'm going to add it to dyld now too :)
Dec 2 2020
LGTM. Thanks for doing this!
Sep 3 2020
LGTM
Aug 18 2020
Seems reasonable to me too.
Aug 17 2020
LGTM
Mar 4 2020
LGTM
Feb 10 2020
This shouldn't affect the final binary size as the linker is going to probably recreate the relocations and symbol table anyway, but seems fine to align this more in the object files.
Dec 16 2019
LGTM.
Nov 15 2019
LGTM
LGTM
Oct 29 2019
Sep 19 2019
LGTM
Sep 3 2019
Aug 22 2019
LGTM.
Aug 7 2019
Looks like the tests are extremely comprehensive. LGTM.
Jun 5 2019
LGTM.
May 30 2019
I'm trusting the binary blobs are good. Phab doesn't have a built in mach-o parser :)
LGTM.
May 17 2019
Looks good. That’s nice to see more lines removed than added :)
Apr 24 2019
Wow. That must be a huge test case for this to be a problem!
Apr 19 2019
LGTM.
Mar 20 2019
Mar 9 2019
LGTM.
Mar 7 2019
LGTM.
Mar 6 2019
LGTM. Thanks!
Feb 22 2019
Feb 11 2019
Looks like we can have print_protocol_list64_t also call the new print_protocol_64_t, but that can be done in a later NFC commit.
Jan 30 2019
LGTM. Thanks for fixing this!
Jan 22 2019
LGTM
Jan 2 2019
Thanks for the review. Submitted as r350284.
Dec 21 2018
Thanks for all the feedback so far. Is there anything else you'd like me to change before I can land this?
Dec 20 2018
Dec 19 2018
Dec 18 2018
Dec 17 2018
Dec 7 2018
Added test for integer argument and updated code to only accept pointer types to allocWithZone.
I added the other objc* intrinsics used by ARC in r348646.