Adds basic parsing/sema/serialization support for the #pragma omp masked
directive.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
marked->masked
clang/include/clang/AST/OpenMPClause.h | ||
---|---|---|
8244 | condition? | |
8270–8272 | Make it private | |
clang/lib/Parse/ParseOpenMP.cpp | ||
2955–2957 | Why you did not put it to the case with num_threads etc. clauses? | |
clang/lib/Sema/SemaOpenMP.cpp | ||
4727–4728 | Update a reference/text here | |
4761–4779 | Sam, update text | |
clang/test/OpenMP/masked_ast_print.cpp | ||
27 | nonconst threadid tests? |
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
2813 | This can be simplified like this: if (!FirstClause) { Diag(Tok, diag::err_omp_more_one_clause) << getOpenMPDirectiveName(DKind) << getOpenMPClauseName(CKind) << 0; ErrorFound = true; } LLVM_FALLTHROUGH; case OMPC_filter: Plus, I think, you should not exclude OMPC_filter from the check, I think only single clause is allowed by the spec. |
clang/lib/Parse/ParseOpenMP.cpp | ||
---|---|---|
2813 | I misunderstood the syntax and will fix this and the tests, thanks! |
condition?