Head files are included in the second patch in case the name needs to be changed.
RV32 / 64:
clmul
clmulh
clmulr
Paths
| Differential D99711
[RISCV] [1/2] Add intrinsic for Zbc extension ClosedPublic Authored by LevyHsu on Apr 1 2021, 2:46 AM.
Details Summary Head files are included in the second patch in case the name needs to be changed. RV32 / 64:
Diff Detail
Event TimelineHerald added subscribers: vkmr, frasercrmck, evandro and 21 others. · View Herald TranscriptApr 1 2021, 2:46 AM Herald added subscribers: llvm-commits, cfe-commits, MaskRay. · View Herald TranscriptApr 1 2021, 2:46 AM LevyHsu retitled this revision from [RISCV] [2/2] Add intrinsic for Zbc extension to [RISCV] [1/2] Add intrinsic for Zbc extension.Apr 1 2021, 2:47 AM LevyHsu added a child revision: D99712: [RISCV] [2/2] Add intrinsic for Zbc extension.Apr 1 2021, 6:14 PM LevyHsu marked 2 inline comments as done. Comment Actions
Comment Actions LGTM. We can adjust the builtin names in the future if we need to do something different to match gcc. This revision is now accepted and ready to land.Apr 1 2021, 11:04 PM Closed by commit rGf78d932cf23a: [RISCV] Add IR intrinsics for Zbc extension (authored by LevyHsu, committed by craig.topper). · Explain WhyApr 2 2021, 12:09 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 334628 clang/include/clang/Basic/BuiltinsRISCV.def
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Sema/SemaChecking.cpp
clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbc.c
clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbc.c
llvm/include/llvm/IR/IntrinsicsRISCV.td
llvm/lib/Target/RISCV/RISCVInstrInfoB.td
llvm/test/CodeGen/RISCV/rv32zbc-intrinsic.ll
llvm/test/CodeGen/RISCV/rv64zbc-intrinsic.ll
|
I think we should drop the underscore in clmul_h and clmul_r. The mnemonic doesn't have a period between them. So that's different than orc.b and crc32.w.