Page MenuHomePhabricator

evandro (Evandro Menezes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2016, 9:21 AM (245 w, 5 d)

Currently working at SiFive.

Recent Activity

Thu, Sep 17

evandro requested review of D87873: [RISCV] Merge the pipeline models for Rocket.
Thu, Sep 17, 4:58 PM · Restricted Project

Tue, Aug 25

evandro updated the diff for D85366: [RISCV] Do not mandate scheduling for CSR instructions.
Tue, Aug 25, 1:31 PM · Restricted Project

Aug 13 2020

evandro added a comment to D85366: [RISCV] Do not mandate scheduling for CSR instructions.

hasSideEffects may imply isNotDuplicable, especially when rematerializing, but the latter prevents duplication more extensively in the middle end (e.g., tail end duplication).

But why does that matter? If LLVM decides it's better to fork a code path then let it, whether it's a CSR instruction or not really does not matter, it's just I-cache usage. In fact that's another reason why I _wouldn't_ want this change to go through.

Aug 13 2020, 3:12 PM · Restricted Project

Aug 11 2020

evandro added a comment to D85366: [RISCV] Do not mandate scheduling for CSR instructions.

hasSideEffects may imply isNotDuplicable, especially when rematerializing, but the latter prevents duplication more extensively in the middle end (e.g., tail end duplication).
Indeed, isReMaterializable (default to false) applies here too.

Aug 11 2020, 2:48 PM · Restricted Project

Aug 5 2020

evandro requested review of D85366: [RISCV] Do not mandate scheduling for CSR instructions.
Aug 5 2020, 3:09 PM · Restricted Project

Jul 30 2020

evandro accepted D72031: [Scheduling] Create the missing dependency edges for store cluster.
Jul 30 2020, 4:39 PM · Restricted Project
evandro added a comment to D72031: [Scheduling] Create the missing dependency edges for store cluster.

I'm not familiar with the AMDGPU target, but the changes in these new tests seem harmless, except in CodeGen/AMDGPU/stack-realign.ll, where an instruction disappeared. Again, I'd defer to someone who works in this backend, perhaps @arsenm, to chime in.

Jul 30 2020, 7:12 AM · Restricted Project

Jul 28 2020

evandro accepted D80802: [RISCV] Upgrade RVV MC to v0.9..
Jul 28 2020, 3:19 PM · Restricted Project, Restricted Project

Jul 24 2020

evandro accepted D84139: [Scheduling] Improve group algorithm for store cluster.
Jul 24 2020, 11:48 AM · Restricted Project
evandro accepted D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 24 2020, 11:27 AM · Restricted Project

Jul 22 2020

evandro added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 22 2020, 3:31 PM · Restricted Project

Jul 21 2020

evandro added a comment to D84139: [Scheduling] Improve group algorithm for store cluster.

Other than that, it seems sensible.

Jul 21 2020, 12:52 PM · Restricted Project
evandro added a comment to D72031: [Scheduling] Create the missing dependency edges for store cluster.

The AMDGPU test change likely means nothing, but it'd be good if someone who maintains or work that target would ok it. I suggest giving it another week or so. Otherwise, it LGTM.

Jul 21 2020, 12:41 PM · Restricted Project

Jul 20 2020

evandro added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 20 2020, 9:16 PM · Restricted Project

Jul 17 2020

evandro added a comment to D80802: [RISCV] Upgrade RVV MC to v0.9..

Just a couple of nits, but otherwise it LGTM.

Jul 17 2020, 1:56 PM · Restricted Project, Restricted Project

Jul 13 2020

evandro added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 13 2020, 11:41 AM · Restricted Project

Jul 10 2020

evandro added inline comments to D83588: [TableGen][CGS] Print better errors on overlapping InstRW.
Jul 10 2020, 2:26 PM · Restricted Project

Jul 9 2020

evandro accepted D77030: [RISCV] refactor FeatureRVCHints to make ProcessorModel more intuitive.
Jul 9 2020, 8:06 AM · Restricted Project

Jul 6 2020

evandro added inline comments to D82713: Improve stack object printing..
Jul 6 2020, 2:07 PM · Restricted Project

Jul 2 2020

evandro added inline comments to D82713: Improve stack object printing..
Jul 2 2020, 3:41 PM · Restricted Project

Jun 30 2020

evandro added inline comments to D82713: Improve stack object printing..
Jun 30 2020, 4:18 PM · Restricted Project

Jun 29 2020

evandro accepted D81213: [RISCV] Support experimental v extension v0.9..

It LGTM after D80802.

Jun 29 2020, 3:32 PM · Restricted Project

Jun 25 2020

evandro added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 25 2020, 8:33 AM · Restricted Project, Restricted Project

Jun 19 2020

evandro added a comment to D81724: [MVT] Add new MVT types for RISC-V vector..

It LGTM, but it's better to wait for an OK from a couple or so of other reviewers to chime in.

Jun 19 2020, 12:32 PM · Restricted Project

Jun 15 2020

evandro added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 15 2020, 12:40 PM · Restricted Project, Restricted Project

Jun 4 2020

evandro added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Jun 4 2020, 3:30 PM · Restricted Project, Restricted Project
evandro added a comment to D80802: [RISCV] Upgrade RVV MC to v0.9..

Again, the clang part should be split in another patch and be made a child of D81188.

Jun 4 2020, 1:16 PM · Restricted Project, Restricted Project
evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

It looks pretty GTM. At this point, I'd be fine with accepting this patch as the major issues seem to have already been addressed. Should there be any other minor issue, it could be addressed later.

Jun 4 2020, 12:42 PM · Restricted Project, Restricted Project

May 8 2020

evandro added inline comments to D79409: [InstCombine] Remove hasNoInfs check for pow(C,y) -> exp2(log2(C)*y).
May 8 2020, 1:58 PM · Restricted Project

May 6 2020

evandro added a comment to D78129: Add Marvell ThunderX3T110 support.
list<Predicate> UnsupportedFeatures = !listconcat(SVEUnsupported.F, PAUnsupported.F);
May 6 2020, 5:04 PM · Restricted Project, Restricted Project
evandro added a comment to D79409: [InstCombine] Remove hasNoInfs check for pow(C,y) -> exp2(log2(C)*y).

No, the sign of log2(x) depends on whether x is less or greater than 1, not less or greater than 2.

May 6 2020, 5:04 PM · Restricted Project
evandro added a comment to D79409: [InstCombine] Remove hasNoInfs check for pow(C,y) -> exp2(log2(C)*y).

pow(x, -∞) → ∞ if |x| < 1 or 0 if |x| > 1
pow(x, +∞) → 0 if |x| < 1 or ∞ if |x| > 1
exp2(log2(x) * -∞)exp2(±∞) → ∞ if x < 2 or 0 if x > 2
exp2(log2(x) * +∞)exp2(±∞) → 0 if x < 2 or ∞ if x > 2

May 6 2020, 2:10 PM · Restricted Project
evandro added a comment to D79409: [InstCombine] Remove hasNoInfs check for pow(C,y) -> exp2(log2(C)*y).

pow(∞, y) → 0 if y < 0 or ∞ if y > 0
exp2(log2(∞) * y)exp2(∞ * y)exp2(∞) → 0 if y < 0 or ∞ if y > 0

May 6 2020, 1:00 PM · Restricted Project

May 4 2020

evandro accepted D79321: [SLC] Allow llvm.pow(2**n,x) -> llvm.exp2(n*x) even if no exp2 lib func.

LGTM

May 4 2020, 3:37 PM · Restricted Project

Mar 10 2020

evandro added inline comments to D57497: [RISCV] Passing small data limitation value to RISCV backend.
Mar 10 2020, 12:33 PM · Restricted Project
evandro added a comment to D74338: [TableGen] Support combining AssemblerPredicates with ORs.

It'd be nice if a single predicate wouldn't need all_of, but I don't feel strongly about it.

Mar 10 2020, 12:00 PM · Restricted Project

Feb 18 2020

evandro added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Feb 18 2020, 1:30 PM · Restricted Project, Restricted Project
evandro added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Feb 18 2020, 9:30 AM · Restricted Project, Restricted Project
evandro added a comment to D72031: [Scheduling] Create the missing dependency edges for store cluster.

Would it be possible to add a test case for AArch64?

Feb 18 2020, 8:53 AM · Restricted Project

Feb 14 2020

evandro committed rG4af3be7b044e: [docs] Add note on using cmake to perform the build (authored by evandro).
[docs] Add note on using cmake to perform the build
Feb 14 2020, 11:53 AM

Feb 13 2020

evandro added inline comments to D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension.
Feb 13 2020, 3:10 PM · Restricted Project
evandro added inline comments to D72930: [FEnv] Constfold some unary constrained operations.
Feb 13 2020, 12:15 PM · Restricted Project
evandro added a comment to D74338: [TableGen] Support combining AssemblerPredicates with ORs.

It's a logical addition to the semantics of features. Though at the moment RV is probably the only user of this addition, the eventual patch implementing it should not include the RV specific changes, which would be better in a separate patch.

Feb 13 2020, 11:56 AM · Restricted Project
evandro added inline comments to D74023: [RISCV] ELF attribute section for RISC-V.
Feb 13 2020, 8:42 AM · Restricted Project, Restricted Project

Feb 12 2020

evandro committed rG905ccf8b2fea: [README] Add note on using cmake to perform the build (authored by evandro).
[README] Add note on using cmake to perform the build
Feb 12 2020, 1:02 PM

Feb 4 2020

evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Shouldn't most instructions have the vtype register in Uses? Shouldn't most FP instructions have fflags in Defs?

Feb 4 2020, 4:50 PM · Restricted Project, Restricted Project

Jan 31 2020

evandro added a comment to D73643: [RISCV] Macro Fusion for RISC-V.

Please, prefix the title with [RISCV].

Jan 31 2020, 10:26 AM · Restricted Project

Jan 29 2020

evandro added inline comments to D73643: [RISCV] Macro Fusion for RISC-V.
Jan 29 2020, 11:40 AM · Restricted Project
evandro added a comment to D73643: [RISCV] Macro Fusion for RISC-V.

As @lenary said, this must be enabled only for those sub targets that actually fuse these instrs. Also, when using the macro fusion pass, you should also enable the post RA pass. Otherwise, it's less effective.

Jan 29 2020, 11:40 AM · Restricted Project

Jan 24 2020

evandro committed rG9fa0f236d501: [PATCH] [Target] Test commit (authored by evandro).
[PATCH] [Target] Test commit
Jan 24 2020, 2:00 PM
evandro committed rGf1d4dfe3bc8a: [Target] Test commit (authored by evandro).
[Target] Test commit
Jan 24 2020, 1:43 PM

Jan 23 2020

evandro committed rG838a28e234e0: [RISCV] Scheduler description for the Rocket core (authored by HsiangKai).
[RISCV] Scheduler description for the Rocket core
Jan 23 2020, 5:38 PM
evandro closed D68685: [RISCV] Scheduler description for Rocket Core.
Jan 23 2020, 5:38 PM · Restricted Project

Jan 21 2020

evandro accepted D68685: [RISCV] Scheduler description for Rocket Core.

Going thrice!

Jan 21 2020, 1:28 PM · Restricted Project

Jan 20 2020

evandro added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

It LGTM, but let's wait till tomorrow, when the patch will be 3 business days old, for any input.

Jan 20 2020, 1:32 PM · Restricted Project

Jan 16 2020

evandro added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

Except for a handful of gnats, this is really close to LGTM.

Jan 16 2020, 3:13 PM · Restricted Project

Jan 13 2020

evandro added inline comments to D68685: [RISCV] Scheduler description for Rocket Core.
Jan 13 2020, 2:02 PM · Restricted Project
evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

The major issue is should we accept/merge an extension which is not ratified/standardized.

Jan 13 2020, 1:15 PM · Restricted Project, Restricted Project

Jan 10 2020

evandro added inline comments to D71992: [ARM] Unrestrict Armv8 IT blocks.
Jan 10 2020, 12:24 PM · Restricted Project
evandro accepted D72070: [NFC] Refactor memory ops cluster method.
Jan 10 2020, 12:14 PM · Restricted Project
evandro added inline comments to D71124: [RISCV] support clang driver to select cpu.
Jan 10 2020, 11:19 AM · Restricted Project, Restricted Project
evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

It seems to me that all remarks have already been addressed. Is there anything holding this patch? For it pretty much LGTM.

Jan 10 2020, 11:10 AM · Restricted Project, Restricted Project
evandro added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

Overall, it looks nearly good enough. I don't know how the scheduler will behave is interesting cases when there is no ShedRead for each argument in the ins list of the instructions. However, it shouldn't be too difficult to add them in the instruction classes.

Jan 10 2020, 10:31 AM · Restricted Project

Nov 22 2019

evandro committed rGff0f407e90be: [MCA] Fix test cases (NFC) (authored by evandro).
[MCA] Fix test cases (NFC)
Nov 22 2019, 2:25 PM
evandro added a comment to D70066: [MacroFusion] Limit the max fused number as 2 to reduce the dependency.

Can you please clarify how the existing implementation hurts the scheduler and when fused pairs are then broken?

Nov 22 2019, 1:48 PM · Restricted Project
evandro added a comment to D69998: [MacroFusion] Create the missing artificial edges if there are more than 2 SU fused..

At first glance, this patch seems sensible, but I'm not sure that D70066 is necessary.

Nov 22 2019, 1:48 PM · Restricted Project
evandro committed rG48b7fe02a114: [AArch64] Add the pipeline model for Exynos M5 (authored by evandro).
[AArch64] Add the pipeline model for Exynos M5
Nov 22 2019, 1:29 PM

Nov 20 2019

evandro committed rG9bdfee2a3bd1: [AArch64] Add the pipeline model for Exynos M5 (authored by evandro).
[AArch64] Add the pipeline model for Exynos M5
Nov 20 2019, 3:02 PM

Nov 12 2019

evandro committed rG9b1e86f0cb47: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 12 2019, 12:47 PM
evandro committed rG98856e3943de: [AArch64] Fix addressing mode predicates (authored by evandro).
[AArch64] Fix addressing mode predicates
Nov 12 2019, 12:47 PM

Nov 11 2019

evandro committed rG2eb9233034ca: [AArch64] Add new scheduling predicates (authored by evandro).
[AArch64] Add new scheduling predicates
Nov 11 2019, 1:07 PM
evandro committed rGc19528f18093: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 11 2019, 1:07 PM

Nov 4 2019

evandro committed rG4cbe10efc201: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 4 2019, 2:26 PM

Oct 31 2019

evandro committed rG80c03fb5c275: [mca] Fix test case (NFC) (authored by evandro).
[mca] Fix test case (NFC)
Oct 31 2019, 2:53 PM
evandro committed rGf9af4ccb8a1c: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Oct 31 2019, 1:26 PM

Oct 30 2019

evandro committed rG215da6606c0e: [clang][llvm] Obsolete Exynos M1 and M2 (authored by evandro).
[clang][llvm] Obsolete Exynos M1 and M2
Oct 30 2019, 1:07 PM
evandro committed rG42c8fae9d1b0: [AArch64] Remove overlapping scheduling definitions (NFC) (authored by evandro).
[AArch64] Remove overlapping scheduling definitions (NFC)
Oct 30 2019, 12:00 PM
evandro closed D68353: [AArch64] Remove overlapping definitions (NFC).
Oct 30 2019, 12:00 PM · Restricted Project

Oct 17 2019

evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

🔔 ¡Ping! 🔔

Oct 17 2019, 10:04 AM · Restricted Project

Oct 11 2019

evandro added a comment to D67199: [InstCombine] Expand the simplification of log().

For the record, the issue reported in PR43617 was fixed by rL374243 and a test case was added by rL374453.

Oct 11 2019, 11:30 AM · Restricted Project

Oct 10 2019

evandro committed rG8bd42769816a: [InstCombine] Add test case for PR43617 (NFC) (authored by evandro).
[InstCombine] Add test case for PR43617 (NFC)
Oct 10 2019, 2:34 PM
evandro committed rL374453: [InstCombine] Add test case for PR43617 (NFC).
[InstCombine] Add test case for PR43617 (NFC)
Oct 10 2019, 2:34 PM

Oct 9 2019

evandro committed rGd2f4c452d9e6: [InstCombine] Fix PR43617 (authored by evandro).
[InstCombine] Fix PR43617
Oct 9 2019, 3:05 PM
evandro committed rL374243: [InstCombine] Fix PR43617.
[InstCombine] Fix PR43617
Oct 9 2019, 3:04 PM
evandro updated subscribers of D67199: [InstCombine] Expand the simplification of log().
Oct 9 2019, 1:29 PM · Restricted Project
evandro committed rGc57a9dc487e3: [AMDGPU] Use math constants defined in MathExtras (NFC) (authored by evandro).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Oct 9 2019, 1:01 PM
evandro committed rGe60415a0db2b: [Support] Add mathematical constants (authored by evandro).
[Support] Add mathematical constants
Oct 9 2019, 1:01 PM
evandro closed D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 9 2019, 1:01 PM · Restricted Project
evandro committed rL374208: [AMDGPU] Use math constants defined in MathExtras (NFC).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Oct 9 2019, 1:01 PM
evandro committed rL374207: [Support] Add mathematical constants.
[Support] Add mathematical constants
Oct 9 2019, 1:01 PM
evandro closed D68257: [Support] Add mathematical constants.
Oct 9 2019, 1:00 PM · Restricted Project
evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

Ping! 🔔

Oct 9 2019, 12:26 PM · Restricted Project
evandro added a comment to D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 9 2019, 12:25 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 9 2019, 12:23 PM · Restricted Project

Oct 8 2019

evandro updated the diff for D68257: [Support] Add mathematical constants.

Added the hex FP constants for easier auditing.

Oct 8 2019, 12:59 PM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.

@efriedma, you had a point. I now trimmed the precision down to one digit short of seeing a change in the mantissa bits.

Oct 8 2019, 12:03 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 8 2019, 8:54 AM · Restricted Project

Oct 7 2019

evandro added inline comments to D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.
Oct 7 2019, 3:21 PM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Oct 7 2019, 3:08 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 7 2019, 3:00 PM · Restricted Project