Page MenuHomePhabricator

evandro (Evandro Menezes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2016, 9:21 AM (210 w, 3 d)

Currently working at SiFive.

Recent Activity

Yesterday

evandro added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

Except for a handful of gnats, this is really close to LGTM.

Thu, Jan 16, 3:13 PM · Restricted Project

Wed, Jan 15

Herald updated subscribers of D53613: RFC: Explicit Vector Length Intrinsics and Attributes.
Wed, Jan 15, 4:06 PM · Restricted Project

Mon, Jan 13

evandro added inline comments to D68685: [RISCV] Scheduler description for Rocket Core.
Mon, Jan 13, 2:02 PM · Restricted Project
evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

The major issue is should we accept/merge an extension which is not ratified/standardized.

Mon, Jan 13, 1:15 PM · Restricted Project

Fri, Jan 10

evandro added inline comments to D71992: [ARM] Unrestrict Armv8 IT blocks.
Fri, Jan 10, 12:24 PM · Restricted Project
evandro accepted D72070: [NFC] Refactor memory ops cluster method.
Fri, Jan 10, 12:14 PM · Restricted Project
evandro added inline comments to D71124: [RISCV] support clang driver to select cpu.
Fri, Jan 10, 11:19 AM · Restricted Project
evandro added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

It seems to me that all remarks have already been addressed. Is there anything holding this patch? For it pretty much LGTM.

Fri, Jan 10, 11:10 AM · Restricted Project
evandro added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

Overall, it looks nearly good enough. I don't know how the scheduler will behave is interesting cases when there is no ShedRead for each argument in the ins list of the instructions. However, it shouldn't be too difficult to add them in the instruction classes.

Fri, Jan 10, 10:31 AM · Restricted Project

Nov 22 2019

evandro committed rGff0f407e90be: [MCA] Fix test cases (NFC) (authored by evandro).
[MCA] Fix test cases (NFC)
Nov 22 2019, 2:25 PM
evandro added a comment to D70066: [MacroFusion] Limit the max fused number as 2 to reduce the dependency.

Can you please clarify how the existing implementation hurts the scheduler and when fused pairs are then broken?

Nov 22 2019, 1:48 PM · Restricted Project
evandro added a comment to D69998: [MacroFusion] Create the missing artificial edges if there are more than 2 SU fused..

At first glance, this patch seems sensible, but I'm not sure that D70066 is necessary.

Nov 22 2019, 1:48 PM · Restricted Project
evandro committed rG48b7fe02a114: [AArch64] Add the pipeline model for Exynos M5 (authored by evandro).
[AArch64] Add the pipeline model for Exynos M5
Nov 22 2019, 1:29 PM

Nov 20 2019

evandro committed rG9bdfee2a3bd1: [AArch64] Add the pipeline model for Exynos M5 (authored by evandro).
[AArch64] Add the pipeline model for Exynos M5
Nov 20 2019, 3:02 PM

Nov 12 2019

evandro committed rG9b1e86f0cb47: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 12 2019, 12:47 PM
evandro committed rG98856e3943de: [AArch64] Fix addressing mode predicates (authored by evandro).
[AArch64] Fix addressing mode predicates
Nov 12 2019, 12:47 PM

Nov 11 2019

evandro committed rG2eb9233034ca: [AArch64] Add new scheduling predicates (authored by evandro).
[AArch64] Add new scheduling predicates
Nov 11 2019, 1:07 PM
evandro committed rGc19528f18093: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 11 2019, 1:07 PM

Nov 4 2019

evandro committed rG4cbe10efc201: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Nov 4 2019, 2:26 PM

Oct 31 2019

evandro committed rG80c03fb5c275: [mca] Fix test case (NFC) (authored by evandro).
[mca] Fix test case (NFC)
Oct 31 2019, 2:53 PM
Herald updated subscribers of D59514: [PGO] Profile guided code size optimization..
Oct 31 2019, 1:29 PM · Restricted Project
evandro committed rGf9af4ccb8a1c: [AArch64] Update for Exynos (authored by evandro).
[AArch64] Update for Exynos
Oct 31 2019, 1:26 PM

Oct 30 2019

evandro committed rG215da6606c0e: [clang][llvm] Obsolete Exynos M1 and M2 (authored by evandro).
[clang][llvm] Obsolete Exynos M1 and M2
Oct 30 2019, 1:07 PM
evandro committed rG42c8fae9d1b0: [AArch64] Remove overlapping scheduling definitions (NFC) (authored by evandro).
[AArch64] Remove overlapping scheduling definitions (NFC)
Oct 30 2019, 12:00 PM
evandro closed D68353: [AArch64] Remove overlapping definitions (NFC).
Oct 30 2019, 12:00 PM · Restricted Project

Oct 17 2019

evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

🔔 ¡Ping! 🔔

Oct 17 2019, 10:04 AM · Restricted Project

Oct 11 2019

evandro added a comment to D67199: [InstCombine] Expand the simplification of log().

For the record, the issue reported in PR43617 was fixed by rL374243 and a test case was added by rL374453.

Oct 11 2019, 11:30 AM · Restricted Project

Oct 10 2019

evandro committed rG8bd42769816a: [InstCombine] Add test case for PR43617 (NFC) (authored by evandro).
[InstCombine] Add test case for PR43617 (NFC)
Oct 10 2019, 2:34 PM
evandro committed rL374453: [InstCombine] Add test case for PR43617 (NFC).
[InstCombine] Add test case for PR43617 (NFC)
Oct 10 2019, 2:34 PM

Oct 9 2019

evandro committed rGd2f4c452d9e6: [InstCombine] Fix PR43617 (authored by evandro).
[InstCombine] Fix PR43617
Oct 9 2019, 3:05 PM
evandro committed rL374243: [InstCombine] Fix PR43617.
[InstCombine] Fix PR43617
Oct 9 2019, 3:04 PM
evandro updated subscribers of D67199: [InstCombine] Expand the simplification of log().
Oct 9 2019, 1:29 PM · Restricted Project
evandro committed rGc57a9dc487e3: [AMDGPU] Use math constants defined in MathExtras (NFC) (authored by evandro).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Oct 9 2019, 1:01 PM
evandro committed rGe60415a0db2b: [Support] Add mathematical constants (authored by evandro).
[Support] Add mathematical constants
Oct 9 2019, 1:01 PM
evandro closed D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 9 2019, 1:01 PM · Restricted Project
evandro committed rL374208: [AMDGPU] Use math constants defined in MathExtras (NFC).
[AMDGPU] Use math constants defined in MathExtras (NFC)
Oct 9 2019, 1:01 PM
evandro committed rL374207: [Support] Add mathematical constants.
[Support] Add mathematical constants
Oct 9 2019, 1:01 PM
evandro closed D68257: [Support] Add mathematical constants.
Oct 9 2019, 1:00 PM · Restricted Project
evandro added a comment to D68353: [AArch64] Remove overlapping definitions (NFC).

Ping! 🔔

Oct 9 2019, 12:26 PM · Restricted Project
evandro added a comment to D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 9 2019, 12:25 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 9 2019, 12:23 PM · Restricted Project

Oct 8 2019

evandro updated the diff for D68257: [Support] Add mathematical constants.

Added the hex FP constants for easier auditing.

Oct 8 2019, 12:59 PM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.

@efriedma, you had a point. I now trimmed the precision down to one digit short of seeing a change in the mantissa bits.

Oct 8 2019, 12:03 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 8 2019, 8:54 AM · Restricted Project

Oct 7 2019

evandro added inline comments to D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.
Oct 7 2019, 3:21 PM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Oct 7 2019, 3:08 PM · Restricted Project
evandro added inline comments to D68257: [Support] Add mathematical constants.
Oct 7 2019, 3:00 PM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Oct 7 2019, 12:24 PM · Restricted Project
evandro added a comment to D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func.

Indeed, it seemed to be a coarse check in case the following transformations end up calling pow(). However, the only transformation that calls pow() is when shrinking to powf(), which itself chacks for the availability of this routine. So this patch seems to address this issue the wrong way. It seems that removing this check would be better.

Oct 7 2019, 12:13 PM · Restricted Project

Oct 5 2019

evandro updated the diff for D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 5 2019, 9:59 AM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.
Oct 5 2019, 9:52 AM · Restricted Project

Oct 2 2019

evandro created D68353: [AArch64] Remove overlapping definitions (NFC).
Oct 2 2019, 12:58 PM · Restricted Project
evandro committed rGe139a73c5fc1: [TableGen] Improve error reporting of overlapping definitions (NFC) (authored by evandro).
[TableGen] Improve error reporting of overlapping definitions (NFC)
Oct 2 2019, 12:44 PM
evandro committed rL373514: [TableGen] Improve error reporting of overlapping definitions (NFC).
[TableGen] Improve error reporting of overlapping definitions (NFC)
Oct 2 2019, 12:42 PM
evandro added a comment to D68257: [Support] Add mathematical constants.

Maybe take std::numbers implementation - llvm::numbers?

Oct 2 2019, 10:33 AM · Restricted Project

Oct 1 2019

evandro added a child revision for D68257: [Support] Add mathematical constants: D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 1 2019, 11:27 AM · Restricted Project
evandro added a parent revision for D68285: [AMDGPU] Use math constants defined in MathExtras (NFC): D68257: [Support] Add mathematical constants.
Oct 1 2019, 11:27 AM · Restricted Project
evandro created D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 1 2019, 11:27 AM · Restricted Project
evandro updated the diff for D68257: [Support] Add mathematical constants.

Split the changes to the AMDGPU target in a separate patch.

Oct 1 2019, 11:22 AM · Restricted Project

Sep 30 2019

evandro created D68257: [Support] Add mathematical constants.
Sep 30 2019, 9:09 PM · Restricted Project
evandro committed rG41ead4281fad: [SimplifyLibCalls] Define the value of the Euler number (authored by evandro).
[SimplifyLibCalls] Define the value of the Euler number
Sep 30 2019, 4:20 PM
evandro committed rL373274: [SimplifyLibCalls] Define the value of the Euler number.
[SimplifyLibCalls] Define the value of the Euler number
Sep 30 2019, 4:20 PM
evandro committed rG22cb3d2e58f4: [ConstantFolding] Fold constant calls to log2() (authored by evandro).
[ConstantFolding] Fold constant calls to log2()
Sep 30 2019, 1:53 PM
evandro committed rG110b1138baf4: [InstCombine] Expand the simplification of log() (authored by evandro).
[InstCombine] Expand the simplification of log()
Sep 30 2019, 1:51 PM
evandro committed rL373262: [ConstantFolding] Fold constant calls to log2().
[ConstantFolding] Fold constant calls to log2()
Sep 30 2019, 1:51 PM
evandro closed D67300: [ConstantFolding] Fold constant calls to log2().
Sep 30 2019, 1:51 PM · Restricted Project
evandro committed rL373261: [InstCombine] Expand the simplification of log().
[InstCombine] Expand the simplification of log()
Sep 30 2019, 1:50 PM
evandro closed D67199: [InstCombine] Expand the simplification of log().
Sep 30 2019, 1:50 PM · Restricted Project

Sep 25 2019

evandro committed rG3bd8ba156b52: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets (authored by evandro).
[CodeGen] Replace -max-jump-table-size with -max-jump-table-targets
Sep 25 2019, 9:12 AM
evandro committed rL372893: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
[CodeGen] Replace -max-jump-table-size with -max-jump-table-targets
Sep 25 2019, 9:09 AM
evandro closed D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 25 2019, 9:09 AM · Restricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Thank you.

Sep 25 2019, 9:05 AM · Restricted Project

Sep 24 2019

evandro added a comment to D67199: [InstCombine] Expand the simplification of log().

Ping! 🔔

Sep 24 2019, 1:58 PM · Restricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

🤦🏻‍♂️

Sep 24 2019, 11:07 AM · Restricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 24 2019, 11:07 AM · Restricted Project

Sep 23 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 23 2019, 11:30 AM · Restricted Project

Sep 20 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 20 2019, 12:50 PM · Restricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 20 2019, 12:29 PM · Restricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 20 2019, 11:18 AM · Restricted Project

Sep 19 2019

evandro committed rGa4da991e4a4e: [AArch64] Fix formatting (NFC) (authored by evandro).
[AArch64] Fix formatting (NFC)
Sep 19 2019, 2:49 PM
evandro committed rL372357: [AArch64] Fix formatting (NFC).
[AArch64] Fix formatting (NFC)
Sep 19 2019, 2:48 PM

Sep 18 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 18 2019, 8:23 AM · Restricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 18 2019, 8:16 AM · Restricted Project

Sep 17 2019

evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Update the patch Including the suggested refactoring.

Sep 17 2019, 9:52 AM · Restricted Project
evandro added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Sep 17 2019, 8:32 AM · Restricted Project
evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Thank you.

Sep 17 2019, 8:25 AM · Restricted Project

Sep 16 2019

evandro updated the diff for D67199: [InstCombine] Expand the simplification of log().
Sep 16 2019, 11:21 AM · Restricted Project
evandro added inline comments to D67199: [InstCombine] Expand the simplification of log().
Sep 16 2019, 11:00 AM · Restricted Project

Sep 12 2019

evandro added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Running llc -O1 3 times on the byte code from a.i in the "reduced some more" archive:

  • Before: average of 38.383s ± 0.064s
  • After: average of 38.440s ± 0.049s
Sep 12 2019, 5:07 PM · Restricted Project
evandro committed rG08df6e64d570: [ConstantFolding] Expand folding of some library functions (authored by evandro).
[ConstantFolding] Expand folding of some library functions
Sep 12 2019, 2:25 PM
evandro committed rL371774: [ConstantFolding] Expand folding of some library functions.
[ConstantFolding] Expand folding of some library functions
Sep 12 2019, 2:22 PM
evandro closed D67468: [ConstantFolding] Expand folding of some library functions.
Sep 12 2019, 2:21 PM · Restricted Project
evandro updated the diff for D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

Please, stand by for numbers.

Sep 12 2019, 1:01 PM · Restricted Project
evandro added a comment to D67497: [aarch64] move custom isel of extract_vector_elt to td file - NFC.

Is there a test case that checks that this change does not break what the code in AArch64DAGToDAGISel::Select() was meant to handle?

Sep 12 2019, 7:57 AM · Restricted Project

Sep 11 2019

evandro committed rGed5f45264554: [ConstantFolding] Refactor math functions to use LLVM ones (NFC) (authored by evandro).
[ConstantFolding] Refactor math functions to use LLVM ones (NFC)
Sep 11 2019, 2:47 PM
evandro committed rL371677: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
[ConstantFolding] Refactor math functions to use LLVM ones (NFC)
Sep 11 2019, 2:45 PM
evandro closed D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
Sep 11 2019, 2:45 PM · Restricted Project
evandro added a parent revision for D67468: [ConstantFolding] Expand folding of some library functions: D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC).
Sep 11 2019, 2:29 PM · Restricted Project
evandro added a child revision for D67459: [ConstantFolding] Refactor math functions to use LLVM ones (NFC): D67468: [ConstantFolding] Expand folding of some library functions.
Sep 11 2019, 2:28 PM · Restricted Project
evandro created D67468: [ConstantFolding] Expand folding of some library functions.
Sep 11 2019, 2:28 PM · Restricted Project