evandro (Evandro Menezes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2016, 9:21 AM (145 w, 4 d)

Currently working at the Samsung Austin R&D Center on the Samsung next generation ARM cores.

Recent Activity

Fri, Oct 19

evandro committed rL344814: [NFC][InstCombine] Undo stray change.
[NFC][InstCombine] Undo stray change
Fri, Oct 19, 2:00 PM

Tue, Oct 16

evandro committed rL344632: [PATCH] [NFC][AArch64] Fix refactoring of macro fusion.
[PATCH] [NFC][AArch64] Fix refactoring of macro fusion
Tue, Oct 16, 10:43 AM
evandro committed rL344625: [NFC][ARM] Refactor macro fusion.
[NFC][ARM] Refactor macro fusion
Tue, Oct 16, 10:21 AM
evandro committed rL344624: [NFC][AArch64] Refactor macro fusion.
[NFC][AArch64] Refactor macro fusion
Tue, Oct 16, 10:21 AM

Fri, Oct 12

evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.

Rather than a feature in AArch.td, I'd prefer a line in AArch64Subtarget::initializeProperties().

Fri, Oct 12, 9:19 AM

Wed, Oct 10

evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.

I'm getting mixed results on Exynos, with significant improvements and regressions. I'd like to run more tests, but, at the moment, I'd rather that this feature would be gated, either as @jfb or @rengolin suggested.

Wed, Oct 10, 2:44 PM
evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.
In D32564#1259703, @jfb wrote:

Do you have an ETA?

Wed, Oct 10, 8:25 AM

Tue, Oct 9

evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.

Is that in trunk? I can't see any obvious candidates with a git grep -i exynos. If not, it's probably not relevant to this review.

Tue, Oct 9, 3:28 PM
evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.
In D32564#1259155, @jfb wrote:

Do you have specific worries? Or at least a timeline? Seems the patch can be reviewed without waiting for your exploration.

Tue, Oct 9, 1:40 PM
evandro updated subscribers of D32564: AArch64: compress jump tables to minimum size needed to reach destinations.
Tue, Oct 9, 11:01 AM
evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.

This is good data. However, I'd like to evaluate this patch a bit further on Exynos, if I may.

Tue, Oct 9, 11:00 AM

Mon, Oct 8

evandro added a comment to D32564: AArch64: compress jump tables to minimum size needed to reach destinations.

Can you please provide some figures on the code size saved and the effect on the performance of this change?

Mon, Oct 8, 1:48 PM

Mon, Oct 1

evandro committed rL343489: [AArch64] Refactor cheap cost model.
[AArch64] Refactor cheap cost model
Mon, Oct 1, 9:13 AM

Fri, Sep 28

evandro committed rL343354: [AArch64] Split zero cycle feature more granularly.
[AArch64] Split zero cycle feature more granularly
Fri, Sep 28, 12:06 PM
evandro closed D52621: [AArch64] Split zero cycle feature more granularly.
Fri, Sep 28, 12:06 PM

Thu, Sep 27

evandro created D52621: [AArch64] Split zero cycle feature more granularly.
Thu, Sep 27, 10:41 AM

Mon, Sep 24

evandro committed rL342900: [ARM] Adjust the cost model for Exynos.
[ARM] Adjust the cost model for Exynos
Mon, Sep 24, 9:36 AM
evandro committed rL342899: [ARM] Adjust the feature set for Exynos.
[ARM] Adjust the feature set for Exynos
Mon, Sep 24, 9:36 AM

Sep 19 2018

evandro accepted D52256: AArch64: Add FuseCryptoEOR fusion rules.

Me likes it.

Sep 19 2018, 1:12 PM
evandro committed rL342585: [ARM] Adjust the feature set for Exynos.
[ARM] Adjust the feature set for Exynos
Sep 19 2018, 12:52 PM
evandro committed rL342583: [ARM] Refactor Exynos feature set (NFC).
[ARM] Refactor Exynos feature set (NFC)
Sep 19 2018, 12:44 PM
evandro added inline comments to D52256: AArch64: Add FuseCryptoEOR fusion rules.
Sep 19 2018, 8:52 AM

Aug 30 2018

evandro committed rL341101: [ARM] Adjust the feature set for Exynos.
[ARM] Adjust the feature set for Exynos
Aug 30 2018, 12:22 PM
evandro committed rL341095: [InstCombine] Expand the simplification of pow() into exp2().
[InstCombine] Expand the simplification of pow() into exp2()
Aug 30 2018, 12:07 PM
evandro closed D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 30 2018, 12:07 PM
evandro added a comment to D49273: [InstCombine] Expand the simplification of pow() into exp2().

@rnk has kindly reduced the issue to:

Aug 30 2018, 12:07 PM
evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().

Add more tests.

Aug 30 2018, 10:36 AM
evandro requested review of D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 30 2018, 10:28 AM
evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().

Guard this transformation against targets that lack support for exp2(). In this case, refrain from transforming into either an intrinsic or a libcall.

Aug 30 2018, 10:08 AM
evandro reopened D49273: [InstCombine] Expand the simplification of pow() into exp2().

Windows lacks exp2() support.

Aug 30 2018, 9:58 AM
evandro added a comment to D51435: [SLC] Support expanding pow(x, n+0.5) to x * x * ... * sqrt(x).

Yes, it makes sense.

Aug 30 2018, 9:09 AM
evandro added inline comments to D51435: [SLC] Support expanding pow(x, n+0.5) to x * x * ... * sqrt(x).
Aug 30 2018, 8:40 AM
evandro updated subscribers of D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 30 2018, 8:30 AM

Aug 29 2018

evandro added a comment to D51435: [SLC] Support expanding pow(x, n+0.5) to x * x * ... * sqrt(x).

LGTM, but, please, wait for @spatel's agreement.

Aug 29 2018, 3:23 PM
evandro added inline comments to D51435: [SLC] Support expanding pow(x, n+0.5) to x * x * ... * sqrt(x).
Aug 29 2018, 12:54 PM
evandro committed rL340948: [InstCombine] Expand the simplification of pow() with nested exp{,2}().
[InstCombine] Expand the simplification of pow() with nested exp{,2}()
Aug 29 2018, 11:01 AM
evandro closed D51195: [InstCombine] Expand the simplification of pow() with nested exp{,2}().
Aug 29 2018, 11:01 AM
evandro committed rL340947: [InstCombine] Expand the simplification of pow() into exp2().
[InstCombine] Expand the simplification of pow() into exp2()
Aug 29 2018, 11:00 AM
evandro closed D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 29 2018, 11:00 AM

Aug 28 2018

evandro added a comment to D49273: [InstCombine] Expand the simplification of pow() into exp2().

Are there any negative tests where the base is not a power-of-2? If not, please add at least 1 test like that to make sure we're not transforming that.

Aug 28 2018, 12:34 PM

Aug 27 2018

evandro committed rL340784: [PATCH] [InstCombine] Fix issue in the simplification of pow() with nested exp{….
[PATCH] [InstCombine] Fix issue in the simplification of pow() with nested exp{…
Aug 27 2018, 3:12 PM
evandro closed D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().
Aug 27 2018, 3:12 PM
evandro updated the diff for D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().

Address the case when the result from exp{,2}() is reused elsewhere.

Aug 27 2018, 2:44 PM
evandro added a comment to D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().

The function pow_exp2_libcall() in the test case is one such example without readnone. I'll augment the test case with a reuse scenario.

Aug 27 2018, 9:11 AM

Aug 23 2018

evandro added a dependent revision for D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}(): D51195: [InstCombine] Expand the simplification of pow() with nested exp{,2}().
Aug 23 2018, 4:08 PM
evandro added a dependency for D51195: [InstCombine] Expand the simplification of pow() with nested exp{,2}(): D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().
Aug 23 2018, 4:08 PM
evandro created D51195: [InstCombine] Expand the simplification of pow() with nested exp{,2}().
Aug 23 2018, 4:08 PM
evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().

Rebase after D51194.

Aug 23 2018, 4:05 PM
evandro added a dependency for D49273: [InstCombine] Expand the simplification of pow() into exp2(): D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().
Aug 23 2018, 3:58 PM
evandro added a dependent revision for D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}(): D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 23 2018, 3:58 PM
evandro created D51194: [InstCombine] Fix issue in the simplification of pow() with nested exp{,2}().
Aug 23 2018, 3:57 PM
evandro retitled D49273: [InstCombine] Expand the simplification of pow() into exp2() from [InstCombine] Expand the simplification of pow() into exp{,2}() to [InstCombine] Expand the simplification of pow() into exp2().
Aug 23 2018, 1:37 PM
evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 23 2018, 12:35 PM

Aug 22 2018

evandro committed rL340476: [NFC] Refactor simplification of pow().
[NFC] Refactor simplification of pow()
Aug 22 2018, 4:19 PM
evandro added a comment to D49273: [InstCombine] Expand the simplification of pow() into exp2().

Increased test coverage in rL340462, where I also identified an issue with pow(exp{,2}(x), y).

Aug 22 2018, 3:45 PM
evandro committed rL340462: [NFC] Expand test cases for simplifying pow().
[NFC] Expand test cases for simplifying pow()
Aug 22 2018, 3:45 PM

Aug 17 2018

evandro added a comment to D50900: [SimplifyLibCalls] Support pow(x, -0.5) in replacePowWithSqrt without NSZ/noInfs..

We were also thinking about expanding pow(x, n+0.5) -> x * x * x * ... * sqrt(x). Is this something you have also planned on adding?

Aug 17 2018, 2:17 PM
evandro added a comment to D50900: [SimplifyLibCalls] Support pow(x, -0.5) in replacePowWithSqrt without NSZ/noInfs..

Can you please rebase it, for D50036 touched the same function?

Aug 17 2018, 1:05 PM
evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().

Rebase after the preliminary patches rL340060 and rL340061.

Aug 17 2018, 11:12 AM
evandro committed rL340061: [InstCombine] Refactor the simplification of pow() (NFC).
[InstCombine] Refactor the simplification of pow() (NFC)
Aug 17 2018, 11:00 AM
evandro committed rL340060: [NFC] Expand test cases for simplifying pow().
[NFC] Expand test cases for simplifying pow()
Aug 17 2018, 11:00 AM
evandro updated subscribers of D49306: [SLC] Simplify pow(x, 0.25) to sqrt(sqrt(x)).
Aug 17 2018, 8:03 AM
evandro updated subscribers of D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x).
Aug 17 2018, 8:02 AM
evandro updated subscribers of D50035: [SLC] Expand simplification of pow() for vector types.
Aug 17 2018, 8:01 AM
evandro updated subscribers of D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).
Aug 17 2018, 8:01 AM
evandro updated subscribers of D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 17 2018, 8:00 AM

Aug 16 2018

evandro committed rL339900: [NFC] Fix typo in test cases.
[NFC] Fix typo in test cases
Aug 16 2018, 10:04 AM
evandro added a comment to D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).

Thank you.

Aug 16 2018, 8:59 AM
evandro committed rL339887: [InstCombine] Expand the simplification of pow(x, 0.5) to sqrt(x).
[InstCombine] Expand the simplification of pow(x, 0.5) to sqrt(x)
Aug 16 2018, 8:59 AM
evandro closed D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).
Aug 16 2018, 8:58 AM

Aug 15 2018

evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 15 2018, 11:47 AM
evandro updated the diff for D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).
Aug 15 2018, 11:45 AM

Aug 14 2018

evandro added inline comments to D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).
Aug 14 2018, 9:28 AM
evandro added inline comments to D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).
Aug 14 2018, 8:56 AM
evandro added inline comments to D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 14 2018, 8:46 AM
evandro added a comment to D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).

I'll commit the data type changes increasing type diversity on the side.

Aug 14 2018, 8:41 AM

Aug 13 2018

evandro committed rL339578: [SLC] Expand simplification of pow() for vector types.
[SLC] Expand simplification of pow() for vector types
Aug 13 2018, 9:13 AM
evandro closed D50035: [SLC] Expand simplification of pow() for vector types.
Aug 13 2018, 9:13 AM

Aug 10 2018

evandro added a comment to D50035: [SLC] Expand simplification of pow() for vector types.

The dependent patches can be found in the Stack below: D49273 and D50036.

Aug 10 2018, 2:19 PM
evandro added a comment to D50035: [SLC] Expand simplification of pow() for vector types.

Thank you.

Aug 10 2018, 1:52 PM
evandro edited dependencies for D49273: [InstCombine] Expand the simplification of pow() into exp2(), added: 1; removed: 1.
Aug 10 2018, 11:20 AM
evandro removed a dependent revision for D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x): D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 10 2018, 11:20 AM
evandro added a dependent revision for D50035: [SLC] Expand simplification of pow() for vector types: D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 10 2018, 11:20 AM
evandro added inline comments to D50035: [SLC] Expand simplification of pow() for vector types.
Aug 10 2018, 11:17 AM
evandro updated the diff for D50035: [SLC] Expand simplification of pow() for vector types.

Added test for shrinking pow() when simplifying libcalls is disabled.

Aug 10 2018, 11:17 AM
evandro added inline comments to D50035: [SLC] Expand simplification of pow() for vector types.
Aug 10 2018, 8:47 AM

Aug 9 2018

evandro updated the diff for D49273: [InstCombine] Expand the simplification of pow() into exp2().

Remove additional simplification when exp10() is the base in pow(), since it's not enabled by many targets.

Aug 9 2018, 3:02 PM
evandro updated the summary of D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 9 2018, 2:28 PM
evandro removed a dependency for D49273: [InstCombine] Expand the simplification of pow() into exp2(): D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x).
Aug 9 2018, 2:23 PM
evandro removed a dependent revision for D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x): D49273: [InstCombine] Expand the simplification of pow() into exp2().
Aug 9 2018, 2:23 PM
evandro abandoned D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x).

OK, then.

Aug 9 2018, 2:20 PM
evandro added inline comments to D50035: [SLC] Expand simplification of pow() for vector types.
Aug 9 2018, 1:42 PM
evandro committed rL339356: [ARM] Adjust the feature set for Exynos.
[ARM] Adjust the feature set for Exynos
Aug 9 2018, 9:35 AM
evandro closed D50396: [ARM] Replace processor check with feature.

Closed by commit rL339354

Aug 9 2018, 9:16 AM
evandro committed rL339354: [ARM] Replace processor check with feature.
[ARM] Replace processor check with feature
Aug 9 2018, 9:14 AM

Aug 7 2018

evandro added a comment to D50036: [SLC] Expand the simplification of pow(x, 0.5) to sqrt(x).

Ping! 🔔

Aug 7 2018, 11:14 AM
evandro added a comment to D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x).

Ping! 🔔

Aug 7 2018, 11:14 AM
evandro added a comment to D49273: [InstCombine] Expand the simplification of pow() into exp2().

Ping! 🔔

Aug 7 2018, 11:13 AM
evandro created D50396: [ARM] Replace processor check with feature.
Aug 7 2018, 10:05 AM

Aug 6 2018

evandro committed rL339046: [SLC] Fix shrinking of pow().
[SLC] Fix shrinking of pow()
Aug 6 2018, 12:40 PM