Page MenuHomePhabricator

evandro (Evandro Menezes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2016, 9:21 AM (163 w, 3 d)

Currently working at the Samsung Austin R&D Center on the Samsung next generation ARM cores.

Recent Activity

Mon, Feb 11

evandro added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.

Commited extra float C99 functions in rGf4a369596f7b.

Mon, Feb 11, 2:16 PM · Restricted Project
evandro committed rGf4a369596f7b: [TargetLibraryInfo] Update run time support for Windows (authored by evandro).
[TargetLibraryInfo] Update run time support for Windows
Mon, Feb 11, 2:13 PM
evandro committed rL353758: [TargetLibraryInfo] Update run time support for Windows.
[TargetLibraryInfo] Update run time support for Windows
Mon, Feb 11, 2:12 PM
evandro committed rG4b86c474ff10: [TargetLibraryInfo] Update run time support for Windows (authored by evandro).
[TargetLibraryInfo] Update run time support for Windows
Mon, Feb 11, 11:03 AM
evandro committed rL353733: [TargetLibraryInfo] Update run time support for Windows.
[TargetLibraryInfo] Update run time support for Windows
Mon, Feb 11, 11:02 AM
evandro closed D57625: [TargetLibraryInfo] Update run time support for Windows.
Mon, Feb 11, 11:02 AM · Restricted Project
evandro added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Mon, Feb 11, 8:48 AM · Restricted Project

Thu, Feb 7

evandro updated subscribers of D57625: [TargetLibraryInfo] Update run time support for Windows.
Thu, Feb 7, 1:19 PM · Restricted Project
evandro accepted D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

After the nsz check is addressed, it LGTM.

Thu, Feb 7, 8:40 AM · Restricted Project
evandro added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

@evandro Why do we want to add new cases in test/Transforms/InstCombine/pow-sqrt.ll? Am I right that InstCombine tests opt? This new changes happen in llc.

Thu, Feb 7, 8:37 AM · Restricted Project

Wed, Feb 6

evandro updated the diff for D57625: [TargetLibraryInfo] Update run time support for Windows.

Separated functions between VC19 and float.

Wed, Feb 6, 11:30 AM · Restricted Project
evandro added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Wed, Feb 6, 10:11 AM · Restricted Project
evandro added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Wed, Feb 6, 9:41 AM · Restricted Project

Tue, Feb 5

evandro updated the diff for D57625: [TargetLibraryInfo] Update run time support for Windows.

Assume VC19 as the default. However, I wonder if this should be the default earlier, in the clang driver.

Tue, Feb 5, 6:34 PM · Restricted Project
evandro updated the summary of D57625: [TargetLibraryInfo] Update run time support for Windows.
Tue, Feb 5, 5:26 PM · Restricted Project
evandro updated the diff for D57625: [TargetLibraryInfo] Update run time support for Windows.

Restrict the improvements to VS2015.

Tue, Feb 5, 5:22 PM · Restricted Project
evandro added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Tue, Feb 5, 3:18 PM · Restricted Project
evandro added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Tue, Feb 5, 3:15 PM · Restricted Project
evandro added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.
In D57625#1386061, @rnk wrote:

Do we know when most of these were added? Did the all arrive in more or less the same version? It would be nice to make this conditional on a new enough environment version. That gives users a way to indicate that they are targetting an old CRT if they need to.

Tue, Feb 5, 3:03 PM · Restricted Project
evandro updated the diff for D57625: [TargetLibraryInfo] Update run time support for Windows.

Rebase.

Tue, Feb 5, 12:27 PM · Restricted Project
evandro committed rGe5bb58b11593: [TargetLibraryInfo] Regroup run time functions for Windows (NFC) (authored by evandro).
[TargetLibraryInfo] Regroup run time functions for Windows (NFC)
Tue, Feb 5, 12:24 PM
evandro committed rL353213: [TargetLibraryInfo] Regroup run time functions for Windows (NFC).
[TargetLibraryInfo] Regroup run time functions for Windows (NFC)
Tue, Feb 5, 12:24 PM
evandro updated the diff for D57625: [TargetLibraryInfo] Update run time support for Windows.

Include ARM.

Tue, Feb 5, 9:46 AM · Restricted Project
evandro added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.

But the other point still stands; even if compiling LLVM requires VS 2015 or newer, the generated code can work with older MSVC runtimes as well. @rnk - is there any declared minimum for this? I'm using Clang with MSVC 2013 SDK/runtimes just fine in one setup at least (although this setup currently uses Clang/LLVM 4.0, I haven't recently retested it with latest). AFAIK, the exact version of MSVC that is targeted is kept available via Triplet::getEnvironmentVersion, so unless it's intended to drop support for all the older runtimes as well, this would have to check the version of it.

Tue, Feb 5, 9:34 AM · Restricted Project

Mon, Feb 4

evandro committed rG98f356cd74ad: Revert "[PATCH] [TargetLibraryInfo] Update run time support for Windows" (authored by evandro).
Revert "[PATCH] [TargetLibraryInfo] Update run time support for Windows"
Mon, Feb 4, 3:36 PM
evandro committed rGd01676377419: [ADT] Refactor the Windows query functions (NFC) (authored by evandro).
[ADT] Refactor the Windows query functions (NFC)
Mon, Feb 4, 3:36 PM
evandro committed rL353118: Revert "[PATCH] [TargetLibraryInfo] Update run time support for Windows".
Revert "[PATCH] [TargetLibraryInfo] Update run time support for Windows"
Mon, Feb 4, 3:35 PM
evandro committed rL353117: [ADT] Refactor the Windows query functions (NFC).
[ADT] Refactor the Windows query functions (NFC)
Mon, Feb 4, 3:35 PM
evandro committed rGff5527718d5d: [PATCH] [TargetLibraryInfo] Update run time support for Windows (authored by evandro).
[PATCH] [TargetLibraryInfo] Update run time support for Windows
Mon, Feb 4, 3:31 PM
evandro committed rL353114: [PATCH] [TargetLibraryInfo] Update run time support for Windows.
[PATCH] [TargetLibraryInfo] Update run time support for Windows
Mon, Feb 4, 3:30 PM
evandro added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.

(And it also works with mingw which normally uses an ancient msvcrt.)

Mon, Feb 4, 2:39 PM · Restricted Project

Fri, Feb 1

evandro created D57625: [TargetLibraryInfo] Update run time support for Windows.
Fri, Feb 1, 3:08 PM · Restricted Project
evandro committed rL352935: [InstCombine] Refactor test checks (NFC).
[InstCombine] Refactor test checks (NFC)
Fri, Feb 1, 2:52 PM
evandro committed rL352917: [InstCombine] Expand Windows test (NFC).
[InstCombine] Expand Windows test (NFC)
Fri, Feb 1, 1:14 PM
evandro committed rL352908: [InstCombine] Expand Windows test (NFC).
[InstCombine] Expand Windows test (NFC)
Fri, Feb 1, 12:42 PM
evandro committed rL352895: [InstCombine] Refactor test checks (NFC).
[InstCombine] Refactor test checks (NFC)
Fri, Feb 1, 10:34 AM
evandro committed rL352892: [InstCombine] Expand Windows test (NFC).
[InstCombine] Expand Windows test (NFC)
Fri, Feb 1, 9:39 AM
evandro committed rL352886: [InstCombine] Refactor test checks (NFC).
[InstCombine] Refactor test checks (NFC)
Fri, Feb 1, 8:57 AM

Thu, Jan 31

evandro added inline comments to D57044: [AArch64] OOptimize floating point materialization.
Thu, Jan 31, 2:06 PM · Restricted Project
evandro added inline comments to D57044: [AArch64] OOptimize floating point materialization.
Thu, Jan 31, 1:35 PM · Restricted Project

Wed, Jan 30

evandro committed rL352714: [InstCombine] Expand testing for Windows (NFC).
[InstCombine] Expand testing for Windows (NFC)
Wed, Jan 30, 5:41 PM
evandro committed rL352707: [InstCombine] Simplify check clauses in test (NFC).
[InstCombine] Simplify check clauses in test (NFC)
Wed, Jan 30, 4:51 PM
evandro added a comment to D57434: Optimize pow(X, 0.75) to sqrt(X) * sqrt(sqrt(X)).

Please, add a test for AArch64 and new cases in test/Transforms/InstCombine/pow-sqrt.ll as well.

Wed, Jan 30, 10:59 AM · Restricted Project

Jan 14 2019

evandro committed rL351149: [AArch64] Adjust the feature set for Exynos.
[AArch64] Adjust the feature set for Exynos
Jan 14 2019, 5:57 PM
evandro committed rL351144: [AArch64] Fix typo (NFC).
[AArch64] Fix typo (NFC)
Jan 14 2019, 5:05 PM
evandro committed rL351143: [AArch64] Fix typo (NFC).
[AArch64] Fix typo (NFC)
Jan 14 2019, 4:24 PM
evandro committed rL351139: [AArch64] Add new target feature to fuse arithmetic and logic operations.
[AArch64] Add new target feature to fuse arithmetic and logic operations
Jan 14 2019, 3:58 PM
evandro closed D56572: [AArch64] Add new target feature to fuse arithmetic and logic operations.
Jan 14 2019, 3:58 PM

Jan 11 2019

evandro committed rL350986: [ARM] Fix typo.
[ARM] Fix typo
Jan 11 2019, 5:12 PM
evandro updated the diff for D56572: [AArch64] Add new target feature to fuse arithmetic and logic operations.

Replaced the test case with a MIR file.

Jan 11 2019, 2:45 PM
evandro committed rL350976: [AArch64] Improve Exynos predicates.
[AArch64] Improve Exynos predicates
Jan 11 2019, 2:44 PM
evandro committed rL350961: [llvm-mca] Update tests for Exynos (NFC).
[llvm-mca] Update tests for Exynos (NFC)
Jan 11 2019, 11:40 AM
evandro committed rL350960: [AArch64] Add pipeline model for Exynos M4.
[AArch64] Add pipeline model for Exynos M4
Jan 11 2019, 11:40 AM
evandro committed rC350954: [test] Update support for Exynos M4 (NFC).
[test] Update support for Exynos M4 (NFC)
Jan 11 2019, 11:00 AM
evandro committed rL350954: [test] Update support for Exynos M4 (NFC).
[test] Update support for Exynos M4 (NFC)
Jan 11 2019, 11:00 AM
evandro committed rL350953: [AArch64] Create feature set for Exynos M4.
[AArch64] Create feature set for Exynos M4
Jan 11 2019, 11:00 AM
evandro updated the diff for D56572: [AArch64] Add new target feature to fuse arithmetic and logic operations.

I'm afraid that I'll need more time to craft the MIR file. Then, I might as well do the same for the other fusion tests.

Jan 11 2019, 9:41 AM
evandro added a comment to D56572: [AArch64] Add new target feature to fuse arithmetic and logic operations.

Would it be possible to have a MIR test here, which just runs the scheduler?

Jan 11 2019, 8:43 AM
evandro updated subscribers of rL350661: [llvm-mca] Improve debugging (NFC).
Jan 11 2019, 8:38 AM

Jan 10 2019

evandro created D56572: [AArch64] Add new target feature to fuse arithmetic and logic operations.
Jan 10 2019, 5:40 PM

Jan 9 2019

evandro committed rL350777: [llvm-mca] Display masks in hex.
[llvm-mca] Display masks in hex
Jan 9 2019, 4:01 PM

Jan 8 2019

evandro committed rL350663: [AArch64] Adjust the cost model for Exynos.
[AArch64] Adjust the cost model for Exynos
Jan 8 2019, 2:35 PM
evandro committed rL350662: [llvm-mca] Update the Exynos test cases (NFC).
[llvm-mca] Update the Exynos test cases (NFC)
Jan 8 2019, 2:35 PM
evandro committed rL350661: [llvm-mca] Improve debugging (NFC).
[llvm-mca] Improve debugging (NFC)
Jan 8 2019, 2:35 PM

Jan 4 2019

evandro committed rL350434: [AArch64] Adjust the cost model for Exynos M3.
[AArch64] Adjust the cost model for Exynos M3
Jan 4 2019, 1:06 PM

Jan 3 2019

evandro committed rL350332: [AArch64] Add new scheduling predicates.
[AArch64] Add new scheduling predicates
Jan 3 2019, 9:31 AM

Dec 21 2018

evandro committed rL349918: [AArch64] Refactor Exynos predicate (NFC).
[AArch64] Refactor Exynos predicate (NFC)
Dec 21 2018, 7:55 AM

Dec 19 2018

evandro committed rL349688: [llvm-mca] Rename directory for the Cortex tests (NFC).
[llvm-mca] Rename directory for the Cortex tests (NFC)
Dec 19 2018, 2:28 PM
evandro committed rL349687: [llvm-mca] Update Exynos test cases (NFC).
[llvm-mca] Update Exynos test cases (NFC)
Dec 19 2018, 2:28 PM
evandro committed rL349686: [AArch64] Improve Exynos predicates.
[AArch64] Improve Exynos predicates
Dec 19 2018, 2:28 PM
evandro committed rL349685: [AArch64] Use canonical copy idiom.
[AArch64] Use canonical copy idiom
Dec 19 2018, 2:28 PM
evandro committed rL349652: [AArch64] Improve the Exynos M3 pipeline model.
[AArch64] Improve the Exynos M3 pipeline model
Dec 19 2018, 9:41 AM
evandro committed rL349651: [llvm-mca] Split test (NFC).
[llvm-mca] Split test (NFC)
Dec 19 2018, 9:40 AM

Dec 18 2018

evandro committed rL349569: [AArch64] Simplify the Exynos M3 pipeline model.
[AArch64] Simplify the Exynos M3 pipeline model
Dec 18 2018, 3:23 PM
evandro committed rL349568: [AArch64] Fix instructions order (NFC).
[AArch64] Fix instructions order (NFC)
Dec 18 2018, 3:23 PM
evandro committed rL349567: [llvm-mca] Improve test (NFC).
[llvm-mca] Improve test (NFC)
Dec 18 2018, 3:23 PM
evandro committed rL349537: [llvm-mca] Update the Exynos test cases (NFC).
[llvm-mca] Update the Exynos test cases (NFC)
Dec 18 2018, 12:49 PM
evandro committed rL349536: [llvm-mca] Dump mask in hex.
[llvm-mca] Dump mask in hex
Dec 18 2018, 12:49 PM

Dec 14 2018

evandro committed rL349185: [AArch64] Simplify the scheduling predicates (NFC).
[AArch64] Simplify the scheduling predicates (NFC)
Dec 14 2018, 12:08 PM

Dec 13 2018

evandro committed rL349091: [AArch64] Fix Exynos predicates (NFC).
[AArch64] Fix Exynos predicates (NFC)
Dec 13 2018, 3:23 PM

Dec 10 2018

evandro committed rL348774: [AArch64] Refactor the Exynos scheduling predicates.
[AArch64] Refactor the Exynos scheduling predicates
Dec 10 2018, 9:21 AM
evandro closed D55345: [AArch64] Refactor the Exynos scheduling predicates.
Dec 10 2018, 9:21 AM
evandro added an edge to rL348766: [llvm-mca] Add new tests for Exynos (NFC): D55345: [AArch64] Refactor the Exynos scheduling predicates.
Dec 10 2018, 8:53 AM
evandro added 1 commit(s) for D55345: [AArch64] Refactor the Exynos scheduling predicates: rL348766: [llvm-mca] Add new tests for Exynos (NFC).
Dec 10 2018, 8:53 AM
evandro updated the diff for D55345: [AArch64] Refactor the Exynos scheduling predicates.
Dec 10 2018, 8:49 AM
evandro committed rL348768: [AArch64] Refactor the scheduling predicates.
[AArch64] Refactor the scheduling predicates
Dec 10 2018, 8:27 AM
evandro closed D55375: [AArch64] Refactor the scheduling predicates.
Dec 10 2018, 8:27 AM
evandro committed rL348766: [llvm-mca] Add new tests for Exynos (NFC).
[llvm-mca] Add new tests for Exynos (NFC)
Dec 10 2018, 8:26 AM

Dec 6 2018

evandro committed rL348565: [llvm-mca] Improve test (NFC).
[llvm-mca] Improve test (NFC)
Dec 6 2018, 7:26 PM
evandro committed rL348564: [llvm-mca] Improve test (NFC).
[llvm-mca] Improve test (NFC)
Dec 6 2018, 7:26 PM
evandro added inline comments to D55375: [AArch64] Refactor the scheduling predicates.
Dec 6 2018, 3:49 PM
evandro updated the diff for D55345: [AArch64] Refactor the Exynos scheduling predicates.

Sorry, I was juggling too many patches out of order.

Dec 6 2018, 10:45 AM
evandro updated the diff for D55375: [AArch64] Refactor the scheduling predicates.
Dec 6 2018, 10:43 AM
evandro added a comment to D55375: [AArch64] Refactor the scheduling predicates.

Note that I made this patch a predecessor for D55345.

Dec 6 2018, 10:34 AM
evandro added an edge to rL348510: [AArch64] Fix Exynos predicate: D55375: [AArch64] Refactor the scheduling predicates.
Dec 6 2018, 10:32 AM
evandro added 1 commit(s) for D55375: [AArch64] Refactor the scheduling predicates: rL348510: [AArch64] Fix Exynos predicate.
Dec 6 2018, 10:32 AM
evandro committed rL348510: [AArch64] Fix Exynos predicate.
[AArch64] Fix Exynos predicate
Dec 6 2018, 10:30 AM
evandro updated the diff for D55345: [AArch64] Refactor the Exynos scheduling predicates.

Rebase the patch.

Dec 6 2018, 8:43 AM
evandro added a parent revision for D55345: [AArch64] Refactor the Exynos scheduling predicates: D55375: [AArch64] Refactor the scheduling predicates.
Dec 6 2018, 8:41 AM
evandro added a child revision for D55375: [AArch64] Refactor the scheduling predicates: D55345: [AArch64] Refactor the Exynos scheduling predicates.
Dec 6 2018, 8:41 AM