Currently working at SiFive.
User Details
- User Since
- Jan 5 2016, 9:21 AM (263 w, 2 d)
Fri, Jan 15
Mon, Jan 11
Fri, Jan 8
If you happen to have a test case, please, consider adding it.
Thu, Jan 7
Wed, Jan 6
Tue, Jan 5
Mon, Jan 4
LGTM
LGTM
Wed, Dec 23
Address @HsiangKai's comments.
Dec 22 2020
Dec 21 2020
Dec 18 2020
LGTM
Dec 14 2020
RV32 tests are also needed, please.
LGTM, but, please, see if any of the lint notices can be addressed before committing.
Dec 11 2020
Dec 10 2020
The default should be ta and mu. The compiler is usually agnostic about the tail of the vector, but usually assumes that masked elements are preserved.
Dec 7 2020
Dec 5 2020
Dec 4 2020
Nov 25 2020
Nov 24 2020
Nov 23 2020
Nov 6 2020
Oct 23 2020
Oct 19 2020
Supporting old names without change of function is sensible, but, in this case, the bit fields in satp are different from stpbr. Then, the sensible result should be an error, because the code does need to be ported to the new version of the spec.
Oct 16 2020
Oct 15 2020
This is a wider discussion, but I would favor following the ratified specs, with exceptions on specific cases. I would also favor that the toolchain would enforce compliance on its own, even if more currently than an official, yet non compliant, compliance test suite.
Note: this patch maintains backwards compatibility with a preliminary spec.
Oct 14 2020
I agree with @jrtc27. What's the motivation to support a register name obsoleted by a ratified spec?
Oct 13 2020
It LGTM, but it's better to wait a couple of days before committing in order to give others time to comment.
Oct 5 2020
Oct 2 2020
Sep 29 2020
LGTM
Sep 25 2020
Sep 24 2020
Sep 22 2020
Sep 21 2020
Sep 17 2020
Aug 25 2020
Aug 13 2020
Aug 11 2020
hasSideEffects may imply isNotDuplicable, especially when rematerializing, but the latter prevents duplication more extensively in the middle end (e.g., tail end duplication).
Indeed, isReMaterializable (default to false) applies here too.
Aug 5 2020
Jul 30 2020
I'm not familiar with the AMDGPU target, but the changes in these new tests seem harmless, except in CodeGen/AMDGPU/stack-realign.ll, where an instruction disappeared. Again, I'd defer to someone who works in this backend, perhaps @arsenm, to chime in.
Jul 28 2020
Jul 24 2020
Jul 22 2020
Jul 21 2020
Other than that, it seems sensible.
The AMDGPU test change likely means nothing, but it'd be good if someone who maintains or work that target would ok it. I suggest giving it another week or so. Otherwise, it LGTM.
Jul 20 2020
Jul 17 2020
Just a couple of nits, but otherwise it LGTM.
Jul 13 2020
Jul 10 2020
Jul 9 2020
Jul 6 2020
Jul 2 2020
Jun 30 2020
Jun 29 2020
It LGTM after D80802.
Jun 25 2020
Jun 19 2020
It LGTM, but it's better to wait for an OK from a couple or so of other reviewers to chime in.
Jun 15 2020
Jun 4 2020
Again, the clang part should be split in another patch and be made a child of D81188.
It looks pretty GTM. At this point, I'd be fine with accepting this patch as the major issues seem to have already been addressed. Should there be any other minor issue, it could be addressed later.
May 8 2020
May 6 2020
pow(x, -∞) → ∞ if |x| < 1 or 0 if |x| > 1
pow(x, +∞) → 0 if |x| < 1 or ∞ if |x| > 1
exp2(log2(x) * -∞) → exp2(±∞) → ∞ if x < 2 or 0 if x > 2
exp2(log2(x) * +∞) → exp2(±∞) → 0 if x < 2 or ∞ if x > 2