Page MenuHomePhabricator

jyknight (James Y Knight)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2015, 11:23 AM (204 w, 21 h)

Recent Activity

Yesterday

jyknight updated the diff for D58548: IR: Support parsing numeric block ids, and emit them in textual output..

Minor tweaks per comments.

Fri, Feb 22, 2:50 PM · Restricted Project, Restricted Project
jyknight added a comment to D58548: IR: Support parsing numeric block ids, and emit them in textual output..

I like this idea, and I don’t think the textual IR central is too important. A few things:

  • Changes to the IR should always be discussed on llvm-dev. Did this already happen?
Fri, Feb 22, 12:12 PM · Restricted Project, Restricted Project
jyknight updated the diff for D58548: IR: Support parsing numeric block ids, and emit them in textual output..

Add some wording to LangRef and clang-format.

Fri, Feb 22, 12:12 PM · Restricted Project, Restricted Project
jyknight created D58548: IR: Support parsing numeric block ids, and emit them in textual output..
Fri, Feb 22, 7:27 AM · Restricted Project, Restricted Project

Wed, Feb 20

jyknight added a comment to D57601: Seperate volatility and atomicity/ordering in SelectionDAG.

Question for Reviewers: Going through uses of isVolatile in backend code, I see suspicious bits in Lania, ARM, and Hexagon. What's the best way to handle this? I can easily apply the workaround I mention for out of tree backends, or I could make them equally conservative for isAtomic. The other in tree backends appear to be fine, though I'd welcome review from folks knowledgeable of non-x86 backends.

Wed, Feb 20, 9:48 AM

Tue, Feb 19

jyknight added inline comments to D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics.
Tue, Feb 19, 10:05 AM · Restricted Project
jyknight added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Tue, Feb 19, 7:08 AM · Restricted Project, Restricted Project

Sat, Feb 16

jyknight added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

I still don't like it...It's different, unusual, and IMO surprising to have such a wildcard ignore.

Sat, Feb 16, 5:09 PM

Fri, Feb 15

jyknight added a comment to D58260: [INLINER] allow inlining of address taken blocks.

I'm concerned that "nocapture" is not sufficient to describe the necessary property here.

Fri, Feb 15, 12:21 PM · Restricted Project
jyknight added inline comments to D58260: [INLINER] allow inlining of address taken blocks.
Fri, Feb 15, 10:31 AM · Restricted Project

Wed, Feb 13

jyknight added a comment to D58091: Customize warnings for missing built-in type.

I think this warning (-Wbuiltin-requires-header) doesn't really make sense as its own warning.

Wed, Feb 13, 8:28 PM · Restricted Project
jyknight added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

OK, I'm happy with all of that.

Wed, Feb 13, 12:31 PM · Restricted Project
jyknight accepted D58120: [Builtins] Treat `bcmp` as a builtin..

Looks reasonable to me.

Wed, Feb 13, 11:09 AM · Restricted Project

Mon, Feb 11

jyknight added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

It'd be great to see this somewhat more widely publicized, outside of just the clang community. If libc implementors are aware of the gains and are willing to provide an actually-faster bcmp implementation, it'd be a lot better, than having this optimization that doesn't really optimize anything without users providing their own bcmp implementation.

Mon, Feb 11, 10:34 AM · Restricted Project

Sat, Feb 9

jyknight committed rG751fe286dc39: [opaque pointer types] Cleanup CGBuilder's Create*GEP. (authored by jyknight).
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Sat, Feb 9, 2:22 PM
jyknight committed rC353629: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Sat, Feb 9, 2:22 PM
jyknight committed rL353629: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Sat, Feb 9, 2:22 PM
jyknight closed D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
Sat, Feb 9, 2:22 PM · Restricted Project, Restricted Project

Fri, Feb 8

jyknight committed rGae2f95121969: [opaque pointer types] Update calls to CreateCall to pass the function type in… (authored by jyknight).
[opaque pointer types] Update calls to CreateCall to pass the function type in…
Fri, Feb 8, 11:32 AM
jyknight committed rLLDB353549: [opaque pointer types] Update calls to CreateCall to pass the function.
[opaque pointer types] Update calls to CreateCall to pass the function
Fri, Feb 8, 11:31 AM
jyknight committed rL353549: [opaque pointer types] Update calls to CreateCall to pass the function.
[opaque pointer types] Update calls to CreateCall to pass the function
Fri, Feb 8, 11:31 AM
jyknight committed rGf5f1b0e59eb7: [opaque pointer types] Cleanup CGBuilder's Create*GEP. (authored by jyknight).
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Fri, Feb 8, 7:34 AM
jyknight committed rC353529: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Fri, Feb 8, 7:34 AM
jyknight committed rL353529: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
[opaque pointer types] Cleanup CGBuilder's Create*GEP.
Fri, Feb 8, 7:34 AM
jyknight closed D57766: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
Fri, Feb 8, 7:34 AM · Restricted Project, Restricted Project

Wed, Feb 6

jyknight committed rGcfe8cd7e06aa: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke. (authored by jyknight).
[opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.
Wed, Feb 6, 5:17 PM
jyknight committed rL353356: [opaque pointer types] Make EmitCall pass Function Types to.
[opaque pointer types] Make EmitCall pass Function Types to
Wed, Feb 6, 5:16 PM
jyknight committed rC353356: [opaque pointer types] Make EmitCall pass Function Types to.
[opaque pointer types] Make EmitCall pass Function Types to
Wed, Feb 6, 5:16 PM
jyknight closed D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke..
Wed, Feb 6, 5:16 PM · Restricted Project
jyknight committed rGf7321540d518: [opaque pointer types] Pass through function types for TLS initialization and… (authored by jyknight).
[opaque pointer types] Pass through function types for TLS initialization and…
Wed, Feb 6, 5:16 PM
jyknight committed rL353355: [opaque pointer types] Pass through function types for TLS.
[opaque pointer types] Pass through function types for TLS
Wed, Feb 6, 5:14 PM
jyknight committed rC353355: [opaque pointer types] Pass through function types for TLS.
[opaque pointer types] Pass through function types for TLS
Wed, Feb 6, 5:14 PM
jyknight closed D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls..
Wed, Feb 6, 5:14 PM · Restricted Project

Tue, Feb 5

jyknight created D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke..
Tue, Feb 5, 7:36 PM · Restricted Project
jyknight created D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls..
Tue, Feb 5, 6:40 PM · Restricted Project
jyknight committed rGab4f7f144a63: Fix MSVC constructor call extension after b92d290e48e9 (r353181). (authored by jyknight).
Fix MSVC constructor call extension after b92d290e48e9 (r353181).
Tue, Feb 5, 4:06 PM
jyknight committed rC353246: Fix MSVC constructor call extension after b92d290e48e9 (r353181)..
Fix MSVC constructor call extension after b92d290e48e9 (r353181).
Tue, Feb 5, 4:06 PM
jyknight committed rL353246: Fix MSVC constructor call extension after b92d290e48e9 (r353181)..
Fix MSVC constructor call extension after b92d290e48e9 (r353181).
Tue, Feb 5, 4:05 PM
jyknight closed D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181)..
Tue, Feb 5, 4:05 PM · Restricted Project, Restricted Project
jyknight created D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181)..
Tue, Feb 5, 3:32 PM · Restricted Project, Restricted Project
jyknight committed rG76f787424d45: [opaque pointer types] More trivial changes to pass FunctionType to CallInst. (authored by jyknight).
[opaque pointer types] More trivial changes to pass FunctionType to CallInst.
Tue, Feb 5, 11:18 AM
jyknight committed rL353199: [opaque pointer types] More trivial changes to pass FunctionType to CallInst..
[opaque pointer types] More trivial changes to pass FunctionType to CallInst.
Tue, Feb 5, 11:17 AM
jyknight committed rC353199: [opaque pointer types] More trivial changes to pass FunctionType to CallInst..
[opaque pointer types] More trivial changes to pass FunctionType to CallInst.
Tue, Feb 5, 11:17 AM
jyknight committed rG3d2df5ab83b4: Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*. (authored by jyknight).
Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*.
Tue, Feb 5, 11:02 AM
jyknight committed rL353197: Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*..
Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*.
Tue, Feb 5, 11:02 AM
jyknight committed rC353197: Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*..
Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*.
Tue, Feb 5, 11:02 AM
jyknight created D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
Tue, Feb 5, 9:31 AM · Restricted Project, Restricted Project
jyknight created D57766: [opaque pointer types] Cleanup CGBuilder's Create*GEP..
Tue, Feb 5, 9:31 AM · Restricted Project, Restricted Project
jyknight committed rG9871db064d3e: [opaque pointer types] Pass function types for runtime function calls. (authored by jyknight).
[opaque pointer types] Pass function types for runtime function calls.
Tue, Feb 5, 8:43 AM
jyknight committed rL353184: [opaque pointer types] Pass function types for runtime function calls..
[opaque pointer types] Pass function types for runtime function calls.
Tue, Feb 5, 8:42 AM
jyknight committed rC353184: [opaque pointer types] Pass function types for runtime function calls..
[opaque pointer types] Pass function types for runtime function calls.
Tue, Feb 5, 8:42 AM
jyknight closed D57668: [opaque pointer types] Pass function types for runtime function calls..
Tue, Feb 5, 8:42 AM · Restricted Project
jyknight committed rGb92d290e48e9: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases. (authored by jyknight).
[opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.
Tue, Feb 5, 8:06 AM
jyknight committed rL353181: [opaque pointer types] Fix the CallInfo passed to EmitCall in some.
[opaque pointer types] Fix the CallInfo passed to EmitCall in some
Tue, Feb 5, 8:05 AM
jyknight committed rC353181: [opaque pointer types] Fix the CallInfo passed to EmitCall in some.
[opaque pointer types] Fix the CallInfo passed to EmitCall in some
Tue, Feb 5, 8:05 AM
jyknight closed D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases..
Tue, Feb 5, 8:05 AM · Restricted Project

Mon, Feb 4

jyknight added inline comments to D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases..
Mon, Feb 4, 6:52 PM · Restricted Project
jyknight updated the diff for D57668: [opaque pointer types] Pass function types for runtime function calls..

Address comment.

Mon, Feb 4, 6:47 PM · Restricted Project
jyknight added inline comments to D57668: [opaque pointer types] Pass function types for runtime function calls..
Mon, Feb 4, 6:45 PM · Restricted Project

Sun, Feb 3

jyknight created D57668: [opaque pointer types] Pass function types for runtime function calls..
Sun, Feb 3, 3:06 PM · Restricted Project
jyknight committed rG8799caee8db3: [opaque pointer types] Trivial changes towards CallInst requiring explicit… (authored by jyknight).
[opaque pointer types] Trivial changes towards CallInst requiring explicit…
Sun, Feb 3, 1:54 PM
jyknight committed rC353009: [opaque pointer types] Trivial changes towards CallInst requiring.
[opaque pointer types] Trivial changes towards CallInst requiring
Sun, Feb 3, 1:54 PM
jyknight committed rL353009: [opaque pointer types] Trivial changes towards CallInst requiring.
[opaque pointer types] Trivial changes towards CallInst requiring
Sun, Feb 3, 1:54 PM
jyknight created D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases..
Sun, Feb 3, 1:18 PM · Restricted Project

Fri, Feb 1

jyknight committed rC352946: Remove redundant FunctionDecl argument from a couple functions..
Remove redundant FunctionDecl argument from a couple functions.
Fri, Feb 1, 5:48 PM
jyknight committed rL352946: Remove redundant FunctionDecl argument from a couple functions..
Remove redundant FunctionDecl argument from a couple functions.
Fri, Feb 1, 5:48 PM
jyknight committed rL352911: [opaque pointer types] Pass value type to LoadInst creation..
[opaque pointer types] Pass value type to LoadInst creation.
Fri, Feb 1, 12:45 PM
jyknight committed rL352913: [opaque pointer types] Pass value type to GetElementPtr creation..
[opaque pointer types] Pass value type to GetElementPtr creation.
Fri, Feb 1, 12:45 PM
jyknight closed D57173: [opaque pointer types] Pass value type to GetElementPtr creation..
Fri, Feb 1, 12:45 PM · Restricted Project
jyknight committed rL352914: [opaque pointer types] Pass function type for CallBase::setCalledFunction..
[opaque pointer types] Pass function type for CallBase::setCalledFunction.
Fri, Feb 1, 12:45 PM
jyknight closed D57174: [opaque pointer types] Pass function type for CallBase::setCalledFunction..
Fri, Feb 1, 12:44 PM · Restricted Project
jyknight closed D57172: [opaque pointer types] Pass value type to LoadInst creation..
Fri, Feb 1, 12:44 PM · Restricted Project
jyknight committed rL352909: [opaque pointer types] Pass function types to CallInst creation..
[opaque pointer types] Pass function types to CallInst creation.
Fri, Feb 1, 12:43 PM
jyknight committed rL352910: [opaque pointer types] Pass function types to InvokeInst creation..
[opaque pointer types] Pass function types to InvokeInst creation.
Fri, Feb 1, 12:43 PM
jyknight closed D57171: [opaque pointer types] Pass function types to InvokeInst creation..
Fri, Feb 1, 12:43 PM · Restricted Project
jyknight closed D57170: [opaque pointer types] Pass function types to CallInst creation..
Fri, Feb 1, 12:43 PM · Restricted Project
jyknight committed rL352903: Hopefully fix a couple more sphinx doc errors..
Hopefully fix a couple more sphinx doc errors.
Fri, Feb 1, 11:40 AM
jyknight committed rLLD352887: Fix some sphinx doc errors..
Fix some sphinx doc errors.
Fri, Feb 1, 9:07 AM
jyknight committed rC352887: Fix some sphinx doc errors..
Fix some sphinx doc errors.
Fri, Feb 1, 9:06 AM
jyknight committed rL352887: Fix some sphinx doc errors..
Fix some sphinx doc errors.
Fri, Feb 1, 9:06 AM

Thu, Jan 31

jyknight committed rL352830: Fix compilation of examples after 13680223b9d8 / r352827.
Fix compilation of examples after 13680223b9d8 / r352827
Thu, Jan 31, 7:23 PM
jyknight committed rL352827: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Thu, Jan 31, 6:28 PM
jyknight committed rC352827: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Thu, Jan 31, 6:28 PM
jyknight committed rC352800: Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it.".
Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it."
Thu, Jan 31, 1:52 PM
jyknight committed rL352800: Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it.".
Revert "[opaque pointer types] Add a FunctionCallee wrapper type, and use it."
Thu, Jan 31, 1:52 PM
jyknight committed rL352795: Fix compilation error with GCC after r352791..
Fix compilation error with GCC after r352791.
Thu, Jan 31, 1:21 PM
jyknight committed rL352791: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Thu, Jan 31, 12:36 PM
jyknight committed rC352791: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
[opaque pointer types] Add a FunctionCallee wrapper type, and use it.
Thu, Jan 31, 12:36 PM
jyknight closed D57315: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
Thu, Jan 31, 12:35 PM
jyknight accepted D57525: Allow old toolchain on sanitizer-windows.

I've no idea whether buildbot auto-updates or if it requires someone to go manually poke it, but this at least looks reasonable.

Thu, Jan 31, 12:06 PM · Restricted Project
jyknight added inline comments to D57315: [opaque pointer types] Add a FunctionCallee wrapper type, and use it..
Thu, Jan 31, 10:49 AM

Wed, Jan 30

jyknight committed rL352679: Update the "Useful Links" leftbar to point to GitHub..
Update the "Useful Links" leftbar to point to GitHub.
Wed, Jan 30, 1:59 PM

Tue, Jan 29

jyknight committed rL352595: Cleanup: replace uses of CallSite with CallBase..
Cleanup: replace uses of CallSite with CallBase.
Tue, Jan 29, 6:55 PM
jyknight committed rC352595: Cleanup: replace uses of CallSite with CallBase..
Cleanup: replace uses of CallSite with CallBase.
Tue, Jan 29, 6:55 PM
jyknight committed rC352535: Fix the behavior of clang's -w flag..
Fix the behavior of clang's -w flag.
Tue, Jan 29, 11:33 AM
jyknight committed rL352535: Fix the behavior of clang's -w flag..
Fix the behavior of clang's -w flag.
Tue, Jan 29, 11:33 AM
jyknight closed D53199: Fix the behavior of clang's -w flag..
Tue, Jan 29, 11:33 AM
jyknight added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

Mmm, I think this adding a default /* ignore is setting us up for problems. I'd be okay with a default ignore for '/build*', though.

Tue, Jan 29, 10:52 AM
jyknight committed rL352516: Add .clang-tidy and .clang-format files to the toplevel of the.
Add .clang-tidy and .clang-format files to the toplevel of the
Tue, Jan 29, 8:45 AM
jyknight committed rCXXA352514: Adjust documentation for git migration..
Adjust documentation for git migration.
Tue, Jan 29, 8:39 AM