Page MenuHomePhabricator

jyknight (James Y Knight)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2015, 11:23 AM (374 w, 1 h)

Recent Activity

Wed, May 25

jyknight committed rG997b072e10d2: C++ DR2394: Const-default-constructible for members. (authored by jyknight).
C++ DR2394: Const-default-constructible for members.
Wed, May 25, 11:58 AM · Restricted Project, Restricted Project
jyknight closed D126170: C++ DR2394: Const-default-constructible for members..
Wed, May 25, 11:57 AM · Restricted Project, Restricted Project
jyknight accepted D125814: Improve the strict prototype diagnostic behavior.
Wed, May 25, 11:04 AM · Restricted Project, Restricted Project
jyknight committed rG18e6b8234a0d: Allow pointer types for atomicrmw xchg (authored by tkf).
Allow pointer types for atomicrmw xchg
Wed, May 25, 9:24 AM · Restricted Project, Restricted Project
jyknight closed D124728: Allow pointer types for atomicrmw xchg.
Wed, May 25, 9:24 AM · Restricted Project, Restricted Project
jyknight updated subscribers of D125652: [LLVM] Add a check if should cast atomic operations to integer type.

As somewhat coincidentally just discussed in the thread on https://reviews.llvm.org/D124728 the target hooks don't really make sense as implemented here.

Wed, May 25, 9:17 AM · Restricted Project, Restricted Project
jyknight added a comment to D126324: [clang] Allow const variables with weak attribute to be overridden.

The changes so far look sensible, but I think we should add some more tests for a few situations. 1) Using a const weak symbol as a valid initializer should be diagnosed (with a warning? with an error?) so users are alerted to the behavioral quirks.

Wed, May 25, 7:51 AM · Restricted Project, Restricted Project

Tue, May 24

jyknight added a comment to D125814: Improve the strict prototype diagnostic behavior.

Good improvement, but an additional change to wording for just the zero-arg non-prototype function declaration case could help a lot. The fact that zero-arg it's only being warned about because of the "...because of" note isn't particularly clear -- especially when the "because of" isn't emitted.

Tue, May 24, 2:13 PM · Restricted Project, Restricted Project
jyknight added a comment to D124728: Allow pointer types for atomicrmw xchg.

Can this patch land? Is there anything else that needs to be done?

Tue, May 24, 6:49 AM · Restricted Project, Restricted Project

Sun, May 22

jyknight requested review of D126170: C++ DR2394: Const-default-constructible for members..
Sun, May 22, 7:33 AM · Restricted Project, Restricted Project
jyknight added a comment to rG50b1faf5c188: [Clang] CWG 1394: Incomplete types as parameters of deleted functions.

FYI, clang/www/cxx_dr_status.html is not intended to be edited manually; it's built from automation based on test cases added to clang/test/CXX/drs/, which this change didn't add.

Sun, May 22, 7:27 AM · Restricted Project, Restricted Project
jyknight committed rG69c0af3de224: CWG 1394: Incomplete types as parameters of deleted functions (authored by jyknight).
CWG 1394: Incomplete types as parameters of deleted functions
Sun, May 22, 7:26 AM · Restricted Project, Restricted Project

Fri, May 20

jyknight added a comment to D126079: [NFC][LLVM] Merge shouldExpandAtomic*InIR into shouldExpandAtomicInstInIR.

I did have one patch locally that only keeps the function shouldExpandAtomicInstInIR(Instruction *) and in the body it has something like if (auto *SI = dyn_cast<StoreInst>(I)). In terms of readability, IMO it is same as overload. However, of course it can reduce number of APIs. I can use that method, but it looks like the controversy here is readability.

Fri, May 20, 12:23 PM · Restricted Project, Restricted Project
jyknight requested changes to D126079: [NFC][LLVM] Merge shouldExpandAtomic*InIR into shouldExpandAtomicInstInIR.

IMO, this change hurts the readability of the code, not improves it.

Fri, May 20, 11:27 AM · Restricted Project, Restricted Project
jyknight accepted D124728: Allow pointer types for atomicrmw xchg.

Thanks!

Fri, May 20, 9:18 AM · Restricted Project, Restricted Project

Thu, May 19

jyknight added inline comments to D124728: Allow pointer types for atomicrmw xchg.
Thu, May 19, 9:39 AM · Restricted Project, Restricted Project
jyknight added a comment to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

Header modules are part of the C++20 standard (where they are called "header units"), and module maps are an intended way for Clang to provide this functionality in C++20 mode. I don't think turning this off by default in C++20 is the right forward-looking plan; rather, I think we should be thinking about moving towards header modules simply always being something that Clang can do, with no flag to control that.

Thu, May 19, 8:04 AM · Restricted Project, Restricted Project

Wed, May 18

jyknight accepted D124895: [Object] Fix updating darwin archives.

LGTM, modulo final comments.

Wed, May 18, 11:57 AM · Restricted Project, Restricted Project

Tue, May 17

jyknight added a comment to D125814: Improve the strict prototype diagnostic behavior.

This confuses me.

Tue, May 17, 11:13 AM · Restricted Project, Restricted Project

Mon, May 16

jyknight added a comment to D124435: [X86] Always extend the integer parameters in callee.

I find the option names you have a bit confusing. I'd like to suggest calling them, instead:

Mon, May 16, 4:49 AM · Restricted Project, Restricted Project

Fri, May 13

jyknight added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

The warnings for this case aren't great:

int foo();
Fri, May 13, 7:34 AM · Restricted Project, Restricted Project

Wed, May 11

jyknight added a comment to D124895: [Object] Fix updating darwin archives.

Couple more comments, but looks pretty good.

Wed, May 11, 7:57 AM · Restricted Project, Restricted Project

Thu, May 5

jyknight added a comment to D124895: [Object] Fix updating darwin archives.

Also, while your goal of improving the heuristics seems reasonable, perhaps we ought to have a --archive-format option for objcopy, so that users can be explicit if they desire. (We already have --format for ar, and for the cross-compiling case it's basically required -- there's simply no other way to choose the correct behavior for archives with no files, like llvm-ar rcs x.a).

From a UX perspective I hope we can come to a reasonable patch here instead so folks don't have to know about these details in this case. In the case of no files I don't think the decision really matters for this use case at least, although I get that issue in general.

Thu, May 5, 8:49 AM · Restricted Project, Restricted Project

Wed, May 4

jyknight added a comment to D124895: [Object] Fix updating darwin archives.

I don't think we ought to modify the archive reader like you've done, because we don't need to tell the difference between BSD/DARWIN when reading, only while writing. Thus, going through the trouble of distinguishing them in the reader is wasted work. Instead, please add a separate function, which ar and objcopy can call before constructing an ArchiveWriter, which returns the more "refined" Kind.

Wed, May 4, 10:46 AM · Restricted Project, Restricted Project

Tue, May 3

Herald added a project to D112849: [llvm] Disable xar on macOS 12.0 and later : Restricted Project.

Isn't libxar still required by the lld.ld64 -bitcode_bundle option, so doesn't LLVM need to continue to use it despite it being deprecated?

Tue, May 3, 10:40 AM · Restricted Project, Restricted Project

Fri, Apr 29

jyknight added a comment to D122857: [LoopCacheAnalysis] Enable delinearization of fixed sized arrays.

The test case added here appears to sometimes fail due to output ordering differences. E.g. https://lab.llvm.org/buildbot/#/builders/16/builds/28225

Fri, Apr 29, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
jyknight added a reverting change for rG35f38583d2f2: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes: rG02aa79578537: Revert "[JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes".
Fri, Apr 29, 2:17 PM · Restricted Project, Restricted Project
jyknight committed rG02aa79578537: Revert "[JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes" (authored by jyknight).
Revert "[JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes"
Fri, Apr 29, 2:17 PM · Restricted Project, Restricted Project
jyknight added a reverting change for D124439: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes: rG02aa79578537: Revert "[JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes".
Fri, Apr 29, 2:17 PM · Restricted Project, Restricted Project
jyknight added a comment to D124439: [JumpThreading][NFC][CompileTime] Do not recompute BPI/BFI analyzes.

This change has caused our internal PGO+NewPM builds of clang to have become non-reproducible (that is: the binary is different every build, when built with a Clang that includes this change). The problem appears only when providing profile data. I am not sure why this change causes a problem -- perhaps some of the analysis data ought to have been invalidated by some other pass, but wasn't?

Fri, Apr 29, 2:14 PM · Restricted Project, Restricted Project

Thu, Apr 28

jyknight updated subscribers of D116995: [gold] Ignore bitcode from sections inside object files.

-fembed-bitcode was originally added by Apple to enable them to recompile
3rd-party-developers' software with a newer compiler, or for new CPU
targets, without the source code. It uses the normal non-LTO optimization
pipeline, and emits bitcode corresponding to the binary object also
emitted.

Thu, Apr 28, 8:51 PM · Restricted Project, Restricted Project

Apr 19 2022

jyknight accepted D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Looks good to me, whichever way you go regarding rsmith's comments.

Apr 19 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 15 2022

jyknight accepted D123872: Force GHashCell to be 8-byte-aligned..

Sidenote: Oh, yikes! I didn't even notice before that this code is doing reinterpret_cast from a GHashCell* to a std::atomic<GHashCell>*. That's...kinda not great...

Apr 15 2022, 1:22 PM · Restricted Project, Restricted Project
jyknight added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

I think we should just make this an error by default in C99 onwards;

Out of curiosity -- do you think we should remove the DefaultIgnore in C89 mode so that we warn by default there (perhaps as a follow up)? Also, I presume you expect diag::ext_implicit_lib_function_decl to behave the same way (warn in C89, warn-as-err in C99 and up) as part of this patch?

Apr 15 2022, 12:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyknight added a comment to D123642: [clang codegen] Assume arguments of __atomic_* are aligned..

I disagree with this on principle -- IMO, it is basically a historical bug in GCC that it ignores the type alignment, and we should NOT try to match that -- it's dangerous.

gcc has always behaved this way, and I don't see any indication they intend to change it. I mean, you can call it a bug, but at the end of the day the bug reports will land in our bugtracker, not gcc's.

Apr 15 2022, 11:59 AM · Restricted Project, Restricted Project

Apr 12 2022

jyknight added a comment to D123642: [clang codegen] Assume arguments of __atomic_* are aligned..

I disagree with this on principle -- IMO, it is basically a historical bug in GCC that it ignores the type alignment, and we should NOT try to match that -- it's dangerous.

Apr 12 2022, 8:11 PM · Restricted Project, Restricted Project
jyknight accepted D123627: Correctly diagnose prototype redeclaration errors in C.
Apr 12 2022, 2:11 PM · Restricted Project, Restricted Project
jyknight added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Looks reasonable overall.

Apr 12 2022, 1:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyknight added inline comments to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Apr 12 2022, 8:22 AM · Restricted Project, Restricted Project
jyknight added inline comments to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Apr 12 2022, 7:03 AM · Restricted Project, Restricted Project

Apr 11 2022

jyknight added inline comments to D121556: [randstruct] Add randomize structure layout support.
Apr 11 2022, 3:16 PM · Restricted Project, Restricted Project

Apr 7 2022

Herald added a project to D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.: Restricted Project.

What's the status of this? Did the GCC proposal go anywhere? I'd be happy to see this move forward if you're also pushing it on the GCC side.

Apr 7 2022, 8:22 AM · Restricted Project, Restricted Project
jyknight accepted D122976: Bump minimum toolchain version.

LG, just some minor comments.

Apr 7 2022, 7:55 AM · Restricted Project, Restricted Project
jyknight updated subscribers of D122963: [X86] Extend the integer parameter if the function isn't local linked.

Sometimes ignoring the attribute and performing zeroext ourselves is a
workaround for ABI mismatch.

Apr 7 2022, 5:01 AM · Restricted Project, Restricted Project

Apr 4 2022

jyknight added inline comments to D122976: Bump minimum toolchain version.
Apr 4 2022, 2:37 PM · Restricted Project, Restricted Project

Apr 1 2022

jyknight added inline comments to D121642: InstCombineCalls: when adding an align attribute, never reduce it.
Apr 1 2022, 11:30 AM · Restricted Project, Restricted Project
jyknight added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Starting by looking at the test cases, I've got some suggestions on making the diagnostics a bit less confusing.

Apr 1 2022, 8:01 AM · Restricted Project, Restricted Project

Mar 31 2022

jyknight updated subscribers of D122821: CallBase: fix getFnAttr so it also checks the function.

This discrepancy in behavior seems to have arisen because getFnAttr was only added recently in 7557d6c896d3418216e82c0d0cf3b0708f2145bb by @aeubanks; I suspect it was an oversight not to have it match the longstanding behavior of hasFnAttr.

Mar 31 2022, 8:29 AM · Restricted Project, Restricted Project

Mar 29 2022

jyknight added a comment to D120159: [Clang] Implement __builtin_source_location..

This appears to have broken buildbot: sanitizer-x86_64-linux-fast

Validating if reversion clears it up.

Then will revert.

Mar 29 2022, 2:34 PM · Restricted Project, Restricted Project
jyknight committed rG8f66f1371981: Fix memory leak in [Clang] Implement __builtin_source_location. (authored by jyknight).
Fix memory leak in [Clang] Implement __builtin_source_location.
Mar 29 2022, 2:33 PM · Restricted Project, Restricted Project
jyknight accepted D122681: Don't diagnostic atomic object access as UB in an unevaluated context.
Mar 29 2022, 12:48 PM · Restricted Project, Restricted Project

Mar 28 2022

jyknight committed rGd61487490022: [Clang] Implement __builtin_source_location. (authored by jyknight).
[Clang] Implement __builtin_source_location.
Mar 28 2022, 3:29 PM · Restricted Project, Restricted Project
jyknight closed D120159: [Clang] Implement __builtin_source_location..
Mar 28 2022, 3:29 PM · Restricted Project, Restricted Project

Mar 22 2022

jyknight added a comment to D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""".

Given that this is an error error: functions cannot be declared in an anonymous struct (thus you can assume that function declarations inside a struct imply that the struct MUST have a linkage name)

struct {
  static int foo();
};

then I don't think there's any conceptual reason why we cannot emit the desired diagnostics without the undesired side-effect.

Mar 22 2022, 2:25 PM · Restricted Project, Restricted Project

Mar 21 2022

jyknight added a comment to D120159: [Clang] Implement __builtin_source_location..

Ping; any more comments?

Mar 21 2022, 8:35 AM · Restricted Project, Restricted Project
Herald added a project to D114523: [compiler-rt][AArch64] Add a workaround for Exynos 9810: Restricted Project.

Expanded the comment slightly in 4a6fab793fa00b8155c2c08a6fbad7ee3e7feba6.

Mar 21 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
jyknight committed rG4a6fab793fa0: [compiler-rt] Expand comment about Exynos 9810 workaround. (authored by jyknight).
[compiler-rt] Expand comment about Exynos 9810 workaround.
Mar 21 2022, 6:36 AM · Restricted Project

Mar 18 2022

jyknight accepted D119414: [LangRef] Allow non-power-of-two assume operand bundle.

Being consistent with allocalign's proposed semantics sounds good to me.

Mar 18 2022, 8:37 AM · Restricted Project, Restricted Project

Mar 14 2022

jyknight added inline comments to D119271: clang: emit allocalign to LLVM for alloc_align attributes.
Mar 14 2022, 3:23 PM · Restricted Project, Restricted Project

Mar 10 2022

jyknight added a comment to D118511: Add a warning for not packing non-POD members in packed structs.

I'm fine with reverting if you think this is the best solution. I just would like to conclude soon so I can make the final release candidate.

Mar 10 2022, 7:34 AM · Restricted Project, Restricted Project

Mar 4 2022

jyknight accepted D119272: llvm: add missing `allocalign` attributes.
Mar 4 2022, 8:25 AM · Restricted Project, Restricted Project
jyknight accepted D119273: llvm: only use allocalign for allocation functions.
Mar 4 2022, 8:21 AM · Restricted Project, Restricted Project

Mar 1 2022

jyknight added a comment to D120634: [Libcxx] Add <source_location> header..

Does this mean we'll only implement source_location with Clang? Or does GCC provide a similar builtin? If so, are both compatible?

Mar 1 2022, 3:27 PM · Restricted Project, Restricted Project
jyknight added inline comments to D120634: [Libcxx] Add <source_location> header..
Mar 1 2022, 3:25 PM · Restricted Project, Restricted Project
jyknight updated the diff for D120634: [Libcxx] Add <source_location> header..

Update for review comments.

Mar 1 2022, 3:25 PM · Restricted Project, Restricted Project
jyknight added a comment to D120634: [Libcxx] Add <source_location> header..

So, in doing further testing, I've noticed a problem. Currently, clang cannot compile code that calls a consteval function in a default argument. (see https://github.com/llvm/llvm-project/issues/48230 and https://reviews.llvm.org/D119646)

Mar 1 2022, 7:21 AM · Restricted Project, Restricted Project
jyknight added a comment to D120634: [Libcxx] Add <source_location> header..

Looks like you have to run ninja libcxx-generate-files.

Mar 1 2022, 7:06 AM · Restricted Project, Restricted Project
jyknight updated the diff for D120634: [Libcxx] Add <source_location> header..

Update per review comments.

Mar 1 2022, 7:03 AM · Restricted Project, Restricted Project
jyknight updated the diff for D120159: [Clang] Implement __builtin_source_location..

Fix and test __impl lookup within the definition of std::source_location.

Mar 1 2022, 7:00 AM · Restricted Project, Restricted Project

Feb 28 2022

jyknight added a comment to D119051: Extend the C++03 definition of POD to include defaulted functions.

Ah, looks like this is the existing https://github.com/itanium-cxx-abi/cxx-abi/issues/66

Feb 28 2022, 7:53 PM · Restricted Project, Restricted Project
jyknight added a comment to D120159: [Clang] Implement __builtin_source_location..

Ah, okay, that's a good point. I was thinking this would show up in the AST in places like:

template <typename Ty>
auto func() -> Ty;

int main() {
  func<decltype(__builtin_source_location())>();
}

when we go to print the Ty type from the template. Does that not happen?

Feb 28 2022, 10:29 AM · Restricted Project, Restricted Project
jyknight added a comment to D120159: [Clang] Implement __builtin_source_location..

Btw, I think there may be some functionality missing for AST dumping, so I'd like to see some additional tests for that.

Feb 28 2022, 7:35 AM · Restricted Project, Restricted Project
jyknight updated the diff for D120159: [Clang] Implement __builtin_source_location..

Update per review comments.

Feb 28 2022, 7:34 AM · Restricted Project, Restricted Project

Feb 27 2022

jyknight requested review of D120634: [Libcxx] Add <source_location> header..
Feb 27 2022, 11:03 AM · Restricted Project, Restricted Project
jyknight updated the diff for D120159: [Clang] Implement __builtin_source_location..

Minor tweaks to comments and docs.

Feb 27 2022, 10:48 AM · Restricted Project, Restricted Project

Feb 23 2022

jyknight added inline comments to D119271: clang: emit allocalign to LLVM for alloc_align attributes.
Feb 23 2022, 6:35 AM · Restricted Project, Restricted Project
jyknight accepted D118263: getAllocAlignment: respect allocalign attribute if present.
Feb 23 2022, 5:52 AM · Restricted Project, Restricted Project
jyknight added a comment to D119604: AttributorAttributes: avoid a crashing on bad alignments.

This can be submitted first, separately from the rest of the stack.

Feb 23 2022, 5:49 AM · Restricted Project
jyknight accepted D119604: AttributorAttributes: avoid a crashing on bad alignments.

It's not UB to provide invalid alignments to aligned_alloc, but that's not something the langref covers.

Feb 23 2022, 5:46 AM · Restricted Project
jyknight accepted D117921: Attributes: add a new allocalign attribute.
Feb 23 2022, 5:39 AM · Restricted Project, Restricted Project
jyknight accepted D117923: BuildLibCalls: add allocalign attributes for memalign and aligned_alloc.
Feb 23 2022, 5:38 AM · Restricted Project, Restricted Project

Feb 18 2022

jyknight requested review of D120159: [Clang] Implement __builtin_source_location..
Feb 18 2022, 1:11 PM · Restricted Project, Restricted Project

Feb 14 2022

jyknight added inline comments to D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute.
Feb 14 2022, 10:01 AM · Restricted Project
jyknight added inline comments to D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute.
Feb 14 2022, 8:53 AM · Restricted Project

Feb 11 2022

jyknight added inline comments to D118263: getAllocAlignment: respect allocalign attribute if present.
Feb 11 2022, 2:15 PM · Restricted Project, Restricted Project
jyknight accepted D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Feb 11 2022, 2:06 PM · Restricted Project, Restricted Project

Feb 10 2022

jyknight added inline comments to D119271: clang: emit allocalign to LLVM for alloc_align attributes.
Feb 10 2022, 6:44 PM · Restricted Project, Restricted Project
jyknight added inline comments to D118263: getAllocAlignment: respect allocalign attribute if present.
Feb 10 2022, 3:41 PM · Restricted Project, Restricted Project
jyknight requested changes to D117923: BuildLibCalls: add allocalign attributes for memalign and aligned_alloc.
Feb 10 2022, 3:28 PM · Restricted Project, Restricted Project
jyknight accepted D117923: BuildLibCalls: add allocalign attributes for memalign and aligned_alloc.

Agree, we do want this. The general strategy (which I don't think should be changed) is for LLVM to be aware of standard libc functions, and infer attributes for them. (We do want to get it out of the business of being aware of the C++ stdlib functions, however.)

Feb 10 2022, 3:24 PM · Restricted Project, Restricted Project
jyknight accepted D117921: Attributes: add a new allocalign attribute.

I'm happy with the LangRef semantics and wording that here now.

Feb 10 2022, 3:23 PM · Restricted Project, Restricted Project
jyknight added inline comments to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Feb 10 2022, 3:18 PM · Restricted Project, Restricted Project

Feb 9 2022

jyknight added a comment to D115955: [SLP]Alternate vectorization for cmp instructions..

It was reverted in 14, currently only in trunk.

Feb 9 2022, 12:20 PM · Restricted Project

Feb 8 2022

jyknight committed rG9545976ff160: Revert "[Clang] Propagate guaranteed alignment for malloc and others" (authored by jyknight).
Revert "[Clang] Propagate guaranteed alignment for malloc and others"
Feb 8 2022, 11:35 AM
jyknight added a reverting change for rGc2297544c047: [Clang] Propagate guaranteed alignment for malloc and others: rG9545976ff160: Revert "[Clang] Propagate guaranteed alignment for malloc and others".
Feb 8 2022, 11:35 AM
jyknight added a reverting change for D100879: [Clang] Propagate guaranteed alignment for malloc and others : rG9545976ff160: Revert "[Clang] Propagate guaranteed alignment for malloc and others".
Feb 8 2022, 11:35 AM · Restricted Project
jyknight closed D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others".
Feb 8 2022, 11:35 AM · Restricted Project, Restricted Project

Feb 7 2022

jyknight added a comment to D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others".

I support this revert.

Feb 7 2022, 4:22 PM · Restricted Project, Restricted Project
jyknight added a comment to D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others".

Is it hard to retrofit this diff into LLVM 13?

Feb 7 2022, 10:21 AM · Restricted Project, Restricted Project
jyknight updated the diff for D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others".

Rebase, and preserve (and modify) test-case.

Feb 7 2022, 8:32 AM · Restricted Project, Restricted Project