Page MenuHomePhabricator

jyknight (James Y Knight)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2015, 11:23 AM (229 w, 2 d)

Recent Activity

Fri, Aug 2

jyknight committed rG383d760ffef9: Fix git-llvm to not delete non-empty directories. (authored by jyknight).
Fix git-llvm to not delete non-empty directories.
Fri, Aug 2, 10:11 AM
jyknight committed rL367693: Fix git-llvm to not delete non-empty directories..
Fix git-llvm to not delete non-empty directories.
Fri, Aug 2, 10:11 AM
jyknight closed D65416: Fix git-llvm to not delete non-empty directories..
Fri, Aug 2, 10:11 AM · Restricted Project
jyknight added a comment to D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description..

Doing a websearch for "xtensa isa", I do see that documentation does seem to exist: https://github.com/eerimoq/hardware-reference/blob/master/esp32/xtensa%20Instruction%20Set%20Architecture%20(ISA)%20Reference%20Manual.pdf.

Fri, Aug 2, 9:46 AM · Restricted Project

Thu, Aug 1

jyknight added a comment to D65582: IR: accept and print numbered %N names for function args.

+1 for doing this. I started looking at fixing this when I modified the printer to print proper labels for numbered basic-blocks (instead of comments), but I didn't do so because of the amount of test churn was off-putting.

Thu, Aug 1, 9:02 AM · Restricted Project, Restricted Project
jyknight added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

With this new pass, I think we should be able to remove the code handling the objectsize and is.constant instrinsics in CodegenPrepare, FastISel, SelectionDAGBuilder.cpp, and IRTranslator. Which sure is a nice cleanup.

Thu, Aug 1, 8:05 AM · Restricted Project
jyknight added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

I think the pass needs to handle the removal of any remaining llvm.objectsize, as well, so that llvm.is.constant(llvm.objectsize(...)) continues to return true -- even if the object size cannot be determined.

Thu, Aug 1, 7:44 AM · Restricted Project

Tue, Jul 30

jyknight accepted D64893: Ask confirmation when `git llvm push` will push multiple commits.
Tue, Jul 30, 8:15 AM · Restricted Project
jyknight added a comment to D65416: Fix git-llvm to not delete non-empty directories..

.

Tue, Jul 30, 8:07 AM · Restricted Project
jyknight added inline comments to D65416: Fix git-llvm to not delete non-empty directories..
Tue, Jul 30, 7:35 AM · Restricted Project
jyknight added a comment to D65436: [docs] Add note about git version to git-llvm section.

I don't really want to promise any particular version, because nobody is really checking that particular versions of git work -- the way our scripts continue work with old versions is when developers use them and report a problem. The only real requirement here is "whatever the oldest version someone's actually used recently".

Tue, Jul 30, 7:23 AM · Restricted Project, Restricted Project

Mon, Jul 29

jyknight accepted D64796: [builtins][test] XFAIL two SPARC tests.

Given the reference to the bug, seems fine to me to commit an xfail here since nobody is actively working to fix this right now.

Mon, Jul 29, 2:06 PM · Restricted Project, Restricted Project
jyknight committed rG2fd2f41d2a36: git-llvm: Restore compatibility with git 1.8.3. (authored by jyknight).
git-llvm: Restore compatibility with git 1.8.3.
Mon, Jul 29, 2:05 PM
jyknight committed rL367259: git-llvm: Restore compatibility with git 1.8.3..
git-llvm: Restore compatibility with git 1.8.3.
Mon, Jul 29, 2:00 PM
jyknight created D65416: Fix git-llvm to not delete non-empty directories..
Mon, Jul 29, 1:55 PM · Restricted Project
jyknight added inline comments to D64893: Ask confirmation when `git llvm push` will push multiple commits.
Mon, Jul 29, 1:41 PM · Restricted Project
jyknight added a comment to D65192: [Sema] Make -Wbitwise-op-parentheses and -Wlogical-op-parentheses disabled-by-default.

I'm not sure the history behind why these were added as default-on warnings....they don't really seem appropriate as default warnings to me, either.

Mon, Jul 29, 1:34 PM · Restricted Project, Restricted Project
jyknight added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

I fear it is necessary: at least it matches documented behaviour of both the Sun/Oracle Studio compilers and gcc.

Mon, Jul 29, 11:16 AM · Restricted Project, Restricted Project

Tue, Jul 23

jyknight added a comment to D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris.

Is this really necessary? Users don't typically pass -std= to the driver for linking anyways (what do you even pass if you've compiled both C and C++ code?) so this seems a rather odd way to control behavior.

Tue, Jul 23, 8:30 AM · Restricted Project, Restricted Project
jyknight added a comment to D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590.

Thanks for restoring this, but I'm a bit confused how this has happened. My original diff didn't remove these folders, but it seems when I committed the diff via arcanist and git llvm it also removed these other folders. I assume git llvm is when translating the change to SVN not just removing a folder but also all folders in the same directory?

Interesting.. I wouldn't be totally surprised by that as git-llvm does some magic to svn check out only the files/directories that have been modified. Combining that with the different treatment of directories in svn and git (explicit modelling vs. implicit "it exists if it contains a file"), I can see how things might go south in some corner cases like this. But that's just speculation -- I'm generally trying to avoid git-llvm as it is too magical for my taste. Maybe @jyknight or @mehdi_amini can shed more light on this?

Tue, Jul 23, 7:21 AM · Restricted Project, Restricted Project
jyknight accepted D64484: [CMake] Add -z defs on Solaris.
Tue, Jul 23, 7:09 AM · Restricted Project
jyknight accepted D64496: [compiler-rt][builtins] Provide __clear_cache for SPARC.

The code you reference in GCC is only for trampolines, while this function is used to implement builtin_clear_cache. AFAICT GCC is just wrong to implement this as a no-op.

Tue, Jul 23, 7:09 AM · Restricted Project, Restricted Project
jyknight accepted D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC.

LGTM.

Tue, Jul 23, 6:38 AM · Restricted Project

Jul 17 2019

jyknight added a comment to D64875: Add LLVM's LICENSE.txt file to the monorepo root.

I agree, it should have one, especially once we stop supporting separate checkouts, and hopefully can remove redundant copies in other places.

Jul 17 2019, 1:27 PM · Restricted Project

Jul 12 2019

jyknight committed rG8b76e622b389: Fix some minor coding-style issues in git-llvm. (authored by jyknight).
Fix some minor coding-style issues in git-llvm.
Jul 12 2019, 9:43 AM
jyknight committed rG541faedd6675: Allow the 'git-llvm' tool to push to svn from the split repositories for 'test… (authored by jyknight).
Allow the 'git-llvm' tool to push to svn from the split repositories for 'test…
Jul 12 2019, 9:42 AM
jyknight committed rL365918: Fix some minor coding-style issues in git-llvm..
Fix some minor coding-style issues in git-llvm.
Jul 12 2019, 9:41 AM
jyknight committed rL365917: Allow the 'git-llvm' tool to push to svn from the split repositories.
Allow the 'git-llvm' tool to push to svn from the split repositories
Jul 12 2019, 9:40 AM

Jun 13 2019

jyknight added a comment to D63244: Add --undefined-glob which is an --undefined with wildcard pattern match..

Actually linker scripts do support metacharacter escaping (although, it seems lld does not support this correctly, yet).

Jun 13 2019, 8:32 AM · Restricted Project

Jun 5 2019

jyknight added a comment to D62798: Explicitly detect recursive response files.

Comment updates SGTM.

Jun 5 2019, 2:04 PM · Restricted Project
jyknight accepted D62798: Explicitly detect recursive response files.

I like it. Some minor suggestions for a few extra comments, but other than that LGTM.

Jun 5 2019, 11:36 AM · Restricted Project

Jun 4 2019

jyknight committed rGdbb4322e511b: [lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85… (authored by jyknight).
[lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85…
Jun 4 2019, 8:25 AM
jyknight committed rL362510: [lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85.
[lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85
Jun 4 2019, 8:24 AM

May 30 2019

jyknight added a comment to D60748: Fix i386 struct and union parameter alignment.

I don't think this was correct (where by "correct", there, I mean "what GCC does", as this patch is intended to match GCC behavior).

May 30 2019, 9:41 AM · Restricted Project
jyknight added a comment to D62035: [AST] const-ify ObjC inherited class search.

I don't really have much to say about this, and the patch is probably fine, but I do note that most of the other accessors on this class also return mutable objects.

May 30 2019, 7:14 AM · Restricted Project

May 23 2019

jyknight added a comment to D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters.

One of the other suggestions was to pass a _type_ as a parameter to byval. IMO that would be the nicest idea (but I don't know if it's infeasibly difficult?)

May 23 2019, 8:34 AM · Restricted Project
jyknight accepted D60017: [git] Be more specific when looking for llvm-svn.
May 23 2019, 7:05 AM · Restricted Project

May 22 2019

jyknight added a comment to D60017: [git] Be more specific when looking for llvm-svn.

Sorry for dropping this, a couple more comments, then I think it's good.

May 22 2019, 2:39 PM · Restricted Project
jyknight committed rGb2ece169ed60: Add back --sysroot support for darwin header search. (authored by jyknight).
Add back --sysroot support for darwin header search.
May 22 2019, 1:42 PM
jyknight committed rL361429: Add back --sysroot support for darwin header search..
Add back --sysroot support for darwin header search.
May 22 2019, 1:37 PM
jyknight committed rC361429: Add back --sysroot support for darwin header search..
Add back --sysroot support for darwin header search.
May 22 2019, 1:37 PM
jyknight closed D62268: Add back --sysroot support for darwin header search..
May 22 2019, 1:37 PM · Restricted Project
jyknight added a comment to D62268: Add back --sysroot support for darwin header search..

This LGTM.

When I did the refactor, all the code was only using -isysroot (and never accessing --sysroot), so I thought only -isysroot was relevant on Darwin. Seems like I was wrong.

May 22 2019, 1:37 PM · Restricted Project
jyknight created D62268: Add back --sysroot support for darwin header search..
May 22 2019, 1:18 PM · Restricted Project

May 9 2019

jyknight added inline comments to D61267: Update Phabricator.rst.
May 9 2019, 3:17 PM · Restricted Project

May 6 2019

jyknight committed rG1fe312b34b74: PR41183: Don't emit strict-prototypes warning for an implicit function… (authored by jyknight).
PR41183: Don't emit strict-prototypes warning for an implicit function…
May 6 2019, 2:39 PM
jyknight committed rL360084: PR41183: Don't emit strict-prototypes warning for an implicit function.
PR41183: Don't emit strict-prototypes warning for an implicit function
May 6 2019, 2:35 PM
jyknight committed rC360084: PR41183: Don't emit strict-prototypes warning for an implicit function.
PR41183: Don't emit strict-prototypes warning for an implicit function
May 6 2019, 2:35 PM
jyknight closed D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration..
May 6 2019, 2:35 PM · Restricted Project

May 2 2019

jyknight added inline comments to D61411: [SelectionDAG] Expand ADD/SUBCARRY.
May 2 2019, 7:30 AM · Restricted Project

Apr 19 2019

jyknight added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

There shouldn't be an empty string ("") in the asm output -- that should be a reference to the "l_yes" label, not the empty string. That seems very weird...

Apr 19 2019, 7:21 PM
jyknight added a comment to D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration..

Ping.

Apr 19 2019, 3:15 PM · Restricted Project

Apr 9 2019

jyknight added inline comments to D60274: [ELF] Implement Dependent Libraries Feature.
Apr 9 2019, 8:00 AM · Restricted Project
jyknight added a comment to D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration..

Ping.

Apr 9 2019, 5:11 AM · Restricted Project
jyknight accepted D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..

Thanks!

Apr 9 2019, 2:46 AM · Restricted Project
jyknight committed rT357986: Fix siod's gc implementation when used with GLIBC..
Fix siod's gc implementation when used with GLIBC.
Apr 9 2019, 2:32 AM
jyknight committed rL357986: Fix siod's gc implementation when used with GLIBC..
Fix siod's gc implementation when used with GLIBC.
Apr 9 2019, 2:20 AM
jyknight closed D60039: Fix the bug of garbage collection of siod..
Apr 9 2019, 2:20 AM · Restricted Project

Apr 8 2019

jyknight accepted D60039: Fix the bug of garbage collection of siod..
Apr 8 2019, 7:57 AM · Restricted Project
jyknight added a comment to D60039: Fix the bug of garbage collection of siod..

If you change to condition on GLIBC instead of linux, I think this is fine to commit (although it still seems unfortunate to me that we're carrying an abandoned codebase which depends on weird broken stuff like this...)

Apr 8 2019, 5:42 AM · Restricted Project
jyknight added a comment to D59509: Make static constructors + destructors minsize + cold (except for in -O0).

Looks reasonable to me.

Apr 8 2019, 3:22 AM · Restricted Project
jyknight added inline comments to D60017: [git] Be more specific when looking for llvm-svn.
Apr 8 2019, 3:11 AM · Restricted Project
jyknight added a comment to D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..

Can you please write a test case for this? There's some existing sparcv9 spill tests in llvm/test/CodeGen/SPARC/64spill.ll.

Apr 8 2019, 2:59 AM · Restricted Project

Apr 6 2019

jyknight added inline comments to D60274: [ELF] Implement Dependent Libraries Feature.
Apr 6 2019, 3:13 PM · Restricted Project

Apr 5 2019

jyknight added a comment to D60274: [ELF] Implement Dependent Libraries Feature.

This commit message is rather bare-bones -- I hope that the ultimate commit message will be updated to contain more than just a reference to the RFC thread.

Apr 5 2019, 11:31 AM · Restricted Project

Apr 4 2019

jyknight committed rGa0401744185b: Revert [X86] When using Win64 ABI, exit with error if SSE is disabled for… (authored by jyknight).
Revert [X86] When using Win64 ABI, exit with error if SSE is disabled for…
Apr 4 2019, 12:07 PM
jyknight committed rL357718: Revert [X86] When using Win64 ABI, exit with error if SSE is disabled for….
Revert [X86] When using Win64 ABI, exit with error if SSE is disabled for…
Apr 4 2019, 12:04 PM
jyknight added a comment to D42512: [X86] When using Win64 ABI, exit with error if SSE is disabled for varargs.

This patch is not correct -- the crash is not with varargs functions specifically, llvm also crashes for a function declared to explicitly take a float/double. The Win64 calling convention code assigns values to xmm registers, but it should not when sse is disabled.

Apr 4 2019, 11:58 AM · Restricted Project

Apr 3 2019

jyknight added a comment to D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

After looking at this a bit more, I realized that this is still insufficient. There's *many* more target-specific constraints than just x86 "i" which sign extend constant integer arguments -- and we'll need to apply this change to every one of them, in all targets.

Apr 3 2019, 2:03 PM · Restricted Project
jyknight added a comment to D60208: [X86] Extend boolean arguments to inline-asm according to getBooleanType.

This looks like the same bug is present in the generic code in llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp as well.

Apr 3 2019, 10:42 AM · Restricted Project
jyknight added a comment to D60039: Fix the bug of garbage collection of siod..

I would question whether it's actually worth it to attempt to keep software working that seems to have been abandoned for a decade as part of the llvm test suite? Should this code just be removed, instead of patched?

Apr 3 2019, 10:35 AM · Restricted Project

Apr 1 2019

jyknight added a comment to D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris.

Sounds like this file is missing #include <math.h> (it probably only #include <cmath>). If it wants to use ::log10, it should #include <math.h>. If it wants to use <cmath>, it should use std::log10.

Apr 1 2019, 8:28 AM · Restricted Project

Mar 29 2019

jyknight accepted D58070: [DAGCombine] Prune unnused nodes..

It'd be nice if we knew why adding new nodes to the worklist seemed to cause an issue, but the reduced form as here seems okay as far as it goes.

Mar 29 2019, 9:36 AM · Restricted Project
jyknight accepted D58068: [DAG] Set up infrastructure to avoid smart constructor-based dangling nodes.

Looks fine again.

Mar 29 2019, 8:38 AM · Restricted Project

Mar 28 2019

jyknight added inline comments to D59837: Add "git llvm revert" subcommand.
Mar 28 2019, 2:02 PM · Restricted Project

Mar 27 2019

jyknight accepted D59897: [DAGCombiner] Teach TokenFactor pruning to peek through lifetime nodes.
Mar 27 2019, 1:36 PM · Restricted Project

Mar 26 2019

jyknight added a comment to D30471: [SDAG] Relax conditions under stores of loaded values can be merged.

Not sure if the PPC issue was a different one, but the commit that reverted this was:

Mar 26 2019, 7:29 AM

Mar 25 2019

jyknight added inline comments to D58070: [DAGCombine] Prune unnused nodes..
Mar 25 2019, 12:14 PM · Restricted Project
jyknight accepted D58068: [DAG] Set up infrastructure to avoid smart constructor-based dangling nodes.
Mar 25 2019, 12:14 PM · Restricted Project

Mar 22 2019

jyknight created D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration..
Mar 22 2019, 12:36 PM · Restricted Project
jyknight committed rGc0e6b8ac3ad4: IR: Support parsing numeric block ids, and emit them in textual output. (authored by jyknight).
IR: Support parsing numeric block ids, and emit them in textual output.
Mar 22 2019, 11:28 AM
jyknight committed rL356789: IR: Support parsing numeric block ids, and emit them in textual output..
IR: Support parsing numeric block ids, and emit them in textual output.
Mar 22 2019, 11:28 AM
jyknight committed rC356789: IR: Support parsing numeric block ids, and emit them in textual output..
IR: Support parsing numeric block ids, and emit them in textual output.
Mar 22 2019, 11:27 AM
jyknight closed D58548: IR: Support parsing numeric block ids, and emit them in textual output..
Mar 22 2019, 11:27 AM · Restricted Project, Restricted Project

Mar 20 2019

Herald added a project to D44373: Fix reading objects created with -fembed-bitcode-marker.: Restricted Project.

Thanks for fixing this. LGTM.

Mar 20 2019, 7:29 AM · Restricted Project

Mar 18 2019

jyknight added inline comments to D58070: [DAGCombine] Prune unnused nodes..
Mar 18 2019, 3:01 PM · Restricted Project
jyknight added a comment to D58068: [DAG] Set up infrastructure to avoid smart constructor-based dangling nodes.

Could you add a comment to the CL description noting that a bunch of the calls to AddToWorklist in DAGCombiner.cpp that follow a DAG.getNode() are now redundant, and should be cleaned up in the future.

Mar 18 2019, 12:43 PM · Restricted Project
jyknight added a comment to D58548: IR: Support parsing numeric block ids, and emit them in textual output..

Sorry, forgot to re-ping this in a timely manner. :)

Mar 18 2019, 12:41 PM · Restricted Project, Restricted Project
jyknight accepted D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h.

Looks good.

Mar 18 2019, 12:41 PM · Restricted Project

Mar 14 2019

jyknight added a comment to rG087968716c3e: Sync with upstream.

It looks like this was generated because a pull request against the upstream repo was created containing this commit.

Mar 14 2019, 9:30 AM

Mar 6 2019

jyknight added a comment to D58154: Add support for -fpermissive..

Ah -- I now understand your concern, and managing user expectations appropriately does seem like a potential concern.

Mar 6 2019, 9:04 AM · Restricted Project

Mar 5 2019

jyknight added a comment to D58998: Replace function template (plus explicit specializations) by non-template overloads..

Is there any reason this needs to be a template -- can't these just be changed to function overloads, instead of template specializations?

Mar 5 2019, 3:35 PM · Restricted Project
jyknight added a comment to D58154: Add support for -fpermissive..

The errors disabled by this feature are default-error warnings -- you can already get the same effect by using -Wno-<lots-of-things>. Why is it bad to additionally allow -fpermissive to disable them? (If we have any diagnostics which are currently default-on-warnings which should not _ever_ be disable-able, then maybe we should just fix those?)

Mar 5 2019, 8:41 AM · Restricted Project

Mar 4 2019

jyknight accepted D58154: Add support for -fpermissive..
Mar 4 2019, 12:48 PM · Restricted Project
jyknight added a comment to D58154: Add support for -fpermissive..

Hm -- in GCC, -fpermissive has nothing at all to do with -pedantic/-pedantic-errors, but I suppose it should be fine to do this way.

Mar 4 2019, 12:48 PM · Restricted Project

Mar 2 2019

jyknight committed rGcf03bd92d64a: Tweak r355278 for compatibility with gcc 6 and earlier. (authored by jyknight).
Tweak r355278 for compatibility with gcc 6 and earlier.
Mar 2 2019, 1:55 PM
jyknight committed rL355280: Tweak r355278 for compatibility with gcc 6 and earlier..
Tweak r355278 for compatibility with gcc 6 and earlier.
Mar 2 2019, 1:54 PM
jyknight committed rC355280: Tweak r355278 for compatibility with gcc 6 and earlier..
Tweak r355278 for compatibility with gcc 6 and earlier.
Mar 2 2019, 1:54 PM
jyknight committed rG1ce395f25e29: Tweak r355278 for compatibility with gcc 6 and earlier. (authored by jyknight).
Tweak r355278 for compatibility with gcc 6 and earlier.
Mar 2 2019, 1:20 PM
jyknight committed rL355279: Tweak r355278 for compatibility with gcc 6 and earlier..
Tweak r355278 for compatibility with gcc 6 and earlier.
Mar 2 2019, 1:20 PM