Page MenuHomePhabricator

jyknight (James Y Knight)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2015, 11:23 AM (417 w, 2 d)

Recent Activity

Wed, Mar 22

jyknight added inline comments to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..
Wed, Mar 22, 11:43 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

jyknight added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

Looks reasonable to me -- but I'd like to see the LLD change implemented and both pieces tested together end-to-end before this is submitted.

Thu, Mar 16, 8:34 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

jyknight committed rGb87dc3566992: [TableGen] Delete support for deprecated positional matching. (authored by jyknight).
[TableGen] Delete support for deprecated positional matching.
Tue, Mar 7, 12:04 PM · Restricted Project, Restricted Project
jyknight closed D144210: [TableGen] Delete support for deprecated positional matching..
Tue, Mar 7, 12:04 PM · Restricted Project, Restricted Project

Mon, Mar 6

jyknight added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

+1 Agreed that impl simplicity should be prioritized.

Mon, Mar 6, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
jyknight added a comment to D145416: [clang] model 'p' inline asm constraint as reading memory.

Also, I note the doc says it's useful for for “load address” and “push address” instructions (note, "load address" means e.g. x86 "lea" instruction) -- which should NOT be dependent upon the value stored in the memory. The x86 backend actually uses a "Ts" constraint for *lea<mode> which is defined by define_address_constraint, documented as making a constraint that is basically equivalent to p (just with different limits as to what kinds of addresses are accepted.)

Mon, Mar 6, 3:53 PM · Restricted Project, Restricted Project
jyknight added a comment to D145416: [clang] model 'p' inline asm constraint as reading memory.

‘p’ in the constraint must be accompanied by address_operand as the predicate in the match_operand. This predicate interprets the mode specified in the match_operand as the mode of the memory reference for which the address would be valid.

Mon, Mar 6, 3:08 PM · Restricted Project, Restricted Project
jyknight added a comment to D145416: [clang] model 'p' inline asm constraint as reading memory.

It looks to me from GCC that constraint 'p' is intended to be used internally, not for inline-asm. I question whether the kernel should be using it, and whether we should even implement it at all.

Mon, Mar 6, 3:05 PM · Restricted Project, Restricted Project

Thu, Mar 2

jyknight added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

One issue is that we need to emit ONLY dwarf-unwind for those functions which use nonstandard personalities, while femit-dwarf-unwind enables emitting both compact-unwind and dwarf unwind.

So IMO the ideal design is that we emit both and have the linker fall back to DWARF unwind info if the number of personalities is too large.

OK - this sounds like a reasonable behaviour. 👍

Thu, Mar 2, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
jyknight added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

no-compact-unwind is particularly useful for newer x86_64 platforms: we don't want to omit DWARF unwind for x86_64 in general due to possible backwards compat issues, but we should make it possible for people to opt into this behavior if they are only targeting newer platforms.

Thu, Mar 2, 10:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Feb 28

jyknight added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

So, sigh -- I've just realized this will need a (small) linker change, as well. Currently, we (both LLD and LD64) encode the personality function in the compact-unwind even for unwind infos marked MODE_DWARF.

Tue, Feb 28, 3:14 PM · Restricted Project, Restricted Project, Restricted Project
jyknight added inline comments to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..
Tue, Feb 28, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
jyknight added a comment to D144889: [C2x] Support <string.h> in freestanding.

On the other hand, I think a not-insignificant number of users are interested in freestanding environments for one-off/fun/experimental projects where ease of access is more important than performance characteristics -- think: users who are playing around with an arduino, etc.

Tue, Feb 28, 9:59 AM · Restricted Project, Restricted Project

Mon, Feb 27

jyknight added a comment to D144889: [C2x] Support <string.h> in freestanding.

Likely because of GCC's perspective on this, the set of C headers provided by GCC, Clang, ICC, etc. has included the complete list of freestanding headers and more or less no others, with some libc implementations providing the full set and some providing just the non-freestanding ones. If we're moving away from that, we'll presumably need a new agreement between compiler folks and libc folks about which headers are provided by whom (and I expect it'll be "compilers provide what the C standard said before this change to freestanding and we pretend the change never happened").

Mon, Feb 27, 5:57 PM · Restricted Project, Restricted Project

Feb 22 2023

jyknight added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

however the fix in most cases should be to use -std=c++2b and the code will work out of the box.

Feb 22 2023, 1:45 PM · Restricted Project, Restricted Project

Feb 16 2023

jyknight requested review of D144210: [TableGen] Delete support for deprecated positional matching..
Feb 16 2023, 11:36 AM · Restricted Project, Restricted Project

Feb 15 2023

jyknight accepted D143430: [C2x] Implement the `unreachable` macro for WG14 N2826.
Feb 15 2023, 11:29 AM · Restricted Project, Restricted Project

Feb 14 2023

jyknight added a comment to D143813: [ClangFE] Check that __sync builtins are naturally aligned..

(Firstly, really nobody should be using the __sync_* builtins...)

Feb 14 2023, 11:21 AM · Restricted Project, Restricted Project
jyknight accepted D143505: [InstSimplify] fix/improve folding with an SNaN operand.
Feb 14 2023, 11:02 AM · Restricted Project, Restricted Project
jyknight added inline comments to D143505: [InstSimplify] fix/improve folding with an SNaN operand.
Feb 14 2023, 9:46 AM · Restricted Project, Restricted Project
jyknight accepted D143074: [LangRef] improve documentation of SNaN in the default FP environment.

Given the reassurance regarding optimizations of non-deterministic results, I'm satisfied.

Feb 14 2023, 7:04 AM · Restricted Project, Restricted Project

Feb 9 2023

jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

How many of these sNaN vs qNaN cases that matter are there? I've seen pow() mentioned in this ticket. What are the other cases?

Feb 9 2023, 1:08 PM · Restricted Project, Restricted Project

Feb 7 2023

jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

GCC has option -fsignaling-nans, which may be used to turn on standard treatment of SNaNs. Clang does not have similar option, now the only way to handle SNaNs in the standard way is to turn on exception handling, which is not suitable in some cases. LLVM as a low-level component must support SNaN on an opt-in basis, but request for such support must be more selective. Anyway SNaN treatment is nor a part of strict exception handling semantics.

Feb 7 2023, 7:53 AM · Restricted Project, Restricted Project

Feb 6 2023

jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

The property of SNaN like SNan + 0.0 -> QNaN is not related to exceptions and must be preserved in default environment also.

Feb 6 2023, 1:22 PM · Restricted Project, Restricted Project
jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

we cannot allow LLVM to spuriously introduce sNaNs when the original code did not use any.

That is one of the things being discussed here, right? Right now at least on old MIPS LLVM does *not* satisfy this requirement (apfloat will produce sNaN for that platform). The LangRef says "No floating-point exception state is maintained in this environment" which I read as "we don't care at all about the sNaN vs qNaN distinction and will just do whatever".

Feb 6 2023, 7:48 AM · Restricted Project, Restricted Project

Feb 4 2023

jyknight accepted D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.
Feb 4 2023, 6:56 PM · Restricted Project, Restricted Project
jyknight added a comment to D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.

As far as I can tell, this conversation has run its course, and I don't think there were any more comments on the actual code, so I'm going to accept this revision.

Feb 4 2023, 6:56 PM · Restricted Project, Restricted Project
jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

C standard library's semantics, which state that pow(1.0, NaN) = 1.0, for any NaN

Feb 4 2023, 6:19 PM · Restricted Project, Restricted Project
jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

Floating-point math operations assume that all NaNs are quiet.

That could be read as "if you produce a signaling NaN (e.g. via a bitcast) and feed that to a math operation, that violates the assumption, and hence is UB".

Feb 4 2023, 2:34 PM · Restricted Project, Restricted Project

Feb 3 2023

jyknight added a comment to D143074: [LangRef] improve documentation of SNaN in the default FP environment.

Overall, I think the points we need to convey are here:

  1. It's assumed that the rounding mode is round-to-nearest, and all floating-point traps are disabled.
  2. The status flags may be set to arbitrary values.
  3. Floating-point math operations assume that all NaNs are quiet.
Feb 3 2023, 3:24 PM · Restricted Project, Restricted Project

Feb 2 2023

jyknight committed rG0be684ed9739: [PowerPC] Switch to by-name matching for instructions (part 2 of 2). (authored by jyknight).
[PowerPC] Switch to by-name matching for instructions (part 2 of 2).
Feb 2 2023, 12:29 PM · Restricted Project, Restricted Project
jyknight committed rG4b43ef3e5c37: [PowerPC] Switch to by-name matching for instructions (part 1 of 2). (authored by jyknight).
[PowerPC] Switch to by-name matching for instructions (part 1 of 2).
Feb 2 2023, 12:29 PM · Restricted Project, Restricted Project
jyknight closed D137670: [PowerPC] Switch to by-name matching for instructions (part 2 of 2)..
Feb 2 2023, 12:29 PM · Restricted Project, Restricted Project
jyknight closed D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2)..
Feb 2 2023, 12:29 PM · Restricted Project, Restricted Project
jyknight added a comment to D137670: [PowerPC] Switch to by-name matching for instructions (part 2 of 2)..

Thanks for the reviews!

Feb 2 2023, 9:24 AM · Restricted Project, Restricted Project

Feb 1 2023

jyknight added a comment to D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings.

For tiny and small code models, we use DW_EH_PE_sdata8 instead of GCC's
DW_EH_PE_sdata4. This is a deliberate choice to support personality-.eh_frame
offset > 2GiB.

Feb 1 2023, 3:39 PM · Restricted Project, Restricted Project

Jan 31 2023

jyknight added inline comments to D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.
Jan 31 2023, 5:25 PM · Restricted Project, Restricted Project
jyknight updated the diff for D137670: [PowerPC] Switch to by-name matching for instructions (part 2 of 2)..

Rebase.

Jan 31 2023, 5:20 PM · Restricted Project, Restricted Project
jyknight updated the diff for D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2)..

Rebase.

Jan 31 2023, 5:19 PM · Restricted Project, Restricted Project
jyknight updated the diff for D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2)..

Rebase.

Jan 31 2023, 5:19 PM · Restricted Project, Restricted Project
jyknight committed rG61e9e6199e2e: [VE] Fix useDeprecatedPositionallyEncodedOperands errors. (authored by jyknight).
[VE] Fix useDeprecatedPositionallyEncodedOperands errors.
Jan 31 2023, 4:51 PM · Restricted Project, Restricted Project
jyknight closed D140922: [VE] Fix useDeprecatedPositionallyEncodedOperands errors..
Jan 31 2023, 4:51 PM · Restricted Project, Restricted Project
jyknight added inline comments to D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.
Jan 31 2023, 4:06 PM · Restricted Project, Restricted Project
jyknight added a comment to D137811: InstCombine: Perform basic isnan combines on llvm.is.fpclass.

I do not believe there's any problem with an isnan to fcmp transform -- as long as we restrict it to non-strictfp functions. And I'm not sure why there's so much debate here. I thought all those sorts of semantic questions were already pretty well settled. Does the documentation about strictfp vs not-strictfp semantics need to be made clearer?

Jan 31 2023, 3:46 PM · Restricted Project, Restricted Project
jyknight committed rGab0116e2f05c: [Clang] Improve error message for violations of -fmodules-decluse. (authored by jyknight).
[Clang] Improve error message for violations of -fmodules-decluse.
Jan 31 2023, 6:57 AM · Restricted Project, Restricted Project
jyknight closed D142925: [Clang] Improve error message for violations of -fmodules-decluse..
Jan 31 2023, 6:57 AM · Restricted Project, Restricted Project
jyknight added inline comments to D140180: [llvm] add CallBrPrepare pass to pipelines.
Jan 31 2023, 5:52 AM · Restricted Project, Restricted Project

Jan 30 2023

jyknight added inline comments to D140160: [llvm][SelectionDAGBuilder] codegen callbr.landingpad intrinsic.
Jan 30 2023, 1:58 PM · Restricted Project, Restricted Project
jyknight added inline comments to D139861: [llvm] boilerplate for new callbrprepare codegen IR pass.
Jan 30 2023, 1:57 PM · Restricted Project, Restricted Project
jyknight requested review of D142925: [Clang] Improve error message for violations of -fmodules-decluse..
Jan 30 2023, 12:07 PM · Restricted Project, Restricted Project

Jan 27 2023

jyknight accepted D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC.
Jan 27 2023, 4:31 PM · Restricted Project, Restricted Project
jyknight added inline comments to D140180: [llvm] add CallBrPrepare pass to pipelines.
Jan 27 2023, 3:46 PM · Restricted Project, Restricted Project
jyknight accepted D139970: [llvm][CallBrPrepare] use SSAUpdater to use intrinsic value.
Jan 27 2023, 2:50 PM · Restricted Project, Restricted Project
jyknight accepted D139883: [llvm][CallBrPrepare] add llvm.callbr.landingpad intrinsic.
Jan 27 2023, 2:48 PM · Restricted Project, Restricted Project
jyknight accepted D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension.
Jan 27 2023, 7:27 AM · Restricted Project, Restricted Project

Jan 25 2023

jyknight added inline comments to D140180: [llvm] add CallBrPrepare pass to pipelines.
Jan 25 2023, 10:49 AM · Restricted Project, Restricted Project
jyknight added inline comments to D140160: [llvm][SelectionDAGBuilder] codegen callbr.landingpad intrinsic.
Jan 25 2023, 10:47 AM · Restricted Project, Restricted Project
jyknight accepted D139872: [llvm][CallBrPrepare] split critical edges.

Thanks, looks good now!

Jan 25 2023, 8:11 AM · Restricted Project, Restricted Project

Jan 19 2023

jyknight added inline comments to D139883: [llvm][CallBrPrepare] add llvm.callbr.landingpad intrinsic.
Jan 19 2023, 11:53 AM · Restricted Project, Restricted Project
jyknight added inline comments to D139872: [llvm][CallBrPrepare] split critical edges.
Jan 19 2023, 11:01 AM · Restricted Project, Restricted Project
jyknight added inline comments to D139861: [llvm] boilerplate for new callbrprepare codegen IR pass.
Jan 19 2023, 11:01 AM · Restricted Project, Restricted Project
jyknight added inline comments to D139861: [llvm] boilerplate for new callbrprepare codegen IR pass.
Jan 19 2023, 10:11 AM · Restricted Project, Restricted Project

Jan 17 2023

jyknight added inline comments to D137653: [TableGen] More named sub-operands work..
Jan 17 2023, 6:06 AM · Restricted Project, Restricted Project
Herald added a project to D73739: Exception support for basic block sections: Restricted Project.

This does not matter in practice because these call site tables are all comprehensive

Jan 17 2023, 5:47 AM · Restricted Project, Restricted Project
jyknight requested review of D141918: WIP: [Clang] Emit 'unwindabort' when applicable..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project
jyknight requested review of D141917: WIP: Unwindabort: Implement CodeGen for DWARF-style exception handling..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project
jyknight requested review of D141916: WIP: Unwindabort: add support for IR transforms and analysis..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project
jyknight requested review of D141915: WIP: Unwindabort: Add "unwindabort" syntax for the "catchswitch" instruction..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project
jyknight requested review of D141914: WIP: Unwindabort: Add "unwindabort" syntax for the "resume" instruction..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project
jyknight requested review of D141913: WIP: Unwindabort: Add "unwindabort" syntax for the "call" instruction..
Jan 17 2023, 3:53 AM · Restricted Project, Restricted Project

Jan 16 2023

jyknight committed rG06210d50c05d: ExceptionHandling documentation tweaks. (authored by jyknight).
ExceptionHandling documentation tweaks.
Jan 16 2023, 5:36 PM · Restricted Project, Restricted Project
jyknight committed rG52f6ed099cba: Move Personalities array from MachineModuleInfo to DwarfCFIException. (authored by jyknight).
Move Personalities array from MachineModuleInfo to DwarfCFIException.
Jan 16 2023, 3:17 PM · Restricted Project, Restricted Project
jyknight committed rGa1551fdd4888: FastISel: remove EH_LABEL skipping code. (authored by jyknight).
FastISel: remove EH_LABEL skipping code.
Jan 16 2023, 3:17 PM · Restricted Project, Restricted Project

Jan 12 2023

jyknight updated the diff for D140922: [VE] Fix useDeprecatedPositionallyEncodedOperands errors..

Rename 'cf' field to 'cond' per review request.

Jan 12 2023, 3:41 PM · Restricted Project, Restricted Project
jyknight added a comment to D120634: [Libcxx] Add <source_location> header..
Jan 12 2023, 4:40 AM · Restricted Project, Restricted Project

Jan 11 2023

jyknight committed rG73d94b191613: [Libcxx] Add <source_location> header. (authored by jyknight).
[Libcxx] Add <source_location> header.
Jan 11 2023, 1:03 PM · Restricted Project, Restricted Project
jyknight closed D120634: [Libcxx] Add <source_location> header..
Jan 11 2023, 1:02 PM · Restricted Project, Restricted Project
jyknight updated the diff for D120634: [Libcxx] Add <source_location> header..

Fix transitive_includes test errors.

Jan 11 2023, 7:48 AM · Restricted Project, Restricted Project
jyknight updated the diff for D120634: [Libcxx] Add <source_location> header..

Add missing auto-generated file, fix review nits.

Jan 11 2023, 6:58 AM · Restricted Project, Restricted Project

Jan 10 2023

jyknight added a comment to D120634: [Libcxx] Add <source_location> header..

Now that D136554 has re-landed, it seems that we're now actually good to go here (yay!)

Jan 10 2023, 6:10 PM · Restricted Project, Restricted Project
jyknight updated the diff for D120634: [Libcxx] Add <source_location> header..

Rebase, rerun ninja libcxx-generate-files, address last review nits.

Jan 10 2023, 6:09 PM · Restricted Project, Restricted Project

Jan 9 2023

jyknight accepted D141191: [CMake][LoongArch] Add LoongArch to LLVM_ALL_TARGETS so it is built by default.

Hearning no objections, I'll approve this.

Jan 9 2023, 3:18 PM · Restricted Project, Restricted Project
jyknight added a comment to D138307: [libc++] Remove default definition of std::char_traits.

Leaving an xref trail here, I filed issues against the two projects I reported above:

Jan 9 2023, 3:10 PM · Restricted Project, Restricted Project

Jan 6 2023

jyknight committed rG648ce3d35856: Cleanup unwind table emission code a bit. (authored by jyknight).
Cleanup unwind table emission code a bit.
Jan 6 2023, 10:54 AM · Restricted Project, Restricted Project
jyknight committed rG1ae36b1387e4: Remove special cases for invoke of non-throwing inline-asm. (authored by jyknight).
Remove special cases for invoke of non-throwing inline-asm.
Jan 6 2023, 10:54 AM · Restricted Project, Restricted Project

Jan 5 2023

jyknight added a comment to rG2679e8bba3e1: [X86] Revert -fno-plt __tls_get_addr workaround for old GNU ld.

I wonder if, at this point, we could just default relax-elf-relocations to true in LLVM -- and potentially even remove the cmake ENABLE_X86_RELAX_RELOCATIONS knob, as well.

Jan 5 2023, 12:54 PM · Restricted Project, Restricted Project
jyknight added a comment to rG2679e8bba3e1: [X86] Revert -fno-plt __tls_get_addr workaround for old GNU ld.

AFAIU, the upshot of https://sourceware.org/bugzilla/show_bug.cgi?id=24784 is that -fno-plt is broken after this change, unless -mrelax-relocations is enabled. Clang enables it by default subject to the CMake option ENABLE_X86_RELAX_RELOCATIONS (which defaults to on), but it's disabled by default by LLVM itself.

Jan 5 2023, 12:14 PM · Restricted Project, Restricted Project

Jan 4 2023

jyknight added a comment to D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2)..

Now PPC and VE are the last two targets still using useDeprecatedPositionallyEncodedOperands. This change is repetitive and large -- but necessary.

Jan 4 2023, 9:53 AM · Restricted Project, Restricted Project
jyknight added a reviewer for D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2).: stefanp.
Jan 4 2023, 9:46 AM · Restricted Project, Restricted Project
jyknight updated the diff for D137670: [PowerPC] Switch to by-name matching for instructions (part 2 of 2)..

Rebase

Jan 4 2023, 9:44 AM · Restricted Project, Restricted Project
jyknight updated the diff for D137661: [PowerPC] Switch to by-name matching for instructions (part 1 of 2)..

Rebase.

Jan 4 2023, 9:44 AM · Restricted Project, Restricted Project

Jan 3 2023

jyknight committed rG7ff64d44b9c1: [AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors. (authored by jyknight).
[AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors.
Jan 3 2023, 2:52 PM · Restricted Project, Restricted Project
jyknight closed D140918: [AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors..
Jan 3 2023, 2:52 PM · Restricted Project, Restricted Project
jyknight requested review of D140922: [VE] Fix useDeprecatedPositionallyEncodedOperands errors..
Jan 3 2023, 1:10 PM · Restricted Project, Restricted Project
jyknight requested review of D140918: [AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors..
Jan 3 2023, 12:42 PM · Restricted Project, Restricted Project

Dec 12 2022

jyknight added a comment to D139893: [RISCV] Set ShouldSignExtI32Param in TargetLibraryInfo for riscv64..

So, I guess these have all been getting actually miscompiled on riscv64 up till now? Whoops!

Dec 12 2022, 4:40 PM · Restricted Project, Restricted Project

Dec 10 2022

jyknight accepted D139772: InstSimplify: Add basic folding of llvm.is.fpclass intrinsic.
Dec 10 2022, 6:03 PM · Restricted Project, Restricted Project
jyknight accepted D139761: Verifier: Enforce value of llvm.is.fpclass test mask.
Dec 10 2022, 5:44 PM · Restricted Project, Restricted Project

Dec 8 2022

jyknight accepted D139652: Add the thread sanitizer support for X86_64 WatchOS simulators.

Thanks for the change.

Dec 8 2022, 10:41 AM · Restricted Project, Restricted Project
jyknight updated subscribers of D139652: Add the thread sanitizer support for X86_64 WatchOS simulators.
Dec 8 2022, 10:39 AM · Restricted Project, Restricted Project