Page MenuHomePhabricator

vkmr (Vineet Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
May 7 2019, 7:55 AM (159 w, 3 d)

Recent Activity

Feb 25 2022

vkmr updated subscribers of D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

So, um, I would like to look at your patches, but I'm not having much success running "arc patch" against them.

@SamB, this patch is highly out of sync with the upstream and won't work in its current state. The VPlan infrastructure has significantly changed since this patch. If you want to focus on the VPlan part of this patch, patch stack - D104608, D104610, D104673, D104979 is a bit more recent although I suspect they would still conflict with the upstream.

Feb 25 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2021

vkmr updated the diff for D104608: [VPlan, VP] Introduce new recipes to support predicated vectorization.

Rebasing on more recent upstream main.

Nov 22 2021, 9:40 PM · Restricted Project, Restricted Project

Oct 12 2021

vkmr added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

@simoll I believe there is a way to commit without changing the author, such that both phabricator and github show something like "authored by <author> and committed by <committer>".

Oct 12 2021, 7:14 AM · Restricted Project, Restricted Project

Sep 28 2021

vkmr added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

Can someone please commit it on my behalf? I don't have commit access.

Sep 28 2021, 6:10 AM · Restricted Project, Restricted Project

Aug 13 2021

vkmr updated the diff for D103898: [VP] Vector predicated vector splice intrinsic.

addressed typos found by @frasercrmck.

Aug 13 2021, 3:30 PM · Restricted Project, Restricted Project

Jul 7 2021

vkmr added inline comments to D104673: [LV, VP] Add CLI option to support predicated vectorization.
Jul 7 2021, 2:07 PM · Restricted Project, Restricted Project, Restricted Project
vkmr added a comment to D104673: [LV, VP] Add CLI option to support predicated vectorization.

Ping!

Jul 7 2021, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
vkmr added a comment to D104610: [VPlan, VP] Introduce new live-in values and refactoring to support EVL recipe.

Ping!

Jul 7 2021, 7:12 AM · Restricted Project, Restricted Project, Restricted Project
vkmr added a comment to D104608: [VPlan, VP] Introduce new recipes to support predicated vectorization.

Just a friendly ping!

Jul 7 2021, 7:12 AM · Restricted Project, Restricted Project

Jul 5 2021

vkmr updated the diff for D103898: [VP] Vector predicated vector splice intrinsic.

Addressed comments.

Jul 5 2021, 4:47 AM · Restricted Project, Restricted Project

Jul 1 2021

vkmr added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

As discussed on the call, maybe rename llvm.experimental.vp.vector.splice to llvm.experimental.vp.splice.. the "vector" is implied

Jul 1 2021, 7:31 PM · Restricted Project, Restricted Project
vkmr added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

This patch needs to implement VPIntrinsic::getDeclarationForParams.

Jul 1 2021, 7:30 PM · Restricted Project, Restricted Project
vkmr updated the diff for D103898: [VP] Vector predicated vector splice intrinsic.

Addressed @simoll's comment. Took the liberty to clang-format part of the test for memory ops.

Jul 1 2021, 7:27 PM · Restricted Project, Restricted Project

Jun 26 2021

vkmr requested review of D104979: [VPlan, VP] WIP: Build and execute VP recipes.
Jun 26 2021, 8:46 AM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2021

vkmr requested review of D104673: [LV, VP] Add CLI option to support predicated vectorization.
Jun 21 2021, 3:43 PM · Restricted Project, Restricted Project, Restricted Project

Jun 20 2021

vkmr added a reviewer for D104608: [VPlan, VP] Introduce new recipes to support predicated vectorization: HsiangKai.
Jun 20 2021, 6:37 PM · Restricted Project, Restricted Project
vkmr added reviewers for D104610: [VPlan, VP] Introduce new live-in values and refactoring to support EVL recipe: simoll, rogfer01, fhahn, craig.topper, frasercrmck, sdesmalen, HsiangKai.
Jun 20 2021, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
vkmr requested review of D104610: [VPlan, VP] Introduce new live-in values and refactoring to support EVL recipe.
Jun 20 2021, 6:32 PM · Restricted Project, Restricted Project, Restricted Project
vkmr requested review of D104608: [VPlan, VP] Introduce new recipes to support predicated vectorization.
Jun 20 2021, 4:38 PM · Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Address VPlan related comments.

Jun 20 2021, 2:51 PM · Restricted Project, Restricted Project, Restricted Project

Jun 10 2021

vkmr added a reviewer for D103898: [VP] Vector predicated vector splice intrinsic: HsiangKai.
Jun 10 2021, 6:54 AM · Restricted Project, Restricted Project
vkmr added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

Are evl1 and evl2 likely to be the same value? Do you have an example when they would be different?

Jun 10 2021, 6:51 AM · Restricted Project, Restricted Project

Jun 8 2021

vkmr retitled D103898: [VP] Vector predicated vector splice intrinsic from [VP] Length predicated vector splice intrinsic to [VP] Vector predicated vector splice intrinsic.
Jun 8 2021, 8:01 AM · Restricted Project, Restricted Project
vkmr requested review of D103898: [VP] Vector predicated vector splice intrinsic.
Jun 8 2021, 7:46 AM · Restricted Project, Restricted Project

Jun 7 2021

vkmr accepted D102686: [VP] getDeclarationForParams.

LGTM.

Jun 7 2021, 11:59 AM · Restricted Project, Restricted Project

May 19 2021

vkmr added inline comments to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
May 19 2021, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
vkmr added a comment to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Thanks @fhahn for a look at the VPlan bits of the patch.

May 19 2021, 10:23 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2021

vkmr accepted D101945: [LV] Add -scalable-vectorization=<option> flag..

LGTM.

May 18 2021, 4:00 AM · Restricted Project

May 17 2021

vkmr added inline comments to D101945: [LV] Add -scalable-vectorization=<option> flag..
May 17 2021, 4:33 AM · Restricted Project

May 11 2021

vkmr added a comment to D101945: [LV] Add -scalable-vectorization=<option> flag..

Thanks @sdesmalen for the patch!
Just a couple of clarifying questions.
Also, all the non-target specific test cases only check for -scalable-vectorization=on and with metadata hint enabled (except for one that focuses on width hint). Just for the sake of completeness, more tests with different values for the flag and its combination with the metadata hint would be nice to have.

May 11 2021, 5:52 AM · Restricted Project

May 6 2021

vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Sync up with ongoing changes in VPlan. Minor refactor.

May 6 2021, 4:33 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2021

vkmr added a comment to D100941: Implementation for `TargetTransformInfo::hasActiveVectorLength()`.

@vkmr do you have commit rights? I can commit this for you.

Apr 26 2021, 6:17 AM · Restricted Project, Restricted Project

Apr 21 2021

vkmr requested review of D100941: Implementation for `TargetTransformInfo::hasActiveVectorLength()`.
Apr 21 2021, 4:10 AM · Restricted Project, Restricted Project

Apr 19 2021

vkmr added inline comments to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Apr 19 2021, 7:56 AM · Restricted Project, Restricted Project, Restricted Project

Apr 15 2021

vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Addressed review comments by @craig.topper and @frasercrmck.

Apr 15 2021, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
vkmr added a reviewer for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept): cameron.mcinally.
Apr 15 2021, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
vkmr added a reviewer for D93470: [VP] Binary floating-point intrinsics.: vkmr.
Apr 15 2021, 3:44 AM · Restricted Project, Restricted Project

Apr 14 2021

vkmr added a comment to D100474: [docs] Add vector predication call.

@simoll thanks for putting this up. Wondering if this would be the right place to add a link to the discord channel too!

Apr 14 2021, 9:08 AM · Restricted Project, Restricted Project

Apr 1 2021

vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Merged more recent changes on main.

Apr 1 2021, 6:29 PM · Restricted Project, Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Revert diff 334860

Apr 1 2021, 5:02 PM · Restricted Project, Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Remove unused header

Apr 1 2021, 4:57 PM · Restricted Project, Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Remove unused header include

Apr 1 2021, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
vkmr added reviewers for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept): sdesmalen, dmgreen, craig.topper, evandro, bmahjour, fhahn, hussainjk.
Apr 1 2021, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
vkmr updated the summary of D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Apr 1 2021, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
vkmr requested review of D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Apr 1 2021, 10:32 AM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2021

vkmr added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Thanks Hussain for this patch!
For now I have a couple of minor comments, I will take a deeper look later.
Also, I don't quite understand yet how VP handles (or plans to handle) specifying alignment parameter. Does it need VPBuilder (not to be confused with VPlan VPBuilder!) for that? Would it make sense to add the Alignment parameter to VP load/store/scatter/gather intrinsics (much like their masked counterparts) for now, unless there is already a way to specify that?

Mar 26 2021, 10:22 AM · Restricted Project, Restricted Project

Feb 1 2021

vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Feb 1 2021, 5:08 AM · Restricted Project

Jan 29 2021

vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Jan 29 2021, 10:45 AM · Restricted Project
vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Jan 29 2021, 5:16 AM · Restricted Project

Jan 27 2021

vkmr added a comment to D94708: [IR] Introduce llvm.experimental.vector.splice intrinsic.

FWIW, we have a similar intrinsic in our downstream compiler for RISC-V. We call it experimental.vector.slideleftfill and is same as flavour 2 of this (except the "offset" need not be an immediate) as suggested by @sdesmalen. We have a separate predicated version (experimental.vector.vp.slideleftfill) too which takes additional arguments for the explicit vector length of the two vectors.

Jan 27 2021, 2:27 AM · Restricted Project

Nov 5 2020

vkmr accepted D90715: [VPlan] NFC: Change VFRange to take ElementCount.

LGTM.

Nov 5 2020, 1:09 PM · Restricted Project
vkmr added a comment to D90715: [VPlan] NFC: Change VFRange to take ElementCount.

Other than the minor nit, LGTM.

Nov 5 2020, 7:30 AM · Restricted Project

Oct 29 2020

vkmr added a comment to D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .

Overall, definitely a good starting point. I just have a couple of minor comments.

Oct 29 2020, 6:13 AM · Restricted Project

Oct 5 2020

vkmr added inline comments to D88409: [SVE] Make ElementCount and TypeSize use a new PolySize class.
Oct 5 2020, 5:34 PM · Restricted Project, Restricted Project

Sep 30 2020

vkmr added inline comments to D88409: [SVE] Make ElementCount and TypeSize use a new PolySize class.
Sep 30 2020, 7:56 AM · Restricted Project, Restricted Project

Aug 14 2020

vkmr added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:57 PM · Restricted Project
vkmr added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:41 PM · Restricted Project

Aug 13 2020

vkmr added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thanks @fpetrogalli for this proposal! I agree with @rogfer01 and @rengolin in that this approach makes a lot of sense.
I have added a few comments inline. Overall looks good.

Aug 13 2020, 6:08 AM · Restricted Project

May 18 2020

vkmr added inline comments to D79100: [LV] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops.
May 18 2020, 4:18 PM · Restricted Project
vkmr added inline comments to D79100: [LV] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops.
May 18 2020, 3:45 PM · Restricted Project