- User Since
- May 7 2019, 7:55 AM (203 w, 4 d)
Feb 25 2022
So, um, I would like to look at your patches, but I'm not having much success running "arc patch" against them.
@SamB, this patch is highly out of sync with the upstream and won't work in its current state. The VPlan infrastructure has significantly changed since this patch. If you want to focus on the VPlan part of this patch, patch stack - D104608, D104610, D104673, D104979 is a bit more recent although I suspect they would still conflict with the upstream.
Nov 22 2021
Rebasing on more recent upstream main.
Oct 12 2021
@simoll I believe there is a way to commit without changing the author, such that both phabricator and github show something like "authored by <author> and committed by <committer>".
Sep 28 2021
Can someone please commit it on my behalf? I don't have commit access.
Aug 13 2021
addressed typos found by @frasercrmck.
Jul 7 2021
Just a friendly ping!
Jul 5 2021
Jul 1 2021
Addressed @simoll's comment. Took the liberty to clang-format part of the test for memory ops.
Jun 26 2021
Jun 21 2021
Jun 20 2021
Address VPlan related comments.
Jun 10 2021
Jun 8 2021
Jun 7 2021
May 19 2021
Thanks @fhahn for a look at the VPlan bits of the patch.
May 18 2021
May 17 2021
May 11 2021
Thanks @sdesmalen for the patch!
Just a couple of clarifying questions.
Also, all the non-target specific test cases only check for -scalable-vectorization=on and with metadata hint enabled (except for one that focuses on width hint). Just for the sake of completeness, more tests with different values for the flag and its combination with the metadata hint would be nice to have.
May 6 2021
Sync up with ongoing changes in VPlan. Minor refactor.
Apr 26 2021
Apr 21 2021
Apr 19 2021
Apr 15 2021
Addressed review comments by @craig.topper and @frasercrmck.
Apr 14 2021
@simoll thanks for putting this up. Wondering if this would be the right place to add a link to the discord channel too!
Apr 1 2021
Merged more recent changes on main.
Revert diff 334860
Remove unused header
Remove unused header include
Mar 26 2021
Thanks Hussain for this patch!
For now I have a couple of minor comments, I will take a deeper look later.
Also, I don't quite understand yet how VP handles (or plans to handle) specifying alignment parameter. Does it need VPBuilder (not to be confused with VPlan VPBuilder!) for that? Would it make sense to add the Alignment parameter to VP load/store/scatter/gather intrinsics (much like their masked counterparts) for now, unless there is already a way to specify that?
Feb 1 2021
Jan 29 2021
Jan 27 2021
FWIW, we have a similar intrinsic in our downstream compiler for RISC-V. We call it experimental.vector.slideleftfill and is same as flavour 2 of this (except the "offset" need not be an immediate) as suggested by @sdesmalen. We have a separate predicated version (experimental.vector.vp.slideleftfill) too which takes additional arguments for the explicit vector length of the two vectors.
Nov 5 2020
Other than the minor nit, LGTM.
Oct 29 2020
Overall, definitely a good starting point. I just have a couple of minor comments.
Oct 5 2020
Sep 30 2020
Aug 14 2020
Aug 13 2020
Thanks @fpetrogalli for this proposal! I agree with @rogfer01 and @rengolin in that this approach makes a lot of sense.
I have added a few comments inline. Overall looks good.