Page MenuHomePhabricator
Differential D74977

[RISCV][GlobalISel] Add lowerFormalArguments for calling convention
Needs ReviewPublic
Actions

Authored by lewis-revill on Feb 21 2020, 11:34 AM.

Details

Reviewers
asb
weiwei
luismarques
simoncook
apazos
shiva0217
Joe
edward-jones
dsanders
arsenm
lenary
Summary

This patch adds an IncomingValueHandler and IncomingValueAssigner, and implements minimal support for lowering formal arguments according to the RISC-V calling convention. Simple non-aggregate integer and pointer types are supported.

Diff Detail

Unit TestsFailed
View All

TimeTest
1,580 msx64 debian > libarcher.races::critical-unrelated.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/critical-unrelated.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/critical-unrelated.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/critical-unrelated.c
1,740 msx64 debian > libarcher.races::lock-nested-unrelated.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-nested-unrelated.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-nested-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-nested-unrelated.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-nested-unrelated.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-nested-unrelated.c
1,640 msx64 debian > libarcher.races::lock-unrelated.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c
1,720 msx64 debian > libarcher.races::parallel-simple.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/parallel-simple.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/parallel-simple.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/parallel-simple.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/parallel-simple.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/parallel-simple.c
1,640 msx64 debian > libarcher.races::task-dependency.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-dependency.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-dependency.c
View Full Test Results (9 Failed)

Event Timeline

lewis-revill created this revision.Feb 21 2020, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2020, 11:34 AM
Herald added subscribers: llvm-commits, evandro, sameer.abuasal and 23 others. · View Herald Transcript
lewis-revill added a parent revision: D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..Feb 21 2020, 11:35 AM
lewis-revill updated this revision to Diff 246068.Feb 22 2020, 2:51 AM
lewis-revill updated this revision to Diff 246115.Feb 23 2020, 11:07 AM
lewis-revill added a child revision: D75023: [RISCV][GlobalISel] Add lowerCall for calling convention.Feb 23 2020, 11:11 AM
lewis-revill updated this revision to Diff 248480.Mar 5 2020, 7:46 AM

Rebase, update test structure.

Harbormaster failed remote builds in B48201: Diff 248480!Mar 5 2020, 8:45 AM
lewis-revill edited parent revisions, added: D75683: [NFC][RISCV][GlobalISel] Move test file into irtranslator subdirectory; removed: D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..Mar 18 2020, 10:02 AM
lewis-revill added a reviewer: Joe.Mar 18 2020, 10:07 AM
Joe added inline comments.Mar 20 2020, 7:52 AM
llvm/lib/Target/RISCV/RISCVCallLowering.cpp
201

Perhaps add a test for this?

203

Floats don't work here. HandleAssignments tries to truncate it. Best to leave it unsupported for now.

lewis-revill updated this revision to Diff 253565.Mar 30 2020, 5:37 AM
lewis-revill edited the summary of this revision. (Show Details)

Address comments relating to supported types.

Harbormaster failed remote builds in B50945: Diff 253565!Mar 30 2020, 6:27 AM
lewis-revill updated this revision to Diff 254140.Apr 1 2020, 3:06 AM
Harbormaster failed remote builds in B51268: Diff 254140!Apr 1 2020, 3:51 AM
lenary resigned from this revision.Jan 14 2021, 10:10 AM
Herald added subscribers: frasercrmck, NickHung. · View Herald TranscriptJan 14 2021, 10:10 AM
rkruppe removed a subscriber: rkruppe.Jan 14 2021, 10:20 AM
lewis-revill updated this revision to Diff 399995.Jan 14 2022, 7:29 AM
lewis-revill edited the summary of this revision. (Show Details)
lewis-revill added reviewers: edward-jones, dsanders, arsenm.

Rebased, and updated where appropriate to continue to build correctly.

Herald added subscribers: VincentWu, luke957, achieveartificialintelligence and 2 others. · View Herald TranscriptJan 14 2022, 7:29 AM
lewis-revill edited parent revisions, added: D117318: [RISCV][GlobalISel] Add lowerReturn for calling conv; removed: D75683: [NFC][RISCV][GlobalISel] Move test file into irtranslator subdirectory.Jan 14 2022, 7:29 AM
Harbormaster completed remote builds in B143391: Diff 399995.Jan 14 2022, 9:01 AM
arsenm added inline comments.Jan 17 2022, 4:42 PM
llvm/lib/Target/RISCV/RISCVCallLowering.cpp
231

Same as other patches, don't copy your own splitToValueTypes

Herald added subscribers: alextsao1999, eopXD. · View Herald TranscriptJan 17 2022, 4:42 PM
lewis-revill updated this revision to Diff 403204.Jan 26 2022, 4:01 AM
lewis-revill edited the summary of this revision. (Show Details)

Introduce an IncomingValueAssigner to allow us to call determineAndHandleAssignments.

Herald added a subscriber: pcwang-thead. · View Herald TranscriptJan 26 2022, 4:01 AM
lewis-revill marked 3 inline comments as done.Jan 26 2022, 4:02 AM
Harbormaster completed remote builds in B145709: Diff 403204.Jan 27 2022, 1:12 AM
lewis-revill retitled this revision from [WIP][RISCV][GlobalISel] Add lowerFormalArguments for calling convention to [RISCV][GlobalISel] Add lowerFormalArguments for calling convention.Feb 9 2022, 3:12 AM
arsenm added inline comments.Feb 9 2022, 8:46 AM
llvm/test/CodeGen/RISCV/GlobalISel/irtranslator/args.ll
257

Probably should have some byval, sret, and cases where the argument list runs out of registers. Same for return values / hidden sret

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
97 lines
test/
CodeGen/
RISCV/
GlobalISel/
irtranslator/
257 lines

Diff 403204

View Options

llvm/lib/Target/RISCV/RISCVCallLowering.cpp

Loading...
View Options

llvm/test/CodeGen/RISCV/GlobalISel/irtranslator/args.ll

Loading...