Page MenuHomePhabricator

achieveartificialintelligence (new account: sunshaoce)
new account: sunshaoce

Projects

User does not belong to any projects.

User Details

User Since
Aug 4 2020, 2:44 AM (93 w, 6 d)

Recent Activity

Mar 28 2022

achieveartificialintelligence updated achieveartificialintelligence.
Mar 28 2022, 7:24 PM

Mar 15 2022

achieveartificialintelligence updated achieveartificialintelligence.
Mar 15 2022, 11:35 AM
achieveartificialintelligence updated achieveartificialintelligence.
Mar 15 2022, 11:27 AM
achieveartificialintelligence added inline comments to D117432: [RISCV] Implement support for the Zicbom and Zicboz extensions.
Mar 15 2022, 11:04 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D121670: [RISCV] Add zihintntl instructions.

Fix typo

Mar 15 2022, 12:49 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence requested review of D121670: [RISCV] Add zihintntl instructions.
Mar 15 2022, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2022

achieveartificialintelligence updated achieveartificialintelligence.
Mar 12 2022, 11:00 PM

Mar 7 2022

achieveartificialintelligence committed rG365c858a5dca: [RISCV] Share PatFprFpr classes for F, D, and Zfh (authored by achieveartificialintelligence).
[RISCV] Share PatFprFpr classes for F, D, and Zfh
Mar 7 2022, 9:02 PM · Restricted Project
achieveartificialintelligence closed D121066: [RISCV] Share PatFprFpr classes for F, D, and Zfh.
Mar 7 2022, 9:02 PM · Restricted Project, Restricted Project

Mar 6 2022

achieveartificialintelligence requested review of D121066: [RISCV] Share PatFprFpr classes for F, D, and Zfh.
Mar 6 2022, 1:25 AM · Restricted Project, Restricted Project

Mar 4 2022

achieveartificialintelligence committed rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence).
[RISCV] Support k-ext clang intrinsics
Mar 4 2022, 9:57 PM · Restricted Project
achieveartificialintelligence closed D112774: [RISCV] Support k-ext clang intrinsics.
Mar 4 2022, 9:57 PM · Restricted Project, Restricted Project

Mar 3 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Address @craig.topper's comments. Thanks!

Mar 3 2022, 6:30 AM · Restricted Project, Restricted Project

Mar 1 2022

achieveartificialintelligence committed rG0e38b295435b: [RISCV] add the MC layer support of Zfinx extension (authored by achieveartificialintelligence).
[RISCV] add the MC layer support of Zfinx extension
Mar 1 2022, 10:25 PM · Restricted Project
achieveartificialintelligence closed D93298: [RISCV] add the MC layer support of Zfinx extension.
Mar 1 2022, 10:25 PM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Address @craig.topper's comment

Feb 28 2022, 9:29 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Are there any other errors now? @krasimir @nikic

Feb 28 2022, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence added inline comments to D120597: [RISCV] With Zbb, fold (sext_inreg (abs X)) -> (max X, (negw X)).
Feb 28 2022, 7:10 AM · Restricted Project, Restricted Project

Feb 27 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Address @jrtc27's comments

Feb 27 2022, 9:07 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Rebase

Feb 27 2022, 6:33 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Can you help test if this patch works fine now? @krasimir

Feb 27 2022, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Fix typo

Feb 27 2022, 7:39 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Thanks for @craig.topper's detailed advice!

Feb 27 2022, 7:37 AM · Restricted Project, Restricted Project

Feb 25 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Ping & Rebase

Feb 25 2022, 4:28 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Thanks for @craig.topper's patch!

Feb 25 2022, 3:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

achieveartificialintelligence committed rG78b5f0fb0523: [NFC][RISCV] Reuse ISD::NodeType in float extension (authored by achieveartificialintelligence).
[NFC][RISCV] Reuse ISD::NodeType in float extension
Feb 24 2022, 3:58 AM
achieveartificialintelligence closed D120412: [NFC][RISCV] Reuse ISD::NodeType in float extension.
Feb 24 2022, 3:58 AM · Restricted Project
achieveartificialintelligence reopened D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 24 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rGa8b4b9104c8f: [NFC][clang] Simplify `isOneOf` function (authored by achieveartificialintelligence).
[NFC][clang] Simplify `isOneOf` function
Feb 24 2022, 3:12 AM
achieveartificialintelligence closed D117740: [NFC][clang] Simplify `isOneOf` function.
Feb 24 2022, 3:12 AM · Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@achieveartificialintelligence any progress with the problematic IR? Have you been able to reproduce using nikic's reduced example?

Feb 24 2022, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

achieveartificialintelligence added a comment to D117740: [NFC][clang] Simplify `isOneOf` function.

Ping

Feb 23 2022, 7:25 PM · Restricted Project
achieveartificialintelligence added reviewers for D117740: [NFC][clang] Simplify `isOneOf` function: rsmith, lebedev.ri, akyrtzi, tmatheson.
Feb 23 2022, 7:25 PM · Restricted Project
achieveartificialintelligence updated the diff for D120412: [NFC][RISCV] Reuse ISD::NodeType in float extension.

Address @craig.topper's comment

Feb 23 2022, 7:14 PM · Restricted Project
achieveartificialintelligence requested review of D120412: [NFC][RISCV] Reuse ISD::NodeType in float extension.
Feb 23 2022, 7:26 AM · Restricted Project

Feb 21 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Rebase

Feb 21 2022, 9:28 PM · Restricted Project, Restricted Project

Feb 18 2022

achieveartificialintelligence abandoned D120130: [RISCV] Fix zfinx test error in rust.
Feb 18 2022, 9:11 AM · Restricted Project
achieveartificialintelligence added a comment to D120130: [RISCV] Fix zfinx test error in rust.

Missing test

Feb 18 2022, 7:20 AM · Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

@krasimir Since I don't have a rust environment, can you help me to test if D120130 works?

Feb 18 2022, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence requested review of D120130: [RISCV] Fix zfinx test error in rust.
Feb 18 2022, 6:47 AM · Restricted Project

Feb 17 2022

achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Thanks all!

Feb 17 2022, 5:59 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rG7798ecca9c3d: [RISCV] add the MC layer support of Zfinx extension (authored by achieveartificialintelligence).
[RISCV] add the MC layer support of Zfinx extension
Feb 17 2022, 5:54 AM
achieveartificialintelligence closed D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 17 2022, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rGf29f86b60bf7: [NFC] Fix comment (authored by achieveartificialintelligence).
[NFC] Fix comment
Feb 17 2022, 5:19 AM
achieveartificialintelligence committed rG21ac47439218: [NFC] Correct typo `interger` to `integer` (authored by achieveartificialintelligence).
[NFC] Correct typo `interger` to `integer`
Feb 17 2022, 5:18 AM

Feb 15 2022

achieveartificialintelligence added a comment to D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`.

@achieveartificialintelligence Please explain why a patch is reverted in the commit message next time.

Feb 15 2022, 10:55 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rG2aed07e96c7a: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter` (authored by achieveartificialintelligence).
[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`
Feb 15 2022, 9:38 PM
achieveartificialintelligence added a reverting change for rGfe25c06cc5bd: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`: rG9cc49c1951dc: Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`".
Feb 15 2022, 7:58 PM
achieveartificialintelligence committed rG9cc49c1951dc: Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`" (authored by achieveartificialintelligence).
Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`"
Feb 15 2022, 7:58 PM
achieveartificialintelligence added a reverting change for D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`: rG9cc49c1951dc: Revert "[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`".
Feb 15 2022, 7:58 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rGfe25c06cc5bd: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter` (authored by achieveartificialintelligence).
[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`
Feb 15 2022, 7:47 PM
achieveartificialintelligence closed D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`.
Feb 15 2022, 7:47 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence requested review of D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`.
Feb 15 2022, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Address @craig.topper's comments.

Feb 13 2022, 7:57 PM · Restricted Project, Restricted Project
achieveartificialintelligence added inline comments to D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Feb 13 2022, 7:40 PM · Restricted Project
achieveartificialintelligence committed rG352e19c02348: [NFC][RISCV] Remove redundant `Returned` (authored by achieveartificialintelligence).
[NFC][RISCV] Remove redundant `Returned`
Feb 13 2022, 7:39 PM
achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Ping & Rebase.

Feb 13 2022, 6:31 PM · Restricted Project, Restricted Project

Feb 11 2022

achieveartificialintelligence added inline comments to D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 11 2022, 5:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2022

achieveartificialintelligence added inline comments to D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 10 2022, 5:04 AM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Address comments.

Feb 10 2022, 4:57 AM · Restricted Project, Restricted Project, Restricted Project

Feb 4 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Amend tests.

Feb 4 2022, 9:21 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Address comments.

Feb 4 2022, 9:04 AM · Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Assuming this will be merged soon, do you want to submit a backport request for the 14.0 branch?

Feb 4 2022, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2022

achieveartificialintelligence updated the diff for D112774: [RISCV] Support k-ext clang intrinsics.

Rebase

Feb 3 2022, 5:50 AM · Restricted Project, Restricted Project
achieveartificialintelligence committed rG005fd8aa702e: [RISCV] Add support for Zihintpause extention (authored by achieveartificialintelligence).
[RISCV] Add support for Zihintpause extention
Feb 3 2022, 4:56 AM
achieveartificialintelligence closed D117789: [RISCV] Add support for Zihintpause extention.
Feb 3 2022, 4:55 AM · Restricted Project

Feb 1 2022

achieveartificialintelligence committed rGa2a7fc7ea561: [RISCV] Adjust some comments. (authored by achieveartificialintelligence).
[RISCV] Adjust some comments.
Feb 1 2022, 6:54 AM
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Separate the Zhinxmin and Zhinx extensions. Inspired by D118581

Feb 1 2022, 6:37 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2022

achieveartificialintelligence added a comment to D117740: [NFC][clang] Simplify `isOneOf` function.

Ping

Jan 31 2022, 4:35 AM · Restricted Project
achieveartificialintelligence added a comment to D117789: [RISCV] Add support for Zihintpause extention.

Ping

Jan 31 2022, 4:35 AM · Restricted Project
achieveartificialintelligence accepted D118581: [RISCV] Separate the Zfhmin and Zfh extensions..

LGTM. I think this is indeed a better way to implement Zfhmin.

Jan 31 2022, 4:34 AM · Restricted Project
achieveartificialintelligence accepted D118578: [RISCV] Make Zfhmin in march imply F..

LGTM. Sorry for my previous wrong comment.

Jan 31 2022, 4:31 AM · Restricted Project, Restricted Project

Jan 25 2022

achieveartificialintelligence committed rGf2c2333b6d2f: [NFC][llvm] Align the comment (authored by nannan1025).
[NFC][llvm] Align the comment
Jan 25 2022, 7:50 PM
achieveartificialintelligence closed D116579: [NFC][llvm] Align the comment.
Jan 25 2022, 7:50 PM · Restricted Project

Jan 24 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

@asb Thank you very much! Could you please take a look at what needs to be modified now?

Jan 24 2022, 7:16 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D113237: [RISCV] Support I extension version 2.1.

@achieveartificialintelligence Do you know what is the relation between your patch and D115921?

Jan 24 2022, 4:53 PM · Restricted Project, Restricted Project

Jan 20 2022

achieveartificialintelligence requested review of D117789: [RISCV] Add support for Zihintpause extention.
Jan 20 2022, 7:58 AM · Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Address @craig.topper's comments. Thanks!

Jan 20 2022, 12:10 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2022

achieveartificialintelligence added inline comments to D112408: [RISCV] Add the zve extension according to the v1.0 spec.
Jan 19 2022, 10:33 PM · Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Ping. Any other suggestions?

Jan 19 2022, 7:06 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence requested review of D117740: [NFC][clang] Simplify `isOneOf` function.
Jan 19 2022, 6:59 PM · Restricted Project

Jan 18 2022

achieveartificialintelligence updated the diff for D93019: [RISCV] Add support for Zihintpause extention.

This patch is accepted a year ago. Could this patch land now?

Jan 18 2022, 12:13 AM · Restricted Project
achieveartificialintelligence updated the summary of D93019: [RISCV] Add support for Zihintpause extention.
Jan 18 2022, 12:10 AM · Restricted Project

Jan 17 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

rebase

Jan 17 2022, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
achieveartificialintelligence committed rGefd72ee23b99: [NFC][SDNode] Use `StringSwitch` instead of `if` (authored by achieveartificialintelligence).
[NFC][SDNode] Use `StringSwitch` instead of `if`
Jan 17 2022, 4:12 PM
achieveartificialintelligence closed D117448: [NFC][SDNode] Use `StringSwitch` instead of `if`.
Jan 17 2022, 4:12 PM · Restricted Project

Jan 16 2022

achieveartificialintelligence updated the diff for D117448: [NFC][SDNode] Use `StringSwitch` instead of `if`.

Address @craig.topper's comments. Thanks!

Jan 16 2022, 8:21 PM · Restricted Project
achieveartificialintelligence added a reviewer for D117448: [NFC][SDNode] Use `StringSwitch` instead of `if`: craig.topper.
Jan 16 2022, 8:21 PM · Restricted Project
achieveartificialintelligence requested review of D117448: [NFC][SDNode] Use `StringSwitch` instead of `if`.
Jan 16 2022, 6:52 PM · Restricted Project

Jan 15 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Rebase

Jan 15 2022, 12:30 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2022

achieveartificialintelligence closed D117098: [RISCV] update zfh and zfhmin extention to v1.0.
Jan 14 2022, 5:22 PM · Restricted Project, Restricted Project
achieveartificialintelligence committed rGa0a76fee0cf8: [RISCV] update zfh and zfhmin extention to v1.0 (authored by achieveartificialintelligence).
[RISCV] update zfh and zfhmin extention to v1.0
Jan 14 2022, 5:22 PM
achieveartificialintelligence updated the diff for D117098: [RISCV] update zfh and zfhmin extention to v1.0.

Address @craig.topper's comments

Jan 14 2022, 5:16 PM · Restricted Project, Restricted Project

Jan 13 2022

achieveartificialintelligence accepted D117199: [RISCV] Add missing namespace (NFC).

OK, LGTM. Thanks! @fakepaper56 @khchen

Jan 13 2022, 5:17 PM · Restricted Project
achieveartificialintelligence accepted D117227: [RISCV][NFC] Use TableGen 'foreach' to simplify repetitive CSR definitions.

How about this way?

LGTM. Thanks! And sorry for my this comment.

Jan 13 2022, 8:47 AM · Restricted Project
achieveartificialintelligence added inline comments to D117227: [RISCV][NFC] Use TableGen 'foreach' to simplify repetitive CSR definitions.
Jan 13 2022, 8:46 AM · Restricted Project
achieveartificialintelligence added inline comments to D117227: [RISCV][NFC] Use TableGen 'foreach' to simplify repetitive CSR definitions.
Jan 13 2022, 8:31 AM · Restricted Project
achieveartificialintelligence added inline comments to D117227: [RISCV][NFC] Use TableGen 'foreach' to simplify repetitive CSR definitions.
Jan 13 2022, 8:09 AM · Restricted Project
achieveartificialintelligence added inline comments to D117199: [RISCV] Add missing namespace (NFC).
Jan 13 2022, 1:40 AM · Restricted Project

Jan 12 2022

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Address @craig.topper's comments

Jan 12 2022, 6:52 PM · Restricted Project, Restricted Project, Restricted Project