Page MenuHomePhabricator

achieveartificialintelligence (Shao-Ce Sun)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 4 2020, 2:44 AM (39 w, 3 d)

Recent Activity

Mar 23 2021

achieveartificialintelligence added a comment to D99017: [NFC][Kaleidoscope] Modify a char type typo.

Yeah, the code is correct as-is, changing it to char would be incorrect.

getchar returns int ( https://linux.die.net/man/3/getchar ) and needs to so it can return EOF, which isn't a char value (otherwise there'd be no way to distinguish between that char value correctly being read from the file, and the case where it indicates the end of the file)

Mar 23 2021, 11:46 PM · Restricted Project

Mar 20 2021

achieveartificialintelligence abandoned D99017: [NFC][Kaleidoscope] Modify a char type typo.
Mar 20 2021, 5:07 PM · Restricted Project
achieveartificialintelligence requested review of D99017: [NFC][Kaleidoscope] Modify a char type typo.
Mar 20 2021, 8:11 AM · Restricted Project

Mar 19 2021

achieveartificialintelligence committed rG4d11baab25a8: [NFC][ValueTypes] Align code by column (authored by achieveartificialintelligence).
[NFC][ValueTypes] Align code by column
Mar 19 2021, 10:44 PM
achieveartificialintelligence closed D98975: [NFC][ValueTypes] Align code by column.
Mar 19 2021, 10:43 PM · Restricted Project
achieveartificialintelligence updated the diff for D98975: [NFC][ValueTypes] Align code by column.

Align code by column

Mar 19 2021, 12:35 PM · Restricted Project
achieveartificialintelligence added a comment to D98975: [NFC][ValueTypes] Align code by column.

Why does this have RISCV in its title?

Otherwise LGTM

Mar 19 2021, 12:11 PM · Restricted Project
achieveartificialintelligence retitled D98975: [NFC][ValueTypes] Align code by column from [NFC][ValueTypes][RISCV]Align code by column to [NFC][ValueTypes] Align code by column.
Mar 19 2021, 12:09 PM · Restricted Project
achieveartificialintelligence updated the diff for D98975: [NFC][ValueTypes] Align code by column.

Align code by column

Mar 19 2021, 12:07 PM · Restricted Project
achieveartificialintelligence updated the diff for D98975: [NFC][ValueTypes] Align code by column.

Resume some whitespaces.

Mar 19 2021, 11:53 AM · Restricted Project
achieveartificialintelligence requested review of D98975: [NFC][ValueTypes] Align code by column.
Mar 19 2021, 11:37 AM · Restricted Project
achieveartificialintelligence abandoned D98933: [test commit] Add my name to the CREDITS.TXT.
Mar 19 2021, 2:45 AM · Restricted Project
achieveartificialintelligence updated subscribers of D98933: [test commit] Add my name to the CREDITS.TXT.
Mar 19 2021, 2:39 AM · Restricted Project
achieveartificialintelligence requested review of D98933: [test commit] Add my name to the CREDITS.TXT.
Mar 19 2021, 2:35 AM · Restricted Project

Feb 25 2021

achieveartificialintelligence committed rGad14ccc8c22e: [clang][flang] Improve the consistency of the code-base (authored by achieveartificialintelligence).
[clang][flang] Improve the consistency of the code-base
Feb 25 2021, 5:26 AM
achieveartificialintelligence closed D97138: [clang][flang] Improve the consistency of the code-base.
Feb 25 2021, 5:26 AM · Restricted Project
achieveartificialintelligence added a comment to D97138: [clang][flang] Improve the consistency of the code-base.

Thanks @aganea. And I have a question that, should I use argc & argv or argC & argV in the flang part now ?

Feb 25 2021, 12:41 AM · Restricted Project
achieveartificialintelligence updated the diff for D97138: [clang][flang] Improve the consistency of the code-base.
Feb 25 2021, 12:35 AM · Restricted Project

Feb 22 2021

achieveartificialintelligence added a comment to D97138: [clang][flang] Improve the consistency of the code-base.

Thank you for submitting this @achieveartificialintelligence !

The aim of these changes is to improve the consistency of the code-base with respect to the coding standards documented separately for Clang and Flang. I think that this is a very positive suggestion, but would like to request a few refinements before this is ready:

  • Please note that in LLVM/Clang, variables names start with upper case (so it should be int main(int Argc, const char **Argv) instead of main(int argc, const char **argv) ). link
  • In Flang the rules are slightly different, and the variable names start with a lower case (so it should be int main(int Argc, const char **Argv) instead of main(int argc, const char **argv) ). link
  • Your commit message refers to _a driver_, but in fact you are updating 2 specific drivers: Clang compiler driver and Flang compiler driver - could you clarify?
  • Your commit message refers to argc_ specifically, but you are updating argc_, argv_ and Argv/argv too.

Personally I'd prefer ArgC/argC and ArgV/argV for input parameters and ArgValues/argValues for the local variable. This way it would be more self-explanatory. But that's a matter of style. As long as this is consistent with the coding standards, I think that this should be accepted.

Feb 22 2021, 4:41 PM · Restricted Project
achieveartificialintelligence updated the diff for D97138: [clang][flang] Improve the consistency of the code-base.
Feb 22 2021, 4:41 PM · Restricted Project

Feb 21 2021

achieveartificialintelligence requested review of D97138: [clang][flang] Improve the consistency of the code-base.
Feb 21 2021, 12:10 AM · Restricted Project

Feb 1 2021

achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Ping

Feb 1 2021, 12:16 AM · Restricted Project, Restricted Project

Jan 28 2021

achieveartificialintelligence added a comment to D94579: [RISCV] add the MC layer support of P extension.

Ping.

Jan 28 2021, 4:34 AM · Restricted Project

Jan 27 2021

achieveartificialintelligence added a comment to D95588: [RISCV] Implement the MC layer support of P extension.
Jan 27 2021, 11:40 PM · Restricted Project, Restricted Project

Jan 19 2021

achieveartificialintelligence updated the diff for D94579: [RISCV] add the MC layer support of P extension.
Jan 19 2021, 11:45 PM · Restricted Project

Jan 13 2021

achieveartificialintelligence added reviewers for D94579: [RISCV] add the MC layer support of P extension: kito-cheng, Jim.
Jan 13 2021, 5:39 AM · Restricted Project
achieveartificialintelligence added a comment to D94579: [RISCV] add the MC layer support of P extension.

Thanks Everyone for all the comments. We will update the code later.

Jan 13 2021, 5:37 AM · Restricted Project

Jan 12 2021

achieveartificialintelligence requested review of D94579: [RISCV] add the MC layer support of P extension.
Jan 12 2021, 7:38 PM · Restricted Project

Jan 6 2021

achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Thanks for suggestions. We updated the code again.

Jan 6 2021, 6:27 AM · Restricted Project, Restricted Project

Jan 4 2021

achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Your tests look like copies of the F/D/Zfh tests with not all the comments updated and instances of tests that just don't make sense for Zfinx. I only skimmed them and picked up a few issues, I haven't gone through them thoroughly, please do that yourself.

Jan 4 2021, 4:17 AM · Restricted Project, Restricted Project
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Do you have implement register pair for rv32ifd_zfinx? I didn't saw the related implementation, but I could be wrong since I am not LLVM expert, in case you have implemented, you need a test case for that.

Jan 4 2021, 3:33 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Including Zfinx, zdinx. Zfhinx.

Jan 4 2021, 3:11 AM · Restricted Project, Restricted Project

Jan 3 2021

achieveartificialintelligence updated the summary of D93298: [RISCV] add the MC layer support of Zfinx extension.
Jan 3 2021, 10:16 PM · Restricted Project, Restricted Project

Dec 17 2020

achieveartificialintelligence updated achieveartificialintelligence.
Dec 17 2020, 4:53 AM
achieveartificialintelligence added a comment to D93298: [RISCV] add the MC layer support of Zfinx extension.

Thanks. I've updated it.

Dec 17 2020, 4:43 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.
Dec 17 2020, 4:07 AM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.
Dec 17 2020, 12:38 AM · Restricted Project, Restricted Project

Dec 15 2020

achieveartificialintelligence requested review of D93298: [RISCV] add the MC layer support of Zfinx extension.
Dec 15 2020, 6:53 AM · Restricted Project, Restricted Project

Oct 15 2020

achieveartificialintelligence committed rG2de693756fef: [RISCV] fix a mistake in RISCVInstrInfoV.td (authored by achieveartificialintelligence).
[RISCV] fix a mistake in RISCVInstrInfoV.td
Oct 15 2020, 8:17 AM
achieveartificialintelligence closed D88142: fix a mistake in RISCVInstrInfoV.td.
Oct 15 2020, 8:17 AM · Restricted Project

Sep 26 2020

achieveartificialintelligence abandoned D85190: remove STLExtras.h.
Sep 26 2020, 11:03 PM · Restricted Project

Sep 24 2020

achieveartificialintelligence added a comment to D88141: Update Kaleidoscope tutorial and remove useless header.
Sep 24 2020, 10:08 PM · Restricted Project

Sep 23 2020

achieveartificialintelligence updated the diff for D88141: Update Kaleidoscope tutorial and remove useless header.

thanks.

Sep 23 2020, 8:52 AM · Restricted Project
achieveartificialintelligence requested review of D88142: fix a mistake in RISCVInstrInfoV.td.
Sep 23 2020, 3:19 AM · Restricted Project
achieveartificialintelligence requested review of D88141: Update Kaleidoscope tutorial and remove useless header.
Sep 23 2020, 3:05 AM · Restricted Project

Aug 4 2020

achieveartificialintelligence added reviewers for D85190: remove STLExtras.h: kuhnel, azharudd, antiagainst.
Aug 4 2020, 1:21 PM · Restricted Project
achieveartificialintelligence set the repository for D85190: remove STLExtras.h to rG LLVM Github Monorepo.
Aug 4 2020, 3:16 AM · Restricted Project
achieveartificialintelligence added a comment to D85190: remove STLExtras.h.

I don't have commit access

Aug 4 2020, 2:58 AM · Restricted Project
achieveartificialintelligence requested review of D85190: remove STLExtras.h.
Aug 4 2020, 2:58 AM · Restricted Project