Page MenuHomePhabricator

Joe (Joseph Faulls)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2019, 1:37 AM (138 w, 4 d)

Recent Activity

Mar 21 2022

Joe updated the diff for D120908: [FuncSpec] Enable function specialize for a constant range of arguments.

Updated diff. Now a very small change.

Mar 21 2022, 8:00 AM · Restricted Project, Restricted Project
Joe added a comment to D120136: [ConstantRange] Construct constant range from xor operation.

Ping

Mar 21 2022, 7:42 AM · Restricted Project, Restricted Project

Mar 7 2022

Herald added a project to D120136: [ConstantRange] Construct constant range from xor operation: Restricted Project.

Ping

Mar 7 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 4 2022

Joe added a comment to D120908: [FuncSpec] Enable function specialize for a constant range of arguments.

My understanding is that function specialization of such constant arguments is controlled by the option -function-specialization-for-literal-constant. That is disabled by default as it increases compilation times. I measured how it affects instruction count using perf when compiling the llvm test suite. It was generally neutral except for the benchmark SPASS which was regressed by 4%.

Mar 4 2022, 1:42 AM · Restricted Project, Restricted Project

Mar 3 2022

Joe requested review of D120908: [FuncSpec] Enable function specialize for a constant range of arguments.
Mar 3 2022, 7:18 AM · Restricted Project, Restricted Project

Feb 21 2022

Joe added inline comments to D120136: [ConstantRange] Construct constant range from xor operation.
Feb 21 2022, 5:04 AM · Restricted Project, Restricted Project
Joe updated the diff for D120136: [ConstantRange] Construct constant range from xor operation.

Add exhaustive correctness test.
Also remove signage test in binaryXor, as the common bits would be 0 anyway, thus creating a full set regardless.

Feb 21 2022, 5:04 AM · Restricted Project, Restricted Project

Feb 18 2022

Joe updated subscribers of D120136: [ConstantRange] Construct constant range from xor operation.
Feb 18 2022, 8:45 AM · Restricted Project, Restricted Project
Joe retitled D120136: [ConstantRange] Construct constant range from xor operation from [VRP] Construct constant range from xor operation to [ConstantRange] Construct constant range from xor operation.
Feb 18 2022, 8:45 AM · Restricted Project, Restricted Project
Joe updated the diff for D120136: [ConstantRange] Construct constant range from xor operation.
Feb 18 2022, 8:41 AM · Restricted Project, Restricted Project
Joe updated the diff for D120136: [ConstantRange] Construct constant range from xor operation.

Fix malformed diff.

Feb 18 2022, 8:39 AM · Restricted Project, Restricted Project
Joe requested review of D120136: [ConstantRange] Construct constant range from xor operation.
Feb 18 2022, 8:36 AM · Restricted Project, Restricted Project

Apr 13 2021

Joe added inline comments to D93838: [SCCP] Add Function Specialization pass.
Apr 13 2021, 6:11 AM · Restricted Project
Joe added inline comments to D93838: [SCCP] Add Function Specialization pass.
Apr 13 2021, 4:33 AM · Restricted Project

Apr 7 2021

Joe added inline comments to D93838: [SCCP] Add Function Specialization pass.
Apr 7 2021, 9:29 AM · Restricted Project

Apr 8 2020

Joe added a comment to D76354: [RISCV][GlobalISel] Legalize types for ALU operations.

LGTM, but probably wait for someone more experienced to upvote :)

Apr 8 2020, 6:27 AM · Restricted Project, Restricted Project

Mar 20 2020

Joe added inline comments to D74977: [RISCV][GlobalISel] Add lowerFormalArguments for calling convention.
Mar 20 2020, 8:05 AM · Restricted Project
Joe added a comment to D76354: [RISCV][GlobalISel] Legalize types for ALU operations.

What about G_OR and G_XOR? Is there a reason why they're not listed?

Mar 20 2020, 7:32 AM · Restricted Project, Restricted Project

Mar 17 2020

Joe added a comment to D75023: [RISCV][GlobalISel] Add lowerCall for calling convention.

If you're supporting a pointer value return type, should there be a test for this?

Mar 17 2020, 5:06 AM · Restricted Project

Dec 2 2019

Joe updated the diff for D68328: Fix occurrences that size and range of pointers are assumed to be the same..

Rebased on current head.

Dec 2 2019, 3:09 AM · Restricted Project, Restricted Project

Nov 25 2019

Joe added a comment to D68328: Fix occurrences that size and range of pointers are assumed to be the same..

LGTM,
Thanks

Nov 25 2019, 1:45 AM · Restricted Project, Restricted Project

Nov 14 2019

Joe updated the diff for D68328: Fix occurrences that size and range of pointers are assumed to be the same..

Addressed @igorb 's comments.

Nov 14 2019, 10:06 AM · Restricted Project, Restricted Project

Nov 13 2019

Joe updated the diff for D68328: Fix occurrences that size and range of pointers are assumed to be the same..

Updated diff:

Nov 13 2019, 6:26 AM · Restricted Project, Restricted Project

Nov 7 2019

Joe added a comment to D68328: Fix occurrences that size and range of pointers are assumed to be the same..

After further review and testing, I have found that changing the effective SCEV type to be the pointer index type does not work. Though neither does it work when assumed to be pointer size. In many places, these are assumed to be the same. I'm unsure of which way to go with this. Do I force effective SCEV type to be the pointer size and enforce this, or change it to be index size and enforce this?

Nov 7 2019, 8:09 AM · Restricted Project, Restricted Project

Nov 4 2019

Joe added a comment to D68328: Fix occurrences that size and range of pointers are assumed to be the same..

Ping

Nov 4 2019, 1:44 AM · Restricted Project, Restricted Project

Oct 4 2019

Joe added inline comments to D68328: Fix occurrences that size and range of pointers are assumed to be the same..
Oct 4 2019, 7:26 AM · Restricted Project, Restricted Project

Oct 2 2019

Joe added inline comments to D68328: Fix occurrences that size and range of pointers are assumed to be the same..
Oct 2 2019, 6:49 AM · Restricted Project, Restricted Project
Joe created D68328: Fix occurrences that size and range of pointers are assumed to be the same..
Oct 2 2019, 3:35 AM · Restricted Project, Restricted Project
Joe retitled D68328: Fix occurrences that size and range of pointers are assumed to be the same. from Fix occurances that size and range of pointers are assumed to be the same. to Fix occurrences that size and range of pointers are assumed to be the same..
Oct 2 2019, 3:35 AM · Restricted Project, Restricted Project