Page MenuHomePhabricator

lewis-revill (Lewis Revill)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:55 AM (63 w, 2 d)

Recent Activity

Today

lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

I need to investigate some failures with this patch whereby sections of code which reference different temporary symbols still get outlined, with only one reference being used in the outlined function.

Thu, Oct 17, 7:49 AM · Restricted Project
lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

Lewis, this patch is not applying clean on top of https://reviews.llvm.org/D62686. Can you please rebase?

Thu, Oct 17, 12:21 AM · Restricted Project

Yesterday

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Disable the save/restore optimization when a function contains tail calls. Address various miscellaneous concerns with the patch. Update tests to include less redundant code when checking cases where save/restore libcalls are not used.

Wed, Oct 16, 8:27 AM · Restricted Project, Restricted Project

Tue, Oct 15

lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Tue, Oct 15, 4:33 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Yes Eli thanks for pointing out there are more scenarios that can fail.
It looks like the best solution is to permit both flags on, but then bail out from doing this transformation if there is any type of tail call already in the function.
This way we avoid messing with reverting tail calls back to regular calls.

Tue, Oct 15, 3:23 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Use MBB.end() and a blank DebugLoc for epilogue insertion when a basic block is empty.

Tue, Oct 15, 3:11 AM · Restricted Project

Sun, Oct 13

lewis-revill added inline comments to D62190: [RISCV] Allow shrink wrapping for RISC-V.
Sun, Oct 13, 8:48 AM · Restricted Project

Thu, Oct 10

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Thu, Oct 10, 8:03 AM · Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased prior to commit; Will run this through the testsuite once more first.

Thu, Oct 10, 8:03 AM · Restricted Project

Tue, Oct 8

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased prior to commit; Will run this through the testsuite once more first.

Tue, Oct 8, 7:48 AM · Restricted Project
lewis-revill added parent revisions for D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled: D62190: [RISCV] Allow shrink wrapping for RISC-V, D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Tue, Oct 8, 7:38 AM · Restricted Project
lewis-revill added a child revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Tue, Oct 8, 7:38 AM · Restricted Project, Restricted Project
lewis-revill added a child revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Tue, Oct 8, 7:38 AM · Restricted Project
lewis-revill created D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Tue, Oct 8, 7:38 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased to fix conflicts with recent split SP adjustments

Tue, Oct 8, 7:38 AM · Restricted Project, Restricted Project
lewis-revill removed a parent revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Tue, Oct 8, 7:29 AM · Restricted Project
lewis-revill removed a child revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D62190: [RISCV] Allow shrink wrapping for RISC-V.
Tue, Oct 8, 7:29 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Make this patch independent of save/restore compatibility

Tue, Oct 8, 7:29 AM · Restricted Project

Thu, Oct 3

lewis-revill added a comment to D68290: [RISCV] Added isCompressibleInst() to estimate size in getInstSizeInBytes().

Hi Ana, I'm yet to try this out on our benchmarks, but it looks like a good implementation to me. Considering Alex's comments above, should this patch be reduced to just the isCompressible check and I can merge the rest into the machine outliner patch after adding this one as a parent?

Thu, Oct 3, 9:06 AM · Restricted Project
lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

Sure, that's sensible. I'll keep a separate patch for ensuring compatibility with save/restore for if/when it's required.

Thu, Oct 3, 7:13 AM · Restricted Project

Tue, Oct 1

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased due to updated dependency.

Tue, Oct 1, 9:16 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rewrote logic to calculate stack sizes, frame indexes and frame pointer offsets. This was necessary to take into account the fact that the save/restore lib calls are essentially an opaque section of the stack that is inserted at the beginning of the frame, after positive offset objects such as fixed stack arguments, but before additional callee saved registers (IE FP registers) and negative offset (dynamic) objects. So calculations of the actual offsets of these objects must be adjusted accordingly for the stack to function correctly.

Tue, Oct 1, 9:16 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Add missing bailout condition after potentially removing candidate locations.

Tue, Oct 1, 3:53 AM · Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

I have run a couple of standard workloads like SPEC.
There is no correctness issue when enabling the MO feature (except for spec2000/twolf which fails with/without MO).
The MO code size gains without compression are up to 7%. With compression enabled, most of the code size gain is gone, and I see more code size increase.
It is possible it has to do with the SequenceSize we are estimating.
The reason we enable compression late is to have all paths - coming from codegen (LLVM IR), parsing, assembling .s or inline asm - go through the same mechanism for compression.
This is similar/compatible with GCC behavior, which relies on the external assembler to implement compression.
We can better estimate SequenceSize by checking if an instruction is compressable. We can modify the tablegen backend for compression emitter to generate a function that does the isCompressable check, but instead of using MCInst and MCOperands for the checks, we need to use MachineInstr and MachineOperand types. I will try this solution. Another alternative is to compress LLVM IR code before running the machine outliner.

Tue, Oct 1, 2:33 AM · Restricted Project

Mon, Sep 23

lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

It seems like the regressions I'm seeing are due to the fact that calculating offsets for fixed objects at the top of the frame didn't account for extra stack size adjustment from the libcalls. I'm trying to find a neat way around this without breaking other calculations.

Mon, Sep 23, 3:14 AM · Restricted Project, Restricted Project

Thu, Sep 19

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

We discussed this in the RISC-V meeting on 19 Sept 2019. @apazos says there are some SPEC failures in both 2006 and 2017, which would be good to triage.

Thu, Sep 19, 9:14 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Thu, Sep 19, 9:03 AM · Restricted Project, Restricted Project

Wed, Sep 18

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased and updated to incorporate changes to parent revision

Wed, Sep 18, 8:19 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Replace internal -mllvm option with target feature enabled through the clang frontend using -msave-restore.

Wed, Sep 18, 8:17 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

There is an option to Clang for '-msave-restore' which should be utilized to enable this.

I don't think we'd have a problem if clang support for this came in a separate commit.

Wed, Sep 18, 3:26 AM · Restricted Project, Restricted Project

Sep 17 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Updated to address comments.

Sep 17 2019, 6:53 AM · Restricted Project

Sep 16 2019

lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

There is an option to Clang for '-msave-restore' which should be utilized to enable this.

Sep 16 2019, 4:45 AM · Restricted Project, Restricted Project

Sep 13 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Fix git error whereby logic from this patch was mistakenly included in D62190

Sep 13 2019, 6:49 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Fix git error whereby logic from D62686 was mistakenly included in this patch

Sep 13 2019, 6:49 AM · Restricted Project
lewis-revill committed rL371841: Request commit access for lewis-revill.
Request commit access for lewis-revill
Sep 13 2019, 4:24 AM
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Refactor the MIR test case again:

  • use -run-pass=machine-outliner to only test this pass (required removing the no-machineoutliner checks, they are redundant anyway)
  • add riscv64 checks for completeness?
  • add -verify-machineinstrs
Sep 13 2019, 3:39 AM · Restricted Project

Sep 11 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Sep 11 2019, 9:32 AM · Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Don't allow return statements in outlined sequences until tail calls to outlined functions are properly implemented. Improve logic for checking if X5 is available for use at the insertion point of an outlined sequence, and update the test to be pure MIR.

Sep 11 2019, 9:22 AM · Restricted Project
lewis-revill planned changes to D66210: [RISCV] Enable the machine outliner for RISC-V.

I've been testing this on the Embench set of benchmarks (https://github.com/embench/embench-iot), and it appears that some programs cause execution failures with this enabled, which is a little concerning... I'm going to look into this and then also update the tests.

Sep 11 2019, 2:32 AM · Restricted Project

Sep 2 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Updated the test to an MIR-based test, and added checks for the cases where outlining cannot be done.

Sep 2 2019, 5:54 AM · Restricted Project
lewis-revill accepted D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly.

Thanks Kito. This looks good to me.

Sep 2 2019, 2:41 AM · Restricted Project, Restricted Project

Aug 29 2019

lewis-revill added a comment to D66887: [test-suite] Add GCC C Torture Suite.

I'd just like to bring up that at Embecosm we have been in discussions with the GCC community for a while about an alternative approach to this style of blacklisting, where instead we add more fine grained procedures within the target-supports.exp file to allow us to annotate tests with things like /* { dg-require-effective-target builtin_setjmplngjmp } */. For now we have also added gcc_frontend and gcc_internals 'effective targets' to help with cases like tests which check for GCC-specific warning output, or GCC-specific optimization behaviour.

Aug 29 2019, 7:54 AM · Restricted Project

Aug 22 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Aug 22 2019, 2:43 AM · Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased and addressed a couple of comments.

Aug 22 2019, 2:43 AM · Restricted Project

Aug 20 2019

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased, and modified the logic to find the insertion point for the epilogue code.

Aug 20 2019, 4:42 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased.

Aug 20 2019, 4:42 AM · Restricted Project, Restricted Project

Aug 19 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Aug 19 2019, 4:49 AM · Restricted Project

Aug 16 2019

lewis-revill committed rGd3f774d33cd1: [RISCV] Allow parsing of bare symbols with offsets (authored by lewis-revill).
[RISCV] Allow parsing of bare symbols with offsets
Aug 16 2019, 5:04 AM
lewis-revill committed rL369097: [RISCV] Allow parsing of bare symbols with offsets.
[RISCV] Allow parsing of bare symbols with offsets
Aug 16 2019, 5:03 AM
lewis-revill closed D57332: [RISCV] Allow parsing of bare symbols with offsets.
Aug 16 2019, 5:03 AM · Restricted Project
lewis-revill closed D54296: [RISCV] Lower inline asm constraint A for RISC-V.

Committed (ill formed commit message so phabricator did not pick it up)

Aug 16 2019, 3:41 AM · Restricted Project
lewis-revill added an edge to rL369095: [RISCV] Lower inline asm constraint A for RISC-V: D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Aug 16 2019, 3:41 AM
lewis-revill added 1 commit(s) for D54296: [RISCV] Lower inline asm constraint A for RISC-V: rL369095: [RISCV] Lower inline asm constraint A for RISC-V.
Aug 16 2019, 3:41 AM · Restricted Project
lewis-revill committed rG7abf863f761c: [RISCV] Lower inline asm constraint A for RISC-V (authored by lewis-revill).
[RISCV] Lower inline asm constraint A for RISC-V
Aug 16 2019, 3:29 AM
lewis-revill committed rL369095: [RISCV] Lower inline asm constraint A for RISC-V.
[RISCV] Lower inline asm constraint A for RISC-V
Aug 16 2019, 3:28 AM
lewis-revill committed rG1653ebee3f04: [RISCV] Add inline asm constraint A for RISC-V (authored by lewis-revill).
[RISCV] Add inline asm constraint A for RISC-V
Aug 16 2019, 3:25 AM
lewis-revill committed rL369093: [RISCV] Add inline asm constraint A for RISC-V.
[RISCV] Add inline asm constraint A for RISC-V
Aug 16 2019, 3:23 AM
lewis-revill closed D54295: [RISCV] Add inline asm constraint A for RISC-V.
Aug 16 2019, 3:23 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D54295: [RISCV] Add inline asm constraint A for RISC-V.

Rebased prior to commit.

Aug 16 2019, 3:06 AM · Restricted Project, Restricted Project

Aug 15 2019

lewis-revill updated the diff for D54296: [RISCV] Lower inline asm constraint A for RISC-V.

Rebased prior to commit.

Aug 15 2019, 9:09 AM · Restricted Project

Aug 14 2019

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
In D62686#1571192, @asb wrote:

Hi Lewis, did you evaluate implementing the machine outliner as a more general approach for getting code size savings in this sort of way?

Aug 14 2019, 3:59 AM · Restricted Project, Restricted Project
lewis-revill created D66210: [RISCV] Enable the machine outliner for RISC-V.
Aug 14 2019, 3:55 AM · Restricted Project

Aug 5 2019

lewis-revill added inline comments to D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension.
Aug 5 2019, 6:09 AM · Restricted Project

Aug 1 2019

lewis-revill abandoned D58843: [WIP][MC][RISCV] Allow targets to defer forcing relocations.

Abandoned since this is no longer relevant to RISC-V; other individual fixes for issues relating to this problem have been merged since. I will keep D61907 around for discussion even though it's a similar 'big hammer' approach to the problem.

Aug 1 2019, 8:28 AM · Restricted Project

Jul 31 2019

lewis-revill added inline comments to D65205: [RISCV] Add Custom Parser for Atomic Memory Operands.
Jul 31 2019, 3:09 AM · Restricted Project

Jul 29 2019

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
In D62686#1571192, @asb wrote:

Hi Lewis, did you evaluate implementing the machine outliner as a more general approach for getting code size savings in this sort of way?

You should have tests for at least a subset of target-abi {ilp32,lp64}{f,d} and the compiler shouldn't assert in those cases.

Jul 29 2019, 7:36 AM · Restricted Project, Restricted Project

Jul 25 2019

lewis-revill updated the diff for D54296: [RISCV] Lower inline asm constraint A for RISC-V.

Rebased and updated to use '0(' prefix for memory constraints.

Jul 25 2019, 2:15 AM · Restricted Project

Jul 22 2019

lewis-revill added a parent revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D64751: [RISCV] Add support for lowering floating point inlineasm clobbers.
Jul 22 2019, 7:30 AM · Restricted Project, Restricted Project
lewis-revill added a child revision for D64751: [RISCV] Add support for lowering floating point inlineasm clobbers: D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 22 2019, 7:30 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Add support for a split save/restore approach when callee saved registers from the floating point ABIs are used.

Jul 22 2019, 7:30 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Jul 22 2019, 3:28 AM · Restricted Project

Jul 12 2019

lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 12 2019, 4:15 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D61907: [RISCV] Leave pcrel_hi/pcrel_lo fixup pairs unresolved.
Jul 12 2019, 2:28 AM · Restricted Project

Jul 11 2019

lewis-revill updated the diff for D57332: [RISCV] Allow parsing of bare symbols with offsets.

Rebased

Jul 11 2019, 7:53 AM · Restricted Project

Jul 5 2019

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Will do, I can rebase this patch on top of your hard float patch.

Jul 5 2019, 5:43 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
In D62686#1571192, @asb wrote:

Hi Lewis, did you evaluate implementing the machine outliner as a more general approach for getting code size savings in this sort of way?

Jul 5 2019, 5:43 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 5 2019, 2:56 AM · Restricted Project, Restricted Project

Jul 4 2019

lewis-revill retitled D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls from [WIP][RISCV] Add support for save/restore of callee-saved registers via libcalls to [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 4 2019, 8:10 AM · Restricted Project, Restricted Project
lewis-revill retitled D62190: [RISCV] Allow shrink wrapping for RISC-V from [WIP][RISCV] Allow shrink wrapping for RISC-V to [RISCV] Allow shrink wrapping for RISC-V.
Jul 4 2019, 8:10 AM · Restricted Project
lewis-revill added a parent revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 4 2019, 8:10 AM · Restricted Project
lewis-revill added a child revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D62190: [RISCV] Allow shrink wrapping for RISC-V.
Jul 4 2019, 8:10 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

I've reworked this patch to safely work around the implementation of save/restore via libcalls. These place constraints on the save/restore points that can be chosen by the shrink wrapping algorithm.

Jul 4 2019, 8:10 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebase, and only use the getUseSaveRestoreLibCalls getter method rather than the useSaveRestoreLibCalls method which does not save its result.

Jul 4 2019, 8:06 AM · Restricted Project, Restricted Project
lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Jul 4 2019, 7:33 AM · Restricted Project, Restricted Project

Jun 26 2019

lewis-revill committed rGcf74881329d3: [RISCV] Add pseudo instruction for calls with explicit register (authored by lewis-revill).
[RISCV] Add pseudo instruction for calls with explicit register
Jun 26 2019, 3:39 AM
lewis-revill committed rL364403: [RISCV] Add pseudo instruction for calls with explicit register.
[RISCV] Add pseudo instruction for calls with explicit register
Jun 26 2019, 3:39 AM
lewis-revill closed D62685: [RISCV] Add pseudo instruction for calls with explicit register.
Jun 26 2019, 3:39 AM · Restricted Project

Jun 19 2019

lewis-revill updated the diff for D62685: [RISCV] Add pseudo instruction for calls with explicit register.

Quick end-of-file newline fix

Jun 19 2019, 8:59 AM · Restricted Project
lewis-revill updated the diff for D62685: [RISCV] Add pseudo instruction for calls with explicit register.

Added additional tests

Jun 19 2019, 8:57 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased to incorporate the recent CFI additions.

Jun 19 2019, 8:17 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Just a quick comment, I'm assuming this depends on D58335 based on the test file you've modified?

Jun 19 2019, 7:27 AM · Restricted Project
lewis-revill added a comment to D62685: [RISCV] Add pseudo instruction for calls with explicit register.

Should the error change at all? We'll still get 'error: operand must be a bare symbol name' for call foo, bar. I guess this patch doesn't put us in a greate situation now that parseCallSymbol can return NoMatch even though technically we parsed a call symbol...

Jun 19 2019, 6:43 AM · Restricted Project
lewis-revill abandoned D57240: [RISCV] Don't incorrectly force relocation for %pcrel_lo.

Abandoned in favour of D61907

Jun 19 2019, 3:35 AM · Restricted Project
lewis-revill added inline comments to D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Jun 19 2019, 3:30 AM · Restricted Project
lewis-revill committed rG18737e81eb59: [RISCV] Allow parsing immediates that use tilde & exclaim (authored by lewis-revill).
[RISCV] Allow parsing immediates that use tilde & exclaim
Jun 19 2019, 3:25 AM
lewis-revill committed rL363783: [RISCV] Allow parsing immediates that use tilde & exclaim.
[RISCV] Allow parsing immediates that use tilde & exclaim
Jun 19 2019, 3:25 AM
lewis-revill closed D57320: [RISCV] Allow parsing immediates that use tilde & exclaim.
Jun 19 2019, 3:25 AM · Restricted Project
lewis-revill committed rG218aa0edb159: [RISCV] Fix failure to parse parenthesized immediates (authored by lewis-revill).
[RISCV] Fix failure to parse parenthesized immediates
Jun 19 2019, 3:10 AM
lewis-revill committed rL363782: [RISCV] Fix failure to parse parenthesized immediates.
[RISCV] Fix failure to parse parenthesized immediates
Jun 19 2019, 3:10 AM
lewis-revill closed D57319: [RISCV] Fix failure to parse parenthesized immediates.
Jun 19 2019, 3:10 AM · Restricted Project