In D54029#1404753, @apazos wrote:

Hi James, I encountered another case not handled yet in this patch. It produces the error: could not find corresponding %pcrel_hi

.option push
.option norelax
la gp, __global_pointer$
.option pop
la sp, _sp

Correct test.

Don't use zero register for 'J' constraint.

I think I ended up being thrown off at the time by the output of something with the '%z' modifier, which I see you have now implemented @jrtc27. I'll correct this patch.

Rebased.

Don't incorrectly set RelaxCandidate for GOT fixups.

Correct local rebasing of older patch; add fixup_riscv_relax as well as tprel_add where appropriate; seperate reporting of errors for incorrectly expanding a tprel_add fixup.

Rebased

Rebased

In D57240#1385261, @jrtc27 wrote:

Could we not have a situation where the pcrel_hi20 is seen *after* the lo12, in which case the lo12 would be forced but the hi20 could still be evaluated? E.g. I think the following would be problematic:

foo:
    j 1f
0:  addi a0, a0, %pcrel_lo(1f)
    ret
1: auipc a0, %pcrel_hi(bar)
    j 0b

.align 2
bar:
    # ...

Obviously extremely pathological code, but nonetheless valid.

Don't output an additional '0' when printing indirect memory operands.

Added RISC-V to thread specifier test as a means of checking TLS is supported.

Rebased with updated dependency

Rebased with updated dependency

Rebased with updated dependency

Abandoned in favour of D57450

Should this only support constant offsets to a symbol? It seems sensible to only support offsets to the symbol, IE add/sub rather than more complex expressions, but the RHS could be any expression at the moment.

Also parse exlaim (!) as a valid token to start an immediate. Add some CSR tests.

Save the token for the parsed LParen rather than reconstructing one. Add some more tests.

In D57320#1373431, @jrtc27 wrote:

There's also AsmToken::Exclaim for logical not that we could allow (although that's not one I've ever seen in real-world assembly). Please add tests for the CSR change?

In D57319#1373436, @jrtc27 wrote:

You should save the original AsmToken rather than reconstructing it, so as to retain the SMLoc, and Buf no longer needs to be at function scope. Also, I had some more exhaustive tests in mine; I think the important one is addi a1, a0, (1) to ensure that we can parse parenthesised immediate expressions when *not* part of a memory reference.

Remove irrelevant dependencies.

Some basic tests should probably be included for completeness.

This patch doesnt interact well with instructions like sw a3, CONST(a4) introduced by D52298. Looks like MatchOperandParserImpl is happy to match the 'CONST' as a bare symbol for the pseudo before parseImmediate can be called. Perhaps one way to fix it is to have parseBareSymbol check for a trailing parenthesis?

Rely on default value rather than explicitly marking TLSSupported as true.

Rebased and fixed FileCheck lines.

Rebased.

Rebased (assuming updates to D55279)

Rebased (assuming updates to D55279)

Rebased.

Rebased.

Rebased.

Rebased and updated comments.

Rebased and updated comment.

Can this be rebased to apply cleanly with the upstreamed D54029?

Rebase with updated dependencies. Use and expand the la.tls.ie and la.tls.gd pseudo instructions.

Rebased with updated dependencies. Renamed ie_hi to got_hi to match relocation, and rearrange to be adjacent to gd_hi in most files. Added tests to relocations.s, and ensured that fixups evaluate correctly.

Fix bad merge and failing tests

Rebased with updated dependencies

Move getAddrPIC() and isPositionIndependent() checks to getAddr()

Remove unnecessary Flags operand

Remove unnecessary Flags operand.

Rebase following update to D55560.

Do not allow VK_RISCV_None on call symbols

Rebased to use D55560 and with fewer dependencies

Rebased removing unnecessary dependencies and to use the cleaner CallSymbol patch.

I think that is a change that should be implemented in this revision, since this is the revision that adds the fixup and the tests. Otherwise we would end up with D54029 depending on this, which itself depends on D54029.

Rebased and updated to use and expand PseudoLA.

In D55279#1326556, @lewis-revill wrote:

Do you need to add a check for RISCV::fixup_riscv_pcrel_hi20 in getPcRelHiExpr? Currently this is returning null and causing a segfault when running your relocations.s tests.

Do you need to add a check for RISCV::fixup_riscv_pcrel_hi20 in getPcRelHiExpr? Currently this is returning null and causing a segfault when running your relocations.s tests.

Rebasing with latest changes to D55279 and modifying this patch to use and expand PseudoLA (D55325).

Rebased and updated to use and expand PseudoLLA for PC-relative addressing.

Rebasing and modifying this patch to use and expand PseudoLLA instead of introducing a new wrapper.

Address minor issues.