Page MenuHomePhabricator

lewis-revill (Lewis Revill)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:55 AM (77 w, 5 d)

Recent Activity

Wed, Jan 15

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Lewis, your latest patch looks good, we just had another run with no new failures. But we know it will have issues with -g. So I think we should not merge it yet. Do you have a version of the patch that creates the labels for the compiler-generated save/restore lib calls, so that this optimization does not depend on D71593? We could merge that version then, and when D71593 is accepted, you just have to rework/remove the label generation part of the patch.

Wed, Jan 15, 1:05 AM · Restricted Project, Restricted Project

Tue, Jan 14

lewis-revill committed rGcd800f3b226b: [RISCV] Allow shrink wrapping for RISC-V (authored by lewis-revill).
[RISCV] Allow shrink wrapping for RISC-V
Tue, Jan 14, 11:03 AM
lewis-revill closed D62190: [RISCV] Allow shrink wrapping for RISC-V.
Tue, Jan 14, 11:03 AM · Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Should I wait for the comments to be resolved on D71593 before I commit this patch? Ideally if this patch makes it into a release then that bug fix should be there too.

Tue, Jan 14, 10:14 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Quick fix of shadow variable assignment.

Tue, Jan 14, 12:55 AM · Restricted Project

Mon, Jan 13

lewis-revill added a comment to D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls.

Please add a test case.

Mon, Jan 13, 4:25 AM · debug-info, Restricted Project
lewis-revill added a comment to D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls.

What about going the other way, and making sure instructions in frame setup that need labels get them?

Mon, Jan 13, 3:57 AM · debug-info, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Lewis, is the patch final? It would be good to merge it before the 10.0 release branch creation on Jan 15th

Mon, Jan 13, 3:57 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Fix .cfi_offset signedness error.

Mon, Jan 13, 3:48 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

I see the following .cfi_offset directives generated using @shiva0217's test case. Any idea why the offset for ra is 536870908?

call    t0, __riscv_save_0
.cfi_def_cfa_offset 16
.cfi_offset ra, 536870908
Mon, Jan 13, 3:19 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

This patch is yes, so long as it applies cleanly. So if it's agreed that it should be landed then I can do that as soon as I get a chance.

Mon, Jan 13, 2:44 AM · Restricted Project

Dec 20 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Added .cfi_offset directives for registers saved by libcalls.

Dec 20 2019, 3:04 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Fixed existing .cfi_offset offsets. Since these are frame-pointer based they also need to account for the libcall stack adjustment.

Dec 20 2019, 2:11 AM · Restricted Project, Restricted Project

Dec 19 2019

lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

Pinging @paquette perhaps you have some insight into whether there's anything that can be done to avoid this issue (also discussed above).

Dec 19 2019, 10:14 AM · Restricted Project
lewis-revill added a reviewer for D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls: asb.
Dec 19 2019, 9:13 AM · debug-info, Restricted Project
lewis-revill committed rGa116f28a0d71: [RISCV] Enable the machine outliner for RISC-V (authored by lewis-revill).
[RISCV] Enable the machine outliner for RISC-V
Dec 19 2019, 8:44 AM
lewis-revill closed D66210: [RISCV] Enable the machine outliner for RISC-V.
Dec 19 2019, 8:44 AM · Restricted Project
lewis-revill added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Dec 19 2019, 6:25 AM · Restricted Project
lewis-revill added a comment to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..

Thank you for the update! Please see comments.

Dec 19 2019, 3:27 AM · Restricted Project

Dec 18 2019

lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

Can you open a bug for the machine outliner and maybe contact Jessica, may be she can help fix this quickly.

Dec 18 2019, 9:32 AM · Restricted Project

Dec 17 2019

lewis-revill added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Dec 17 2019, 8:53 AM · Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased.

Dec 17 2019, 3:47 AM · Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

So the failure in the GCC testsuite occurs due to the following test:

Dec 17 2019, 3:38 AM · Restricted Project
lewis-revill created D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls.
Dec 17 2019, 1:54 AM · debug-info, Restricted Project
lewis-revill added reviewers for D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls: simoncook, shiva0217.
Dec 17 2019, 1:54 AM · debug-info, Restricted Project

Dec 16 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased and addressed StackSize vs RealStackSize error.

Dec 16 2019, 10:07 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased.

Dec 16 2019, 9:39 AM · Restricted Project
lewis-revill added a comment to D68290: [RISCV] Added isCompressibleInst() to estimate size in getInstSizeInBytes().

Is this waiting for someone with commit access to go ahead?

Dec 16 2019, 9:30 AM · Restricted Project
lewis-revill added a comment to D71553: [RISCV] Add Clang frontend support for Bitmanip extension.

Thanks Scott, it should be relatively easy to add tests for this in 'clang/test/Preprocessor/riscv-target-features.c' if you could.

Dec 16 2019, 9:11 AM · Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Dec 16 2019, 9:01 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

I'm doing a final rebase and check on this before merging. I have a failure in the GCC testsuite which I'm triaging.

Dec 16 2019, 5:26 AM · Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Dec 16 2019, 4:10 AM · Restricted Project, Restricted Project

Dec 7 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased.

Dec 7 2019, 8:01 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased

Dec 7 2019, 7:44 AM · Restricted Project

Dec 3 2019

lewis-revill added inline comments to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
Dec 3 2019, 8:23 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

So I have a quick comment about this patch, perhaps it might help to get things moving again.

Dec 3 2019, 7:55 AM · Restricted Project, Restricted Project

Nov 21 2019

lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.
In D62190#1755159, @asb wrote:

I note that the TargetFrameLowering hooks canUseAsPrologue and canUseAsEpilogue are both called by the shrink wrapper. They default to true, but targets may need to override this for correctness. Looking at e.g. AArch64, I see it overrides canUseAsPrologue and returns false in the case that the function needs stack realignment and there are no scratch registers available. Are you certain that no such case is needed for RISC-V?

Nov 21 2019, 8:47 AM · Restricted Project

Nov 19 2019

lewis-revill added a comment to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..

See comments above. Otherwise, this looks good to me although others should evaluate too.

Nov 19 2019, 11:29 AM · Restricted Project
lewis-revill added inline comments to D69808: [RISCV GlobalISel] Add lowerReturn for calling conv..
Nov 19 2019, 10:33 AM · Restricted Project

Nov 15 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased

Nov 15 2019, 2:33 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased

Nov 15 2019, 2:33 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Nov 15 2019, 2:33 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased

Nov 15 2019, 2:28 AM · Restricted Project

Nov 1 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased. Added special case for size of jr t0 with compression enabled. Fixed failure in GCC testsuite.

Nov 1 2019, 1:35 PM · Restricted Project
lewis-revill abandoned D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.

This functionality has been merged into the save/restore patch.

Nov 1 2019, 1:24 PM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased and merged D68644 into this patch - this patch already assumes shrink wrapping support anyway.

Nov 1 2019, 1:24 PM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased.

Nov 1 2019, 1:24 PM · Restricted Project

Oct 31 2019

lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

So I've been looking into the benchmarks that I've been running to figure out why code doesn't change with this enabled.

Oct 31 2019, 8:28 AM · Restricted Project

Oct 23 2019

lewis-revill added a parent revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D62190: [RISCV] Allow shrink wrapping for RISC-V.
Oct 23 2019, 12:14 PM · Restricted Project, Restricted Project
lewis-revill added a child revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Oct 23 2019, 12:14 PM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebase on top of shrink wrapping patch.

Oct 23 2019, 12:06 PM · Restricted Project, Restricted Project

Oct 17 2019

lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

I need to investigate some failures with this patch whereby sections of code which reference different temporary symbols still get outlined, with only one reference being used in the outlined function.

Oct 17 2019, 7:49 AM · Restricted Project
lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

Lewis, this patch is not applying clean on top of https://reviews.llvm.org/D62686. Can you please rebase?

Oct 17 2019, 12:21 AM · Restricted Project

Oct 16 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Disable the save/restore optimization when a function contains tail calls. Address various miscellaneous concerns with the patch. Update tests to include less redundant code when checking cases where save/restore libcalls are not used.

Oct 16 2019, 8:27 AM · Restricted Project, Restricted Project

Oct 15 2019

lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Oct 15 2019, 4:33 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Yes Eli thanks for pointing out there are more scenarios that can fail.
It looks like the best solution is to permit both flags on, but then bail out from doing this transformation if there is any type of tail call already in the function.
This way we avoid messing with reverting tail calls back to regular calls.

Oct 15 2019, 3:23 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Use MBB.end() and a blank DebugLoc for epilogue insertion when a basic block is empty.

Oct 15 2019, 3:11 AM · Restricted Project

Oct 13 2019

lewis-revill added inline comments to D62190: [RISCV] Allow shrink wrapping for RISC-V.
Oct 13 2019, 8:48 AM · Restricted Project

Oct 10 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Oct 10 2019, 8:03 AM · Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased prior to commit; Will run this through the testsuite once more first.

Oct 10 2019, 8:03 AM · Restricted Project

Oct 8 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased prior to commit; Will run this through the testsuite once more first.

Oct 8 2019, 7:48 AM · Restricted Project
lewis-revill added parent revisions for D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled: D62190: [RISCV] Allow shrink wrapping for RISC-V, D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Oct 8 2019, 7:38 AM · Restricted Project
lewis-revill added a child revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Oct 8 2019, 7:38 AM · Restricted Project, Restricted Project
lewis-revill added a child revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Oct 8 2019, 7:38 AM · Restricted Project
lewis-revill created D68644: [RISCV] Prevent unsafe shrink wrapping with save/restore enabled.
Oct 8 2019, 7:38 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased to fix conflicts with recent split SP adjustments

Oct 8 2019, 7:38 AM · Restricted Project, Restricted Project
lewis-revill removed a parent revision for D62190: [RISCV] Allow shrink wrapping for RISC-V: D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Oct 8 2019, 7:29 AM · Restricted Project
lewis-revill removed a child revision for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls: D62190: [RISCV] Allow shrink wrapping for RISC-V.
Oct 8 2019, 7:29 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Make this patch independent of save/restore compatibility

Oct 8 2019, 7:29 AM · Restricted Project

Oct 3 2019

lewis-revill added a comment to D68290: [RISCV] Added isCompressibleInst() to estimate size in getInstSizeInBytes().

Hi Ana, I'm yet to try this out on our benchmarks, but it looks like a good implementation to me. Considering Alex's comments above, should this patch be reduced to just the isCompressible check and I can merge the rest into the machine outliner patch after adding this one as a parent?

Oct 3 2019, 9:06 AM · Restricted Project
lewis-revill added a comment to D62190: [RISCV] Allow shrink wrapping for RISC-V.

Sure, that's sensible. I'll keep a separate patch for ensuring compatibility with save/restore for if/when it's required.

Oct 3 2019, 7:13 AM · Restricted Project

Oct 1 2019

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased due to updated dependency.

Oct 1 2019, 9:16 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rewrote logic to calculate stack sizes, frame indexes and frame pointer offsets. This was necessary to take into account the fact that the save/restore lib calls are essentially an opaque section of the stack that is inserted at the beginning of the frame, after positive offset objects such as fixed stack arguments, but before additional callee saved registers (IE FP registers) and negative offset (dynamic) objects. So calculations of the actual offsets of these objects must be adjusted accordingly for the stack to function correctly.

Oct 1 2019, 9:16 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Add missing bailout condition after potentially removing candidate locations.

Oct 1 2019, 3:53 AM · Restricted Project
lewis-revill added a comment to D66210: [RISCV] Enable the machine outliner for RISC-V.

I have run a couple of standard workloads like SPEC.
There is no correctness issue when enabling the MO feature (except for spec2000/twolf which fails with/without MO).
The MO code size gains without compression are up to 7%. With compression enabled, most of the code size gain is gone, and I see more code size increase.
It is possible it has to do with the SequenceSize we are estimating.
The reason we enable compression late is to have all paths - coming from codegen (LLVM IR), parsing, assembling .s or inline asm - go through the same mechanism for compression.
This is similar/compatible with GCC behavior, which relies on the external assembler to implement compression.
We can better estimate SequenceSize by checking if an instruction is compressable. We can modify the tablegen backend for compression emitter to generate a function that does the isCompressable check, but instead of using MCInst and MCOperands for the checks, we need to use MachineInstr and MachineOperand types. I will try this solution. Another alternative is to compress LLVM IR code before running the machine outliner.

Oct 1 2019, 2:33 AM · Restricted Project

Sep 23 2019

lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

It seems like the regressions I'm seeing are due to the fact that calculating offsets for fixed objects at the top of the frame didn't account for extra stack size adjustment from the libcalls. I'm trying to find a neat way around this without breaking other calculations.

Sep 23 2019, 3:14 AM · Restricted Project, Restricted Project

Sep 19 2019

lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

We discussed this in the RISC-V meeting on 19 Sept 2019. @apazos says there are some SPEC failures in both 2006 and 2017, which would be good to triage.

Sep 19 2019, 9:14 AM · Restricted Project, Restricted Project
lewis-revill added inline comments to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.
Sep 19 2019, 9:03 AM · Restricted Project, Restricted Project

Sep 18 2019

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased and updated to incorporate changes to parent revision

Sep 18 2019, 8:19 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Replace internal -mllvm option with target feature enabled through the clang frontend using -msave-restore.

Sep 18 2019, 8:17 AM · Restricted Project, Restricted Project
lewis-revill added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

There is an option to Clang for '-msave-restore' which should be utilized to enable this.

I don't think we'd have a problem if clang support for this came in a separate commit.

Sep 18 2019, 3:26 AM · Restricted Project, Restricted Project

Sep 17 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Updated to address comments.

Sep 17 2019, 6:53 AM · Restricted Project

Sep 16 2019

lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

There is an option to Clang for '-msave-restore' which should be utilized to enable this.

Sep 16 2019, 4:45 AM · Restricted Project, Restricted Project

Sep 13 2019

lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Fix git error whereby logic from this patch was mistakenly included in D62190

Sep 13 2019, 6:49 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Fix git error whereby logic from D62686 was mistakenly included in this patch

Sep 13 2019, 6:49 AM · Restricted Project
lewis-revill committed rL371841: Request commit access for lewis-revill.
Request commit access for lewis-revill
Sep 13 2019, 4:24 AM
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Refactor the MIR test case again:

  • use -run-pass=machine-outliner to only test this pass (required removing the no-machineoutliner checks, they are redundant anyway)
  • add riscv64 checks for completeness?
  • add -verify-machineinstrs
Sep 13 2019, 3:39 AM · Restricted Project

Sep 11 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Sep 11 2019, 9:32 AM · Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Don't allow return statements in outlined sequences until tail calls to outlined functions are properly implemented. Improve logic for checking if X5 is available for use at the insertion point of an outlined sequence, and update the test to be pure MIR.

Sep 11 2019, 9:22 AM · Restricted Project
lewis-revill planned changes to D66210: [RISCV] Enable the machine outliner for RISC-V.

I've been testing this on the Embench set of benchmarks (https://github.com/embench/embench-iot), and it appears that some programs cause execution failures with this enabled, which is a little concerning... I'm going to look into this and then also update the tests.

Sep 11 2019, 2:32 AM · Restricted Project

Sep 2 2019

lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Updated the test to an MIR-based test, and added checks for the cases where outlining cannot be done.

Sep 2 2019, 5:54 AM · Restricted Project
lewis-revill accepted D67065: [RISCV] Define __riscv_cmodel_medlow and __riscv_cmodel_medany correctly.

Thanks Kito. This looks good to me.

Sep 2 2019, 2:41 AM · Restricted Project, Restricted Project

Aug 29 2019

lewis-revill added a comment to D66887: [test-suite] Add GCC C Torture Suite.

I'd just like to bring up that at Embecosm we have been in discussions with the GCC community for a while about an alternative approach to this style of blacklisting, where instead we add more fine grained procedures within the target-supports.exp file to allow us to annotate tests with things like /* { dg-require-effective-target builtin_setjmplngjmp } */. For now we have also added gcc_frontend and gcc_internals 'effective targets' to help with cases like tests which check for GCC-specific warning output, or GCC-specific optimization behaviour.

Aug 29 2019, 7:54 AM · Restricted Project

Aug 22 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Aug 22 2019, 2:43 AM · Restricted Project
lewis-revill updated the diff for D66210: [RISCV] Enable the machine outliner for RISC-V.

Rebased and addressed a couple of comments.

Aug 22 2019, 2:43 AM · Restricted Project

Aug 20 2019

lewis-revill updated the diff for D62190: [RISCV] Allow shrink wrapping for RISC-V.

Rebased, and modified the logic to find the insertion point for the epilogue code.

Aug 20 2019, 4:42 AM · Restricted Project
lewis-revill updated the diff for D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Rebased.

Aug 20 2019, 4:42 AM · Restricted Project, Restricted Project

Aug 19 2019

lewis-revill added inline comments to D66210: [RISCV] Enable the machine outliner for RISC-V.
Aug 19 2019, 4:49 AM · Restricted Project

Aug 16 2019

lewis-revill committed rGd3f774d33cd1: [RISCV] Allow parsing of bare symbols with offsets (authored by lewis-revill).
[RISCV] Allow parsing of bare symbols with offsets
Aug 16 2019, 5:04 AM
lewis-revill committed rL369097: [RISCV] Allow parsing of bare symbols with offsets.
[RISCV] Allow parsing of bare symbols with offsets
Aug 16 2019, 5:03 AM