Page MenuHomePhabricator

tschuett (Thorsten)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2017, 6:56 AM (318 w, 6 d)

Recent Activity

Yesterday

tschuett updated subscribers of D147162: [MemCpyOpt] Don't fold memcpy.inline into memmove.

@gchatelet

Wed, Mar 29, 1:42 PM · Restricted Project, Restricted Project

Tue, Mar 28

tschuett added a comment to D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver.

I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the flang/lib/Frontend directory.

Tue, Mar 28, 12:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Mar 27

tschuett added a comment to D146973: [Clang] Implicitly include LLVM libc headers for the GPU.

Could you hide the amdgpu and nvptx somewhere here clang -print-resource-dir in two different directories? One for AMD, one for NVPTX.

Mon, Mar 27, 12:33 PM · Restricted Project, Restricted Project
tschuett added a comment to D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver.

Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From the conversation, there seems to be more target specific behaviours.

Mon, Mar 27, 7:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Mar 24

tschuett added a comment to D146751: Support for PowerPC vector type.

Is this the first of ten vendors types? Do I need a flag to enable the PowerPC vector type or does it also work on other architectures?

Fri, Mar 24, 8:49 AM · Restricted Project
tschuett added a comment to D144274: [InstCombine] use loop info when running the pass after loop vectorization.

There is no space for an InstCombineWithLoopInfo to avoid all the phase ordering issues?

Hi @tschuett, sorry I don't really understand what you mean. Can you explain what you would like me to do?

Fri, Mar 24, 7:01 AM · Restricted Project, Restricted Project
tschuett added a comment to D144274: [InstCombine] use loop info when running the pass after loop vectorization.

There is no space for an InstCombineWithLoopInfo to avoid all the phase ordering issues?

Fri, Mar 24, 6:54 AM · Restricted Project, Restricted Project

Thu, Mar 23

tschuett added a comment to D144083: [JITLink] Initial AArch32 backend.

Proper GOT/PLT handling is not yet implemented.

Thu, Mar 23, 3:18 AM · Restricted Project, Restricted Project

Tue, Mar 21

tschuett added inline comments to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.
Tue, Mar 21, 12:26 PM · Restricted Project, Restricted Project
tschuett added a comment to D142885: [VPlan] Allow building a VPlan to may fail..

Rename to tryToBuildVPlanWithVPRecipes as suggested, thanks!

Tue, Mar 21, 4:51 AM · Restricted Project, Restricted Project
tschuett added a comment to D142885: [VPlan] Allow building a VPlan to may fail..

Now that building may fail, you could even call it tryBuildVPlanWithVPRecipes .

Tue, Mar 21, 2:05 AM · Restricted Project, Restricted Project
tschuett added inline comments to D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..
Tue, Mar 21, 1:22 AM · Restricted Project, Restricted Project

Mon, Mar 20

tschuett added a comment to D144994: [Draft][libc++][modules] Adds std module..

There was objection against using /usr/modules on discourse. I assumed that libc++ owns /usr/include/c++ and hides everything under there.

Mon, Mar 20, 11:31 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Mon, Mar 20, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Mar 19

tschuett added inline comments to D146333: [Flang] Exit gracefully with a useful message when we fail to lookup a target.
Sun, Mar 19, 5:50 AM · Restricted Project, Restricted Project
tschuett added a comment to D146278: [flang] add -flang-experimental-hlfir flag to flang-new.

You can either pass parameters to passes or use different pass pipelines for different optimisation levels (in MLIR territory).

Sun, Mar 19, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 17

tschuett added a comment to D146163: Experimental new python bindings for clang/llvm based on Cython.

Began discussion in Discord to see interest for other collaborators on this type of binding: https://discord.com/channels/636084430946959380/700158649129238591/1086362007684513844

Fri, Mar 17, 12:04 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

tschuett added a comment to D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain.

Flang will also support OpenACC for offload. It is very similar to OpenMP.

Thu, Mar 16, 9:31 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D145502: [flang][hlfir] move intrinsic lowering out of BufferizeHLFIR.
Thu, Mar 16, 12:55 AM · Restricted Project, Restricted Project

Wed, Mar 15

tschuett added a comment to D146075: [flang][driver][openmp] Write MLIR for -save-temps.

Frontend is in the file name.

Wed, Mar 15, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D146075: [flang][driver][openmp] Write MLIR for -save-temps.

What is the policy on trivial braces in the frontend?

Wed, Mar 15, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D146075: [flang][driver][openmp] Write MLIR for -save-temps.
Wed, Mar 15, 9:55 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

tschuett added inline comments to D145602: Remove circular dependency between libFIRSupport and libFIRDialect.
Wed, Mar 8, 11:23 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Wed, Mar 8, 10:26 AM · Restricted Project, Restricted Project
tschuett added a comment to D145566: [lldb] Add RegisterFlags class.

My only comment is: views look more modern than const-ref. The efficiency is not affected at all.

Wed, Mar 8, 6:45 AM · Restricted Project, Restricted Project
tschuett added inline comments to D145566: [lldb] Add RegisterFlags class.
Wed, Mar 8, 6:20 AM · Restricted Project, Restricted Project
tschuett added inline comments to D145566: [lldb] Add RegisterFlags class.
Wed, Mar 8, 6:19 AM · Restricted Project, Restricted Project

Fri, Mar 3

tschuett added a comment to D144274: [InstCombine] use loop info when running the pass after loop vectorization.

It is odd to me that instcombine has two modes: with and without loopinfo. Wouldn't completely removing loopinfo make instcombine better testable, hermetic, and predictable?

Fri, Mar 3, 11:36 AM · Restricted Project, Restricted Project

Thu, Mar 2

tschuett added a comment to D144994: [Draft][libc++][modules] Adds std module..

Really stupid question^{TM}: if you would put the cppm files into the include directory and provide cmake files to integrate into out-of-tree projects.

> ninja install-cmake-exports install-mlir-cmake-exports

LLVM installs theses cmake files so that other cmake projects can include them in their project. User could integrate files into their cmake project and have a target to build the pcm files.

Thu, Mar 2, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits..
Any binary that uses this feature is not forward portable to hardware
with a larger vector size. That's true for SVE as well.

I did not understood this sentence. AFAIK, SVE uses the ptrue instruction to generate a mask to only activate the necessary lanes. If I do fixed length SVE with 128 bit and you give a machine 2048 bits, then it should still work. Probably I missed something.

Thu, Mar 2, 11:02 AM · Restricted Project, Restricted Project

Tue, Feb 28

tschuett added a comment to D144994: [Draft][libc++][modules] Adds std module..

You cannot ship pcm files. They are tied to the clang`s git hash that they were built with. The pcm format could differ between 2 git commits.

Tue, Feb 28, 11:51 PM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2023

tschuett added a comment to D144921: [flang] Polymorphic Operations Conversion Pass .

https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Feb 27 2023, 10:23 PM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2023

tschuett added inline comments to D144083: [JITLink] Initial AArch32 backend.
Feb 24 2023, 10:42 AM · Restricted Project, Restricted Project
tschuett added inline comments to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.
Feb 24 2023, 1:02 AM · Restricted Project, Restricted Project

Feb 23 2023

tschuett added a comment to D144687: [GlobalISel][NFC] Add MachineInstr::getFirst[N]{Regs,LLTs}() helpers to extract regs & types..

Could you achieve the same with structured bindings?

Feb 23 2023, 11:55 PM · Restricted Project, Restricted Project
tschuett added a comment to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.

According to the tests in https://reviews.llvm.org/D112025 it also supports f64.

Feb 23 2023, 1:51 PM · Restricted Project, Restricted Project
tschuett added inline comments to D143018: [DAGCombiner][NFC] Factor out ByteProvider.
Feb 23 2023, 11:35 AM · Restricted Project, Restricted Project

Feb 22 2023

tschuett accepted D144509: [CMake] Bumps minimum version to 3.20.0..
Feb 22 2023, 3:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 20 2023

tschuett added inline comments to D143142: [clang][lex] Enable Lexer to grow its buffer.
Feb 20 2023, 2:55 AM · Restricted Project, Restricted Project

Feb 15 2023

tschuett added a comment to D144094: [flang] add hlfir.matmul operation.

Kudos. You found a pattern. At the top right, you will find Edit Related Revisions ....

Feb 15 2023, 6:26 AM · Restricted Project, Restricted Project

Feb 13 2023

tschuett added inline comments to D143938: [VPlan] Compute costs for plans directly after construction (WIP)..
Feb 13 2023, 12:33 PM · Restricted Project, Restricted Project

Feb 12 2023

tschuett added a comment to D143821: [flang] Conform with standard (mostly) for character length mismatches on arguments.

The web interface says at several places "Context not available.". Did you git diff -U999999 main?
https://llvm.org/docs/DeveloperPolicy.html#id10

Feb 12 2023, 9:18 AM · Restricted Project, Restricted Project
tschuett added inline comments to D143842: [lldb][test] Add check for Xcode binutils version to test-runner.
Feb 12 2023, 2:35 AM · Restricted Project, Restricted Project

Feb 11 2023

tschuett added a comment to D143820: [flang] Diagnose REPEAT with negative NCOPIES=.

You tend to upload without context. Do you need a pointer for some help?

Feb 11 2023, 10:56 AM · Restricted Project, Restricted Project

Feb 8 2023

tschuett added inline comments to D143535: github: Add manual workflow to build and upload release binaries.
Feb 8 2023, 12:26 AM · Restricted Project, Restricted Project
tschuett added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

For AArch64 the default alignment is 0? I would have expected 128.

Feb 8 2023, 12:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

tschuett added inline comments to D143323: [ConstraintElim] Add reproducer remarks..
Feb 6 2023, 11:00 AM · Restricted Project, Restricted Project

Feb 2 2023

tschuett added a comment to D142420: [Flang] Add support to use LTO specific pipelines.

Would it help to compile a lto.f90 to lto.o and check with llvm-objdump that there is a special section?

The .o is just llvm bitcode

Feb 2 2023, 11:11 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D142897: [flang] add hlfir.sum operation.
Feb 2 2023, 12:41 PM · Restricted Project, Restricted Project

Feb 1 2023

tschuett added a comment to D143102: [flang] Add AMDGPU target in flang.

I would have expected something ala:

flang -fopenmp -fopenmp-targets=nvptx64-nvidia-cuda example.f90
Feb 1 2023, 2:03 PM · Restricted Project, Restricted Project
tschuett added a comment to D133289: [C2X] N3007 Type inference for object definitions.

It surprised me that there are no type inference messages? The type of this auto is double. I only found warnings of misuse of auto and codegen tests.

Can you give a code example of what you expected to see a diagnostic for but aren't getting one?

This is probably only for testing and not for Clang users:

auto Float = 3.0; // note that Float is a float
Feb 1 2023, 7:13 AM · Restricted Project, Restricted Project

Jan 30 2023

tschuett added a comment to D142420: [Flang] Add support to use LTO specific pipelines.

Would it help to compile a lto.f90 to lto.o and check with llvm-objdump that there is a special section?

Jan 30 2023, 12:05 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2023

tschuett added a comment to D142578: [Clang][Doc] Edit the Clang release notes.

IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or beginning with Clang 16, we start a long-term project to overhaul the diagnostics.

Jan 28 2023, 6:22 AM · Restricted Project, Restricted Project
tschuett added a comment to D141234: [BOLT][Golang support] Core changes.

https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task

Jan 28 2023, 6:14 AM · Restricted Project, Restricted Project
tschuett added a comment to D142578: [Clang][Doc] Edit the Clang release notes.

I am not the only one who has a different background. If the introduction says this is the introduction of the release notes, I am not super motivated to read on. I would prefer to see some highlights to motivate the readers to continue reading.

Jan 28 2023, 5:25 AM · Restricted Project, Restricted Project

Jan 27 2023

tschuett added a comment to D142771: [flang] Avoid crashing from recursion on very tall expression parse trees.

Have you thought about adding a fuzzer for Flang ala
https://github.com/llvm/llvm-project/blob/main/libc/fuzzing/string/strcpy_fuzz.cpp

Jan 27 2023, 10:09 AM · Restricted Project, Restricted Project
tschuett added a comment to D142015: [LV] Plan with and without FoldTailByMasking.

Could you model this approach instead as a VPlan transformation, instead of hardcoding unscalable flags. Transform: add tail folding. Transform: add masked tail folding. Transform: add scalar tail. Then you can take the cost model to decide which is more desirable.

Jan 27 2023, 12:10 AM · Restricted Project, Restricted Project

Jan 26 2023

tschuett added inline comments to D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.
Jan 26 2023, 12:05 PM · Restricted Project, Restricted Project

Jan 24 2023

tschuett added a comment to D142438: [Docs] Mention GitHub commit comments as a possible post-commit review venue.

Bugzilla is offline?

Jan 24 2023, 1:35 AM · Restricted Project, Restricted Project

Jan 21 2023

tschuett added a comment to D142289: [NFC][TLI] Remove trailing whitespace from comment.

Are you looking for a LGTM? Is this a test Diff? You can commit such changes directly.

Jan 21 2023, 12:48 PM · Restricted Project, Restricted Project
tschuett added inline comments to D142273: [flang] Avoid unnecessary temporaries in ArrayValueCopy..
Jan 21 2023, 12:44 PM · Restricted Project, Restricted Project

Jan 20 2023

tschuett added inline comments to D142229: [docs] add early Arm arch support improvements to release notes.
Jan 20 2023, 9:14 AM · Restricted Project, Restricted Project

Jan 18 2023

tschuett added a comment to D141406: [AArch64] Codegen for FEAT_LSE128.

Sure.

Jan 18 2023, 10:08 AM · Restricted Project, Restricted Project
tschuett added a comment to D141406: [AArch64] Codegen for FEAT_LSE128.

If there are equivalent instructions in LLVM IR, you could touch the IR translator?

Jan 18 2023, 10:01 AM · Restricted Project, Restricted Project

Jan 17 2023

tschuett added a comment to D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension.

Could you please put an X86.rst file into llvm/docs? There is a Sphinx template with instructions.

Jan 17 2023, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D141625: [DeclContext] Sort the Decls before adding into DeclContext.

EXPANSIVE_CHECKS will reshuffle the llvm::sort input: https://lists.llvm.org/pipermail/llvm-dev/2018-April/122576.html

Jan 17 2023, 9:25 AM · Restricted Project, Restricted Project
tschuett added a comment to D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension.

The summary only says what you are doing. I am missing something about why.

Jan 17 2023, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension.
  • Can "x86.AMX" be a named constant somewhere? I found a lot of copies.
  • Release note?
Jan 17 2023, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

tschuett added a comment to D141581: [build] Fix stand-alone builds of clang..

I though Clang Basic is a leaf library and must not depend on anything.

Jan 16 2023, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2023

tschuett added a comment to D141187: [SystemZ] Set setMaxAtomicSizeInBitsSupported.

No, you don't. You cannot mix lock-free and mutex atomics. E.g, if loads are lock-free and stores use a mutex. Then you have lost atomicity. Your mutex version could do stores one byte at a time.

Jan 14 2023, 12:56 PM · Restricted Project, Restricted Project

Jan 13 2023

tschuett added a comment to D141723: [Clang] Remove `CLANG_OPENMP_NVPTX_DEFAULT_ARCH` CMake option..

Up right you will find Edit Related Revisions....

Jan 13 2023, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D141674: [Flang][Debug] Modifications for getting pathname.
Jan 13 2023, 6:58 AM · Restricted Project, Restricted Project

Jan 11 2023

tschuett updated subscribers of D141310: [clang] add -Wcompare-function-pointers.

Dependent of the build flags, we decide which warnings to enable or not? Do we have other warnings for ThinLTO?

Jan 11 2023, 10:52 AM · Restricted Project, Restricted Project

Jan 10 2023

tschuett added inline comments to D141410: [flang] Added coarse grained alias analysis for FIR..
Jan 10 2023, 2:38 PM · Restricted Project, Restricted Project
tschuett added inline comments to D141410: [flang] Added coarse grained alias analysis for FIR..
Jan 10 2023, 1:45 PM · Restricted Project, Restricted Project
tschuett added inline comments to D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.
Jan 10 2023, 6:51 AM · Restricted Project, Restricted Project
tschuett added inline comments to D141360: [PowerPC][GISel] Select sync instructions required by atomic operations.
Jan 10 2023, 6:51 AM · Restricted Project, Restricted Project

Jan 9 2023

tschuett added a comment to D133289: [C2X] N3007 Type inference for object definitions.

It surprised me that there are no type inference messages? The type of this auto is double. I only found warnings of misuse of auto and codegen tests.

Jan 9 2023, 10:52 AM · Restricted Project, Restricted Project

Jan 8 2023

tschuett added inline comments to D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins.
Jan 8 2023, 12:12 PM · Restricted Project, Restricted Project
tschuett added a comment to D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins.

https://github.com/openucx/ucx/blob/master/src/ucs/datastruct/pgtable.h super optimized page table for a similar use case.

Jan 8 2023, 9:43 AM · Restricted Project, Restricted Project

Jan 5 2023

tschuett added a comment to D140959: RFC: Multilib prototype.

Did you look at Yaml I/O?

Jan 5 2023, 7:03 AM · Restricted Project, Restricted Project

Jan 4 2023

tschuett added a comment to D137956: [Flang] Add/Restore basic debug support (1/n).

In https://reviews.llvm.org/D140415 there was similar question: pass or part of lowering? Could you register callbacks or some other magic into the lowering part to make it extensible for debug info, stack arrays, and more?

Jan 4 2023, 8:32 AM · Restricted Project, Restricted Project

Jan 3 2023

tschuett added a comment to D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4).

I believe you are arguing for a JSON file. The complexity of flags that want to pass to clang-scan-deps is too high. You even get some benefit of caching if you create a JSON file with several targets.

Jan 3 2023, 1:55 PM · Restricted Project, Restricted Project

Jan 2 2023

tschuett added inline comments to D133715: [ADT] Add TrieRawHashMap.
Jan 2 2023, 12:30 PM · Restricted Project, Restricted Project

Dec 31 2022

tschuett added inline comments to D140791: [DWARFLinkerParallel] Add simple list with thread safe insertions..
Dec 31 2022, 12:14 AM · Restricted Project, Restricted Project
tschuett added inline comments to D140788: [DWARFLinkerParallel] add AddressesMap interface..
Dec 31 2022, 12:08 AM · Restricted Project, Restricted Project

Dec 30 2022

tschuett added inline comments to D140788: [DWARFLinkerParallel] add AddressesMap interface..
Dec 30 2022, 12:37 PM · Restricted Project, Restricted Project

Dec 29 2022

tschuett added a comment to D140340: [flang] Restore checking for some optional values before use.

Are asserts the right solution or do you need control flow to check whether optionals have a value?

Dec 29 2022, 8:22 AM · Restricted Project, Restricted Project

Dec 28 2022

tschuett added a comment to D140720: [OpenMP][JIT] Introduce support for AMDGPU.

Halide is apparently using lld as a library: https://reviews.llvm.org/D140726

Dec 28 2022, 10:05 AM · Restricted Project, Restricted Project
tschuett added a comment to D140720: [OpenMP][JIT] Introduce support for AMDGPU.

Rust does not really care whether cc is clang or gcc. My point is that it is safer to invoke clang and let it manage the link step.

Dec 28 2022, 9:47 AM · Restricted Project, Restricted Project
tschuett added a comment to D140720: [OpenMP][JIT] Introduce support for AMDGPU.

Instead of invoking lld and copying the flags, could you invoke clang instead? The flags may change over time. Rust calls cc for linking.

Dec 28 2022, 12:01 AM · Restricted Project, Restricted Project

Dec 21 2022

tschuett added a comment to D140415: [flang] stack arrays pass.

Could you have a look at:
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Dec 21 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 20 2022

tschuett added a comment to D140347: SelectionDAG: Teach ComputeKnownBits about VSCALE.

There is as trySextValue in APInt: https://reviews.llvm.org/D139683. Maybe you need a tryMul.

Dec 20 2022, 1:27 PM · Restricted Project, Restricted Project
tschuett added a comment to D140241: [Flang] Rework the overview document.

Will you use the LLVM remarks facilities for optimisation reports?

I'm not familiar with the LLVM remarks facilities.

Dec 20 2022, 10:37 AM · Restricted Project, Restricted Project
tschuett added a comment to D140278: [libc++] Add __pointer_int_pair.

LLVM ships the same type: PointerIntPair.

Dec 20 2022, 8:44 AM · Restricted Project, Restricted Project
tschuett added a comment to D140241: [Flang] Rework the overview document.

Will you use the LLVM remarks facilities for optimisation reports?

Dec 20 2022, 6:15 AM · Restricted Project, Restricted Project

Dec 18 2022

tschuett added inline comments to D140275: [clangd] Tweak to add doxygen comment to the function declaration.
Dec 18 2022, 10:54 PM · Restricted Project, Restricted Project
tschuett added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Would __tuple_helpers or __tuple_utils be less ugly resp. obvious solutions to the challenge?

Dec 18 2022, 2:44 PM · Restricted Project, Restricted Project
tschuett added a comment to D140226: [NVPTX] Introduce attribute to mark kernels without a language mode.

There are already SYCL specific attributes: https://reviews.llvm.org/D60455

We could potentially merge these all into some generic attribute since they all do the same thing on a conceptual level. The unique thing about the existing amdgpu_kernel and corresponding nvptx_kernel is that they don't rely on the language options like SYCL or CUDA. Though, semantically those are definitely involved because the kernel itself is only meaningful to whatever runtime is going to load it (e.g. CUDA or HSA) but we can probably consider that separately to the compilation itself and just think of these as calling conventions.

Dec 18 2022, 10:17 AM · Restricted Project, Restricted Project
tschuett added a comment to D140226: [NVPTX] Introduce attribute to mark kernels without a language mode.

There are already SYCL specific attributes: https://reviews.llvm.org/D60455

Dec 18 2022, 8:56 AM · Restricted Project, Restricted Project