Page MenuHomePhabricator

tschuett (Thorsten)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2017, 6:56 AM (274 w, 3 d)

Recent Activity

Yesterday

tschuett added a comment to D126163: [flang] Set red bold color for the keyword "fatal internal error".

There is:
https://llvm.org/doxygen/classllvm_1_1WithColor.html
and
https://reviews.llvm.org/rG990d0c71090836fb117e72c262d6d19b76f346cc

Sun, May 22, 10:54 AM · Restricted Project, Restricted Project

Wed, May 18

tschuett added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

I remember that there was talk about a FloatCombine pass with costs.

Wed, May 18, 8:00 AM · Restricted Project, Restricted Project

Tue, May 17

tschuett added inline comments to D125768: [libc] Non-temporal memory function support.
Tue, May 17, 10:08 AM · Restricted Project, Restricted Project

Mon, May 9

tschuett added inline comments to D124776: [SPIR-V] Allow setting SPIR-V version via target triple.
Mon, May 9, 10:03 AM · Restricted Project, Restricted Project

Thu, May 5

tschuett added inline comments to D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang.
Thu, May 5, 10:36 AM · Restricted Project, Restricted Project
tschuett added inline comments to D125008: [llvm-objdump] Print Mnemonic Histogram.
Thu, May 5, 9:00 AM · Restricted Project, Restricted Project
tschuett added inline comments to D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang.
Thu, May 5, 6:22 AM · Restricted Project, Restricted Project

Mon, May 2

tschuett added a comment to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

Could you split this into smaller patches?
Does this support C++20 modules or is it limited to clang header modules?
Is there overhead in the non dependency scanning mode?

Mon, May 2, 7:22 AM · Restricted Project, Restricted Project

Sun, May 1

tschuett added inline comments to D123228: [libc++][WIP] Implement P0881R7 (std::stacktrace).
Sun, May 1, 1:03 PM · Restricted Project, Restricted Project

Fri, Apr 29

tschuett added inline comments to D124677: [ConstantFold] Don't convert getelementptr to ptrtoint+inttoptr.
Fri, Apr 29, 12:04 PM · Restricted Project, Restricted Project
tschuett added inline comments to D124663: LNT: Only use text segment when isSO.
Fri, Apr 29, 2:27 AM · Restricted Project, Restricted Project
tschuett added a comment to D112175: [NFC] Add llvm::StaticVector ADT.

You could use __cplusplus to determine the C++ version.

Fri, Apr 29, 2:20 AM · Restricted Project, Restricted Project
tschuett added inline comments to D124638: [clang] Track how headers get included generally during lookup time.
Fri, Apr 29, 1:04 AM · Restricted Project, Restricted Project

Tue, Apr 26

tschuett added a comment to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.

Thanks! I have the feeling that Release wins at execution speed and is the fastest to build?

Tue, Apr 26, 10:17 AM · Restricted Project, Restricted Project

Mon, Apr 25

tschuett added inline comments to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.
Mon, Apr 25, 1:37 AM · Restricted Project, Restricted Project
tschuett added a comment to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.

Thanks for driving this.

Mon, Apr 25, 1:36 AM · Restricted Project, Restricted Project

Sun, Apr 24

tschuett added a comment to D124347: [BOLT] RFC: Add golang support.

Using llvm-objdump to read properties of Go binaries.

Sun, Apr 24, 12:10 PM · Restricted Project, Restricted Project
tschuett added a comment to D124347: [BOLT] RFC: Add golang support.

This is a large patch.

Sun, Apr 24, 11:29 AM · Restricted Project, Restricted Project

Sat, Apr 23

tschuett updated subscribers of D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

@compnerd

Sat, Apr 23, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

tschuett added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

Then I have to repeat myself. If you google for LLVM and CMAKE_BUILD_TYPE, you will only find a list of the types. There is no documentation about the trade-offs or recommendations.

Apr 22 2022, 11:56 PM · Restricted Project, Restricted Project
tschuett added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

Rather than changing the default and annoying or confusing people, improve the documentation! Have cmake print a link to the awesome documentation.

Apr 22 2022, 8:43 AM · Restricted Project, Restricted Project

Apr 19 2022

tschuett added a comment to D123957: Update the developer policy to mention release notes.

LGTM and thanks.

Apr 19 2022, 12:37 PM · Restricted Project, Restricted Project
tschuett added a comment to D124007: [mlir] Connect Transform dialect to PDL.

Tranfsorm -> Transform in the summary.

Apr 19 2022, 9:44 AM · Restricted Project, Restricted Project
tschuett added a comment to D123664: [mlir][transform] Introduce transform.sequence op.

opertaion -> operation in the summary.

Apr 19 2022, 9:44 AM · Restricted Project, Restricted Project

Apr 17 2022

tschuett added a comment to D123911: [VectorCombine] Fold shuffle select pattern.

Are there remarks for the VectorCombine pass?

Apr 17 2022, 6:34 AM · Restricted Project, Restricted Project

Apr 15 2022

tschuett added a comment to D123050: [BOLT] Cache-Aware Tail Duplication.

There was a *very* brief discussion about system models on llvm-dev. Did you consider using something similar in bolt resp. llvm?
https://lists.llvm.org/pipermail/llvm-dev/2018-October/127319.html

Interesting, thanks for the pointer. Is there a discussion somewhere, i can only see a single message with RFC.

Apr 15 2022, 12:57 PM · Restricted Project, Restricted Project
tschuett added a comment to D123050: [BOLT] Cache-Aware Tail Duplication.

There was a *very* brief discussion about system models on llvm-dev. Did you consider using something similar in bolt resp. llvm?
https://lists.llvm.org/pipermail/llvm-dev/2018-October/127319.html

Apr 15 2022, 8:24 AM · Restricted Project, Restricted Project

Apr 14 2022

tschuett added a comment to D123645: [libc][docs] Add doc for libc string functions.

Still LGTM with the suggested inline fix.

Apr 14 2022, 12:06 PM · Restricted Project, Restricted Project
tschuett added inline comments to D123751: Implement support for __llvm_addrsig for MachO in llvm-mc.
Apr 14 2022, 7:08 AM · Restricted Project, Restricted Project

Apr 13 2022

tschuett added a comment to D121296: [GlobalIsel][X86] Legalization of G_IS_FPCLASS.

Could also use FewerElementsVector handling

Some support for fewerElements was added, but the support of vector types in X86 Global ISel is weak, and I could not make tests for this case. Some patches for this support are in work, but it is a long trail.

Apr 13 2022, 3:20 AM · Restricted Project, Restricted Project

Apr 11 2022

tschuett added a comment to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Unfortunately not. set and map seem to be very malloc heavy. I could not find any great alternatives in the LLVM manual.

Apr 11 2022, 1:42 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

I do not want to bother you at all:
https://llvm.org/docs/ProgrammersManual.html#map

Apr 11 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 11 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.

This would silently reduce protection, when incompatible modules are linked?

Apr 11 2022, 3:58 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2022

tschuett added a comment to D123435: [lld-macho] Initial support for EH Frames.

Is there another EH frame parser in-tree? LLVM or LLDB?

Apr 9 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

tschuett added a comment to D122008: [flang][driver] Add support for generating executables.

In my example, they even promised that the flag will removed.

Apr 7 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D123278: [Clang] [Docs] Add HLSLSupport page.

Thanks. I let Aaron go over the details.

Apr 7 2022, 7:03 AM · Restricted Project, Restricted Project

Apr 6 2022

tschuett added a comment to D123167: [HLSL] Pointers are unsupported in HLSL.

Relying on the parser to find semantic misbehavior sounds strange ...

I don't disagree. An alternative point: HLSL has no _syntax_ for pointers.

Apr 6 2022, 2:08 PM · Restricted Project, Restricted Project
tschuett added a comment to D123167: [HLSL] Pointers are unsupported in HLSL.

Relying on the parser to find semantic misbehavior sounds strange ...

Apr 6 2022, 2:05 PM · Restricted Project, Restricted Project
tschuett added a comment to D123167: [HLSL] Pointers are unsupported in HLSL.

Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp?

Yes absolutely. I haven't yet added any Sema-specific validations yet that are complex enough to break out, but we will 100% get there soon.

Apr 6 2022, 2:00 PM · Restricted Project, Restricted Project
tschuett added a comment to D123167: [HLSL] Pointers are unsupported in HLSL.

Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp?

Apr 6 2022, 1:57 PM · Restricted Project, Restricted Project
tschuett added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

My bad. I though of a last resort before the system crashes.

Apr 6 2022, 1:22 PM · Restricted Project, Restricted Project
tschuett added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:15 PM · Restricted Project, Restricted Project
tschuett added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

You cannot query the maximum parallelism ondemand and then create the array?

It's a little fragile -- things would break if someone created more than one ThreadPool instance & gave each instance the max hardware parallelism

But then MAX_THREADS has the same problem? For two thread pools I would need 2 * MAX_THREADS ?

Apr 6 2022, 12:34 PM · Restricted Project, Restricted Project
tschuett added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

You cannot query the maximum parallelism ondemand and then create the array?

Apr 6 2022, 12:29 PM · Restricted Project, Restricted Project
tschuett added a comment to D123226: [lldb] use one shared ThreadPool and task groups.

You cannot access/find the global thread pool? Sorry, wrong diff.

Apr 6 2022, 8:32 AM · Restricted Project, Restricted Project

Apr 5 2022

tschuett accepted D123002: [mlir] Add the Emacs support for MLIR's LSP server.

LGTM

Apr 5 2022, 4:22 AM · Restricted Project, Restricted Project

Apr 4 2022

tschuett added a comment to D122008: [flang][driver] Add support for generating executables.

https://reviews.llvm.org/D54604 used a really ugly flag:
-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

Apr 4 2022, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added a comment to D118948: [MTE] Add -fsanitize=memtag* and friends..

Is -fsanitize=memtag-heap Android specific or target independent? It passes Android flags to the linker?!?

Apr 4 2022, 12:42 PM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2022

tschuett added a comment to D123002: [mlir] Add the Emacs support for MLIR's LSP server.

I've thought about it, but I had two pros for keeping it here in my head: 1) since the mlir-mode and the mlir-lsp-server are distributed with LLVM, maybe it is better to keep it here (for example to match the compatibility) 2) it might worth merging this client with the mlir-mode

wdyt?

Apr 3 2022, 2:52 PM · Restricted Project, Restricted Project
tschuett added a comment to D123002: [mlir] Add the Emacs support for MLIR's LSP server.

Do you want to eventually upstream the support for MLIR to https://github.com/emacs-lsp/lsp-mode/?

Apr 3 2022, 2:22 PM · Restricted Project, Restricted Project
tschuett added inline comments to D123002: [mlir] Add the Emacs support for MLIR's LSP server.
Apr 3 2022, 12:10 PM · Restricted Project, Restricted Project

Apr 2 2022

tschuett added a comment to D122976: Bump minimum toolchain version.

Do you want to say something about buildbots, C++ features, and that you are not committing until foo.

Apr 2 2022, 12:38 PM · Restricted Project, Restricted Project

Mar 21 2022

tschuett added a comment to D122160: [clang][extract-api] Refactor ExtractAPI and improve docs.

Would you mind putting a high level description of the intent at the top of the main header.

Mar 21 2022, 12:29 PM · Restricted Project, Restricted Project
tschuett added a comment to D122082: Add DXIL Bitcode Writer and DXIL testing.

Yes, opaque pointer support is a hard requirement for any new code introduced in LLVM.

Mar 21 2022, 1:37 AM · Restricted Project, Restricted Project

Mar 13 2022

Herald added a project to D120232: [SelectOpti][4/5] Loop Heuristics: Restricted Project.
Mar 13 2022, 5:21 AM · Restricted Project, Restricted Project
Herald added a project to D120231: [SelectOpti][3/5] Base Heuristics: Restricted Project.
Mar 13 2022, 5:21 AM · Restricted Project, Restricted Project

Mar 12 2022

tschuett added inline comments to D121531: [ELF] Implement --build-id={md5,sha1} with truncated BLAKE3.
Mar 12 2022, 1:46 PM · Restricted Project, Restricted Project

Mar 11 2022

tschuett added inline comments to D121443: [lldb] Add a getter for the process' system architecture.
Mar 11 2022, 10:47 AM · Restricted Project, Restricted Project
tschuett added a comment to D120894: [AArch64][SVE]Make better use of gather/scatter when inside a loop body.

Removed unnecessary for loop from isInstUsedByGEP

Mar 11 2022, 6:02 AM · Restricted Project, Restricted Project

Mar 6 2022

tschuett added a comment to D120867: [IROutliner] Adding support to properly handle musttail, swifttailcc and tailcc.

I'm not sure how often musttail/tailcc appears in the LLVM test suite, but this didn't introduce any asserts there, and all of the tests pass.

@aschwaighofer Can you think of any (open source) Swift programs we can test this on? :)

Mar 6 2022, 1:30 PM · Restricted Project, Restricted Project

Mar 3 2022

tschuett added inline comments to D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems.
Mar 3 2022, 6:58 PM · Restricted Project, Restricted Project
tschuett added a comment to D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems.

Stupid question: this works with Windows as well? And the BTW sounds odd. gcc also decided to use a dash as the separator.

Mar 3 2022, 6:55 PM · Restricted Project, Restricted Project

Mar 2 2022

tschuett added a comment to D120836: [LLDB] Remove cases of using namespace llvm:: from header file.

I found this:
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions

Mar 2 2022, 11:25 AM · Restricted Project, Restricted Project

Feb 28 2022

tschuett added a comment to D120625: [BOLT][CMAKE] Bump minimum required CMake version to 3.14.

If you could ask for a cherry-pick into the 14.x. It would be great, if LLVM 14 would have consistent cmake version requirements.

Feb 28 2022, 3:33 PM · Restricted Project, Restricted Project

Feb 22 2022

tschuett updated subscribers of D120246: [flang][driver] Add support for `--target`/`--triple`.

There was a discussion that -emit-llvm is considered a mistake.

Feb 22 2022, 7:40 PM · Restricted Project, Restricted Project
tschuett added a comment to rGd3b26dea1610: Clang: Change the default DWARF version to 5.

Dwarf Error: found dwarf version '12', this reader only handles version 2, 3, 4 and 5 information.
Dwarf Error: Invalid or unhandled FORM value: 0x25.

For me, ld crashed on Ubuntu 18 LTS; GNU ld (GNU Binutils for Ubuntu) 2.30. EOL: April, 2023. Such breaking change (not compatible with gcc) could be acceptable after EOL, IMHO.

Does it stop the linker from linking? What flags are involved (-Wl,--gdb-index? that's the only one I can think of that /has/ to parse DWARF to link - the others are for error message quality, which hopefully lld still produces some usable error message, even if it doesn't mention file/line/source for the symbols)

Thankfully I read on Phoronix that dwarf 5 is now default in Clang, but I can imagine many developers would not know how to workaround that dwarf errors.

Could put up some sort of FAQ somewhere? (potentially ask/answer on stackoverflow or the like, but maybe there's some place we could put it in LLVM documentation - it is mentioned in the release notes, at least, I think)

(also, looking forward, maybe lld/libdebuginfo it's using needs some better parser support - I'm not sure where it's getting the "12" version number from, and it could string-ify the form number 0x25, which is a standard form in DWARFv5 which it says it supports - none of that addresses the usability of lld with Clang's DWARFv5 right now, but googling around there are repeated cases of these error messages showing up around DWARF default transitions, etc, and being pretty inscrutible, mentioning broken DWARF versions and opaque form numbers, etc)

Maybe additional check like if ubuntu < 20 then default = 4?

I don't think we have any specific Ubuntu detection, or Linux OS version checking in Clang to determine which flags to pass.

Feb 22 2022, 1:26 PM

Feb 18 2022

tschuett added a comment to D120152: [AArch64][SVE] Match VLS all-1's masks to PTRUE.

Why didn't or cannot InstCombine catch this?

Feb 18 2022, 12:07 PM · Restricted Project

Feb 13 2022

tschuett added a comment to D119641: Implement basic loader for Linux aarch64.

Interesting. I didn't know about it.

Feb 13 2022, 10:03 AM · Restricted Project

Feb 12 2022

tschuett added a comment to D119641: Implement basic loader for Linux aarch64.

You are mixing aarch64 and ARM64. I always associate ARM64 with Apple and aarch64 with the rest (Unix).

Feb 12 2022, 11:42 AM · Restricted Project
tschuett added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

This file describes the ABI for exporting the AArch64 CPU ID/feature registers to userspace. The availability of this ABI is advertised via the HWCAP_CPUID in HWCAPs.

Feb 12 2022, 7:17 AM · Restricted Project, Restricted Project

Feb 11 2022

tschuett added a comment to D119435: [Support][AArch64] Detect a few more host CPU features on AArch64.

https://github.com/torvalds/linux/blob/master/Documentation/arm64/cpu-feature-registers.rst
Is similar to how Intel is doing feature detection.

Feb 11 2022, 3:54 PM · Restricted Project, Restricted Project

Feb 3 2022

tschuett added a comment to D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst.

https://reviews.llvm.org/D118862
https://reviews.llvm.org/D118875

Feb 3 2022, 9:44 AM · Restricted Project, Restricted Project

Feb 1 2022

tschuett added inline comments to D108416: [llvm-libgcc] initial commit.
Feb 1 2022, 5:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D118732: [BOLT] Add aarch64 support for peephole passes.
Feb 1 2022, 1:08 PM · Restricted Project

Jan 31 2022

tschuett added a comment to D118669: [Attributor] Introduce the concept of query AAs.

Feel free to ignore:
https://rustc-dev-guide.rust-lang.org/query.html

Jan 31 2022, 5:18 PM · Restricted Project
tschuett added inline comments to D118592: [cte] Add release notes for clangd-14.
Jan 31 2022, 6:58 AM · Restricted Project

Jan 30 2022

tschuett updated subscribers of D118545: [ARM] Fix 8-bit immediate overflow in the instruction of segmented stack prologue..

@dmgreen

Jan 30 2022, 1:01 PM · Restricted Project, Restricted Project

Jan 29 2022

tschuett updated subscribers of D118331: [llvm-objdump][macho] Add initial --chained_fixups support.
Jan 29 2022, 5:22 PM · Restricted Project, Restricted Project
tschuett added a comment to D118331: [llvm-objdump][macho] Add initial --chained_fixups support.

https://reviews.llvm.org/D113630

Jan 29 2022, 12:59 PM · Restricted Project, Restricted Project

Jan 24 2022

tschuett added a comment to D114342: ConvertUTF, new wrapper API.

I though modern LLVM is to return llvm::Expected<std::string>?!?

Jan 24 2022, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
tschuett added inline comments to D117938: [clang][dataflow] Avoid MaxIterations overflow.
Jan 24 2022, 6:47 AM · Restricted Project

Jan 19 2022

tschuett added a comment to D117664: [Support] Remove incorrect noalias return attribute in BumpPtrAllocator.

Maybe add a macro LLVM_ATTRIBUTE_RETURNS_ALIAS for documentation.

Jan 19 2022, 9:47 AM · Restricted Project

Jan 13 2022

tschuett added a comment to D108416: [llvm-libgcc] initial commit.

I prefer: #!/usr/bin/env python3

Jan 13 2022, 1:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 9 2022

tschuett added inline comments to D116897: [libc++] Fix the documentation and re-enable documentation CI.
Jan 9 2022, 12:12 PM · Restricted Project
tschuett added a comment to D116882: [docs] [clang] Small documentation change for compilation databases.

https://sarcasm.github.io/notes/dev/compilation-database.html#clang

Jan 9 2022, 2:11 AM · Restricted Project

Jan 7 2022

tschuett added inline comments to D116702: [GlobalISel] Combine select + fcmp to fminnum/fmaxnum/fminimum/fmaximum.
Jan 7 2022, 10:13 AM · Restricted Project, Restricted Project

Dec 16 2021

tschuett added inline comments to D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack.
Dec 16 2021, 12:04 PM · Restricted Project, Restricted Project

Dec 15 2021

tschuett added a comment to D115009: [SPIRV 1/6] Add stub for SPIRV backend.

You could mark the other revisions as child revisions with Edit Related Revisions... at the top right.

Dec 15 2021, 7:57 AM · Restricted Project, Restricted Project

Dec 9 2021

tschuett added a comment to D115408: [libc] Implement correctly rounded logf based on RLIBM library..

Do you believe this is a permalink? Maybe cite a paper of the algorithm?

Dec 9 2021, 10:21 AM · Restricted Project

Dec 7 2021

tschuett added a comment to D115211: [lldb] Make the LLDB version a first class citizen.

I believe the Basic library in Clang does not depend on other Clang libraries. It is a tail library. Do you envision a Basic, Utility, ... library that does not depend on Clang and provides basic utilities.

Dec 7 2021, 2:09 AM · Restricted Project

Dec 3 2021

tschuett added a comment to D114964: [DAG] Create fptoui.sat from clamped fptoui.

As an outsider, similar to VectorCombine maybe other FooCombine passes (special purpose) with costs. As an addition/extension to InstCombine.

Dec 3 2021, 12:09 PM · Restricted Project

Dec 2 2021

tschuett added inline comments to D114971: [clang][deps] Handle symlinks in minimizing FS.
Dec 2 2021, 10:08 AM · Restricted Project
tschuett added inline comments to D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 2 2021, 12:55 AM · Restricted Project
tschuett added inline comments to D114141: Allow DataLayout to support arbitrary pointer sizes.
Dec 2 2021, 12:41 AM · Restricted Project

Nov 28 2021

tschuett accepted D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.

LGTM

Nov 28 2021, 12:02 PM · Restricted Project
tschuett added a comment to D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.

There is precedence for checking WaMArch.size() in the file. I would expected !WaMArch.empty().

Nov 28 2021, 10:23 AM · Restricted Project
tschuett added inline comments to D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.
Nov 28 2021, 10:19 AM · Restricted Project

Nov 26 2021

tschuett added a comment to D114542: [CodeGen][SVE] Use whilelo instruction when lowering @llvm.get.active.lane.mask.

I think the main difference between SVE and MVE is that for MVE we have to set up some state before entering the loop, and perhaps the actual instruction that generates the predicate uses that state? Whereas for SVE we don't have that problem.

Yep, and I would need to refresh my memory and read the reference manual, but I am almost certain that for MVE we would get wrong results if overflow occurs in the VCTP instructions.

Could you add Metadata to the intrinsic to state the assumptions?

Something along those lines would probably be possible, but defeats the purpose of the intrinsic, which is about communicating information from the middle-end to the back-end. If we need an intrinsic and also meta-data to achieve this, then we should probably revise the definition of the intrinsic. But it looks like we don't need to do that at the moment, and we are also good for SVE.

Nov 26 2021, 1:08 AM · Restricted Project

Nov 25 2021

tschuett added a comment to D114542: [CodeGen][SVE] Use whilelo instruction when lowering @llvm.get.active.lane.mask.

I think the main difference between SVE and MVE is that for MVE we have to set up some state before entering the loop, and perhaps the actual instruction that generates the predicate uses that state? Whereas for SVE we don't have that problem.

Yep, and I would need to refresh my memory and read the reference manual, but I am almost certain that for MVE we would get wrong results if overflow occurs in the VCTP instructions.

Nov 25 2021, 1:43 AM · Restricted Project