User Details
- User Since
- Feb 17 2017, 6:56 AM (274 w, 3 d)
Yesterday
Wed, May 18
I remember that there was talk about a FloatCombine pass with costs.
Tue, May 17
Mon, May 9
Thu, May 5
Mon, May 2
Could you split this into smaller patches?
Does this support C++20 modules or is it limited to clang header modules?
Is there overhead in the non dependency scanning mode?
Sun, May 1
Fri, Apr 29
You could use __cplusplus to determine the C++ version.
Tue, Apr 26
Thanks! I have the feeling that Release wins at execution speed and is the fastest to build?
Mon, Apr 25
Thanks for driving this.
Sun, Apr 24
Using llvm-objdump to read properties of Go binaries.
This is a large patch.
Sat, Apr 23
Apr 22 2022
Then I have to repeat myself. If you google for LLVM and CMAKE_BUILD_TYPE, you will only find a list of the types. There is no documentation about the trade-offs or recommendations.
Rather than changing the default and annoying or confusing people, improve the documentation! Have cmake print a link to the awesome documentation.
Apr 19 2022
LGTM and thanks.
Tranfsorm -> Transform in the summary.
opertaion -> operation in the summary.
Apr 17 2022
Are there remarks for the VectorCombine pass?
Apr 15 2022
There was a *very* brief discussion about system models on llvm-dev. Did you consider using something similar in bolt resp. llvm?
https://lists.llvm.org/pipermail/llvm-dev/2018-October/127319.html
Apr 14 2022
Apr 13 2022
Apr 11 2022
Unfortunately not. set and map seem to be very malloc heavy. I could not find any great alternatives in the LLVM manual.
I do not want to bother you at all:
https://llvm.org/docs/ProgrammersManual.html#map
This would silently reduce protection, when incompatible modules are linked?
Apr 9 2022
Is there another EH frame parser in-tree? LLVM or LLDB?
Apr 7 2022
In my example, they even promised that the flag will removed.
Thanks. I let Aaron go over the details.
Apr 6 2022
Relying on the parser to find semantic misbehavior sounds strange ...
Do you need a SemaHLSL.cpp file similar to SemaSYCL.cpp?
My bad. I though of a last resort before the system crashes.
But then MAX_THREADS has the same problem? For two thread pools I would need 2 * MAX_THREADS ?
You cannot query the maximum parallelism ondemand and then create the array?
You cannot access/find the global thread pool? Sorry, wrong diff.
Apr 5 2022
LGTM
Apr 4 2022
https://reviews.llvm.org/D54604 used a really ugly flag:
-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang
Is -fsanitize=memtag-heap Android specific or target independent? It passes Android flags to the linker?!?
Apr 3 2022
Do you want to eventually upstream the support for MLIR to https://github.com/emacs-lsp/lsp-mode/?
Apr 2 2022
Do you want to say something about buildbots, C++ features, and that you are not committing until foo.
Mar 21 2022
Would you mind putting a high level description of the intent at the top of the main header.
Mar 13 2022
Mar 12 2022
Mar 11 2022
Mar 6 2022
Mar 3 2022
Stupid question: this works with Windows as well? And the BTW sounds odd. gcc also decided to use a dash as the separator.
Mar 2 2022
Feb 28 2022
If you could ask for a cherry-pick into the 14.x. It would be great, if LLVM 14 would have consistent cmake version requirements.
Feb 22 2022
There was a discussion that -emit-llvm is considered a mistake.
Feb 18 2022
Why didn't or cannot InstCombine catch this?
Feb 13 2022
Interesting. I didn't know about it.
Feb 12 2022
You are mixing aarch64 and ARM64. I always associate ARM64 with Apple and aarch64 with the rest (Unix).
This file describes the ABI for exporting the AArch64 CPU ID/feature registers to userspace. The availability of this ABI is advertised via the HWCAP_CPUID in HWCAPs.
Feb 11 2022
https://github.com/torvalds/linux/blob/master/Documentation/arm64/cpu-feature-registers.rst
Is similar to how Intel is doing feature detection.
Feb 3 2022
Feb 1 2022
Jan 31 2022
Feel free to ignore:
https://rustc-dev-guide.rust-lang.org/query.html
Jan 30 2022
Jan 29 2022
Jan 24 2022
I though modern LLVM is to return llvm::Expected<std::string>?!?
Jan 19 2022
Maybe add a macro LLVM_ATTRIBUTE_RETURNS_ALIAS for documentation.
Jan 13 2022
I prefer: #!/usr/bin/env python3
Jan 9 2022
Jan 7 2022
Dec 16 2021
Dec 15 2021
You could mark the other revisions as child revisions with Edit Related Revisions... at the top right.
Dec 9 2021
Do you believe this is a permalink? Maybe cite a paper of the algorithm?
Dec 7 2021
I believe the Basic library in Clang does not depend on other Clang libraries. It is a tail library. Do you envision a Basic, Utility, ... library that does not depend on Clang and provides basic utilities.
Dec 3 2021
As an outsider, similar to VectorCombine maybe other FooCombine passes (special purpose) with costs. As an addition/extension to InstCombine.
Dec 2 2021
Nov 28 2021
LGTM
There is precedence for checking WaMArch.size() in the file. I would expected !WaMArch.empty().