Page MenuHomePhabricator

tschuett (Thorsten)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2017, 6:56 AM (187 w, 2 d)

Recent Activity

Fri, Sep 18

tschuett added a comment to D87936: [GISel] Add new combines for G_ADD.

Out of curiosity, is the first rule a win or canonicalisation?

Fri, Sep 18, 1:24 PM · Restricted Project

Thu, Sep 17

tschuett abandoned D82404: [libc] Minimal Darwin support.
Thu, Sep 17, 12:43 AM · Restricted Project

Mon, Sep 14

tschuett added a comment to D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Are you sure about std::set?
https://llvm.org/docs/ProgrammersManual.html#set

Mon, Sep 14, 10:58 AM · Restricted Project

Tue, Sep 1

tschuett added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

You could just a a file to clang docs with:
Clang assumes that memcpy(p, p, n) is safe.

Tue, Sep 1, 12:00 PM · Restricted Project

Fri, Aug 28

tschuett added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

How about making it explicit: The source location and the destination location may overlap.

Fri, Aug 28, 1:52 PM · Restricted Project
tschuett added a comment to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

How about a malformed module map is not loaded and gives no errors?

Fri, Aug 28, 12:42 PM · Restricted Project

Thu, Aug 27

tschuett added inline comments to D86688: [RecoveryExpr] Add 11.0.0 release note..
Thu, Aug 27, 6:10 AM · Restricted Project

Aug 21 2020

tschuett added a comment to D86351: WIP: llvm-buildozer 1/3 [llvm part].

When you extended the thread pool for high cores counts for Windows, I thought the other way around. I want to you use the distributed thinlto locally. Then each ninja job is single threaded and ninja can schedule everything. This probably won't be a desirable solution for Windows.

Aug 21 2020, 11:39 AM

Aug 18 2020

tschuett added a comment to D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing.

You can buy a PRIMEHPC FX700 from Fujitsu. It has a A64FX CPU with SVE.

Aug 18 2020, 2:32 AM · Restricted Project

Aug 14 2020

tschuett added inline comments to D85977: [release][docs] Update contributions to LLVM 11 for SVE..
Aug 14 2020, 10:06 AM · Restricted Project, Restricted Project

Aug 10 2020

tschuett added a comment to D85594: [MachO] Add skeletal support for DriverKit platform.

No worries. I added @ributzka and @cishida as reviewers because they should know.

Aug 10 2020, 8:56 AM · Restricted Project

Aug 9 2020

tschuett added a comment to D81413: [lld-macho] improve handling of -platform_version.

Here is v530:
https://opensource.apple.com/tarballs/ld64/ld64-530.tar.gz

Aug 9 2020, 10:43 PM · Restricted Project, lld
tschuett added reviewers for D85594: [MachO] Add skeletal support for DriverKit platform: ributzka, cishida.
Aug 9 2020, 4:05 AM · Restricted Project
tschuett added a comment to D85594: [MachO] Add skeletal support for DriverKit platform.

Do you want to add something similar to:
https://github.com/llvm/llvm-project/blob/master/llvm/unittests/TextAPI/TextStubV4Tests.cpp#L593
for DriverKit?

Aug 9 2020, 1:40 AM · Restricted Project

Aug 8 2020

tschuett added a comment to D81413: [lld-macho] improve handling of -platform_version.

You can add DriverKit here:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/TextAPI/MachO/Platform.h#L33
and here:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/BinaryFormat/MachO.h#L499

Aug 8 2020, 9:24 AM · Restricted Project, lld

Aug 6 2020

tschuett added a comment to D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder..

I don't know whether the name of your downstream target is a secret. Wouldn't it help you to add a fake 16bit per char target to clang and add units tests to prevent regressions?

Aug 6 2020, 6:10 AM · Restricted Project

Aug 5 2020

tschuett added a comment to D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

And you can write it as

Aug 5 2020, 10:50 PM · Restricted Project
tschuett added a comment to D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

auto_ptr is deprecated since C++11 and will be removed in C++17.

Aug 5 2020, 10:20 PM · Restricted Project

Aug 4 2020

tschuett added inline comments to D83094: Analysis: Add a GenericCycleInfo analysis.
Aug 4 2020, 2:10 PM · Restricted Project
tschuett added a comment to D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute.

Sorry. I meant ABI. Can link GCC .o files with Clang .o files using the attributes?

Aug 4 2020, 6:43 AM · Restricted Project, Restricted Project

Aug 3 2020

tschuett added a comment to D85102: [clang] improve diagnostics for misaligned and large atomics.

I would appreciate it, if somebody could commit this patch on my behalf.
Thorsten Schuett
schuett@gmail.com

Aug 3 2020, 12:22 PM · Restricted Project
tschuett added a comment to D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute.

Stupid questions.

  • Is it for convenience? You get arrays, global variables, structs, ... . Vectorization becomes easier ...
  • Are there any potential performance benefits over scalable vectors?
  • Is it compatible with GCC?
Aug 3 2020, 9:43 AM · Restricted Project, Restricted Project
tschuett updated the diff for D85102: [clang] improve diagnostics for misaligned and large atomics.

added missing "alignment"

Aug 3 2020, 8:46 AM · Restricted Project
tschuett added a comment to D85102: [clang] improve diagnostics for misaligned and large atomics.

I wanted to save space. I know that the alignment is missing there, but the line is already too long.

Aug 3 2020, 8:42 AM · Restricted Project

Aug 2 2020

tschuett updated the diff for D85102: [clang] improve diagnostics for misaligned and large atomics.

add/updated test

Aug 2 2020, 4:59 PM · Restricted Project
tschuett added a comment to D85102: [clang] improve diagnostics for misaligned and large atomics.

introduced in https://reviews.llvm.org/D45319

Aug 2 2020, 4:21 PM · Restricted Project
tschuett updated the summary of D85102: [clang] improve diagnostics for misaligned and large atomics.
Aug 2 2020, 4:10 PM · Restricted Project
tschuett updated the diff for D85102: [clang] improve diagnostics for misaligned and large atomics.

Replaced (...) by ;

Aug 2 2020, 4:09 PM · Restricted Project
tschuett requested review of D85102: [clang] improve diagnostics for misaligned and large atomics.
Aug 2 2020, 3:58 PM · Restricted Project

Jul 30 2020

tschuett added a comment to D83692: Add first microbenchmarks for matrix types extensions..

Feel free to ignore: "On Subnormal Floating Point and Abnormal Timing"
http://www.ieee-security.org/TC/SP2015/papers-archived/6949a623.pdf

Jul 30 2020, 11:47 AM

Jul 10 2020

tschuett added a comment to D82404: [libc] Minimal Darwin support.

Mach-O is my toy project. The real one will be COFF/Windows.

Jul 10 2020, 12:31 PM · Restricted Project
tschuett added a comment to D82404: [libc] Minimal Darwin support.

Now, I realized that I cannot use/develop malloc/free redirectors on Darwin.

Jul 10 2020, 12:20 PM · Restricted Project
tschuett added a comment to D82404: [libc] Minimal Darwin support.

I see, but this solution seems to be a very Linux/ELF way of doing it. I could not find anything similar for Mach-O.

Jul 10 2020, 12:06 PM · Restricted Project
tschuett updated the diff for D82404: [libc] Minimal Darwin support.
  • fixed linting
  • minimal entry point
Jul 10 2020, 2:04 AM · Restricted Project

Jul 9 2020

tschuett added a comment to D82404: [libc] Minimal Darwin support.
/Users/XXX/Work/XXX/llvm-project/libc/src/string/memcpy.h:13:1: error: system include stddef.h not allowed, transitively included from /Users/XXX/Work/XXX/llvm-project/libc/src/string/memcpy.h (/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/stddef.h) [llvmlibc-restrict-system-libc-headers,-warnings-as-errors]
#include <stddef.h> // size_t
Jul 9 2020, 6:21 AM · Restricted Project
tschuett added a comment to D83452: [DWARFYAML] Use override instead of virtual for better safety..

See the c++ core guide rules:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override

Jul 9 2020, 1:51 AM · Restricted Project

Jul 8 2020

tschuett added a comment to D82376: [libc] Add strdup implementation..

There was a redirector for the round function:
https://reviews.llvm.org/D69020

Jul 8 2020, 2:22 PM · Restricted Project

Jul 7 2020

tschuett added a comment to D82376: [libc] Add strdup implementation..

See below:
https://github.com/llvm/llvm-project/blob/master/libc/docs/redirectors.rst

Jul 7 2020, 11:20 PM · Restricted Project

Jul 6 2020

tschuett added a comment to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Pardon my cmake, but don't you need a CMakeLists.txt in the GISel sub-directory?

Jul 6 2020, 2:09 PM · Restricted Project

Jul 5 2020

tschuett added a comment to D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source.

You could try:

clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp -emit-llvm -o /dev/null
Jul 5 2020, 6:55 AM · Restricted Project, Restricted Project

Jul 3 2020

tschuett added inline comments to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
Jul 3 2020, 2:34 PM · Restricted Project
tschuett added a comment to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

AArch64 has a sub-directory for GlobalISel related things:
https://reviews.llvm.org/D81116

Jul 3 2020, 10:12 AM · Restricted Project

Jul 1 2020

tschuett added a comment to D82923: introducing llvm-libtool-darwin.

I suggest removing the extraneous level of directory "Darwin" -- just put the files in "llvm/tools/llvm-libtool-darwin", name the source "llvm-libtool-darwin.cpp", and say you're adding "llvm-libtool-darwin" in the commit message.

While it's weird to have a darwin-specific tool for creating archives and shared libraries, that's the status quo. And moving that to an LLVM implementation is entirely reasonable. Let's just not pretend this is ever going to be something else other than that.

Jul 1 2020, 12:59 PM · Restricted Project

Jun 27 2020

tschuett added a comment to D82404: [libc] Minimal Darwin support.

Maybe the linting problem is not unique to Darwin, but highlights a more general problem with this approach. So far development was limited to Linux.

Jun 27 2020, 12:02 AM · Restricted Project

Jun 26 2020

tschuett added a comment to D82404: [libc] Minimal Darwin support.

I don't know whether linking without systemb is supported at all, but LLVM libc is designed to be layered on top of the system libc. It seems to be a problem of the include order.

Jun 26 2020, 11:42 PM · Restricted Project

Jun 25 2020

tschuett added a comment to D82591: [libc] Add the remaining long double flavors of nearest integer functions..

Did you miss the aarch64 entry points?

Jun 25 2020, 1:05 PM · Restricted Project
tschuett updated subscribers of D82554: Update config.guess to more recent version.

Does this change undo https://reviews.llvm.org/rG050ed9720f84343d859c530b8b692eb6141e6a63 ?

Jun 25 2020, 8:33 AM · Restricted Project

Jun 24 2020

tschuett added a comment to D82404: [libc] Minimal Darwin support.

Notes:

  • llvm-objcopy cannot do aliases for Mach-O. It can only rename symbols.
  • ld64 supports an alias_list option to create aliases. It would probably require the mangled names.
  • clang does not support the alias attribute for Darwin.
  • use llvm-readobj to extract the mangled names from the entry point sections.
Jun 24 2020, 2:09 PM · Restricted Project
tschuett updated the diff for D82404: [libc] Minimal Darwin support.

add missing include

Jun 24 2020, 1:02 AM · Restricted Project

Jun 23 2020

tschuett updated the diff for D82404: [libc] Minimal Darwin support.

some cmake improvements

Jun 23 2020, 2:32 PM · Restricted Project
tschuett updated the diff for D82404: [libc] Minimal Darwin support.

copy and paste api.td from linux ...

Jun 23 2020, 1:59 PM · Restricted Project
tschuett updated the summary of D82404: [libc] Minimal Darwin support.
Jun 23 2020, 1:26 PM · Restricted Project
tschuett updated the summary of D82404: [libc] Minimal Darwin support.
Jun 23 2020, 1:26 PM · Restricted Project
tschuett created D82404: [libc] Minimal Darwin support.
Jun 23 2020, 12:54 PM · Restricted Project
tschuett added a comment to D82376: [libc] Add strdup implementation..

Add a redirector for malloc/free as a temporary solution?

Jun 23 2020, 10:10 AM · Restricted Project

Jun 12 2020

tschuett added a comment to D80582: [lld-macho] Specify the complete set of command-line options for ld64.

https://opensource.apple.com/source/ld64/ld64-530/doc/man/man1/ld.1.auto.html
https://opensource.apple.com/source/ld64/ld64-530/

Jun 12 2020, 2:14 PM · Restricted Project

Jun 9 2020

tschuett abandoned D81496: Add PLATFORM driverkit.
Jun 9 2020, 11:25 PM · Restricted Project
tschuett updated the summary of D81496: Add PLATFORM driverkit.
Jun 9 2020, 1:14 PM · Restricted Project
tschuett created D81496: Add PLATFORM driverkit.
Jun 9 2020, 1:14 PM · Restricted Project
tschuett updated the summary of D81496: Add PLATFORM driverkit.
Jun 9 2020, 1:14 PM · Restricted Project

Jun 8 2020

tschuett added a comment to D81413: [lld-macho] improve handling of -platform_version.

Neither PlatformType nor PlatformKind cover all cases of -platform_version, but TextAPI uses PlatformKind.

Jun 8 2020, 12:41 PM · Restricted Project, lld

May 26 2020

tschuett added a comment to D80291: [libc][NFC] Simplify memcpy implementation.

Shouldn't "kRepMovsBSize = -1" be "kRepMovsBSize =SIZE_MAX"?

May 26 2020, 1:05 PM · Restricted Project
tschuett added a comment to D80291: [libc][NFC] Simplify memcpy implementation.

Would it help the reader to say: The function is written in pure C++ *and not in assembler/intrinsics* for several reasons:

May 26 2020, 11:58 AM · Restricted Project

May 24 2020

tschuett retitled D80494: [libc] Making libc compile on AArch64. from Making libc compile on AArch64. to [libc] Making libc compile on AArch64..
May 24 2020, 1:20 PM

May 19 2020

tschuett added a comment to D80124: [Matrix] Make matrix.multiply variadic, accept optional NUW/NSW flags..

No worries. I just wanted to point out that there are other efforts to define floating-point behaviour beyond fast-math.

May 19 2020, 7:34 AM · Restricted Project
tschuett added a comment to D80124: [Matrix] Make matrix.multiply variadic, accept optional NUW/NSW flags..

constrained math: https://llvm.org/docs/LangRef.html#constrained-floating-point-intrinsics

May 19 2020, 2:08 AM · Restricted Project

May 18 2020

tschuett added a comment to D68115: Zero initialize padding in unions.

I watched the talk, but I still prefer compile-time errors over runtime crashes.

May 18 2020, 1:33 PM · Restricted Project

May 17 2020

tschuett added a comment to D68115: Zero initialize padding in unions.

As an outsider: In Swift, reading an uninitialized variable is a compile-time error. Clang is not powerful enough to do this analysis. Aren't you really looking for the Clang Intermediate Language (CIL) ?

May 17 2020, 10:06 AM · Restricted Project

May 11 2020

tschuett retitled D79708: [clang][BFloat] add NEON emitter for bfloat from [clangd][BFloat] add NEON emitter for bfloat to [clang][BFloat] add NEON emitter for bfloat.
May 11 2020, 12:22 PM · Restricted Project
tschuett retitled D79710: [clang][BFloat] Add create/set/get/dup intrinsics from [clangd][BFloat] add create/set/get/dup intrinsics to [clang][BFloat] add create/set/get/dup intrinsics.
May 11 2020, 12:22 PM · Restricted Project

May 2 2020

tschuett added inline comments to D78903: [Driver] Add option -fproc-stat-report.
May 2 2020, 2:36 AM · Restricted Project

Apr 22 2020

tschuett added a comment to D78612: [libc] Add sanitizer instrumentation to the SIMD strlen implementation..

Do what ever you want, but I would go with the slow and safe strlen implementation until somebody proves that strlen is a performance issue.

Apr 22 2020, 11:58 AM · Restricted Project
tschuett added a comment to D78612: [libc] Add sanitizer instrumentation to the SIMD strlen implementation..

Sorry, my mistake. With "avoid the sanitizer dancing" I meant that the compiler should do the instrumentation instead of doing it manually, which is error-prone.

Apr 22 2020, 11:26 AM · Restricted Project
tschuett added a comment to D78612: [libc] Add sanitizer instrumentation to the SIMD strlen implementation..

I am starting to believe that it is better to stay with the slow and safe strlen implementation. Avoid the sanitizer dancing. Spend more energy on adding features. So that people start using this libc. Then you can use a profiler to find the hot functions.

Apr 22 2020, 10:52 AM · Restricted Project

Apr 15 2020

tschuett added a comment to D77949: [libc] Add SIMD strlen implementation ..

Pattern matching? Most compilers can recognize matrix-matrix multiplication. It bit me once.
It might eventually learn these SIMD patterns.

Apr 15 2020, 7:05 AM · Restricted Project

Apr 14 2020

tschuett added a comment to D77949: [libc] Add SIMD strlen implementation ..

No worries. I am only afraid that a future compiler detects the UB and starts to optimize.

Apr 14 2020, 11:22 PM · Restricted Project

Apr 13 2020

tschuett added a comment to D77949: [libc] Add SIMD strlen implementation ..

glibc is doing it in a similar way. It exhibits the same UB.
https://sourceware.org/git/?p=glibc.git;a=blob;f=string/strlen.c;h=f934e1a1e897c0176c04566a182f092dc1ab2a37;hb=HEAD

Apr 13 2020, 11:57 PM · Restricted Project

Apr 11 2020

tschuett added a comment to D77949: [libc] Add SIMD strlen implementation ..

AddressSanitizer is already unhappy about EmptyString.

Apr 11 2020, 1:52 PM · Restricted Project
tschuett updated the diff for D77949: [libc] Add SIMD strlen implementation ..

Some stylistic improvements.

Apr 11 2020, 11:43 AM · Restricted Project
tschuett updated the diff for D77949: [libc] Add SIMD strlen implementation ..

Added SevenBytes and SixBytes

Apr 11 2020, 11:11 AM · Restricted Project
tschuett added a comment to D77949: [libc] Add SIMD strlen implementation ..

For reference, this was also discussed in https://reviews.llvm.org/D77279.

Apr 11 2020, 11:11 AM · Restricted Project
tschuett created D77949: [libc] Add SIMD strlen implementation ..
Apr 11 2020, 10:07 AM · Restricted Project

Jan 8 2020

tschuett added a comment to D72353: [libc] Add a convenience CMake rule to add testsuites..

Unfortunately, this fails on OSX when ${LIBC_TARGET_OS} == "darwin" in libc/test/config/CMakeLists.txt. Windows might have a similar problem. I have no intent building libc. It fails with having libc in LLVM_ENABLE_PROJECTS.

Jan 8 2020, 1:29 AM · Restricted Project

Sep 10 2019

tschuett added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

No worries.

Sep 10 2019, 10:09 PM
tschuett added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Thanks for doing that! But it looks odd to attach the dependencies to the output file.

Sep 10 2019, 5:14 AM

Aug 21 2019

tschuett added a comment to D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.

How does it relate to the -MJ option?

Aug 21 2019, 11:07 PM · Restricted Project

Apr 2 2019

tschuett added a comment to D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

Are you planning to do this recursively?
The minimizer does not help much for the following example, while Sema.h contains 10,000 lines of useless code.

#include "clang/Sema/Sema.h"
Apr 2 2019, 3:33 AM · Restricted Project, Restricted Project

Nov 16 2018

tschuett added a comment to D53510: [LLVM] Allow modulemap installation.

Thx, for doing this. Are you planning to do a follow up for Clang? I have been hacking this myself locally.

Nov 16 2018, 10:50 AM

Jun 21 2017

tschuett added a comment to D33586: ARMv8.1 support for LLVM AArch64.

Is it possible that the tests were excluded from the commit?

Jun 21 2017, 8:02 AM