Page MenuHomePhabricator
People eopXD

eopXD (Yueh-Ting (eop) Chen)
Wandering Deer

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2021, 8:43 PM (62 w, 17 h)

Go go change the world!

Recent Activity
View All

Sat, May 21

eopXD added a comment to D124926: [LoopInterchange] New cost model for loop interchange.

There's some changes to lit tests. Most of them are minor. One change that applies to all tests is that I changed the target triple from "x86_64" to "aarch64" and added "-mcpu=tsv110" in the RUN lines.

Sat, May 21, 5:23 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 20

eopXD updated the diff for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

Rebase to latest main.

Fri, May 20, 12:18 AM · Restricted Project, Restricted Project

Thu, May 19

eopXD committed rGda201aa4242e: [RISCV][NFC] Remove `*=` operator for LMULType (authored by eopXD).
[RISCV][NFC] Remove `*=` operator for LMULType
Thu, May 19, 11:48 PM · Restricted Project, Restricted Project
eopXD closed D126042: [RISCV][NFC] Remove `*=` operator for LMULType.
Thu, May 19, 11:47 PM · Restricted Project, Restricted Project
eopXD added a reviewer for D126043: [LSR] Drop LSR solution if it is less profitable than baseline: Restricted Project.
Thu, May 19, 11:35 PM · Restricted Project, Restricted Project
eopXD added a reviewer for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V: Restricted Project.
Thu, May 19, 11:35 PM · Restricted Project, Restricted Project
eopXD added a reviewer for D125670: [LSR] Early exit for RateFormula when it is already losing: Restricted Project.
Thu, May 19, 11:35 PM · Restricted Project, Restricted Project
eopXD requested review of D126043: [LSR] Drop LSR solution if it is less profitable than baseline.
Thu, May 19, 11:34 PM · Restricted Project, Restricted Project
eopXD requested review of D126042: [RISCV][NFC] Remove `*=` operator for LMULType.
Thu, May 19, 11:24 PM · Restricted Project, Restricted Project

Mon, May 16

eopXD added a reviewer for D125670: [LSR] Early exit for RateFormula when it is already losing: Meinersbur.
Mon, May 16, 8:18 AM · Restricted Project, Restricted Project
Herald added a project to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution: Restricted Project.

This patch looks good to me.
I think we can rebase and land this?

Mon, May 16, 1:43 AM · Restricted Project
eopXD requested review of D125670: [LSR] Early exit for RateFormula when it is already losing.
Mon, May 16, 1:29 AM · Restricted Project, Restricted Project

Thu, May 12

eopXD updated the summary of D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.
Thu, May 12, 10:48 AM · Restricted Project, Restricted Project
eopXD updated subscribers of D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

@reames
Since you mentioned the LSR deficiency in your public note.
You may be interested with these new test cases for the RISC-V backend.

Thu, May 12, 10:47 AM · Restricted Project, Restricted Project

Sun, May 8

eopXD added inline comments to D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.
Sun, May 8, 4:49 AM · Restricted Project, Restricted Project
eopXD updated the diff for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

Update testcase:

  • add -mattr=+m for loop-strength-reduce-add-cheaper-than-mul.ll
  • run simplifycfg for loop-strength-reduce-ivusers.ll
Sun, May 8, 4:49 AM · Restricted Project, Restricted Project

Apr 16 2022

eopXD committed rG38ec33d6b9cf: [LSR] Update outdated comment (authored by eopXD).
[LSR] Update outdated comment
Apr 16 2022, 12:24 PM · Restricted Project, Restricted Project
eopXD added a comment to D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

gentle ping.

Apr 16 2022, 3:20 AM · Restricted Project, Restricted Project

Apr 10 2022

eopXD updated the diff for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

Update code.

  • Delete peephole optimization testcases of X86
  • Delete duplicate test case (since we are checking line-by-line)
  • Rename test cases
  • Add some descriptions into test cases
Apr 10 2022, 11:18 AM · Restricted Project, Restricted Project
eopXD committed rGc6e83f560f06: [X86] Remove dead code from test case (authored by eopXD).
[X86] Remove dead code from test case
Apr 10 2022, 9:24 AM · Restricted Project, Restricted Project
eopXD closed D123465: [X86] Remove dead code from test case.
Apr 10 2022, 9:24 AM · Restricted Project, Restricted Project
eopXD added a comment to D123465: [X86] Remove dead code from test case.

Ok, thanks.

Apr 10 2022, 9:23 AM · Restricted Project, Restricted Project
eopXD added reviewers for D123465: [X86] Remove dead code from test case: xbolva00, spatel.
Apr 10 2022, 8:32 AM · Restricted Project, Restricted Project
eopXD requested review of D123465: [X86] Remove dead code from test case.
Apr 10 2022, 8:31 AM · Restricted Project, Restricted Project

Apr 9 2022

eopXD updated the summary of D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.
Apr 9 2022, 12:03 PM · Restricted Project, Restricted Project
eopXD added reviewers for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V: jrtc27, frasercrmck.
Apr 9 2022, 12:02 PM · Restricted Project, Restricted Project
eopXD updated the summary of D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.
Apr 9 2022, 12:00 PM · Restricted Project, Restricted Project
eopXD updated the diff for D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.

Update code.

Apr 9 2022, 11:59 AM · Restricted Project, Restricted Project
eopXD requested review of D123458: [LSR][RISCV] Improve test coverage for LSR in RISC-V.
Apr 9 2022, 11:58 AM · Restricted Project, Restricted Project

Apr 4 2022

Herald added a project to D109661: [FunctionPropertiesAnalysis] Add `PreciseFunctionPropertiesAnalysis`: Restricted Project.
Apr 4 2022, 1:08 AM · Restricted Project, Restricted Project

Mar 8 2022

eopXD committed rG550b2eaaa6e4: [RISCV] Add combination crypto extensions in ISAInfo (authored by eopXD).
[RISCV] Add combination crypto extensions in ISAInfo
Mar 8 2022, 9:53 AM · Restricted Project
eopXD closed D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Mar 8 2022, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

eopXD updated the diff for D119530: [RISCV] Add combination crypto extensions in ISAInfo.

Rebase to latest main

Mar 7 2022, 7:45 PM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

eopXD added a comment to D119530: [RISCV] Add combination crypto extensions in ISAInfo.

Gentle ping

Feb 28 2022, 10:22 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

eopXD updated eopXD.
Feb 23 2022, 11:53 PM
eopXD added a comment to D119530: [RISCV] Add combination crypto extensions in ISAInfo.

Friendly ping @VincentWu ;)
Any comments to the latest response?

Feb 23 2022, 11:32 PM · Restricted Project, Restricted Project, Restricted Project
eopXD updated the diff for D119530: [RISCV] Add combination crypto extensions in ISAInfo.

Add test for clang.

Feb 23 2022, 11:27 PM · Restricted Project, Restricted Project, Restricted Project
eopXD added inline comments to D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics..
Feb 23 2022, 11:22 PM · Restricted Project, Restricted Project
eopXD added inline comments to D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics..
Feb 23 2022, 11:21 PM · Restricted Project, Restricted Project
eopXD committed rG8b62f19f27d4: [Driver][RISCV] Add missing rv64 test case (authored by eopXD).
[Driver][RISCV] Add missing rv64 test case
Feb 23 2022, 10:54 PM
eopXD closed D120297: [Driver][RISCV] Add missing rv64 test case.
Feb 23 2022, 10:53 PM · Restricted Project

Feb 21 2022

eopXD added inline comments to D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication.
Feb 21 2022, 7:21 PM · Restricted Project
eopXD requested review of D120297: [Driver][RISCV] Add missing rv64 test case.
Feb 21 2022, 7:20 PM · Restricted Project
eopXD added inline comments to D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 21 2022, 7:14 PM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2022

eopXD added a comment to D119210: [RISCV] Recover the implication between Zve* extensions and the V extension..

Thanks!

Feb 13 2022, 11:57 PM · Restricted Project, Restricted Project
eopXD added a comment to D119210: [RISCV] Recover the implication between Zve* extensions and the V extension..

Kindly reverse ping.
May you land this change?

Feb 13 2022, 11:25 PM · Restricted Project, Restricted Project
eopXD committed rG7f51a9e2730e: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after… (authored by eopXD).
[RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after…
Feb 13 2022, 9:05 PM
eopXD closed D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication.
Feb 13 2022, 9:05 PM · Restricted Project
eopXD updated the diff for D119530: [RISCV] Add combination crypto extensions in ISAInfo.

Address comment, reuse existing strings.

Feb 13 2022, 5:01 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2022

eopXD added inline comments to D115853: [RISCV][NFC] Move ilp32e/rv32e checks to AsmParser and TargetLowering.
Feb 11 2022, 6:20 AM · Restricted Project
eopXD updated the diff for D115853: [RISCV][NFC] Move ilp32e/rv32e checks to AsmParser and TargetLowering.

Rebase and add testcase.

Feb 11 2022, 6:09 AM · Restricted Project
eopXD updated the diff for D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication.

Add testcase.

Feb 11 2022, 5:31 AM · Restricted Project
eopXD retitled D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication from [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-isa features back after implication to [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication.
Feb 11 2022, 4:42 AM · Restricted Project
eopXD requested review of D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication.
Feb 11 2022, 4:42 AM · Restricted Project
eopXD added a comment to D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap.
In D113336#3313909, @junparser wrote:

@eopXD, hi, this patch make us lost +relax and -save-restore by default, would you please fix it?

Feb 11 2022, 4:04 AM · Restricted Project, Restricted Project
eopXD retitled D119530: [RISCV] Add combination crypto extensions in ISAInfo from [WIP][RISCV] Add combination crypto extensions in ISAInfo to [RISCV] Add combination crypto extensions in ISAInfo.
Feb 11 2022, 3:44 AM · Restricted Project, Restricted Project, Restricted Project
eopXD updated the diff for D119530: [RISCV] Add combination crypto extensions in ISAInfo.
  • Add zkn, zks
  • Follow clang-format
Feb 11 2022, 3:42 AM · Restricted Project, Restricted Project, Restricted Project
eopXD accepted D119210: [RISCV] Recover the implication between Zve* extensions and the V extension..

LGTM.
For the record the implication in this patch correspond to the note under v-spec:

Feb 11 2022, 3:30 AM · Restricted Project, Restricted Project
eopXD added a comment to D119530: [RISCV] Add combination crypto extensions in ISAInfo.

I will also add zkn, zks later.

Feb 11 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
eopXD retitled D119530: [RISCV] Add combination crypto extensions in ISAInfo from [RISCV] Add combination crypto extensions in ISAInfo to [WIP][RISCV] Add combination crypto extensions in ISAInfo.
Feb 11 2022, 2:02 AM · Restricted Project, Restricted Project, Restricted Project
eopXD retitled D119530: [RISCV] Add combination crypto extensions in ISAInfo from [RISCV] Add combination for ISAInfo - zkn, zkr, zkt -> zk to [RISCV] Add combination crypto extensions in ISAInfo.
Feb 11 2022, 1:55 AM · Restricted Project, Restricted Project, Restricted Project
eopXD requested review of D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 11 2022, 1:49 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2022

eopXD committed rG5f856c5b308e: [NFC][RISCV] Bundle up ISAInfo updates and checks (authored by eopXD).
[NFC][RISCV] Bundle up ISAInfo updates and checks
Jan 28 2022, 7:13 AM
eopXD closed D118334: [NFC][RISCV] Bundle up ISAInfo updates and checks.
Jan 28 2022, 7:13 AM · Restricted Project
eopXD updated the diff for D118334: [NFC][RISCV] Bundle up ISAInfo updates and checks.

Rebase.

Jan 28 2022, 3:29 AM · Restricted Project

Jan 27 2022

eopXD updated the diff for D118334: [NFC][RISCV] Bundle up ISAInfo updates and checks.

Rebase again, the test failure in past diff seems to be caused by other commits.

Jan 27 2022, 9:36 PM · Restricted Project
eopXD updated the diff for D118334: [NFC][RISCV] Bundle up ISAInfo updates and checks.

Update code. Try to encapsulate more.

Jan 27 2022, 1:38 AM · Restricted Project
eopXD requested review of D118334: [NFC][RISCV] Bundle up ISAInfo updates and checks.
Jan 27 2022, 1:20 AM · Restricted Project

Jan 26 2022

eopXD added a comment to D118225: [RISCV] Decouple Zve* extensions..

Not sure if this simplifies things. Users and the compiler can use the macro __riscv_v_elen and __riscv_v_elen_fp to do things to the vector-related target feature.

Jan 26 2022, 4:06 AM · Restricted Project, Restricted Project

Jan 25 2022

eopXD committed rG970a191203e6: [Clang][RISCV] Guard vmulh, vsmul correctly (authored by eopXD).
[Clang][RISCV] Guard vmulh, vsmul correctly
Jan 25 2022, 10:19 AM
eopXD closed D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.
Jan 25 2022, 10:19 AM · Restricted Project
eopXD committed rGb089e4072a01: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x (authored by eopXD).
[RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x
Jan 25 2022, 9:55 AM
eopXD closed D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.
Jan 25 2022, 9:55 AM · Restricted Project

Jan 24 2022

eopXD updated the diff for D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.

Update code dues to variable rename from new commits.

Jan 24 2022, 7:48 PM · Restricted Project
eopXD updated the diff for D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.

Rebase with no change, the buildbot halted.

Jan 24 2022, 7:42 PM · Restricted Project
eopXD updated the diff for D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Rebase with no change, the buildbot halted.

Jan 24 2022, 7:40 PM · Restricted Project
eopXD updated the summary of D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.
Jan 24 2022, 9:23 AM · Restricted Project
eopXD added inline comments to D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.
Jan 24 2022, 9:23 AM · Restricted Project
eopXD updated the diff for D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Undo comment moved and follow clang-format.

Jan 24 2022, 9:23 AM · Restricted Project
eopXD updated the diff for D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.

Rebase to latest main.

Jan 24 2022, 9:15 AM · Restricted Project
eopXD updated the diff for D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.

Update test case due to rebase.

Jan 24 2022, 9:14 AM · Restricted Project
eopXD committed rG6be77561f82d: [SLP][NFC] Add debug logs for entry. (authored by eopXD).
[SLP][NFC] Add debug logs for entry.
Jan 24 2022, 9:05 AM
eopXD closed D117980: [SLP][NFC] Add debug logs for entry..
Jan 24 2022, 9:05 AM · Restricted Project
eopXD added reviewers for D117980: [SLP][NFC] Add debug logs for entry.: ABataev, RKSimon, spatel.
Jan 24 2022, 8:47 AM · Restricted Project

Jan 23 2022

eopXD added a comment to D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Concluding the test case change:

Jan 23 2022, 10:45 PM · Restricted Project
eopXD updated the diff for D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Update test case.

Jan 23 2022, 10:35 PM · Restricted Project
eopXD updated the diff for D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Update comment.

Jan 23 2022, 10:31 PM · Restricted Project
eopXD updated the diff for D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.

Update test case.

Jan 23 2022, 10:24 PM · Restricted Project
eopXD added inline comments to D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.
Jan 23 2022, 10:05 PM · Restricted Project
eopXD updated the diff for D117913: [Clang][RISCV] Guard vmulh, vsmul correctly.

Rebase to latest main.

Jan 23 2022, 9:55 PM · Restricted Project
eopXD added inline comments to D117947: [RISCV] Don't allow i64 vector div by constant to use mulh with Zve64x.
Jan 23 2022, 9:54 PM · Restricted Project
eopXD added reviewers for D117982: [Doc][RFC][SLP] Add more description for SLP Vectorizer: nikic, lebedev.ri, fhahn.
Jan 23 2022, 4:16 AM · Restricted Project
eopXD updated the summary of D117982: [Doc][RFC][SLP] Add more description for SLP Vectorizer.
Jan 23 2022, 4:13 AM · Restricted Project
eopXD updated the summary of D117982: [Doc][RFC][SLP] Add more description for SLP Vectorizer.
Jan 23 2022, 4:12 AM · Restricted Project
eopXD added a comment to D117982: [Doc][RFC][SLP] Add more description for SLP Vectorizer.

You can preview the document here: https://github.com/eopXD/llvm-project/blob/doc/llvm/docs/Vectorizers.rst#the-slp-vectorizer

Jan 23 2022, 4:11 AM · Restricted Project
eopXD requested review of D117982: [Doc][RFC][SLP] Add more description for SLP Vectorizer.
Jan 23 2022, 4:10 AM · Restricted Project

Jan 22 2022

eopXD added a comment to D117980: [SLP][NFC] Add debug logs for entry..

I was trying out the SLP vectorizer and find that adding some hint will be helpful.

Jan 22 2022, 11:20 PM · Restricted Project
eopXD requested review of D117980: [SLP][NFC] Add debug logs for entry..
Jan 22 2022, 11:19 PM · Restricted Project
eopXD added inline comments to D117954: [RISCV] Add DAG combines to transform ADD_VL/SUB_VL into widening add/sub..
Jan 22 2022, 10:36 PM · Restricted Project
eopXD added inline comments to D117954: [RISCV] Add DAG combines to transform ADD_VL/SUB_VL into widening add/sub..
Jan 22 2022, 10:06 PM · Restricted Project