I code with good intention.
- User Since
- Mar 14 2021, 8:43 PM (106 w, 1 d)
Sun, Mar 26
Sat, Mar 25
Tue, Mar 21
I agree with @fhahn that such hook to a middle-end optimization like LSR is not a great approach. I have generally improving LSR term-fold and default enabling it as an item to my queue. I have the RVV intrinsics to be dealt with first but this will be the first thing I'll revisit once I am done there.
Sun, Mar 19
Tue, Mar 14
LGTM, please wait for another day so others can also check the patch.
CC-ing @reames, since he is the author of the FIXME.
I think the patch description should also include the added poison check. (and also remove the extra semicolon)
Thank you for looking into this! Some comments and I think we are good to go.
Thu, Mar 9
@loralb Just a heads up, I have a patch that will resolve the problem of disabling the vectorizer when interleave factor is 1. Haven't updated it in a while and hope I can land it before discussion here is converged.
Wed, Mar 1
We probably should do the same to HasRISCVVTypes and HasFloat16.
Feb 26 2023
Feb 23 2023
Thank you for the patch. May you explain how this would help support multi-versioning?
Feb 20 2023
Feb 18 2023
Feb 15 2023
Feb 14 2023
Feb 13 2023
Feb 11 2023
This change looks reasonable to me.
Address comment from Craig.
Feb 10 2023
Update code: use a more scalable way to check for RVV type.
Feb 9 2023
Update code based on comments from Craig.
Update code: check for experimental-zvfh instead of zvfh.
Update code: rename error for vector support, remove dead code under SemaRISCVVectorLoopup.cpp
Forward declaration (snippet below) is still allowed after this commit.
This was cherry-picked into the release branch of LLVM 16. Closing the patch.
Feb 2 2023
Feb 1 2023
Jan 31 2023
Address comment from Alex.
Update left-out test cases.
Update test case Sema/uninit-variables-riscv-vector.c.
Previous landing was reverted because of test case Clang :: Sema/uninit-variables-riscv-vector.c that was not updated, causing failure. Reopening to land this patch correctly.
Jan 28 2023
Jan 27 2023
Jan 26 2023
Update test case for vlenb.
As requested, @jrtc27 @kito-cheng, the patch does not alter the function name now.
Update code. Split the single patch into a patch-set of smaller steps.
Update code upon re-commit of D141796.
Re-commiting this now that the problem is resolved.
Update code. The removal of PolicyAttrs.IsUnspecified = false; under
This commit seems to cause riscv_vector_builtin_cg.inc to explode into a 630K file, which causes the out-of-memory build fail. Confirmed that this is the commit that is causing the error.
Rebase to latest main.
Reopening the revision to try land this correctly.
Hi @dyung and @DavidSpickett,