I code with good intention.
User Details
User Details
- User Since
- Mar 14 2021, 8:43 PM (106 w, 1 d)
Sun, Mar 26
Sun, Mar 26
eopXD added a comment to D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
Sat, Mar 25
Sat, Mar 25
eopXD updated the summary of D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types.
eopXD retitled D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type from [WIP][1/N][IR] Permit load/store/alloca for struct of the same scalable vector type to [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
eopXD retitled D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types from [POC][Clang][RISCV] Define RVV tuple types to [2/N][POC][Clang][RISCV] Define RVV tuple types.
eopXD updated the summary of D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
eopXD retitled D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type from [IR] Permit load/store/alloca for struct of the same scalable vector type to [WIP][1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
eopXD updated the summary of D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
eopXD updated the diff for D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types.
Update code.
eopXD updated the summary of D146872: [1/N][IR] Permit load/store/alloca for struct of the same scalable vector type.
eopXD requested review of D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types.
Tue, Mar 21
Tue, Mar 21
eopXD updated subscribers of D134893: [LSR][TTI][RISCV] Add isAllowTerminatingConditionFoldingAfterLSR into TTI and enable it for RISC-V.
I agree with @fhahn that such hook to a middle-end optimization like LSR is not a great approach. I have generally improving LSR term-fold and default enabling it as an item to my queue. I have the RVV intrinsics to be dealt with first but this will be the first thing I'll revisit once I am done there.
Sun, Mar 19
Sun, Mar 19
Tue, Mar 14
Tue, Mar 14
eopXD retitled D145929: [LSR] Fold terminating condition not only for eq and ne from [LSR]: Fold terminating condition not only for eq and ne. to [LSR] Fold terminating condition not only for eq and ne.
LGTM, please wait for another day so others can also check the patch.
eopXD added a comment to D145929: [LSR] Fold terminating condition not only for eq and ne.
CC-ing @reames, since he is the author of the FIXME.
eopXD added a reviewer for D145929: [LSR] Fold terminating condition not only for eq and ne: reames.
eopXD added a comment to D145929: [LSR] Fold terminating condition not only for eq and ne.
I think the patch description should also include the added poison check. (and also remove the extra semicolon)
eopXD added a comment to D145929: [LSR] Fold terminating condition not only for eq and ne.
Thank you for looking into this! Some comments and I think we are good to go.
Thu, Mar 9
Thu, Mar 9
eopXD added a comment to D143723: [RISCV] Increase default vectorizer LMUL to 2.
eopXD added a reviewer for D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer: Meinersbur.
eopXD added a comment to D143723: [RISCV] Increase default vectorizer LMUL to 2.
@loralb Just a heads up, I have a patch that will resolve the problem of disabling the vectorizer when interleave factor is 1. Haven't updated it in a while and hope I can land it before discussion here is converged.
Wed, Mar 1
Wed, Mar 1
eopXD added a comment to D145071: [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled.
We probably should do the same to HasRISCVVTypes and HasFloat16.
Wed, Mar 1, 8:19 AM · Restricted Project
Feb 26 2023
Feb 26 2023
eopXD added inline comments to D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion..
Feb 23 2023
Feb 23 2023
eopXD added a comment to D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion..
Thank you for the patch. May you explain how this would help support multi-versioning?
Feb 20 2023
Feb 20 2023
[TypeSize][NFC] Fix type-o
Feb 18 2023
Feb 18 2023
[Doc] Fix type-o under LangRef
Feb 15 2023
Feb 15 2023
eopXD committed rG5e815372480d: [Clang][RISCV] Sort test cases into its mnemonics (authored by eopXD).
[Clang][RISCV] Sort test cases into its mnemonics
eopXD requested review of D144147: [Clang][RISCV] Sort test cases into its mnemonics.
Feb 14 2023
Feb 14 2023
eopXD committed rG6e794ba0b238: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis (authored by eopXD).
[Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis
eopXD updated the diff for D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
Update code.
eopXD updated the diff for D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
Update code.
Feb 13 2023
Feb 13 2023
eopXD committed rG235e90c1d760: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis (authored by eopXD).
[Clang][RISCV] Guard vector float16 type correctly with semantic analysis
Feb 11 2023
Feb 11 2023
This change looks reasonable to me.
eopXD updated the diff for D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Address comment from Craig.
Feb 10 2023
Feb 10 2023
eopXD updated the diff for D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Update code: use a more scalable way to check for RVV type.
Feb 9 2023
Feb 9 2023
eopXD updated the diff for D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Update code based on comments from Craig.
eopXD added inline comments to D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
eopXD added inline comments to D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
eopXD updated the diff for D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
Bump CI.
eopXD updated the diff for D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Update code: check for experimental-zvfh instead of zvfh.
eopXD requested review of D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis.
eopXD updated the diff for D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Update code: rename error for vector support, remove dead code under SemaRISCVVectorLoopup.cpp
eopXD added a comment to D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
Forward declaration (snippet below) is still allowed after this commit.
eopXD added a comment to D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
eopXD retitled D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis from [Clang][RISCV] Guard vector float16 type correctly under Sema to [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
eopXD requested review of D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis.
This was cherry-picked into the release branch of LLVM 16. Closing the patch.
Feb 2 2023
Feb 2 2023
eopXD committed rGe685bde1e0b0: [Clang][RISCV] Bump rvv intrinsics version to v0.11 (authored by eopXD).
[Clang][RISCV] Bump rvv intrinsics version to v0.11
Feb 1 2023
Feb 1 2023
eopXD requested review of D143051: [Clang][RISCV] Bump rvv intrinsics version to v0.11.
Jan 31 2023
Jan 31 2023
eopXD retitled D142094: [Clang][Doc] Add release note for changes of the RVV intrinsics from [Clang][Doc] Add release note for changes for the RVV intrinsics to [Clang][Doc] Add release note for changes of the RVV intrinsics.
eopXD updated the diff for D142094: [Clang][Doc] Add release note for changes of the RVV intrinsics.
Address comment from Alex.
eopXD committed rG18888ec6c562: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics (authored by eopXD).
[3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics
eopXD updated the diff for D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics.
Update left-out test cases.
eopXD committed rG013c7d1f3a13: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics (authored by eopXD).
[2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics
eopXD updated the diff for D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics.
Update test case Sema/uninit-variables-riscv-vector.c.
Previous landing was reverted because of test case Clang :: Sema/uninit-variables-riscv-vector.c that was not updated, causing failure. Reopening to land this patch correctly.
eopXD committed rGa6f66d57e1d6: Revert "[2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics" (authored by eopXD).
Revert "[2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics"
eopXD committed rG2153544865a9: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics (authored by eopXD).
[2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics
eopXD committed rG54b40a1785e9: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and… (authored by eopXD).
[1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and…
Jan 28 2023
Jan 28 2023
eopXD committed rGd94a315ee3ec: [Clang][RISCV] Simplify RVV intrinsic policy suffix (authored by eopXD).
[Clang][RISCV] Simplify RVV intrinsic policy suffix
Jan 27 2023
Jan 27 2023
eopXD retitled D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics from [WIP][3/N][Clang][RISCV] Add `__riscv_` for overloaded intrinsics to [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics.
eopXD retitled D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics from [WIP][2/N][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics to [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics.
eopXD retitled D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax from [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax to [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax.
eopXD requested review of D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics.
eopXD updated the diff for D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics.
Add comment.
Jan 26 2023
Jan 26 2023
eopXD requested review of D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics.
eopXD updated the diff for D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax.
Update test case for vlenb.
eopXD retitled D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax from [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vsetvl, and vsetvlmax to [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax.
eopXD added a comment to D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax.
As requested, @jrtc27 @kito-cheng, the patch does not alter the function name now.
eopXD updated the diff for D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax.
Update code. Split the single patch into a patch-set of smaller steps.
eopXD retitled D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax from [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics to [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vsetvl, and vsetvlmax.
eopXD updated the diff for D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix.
Update code upon re-commit of D141796.
eopXD committed rG719a728b86a1: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants (authored by eopXD).
[15/15][Clang][RISCV][NFC] Set data member under Policy as constants
eopXD added a comment to D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
Re-commiting this now that the problem is resolved.
eopXD updated the diff for D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
Update code. The removal of PolicyAttrs.IsUnspecified = false; under
eopXD added a comment to D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
eopXD added a comment to D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
This commit seems to cause riscv_vector_builtin_cg.inc to explode into a 630K file, which causes the out-of-memory build fail. Confirmed that this is the commit that is causing the error.
eopXD updated the diff for D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
Rebase to latest main.
Reopening the revision to try land this correctly.
eopXD added a comment to D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.
Hi @dyung and @DavidSpickett,
Jan 24 2023
Jan 24 2023
eopXD committed rG2b807336ad38: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants (authored by eopXD).
[15/15][Clang][RISCV][NFC] Set data member under Policy as constants
eopXD committed rG84c8bbe95a8a: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA (authored by eopXD).
[14/15][Clang][RISCV] Change default policy from TAMU to TAMA
eopXD committed rGcaa61ccc8f99: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics… (authored by eopXD).
[13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics…
eopXD committed rG1a803e0b2ad7: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in… (authored by eopXD).
[12/15][Clang][RISCV][NFC] Refine the way to check for Policy in…