Page MenuHomePhabricator

edward-jones (Edward Jones)
Compiler Engineer at Embecosm

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 6:56 AM (216 w, 6 d)

Recent Activity

Mon, Oct 14

edward-jones added a comment to D68393: [RISCV] Add riscv{32,64} to ALL_CRT_SUPPORTED_ARCH list.

@edward-jones: what LLVM cmake options are you using to test this?

Mon, Oct 14, 5:56 AM · Restricted Project, Restricted Project

Fri, Oct 4

edward-jones added a reviewer for D68407: [RISCV] Use compiler-rt if no GCC installation detected: luismarques.
Fri, Oct 4, 6:47 AM · Restricted Project
edward-jones added reviewers for D68391: [RISCV] Improve sysroot computation if no GCC install detected: asb, luismarques.
Fri, Oct 4, 6:47 AM · Restricted Project
edward-jones added reviewers for D68393: [RISCV] Add riscv{32,64} to ALL_CRT_SUPPORTED_ARCH list: asb, luismarques.
Fri, Oct 4, 6:47 AM · Restricted Project, Restricted Project
edward-jones added a child revision for D68391: [RISCV] Improve sysroot computation if no GCC install detected: D68407: [RISCV] Use compiler-rt if no GCC installation detected.
Fri, Oct 4, 6:45 AM · Restricted Project
edward-jones added a parent revision for D68407: [RISCV] Use compiler-rt if no GCC installation detected: D68391: [RISCV] Improve sysroot computation if no GCC install detected.
Fri, Oct 4, 6:45 AM · Restricted Project
edward-jones updated the diff for D68407: [RISCV] Use compiler-rt if no GCC installation detected.

Rebased, updated tests from D68391 to check for existence of compiler-rt crtbegin/crtend and runtime library.

Fri, Oct 4, 6:45 AM · Restricted Project
edward-jones updated the diff for D68391: [RISCV] Improve sysroot computation if no GCC install detected.

Rebased and added tests

Fri, Oct 4, 6:42 AM · Restricted Project
edward-jones planned changes to D68391: [RISCV] Improve sysroot computation if no GCC install detected.

I'm reworking this at the moment and adding some tests. Standby!

Fri, Oct 4, 5:56 AM · Restricted Project

Thu, Oct 3

edward-jones added a comment to D68407: [RISCV] Use compiler-rt if no GCC installation detected.

Work in progress because this needs tests (and probably clang-format too).

Thu, Oct 3, 10:20 AM · Restricted Project
edward-jones created D68407: [RISCV] Use compiler-rt if no GCC installation detected.
Thu, Oct 3, 10:12 AM · Restricted Project
edward-jones committed rGf5177a7db48b: [RISCV] Add obsolete aliases of fscsr, frcsr (fssr, frsr) (authored by edward-jones).
[RISCV] Add obsolete aliases of fscsr, frcsr (fssr, frsr)
Thu, Oct 3, 8:47 AM
edward-jones updated the diff for D68392: [RISCV] Add obsolete aliases of fscsr, frcsr (fssr, frsr).

Added tests!

Thu, Oct 3, 7:59 AM · Restricted Project
edward-jones added a comment to D68391: [RISCV] Improve sysroot computation if no GCC install detected.

Before falling back to returning the empty string this first looks for a directory with the triple name up one level from the driver.

Thu, Oct 3, 7:35 AM · Restricted Project
edward-jones added a comment to D68392: [RISCV] Add obsolete aliases of fscsr, frcsr (fssr, frsr).

A comment on github by Andrew Waterman suggests that these aliases are expected to be supported by the tools even if they are obsolete. At the very least newlib still seems to use them.

Thu, Oct 3, 7:18 AM · Restricted Project
edward-jones created D68393: [RISCV] Add riscv{32,64} to ALL_CRT_SUPPORTED_ARCH list.
Thu, Oct 3, 7:13 AM · Restricted Project, Restricted Project
edward-jones created D68392: [RISCV] Add obsolete aliases of fscsr, frcsr (fssr, frsr).
Thu, Oct 3, 7:13 AM · Restricted Project
edward-jones created D68391: [RISCV] Improve sysroot computation if no GCC install detected.
Thu, Oct 3, 7:10 AM · Restricted Project

Sep 2 2019

edward-jones abandoned D64715: [WIP][RISCV] Use RISCV_32_PCREL reloc for FDE initial location.

Superceded by D66419

Sep 2 2019, 4:43 AM · Restricted Project

Aug 20 2019

edward-jones abandoned D63409: [RISCV] Specify various encodings for DWARF exception handling.

Abandoned since this was superceded by rL366327.

Aug 20 2019, 1:42 AM · Restricted Project

Aug 5 2019

edward-jones updated the diff for D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.

Rebase, and fix another test of FDE

Aug 5 2019, 9:04 AM · Restricted Project

Jul 16 2019

edward-jones added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.
In D63409#1587117, @asb wrote:

Hi Ed, this is really hard to review without any documentation in the psABI or otherwise. Can you confirm that you've verified this matches gcc/gas? Are you planning to submit document to riscv-elf-psabi-doc to reflect this?

Jul 16 2019, 4:53 AM · Restricted Project

Jul 15 2019

edward-jones added a comment to D64715: [WIP][RISCV] Use RISCV_32_PCREL reloc for FDE initial location.

Here's a link to the equivalent change made to GAS which should give more context (the commit has since be incorporated into upstream binutils):

Jul 15 2019, 4:27 AM · Restricted Project
edward-jones added inline comments to D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jul 15 2019, 4:06 AM · Restricted Project
edward-jones created D64715: [WIP][RISCV] Use RISCV_32_PCREL reloc for FDE initial location.
Jul 15 2019, 4:05 AM · Restricted Project

Jul 8 2019

edward-jones added a comment to D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.

I realize that I hadn't associated this change with D61584

Jul 8 2019, 9:01 AM · Restricted Project
edward-jones added a parent revision for D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs: D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jul 8 2019, 8:50 AM · Restricted Project
edward-jones added a child revision for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled.: D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.
Jul 8 2019, 8:50 AM · Restricted Project
edward-jones removed a parent revision for D63417: [RISCV] Specify registers used for exception handling: D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jul 8 2019, 8:49 AM · Restricted Project, Restricted Project
edward-jones removed a child revision for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled.: D63417: [RISCV] Specify registers used for exception handling.
Jul 8 2019, 8:49 AM · Restricted Project
edward-jones added a parent revision for D63417: [RISCV] Specify registers used for exception handling: D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jul 8 2019, 8:49 AM · Restricted Project, Restricted Project
edward-jones added a child revision for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled.: D63417: [RISCV] Specify registers used for exception handling.
Jul 8 2019, 8:49 AM · Restricted Project

Jul 3 2019

edward-jones added a comment to D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.

I'll look into changes that would need to be made to the psabi docs too.

Jul 3 2019, 5:46 AM · Restricted Project
edward-jones updated the diff for D63417: [RISCV] Specify registers used for exception handling.
Jul 3 2019, 5:43 AM · Restricted Project, Restricted Project
edward-jones updated the diff for D63411: [RISCV] Specify registers used in DWARF exception handling.

Added test, rebased.

Jul 3 2019, 5:41 AM · Restricted Project
edward-jones abandoned D63416: [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table.

Changes from this revision have been merged into D63415

Jul 3 2019, 5:41 AM · Restricted Project
edward-jones updated the diff for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.

Merged D63416 into this patch, rebased.

Jul 3 2019, 5:41 AM · Restricted Project
edward-jones updated the diff for D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.

Added test, rebased

Jul 3 2019, 5:29 AM · Restricted Project
edward-jones updated the diff for D63417: [RISCV] Specify registers used for exception handling.

Add riscv64 target run line, renamed test file to builtins-riscv.c, and rebased.

Jul 3 2019, 2:48 AM · Restricted Project, Restricted Project

Jun 27 2019

edward-jones accepted D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

LGTM now

Jun 27 2019, 8:19 AM · Restricted Project, Restricted Project

Jun 25 2019

edward-jones added a comment to D63411: [RISCV] Specify registers used in DWARF exception handling.
In D63411#1551719, @asb wrote:

Thanks for the patch! Do you have a reference for these being the appropriate values?

Jun 25 2019, 8:59 AM · Restricted Project
edward-jones added inline comments to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jun 25 2019, 8:06 AM · Restricted Project
edward-jones added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.

I think D63409, D63411, D63415, and D63416 could be merged as one patch. They are all related to exception handling for RISC-V.

Jun 25 2019, 6:54 AM · Restricted Project

Jun 19 2019

edward-jones added inline comments to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jun 19 2019, 7:03 AM · Restricted Project
edward-jones updated the diff for D63274: [RISCV] Avoid overflow when determining number of nops for code align.

Rebased

Jun 19 2019, 4:48 AM · Restricted Project
edward-jones updated the diff for D63285: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign().

Rebased

Jun 19 2019, 4:48 AM · Restricted Project
edward-jones planned changes to D23664: [AAP] (1) Add AAP target triple.
Jun 19 2019, 4:28 AM
edward-jones updated the diff for D63416: [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table.

Added tests, rebased

Jun 19 2019, 4:28 AM · Restricted Project
edward-jones updated the diff for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.

Rebased against master

Jun 19 2019, 4:26 AM · Restricted Project
edward-jones updated the diff for D63409: [RISCV] Specify various encodings for DWARF exception handling.

Added tests, rebased against master

Jun 19 2019, 4:25 AM · Restricted Project
edward-jones added a parent revision for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 19 2019, 4:25 AM · Restricted Project
edward-jones added a child revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jun 19 2019, 4:25 AM · Restricted Project
edward-jones removed a parent revision for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 19 2019, 4:22 AM · Restricted Project
edward-jones added a parent revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 19 2019, 4:22 AM · Restricted Project
edward-jones edited child revisions for D63411: [RISCV] Specify registers used in DWARF exception handling, added: 1; removed: 1.
Jun 19 2019, 4:22 AM · Restricted Project
edward-jones updated the diff for D63411: [RISCV] Specify registers used in DWARF exception handling.

Rebased against master

Jun 19 2019, 4:22 AM · Restricted Project
edward-jones removed a child revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 19 2019, 4:22 AM · Restricted Project
edward-jones removed a parent revision for D63411: [RISCV] Specify registers used in DWARF exception handling: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 19 2019, 4:22 AM · Restricted Project
edward-jones updated the diff for D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.

Rebased against master

Jun 19 2019, 4:22 AM · Restricted Project
edward-jones updated the diff for D63417: [RISCV] Specify registers used for exception handling.

Added tests

Jun 19 2019, 4:20 AM · Restricted Project, Restricted Project

Jun 17 2019

edward-jones added a parent revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63417: [RISCV] Specify registers used for exception handling.
Jun 17 2019, 10:07 AM · Restricted Project
edward-jones added a child revision for D63417: [RISCV] Specify registers used for exception handling: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 17 2019, 10:07 AM · Restricted Project, Restricted Project
edward-jones removed a child revision for D63411: [RISCV] Specify registers used in DWARF exception handling: D63417: [RISCV] Specify registers used for exception handling.
Jun 17 2019, 10:07 AM · Restricted Project
edward-jones removed a parent revision for D63417: [RISCV] Specify registers used for exception handling: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 10:07 AM · Restricted Project, Restricted Project
edward-jones added a comment to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

Since CFI emission has been added this probably needs to be rebased. I don't think CFI should materially affect the implementation though.

Jun 17 2019, 8:31 AM · Restricted Project, Restricted Project
edward-jones added a parent revision for D63417: [RISCV] Specify registers used for exception handling: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 4:58 AM · Restricted Project, Restricted Project
edward-jones added a child revision for D63411: [RISCV] Specify registers used in DWARF exception handling: D63417: [RISCV] Specify registers used for exception handling.
Jun 17 2019, 4:58 AM · Restricted Project
edward-jones added a parent revision for D63416: [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table: D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jun 17 2019, 4:58 AM · Restricted Project
edward-jones added a child revision for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable: D63416: [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table.
Jun 17 2019, 4:58 AM · Restricted Project
edward-jones added a parent revision for D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 4:55 AM · Restricted Project
edward-jones added a child revision for D63411: [RISCV] Specify registers used in DWARF exception handling: D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jun 17 2019, 4:55 AM · Restricted Project
edward-jones added a child revision for D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 17 2019, 4:54 AM · Restricted Project
edward-jones added a parent revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.
Jun 17 2019, 4:54 AM · Restricted Project
edward-jones created D63417: [RISCV] Specify registers used for exception handling.
Jun 17 2019, 4:54 AM · Restricted Project, Restricted Project
edward-jones created D63416: [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table.
Jun 17 2019, 4:50 AM · Restricted Project
edward-jones created D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jun 17 2019, 4:50 AM · Restricted Project
edward-jones updated the summary of D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 4:46 AM · Restricted Project
edward-jones added a parent revision for D63411: [RISCV] Specify registers used in DWARF exception handling: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 17 2019, 4:44 AM · Restricted Project
edward-jones added a child revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 4:44 AM · Restricted Project
edward-jones created D63411: [RISCV] Specify registers used in DWARF exception handling.
Jun 17 2019, 4:42 AM · Restricted Project
edward-jones added a parent revision for D63409: [RISCV] Specify various encodings for DWARF exception handling: D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jun 17 2019, 4:40 AM · Restricted Project
edward-jones added a child revision for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled.: D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 17 2019, 4:40 AM · Restricted Project
edward-jones created D63409: [RISCV] Specify various encodings for DWARF exception handling.
Jun 17 2019, 4:38 AM · Restricted Project
edward-jones created D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.
Jun 17 2019, 4:32 AM · Restricted Project

Jun 13 2019

edward-jones added a parent revision for D63274: [RISCV] Avoid overflow when determining number of nops for code align: D63285: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign().
Jun 13 2019, 10:37 AM · Restricted Project
edward-jones added a child revision for D63285: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign(): D63274: [RISCV] Avoid overflow when determining number of nops for code align.
Jun 13 2019, 10:37 AM · Restricted Project
edward-jones updated the diff for D63274: [RISCV] Avoid overflow when determining number of nops for code align.

Incorporated Lewis' suggested fix.

Jun 13 2019, 10:34 AM · Restricted Project
edward-jones created D63285: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign().
Jun 13 2019, 10:28 AM · Restricted Project
edward-jones created D63274: [RISCV] Avoid overflow when determining number of nops for code align.
Jun 13 2019, 8:00 AM · Restricted Project

Mar 14 2019

edward-jones added a comment to D58896: Suppress -Wchar-subscripts if the index is a literal char.

Do you have some evidence that the current behavior is causing a lot of false positives in the wild? For ASCII character literals, I can sort of guess at why people might want to do this, but for things like wide character literals, or character literals relying on the current code page, etc, I'm less convinced.

Mar 14 2019, 3:02 AM · Restricted Project

Mar 4 2019

edward-jones added a reviewer for D58896: Suppress -Wchar-subscripts if the index is a literal char: aaron.ballman.
Mar 4 2019, 2:39 AM · Restricted Project
edward-jones created D58896: Suppress -Wchar-subscripts if the index is a literal char.
Mar 4 2019, 2:35 AM · Restricted Project

Oct 22 2018

edward-jones updated the diff for D53392: [RISCV] Collect library directories and triples for riscv64 triple too.
Oct 22 2018, 1:21 AM · Restricted Project
edward-jones updated the diff for D53392: [RISCV] Collect library directories and triples for riscv64 triple too.

I've incorporated your suggested changes and added riscv32/64-linux-gnu entrys to the Triple + LibDirs lists.

Oct 22 2018, 1:17 AM · Restricted Project

Oct 18 2018

edward-jones created D53392: [RISCV] Collect library directories and triples for riscv64 triple too.
Oct 18 2018, 5:37 AM · Restricted Project

May 31 2018

edward-jones updated the diff for D45773: [RISCV] Don't fold symbol diff.

Updated to incorporate Alex's suggestion - keeping absoluteSymbolDiff static

May 31 2018, 7:31 AM

May 23 2018

edward-jones added a comment to D45773: [RISCV] Don't fold symbol diff.
In D45773#1109391, @asb wrote:

What did you think about keeping absoluteSymbolDiff as static and updating the callsites?

May 23 2018, 8:18 AM

May 14 2018

edward-jones updated the diff for D45773: [RISCV] Don't fold symbol diff.
May 14 2018, 2:27 AM

May 1 2018

edward-jones updated the diff for D45773: [RISCV] Don't fold symbol diff.

Added a test

May 1 2018, 1:38 AM

Apr 30 2018

edward-jones added a comment to D45773: [RISCV] Don't fold symbol diff.

Working on creating a test at the moment, however while trying to create a test I realized this change doesn't actually work when using llc to generate an object file. It seems that when compiling with llc, the RISCV::FeatureRelax bit is never set, so RISCV::requiresDiffExpressionRelocations always returns false. This happens even with "target-features"="+relax" in the function attributes.

Apr 30 2018, 9:16 AM