This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang/
-
docs/
1/2
ReleaseNotes.rst
-
lib/Sema/
-
Sema/
-
SemaExpr.cpp
-
test/
-
AST/Interp/
-
Interp/
-
constexpr-nqueens.cpp
-
literals.cpp
-
Analysis/
-
copypaste/
-
macro-complexity.cpp
-
cxx-uninitialized-object-unguarded-access.cpp
-
malloc-overflow.c
-
misc-ps.m
-
nullability.mm
-
runtime-regression.c
-
uninit-vals.c
-
use-after-move.cpp
-
CXX/temp/temp.decls/temp.variadic/
-
temp/
-
temp.decls/
-
temp.variadic/
-
partial-ordering.cpp
-
Frontend/
-
macros.c
-
OpenMP/
-
cancel_if_messages.cpp
-
distribute_collapse_messages.cpp
-
distribute_dist_schedule_messages.cpp
-
distribute_firstprivate_messages.cpp
-
distribute_parallel_for_collapse_messages.cpp
-
distribute_parallel_for_copyin_messages.cpp
-
distribute_parallel_for_dist_schedule_messages.cpp
-
distribute_parallel_for_firstprivate_messages.cpp
-
distribute_parallel_for_if_messages.cpp
-
distribute_parallel_for_lastprivate_messages.cpp
-
distribute_parallel_for_num_threads_messages.cpp
-
distribute_parallel_for_private_messages.cpp
-
distribute_parallel_for_reduction_messages.cpp
-
distribute_parallel_for_schedule_messages.cpp
-
distribute_parallel_for_shared_messages.cpp
-
distribute_parallel_for_simd_aligned_messages.cpp
-
distribute_parallel_for_simd_collapse_messages.cpp
-
distribute_parallel_for_simd_copyin_messages.cpp
-
distribute_parallel_for_simd_dist_schedule_messages.cpp
-
distribute_parallel_for_simd_firstprivate_messages.cpp
-
distribute_parallel_for_simd_if_messages.cpp
-
distribute_parallel_for_simd_lastprivate_messages.cpp
-
distribute_parallel_for_simd_linear_messages.cpp
-
distribute_parallel_for_simd_num_threads_messages.cpp
-
distribute_parallel_for_simd_private_messages.cpp
-
distribute_parallel_for_simd_reduction_messages.cpp
-
distribute_parallel_for_simd_safelen_messages.cpp
-
distribute_parallel_for_simd_schedule_messages.cpp
-
distribute_parallel_for_simd_shared_messages.cpp
-
distribute_parallel_for_simd_simdlen_messages.cpp
-
distribute_private_messages.cpp
-
distribute_simd_aligned_messages.cpp
-
distribute_simd_collapse_messages.cpp
-
distribute_simd_dist_schedule_messages.cpp
-
distribute_simd_firstprivate_messages.cpp
-
distribute_simd_if_messages.cpp
-
distribute_simd_lastprivate_messages.cpp
-
distribute_simd_linear_messages.cpp
-
distribute_simd_private_messages.cpp
-
distribute_simd_reduction_messages.cpp
-
distribute_simd_safelen_messages.cpp
-
distribute_simd_simdlen_messages.cpp
-
for_collapse_messages.cpp
-
for_firstprivate_messages.cpp
-
for_lastprivate_messages.cpp
-
for_linear_messages.cpp
-
for_ordered_clause.cpp
-
for_private_messages.cpp
-
for_reduction_messages.cpp
-
for_schedule_messages.cpp
-
for_simd_aligned_messages.cpp
-
for_simd_collapse_messages.cpp
-
for_simd_firstprivate_messages.cpp
-
for_simd_if_messages.cpp
-
for_simd_lastprivate_messages.cpp
-
for_simd_linear_messages.cpp
-
for_simd_private_messages.cpp
-
for_simd_reduction_messages.cpp
-
for_simd_safelen_messages.cpp
-
for_simd_schedule_messages.cpp
-
for_simd_simdlen_messages.cpp
-
masked_taskloop_collapse_messages.cpp
-
masked_taskloop_final_messages.cpp
-
masked_taskloop_firstprivate_messages.cpp
-
masked_taskloop_grainsize_messages.cpp
-
masked_taskloop_in_reduction_messages.cpp
-
masked_taskloop_lastprivate_messages.cpp
-
masked_taskloop_num_tasks_messages.cpp
-
masked_taskloop_priority_messages.cpp
-
masked_taskloop_private_messages.cpp
-
masked_taskloop_simd_aligned_messages.cpp
-
masked_taskloop_simd_collapse_messages.cpp
-
masked_taskloop_simd_final_messages.cpp
-
masked_taskloop_simd_firstprivate_messages.cpp
-
masked_taskloop_simd_grainsize_messages.cpp
-
masked_taskloop_simd_in_reduction_messages.cpp
-
masked_taskloop_simd_lastprivate_messages.cpp
-
masked_taskloop_simd_linear_messages.cpp
-
masked_taskloop_simd_num_tasks_messages.cpp
-
masked_taskloop_simd_priority_messages.cpp
-
masked_taskloop_simd_private_messages.cpp
-
masked_taskloop_simd_reduction_messages.cpp
-
masked_taskloop_simd_safelen_messages.cpp
-
masked_taskloop_simd_simdlen_messages.cpp
-
master_taskloop_collapse_messages.cpp
-
master_taskloop_final_messages.cpp
-
master_taskloop_firstprivate_messages.cpp
-
master_taskloop_grainsize_messages.cpp
-
master_taskloop_in_reduction_messages.cpp
-
master_taskloop_lastprivate_messages.cpp
-
master_taskloop_num_tasks_messages.cpp
-
master_taskloop_priority_messages.cpp
-
master_taskloop_private_messages.cpp
-
master_taskloop_reduction_messages.cpp
-
master_taskloop_simd_aligned_messages.cpp
-
master_taskloop_simd_collapse_messages.cpp
-
master_taskloop_simd_final_messages.cpp
-
master_taskloop_simd_firstprivate_messages.cpp
-
master_taskloop_simd_grainsize_messages.cpp
-
master_taskloop_simd_in_reduction_messages.cpp
-
master_taskloop_simd_lastprivate_messages.cpp
-
master_taskloop_simd_linear_messages.cpp
-
master_taskloop_simd_num_tasks_messages.cpp
-
master_taskloop_simd_priority_messages.cpp
-
master_taskloop_simd_private_messages.cpp
-
master_taskloop_simd_reduction_messages.cpp
-
master_taskloop_simd_safelen_messages.cpp
-
master_taskloop_simd_simdlen_messages.cpp
-
parallel_copyin_messages.cpp
-
parallel_firstprivate_messages.cpp
-
parallel_for_collapse_messages.cpp
-
parallel_for_copyin_messages.cpp
-
parallel_for_firstprivate_messages.cpp
-
parallel_for_if_messages.cpp
-
parallel_for_lastprivate_messages.cpp
-
parallel_for_linear_messages.cpp
-
parallel_for_num_threads_messages.cpp
-
parallel_for_ordered_messages.cpp
-
parallel_for_private_messages.cpp
-
parallel_for_reduction_messages.cpp
-
parallel_for_schedule_messages.cpp
-
parallel_for_simd_aligned_messages.cpp
-
parallel_for_simd_collapse_messages.cpp
-
parallel_for_simd_copyin_messages.cpp
-
parallel_for_simd_firstprivate_messages.cpp
-
parallel_for_simd_if_messages.cpp
-
parallel_for_simd_lastprivate_messages.cpp
-
parallel_for_simd_linear_messages.cpp
-
parallel_for_simd_num_threads_messages.cpp
-
parallel_for_simd_private_messages.cpp
-
parallel_for_simd_reduction_messages.cpp
-
parallel_for_simd_safelen_messages.cpp
-
parallel_for_simd_schedule_messages.cpp
-
parallel_for_simd_simdlen_messages.cpp
-
parallel_if_messages.cpp
-
parallel_masked_copyin_messages.cpp
-
parallel_masked_firstprivate_messages.cpp
-
parallel_masked_if_messages.cpp
-
parallel_masked_num_threads_messages.cpp
-
parallel_masked_private_messages.cpp
-
parallel_masked_reduction_messages.cpp
-
parallel_masked_shared_messages.cpp
-
parallel_masked_taskloop_collapse_messages.cpp
-
parallel_masked_taskloop_final_messages.cpp
-
parallel_masked_taskloop_firstprivate_messages.cpp
-
parallel_masked_taskloop_grainsize_messages.cpp
-
parallel_masked_taskloop_lastprivate_messages.cpp
-
parallel_masked_taskloop_num_tasks_messages.cpp
-
parallel_masked_taskloop_priority_messages.cpp
-
parallel_masked_taskloop_private_messages.cpp
-
parallel_masked_taskloop_reduction_messages.cpp
-
parallel_masked_taskloop_simd_aligned_messages.cpp
-
parallel_masked_taskloop_simd_collapse_messages.cpp
-
parallel_masked_taskloop_simd_final_messages.cpp
-
parallel_masked_taskloop_simd_firstprivate_messages.cpp
-
parallel_masked_taskloop_simd_grainsize_messages.cpp
-
parallel_masked_taskloop_simd_lastprivate_messages.cpp
-
parallel_masked_taskloop_simd_linear_messages.cpp
-
parallel_masked_taskloop_simd_num_tasks_messages.cpp
-
parallel_masked_taskloop_simd_priority_messages.cpp
-
parallel_masked_taskloop_simd_private_messages.cpp
-
parallel_masked_taskloop_simd_reduction_messages.cpp
-
parallel_masked_taskloop_simd_safelen_messages.cpp
-
parallel_masked_taskloop_simd_simdlen_messages.cpp
-
parallel_master_copyin_messages.cpp
-
parallel_master_firstprivate_messages.cpp
-
parallel_master_if_messages.cpp
-
parallel_master_num_threads_messages.cpp
-
parallel_master_private_messages.cpp
-
parallel_master_reduction_messages.cpp
-
parallel_master_shared_messages.cpp
-
parallel_master_taskloop_collapse_messages.cpp
-
parallel_master_taskloop_final_messages.cpp
-
parallel_master_taskloop_firstprivate_messages.cpp
-
parallel_master_taskloop_grainsize_messages.cpp
-
parallel_master_taskloop_lastprivate_messages.cpp
-
parallel_master_taskloop_num_tasks_messages.cpp
-
parallel_master_taskloop_priority_messages.cpp
-
parallel_master_taskloop_private_messages.cpp
-
parallel_master_taskloop_reduction_messages.cpp
-
parallel_master_taskloop_simd_aligned_messages.cpp
-
parallel_master_taskloop_simd_collapse_messages.cpp
-
parallel_master_taskloop_simd_final_messages.cpp
-
parallel_master_taskloop_simd_firstprivate_messages.cpp
-
parallel_master_taskloop_simd_grainsize_messages.cpp
-
parallel_master_taskloop_simd_lastprivate_messages.cpp
-
parallel_master_taskloop_simd_linear_messages.cpp
-
parallel_master_taskloop_simd_num_tasks_messages.cpp
-
parallel_master_taskloop_simd_priority_messages.cpp
-
parallel_master_taskloop_simd_private_messages.cpp
-
parallel_master_taskloop_simd_reduction_messages.cpp
-
parallel_master_taskloop_simd_safelen_messages.cpp
-
parallel_master_taskloop_simd_simdlen_messages.cpp
-
parallel_num_threads_messages.cpp
-
parallel_private_messages.cpp
-
parallel_reduction_messages.cpp
-
parallel_sections_copyin_messages.cpp
-
parallel_sections_firstprivate_messages.cpp
-
parallel_sections_if_messages.cpp
-
parallel_sections_lastprivate_messages.cpp
-
parallel_sections_num_threads_messages.cpp
-
parallel_sections_private_messages.cpp
-
parallel_sections_reduction_messages.cpp
-
parallel_sections_shared_messages.cpp
-
parallel_shared_messages.cpp
-
sections_firstprivate_messages.cpp
-
sections_lastprivate_messages.cpp
-
sections_private_messages.cpp
-
sections_reduction_messages.cpp
-
simd_aligned_messages.cpp
-
simd_collapse_messages.cpp
-
simd_if_messages.cpp
-
simd_lastprivate_messages.cpp
-
simd_linear_messages.cpp
-
simd_private_messages.cpp
-
simd_reduction_messages.cpp
-
simd_safelen_messages.cpp
-
simd_simdlen_messages.cpp
-
single_copyprivate_messages.cpp
-
single_firstprivate_messages.cpp
-
single_private_messages.cpp
-
target_data_device_messages.cpp
-
target_data_if_messages.cpp
-
target_device_messages.cpp
-
target_enter_data_device_messages.cpp
-
target_enter_data_if_messages.cpp
-
target_exit_data_device_messages.cpp
-
target_exit_data_if_messages.cpp
-
target_firstprivate_messages.cpp
-
target_if_messages.cpp
-
target_map_messages.cpp
-
target_ompx_dyn_cgroup_mem_messages.cpp
-
target_parallel_device_messages.cpp
-
target_parallel_firstprivate_messages.cpp
-
target_parallel_for_collapse_messages.cpp
-
target_parallel_for_device_messages.cpp
-
target_parallel_for_firstprivate_messages.cpp
-
target_parallel_for_if_messages.cpp
-
target_parallel_for_lastprivate_messages.cpp
-
target_parallel_for_linear_messages.cpp
-
target_parallel_for_map_messages.cpp
-
target_parallel_for_num_threads_messages.cpp
-
target_parallel_for_ordered_messages.cpp
-
target_parallel_for_private_messages.cpp
-
target_parallel_for_reduction_messages.cpp
-
target_parallel_for_schedule_messages.cpp
-
target_parallel_for_simd_aligned_messages.cpp
-
target_parallel_for_simd_collapse_messages.cpp
-
target_parallel_for_simd_device_messages.cpp
-
target_parallel_for_simd_firstprivate_messages.cpp
-
target_parallel_for_simd_if_messages.cpp
-
target_parallel_for_simd_lastprivate_messages.cpp
-
target_parallel_for_simd_linear_messages.cpp
-
target_parallel_for_simd_map_messages.cpp
-
target_parallel_for_simd_num_threads_messages.cpp
-
target_parallel_for_simd_ordered_messages.cpp
-
target_parallel_for_simd_private_messages.cpp
-
target_parallel_for_simd_reduction_messages.cpp
-
target_parallel_for_simd_safelen_messages.cpp
-
target_parallel_for_simd_schedule_messages.cpp
-
target_parallel_for_simd_simdlen_messages.cpp
-
target_parallel_if_messages.cpp
-
target_parallel_map_messages.cpp
-
target_parallel_num_threads_messages.cpp
-
target_parallel_private_messages.cpp
-
target_parallel_reduction_messages.cpp
-
target_parallel_shared_messages.cpp
-
target_private_messages.cpp
-
target_reduction_messages.cpp
-
target_simd_aligned_messages.cpp
-
target_simd_collapse_messages.cpp
-
target_simd_device_messages.cpp
-
target_simd_firstprivate_messages.cpp
-
target_simd_if_messages.cpp
-
target_simd_lastprivate_messages.cpp
-
target_simd_linear_messages.cpp
-
target_simd_map_messages.cpp
-
target_simd_private_messages.cpp
-
target_simd_reduction_messages.cpp
-
target_simd_safelen_messages.cpp
-
target_simd_simdlen_messages.cpp
-
target_teams_device_messages.cpp
-
target_teams_distribute_collapse_messages.cpp
-
target_teams_distribute_device_messages.cpp
-
target_teams_distribute_dist_schedule_messages.cpp
-
target_teams_distribute_firstprivate_messages.cpp
-
target_teams_distribute_if_messages.cpp
-
target_teams_distribute_lastprivate_messages.cpp
-
target_teams_distribute_map_messages.cpp
-
target_teams_distribute_num_teams_messages.cpp
-
target_teams_distribute_parallel_for_collapse_messages.cpp
-
target_teams_distribute_parallel_for_device_messages.cpp
-
target_teams_distribute_parallel_for_dist_schedule_messages.cpp
-
target_teams_distribute_parallel_for_firstprivate_messages.cpp
-
target_teams_distribute_parallel_for_if_messages.cpp
-
target_teams_distribute_parallel_for_lastprivate_messages.cpp
-
target_teams_distribute_parallel_for_map_messages.cpp
-
target_teams_distribute_parallel_for_num_teams_messages.cpp
-
target_teams_distribute_parallel_for_num_threads_messages.cpp
-
target_teams_distribute_parallel_for_private_messages.cpp
-
target_teams_distribute_parallel_for_reduction_messages.cpp
-
target_teams_distribute_parallel_for_schedule_messages.cpp
-
target_teams_distribute_parallel_for_shared_messages.cpp
-
target_teams_distribute_parallel_for_simd_aligned_messages.cpp
-
target_teams_distribute_parallel_for_simd_collapse_messages.cpp
-
target_teams_distribute_parallel_for_simd_device_messages.cpp
-
target_teams_distribute_parallel_for_simd_dist_schedule_messages.cpp
-
target_teams_distribute_parallel_for_simd_firstprivate_messages.cpp
-
target_teams_distribute_parallel_for_simd_if_messages.cpp
-
target_teams_distribute_parallel_for_simd_lastprivate_messages.cpp
-
target_teams_distribute_parallel_for_simd_linear_messages.cpp
-
target_teams_distribute_parallel_for_simd_map_messages.cpp
-
target_teams_distribute_parallel_for_simd_num_teams_messages.cpp
-
target_teams_distribute_parallel_for_simd_num_threads_messages.cpp
-
target_teams_distribute_parallel_for_simd_private_messages.cpp
-
target_teams_distribute_parallel_for_simd_reduction_messages.cpp
-
target_teams_distribute_parallel_for_simd_safelen_messages.cpp
-
target_teams_distribute_parallel_for_simd_schedule_messages.cpp
-
target_teams_distribute_parallel_for_simd_shared_messages.cpp
-
target_teams_distribute_parallel_for_simd_simdlen_messages.cpp
-
target_teams_distribute_parallel_for_simd_thread_limit_messages.cpp
-
target_teams_distribute_parallel_for_thread_limit_messages.cpp
-
target_teams_distribute_private_messages.cpp
-
target_teams_distribute_reduction_messages.cpp
-
target_teams_distribute_shared_messages.cpp
-
target_teams_distribute_simd_aligned_messages.cpp
-
target_teams_distribute_simd_collapse_messages.cpp
-
target_teams_distribute_simd_device_messages.cpp
-
target_teams_distribute_simd_dist_schedule_messages.cpp
-
target_teams_distribute_simd_firstprivate_messages.cpp
-
target_teams_distribute_simd_if_messages.cpp
-
target_teams_distribute_simd_lastprivate_messages.cpp
-
target_teams_distribute_simd_linear_messages.cpp
-
target_teams_distribute_simd_map_messages.cpp
-
target_teams_distribute_simd_num_teams_messages.cpp
-
target_teams_distribute_simd_private_messages.cpp
-
target_teams_distribute_simd_reduction_messages.cpp
-
target_teams_distribute_simd_safelen_messages.cpp
-
target_teams_distribute_simd_shared_messages.cpp
-
target_teams_distribute_simd_simdlen_messages.cpp
-
target_teams_distribute_simd_thread_limit_messages.cpp
-
target_teams_firstprivate_messages.cpp
-
target_teams_if_messages.cpp
-
target_teams_map_messages.cpp
-
target_teams_num_teams_messages.cpp
-
target_teams_private_messages.cpp
-
target_teams_reduction_messages.cpp
-
target_teams_shared_messages.cpp
-
target_teams_thread_limit_messages.cpp
-
target_update_device_messages.cpp
-
target_update_from_messages.cpp
-
target_update_if_messages.cpp
-
target_update_to_messages.cpp
-
target_uses_allocators_messages.cpp
-
task_final_messages.cpp
-
task_firstprivate_messages.cpp
-
task_if_messages.cpp
-
task_in_reduction_message.cpp
-
task_priority_messages.cpp
-
task_private_messages.cpp
-
task_shared_messages.cpp
-
taskgroup_task_reduction_messages.cpp
-
taskloop_collapse_messages.cpp
-
taskloop_final_messages.cpp
-
taskloop_firstprivate_messages.cpp
-
taskloop_grainsize_messages.cpp
-
taskloop_in_reduction_messages.cpp
-
taskloop_lastprivate_messages.cpp
-
taskloop_num_tasks_messages.cpp
-
taskloop_priority_messages.cpp
-
taskloop_private_messages.cpp
-
taskloop_reduction_messages.cpp
-
taskloop_simd_aligned_messages.cpp
-
taskloop_simd_collapse_messages.cpp
-
taskloop_simd_final_messages.cpp
-
taskloop_simd_firstprivate_messages.cpp
-
taskloop_simd_grainsize_messages.cpp
-
taskloop_simd_in_reduction_messages.cpp
-
taskloop_simd_lastprivate_messages.cpp
-
taskloop_simd_linear_messages.cpp
-
taskloop_simd_num_tasks_messages.cpp
-
taskloop_simd_priority_messages.cpp
-
taskloop_simd_private_messages.cpp
-
taskloop_simd_reduction_messages.cpp
-
taskloop_simd_safelen_messages.cpp
-
taskloop_simd_simdlen_messages.cpp
-
teams_distribute_collapse_messages.cpp
-
teams_distribute_dist_schedule_messages.cpp
-
teams_distribute_firstprivate_messages.cpp
-
teams_distribute_lastprivate_messages.cpp
-
teams_distribute_num_teams_messages.cpp
-
teams_distribute_parallel_for_collapse_messages.cpp
-
teams_distribute_parallel_for_copyin_messages.cpp
-
teams_distribute_parallel_for_dist_schedule_messages.cpp
-
teams_distribute_parallel_for_firstprivate_messages.cpp
-
teams_distribute_parallel_for_if_messages.cpp
-
teams_distribute_parallel_for_lastprivate_messages.cpp
-
teams_distribute_parallel_for_num_teams_messages.cpp
-
teams_distribute_parallel_for_private_messages.cpp
-
teams_distribute_parallel_for_reduction_messages.cpp
-
teams_distribute_parallel_for_schedule_messages.cpp
-
teams_distribute_parallel_for_shared_messages.cpp
-
teams_distribute_parallel_for_simd_aligned_messages.cpp
-
teams_distribute_parallel_for_simd_collapse_messages.cpp
-
teams_distribute_parallel_for_simd_dist_schedule_messages.cpp
-
teams_distribute_parallel_for_simd_firstprivate_messages.cpp
-
teams_distribute_parallel_for_simd_if_messages.cpp
-
teams_distribute_parallel_for_simd_lastprivate_messages.cpp
-
teams_distribute_parallel_for_simd_linear_messages.cpp
-
teams_distribute_parallel_for_simd_num_teams_messages.cpp
-
teams_distribute_parallel_for_simd_num_teams_messages_attr.cpp
-
teams_distribute_parallel_for_simd_num_threads_messages.cpp
-
teams_distribute_parallel_for_simd_private_messages.cpp
-
teams_distribute_parallel_for_simd_reduction_messages.cpp
-
teams_distribute_parallel_for_simd_safelen_messages.cpp
-
teams_distribute_parallel_for_simd_shared_messages.cpp
-
teams_distribute_parallel_for_simd_simdlen_messages.cpp
-
teams_distribute_parallel_for_simd_thread_limit_messages.cpp
-
teams_distribute_parallel_for_thread_limit_messages.cpp
-
teams_distribute_private_messages.cpp
-
teams_distribute_reduction_messages.cpp
-
teams_distribute_shared_messages.cpp
-
teams_distribute_simd_aligned_messages.cpp
-
teams_distribute_simd_collapse_messages.cpp
-
teams_distribute_simd_dist_schedule_messages.cpp
-
teams_distribute_simd_firstprivate_messages.cpp
-
teams_distribute_simd_if_messages.cpp
-
teams_distribute_simd_lastprivate_messages.cpp
-
teams_distribute_simd_linear_messages.cpp
-
teams_distribute_simd_num_teams_messages.cpp
-
teams_distribute_simd_private_messages.cpp
-
teams_distribute_simd_reduction_messages.cpp
-
teams_distribute_simd_safelen_messages.cpp
-
teams_distribute_simd_shared_messages.cpp
-
teams_distribute_simd_simdlen_messages.cpp
-
teams_distribute_simd_thread_limit_messages.cpp
-
teams_distribute_thread_limit_messages.cpp
-
teams_firstprivate_messages.cpp
-
teams_num_teams_messages.cpp
-
teams_private_messages.cpp
-
teams_reduction_messages.cpp
-
teams_shared_messages.cpp
-
teams_thread_limit_messages.cpp
-
Parser/
-
cxx-attributes.cpp
-
cxx2a-init-statement.cpp
-
Sema/
-
128bitint.c
-
align-arm-apcs.c
-
align-systemz.c
-
align-x86-64.c
-
array-init.c
-
attr-aligned.c
-
attr-mode.c
-
bitfield-layout.c
-
bitfield-layout_1.c
-
builtin-classify-type.c
-
compare.c
-
complex-promotion.c
-
conditional.c
-
const-eval-64.c
-
const-eval.c
-
constant-builtins-2.c
-
constant-builtins.c
-
designated-initializers.c
-
enum.c
-
expr-comma-c99.c
-
expr-comma.c
-
format-strings.c
-
generic-selection.c
-
i-c-e.c
-
i386-linux-android.c
-
integer-overflow.c
-
merge-decls.c
-
offsetof.c
2
parentheses.c
2/2
parentheses.cpp
-
pragma-align-mac68k.c
-
pragma-align-packed.c
-
pragma-ms_struct.c
-
pragma-pack-2.c
-
pragma-pack-3.c
-
pragma-pack-5.c
-
pragma-pack-6.c
-
pragma-pack-and-options-align.c
-
predef.c
-
short-enums.c
-
sign-conversion.c
-
sizeless-1.c
-
sizeof-struct-non-zero-as-member.cl
-
struct-packed-align.c
-
ucn-cstring.c
-
unused-expr.c
-
vector-init.c
-
warn-unreachable.c
-
wchar.c
-
zvector.c
-
zvector2.c
-
SemaCUDA/
-
amdgpu-attrs.cu
-
SemaCXX/
-
Inputs/
-
std-compare.h
-
__null.cpp
-
altivec.cpp
-
array-bounds.cpp
-
bitfield-layout.cpp
-
builtin-classify-type.cpp
-
constant-conversion.cpp
-
constant-expression-cxx11.cpp
-
constant-expression-cxx14.cpp
-
constant-expression-cxx2a.cpp
-
constexpr-depth.cpp
-
constexpr-string.cpp
-
constexpr-turing-cxx2a.cpp
-
constexpr-turing.cpp
-
cxx11-user-defined-literals.cpp
-
cxx1y-generic-lambdas-capturing.cpp
-
cxx2a-adl-only-template-id.cpp
-
dcl_init_aggr.cpp
-
integer-overflow.cpp
-
issue547.cpp
-
member-pointer-size.cpp
-
ms_wide_bitfield.cpp
-
offsetof.cpp
-
pragma-pack.cpp
-
primary-base.cpp
-
short-wchar-sign.cpp
-
typedef-redecl.cpp
-
using-directive.cpp
-
warn-thread-safety-analysis.cpp
-
warn-unused-comparison.cpp
-
warn-zero-nullptr-cxx20.cpp
-
wchar_t.cpp
-
SemaObjC/
-
conditional-expr-8.m
-
enum-fixed-type.m
-
exprs.m
-
format-strings-objc.m
-
pragma-pack.m
-
SemaTemplate/
-
ackermann.cpp
-
address_space-dependent.cpp
-
alignas.cpp
-
constexpr-instantiate.cpp
-
deduction.cpp
-
dependent-names.cpp
-
dependent-sized_array.cpp
-
dependent-template-recover.cpp
-
example-typelist.cpp
-
ext-vector-type.cpp
-
friend-template.cpp
-
instantiate-attr.cpp
-
instantiate-declref-ice.cpp
-
instantiate-expr-5.cpp
-
instantiate-field.cpp
-
instantiate-static-var.cpp
-
instantiate-var-template.cpp
-
instantiation-dependence.cpp
-
matrix-type.cpp
-
pragma-ms_struct.cpp
-
temp_arg_template.cpp
-
temp_class_order.cpp
-
temp_class_spec.cpp
-
libcxx/
-
include/
-
__chrono/
-
duration.h
1/1
strstream
-
src/
-
filesystem/
-
operations.cpp
-
locale.cpp
-
memory_resource.cpp
-
ryu/
-
d2fixed.cpp
-
f2s.cpp
-
test/libcxx/algorithms/
-
libcxx/
-
algorithms/
-
nth_element_stability.pass.cpp
-
partial_sort_stability.pass.cpp
-
sort_stability.pass.cpp
-
libcxxabi/src/
-
src/
-
cxa_default_handlers.cpp
-
cxa_demangle.cpp
-
cxa_exception.cpp
1
cxa_personality.cpp
-
demangle/
-
ItaniumDemangle.h

Differential D147844

[clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression
Needs ReviewPublic

Authored by chaitanyav on Apr 8 2023, 1:50 AM.

Download Raw Diff

Details

Reviewers

aaron.ballman
Mordante
dblaikie
cjdb
echristo
jdoerfert

Group Reviewers

Restricted Project
Restricted Project
Restricted Project

Summary

Fixes issue https://github.com/llvm/llvm-project/issues/61943

#include <iostream>

int main()
{
    int ai32 = 5;
    std::cout << true ? 1 : 0;
    std::cout << "Test" << ai32 ? 1 : 0;
    int b = ai32 & 1 ? true : false;
    auto c = true ? "1" : "0";
    return 0;
}

Before the change

test.cpp:6:23: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
    std::cout << true ? 1 : 0;
    ~~~~~~~~~~~~~~~~~ ^
test.cpp:6:23: note: place parentheses around the '<<' expression to silence this warning
    std::cout << true ? 1 : 0;
                      ^
    (                )
test.cpp:6:23: note: place parentheses around the '?:' expression to evaluate it first
    std::cout << true ? 1 : 0;
                      ^
                 (           )
1 warning generated.

After the change

test.cpp:6:23: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
    std::cout << true ? 1 : 0;
    ~~~~~~~~~~~~~~~~~ ^
test.cpp:6:23: note: place parentheses around the '<<' expression to silence this warning
    std::cout << true ? 1 : 0;
                      ^
    (                )
test.cpp:6:23: note: place parentheses around the '?:' expression to evaluate it first
    std::cout << true ? 1 : 0;
                      ^
                 (           )
test.cpp:7:33: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
    std::cout << "Test" << ai32 ? 1 : 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
test.cpp:7:33: note: place parentheses around the '<<' expression to silence this warning
    std::cout << "Test" << ai32 ? 1 : 0;
                                ^
    (                          )
test.cpp:7:33: note: place parentheses around the '?:' expression to evaluate it first
    std::cout << "Test" << ai32 ? 1 : 0;
                                ^
                           (           )
test.cpp:8:22: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
    int b = ai32 & 1 ? true : false;
            ~~~~~~~~ ^
test.cpp:8:22: note: place parentheses around the '&' expression to silence this warning
    int b = ai32 & 1 ? true : false;
                     ^
            (       )
test.cpp:8:22: note: place parentheses around the '?:' expression to evaluate it first
    int b = ai32 & 1 ? true : false;
                     ^
                   (               )
3 warnings generated.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	1,400 ms	x64 debian > Clang.AST::ast-dump-openmp-distribute-parallel-for-simd.c
	1,280 ms	x64 debian > Clang.AST::ast-dump-openmp-distribute-parallel-for.c
	1,460 ms	x64 debian > Clang.AST::ast-dump-openmp-distribute-simd.c
	1,270 ms	x64 debian > Clang.AST::ast-dump-openmp-distribute.c
	1,270 ms	x64 debian > Clang.AST::ast-dump-openmp-for-simd.c
		View Full Test Results (572 Failed)

Event Timeline

chaitanyav created this revision.Apr 8 2023, 1:50 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2023, 1:50 AM

chaitanyav requested review of this revision.Apr 8 2023, 1:50 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2023, 1:50 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

chaitanyav added a reviewer: aaron.ballman.Apr 8 2023, 1:51 AM

output for testcases mentioned in https://github.com/llvm/llvm-project/issues/61943

test.cpp:6:30: warning: overloaded operator << has higher precedence than comparison operator [-Woverloaded-shift-op-parentheses]
    std::cout << "Test" << a == 5 ? 1 : 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~
test.cpp:6:25: note: place parentheses around the '<<' expression to silence this warning
    std::cout << "Test" << a == 5 ? 1 : 0;
                        ^
    (                       )
test.cpp:6:30: note: place parentheses around comparison expression to evaluate it first
    std::cout << "Test" << a == 5 ? 1 : 0;
                             ^
                           (     )
test.cpp:6:30: error: invalid operands to binary expression ('ostream' and 'int')
    std::cout << "Test" << a == 5 ? 1 : 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~
test.cpp:7:30: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
    std::cout << "Test" << a ? 1 : 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~ ^
test.cpp:7:30: note: place parentheses around the '<<' expression to silence this warning
    std::cout << "Test" << a ? 1 : 0;
                             ^
    (                       )
test.cpp:7:30: note: place parentheses around the '?:' expression to evaluate it first
    std::cout << "Test" << a ? 1 : 0;
                             ^
                           (        )
test.cpp:8:49: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
    std::cout << "Test" << static_cast<bool>(a) ? 1 : 0;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
test.cpp:8:49: note: place parentheses around the '<<' expression to silence this warning
    std::cout << "Test" << static_cast<bool>(a) ? 1 : 0;
                                                ^
    (                                          )
test.cpp:8:49: note: place parentheses around the '?:' expression to evaluate it first
    std::cout << "Test" << static_cast<bool>(a) ? 1 : 0;
                                                ^

@aaron.ballman Please review

Harbormaster completed remote builds in B224342: Diff 511863.Apr 8 2023, 2:54 AM

@aaron.ballman Please review this.

chaitanyav abandoned this revision.Apr 14 2023, 2:25 PM

re-opening the revision to make further updates as per comments on the github issue.

Thank you for working on this! The only thing I think is missing is a release note, though I did have a question on a change in the tests.

clang/test/Sema/parentheses.cpp
34	Is this change necessary? Alternatively, can we add this as an overload instead of changing the operator?

Update release notes about the fix

aaron.ballman added inline comments.Apr 18 2023, 11:53 AM

clang/test/Sema/parentheses.cpp
34	I'm still wondering about this.

Harbormaster completed remote builds in B226423: Diff 514702.Apr 18 2023, 12:17 PM

@aaron.ballman am looking into this. If i change it back to
operation int();
and add
Stream& operator<<(bool)
i get
`
error: 'warning' diagnostics expected but not seen:

File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: operator '?:' has lower precedence than '<<'

error: 'note' diagnostics expected but not seen:

File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '<<' expression to silence this warning
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '?:' expression to evaluate it first

3 errors generated.
`
But it works correctly with std::cout

`
test.cpp:7:30: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]

std::cout << "Test" << a ? 1 : 0;
~~~~~~~~~~~~~~~~~~~~~~~~ ^

test.cpp:7:30: note: place parentheses around the '<<' expression to silence this warning

std::cout << "Test" << a ? 1 : 0;
                         ^
(                       )

test.cpp:7:30: note: place parentheses around the '?:' expression to evaluate it first

std::cout << "Test" << a ? 1 : 0;
                         ^
                       (        )

In D147844#4278384, @chaitanyav wrote:
@aaron.ballman am looking into this. If i change it back to
operation int();
and add
Stream& operator<<(bool)
i get
`
error: 'warning' diagnostics expected but not seen:
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: operator '?:' has lower precedence than '<<'
error: 'note' diagnostics expected but not seen:
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '<<' expression to silence this warning
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '?:' expression to evaluate it first
3 errors generated.
`
But it works correctly with std::cout

`
test.cpp:7:30: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
std::cout << "Test" << a ? 1 : 0;
~~~~~~~~~~~~~~~~~~~~~~~~ ^
test.cpp:7:30: note: place parentheses around the '<<' expression to silence this warning
std::cout << "Test" << a ? 1 : 0;
                         ^
(                       )
test.cpp:7:30: note: place parentheses around the '?:' expression to evaluate it first
std::cout << "Test" << a ? 1 : 0;
                         ^
                       (        )

I would expect to get the same diagnostic with either operator int() or operator bool() as the precedence is the same either way. I think what might be happening here is that ExprLooksBoolean is getting tricked into thinking the expression isn't boolean when it actually is (I think this might be the FIXME comment in that function needing to be addressed).

In D147844#4281288, @aaron.ballman wrote:
In D147844#4278384, @chaitanyav wrote:
@aaron.ballman am looking into this. If i change it back to
operation int();
and add
Stream& operator<<(bool)
i get
`
error: 'warning' diagnostics expected but not seen:
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: operator '?:' has lower precedence than '<<'
error: 'note' diagnostics expected but not seen:
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '<<' expression to silence this warning
File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line 68: place parentheses around the '?:' expression to evaluate it first
3 errors generated.
`
But it works correctly with std::cout

`
test.cpp:7:30: warning: operator '?:' has lower precedence than '<<'; '<<' will be evaluated first [-Wparentheses]
std::cout << "Test" << a ? 1 : 0;
~~~~~~~~~~~~~~~~~~~~~~~~ ^
test.cpp:7:30: note: place parentheses around the '<<' expression to silence this warning
std::cout << "Test" << a ? 1 : 0;
                         ^
(                       )
test.cpp:7:30: note: place parentheses around the '?:' expression to evaluate it first
std::cout << "Test" << a ? 1 : 0;
                         ^
                       (        )
I would expect to get the same diagnostic with either operator int() or operator bool() as the precedence is the same either way. I think what might be happening here is that ExprLooksBoolean is getting tricked into thinking the expression isn't boolean when it actually is (I think this might be the FIXME comment in that function needing to be addressed).

Thanks @aaron.ballman, will look into the FIXME.

Emit warning when implicit cast from int to bool in an conditional operator expression

@aaron.ballman I have made more changes so that the warning is emitted on other integer expressions where the opertors has higher precedence than conditional operator.

Harbormaster completed remote builds in B226728: Diff 515130.Apr 19 2023, 7:42 PM

Update SemaCXX tests to use parentheses around conditional operator

Update test to use parentheses around conditional operator

Harbormaster completed remote builds in B226920: Diff 515394.Apr 20 2023, 12:23 PM

Place parentheses around & expression since -Werror is enabled for build

:/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__chrono/duration.h:197:32: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
2650-    return __lower.count() & 1 ? __upper : __lower;
2651-           ~~~~~~~~~~~~~~~~~~~ ^
2652:/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__chrono/duration.h:197:32: note: place parentheses around the '&' expression to silence this warning
2653-    return __lower.count() & 1 ? __upper : __lower;
2654-                               ^
2655-           (                  )
2656:/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__chrono/duration.h:197:32: note: place parentheses around the '?:' expression to evaluate it first
2657-    return __lower.count() & 1 ? __upper : __lower;
2658-                               ^
2659-                             (                    )
2660-1 error generated.

/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/libcxxabi/src/cxa_personality.cpp:722:38: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
                                     ? _URC_CONTINUE_UNWIND
                                     ^
/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/libcxxabi/src/cxa_personality.cpp:722:38: note: place parentheses around the '&' expression to silence this warning
                                     ? _URC_CONTINUE_UNWIND
                                     ^
/home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-libcxx-precommit-ci-group-60nx-1/llvm-project/libcxx-ci/libcxxabi/src/cxa_personality.cpp:722:38: note: place parentheses around the '?:' expression to evaluate it first
                                     ? _URC_CONTINUE_UNWIND
                                     ^
1 error generated.

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 12:57 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

chaitanyav retitled this revision from Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression to Emit warning when implicit cast from int to bool happens in an conditional operator expression.Apr 20 2023, 1:02 PM

Place parentheses around conditional expression to prevent precedence warnings since -Werror is enabled on build

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 2:41 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

clang-format the changes to the file

Harbormaster completed remote builds in B227001: Diff 515513.Apr 20 2023, 10:21 PM

Place parentheses around conditional expression to prevent precedence warnings since -Werror is enabled on build

@aaron.ballman please take a look.

I filed a issue that premerge checks are not working on AIX
https://github.com/google/llvm-premerge-checks/issues/441

Not sure why the TSAN, MSAN and ASAN checks are failing on libcxx
https://buildkite.com/llvm-project/libcxx-ci/builds/22664

Harbormaster completed remote builds in B227069: Diff 515591.Apr 21 2023, 2:09 AM

I have to say I'm not really convinced this change is a good idea. The cases it flags don't really seem in any way ambiguous/erroneous.

In D147844#4286364, @chaitanyav wrote:

@aaron.ballman please take a look.

I filed a issue that premerge checks are not working on AIX
https://github.com/google/llvm-premerge-checks/issues/441

Not sure why the TSAN, MSAN and ASAN checks are failing on libcxx
https://buildkite.com/llvm-project/libcxx-ci/builds/22664

The AIX builders are currently broken. That has to do with an update. We don't really know what's going on with the sanitizer builds, but these are unrelated too (probably also a problem with the builders).

libcxx/include/strstream
303	Please don't change the indentation. It was correct before.

Fix indentation

Harbormaster completed remote builds in B227142: Diff 515687.Apr 21 2023, 5:47 AM

I too am not really convinced by all changes in libc++. On the other hand I don't think the change make the libc++ code looking bad. So I don't feel a reason to reject the libc++ changes.

I don't like the commit message, there's only a title and a bug report. Please add a bit more information in the message, with an example of code that now gives a diagnostic.

Note I only reviewed the libc++ changes, I leave the clang part to @aaron.ballman.

chaitanyav edited the summary of this revision. (Show Details)Apr 21 2023, 1:31 PM

Modify the commit message

chaitanyav retitled this revision from Emit warning when implicit cast from int to bool happens in an conditional operator expression to [clang][Sema]Print diagnostic warning when implicit cast from int to bool happens in an conditional operator expression.Apr 21 2023, 6:40 PM

Revise commit message

chaitanyav retitled this revision from [clang][Sema]Print diagnostic warning when implicit cast from int to bool happens in an conditional operator expression to [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression.Apr 21 2023, 7:39 PM

One suggestion for the commit message either use [[maybe_unused]] or -Wno-unused that way the unrelated messages aren't shown in the commit message.

chaitanyav edited the summary of this revision. (Show Details)Apr 22 2023, 8:46 AM

Harbormaster completed remote builds in B227375: Diff 515978.Apr 22 2023, 11:48 AM

In D147844#4286500, @philnik wrote:

I have to say I'm not really convinced this change is a good idea. The cases it flags don't really seem in any way ambiguous/erroneous.

I think some of the cases are ambiguous while others are not. It's taken me a while to come up with what I think my brain is doing, maybe this happens for others as well. When the ternary conditional expression is a binary expression, my brain can figure things out very quickly when the RHS of that binary expression is a literal but my brain is much less confident when the RHS of that binary expression is an identifier. e.g., x & 1 ? foo : bar is easy for my brain to go "well, obviously the condition is not testing whether 1 is nonzero, so it must be testing the result of x & 1 instead", but something like x & y ? foo : bar is far less obvious as to what the behavior is because x & (y ? foo : bar) is as reasonable a choice as (x & y) ? foo : bar without putting a lot more thought into it. However, that might be splitting hairs with the diagnostic functionality (esp because macros and enumerations are sort of like literals and sort of like identifiers, depending on the way you want to think of them).

Adding in some more folks for opinions on whether the proposed changes in this patch are an improvement or whether we want to tweak the heuristic a bit more. My original thinking was that all precedence situations with ternary conditional expressions are kind of equally confusing, but given that two folks have pushed back on the proposed changes, more opinions would be valuable.

I think this is a good diagnostic to add: it improves readability and eliminates ambiguities. My only request is that if there isn't already a FixIt hint, one be added, please.

clang/test/Sema/parentheses.c
94	I think this should also warn.

I think some of the cases are ambiguous while others are not.

Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant frequency in a codebase?)

I'm afraid I have been bitten by this very issue several more than once. I can only assume I'm not the only one. so this looks like a nice improvement.
There are only a few changes in libc++ so it seems fairly low noise.

Did you try to compile llvm with it? I'd be curious to see how many time these occurs in clang own diagnostics.

In D147844#4293693, @dblaikie wrote:

I think some of the cases are ambiguous while others are not.

Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant frequency in a codebase?)

I disagree that there's a need for bugs to add this warning. Reading ambiguous-but-correct code isn't going to be buggy, but it is going to cause readability issues for any reviewers or maintainers.

In D147844#4293743, @cjdb wrote:

In D147844#4293693, @dblaikie wrote:

I think some of the cases are ambiguous while others are not.

Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant frequency in a codebase?)

I disagree that there's a need for bugs to add this warning. Reading ambiguous-but-correct code isn't going to be buggy, but it is going to cause readability issues for any reviewers or maintainers.

That's generally been the bar we use for evaluating warnings - does it find bugs. Especially because if it doesn't, it's unlikely to be turned on on large pre-existing codebases owing to the cost of cleaning them up with limited value in terms of improving readability but not finding any bugs. (& goes hand-in-hand with the general policy of not adding off-by-default warnings, because they don't get used much and come at a cost to clang's codebase (& some (death-by-a-thousand-cuts) cost to compile time performance, even when the warning is disabled))

Readability improvements that don't cross the threshold to be the cause of a significant number of bugs are moreso the domain of clang-tidy, not clang warnings.

In D147844#4293299, @cjdb wrote:

I think this is a good diagnostic to add: it improves readability and eliminates ambiguities. My only request is that if there isn't already a FixIt hint, one be added, please.

@cjb quick question, should we restrict to

>, <, >=, <=

I am finding lots of files in the project with == and ?: precedence warnings.

clang/test/Sema/parentheses.c
94	@cjdb am looking into this.

chaitanyav updated this revision to Diff 517042.Apr 25 2023, 9:29 PM

Fix tests/code by adding parentheses around the conditional operator expression

Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 25 2023, 9:29 PM

Herald added subscribers: jplehr, kosarev, jdoerfert and 3 others. · View Herald Transcript

Added parentheses to lots of files to fix the precedence warning. Still a lot to change in OpenMP.

Harbormaster completed remote builds in B228202: Diff 517042.Apr 25 2023, 10:53 PM

Fix more failing tests due to missing parentheses in conditional operator expression

Herald added a subscriber: arphaman. · View Herald TranscriptApr 25 2023, 11:26 PM

Harbormaster completed remote builds in B228227: Diff 517070.Apr 25 2023, 11:47 PM

In D147844#4293743, @cjdb wrote:

In D147844#4293693, @dblaikie wrote:

I think some of the cases are ambiguous while others are not.

Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant frequency in a codebase?)

I disagree that there's a need for bugs to add this warning. Reading ambiguous-but-correct code isn't going to be buggy, but it is going to cause readability issues for any reviewers or maintainers.

The number of changes to test cases convinces me that we definitely need data on whether it's worth it or not. This warning now looks chatty enough that it needs to be disabled by default, and that doesn't meet our usual bar.

Readability improvements that don't cross the threshold to be the cause of a significant number of bugs are moreso the domain of clang-tidy, not clang warnings.

Strong +1, this is starting to feel more like a style warning due to the chattiness.

In D147844#4293988, @dblaikie wrote:

In D147844#4293743, @cjdb wrote:

In D147844#4293693, @dblaikie wrote:

I think some of the cases are ambiguous while others are not.

Data would be good to have - if this assessment is true, we'd expect this to bear out in terms of bug finding, yeah? (that the cases you find to be ambiguous turn up as real bugs with some significant frequency in a codebase?)

I disagree that there's a need for bugs to add this warning. Reading ambiguous-but-correct code isn't going to be buggy, but it is going to cause readability issues for any reviewers or maintainers.

That's generally been the bar we use for evaluating warnings - does it find bugs. Especially because if it doesn't, it's unlikely to be turned on on large pre-existing codebases owing to the cost of cleaning them up with limited value in terms of improving readability but not finding any bugs. (& goes hand-in-hand with the general policy of not adding off-by-default warnings, because they don't get used much and come at a cost to clang's codebase (& some (death-by-a-thousand-cuts) cost to compile time performance, even when the warning is disabled))

Readability improvements that don't cross the threshold to be the cause of a significant number of bugs are moreso the domain of clang-tidy, not clang warnings.

Fair enough, I often mix up which project a warning belongs to, so thanks for the reminder :)

@aaron.ballman just for learning, can you point me to the code where a warning is selectively enabled/disabled based on a flag. For e.g. -Wunused-comparison

In D147844#4299418, @chaitanyav wrote:

@aaron.ballman just for learning, can you point me to the code where a warning is selectively enabled/disabled based on a flag. For e.g. -Wunused-comparison

Sure! This is handled automagically for you by tablegen when you use DefaultIgnore while defining the diagnostic, as in: https://github.com/llvm/llvm-project/blob/c4505158950f2211d8c4b429049f2cd765f3e092/clang/include/clang/Basic/DiagnosticSemaKinds.td#L28

Disable precedence conditional warning by default; Revert changes to test files

In D147844#4299856, @chaitanyav wrote:

Disable precedence conditional warning by default; Revert changes to test files

I'm sorry, I think there was a miscommunication. We were saying that we don't typically want off-by-default diagnostics at all, not asking to turn this one off by default. We've found that when a diagnostic is off by default, it very rarely gets enabled by enough projects to be worth having the diagnostic. So we instead expect diagnostics to have a very low false positive rate so that they can be on by default without worrying that a lot of users will have to disable it due to chattiness.

So instead of making this diagnostic be DefaultIgnore, I think you should back out most of the recent changes so we're back to only the small number of additional diagnostics in the earlier patches.

In D147844#4299874, @aaron.ballman wrote:

In D147844#4299856, @chaitanyav wrote:

Disable precedence conditional warning by default; Revert changes to test files

I'm sorry, I think there was a miscommunication. We were saying that we don't typically want off-by-default diagnostics at all, not asking to turn this one off by default. We've found that when a diagnostic is off by default, it very rarely gets enabled by enough projects to be worth having the diagnostic. So we instead expect diagnostics to have a very low false positive rate so that they can be on by default without worrying that a lot of users will have to disable it due to chattiness.

So instead of making this diagnostic be DefaultIgnore, I think you should back out most of the recent changes so we're back to only the small number of additional diagnostics in the earlier patches.

@aaron.ballman am reverting to the earliest patch.

Revert to earliest patch

Harbormaster completed remote builds in B228381: Diff 517300.Apr 26 2023, 3:53 PM

Add parentheses around integer expressions in libcxx tests

Harbormaster completed remote builds in B228434: Diff 517372.Apr 26 2023, 6:23 PM

Revert libcxx libcxxabi files unrelated to the issue

Harbormaster completed remote builds in B228474: Diff 517429.Apr 26 2023, 9:23 PM

Rebase with upstream

Harbormaster failed remote builds in B228972: Diff 518118!Apr 28 2023, 7:15 PM

Harbormaster completed remote builds in B228972: Diff 518118.May 3 2023, 11:26 AM

Rebase with upstream

Harbormaster completed remote builds in B229821: Diff 519259.May 3 2023, 7:57 PM

Rebase with upstream

Harbormaster completed remote builds in B230711: Diff 520491.May 8 2023, 5:56 PM

In general, I think this is incremental progress on the diagnostic behavior. However, it's clear that there is room for interpretation on what is or is not a false positive diagnostic for this, so we should pay close attention to user feedback during the 17.x release cycle. If it seems we're getting significant push back, we may need to come back and rethink.

Specifically, I think we've improved the situation for code like this:

// `p` is a pointer, `x` is an `int`, and `b` is a `bool`
p + x ? 1 : 2; // previously didn't warn, now warns
p + b ? 1 : 2; // always warned

Does anyone feel we should not move forward with accepting the patch in its current form?

clang/docs/ReleaseNotes.rst
326–327	It looks like a rebase accidentally duplicated this line.

Rebase with upstream and remove duplicate line from ReleaseNotes

Harbormaster completed remote builds in B230891: Diff 520725.May 9 2023, 3:39 PM

Code changes in libc++ and libc++abi LGTM. I am neutral on whether the diagnostic is worth adding, but don't consider libc++ and libc++abi as blockers for this patch.

libcxxabi/src/cxa_personality.cpp
721	Double-parens are not required.

This revision is now accepted and ready to land.May 10 2023, 2:47 PM

Remove extra parens

Harbormaster completed remote builds in B231252: Diff 521203.May 10 2023, 10:09 PM

Rebase with upstream

In D147844#4333407, @ldionne wrote:

Code changes in libc++ and libc++abi LGTM. I am neutral on whether the diagnostic is worth adding, but don't consider libc++ and libc++abi as blockers for this patch.

Thank you @ldionne! My plan is to accept & land this if we hear no objections by next Thur (May 18).

Harbormaster completed remote builds in B231351: Diff 521330.May 11 2023, 10:53 AM

In D147844#4329497, @aaron.ballman wrote:

In general, I think this is incremental progress on the diagnostic behavior. However, it's clear that there is room for interpretation on what is or is not a false positive diagnostic for this,

I hope we can agree on what a false positive is here - when the warning fires but the code is what the developer intended (ie: the existing code with the existing language semantics produce the desired result, the "fix" is to add parentheses that explicitly encode the language's existing rules/behavior anyway).

Not that we don't have warnings that do this - that encourage parens to reinforce what the language already does to be more explicit/intentional about it, and in some cases it's not that uncommon that the user will be adding parens that reinforce the precedence rules anyway.

Like, I think all the fixes in libc++, llvm, etc, are false positives? (none of them found bugs/unintended behavior) Are there any examples of bugs being found by this warning in a codebase? (& how many false positives in such a codebase did it also flag?)

so we should pay close attention to user feedback during the 17.x release cycle. If it seems we're getting significant push back, we may need to come back and rethink.

Specifically, I think we've improved the situation for code like this:
// `p` is a pointer, `x` is an `int`, and `b` is a `bool`
p + x ? 1 : 2; // previously didn't warn, now warns
p + b ? 1 : 2; // always warned
Does anyone feel we should not move forward with accepting the patch in its current form?

*goes to look*

Mixed feelings - you're right, incremental improvement/adding missed cases to an existing warning (especially if that warning's already stylistic in nature) is a lower bar/doesn't necessarily need the false positive assessment. But it looks like this case might've been intentionally suppressed in the initial warning implementation? (anyone linked to the original warning implementation/review/design to check if this was intentional?)

But, yeah, seems marginal enough I don't have strong feelings either way.

Rebase with upstream

Harbormaster completed remote builds in B233401: Diff 524072.May 20 2023, 6:41 PM

Rebase with upstream

Harbormaster completed remote builds in B233585: Diff 524321.May 22 2023, 9:17 AM

Rebase with upstream

Harbormaster completed remote builds in B233623: Diff 524376.May 22 2023, 12:08 PM

In D147844#4335598, @dblaikie wrote:

In D147844#4329497, @aaron.ballman wrote:

In general, I think this is incremental progress on the diagnostic behavior. However, it's clear that there is room for interpretation on what is or is not a false positive diagnostic for this,

I hope we can agree on what a false positive is here - when the warning fires but the code is what the developer intended (ie: the existing code with the existing language semantics produce the desired result, the "fix" is to add parentheses that explicitly encode the language's existing rules/behavior anyway).

I agree with that definition -- that's a useful way to approach this, thank you!

Not that we don't have warnings that do this - that encourage parens to reinforce what the language already does to be more explicit/intentional about it, and in some cases it's not that uncommon that the user will be adding parens that reinforce the precedence rules anyway.

Yup, which is largely what this patch is about.

Like, I think all the fixes in libc++, llvm, etc, are false positives? (none of them found bugs/unintended behavior)

Yes, they all are false positives by the above definition.

Are there any examples of bugs being found by this warning in a codebase? (& how many false positives in such a codebase did it also flag?)

This would be good to know, but a bit of a heavy lift to require of @chaitanyav because they were working on this issue (https://github.com/llvm/llvm-project/issues/61943) with a "good first issue" label that is starting to look a bit like it was misleading (sorry about that!). However, if you're able to try compiling some larger projects with your patch applied to see if it spots any bugs in real world code, that would be very helpful!

so we should pay close attention to user feedback during the 17.x release cycle. If it seems we're getting significant push back, we may need to come back and rethink.

Specifically, I think we've improved the situation for code like this:
// `p` is a pointer, `x` is an `int`, and `b` is a `bool`
p + x ? 1 : 2; // previously didn't warn, now warns
p + b ? 1 : 2; // always warned
Does anyone feel we should not move forward with accepting the patch in its current form?
*goes to look*

Mixed feelings - you're right, incremental improvement/adding missed cases to an existing warning (especially if that warning's already stylistic in nature) is a lower bar/doesn't necessarily need the false positive assessment. But it looks like this case might've been intentionally suppressed in the initial warning implementation? (anyone linked to the original warning implementation/review/design to check if this was intentional?)

I tried to chase down where this got added to see what review comments there were, but it seems to predate my involvement (I'm seeing mentions of this in 2011).

But, yeah, seems marginal enough I don't have strong feelings either way.

Thank you for the opinion! I think pointer + int is a far more common code pattern than pointer + bool, so it makes some sense to me that we would silence the first case while diagnosing the second case. Given the general lack of enthusiasm for the new diagnostics, it may boil down to answering whether this finds any true positives or not.

In D147844#4361956, @aaron.ballman wrote:

In D147844#4335598, @dblaikie wrote:

In D147844#4329497, @aaron.ballman wrote:

In general, I think this is incremental progress on the diagnostic behavior. However, it's clear that there is room for interpretation on what is or is not a false positive diagnostic for this,

I hope we can agree on what a false positive is here - when the warning fires but the code is what the developer intended (ie: the existing code with the existing language semantics produce the desired result, the "fix" is to add parentheses that explicitly encode the language's existing rules/behavior anyway).

I agree with that definition -- that's a useful way to approach this, thank you!

Not that we don't have warnings that do this - that encourage parens to reinforce what the language already does to be more explicit/intentional about it, and in some cases it's not that uncommon that the user will be adding parens that reinforce the precedence rules anyway.

Yup, which is largely what this patch is about.

Like, I think all the fixes in libc++, llvm, etc, are false positives? (none of them found bugs/unintended behavior)

Yes, they all are false positives by the above definition.

Are there any examples of bugs being found by this warning in a codebase? (& how many false positives in such a codebase did it also flag?)

This would be good to know, but a bit of a heavy lift to require of @chaitanyav because they were working on this issue (https://github.com/llvm/llvm-project/issues/61943) with a "good first issue" label that is starting to look a bit like it was misleading (sorry about that!). However, if you're able to try compiling some larger projects with your patch applied to see if it spots any bugs in real world code, that would be very helpful!

@aaron.ballman will try this patch on some projects and post the results here

so we should pay close attention to user feedback during the 17.x release cycle. If it seems we're getting significant push back, we may need to come back and rethink.

Specifically, I think we've improved the situation for code like this:
// `p` is a pointer, `x` is an `int`, and `b` is a `bool`
p + x ? 1 : 2; // previously didn't warn, now warns
p + b ? 1 : 2; // always warned
Does anyone feel we should not move forward with accepting the patch in its current form?
*goes to look*

Mixed feelings - you're right, incremental improvement/adding missed cases to an existing warning (especially if that warning's already stylistic in nature) is a lower bar/doesn't necessarily need the false positive assessment. But it looks like this case might've been intentionally suppressed in the initial warning implementation? (anyone linked to the original warning implementation/review/design to check if this was intentional?)
I tried to chase down where this got added to see what review comments there were, but it seems to predate my involvement (I'm seeing mentions of this in 2011).

But, yeah, seems marginal enough I don't have strong feelings either way.

Thank you for the opinion! I think pointer + int is a far more common code pattern than pointer + bool, so it makes some sense to me that we would silence the first case while diagnosing the second case. Given the general lack of enthusiasm for the new diagnostics, it may boil down to answering whether this finds any true positives or not.

I used the patch to compile LLVM, apache/arrow, apache/trafficserver, folly, tensorstore, protobuf. I did not see any cases with pointer arithmetic in these repos. I have uploaded the make logs for the projects with diagnostic warnings.

llvm_out.txt1 MBDownload

apache_arrow_cpp_out.txt155 KBDownload

apache_trafficserver_out.txt1011 KBDownload

protobuf_out.txt1 MBDownload

folly_out.txt484 KBDownload

tensorstore_out.txt597 KBDownload

Some examples

/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3721:49: warning: operator '?:' has lower precedence than '%'; '%' will be evaluated first [-Wparentheses]
  unsigned NumLeftovers = OrigNumElts % NumElts ? 1 : 0;
                          ~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3721:49: note: place parentheses around the '%' expression to silence this warning
  unsigned NumLeftovers = OrigNumElts % NumElts ? 1 : 0;
                                                ^
                          (                    )
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3721:49: note: place parentheses around the '?:' expression to evaluate it first
  unsigned NumLeftovers = OrigNumElts % NumElts ? 1 : 0;
                                                ^
                                        (              )
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3775:49: warning: operator '?:' has lower precedence than '%'; '%' will be evaluated first [-Wparentheses]
  unsigned NumLeftovers = OrigNumElts % NumElts ? 1 : 0;
                          ~~~~~~~~~~~~~~~~~~~~~ ^

/home/nvellanki/scratch/tensorstore/build/_deps/zlib-src/crc32.c:572:19: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
        b = b & 1 ? (b >> 1) ^ POLY : b >> 1;
            ~~~~~ ^
/home/nvellanki/scratch/tensorstore/build/_deps/zlib-src/crc32.c:572:19: note: place parentheses around the '&' expression to silence this warning
        b = b & 1 ? (b >> 1) ^ POLY : b >> 1;
                  ^
            (    )
/home/nvellanki/scratch/tensorstore/build/_deps/zlib-src/crc32.c:572:19: note: place parentheses around the '?:' expression to evaluate it first
        b = b & 1 ? (b >> 1) ^ POLY : b >> 1;
                  ^
                (                           )

[1m/home/nvellanki/scratch/arrow/cpp/src/arrow/vendored/datetime/date.h:3941:61: [0m[0;1;35mwarning: [0m[1moperator '?:' has lower precedence than '%'; '%' will be evaluated first [-Wparentheses][0m
    static CONSTDATA std::uint64_t value = h * h * (exp % 2 ? 10 : 1);
[0;1;32m                                                    ~~~~~~~ ^
[0m[1m/home/nvellanki/scratch/arrow/cpp/src/arrow/vendored/datetime/date.h:3941:61: [0m[0;1;30mnote: [0mplace parentheses around the '%' expression to silence this warning[0m
    static CONSTDATA std::uint64_t value = h * h * (exp % 2 ? 10 : 1);
[0;1;32m                                                            ^
[0m[0;32m                                                    (      )
[0m[1m/home/nvellanki/scratch/arrow/cpp/src/arrow/vendored/datetime/date.h:3941:61: [0m[0;1;30mnote: [0mplace parentheses around the '?:' expression to evaluate it first[0m
    static CONSTDATA std::uint64_t value = h * h * (exp % 2 ? 10 : 1);
[0;1;32m                                                            ^
[0m[0;32m                                                          (         )

/home/nvellanki/scratch/trafficserver/include/tscore/SimpleTokenizer.h:145:47: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
    _data   = (_mode & OVERWRITE_INPUT_STRING ? const_cast<char *>(s) : ats_strdup(s));
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/trafficserver/include/tscore/SimpleTokenizer.h:145:47: note: place parentheses around the '&' expression to silence this warning
    _data   = (_mode & OVERWRITE_INPUT_STRING ? const_cast<char *>(s) : ats_strdup(s));
                                              ^
               (                             )
/home/nvellanki/scratch/trafficserver/include/tscore/SimpleTokenizer.h:145:47: note: place parentheses around the '?:' expression to evaluate it first
    _data   = (_mode & OVERWRITE_INPUT_STRING ? const_cast<char *>(s) : ats_strdup(s));
                       ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/nvellanki/scratch/protobuf/src/google/protobuf/map.h:773:47: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
                      bits & kUseDestructFunc ? DestroyNode<Node> : nullptr};
                      ~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/protobuf/src/google/protobuf/map.h:773:47: note: place parentheses around the '&' expression to silence this warning
                      bits & kUseDestructFunc ? DestroyNode<Node> : nullptr};
                                              ^
                      (                      )
/home/nvellanki/scratch/protobuf/src/google/protobuf/map.h:773:47: note: place parentheses around the '?:' expression to evaluate it first
                      bits & kUseDestructFunc ? DestroyNode<Node> : nullptr};
                                              ^

In file included from /home/nvellanki/scratch/folly/folly/lang/Bits.h:63:
/home/nvellanki/scratch/folly/folly/ConstexprMath.h:139:20: warning: operator '?:' has lower precedence than '%'; '%' will be evaluated first [-Wparentheses]
          (exp % 2 ? base : T(1));
           ~~~~~~~ ^
/home/nvellanki/scratch/folly/folly/ConstexprMath.h:139:20: note: place parentheses around the '%' expression to silence this warning
          (exp % 2 ? base : T(1));
                   ^
           (      )
/home/nvellanki/scratch/folly/folly/ConstexprMath.h:139:20: note: place parentheses around the '?:' expression to evaluate it first
          (exp % 2 ? base : T(1));
                   ^

/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:24:36: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
  return Flags & MACRO_OFFSET_SIZE ? DWARF64 : DWARF32;
         ~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:24:36: note: place parentheses around the '&' expression to silence this warning
  return Flags & MACRO_OFFSET_SIZE ? DWARF64 : DWARF32;
                                   ^
         (                        )
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:24:36: note: place parentheses around the '?:' expression to evaluate it first
  return Flags & MACRO_OFFSET_SIZE ? DWARF64 : DWARF32;
                                   ^
                 (                                    )

/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/MIRParser/MIParser.cpp:3381:49: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
            : Flags & MachineMemOperand::MOLoad ? "from" : "into";
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/MIRParser/MIParser.cpp:3381:49: note: place parentheses around the '&' expression to silence this warning
            : Flags & MachineMemOperand::MOLoad ? "from" : "into";
                                                ^
              (                                )
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/CodeGen/MIRParser/MIParser.cpp:3381:49: note: place parentheses around the '?:' expression to evaluate it first
            : Flags & MachineMemOperand::MOLoad ? "from" : "into";
                                                ^

                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2377:5: note: place parentheses around the '&' expression to silence this warning
    GENBOOLCOMMENT(", ", VRData, HasVMXInstruction);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2138:65: note: expanded from macro 'GENBOOLCOMMENT'
  CommentOS << (Prefix) << ((V) & (TracebackTable::Field##Mask) ? "+" : "-")   \
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2377:5: note: place parentheses around the '?:' expression to evaluate it first
    GENBOOLCOMMENT(", ", VRData, HasVMXInstruction);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nvellanki/scratch/temp_llvm/llvm-project/llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2138:65: note: expanded from macro 'GENBOOLCOMMENT'
  CommentOS << (Prefix) << ((V) & (TracebackTable::Field##Mask) ? "+" : "-")   \
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

yeah, doesn't look like it found any bugs there (the arrow one seems the most non-trivwial, but I'm guessing the code as-is is correct), so seems a bit questionable as an addition

But @aaron.ballman if you figure this falls more under the "minor tweak to existing diagnostic" I won't stand in the way of it.

Ping. What's missing to land this?

In D147844#4641735, @ldionne wrote:

Ping. What's missing to land this?

Folks have raised enough concerns about chattiness on the thread that I think we should not move forward without more evidence that the changes will find new true positives. I'm marking this as requesting changes so the review gets out of people's Phab queues, but the "changes" are largely about what evidence we find.

This revision now requires changes to proceed.Sep 15 2023, 4:33 AM

FWIW: adding parentheses for expressions, such as overflow = (4608 * 1024 * 1024) ? 4608 * 1024 * 1024 : 0;, and results.reason = (actions & _UA_SEARCH_PHASE) ? ... : ..., looks unnatural and is too noisy to me.

In D147844#4646633, @MaskRay wrote:

FWIW: adding parentheses for expressions, such as overflow = (4608 * 1024 * 1024) ? 4608 * 1024 * 1024 : 0;, and results.reason = (actions & _UA_SEARCH_PHASE) ? ... : ..., looks unnatural and is too noisy to me.

From quuxplusone:

The first expression

overflow = (4608 * 1024 * 1024) ?  4608 * 1024 * 1024 : 0;

is a tautology; it is not possible for (4608 * 1024 * 1024) to be zero. (If it's signed integer overflow, it's UB, not zero; and the compiler knows this.)
But if you make it defined by adding u, then IMO it's very little hardship to explicitly write the comparison to zero:

overflow = (4608u * 1024 * 1024) != 0 ?  4608u * 1024 * 1024 : 0;  // OK, no UB, no warning

The second expression

results.reason = (actions & _UA_SEARCH_PHASE) ? ... : ...

should IMHO also be written as

results.reason = (actions & _UA_SEARCH_PHASE) != 0 ? ... : ...

but I think you would get good support if you proposed that the compiler should treat & as a "logical operator" in this specific case. This just means changing line 9312 to

return OP->isComparisonOp() || OP->isLogicalOp() || (OP->getOpcode() == BO_And);

Rebase with upstream and update code as per comments

aaron.ballman added inline comments.Sep 26 2023, 10:00 AM

clang/docs/ReleaseNotes.rst
238–240	It looks like your rebase may have pulled in unintended changes.

Rebase with upstream

Bootstrapping build failed due to -werror flag (https://buildkite.com/llvm-project/libcxx-ci/builds/30031)

 | /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-4613821dc47f-1/llvm-project/libcxx-ci/libcxx/test/std/containers/unord/unord.multiset/eq.different_hash.pass.cpp:43:18: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
# |    43 |   return val & 1 ? 1 : 0;
# |       |          ~~~~~~~ ^


# | /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-4613821dc47f-1/llvm-project/libcxx-ci/libcxx/test/std/containers/unord/unord.multiset/eq.different_hash.pass.cpp:64:19: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
# |    64 |   return *val & 1 ? 1 : 0;
# |       |          ~~~~~~~~ ^

Harbormaster completed remote builds in B257614: Diff 557373.Sep 27 2023, 5:34 AM

In D147844#4651113, @chaitanyav wrote:

Bootstrapping build failed due to -werror flag (https://buildkite.com/llvm-project/libcxx-ci/builds/30031)

 | /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-4613821dc47f-1/llvm-project/libcxx-ci/libcxx/test/std/containers/unord/unord.multiset/eq.different_hash.pass.cpp:43:18: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
# |    43 |   return val & 1 ? 1 : 0;
# |       |          ~~~~~~~ ^


# | /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-4613821dc47f-1/llvm-project/libcxx-ci/libcxx/test/std/containers/unord/unord.multiset/eq.different_hash.pass.cpp:64:19: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses]
# |    64 |   return *val & 1 ? 1 : 0;
# |       |          ~~~~~~~~ ^

That looks like it is just in a test in libcxx, so at least that is a fairly simple thing to fix. I'd suggest just adding the parens in there (and I'm sure that is something that @ldionne would have no problem with), or adding the -Wno flag to the tests.

Add parentheses to the conditional expression

Harbormaster completed remote builds in B257649: Diff 557427.Sep 28 2023, 1:41 AM

rebase upstream changes

Ran llvm with the boolean and operator change. attaching the log file with errors .

llvm.txt1 MBDownload

Harbormaster completed remote builds in B257706: Diff 557513.Oct 2 2023, 2:57 AM

Looks like there is quite a few places in the LLVM build that need updating (IteratorTest.cpp, Wasm.h, ElfDumper.cpp) so that builds don't fail as we commit this.

Rebase with upstream

I've been pondering what I'd want from a warning here. I think generally I would like to warn if there are two plausible interpretations of the token sequence -- that is, if giving the ? different precedence could plausibly lead to a different valid program. I think concretely that would lead to this rule:

Warn if: the condition in a conditional-expression has a suffix (right-hand operand, recursively, looking only through binary operators) that is plausibly a condition. That is:

It is of a bool-like type: either bool itself, or an arithmetic or pointer or member pointer type, or a class with an operator bool.
It is not a constant expression.

Compared to this patch, I think the main change would be the second bullet: do *not* warn if the potential alternative condition is a constant expression -- that's not a plausible condition for a conditional expression. Looking through the test changes in this patch, this change would remove the vast majority of the false positives where it's obvious to me as a reader of the code that the code was already correct, and just leave a few changes like the second one in cxa_personality.cpp where the code really does look ambiguous as written.

Harbormaster completed remote builds in B257754: Diff 557588.Oct 4 2023, 4:01 PM

Large Diff

This large diff affects 586 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

Path

Size

clang/

docs/

ReleaseNotes.rst

3 lines

lib/

Sema/

SemaExpr.cpp

5 lines

test/

AST/

Interp/

constexpr-nqueens.cpp

12 lines

literals.cpp

6 lines

Analysis/

copypaste/

macro-complexity.cpp

6 lines

cxx-uninitialized-object-unguarded-access.cpp

4 lines

2 lines

2 lines

2 lines

8 lines

2 lines

4 lines

CXX/

temp/

temp.decls/

temp.variadic/

partial-ordering.cpp

10 lines

Frontend/

macros.c

2 lines

OpenMP/

cancel_if_messages.cpp

4 lines

distribute_collapse_messages.cpp

2 lines

distribute_dist_schedule_messages.cpp

4 lines

distribute_firstprivate_messages.cpp

2 lines

distribute_parallel_for_collapse_messages.cpp

2 lines

distribute_parallel_for_copyin_messages.cpp

4 lines

distribute_parallel_for_dist_schedule_messages.cpp

4 lines

distribute_parallel_for_firstprivate_messages.cpp

4 lines

distribute_parallel_for_if_messages.cpp

4 lines

distribute_parallel_for_lastprivate_messages.cpp

4 lines

distribute_parallel_for_num_threads_messages.cpp

2 lines

distribute_parallel_for_private_messages.cpp

4 lines

distribute_parallel_for_reduction_messages.cpp

2 lines

distribute_parallel_for_schedule_messages.cpp

2 lines

distribute_parallel_for_shared_messages.cpp

4 lines

distribute_parallel_for_simd_aligned_messages.cpp

4 lines

distribute_parallel_for_simd_collapse_messages.cpp

2 lines

distribute_parallel_for_simd_copyin_messages.cpp

4 lines

distribute_parallel_for_simd_dist_schedule_messages.cpp

4 lines

distribute_parallel_for_simd_firstprivate_messages.cpp

4 lines

distribute_parallel_for_simd_if_messages.cpp

4 lines

distribute_parallel_for_simd_lastprivate_messages.cpp

4 lines

distribute_parallel_for_simd_linear_messages.cpp

4 lines

distribute_parallel_for_simd_num_threads_messages.cpp

2 lines

distribute_parallel_for_simd_private_messages.cpp

4 lines

distribute_parallel_for_simd_reduction_messages.cpp

2 lines

distribute_parallel_for_simd_safelen_messages.cpp

2 lines

distribute_parallel_for_simd_schedule_messages.cpp

2 lines

distribute_parallel_for_simd_shared_messages.cpp

4 lines

distribute_parallel_for_simd_simdlen_messages.cpp

2 lines

distribute_private_messages.cpp

2 lines

distribute_simd_aligned_messages.cpp

4 lines

distribute_simd_collapse_messages.cpp

2 lines

distribute_simd_dist_schedule_messages.cpp

4 lines

distribute_simd_firstprivate_messages.cpp

4 lines

distribute_simd_if_messages.cpp

4 lines

distribute_simd_lastprivate_messages.cpp

4 lines

distribute_simd_linear_messages.cpp

4 lines

distribute_simd_private_messages.cpp

4 lines

distribute_simd_reduction_messages.cpp

2 lines

distribute_simd_safelen_messages.cpp

2 lines

distribute_simd_simdlen_messages.cpp

2 lines

for_collapse_messages.cpp

2 lines

for_firstprivate_messages.cpp

4 lines

for_lastprivate_messages.cpp

4 lines

for_linear_messages.cpp

4 lines

for_ordered_clause.cpp

2 lines

for_private_messages.cpp

4 lines

for_reduction_messages.cpp

2 lines

for_schedule_messages.cpp

2 lines

for_simd_aligned_messages.cpp

4 lines

for_simd_collapse_messages.cpp

2 lines

for_simd_firstprivate_messages.cpp

4 lines

for_simd_if_messages.cpp

4 lines

for_simd_lastprivate_messages.cpp

4 lines

for_simd_linear_messages.cpp

4 lines

for_simd_private_messages.cpp

4 lines

for_simd_reduction_messages.cpp

2 lines

for_simd_safelen_messages.cpp

2 lines

for_simd_schedule_messages.cpp

2 lines

for_simd_simdlen_messages.cpp

2 lines

masked_taskloop_collapse_messages.cpp

2 lines

masked_taskloop_final_messages.cpp

4 lines

masked_taskloop_firstprivate_messages.cpp

4 lines

masked_taskloop_grainsize_messages.cpp

4 lines

masked_taskloop_in_reduction_messages.cpp

2 lines

masked_taskloop_lastprivate_messages.cpp

4 lines

masked_taskloop_num_tasks_messages.cpp

4 lines

masked_taskloop_priority_messages.cpp

4 lines

masked_taskloop_private_messages.cpp

4 lines

masked_taskloop_simd_aligned_messages.cpp

4 lines

masked_taskloop_simd_collapse_messages.cpp

2 lines

masked_taskloop_simd_final_messages.cpp

4 lines

masked_taskloop_simd_firstprivate_messages.cpp

4 lines

masked_taskloop_simd_grainsize_messages.cpp

4 lines

masked_taskloop_simd_in_reduction_messages.cpp

2 lines

masked_taskloop_simd_lastprivate_messages.cpp

4 lines

masked_taskloop_simd_linear_messages.cpp

4 lines

masked_taskloop_simd_num_tasks_messages.cpp

4 lines

masked_taskloop_simd_priority_messages.cpp

4 lines

masked_taskloop_simd_private_messages.cpp

4 lines

masked_taskloop_simd_reduction_messages.cpp

2 lines

masked_taskloop_simd_safelen_messages.cpp

2 lines

masked_taskloop_simd_simdlen_messages.cpp

2 lines

master_taskloop_collapse_messages.cpp

2 lines

master_taskloop_final_messages.cpp

4 lines

master_taskloop_firstprivate_messages.cpp

4 lines

master_taskloop_grainsize_messages.cpp

4 lines

master_taskloop_in_reduction_messages.cpp

2 lines

master_taskloop_lastprivate_messages.cpp

4 lines

master_taskloop_num_tasks_messages.cpp

4 lines

master_taskloop_priority_messages.cpp

4 lines

master_taskloop_private_messages.cpp

4 lines

master_taskloop_reduction_messages.cpp

2 lines

master_taskloop_simd_aligned_messages.cpp

4 lines

master_taskloop_simd_collapse_messages.cpp

2 lines

master_taskloop_simd_final_messages.cpp

4 lines

master_taskloop_simd_firstprivate_messages.cpp

4 lines

master_taskloop_simd_grainsize_messages.cpp

4 lines

master_taskloop_simd_in_reduction_messages.cpp

2 lines

master_taskloop_simd_lastprivate_messages.cpp

4 lines

master_taskloop_simd_linear_messages.cpp

4 lines

master_taskloop_simd_num_tasks_messages.cpp

4 lines

master_taskloop_simd_priority_messages.cpp

4 lines

master_taskloop_simd_private_messages.cpp

4 lines

master_taskloop_simd_reduction_messages.cpp

2 lines

master_taskloop_simd_safelen_messages.cpp

2 lines

master_taskloop_simd_simdlen_messages.cpp

2 lines

parallel_copyin_messages.cpp

2 lines

parallel_firstprivate_messages.cpp

2 lines

parallel_for_collapse_messages.cpp

2 lines

parallel_for_copyin_messages.cpp

2 lines

parallel_for_firstprivate_messages.cpp

4 lines

parallel_for_if_messages.cpp

4 lines

parallel_for_lastprivate_messages.cpp

4 lines

parallel_for_linear_messages.cpp

4 lines

parallel_for_num_threads_messages.cpp

2 lines

parallel_for_ordered_messages.cpp

2 lines

parallel_for_private_messages.cpp

4 lines

parallel_for_reduction_messages.cpp

2 lines

parallel_for_schedule_messages.cpp

2 lines

parallel_for_simd_aligned_messages.cpp

4 lines

parallel_for_simd_collapse_messages.cpp

2 lines

parallel_for_simd_copyin_messages.cpp

2 lines

parallel_for_simd_firstprivate_messages.cpp

4 lines

parallel_for_simd_if_messages.cpp

4 lines

parallel_for_simd_lastprivate_messages.cpp

4 lines

parallel_for_simd_linear_messages.cpp

4 lines

parallel_for_simd_num_threads_messages.cpp

2 lines

parallel_for_simd_private_messages.cpp

4 lines

parallel_for_simd_reduction_messages.cpp

2 lines

parallel_for_simd_safelen_messages.cpp

2 lines

parallel_for_simd_schedule_messages.cpp

2 lines

parallel_for_simd_simdlen_messages.cpp

2 lines

parallel_if_messages.cpp

4 lines

parallel_masked_copyin_messages.cpp

2 lines

parallel_masked_firstprivate_messages.cpp

4 lines

parallel_masked_if_messages.cpp

4 lines

parallel_masked_num_threads_messages.cpp

2 lines

parallel_masked_private_messages.cpp

4 lines

parallel_masked_reduction_messages.cpp

2 lines

parallel_masked_shared_messages.cpp

2 lines

parallel_masked_taskloop_collapse_messages.cpp

2 lines

parallel_masked_taskloop_final_messages.cpp

4 lines

parallel_masked_taskloop_firstprivate_messages.cpp

4 lines

parallel_masked_taskloop_grainsize_messages.cpp

4 lines

parallel_masked_taskloop_lastprivate_messages.cpp

4 lines

parallel_masked_taskloop_num_tasks_messages.cpp

4 lines

parallel_masked_taskloop_priority_messages.cpp

4 lines

parallel_masked_taskloop_private_messages.cpp

4 lines

parallel_masked_taskloop_reduction_messages.cpp

2 lines

parallel_masked_taskloop_simd_aligned_messages.cpp

4 lines

parallel_masked_taskloop_simd_collapse_messages.cpp

2 lines

parallel_masked_taskloop_simd_final_messages.cpp

4 lines

parallel_masked_taskloop_simd_firstprivate_messages.cpp

4 lines

parallel_masked_taskloop_simd_grainsize_messages.cpp

4 lines

parallel_masked_taskloop_simd_lastprivate_messages.cpp

4 lines

parallel_masked_taskloop_simd_linear_messages.cpp

4 lines

parallel_masked_taskloop_simd_num_tasks_messages.cpp

4 lines

parallel_masked_taskloop_simd_priority_messages.cpp

4 lines

parallel_masked_taskloop_simd_private_messages.cpp

4 lines

parallel_masked_taskloop_simd_reduction_messages.cpp

2 lines

parallel_masked_taskloop_simd_safelen_messages.cpp

2 lines

parallel_masked_taskloop_simd_simdlen_messages.cpp

2 lines

parallel_master_copyin_messages.cpp

2 lines

parallel_master_firstprivate_messages.cpp

4 lines

parallel_master_if_messages.cpp

4 lines

parallel_master_num_threads_messages.cpp

2 lines

parallel_master_private_messages.cpp

4 lines

parallel_master_reduction_messages.cpp

2 lines

parallel_master_shared_messages.cpp

2 lines

parallel_master_taskloop_collapse_messages.cpp

2 lines

parallel_master_taskloop_final_messages.cpp

4 lines

parallel_master_taskloop_firstprivate_messages.cpp

4 lines

parallel_master_taskloop_grainsize_messages.cpp

4 lines

parallel_master_taskloop_lastprivate_messages.cpp

4 lines

parallel_master_taskloop_num_tasks_messages.cpp

4 lines

parallel_master_taskloop_priority_messages.cpp

4 lines

parallel_master_taskloop_private_messages.cpp

4 lines

parallel_master_taskloop_reduction_messages.cpp

2 lines

parallel_master_taskloop_simd_aligned_messages.cpp

4 lines

parallel_master_taskloop_simd_collapse_messages.cpp

2 lines

parallel_master_taskloop_simd_final_messages.cpp

4 lines

parallel_master_taskloop_simd_firstprivate_messages.cpp

4 lines

parallel_master_taskloop_simd_grainsize_messages.cpp

4 lines

parallel_master_taskloop_simd_lastprivate_messages.cpp

4 lines

parallel_master_taskloop_simd_linear_messages.cpp

4 lines

parallel_master_taskloop_simd_num_tasks_messages.cpp

4 lines

parallel_master_taskloop_simd_priority_messages.cpp

4 lines

parallel_master_taskloop_simd_private_messages.cpp

4 lines

parallel_master_taskloop_simd_reduction_messages.cpp

2 lines

parallel_master_taskloop_simd_safelen_messages.cpp

2 lines

parallel_master_taskloop_simd_simdlen_messages.cpp

2 lines

parallel_num_threads_messages.cpp

2 lines

parallel_private_messages.cpp

2 lines

parallel_reduction_messages.cpp

2 lines

parallel_sections_copyin_messages.cpp

2 lines

parallel_sections_firstprivate_messages.cpp

4 lines

parallel_sections_if_messages.cpp

4 lines

parallel_sections_lastprivate_messages.cpp

4 lines

parallel_sections_num_threads_messages.cpp

2 lines

parallel_sections_private_messages.cpp

4 lines

parallel_sections_reduction_messages.cpp

2 lines

parallel_sections_shared_messages.cpp

2 lines

parallel_shared_messages.cpp

2 lines

sections_firstprivate_messages.cpp

4 lines

sections_lastprivate_messages.cpp

4 lines

sections_private_messages.cpp

4 lines

sections_reduction_messages.cpp

2 lines

simd_aligned_messages.cpp

4 lines

simd_collapse_messages.cpp

2 lines

simd_if_messages.cpp

4 lines

simd_lastprivate_messages.cpp

4 lines

simd_linear_messages.cpp

4 lines

simd_private_messages.cpp

4 lines

simd_reduction_messages.cpp

2 lines

simd_safelen_messages.cpp

2 lines

simd_simdlen_messages.cpp

2 lines

single_copyprivate_messages.cpp

4 lines

single_firstprivate_messages.cpp

4 lines

single_private_messages.cpp

4 lines

target_data_device_messages.cpp

2 lines

target_data_if_messages.cpp

2 lines

target_device_messages.cpp

2 lines

target_enter_data_device_messages.cpp

2 lines

target_enter_data_if_messages.cpp

2 lines

target_exit_data_device_messages.cpp

2 lines

target_exit_data_if_messages.cpp

2 lines

target_firstprivate_messages.cpp

4 lines

target_if_messages.cpp

4 lines

target_map_messages.cpp

4 lines

target_ompx_dyn_cgroup_mem_messages.cpp

4 lines

target_parallel_device_messages.cpp

2 lines

target_parallel_firstprivate_messages.cpp

2 lines

target_parallel_for_collapse_messages.cpp

2 lines

target_parallel_for_device_messages.cpp

2 lines

target_parallel_for_firstprivate_messages.cpp

4 lines

target_parallel_for_if_messages.cpp

4 lines

target_parallel_for_lastprivate_messages.cpp

4 lines

target_parallel_for_linear_messages.cpp

4 lines

target_parallel_for_map_messages.cpp

4 lines

target_parallel_for_num_threads_messages.cpp

2 lines

target_parallel_for_ordered_messages.cpp

2 lines

target_parallel_for_private_messages.cpp

4 lines

target_parallel_for_reduction_messages.cpp

2 lines

target_parallel_for_schedule_messages.cpp

2 lines

target_parallel_for_simd_aligned_messages.cpp

4 lines

target_parallel_for_simd_collapse_messages.cpp

2 lines

target_parallel_for_simd_device_messages.cpp

2 lines

target_parallel_for_simd_firstprivate_messages.cpp

4 lines

target_parallel_for_simd_if_messages.cpp

4 lines

target_parallel_for_simd_lastprivate_messages.cpp

4 lines

target_parallel_for_simd_linear_messages.cpp

4 lines

target_parallel_for_simd_map_messages.cpp

4 lines

target_parallel_for_simd_num_threads_messages.cpp

2 lines

target_parallel_for_simd_ordered_messages.cpp

2 lines

target_parallel_for_simd_private_messages.cpp

4 lines

target_parallel_for_simd_reduction_messages.cpp

2 lines

target_parallel_for_simd_safelen_messages.cpp

2 lines

target_parallel_for_simd_schedule_messages.cpp

2 lines

target_parallel_for_simd_simdlen_messages.cpp

2 lines

target_parallel_if_messages.cpp

4 lines

target_parallel_map_messages.cpp

4 lines

target_parallel_num_threads_messages.cpp

2 lines

target_parallel_private_messages.cpp

4 lines

target_parallel_reduction_messages.cpp

2 lines

target_parallel_shared_messages.cpp

2 lines

target_private_messages.cpp

4 lines

target_reduction_messages.cpp

2 lines

target_simd_aligned_messages.cpp

4 lines

target_simd_collapse_messages.cpp

2 lines

target_simd_device_messages.cpp

2 lines

target_simd_firstprivate_messages.cpp

4 lines

target_simd_if_messages.cpp

4 lines

target_simd_lastprivate_messages.cpp

4 lines

target_simd_linear_messages.cpp

4 lines

target_simd_map_messages.cpp

4 lines

target_simd_private_messages.cpp

4 lines

target_simd_reduction_messages.cpp

2 lines

target_simd_safelen_messages.cpp

2 lines

target_simd_simdlen_messages.cpp

2 lines

target_teams_device_messages.cpp

2 lines

target_teams_distribute_collapse_messages.cpp

2 lines

target_teams_distribute_device_messages.cpp

2 lines

target_teams_distribute_dist_schedule_messages.cpp

4 lines

target_teams_distribute_firstprivate_messages.cpp

2 lines

target_teams_distribute_if_messages.cpp

4 lines

target_teams_distribute_lastprivate_messages.cpp

4 lines

target_teams_distribute_map_messages.cpp

4 lines

target_teams_distribute_num_teams_messages.cpp

4 lines

target_teams_distribute_parallel_for_collapse_messages.cpp

2 lines

target_teams_distribute_parallel_for_device_messages.cpp

2 lines

target_teams_distribute_parallel_for_dist_schedule_messages.cpp

4 lines

target_teams_distribute_parallel_for_firstprivate_messages.cpp

2 lines

target_teams_distribute_parallel_for_if_messages.cpp

4 lines

target_teams_distribute_parallel_for_lastprivate_messages.cpp

4 lines

target_teams_distribute_parallel_for_map_messages.cpp

4 lines

target_teams_distribute_parallel_for_num_teams_messages.cpp

4 lines

target_teams_distribute_parallel_for_num_threads_messages.cpp

2 lines

target_teams_distribute_parallel_for_private_messages.cpp

2 lines

target_teams_distribute_parallel_for_reduction_messages.cpp

2 lines

target_teams_distribute_parallel_for_schedule_messages.cpp

2 lines

target_teams_distribute_parallel_for_shared_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_aligned_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_collapse_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_device_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_dist_schedule_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_firstprivate_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_if_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_lastprivate_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_linear_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_map_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_num_teams_messages.cpp

4 lines

target_teams_distribute_parallel_for_simd_num_threads_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_private_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_reduction_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_safelen_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_schedule_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_shared_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_simdlen_messages.cpp

2 lines

target_teams_distribute_parallel_for_simd_thread_limit_messages.cpp

4 lines

target_teams_distribute_parallel_for_thread_limit_messages.cpp

4 lines

target_teams_distribute_private_messages.cpp

2 lines

target_teams_distribute_reduction_messages.cpp

2 lines

target_teams_distribute_shared_messages.cpp

2 lines

target_teams_distribute_simd_aligned_messages.cpp

4 lines

target_teams_distribute_simd_collapse_messages.cpp

2 lines

target_teams_distribute_simd_device_messages.cpp

2 lines

target_teams_distribute_simd_dist_schedule_messages.cpp

4 lines

target_teams_distribute_simd_firstprivate_messages.cpp

2 lines

target_teams_distribute_simd_if_messages.cpp

4 lines

target_teams_distribute_simd_lastprivate_messages.cpp

4 lines

target_teams_distribute_simd_linear_messages.cpp

4 lines

target_teams_distribute_simd_map_messages.cpp

4 lines

target_teams_distribute_simd_num_teams_messages.cpp

4 lines

target_teams_distribute_simd_private_messages.cpp

2 lines

target_teams_distribute_simd_reduction_messages.cpp

2 lines

target_teams_distribute_simd_safelen_messages.cpp

2 lines

target_teams_distribute_simd_shared_messages.cpp

2 lines

target_teams_distribute_simd_simdlen_messages.cpp

2 lines

target_teams_distribute_simd_thread_limit_messages.cpp

4 lines

target_teams_firstprivate_messages.cpp

2 lines

target_teams_if_messages.cpp

4 lines

target_teams_map_messages.cpp

4 lines

target_teams_num_teams_messages.cpp

4 lines

target_teams_private_messages.cpp

2 lines

target_teams_reduction_messages.cpp

2 lines

target_teams_shared_messages.cpp

2 lines

target_teams_thread_limit_messages.cpp

4 lines

target_update_device_messages.cpp

4 lines

target_update_from_messages.cpp

4 lines

target_update_if_messages.cpp

4 lines

target_update_to_messages.cpp

4 lines

target_uses_allocators_messages.cpp

4 lines

task_final_messages.cpp

4 lines

task_firstprivate_messages.cpp

2 lines

task_if_messages.cpp

4 lines

task_in_reduction_message.cpp

2 lines

task_priority_messages.cpp

4 lines

task_private_messages.cpp

2 lines

task_shared_messages.cpp

2 lines

taskgroup_task_reduction_messages.cpp

2 lines

taskloop_collapse_messages.cpp

2 lines

taskloop_final_messages.cpp

4 lines

taskloop_firstprivate_messages.cpp

4 lines

taskloop_grainsize_messages.cpp

4 lines

taskloop_in_reduction_messages.cpp

2 lines

taskloop_lastprivate_messages.cpp

4 lines

taskloop_num_tasks_messages.cpp

4 lines

taskloop_priority_messages.cpp

4 lines

taskloop_private_messages.cpp

4 lines

taskloop_reduction_messages.cpp

2 lines

taskloop_simd_aligned_messages.cpp

4 lines

taskloop_simd_collapse_messages.cpp

2 lines

taskloop_simd_final_messages.cpp

4 lines

taskloop_simd_firstprivate_messages.cpp

4 lines

taskloop_simd_grainsize_messages.cpp

4 lines

taskloop_simd_in_reduction_messages.cpp

2 lines

taskloop_simd_lastprivate_messages.cpp

4 lines

taskloop_simd_linear_messages.cpp

4 lines

taskloop_simd_num_tasks_messages.cpp

4 lines

taskloop_simd_priority_messages.cpp

4 lines

taskloop_simd_private_messages.cpp

4 lines

taskloop_simd_reduction_messages.cpp

2 lines

taskloop_simd_safelen_messages.cpp

2 lines

taskloop_simd_simdlen_messages.cpp

2 lines

teams_distribute_collapse_messages.cpp

2 lines

teams_distribute_dist_schedule_messages.cpp

4 lines

teams_distribute_firstprivate_messages.cpp

2 lines

teams_distribute_lastprivate_messages.cpp

4 lines

teams_distribute_num_teams_messages.cpp

4 lines

teams_distribute_parallel_for_collapse_messages.cpp

2 lines

teams_distribute_parallel_for_copyin_messages.cpp

2 lines

teams_distribute_parallel_for_dist_schedule_messages.cpp

4 lines

teams_distribute_parallel_for_firstprivate_messages.cpp

2 lines

teams_distribute_parallel_for_if_messages.cpp

4 lines

teams_distribute_parallel_for_lastprivate_messages.cpp

4 lines

teams_distribute_parallel_for_num_teams_messages.cpp

4 lines

teams_distribute_parallel_for_private_messages.cpp

2 lines

teams_distribute_parallel_for_reduction_messages.cpp

2 lines

teams_distribute_parallel_for_schedule_messages.cpp

2 lines

teams_distribute_parallel_for_shared_messages.cpp

2 lines

teams_distribute_parallel_for_simd_aligned_messages.cpp

4 lines

teams_distribute_parallel_for_simd_collapse_messages.cpp

2 lines

teams_distribute_parallel_for_simd_dist_schedule_messages.cpp

4 lines

teams_distribute_parallel_for_simd_firstprivate_messages.cpp

2 lines

teams_distribute_parallel_for_simd_if_messages.cpp

4 lines

teams_distribute_parallel_for_simd_lastprivate_messages.cpp

4 lines

teams_distribute_parallel_for_simd_linear_messages.cpp

4 lines

teams_distribute_parallel_for_simd_num_teams_messages.cpp

4 lines

teams_distribute_parallel_for_simd_num_teams_messages_attr.cpp

4 lines

teams_distribute_parallel_for_simd_num_threads_messages.cpp

2 lines

teams_distribute_parallel_for_simd_private_messages.cpp

2 lines

teams_distribute_parallel_for_simd_reduction_messages.cpp

2 lines

teams_distribute_parallel_for_simd_safelen_messages.cpp

2 lines

teams_distribute_parallel_for_simd_shared_messages.cpp

2 lines

teams_distribute_parallel_for_simd_simdlen_messages.cpp

2 lines

teams_distribute_parallel_for_simd_thread_limit_messages.cpp

4 lines

teams_distribute_parallel_for_thread_limit_messages.cpp

4 lines

teams_distribute_private_messages.cpp

2 lines

teams_distribute_reduction_messages.cpp

2 lines

teams_distribute_shared_messages.cpp

2 lines

teams_distribute_simd_aligned_messages.cpp

4 lines

teams_distribute_simd_collapse_messages.cpp

2 lines

teams_distribute_simd_dist_schedule_messages.cpp

4 lines

teams_distribute_simd_firstprivate_messages.cpp

2 lines

teams_distribute_simd_if_messages.cpp

4 lines

teams_distribute_simd_lastprivate_messages.cpp

4 lines

teams_distribute_simd_linear_messages.cpp

4 lines

teams_distribute_simd_num_teams_messages.cpp

4 lines

teams_distribute_simd_private_messages.cpp

2 lines

teams_distribute_simd_reduction_messages.cpp

2 lines

teams_distribute_simd_safelen_messages.cpp

2 lines

teams_distribute_simd_shared_messages.cpp

2 lines

teams_distribute_simd_simdlen_messages.cpp

2 lines

teams_distribute_simd_thread_limit_messages.cpp

4 lines

teams_distribute_thread_limit_messages.cpp

4 lines

teams_firstprivate_messages.cpp

2 lines

teams_num_teams_messages.cpp

4 lines

teams_private_messages.cpp

2 lines

teams_reduction_messages.cpp

2 lines

teams_shared_messages.cpp

2 lines

teams_thread_limit_messages.cpp

4 lines

Parser/

cxx-attributes.cpp

2 lines

cxx2a-init-statement.cpp

2 lines

Sema/

6 lines

2 lines

4 lines

2 lines

20 lines

34 lines

22 lines

6 lines

2 lines

builtin-classify-type.c

38 lines

6 lines

10 lines

2 lines

4 lines

24 lines

constant-builtins-2.c

110 lines

constant-builtins.c

6 lines

designated-initializers.c

2 lines

2 lines

10 lines

12 lines

6 lines

18 lines

8 lines

4 lines

8 lines

2 lines

12 lines

6 lines

33 lines

pragma-align-mac68k.c

70 lines

pragma-align-packed.c

10 lines

2 lines

14 lines

4 lines

14 lines

4 lines

pragma-pack-and-options-align.c

12 lines

2 lines

2 lines

2 lines

6 lines

sizeof-struct-non-zero-as-member.cl

8 lines

struct-packed-align.c

84 lines

2 lines

2 lines

4 lines

2 lines

2 lines

26 lines

2 lines

SemaCUDA/

amdgpu-attrs.cu

4 lines

SemaCXX/

Inputs/

12 lines

2 lines

26 lines

6 lines

4 lines

builtin-classify-type.cpp

44 lines

constant-conversion.cpp

4 lines

constant-expression-cxx11.cpp

22 lines

constant-expression-cxx14.cpp

2 lines

constant-expression-cxx2a.cpp

2 lines

constexpr-depth.cpp

2 lines

constexpr-string.cpp

2 lines

constexpr-turing-cxx2a.cpp

2 lines

constexpr-turing.cpp

8 lines

cxx11-user-defined-literals.cpp

2 lines

cxx1y-generic-lambdas-capturing.cpp

6 lines

cxx2a-adl-only-template-id.cpp

4 lines

dcl_init_aggr.cpp

2 lines

integer-overflow.cpp

8 lines

issue547.cpp

8 lines

member-pointer-size.cpp

4 lines

2 lines

8 lines

8 lines

2 lines

2 lines

8 lines

2 lines

warn-thread-safety-analysis.cpp

12 lines

warn-unused-comparison.cpp

10 lines

warn-zero-nullptr-cxx20.cpp

4 lines

wchar_t.cpp

2 lines

SemaObjC/

conditional-expr-8.m

2 lines

enum-fixed-type.m

4 lines

exprs.m

2 lines

format-strings-objc.m

2 lines

pragma-pack.m

2 lines

SemaTemplate/

ackermann.cpp

2 lines

address_space-dependent.cpp

2 lines

alignas.cpp

2 lines

constexpr-instantiate.cpp

2 lines

deduction.cpp

4 lines

dependent-names.cpp

2 lines

dependent-sized_array.cpp

2 lines

dependent-template-recover.cpp

2 lines

2 lines

8 lines

2 lines

12 lines

instantiate-declref-ice.cpp

6 lines

instantiate-expr-5.cpp

4 lines

instantiate-field.cpp

2 lines

instantiate-static-var.cpp

2 lines

instantiate-var-template.cpp

2 lines

instantiation-dependence.cpp

4 lines

matrix-type.cpp

8 lines

pragma-ms_struct.cpp

2 lines

temp_arg_template.cpp

2 lines

temp_class_order.cpp

8 lines

temp_class_spec.cpp

2 lines

libcxx/

include/

__chrono/

duration.h

2 lines

strstream

4 lines

src/

filesystem/

operations.cpp

6 lines

locale.cpp

24 lines

memory_resource.cpp

4 lines

ryu/

d2fixed.cpp

6 lines

f2s.cpp

2 lines

test/

libcxx/

algorithms/

nth_element_stability.pass.cpp

6 lines

partial_sort_stability.pass.cpp

6 lines

sort_stability.pass.cpp

6 lines

libcxxabi/

src/

cxa_default_handlers.cpp

7 lines

cxa_demangle.cpp

2 lines

cxa_exception.cpp

4 lines

cxa_personality.cpp

16 lines

demangle/

ItaniumDemangle.h

4 lines

Diff 517042

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 229 Lines • ▼ Show 20 Lines

- Clang's "static assertion failed" diagnostic now points to the static assertion

(`#61951 <https://github.com/llvm/llvm-project/issues/61951>`_)

- ``-Wformat`` now recognizes ``%lb`` for the ``printf``/``scanf`` family of

functions.

(`#62247: <https://github.com/llvm/llvm-project/issues/62247>`_).

Bug Fixes in This Version

-------------------------

- Fix crash when diagnosing incorrect usage of ``_Nullable`` involving alias

templates.

(`#60344 <https://github.com/llvm/llvm-project/issues/60344>`_)

aaron.ballmanUnsubmitted

Not Done

It looks like your rebase may have pulled in unintended changes.

aaron.ballman: It looks like your rebase may have pulled in unintended changes.

- Fix confusing warning message when ``/clang:-x`` is passed in ``clang-cl``

driver mode and emit an error which suggests using ``/TC`` or ``/TP``

``clang-cl`` options instead.

(`#59307 <https://github.com/llvm/llvm-project/issues/59307>`_)

- Fix assert that fails when the expression causing the this pointer to be

captured by a block is part of a constexpr if statement's branch and

instantiation of the enclosing method causes the branch to be discarded.

- Fix __VA_OPT__ implementation so that it treats the concatenation of a

▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines

- Fix defaulted equality operator so that it does not attempt to compare unnamed

(`#61355 <https://github.com/llvm/llvm-project/issues/61335>`_) and

(`#61417 <https://github.com/llvm/llvm-project/issues/61417>`_)

- Fix crash after suggesting typo correction to constexpr if condition.

(`#61885 <https://github.com/llvm/llvm-project/issues/61885>`_)

- Clang constexpr evaluator now treats comparison of [[gnu::weak]]-attributed

member pointer as an invalid expression.

- Fix crash when member function contains invalid default argument.

(`#62122 <https://github.com/llvm/llvm-project/issues/62122>`_)

- Print diagnostic warning about precedence when integer expression is used

without parentheses in an conditional operator expression

aaron.ballmanUnsubmitted

Done

(`#62305 <https://github.com/llvm/llvm-project/issues/62305>`_)

- (`#62305 <https://github.com/llvm/llvm-project/issues/62305>`_)

- Print diagnostic warning about precedence when integer expression is used

without parentheses in an conditional operator expression

It looks like a rebase accidentally duplicated this line.

aaron.ballman: It looks like a rebase accidentally duplicated this line.

(`#61943 <https://github.com/llvm/llvm-project/issues/61943>`_)

Bug Fixes to Compiler Builtins

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Bug Fixes to Attribute Support

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Bug Fixes to C++ Support

▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expressionNeeds ReviewPublic

Details

Diff Detail

Unit TestsFailed

Event Timeline

Large Diff

Revision Contents

Diff 517042

clang/docs/ReleaseNotes.rst

clang/lib/Sema/SemaExpr.cpp

clang/test/AST/Interp/constexpr-nqueens.cpp

clang/test/AST/Interp/literals.cpp

clang/test/Analysis/copypaste/macro-complexity.cpp

clang/test/Analysis/cxx-uninitialized-object-unguarded-access.cpp

clang/test/Analysis/malloc-overflow.c

clang/test/Analysis/misc-ps.m

clang/test/Analysis/nullability.mm

clang/test/Analysis/runtime-regression.c

clang/test/Analysis/uninit-vals.c

clang/test/Analysis/use-after-move.cpp

clang/test/CXX/temp/temp.decls/temp.variadic/partial-ordering.cpp

clang/test/Frontend/macros.c

clang/test/OpenMP/cancel_if_messages.cpp

clang/test/OpenMP/distribute_collapse_messages.cpp

clang/test/OpenMP/distribute_dist_schedule_messages.cpp

clang/test/OpenMP/distribute_firstprivate_messages.cpp

clang/test/OpenMP/distribute_parallel_for_collapse_messages.cpp

clang/test/OpenMP/distribute_parallel_for_copyin_messages.cpp

clang/test/OpenMP/distribute_parallel_for_dist_schedule_messages.cpp

clang/test/OpenMP/distribute_parallel_for_firstprivate_messages.cpp

clang/test/OpenMP/distribute_parallel_for_if_messages.cpp

clang/test/OpenMP/distribute_parallel_for_lastprivate_messages.cpp

clang/test/OpenMP/distribute_parallel_for_num_threads_messages.cpp

clang/test/OpenMP/distribute_parallel_for_private_messages.cpp

clang/test/OpenMP/distribute_parallel_for_reduction_messages.cpp

clang/test/OpenMP/distribute_parallel_for_schedule_messages.cpp

clang/test/OpenMP/distribute_parallel_for_shared_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_aligned_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_collapse_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_copyin_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_dist_schedule_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_firstprivate_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_if_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_lastprivate_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_linear_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_num_threads_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_private_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_reduction_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_safelen_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_schedule_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_shared_messages.cpp

clang/test/OpenMP/distribute_parallel_for_simd_simdlen_messages.cpp

clang/test/OpenMP/distribute_private_messages.cpp

clang/test/OpenMP/distribute_simd_aligned_messages.cpp

clang/test/OpenMP/distribute_simd_collapse_messages.cpp

clang/test/OpenMP/distribute_simd_dist_schedule_messages.cpp

clang/test/OpenMP/distribute_simd_firstprivate_messages.cpp

clang/test/OpenMP/distribute_simd_if_messages.cpp

clang/test/OpenMP/distribute_simd_lastprivate_messages.cpp

clang/test/OpenMP/distribute_simd_linear_messages.cpp

clang/test/OpenMP/distribute_simd_private_messages.cpp

clang/test/OpenMP/distribute_simd_reduction_messages.cpp

clang/test/OpenMP/distribute_simd_safelen_messages.cpp

clang/test/OpenMP/distribute_simd_simdlen_messages.cpp

clang/test/OpenMP/for_collapse_messages.cpp

clang/test/OpenMP/for_firstprivate_messages.cpp

clang/test/OpenMP/for_lastprivate_messages.cpp

clang/test/OpenMP/for_linear_messages.cpp

clang/test/OpenMP/for_ordered_clause.cpp

clang/test/OpenMP/for_private_messages.cpp

clang/test/OpenMP/for_reduction_messages.cpp

clang/test/OpenMP/for_schedule_messages.cpp

clang/test/OpenMP/for_simd_aligned_messages.cpp

clang/test/OpenMP/for_simd_collapse_messages.cpp

clang/test/OpenMP/for_simd_firstprivate_messages.cpp

clang/test/OpenMP/for_simd_if_messages.cpp

clang/test/OpenMP/for_simd_lastprivate_messages.cpp

clang/test/OpenMP/for_simd_linear_messages.cpp

clang/test/OpenMP/for_simd_private_messages.cpp

[clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression
Needs ReviewPublic