Page MenuHomePhabricator
People gedare

gedare (Gedare Bloom)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2022, 5:44 PM (12 w, 6 d)

Recent Activity
View All

Dec 5 2022

gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.
In D137762#3969770, @owenpan wrote:

@gedare do you need us to commit this patch on your behalf (using "Gedare Bloom <gedare@rtems.org>")?

Dec 5 2022, 8:38 PM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2022

gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.

I have changed the code as recommended by @owenpan with new unit tests passing, and reverting the modifications to existing unit tests. Someone else may janitor the EXPECT_EQ blocks separately.

Nov 17 2022, 11:41 AM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.
  • fixup: use simpler logic for handling rparens
  • Revert "fixup: port other EXPECT_EQ to verifyFormat"
Nov 17 2022, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
gedare added inline comments to D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 17 2022, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2022

gedare added inline comments to D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 14 2022, 5:30 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.
  • FormatTest: restore Input variable to one test
Nov 14 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.
  • fixup: unit test formatting
Nov 14 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.
  • fixup: replace EXPECT_EQ with verifyFormat
  • fixup: port other EXPECT_EQ to verifyFormat
Nov 14 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Nov 11 2022

gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.

I've added unit tests and confirmed (1) the new tests fail on current main and (2) all unit tests pass with this revision applied.

[100%] Running lit suite /llvm-project/clang/test/Unit
Nov 11 2022, 5:35 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.
  • fixup typo in unit test
Nov 11 2022, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

Refactor horrible to read logic

Nov 11 2022, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

add unit tests for BlockIndent

Nov 11 2022, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
gedare added inline comments to D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 11 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

Address review comments

Nov 11 2022, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

Run tests and fix bad breaks. Fix comment style.

Nov 11 2022, 11:18 AM · Restricted Project, Restricted Project, Restricted Project

Nov 10 2022

gedare added inline comments to D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 10 2022, 9:56 PM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.

Another test case for function pointers is here:

tmp.c237 BDownload

Nov 9 2022, 9:44 PM · Restricted Project, Restricted Project, Restricted Project
gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.

A test case from the GitHub Issue https://github.com/llvm/llvm-project/issues/57250 is attached here:

test.c363 BDownload

Nov 9 2022, 9:34 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

Add a fix to enable breaking for continuation after a )(

Nov 9 2022, 9:28 PM · Restricted Project, Restricted Project, Restricted Project
gedare updated the diff for D137762: [clang-format] avoid breaking )( with BlockIndent.

Allow line breaks in a continuation with BlockIndent after )(

Nov 9 2022, 9:26 PM · Restricted Project, Restricted Project, Restricted Project
gedare added a comment to D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 9 2022, 9:09 PM · Restricted Project, Restricted Project, Restricted Project
gedare edited projects for D137762: [clang-format] avoid breaking )( with BlockIndent, added: Restricted Project, Restricted Project; removed Restricted Project.
Nov 9 2022, 8:46 PM · Restricted Project, Restricted Project, Restricted Project
gedare requested review of D137762: [clang-format] avoid breaking )( with BlockIndent.
Nov 9 2022, 8:44 PM · Restricted Project, Restricted Project, Restricted Project