Page MenuHomePhabricator
People cjdb

cjdb (Christopher Di Bella)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2017, 5:18 AM (169 w, 2 d)

Recent Activity
View All

Mon, Jun 22

cjdb added a reviewer for D80902: [libcxx] adds lexicographical_compare_three_way: Restricted Project.
Mon, Jun 22, 9:39 AM · Restricted Project
cjdb added a comment to D80899: [libcxx] adds std::compare_three_way.

Ping.

Mon, Jun 22, 9:39 AM · Restricted Project
cjdb added a reviewer for D80899: [libcxx] adds std::compare_three_way: Restricted Project.
Mon, Jun 22, 9:39 AM · Restricted Project
cjdb added a comment to D80895: [libcxx] adds operator<=> for basic_string.

Ping.

Mon, Jun 22, 9:39 AM
cjdb added a comment to D80891: [libcxx] adds operator<=> for basic_string_view.

Ping.

Mon, Jun 22, 9:39 AM
cjdb added a reviewer for D80895: [libcxx] adds operator<=> for basic_string: Restricted Project.
Mon, Jun 22, 9:39 AM

Thu, Jun 18

cjdb added reviewers for D80891: [libcxx] adds operator<=> for basic_string_view: miscco, Restricted Project.
Thu, Jun 18, 11:27 AM
cjdb updated the diff for D80891: [libcxx] adds operator<=> for basic_string_view.
Thu, Jun 18, 9:13 AM
cjdb added a comment to D80891: [libcxx] adds operator<=> for basic_string_view.

I think all the comments requesting changes have been addressed now. @miscco @EricWF could you please confirm?

Thu, Jun 18, 9:13 AM
cjdb updated the diff for D80891: [libcxx] adds operator<=> for basic_string_view.

Rebases on D81823.

Thu, Jun 18, 9:13 AM

Wed, Jun 17

cjdb added a comment to D81823: adds equality for spaceship types for themselves.

@ldionne is there anything that remains to be done on my end, or do I just need to sit tight for now?

Wed, Jun 17, 12:24 PM · Restricted Project

Mon, Jun 15

cjdb updated the diff for D81823: adds equality for spaceship types for themselves.

Is there nothing in cxx2a_status.html that needs updating?

Mon, Jun 15, 5:08 PM · Restricted Project
cjdb added a comment to D81823: adds equality for spaceship types for themselves.

Thanks @EricWF. Assuming your approval is synonymous with LGTM, is there anything actionable on my end before someone with write access commits it?

Mon, Jun 15, 12:36 PM · Restricted Project
cjdb added a reviewer for D81823: adds equality for spaceship types for themselves: Restricted Project.
Mon, Jun 15, 9:14 AM · Restricted Project
cjdb updated subscribers of D81823: adds equality for spaceship types for themselves.

Thanks @miscco! Hoping this lands very soon.

Mon, Jun 15, 9:13 AM · Restricted Project

Sun, Jun 14

cjdb updated the diff for D81823: adds equality for spaceship types for themselves.
Sun, Jun 14, 10:55 PM · Restricted Project
cjdb created D81823: adds equality for spaceship types for themselves.
Sun, Jun 14, 10:55 PM · Restricted Project

Sat, Jun 13

cjdb updated the diff for D80902: [libcxx] adds lexicographical_compare_three_way.
Sat, Jun 13, 7:44 PM · Restricted Project
cjdb added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
Sat, Jun 13, 7:13 PM · Restricted Project
cjdb updated the diff for D80902: [libcxx] adds lexicographical_compare_three_way.
Sat, Jun 13, 7:13 PM · Restricted Project

Jun 9 2020

cjdb updated the diff for D80891: [libcxx] adds operator<=> for basic_string_view.

Applies @EricWF's comments.

Jun 9 2020, 5:42 PM
cjdb added inline comments to D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 9 2020, 5:42 PM
cjdb added inline comments to D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 9 2020, 1:48 PM
cjdb updated the diff for D80891: [libcxx] adds operator<=> for basic_string_view.

Fixes some of @EricWF's comments.

Jun 9 2020, 1:48 PM

Jun 3 2020

cjdb updated the diff for D80895: [libcxx] adds operator<=> for basic_string.
Jun 3 2020, 9:53 AM
cjdb added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 3 2020, 9:53 AM

Jun 2 2020

cjdb added reviewers for D80895: [libcxx] adds operator<=> for basic_string: jfb, mpark.
Jun 2 2020, 6:40 PM
cjdb removed a reviewer for D80902: [libcxx] adds lexicographical_compare_three_way: mpark.
Jun 2 2020, 6:40 PM · Restricted Project
cjdb added a reviewer for D80902: [libcxx] adds lexicographical_compare_three_way: mpark.
Jun 2 2020, 6:40 PM · Restricted Project
cjdb added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 2 2020, 6:07 PM · Restricted Project
cjdb updated the diff for D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 2 2020, 6:07 PM · Restricted Project
cjdb updated the diff for D80902: [libcxx] adds lexicographical_compare_three_way.

Applies some of @curdeius's suggestions.

Jun 2 2020, 6:07 PM · Restricted Project

Jun 1 2020

cjdb added inline comments to D80904: [libcxx] adds spaceship for vector.
Jun 1 2020, 9:39 AM · Restricted Project
cjdb added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 1 2020, 9:10 AM · Restricted Project
cjdb updated the diff for D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 1 2020, 9:10 AM · Restricted Project
cjdb updated the diff for D80899: [libcxx] adds std::compare_three_way.
Jun 1 2020, 9:06 AM · Restricted Project
cjdb added inline comments to D80899: [libcxx] adds std::compare_three_way.
Jun 1 2020, 9:06 AM · Restricted Project
cjdb added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 1 2020, 8:37 AM
cjdb updated the diff for D80895: [libcxx] adds operator<=> for basic_string.

Applies @miscco's suggestions.

Jun 1 2020, 8:37 AM
cjdb added a comment to D80891: [libcxx] adds operator<=> for basic_string_view.

Thanks @miscco!

Jun 1 2020, 8:33 AM
cjdb updated the diff for D80891: [libcxx] adds operator<=> for basic_string_view.

Applies @miscco's suggestions.

Jun 1 2020, 8:33 AM

May 31 2020

cjdb added a parent revision for D80904: [libcxx] adds spaceship for vector: D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 5:49 PM · Restricted Project
cjdb added a child revision for D80902: [libcxx] adds lexicographical_compare_three_way: D80904: [libcxx] adds spaceship for vector.
May 31 2020, 5:49 PM · Restricted Project
cjdb created D80904: [libcxx] adds spaceship for vector.
May 31 2020, 5:49 PM · Restricted Project
cjdb created D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 3:26 PM · Restricted Project
cjdb added a parent revision for D80902: [libcxx] adds lexicographical_compare_three_way: D80899: [libcxx] adds std::compare_three_way.
May 31 2020, 3:26 PM · Restricted Project
cjdb added a child revision for D80899: [libcxx] adds std::compare_three_way: D80902: [libcxx] adds lexicographical_compare_three_way.
May 31 2020, 3:26 PM · Restricted Project
cjdb created D80899: [libcxx] adds std::compare_three_way.
May 31 2020, 2:38 PM · Restricted Project
cjdb added a child revision for D80891: [libcxx] adds operator<=> for basic_string_view: D80895: [libcxx] adds operator<=> for basic_string.
May 31 2020, 12:14 PM
cjdb added a parent revision for D80895: [libcxx] adds operator<=> for basic_string: D80891: [libcxx] adds operator<=> for basic_string_view.
May 31 2020, 12:14 PM
cjdb created D80895: [libcxx] adds operator<=> for basic_string.
May 31 2020, 12:14 PM
cjdb created D80891: [libcxx] adds operator<=> for basic_string_view.
May 31 2020, 11:10 AM

Apr 17 2020

cjdb added inline comments to D77961: WIP: Adds `std::convertible_to` to <concepts>.
Apr 17 2020, 9:42 AM · Restricted Project

Apr 11 2020

cjdb added a child revision for D74292: [libcxx] adds [concept.derived]: D77961: WIP: Adds `std::convertible_to` to <concepts>.
Apr 11 2020, 10:56 PM
cjdb added a parent revision for D77961: WIP: Adds `std::convertible_to` to <concepts>: D74292: [libcxx] adds [concept.derived].
Apr 11 2020, 10:56 PM · Restricted Project
cjdb created D77961: WIP: Adds `std::convertible_to` to <concepts>.
Apr 11 2020, 10:23 PM · Restricted Project

Apr 9 2020

cjdb added inline comments to D74292: [libcxx] adds [concept.derived].
Apr 9 2020, 9:20 AM

Apr 8 2020

cjdb added inline comments to D74292: [libcxx] adds [concept.derived].
Apr 8 2020, 10:40 PM
cjdb updated the diff for D74292: [libcxx] adds [concept.derived].

Updates tests to check for fundamental(ish) types, cv-qualifiers, references, pointers, void, functions, pointer-to-functions, reference-to-functions, pointer-to-member(-functions), and arrays.

Apr 8 2020, 9:03 PM

Apr 7 2020

cjdb updated the diff for D74291: [libcxx] Adds [concept.same].

Applies changes to comments made by @EricWF and @miscco.

Apr 7 2020, 10:18 PM

Mar 31 2020

cjdb updated the diff for D74291: [libcxx] Adds [concept.same].

Rebased according to 08682dcc863.

Mar 31 2020, 12:33 PM

Feb 16 2020

cjdb added inline comments to D74291: [libcxx] Adds [concept.same].
Feb 16 2020, 9:16 PM

Feb 12 2020

cjdb added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 12 2020, 2:42 PM · Restricted Project
cjdb added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 12 2020, 11:28 AM · Restricted Project

Feb 10 2020

cjdb updated the diff for D74291: [libcxx] Adds [concept.same].
Feb 10 2020, 8:49 PM
cjdb added inline comments to D74291: [libcxx] Adds [concept.same].
Feb 10 2020, 8:49 PM
cjdb added inline comments to D74351: [libcxx][type_traits] Implement C++20 common_ref.
Feb 10 2020, 8:01 PM · Restricted Project

Feb 8 2020

cjdb added a parent revision for D74292: [libcxx] adds [concept.derived]: D74291: [libcxx] Adds [concept.same].
Feb 8 2020, 9:23 PM
cjdb added a child revision for D74291: [libcxx] Adds [concept.same]: D74292: [libcxx] adds [concept.derived].
Feb 8 2020, 9:23 PM
cjdb created D74292: [libcxx] adds [concept.derived].
Feb 8 2020, 9:16 PM
cjdb updated the diff for D74291: [libcxx] Adds [concept.same].
Feb 8 2020, 8:29 PM
cjdb updated the diff for D74291: [libcxx] Adds [concept.same].

Added a check for constness and removed some Unicode zero-width joiners.

Feb 8 2020, 8:29 PM
cjdb created D74291: [libcxx] Adds [concept.same].
Feb 8 2020, 4:59 PM