Page MenuHomePhabricator

cjdb (Christopher Di Bella)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2017, 5:18 AM (267 w, 3 d)

Recent Activity

Today

cjdb added inline comments to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Fri, May 27, 3:04 PM · Unknown Object (Project), Restricted Project
cjdb updated the diff for D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

replaces vector<signed char> with vector<bool>

Fri, May 27, 2:59 PM · Unknown Object (Project), Restricted Project

Wed, May 25

cjdb added inline comments to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Wed, May 25, 8:41 AM · Unknown Object (Project), Restricted Project

Tue, May 24

cjdb updated the diff for D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

re-adds header to modulemap, fixes test to work in C++03 mode (apparently lambdas aren't backported)

Tue, May 24, 5:08 PM · Unknown Object (Project), Restricted Project
cjdb updated the diff for D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

adds test to improve confidence

Tue, May 24, 4:42 PM · Unknown Object (Project), Restricted Project
cjdb added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

I'm not sure why there's so much resistance to reverting. libc++:

  1. has users with broken code right now;
  2. actively supports uniform_int_distribution<__int128_t>, which is also undefined (I don't get why you consider signed char, unsigned char, char, and bool to be problematic, but not __int128_t and unsigned __int128_t);
  3. has licence to make it an extension without Microsoft/STL's support;

You can also propose standardising this right now.

I don't know whether our distributions actually work with these types. This explicit rejection was added in D114920, which was itself prompted by discussions on D114129, whose goal was to fix http://llvm.org/PR51520 (an overflow in uniform_int_distribution<__int128_t>). What tells us that we don't have similar problems with uniform_int_distribution<char> & friends. They are not tested, so anything is possible. Then, add the fact that the Standard made those undefined, which I consider a red flag; without diving into the implementation of those distributions, I'm thinking there might be a good reason why they didn't require implementations to support those types, e.g. maybe the usual algorithms don't work properly for types of that size.

So, given this uncertainty, I think it's better for everyone (our users especially) to get this compile-time error. However, if this patch showed that our implementation indeed supports these types properly, it would become a simple question of "do we want to support them as an extension, like we do for __int128_t", and that's easier to answer.

If you can add tests to show that distributions work with these types, I'd be OK with that. We still have until June 8th to cherry-pick to LLVM 14, so we could even backport to LLVM 14 and avoid breaking users for just one release (which would be very annoying indeed).

Tue, May 24, 12:42 PM · Unknown Object (Project), Restricted Project

Mon, May 23

cjdb added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

GCC ships this as an extension. I can't find a reason why the extension would be non-conforming or dangerous, and it seems like a safer way for users to generate char values, rather than expecting the user to correctly pass the numerical_limits<char>::max() to the constructor.
I think we should reach out to someone at Microsoft (maybe STL), and see how open they are to shipping this as an extension. If they're willing then we avoid the portability trap that we're trying to protect users from.

@CaseyCarter Would you be willing to, as an extension, support char in the random distributions? This is currently marked as being undefined by http://eel.is/c++draft/rand.req.genl#1. If you are willing, then I could also write a short paper to suggest adding it to the spec, since all three major implementations would support it.

Mon, May 23, 4:28 PM · Unknown Object (Project), Restricted Project

Sat, May 14

cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.

rebases for D116203's sake

Sat, May 14, 12:05 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.
  • fixes wchar_t (wasn't supported) and charX_t (all three went to an 8-bit type)
  • makes underlying type for signed wchar_t int rather than wchar_t
  • adds tests for these types
Sat, May 14, 11:51 AM · Restricted Project, Restricted Project

Fri, May 13

cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.

makes __is_destructible and __is_nothrow_destructible KEYCXX instead of KEYMS (attention @aaron.ballman)

Fri, May 13, 9:54 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

rebases

Fri, May 13, 1:08 PM · Restricted Project, Restricted Project
cjdb added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Fri, May 13, 12:58 PM · Restricted Project, Restricted Project
cjdb added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Fri, May 13, 12:56 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

responds to the vast majority of open feedback

Fri, May 13, 12:56 PM · Restricted Project, Restricted Project

Wed, May 11

cjdb added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

@cjdb @CrystalSplitter I understand your frustration with something that "used to work" and doesn't anymore. My main concern is that there must be a reason why these types are disallowed in the first place -- did you try to investigate why there was such a restriction in the Standard in the first place? If you do, perhaps we can use the result of that investigation to better inform on whether we should support that extension (or just lift it and change the Standard).

Wed, May 11, 4:28 PM · Unknown Object (Project), Restricted Project
cjdb updated subscribers of D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

http://eel.is/c++draft/rand.req.genl#1 says that the effect of instantiating one of these templates with a type that isn't in <list-of-allowed-types> is undefined. That means it's undefined behavior, and we strive to catch cases where users rely on undefined behavior for various reasons, notably to make their code more portable (https://godbolt.org/z/E6oGjfjhP), but also because we can't guarantee what the behavior is for such inputs.

Wed, May 11, 11:13 AM · Unknown Object (Project), Restricted Project

Tue, May 10

cjdb added a comment to D125078: Implement a feature to show line numbers in diagnostics.

I support turning it on by default. I'm simply passing on the message.

Tue, May 10, 9:33 AM · Restricted Project, Restricted Project

Mon, May 9

cjdb added a reverting change for rGa3255f219a86: [libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.: D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Mon, May 9, 5:55 PM
cjdb requested review of D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Mon, May 9, 5:54 PM · Unknown Object (Project), Restricted Project
cjdb added a reverting change for D114920: [libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.: D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Mon, May 9, 5:54 PM · Unknown Object (Project)
cjdb updated subscribers of D125078: Implement a feature to show line numbers in diagnostics.

I'm in favour of this, but @rsmith warned me a little while ago that we mightn't be able to have stuff like this on by default because scripts probably depend on specific compiler output. Hyrum's Law strikes again :(

Mon, May 9, 9:16 AM · Restricted Project, Restricted Project

Fri, May 6

cjdb added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Thanks for working on this!

Fri, May 6, 11:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

cjdb accepted D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..

Thanks!

Apr 27 2022, 8:46 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.

fixes formatting

Apr 22 2022, 5:25 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.
  • handles VLAs
  • adds __is_referenceable which is used by portions of the standard library
Apr 22 2022, 5:22 PM · Restricted Project, Restricted Project
cjdb added a reverting change for rG973de7185606: Revert "[clang][pp] adds '#pragma include_instead'": rGe9a902c7f755: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""".
Apr 22 2022, 9:38 AM
cjdb committed rGe9a902c7f755: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""" (authored by cjdb).
Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'"""
Apr 22 2022, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
cjdb closed D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""".
Apr 22 2022, 9:37 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

removes discrete number of elements in small vector

Apr 19 2022, 1:14 PM · Restricted Project, Restricted Project

Apr 18 2022

cjdb added inline comments to D116280: [clang] adds unary type trait checks as compiler built-ins.
Apr 18 2022, 10:43 AM · Restricted Project, Restricted Project

Apr 16 2022

cjdb added inline comments to D116280: [clang] adds unary type trait checks as compiler built-ins.
Apr 16 2022, 11:17 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.
  • finishes __is_move_constructible and __is_move_assignable
  • fixes detecting C++ mode
  • clang-formats
Apr 16 2022, 11:17 PM · Restricted Project, Restricted Project
cjdb added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Apr 16 2022, 12:15 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.
  • catches some missing things that only handled __underlying_type
  • makes __remove_pointer remove address spaces (otherwise it'd create types like int __attribute__((address_space(1))))
Apr 16 2022, 12:11 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

achieves harmony with libstdc++

Apr 16 2022, 12:08 AM · Restricted Project, Restricted Project

Apr 15 2022

cjdb added a reverting change for rG973de7185606: Revert "[clang][pp] adds '#pragma include_instead'": D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""".
Apr 15 2022, 5:26 PM
cjdb requested review of D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""".
Apr 15 2022, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

responds to all feedback from the last round, except for handling __remove_cv in libstdc++ land

Apr 15 2022, 9:21 AM · Restricted Project, Restricted Project

Apr 10 2022

cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.

adds __is_copy_constructible, __is_copy_assignable, __is_move_constructible (WIP), and __is_move_assignable (incomplete)

Apr 10 2022, 11:17 PM · Restricted Project, Restricted Project

Apr 9 2022

cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.
  • updates mangling tests to check everything added
  • adds __remove_restrict (per offline conversation with @aaron.ballman we're deferring __remove_all_qualifiers to a later CL)
  • removes programmability for BuiltinEnumUnderlyingType, BuiltinAddPointer, and BuiltinDecay with respect to UTTKind since they don't need this
Apr 9 2022, 1:08 PM · Restricted Project, Restricted Project

Apr 7 2022

cjdb added a comment to D116203: [clang] adds unary type transformations as compiler built-ins.

I've noticed that libstdc++ has using __remove_cv = typename remove_cv<T>::type, which causes Clang to chuck a wobbly. Changing from KEYWORD to TYPE_TRAIT_1 didn't seem to fix anything.
Is there a way we can work around this, or should we just rename __remove_cv and friends to something else?

You could work around it by taking note that you're in a libstdc++ system header and do a special dance, but because these are in the implementation's namespace, I think it's probably kinder for everyone to just pick a different name.

I was hoping we could do something similar to struct __remove_cv which would issue a warning?

If you wanted to be especially mean, you could go with __remove_cvr, but I'd suggest __remove_cv_qualifiers instead. However, what about restrict qualifiers? We support them in C++: https://godbolt.org/z/11EPefhjf

Along with a fair number of other vendor qualifiers, yeah. I think you have to make a policy decision about whether the intent of std::remove_cv is really to just remove CV qualifiers or to produce an unqualified type (at the outermost level). The former is probably more defensible, even if it makes the transform less useful in the presence of extended qualifiers.

I'm partial to std::remove_cv being faithful to its name, unless existing implementations do something else already. I don't mind adding support for the other stuff, but if there's more than just add/remove restrict, we're going to have a combinatorial explosion for removes. Is there an alternate way we can approach this?
Possibly:

template<class T>
using remove_const_t = __remove_qualifiers(T, const);


template<class T>
using remove_reference_t = __remove_qualifiers(T, &, &&);

template<class T>
using remove_rcvref_t = __remove_qualifiers(T, const, volatile, restrict, &, &&); // rcv instead of cvr to prevent a typo with remove_cvref_t

I don't think it's worth adding that parsing complexity for a builtin that we expect to only be used in system headers. Let's just remove const and volatile and leave other qualifiers in place.

I come down on the opposite side of the fence and think it should remove all qualifiers (or that should be an interface we support in addition to removing just cv qualifiers). WG14 adopted https://www9.open-std.org/jtc1/sc22/wg14/www/docs/n2927.htm into C23 with a remove_quals function which removes *all* qualifiers (including _Atomic), as an example. But even in C++ mode, I fail to see why we wouldn't want <some> interface for stripping __restrict the same as const or volatile along with some interface for stripping all qualifiers period (I don't see a huge need for a __remove_cvr if we have the ability to remove all qualifiers, so I don't think we need the combinatorial explosion or a complex interface). Basically -- if we have extensions like __restrict or _Atomic, we should fully support them rather than halfway do it.

Apr 7 2022, 9:51 AM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.
  • updates name of __remove_cv to __remove_cv_qualifiers
  • updates mangling
  • updates mangling test
Apr 7 2022, 12:16 AM · Restricted Project, Restricted Project

Apr 6 2022

cjdb added a comment to D116203: [clang] adds unary type transformations as compiler built-ins.

I've noticed that libstdc++ has using __remove_cv = typename remove_cv<T>::type, which causes Clang to chuck a wobbly. Changing from KEYWORD to TYPE_TRAIT_1 didn't seem to fix anything.
Is there a way we can work around this, or should we just rename __remove_cv and friends to something else?

You could work around it by taking note that you're in a libstdc++ system header and do a special dance, but because these are in the implementation's namespace, I think it's probably kinder for everyone to just pick a different name.

Apr 6 2022, 3:10 PM · Restricted Project, Restricted Project

Apr 3 2022

cjdb added a comment to D116203: [clang] adds unary type transformations as compiler built-ins.

I've noticed that libstdc++ has using __remove_cv = typename remove_cv<T>::type, which causes Clang to chuck a wobbly. Changing from KEYWORD to TYPE_TRAIT_1 didn't seem to fix anything.
Is there a way we can work around this, or should we just rename __remove_cv and friends to something else?

Apr 3 2022, 9:59 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.
  • fixes assert failure
  • removes __add_{const,volatile,cv}
Apr 3 2022, 9:59 PM · Restricted Project, Restricted Project

Apr 1 2022

cjdb added a comment to D116203: [clang] adds unary type transformations as compiler built-ins.

The summary for the patch explains what's being added, but there's really no information as to why it's being added. Why do we need these builtins?

Btw, I still think the patch summary should be updated with this information.

Apr 1 2022, 3:35 PM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

provides most of the updates to commentary from ages ago

Apr 1 2022, 3:35 PM · Restricted Project, Restricted Project

Mar 7 2022

cjdb accepted D120774: [clang-format] Handle builtins in constraint expression.

Thanks for working on this!

Mar 7 2022, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2022

cjdb committed rG5aaefa510ef0: [libcxx][modules] protects users from relying on detail headers (authored by cjdb).
[libcxx][modules] protects users from relying on detail headers
Feb 26 2022, 1:01 AM
cjdb closed D106124: [libcxx][modules] protects users from relying on detail headers.
Feb 26 2022, 1:01 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 25 2022

cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

adds no-locale and no-thread to list of unsupported

Feb 25 2022, 11:34 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

Puts threading_support.h into config files

Feb 25 2022, 10:19 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

changes <threading_support.h> to "threading_support.h"

Feb 25 2022, 9:20 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

adds clang-13, apple-clang-{11,12,13} as unsupported

Feb 25 2022, 5:31 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

rebases to ToT, which I'd forgotten to do before last push

Feb 25 2022, 3:36 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb updated the diff for D106124: [libcxx][modules] protects users from relying on detail headers.

Reviving this patch since we need this support

Feb 25 2022, 11:47 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 16 2022

cjdb committed rGc5a20b518203: [llvm-libgcc] initial commit (authored by cjdb).
[llvm-libgcc] initial commit
Feb 16 2022, 9:07 AM
cjdb closed D108416: [llvm-libgcc] initial commit.
Feb 16 2022, 9:07 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Feb 15 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

rebases to activate CI

Feb 15 2022, 11:04 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.
  • makes it harder to accidentally build llvm-libgcc by removing it from LLVM_ENABLE_RUNTIMES=all
  • installs shared objects properly
Feb 15 2022, 2:51 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

cleans up a few things

Feb 15 2022, 1:01 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb added inline comments to D108416: [llvm-libgcc] initial commit.
Feb 15 2022, 12:43 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

responds to feedback

Feb 15 2022, 12:43 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb committed rGe51e7e7f44cf: [polly][NFC] removes using-directives to fix modules build (authored by cjdb).
[polly][NFC] removes using-directives to fix modules build
Feb 15 2022, 10:58 AM
cjdb closed D119809: [polly][NFC] removes using-directives to fix modules build.
Feb 15 2022, 10:58 AM · Restricted Project
cjdb committed rGd7b1c840ba4e: [clangd][NFC] includes missing headers (authored by cjdb).
[clangd][NFC] includes missing headers
Feb 15 2022, 9:46 AM
cjdb closed D119806: [clangd][NFC] includes missing headers.
Feb 15 2022, 9:46 AM · Restricted Project
cjdb updated the diff for D119809: [polly][NFC] removes using-directives to fix modules build.

qualifies something that Clang missed, but MSVC caught

Feb 15 2022, 9:43 AM · Restricted Project
cjdb updated the diff for D119809: [polly][NFC] removes using-directives to fix modules build.
  • qualifies things that weren't caught by the modules build
  • adds using-declarations for some of the more commonly used types so that they don't need to be qualified
Feb 15 2022, 12:29 AM · Restricted Project

Feb 14 2022

cjdb updated the diff for D119809: [polly][NFC] removes using-directives to fix modules build.

creates namespace alias

Feb 14 2022, 11:51 PM · Restricted Project
cjdb requested review of D119809: [polly][NFC] removes using-directives to fix modules build.
Feb 14 2022, 10:59 PM · Restricted Project
cjdb requested review of D119806: [clangd][NFC] includes missing headers.
Feb 14 2022, 8:48 PM · Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

quick CMake fix

Feb 14 2022, 7:16 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

gets CMake scripts into a decent state

Feb 14 2022, 6:58 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Feb 13 2022

cjdb added a comment to D119670: [clang] Warn on unqualified calls to std::move and std::forward.

Thanks for working on this! I'm overall very happy, but I don't see a test case for a unary move originating from another namespace.

Feb 13 2022, 9:53 AM · Restricted Project

Feb 1 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

broadens armhf detection

Feb 1 2022, 12:06 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 31 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

changes to SIZEOF_POINTER >= 8

Jan 31 2022, 5:37 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb added inline comments to D108416: [llvm-libgcc] initial commit.
Jan 31 2022, 10:39 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

changes how GLOBAL_32BIT and GLOBAL_64BIT are enabled

Jan 31 2022, 10:39 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 28 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

changes how the version script is laid out so that global symbols are all listed first, and exclusive symbols are listed afterward

Jan 28 2022, 2:33 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb added inline comments to D108416: [llvm-libgcc] initial commit.
Jan 28 2022, 11:52 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

applies @danielkiss' feedback

Jan 28 2022, 11:52 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb added a comment to D108416: [llvm-libgcc] initial commit.

Could you please comparing the symbol set with GCC libgcc_s.so.1 for these architectures you mostly care about?

Jan 28 2022, 10:28 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.
  • re-adds generate_version_script.py
  • responds to @MaskRay's feedback
Jan 28 2022, 10:25 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 27 2022

cjdb added inline comments to D108416: [llvm-libgcc] initial commit.
Jan 27 2022, 11:57 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.
  • collapses the version script preprocessing into a single version script that's now run through the C preprocessor
  • adds pseudo-detection for arm-*-*-gnueabihf
Jan 27 2022, 11:32 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 26 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

updates documentation to reflect status quo

Jan 26 2022, 3:58 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

restores the version scripts, but instead makes them generated when invoking the build

Jan 26 2022, 3:54 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 25 2022

cjdb updated the diff for D108416: [llvm-libgcc] initial commit.

updating to C symver file

Jan 25 2022, 7:22 PM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Jan 24 2022

cjdb resigned from D117948: [libc++][doc] Update the release notes..
Jan 24 2022, 4:12 PM · Unknown Object (Project)

Jan 18 2022

cjdb resigned from D101098: [libcxx][docs] Add section for header layout and guidlines..
Jan 18 2022, 1:38 PM · Unknown Object (Project)
cjdb resigned from D103840: [libcxx][ranges][nfc] Factor out common logic in the copy algorithms..
Jan 18 2022, 1:38 PM · Unknown Object (Project)
cjdb resigned from D109298: [libc++][NFC] Make tuple dtor test compile test.
Jan 18 2022, 1:38 PM · Unknown Object (Project)
cjdb resigned from D104492: [libc++][pstl] Implement tag dispatching.
Jan 18 2022, 1:37 PM · Unknown Object (Project)
cjdb resigned from D107500: [libc++][ranges] Implement `lazy_split_view`..
Jan 18 2022, 1:37 PM · Restricted Project, Unknown Object (Project)
cjdb added a comment to D53847: [C++2a] P0634r3: Down with typename!.

What's the status of this patch?

Jan 18 2022, 1:28 PM · Restricted Project, Restricted Project
cjdb abandoned D115059: [libcxx][modularisation] completes <memory> modularisation.
Jan 18 2022, 11:54 AM · Unknown Object (Project)
cjdb abandoned D106124: [libcxx][modules] protects users from relying on detail headers.
Jan 18 2022, 11:54 AM · Restricted Project, Restricted Project, Unknown Object (Project)
cjdb abandoned D105794: [libcxx][algorithms] adds ranges::is_partitioned and ranges::partition_point.
Jan 18 2022, 11:54 AM · Unknown Object (Project)
cjdb abandoned D105793: [libcxx][algorithms] adds ranges::all_of, ranges::any_of, and ranges::none_of.
Jan 18 2022, 11:54 AM · Restricted Project