With D134950, targets get notified when a virtual register is created and/or
cloned. Targets can do the needful with the delegate callback. AMDGPU propagates
the virtual register flags maintained in the target file itself. They are useful
to identify a certain type of machine operands while inserting spill stores and
reloads. Since RegAllocFast spills the physical register itself, there is no way
its virtual register can be mapped back to retrieve the flags. It can be solved
by passing the virtual register as an additional argument. This argument has no
use when the spill interfaces are called during the greedy allocator or even the
PrologEpilogInserter and can pass a null register in such cases.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/include/llvm/CodeGen/TargetInstrInfo.h | ||
---|---|---|
1063–1068 | State what VReg is before stating why it's here |
llvm/include/llvm/CodeGen/TargetInstrInfo.h | ||
---|---|---|
1064 | Still think the phrasing could be improved. How about something like:
|
Comment Actions
I will wait for a couple of days before I upstream it to see if there is any comment from others.
Still think the phrasing could be improved. How about something like: