Page MenuHomePhabricator
People yassingh

yassingh (Yashwant Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2022, 1:56 AM (25 w, 6 d)

Recent Activity
View All

Today

yassingh committed rG422d379de287: [AMDGPU] Use tablegen to list uniform intrinsics (authored by yassingh).
[AMDGPU] Use tablegen to list uniform intrinsics
Tue, Jan 31, 4:15 AM · Restricted Project, Restricted Project
yassingh closed D142961: [AMDGPU] Use tablegen to list uniform intrinsics .
Tue, Jan 31, 4:15 AM · Restricted Project, Restricted Project
yassingh retitled D142961: [AMDGPU] Use tablegen to list uniform intrinsics from Make always uniform intrinsics table driven to [AMDGPU] Use tablegen to list uniform intrinsics .
Tue, Jan 31, 2:07 AM · Restricted Project, Restricted Project
yassingh requested review of D142961: [AMDGPU] Use tablegen to list uniform intrinsics .
Tue, Jan 31, 1:28 AM · Restricted Project, Restricted Project

Tue, Jan 24

yassingh committed rG2a832d0f09f7: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad (authored by yassingh).
[AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad
Tue, Jan 24, 12:55 AM · Restricted Project, Restricted Project
yassingh closed D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.
Tue, Jan 24, 12:55 AM · Restricted Project, Restricted Project

Sun, Jan 22

yassingh updated the diff for D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.

Cleaned up MIR test

Sun, Jan 22, 9:47 PM · Restricted Project, Restricted Project

Thu, Jan 19

yassingh updated the diff for D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.

Addressed review comments, updated MIR test

Thu, Jan 19, 10:37 PM · Restricted Project, Restricted Project

Wed, Jan 18

yassingh added inline comments to D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.
Wed, Jan 18, 2:58 AM · Restricted Project, Restricted Project
yassingh updated the diff for D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.

Addressed Matt's comments

Wed, Jan 18, 2:56 AM · Restricted Project, Restricted Project

Mon, Jan 16

yassingh requested review of D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad.
Mon, Jan 16, 11:07 PM · Restricted Project, Restricted Project

Dec 21 2022

yassingh committed rG9e0d8ab8227d: [AMDGPU][Test] Update perfhint test to use opaque pointers (authored by yassingh).
[AMDGPU][Test] Update perfhint test to use opaque pointers
Dec 21 2022, 8:20 PM · Restricted Project, Restricted Project
yassingh closed D140452: [AMDGPU][Test] Update perfhint test to use opaque pointers.
Dec 21 2022, 8:19 PM · Restricted Project, Restricted Project
yassingh planned changes to D138937: [AMDGPU] Update InstrCost calculation.
Dec 21 2022, 8:00 PM · Restricted Project, Restricted Project

Dec 20 2022

yassingh added inline comments to D138937: [AMDGPU] Update InstrCost calculation.
Dec 20 2022, 7:48 PM · Restricted Project, Restricted Project
yassingh added inline comments to D140452: [AMDGPU][Test] Update perfhint test to use opaque pointers.
Dec 20 2022, 7:46 PM · Restricted Project, Restricted Project
yassingh requested review of D140452: [AMDGPU][Test] Update perfhint test to use opaque pointers.
Dec 20 2022, 7:43 PM · Restricted Project, Restricted Project

Nov 29 2022

yassingh added inline comments to D138937: [AMDGPU] Update InstrCost calculation.
Nov 29 2022, 11:11 PM · Restricted Project, Restricted Project
yassingh updated the diff for D138937: [AMDGPU] Update InstrCost calculation.

Addressed Matt's comments

Nov 29 2022, 11:03 PM · Restricted Project, Restricted Project
yassingh requested review of D138937: [AMDGPU] Update InstrCost calculation.
Nov 29 2022, 11:46 AM · Restricted Project, Restricted Project

Nov 16 2022

yassingh committed rG2652db4d68ea: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form (authored by yassingh).
Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form
Nov 16 2022, 8:32 PM · Restricted Project, Restricted Project
yassingh closed D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Nov 16 2022, 8:32 PM · Restricted Project, Restricted Project

Nov 14 2022

yassingh committed rG1c9a93ae3ad0: [GlobalIsel][AMDGPU] Changing legalize rule for… (authored by yassingh).
[GlobalIsel][AMDGPU] Changing legalize rule for…
Nov 14 2022, 10:13 AM · Restricted Project, Restricted Project
yassingh closed D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}.
Nov 14 2022, 10:13 AM · Restricted Project, Restricted Project, Unknown Object (Project)
yassingh updated the diff for D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}.

Removed -O0 from run lines of all tests. legalize-uadde.mir, legalize-uaddo.mir, legalize-usube.mir, legalize-usubo.mir had to be updated

Nov 14 2022, 9:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)
yassingh updated the diff for D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}.

Removed -global-isel-abort=0

Nov 14 2022, 7:22 AM · Restricted Project, Restricted Project, Unknown Object (Project)
yassingh added inline comments to D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}.
Nov 14 2022, 7:16 AM · Restricted Project, Restricted Project, Unknown Object (Project)
yassingh requested review of D137932: [GlobalIsel][AMDGPU] Changing legalize rule for G_{UADDO|UADDE|USUBO|USUBE|SADDE|SSUBE}.
Nov 14 2022, 3:39 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Nov 10 2022

yassingh added inline comments to D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Nov 10 2022, 9:59 PM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.

Addressed review comments, updated summary.

Nov 10 2022, 9:52 PM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Nov 10 2022, 3:26 AM · Restricted Project, Restricted Project
yassingh added inline comments to D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Nov 10 2022, 3:25 AM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Nov 10 2022, 2:13 AM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.

Since only v_add_co_u32_e32 can be converted to SDWA form there is no need to try convert v_addc_co_u32_e64 to it's VOP2 form. This will allow us to get rid of all the checks we were performing on v_addc_co_u32. The shrinking of this instr will be taken care by si-shrink-instructions.

Nov 10 2022, 2:07 AM · Restricted Project, Restricted Project

Nov 8 2022

yassingh abandoned D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.

Sorry! Accidently reopened the review with another patch I'm working on. Closing again.

Nov 8 2022, 10:02 PM · Restricted Project, Restricted Project
yassingh updated the diff for D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.
  • New changes abandon carry handling
  • updated tests for updated rule
  • clang format
Nov 8 2022, 9:46 PM · Restricted Project, Restricted Project

Nov 5 2022

yassingh abandoned D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.

Realized my mistake the carry output is properly updated (if condition, line 5104)

Nov 5 2022, 5:25 AM · Restricted Project, Restricted Project

Nov 4 2022

yassingh added inline comments to D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.
Nov 4 2022, 10:53 AM · Restricted Project, Restricted Project
yassingh added a comment to D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.
In D137407#3908174, @foad wrote:
In D137407#3907766, @yassingh wrote:

Where should I add the tests for this change?

Does AMDGPU use this code? If so you could put something in test/CodeGen/AMDGPU/GlobalISel/legalize-add.mir.

Nov 4 2022, 10:03 AM · Restricted Project, Restricted Project
yassingh added a comment to D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.

Where should I add the tests for this change?

Nov 4 2022, 4:11 AM · Restricted Project, Restricted Project
yassingh added reviewers for D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action: arsenm, aemerson, paquette, foad.
Nov 4 2022, 4:11 AM · Restricted Project, Restricted Project
yassingh requested review of D137407: [GlobalIsel] Handle carry output generated in narrowScalarAddSub legalize action.
Nov 4 2022, 4:05 AM · Restricted Project, Restricted Project

Oct 27 2022

yassingh added inline comments to D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Oct 27 2022, 4:53 AM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.

Only shrink V_ADD_CO_U32_e32 instruction if V_ADDC_CO_U32_e32 is not shrinkable. Hence avoiding introducing redundant copy instruction as suggested by @arsenm and @foad

Oct 27 2022, 4:35 AM · Restricted Project, Restricted Project

Oct 26 2022

yassingh added inline comments to D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Oct 26 2022, 9:58 AM · Restricted Project, Restricted Project
yassingh updated the diff for D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.

Pre-committed the tests and rebased the diff

Oct 26 2022, 9:54 AM · Restricted Project, Restricted Project
yassingh committed rG14fb4040e2b6: [AMDGPU][test] precommiting tests for D136663 (authored by yassingh).
[AMDGPU][test] precommiting tests for D136663
Oct 26 2022, 9:40 AM · Restricted Project, Restricted Project
yassingh added inline comments to D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Oct 26 2022, 4:59 AM · Restricted Project, Restricted Project

Oct 24 2022

yassingh updated the summary of D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Oct 24 2022, 11:10 PM · Restricted Project, Restricted Project
yassingh requested review of D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form.
Oct 24 2022, 10:51 PM · Restricted Project, Restricted Project

Sep 22 2022

yassingh committed rG3fe71809a5d6: Introduce predicate for a atomic operations in GMIR (authored by yassingh).
Introduce predicate for a atomic operations in GMIR
Sep 22 2022, 11:05 PM · Restricted Project, Restricted Project
yassingh closed D134266: Introduce predicate for a atomic operations in GMIR.
Sep 22 2022, 11:05 PM · Restricted Project, Restricted Project
yassingh committed rG6b93f30b1c63: [NFC] Empty commit to check commit access (authored by yassingh).
[NFC] Empty commit to check commit access
Sep 22 2022, 10:25 AM
yassingh updated the diff for D134266: Introduce predicate for a atomic operations in GMIR.
Sep 22 2022, 7:00 AM · Restricted Project, Restricted Project
yassingh added inline comments to D134266: Introduce predicate for a atomic operations in GMIR.
Sep 22 2022, 6:56 AM · Restricted Project, Restricted Project
yassingh added inline comments to D134266: Introduce predicate for a atomic operations in GMIR.
Sep 22 2022, 6:51 AM · Restricted Project, Restricted Project
yassingh updated the diff for D134266: Introduce predicate for a atomic operations in GMIR.

Updated the predicate to check isAtomicRMW operations, added another one for CMPXCGH

Sep 22 2022, 1:48 AM · Restricted Project, Restricted Project

Sep 21 2022

yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

removed unnecessary namespace identifier llvm:: as @arsenm suggested

Sep 21 2022, 9:11 AM · Restricted Project, Restricted Project

Sep 20 2022

yassingh added inline comments to D134266: Introduce predicate for a atomic operations in GMIR.
Sep 20 2022, 7:45 AM · Restricted Project, Restricted Project
yassingh added a comment to D134266: Introduce predicate for a atomic operations in GMIR.
In D134266#3802636, @arsenm wrote:

What's this going to be used for?

Sep 20 2022, 7:43 AM · Restricted Project, Restricted Project
yassingh updated the diff for D134266: Introduce predicate for a atomic operations in GMIR.

Removed extra markers

Sep 20 2022, 3:18 AM · Restricted Project, Restricted Project
yassingh added inline comments to D134266: Introduce predicate for a atomic operations in GMIR.
Sep 20 2022, 2:59 AM · Restricted Project, Restricted Project
yassingh retitled D134266: Introduce predicate for a atomic operations in GMIR from Generic atomic instructions identifier function to Introduce predicate for a atomic operations in GMIR.
Sep 20 2022, 2:54 AM · Restricted Project, Restricted Project
yassingh requested review of D134266: Introduce predicate for a atomic operations in GMIR.
Sep 20 2022, 2:00 AM · Restricted Project, Restricted Project

Sep 19 2022

yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

Moved string label template functions back to CFGPrinter.h

Sep 19 2022, 10:37 AM · Restricted Project, Restricted Project
yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

Moved common code to generate node label to template functions

Sep 19 2022, 8:08 AM · Restricted Project, Restricted Project

Sep 16 2022

yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

Updating entire diff, since changes dropped the original patch, all syntax changes requested have been addressed.
Discussion about whether to move common cl-options for -dot-cfg and -dot-mcfg in single place is still open, but as @arsenm suggested it might not be worth the effort and I agree.

Sep 16 2022, 8:47 AM · Restricted Project, Restricted Project
yassingh added a comment to D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
In D133709#3795640, @arsenm wrote:

Latest patch seems to have dropped the base patch

Sep 16 2022, 8:34 AM · Restricted Project, Restricted Project
yassingh updated the summary of D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
Sep 16 2022, 8:22 AM · Restricted Project, Restricted Project
yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

Syntax changes addressing reviewers comments

Sep 16 2022, 8:21 AM · Restricted Project, Restricted Project

Sep 13 2022

yassingh added inline comments to D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
Sep 13 2022, 10:36 AM · Restricted Project, Restricted Project
yassingh updated the diff for D133709: -dot-machine-cfg for printing MachineFunction to a dot file.

Changes addressing Matt's comments
Updated pass summary, code syntax and added tests

Sep 13 2022, 10:28 AM · Restricted Project, Restricted Project
yassingh added inline comments to D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
Sep 13 2022, 3:26 AM · Restricted Project, Restricted Project
yassingh updated subscribers of D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
Sep 13 2022, 1:25 AM · Restricted Project, Restricted Project

Sep 12 2022

yassingh added reviewers for D133709: -dot-machine-cfg for printing MachineFunction to a dot file: Restricted Project, foad, nhaehnle, arsenm, qcolombet, dblaikie, craig.topper, MatzeB.
Sep 12 2022, 10:16 AM · Restricted Project, Restricted Project
yassingh requested review of D133709: -dot-machine-cfg for printing MachineFunction to a dot file.
Sep 12 2022, 10:07 AM · Restricted Project, Restricted Project