Page MenuHomePhabricator

stoklund (Jakob Stoklund Olesen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2015, 5:54 PM (202 w, 4 d)

Recent Activity

Mar 24 2017

stoklund accepted D31322: [TableGen] Make CodeGenMapTable understand the namespace field of an instruction.

Looks good.

Mar 24 2017, 10:11 AM

Jan 30 2017

stoklund added a comment to D29080: Use less stack in DAGISelMatcherOpt.

Sorry, I don't have an LLVM sandbox these days. Maybe ask on llvm-commits?

Jan 30 2017, 8:22 AM

Jan 25 2017

stoklund accepted D29080: Use less stack in DAGISelMatcherOpt.

Looks good. I'm all for eliminating recursion.

Jan 25 2017, 11:14 AM

Feb 17 2016

stoklund added a comment to D17304: Fix quadratic spill behavior?.

Hi Jakob,

Thanks for the root causing this issue.

Will you provide a patch or should Fiona or I work on it?

Feb 17 2016, 11:29 AM

Feb 16 2016

stoklund added a comment to D17304: Fix quadratic spill behavior?.

To elaborate on this precise example: we have 4000 basic blocks. They're a linear chain of small loops (artificial test). The hopfield network grows at a rate of 2 blocks per call, which results in O(N^2) overall behavior. 256 registers * 4000^2 basic blocks == enormous, big, scary number.

Feb 16 2016, 9:41 PM

Oct 7 2015

stoklund added a comment to D13417: [MachineCombiner] make slack optional in critical path cost calculation (PR25016).

I think that shows the intended usage: slack is limited both by a dynamic calculation and a heuristic. Without those limits, we're almost certain to increase the critical path and lose performance (as shown in the examples here).

Oct 7 2015, 8:44 AM

Jul 13 2015

stoklund accepted D10911: MachineRegisterInfo: Remove UsedPhysReg infrastructure.
Jul 13 2015, 8:25 PM
stoklund accepted D10910: RAGreedy: Keep track of allocated PhysRegs internally.
Jul 13 2015, 8:25 PM
stoklund added a comment to D10911: MachineRegisterInfo: Remove UsedPhysReg infrastructure.

Looks good!

Jul 13 2015, 8:23 PM

Jul 2 2015

stoklund added a comment to D10910: RAGreedy: Keep track of allocated PhysRegs internally.

Instead of maintaining a bitvector in RAGreedy, how about asking LiveRegMatrix? It can tell you if the corresponding LiveIntervalUnion is empty.

Jul 2 2015, 6:07 PM
stoklund added a comment to D10911: MachineRegisterInfo: Remove UsedPhysReg infrastructure.

Very nice! Should those reg_empty calls be reg_nodbg_empty?

Jul 2 2015, 6:02 PM