revert "[CodeGen] Require a name for a block addr target"

[nickdesaulniers]

Summary

Reverts commit 79176a2542d03107b90613c84f18ccba41ad8fa8.

After D130316, this is no longer necessary.

[nickdesaulniers]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

216–217

Note: we already assert, so having a conditional later is pointless. I suspect the assert was added after 79176a2542d03107b90613c84f18ccba41ad8fa8 (but haven't checked the git log) and that this should have been fixed up when the assert was added.

[nickdesaulniers]

Turning on more build targets, either this or https://reviews.llvm.org/D130391 regresses (llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll).

[barannikov88]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

232

The old behavior is to call createNamedTempSymbol
I can't judge if the new behavior is wrong or not, just noticed that it has changed.

[nickdesaulniers]

• rebase

[nickdesaulniers]

Bumping for review

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

232

Correct; I'm intentionally reverting that behavior.

The regression in llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll was due to a different patch in the series, https://reviews.llvm.org/D130323, which I've removed from the dependency chain for now.

[efriedma]

We still allow referring to a blockaddress in an asm operand, right? Does that still work with this patch? Something like the following:

long f() {
  void* z = &&X;
  goto *z;
  long a;
  X: asm("lea %1(%%rip), %0" : "=r"(a) : "i"(&&X));
  return a;
}

[nickdesaulniers]

In D130391#3729924, @efriedma wrote:

We still allow referring to a blockaddress in an asm operand, right? Does that still work with this patch? Something like the following:

long f() {
  void* z = &&X;
  goto *z;
  long a;
  X: asm("lea %1(%%rip), %0" : "=r"(a) : "i"(&&X));
  return a;
}

works just fine with this patch.

[efriedma]

LGTM

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

public:
   void takeDeletedSymbolsForFunction(Function *F,
                                      std::vector<MCSymbol *> &Result);
 
   void UpdateForDeletedBlock(BasicBlock *BB);
   void UpdateForRAUWBlock(BasicBlock *Old, BasicBlock *New);
 };
 
 ArrayRef<MCSymbol *> AddrLabelMap::getAddrLabelSymbolToEmit(BasicBlock *BB) {
   assert(BB->hasAddressTaken() &&
          "Shouldn't get label for block without address taken");
   AddrLabelSymEntry &Entry = AddrLabelSymbols[BB];
 
   // If we already had an entry for this block, just return it.
   if (!Entry.Symbols.empty()) {
     assert(BB->getParent() == Entry.Fn && "Parent changed");
     return Entry.Symbols;
   }
 
   // Otherwise, this is a new entry, create a new symbol for it and add an
   // entry to BBCallbacks so we can be notified if the BB is deleted or RAUWd.
   BBCallbacks.emplace_back(BB);
   BBCallbacks.back().setMap(this);
   Entry.Index = BBCallbacks.size() - 1;
   Entry.Fn = BB->getParent();
-  MCSymbol *Sym = BB->hasAddressTaken() ? Context.createNamedTempSymbol()
-                                        : Context.createTempSymbol();
-  Entry.Symbols.push_back(Sym);
+  Entry.Symbols.push_back(Context.createTempSymbol());
   return Entry.Symbols;
 }
 
 /// If we have any deleted symbols for F, return them.
 void AddrLabelMap::takeDeletedSymbolsForFunction(
     Function *F, std::vector<MCSymbol *> &Result) {
   DenseMap<AssertingVH<Function>, std::vector<MCSymbol *>>::iterator I =
       DeletedAddrLabelsNeedingEmission.find(F);