Reverts commit 79176a2542d03107b90613c84f18ccba41ad8fa8.
After D130316, this is no longer necessary.
Differential D130391
revert "[CodeGen] Require a name for a block addr target" nickdesaulniers on Jul 22 2022, 12:33 PM. Authored by
Details
Reverts commit 79176a2542d03107b90613c84f18ccba41ad8fa8. After D130316, this is no longer necessary.
Diff Detail
Unit Tests Event Timeline
Comment Actions Turning on more build targets, either this or https://reviews.llvm.org/D130391 regresses (llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll).
Comment Actions Bumping for review
Comment Actions We still allow referring to a blockaddress in an asm operand, right? Does that still work with this patch? Something like the following: long f() { void* z = &&X; goto *z; long a; X: asm("lea %1(%%rip), %0" : "=r"(a) : "i"(&&X)); return a; } |
Note: we already assert, so having a conditional later is pointless. I suspect the assert was added after 79176a2542d03107b90613c84f18ccba41ad8fa8 (but haven't checked the git log) and that this should have been fixed up when the assert was added.