Page MenuHomePhabricator

[llvm][test] preprocess test with update_llc_test_checks NFC
AbandonedPublic

Authored by nickdesaulniers on Jul 19 2022, 3:36 PM.

Details

Summary

In preparation for https://reviews.llvm.org/D130127, preprocess
llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll with
update_llc_test_checks.py. Add nounwind fn attr to remove .cfi
directives. -asm-verbose=0 would be nice but breaks
update_llc_test_checks.py. Remove IR comments, and unnecessary keywords.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 3:36 PM
nickdesaulniers requested review of this revision.Jul 19 2022, 3:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 3:36 PM
  • remove one more hidden

Rereading https://reviews.llvm.org/D65352, we might either want:

  1. to also do this for llvm/test/CodeGen/X86/callbr-asm-obj-file.ll
  2. not do this, and simply manually fix up the test in https://reviews.llvm.org/D130127 (avoiding the use of utils/update_llc_test_checks.py)
  3. OTHER
nickdesaulniers planned changes to this revision.Jul 22 2022, 9:50 AM
nickdesaulniers abandoned this revision.Aug 24 2022, 2:21 PM

I think for https://reviews.llvm.org/D130127 it's better to keep the test as is.