Page MenuHomePhabricator

void (Bill Wendling)
Mind Taker

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2012, 10:22 AM (358 w, 2 d)

Sent here from the planet Zvddw, Bill's mission is to conquer the world by staying at home and occasionally (read: always) playing poker.

In his spare time, he works on LLVM-related things.

Recent Activity

Tue, Oct 8

void committed rG4d69ca8c67c9: [IA] Add tests for a few other edge cases (authored by void).
[IA] Add tests for a few other edge cases
Tue, Oct 8, 3:12 PM
void committed rL374124: [IA] Add tests for a few other edge cases.
[IA] Add tests for a few other edge cases
Tue, Oct 8, 3:12 PM

Mon, Oct 7

void committed rG411f1885b655: [IA] Recognize hexadecimal escape sequences (authored by void).
[IA] Recognize hexadecimal escape sequences
Mon, Oct 7, 10:27 PM
void committed rL374018: [IA] Recognize hexadecimal escape sequences.
[IA] Recognize hexadecimal escape sequences
Mon, Oct 7, 10:27 PM
void closed D68598: [IA] Recognize hexadecimal escape sequences.
Mon, Oct 7, 10:27 PM · Restricted Project
void committed rG6942327a8f3b: [IA] Recognize hexadecimal escape sequences (authored by void).
[IA] Recognize hexadecimal escape sequences
Mon, Oct 7, 10:07 PM
void added a comment to D68483: [IA] Recognize hexadecimal escape sequences.

I reverted this in r373898 since MC/AsmParser/directive_ascii.s failed on bots. I didn't look into it, but maybe it's because there's no bounds checking on the i + 1 index.

Mon, Oct 7, 2:49 PM · Restricted Project
void created D68598: [IA] Recognize hexadecimal escape sequences.
Mon, Oct 7, 2:48 PM · Restricted Project
void committed rL373888: [IA] Recognize hexadecimal escape sequences.
[IA] Recognize hexadecimal escape sequences
Mon, Oct 7, 2:56 AM
void closed D68483: [IA] Recognize hexadecimal escape sequences.
Mon, Oct 7, 2:56 AM · Restricted Project

Fri, Oct 4

void updated the diff for D68483: [IA] Recognize hexadecimal escape sequences.

Adding testcase for hex over 0xFF.

Fri, Oct 4, 4:28 PM · Restricted Project
void created D68483: [IA] Recognize hexadecimal escape sequences.
Fri, Oct 4, 1:43 PM · Restricted Project

Tue, Sep 24

void added a comment to rGcb3d969453c9: Revert rL372693 : [clang-tidy] New bugprone-infinite-loop check for detecting….

You forgot to add the InfiniteLoopCheck.cpp file.

Tue, Sep 24, 1:59 AM

Mon, Sep 23

void accepted D67196: [Verifier] add invariant check for callbr.

LGTMing. Others please comment if you have objections.

Mon, Sep 23, 5:24 PM · Restricted Project

Sep 16 2019

void committed rL372045: Add my SVN/GitHub information.
Add my SVN/GitHub information
Sep 16 2019, 4:16 PM

Sep 9 2019

void added a comment to D67196: [Verifier] add invariant check for callbr.

The llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll change LGTM.

Sep 9 2019, 3:07 PM · Restricted Project

Aug 14 2019

void committed rGcc2bebe03937: Ignore indirect branches from callbr. (authored by void).
Ignore indirect branches from callbr.
Aug 14 2019, 9:44 AM
void committed rL368873: Ignore indirect branches from callbr..
Ignore indirect branches from callbr.
Aug 14 2019, 9:43 AM
void closed D66200: Ignore indirect branches from callbr..
Aug 14 2019, 9:43 AM · Restricted Project
void created D66200: Ignore indirect branches from callbr..
Aug 14 2019, 1:35 AM · Restricted Project

Aug 13 2019

void added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

This PR is possibly related to the original issue: https://bugs.llvm.org/show_bug.cgi?id=42956

Aug 13 2019, 3:05 AM · Restricted Project

Aug 9 2019

void committed rG79176a2542d0: [CodeGen] Require a name for a block addr target (authored by void).
[CodeGen] Require a name for a block addr target
Aug 9 2019, 1:18 PM
void committed rL368478: [CodeGen] Require a name for a block addr target.
[CodeGen] Require a name for a block addr target
Aug 9 2019, 1:17 PM
void closed D65352: [CodeGen] Require a name for a block addr target.
Aug 9 2019, 1:17 PM · Restricted Project
void committed rG1b104388752f: [MC] Don't recreate a label if it's already used (authored by void).
[MC] Don't recreate a label if it's already used
Aug 9 2019, 1:17 PM
void committed rL368477: [MC] Don't recreate a label if it's already used.
[MC] Don't recreate a label if it's already used
Aug 9 2019, 1:15 PM
void closed D65304: [MC] Don't recreate a label if it's already used.
Aug 9 2019, 1:15 PM · Restricted Project
void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Move method out-of-line to keep MCContext.h simpler.

Aug 9 2019, 1:13 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

I think the comment in LLVMTargetMachine::addAsmPrinter about // Don't waste memory on names of temp labels. should be amended in this patch to say ... unless it's address is taken or something to that effect.

Aug 9 2019, 1:08 PM · Restricted Project

Aug 8 2019

void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Update testcase.

Aug 8 2019, 10:24 PM · Restricted Project
void added inline comments to D65304: [MC] Don't recreate a label if it's already used.
Aug 8 2019, 1:15 PM · Restricted Project
void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Remove smelly code and use correct triple in test.

Aug 8 2019, 1:15 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

In the "Revision Contents" box, there's a "Stack" tab. It looks like that's what shows the relationship.

Aug 8 2019, 12:50 PM · Restricted Project

Aug 7 2019

void retitled D65304: [MC] Don't recreate a label if it's already used from Don't recreate a label if it's already used to [MC] Don't recreate a label if it's already used.
Aug 7 2019, 10:12 PM · Restricted Project
void updated the summary of D65352: [CodeGen] Require a name for a block addr target.
Aug 7 2019, 5:57 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

It's not enough to just check that a BB's address is used by a callbr, since
the value doesn't have to be directly used by it. E.g., it could be stored into
memory and then loaded.

Aug 7 2019, 5:56 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

Remove accidentally added files.

Aug 7 2019, 5:10 PM · Restricted Project
void updated the summary of D65352: [CodeGen] Require a name for a block addr target.
Aug 7 2019, 4:39 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

Ah! Good point. Use "any_of" instead of creating a symbol for all block addresses.

Aug 7 2019, 4:39 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

Ugh! The last update combined D65304 with this...:-/

Aug 7 2019, 4:39 PM · Restricted Project
void committed rG85f07cbb547c: Add target requirements for those bots which don't handle x86. (authored by void).
Add target requirements for those bots which don't handle x86.
Aug 7 2019, 12:38 PM
void committed rL368202: Add target requirements for those bots which don't handle x86..
Add target requirements for those bots which don't handle x86.
Aug 7 2019, 12:38 PM
void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's inspecting assembly.
See clang/test/CodeGen/addrsig.c to see how that is handled (via REQUIRES: x86-registered-target).

Oddly enough, other tests that use -triple x86_64* and only inspect the AST don't require the registered target.

Aug 7 2019, 12:37 PM · Restricted Project, Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

Friendly ping. :-)

Aug 7 2019, 11:24 AM · Restricted Project
void added a comment to D65304: [MC] Don't recreate a label if it's already used.

Friendly ping. :-)

Aug 7 2019, 11:24 AM · Restricted Project

Aug 6 2019

void committed rG73be7cf5aaf2: Use parenthses to silence warning. (authored by void).
Use parenthses to silence warning.
Aug 6 2019, 3:48 PM
void committed rL368105: Use parenthses to silence warning..
Use parenthses to silence warning.
Aug 6 2019, 3:47 PM
void committed rGce29291fc3be: Delay diagnosing asm constraints that require immediates until after inlining (authored by void).
Delay diagnosing asm constraints that require immediates until after inlining
Aug 6 2019, 3:45 PM
void committed rL368104: Delay diagnosing asm constraints that require immediates until after inlining.
Delay diagnosing asm constraints that require immediates until after inlining
Aug 6 2019, 3:40 PM
void closed D60943: Delay diagnosing asm constraints that require immediates until after inlining.
Aug 6 2019, 3:40 PM · Restricted Project, Restricted Project
void committed rGebc2cf9c27d1: Use "isa" since the variable isn't used. (authored by void).
Use "isa" since the variable isn't used.
Aug 6 2019, 12:28 AM
void committed rL367985: Use "isa" since the variable isn't used..
Use "isa" since the variable isn't used.
Aug 6 2019, 12:28 AM

Aug 5 2019

void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

The combination of D60942, D06943 and D65280 solves the problems for me on all targets I have.

Aug 5 2019, 3:08 PM · Restricted Project, Restricted Project

Aug 2 2019

void committed rG41a2847a9ae5: Emit diagnostic if an inline asm constraint requires an immediate (authored by void).
Emit diagnostic if an inline asm constraint requires an immediate
Aug 2 2019, 10:55 PM
void committed rL367750: Emit diagnostic if an inline asm constraint requires an immediate.
Emit diagnostic if an inline asm constraint requires an immediate
Aug 2 2019, 10:53 PM
void closed D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Aug 2 2019, 10:52 PM · Restricted Project
void committed rG383650c7f19b: Add brackets to remove warnings about ambiguous 'else's. (authored by void).
Add brackets to remove warnings about ambiguous 'else's.
Aug 2 2019, 5:28 PM
void committed rL367740: Add brackets to remove warnings about ambiguous 'else's..
Add brackets to remove warnings about ambiguous 'else's.
Aug 2 2019, 5:28 PM

Jul 31 2019

void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Friendly ping. :-)

Jul 31 2019, 2:31 PM · Restricted Project, Restricted Project

Jul 29 2019

void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Jul 29 2019, 3:37 PM · Restricted Project
void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Jul 29 2019, 2:57 PM · Restricted Project
void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Jul 29 2019, 1:49 PM · Restricted Project
void added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

Feel free to hijack my revision. :-) I may not get back to my change soon.

Jul 29 2019, 1:43 PM · Restricted Project

Jul 28 2019

void added a comment to D60942: Emit diagnostic if an inline asm constraint requires an immediate.

I've updated this patch to better coincide with D60943. It adds support for RISC-V inline asm immediate constraints (to make the errors match those of the front-end) and a few more tests. Please take another look, since these are non-trivial changes.

Jul 28 2019, 12:59 AM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Update testing. This adds support for RISC-V inline asm immediate constraints
so that we emit the same errors that the front-end would.

Jul 28 2019, 12:59 AM · Restricted Project
void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Move a few more tests around. Some go to the LLVM side.

Jul 28 2019, 12:48 AM · Restricted Project, Restricted Project

Jul 27 2019

void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Don't emit errors here. Wait until codegen.

Jul 27 2019, 11:39 PM · Restricted Project, Restricted Project
void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Save checking of immediates until code generation.

Jul 27 2019, 2:16 PM · Restricted Project, Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Emit an error for an out-of-range immediate.

Jul 27 2019, 2:14 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

"like" :: "line" -- "potAYto" :: "potAHto"

Jul 27 2019, 1:19 PM · Restricted Project
void added inline comments to D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Jul 27 2019, 1:05 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Mark some constraints which require immediates as needing immediates.

Jul 27 2019, 1:05 PM · Restricted Project

Jul 26 2019

void added inline comments to D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Jul 26 2019, 5:18 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Remove file that sneaked in.

Jul 26 2019, 5:18 PM · Restricted Project
void abandoned D65181: Use the MachineBasicBlock symbol for a callbr target.
Jul 26 2019, 5:16 PM · Restricted Project
void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

That was intentional. We want to do this for more than just the n constraint.

Jul 26 2019, 5:16 PM · Restricted Project, Restricted Project
void added a parent revision for D65352: [CodeGen] Require a name for a block addr target: D65304: [MC] Don't recreate a label if it's already used.
Jul 26 2019, 4:55 PM · Restricted Project
void added a child revision for D65304: [MC] Don't recreate a label if it's already used: D65352: [CodeGen] Require a name for a block addr target.
Jul 26 2019, 4:55 PM · Restricted Project
void created D65352: [CodeGen] Require a name for a block addr target.
Jul 26 2019, 2:54 PM · Restricted Project

Jul 25 2019

void created D65304: [MC] Don't recreate a label if it's already used.
Jul 25 2019, 3:49 PM · Restricted Project

Jul 23 2019

void created D65181: Use the MachineBasicBlock symbol for a callbr target.
Jul 23 2019, 6:28 PM · Restricted Project

Jul 22 2019

void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

It would be nice to merge this fix into 9.0 branch after some time in trunk. What do you think?

@hans

Sounds like this was reverted on trunk. Please let me know if there are follow-ups that might be candidates for merging.

Jul 22 2019, 9:33 PM · Restricted Project

Jul 19 2019

void abandoned D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 11:43 AM · Restricted Project
void added inline comments to D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 3:39 AM · Restricted Project
void updated the diff for D64982: [AsmPrinter] Print label if MBB's address is taken.

Cast to reference.

Jul 19 2019, 3:32 AM · Restricted Project
void added inline comments to D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 2:45 AM · Restricted Project
void created D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 2:20 AM · Restricted Project

Jul 18 2019

void committed rGccbffefccaff: Use the MachineBasicBlock symbol for a callbr target (authored by void).
Use the MachineBasicBlock symbol for a callbr target
Jul 18 2019, 6:14 PM
void committed rL366523: Use the MachineBasicBlock symbol for a callbr target.
Use the MachineBasicBlock symbol for a callbr target
Jul 18 2019, 6:10 PM
void closed D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 18 2019, 6:10 PM · Restricted Project
void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

Thanks! Though your example pointed out a separate problem: not accepting the label as a valid operand. I'll do some work on that.

Jul 18 2019, 6:01 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Git-ifying my change.

Jul 18 2019, 5:32 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Revert accidentally added files.

Jul 18 2019, 5:26 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Revert the prvious update

Jul 18 2019, 5:19 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Updating.

Jul 18 2019, 5:16 PM · Restricted Project
void updated the diff for D64963: Add a pass to lower is.constant intrinsics.

Remove other commit.

Jul 18 2019, 5:16 PM · Restricted Project
void created D64963: Add a pass to lower is.constant intrinsics.
Jul 18 2019, 5:07 PM · Restricted Project
void added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 18 2019, 4:59 PM · Restricted Project

Jul 17 2019

void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Update test with correct dest labels

Jul 17 2019, 5:13 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Update triple.

Jul 17 2019, 4:55 PM · Restricted Project