Page MenuHomePhabricator

void (Bill Wendling)
Mind Taker

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2012, 10:22 AM (350 w, 4 d)

Sent here from the planet Zvddw, Bill's mission is to conquer the world by staying at home and occasionally (read: always) playing poker.

In his spare time, he works on LLVM-related things.

Recent Activity

Wed, Aug 14

void committed rGcc2bebe03937: Ignore indirect branches from callbr. (authored by void).
Ignore indirect branches from callbr.
Wed, Aug 14, 9:44 AM
void committed rL368873: Ignore indirect branches from callbr..
Ignore indirect branches from callbr.
Wed, Aug 14, 9:43 AM
void closed D66200: Ignore indirect branches from callbr..
Wed, Aug 14, 9:43 AM · Restricted Project
void created D66200: Ignore indirect branches from callbr..
Wed, Aug 14, 1:35 AM · Restricted Project

Tue, Aug 13

void added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

This PR is possibly related to the original issue: https://bugs.llvm.org/show_bug.cgi?id=42956

Tue, Aug 13, 3:05 AM · Restricted Project

Fri, Aug 9

void committed rG79176a2542d0: [CodeGen] Require a name for a block addr target (authored by void).
[CodeGen] Require a name for a block addr target
Fri, Aug 9, 1:18 PM
void committed rL368478: [CodeGen] Require a name for a block addr target.
[CodeGen] Require a name for a block addr target
Fri, Aug 9, 1:17 PM
void closed D65352: [CodeGen] Require a name for a block addr target.
Fri, Aug 9, 1:17 PM · Restricted Project
void committed rG1b104388752f: [MC] Don't recreate a label if it's already used (authored by void).
[MC] Don't recreate a label if it's already used
Fri, Aug 9, 1:17 PM
void committed rL368477: [MC] Don't recreate a label if it's already used.
[MC] Don't recreate a label if it's already used
Fri, Aug 9, 1:15 PM
void closed D65304: [MC] Don't recreate a label if it's already used.
Fri, Aug 9, 1:15 PM · Restricted Project
void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Move method out-of-line to keep MCContext.h simpler.

Fri, Aug 9, 1:13 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

I think the comment in LLVMTargetMachine::addAsmPrinter about // Don't waste memory on names of temp labels. should be amended in this patch to say ... unless it's address is taken or something to that effect.

Fri, Aug 9, 1:08 PM · Restricted Project

Thu, Aug 8

void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Update testcase.

Thu, Aug 8, 10:24 PM · Restricted Project
void added inline comments to D65304: [MC] Don't recreate a label if it's already used.
Thu, Aug 8, 1:15 PM · Restricted Project
void updated the diff for D65304: [MC] Don't recreate a label if it's already used.

Remove smelly code and use correct triple in test.

Thu, Aug 8, 1:15 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

In the "Revision Contents" box, there's a "Stack" tab. It looks like that's what shows the relationship.

Thu, Aug 8, 12:50 PM · Restricted Project

Wed, Aug 7

void retitled D65304: [MC] Don't recreate a label if it's already used from Don't recreate a label if it's already used to [MC] Don't recreate a label if it's already used.
Wed, Aug 7, 10:12 PM · Restricted Project
void updated the summary of D65352: [CodeGen] Require a name for a block addr target.
Wed, Aug 7, 5:57 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

It's not enough to just check that a BB's address is used by a callbr, since
the value doesn't have to be directly used by it. E.g., it could be stored into
memory and then loaded.

Wed, Aug 7, 5:56 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

Remove accidentally added files.

Wed, Aug 7, 5:10 PM · Restricted Project
void updated the summary of D65352: [CodeGen] Require a name for a block addr target.
Wed, Aug 7, 4:39 PM · Restricted Project
void updated the diff for D65352: [CodeGen] Require a name for a block addr target.

Ah! Good point. Use "any_of" instead of creating a symbol for all block addresses.

Wed, Aug 7, 4:39 PM · Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

Ugh! The last update combined D65304 with this...:-/

Wed, Aug 7, 4:39 PM · Restricted Project
void committed rG85f07cbb547c: Add target requirements for those bots which don't handle x86. (authored by void).
Add target requirements for those bots which don't handle x86.
Wed, Aug 7, 12:38 PM
void committed rL368202: Add target requirements for those bots which don't handle x86..
Add target requirements for those bots which don't handle x86.
Wed, Aug 7, 12:38 PM
void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's inspecting assembly.
See clang/test/CodeGen/addrsig.c to see how that is handled (via REQUIRES: x86-registered-target).

Oddly enough, other tests that use -triple x86_64* and only inspect the AST don't require the registered target.

Wed, Aug 7, 12:37 PM · Restricted Project, Restricted Project
void added a comment to D65352: [CodeGen] Require a name for a block addr target.

Friendly ping. :-)

Wed, Aug 7, 11:24 AM · Restricted Project
void added a comment to D65304: [MC] Don't recreate a label if it's already used.

Friendly ping. :-)

Wed, Aug 7, 11:24 AM · Restricted Project

Tue, Aug 6

void committed rG73be7cf5aaf2: Use parenthses to silence warning. (authored by void).
Use parenthses to silence warning.
Tue, Aug 6, 3:48 PM
void committed rL368105: Use parenthses to silence warning..
Use parenthses to silence warning.
Tue, Aug 6, 3:47 PM
void committed rGce29291fc3be: Delay diagnosing asm constraints that require immediates until after inlining (authored by void).
Delay diagnosing asm constraints that require immediates until after inlining
Tue, Aug 6, 3:45 PM
void committed rL368104: Delay diagnosing asm constraints that require immediates until after inlining.
Delay diagnosing asm constraints that require immediates until after inlining
Tue, Aug 6, 3:40 PM
void closed D60943: Delay diagnosing asm constraints that require immediates until after inlining.
Tue, Aug 6, 3:40 PM · Restricted Project, Restricted Project
void committed rGebc2cf9c27d1: Use "isa" since the variable isn't used. (authored by void).
Use "isa" since the variable isn't used.
Tue, Aug 6, 12:28 AM
void committed rL367985: Use "isa" since the variable isn't used..
Use "isa" since the variable isn't used.
Tue, Aug 6, 12:28 AM

Mon, Aug 5

void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

The combination of D60942, D06943 and D65280 solves the problems for me on all targets I have.

Mon, Aug 5, 3:08 PM · Restricted Project, Restricted Project

Fri, Aug 2

void committed rG41a2847a9ae5: Emit diagnostic if an inline asm constraint requires an immediate (authored by void).
Emit diagnostic if an inline asm constraint requires an immediate
Fri, Aug 2, 10:55 PM
void committed rL367750: Emit diagnostic if an inline asm constraint requires an immediate.
Emit diagnostic if an inline asm constraint requires an immediate
Fri, Aug 2, 10:53 PM
void closed D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Fri, Aug 2, 10:52 PM · Restricted Project
void committed rG383650c7f19b: Add brackets to remove warnings about ambiguous 'else's. (authored by void).
Add brackets to remove warnings about ambiguous 'else's.
Fri, Aug 2, 5:28 PM
void committed rL367740: Add brackets to remove warnings about ambiguous 'else's..
Add brackets to remove warnings about ambiguous 'else's.
Fri, Aug 2, 5:28 PM

Wed, Jul 31

void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Friendly ping. :-)

Wed, Jul 31, 2:31 PM · Restricted Project, Restricted Project

Mon, Jul 29

void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Mon, Jul 29, 3:37 PM · Restricted Project
void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Mon, Jul 29, 2:57 PM · Restricted Project
void added inline comments to D64963: Add a pass to lower is.constant intrinsics.
Mon, Jul 29, 1:49 PM · Restricted Project
void added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

Feel free to hijack my revision. :-) I may not get back to my change soon.

Mon, Jul 29, 1:43 PM · Restricted Project

Sun, Jul 28

void added a comment to D60942: Emit diagnostic if an inline asm constraint requires an immediate.

I've updated this patch to better coincide with D60943. It adds support for RISC-V inline asm immediate constraints (to make the errors match those of the front-end) and a few more tests. Please take another look, since these are non-trivial changes.

Sun, Jul 28, 12:59 AM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Update testing. This adds support for RISC-V inline asm immediate constraints
so that we emit the same errors that the front-end would.

Sun, Jul 28, 12:59 AM · Restricted Project
void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Move a few more tests around. Some go to the LLVM side.

Sun, Jul 28, 12:48 AM · Restricted Project, Restricted Project

Sat, Jul 27

void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Don't emit errors here. Wait until codegen.

Sat, Jul 27, 11:39 PM · Restricted Project, Restricted Project
void updated the diff for D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Save checking of immediates until code generation.

Sat, Jul 27, 2:16 PM · Restricted Project, Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Emit an error for an out-of-range immediate.

Sat, Jul 27, 2:14 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

"like" :: "line" -- "potAYto" :: "potAHto"

Sat, Jul 27, 1:19 PM · Restricted Project
void added inline comments to D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Sat, Jul 27, 1:05 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Mark some constraints which require immediates as needing immediates.

Sat, Jul 27, 1:05 PM · Restricted Project

Fri, Jul 26

void added inline comments to D60942: Emit diagnostic if an inline asm constraint requires an immediate.
Fri, Jul 26, 5:18 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Remove file that sneaked in.

Fri, Jul 26, 5:18 PM · Restricted Project
void abandoned D65181: Use the MachineBasicBlock symbol for a callbr target.
Fri, Jul 26, 5:16 PM · Restricted Project
void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

That was intentional. We want to do this for more than just the n constraint.

Fri, Jul 26, 5:16 PM · Restricted Project, Restricted Project
void added a parent revision for D65352: [CodeGen] Require a name for a block addr target: D65304: [MC] Don't recreate a label if it's already used.
Fri, Jul 26, 4:55 PM · Restricted Project
void added a child revision for D65304: [MC] Don't recreate a label if it's already used: D65352: [CodeGen] Require a name for a block addr target.
Fri, Jul 26, 4:55 PM · Restricted Project
void created D65352: [CodeGen] Require a name for a block addr target.
Fri, Jul 26, 2:54 PM · Restricted Project

Thu, Jul 25

void created D65304: [MC] Don't recreate a label if it's already used.
Thu, Jul 25, 3:49 PM · Restricted Project

Jul 23 2019

void created D65181: Use the MachineBasicBlock symbol for a callbr target.
Jul 23 2019, 6:28 PM · Restricted Project

Jul 22 2019

void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

It would be nice to merge this fix into 9.0 branch after some time in trunk. What do you think?

@hans

Sounds like this was reverted on trunk. Please let me know if there are follow-ups that might be candidates for merging.

Jul 22 2019, 9:33 PM · Restricted Project

Jul 19 2019

void abandoned D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 11:43 AM · Restricted Project
void added inline comments to D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 3:39 AM · Restricted Project
void updated the diff for D64982: [AsmPrinter] Print label if MBB's address is taken.

Cast to reference.

Jul 19 2019, 3:32 AM · Restricted Project
void added inline comments to D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 2:45 AM · Restricted Project
void created D64982: [AsmPrinter] Print label if MBB's address is taken.
Jul 19 2019, 2:20 AM · Restricted Project

Jul 18 2019

void committed rGccbffefccaff: Use the MachineBasicBlock symbol for a callbr target (authored by void).
Use the MachineBasicBlock symbol for a callbr target
Jul 18 2019, 6:14 PM
void committed rL366523: Use the MachineBasicBlock symbol for a callbr target.
Use the MachineBasicBlock symbol for a callbr target
Jul 18 2019, 6:10 PM
void closed D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 18 2019, 6:10 PM · Restricted Project
void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

Thanks! Though your example pointed out a separate problem: not accepting the label as a valid operand. I'll do some work on that.

Jul 18 2019, 6:01 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Git-ifying my change.

Jul 18 2019, 5:32 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Revert accidentally added files.

Jul 18 2019, 5:26 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Revert the prvious update

Jul 18 2019, 5:19 PM · Restricted Project
void updated the diff for D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Updating.

Jul 18 2019, 5:16 PM · Restricted Project
void updated the diff for D64963: Add a pass to lower is.constant intrinsics.

Remove other commit.

Jul 18 2019, 5:16 PM · Restricted Project
void created D64963: Add a pass to lower is.constant intrinsics.
Jul 18 2019, 5:07 PM · Restricted Project
void added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 18 2019, 4:59 PM · Restricted Project

Jul 17 2019

void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Update test with correct dest labels

Jul 17 2019, 5:13 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Update triple.

Jul 17 2019, 4:55 PM · Restricted Project
void added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 17 2019, 4:39 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Use for-each loop.

Jul 17 2019, 4:23 PM · Restricted Project
void added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 17 2019, 3:26 PM · Restricted Project
void added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 17 2019, 3:20 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Fix syntax errors and use better accessor methods.

Jul 17 2019, 3:20 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Fix bad update.

Jul 17 2019, 3:12 PM · Restricted Project
void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 17 2019, 3:12 PM · Restricted Project
void updated the diff for D64888: Use the MachineBasicBlock symbol for a callbr target.

Add testcase.

Jul 17 2019, 3:07 PM · Restricted Project
void added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

Test?

Jul 17 2019, 2:59 PM · Restricted Project
void created D64888: Use the MachineBasicBlock symbol for a callbr target.
Jul 17 2019, 2:46 PM · Restricted Project

Jul 14 2019

void committed rG796ed134ccc3: Remove set but unused variable. (authored by void).
Remove set but unused variable.
Jul 14 2019, 11:38 PM
void committed rL366041: Remove set but unused variable..
Remove set but unused variable.
Jul 14 2019, 11:38 PM

Jul 9 2019

void added a comment to D60942: Emit diagnostic if an inline asm constraint requires an immediate.

Friendly ping.

Jul 9 2019, 12:08 AM · Restricted Project
void added a comment to D60943: Delay diagnosing asm constraints that require immediates until after inlining.

Friendly ping.

Jul 9 2019, 12:08 AM · Restricted Project, Restricted Project

Jul 8 2019

void committed rG858e35160e2b: Add parentheses to silence warnings. (authored by void).
Add parentheses to silence warnings.
Jul 8 2019, 3:09 PM
void committed rL365397: Add parentheses to silence warnings..
Add parentheses to silence warnings.
Jul 8 2019, 3:09 PM