In D68483#1697207, @thakis wrote:

I reverted this in r373898 since MC/AsmParser/directive_ascii.s failed on bots. I didn't look into it, but maybe it's because there's no bounds checking on the i + 1 index.

Adding testcase for hex over 0xFF.

You forgot to add the InfiniteLoopCheck.cpp file.

LGTMing. Others please comment if you have objections.

The llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll change LGTM.

This PR is possibly related to the original issue: https://bugs.llvm.org/show_bug.cgi?id=42956

Move method out-of-line to keep MCContext.h simpler.

In D65352#1622024, @nickdesaulniers wrote:

I think the comment in LLVMTargetMachine::addAsmPrinter about // Don't waste memory on names of temp labels. should be amended in this patch to say ... unless it's address is taken or something to that effect.

Update testcase.

Remove smelly code and use correct triple in test.

In the "Revision Contents" box, there's a "Stack" tab. It looks like that's what shows the relationship.

It's not enough to just check that a BB's address is used by a callbr, since
the value doesn't have to be directly used by it. E.g., it could be stored into
memory and then loaded.

Remove accidentally added files.

Ah! Good point. Use "any_of" instead of creating a symbol for all block addresses.

Ugh! The last update combined D65304 with this...:-/

In D60943#1619579, @JamesNagurne wrote:

In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's inspecting assembly.
See clang/test/CodeGen/addrsig.c to see how that is handled (via REQUIRES: x86-registered-target).

Oddly enough, other tests that use -triple x86_64* and only inspect the AST don't require the registered target.

Friendly ping. :-)

Friendly ping. :-)

In D60943#1612083, @joerg wrote:

The combination of D60942, D06943 and D65280 solves the problems for me on all targets I have.

Friendly ping. :-)

Feel free to hijack my revision. :-) I may not get back to my change soon.

I've updated this patch to better coincide with D60943. It adds support for RISC-V inline asm immediate constraints (to make the errors match those of the front-end) and a few more tests. Please take another look, since these are non-trivial changes.

Update testing. This adds support for RISC-V inline asm immediate constraints
so that we emit the same errors that the front-end would.

Move a few more tests around. Some go to the LLVM side.

Don't emit errors here. Wait until codegen.

Save checking of immediates until code generation.

Emit an error for an out-of-range immediate.

"like" :: "line" -- "potAYto" :: "potAHto"

Mark some constraints which require immediates as needing immediates.

Remove file that sneaked in.

That was intentional. We want to do this for more than just the n constraint.

In D64888#1596336, @hans wrote:

In D64888#1593116, @xbolva00 wrote:

It would be nice to merge this fix into 9.0 branch after some time in trunk. What do you think?

@hans

Sounds like this was reverted on trunk. Please let me know if there are follow-ups that might be candidates for merging.

Cast to reference.

Thanks! Though your example pointed out a separate problem: not accepting the label as a valid operand. I'll do some work on that.

Git-ifying my change.

Revert accidentally added files.

Revert the prvious update

Updating.

Remove other commit.

Update test with correct dest labels

Update triple.