This patch enables support for Cortex-A510 CPUs.
|850 ms||x64 debian > Clang.Misc::target-invalid-cpu-note.c|
Script: -- : 'RUN: at line 2'; not /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/14.0.0/include -nostdsysteminc -triple armv5--- -target-cpu not-a-cpu -fsyntax-only /var/lib/buildkite-agent/builds/llvm-project/clang/test/Misc/target-invalid-cpu-note.c 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/clang/test/Misc/target-invalid-cpu-note.c --check-prefix ARM
As I did the downstream work for this, I'm happy with it to go in in this form.
This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and it is probably best not to review patches you write yourself.
Why is this 8.3? The TRM (https://developer.arm.com/documentation/101604/0003/The-Cortex-A510--core) describes it as implementing the 9.0-A architecture.
This should be in some sort of order, next to the Cortex-A55. It should probably be called ProcA510 for consistency too.
Ordering. Please use the CortexA55Model. This is not an out of order core like the A57.
This can be the same case block as the A53 and A55.
Yeah, those changes are in history, But we need them in the present to commit :)
The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line?
I'm not convinced this is required - those tests are to ensure that the extensions (rcpc, dotprod) can be enabled either from a -march, or from a -mcpu=<cpu> with a cpu that contains that extension -- they are not testing that the extension is enabled from *all* cpus that contain said extension.
Thanks, but did this change miss being updated in the review?
This still needs doing. Also please add a line to the arm section saying "Added support for the Armv9-A, Armv9.1-A and Armv9.2-A architectures."
It looks like there are some llvm release notes in llvm/docs/ReleaseNotes.rst too, that could have a line added.
AEK_PAUTH is twice here.