This patch enables support for Cortex-A510 CPUs.
As I did the downstream work for this, I'm happy with it to go in in this form.
This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and it is probably best not to review patches you write yourself.
Why is this 8.3? The TRM (https://developer.arm.com/documentation/101604/0003/The-Cortex-A510--core) describes it as implementing the 9.0-A architecture.
This should be in some sort of order, next to the Cortex-A55. It should probably be called ProcA510 for consistency too.
Ordering. Please use the CortexA55Model. This is not an out of order core like the A57.
|196 ↗||(On Diff #372691)|
This can be the same case block as the A53 and A55.
Yeah, those changes are in history, But we need them in the present to commit :)
The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line?
I'm not convinced this is required - those tests are to ensure that the extensions (rcpc, dotprod) can be enabled either from a -march, or from a -mcpu=<cpu> with a cpu that contains that extension -- they are not testing that the extension is enabled from *all* cpus that contain said extension.
Thanks, but did this change miss being updated in the review?
|86 ↗||(On Diff #378645)|
This still needs doing. Also please add a line to the arm section saying "Added support for the Armv9-A, Armv9.1-A and Armv9.2-A architectures."
It looks like there are some llvm release notes in llvm/docs/ReleaseNotes.rst too, that could have a line added.
AEK_PAUTH is twice here.