User
User Details
- User Since
- Mar 5 2020, 7:57 AM (116 w, 2 d)
Apr 6 2022
Jan 28 2022
Thank you for review.
@aaron.ballman should I commit the patch? I have checked the html files in browser they looks good now.
Jan 26 2022
LGTM, Thanks!
Address comments
Jan 17 2022
Jan 6 2022
Oh, Thank you for your efforts @aykevl!
Jan 3 2022
Thanks for review.
Thanks for review.
clang-format
Dec 22 2021
test case update
Dec 21 2021
Sorry, I didn't read it before (I have seen a few times contributors commit in the such/same way) I will take care to not commit until patch is approved and all reviewers satisfy with the changes.
Dec 20 2021
update
.
Dec 19 2021
Honestly, I am not aware that you are only reviewing the RISCV test case. I have no objection to reverting it immediately if any SelectionDAG developer objects to change.
Adding @sushmaunnibhavi (who started GISel support in M68k) as a reviewer in case she still working in this area.
Sorry to ping reviewers (i am not confident to review it myself) to review, as this patch's .cfi_remeber_state & .cfi_remember_state support is a prerequisite to fix/complete the RISCV CFI directive support. Just a question: the patch is adding .cfi_same_value support but no test case shows that functionality?
minor fix after lint
I will commit as it seems not a big change. and all comments are addressed.
Dec 18 2021
Can someone accept the patch so I commit the change?
update
Dec 17 2021
comment fix
Thank you suggestions. I get to know many things.
address comments
.
There is some problem with the script when I generate .ll file with -g flag and use it to generate CHECK lines it will not work, but it work when the test case has no debug info. This debuginfo test also doesn't use the script for check lines https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/dwarf-eh.ll.
Address comments
Dec 15 2021
minor fix
Dec 13 2021
A test case is missing, but I tested on local system, above reported issue is now fixed.
Dec 11 2021
Dec 8 2021
Dec 5 2021
Will do it later.
Nov 30 2021
sorry, I don't know the meaning of dwarf. From google search- cause to seem small or insignificant in comparison.
Nov 28 2021
Nov 26 2021
LGTM, thanks.
Nov 24 2021
Nov 23 2021
ping @dvyukov, Does this patch need a review or It was my mistake in configure step.
(@chill, I am also waiting for your patch as these two CFI directives are needed to fix the stack unwinding issue with shrink wrapping in RISCV)
Nov 14 2021
I have taken this example from https://reviews.llvm.org/D69723 to understand the problem with stack unwinding.
Nov 8 2021
can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?
Oops, commented on wrong review.
can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?
Nov 3 2021
update
update
.
Nov 2 2021
Thanks for the review.
address comments
mention similar update script
[mlir][sparse] tag should be in beginning, see https://llvm.org/docs/DeveloperPolicy.html#commit-messages. There should be a summary of "why" you have created this patch or renamed the file. You can do so from the Edit revision button available at the top right corner.
Nov 1 2021
correct heading
Oct 28 2021
Hi @luismarques, Do you have any comments here? Or what happens(break) when this CFI directive is emitted and shrink wrapping is used, an example? Stack unwinding problem, still it is here, what it needed to be fixed, maybe some hint.
update all test cases
Oct 26 2021
Hi @HsiangKai, I want to know how you have written 12877+ lines of test cases such as in https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/rvv/vluxseg-rv32.ll . I need to update them in this patch to pass check-llvm. It is some script? can you please tell me how to use that.
.
Oct 25 2021
rebase, address nits, and committed in https://reviews.llvm.org/rGb2544fb9c5b38339572d50048563e8b6e72bf0ad, Thanks.