User
User Details
- User Since
- Mar 5 2020, 7:57 AM (159 w, 2 d)
Wed, Mar 8
Wed, Mar 1
LGTM, Thank.
Seems reasonable.
Feb 20 2023
Feb 17 2023
Feb 16 2023
gentle ping for review.
Feb 14 2023
gentle ping for review.
Feb 11 2023
Feb 6 2023
address comments
remove old code
use function to avoid code duplication
Feb 3 2023
remov blank
clang-format
gentle ping for review.
Feb 1 2023
Jan 31 2023
address comment
I use arc diff to upload and update the patch every time (I heard people saying arcanist is smart) and arc patch D142323 to review the author's patch.
Thank you so much for reviewing my first patch :>
address comments
Jan 30 2023
Yeah, I saw someone asking about it on discord on Sunday. so thought to look.
update release note
address comment
Jan 29 2023
Thank you for the patch!
Jan 28 2023
update test cases
Jan 27 2023
sorry, I missed and committed, you have also added a new reviewer.
Jan 26 2023
Ah, Thanks. Then it is fine. I will drop this revision since fixed is already there.
WIP && TODO- Fixed test
add test cases
Jan 24 2023
Jan 23 2023
address comments
fix build
address comments
Ah, this particular fault is because I recently added a new element to MIR files. It would appear that you're using an older version of llc to read the output of a newer llc -- you should be able to just rebuild llc and it will work, or in the worst case, rebase onto a commit more recent than rG9f8544713ad8e57.
use --llc-binary build/bin/llc to correcting update test case
update test case for CHECK lines.
address comments
address comments