Page MenuHomePhabricator

xgupta (Shivam Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2020, 7:57 AM (159 w, 2 d)

User

Recent Activity

Wed, Mar 8

xgupta requested review of D145554: [Docs] Fix a link for cray-pointer documentation.
Wed, Mar 8, 1:04 AM · Restricted Project, Restricted Project

Wed, Mar 1

xgupta accepted D145039: Move close() to the proper else block.

LGTM, Thank.
Seems reasonable.

Wed, Mar 1, 5:32 AM · Restricted Project, Restricted Project

Feb 20 2023

xgupta committed rGbfb1559fbe2f: [NFC] Fix missing colon in CHECK directives (authored by aabhinavg).
[NFC] Fix missing colon in CHECK directives
Feb 20 2023, 10:43 AM · Restricted Project, Restricted Project
xgupta closed D144412: [NFC] Fix missing colon in CHECK directives.
Feb 20 2023, 10:43 AM · Restricted Project, Restricted Project

Feb 17 2023

xgupta added a reviewer for D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/: kastiglione.
Feb 17 2023, 6:22 AM · Restricted Project, Restricted Project

Feb 16 2023

xgupta added a comment to D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

gentle ping for review.

Feb 16 2023, 5:40 AM · Restricted Project, Restricted Project

Feb 14 2023

xgupta added a comment to D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.

gentle ping for review.

Feb 14 2023, 6:58 AM · Restricted Project, Restricted Project

Feb 11 2023

xgupta committed rG19c42f672f94: [DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file (authored by DarshanRamakant).
[DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file
Feb 11 2023, 1:02 AM · Restricted Project, Restricted Project
xgupta closed D139767: [DFAPacketizer] Move DefaultVLIWScheduler class declaration to header file.
Feb 11 2023, 1:02 AM · Restricted Project, Restricted Project
xgupta reopened D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.
Feb 11 2023, 12:35 AM · Restricted Project, Restricted Project

Feb 6 2023

xgupta added inline comments to D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.
Feb 6 2023, 9:59 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

address comments

Feb 6 2023, 9:51 PM · Restricted Project, Restricted Project
xgupta added a comment to D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.

LGTM, but I wonder when we'll be able to get rid of RenderScript completely (CC @labath)

I am not going to stand in your way. I usually redirect these questions to @srhines, but I understand he's moved on to other things as well.

Feb 6 2023, 9:21 AM · Restricted Project, Restricted Project
xgupta committed rG0b8eff1f8724: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp (authored by xgupta).
[LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp
Feb 6 2023, 8:38 AM · Restricted Project
xgupta closed D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.
Feb 6 2023, 8:38 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

remove old code

Feb 6 2023, 7:18 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

use function to avoid code duplication

Feb 6 2023, 7:10 AM · Restricted Project, Restricted Project

Feb 3 2023

xgupta added inline comments to D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.
Feb 3 2023, 7:41 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

remov blank

Feb 3 2023, 7:22 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

clang-format

Feb 3 2023, 7:19 AM · Restricted Project, Restricted Project
xgupta added a comment to D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.

LGTM, but I wonder when we'll be able to get rid of RenderScript completely (CC @labath)

Feb 3 2023, 2:46 AM · Restricted Project, Restricted Project
xgupta added a comment to D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.

gentle ping for review.

Feb 3 2023, 2:45 AM · Restricted Project, Restricted Project

Feb 1 2023

xgupta added a comment to D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910

You can reproduce the bot using the instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (substitute buildbot_fast.sh for buildbot_cmake.sh to get the right one, but I don't think using the official buildscript is necessary. This looks like a 2-stage compile is not currently -Wextra -Werror clean:

/b/sanitizer-x86_64-linux/build/llvm-project/llvm/lib/ProfileData/InstrProfReader.cpp:177:41: error: result of comparison 'uint64_t' (aka 'unsigned long') > 18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare]
  if (uint64_t(Buffer->getBufferSize()) > std::numeric_limits<uint64_t>::max())
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/sanitizer-x86_64-linux/build/llvm-project/llvm/lib/ProfileData/InstrProfReader.cpp:227:41: error: result of comparison 'uint64_t' (aka 'unsigned long') > 18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare]
  if (uint64_t(Buffer->getBufferSize()) > std::numeric_limits<uint64_t>::max())
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I tried to whack-a-mole those two bugs (see my two commits on https://lab.llvm.org/buildbot/#/builders/37/builds/19926), but there's more latent bugs hanging around.

Probably worth reverting this and the warnings need to be fixed inside clang/llvm first, then we can make it the default.

Feb 1 2023, 4:32 PM · Restricted Project, Restricted Project
xgupta added a reverting change for rG95668c0d97e6: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility: rG897e345042cd: Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility".
Feb 1 2023, 4:30 PM · Restricted Project, Restricted Project
xgupta committed rG897e345042cd: Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility" (authored by xgupta).
Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility"
Feb 1 2023, 4:30 PM · Restricted Project, Restricted Project
xgupta added a reverting change for D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility: rG897e345042cd: Revert "[Clang] Add -Wtype-limits to -Wextra for GCC compatibility".
Feb 1 2023, 4:30 PM · Restricted Project, Restricted Project
xgupta added a comment to D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

LGTM, thank you!

Feb 1 2023, 6:02 AM · Restricted Project, Restricted Project
xgupta committed rG95668c0d97e6: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility (authored by xgupta).
[Clang] Add -Wtype-limits to -Wextra for GCC compatibility
Feb 1 2023, 6:01 AM · Restricted Project, Restricted Project
xgupta closed D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.
Feb 1 2023, 6:00 AM · Restricted Project, Restricted Project

Jan 31 2023

xgupta updated the diff for D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

address comment

Jan 31 2023, 7:21 PM · Restricted Project, Restricted Project
xgupta added a comment to D142323: [Kaleidoscope] Update code snippets in text to match full code listings.

Okay, I have fixed the code and I think the patch is ready now. It turns out you have to specify the number of commits to push to the patch, arc doesn't pick up on it automatically. Also, in my case it didn't pick up on the fact that I already had a patch (or is it revision?) made, so I had to use the command arc diff HEAD~~ --update D142323 and everything seems fine.

I use arc diff to upload and update the patch every time (I heard people saying arcanist is smart) and arc patch D142323 to review the author's patch.

Thank you so much for reviewing my first patch :>

Jan 31 2023, 10:07 AM · Restricted Project, Restricted Project
xgupta committed rG1625530d7655: [Kaleidoscope] Update code snippets in text to match full code listings (authored by 0xdc03).
[Kaleidoscope] Update code snippets in text to match full code listings
Jan 31 2023, 10:01 AM · Restricted Project, Restricted Project
xgupta closed D142323: [Kaleidoscope] Update code snippets in text to match full code listings.
Jan 31 2023, 10:01 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

address comments

Jan 31 2023, 9:38 AM · Restricted Project, Restricted Project
xgupta added a comment to D142323: [Kaleidoscope] Update code snippets in text to match full code listings.

@xgupta I have updated the comment in the code listing to match the code that creates the function. I think it is better to keep the ExitOnError variable as I was quite confused as to what ExitOnErr was when reading the tutorial and I only realized it once I scrolled to the end and found the declaration. If this seems correct to you, can you land this patch for me as I do not have commit access? Please use "Dhruv Chawla <dhruv263.dc@gmail.com>" to commit the change.

Thanks!

PS: I am a little concerned if I updated my revision correctly: I used arc diff --update to commit my second change, and I am not sure if that is correct as phabricator is only showing the diff against the second commit...

Jan 31 2023, 6:38 AM · Restricted Project, Restricted Project
xgupta added inline comments to D142323: [Kaleidoscope] Update code snippets in text to match full code listings.
Jan 31 2023, 6:36 AM · Restricted Project, Restricted Project

Jan 30 2023

xgupta added a comment to D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

Heh, I literally started working on this on Friday afternoon. :-D

Yeah, I saw someone asking about it on discord on Sunday. so thought to look.

Jan 30 2023, 7:59 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

update release note

Jan 30 2023, 7:57 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

address comment

Jan 30 2023, 7:48 PM · Restricted Project, Restricted Project

Jan 29 2023

xgupta accepted D142323: [Kaleidoscope] Update code snippets in text to match full code listings.

Thank you for the patch!

Jan 29 2023, 11:25 AM · Restricted Project, Restricted Project

Jan 28 2023

xgupta requested review of D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.
Jan 28 2023, 8:51 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

update test cases

Jan 28 2023, 5:46 AM · Restricted Project, Restricted Project

Jan 27 2023

xgupta added a comment to D142633: [Docs] Fix a statement wrt instruction alignment of 0.

It looks like the definition of stores has the same "value of 0 or" language?

Otherwise looks fine.

Jan 27 2023, 9:03 PM · Restricted Project, Restricted Project
xgupta committed rG6cfebf39103e: [Docs] Fix a statement wrt instruction alignment of 0 (authored by xgupta).
[Docs] Fix a statement wrt instruction alignment of 0
Jan 27 2023, 9:02 PM · Restricted Project, Restricted Project
xgupta added a comment to D142633: [Docs] Fix a statement wrt instruction alignment of 0.

sorry, I missed and committed, you have also added a new reviewer.

Jan 27 2023, 6:45 AM · Restricted Project, Restricted Project
xgupta committed rG9922c78a67eb: [Docs] Fix a statement wrt instruction alignment of 0 (authored by xgupta).
[Docs] Fix a statement wrt instruction alignment of 0
Jan 27 2023, 3:59 AM · Restricted Project, Restricted Project
xgupta closed D142633: [Docs] Fix a statement wrt instruction alignment of 0.
Jan 27 2023, 3:58 AM · Restricted Project, Restricted Project

Jan 26 2023

xgupta planned changes to D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.
Jan 26 2023, 10:06 AM · Restricted Project, Restricted Project
xgupta abandoned D142308: [Polly] Fix a if condition in isl_coalesce.ci.
Jan 26 2023, 9:28 AM · Restricted Project, Restricted Project
xgupta added a comment to D142308: [Polly] Fix a if condition in isl_coalesce.ci.

Thank you for the patch. However, we do not patch ISL in the LLVM directly, but instead report upstream to isl-development@googlegroups.com and then update the LLVM copy.

I think this has already been fixed upstream in https://repo.or.cz/isl.git/blobdiff/f7b0ef95845d57fc839090d5075b84fa706eeb15..f035f41be325a5e173d6531f384ded9799943d87:/isl_coalesce.c . I just updated the LLVM copy. The funcion now reads

	if (any) {
		if (isl_tab_rollback(info->tab, snap) < 0)
			return isl_stat_error;
		info->bmap = isl_basic_map_cow(info->bmap);
		info->bmap = isl_basic_map_free_inequality(info->bmap, 2 * n);
		if (!info->bmap)
			return isl_stat_error;

		return fix_constant_divs(info, n, expanded);
	}

Please check whether the problem still occurs. I cannot check without a test case.

Ah, Thanks. Then it is fine. I will drop this revision since fixed is already there.

Jan 26 2023, 9:27 AM · Restricted Project, Restricted Project
xgupta added a reviewer for D142633: [Docs] Fix a statement wrt instruction alignment of 0: zero9178.
Jan 26 2023, 9:23 AM · Restricted Project, Restricted Project
xgupta committed rGded3644a3f8e: [MLIR][NFC] Fix a checked after used case in ReshapeOpsUtils.cpp (authored by xgupta).
[MLIR][NFC] Fix a checked after used case in ReshapeOpsUtils.cpp
Jan 26 2023, 9:21 AM · Restricted Project, Restricted Project
xgupta closed D142312: [MLIR][NFC] Fix a checked after used case in ReshapeOpsUtils.cpp.
Jan 26 2023, 9:21 AM · Restricted Project, Restricted Project
xgupta requested review of D142633: [Docs] Fix a statement wrt instruction alignment of 0.
Jan 26 2023, 7:35 AM · Restricted Project, Restricted Project
xgupta added a comment to D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

WIP && TODO- Fixed test

Jan 26 2023, 3:42 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.

add test cases

Jan 26 2023, 2:59 AM · Restricted Project, Restricted Project
xgupta requested review of D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant.
Jan 26 2023, 2:36 AM · Restricted Project, Restricted Project

Jan 24 2023

xgupta added a reviewer for D142312: [MLIR][NFC] Fix a checked after used case in ReshapeOpsUtils.cpp: ftynse.
Jan 24 2023, 10:14 PM · Restricted Project, Restricted Project
xgupta added a comment to D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.

Thanks for the work on this patch! MIR tests aren't the most fun to write/generate, but doing so builds muscle!

Jan 24 2023, 9:35 PM · Restricted Project, Restricted Project
xgupta committed rG7454439674a4: [zero-call-used-regs] Mark only non-debug instruction's register as used (authored by xgupta).
[zero-call-used-regs] Mark only non-debug instruction's register as used
Jan 24 2023, 9:34 PM · Restricted Project, Restricted Project
xgupta closed D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.
Jan 24 2023, 9:33 PM · Restricted Project, Restricted Project

Jan 23 2023

xgupta added inline comments to D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.
Jan 23 2023, 11:39 PM · Restricted Project, Restricted Project
xgupta updated the diff for D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.

address comments

Jan 23 2023, 11:37 PM · Restricted Project, Restricted Project
xgupta committed rG40003af98456: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC (authored by xgupta).
[Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC
Jan 23 2023, 10:26 PM · Restricted Project, Restricted Project
xgupta closed D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC.
Jan 23 2023, 10:26 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.

fix build

Jan 23 2023, 9:56 PM · Restricted Project, Restricted Project
xgupta added a reviewer for D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/: jingham.
Jan 23 2023, 9:17 PM · Restricted Project, Restricted Project
xgupta added a comment to D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.

I don't think this code is going to compile, is it? You took out the if (!buffer) { but left the RHS } so now the scopes are unbalanced. I think you should just change how the shared pointer is defined - which is presumably the substance of the patch - and leave everything after as is.

Jan 23 2023, 9:15 PM · Restricted Project, Restricted Project
xgupta updated the diff for D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.

address comments

Jan 23 2023, 9:14 PM · Restricted Project, Restricted Project
xgupta added a comment to D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.

Ah, this particular fault is because I recently added a new element to MIR files. It would appear that you're using an older version of llc to read the output of a newer llc -- you should be able to just rebuild llc and it will work, or in the worst case, rebase onto a commit more recent than rG9f8544713ad8e57.

Jan 23 2023, 11:32 AM · Restricted Project, Restricted Project
xgupta updated the diff for D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.

use --llc-binary build/bin/llc to correcting update test case

Jan 23 2023, 11:30 AM · Restricted Project, Restricted Project
xgupta updated the diff for D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used.

update test case for CHECK lines.

Jan 23 2023, 11:21 AM · Restricted Project, Restricted Project
xgupta added a comment to D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h.

I looked through the code base and I think this fix is good but benign (it doesn't look like it'll impact anything that I can see). So LGTM without tests.

Jan 23 2023, 10:19 AM · Restricted Project, Restricted Project
xgupta committed rG94b9187a7d37: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h (authored by xgupta).
[Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h
Jan 23 2023, 10:18 AM · Restricted Project, Restricted Project
xgupta closed D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h.
Jan 23 2023, 10:18 AM · Restricted Project, Restricted Project
xgupta added a comment to D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC.

LGTM, assuming the pre-commit CI failures are unrelated.

Jan 23 2023, 8:25 AM · Restricted Project, Restricted Project
xgupta added a comment to D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h.

LGTM but can you find a test case that would show we don't regress this in the future?

Jan 23 2023, 8:02 AM · Restricted Project, Restricted Project
xgupta committed rG68b890831615: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h (authored by xgupta).
[Clang[NFC] Fix bitmask for NullabilityPayload in Types.h
Jan 23 2023, 6:48 AM · Restricted Project, Restricted Project
xgupta closed D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h.
Jan 23 2023, 6:48 AM · Restricted Project, Restricted Project
xgupta updated the summary of D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h.
Jan 23 2023, 4:57 AM · Restricted Project, Restricted Project
xgupta added inline comments to D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h.
Jan 23 2023, 4:55 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h.

address comments

Jan 23 2023, 4:54 AM · Restricted Project, Restricted Project
xgupta retitled D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/ from [LLDB][NFC] Fix a null pointer check in LibCxx.cpp to [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.
Jan 23 2023, 3:48 AM · Restricted Project, Restricted Project
xgupta updated the diff for D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.

address comments

Jan 23 2023, 3:44 AM · Restricted Project, Restricted Project
xgupta added a comment to D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.

Looks correct to me, given we seem to allow valobj_sp to be null. Though we seem to be doing it in a lot of other places too around this file. So could fix those all at once?

Jan 23 2023, 3:21 AM · Restricted Project, Restricted Project
xgupta updated the summary of D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.
Jan 23 2023, 2:55 AM · Restricted Project, Restricted Project
xgupta requested review of D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/.
Jan 23 2023, 2:54 AM · Restricted Project, Restricted Project
xgupta added reviewers for D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC: aaron.ballman, tbaeder.
Jan 23 2023, 2:24 AM · Restricted Project, Restricted Project
xgupta requested review of D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC.
Jan 23 2023, 2:22 AM · Restricted Project, Restricted Project
xgupta committed rG586ce6ac9e45: [MLIR][NFC] Fix a memset in MemRefUtils.h (authored by xgupta).
[MLIR][NFC] Fix a memset in MemRefUtils.h
Jan 23 2023, 1:45 AM · Restricted Project, Restricted Project
xgupta closed D142310: [MLIR][NFC] Fix a memset in MemRefUtils.h.
Jan 23 2023, 1:45 AM · Restricted Project, Restricted Project
xgupta requested review of D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h.
Jan 23 2023, 1:44 AM · Restricted Project, Restricted Project
xgupta committed rG051bf9cd76ad: [Flang] fix a copy-paste error in scope.cpp (authored by xgupta).
[Flang] fix a copy-paste error in scope.cpp
Jan 23 2023, 1:27 AM · Restricted Project, Restricted Project
xgupta closed D142306: [Flang] fix a copy-paste error in scope.cpp.
Jan 23 2023, 1:26 AM · Restricted Project, Restricted Project

Jan 22 2023

xgupta requested review of D142312: [MLIR][NFC] Fix a checked after used case in ReshapeOpsUtils.cpp.
Jan 22 2023, 9:54 AM · Restricted Project, Restricted Project
xgupta requested review of D142310: [MLIR][NFC] Fix a memset in MemRefUtils.h.
Jan 22 2023, 9:10 AM · Restricted Project, Restricted Project
xgupta requested review of D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp.
Jan 22 2023, 8:59 AM · Restricted Project, Restricted Project
xgupta requested review of D142308: [Polly] Fix a if condition in isl_coalesce.ci.
Jan 22 2023, 8:35 AM · Restricted Project, Restricted Project
xgupta committed rGe4c4841e5bba: [Flang][NFC] fix a cpoy-paste in fold-logical.cpp (authored by xgupta).
[Flang][NFC] fix a cpoy-paste in fold-logical.cpp
Jan 22 2023, 8:12 AM · Restricted Project, Restricted Project
xgupta requested review of D142306: [Flang] fix a copy-paste error in scope.cpp.
Jan 22 2023, 7:59 AM · Restricted Project, Restricted Project