Thank you for review.

@aaron.ballman should I commit the patch? I have checked the html files in browser they looks good now.

LG, Thanks.

LGTM, Thanks!

Address comments

Oh, Thank you for your efforts @aykevl!

Thanks for review.

Thanks for review.

clang-format

test case update

In D115808#3201928, @jrtc27 wrote:

In D115808#3201773, @xgupta wrote:

I will commit as it seems not a big change. and all comments are addressed.

This goes against the LLVM Code-Review Policy and Practices:

Code review can be an iterative process, which continues until the patch is ready to be committed. Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed. Do not assume silent approval, or solicit objections to a patch with a deadline.

• https://llvm.org/docs/CodeReview.html#code-review-workflow

Sorry, I didn't read it before (I have seen a few times contributors commit in the such/same way) I will take care to not commit until patch is approved and all reviewers satisfy with the changes.

update

.

Honestly, I am not aware that you are only reviewing the RISCV test case. I have no objection to reverting it immediately if any SelectionDAG developer objects to change.

Adding @sushmaunnibhavi (who started GISel support in M68k) as a reviewer in case she still working in this area.

Sorry to ping reviewers (i am not confident to review it myself) to review, as this patch's .cfi_remeber_state & .cfi_remember_state support is a prerequisite to fix/complete the RISCV CFI directive support. Just a question: the patch is adding .cfi_same_value support but no test case shows that functionality?

minor fix after lint

I will commit as it seems not a big change. and all comments are addressed.

Can someone accept the patch so I commit the change?

update

comment fix

Thank you suggestions. I get to know many things.

address comments

.

There is some problem with the script when I generate .ll file with -g flag and use it to generate CHECK lines it will not work, but it work when the test case has no debug info. This debuginfo test also doesn't use the script for check lines https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/dwarf-eh.ll.

Address comments

minor fix

A test case is missing, but I tested on local system, above reported issue is now fixed.

In D115094#3174635, @dblaikie wrote:

This'll at least need a test case added - though the specifics of how the warning should work I'll leave up to @aaron.ballman - unless he wants some second opinions. (I don't immediately have a strong feeling either way regarding the current or proposed behavior)

Will do it later.

sorry, I don't know the meaning of dwarf. From google search- cause to seem small or insignificant in comparison.

LGTM, thanks.

In D113009#3149832, @MaskRay wrote:

The page looks outdated. It may need to be converted to .rst.

ping @dvyukov, Does this patch need a review or It was my mistake in configure step.

In D109254#3148360, @chill wrote:

In D109254#3148338, @xgupta wrote:

(@chill, I am also waiting for your patch as these two CFI directives are needed to fix the stack unwinding issue with shrink wrapping in RISCV)

Noted. Unfortunately, the initial algorithm (as described above) was wrong. I've come up with another one I'm working on it right now.

(@chill, I am also waiting for your patch as these two CFI directives are needed to fix the stack unwinding issue with shrink wrapping in RISCV)

I have taken this example from https://reviews.llvm.org/D69723 to understand the problem with stack unwinding.

In D111519#3115534, @jrtc27 wrote:

In D111519#3115513, @xgupta wrote:

Hello @luismarques,

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

define void @branch_and_tail_call(i1 %a) {
; RV32-LABEL: branch_and_tail_call:
; RV32:       # %bb.0:
; RV32-NEXT:    addi sp, sp, -16
; RV32-NEXT:    .cfi_def_cfa_offset 16
; RV32-NEXT:    sw ra, 12(sp)
; RV32-NEXT:    .cfi_offset ra, -4
; RV32-NEXT:    andi a0, a0, 1
; RV32-NEXT:    beqz a0, .LBB2_2
; RV32-NEXT:  # %bb.1: # %blue_pill
; RV32-NEXT:    lw ra, 12(sp)
; RV32-NEXT:    .cfi_restore ra
; RV32-NEXT:    addi sp, sp, 16
; RV32-NEXT:    .cfi_def_cfa_offset 0
; RV32-NEXT:    tail foo
; RV32-NEXT:  .LBB2_2: # %red_pill
; RV32-NEXT:    call bar
; RV32-NEXT:    lw ra, 12(sp)
; RV32-NEXT:    .cfi_restore ra
; RV32-NEXT:    addi sp, sp, 16
; RV32-NEXT:    .cfi_def_cfa_offset 0
; RV32-NEXT:    ret
}

This is clearly the branch_and_tail_call test case in frame-info.ll that had the ; FIXME: fix use of .cfi_restore with wrong CFAs.

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

Oops, commented on wrong review.

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

update

update

.

Thanks for the review.

address comments

mention similar update script

[mlir][sparse] tag should be in beginning, see https://llvm.org/docs/DeveloperPolicy.html#commit-messages. There should be a summary of "why" you have created this patch or renamed the file. You can do so from the Edit revision button available at the top right corner.

correct heading

Hi @luismarques, Do you have any comments here? Or what happens(break) when this CFI directive is emitted and shrink wrapping is used, an example? Stack unwinding problem, still it is here, what it needed to be fixed, maybe some hint.

In D111519#3087096, @jrtc27 wrote:

That is:

utils/update_llc_test_checks.py --llc-binary build/bin/llc -u `find llvm/test/CodeGen/RISCV \( -name '*.ll' -o -name '*.mir' \)`
utils/update_mir_test_checks.py --llc-binary build/bin/llc -u `find llvm/test/CodeGen/RISCV \( -name '*.ll' -o -name '*.mir' \)`

update all test cases

Hi @HsiangKai, I want to know how you have written 12877+ lines of test cases such as in https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/rvv/vluxseg-rv32.ll . I need to update them in this patch to pass check-llvm. It is some script? can you please tell me how to use that.

.

rebase, address nits, and committed in https://reviews.llvm.org/rGb2544fb9c5b38339572d50048563e8b6e72bf0ad, Thanks.