Page MenuHomePhabricator

xgupta (Shivam Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2020, 7:57 AM (116 w, 2 d)

User

Recent Activity

Apr 6 2022

xgupta committed rW1f36d89405de: [GSOC] Improve Clang Diagnostics (authored by xgupta).
[GSOC] Improve Clang Diagnostics
Apr 6 2022, 10:41 AM · Restricted Project

Jan 28 2022

xgupta committed rGc95df64ce064: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers (authored by xgupta).
[NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers
Jan 28 2022, 10:57 PM
xgupta closed D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.
Jan 28 2022, 10:57 PM · Restricted Project
xgupta added a comment to D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

Thank you for review.

Jan 28 2022, 6:49 AM · Restricted Project
xgupta accepted D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

@aaron.ballman should I commit the patch? I have checked the html files in browser they looks good now.

Jan 28 2022, 6:12 AM · Restricted Project

Jan 26 2022

xgupta committed rG82f987fdd046: FIx typo in comment (authored by alextsao1999).
FIx typo in comment
Jan 26 2022, 8:35 AM
xgupta closed D118219: FIx typo in comment.
Jan 26 2022, 8:35 AM · Restricted Project
xgupta accepted D118219: FIx typo in comment.

LG, Thanks.

Jan 26 2022, 8:32 AM · Restricted Project
xgupta accepted D109810: [doc] documentation of code review tools.

LGTM, Thanks!

Jan 26 2022, 8:30 AM · Restricted Project, Restricted Project
xgupta updated the diff for D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

Address comments

Jan 26 2022, 8:19 AM · Restricted Project

Jan 17 2022

xgupta committed rG6f61fe7de97c: [Aarch64] Customer lowering of COPYSIGN to SIMD should check for NEON… (authored by Akshay Kumar <akshay.kumar@blackfigtech.com>).
[Aarch64] Customer lowering of COPYSIGN to SIMD should check for NEON…
Jan 17 2022, 10:56 AM
xgupta closed D116581: [Aarch64] Customer lowering of COPYSIGN to SIMD should check for NEON availability.
Jan 17 2022, 10:55 AM · Restricted Project

Jan 6 2022

xgupta added a comment to D107853: [NFC][AVR] Remove unused isMachineVerifierClean().

Oh, Thank you for your efforts @aykevl!

Jan 6 2022, 5:39 AM · Restricted Project

Jan 3 2022

xgupta added a comment to D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

Thanks for review.

Jan 3 2022, 6:29 AM · Restricted Project
xgupta added a comment to D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

Thanks for review.

Jan 3 2022, 6:11 AM · Restricted Project
xgupta updated the diff for D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

clang-format

Jan 3 2022, 6:11 AM · Restricted Project

Dec 22 2021

xgupta committed rG0489e891199a: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience (authored by xgupta).
[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience
Dec 22 2021, 9:20 PM
xgupta closed D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 22 2021, 9:20 PM · Restricted Project
xgupta added inline comments to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 22 2021, 6:16 AM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

test case update

Dec 22 2021, 6:14 AM · Restricted Project

Dec 21 2021

xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

I will commit as it seems not a big change. and all comments are addressed.

This goes against the LLVM Code-Review Policy and Practices:

Code review can be an iterative process, which continues until the patch is ready to be committed. Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed. Do not assume silent approval, or solicit objections to a patch with a deadline.

Sorry, I didn't read it before (I have seen a few times contributors commit in the such/same way) I will take care to not commit until patch is approved and all reviewers satisfy with the changes.

Dec 21 2021, 2:43 AM · Restricted Project

Dec 20 2021

xgupta added a reverting change for rG731bde1ed30f: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience: rGeb66f0662ad9: Revert "[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug….
Dec 20 2021, 8:14 AM
xgupta committed rGeb66f0662ad9: Revert "[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug… (authored by xgupta).
Revert "[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug…
Dec 20 2021, 8:14 AM
xgupta added a reverting change for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience: rGeb66f0662ad9: Revert "[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug….
Dec 20 2021, 8:14 AM · Restricted Project
xgupta added a reviewer for D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers: aaron.ballman.
Dec 20 2021, 8:08 AM · Restricted Project
xgupta updated the diff for D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

update

Dec 20 2021, 8:08 AM · Restricted Project
xgupta abandoned D115946: [DAG] Directed Acyclic Graph - DOT printer test.
Dec 20 2021, 7:55 AM · Restricted Project
xgupta resigned from D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Dec 20 2021, 3:57 AM · Restricted Project, Restricted Project
xgupta abandoned D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

.

Dec 20 2021, 3:57 AM · Restricted Project
xgupta added inline comments to D115946: [DAG] Directed Acyclic Graph - DOT printer test.
Dec 20 2021, 3:56 AM · Restricted Project
xgupta published D115946: [DAG] Directed Acyclic Graph - DOT printer test for review.
Dec 20 2021, 3:53 AM · Restricted Project

Dec 19 2021

xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

Honestly, I am not aware that you are only reviewing the RISCV test case. I have no objection to reverting it immediately if any SelectionDAG developer objects to change.

Dec 19 2021, 8:33 PM · Restricted Project
xgupta added a reviewer for D115874: [M68k][GlobalISel] Implement lowerCall based on M68k calling convention: sushmaunnibhavi.

Adding @sushmaunnibhavi (who started GISel support in M68k) as a reviewer in case she still working in this area.

Dec 19 2021, 8:29 PM · Restricted Project
xgupta added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Sorry to ping reviewers (i am not confident to review it myself) to review, as this patch's .cfi_remeber_state & .cfi_remember_state support is a prerequisite to fix/complete the RISCV CFI directive support. Just a question: the patch is adding .cfi_same_value support but no test case shows that functionality?

Dec 19 2021, 9:32 AM · Restricted Project, Restricted Project
xgupta updated the diff for D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.

minor fix after lint

Dec 19 2021, 9:14 AM · Restricted Project
xgupta requested review of D116004: [NFC] Add missing doxygen file tag in llvm/include/llvm/ADT/ headers.
Dec 19 2021, 9:09 AM · Restricted Project
xgupta committed rG731bde1ed30f: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience (authored by xgupta).
[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience
Dec 19 2021, 7:33 AM
xgupta closed D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 19 2021, 7:33 AM · Restricted Project
xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

I will commit as it seems not a big change. and all comments are addressed.

Dec 19 2021, 7:32 AM · Restricted Project
xgupta accepted D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 19 2021, 7:30 AM · Restricted Project

Dec 18 2021

xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

Can someone accept the patch so I commit the change?

Dec 18 2021, 8:28 PM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

update

Dec 18 2021, 1:40 AM · Restricted Project

Dec 17 2021

xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

comment fix

Dec 17 2021, 10:16 PM · Restricted Project
xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

Thank you suggestions. I get to know many things.

Dec 17 2021, 10:13 PM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

address comments

Dec 17 2021, 10:11 PM · Restricted Project
xgupta added inline comments to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 17 2021, 3:15 PM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

.

Dec 17 2021, 3:14 PM · Restricted Project
xgupta added a comment to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

There is some problem with the script when I generate .ll file with -g flag and use it to generate CHECK lines it will not work, but it work when the test case has no debug info. This debuginfo test also doesn't use the script for check lines https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/dwarf-eh.ll.

Dec 17 2021, 6:00 AM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

Address comments

Dec 17 2021, 5:55 AM · Restricted Project

Dec 15 2021

xgupta added inline comments to D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 15 2021, 9:52 AM · Restricted Project
xgupta updated the diff for D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.

minor fix

Dec 15 2021, 9:47 AM · Restricted Project
xgupta requested review of D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience.
Dec 15 2021, 9:46 AM · Restricted Project

Dec 13 2021

xgupta accepted D115649: Revert unnecessary and incorrect change made to GraphWriter.

A test case is missing, but I tested on local system, above reported issue is now fixed.

Dec 13 2021, 9:35 PM · Restricted Project

Dec 11 2021

xgupta updated subscribers of D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99.

This'll at least need a test case added - though the specifics of how the warning should work I'll leave up to @aaron.ballman - unless he wants some second opinions. (I don't immediately have a strong feeling either way regarding the current or proposed behavior)

Dec 11 2021, 3:54 AM · Restricted Project

Dec 8 2021

xgupta accepted D115414: [dsymutil][NFC] Fix typo in help message.
Dec 8 2021, 8:18 PM · Restricted Project

Dec 5 2021

xgupta abandoned D113009: [Docs] Mention that compier-rt's check-all depend on clang.

Will do it later.

Dec 5 2021, 8:36 PM · Restricted Project
xgupta committed rGb1eb6a358908: [Docs] Fix a link (authored by xgupta).
[Docs] Fix a link
Dec 5 2021, 8:33 PM
xgupta closed D115119: [Docs] Fix a link.
Dec 5 2021, 8:33 PM · Restricted Project
xgupta requested review of D115119: [Docs] Fix a link.
Dec 5 2021, 10:37 AM · Restricted Project

Nov 30 2021

xgupta abandoned D114850: [Docs] Typo fix.

sorry, I don't know the meaning of dwarf. From google search- cause to seem small or insignificant in comparison.

Nov 30 2021, 11:57 PM · Restricted Project
xgupta requested review of D114850: [Docs] Typo fix.
Nov 30 2021, 11:54 PM · Restricted Project

Nov 28 2021

xgupta updated subscribers of D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Nov 28 2021, 11:13 AM · Restricted Project, Restricted Project

Nov 26 2021

xgupta committed rGa3b099b68c0c: [Docs] Removed /Zd flag still mentioned in documentation (authored by BHUMITRAM).
[Docs] Removed /Zd flag still mentioned in documentation
Nov 26 2021, 4:38 AM
xgupta closed D114632: [Docs] Removed /Zd flag still mentioned in documentation.
Nov 26 2021, 4:38 AM · Restricted Project
xgupta accepted D114632: [Docs] Removed /Zd flag still mentioned in documentation.

LGTM, thanks.

Nov 26 2021, 4:34 AM · Restricted Project

Nov 24 2021

xgupta added a comment to D113009: [Docs] Mention that compier-rt's check-all depend on clang.

The page looks outdated. It may need to be converted to .rst.

Nov 24 2021, 7:19 AM · Restricted Project

Nov 23 2021

xgupta added a comment to D113009: [Docs] Mention that compier-rt's check-all depend on clang.

ping @dvyukov, Does this patch need a review or It was my mistake in configure step.

Nov 23 2021, 2:53 AM · Restricted Project
xgupta added a comment to D109254: [AArch64] Enable CFIInstrInserter.

(@chill, I am also waiting for your patch as these two CFI directives are needed to fix the stack unwinding issue with shrink wrapping in RISCV)

Noted. Unfortunately, the initial algorithm (as described above) was wrong. I've come up with another one I'm working on it right now.

Nov 23 2021, 2:50 AM · Restricted Project, Restricted Project
xgupta added a comment to D109254: [AArch64] Enable CFIInstrInserter.

(@chill, I am also waiting for your patch as these two CFI directives are needed to fix the stack unwinding issue with shrink wrapping in RISCV)

Nov 23 2021, 2:38 AM · Restricted Project, Restricted Project

Nov 14 2021

xgupta added a comment to D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

I have taken this example from https://reviews.llvm.org/D69723 to understand the problem with stack unwinding.

Nov 14 2021, 8:49 PM · Restricted Project
xgupta added a comment to D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

Hello @luismarques,

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

define void @branch_and_tail_call(i1 %a) {
; RV32-LABEL: branch_and_tail_call:
; RV32:       # %bb.0:
; RV32-NEXT:    addi sp, sp, -16
; RV32-NEXT:    .cfi_def_cfa_offset 16
; RV32-NEXT:    sw ra, 12(sp)
; RV32-NEXT:    .cfi_offset ra, -4
; RV32-NEXT:    andi a0, a0, 1
; RV32-NEXT:    beqz a0, .LBB2_2
; RV32-NEXT:  # %bb.1: # %blue_pill
; RV32-NEXT:    lw ra, 12(sp)
; RV32-NEXT:    .cfi_restore ra
; RV32-NEXT:    addi sp, sp, 16
; RV32-NEXT:    .cfi_def_cfa_offset 0
; RV32-NEXT:    tail foo
; RV32-NEXT:  .LBB2_2: # %red_pill
; RV32-NEXT:    call bar
; RV32-NEXT:    lw ra, 12(sp)
; RV32-NEXT:    .cfi_restore ra
; RV32-NEXT:    addi sp, sp, 16
; RV32-NEXT:    .cfi_def_cfa_offset 0
; RV32-NEXT:    ret
}

This is clearly the branch_and_tail_call test case in frame-info.ll that had the ; FIXME: fix use of .cfi_restore with wrong CFAs.

Nov 14 2021, 9:40 AM · Restricted Project

Nov 8 2021

xgupta added a comment to D69723: [RISCV] Fix wrong CFI directives.

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

Nov 8 2021, 7:14 AM · Restricted Project
xgupta added a comment to D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

Oops, commented on wrong review.

Nov 8 2021, 7:13 AM · Restricted Project
xgupta added a comment to D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

can you please tell me how you have generated this assembly mentioned in the commit summary(.c file)?

Nov 8 2021, 7:12 AM · Restricted Project

Nov 3 2021

xgupta added inline comments to D112936: [Docs] Document scripts that are use to generate assertion in test cases.
Nov 3 2021, 11:05 AM · Restricted Project
xgupta committed rG2a7c3f8b02bf: [Docs] Document scripts that are use to generate assertion in test cases (authored by xgupta).
[Docs] Document scripts that are use to generate assertion in test cases
Nov 3 2021, 9:54 AM
xgupta closed D112936: [Docs] Document scripts that are use to generate assertion in test cases.
Nov 3 2021, 9:54 AM · Restricted Project
xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

update

Nov 3 2021, 9:53 AM · Restricted Project
xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

update

Nov 3 2021, 3:38 AM · Restricted Project
xgupta added a comment to D112936: [Docs] Document scripts that are use to generate assertion in test cases.

I have attached the screenshot.

Nov 3 2021, 3:06 AM · Restricted Project
xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

.

Nov 3 2021, 3:05 AM · Restricted Project

Nov 2 2021

xgupta added a comment to D112936: [Docs] Document scripts that are use to generate assertion in test cases.

Thanks for the review.

Nov 2 2021, 7:04 PM · Restricted Project
xgupta updated the summary of D112936: [Docs] Document scripts that are use to generate assertion in test cases.
Nov 2 2021, 7:04 PM · Restricted Project
xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

address comments

Nov 2 2021, 7:00 PM · Restricted Project
xgupta retitled D112936: [Docs] Document scripts that are use to generate assertion in test cases from [Docs] Document update_llc_test_checks.py in TestingGuide.rst to [Docs] Document scripts that are use to generate assertion in test cases.
Nov 2 2021, 6:17 AM · Restricted Project
xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

mention similar update script

Nov 2 2021, 6:11 AM · Restricted Project
xgupta added a comment to D112936: [Docs] Document scripts that are use to generate assertion in test cases.
Nov 2 2021, 5:59 AM · Restricted Project
xgupta requested review of D113009: [Docs] Mention that compier-rt's check-all depend on clang.
Nov 2 2021, 5:50 AM · Restricted Project
xgupta added a comment to D112995: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp".

[mlir][sparse] tag should be in beginning, see https://llvm.org/docs/DeveloperPolicy.html#commit-messages. There should be a summary of "why" you have created this patch or renamed the file. You can do so from the Edit revision button available at the top right corner.

Nov 2 2021, 4:21 AM · Restricted Project

Nov 1 2021

xgupta updated the diff for D112936: [Docs] Document scripts that are use to generate assertion in test cases.

correct heading

Nov 1 2021, 9:12 AM · Restricted Project
xgupta requested review of D112936: [Docs] Document scripts that are use to generate assertion in test cases.
Nov 1 2021, 9:11 AM · Restricted Project

Oct 28 2021

xgupta edited reviewers for D111519: [WIP] [RISCV] Emit cfi directives for function epilogue, added: asb; removed: luke957.

Hi @luismarques, Do you have any comments here? Or what happens(break) when this CFI directive is emitted and shrink wrapping is used, an example? Stack unwinding problem, still it is here, what it needed to be fixed, maybe some hint.

Oct 28 2021, 8:54 AM · Restricted Project
xgupta added a comment to D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

That is:

utils/update_llc_test_checks.py --llc-binary build/bin/llc -u `find llvm/test/CodeGen/RISCV \( -name '*.ll' -o -name '*.mir' \)`
utils/update_mir_test_checks.py --llc-binary build/bin/llc -u `find llvm/test/CodeGen/RISCV \( -name '*.ll' -o -name '*.mir' \)`
Oct 28 2021, 7:20 AM · Restricted Project
xgupta updated the diff for D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

update all test cases

Oct 28 2021, 7:15 AM · Restricted Project

Oct 26 2021

xgupta updated subscribers of D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

Hi @HsiangKai, I want to know how you have written 12877+ lines of test cases such as in https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/rvv/vluxseg-rv32.ll . I need to update them in this patch to pass check-llvm. It is some script? can you please tell me how to use that.

Oct 26 2021, 5:43 AM · Restricted Project
xgupta updated the diff for D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.

.

Oct 26 2021, 5:24 AM · Restricted Project
xgupta abandoned D111519: [WIP] [RISCV] Emit cfi directives for function epilogue.
Oct 26 2021, 3:06 AM · Restricted Project

Oct 25 2021

xgupta closed D68556: Document `LLVM_USE_SPLIT_DWARF` option.

rebase, address nits, and committed in https://reviews.llvm.org/rGb2544fb9c5b38339572d50048563e8b6e72bf0ad, Thanks.

Oct 25 2021, 6:23 AM · Restricted Project
xgupta committed rGb2544fb9c5b3: Document `LLVM_USE_SPLIT_DWARF` option (authored by beanz).
Document `LLVM_USE_SPLIT_DWARF` option
Oct 25 2021, 6:21 AM

Oct 24 2021

xgupta committed rGa27ae8aa20f4: [NFC] Update test/CodeGen/RISCV/select-constant-xor.ll to use RV --check-prefix (authored by xgupta).
[NFC] Update test/CodeGen/RISCV/select-constant-xor.ll to use RV --check-prefix
Oct 24 2021, 11:48 PM