Page MenuHomePhabricator
People MarkMurrayARM

MarkMurrayARM (Mark Murray)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2019, 8:18 AM (159 w, 5 d)

Recent Activity
View All

Thu, Apr 28

MarkMurrayARM added a comment to D124623: [libc++] Mark tests that use check_assertion.h as requiring unix headers.

This looks sensible for our (ARM's) situation.

Thu, Apr 28, 9:28 AM · Restricted Project, Restricted Project

Feb 22 2022

MarkMurrayARM accepted D120067: [flang][docs] Update the top "doc" page.

Thanks for the clarifications!

Feb 22 2022, 1:22 AM · Restricted Project, Restricted Project

Feb 21 2022

MarkMurrayARM added a comment to D120067: [flang][docs] Update the top "doc" page.

Thanks for the update!

Feb 21 2022, 3:37 AM · Restricted Project, Restricted Project

Feb 7 2022

MarkMurrayARM committed rG3d7662142d50: [ARM] Undeprecate complex IT blocks (authored by MarkMurrayARM).
[ARM] Undeprecate complex IT blocks
Feb 7 2022, 7:48 AM
MarkMurrayARM closed D118044: [ARM] Undeprecate complex IT blocks.
Feb 7 2022, 7:48 AM · Restricted Project, Restricted Project
MarkMurrayARM added inline comments to D118044: [ARM] Undeprecate complex IT blocks.
Feb 7 2022, 7:24 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Address review comments

Feb 7 2022, 5:12 AM · Restricted Project, Restricted Project

Feb 4 2022

MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Fix more tests.

Feb 4 2022, 9:11 AM · Restricted Project, Restricted Project

Feb 3 2022

MarkMurrayARM added inline comments to D118044: [ARM] Undeprecate complex IT blocks.
Feb 3 2022, 4:52 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Address reviewer comments.

Feb 3 2022, 4:40 AM · Restricted Project, Restricted Project

Jan 27 2022

MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Add release note entry.

Jan 27 2022, 7:39 AM · Restricted Project, Restricted Project
MarkMurrayARM added reviewers for D118044: [ARM] Undeprecate complex IT blocks: dmgreen, john.brawn.
Jan 27 2022, 7:21 AM · Restricted Project, Restricted Project

Jan 25 2022

MarkMurrayARM added a comment to D118044: [ARM] Undeprecate complex IT blocks.
In D118044#3266521, @DavidSpickett wrote:

Please define what "complex" is, in the commit message and (if it doesn't make the description a whole paragraph) the command line help.

Given that we're flipping a default for v8 thumb targets does this warrant a release note?

Jan 25 2022, 6:02 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Update commit message as per reviewer request.

Jan 25 2022, 6:00 AM · Restricted Project, Restricted Project

Jan 24 2022

MarkMurrayARM added inline comments to D118044: [ARM] Undeprecate complex IT blocks.
Jan 24 2022, 9:21 AM · Restricted Project, Restricted Project
MarkMurrayARM added a reviewer for D118044: [ARM] Undeprecate complex IT blocks: kristof.beyls.
Jan 24 2022, 7:28 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D118044: [ARM] Undeprecate complex IT blocks.

Tweek commit message.

Jan 24 2022, 7:28 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D118044: [ARM] Undeprecate complex IT blocks.
Jan 24 2022, 7:21 AM · Restricted Project, Restricted Project

Jan 20 2022

MarkMurrayARM accepted D117782: [AArch64] Removing redundant PAuth flag.

I see no problem with this.

Jan 20 2022, 6:35 AM · Restricted Project

Sep 15 2021

MarkMurrayARM added a comment to D109825: [AArch64]Enabling Cortex-A510 Support.
In D109825#3001622, @dmgreen wrote:

As I did the downstream work for this, I'm happy with it to go in in this form.

This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and it is probably best not to review patches you write yourself.

Sep 15 2021, 6:53 AM · Restricted Project, Restricted Project
MarkMurrayARM accepted D109825: [AArch64]Enabling Cortex-A510 Support.

As I did the downstream work for this, I'm happy with it to go in in this form.

Sep 15 2021, 6:47 AM · Restricted Project, Restricted Project

Apr 30 2021

MarkMurrayARM added inline comments to D101606: [ARM][MVE] vcreateq lane ordering for big endian.
Apr 30 2021, 2:04 AM · Restricted Project
MarkMurrayARM added a comment to D101606: [ARM][MVE] vcreateq lane ordering for big endian.

Not sure yet.

Apr 30 2021, 1:50 AM · Restricted Project

Jan 25 2021

MarkMurrayARM closed D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Jan 25 2021, 3:41 AM · Restricted Project, Restricted Project

Jan 20 2021

MarkMurrayARM committed rGf344c028dea3: [AArch64] Add missing "pauth" feature to the .arch_extension directive. (authored by MarkMurrayARM).
[AArch64] Add missing "pauth" feature to the .arch_extension directive.
Jan 20 2021, 3:58 AM
MarkMurrayARM committed rGcab20f610577: [AArch64] Add missing "flagm" feature to the .arch_extension directive. (authored by MarkMurrayARM).
[AArch64] Add missing "flagm" feature to the .arch_extension directive.
Jan 20 2021, 3:58 AM
MarkMurrayARM closed D94971: [AArch64] Add missing "flagm" feature to the .arch_extension directive. Depends on D94970.
Jan 20 2021, 3:58 AM · Restricted Project
MarkMurrayARM closed D94970: [AArch64] Add missing "pauth" feature to the .arch_extension directive..
Jan 20 2021, 3:58 AM · Restricted Project

Jan 19 2021

MarkMurrayARM added a comment to D94970: [AArch64] Add missing "pauth" feature to the .arch_extension directive..

The negative extension case is funny as the instruction generates hints in a way that the test doesn't like. Its not the same pattern.

Jan 19 2021, 7:50 AM · Restricted Project
MarkMurrayARM requested review of D94971: [AArch64] Add missing "flagm" feature to the .arch_extension directive. Depends on D94970.
Jan 19 2021, 6:54 AM · Restricted Project
MarkMurrayARM requested review of D94970: [AArch64] Add missing "pauth" feature to the .arch_extension directive..
Jan 19 2021, 6:53 AM · Restricted Project
MarkMurrayARM accepted D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.
Jan 19 2021, 3:14 AM · Restricted Project

Jan 11 2021

MarkMurrayARM accepted D94414: [ARM] Update existing test case with extra pauth supported targets.
Jan 11 2021, 7:12 AM · Restricted Project

Jan 8 2021

MarkMurrayARM committed rGaf7cce2fa4d1: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer… (authored by MarkMurrayARM).
[AArch64] Add +pauth archictecture option, allowing the v8.3a pointer…
Jan 8 2021, 5:22 AM
MarkMurrayARM committed rG7d4a8bc417bf: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification… (authored by MarkMurrayARM).
[AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification…
Jan 8 2021, 5:22 AM
MarkMurrayARM closed D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension..
Jan 8 2021, 5:22 AM · Restricted Project, Restricted Project
MarkMurrayARM closed D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension..
Jan 8 2021, 5:22 AM · Restricted Project, Restricted Project

Jan 5 2021

MarkMurrayARM updated the diff for D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension..

Fixed the parent commit.

Jan 5 2021, 5:39 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension..
Jan 5 2021, 5:39 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension..
Jan 5 2021, 5:18 AM · Restricted Project, Restricted Project
MarkMurrayARM accepted D93899: [AArch64] Add BRB IALL and BRB INJ instructions.

LGTM

Jan 5 2021, 5:14 AM · Restricted Project
MarkMurrayARM requested changes to D93899: [AArch64] Add BRB IALL and BRB INJ instructions.
Jan 5 2021, 3:46 AM · Restricted Project

Dec 29 2020

MarkMurrayARM committed rG5abfeccf10bc: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM (authored by MarkMurrayARM).
[ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM
Dec 29 2020, 2:25 AM

Dec 24 2020

MarkMurrayARM updated the diff for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

More review comments.

Dec 24 2020, 8:34 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

Address review comments.

Dec 24 2020, 7:04 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

Incorporate reviewer comments. Rebase.

Dec 24 2020, 2:19 AM · Restricted Project, Restricted Project

Dec 22 2020

MarkMurrayARM added a comment to D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.

I remain content.

Dec 22 2020, 1:14 AM · Restricted Project

Dec 17 2020

MarkMurrayARM accepted D93448: [llvm][Arm/AArch64] Format extension flags in CPU test failures.

Even better! Very good.

Dec 17 2020, 4:42 AM · Restricted Project

Dec 16 2020

MarkMurrayARM accepted D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures.

The proposed output contains the exact information I needed with my naive attempt. Also, it does not introduce the technical debt that my hack would have.

Dec 16 2020, 6:09 AM · Restricted Project

Dec 15 2020

MarkMurrayARM added a reviewer for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM: DavidSpickett.
Dec 15 2020, 4:54 AM · Restricted Project, Restricted Project
MarkMurrayARM added a reviewer for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM: miyuki.
Dec 15 2020, 4:54 AM · Restricted Project, Restricted Project
MarkMurrayARM added a reviewer for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM: ktkachov.
Dec 15 2020, 4:52 AM · Restricted Project, Restricted Project
MarkMurrayARM added a comment to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

Marked addressed comments as "done". Some debug code has been abandoned.

Dec 15 2020, 3:54 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.

Address review comments.

Dec 15 2020, 3:51 AM · Restricted Project, Restricted Project
MarkMurrayARM abandoned D93285: [ARM][AArch64] Test case debugging output.
Dec 15 2020, 3:49 AM · Restricted Project
MarkMurrayARM added a comment to D93285: [ARM][AArch64] Test case debugging output.

@DavidSpickett, I would very much appreciate you taking this over, thanks! I needed a way of find out *how* these tests were failing, not just *that* they were failing. I will abandon this change.

Dec 15 2020, 3:49 AM · Restricted Project
MarkMurrayARM updated the summary of D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 15 2020, 1:31 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the summary of D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 15 2020, 1:30 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D93285: [ARM][AArch64] Test case debugging output.
Dec 15 2020, 1:10 AM · Restricted Project

Dec 10 2020

MarkMurrayARM added inline comments to D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 10 2020, 5:37 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM.
Dec 10 2020, 4:02 AM · Restricted Project, Restricted Project

Nov 30 2020

MarkMurrayARM accepted D91994: [AArch64] Cortex-R82: remove crypto.

Looks OK to me, given releated upstreaming work I've done recently.

Nov 30 2020, 1:09 AM · Restricted Project, Restricted Project

Nov 25 2020

MarkMurrayARM committed rG2b6691894ab6: [ARM][AArch64] Adding Neoverse N2 CPU support (authored by MarkMurrayARM).
[ARM][AArch64] Adding Neoverse N2 CPU support
Nov 25 2020, 3:45 AM
MarkMurrayARM closed D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.
Nov 25 2020, 3:45 AM · Restricted Project, Restricted Project

Nov 23 2020

MarkMurrayARM updated the diff for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.

Rebase.

Nov 23 2020, 7:57 AM · Restricted Project, Restricted Project

Nov 19 2020

MarkMurrayARM updated the diff for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.

Address reviewer comment.

Nov 19 2020, 7:15 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.

Address more review comments.

Nov 19 2020, 4:57 AM · Restricted Project, Restricted Project

Nov 18 2020

MarkMurrayARM added a comment to D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.
In D91695#2402616, @tschuett wrote:

The features still differ from gcc.
https://github.com/gcc-mirror/gcc/blob/cb1a4876a0e724ca3962ec14dce9e7819fa72ea5/gcc/config/aarch64/aarch64-cores.def#L146
It has SVE2_Bitperm.

Nov 18 2020, 6:22 AM · Restricted Project, Restricted Project
MarkMurrayARM added a comment to D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.
In D91695#2402495, @tschuett wrote:

In the first version N2 had FeatureTME. Did you remove that on purpose?

Nov 18 2020, 6:16 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.

Address review comment.

Nov 18 2020, 5:14 AM · Restricted Project, Restricted Project
MarkMurrayARM updated the diff for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.

Address reviewer comments.

Nov 18 2020, 5:08 AM · Restricted Project, Restricted Project
MarkMurrayARM added reviewers for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support: simon_tatham, ostannard, keith.walker.arm.
Nov 18 2020, 3:00 AM · Restricted Project, Restricted Project
MarkMurrayARM added reviewers for D91695: [ARM][AArch64] Adding Neoverse N2 CPU support: pratlucas, miyuki, vhscampos.
Nov 18 2020, 2:58 AM · Restricted Project, Restricted Project
MarkMurrayARM requested review of D91695: [ARM][AArch64] Adding Neoverse N2 CPU support.
Nov 18 2020, 2:54 AM · Restricted Project, Restricted Project

Jun 23 2020

MarkMurrayARM accepted D81740: [ARM] BFloat MatMul Intrinsics&CodeGen.

LGTM.

Jun 23 2020, 4:13 AM · Restricted Project, Restricted Project

May 12 2020

MarkMurrayARM accepted D79782: Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant.

LGTM

May 12 2020, 9:06 AM · Restricted Project

Apr 22 2020

MarkMurrayARM committed rG3df8135286a2: [ARM][MC][Thumb] Recommit: Revert relocation for some pc-relative fixups. (authored by MarkMurrayARM).
[ARM][MC][Thumb] Recommit: Revert relocation for some pc-relative fixups.
Apr 22 2020, 9:13 AM

Apr 20 2020

MarkMurrayARM committed rGf5a812cbcc7b: Revert 3ce0ad1b336e67a76d78ae7ff7d66fe127586620 Die to breakage in check-lld. (authored by MarkMurrayARM).
Revert 3ce0ad1b336e67a76d78ae7ff7d66fe127586620 Die to breakage in check-lld.
Apr 20 2020, 5:21 AM
MarkMurrayARM added a reverting change for rG3ce0ad1b336e: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups.: rGf5a812cbcc7b: Revert 3ce0ad1b336e67a76d78ae7ff7d66fe127586620 Die to breakage in check-lld..
Apr 20 2020, 5:21 AM
MarkMurrayARM committed rG3ce0ad1b336e: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups. (authored by MarkMurrayARM).
[ARM][MC][Thumb] Revert relocation for some pc-relative fixups.
Apr 20 2020, 2:07 AM
MarkMurrayARM closed D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups..
Apr 20 2020, 2:07 AM · Restricted Project
MarkMurrayARM updated the diff for D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups..

Address review nits.

Apr 20 2020, 2:06 AM · Restricted Project

Apr 17 2020

MarkMurrayARM retitled D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups. from [ARM][MD] Revert relocation for some pc-relative fixups. to [ARM][MC][Thumb] Revert relocation for some pc-relative fixups..
Apr 17 2020, 2:07 AM · Restricted Project
MarkMurrayARM updated the diff for D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups..

Improve commit message slightly.

Apr 17 2020, 1:35 AM · Restricted Project

Apr 16 2020

MarkMurrayARM added reviewers for D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups.: MaskRay, eli.friedman.
Apr 16 2020, 8:21 AM · Restricted Project
MarkMurrayARM created D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups..
Apr 16 2020, 7:48 AM · Restricted Project

Mar 20 2020

MarkMurrayARM accepted D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..

LGTM

Mar 20 2020, 7:00 AM · Restricted Project
MarkMurrayARM accepted D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics.

LGTM

Mar 20 2020, 6:28 AM · Restricted Project
MarkMurrayARM accepted D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics.

I like to use of the macros instead of a huge cross-product of types.

Mar 20 2020, 6:27 AM · Restricted Project
MarkMurrayARM accepted D76298: [ARM,CDE] Implement CDE S and D-register intrinsics.

LGTM

Mar 20 2020, 6:27 AM · Restricted Project
MarkMurrayARM accepted D76296: [ARM,CDE] Implement GPR CDE intrinsics.

LGTM

Mar 20 2020, 5:55 AM · Restricted Project

Feb 26 2020

MarkMurrayARM accepted D75165: [ARM,MVE] Add predicated intrinsics for many unary functions..

LGTM

Feb 26 2020, 6:04 AM · Restricted Project, Restricted Project

Feb 19 2020

MarkMurrayARM accepted D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families.

LGTM!

Feb 19 2020, 9:31 AM · Restricted Project, Restricted Project
MarkMurrayARM added a comment to D74838: [ARM,MVE] Fix predicate types of some intrinsics.

Nice catch!

Feb 19 2020, 8:07 AM · Restricted Project, Restricted Project
MarkMurrayARM accepted D74838: [ARM,MVE] Fix predicate types of some intrinsics.
Feb 19 2020, 8:07 AM · Restricted Project, Restricted Project

Feb 11 2020

MarkMurrayARM accepted D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations..

LGTM

Feb 11 2020, 5:25 AM · Restricted Project
MarkMurrayARM accepted D74332: [ARM,MVE] Add intrinsics for int <-> float conversion..

LGTM.

Feb 11 2020, 3:25 AM · Restricted Project

Feb 6 2020

MarkMurrayARM accepted D74134: [ARM][MVE] Add fixed point vector conversion intrinsics.

This looks familiar and reassuring.

Feb 6 2020, 8:50 AM · Restricted Project, Restricted Project

Jan 23 2020

MarkMurrayARM accepted D73268: [ARM,MVE] Make the MVE intrinsics work in C++!.

LGTM

Jan 23 2020, 6:03 AM · Restricted Project

Jan 20 2020

MarkMurrayARM committed rGb10a0eb04adf: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first… (authored by MarkMurrayARM).
[ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first…
Jan 20 2020, 6:45 AM