User Details
- User Since
- May 1 2019, 8:18 AM (102 w, 4 d)
Jan 25 2021
Jan 20 2021
Jan 19 2021
The negative extension case is funny as the instruction generates hints in a way that the test doesn't like. Its not the same pattern.
Jan 11 2021
Jan 8 2021
Jan 5 2021
Fixed the parent commit.
LGTM
Dec 29 2020
Dec 24 2020
More review comments.
Address review comments.
Incorporate reviewer comments. Rebase.
Dec 22 2020
I remain content.
Dec 17 2020
Even better! Very good.
Dec 16 2020
The proposed output contains the exact information I needed with my naive attempt. Also, it does not introduce the technical debt that my hack would have.
Dec 15 2020
Marked addressed comments as "done". Some debug code has been abandoned.
Address review comments.
@DavidSpickett, I would very much appreciate you taking this over, thanks! I needed a way of find out *how* these tests were failing, not just *that* they were failing. I will abandon this change.
Dec 10 2020
Nov 30 2020
Looks OK to me, given releated upstreaming work I've done recently.
Nov 25 2020
Nov 23 2020
Rebase.
Nov 19 2020
Address reviewer comment.
Address more review comments.
Nov 18 2020
Address review comment.
Address reviewer comments.
Jun 23 2020
LGTM.
May 12 2020
LGTM
Apr 22 2020
Apr 20 2020
Address review nits.
Apr 17 2020
Improve commit message slightly.
Apr 16 2020
Mar 20 2020
LGTM
LGTM
I like to use of the macros instead of a huge cross-product of types.
LGTM
LGTM
Feb 26 2020
LGTM
Feb 19 2020
LGTM!
Nice catch!
Feb 11 2020
LGTM
LGTM.
Feb 6 2020
This looks familiar and reassuring.
Jan 23 2020
LGTM
Jan 20 2020
Rebase.
Jan 16 2020
Jan 15 2020
Much better impementation after review feedback.
Jan 14 2020
Dec 13 2019
Tiny observation of types - fix only if you feel like it.
LGTM
Shorten title/subject line.
Dec 12 2019
Reformat commit message.
Dec 11 2019
*LIKE*