This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AsmPrinter] Make comments for spill/reload more precise.
ClosedPublic

Authored by HsiangKai on Jan 8 2021, 5:24 AM.

Details

Summary

The size of spill/reload may be unknown for scalable vector types. When the size is unknown, print it as "Unknown size" instead of a very large number.

Diff Detail

Event Timeline

HsiangKai created this revision.Jan 8 2021, 5:24 AM
HsiangKai requested review of this revision.Jan 8 2021, 5:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 5:24 AM
evandro accepted this revision.Jan 8 2021, 7:58 AM

If you happen to have a test case, please, consider adding it.

This revision is now accepted and ready to land.Jan 8 2021, 7:58 AM

LGTM. The only thing I'd say is that "Unknown size" isn't an adjective like "4-byte" is. I'm not sure if "Unknown-sized" is any better, though.