This is an archive of the discontinued LLVM Phabricator instance.

[CallSite removal][TargetLowering] Replace ImmutableCallSite with CallBase
ClosedPublic

Authored by craig.topper on Apr 12 2020, 9:29 PM.

Diff Detail

Event Timeline

craig.topper created this revision.Apr 12 2020, 9:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2020, 9:29 PM

Use auto in place of ImmutableCallSite::arg_iterator

mtrofin added inline comments.Apr 13 2020, 9:26 AM
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
7082

Should we also get 'i' and 'e' to be style-compliant?

llvm/lib/Target/NVPTX/NVPTXISelLowering.h
494

(Here and elsewhere) can CB ever be nullptr? if not, should it be const CallBase &CB (to capture the contract)

Use CallBase& in one of the NVPTX function.
Capitalize i/e used as iterators.

craig.topper marked an inline comment as done.Apr 13 2020, 11:04 AM
craig.topper added inline comments.
llvm/lib/Target/PowerPC/PPCISelLowering.h
1173

These methods should maybe be refactored to use the CallLoweringInfo coming into LowerCall instead of passing a bunch of fields from it separately. I might look at that as a follow up.

Update one PowerPC function to take a reference. I didn't touch any that should probably take CallLoweringInfo. Since if we made that change they would also use the field which is a pointer.

This revision is now accepted and ready to land.Apr 13 2020, 11:20 AM
This revision was automatically updated to reflect the committed changes.