Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (466 w, 6 d)
Roles
Administrator

d0k

Recent Activity

Today

bkramer committed rG596989da6595: [mlir][Linalg] Silence warnings in Release builds. NFC. (authored by bkramer).
[mlir][Linalg] Silence warnings in Release builds. NFC.
Mon, Jun 21, 3:58 AM

Thu, Jun 17

bkramer committed rGc878d03d60fc: [mlir] Split things dependent on LLVM_DEBUG into a .cpp file (authored by bkramer).
[mlir] Split things dependent on LLVM_DEBUG into a .cpp file
Thu, Jun 17, 6:08 AM

Tue, Jun 15

bkramer requested review of D104298: [MemRef] Restrict dim(reshape) transform to constant indices.
Tue, Jun 15, 7:39 AM · Restricted Project
bkramer committed rGcd9393514676: [mlir][MemRef] Make sure types match when folding dim(reshape) (authored by bkramer).
[mlir][MemRef] Make sure types match when folding dim(reshape)
Tue, Jun 15, 3:50 AM
bkramer closed D104287: [mlir][MemRef] Make sure types match when folding dim(reshape).
Tue, Jun 15, 3:50 AM · Restricted Project
bkramer requested review of D104287: [mlir][MemRef] Make sure types match when folding dim(reshape).
Tue, Jun 15, 3:33 AM · Restricted Project

Thu, Jun 10

bkramer committed rG3dceffd0fdbc: [AArch64] Silence fallthrough warning. NFC. (authored by bkramer).
[AArch64] Silence fallthrough warning. NFC.
Thu, Jun 10, 8:25 AM

Wed, Jun 9

bkramer committed rGc0db8d50ca3c: [mlir] Expose a function to populate tensor constant bufferization patterns (authored by bkramer).
[mlir] Expose a function to populate tensor constant bufferization patterns
Wed, Jun 9, 4:52 AM
bkramer closed D103838: [mlir] Expose a function to populate tensor constant bufferization patterns.
Wed, Jun 9, 4:52 AM · Restricted Project

Mon, Jun 7

bkramer requested review of D103838: [mlir] Expose a function to populate tensor constant bufferization patterns.
Mon, Jun 7, 12:59 PM · Restricted Project

Thu, May 27

bkramer committed rG1546c52d9712: Add triples to a bunch of x86-specific tests that currently fail on PPC (authored by bkramer).
Add triples to a bunch of x86-specific tests that currently fail on PPC
Thu, May 27, 3:32 AM

Tue, May 25

bkramer committed rGd2d4f1680665: [Matrix] Use LLVM_DEBUG for a debug flag (authored by bkramer).
[Matrix] Use LLVM_DEBUG for a debug flag
Tue, May 25, 12:11 PM
bkramer committed rG6359842bc088: [GlobalISel] Silence unused variable warning in Release builds. NFC. (authored by bkramer).
[GlobalISel] Silence unused variable warning in Release builds. NFC.
Tue, May 25, 1:55 AM

May 21 2021

bkramer committed rGea438b489828: [X86] Inline variable to avoid unused warning in Release builds. NFCI. (authored by bkramer).
[X86] Inline variable to avoid unused warning in Release builds. NFCI.
May 21 2021, 9:29 AM
bkramer accepted D102785: [mlir][memref] Fix canonicalization of memref.clone.

lgtm

May 21 2021, 7:17 AM · Restricted Project
bkramer accepted D102682: [mlir][linalg] Add scalar operands inlining pattern.

looks good, thanks

May 21 2021, 6:08 AM · Restricted Project

May 20 2021

bkramer accepted D102878: [mlir][Affine] NFC - Drop Affine EDSC usage.

looks good

May 20 2021, 2:45 PM · Restricted Project
bkramer accepted D102868: [mlir][MemRef] NFC - Drop MemRef EDSC usage.

looks good

May 20 2021, 1:12 PM · Restricted Project

May 18 2021

bkramer committed rG3f3642a7631e: [CodeGen] Avoid unused variable warning in Release builds. NFCI. (authored by bkramer).
[CodeGen] Avoid unused variable warning in Release builds. NFCI.
May 18 2021, 2:10 AM

May 17 2021

bkramer committed rG05de4b413930: Put back the trailing commas on TYPED_TEST_SUITE (authored by bkramer).
Put back the trailing commas on TYPED_TEST_SUITE
May 17 2021, 5:14 AM
bkramer committed rG34fa3f87335f: Clean up uses of gmock Invoke in an attempt to make it work with GCC 6.2. NFCI. (authored by bkramer).
Clean up uses of gmock Invoke in an attempt to make it work with GCC 6.2. NFCI.
May 17 2021, 4:49 AM

May 14 2021

bkramer committed rGa558ebbd6f92: Reinstate gtest fix from 4f0b0bf5c6731e3d370558be08c9261801263b09 (authored by bkramer).
Reinstate gtest fix from 4f0b0bf5c6731e3d370558be08c9261801263b09
May 14 2021, 3:36 PM
bkramer added a comment to rGd4d80a2903c1: Bump googletest to 1.10.0.

I landed a couple of fixes for the deprecation warnings. Is there more?

May 14 2021, 3:31 PM
bkramer committed rGcb846654c63b: [compiler-rt] Fix deprection warnings on INSTANTIATE_TEST_CASE_P (authored by bkramer).
[compiler-rt] Fix deprection warnings on INSTANTIATE_TEST_CASE_P
May 14 2021, 3:25 PM
bkramer committed rG4901199f5b84: GTEST_HAS_TR1_TUPLE is gone, stop defining it. (authored by bkramer).
GTEST_HAS_TR1_TUPLE is gone, stop defining it.
May 14 2021, 12:16 PM
bkramer committed rG9c88fb4e270e: [ProfData] Address a unit test FIXME (authored by bkramer).
[ProfData] Address a unit test FIXME
May 14 2021, 12:16 PM
bkramer committed rG17ef1017f0dc: [flang] s/TYPED_TEST_CASE/TYPED_TEST_SUITE/ as the former is deprecated (authored by bkramer).
[flang] s/TYPED_TEST_CASE/TYPED_TEST_SUITE/ as the former is deprecated
May 14 2021, 11:41 AM
bkramer committed rG09499efb7a58: Add another -Wdeprecated-copy hack for gtest (authored by bkramer).
Add another -Wdeprecated-copy hack for gtest
May 14 2021, 11:38 AM
bkramer committed rGfde5b24963f4: [clangd] Make unit test compatible with gtest 1.10.0 (authored by bkramer).
[clangd] Make unit test compatible with gtest 1.10.0
May 14 2021, 10:38 AM
bkramer committed rG1dbfeb463b29: Document updated googletest + modifications (authored by bkramer).
Document updated googletest + modifications
May 14 2021, 10:26 AM
bkramer committed rGd4d80a2903c1: Bump googletest to 1.10.0 (authored by bkramer).
Bump googletest to 1.10.0
May 14 2021, 10:17 AM
bkramer added a comment to D102390: Fix Google Test compilation failure when standard library implements LWG 2221.

Updated googletest to 1.8.1 in 4dd546131ad2749fbde3e048583cf29d615b9851, which includes this change.

May 14 2021, 8:33 AM · Restricted Project
bkramer committed rG4dd546131ad2: Bump googletest to 1.8.1 (authored by bkramer).
Bump googletest to 1.8.1
May 14 2021, 8:20 AM

May 12 2021

bkramer committed rG1470b8587f6f: Remove AST inclusion from Basic include (authored by bkramer).
Remove AST inclusion from Basic include
May 12 2021, 10:56 AM

May 11 2021

bkramer committed rGb20e150c9be1: [mlir] Use static shape knowledge when lowering memref.reshape (authored by bkramer).
[mlir] Use static shape knowledge when lowering memref.reshape
May 11 2021, 9:21 AM
bkramer closed D102232: [mlir] Use static shape knowledge when lowering memref.reshape.
May 11 2021, 9:21 AM · Restricted Project
bkramer requested review of D102232: [mlir] Use static shape knowledge when lowering memref.reshape.
May 11 2021, 5:17 AM · Restricted Project

May 10 2021

bkramer committed rG7b52aeadfa38: [mlir][Tensor] Add folding for tensor.from_elements (authored by bkramer).
[mlir][Tensor] Add folding for tensor.from_elements
May 10 2021, 3:43 PM
bkramer closed D102199: [mlir][Tensor] Add folding for tensor.from_elements.
May 10 2021, 3:43 PM · Restricted Project
bkramer requested review of D102199: [mlir][Tensor] Add folding for tensor.from_elements.
May 10 2021, 2:23 PM · Restricted Project

May 7 2021

bkramer accepted D102089: [mlir] Add a pattern to bufferize linalg.tensor_reshape..

looks good

May 7 2021, 12:24 PM · Restricted Project
bkramer accepted D102088: [mlir] Add a pattern to bufferize std.index_cast..

looks good

May 7 2021, 12:24 PM · Restricted Project
bkramer committed rG6248d1119040: Retire TargetRegisterInfo::getSpillAlignment (authored by bkramer).
Retire TargetRegisterInfo::getSpillAlignment
May 7 2021, 6:17 AM
bkramer added a comment to D100026: [X86] Support AMX fast register allocation.

That's better, thanks!

May 7 2021, 4:57 AM · Restricted Project

May 6 2021

bkramer committed rG3d746962ed18: [ORC] Silence unused variable warnings in Release builds. NFC. (authored by bkramer).
[ORC] Silence unused variable warnings in Release builds. NFC.
May 6 2021, 4:38 AM

May 5 2021

bkramer accepted D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..

Looks good (if Nicolas signed off on this before he went on vacation)

May 5 2021, 2:11 AM · Restricted Project

May 3 2021

bkramer committed rG96a7900eb065: [mlir] Fix multidimensional lowering from std.select to llvm.select (authored by bkramer).
[mlir] Fix multidimensional lowering from std.select to llvm.select
May 3 2021, 10:31 AM
bkramer closed D101767: [mlir] Fix multidimensional lowering from std.select to llvm.select.
May 3 2021, 10:31 AM · Restricted Project
bkramer requested review of D101767: [mlir] Fix multidimensional lowering from std.select to llvm.select.
May 3 2021, 10:26 AM · Restricted Project
bkramer committed rGcdeb4a8a6430: [mlir] Allow lowering cmpi/cmpf with multidimensional vectors to LLVM (authored by bkramer).
[mlir] Allow lowering cmpi/cmpf with multidimensional vectors to LLVM
May 3 2021, 2:31 AM
bkramer closed D101535: [mlir] Allow lowering cmpi/cmpf with multidimensional vectors to LLVM.
May 3 2021, 2:30 AM · Restricted Project

Apr 29 2021

bkramer committed rGb389c80963fb: [mlir] Fix lowering of multi-dimensional vector log1p to LLVM (authored by bkramer).
[mlir] Fix lowering of multi-dimensional vector log1p to LLVM
Apr 29 2021, 12:54 PM
bkramer closed D101531: [mlir] Fix lowering of multi-dimensional vector log1p to LLVM.
Apr 29 2021, 12:54 PM · Restricted Project
bkramer added a reverting change for rG3b8ec86fd576: [X86] Support AMX fast register allocation: rGdf323ba445f7: Revert "[X86] Support AMX fast register allocation".
Apr 29 2021, 9:57 AM
bkramer added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 29 2021, 9:57 AM · Restricted Project
bkramer added a reverting change for rGc3f95e919764: [X86] Refine AMX fast register allocation: rGdf323ba445f7: Revert "[X86] Support AMX fast register allocation".
Apr 29 2021, 9:57 AM
bkramer committed rGdf323ba445f7: Revert "[X86] Support AMX fast register allocation" (authored by bkramer).
Revert "[X86] Support AMX fast register allocation"
Apr 29 2021, 9:57 AM
bkramer added a reverting change for D100026: [X86] Support AMX fast register allocation: rGdf323ba445f7: Revert "[X86] Support AMX fast register allocation".
Apr 29 2021, 9:57 AM · Restricted Project
bkramer requested review of D101535: [mlir] Allow lowering cmpi/cmpf with multidimensional vectors to LLVM.
Apr 29 2021, 6:54 AM · Restricted Project
bkramer requested review of D101531: [mlir] Fix lowering of multi-dimensional vector log1p to LLVM.
Apr 29 2021, 6:27 AM · Restricted Project

Apr 28 2021

bkramer committed rG7e5682ee6201: [ADT] Make TrackingStatistic's ctor constexpr (authored by bkramer).
[ADT] Make TrackingStatistic's ctor constexpr
Apr 28 2021, 3:02 AM

Apr 23 2021

bkramer added a comment to D100495: [SLP] Add detection of shuffled/perfect matching of tree entries..

Seeing a miscompile after this has landed. Trying to reduce a test case, but no luck so far.

Apr 23 2021, 2:55 AM · Restricted Project

Apr 22 2021

bkramer committed rGedc869cb57fb: [lldb-vscode] Use a DenseMap to pacify overly aggressive linters (authored by bkramer).
[lldb-vscode] Use a DenseMap to pacify overly aggressive linters
Apr 22 2021, 4:09 AM

Apr 16 2021

bkramer committed rG7946cc404f43: [tblgen] Fold loop into assert to avoid unused variable warnings. NFCI. (authored by bkramer).
[tblgen] Fold loop into assert to avoid unused variable warnings. NFCI.
Apr 16 2021, 11:50 AM
bkramer accepted D100636: [MLIR][Shape] Expose `getShapeVec` and add support for extent tensors.

thanks

Apr 16 2021, 4:06 AM · Restricted Project

Apr 14 2021

bkramer added a comment to D100264: [SCEV] Don't walk uses of phis without SCEV expression when forgetting.

Can this have an effect on codegen? I'm seeing a loop being turned into an infinite loop with this change, trying to extract a test case but it's buried inside of an enormous JIT'ed program.

Apr 14 2021, 2:47 PM · Restricted Project
bkramer committed rGcf4161673c7e: [Instcombine] Disable memcpy of alloca bypass for instruction sources (authored by bkramer).
[Instcombine] Disable memcpy of alloca bypass for instruction sources
Apr 14 2021, 7:52 AM

Apr 9 2021

bkramer accepted D100198: [MLIR][Shape] Combine `cstr_eq` only if they share shape operands.

Thanks

Apr 9 2021, 7:53 AM · Restricted Project
bkramer added a comment to rG8bc08c55179f: [lldb] Update UUID after https://reviews.llvm.org/D99978..

Turns out this test behaves differently depending on the LLVM_ENABLE_NEW_PASS_MANAGER setting

Apr 9 2021, 2:50 AM
bkramer committed rG735eac7c0bff: [FunctionAttrs] Force old pm in test so it doens't behave differently depending… (authored by bkramer).
[FunctionAttrs] Force old pm in test so it doens't behave differently depending…
Apr 9 2021, 2:48 AM

Apr 8 2021

bkramer added a comment to D98967: [Analysis]Add getPointersDiff function to improve compile time..

Looks like this can trigger an infinite loop: https://bugs.llvm.org/show_bug.cgi?id=49898

Apr 8 2021, 10:11 AM · Restricted Project
bkramer accepted D100105: [MLIR][Shape] Add convenience builder for `shape.assuming_all`.
Apr 8 2021, 10:10 AM · Restricted Project
bkramer accepted D100104: [MLIR][Shape] Canonicalize `assuming_all` when all operands are `cstr_bcastable`.

We can do the same for cstr_eq.

Apr 8 2021, 10:09 AM · Restricted Project

Apr 7 2021

bkramer added a comment to rG5207cde5cb41: [InstCombine] Conditionally fold select i1 into and/or.

This made instcombine hang in some cases, see https://bugs.llvm.org/show_bug.cgi?id=49878

Apr 7 2021, 3:33 AM

Apr 6 2021

bkramer committed rGce4acb01b315: Avoid unused variable warning in Release builds (authored by bkramer).
Avoid unused variable warning in Release builds
Apr 6 2021, 7:26 AM
bkramer accepted D99937: [rt] Update DIPrinter usage in 'sanitizer_symbolize.cpp`..

Thanks

Apr 6 2021, 3:29 AM · Restricted Project

Mar 23 2021

bkramer committed rG39e36fff3d09: [AArch64] Fix unused variable warning (authored by bkramer).
[AArch64] Fix unused variable warning
Mar 23 2021, 5:43 AM
bkramer accepted D99156: [MLIR] Canonicalize `shape.assuming` op to yield only inner values.

Looks good now. I can't comment on whether there should be a more general pass to do this kind of transform (IfOp has the same issue), though.

Mar 23 2021, 4:09 AM · Restricted Project
bkramer accepted D99153: [MLIR] Add callback builder for `shape.assuming` op.

looks good

Mar 23 2021, 2:42 AM · Restricted Project
bkramer added a reviewer for D99161: [MLIR][Shape] Canonicalize casted dynamic extent tensor: herhut.
Mar 23 2021, 2:40 AM · Restricted Project
bkramer accepted D99159: [MLIR][Shape] Canonicalize duplicate operands in `shape.cstr_broadcastable`.

looks good

Mar 23 2021, 2:39 AM · Restricted Project
bkramer added inline comments to D99156: [MLIR] Canonicalize `shape.assuming` op to yield only inner values.
Mar 23 2021, 2:19 AM · Restricted Project
bkramer added a comment to D99059: [mlir] Add an option to still use bottom-up traversal.

The iteration order reversal exposed a bug in FusionOfTensorOpsPass, which basically made it unusable on any large input and required a non-trivial change to fix it. It's not great that this wasn't caught by any tests in the mlir repo, but that doesn't mean the problem doesn't exist. The alternative to get to green would've been to revert Chris' change, which would've created even more havoc as we have way too many overspecified lit tests with no automatic update mechanism.

Mar 23 2021, 1:55 AM · Restricted Project

Mar 19 2021

bkramer added a comment to D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable..

Invalid IR generation should be addressed by 19d2c65ddd757997785163709800f837857f686d

Mar 19 2021, 1:29 PM · Restricted Project
bkramer committed rG6327a7cfd734: [mlir][Linalg] Make LLVM_DEBUG region bigger to avoid warnings in Release builds (authored by bkramer).
[mlir][Linalg] Make LLVM_DEBUG region bigger to avoid warnings in Release builds
Mar 19 2021, 12:58 PM
bkramer committed rG19d2c65ddd75: [CodeGen] Don't crash on for loops with cond variables and no increment (authored by bkramer).
[CodeGen] Don't crash on for loops with cond variables and no increment
Mar 19 2021, 12:48 PM
bkramer closed D98980: [CodeGen] Don't crash on for loops with cond variables and no increment.
Mar 19 2021, 12:48 PM · Restricted Project
bkramer added a comment to D98980: [CodeGen] Don't crash on for loops with cond variables and no increment.

Landing this as it's a pretty bad crasher. Feel free to point out all my mistakes in post-commit review :)

Mar 19 2021, 12:47 PM · Restricted Project
bkramer requested review of D98980: [CodeGen] Don't crash on for loops with cond variables and no increment.
Mar 19 2021, 12:41 PM · Restricted Project

Mar 17 2021

bkramer accepted D98782: [MLIR] Canonicalize broadcast operations on single shapes.

Thanks

Mar 17 2021, 10:49 AM · Restricted Project

Mar 16 2021

bkramer accepted D98190: [NFC] Use SmallString instead of std::string for the AttrBuilder.

Sounds like a good enough improvement to me, thanks for checking.

Mar 16 2021, 4:29 AM · Restricted Project

Mar 10 2021

bkramer accepted D98361: [MLIR] Add canoncalization for `shape.is_broadcastable`.
Mar 10 2021, 10:47 AM · Restricted Project
bkramer added inline comments to D98361: [MLIR] Add canoncalization for `shape.is_broadcastable`.
Mar 10 2021, 10:47 AM · Restricted Project

Mar 9 2021

bkramer added a comment to D98190: [NFC] Use SmallString instead of std::string for the AttrBuilder.

Do we have some information on how long these attributes typically are? libc++'s std::string has an inline capacity of 22, which is why I've been reluctant to change this so far.

Mar 9 2021, 4:58 AM · Restricted Project

Mar 8 2021

bkramer committed rG0d96ea0792bc: [ValueTracking] Move matchSimpleRecurrence out of line (authored by bkramer).
[ValueTracking] Move matchSimpleRecurrence out of line
Mar 8 2021, 3:06 PM
bkramer abandoned D98188: [mlir][Shape] Allow materializing const shapes of any 1D index tensor.

Turned out the thing that motivated this change was a bug elsewhere. dropping.

Mar 8 2021, 12:00 PM · Restricted Project
bkramer requested review of D98188: [mlir][Shape] Allow materializing const shapes of any 1D index tensor.
Mar 8 2021, 8:34 AM · Restricted Project
bkramer committed rG42c195f0ec8f: [mlir][Shape] Allow shape.split_at to return extent tensors and lower it to std. (authored by bkramer).
[mlir][Shape] Allow shape.split_at to return extent tensors and lower it to std.
Mar 8 2021, 7:48 AM
bkramer closed D98177: [mlir][Shape] Allow shape.split_at to return extent tensors and lower it to std.subtensor.
Mar 8 2021, 7:48 AM · Restricted Project
bkramer requested review of D98177: [mlir][Shape] Allow shape.split_at to return extent tensors and lower it to std.subtensor.
Mar 8 2021, 6:26 AM · Restricted Project