Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (520 w, 1 d)
Roles
Administrator

d0k

Recent Activity

Yesterday

bkramer added inline comments to D127729: [Bitcode] Support expanding constant expressions into instructions.
Wed, Jun 29, 5:30 AM · Restricted Project, Restricted Project
bkramer added inline comments to D127729: [Bitcode] Support expanding constant expressions into instructions.
Wed, Jun 29, 4:51 AM · Restricted Project, Restricted Project
bkramer committed rG206a6037a093: [Presburger] Cheat around old versions of clang not doing NRVO when there's a… (authored by bkramer).
[Presburger] Cheat around old versions of clang not doing NRVO when there's a…
Wed, Jun 29, 3:41 AM · Restricted Project, Restricted Project

Mon, Jun 27

bkramer accepted D128345: [Alignment] Replace commonAlignment with std::min.

I think given the semantic difference removing just the one overload makes sense.

Mon, Jun 27, 9:22 AM · Restricted Project, Restricted Project

Sun, Jun 26

bkramer committed rGf5cd172e515f: [Support] Work around an issue when building with old versions of libstdc++ (authored by bkramer).
[Support] Work around an issue when building with old versions of libstdc++
Sun, Jun 26, 4:03 AM · Restricted Project, Restricted Project

Sat, Jun 25

bkramer accepted D128571: [X86] Support `_Float16` on SSE2 and up.

Thanks

Sat, Jun 25, 5:08 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

bkramer added a comment to D128345: [Alignment] Replace commonAlignment with std::min.

@aemerson @bkramer is std::min(Align, Align) clear enough?

Fri, Jun 24, 6:46 AM · Restricted Project, Restricted Project

Tue, Jun 21

bkramer committed rGb3127769b1ae: [mlir][sparse] Preserve NaNs when converting float to bfloat (authored by bkramer).
[mlir][sparse] Preserve NaNs when converting float to bfloat
Tue, Jun 21, 6:31 AM · Restricted Project, Restricted Project

Sat, Jun 18

bkramer committed rG745a4caaebb9: [mlir] Fix an msvc warning (authored by bkramer).
[mlir] Fix an msvc warning
Sat, Jun 18, 1:10 AM · Restricted Project, Restricted Project

Fri, Jun 17

bkramer committed rGd5c29b23e1d4: [mlir][sparse] Inline the definition of LLVM_ATTRIBUTE_WEAK (authored by bkramer).
[mlir][sparse] Inline the definition of LLVM_ATTRIBUTE_WEAK
Fri, Jun 17, 1:41 PM · Restricted Project, Restricted Project
bkramer committed rGfeb8313fbfe0: [bazel] Add missing dependency after 455679413 (authored by bkramer).
[bazel] Add missing dependency after 455679413
Fri, Jun 17, 1:10 PM · Restricted Project
bkramer committed rG3420cd7caf8d: [mlir][sparse] Add testing for bf16 and fallback for software bf16 (authored by bkramer).
[mlir][sparse] Add testing for bf16 and fallback for software bf16
Fri, Jun 17, 12:54 PM · Restricted Project, Restricted Project
bkramer closed D128091: [mlir][sparse] Add testing for bf16 and fallback for software bf16.
Fri, Jun 17, 12:54 PM · Restricted Project, Restricted Project
bkramer accepted D128086: [mlir][sparse] renable f16 tests.

looks good

Fri, Jun 17, 12:46 PM · Restricted Project, Restricted Project
bkramer requested review of D128091: [mlir][sparse] Add testing for bf16 and fallback for software bf16.
Fri, Jun 17, 12:43 PM · Restricted Project, Restricted Project
bkramer added a comment to rG04a3d5f3a119: Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Sorry, I had to revert this again. Hope it's the last time. Two more issues listed in 1a20252978c76cf2518aa45b175a9e5d6d36c4f0

Fri, Jun 17, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
bkramer added a reverting change for rG04a3d5f3a119: Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86…: rG1a20252978c7: Revert "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on….
Fri, Jun 17, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
bkramer committed rG1a20252978c7: Revert "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on… (authored by bkramer).
Revert "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on…
Fri, Jun 17, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
bkramer accepted D128018: [mlir][sparse] move from by-value to by-reference for data types.

looks good

Fri, Jun 17, 12:09 AM · Restricted Project, Restricted Project
bkramer abandoned D128015: [mlir][sparse] Add indirection to passing values to the runtime.
Fri, Jun 17, 12:07 AM · Restricted Project, Restricted Project

Thu, Jun 16

bkramer added a comment to D128015: [mlir][sparse] Add indirection to passing values to the runtime.

I have almost the same revision to push out (I did not know you were working on this too).....

Thu, Jun 16, 4:00 PM · Restricted Project, Restricted Project
bkramer requested review of D128015: [mlir][sparse] Add indirection to passing values to the runtime.
Thu, Jun 16, 3:34 PM · Restricted Project, Restricted Project

Wed, Jun 15

bkramer committed rG8c4a07c61f0a: [DAGCombiner] Fold fold (fp_to_bf16 (bf16_to_fp op)) -> op (authored by bkramer).
[DAGCombiner] Fold fold (fp_to_bf16 (bf16_to_fp op)) -> op
Wed, Jun 15, 10:55 AM · Restricted Project, Restricted Project
bkramer committed rGca50cb120ba5: [SelectionDAG] Constant fold FP_TO_BF16 and BF16_TO_FP. (authored by bkramer).
[SelectionDAG] Constant fold FP_TO_BF16 and BF16_TO_FP.
Wed, Jun 15, 9:53 AM · Restricted Project, Restricted Project
bkramer added a comment to D126444: [mlir]Implement SoftwareBF16 to handle the bf16 type.

To re-raise things, what's the right venue for discussing bf16 emulation in LLVM?

Wed, Jun 15, 9:25 AM · Restricted Project, Restricted Project
bkramer added a comment to rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

@bkramer Any reason on reverting this?

There's a test case in the message of the revert. The problem is a llvm.sqrt on <4xf16> not getting promoted anymore, crashing the compiler.

Thanks. I saw the test. I'll investigate it. What's the command to compile it?

Wed, Jun 15, 6:09 AM · Restricted Project, Restricted Project, Restricted Project
bkramer added a comment to rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

@bkramer Any reason on reverting this?

Wed, Jun 15, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
bkramer added a reverting change for rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI": rG37455b1f71d3: Revert "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the….
Wed, Jun 15, 4:25 AM · Restricted Project, Restricted Project, Restricted Project
bkramer committed rG37455b1f71d3: Revert "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the… (authored by tjoerg).
Revert "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the…
Wed, Jun 15, 4:25 AM · Restricted Project, Restricted Project, Restricted Project
bkramer added inline comments to D124024: [mlir][Arith] Pass to switch signed ops for equivalent unsigned ones.
Wed, Jun 15, 4:15 AM · Restricted Project, Restricted Project
bkramer committed rG8bc0bb956421: Add a conversion from double to bf16 (authored by bkramer).
Add a conversion from double to bf16
Wed, Jun 15, 4:01 AM · Restricted Project, Restricted Project, Restricted Project
bkramer committed rGfb34d531af95: Promote bf16 to f32 when the target doesn't support it (authored by bkramer).
Promote bf16 to f32 when the target doesn't support it
Wed, Jun 15, 4:01 AM · Restricted Project, Restricted Project, Restricted Project
bkramer closed D126953: Promote bf16 to f32 when the target doesn't support it.
Wed, Jun 15, 4:01 AM · Restricted Project, Restricted Project, Restricted Project
bkramer committed rG170ca11aeff2: [Sema] Remove unused function after 8c7b64b5ae2a (authored by bkramer).
[Sema] Remove unused function after 8c7b64b5ae2a
Wed, Jun 15, 3:22 AM · Restricted Project, Restricted Project
bkramer committed rG0886ea902b14: [mlir][Arith] Fix a use-after-free after rewriting ops to unsigned (authored by bkramer).
[mlir][Arith] Fix a use-after-free after rewriting ops to unsigned
Wed, Jun 15, 1:29 AM · Restricted Project, Restricted Project

Tue, Jun 14

bkramer committed rGd3b179684205: [mlir] Try to work around ambiguity in older clang versions (authored by bkramer).
[mlir] Try to work around ambiguity in older clang versions
Tue, Jun 14, 2:59 PM · Restricted Project, Restricted Project
bkramer committed rG55b76fb58e1f: [bazel] Port b0b00432093b (authored by bkramer).
[bazel] Port b0b00432093b
Tue, Jun 14, 2:56 PM · Restricted Project
bkramer committed rG8224fb7ef9aa: [bazel] Port 75bfc6f29579 (authored by bkramer).
[bazel] Port 75bfc6f29579
Tue, Jun 14, 2:46 PM · Restricted Project
bkramer committed rGba0222cdc651: [mlir][linalg] Add named ops for depthwise 3d convolution (authored by bkramer).
[mlir][linalg] Add named ops for depthwise 3d convolution
Tue, Jun 14, 9:29 AM · Restricted Project, Restricted Project
bkramer closed D127687: [mlir][linalg] Add named ops for depthwise 3d convolution.
Tue, Jun 14, 9:29 AM · Restricted Project, Restricted Project

Mon, Jun 13

bkramer committed rGb8cdff8894ea: [bazel] Unbreak the build after cf6a7c194793 (authored by bkramer).
[bazel] Unbreak the build after cf6a7c194793
Mon, Jun 13, 3:24 PM · Restricted Project
bkramer requested review of D127687: [mlir][linalg] Add named ops for depthwise 3d convolution.
Mon, Jun 13, 1:08 PM · Restricted Project, Restricted Project
bkramer committed rGde0aa687a290: [mlir][linalg] Add conv_2d_nhwc_fhwc to core_named_ops.py (authored by bkramer).
[mlir][linalg] Add conv_2d_nhwc_fhwc to core_named_ops.py
Mon, Jun 13, 11:43 AM · Restricted Project, Restricted Project
bkramer committed rG5724231af279: [InstCombine] Only fold trunc(ext) pairs to bitcast if the source and… (authored by bkramer).
[InstCombine] Only fold trunc(ext) pairs to bitcast if the source and…
Mon, Jun 13, 5:34 AM · Restricted Project, Restricted Project
bkramer added a comment to D126953: Promote bf16 to f32 when the target doesn't support it.

Post-wwdc ping.

Mon, Jun 13, 2:29 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

bkramer committed rG6ee5baeb9774: [libc][math] Add EXP_MANT_MASK when long double is double or quad (authored by bkramer).
[libc][math] Add EXP_MANT_MASK when long double is double or quad
Fri, Jun 10, 9:49 AM · Restricted Project, Restricted Project
bkramer committed rG914e30ca5c74: [bazel] Change references to driver-template.cpp.in after 6bc8163c79fd (authored by bkramer).
[bazel] Change references to driver-template.cpp.in after 6bc8163c79fd
Fri, Jun 10, 1:24 AM · Restricted Project

Thu, Jun 9

bkramer committed rG3ae85bd67a3c: [bazel] Add missing dependency after 9f1221521f4b. (authored by bkramer).
[bazel] Add missing dependency after 9f1221521f4b.
Thu, Jun 9, 1:42 PM · Restricted Project
bkramer committed rG0abb472fffaf: AMDGPU/GISel: Remove unused variable. NFC. (authored by bkramer).
AMDGPU/GISel: Remove unused variable. NFC.
Thu, Jun 9, 4:44 AM · Restricted Project, Restricted Project
bkramer committed rGabcf1496ad21: Fix complex.conj integration test (authored by bkramer).
Fix complex.conj integration test
Thu, Jun 9, 4:12 AM · Restricted Project, Restricted Project

Wed, Jun 8

bkramer committed rGb3c0918fb480: [AST] Make header self-contained (authored by bkramer).
[AST] Make header self-contained
Wed, Jun 8, 3:40 AM · Restricted Project, Restricted Project
bkramer committed rG6eb0f8e28598: [mlir][MemRef] Fix a crash when expanding a scalar shape (authored by bkramer).
[mlir][MemRef] Fix a crash when expanding a scalar shape
Wed, Jun 8, 12:43 AM · Restricted Project, Restricted Project
bkramer closed D127232: [mlir][MemRef] Fix a crash when expanding a scalar shape.
Wed, Jun 8, 12:43 AM · Restricted Project, Restricted Project
bkramer accepted D127256: [mlir][bufferize] Improve buffer writability analysis.

thanks

Wed, Jun 8, 12:41 AM · Restricted Project, Restricted Project

Tue, Jun 7

bkramer requested review of D127232: [mlir][MemRef] Fix a crash when expanding a scalar shape.
Tue, Jun 7, 10:32 AM · Restricted Project, Restricted Project
bkramer committed rG1fd6f06b9e97: [format] Fix an uninitialized variable (authored by bkramer).
[format] Fix an uninitialized variable
Tue, Jun 7, 9:19 AM · Restricted Project, Restricted Project
bkramer committed rG1fd0beaa4e20: [DX][ObjYAML] Zero out unused fields that get written to the output file (authored by bkramer).
[DX][ObjYAML] Zero out unused fields that get written to the output file
Tue, Jun 7, 7:32 AM · Restricted Project, Restricted Project

Fri, Jun 3

bkramer committed rG389c0b81d3be: [bazel] Port 95aff23e2921 (authored by bkramer).
[bazel] Port 95aff23e2921
Fri, Jun 3, 11:44 AM · Restricted Project
bkramer committed rG3a252806f41b: [COFF] Fix -Wredundant-move (authored by bkramer).
[COFF] Fix -Wredundant-move
Fri, Jun 3, 8:40 AM · Restricted Project, Restricted Project
bkramer committed rGa8d2a381a2e7: [VPlan] Silence another unused variable warning in release builds (authored by bkramer).
[VPlan] Silence another unused variable warning in release builds
Fri, Jun 3, 5:08 AM · Restricted Project, Restricted Project
bkramer committed rG6b7c18639021: [VPlan] Inline variable into assertion. NFC. (authored by bkramer).
[VPlan] Inline variable into assertion. NFC.
Fri, Jun 3, 5:01 AM · Restricted Project, Restricted Project
bkramer committed rGe8e4b741dd10: [DAGCombiner] Add bf16 to the matrix of types that we don't promote to integer… (authored by bkramer).
[DAGCombiner] Add bf16 to the matrix of types that we don't promote to integer…
Fri, Jun 3, 4:29 AM · Restricted Project, Restricted Project
bkramer requested review of D126953: Promote bf16 to f32 when the target doesn't support it.
Fri, Jun 3, 2:24 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 2

bkramer committed rG5b2a7348b7e7: [IRTests] With opaque ptrs we can test that there is no bitcast inserted (authored by bkramer).
[IRTests] With opaque ptrs we can test that there is no bitcast inserted
Thu, Jun 2, 1:00 AM · Restricted Project, Restricted Project

Wed, Jun 1

bkramer committed rGd9de52819dbd: [bazel] Add a missing dependency after f3bdb56d61e3 (authored by bkramer).
[bazel] Add a missing dependency after f3bdb56d61e3
Wed, Jun 1, 1:52 PM · Restricted Project
bkramer accepted D126799: [mlir] Add conversion and tests for complex.[sqrt|atan2] to Arith..

looks great, thanks

Wed, Jun 1, 11:15 AM · Restricted Project, Restricted Project
bkramer committed rG7d431e9ec57b: [mlir][complex] Remove unused variables. NFC. (authored by bkramer).
[mlir][complex] Remove unused variables. NFC.
Wed, Jun 1, 12:33 AM · Restricted Project, Restricted Project

Tue, May 31

bkramer committed rG110a20b70e43: [bazel] Port 42c17073fcba (authored by bkramer).
[bazel] Port 42c17073fcba
Tue, May 31, 4:52 AM · Restricted Project

May 27 2022

bkramer accepted D126539: [mlir] Lower complex.sqrt and complex.atan2 to Arithmetic dialect..

thanks

May 27 2022, 8:48 AM · Restricted Project, Restricted Project

May 25 2022

bkramer accepted D126357: [mlir] Add `complex.atan2` operation..

looks good

May 25 2022, 1:11 AM · Restricted Project, Restricted Project

May 23 2022

bkramer committed rG2f2ca30d0aba: Fix an unused variable warning in no-asserts build mode (authored by bkramer).
Fix an unused variable warning in no-asserts build mode
May 23 2022, 10:54 AM · Restricted Project, Restricted Project
bkramer accepted D126206: [mlir] Add Expm1 tp ComplexOps.td..

lg

May 23 2022, 7:32 AM · Restricted Project, Restricted Project
bkramer accepted D126202: [mlir] Add RSqrt tp ComplexOps.td..

Looks good

May 23 2022, 7:11 AM · Restricted Project, Restricted Project

May 21 2022

bkramer committed rG295d032762ad: [mlir] Move diagnostic handlers instead of copying (authored by bkramer).
[mlir] Move diagnostic handlers instead of copying
May 21 2022, 4:28 AM · Restricted Project, Restricted Project
bkramer committed rGc312f025940d: [STLExtras] Make indexed_accessor_range operator== compatible with C++20 (authored by bkramer).
[STLExtras] Make indexed_accessor_range operator== compatible with C++20
May 21 2022, 4:06 AM · Restricted Project, Restricted Project
bkramer committed rG86fd1c139fb8: [bufferization] Simplify code. NFCI. (authored by bkramer).
[bufferization] Simplify code. NFCI.
May 21 2022, 2:00 AM · Restricted Project, Restricted Project

May 18 2022

bkramer committed rG46d9a6ebd615: [libcxx] [test] Include header for strverscmp (authored by jwakely).
[libcxx] [test] Include header for strverscmp
May 18 2022, 5:37 AM · Restricted Project, Restricted Project
bkramer committed rG89cacb9ee72c: [libcxx] [test] Add missing header for std::numeric_limits (authored by jwakely).
[libcxx] [test] Add missing header for std::numeric_limits
May 18 2022, 5:37 AM · Restricted Project, Restricted Project
bkramer closed D122570: [libcxx] [test] Include header for strverscmp.
May 18 2022, 5:37 AM · Restricted Project, Restricted Project
bkramer closed D122571: [libcxx] [test] Add missing header for std::numeric_limits.
May 18 2022, 5:37 AM · Restricted Project, Restricted Project
bkramer committed rGe497871356f2: [mlir][complex] Add pow/sqrt/tanh ops and lowering to libm (authored by bkramer).
[mlir][complex] Add pow/sqrt/tanh ops and lowering to libm
May 18 2022, 5:03 AM · Restricted Project, Restricted Project
bkramer closed D125550: [mlir][complex] Add pow/sqrt/tanh ops and lowering to libm.
May 18 2022, 5:03 AM · Restricted Project, Restricted Project

May 17 2022

bkramer accepted D125835: [mlir][SCF] Fix scf.while bufferization.

Thanks

May 17 2022, 2:12 PM · Restricted Project, Restricted Project

May 14 2022

bkramer committed rGcc88212d817c: [bazel] Port ae8bbc43f470 (authored by bkramer).
[bazel] Port ae8bbc43f470
May 14 2022, 3:14 AM · Restricted Project

May 13 2022

bkramer requested review of D125550: [mlir][complex] Add pow/sqrt/tanh ops and lowering to libm.
May 13 2022, 8:17 AM · Restricted Project, Restricted Project

May 12 2022

bkramer committed rG434385ba4104: [DenseElementAttr] Silence warning in -DNDEBUG builds. NFC. (authored by bkramer).
[DenseElementAttr] Silence warning in -DNDEBUG builds. NFC.
May 12 2022, 9:00 AM · Restricted Project, Restricted Project
bkramer committed rG303638248ab1: [mlir][linalg] Add lowering of named ops on complex numbers (authored by bkramer).
[mlir][linalg] Add lowering of named ops on complex numbers
May 12 2022, 4:47 AM · Restricted Project, Restricted Project
bkramer closed D125461: [mlir][linalg] Add lowering of named ops on complex numbers.
May 12 2022, 4:47 AM · Restricted Project, Restricted Project
bkramer requested review of D125461: [mlir][linalg] Add lowering of named ops on complex numbers.
May 12 2022, 4:37 AM · Restricted Project, Restricted Project
bkramer committed rGca6cbbe8d0ca: [bazel] Add support for configuring the bazel build for PPC (authored by bkramer).
[bazel] Add support for configuring the bazel build for PPC
May 12 2022, 3:08 AM · Restricted Project
bkramer committed rG27dad99622bb: [mlir][LLVM] Make the nested type restriction on complex constants less… (authored by bkramer).
[mlir][LLVM] Make the nested type restriction on complex constants less…
May 12 2022, 3:07 AM · Restricted Project, Restricted Project
bkramer closed D125381: [mlir][LLVM] Make the nested type restriction on complex constants less aggressive.
May 12 2022, 3:07 AM · Restricted Project, Restricted Project

May 11 2022

bkramer requested review of D125381: [mlir][LLVM] Make the nested type restriction on complex constants less aggressive.
May 11 2022, 6:16 AM · Restricted Project, Restricted Project

May 9 2022

bkramer committed rGa48adc565864: [mlir][math] Promote (b)f16 to f32 when lowering to libm calls (authored by bkramer).
[mlir][math] Promote (b)f16 to f32 when lowering to libm calls
May 9 2022, 3:04 AM · Restricted Project, Restricted Project
bkramer closed D125093: [mlir][math] Promote (b)f16 to f32 when lowering to libm calls.
May 9 2022, 3:03 AM · Restricted Project, Restricted Project

May 6 2022

bkramer requested review of D125093: [mlir][math] Promote (b)f16 to f32 when lowering to libm calls.
May 6 2022, 6:45 AM · Restricted Project, Restricted Project

May 5 2022

bkramer accepted D124929: [mlir][scf] Implement BufferizableOpInterface for scf::WhileOp.

Not an expert on this, but looks fine to me.

May 5 2022, 11:47 AM · Restricted Project, Restricted Project
bkramer committed rG17d27d926be3: [IR] Simplify code. NFCI. (authored by bkramer).
[IR] Simplify code. NFCI.
May 5 2022, 7:08 AM · Restricted Project, Restricted Project
bkramer committed rG08b20f20d285: [ConstantFold] Use getFltSemantics instead of manually checking the type (authored by bkramer).
[ConstantFold] Use getFltSemantics instead of manually checking the type
May 5 2022, 6:54 AM · Restricted Project, Restricted Project

May 3 2022

bkramer committed rG9eccc7357e6d: [bazel] Fix the build after 2c3326608460 (authored by bkramer).
[bazel] Fix the build after 2c3326608460
May 3 2022, 2:05 PM · Restricted Project