Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (403 w, 6 d)

d0k

Recent Activity

Today

bkramer committed rG880ec421dd20: [MC] Use a byte_swap in emitIntValue instead of doing it in a loop. NFCI. (authored by bkramer).
[MC] Use a byte_swap in emitIntValue instead of doing it in a loop. NFCI.
Mon, Apr 6, 7:00 AM
bkramer committed rGe64e516790b6: [RuntimeDyld] Replace hand-rolled endian conversion with support::endian. NFCI. (authored by bkramer).
[RuntimeDyld] Replace hand-rolled endian conversion with support::endian. NFCI.
Mon, Apr 6, 4:50 AM
bkramer committed rG232eff55f654: [LTO] Replace hand-rolled endian conversion with support::endian. NFCI. (authored by bkramer).
[LTO] Replace hand-rolled endian conversion with support::endian. NFCI.
Mon, Apr 6, 4:50 AM
bkramer committed rG9a9bc2367290: [llvm-bcanalyzer] Simplify code. NFCI. (authored by bkramer).
[llvm-bcanalyzer] Simplify code. NFCI.
Mon, Apr 6, 4:18 AM

Yesterday

bkramer committed rGff889df35669: [X86] Roll some loops. NFCI. (authored by bkramer).
[X86] Roll some loops. NFCI.
Sun, Apr 5, 5:20 AM

Fri, Apr 3

bkramer accepted D76512: [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043).

makes sense to me

Fri, Apr 3, 9:07 AM · Restricted Project
bkramer committed rG71305033d115: [LoopOps] Return ArrayRefs from accessors instead of iterator_ranges (authored by bkramer).
[LoopOps] Return ArrayRefs from accessors instead of iterator_ranges
Fri, Apr 3, 8:36 AM
bkramer committed rG02cb21df3f4a: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Fri, Apr 3, 4:16 AM
bkramer committed rG6aecf0cfef04: Drop unused diagnostic. NFC. (authored by bkramer).
Drop unused diagnostic. NFC.
Fri, Apr 3, 4:16 AM

Thu, Apr 2

bkramer committed rGde8831934a1e: [LoopDataPrefetch] Remove unused include that's a layering violation (authored by bkramer).
[LoopDataPrefetch] Remove unused include that's a layering violation
Thu, Apr 2, 9:13 AM
bkramer committed rGdffc5031874e: Revert "[SimplifyLibCalls] Erase replaced instructions" (authored by bkramer).
Revert "[SimplifyLibCalls] Erase replaced instructions"
Thu, Apr 2, 8:39 AM
bkramer added a reverting change for rG2a77544ad591: [SimplifyLibCalls] Erase replaced instructions: rGdffc5031874e: Revert "[SimplifyLibCalls] Erase replaced instructions".
Thu, Apr 2, 8:39 AM

Wed, Apr 1

bkramer committed rGb605c56b0fac: [ARM] Silence warning in Release builds (authored by bkramer).
[ARM] Silence warning in Release builds
Wed, Apr 1, 6:35 AM
bkramer committed rG66b9f5f7f0d2: [GVNSink] Simplify code. NFC. (authored by bkramer).
[GVNSink] Simplify code. NFC.
Wed, Apr 1, 4:25 AM

Tue, Mar 31

bkramer committed rGe8f13f4f62f5: Replace std::string::find == 0 with StringRef::startswith (authored by bkramer).
Replace std::string::find == 0 with StringRef::startswith
Tue, Mar 31, 12:03 PM

Mon, Mar 30

bkramer committed rG3806b38045c0: [LLDB] Initialize temporary token (authored by bkramer).
[LLDB] Initialize temporary token
Mon, Mar 30, 7:33 AM

Sun, Mar 29

bkramer committed rG6e0afb5f108f: [ARMMVE] Create fewer temporary SmallVectors (authored by bkramer).
[ARMMVE] Create fewer temporary SmallVectors
Sun, Mar 29, 1:56 PM
bkramer committed rG854f268ca62e: [MC] Move deprecation infos from MCTargetDesc to MCInstrInfo (authored by bkramer).
[MC] Move deprecation infos from MCTargetDesc to MCInstrInfo
Sun, Mar 29, 12:51 PM

Sat, Mar 28

bkramer committed rGdd030036f0a2: Put back initializers that were dropped in… (authored by bkramer).
Put back initializers that were dropped in…
Sat, Mar 28, 2:32 PM
bkramer committed rGb578f130a72f: [COFF] Stabilize sort (authored by bkramer).
[COFF] Stabilize sort
Sat, Mar 28, 2:00 PM
bkramer committed rGba2e72c54ec9: [MDBuilder] Don't use stable sort for sorting integers. (authored by bkramer).
[MDBuilder] Don't use stable sort for sorting integers.
Sat, Mar 28, 1:27 PM
bkramer committed rGd3b6e1f1f93e: [ADT] Automatically forward llvm::sort to array_pod_sort if safe (authored by bkramer).
[ADT] Automatically forward llvm::sort to array_pod_sort if safe
Sat, Mar 28, 12:55 PM
bkramer committed rG2d24d74b8595: [AMDGPU] Stabilize sort order (authored by bkramer).
[AMDGPU] Stabilize sort order
Sat, Mar 28, 12:23 PM
bkramer committed rG4065e92195b1: Upgrade some instances of std::sort to llvm::sort. NFC. (authored by bkramer).
Upgrade some instances of std::sort to llvm::sort. NFC.
Sat, Mar 28, 11:49 AM
bkramer committed rG347e31c052d5: Remove constexpr that MSVC doesn't like (authored by bkramer).
Remove constexpr that MSVC doesn't like
Sat, Mar 28, 11:49 AM
bkramer committed rGe8743c0f389d: Const-initialize ParsedAttrInfos (authored by bkramer).
Const-initialize ParsedAttrInfos
Sat, Mar 28, 11:17 AM

Thu, Mar 26

bkramer added a comment to D76007: [WIP][TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes.

I'm lacking an understanding of how concurrency is expected to work within LLVM, but since there is only one RegisterBankInfo constructed per subtarget I don't see how there is a problem with updating the global RegBanks array? Likewise the HwMode is constant for the subtarget, so the write will be of the same value.

Thu, Mar 26, 2:42 PM · Restricted Project

Tue, Mar 24

bkramer committed rG0019c2f194a5: [SelectionDAG] Don't crash when freezing illegal float types (authored by bkramer).
[SelectionDAG] Don't crash when freezing illegal float types
Tue, Mar 24, 11:50 AM
bkramer accepted D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test..

looks good

Tue, Mar 24, 7:29 AM · Restricted Project
bkramer committed rGb6732056a448: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Tue, Mar 24, 5:53 AM

Mon, Mar 23

bkramer committed rGff2f5097ed44: [Attributor] Fold single-use variable into assert (authored by bkramer).
[Attributor] Fold single-use variable into assert
Mon, Mar 23, 9:49 AM

Thu, Mar 19

bkramer committed rG1db8b341a665: [Matrix] Fold single-use variable into assert (authored by bkramer).
[Matrix] Fold single-use variable into assert
Thu, Mar 19, 1:43 PM

Tue, Mar 17

bkramer committed rGacf6e4190f40: Purge unused diagnostics. NFC. (authored by bkramer).
Purge unused diagnostics. NFC.
Tue, Mar 17, 7:26 AM
bkramer accepted D76272: Fix memtag test..

Right, we don't have names for values in release builds.

Tue, Mar 17, 3:00 AM · Restricted Project

Mon, Mar 16

bkramer committed rG05ff3323e073: [AArch64] Remove unused variable (authored by bkramer).
[AArch64] Remove unused variable
Mon, Mar 16, 2:14 PM

Sun, Mar 15

bkramer committed rGcaef4a81c93b: [AVR] Make helper functions static. NFC. (authored by bkramer).
[AVR] Make helper functions static. NFC.
Sun, Mar 15, 9:05 AM
bkramer committed rG5cc9dea78a3b: [tblgen] Remove unused private field. NFC. (authored by bkramer).
[tblgen] Remove unused private field. NFC.
Sun, Mar 15, 9:05 AM

Tue, Mar 10

bkramer committed rG247a177cf78f: Give helpers internal linkage. NFC. (authored by bkramer).
Give helpers internal linkage. NFC.
Tue, Mar 10, 10:53 AM

Mar 5 2020

bkramer committed rG2773c692e8cb: Fix pessimizing move. NFC. (authored by bkramer).
Fix pessimizing move. NFC.
Mar 5 2020, 9:52 AM
bkramer committed rG66addf8e8036: Revert "Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in"… (authored by bkramer).
Revert "Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in"…
Mar 5 2020, 5:30 AM
bkramer added a reverting change for rGbdad0a1b7927: PR45083: Mark statement expressions as being dependent if they appear in…: rG66addf8e8036: Revert "Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in"….
Mar 5 2020, 5:29 AM
bkramer added a reverting change for rGf545ede91c9d: Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in TreeTransform…: rG66addf8e8036: Revert "Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in"….
Mar 5 2020, 5:29 AM

Mar 4 2020

bkramer committed rGaa3f791fa944: [x86][SLH] Rm liveness check from data invariance check (authored by zbrid).
[x86][SLH] Rm liveness check from data invariance check
Mar 4 2020, 1:00 PM
bkramer closed D70283: [x86][SLH] Rm liveness check from data invariance check.
Mar 4 2020, 12:59 PM · Restricted Project
bkramer accepted D75605: [lld] Avoid creating files outside of work directory..

looks good

Mar 4 2020, 6:11 AM · Restricted Project

Mar 3 2020

bkramer committed rGb917d5e1a4f7: [llvm-ar] Remove unused variable. NFC. (authored by bkramer).
[llvm-ar] Remove unused variable. NFC.
Mar 3 2020, 6:22 AM

Feb 29 2020

bkramer committed rG186dd6318271: ArrayRef'ize restoreCalleeSavedRegisters. NFCI. (authored by bkramer).
ArrayRef'ize restoreCalleeSavedRegisters. NFCI.
Feb 29 2020, 12:57 AM

Feb 28 2020

bkramer committed rG5abf128d647d: Add a pass that specializes parallel loops for easier unrolling and… (authored by bkramer).
Add a pass that specializes parallel loops for easier unrolling and…
Feb 28 2020, 10:52 AM
bkramer closed D75240: Add a pass that specializes parallel loops for easier unrolling and vectorization.
Feb 28 2020, 10:52 AM · Restricted Project
bkramer updated the diff for D75240: Add a pass that specializes parallel loops for easier unrolling and vectorization.
  • Renamed the thing ParallelLoopSpecialization
  • Match the canonicalized AffineMap form, not the one produced by ParallelLoopTiling
Feb 28 2020, 4:22 AM · Restricted Project

Feb 27 2020

bkramer accepted D75266: SROA: Don't drop atomic load/store alignments (PR45010).

makes sense to me

Feb 27 2020, 9:13 AM · Restricted Project
bkramer created D75240: Add a pass that specializes parallel loops for easier unrolling and vectorization.
Feb 27 2020, 4:34 AM · Restricted Project
bkramer accepted D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..

looks good, thanks

Feb 27 2020, 4:15 AM · Restricted Project

Feb 25 2020

bkramer committed rGfc466f87804f: Make test not write to the source directory (authored by bkramer).
Make test not write to the source directory
Feb 25 2020, 7:06 AM
bkramer added a reviewer for D75110: Avoid dangling reference when indexing sections: lhames.
Feb 25 2020, 4:44 AM · Restricted Project

Feb 24 2020

bkramer committed rG8c893cac3f65: [ORC] Remove spammy debug print (authored by bkramer).
[ORC] Remove spammy debug print
Feb 24 2020, 3:16 AM
bkramer committed rGbc1947a6f51f: Add a basic tiling pass for parallel loops (authored by bkramer).
Add a basic tiling pass for parallel loops
Feb 24 2020, 2:48 AM
bkramer committed rG3ac37eb9a93a: Silence compiler warnings (authored by bkramer).
Silence compiler warnings
Feb 24 2020, 2:48 AM
bkramer closed D74954: Add a basic tiling pass for parallel loops.
Feb 24 2020, 2:48 AM · Restricted Project
bkramer updated the diff for D74954: Add a basic tiling pass for parallel loops.
  • WTF phab?
Feb 24 2020, 2:48 AM · Restricted Project
bkramer updated the diff for D74954: Add a basic tiling pass for parallel loops.
  • Address moar comments
Feb 24 2020, 2:42 AM · Restricted Project

Feb 21 2020

bkramer updated the diff for D74954: Add a basic tiling pass for parallel loops.
  • Make tileSizes a list
  • Fix min again
Feb 21 2020, 7:09 AM · Restricted Project
bkramer updated the diff for D74954: Add a basic tiling pass for parallel loops.
  • One round of addressed review comments
Feb 21 2020, 6:06 AM · Restricted Project
bkramer updated the diff for D74954: Add a basic tiling pass for parallel loops.
  • use pass option instead of global option
  • fix the recursive walker to walk recursively
Feb 21 2020, 4:53 AM · Restricted Project
bkramer created D74954: Add a basic tiling pass for parallel loops.
Feb 21 2020, 4:35 AM · Restricted Project

Feb 18 2020

bkramer committed rG44bbc7670004: Drop a constexpr in favor of const, MSVC complains. (authored by bkramer).
Drop a constexpr in favor of const, MSVC complains.
Feb 18 2020, 8:08 AM
bkramer committed rG9e4b761aba01: Move DFA tables into the read-only data segmant. (authored by bkramer).
Move DFA tables into the read-only data segmant.
Feb 18 2020, 5:41 AM

Feb 17 2020

bkramer committed rG564a9de28ed4: Hide implementation details. NFC> (authored by bkramer).
Hide implementation details. NFC>
Feb 17 2020, 8:56 AM
bkramer committed rGf4c59c0f97cd: [wasm] Unbreak after 5fc5c7db38672c8962879b6fdce68393181c5e08. NFCI. (authored by bkramer).
[wasm] Unbreak after 5fc5c7db38672c8962879b6fdce68393181c5e08. NFCI.
Feb 17 2020, 6:52 AM
bkramer committed rG5fc5c7db3867: Strength reduce vectors into arrays. NFCI. (authored by bkramer).
Strength reduce vectors into arrays. NFCI.
Feb 17 2020, 6:43 AM
bkramer committed rG6704960f7c28: [ADT] Use inherited ctors to forward to base. NFCI. (authored by bkramer).
[ADT] Use inherited ctors to forward to base. NFCI.
Feb 17 2020, 5:40 AM

Feb 14 2020

bkramer accepted D74592: Do not build the CUBIN conversion pass when NVPTX Backend isn't configured.

In the long term I'd prefer to not initialize backends inside of pass at all, but for the short term this is better than pulling in all backends.

Feb 14 2020, 1:18 AM · Restricted Project

Feb 12 2020

bkramer accepted D74493: Replace std::foo with std::foo_t in LLVM..

looks good

Feb 12 2020, 12:33 PM · Restricted Project

Feb 11 2020

bkramer accepted D74423: Use C++14-style return type deduction in clang..

lg

Feb 11 2020, 11:28 AM · Restricted Project
bkramer accepted D74414: Use std::foo_t rather than std::foo in clang..

lg

Feb 11 2020, 9:36 AM · Restricted Project
bkramer accepted D74412: Fix SFINAE in CFG.cpp..

lg

Feb 11 2020, 9:03 AM · Restricted Project
bkramer accepted D74383: Use C++14-style return type deduction in LLVM..

good stuff

Feb 11 2020, 2:33 AM · Restricted Project
bkramer accepted D74384: Use std::foo_t rather than std::foo in LLVM..

<courage wolf>Push and watch the bots</courage wolf>

Feb 11 2020, 2:33 AM · Restricted Project, Restricted Project

Feb 8 2020

bkramer committed rG7355364f63ea: Put back makeArrayRef to make GCC 5 happy (authored by bkramer).
Put back makeArrayRef to make GCC 5 happy
Feb 8 2020, 7:20 AM
bkramer committed rGec93c758ced7: Drop some uses of StringLiteral in favor of StringRef (authored by bkramer).
Drop some uses of StringLiteral in favor of StringRef
Feb 8 2020, 6:52 AM
bkramer committed rGef83d46b6b42: Use heterogenous lookup for std;:map<std::string with a StringRef. NFCI. (authored by bkramer).
Use heterogenous lookup for std;:map<std::string with a StringRef. NFCI.
Feb 8 2020, 4:30 AM
bkramer committed rGe4230a9f6c51: ArrayRef'ize spillCalleeSavedRegisters. NFCI. (authored by bkramer).
ArrayRef'ize spillCalleeSavedRegisters. NFCI.
Feb 8 2020, 3:21 AM

Feb 7 2020

bkramer added a comment to D42365: [LoopFlatten] Add a loop-flattening pass.

Was this ever committed? Loop flattening looks like something that's useful to have.

Feb 7 2020, 5:00 AM · Restricted Project

Feb 6 2020

bkramer committed rGb68b8be8e2b9: [mlir-tblgen] Stop leaking PredNodes (authored by bkramer).
[mlir-tblgen] Stop leaking PredNodes
Feb 6 2020, 9:09 AM

Jan 29 2020

bkramer committed rGc2b7e4e88a1a: Rewrite test not to rely on StrEq with StringRef (authored by bkramer).
Rewrite test not to rely on StrEq with StringRef
Jan 29 2020, 12:45 PM
bkramer committed rG01213f90700d: [clang-tidy] Initialize token before handing it to the lexer (authored by bkramer).
[clang-tidy] Initialize token before handing it to the lexer
Jan 29 2020, 7:49 AM
bkramer committed rG0ee4b027d37e: Fix an implicit conversion in clang-tidy. GCC 5 complains about it. (authored by bkramer).
Fix an implicit conversion in clang-tidy. GCC 5 complains about it.
Jan 29 2020, 3:07 AM
bkramer committed rG4e3f4f03f3e4: [ASTMatchers] StringRef'ify hasName (authored by bkramer).
[ASTMatchers] StringRef'ify hasName
Jan 29 2020, 1:54 AM
bkramer committed rG757bdc64d33d: Fix clang unnittest build with GCC 5 (authored by bkramer).
Fix clang unnittest build with GCC 5
Jan 29 2020, 1:36 AM

Jan 28 2020

bkramer committed rG49ad3f614322: One more bugpoitn fix for GCC5 (authored by bkramer).
One more bugpoitn fix for GCC5
Jan 28 2020, 6:50 PM
bkramer committed rG42a25e7fe6ff: Try harder to fix bugpoint with GCC5 (authored by bkramer).
Try harder to fix bugpoint with GCC5
Jan 28 2020, 6:32 PM
bkramer committed rGcd87e207ec7c: Make bugpoint work with gcc5 again. (authored by bkramer).
Make bugpoint work with gcc5 again.
Jan 28 2020, 6:14 PM
bkramer committed rGbd31243a34da: Fix more implicit conversions. Getting closer to having clang working with gcc… (authored by bkramer).
Fix more implicit conversions. Getting closer to having clang working with gcc…
Jan 28 2020, 6:05 PM
bkramer committed rGbb39b52950e7: Fix conversions in clang and examples (authored by bkramer).
Fix conversions in clang and examples
Jan 28 2020, 5:56 PM
bkramer committed rG2b36e85542d2: GCC5 buildbot made it to clang. Fix implicit conversions it found. (authored by bkramer).
GCC5 buildbot made it to clang. Fix implicit conversions it found.
Jan 28 2020, 5:20 PM
bkramer committed rG2d92336db008: Another stab at making the gold plugin compile again (authored by bkramer).
Another stab at making the gold plugin compile again
Jan 28 2020, 5:20 PM
bkramer committed rGa9bc7b83a402: Another round of GCC5 fixes. (authored by bkramer).
Another round of GCC5 fixes.
Jan 28 2020, 5:11 PM
bkramer committed rG735f90fe42e5: Fix one round of implicit conversions found by g++5. (authored by bkramer).
Fix one round of implicit conversions found by g++5.
Jan 28 2020, 4:53 PM
bkramer committed rG8b6320c79d4b: Address implicit conversions detected by g++ 5 only. (authored by bkramer).
Address implicit conversions detected by g++ 5 only.
Jan 28 2020, 4:07 PM
bkramer committed rGddf77f10a301: One more batch of things found by g++ 6 (authored by bkramer).
One more batch of things found by g++ 6
Jan 28 2020, 3:58 PM