d0k
User Details
- User Since
- Jul 10 2012, 1:37 PM (444 w, 4 d)
- Roles
- Administrator
Dec 10 2020
Dec 9 2020
- Rename argument from $ty to $arg
Dec 8 2020
- Address comments
Dec 5 2020
Dec 1 2020
Nov 30 2020
While it would be nice for dereferenceable to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See llvm::Value::getPointerDereferenceableBytes and its users.
Nov 26 2020
Let's land this now to unblock asan. It's breaking test/Transforms/test-legalizer.mlir though because there's a cast being left behind.
looks good
Nov 21 2020
Nov 18 2020
Saw some random miscompiles after this. Fixed by 4dbe12e86649ba6b5f03a9ba97e84d718727f7a7, can you check if I got it right?
Nov 17 2020
Nov 16 2020
Nov 10 2020
Nov 4 2020
looks good
Can you add a note to the commit description that this is a reland of D90379?
Nov 3 2020
Nov 2 2020
Building with GCC7 is fixed by 5ece2115d85326e3b24336a7ccb4c191932ccb4a, but looks like this was reverted already.
Should be fixed as of 5ece2115d85326e3b24336a7ccb4c191932ccb4a
looks good
Oct 28 2020
Oct 27 2020
Oct 26 2020
Oct 24 2020
Oct 21 2020
Thanks
Oct 20 2020
Oct 19 2020
thanks
Oct 16 2020
I have no memory of adding that transformation 9 years ago. dec + test should be better than popcnt + cmp even on modern x86, but with no data to back that up it might not matter at all.
This should be safe. Looks good.
Oct 15 2020
The code now essentially says
Oct 14 2020
looking good
Oct 13 2020
Oct 10 2020
Oct 5 2020
Oct 4 2020
- Don't print "std." prefix on tranpose
Oct 2 2020
- Address a round of review comments
Oct 1 2020
Sep 30 2020
Sep 28 2020
looks good
Thanks
Sep 27 2020
Sep 25 2020
Can we promote everything to 64 bits to simplify the logic a bit? Otherwise looking good.
Sep 22 2020
Reproduces for me. Let's roll this back for now.
Sep 21 2020
Ok, let's revert this for now. It's annoying to have a dependency on something that's not used by the in-tree backends, so we need to figure out how to remove it.
Sep 17 2020
looks good
Sep 16 2020
Sep 15 2020
Sep 11 2020
Thanks, I prefer simplicity over efficiency here.