Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (386 w, 5 d)

d0k

Recent Activity

Today

bkramer added a comment to rGa885796d5fd8: Make VFS and FileManager match the current MemoryBuffer API..

Plus, I'm building llvm into webassembly. I guess the above assumption that for most cases mmap will null terminate a mapped buffer is not true in the wasm case.

Mon, Dec 9, 4:49 AM

Tue, Dec 3

bkramer committed rGaa189ed25fbd: Fix compatibility with python3 of clang-include-fixer.py (authored by Yannick Brehon <yannickb@google.com>).
Fix compatibility with python3 of clang-include-fixer.py
Tue, Dec 3, 4:04 AM
bkramer closed D70902: Fix compatibility with python3 of clang-include-fixer.py.
Tue, Dec 3, 4:04 AM · Restricted Project
bkramer accepted D70902: Fix compatibility with python3 of clang-include-fixer.py.

lg

Tue, Dec 3, 3:55 AM · Restricted Project

Thu, Nov 28

bkramer committed rG66237889a79f: [include-fixer] Python 3 support for clang-include-fixer.py (authored by bkramer).
[include-fixer] Python 3 support for clang-include-fixer.py
Thu, Nov 28, 5:24 AM

Thu, Nov 21

bkramer added a comment to D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp.

For us this would be an impediment as we have math models that want ieee behavior while relaxing precision. Adding nnan or ninf would obstruct those choices.

Thu, Nov 21, 12:22 PM · Restricted Project, Restricted Project
bkramer accepted D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows.

lg

Thu, Nov 21, 5:21 AM · Restricted Project
bkramer added a comment to D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".

Pushed this in 446acafb82b5c116b6c94c11d4ac4db7641fa58d. The difference is visible with opt -O3, right? Or do you need an executable test (that's hard)

Thu, Nov 21, 2:50 AM · Restricted Project
bkramer added a reverting change for rG5f026b6d9e88: [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should…: rG446acafb82b5: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load"….
Thu, Nov 21, 2:41 AM
bkramer committed rG446acafb82b5: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load"… (authored by bkramer).
Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load"…
Thu, Nov 21, 2:41 AM
bkramer closed D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".
Thu, Nov 21, 2:41 AM · Restricted Project

Wed, Nov 20

bkramer updated the diff for D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp.

Fix condition

Wed, Nov 20, 5:59 AM · Restricted Project, Restricted Project
bkramer created D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp.
Wed, Nov 20, 5:48 AM · Restricted Project, Restricted Project

Tue, Nov 19

bkramer committed rGcd4811360e2a: [ValueTracking] Add a basic version of isKnownNonInfinity and use it to detect… (authored by bkramer).
[ValueTracking] Add a basic version of isKnownNonInfinity and use it to detect…
Tue, Nov 19, 1:38 PM

Mon, Nov 18

bkramer accepted D70360: [Bindings][Go] Fix go.test failure due to missing argument.

lg

Mon, Nov 18, 5:27 AM · Restricted Project

Thu, Nov 14

bkramer added a reverting change for rGa2292cc537b5: [ThinLTO] Add correctness check for RO/WO variable import: rG360f66173324: Revert "[ThinLTO] Add correctness check for RO/WO variable import".
Thu, Nov 14, 7:12 AM
bkramer committed rG360f66173324: Revert "[ThinLTO] Add correctness check for RO/WO variable import" (authored by bkramer).
Revert "[ThinLTO] Add correctness check for RO/WO variable import"
Thu, Nov 14, 7:12 AM

Sun, Nov 10

bkramer committed rG6c94068da99a: [Driver] Remove unused variable. NFC. (authored by bkramer).
[Driver] Remove unused variable. NFC.
Sun, Nov 10, 3:55 AM

Nov 6 2019

bkramer committed rGeb12b3b8a3e5: Silence warning, PyMODINIT_FUNC already contains extern "C" (authored by bkramer).
Silence warning, PyMODINIT_FUNC already contains extern "C"
Nov 6 2019, 3:35 AM

Nov 5 2019

bkramer committed rG5f158d8e21be: [X86] Gate select->fmin/fmax transform on NoSignedZeros instead of UnsafeFPMath (authored by bkramer).
[X86] Gate select->fmin/fmax transform on NoSignedZeros instead of UnsafeFPMath
Nov 5 2019, 12:29 PM
bkramer committed rG00e53d912dd7: [X86] Specifically limit fmin/fmax commutativity to NoNaNs + NoSignedZeros (authored by bkramer).
[X86] Specifically limit fmin/fmax commutativity to NoNaNs + NoSignedZeros
Nov 5 2019, 10:38 AM

Nov 4 2019

bkramer committed rGd3ec06d21978: Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations… (authored by bkramer).
Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations…
Nov 4 2019, 6:10 AM
bkramer added a reverting change for rG2be17087f8c3: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC): rGd3ec06d21978: Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations….
Nov 4 2019, 6:09 AM
bkramer added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

This fails with asan: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/36343/steps/check-llvm%20asan/logs/stdio
Reverted in d3ec06d219788801380af1948c7f7ef9d3c6100b

Nov 4 2019, 6:09 AM · Restricted Project

Oct 26 2019

bkramer committed rG5e307808557f: Correct size_t format specifier (authored by scw).
Correct size_t format specifier
Oct 26 2019, 1:45 AM
bkramer closed D69455: Correct size_t format specifier.
Oct 26 2019, 1:44 AM · Restricted Project

Oct 24 2019

bkramer committed rG6f0bb7703705: [InstCombine] Fold one-use variable into assert (authored by bkramer).
[InstCombine] Fold one-use variable into assert
Oct 24 2019, 9:01 AM
bkramer committed rGbfa3f0c31665: Hide implementation details in anonymous namespaces. NFC. (authored by bkramer).
Hide implementation details in anonymous namespaces. NFC.
Oct 24 2019, 1:57 AM

Oct 22 2019

bkramer committed rGecc999101aad: [FrontendTests] Try again to make test not write an output file (authored by bkramer).
[FrontendTests] Try again to make test not write an output file
Oct 22 2019, 1:44 AM
bkramer committed rG2108a974f78a: Revert "[FrontendTests] Don't actually run the full compiler, parsing is… (authored by bkramer).
Revert "[FrontendTests] Don't actually run the full compiler, parsing is…
Oct 22 2019, 1:44 AM
bkramer committed rG3ca2b17f847d: [FrontendTests] Don't actually run the full compiler, parsing is sufficient. (authored by bkramer).
[FrontendTests] Don't actually run the full compiler, parsing is sufficient.
Oct 22 2019, 1:17 AM
bkramer committed rG64226b2df667: [clang-fuzzer] Update proto fuzzer example for r375453. (authored by bkramer).
[clang-fuzzer] Update proto fuzzer example for r375453.
Oct 22 2019, 12:58 AM

Oct 15 2019

bkramer committed rGce00cd6ae845: [AsmPrinter] Fix unused variable warning in Release builds. NFC. (authored by bkramer).
[AsmPrinter] Fix unused variable warning in Release builds. NFC.
Oct 15 2019, 7:30 AM
bkramer committed rGdfb7a736015f: [AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST (authored by bkramer).
[AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST
Oct 15 2019, 7:30 AM

Oct 12 2019

bkramer committed rGc5d1d56731d8: [Attributor] Extend anonymous namespace. NFC. (authored by bkramer).
[Attributor] Extend anonymous namespace. NFC.
Oct 12 2019, 4:05 AM
bkramer committed rG97c9804e0639: [LV] Merge LLVM_DEBUG blocks. (authored by bkramer).
[LV] Merge LLVM_DEBUG blocks.
Oct 12 2019, 3:58 AM

Oct 2 2019

bkramer committed rG340406a7400e: [Stencil] Hide implementaion detai. NFC. (authored by bkramer).
[Stencil] Hide implementaion detai. NFC.
Oct 2 2019, 11:37 AM
bkramer committed rG12e915b3fcc5: [ARM] Make helpers static. NFC. (authored by bkramer).
[ARM] Make helpers static. NFC.
Oct 2 2019, 11:20 AM
bkramer accepted D68311: [X86] Rewrite to the vXi1 subvector insertion code to not rely on the value of bits that might be undef.

lg

Oct 2 2019, 10:39 AM · Restricted Project
bkramer requested changes to D68311: [X86] Rewrite to the vXi1 subvector insertion code to not rely on the value of bits that might be undef.

With the suggested changes this passes the test suite from https://github.com/google/jax with AVX512 enabled. I still don't see why the original code would be wrong though.

Oct 2 2019, 1:32 AM · Restricted Project

Oct 1 2019

bkramer changed the visibility for P8166 AVX512 bug.
Oct 1 2019, 12:07 PM
bkramer created P8166 AVX512 bug.
Oct 1 2019, 12:07 PM

Sep 22 2019

bkramer committed rG1b38002c7dae: Move classes into anonymous namespaces. NFC. (authored by bkramer).
Move classes into anonymous namespaces. NFC.
Sep 22 2019, 2:30 AM

Sep 20 2019

bkramer committed rG8599ffa4b1cd: [StaticAnalyzer] Use llvm::StringLiteral instead of StringRef in few places (authored by bkramer).
[StaticAnalyzer] Use llvm::StringLiteral instead of StringRef in few places
Sep 20 2019, 5:59 AM

Sep 19 2019

bkramer committed rGb88800d8829b: Clean out unused diagnostics. NFC. (authored by bkramer).
Clean out unused diagnostics. NFC.
Sep 19 2019, 6:36 AM

Sep 18 2019

bkramer committed rG4b661f94e288: [DDG] Break a cyclic dependency from Analysis to ScalarOpts (authored by bkramer).
[DDG] Break a cyclic dependency from Analysis to ScalarOpts
Sep 18 2019, 11:07 AM
bkramer accepted D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".

Rubber stamp'd

Sep 18 2019, 7:40 AM · Restricted Project
bkramer accepted D67702: [lldb] Fix a test assertion after r372192.

Rubber stamp'd

Sep 18 2019, 5:40 AM · Restricted Project

Sep 17 2019

bkramer committed rG957a6c6bedfa: [clangd] Fix another TSAN issue (authored by bkramer).
[clangd] Fix another TSAN issue
Sep 17 2019, 7:57 AM
bkramer committed rG167b3020753a: [RISCV] Unbreak the build (authored by bkramer).
[RISCV] Unbreak the build
Sep 17 2019, 7:27 AM
bkramer accepted D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".

lg

Sep 17 2019, 7:10 AM · Restricted Project
bkramer committed rGdf4b9a3f4f7a: Hide implementation details in namespaces. (authored by bkramer).
Hide implementation details in namespaces.
Sep 17 2019, 6:01 AM
bkramer accepted D67655: lldb: move a test input to the test Inputs dir.

lg

Sep 17 2019, 5:12 AM · Restricted Project

Sep 13 2019

bkramer committed rGb4160cb94c54: [ADT] Remove a workaround for old versions of clang (authored by bkramer).
[ADT] Remove a workaround for old versions of clang
Sep 13 2019, 6:49 AM
bkramer committed rG266f6347dbb8: [ADT] Make DenseMap use allocate_buffer (authored by bkramer).
[ADT] Make DenseMap use allocate_buffer
Sep 13 2019, 5:32 AM
bkramer committed rG6baaa4be7831: [Orc] Roll back ThreadPool to std::function (authored by bkramer).
[Orc] Roll back ThreadPool to std::function
Sep 13 2019, 5:03 AM
bkramer committed rGce74c3b19f5b: [Orc] Address the remaining move-capture FIXMEs (authored by bkramer).
[Orc] Address the remaining move-capture FIXMEs
Sep 13 2019, 4:35 AM
bkramer accepted D67487: [CodeEmitter] Support instruction widths > 64 bits.

I think this is fine. Features like this might bitrot quickly but that's on you ;)

Sep 13 2019, 3:51 AM · Restricted Project

Sep 7 2019

bkramer committed rG84c7904d62c6: [Attributor] Make unimplemented method pure virtual. (authored by bkramer).
[Attributor] Make unimplemented method pure virtual.
Sep 7 2019, 3:27 AM

Sep 3 2019

bkramer committed rG0581a44e02e4: Unbreak the build after r370798 (authored by bkramer).
Unbreak the build after r370798
Sep 3 2019, 11:25 AM

Aug 26 2019

bkramer committed rG1e4241cad7c7: Remove unused variables. (authored by bkramer).
Remove unused variables.
Aug 26 2019, 1:56 PM
bkramer committed rG57effbdadc0b: [ADT] Make StringRef(const char*) constexpr (authored by bkramer).
[ADT] Make StringRef(const char*) constexpr
Aug 26 2019, 1:52 PM

Aug 25 2019

bkramer committed rG55e8c91dd5a6: [AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC… (authored by bkramer).
[AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC…
Aug 25 2019, 5:50 AM

Aug 24 2019

bkramer committed rGd5e60669c4ad: [TLI] Simplify code. NFCI. (authored by bkramer).
[TLI] Simplify code. NFCI.
Aug 24 2019, 10:30 AM
bkramer committed rG3c614f7b482a: [clang-tidy] Manually enable exceptions in tesst that uses them (authored by bkramer).
[clang-tidy] Manually enable exceptions in tesst that uses them
Aug 24 2019, 10:20 AM
bkramer committed rGaa5ef3887c0e: Hack around a GCC ICE that was fixed in GCC 6.2 (authored by bkramer).
Hack around a GCC ICE that was fixed in GCC 6.2
Aug 24 2019, 9:22 AM
bkramer committed rG7e8f9d579ccb: Try to make MSVC 2017 happy. (authored by bkramer).
Try to make MSVC 2017 happy.
Aug 24 2019, 8:49 AM
bkramer committed rG70434770425c: Fix some accidental global initializers by using StringLiteral instead of… (authored by bkramer).
Fix some accidental global initializers by using StringLiteral instead of…
Aug 24 2019, 8:24 AM
bkramer committed rG573d81cec5c3: Update tablegen test after r369847. (authored by bkramer).
Update tablegen test after r369847.
Aug 24 2019, 8:13 AM
bkramer committed rG45d205637a0e: [llvm-reduce] Silence -Wdocumentation (authored by bkramer).
[llvm-reduce] Silence -Wdocumentation
Aug 24 2019, 8:04 AM
bkramer committed rG16b322914a3f: Use a bit of relaxed constexpr to make FeatureBitset costant intializable (authored by bkramer).
Use a bit of relaxed constexpr to make FeatureBitset costant intializable
Aug 24 2019, 8:04 AM
bkramer committed rG19651b68d956: [OpenCL] Microoptimize OCL2Qual a bit (authored by bkramer).
[OpenCL] Microoptimize OCL2Qual a bit
Aug 24 2019, 6:06 AM

Aug 23 2019

bkramer committed rGdc5f805d31f6: Do a sweep of symbol internalization. NFC. (authored by bkramer).
Do a sweep of symbol internalization. NFC.
Aug 23 2019, 12:59 PM
bkramer committed rGccc272cd32c9: Fix clang-tidy warning in clang-tidy (authored by bkramer).
Fix clang-tidy warning in clang-tidy
Aug 23 2019, 10:28 AM

Aug 22 2019

bkramer committed rGb3a991df3cd6: Fight a bit against global initializers. NFC. (authored by bkramer).
Fight a bit against global initializers. NFC.
Aug 22 2019, 12:51 PM
bkramer committed rG15ee5ba6e757: [clangd] Fold string copy into lambda capture. NFC. (authored by bkramer).
[clangd] Fold string copy into lambda capture. NFC.
Aug 22 2019, 11:15 AM
bkramer committed rGcd2bae3bd77f: Retire llvm::less_ptr. llvm::deref is much more flexible. (authored by bkramer).
Retire llvm::less_ptr. llvm::deref is much more flexible.
Aug 22 2019, 10:32 AM
bkramer committed rGd5aecb9486e4: Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>. (authored by bkramer).
Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>.
Aug 22 2019, 10:32 AM

Aug 21 2019

bkramer committed rG81faa5e6a26c: Use C++14 heteregenous lookup for a couple of std::map<std::string, ...> (authored by bkramer).
Use C++14 heteregenous lookup for a couple of std::map<std::string, ...>
Aug 21 2019, 2:18 PM

Aug 19 2019

bkramer committed rG928071ae4ef5: [Support] Replace sys::Mutex with their standard equivalents. (authored by bkramer).
[Support] Replace sys::Mutex with their standard equivalents.
Aug 19 2019, 12:55 PM

Aug 16 2019

bkramer committed rG31a47f989091: Revert "[CallGraph] Refine call graph for indirect calls with !callees metadata" (authored by bkramer).
Revert "[CallGraph] Refine call graph for indirect calls with !callees metadata"
Aug 16 2019, 4:03 AM

Aug 15 2019

bkramer committed rG2e62396c2f3f: Link libpthread into LLVMCore.so (authored by bkramer).
Link libpthread into LLVMCore.so
Aug 15 2019, 11:06 AM
bkramer committed rG8d3a1523dd96: [Support] Base RWMutex on std::shared_timed_mutex (C++14) (authored by bkramer).
[Support] Base RWMutex on std::shared_timed_mutex (C++14)
Aug 15 2019, 9:56 AM
bkramer committed rG9880b5dd2178: [clangd] Don't use Bind() where C++14 move capture works (authored by bkramer).
[clangd] Don't use Bind() where C++14 move capture works
Aug 15 2019, 7:17 AM
bkramer committed rG5e9a16408ced: [ADT] PointerUnion: Use C++14 constexpr std::min (authored by bkramer).
[ADT] PointerUnion: Use C++14 constexpr std::min
Aug 15 2019, 4:49 AM
bkramer committed rGe1bc32bddf2e: [clangd] llvm::integer_sequence -> std::integer_sequence. (authored by bkramer).
[clangd] llvm::integer_sequence -> std::integer_sequence.
Aug 15 2019, 4:09 AM
bkramer committed rG37508d3dd94b: Replace llvm::integer_sequence and friends with the C++14 standard version (authored by bkramer).
Replace llvm::integer_sequence and friends with the C++14 standard version
Aug 15 2019, 4:00 AM
bkramer committed rGd596dd811399: Bump llvm-go to C++14 (authored by bkramer).
Bump llvm-go to C++14
Aug 15 2019, 4:00 AM

Aug 12 2019

bkramer committed rG3bd2b513403a: Remove outdated comment about clang not populating src2dst_offset (authored by bkramer).
Remove outdated comment about clang not populating src2dst_offset
Aug 12 2019, 7:35 AM

Aug 9 2019

bkramer committed rG8819a734ae51: [sanitizer] Update symbolizer/scripts/global_symbols.txt (authored by bkramer).
[sanitizer] Update symbolizer/scripts/global_symbols.txt
Aug 9 2019, 7:05 AM

Aug 7 2019

bkramer committed rG762bc3351f29: Remove LLVM mutexes from clang in favor of std::mutex (authored by bkramer).
Remove LLVM mutexes from clang in favor of std::mutex
Aug 7 2019, 7:47 AM
bkramer committed rGea134f221f2a: [Support] Base SmartMutex on std::recursive_mutex (authored by bkramer).
[Support] Base SmartMutex on std::recursive_mutex
Aug 7 2019, 5:00 AM
bkramer committed rGe57b60f32102: Replace non-recursive sys::Mutex users with std::mutex (authored by bkramer).
Replace non-recursive sys::Mutex users with std::mutex
Aug 7 2019, 5:00 AM
bkramer committed rG3d5360a4398b: Replace llvm::MutexGuard/UniqueLock with their standard equivalents (authored by bkramer).
Replace llvm::MutexGuard/UniqueLock with their standard equivalents
Aug 7 2019, 3:58 AM

Aug 4 2019

bkramer committed rG6f0ac30ae160: [ORC] Remove a layer of indirection when locking the mutex. NFCI. (authored by bkramer).
[ORC] Remove a layer of indirection when locking the mutex. NFCI.
Aug 4 2019, 4:10 AM

Jul 11 2019

bkramer committed rGeda5d870e916: [NVPTX] Remove now unused atomic.load.add.f32 intrinsics (authored by bkramer).
[NVPTX] Remove now unused atomic.load.add.f32 intrinsics
Jul 11 2019, 12:23 PM
bkramer committed rG3b5e60b695e1: [CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd (authored by bkramer).
[CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd
Jul 11 2019, 10:48 AM
bkramer committed rGfa1a4e4de536: [NVPTX] Use atomicrmw fadd instead of intrinsics (authored by bkramer).
[NVPTX] Use atomicrmw fadd instead of intrinsics
Jul 11 2019, 10:12 AM

Jul 5 2019

bkramer committed rG05eebaa949d0: [PowerPC] Fold another unused variable into assertion. NFC. (authored by bkramer).
[PowerPC] Fold another unused variable into assertion. NFC.
Jul 5 2019, 1:00 PM
bkramer committed rG31f6b13e83a9: [PowerPC] Fold variable into assert. NFC. (authored by bkramer).
[PowerPC] Fold variable into assert. NFC.
Jul 5 2019, 12:49 PM