Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (375 w, 2 d)

d0k

Recent Activity

Yesterday

bkramer committed rGb88800d8829b: Clean out unused diagnostics. NFC. (authored by bkramer).
Clean out unused diagnostics. NFC.
Thu, Sep 19, 6:36 AM

Wed, Sep 18

bkramer committed rG4b661f94e288: [DDG] Break a cyclic dependency from Analysis to ScalarOpts (authored by bkramer).
[DDG] Break a cyclic dependency from Analysis to ScalarOpts
Wed, Sep 18, 11:07 AM
bkramer accepted D67710: Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize".

Rubber stamp'd

Wed, Sep 18, 7:40 AM · Restricted Project
bkramer accepted D67702: [lldb] Fix a test assertion after r372192.

Rubber stamp'd

Wed, Sep 18, 5:40 AM · Restricted Project

Tue, Sep 17

bkramer committed rG957a6c6bedfa: [clangd] Fix another TSAN issue (authored by bkramer).
[clangd] Fix another TSAN issue
Tue, Sep 17, 7:57 AM
bkramer committed rG167b3020753a: [RISCV] Unbreak the build (authored by bkramer).
[RISCV] Unbreak the build
Tue, Sep 17, 7:27 AM
bkramer accepted D67658: Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)".

lg

Tue, Sep 17, 7:10 AM · Restricted Project
bkramer committed rGdf4b9a3f4f7a: Hide implementation details in namespaces. (authored by bkramer).
Hide implementation details in namespaces.
Tue, Sep 17, 6:01 AM
bkramer accepted D67655: lldb: move a test input to the test Inputs dir.

lg

Tue, Sep 17, 5:12 AM · Restricted Project

Fri, Sep 13

bkramer committed rGb4160cb94c54: [ADT] Remove a workaround for old versions of clang (authored by bkramer).
[ADT] Remove a workaround for old versions of clang
Fri, Sep 13, 6:49 AM
bkramer committed rG266f6347dbb8: [ADT] Make DenseMap use allocate_buffer (authored by bkramer).
[ADT] Make DenseMap use allocate_buffer
Fri, Sep 13, 5:32 AM
bkramer committed rG6baaa4be7831: [Orc] Roll back ThreadPool to std::function (authored by bkramer).
[Orc] Roll back ThreadPool to std::function
Fri, Sep 13, 5:03 AM
bkramer committed rGce74c3b19f5b: [Orc] Address the remaining move-capture FIXMEs (authored by bkramer).
[Orc] Address the remaining move-capture FIXMEs
Fri, Sep 13, 4:35 AM
bkramer accepted D67487: [CodeEmitter] Support instruction widths > 64 bits.

I think this is fine. Features like this might bitrot quickly but that's on you ;)

Fri, Sep 13, 3:51 AM · Restricted Project

Sat, Sep 7

bkramer committed rG84c7904d62c6: [Attributor] Make unimplemented method pure virtual. (authored by bkramer).
[Attributor] Make unimplemented method pure virtual.
Sat, Sep 7, 3:27 AM

Tue, Sep 3

bkramer committed rG0581a44e02e4: Unbreak the build after r370798 (authored by bkramer).
Unbreak the build after r370798
Tue, Sep 3, 11:25 AM

Mon, Aug 26

bkramer committed rG1e4241cad7c7: Remove unused variables. (authored by bkramer).
Remove unused variables.
Mon, Aug 26, 1:56 PM
bkramer committed rG57effbdadc0b: [ADT] Make StringRef(const char*) constexpr (authored by bkramer).
[ADT] Make StringRef(const char*) constexpr
Mon, Aug 26, 1:52 PM

Sun, Aug 25

bkramer committed rG55e8c91dd5a6: [AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC… (authored by bkramer).
[AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC…
Sun, Aug 25, 5:50 AM

Sat, Aug 24

bkramer committed rGd5e60669c4ad: [TLI] Simplify code. NFCI. (authored by bkramer).
[TLI] Simplify code. NFCI.
Sat, Aug 24, 10:30 AM
bkramer committed rG3c614f7b482a: [clang-tidy] Manually enable exceptions in tesst that uses them (authored by bkramer).
[clang-tidy] Manually enable exceptions in tesst that uses them
Sat, Aug 24, 10:20 AM
bkramer committed rGaa5ef3887c0e: Hack around a GCC ICE that was fixed in GCC 6.2 (authored by bkramer).
Hack around a GCC ICE that was fixed in GCC 6.2
Sat, Aug 24, 9:22 AM
bkramer committed rG7e8f9d579ccb: Try to make MSVC 2017 happy. (authored by bkramer).
Try to make MSVC 2017 happy.
Sat, Aug 24, 8:49 AM
bkramer committed rG70434770425c: Fix some accidental global initializers by using StringLiteral instead of… (authored by bkramer).
Fix some accidental global initializers by using StringLiteral instead of…
Sat, Aug 24, 8:24 AM
bkramer committed rG573d81cec5c3: Update tablegen test after r369847. (authored by bkramer).
Update tablegen test after r369847.
Sat, Aug 24, 8:13 AM
bkramer committed rG45d205637a0e: [llvm-reduce] Silence -Wdocumentation (authored by bkramer).
[llvm-reduce] Silence -Wdocumentation
Sat, Aug 24, 8:04 AM
bkramer committed rG16b322914a3f: Use a bit of relaxed constexpr to make FeatureBitset costant intializable (authored by bkramer).
Use a bit of relaxed constexpr to make FeatureBitset costant intializable
Sat, Aug 24, 8:04 AM
bkramer committed rG19651b68d956: [OpenCL] Microoptimize OCL2Qual a bit (authored by bkramer).
[OpenCL] Microoptimize OCL2Qual a bit
Sat, Aug 24, 6:06 AM

Fri, Aug 23

bkramer committed rGdc5f805d31f6: Do a sweep of symbol internalization. NFC. (authored by bkramer).
Do a sweep of symbol internalization. NFC.
Fri, Aug 23, 12:59 PM
bkramer committed rGccc272cd32c9: Fix clang-tidy warning in clang-tidy (authored by bkramer).
Fix clang-tidy warning in clang-tidy
Fri, Aug 23, 10:28 AM

Thu, Aug 22

bkramer committed rGb3a991df3cd6: Fight a bit against global initializers. NFC. (authored by bkramer).
Fight a bit against global initializers. NFC.
Thu, Aug 22, 12:51 PM
bkramer committed rG15ee5ba6e757: [clangd] Fold string copy into lambda capture. NFC. (authored by bkramer).
[clangd] Fold string copy into lambda capture. NFC.
Thu, Aug 22, 11:15 AM
bkramer committed rGcd2bae3bd77f: Retire llvm::less_ptr. llvm::deref is much more flexible. (authored by bkramer).
Retire llvm::less_ptr. llvm::deref is much more flexible.
Thu, Aug 22, 10:32 AM
bkramer committed rGd5aecb9486e4: Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>. (authored by bkramer).
Retire llvm::less/equal in favor of C++14 std::less<>/equal_to<>.
Thu, Aug 22, 10:32 AM

Wed, Aug 21

bkramer committed rG81faa5e6a26c: Use C++14 heteregenous lookup for a couple of std::map<std::string, ...> (authored by bkramer).
Use C++14 heteregenous lookup for a couple of std::map<std::string, ...>
Wed, Aug 21, 2:18 PM

Aug 19 2019

bkramer committed rG928071ae4ef5: [Support] Replace sys::Mutex with their standard equivalents. (authored by bkramer).
[Support] Replace sys::Mutex with their standard equivalents.
Aug 19 2019, 12:55 PM

Aug 16 2019

bkramer committed rG31a47f989091: Revert "[CallGraph] Refine call graph for indirect calls with !callees metadata" (authored by bkramer).
Revert "[CallGraph] Refine call graph for indirect calls with !callees metadata"
Aug 16 2019, 4:03 AM

Aug 15 2019

bkramer committed rG2e62396c2f3f: Link libpthread into LLVMCore.so (authored by bkramer).
Link libpthread into LLVMCore.so
Aug 15 2019, 11:06 AM
bkramer committed rG8d3a1523dd96: [Support] Base RWMutex on std::shared_timed_mutex (C++14) (authored by bkramer).
[Support] Base RWMutex on std::shared_timed_mutex (C++14)
Aug 15 2019, 9:56 AM
bkramer committed rG9880b5dd2178: [clangd] Don't use Bind() where C++14 move capture works (authored by bkramer).
[clangd] Don't use Bind() where C++14 move capture works
Aug 15 2019, 7:17 AM
bkramer committed rG5e9a16408ced: [ADT] PointerUnion: Use C++14 constexpr std::min (authored by bkramer).
[ADT] PointerUnion: Use C++14 constexpr std::min
Aug 15 2019, 4:49 AM
bkramer committed rGe1bc32bddf2e: [clangd] llvm::integer_sequence -> std::integer_sequence. (authored by bkramer).
[clangd] llvm::integer_sequence -> std::integer_sequence.
Aug 15 2019, 4:09 AM
bkramer committed rG37508d3dd94b: Replace llvm::integer_sequence and friends with the C++14 standard version (authored by bkramer).
Replace llvm::integer_sequence and friends with the C++14 standard version
Aug 15 2019, 4:00 AM
bkramer committed rGd596dd811399: Bump llvm-go to C++14 (authored by bkramer).
Bump llvm-go to C++14
Aug 15 2019, 4:00 AM

Aug 12 2019

bkramer committed rG3bd2b513403a: Remove outdated comment about clang not populating src2dst_offset (authored by bkramer).
Remove outdated comment about clang not populating src2dst_offset
Aug 12 2019, 7:35 AM

Aug 9 2019

bkramer committed rG8819a734ae51: [sanitizer] Update symbolizer/scripts/global_symbols.txt (authored by bkramer).
[sanitizer] Update symbolizer/scripts/global_symbols.txt
Aug 9 2019, 7:05 AM

Aug 7 2019

bkramer committed rG762bc3351f29: Remove LLVM mutexes from clang in favor of std::mutex (authored by bkramer).
Remove LLVM mutexes from clang in favor of std::mutex
Aug 7 2019, 7:47 AM
bkramer committed rGea134f221f2a: [Support] Base SmartMutex on std::recursive_mutex (authored by bkramer).
[Support] Base SmartMutex on std::recursive_mutex
Aug 7 2019, 5:00 AM
bkramer committed rGe57b60f32102: Replace non-recursive sys::Mutex users with std::mutex (authored by bkramer).
Replace non-recursive sys::Mutex users with std::mutex
Aug 7 2019, 5:00 AM
bkramer committed rG3d5360a4398b: Replace llvm::MutexGuard/UniqueLock with their standard equivalents (authored by bkramer).
Replace llvm::MutexGuard/UniqueLock with their standard equivalents
Aug 7 2019, 3:58 AM

Aug 4 2019

bkramer committed rG6f0ac30ae160: [ORC] Remove a layer of indirection when locking the mutex. NFCI. (authored by bkramer).
[ORC] Remove a layer of indirection when locking the mutex. NFCI.
Aug 4 2019, 4:10 AM

Jul 11 2019

bkramer committed rGeda5d870e916: [NVPTX] Remove now unused atomic.load.add.f32 intrinsics (authored by bkramer).
[NVPTX] Remove now unused atomic.load.add.f32 intrinsics
Jul 11 2019, 12:23 PM
bkramer committed rG3b5e60b695e1: [CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd (authored by bkramer).
[CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd
Jul 11 2019, 10:48 AM
bkramer committed rGfa1a4e4de536: [NVPTX] Use atomicrmw fadd instead of intrinsics (authored by bkramer).
[NVPTX] Use atomicrmw fadd instead of intrinsics
Jul 11 2019, 10:12 AM

Jul 5 2019

bkramer committed rG05eebaa949d0: [PowerPC] Fold another unused variable into assertion. NFC. (authored by bkramer).
[PowerPC] Fold another unused variable into assertion. NFC.
Jul 5 2019, 1:00 PM
bkramer committed rG31f6b13e83a9: [PowerPC] Fold variable into assert. NFC. (authored by bkramer).
[PowerPC] Fold variable into assert. NFC.
Jul 5 2019, 12:49 PM
bkramer committed rG049230b4d2d3: [PowerPC] Remove unused variable. NFC. (authored by bkramer).
[PowerPC] Remove unused variable. NFC.
Jul 5 2019, 12:29 PM

Jul 2 2019

bkramer committed rG8758dce45fcb: [ASTImporter] Make headers self-contained (authored by bkramer).
[ASTImporter] Make headers self-contained
Jul 2 2019, 1:05 AM

Jul 1 2019

bkramer committed rG4f769361e359: [ASTImporter] Silence unused variable warning in Release builds. NFC. (authored by bkramer).
[ASTImporter] Silence unused variable warning in Release builds. NFC.
Jul 1 2019, 7:37 AM
bkramer committed rGed13fef47741: [SelectionDAG] Do minnum->minimum at legalization time instead of building time (authored by bkramer).
[SelectionDAG] Do minnum->minimum at legalization time instead of building time
Jul 1 2019, 4:11 AM

Jun 6 2019

bkramer committed rGf1249442cf3b: Revert "[SCEV] Use wrap flags in InsertBinop" (authored by bkramer).
Revert "[SCEV] Use wrap flags in InsertBinop"
Jun 6 2019, 5:33 AM

Jun 5 2019

bkramer committed rGb90b35479888: [LoopInfo] Fix unused variable warning. NFC. (authored by bkramer).
[LoopInfo] Fix unused variable warning. NFC.
Jun 5 2019, 7:42 AM
bkramer committed rG9b2b8ad8b187: Revert "Factor out duplicated code building a MemberExpr and marking it" and… (authored by bkramer).
Revert "Factor out duplicated code building a MemberExpr and marking it" and…
Jun 5 2019, 4:44 AM

Jun 4 2019

bkramer committed rG03ff1b3c30f1: [X86] Fold single-use variable into assert. NFC. (authored by bkramer).
[X86] Fold single-use variable into assert. NFC.
Jun 4 2019, 11:01 AM

May 30 2019

bkramer committed rG851f57effaaa: [AST] asm goto labels don't have constraints, don't try to copy them. (authored by bkramer).
[AST] asm goto labels don't have constraints, don't try to copy them.
May 30 2019, 12:20 AM

May 29 2019

bkramer committed rG107f8d98730c: [DAGCombiner] Replace gathers with a zero mask with the passthru value (authored by bkramer).
[DAGCombiner] Replace gathers with a zero mask with the passthru value
May 29 2019, 12:22 PM
bkramer updated the diff for D62613: [DAGCombiner] Replace gathers with a zero mask with the passthru value.

Use isBuildVectorAllZeros, drop isNullOrNullSplat change.

May 29 2019, 11:44 AM · Restricted Project
bkramer added inline comments to D62613: [DAGCombiner] Replace gathers with a zero mask with the passthru value.
May 29 2019, 11:44 AM · Restricted Project
bkramer created D62613: [DAGCombiner] Replace gathers with a zero mask with the passthru value.
May 29 2019, 11:22 AM · Restricted Project

May 28 2019

bkramer committed rG57e267a2e92a: [X86] Custom lower CONCAT_VECTORS of v2i1 (authored by bkramer).
[X86] Custom lower CONCAT_VECTORS of v2i1
May 28 2019, 5:52 AM

Apr 18 2019

bkramer committed rG70857952844c: MinidumpYAML: Fix ambiguity between std::make_unique and llvm::make_unique (authored by bkramer).
MinidumpYAML: Fix ambiguity between std::make_unique and llvm::make_unique
Apr 18 2019, 8:08 AM

Apr 3 2019

bkramer accepted D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery.

lg

Apr 3 2019, 12:23 PM · Restricted Project

Apr 1 2019

bkramer accepted D60060: [X86] Fix a test from r357317.

lg

Apr 1 2019, 4:44 AM · Restricted Project

Mar 28 2019

bkramer committed rGba2ea93ad189: Make helper functions static. NFC. (authored by bkramer).
Make helper functions static. NFC.
Mar 28 2019, 10:18 AM

Mar 24 2019

bkramer accepted D59750: Rename directory housing clang-include-fixer to be eponymous.

lg. Is the reference from libclang still around? Might need an update.

Mar 24 2019, 3:36 PM · Restricted Project

Mar 15 2019

bkramer committed rGa65ec7eec8d1: Make getFullyQualifiedName qualify both the pointee and class type for member… (authored by bkramer).
Make getFullyQualifiedName qualify both the pointee and class type for member…
Mar 15 2019, 4:10 AM

Mar 14 2019

bkramer created D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types.
Mar 14 2019, 2:32 PM · Restricted Project, Restricted Project

Mar 11 2019

bkramer committed rG1b1d372b4234: Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC. (authored by bkramer).
Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC.
Mar 11 2019, 3:44 AM
bkramer committed rG6ff32e143a64: [MIPS GlobalISel] Silence uninitialized variable warning (authored by bkramer).
[MIPS GlobalISel] Silence uninitialized variable warning
Mar 11 2019, 3:39 AM
bkramer committed rG9318db0fa199: [Serialization] Add missing include (authored by bkramer).
[Serialization] Add missing include
Mar 11 2019, 3:30 AM

Mar 8 2019

bkramer committed rG93110c2fe46c: Make function definition in header inline (authored by bkramer).
Make function definition in header inline
Mar 8 2019, 2:44 AM

Feb 11 2019

bkramer committed rG711950c1161e: Move some classes into anonymous namespaces. NFC. (authored by bkramer).
Move some classes into anonymous namespaces. NFC.
Feb 11 2019, 7:17 AM
bkramer committed rG756ecb8e44dc: Make some helper functions static. NFC. (authored by bkramer).
Make some helper functions static. NFC.
Feb 11 2019, 6:52 AM
bkramer committed rG582c16013d26: [AMDGPU] Remove unused variable (authored by bkramer).
[AMDGPU] Remove unused variable
Feb 11 2019, 6:51 AM

Jan 30 2019

bkramer accepted D57442: [OpenGL] Fix test on PPC after r352540.

lg

Jan 30 2019, 3:22 AM

Jan 24 2019

bkramer accepted D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule()..
Jan 24 2019, 6:56 AM

Jan 14 2019

bkramer accepted D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes)..

This makes sense to me.

Jan 14 2019, 7:54 AM

Jan 10 2019

bkramer accepted D56521: Avoid use-after-free in ~LegacyRTDyldObjectLinkingLayer.

This is an obvious fix for a use-after-free. Looks good.

Jan 10 2019, 11:57 AM

Dec 9 2018

bkramer accepted D55415: Revert removal of tidy plugin support from libclang.

I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually.

Dec 9 2018, 9:57 PM
bkramer accepted D55484: ComputeLineNumbers: delete SSE2 vectorization.

The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on?

Dec 9 2018, 9:55 PM

Dec 7 2018

bkramer added a comment to D55415: Revert removal of tidy plugin support from libclang.

I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.

Dec 7 2018, 7:06 AM

Nov 21 2018

bkramer accepted D54788: [TI removal] Leverage the fact that TerminatorInst is gone to create a normal base class that provides all common "call" functionality..

I like it.

Nov 21 2018, 7:58 AM

Nov 14 2018

bkramer accepted D54540: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable types.

Thanks. There's a bit of unused code that passes isPodLike through the layers, but this is the minimal fix. Looks good to me.

Nov 14 2018, 2:09 PM

Nov 6 2018

bkramer accepted D54160: [sanitizer] Expose getauxval as weak declaration to fix TSanitizer-x86_64-Test-Nolibc.

Thanks! This looks good to me, but I'd like someone from sanitizer team review it too.

Nov 6 2018, 10:25 AM

Nov 5 2018

bkramer updated the diff for D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
  • Add a comment to the test.
Nov 5 2018, 3:01 PM
bkramer added inline comments to D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
Nov 5 2018, 3:00 PM
bkramer added a comment to D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
In D54113#1287835, @kcc wrote:

Is a test possible here?

Nov 5 2018, 1:50 PM
bkramer updated the diff for D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.

Add test

Nov 5 2018, 1:50 PM
bkramer created D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
Nov 5 2018, 9:42 AM

Oct 25 2018

bkramer accepted D53689: IR: Optimize StructType::get to perform one hash lookup instead of two, NFCI.

lg

Oct 25 2018, 5:26 AM