bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (279 w, 5 d)

d0k

Recent Activity

Thu, Nov 16

bkramer accepted D40140: [VirtualFileSystem] Support creating directories then adding files inside.

lg

Thu, Nov 16, 11:07 AM

Wed, Nov 15

bkramer accepted D40084: Assert correct removal of SUnit in LatencyPriorityQueue.

lg. Do you have commit access?

Wed, Nov 15, 11:12 AM

Tue, Nov 14

bkramer accepted D40027: [libclang] Fix cursors for in-class initializer of field declarations.

lgtm

Tue, Nov 14, 8:51 AM

Fri, Nov 10

bkramer accepted D39763: [clang] [python] [tests] Rewrite to use standard unittest module.

I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this.

Fri, Nov 10, 5:37 AM

Thu, Nov 9

bkramer accepted D39572: [VirtualFileSystem] InMemoryFileSystem::addFile(): Type and Perms.

LGTM!

Thu, Nov 9, 7:52 AM
bkramer added inline comments to D39806: [clang-format] Support python-style comments in text protos.
Thu, Nov 9, 7:38 AM
bkramer accepted D39786: [clang-format] Sort using declarations by splitting on '::'.

lg

Thu, Nov 9, 7:27 AM

Fri, Nov 3

bkramer accepted D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'.

lg, thanks!

Fri, Nov 3, 7:35 AM

Thu, Nov 2

bkramer added a comment to D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'.

Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state.

Thu, Nov 2, 10:25 AM
bkramer accepted D39435: Adds a json::Expr type to represent intermediate JSON expressions..

I think we can go ahead with this. Using std::map is also fine if your elements are heavy and you need sorting :)

Thu, Nov 2, 10:18 AM

Wed, Nov 1

bkramer accepted D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI.

lg

Wed, Nov 1, 10:53 AM

Thu, Oct 26

bkramer accepted D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Looks good, thanks!

Thu, Oct 26, 12:30 AM
bkramer accepted D36390: Fix overloaded static functions in SemaCodeComplete.

This looks good. Sorry for the long wait, do you have commit access?

Thu, Oct 26, 12:26 AM

Wed, Oct 25

bkramer requested changes to D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Can you point at the test cases that are failing? This would mean that there are two symbols with the same name, which seems like something that shouldn't happen.

The following 3 tests fail:

LLVM :: CodeGen/ARM/available_externally.ll
LLVM :: CodeGen/ARM/darwin-tls.ll
LLVM :: CodeGen/ARM/indirect-hidden.ll
Wed, Oct 25, 1:20 AM

Tue, Oct 24

bkramer added a comment to D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Can you point at the test cases that are failing? This would mean that there are two symbols with the same name, which seems like something that shouldn't happen.

Tue, Oct 24, 11:25 PM

Mon, Oct 23

bkramer accepted D38992: Support formatv of TimePoint with strftime-style formats..

I think this can go in now.

Mon, Oct 23, 7:13 PM

Oct 12 2017

bkramer accepted D38787: [FileCheck] doc update/fix.

lg

Oct 12 2017, 8:43 AM

Oct 11 2017

bkramer added a comment to D38787: [FileCheck] doc update/fix.

Does FileCheck actually support BRE? I thought it's always ERE.

Oct 11 2017, 3:23 PM

Oct 9 2017

bkramer accepted D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble..

A testcase would be nice, but this can go in to unblock things.

Oct 9 2017, 9:26 AM
bkramer accepted D37970: [clangd] Added a command-line arg to mirror clangd input into a file..

This looks useful, thanks!

Oct 9 2017, 8:07 AM

Oct 8 2017

bkramer created D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer..
Oct 8 2017, 3:34 PM

Sep 25 2017

bkramer accepted D38225: [clangd] Fix missing "message" key when responding with unsupported method.

This looks good. Do you have commit access?

Sep 25 2017, 7:59 AM
bkramer accepted D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON.

lg

Sep 25 2017, 7:04 AM

Sep 20 2017

bkramer accepted D38087: [clang-tidy] Fix example in documentation, NFC.

fun fun fun fun fun

Sep 20 2017, 11:23 AM

Sep 13 2017

bkramer accepted D37564: Update users of llvm::sys::ExecuteAndWait etc..

lgtm too

Sep 13 2017, 9:45 AM
bkramer accepted D37563: Convenience/safety fix for llvm::sys::Execute(And|No)Wait.

lgtm

Sep 13 2017, 8:29 AM

Sep 8 2017

bkramer accepted D37382: Fixed a crash in code completion..

lg

Sep 8 2017, 6:12 AM

Sep 5 2017

bkramer edited reviewers for D37474: [PCH] Allow VFS to be used for tests that generate PCH files, added: ilya-biryukov; removed: cfe-commits.
Sep 5 2017, 7:29 AM

Sep 4 2017

bkramer accepted D37435: Don't show deleted function (constructor) candidates for code completion.

lgtm

Sep 4 2017, 7:58 AM
bkramer added inline comments to D37435: Don't show deleted function (constructor) candidates for code completion.
Sep 4 2017, 7:10 AM

Aug 21 2017

bkramer accepted D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*.

lg

Aug 21 2017, 3:41 AM
bkramer accepted D36872: Fixed a crash on replaying Preamble's PP conditional stack..

This looks good to me.

Aug 21 2017, 3:20 AM

Aug 14 2017

bkramer accepted D36397: [clangd] Fixed a data race..

I think this can be committed now. It's still a bit awkward but we can address that later.

Aug 14 2017, 12:59 AM

Aug 9 2017

bkramer added a comment to D36458: Fix crash when current lexer is nullptr.

Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future.

Aug 9 2017, 5:04 AM

Aug 8 2017

bkramer added inline comments to D36390: Fix overloaded static functions in SemaCodeComplete.
Aug 8 2017, 7:00 AM
bkramer accepted D36330: Updated two annotations for Store.h and CodeGenFunction.h..

lg

Aug 8 2017, 6:45 AM
bkramer added a comment to D36458: Fix crash when current lexer is nullptr.

Test case?

Aug 8 2017, 4:41 AM
bkramer added a reviewer for D36458: Fix crash when current lexer is nullptr: erikjv.
Aug 8 2017, 4:41 AM

Aug 7 2017

bkramer added a comment to D36187: [clang-diff] Use the relative name for NamedDecls.

There's some similar code in tools/clang/lib/Tooling/Core/Lookup.cpp, it might make sense to share it. Otherwise this looks good.

Aug 7 2017, 6:47 AM
bkramer added inline comments to D36390: Fix overloaded static functions in SemaCodeComplete.
Aug 7 2017, 6:25 AM
bkramer added inline comments to D36330: Updated two annotations for Store.h and CodeGenFunction.h..
Aug 7 2017, 6:19 AM

Aug 3 2017

bkramer accepted D36302: [msan] Switch the pvalloc overflow test to a lit test.

lgtm

Aug 3 2017, 11:28 PM

Aug 2 2017

bkramer accepted D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration..

looks good

Aug 2 2017, 1:21 AM

Aug 1 2017

bkramer added inline comments to D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration..
Aug 1 2017, 9:10 AM
bkramer accepted D36133: [clangd] Rewrote AST and Preamble management..

ship it!

Aug 1 2017, 8:34 AM
bkramer added inline comments to D36133: [clangd] Rewrote AST and Preamble management..
Aug 1 2017, 3:21 AM

Jul 31 2017

bkramer accepted D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete..

lg (it could use a test case though)

Jul 31 2017, 10:00 AM

Jul 28 2017

bkramer accepted D27104: Unify and simplify the behavior of the hasDeclaration matcher..

lg under the precondition that clang-tidy tests still work.

Jul 28 2017, 4:19 AM

Jul 25 2017

bkramer accepted D35828: Fix incorrect use of current directory to find moved paths in ASTReader..

lg

Jul 25 2017, 3:12 AM

Jul 19 2017

bkramer accepted D35617: [clangd] Allow specifying -resource-dir.

Looks good.

Jul 19 2017, 7:48 AM · Restricted Project

Jul 10 2017

bkramer accepted D35203: Avoid white spaces in file names. NFC.

This is fine. We should fix phab though.

Jul 10 2017, 9:03 AM
bkramer accepted D35206: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC.

This is fine. We should fix phab though.

Jul 10 2017, 9:03 AM

Jun 30 2017

bkramer accepted D34882: Fix invalid warnings for header guards in preambles.

This fixes the issues I'm seeing.

Jun 30 2017, 8:54 AM
bkramer edited reviewers for D34304: Allow CompilerInvocations to generate .d files., added: klimek; removed: bkramer.
Jun 30 2017, 3:16 AM

Jun 6 2017

bkramer accepted D33930: Do not pick up by default the LLVM style if passing -format.

Looks good, but I'm wondering if we should also change the default in clang-apply-replacements itself.

Jun 6 2017, 5:29 AM

May 30 2017

bkramer accepted D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider..

lg

May 30 2017, 8:07 AM · Restricted Project

May 24 2017

bkramer accepted D33416: [clangd] Allow to use vfs::FileSystem for file accesses..

Looks good. Make sure to watch the windows buildbots after submitting.

May 24 2017, 5:48 AM

May 23 2017

bkramer added inline comments to D33416: [clangd] Allow to use vfs::FileSystem for file accesses..
May 23 2017, 2:45 AM
bkramer accepted D33397: Allow to use vfs::FileSystem for file accesses inside ASTUnit..

lg

May 23 2017, 2:28 AM

May 22 2017

bkramer accepted D33395: [clangd] Split clangd into library+executable (mainly for unit tests)..

looks good to me

May 22 2017, 9:27 AM · Restricted Project

May 19 2017

bkramer edited reviewers for D33045: [libclang] Avoid more stats than necessary for reparse., added: ilya-biryukov; removed: cfe-commits.
May 19 2017, 7:07 AM
bkramer accepted D33042: [libclang] Allow to suspend a translation unit..

This makes sense to me.

May 19 2017, 7:05 AM
bkramer accepted D33350: [clangd] Switch to incomplete translation units.

lg

May 19 2017, 3:05 AM

May 17 2017

bkramer accepted D33270: [Frontend] Remove unused TemporaryFiles.

Kill it :)

May 17 2017, 7:58 AM
bkramer accepted D33273: Recommit "[include-fixer] Don't throw exception when parsing unknown ar… …guments in vim script.".

looks good, thanks!

May 17 2017, 5:50 AM

May 15 2017

bkramer accepted D33047: [ClangD] Refactor clangd into separate components.

I believe this is good enough now.

May 15 2017, 6:43 AM · Restricted Project

May 12 2017

bkramer accepted D33103: [clang-tidy] TwineLocalCheck: add param # checking.

looks good, thanks!

May 12 2017, 1:19 AM · Restricted Project

Apr 28 2017

bkramer added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Can you please run clang-format on this change? There are pieces that don't follow the style.

Apr 28 2017, 2:45 AM
bkramer added a reviewer for D30946: [ScopePrinting] Added support to print full scopes of types and declarations.: rsmith.
Apr 28 2017, 2:44 AM

Apr 21 2017

bkramer added a comment to D32234: [Clangd] Support Authority-less URIs.

Still looking good. Will commit this soon.

Apr 21 2017, 8:52 AM · Restricted Project
bkramer added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

lg from my side. It would be good to wait until Manuel is back though, I think he had plans for extending this interface at some point.

Apr 21 2017, 8:43 AM
bkramer accepted D32238: [Clangd] Failed to decode params using 1.x-compatible request message.

lg

Apr 21 2017, 7:10 AM · Restricted Project

Apr 19 2017

bkramer accepted D32234: [Clangd] Support Authority-less URIs.

This is fine. Test case would be nice though.

Apr 19 2017, 12:59 PM · Restricted Project
bkramer added a comment to D32238: [Clangd] Failed to decode params using 1.x-compatible request message.

A test case would be nice.

Apr 19 2017, 12:59 PM · Restricted Project

Mar 30 2017

bkramer accepted D31328: [clangd] Add code completion support.

lg

Mar 30 2017, 6:17 AM

Mar 28 2017

bkramer accepted D27810: FileManager: mark virtual file entries as valid entries.

lg

Mar 28 2017, 2:23 AM

Mar 27 2017

bkramer accepted D30367: CodeGen : Check LLVM_ENABLE_DUMP definition for dumpMachineInstrRangeWithSlotIndex..

This is fine.

Mar 27 2017, 1:38 AM
bkramer accepted D30248: [libclang] Fix crash in member access code completion with implicit base.

Let's fix those crashes one at a time. This patch looks good, only minor comments below.

Mar 27 2017, 1:35 AM

Mar 24 2017

bkramer added inline comments to D31328: [clangd] Add code completion support.
Mar 24 2017, 7:01 AM

Mar 23 2017

bkramer accepted D31288: [libclang] Bury dead TemporaryFiles.

kill it with fire

Mar 23 2017, 9:18 AM

Mar 16 2017

bkramer added a comment to D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit.

libclang is supposed to be used for bindings to other languages (it's a pure C interface) and its stable. ASTUnit is the C++ side of libclang, libclang is just a thin wrapper around ASTUnit. ASTUnit itself suffers from lots of technical debt because clang changed since ASTUnit was created and ASTUnit was never refactored to accommodate that.

Mar 16 2017, 9:36 AM
bkramer resigned from D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit.

It's not. the goal is to get rid of ASTUnit inside of clangd in the long term as it's a big problem for extensibility. libclang is just a wrapper for ASTUnit, with even more problems.

Mar 16 2017, 3:52 AM

Mar 15 2017

bkramer accepted D30975: [msan] Relaex lit check in wcsncpy.cc.

lg

Mar 15 2017, 5:22 AM

Mar 14 2017

bkramer accepted D30675: [clangd] Fix not being able to attach a debugger on macOS.

lg, do you have commit access?

Mar 14 2017, 1:32 PM

Mar 13 2017

bkramer accepted D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly..

lg as a prototype.

Mar 13 2017, 9:00 AM

Mar 8 2017

bkramer accepted D30685: [include-fixer] Remove line number from Symbol identity.

lg

Mar 8 2017, 9:19 AM
bkramer added a comment to D30675: [clangd] Fix not being able to attach a debugger on macOS.

Generally makes sense. Is there any reason for the #ifdef? Windows has errno and EINTR too.

Mar 8 2017, 4:45 AM
bkramer added a comment to D27810: FileManager: mark virtual file entries as valid entries.

I assume this is fine but I don't really understand what's going on. A test case would be great.

Mar 8 2017, 3:29 AM

Mar 1 2017

bkramer updated the diff for D30498: [clangd] Add support for FixIts..
  • Use typedef instead of decltype()
  • Rename local variable not to shadow member.
  • Give FixIts their own mutex
  • Use const instead of let in typescript
Mar 1 2017, 8:07 AM
bkramer added a comment to D30367: CodeGen : Check LLVM_ENABLE_DUMP definition for dumpMachineInstrRangeWithSlotIndex..

This will get you an unused function warning if NDEBUG && LLVM_ENABLE_DUMP. You can use LLVM_DUMP_METHOD to avoid that.

Mar 1 2017, 7:39 AM
bkramer created D30498: [clangd] Add support for FixIts..
Mar 1 2017, 6:34 AM
bkramer accepted D30102: [clangd] Add a toy VS Code integration for development purposes.

lgtm

Mar 1 2017, 6:01 AM

Feb 27 2017

bkramer accepted D30425: [clangd] Make clangd install to bin.

lg

Feb 27 2017, 1:50 PM
bkramer accepted D30210: [include-fixer] Add usage count to find-all-symbols..

lg

Feb 27 2017, 1:46 PM
bkramer accepted D30399: clang-format: [JS] whitespace after async in arrow functions..

lg, but I don't really know JS ;)

Feb 27 2017, 2:34 AM

Feb 21 2017

bkramer created D30191: [clang-tidy] Reword the "code outside header guard" warning..
Feb 21 2017, 3:01 AM

Feb 16 2017

bkramer accepted D29990: [clangd] Implement format on type.

lg

Feb 16 2017, 2:26 AM

Feb 15 2017

bkramer added inline comments to D29990: [clangd] Implement format on type.
Feb 15 2017, 10:17 AM
bkramer updated the diff for D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
  • Inline the request struct again.
Feb 15 2017, 6:54 AM
bkramer updated the diff for D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
  • Do not lock while running DocumentStore callbacks
  • Replace fake queue with a real queue (but it still has at most one element.
Feb 15 2017, 6:37 AM