Page MenuHomePhabricator
People bkramer

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (558 w, 5 d)
Roles
Administrator

d0k

Recent Activity
View All

Yesterday

bkramer committed rG9c6b69000d93: [lldb] Move #include out of namespace lldb. NFC. (authored by bkramer).
[lldb] Move #include out of namespace lldb. NFC.
Sat, Mar 25, 5:37 AM · Restricted Project

Thu, Mar 23

bkramer accepted D146769: [NFC] Fix Windows builds that use MSVC 14.x.
Thu, Mar 23, 6:03 PM · Restricted Project, Restricted Project
bkramer committed rG8c7c1f11ffaa: Silence unused variable warning in NDEBUG builds (authored by bkramer).
Silence unused variable warning in NDEBUG builds
Thu, Mar 23, 6:42 AM · Restricted Project, Restricted Project

Mon, Mar 20

bkramer committed rGff48a2925fa3: modify dir of dep in OpenMPCommon (authored by yijia1212).
modify dir of dep in OpenMPCommon
Mon, Mar 20, 3:34 PM · Restricted Project
bkramer closed D146461: modify dir of dep in OpenMPCommon.
Mon, Mar 20, 3:34 PM · Restricted Project, Restricted Project

Thu, Mar 16

bkramer accepted D144787: [NFC][ADT] Tweaked some functions in StringRef.

looks good

Thu, Mar 16, 10:11 AM · Restricted Project, Restricted Project

Wed, Mar 1

bkramer accepted D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.

Using vector.gather for that case looks right to me.

Wed, Mar 1, 9:21 AM · Restricted Project, Restricted Project

Tue, Feb 28

bkramer added a comment to D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.
In D141998#4158912, @awarzynski wrote:

@bkramer , sorry about this issue and thanks for reverting!

In D141998#4158076, @bkramer wrote:

is the test case above enough to see what's going wrong?

Yes! Thanks for sending this :) I think that I know what the problem is and will send a fix tomorrow (I've been traveling today and only just got back, so need a break). Just to double check - the 1st tensor.extract is a contiguous load, the 2nd is a gather. Correct?

Tue, Feb 28, 10:26 AM · Restricted Project, Restricted Project
bkramer added a comment to D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.

Reverted this in e28bbfea5d482c1825b1799c57aedff4e0116619, is the test case above enough to see what's going wrong?

Tue, Feb 28, 4:33 AM · Restricted Project, Restricted Project
bkramer committed rGe28bbfea5d48: Revert "[mlir][linalg] Vectorize tensor.extract using contiguous loads" (authored by bkramer).
Revert "[mlir][linalg] Vectorize tensor.extract using contiguous loads"
Tue, Feb 28, 4:33 AM · Restricted Project, Restricted Project
bkramer added a reverting change for rG89b144ece330: [mlir][linalg] Vectorize tensor.extract using contiguous loads: rGe28bbfea5d48: Revert "[mlir][linalg] Vectorize tensor.extract using contiguous loads".
Tue, Feb 28, 4:33 AM · Restricted Project, Restricted Project
bkramer added a reverting change for D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads: rGe28bbfea5d48: Revert "[mlir][linalg] Vectorize tensor.extract using contiguous loads".
Tue, Feb 28, 4:33 AM · Restricted Project, Restricted Project

Mon, Feb 27

bkramer accepted D144868: [mlir] Insert tensor.cast only when needed when folding tensor.cast into extract_slice..

Thanks

Mon, Feb 27, 6:03 AM · Restricted Project, Restricted Project
bkramer added a comment to D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.

With this change I'm seeing vectorization of

Mon, Feb 27, 4:29 AM · Restricted Project, Restricted Project

Feb 22 2023

bkramer accepted D144561: [mlir] Add missing patterns for lowering to Libm..

thanks

Feb 22 2023, 6:48 AM · Restricted Project, Restricted Project

Feb 21 2023

bkramer committed rG451799bb8261: [IRMover] Remove UB implying parameter attributes when necessary (authored by TimNN).
[IRMover] Remove UB implying parameter attributes when necessary
Feb 21 2023, 9:43 AM · Restricted Project, Restricted Project
bkramer closed D139209: [IRMover] Remove UB implying parameter attributes when necessary.
Feb 21 2023, 9:43 AM · Restricted Project, Restricted Project

Feb 19 2023

bkramer committed rG37f5c598a22a: [lldb] Add missing wasm switch case (authored by bkramer).
[lldb] Add missing wasm switch case
Feb 19 2023, 1:55 AM · Restricted Project

Feb 18 2023

bkramer committed rG7ac658a07b9a: [WebAssembly] assert(false) -> llvm_unreachable (authored by bkramer).
[WebAssembly] assert(false) -> llvm_unreachable
Feb 18 2023, 12:41 AM · Restricted Project, Restricted Project

Feb 17 2023

bkramer committed rGda3623de2411: [JT] Always create BPI/BFI when running in legacy PM (authored by bkramer).
[JT] Always create BPI/BFI when running in legacy PM
Feb 17 2023, 1:18 AM · Restricted Project, Restricted Project

Feb 15 2023

bkramer committed rG1f818f63b829: [clang-format] assert(false) -> llvm_unreachable (authored by bkramer).
[clang-format] assert(false) -> llvm_unreachable
Feb 15 2023, 5:12 AM · Restricted Project, Restricted Project
bkramer committed rG7d9cf97f80f0: [bazel][mlir][examples] Add missing dependency for… (authored by bkramer).
[bazel][mlir][examples] Add missing dependency for…
Feb 15 2023, 1:35 AM · Restricted Project

Feb 13 2023

bkramer committed rGbe7d7ca11018: [lldb] Use portable format string PRIx64 (authored by bkramer).
[lldb] Use portable format string PRIx64
Feb 13 2023, 1:52 PM · Restricted Project

Feb 12 2023

bkramer committed rGc697119dafce: [bazel][libc] Add a few more missing dependency that show up when parsing… (authored by bkramer).
[bazel][libc] Add a few more missing dependency that show up when parsing…
Feb 12 2023, 4:12 AM · Restricted Project

Feb 10 2023

bkramer committed rG185dbf9d6f00: [bazel] Port 81a79ee446 (authored by bkramer).
[bazel] Port 81a79ee446
Feb 10 2023, 10:03 AM · Restricted Project
bkramer committed rG09c52a49402c: [bazel] Add missing dependency after 687f78210d0 (authored by bkramer).
[bazel] Add missing dependency after 687f78210d0
Feb 10 2023, 1:23 AM · Restricted Project

Feb 9 2023

bkramer committed rGc7c910caee09: [bazel] Port 499abb243c (authored by bkramer).
[bazel] Port 499abb243c
Feb 9 2023, 12:36 PM · Restricted Project

Feb 8 2023

bkramer committed rG938fdfc40f7e: [bazel] Actually put Importer in the right library (authored by bkramer).
[bazel] Actually put Importer in the right library
Feb 8 2023, 4:09 AM · Restricted Project
bkramer committed rGa81136c332cd: [bazel] Port b83caa32dc (authored by bkramer).
[bazel] Port b83caa32dc
Feb 8 2023, 4:06 AM · Restricted Project
bkramer committed rG72eac42f21c0: [xxHash] Don't trigger UB on empty StringRef (authored by bkramer).
[xxHash] Don't trigger UB on empty StringRef
Feb 8 2023, 3:56 AM · Restricted Project, Restricted Project

Feb 3 2023

bkramer committed rGf42e1a748479: Fix tsan problem where the per-thread shared_ptr() can be locked right before… (authored by pschuh).
Fix tsan problem where the per-thread shared_ptr() can be locked right before…
Feb 3 2023, 3:02 PM · Restricted Project, Restricted Project
bkramer closed D143294: Fix tsan problem where the per-thread shared_ptr() can be locked right before the cache is destroyed causing a race where it tries to remove an entry from a destroyed cache..
Feb 3 2023, 3:01 PM · Restricted Project, Restricted Project

Feb 1 2023

bkramer committed rGda6e9ef4cea9: [InstCombine][NFC] Fold variable into assert (authored by bkramer).
[InstCombine][NFC] Fold variable into assert
Feb 1 2023, 3:05 AM · Restricted Project, Restricted Project

Jan 31 2023

bkramer committed rGffc9b80c35bc: [clang-format] Fix use after free in FormatTokenSource test (authored by bkramer).
[clang-format] Fix use after free in FormatTokenSource test
Jan 31 2023, 12:05 PM · Restricted Project, Restricted Project
bkramer committed rGd8982f72282b: [AST] assert(false) -> llvm_unreachable (authored by bkramer).
[AST] assert(false) -> llvm_unreachable
Jan 31 2023, 9:58 AM · Restricted Project, Restricted Project
bkramer committed rG669f4bc558b7: [mlir][SubElements] Disambiguate cast<> call for MSVC (authored by bkramer).
[mlir][SubElements] Disambiguate cast<> call for MSVC
Jan 31 2023, 7:55 AM · Restricted Project, Restricted Project

Jan 30 2023

bkramer committed rGd502e0fbf933: [bazel] Port 155e0cf5dc2f (authored by bkramer).
[bazel] Port 155e0cf5dc2f
Jan 30 2023, 2:02 PM · Restricted Project

Jan 28 2023

bkramer committed rG0f0d8f5092b3: [bazel] Adjust lsp-server-support include paths for 305d71853965 (authored by bkramer).
[bazel] Adjust lsp-server-support include paths for 305d71853965
Jan 28 2023, 2:07 AM · Restricted Project
bkramer committed rG84fb0adaeed4: [bazel] Add a dep from target asm parsers to :TargetParser (authored by bkramer).
[bazel] Add a dep from target asm parsers to :TargetParser
Jan 28 2023, 2:07 AM · Restricted Project
bkramer committed rG0a1f30cc772c: [bazel][mlir] Remove references to SubElementInterfaces. (authored by wecing).
[bazel][mlir] Remove references to SubElementInterfaces.
Jan 28 2023, 1:59 AM · Restricted Project
bkramer closed D142789: [bazel][mlir] Remove references to SubElementInterfaces..
Jan 28 2023, 1:59 AM · Restricted Project, Restricted Project
bkramer accepted D142789: [bazel][mlir] Remove references to SubElementInterfaces..
Jan 28 2023, 1:58 AM · Restricted Project, Restricted Project

Jan 27 2023

bkramer committed rGbcc10817d556: Fix tsan problem where the per-thread shared_ptr() can be locked right before… (authored by zhangqiaorjc).
Fix tsan problem where the per-thread shared_ptr() can be locked right before…
Jan 27 2023, 9:57 AM · Restricted Project, Restricted Project
bkramer closed D142394: Fix tsan problem where the per-thread shared_ptr() can be locked right before the cache is destroyed causing a race where it tries to remove an entry from a destroyed cache..
Jan 27 2023, 9:57 AM · Restricted Project, Restricted Project

Jan 26 2023

bkramer committed rGf617c6cc91c0: [bazel] Add missing dependency after 55cf0de35e (authored by bkramer).
[bazel] Add missing dependency after 55cf0de35e
Jan 26 2023, 2:25 PM · Restricted Project
bkramer committed rG77f4c91c5e05: [mlir][vector] Allow transposing multi_reduction when the parallel dim is in… (authored by bkramer).
[mlir][vector] Allow transposing multi_reduction when the parallel dim is in…
Jan 26 2023, 9:07 AM · Restricted Project, Restricted Project
bkramer closed D142483: [mlir][vector] Allow transposing multi_reduction when the parallel dim is in the middle.
Jan 26 2023, 9:06 AM · Restricted Project, Restricted Project
bkramer updated the diff for D142483: [mlir][vector] Allow transposing multi_reduction when the parallel dim is in the middle.
  • Address review comments
  • Add a test to make sure the inner reduction strategy still works
Jan 26 2023, 4:46 AM · Restricted Project, Restricted Project

Jan 25 2023

bkramer committed rG68de221f89d5: [bazel] Port efbc8bb18e (authored by bkramer).
[bazel] Port efbc8bb18e
Jan 25 2023, 4:50 PM · Restricted Project
bkramer committed rG35ca64989a75: [mlir][arith] Don't crash when folding a & ~a -> 0 on vectors (authored by bkramer).
[mlir][arith] Don't crash when folding a & ~a -> 0 on vectors
Jan 25 2023, 5:09 AM · Restricted Project, Restricted Project

Jan 24 2023

bkramer committed rG388b8c16c561: [ADT] Use fold expressions to compare tuples. NFCI (authored by bkramer).
[ADT] Use fold expressions to compare tuples. NFCI
Jan 24 2023, 4:42 PM · Restricted Project, Restricted Project
bkramer committed rG7557b83aa543: [BOLT] Use range-based implicit def/use accessors. NFCI (authored by bkramer).
[BOLT] Use range-based implicit def/use accessors. NFCI
Jan 24 2023, 2:14 PM · Restricted Project
bkramer requested review of D142483: [mlir][vector] Allow transposing multi_reduction when the parallel dim is in the middle.
Jan 24 2023, 9:03 AM · Restricted Project, Restricted Project
bkramer added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..
In D141804#4066843, @ThomasRaoux wrote:
In D141804#4066465, @pifon2a wrote:

For instance developers often store models/IR in linalg format to be able to work in isolation of the front end. Those kind of changes forces them to regenerate models.

I think this is the only valid argument against landing this PR in this whole thread.

I am also curious why linalg was used as a storage format. Are there many clients/models that use it instead of higher level dialects?

My understanding is that it allows to keep a representation of the model independently on importers/front ends.

Adding few people who had problems in the past with breaking linalg changes so that they can weight in and give more details on why having a more stable linalg representation would help:
@Benoit @harsh @powderluv

Jan 24 2023, 4:42 AM · Restricted Project, Restricted Project

Jan 22 2023

bkramer committed rG22f653144949: [bazel] Add missing dependencies for 4f1e244eb5 (authored by bkramer).
[bazel] Add missing dependencies for 4f1e244eb5
Jan 22 2023, 1:59 AM · Restricted Project

Jan 20 2023

bkramer committed rG593fb61838ac: [bazel] Fix up dependency (authored by bkramer).
[bazel] Fix up dependency
Jan 20 2023, 12:59 PM · Restricted Project
bkramer added a reverting change for rG9ef7ae507387: Revert "[MLIR] Update bazel build file after…: rGae4c9285914f: Revert "Revert "[MLIR] Update bazel build file after….
Jan 20 2023, 12:57 PM · Restricted Project
bkramer committed rGae4c9285914f: Revert "Revert "[MLIR] Update bazel build file after… (authored by bkramer).
Revert "Revert "[MLIR] Update bazel build file after…
Jan 20 2023, 12:57 PM · Restricted Project
bkramer committed rGf929def09dd7: [bazel] Remove some unused dependencies (authored by bkramer).
[bazel] Remove some unused dependencies
Jan 20 2023, 11:44 AM · Restricted Project
bkramer committed rGe9b36992b362: [bazel] Add missing dependency after 16f8d17f7b (authored by bkramer).
[bazel] Add missing dependency after 16f8d17f7b
Jan 20 2023, 11:41 AM · Restricted Project
bkramer committed rGfcd505d040cc: [arith] Allow integer casts of 0-D vectors (authored by bkramer).
[arith] Allow integer casts of 0-D vectors
Jan 20 2023, 6:22 AM · Restricted Project, Restricted Project
bkramer closed D142137: [arith] Allow integer casts of 0-D vectors.
Jan 20 2023, 6:22 AM · Restricted Project, Restricted Project
bkramer committed rG044ed6e09f49: [bazel] Add missing dependencies for 790f237012 (authored by bkramer).
[bazel] Add missing dependencies for 790f237012
Jan 20 2023, 2:06 AM · Restricted Project

Jan 19 2023

bkramer committed rGd5cbaa047004: [Linalg] Don't create complex vectors when vectorizing copies (authored by bkramer).
[Linalg] Don't create complex vectors when vectorizing copies
Jan 19 2023, 3:37 PM · Restricted Project, Restricted Project
bkramer closed D142131: [Linalg] Don't create complex vectors when vectorizing copies.
Jan 19 2023, 3:36 PM · Restricted Project, Restricted Project
bkramer requested review of D142137: [arith] Allow integer casts of 0-D vectors.
Jan 19 2023, 9:46 AM · Restricted Project, Restricted Project
bkramer requested review of D142131: [Linalg] Don't create complex vectors when vectorizing copies.
Jan 19 2023, 9:01 AM · Restricted Project, Restricted Project

Jan 18 2023

bkramer committed rGcb5440104ada: [bazel] Fix build after c33b9395b1 (authored by bkramer).
[bazel] Fix build after c33b9395b1
Jan 18 2023, 4:32 AM · Restricted Project

Jan 16 2023

bkramer added a reverting change for rG931d04be2fc8: [ADT] Make StringRef::compare like std::string_view::compare: rG1e67d775da7c: Partially revert 931d04be2fc8.
Jan 16 2023, 1:40 AM · Restricted Project, Restricted Project, Restricted Project
bkramer committed rG1e67d775da7c: Partially revert 931d04be2fc8 (authored by bkramer).
Partially revert 931d04be2fc8
Jan 16 2023, 1:40 AM · Restricted Project, Restricted Project

Jan 15 2023

bkramer committed rGdb6961db7a0d: [FuncitonComparator] Clamp StringRef compare output to [-1,1] (authored by bkramer).
[FuncitonComparator] Clamp StringRef compare output to [-1,1]
Jan 15 2023, 4:47 PM · Restricted Project, Restricted Project
bkramer committed rG8959968b7225: [lldb] Unbreak test after 931d04be2fc8f3f0505b43e64297f75d526cb42a (authored by bkramer).
[lldb] Unbreak test after 931d04be2fc8f3f0505b43e64297f75d526cb42a
Jan 15 2023, 12:42 PM · Restricted Project
bkramer committed rG2f851f26ead0: [ADT] Forward some StringRef::find overloads to std::string_view (authored by bkramer).
[ADT] Forward some StringRef::find overloads to std::string_view
Jan 15 2023, 12:23 PM · Restricted Project, Restricted Project
bkramer committed rG931d04be2fc8: [ADT] Make StringRef::compare like std::string_view::compare (authored by bkramer).
[ADT] Make StringRef::compare like std::string_view::compare
Jan 15 2023, 12:10 PM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

bkramer committed rGd647578726c8: [thread] Fix a FIXME with std::apply. NFCI (authored by bkramer).
[thread] Fix a FIXME with std::apply. NFCI
Jan 13 2023, 9:27 AM · Restricted Project, Restricted Project
bkramer added a comment to D133574: [C2x] reject type definitions in offsetof.

GitHub finds around 1.9k instances of this pattern to compute alignof. There's a lot of duplicates and #ifdefs so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no _Alignof in C99 so for many of those projects there is no easy fix.

Jan 13 2023, 8:11 AM · Restricted Project, Restricted Project
bkramer committed rGc98768f3fff0: [HashBuilder] Simplify with C++17. NFCI (authored by bkramer).
[HashBuilder] Simplify with C++17. NFCI
Jan 13 2023, 7:32 AM · Restricted Project, Restricted Project
bkramer committed rG18b0d2c5d976: [analyzer] Fix a FIXME. NFCI (authored by bkramer).
[analyzer] Fix a FIXME. NFCI
Jan 13 2023, 7:16 AM · Restricted Project, Restricted Project

Jan 10 2023

bkramer accepted D141421: Fix math.cbrt with vector and f16 arguments..

looks good

Jan 10 2023, 12:16 PM · Restricted Project, Restricted Project

Jan 9 2023

bkramer committed rG38c481ddcbd9: [GVN] Fold variable into assert. NFC (authored by bkramer).
[GVN] Fold variable into assert. NFC
Jan 9 2023, 3:41 PM · Restricted Project, Restricted Project

Jan 8 2023

bkramer committed rG91487b248195: [X86][Disassembler][NFCI] Read bytes with support::endian::read (authored by bkramer).
[X86][Disassembler][NFCI] Read bytes with support::endian::read
Jan 8 2023, 9:26 AM · Restricted Project, Restricted Project
bkramer committed rGe68fc86b22fd: [NFCI][Offload Bundler] Replace hand-rolled endian conversion with llvm::support (authored by bkramer).
[NFCI][Offload Bundler] Replace hand-rolled endian conversion with llvm::support
Jan 8 2023, 8:38 AM · Restricted Project, Restricted Project
bkramer committed rGb6942a2880c5: [NFC] Hide implementation details in anonymous namespaces (authored by bkramer).
[NFC] Hide implementation details in anonymous namespaces
Jan 8 2023, 8:38 AM · Restricted Project, Restricted Project, Restricted Project

Jan 6 2023

bkramer committed rG943d8644dfc0: [bazel] Add missing :Support dependency after 1b8224537070 (authored by bkramer).
[bazel] Add missing :Support dependency after 1b8224537070
Jan 6 2023, 3:52 AM · Restricted Project

Dec 30 2022

bkramer committed rGe6329388c39d: [Sema] Avoid double hash lookup. NFCI (authored by bkramer).
[Sema] Avoid double hash lookup. NFCI
Dec 30 2022, 10:27 AM · Restricted Project, Restricted Project
bkramer committed rG07e7168048b1: [AArch64] Stringref'ize AArch64Subtarget constructor. NFCI (authored by bkramer).
[AArch64] Stringref'ize AArch64Subtarget constructor. NFCI
Dec 30 2022, 9:05 AM · Restricted Project, Restricted Project

Dec 29 2022

bkramer committed rGa3d58bbaff92: Detemplate llvm::EmitGEPOffset and move it into a cpp file. NFC. (authored by bkramer).
Detemplate llvm::EmitGEPOffset and move it into a cpp file. NFC.
Dec 29 2022, 7:25 AM · Restricted Project, Restricted Project

Dec 20 2022

bkramer added a reverting change for rG5d65f8a7931c: [Bazel] Remove define HAVE_LSEEK64 to match cmake config.: rG9f6f9488dd05: Revert "[Bazel] Remove define HAVE_LSEEK64 to match cmake config.".
Dec 20 2022, 11:34 AM · Restricted Project
bkramer committed rG9f6f9488dd05: Revert "[Bazel] Remove define HAVE_LSEEK64 to match cmake config." (authored by bkramer).
Revert "[Bazel] Remove define HAVE_LSEEK64 to match cmake config."
Dec 20 2022, 11:34 AM · Restricted Project

Dec 19 2022

bkramer committed rG2916b9918275: [ADT] Alias llvm::Optional to std::optional (authored by bkramer).
[ADT] Alias llvm::Optional to std::optional
Dec 19 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
bkramer committed rG854c10f8d185: [Clang] Prepare for llvm::Optional becoming std::optional. (authored by bkramer).
[Clang] Prepare for llvm::Optional becoming std::optional.
Dec 19 2022, 3:49 PM · Restricted Project, Restricted Project, Restricted Project
bkramer closed D140332: [ADT] Alias llvm::Optional to std::optional.
Dec 19 2022, 3:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
bkramer updated the diff for D140332: [ADT] Alias llvm::Optional to std::optional.

Rebase

Dec 19 2022, 2:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
bkramer added a comment to D140332: [ADT] Alias llvm::Optional to std::optional.
In D140332#4005988, @MaskRay wrote:

Can you push using OptionalFileEntryRef = CustomizableOptional<FileEntryRef>; and the renaming as a separate commit to make this patch smaller?
There is a smaller that this rename may be reverted.
205c0589f918f95d2f2c586a01bea2716d73d603 reverted a change related to OptionalFileEntryRef. I assume that your change is fine.

Dec 19 2022, 2:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
bkramer added inline comments to D140332: [ADT] Alias llvm::Optional to std::optional.
Dec 19 2022, 2:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
bkramer committed rGa1a72b9d6d23: Drop unused forward declarations of llvm::Optional. NFC. (authored by bkramer).
Drop unused forward declarations of llvm::Optional. NFC.
Dec 19 2022, 2:43 PM · Restricted Project, Restricted Project
bkramer committed rG2233c4dc706f: [mlir] Add operator!= to WalkResult, for completeness. (authored by bkramer).
[mlir] Add operator!= to WalkResult, for completeness.
Dec 19 2022, 2:43 PM · Restricted Project, Restricted Project
bkramer committed rG30199d11d274: [mlir] Drop Optional::value() references from tblgen files (authored by bkramer).
[mlir] Drop Optional::value() references from tblgen files
Dec 19 2022, 1:58 PM · Restricted Project, Restricted Project
bkramer committed rGa7cb02d9a80f: [mlir][AMDGPU] Make header build standalone. NFC. (authored by bkramer).
[mlir][AMDGPU] Make header build standalone. NFC.
Dec 19 2022, 12:11 PM · Restricted Project, Restricted Project
bkramer requested review of D140332: [ADT] Alias llvm::Optional to std::optional.
Dec 19 2022, 11:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project