bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (314 w, 2 d)

d0k

Recent Activity

Yesterday

bkramer added a comment to rL337262: [llvm-objcopy] Run not with any python, but the python configured in lit..

Thanks, this is only the 2nd time this has happened to me. Will fix :)

Wed, Jul 18, 9:20 AM
bkramer requested changes to D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2.
Wed, Jul 18, 8:05 AM
bkramer accepted D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2.
Wed, Jul 18, 8:02 AM
bkramer accepted D49302: [AST] Various micro-optimizations in CXXInheritance.

cool

Wed, Jul 18, 7:55 AM · Restricted Project
bkramer accepted D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result..

lg

Wed, Jul 18, 7:53 AM

Mon, Jul 16

bkramer accepted D49378: [x86/SLH] Completely rework how we sink post-load hardening past data invariant instructions to be both more correct and much more powerful..

This is fine, it's just that listing all of the instructions gives me a really bad feeling.

Mon, Jul 16, 7:53 AM

Thu, Jul 5

bkramer accepted D48962: Partially revert r336268 in address-offsets.ll.

sad

Thu, Jul 5, 4:33 AM

Fri, Jun 22

bkramer added a comment to rC335330: [hmaptool] Turn %hmaptool into a proper substitution.

@bkramer, this breaks the tests when the path to python contains spaces (which is why in the original change %python is surrounded by quotes). For example:

Command Output (stdout):
 --
$ ":" "RUN: at line 1"
$ "rm" "-f" "C:\agent1\_work\2\b\LLVMBuild\tools\clang\test\Preprocessor\Output\headermap-rel2.c.tmp.hmap"
$ ":" "RUN: at line 2"
$ "C:/Program" "Files" "(x86)/Microsoft" "Visual" "Studio/Shared/Python36_64/python.exe" "C:/agent1/_work/2/b/LLVMBuild/Release/bin\hmaptool" "write" "C:\agent1\_work\2\s\llvm\tools\clang\test\Preprocessor/Inputs/headermap-rel2/project-headers.hmap.json" "C:\agent1\_work\2\b\LLVMBuild\tools\clang\test\Preprocessor\Output\headermap-rel2.c.tmp.hmap"
# command stderr:
'C:/Program': command not found

You probably should add quotes around the python path in lit.cfg.py when you do the substitution. I can look into this on Monday if you don't have time to fix it beforehand.

Fri, Jun 22, 1:08 PM

Wed, Jun 20

bkramer added inline comments to D48392: [Dominators] Simplify child lists and make them deterministic.
Wed, Jun 20, 2:08 PM
bkramer updated the diff for D48392: [Dominators] Simplify child lists and make them deterministic.

Address comments.

Wed, Jun 20, 2:06 PM
bkramer added a comment to D48392: [Dominators] Simplify child lists and make them deterministic.

I always prefer deterministic execution (all other things being equal). Have you done any testing of performance impact to this change? The adding and erasing of Dominator elements may cost more with how the SmallVector type performs the operations.

Otherwise I think the patch looks good. However, @kuhar is the Dominator expert here and I'd recommend waiting for him to speak up before committing.

I didn't manage to get the 240 MB IR file reduced enough, triggering this bug requires a lot of jump threading, so landing this without a test case.

Did you try bugpoint? a 240MB IR fire is indeed huge but maybe letting it run over night can help reduce the problem space. Non-deterministic errors like these are very difficult to narrow down though.

Wed, Jun 20, 1:44 PM
bkramer created D48392: [Dominators] Simplify child lists and make them deterministic.
Wed, Jun 20, 1:11 PM

Jun 18 2018

bkramer accepted D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

I think this is fine to go in. It's not the most pretty API, but not really more unsafe than what's already there.

Jun 18 2018, 2:54 AM

Jun 11 2018

bkramer added inline comments to D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 4:29 AM

Jun 7 2018

bkramer added a reviewer for D47864: [python] Fix most Python binding unittests on Windows: jbcoe.
Jun 7 2018, 6:49 AM
bkramer added a reviewer for D47864: [python] Fix most Python binding unittests on Windows: wanders.
Jun 7 2018, 6:48 AM
bkramer accepted D47864: [python] Fix most Python binding unittests on Windows.

I don't know much about the python bindings, but this is probably fine.

Jun 7 2018, 6:48 AM

May 24 2018

bkramer accepted D47262: [VFS] Implement getRealPath in InMemoryFileSystem..

lg

May 24 2018, 3:11 AM

May 22 2018

bkramer added a comment to D47214: [InstCombine] Replace bcmp/bcopy with memcmp/memmove.

why?

May 22 2018, 1:50 PM
bkramer accepted D47059: [InstCombine] Calloc-ed strings optimizations.

lg

May 22 2018, 6:32 AM

May 21 2018

bkramer added inline comments to D47059: [InstCombine] Calloc-ed strings optimizations.
May 21 2018, 3:43 AM
bkramer added inline comments to D47059: [InstCombine] Calloc-ed strings optimizations.
May 21 2018, 3:04 AM

May 18 2018

bkramer accepted D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS.

lg

May 18 2018, 9:08 AM
bkramer added a comment to D47059: [InstCombine] Calloc-ed strings optimizations.

This looks overly specific. Can you teach GetStringLength about this instead? All of the transformations should already work if GetStringLength returns a length of zero.

May 18 2018, 6:26 AM
bkramer accepted D47060: [VFS] Implement getRealPath for OverlayFileSystem..

lg

May 18 2018, 6:05 AM

May 17 2018

bkramer accepted D46942: Add vfs::FileSystem::getRealPath.

Looks good. Please watch the windows buildbots carefully after landing this.

May 17 2018, 2:45 AM

May 9 2018

bkramer updated the diff for D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.

Add a FIXME for using the demanded mask of the udiv result.

May 9 2018, 2:42 PM
bkramer added inline comments to D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.
May 9 2018, 11:28 AM
bkramer created D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.
May 9 2018, 10:17 AM
bkramer accepted D46285: [InstCombine] snprintf optimizations.

lg

May 9 2018, 9:10 AM

Apr 28 2018

bkramer added a comment to D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..

Would it be possible to get rid of the flag entirely and make this controlled only by the data layout? That's defined on the module level.

Apr 28 2018, 2:09 AM

Apr 27 2018

bkramer accepted D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..

lgtm

Apr 27 2018, 2:01 PM
bkramer accepted D46148: [CUDA] Added -f[no-]cuda-short-ptr option.

lgtm

Apr 27 2018, 2:01 PM
bkramer added inline comments to D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..
Apr 27 2018, 2:11 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 27 2018, 1:54 AM

Apr 26 2018

bkramer updated the diff for D46130: [NVPTX] Turn on Loop/SLP vectorization.

Extend getNumberOfRegisters comment.

Apr 26 2018, 11:45 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 11:26 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 10:52 AM
bkramer created D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 9:19 AM
bkramer created D46116: [NVPTX] Make the legalizer expand shufflevector of <2 x half>.
Apr 26 2018, 5:41 AM

Apr 24 2018

bkramer added a comment to D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..

Would it be difficult to preserve the invariant if both loads are?

Apr 24 2018, 7:50 AM
bkramer updated the diff for D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..

Improve test by checking that the merged store is not marked as invariant.

Apr 24 2018, 7:43 AM
bkramer created D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..
Apr 24 2018, 7:11 AM

Apr 14 2018

bkramer added reviewers for D45653: Enable sibling-call optimization for functions returning structs: craig.topper, RKSimon.
Apr 14 2018, 7:43 AM
bkramer accepted D45606: NFC: Move ObjectMemoryBuffer to support.

doing it later is fine with me.

Apr 14 2018, 2:44 AM

Apr 13 2018

bkramer added a comment to D45606: NFC: Move ObjectMemoryBuffer to support.

Thanks! I wonder if we can come up with a better name than ObjectMemoryBuffer though. Maybe SmallVectorMemoryBuffer?

Apr 13 2018, 5:42 AM
bkramer accepted D45603: Fix evaluation of `__has_include_next` during -frewrite-includes..

lg

Apr 13 2018, 5:42 AM
bkramer accepted D45545: [profile] Fix binary format reader error propagation..

lg

Apr 13 2018, 5:41 AM

Apr 4 2018

bkramer accepted D44855: [ARM] Change std::sort to llvm::sort in response to r327219.

this is trivially fine.

Apr 4 2018, 7:42 AM
bkramer accepted D45140: [Support] Change std::sort to llvm::sort in response to r327219.

this is trivially fine.

Apr 4 2018, 7:42 AM
bkramer accepted D44769: [Analysis] Support aligned new/delete functions..

lg

Apr 4 2018, 7:40 AM

Mar 22 2018

bkramer accepted D44807: Revert "Revert "[InstrProf] Support for external functions in text format."".

lg, thanks!

Mar 22 2018, 2:27 PM

Mar 20 2018

bkramer accepted D44695: [clang-format] Partially revert r322749, replacing array with DenseSet.

I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format.

Mar 20 2018, 11:38 AM

Mar 14 2018

bkramer added a comment to D23130: [Clang-tidy] Add a check for definitions in the global namespace..

I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review.

Mar 14 2018, 9:17 AM

Mar 6 2018

bkramer added a comment to D44175: Add std:: to begin and end in drop_begin.

What we probably need is some kind of adl_begin/adl_end functions that wrap up this functionality for easy reuse throughout our STL helpers/wrapper/etc. Though I haven't given a lot of thought to how easy/hard that'd be to implement :/

Mar 6 2018, 2:14 PM

Feb 21 2018

bkramer accepted D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration..

lg

Feb 21 2018, 5:09 AM

Feb 19 2018

bkramer accepted D43473: [mem2reg] Use range loops (NFCI).

lg

Feb 19 2018, 10:42 AM
bkramer added a comment to D43473: [mem2reg] Use range loops (NFCI).

Looks like all of these could be written as for-range loops for (User *U : Foo->users()) now.

Feb 19 2018, 10:08 AM

Feb 16 2018

bkramer accepted D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable.

lg

Feb 16 2018, 6:55 AM

Feb 6 2018

bkramer added inline comments to D42946: Verify profile data confirms large loop trip counts..
Feb 6 2018, 10:10 AM
bkramer added inline comments to D42946: Verify profile data confirms large loop trip counts..
Feb 6 2018, 9:44 AM
bkramer added inline comments to D42946: Verify profile data confirms large loop trip counts..
Feb 6 2018, 5:01 AM

Feb 5 2018

bkramer accepted D42907: BitTracker.h needs a full definition of MachineInstr, so include the defining file..

lg. Do you have commit access?

Feb 5 2018, 7:06 AM

Feb 2 2018

bkramer accepted D42361: [Tooling] Returns non-zero status code when files are skipped..

Removing FIXME seems right to me.

Feb 2 2018, 9:02 AM

Feb 1 2018

bkramer accepted D42810: [Sema] Add implicit members even for invalid CXXRecordDecls.

lg

Feb 1 2018, 12:43 PM
bkramer added inline comments to D42361: [Tooling] Returns non-zero status code when files are skipped..
Feb 1 2018, 5:28 AM

Jan 29 2018

bkramer accepted D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch..
Jan 29 2018, 5:17 AM

Jan 24 2018

bkramer added a comment to D42507: Fix -fmodules build after rL323277.

I went a slightly different route in rL323383, but this would've worked too. The layering between CodeGen and TableGen is messy, we'll have to clean that up eventually :(

Jan 24 2018, 3:07 PM

Jan 22 2018

bkramer accepted D42241: [CodeComplete] Fix completion in the middle of idents in macro calls.

I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases.

Jan 22 2018, 6:57 AM
bkramer added inline comments to D42361: [Tooling] Returns non-zero status code when files are skipped..
Jan 22 2018, 4:34 AM

Jan 19 2018

bkramer accepted D42298: [clang-format] Fix shortening blocks in macros causing merged next line.

lgtm

Jan 19 2018, 6:43 AM

Jan 18 2018

bkramer accepted D42187: [clang-format] Adds a canonical delimiter to raw string formatting.

lg

Jan 18 2018, 10:35 AM

Jan 17 2018

bkramer accepted D42189: [clang-format] Replace unordered_set with an array.

lgtm

Jan 17 2018, 11:52 AM
bkramer added inline comments to D42189: [clang-format] Replace unordered_set with an array.
Jan 17 2018, 10:54 AM
bkramer requested changes to D42185: [ASTMatcher] Add isScoped matcher for enumDecl..

dump_ast_matchers.py should be working again now.

Jan 17 2018, 8:52 AM
bkramer accepted D42185: [ASTMatcher] Add isScoped matcher for enumDecl..

lg

Jan 17 2018, 8:15 AM
bkramer accepted D42167: [clang-format] adds enclosing function detection to raw string formatting.

lgtm

Jan 17 2018, 7:35 AM
bkramer added inline comments to D42174: [clangd] Refactored threading in ClangdServer.
Jan 17 2018, 7:32 AM
bkramer added inline comments to D42167: [clang-format] adds enclosing function detection to raw string formatting.
Jan 17 2018, 6:26 AM
bkramer accepted D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor..

lg

Jan 17 2018, 6:18 AM
bkramer accepted D41788: [DeclPrinter] Fix two cases that crash clang -ast-print..

This should be fine.

Jan 17 2018, 3:10 AM

Jan 16 2018

bkramer accepted D42098: [clang-format] Reorganize RawStringFormat based on language.

lg

Jan 16 2018, 7:31 AM
bkramer added inline comments to D41991: [clangd] Always use preamble (even stale) for code completion.
Jan 16 2018, 6:38 AM

Jan 15 2018

bkramer added a comment to D42071: [Sema] Add visited contexts to CodeCompleteContext.

We should have a unit test for this, otherwise it's dead code.

Jan 15 2018, 8:47 AM
bkramer accepted D42004: [Driver] Suggest valid integrated tools.

The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM.

Jan 15 2018, 4:46 AM

Jan 9 2018

bkramer accepted D41487: [clang-format] Adds a FormatStyleSet.

lg

Jan 9 2018, 2:49 AM

Jan 8 2018

bkramer added inline comments to D41487: [clang-format] Adds a FormatStyleSet.
Jan 8 2018, 7:41 AM

Jan 2 2018

bkramer accepted D41672: support phi ranges for machine-level IR.

lgtm

Jan 2 2018, 1:02 PM

Dec 28 2017

bkramer accepted D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.

lgtm

Dec 28 2017, 4:34 AM
bkramer added a comment to D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.

A test case for this edge case would be great.

Dec 28 2017, 3:42 AM

Dec 19 2017

bkramer added inline comments to D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.
Dec 19 2017, 5:07 AM

Dec 11 2017

bkramer accepted D40561: [libclang] Fix cursors for functions with trailing return type.

lg

Dec 11 2017, 4:57 AM

Nov 30 2017

bkramer accepted D40643: [libclang] Add function to get the buffer for a file.

lg

Nov 30 2017, 6:20 AM

Nov 27 2017

bkramer requested changes to D40485: [clangd] Introduced a Context that stores implicit data.
Nov 27 2017, 4:59 AM
bkramer added a comment to D40439: [Tooling] Remove file/command enumeration from CompilationDatabase..

There are a few users of the C++ API out there, do we have migration path for them?

Nov 27 2017, 4:32 AM

Nov 24 2017

bkramer accepted D40435: [clang-format] Deduplicate using declarations.

lg

Nov 24 2017, 8:58 AM
bkramer added inline comments to D40435: [clang-format] Deduplicate using declarations.
Nov 24 2017, 6:15 AM

Nov 23 2017

bkramer accepted D40302: Avoid copying the data of in-memory preambles.

lg

Nov 23 2017, 6:21 AM
bkramer added inline comments to D40302: Avoid copying the data of in-memory preambles.
Nov 23 2017, 6:13 AM

Nov 16 2017

bkramer accepted D40140: [VirtualFileSystem] Support creating directories then adding files inside.

lg

Nov 16 2017, 11:07 AM