Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior ProcrastinatorAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (428 w, 3 d)
Roles
Administrator

d0k

Recent Activity

Yesterday

bkramer committed rG6a1bca8798c6: [Analyzer] Fix unused variable warning in Release builds (authored by bkramer).
[Analyzer] Fix unused variable warning in Release builds
Fri, Sep 25, 5:10 AM
bkramer added a comment to D88290: [mlir] [VectorOps] generalize printing support for integers.

Can we promote everything to 64 bits to simplify the logic a bit? Otherwise looking good.

Fri, Sep 25, 4:52 AM · Restricted Project

Tue, Sep 22

bkramer added a reverting change for rG385c3f43fceb: Implement a new kind of Pass: dynamic pass pipeline: rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Tue, Sep 22, 3:04 AM
bkramer committed rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline" (authored by tjoerg).
Revert "Implement a new kind of Pass: dynamic pass pipeline"
Tue, Sep 22, 3:04 AM
bkramer added a reverting change for D86392: Implement a new kind of Pass: dynamic pass pipeline: rG0356a413a443: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Tue, Sep 22, 3:04 AM · Restricted Project
bkramer closed D88079: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Tue, Sep 22, 3:04 AM · Restricted Project
bkramer accepted D88079: Revert "Implement a new kind of Pass: dynamic pass pipeline".

Reproduces for me. Let's roll this back for now.

Tue, Sep 22, 2:57 AM · Restricted Project

Mon, Sep 21

bkramer accepted D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".

Ok, let's revert this for now. It's annoying to have a dependency on something that's not used by the in-tree backends, so we need to figure out how to remove it.

Mon, Sep 21, 4:29 AM · Restricted Project
bkramer committed rG2d76274b99f2: [mlir][VectorOps] Loosen restrictions on vector.reduction types (authored by bkramer).
[mlir][VectorOps] Loosen restrictions on vector.reduction types
Mon, Sep 21, 3:46 AM
bkramer closed D88010: [mlir][VectorOps] Loosen restrictions on vector.reduction types.
Mon, Sep 21, 3:46 AM · Restricted Project
bkramer requested review of D88010: [mlir][VectorOps] Loosen restrictions on vector.reduction types.
Mon, Sep 21, 3:08 AM · Restricted Project

Thu, Sep 17

bkramer committed rG7d593d0d6905: [amdgpu] Compilation fix for Release (authored by bgraur).
[amdgpu] Compilation fix for Release
Thu, Sep 17, 9:05 AM
bkramer closed D87838: [amdgpu] Compilation fix for Release.
Thu, Sep 17, 9:05 AM · Restricted Project
bkramer accepted D87838: [amdgpu] Compilation fix for Release.

looks good

Thu, Sep 17, 9:04 AM · Restricted Project

Wed, Sep 16

bkramer committed rGf0546173fa4b: [ASTMatchers] Add missing definition for decompositionDecl (authored by bkramer).
[ASTMatchers] Add missing definition for decompositionDecl
Wed, Sep 16, 8:33 AM

Tue, Sep 15

bkramer added a reverting change for rGcfff88c03cf9: [InstCombine] Simplify select operand based on equality condition: rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition".
Tue, Sep 15, 3:26 AM
bkramer committed rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition" (authored by bkramer).
Revert "[InstCombine] Simplify select operand based on equality condition"
Tue, Sep 15, 3:26 AM
bkramer added a reverting change for D87480: [InstCombine] Simplify select operand based on equality condition: rGb768546fe0cc: Revert "[InstCombine] Simplify select operand based on equality condition".
Tue, Sep 15, 3:26 AM · Restricted Project

Fri, Sep 11

bkramer committed rG5405ee553a63: [CodeGenPrepare] Simplify code. NFCI. (authored by bkramer).
[CodeGenPrepare] Simplify code. NFCI.
Fri, Sep 11, 2:25 AM
bkramer committed rGa0e0d30a2984: [mlir][Linalg] Print both types for linalg.transpose (authored by bkramer).
[mlir][Linalg] Print both types for linalg.transpose
Fri, Sep 11, 2:18 AM
bkramer closed D87462: [mlir][Linalg] Print both types for linalg.transpose.
Fri, Sep 11, 2:18 AM · Restricted Project
bkramer accepted D87434: [CodeGenPrepare] Fix zapping dead operands of assume.

Thanks, I prefer simplicity over efficiency here.

Fri, Sep 11, 2:15 AM · Restricted Project

Thu, Sep 10

bkramer added inline comments to D87462: [mlir][Linalg] Print both types for linalg.transpose.
Thu, Sep 10, 11:14 AM · Restricted Project
bkramer updated the diff for D87462: [mlir][Linalg] Print both types for linalg.transpose.

Factor out inferTransposeResultType

Thu, Sep 10, 11:12 AM · Restricted Project
bkramer committed rG5638df195048: Introduce linalg.vecmat (authored by burmako).
Introduce linalg.vecmat
Thu, Sep 10, 9:50 AM
bkramer closed D87292: Introduce linalg.vecmat.
Thu, Sep 10, 9:49 AM · Restricted Project
bkramer requested review of D87462: [mlir][Linalg] Print both types for linalg.transpose.
Thu, Sep 10, 8:58 AM · Restricted Project
bkramer added a comment to D87434: [CodeGenPrepare] Fix zapping dead operands of assume.

Thanks. Can we just wrap it in resetIteratorIfInvalidatedWhileCalling like the call a few lines later? That seems less error prone.

Thu, Sep 10, 2:07 AM · Restricted Project

Wed, Sep 9

bkramer accepted D87404: [mlir] [VectorOps] Enable 32-bit index optimizations.

nice

Wed, Sep 9, 11:25 AM · Restricted Project

Tue, Sep 8

bkramer committed rG51d30c3429fa: [mlir][VectorOps] Fix more GCC5 weirdness (authored by bkramer).
[mlir][VectorOps] Fix more GCC5 weirdness
Tue, Sep 8, 6:42 AM
bkramer committed rGdf63eedef64d: [mlir][VectorOps] (authored by bkramer).
[mlir][VectorOps]
Tue, Sep 8, 5:04 AM
bkramer committed rG307dc7b23692: [mlir][VectorOps] Clean up outdated comments. NFCI. (authored by bkramer).
[mlir][VectorOps] Clean up outdated comments. NFCI.
Tue, Sep 8, 3:02 AM
bkramer committed rG239eff502bca: [mlir][VectorOps] Redo the scalar loop emission in VectoToSCF to pad instead of… (authored by bkramer).
[mlir][VectorOps] Redo the scalar loop emission in VectoToSCF to pad instead of…
Tue, Sep 8, 2:16 AM
bkramer closed D87241: [mlir][VectorOps] Redo the scalar loop emission in VectoToSCF to pad instead of clipping.
Tue, Sep 8, 2:16 AM · Restricted Project

Mon, Sep 7

bkramer requested review of D87241: [mlir][VectorOps] Redo the scalar loop emission in VectoToSCF to pad instead of clipping.
Mon, Sep 7, 8:45 AM · Restricted Project
bkramer committed rG7ba0f81934ca: [X86] Unbreak the build after 22fa6b20d92e (authored by bkramer).
[X86] Unbreak the build after 22fa6b20d92e
Mon, Sep 7, 3:25 AM
bkramer accepted D87150: [mlir][Vector] Revisit VectorToSCF..

looks good

Mon, Sep 7, 1:44 AM · Restricted Project

Sun, Sep 6

bkramer committed rG8c386c94749a: [SmallVector] Move error handling out of line (authored by bkramer).
[SmallVector] Move error handling out of line
Sun, Sep 6, 9:11 AM
bkramer committed rG4d0312c8e05b: Add proper move ctor/move assign to APValue. NFCI. (authored by bkramer).
Add proper move ctor/move assign to APValue. NFCI.
Sun, Sep 6, 4:07 AM

Fri, Sep 4

bkramer committed rG0c2a4d3c1c95: [mlir][VectorOps] Simplify code. NFCI. (authored by bkramer).
[mlir][VectorOps] Simplify code. NFCI.
Fri, Sep 4, 2:13 AM

Thu, Sep 3

bkramer accepted D87116: [mlir] [VectorOps] Improve SIMD compares with narrower indices.

Looks good. Would it make sense to automatically enable this if the incoming memref is known to have fewer than 2^32 elements?

Thu, Sep 3, 4:30 PM · Restricted Project
bkramer committed rGdfb7b3fe02c0: [mlir][VectorOps] Fall back to a loop when accessing a vector from a strided… (authored by bkramer).
[mlir][VectorOps] Fall back to a loop when accessing a vector from a strided…
Thu, Sep 3, 7:06 AM
bkramer closed D87082: [mlir][VectorOps] Fall back to a loop when accessing a vector from a strided memref.
Thu, Sep 3, 7:06 AM · Restricted Project
bkramer updated the diff for D87082: [mlir][VectorOps] Fall back to a loop when accessing a vector from a strided memref.

Also handle transfer_write

Thu, Sep 3, 6:45 AM · Restricted Project
bkramer requested review of D87082: [mlir][VectorOps] Fall back to a loop when accessing a vector from a strided memref.
Thu, Sep 3, 4:53 AM · Restricted Project

Wed, Sep 2

bkramer committed rG2bf491c7294c: [mlir][VectorOps] Fail fast when a strided memref is passed to vector_transfer (authored by bkramer).
[mlir][VectorOps] Fail fast when a strided memref is passed to vector_transfer
Wed, Sep 2, 1:36 AM
bkramer closed D86951: [mlir][VectorOps] Fail fast when a strided memref is passed to vector_transfer.
Wed, Sep 2, 1:35 AM · Restricted Project

Tue, Sep 1

bkramer requested review of D86951: [mlir][VectorOps] Fail fast when a strided memref is passed to vector_transfer.
Tue, Sep 1, 8:23 AM · Restricted Project

Mon, Aug 31

bkramer added inline comments to rG8782c7276559: Strength-reduce SmallVectors to arrays. NFCI..
Mon, Aug 31, 2:54 AM

Sat, Aug 29

bkramer committed rG8e5b1557e5b3: [IR] Inline AttrBuilder::addAttribute. It just sets 1 bit. NFC. (authored by bkramer).
[IR] Inline AttrBuilder::addAttribute. It just sets 1 bit. NFC.
Sat, Aug 29, 10:14 AM

Fri, Aug 28

bkramer committed rG8782c7276559: Strength-reduce SmallVectors to arrays. NFCI. (authored by bkramer).
Strength-reduce SmallVectors to arrays. NFCI.
Fri, Aug 28, 12:16 PM
bkramer committed rG52cc97a0db2d: [CodeGenPrepare] Zap the argument of llvm.assume when deleting it (authored by bkramer).
[CodeGenPrepare] Zap the argument of llvm.assume when deleting it
Fri, Aug 28, 11:52 AM
bkramer committed rG3524c23ff299: [SCCP] Use bulk-remove API to bulk-remove attributes. NFCI. (authored by bkramer).
[SCCP] Use bulk-remove API to bulk-remove attributes. NFCI.
Fri, Aug 28, 5:45 AM
bkramer committed rGdce72dc87040: [FunctionAttrs] Bulk remove attributes. NFC. (authored by bkramer).
[FunctionAttrs] Bulk remove attributes. NFC.
Fri, Aug 28, 3:56 AM

Thu, Aug 27

bkramer committed rGfddf543e6e01: [MLIR][GPUToSPIRV] Fix use-after-free. Found by asan. (authored by bkramer).
[MLIR][GPUToSPIRV] Fix use-after-free. Found by asan.
Thu, Aug 27, 8:59 AM
bkramer committed rGb5924a8e2753: [Hexagon] Fold another layer of single-use variable into assert. NFCI. (authored by bkramer).
[Hexagon] Fold another layer of single-use variable into assert. NFCI.
Thu, Aug 27, 7:53 AM
bkramer committed rG2b7df2707f48: [Hexagon] Fold single-use variable into assert. NFCI. (authored by bkramer).
[Hexagon] Fold single-use variable into assert. NFCI.
Thu, Aug 27, 7:44 AM

Aug 26 2020

bkramer committed rG642cb7865f35: Copy m_plan_is_for_signal_trap member. (authored by bkramer).
Copy m_plan_is_for_signal_trap member.
Aug 26 2020, 4:27 AM

Aug 25 2020

bkramer accepted D86569: [mlir] [LLVMIR] Mark reductions as side-effect free.

lg

Aug 25 2020, 12:40 PM · Restricted Project
bkramer accepted D86501: [mlir] [LLVMIR] Add get active lane mask intrinsic.

Can we use LLVM_OneResultIntrOp to simplify the .td boilerplate? Looks good otherwise.

Aug 25 2020, 2:44 AM · Restricted Project
bkramer added a reverting change for rG557b890ff4f4: [InstCombine] improve demanded element analysis for vector insert-of-extract: rGc6fb72de4f55: Revert "[InstCombine] improve demanded element analysis for vector insert-of….
Aug 25 2020, 2:32 AM
bkramer committed rGc6fb72de4f55: Revert "[InstCombine] improve demanded element analysis for vector insert-of… (authored by bkramer).
Revert "[InstCombine] improve demanded element analysis for vector insert-of…
Aug 25 2020, 2:32 AM
bkramer added a reverting change for D86460: [InstCombine] improve demanded element analysis for vector insert-of-extract: rGc6fb72de4f55: Revert "[InstCombine] improve demanded element analysis for vector insert-of….
Aug 25 2020, 2:32 AM · Restricted Project

Aug 20 2020

bkramer edited reviewers for D86137: Add -Wno-error=unknown flag to clang-format., added: krasimir; removed: bkramer.
Aug 20 2020, 8:13 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

bkramer committed rGb98e25b6d723: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Aug 19 2020, 7:00 AM

Aug 11 2020

bkramer committed rGd287a5a33f63: [GlobalISel] Remove unused variable. NFC. (authored by bkramer).
[GlobalISel] Remove unused variable. NFC.
Aug 11 2020, 7:57 AM
bkramer committed rG8134c2c7ffed: [AutoUpgrade] Simplify code (authored by bkramer).
[AutoUpgrade] Simplify code
Aug 11 2020, 4:23 AM
bkramer committed rG1de173c04984: [X86][FPEnv] Fix a use after free (authored by bkramer).
[X86][FPEnv] Fix a use after free
Aug 11 2020, 4:02 AM

Aug 9 2020

People empowered bkramer as an administrator.
Aug 9 2020, 5:06 AM

Aug 8 2020

bkramer committed rG38537307e502: lib/CodeGen doesn't depend on lib/Passes. (authored by bkramer).
lib/CodeGen doesn't depend on lib/Passes.
Aug 8 2020, 4:41 AM

Aug 6 2020

bkramer accepted D85482: [mlir] [VectorOps] Improve lowering of extract_strided_slice (and friends like shape_cast).

lg

Aug 6 2020, 4:48 PM · Restricted Project
bkramer accepted D85428: [mlir][Vector] Add 2-D vector contract lowering to ReduceOp.

lg

Aug 6 2020, 7:40 AM · Restricted Project
bkramer added inline comments to D85428: [mlir][Vector] Add 2-D vector contract lowering to ReduceOp.
Aug 6 2020, 6:17 AM · Restricted Project
bkramer accepted D85421: [mlir][Vector] NFC - Use matchAndRewrite in ContractionOp lowering patterns.

lgtm

Aug 6 2020, 4:08 AM · Restricted Project
bkramer accepted D85413: [mlir][Linalg] Introduce canonicalization to remove dead LinalgOps.

lg, some nits inline.

Aug 6 2020, 2:25 AM · Restricted Project

Aug 5 2020

bkramer accepted D85357: [mlir] [VectorOps] Add masked load/store operations to Vector dialect.

lg

Aug 5 2020, 2:07 PM · Restricted Project, Restricted Project
bkramer committed rGc558c22cab9a: [llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false. (authored by bkramer).
[llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false.
Aug 5 2020, 3:08 AM
bkramer committed rGba0e71432a60: Do not map read-only data memory sections with EXECUTE flags. (authored by digit).
Do not map read-only data memory sections with EXECUTE flags.
Aug 5 2020, 1:56 AM
bkramer closed D78574: Do not map read-only data memory sections with EXECUTE flags..
Aug 5 2020, 1:55 AM · Restricted Project

Aug 4 2020

bkramer requested review of D85211: Use more efficient "e2" machine types.
Aug 4 2020, 7:36 AM

Aug 2 2020

bkramer added a comment to D84050: YAML: Don't assume an arbitrary StringRef is null terminated.

The parser used to rely on the \0 being present. Was that fixed?

Aug 2 2020, 2:12 AM · Restricted Project

Aug 1 2020

bkramer committed rGeb41f9edde10: [mlir][Vector] Simplify code a bit. NFCI. (authored by bkramer).
[mlir][Vector] Simplify code a bit. NFCI.
Aug 1 2020, 5:49 AM

Jul 31 2020

bkramer committed rGc6f08b14d489: Hide some internal symbols. NFC. (authored by bkramer).
Hide some internal symbols. NFC.
Jul 31 2020, 9:03 AM

Jul 28 2020

bkramer accepted D84753: [mlir][Vector] Drop declarative transforms.

lg

Jul 28 2020, 7:04 AM · Restricted Project

Jul 27 2020

bkramer accepted D81865: [clang] Use string tables for static diagnostic descriptions.

Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this change on that though.

Jul 27 2020, 8:18 AM · Restricted Project

Jul 22 2020

bkramer committed rGbf561dd2eb13: [mlir][Vector] Vectorize integer matmuls (authored by bkramer).
[mlir][Vector] Vectorize integer matmuls
Jul 22 2020, 10:45 AM
bkramer closed D84335: [mlir][Vector] Vectorize integer matmuls.
Jul 22 2020, 10:45 AM · Restricted Project
Herald added a project to D84335: [mlir][Vector] Vectorize integer matmuls: Restricted Project.
Jul 22 2020, 9:23 AM · Restricted Project
bkramer accepted D84293: Add an assertion in SmallVector::push_back().

Thanks!

Jul 22 2020, 1:57 AM · Restricted Project

Jul 20 2020

bkramer committed rG177e5acbe4b9: [Sema] Promote SmallSet of enum to bitset (authored by bkramer).
[Sema] Promote SmallSet of enum to bitset
Jul 20 2020, 8:38 AM
bkramer committed rGf3f1ce4fa9f4: [Driver] Promote SmallSet of enum to a bitset. NFCI. (authored by bkramer).
[Driver] Promote SmallSet of enum to a bitset. NFCI.
Jul 20 2020, 7:58 AM
bkramer committed rG33c9d0320e96: Upgrade SmallSets of pointer-like types to SmallPtrSet (authored by bkramer).
Upgrade SmallSets of pointer-like types to SmallPtrSet
Jul 20 2020, 7:58 AM
bkramer committed rGe88b6ed74868: [LLE] std::inserter doesn't work with SmallSet, so don't use it. (authored by bkramer).
[LLE] std::inserter doesn't work with SmallSet, so don't use it.
Jul 20 2020, 6:48 AM
bkramer committed rG44ab60f74d60: [LoopSimplify] Use SmallPtrSet and range for loops more. NFCI. (authored by bkramer).
[LoopSimplify] Use SmallPtrSet and range for loops more. NFCI.
Jul 20 2020, 6:01 AM

Jul 17 2020

bkramer committed rG9a0689e072da: Make helpers static. NFC. (authored by bkramer).
Make helpers static. NFC.
Jul 17 2020, 4:50 AM

Jul 16 2020

bkramer accepted D83971: [X86] Move integer hadd/hsub formation into a helper function shared by combineAdd and combineSub..

This fixes the miscompile I was seeing. Thanks!

Jul 16 2020, 11:27 AM · Restricted Project

Jul 14 2020

bkramer accepted D83782: [mlir][Vector] Degrade masking information when forwarding linalg.copy to vector.transfer.

lgtm

Jul 14 2020, 8:47 AM · Restricted Project

Jul 13 2020

bkramer committed rG724afa5a3313: [analyzer] Inline StringSet that's defined in a header (authored by bkramer).
[analyzer] Inline StringSet that's defined in a header
Jul 13 2020, 2:51 PM
bkramer accepted D83684: [mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer.

looks good!

Jul 13 2020, 8:06 AM · Restricted Project
bkramer committed rG3bffe6022cc9: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma (authored by bkramer).
[mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma
Jul 13 2020, 3:37 AM