bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (288 w, 1 d)

d0k

Recent Activity

Yesterday

bkramer accepted D42189: [clang-format] Replace unordered_set with an array.

lgtm

Wed, Jan 17, 11:52 AM
bkramer added inline comments to D42189: [clang-format] Replace unordered_set with an array.
Wed, Jan 17, 10:54 AM
bkramer requested changes to D42185: [ASTMatcher] Add isScoped matcher for enumDecl..

dump_ast_matchers.py should be working again now.

Wed, Jan 17, 8:52 AM
bkramer accepted D42185: [ASTMatcher] Add isScoped matcher for enumDecl..

lg

Wed, Jan 17, 8:15 AM
bkramer accepted D42167: [clang-format] adds enclosing function detection to raw string formatting.

lgtm

Wed, Jan 17, 7:35 AM
bkramer added inline comments to D42174: [clangd] Refactored threading in ClangdServer.
Wed, Jan 17, 7:32 AM
bkramer added inline comments to D42167: [clang-format] adds enclosing function detection to raw string formatting.
Wed, Jan 17, 6:26 AM
bkramer accepted D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor..

lg

Wed, Jan 17, 6:18 AM
bkramer accepted D41788: [DeclPrinter] Fix two cases that crash clang -ast-print..

This should be fine.

Wed, Jan 17, 3:10 AM

Tue, Jan 16

bkramer accepted D42098: [clang-format] Reorganize RawStringFormat based on language.

lg

Tue, Jan 16, 7:31 AM
bkramer added inline comments to D41991: [clangd] Always use preamble (even stale) for code completion.
Tue, Jan 16, 6:38 AM

Mon, Jan 15

bkramer added a comment to D42071: [Sema] Add visited contexts to CodeCompleteContext.

We should have a unit test for this, otherwise it's dead code.

Mon, Jan 15, 8:47 AM
bkramer accepted D42004: [Driver] Suggest valid integrated tools.

The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM.

Mon, Jan 15, 4:46 AM

Tue, Jan 9

bkramer accepted D41487: [clang-format] Adds a FormatStyleSet.

lg

Tue, Jan 9, 2:49 AM

Mon, Jan 8

bkramer added inline comments to D41487: [clang-format] Adds a FormatStyleSet.
Mon, Jan 8, 7:41 AM

Tue, Jan 2

bkramer accepted D41672: support phi ranges for machine-level IR.

lgtm

Tue, Jan 2, 1:02 PM

Thu, Dec 28

bkramer accepted D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.

lgtm

Thu, Dec 28, 4:34 AM
bkramer added a comment to D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.

A test case for this edge case would be great.

Thu, Dec 28, 3:42 AM

Tue, Dec 19

bkramer added inline comments to D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion.
Tue, Dec 19, 5:07 AM

Dec 11 2017

bkramer accepted D40561: [libclang] Fix cursors for functions with trailing return type.

lg

Dec 11 2017, 4:57 AM

Nov 30 2017

bkramer accepted D40643: [libclang] Add function to get the buffer for a file.

lg

Nov 30 2017, 6:20 AM

Nov 27 2017

bkramer requested changes to D40485: [clangd] Introduced a Context that stores implicit data.
Nov 27 2017, 4:59 AM
bkramer added a comment to D40439: [Tooling] Remove file/command enumeration from CompilationDatabase..

There are a few users of the C++ API out there, do we have migration path for them?

Nov 27 2017, 4:32 AM

Nov 24 2017

bkramer accepted D40435: [clang-format] Deduplicate using declarations.

lg

Nov 24 2017, 8:58 AM
bkramer added inline comments to D40435: [clang-format] Deduplicate using declarations.
Nov 24 2017, 6:15 AM

Nov 23 2017

bkramer accepted D40302: Avoid copying the data of in-memory preambles.

lg

Nov 23 2017, 6:21 AM
bkramer added inline comments to D40302: Avoid copying the data of in-memory preambles.
Nov 23 2017, 6:13 AM

Nov 16 2017

bkramer accepted D40140: [VirtualFileSystem] Support creating directories then adding files inside.

lg

Nov 16 2017, 11:07 AM

Nov 15 2017

bkramer accepted D40084: Assert correct removal of SUnit in LatencyPriorityQueue.

lg. Do you have commit access?

Nov 15 2017, 11:12 AM

Nov 14 2017

bkramer accepted D40027: [libclang] Fix cursors for in-class initializer of field declarations.

lgtm

Nov 14 2017, 8:51 AM

Nov 10 2017

bkramer accepted D39763: [clang] [python] [tests] Rewrite to use standard unittest module.

I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this.

Nov 10 2017, 5:37 AM

Nov 9 2017

bkramer accepted D39572: [VirtualFileSystem] InMemoryFileSystem::addFile(): Type and Perms.

LGTM!

Nov 9 2017, 7:52 AM
bkramer added inline comments to D39806: [clang-format] Support python-style comments in text protos.
Nov 9 2017, 7:38 AM
bkramer accepted D39786: [clang-format] Sort using declarations by splitting on '::'.

lg

Nov 9 2017, 7:27 AM

Nov 3 2017

bkramer accepted D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'.

lg, thanks!

Nov 3 2017, 7:35 AM

Nov 2 2017

bkramer added a comment to D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'.

Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state.

Nov 2 2017, 10:25 AM
bkramer accepted D39435: Adds a json::Expr type to represent intermediate JSON expressions..

I think we can go ahead with this. Using std::map is also fine if your elements are heavy and you need sorting :)

Nov 2 2017, 10:18 AM

Nov 1 2017

bkramer accepted D39498: [clang-format] Make parseUnaryOperator non-recursive, NFCI.

lg

Nov 1 2017, 10:53 AM

Oct 26 2017

bkramer accepted D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Looks good, thanks!

Oct 26 2017, 12:30 AM
bkramer accepted D36390: Fix overloaded static functions in SemaCodeComplete.

This looks good. Sorry for the long wait, do you have commit access?

Oct 26 2017, 12:26 AM

Oct 25 2017

bkramer requested changes to D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Can you point at the test cases that are failing? This would mean that there are two symbols with the same name, which seems like something that shouldn't happen.

The following 3 tests fail:

LLVM :: CodeGen/ARM/available_externally.ll
LLVM :: CodeGen/ARM/darwin-tls.ll
LLVM :: CodeGen/ARM/indirect-hidden.ll
Oct 25 2017, 1:20 AM

Oct 24 2017

bkramer added a comment to D39214: [MachineModuleInfoImpls] Replace qsort with array_pod_sort.

Can you point at the test cases that are failing? This would mean that there are two symbols with the same name, which seems like something that shouldn't happen.

Oct 24 2017, 11:25 PM

Oct 23 2017

bkramer accepted D38992: Support formatv of TimePoint with strftime-style formats..

I think this can go in now.

Oct 23 2017, 7:13 PM

Oct 12 2017

bkramer accepted D38787: [FileCheck] doc update/fix.

lg

Oct 12 2017, 8:43 AM

Oct 11 2017

bkramer added a comment to D38787: [FileCheck] doc update/fix.

Does FileCheck actually support BRE? I thought it's always ERE.

Oct 11 2017, 3:23 PM

Oct 9 2017

bkramer accepted D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble..

A testcase would be nice, but this can go in to unblock things.

Oct 9 2017, 9:26 AM
bkramer accepted D37970: [clangd] Added a command-line arg to mirror clangd input into a file..

This looks useful, thanks!

Oct 9 2017, 8:07 AM

Oct 8 2017

bkramer created D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer..
Oct 8 2017, 3:34 PM

Sep 25 2017

bkramer accepted D38225: [clangd] Fix missing "message" key when responding with unsupported method.

This looks good. Do you have commit access?

Sep 25 2017, 7:59 AM
bkramer accepted D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON.

lg

Sep 25 2017, 7:04 AM

Sep 20 2017

bkramer accepted D38087: [clang-tidy] Fix example in documentation, NFC.

fun fun fun fun fun

Sep 20 2017, 11:23 AM

Sep 13 2017

bkramer accepted D37564: Update users of llvm::sys::ExecuteAndWait etc..

lgtm too

Sep 13 2017, 9:45 AM
bkramer accepted D37563: Convenience/safety fix for llvm::sys::Execute(And|No)Wait.

lgtm

Sep 13 2017, 8:29 AM

Sep 8 2017

bkramer accepted D37382: Fixed a crash in code completion..

lg

Sep 8 2017, 6:12 AM

Sep 5 2017

bkramer edited reviewers for D37474: [PCH] Allow VFS to be used for tests that generate PCH files, added: ilya-biryukov; removed: cfe-commits.
Sep 5 2017, 7:29 AM

Sep 4 2017

bkramer accepted D37435: Don't show deleted function (constructor) candidates for code completion.

lgtm

Sep 4 2017, 7:58 AM
bkramer added inline comments to D37435: Don't show deleted function (constructor) candidates for code completion.
Sep 4 2017, 7:10 AM

Aug 21 2017

bkramer accepted D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*.

lg

Aug 21 2017, 3:41 AM
bkramer accepted D36872: Fixed a crash on replaying Preamble's PP conditional stack..

This looks good to me.

Aug 21 2017, 3:20 AM

Aug 14 2017

bkramer accepted D36397: [clangd] Fixed a data race..

I think this can be committed now. It's still a bit awkward but we can address that later.

Aug 14 2017, 12:59 AM

Aug 9 2017

bkramer added a comment to D36458: Fix crash when current lexer is nullptr.

Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future.

Aug 9 2017, 5:04 AM

Aug 8 2017

bkramer added inline comments to D36390: Fix overloaded static functions in SemaCodeComplete.
Aug 8 2017, 7:00 AM
bkramer accepted D36330: Updated two annotations for Store.h and CodeGenFunction.h..

lg

Aug 8 2017, 6:45 AM
bkramer added a comment to D36458: Fix crash when current lexer is nullptr.

Test case?

Aug 8 2017, 4:41 AM
bkramer added a reviewer for D36458: Fix crash when current lexer is nullptr: erikjv.
Aug 8 2017, 4:41 AM

Aug 7 2017

bkramer added a comment to D36187: [clang-diff] Use the relative name for NamedDecls.

There's some similar code in tools/clang/lib/Tooling/Core/Lookup.cpp, it might make sense to share it. Otherwise this looks good.

Aug 7 2017, 6:47 AM
bkramer added inline comments to D36390: Fix overloaded static functions in SemaCodeComplete.
Aug 7 2017, 6:25 AM
bkramer added inline comments to D36330: Updated two annotations for Store.h and CodeGenFunction.h..
Aug 7 2017, 6:19 AM

Aug 3 2017

bkramer accepted D36302: [msan] Switch the pvalloc overflow test to a lit test.

lgtm

Aug 3 2017, 11:28 PM

Aug 2 2017

bkramer accepted D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration..

looks good

Aug 2 2017, 1:21 AM

Aug 1 2017

bkramer added inline comments to D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration..
Aug 1 2017, 9:10 AM
bkramer accepted D36133: [clangd] Rewrote AST and Preamble management..

ship it!

Aug 1 2017, 8:34 AM
bkramer added inline comments to D36133: [clangd] Rewrote AST and Preamble management..
Aug 1 2017, 3:21 AM

Jul 31 2017

bkramer accepted D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete..

lg (it could use a test case though)

Jul 31 2017, 10:00 AM

Jul 28 2017

bkramer accepted D27104: Unify and simplify the behavior of the hasDeclaration matcher..

lg under the precondition that clang-tidy tests still work.

Jul 28 2017, 4:19 AM

Jul 25 2017

bkramer accepted D35828: Fix incorrect use of current directory to find moved paths in ASTReader..

lg

Jul 25 2017, 3:12 AM

Jul 19 2017

bkramer accepted D35617: [clangd] Allow specifying -resource-dir.

Looks good.

Jul 19 2017, 7:48 AM · Restricted Project

Jul 10 2017

bkramer accepted D35203: Avoid white spaces in file names. NFC.

This is fine. We should fix phab though.

Jul 10 2017, 9:03 AM
bkramer accepted D35206: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC.

This is fine. We should fix phab though.

Jul 10 2017, 9:03 AM

Jun 30 2017

bkramer accepted D34882: Fix invalid warnings for header guards in preambles.

This fixes the issues I'm seeing.

Jun 30 2017, 8:54 AM
bkramer edited reviewers for D34304: Allow CompilerInvocations to generate .d files., added: klimek; removed: bkramer.
Jun 30 2017, 3:16 AM

Jun 6 2017

bkramer accepted D33930: Do not pick up by default the LLVM style if passing -format.

Looks good, but I'm wondering if we should also change the default in clang-apply-replacements itself.

Jun 6 2017, 5:29 AM

May 30 2017

bkramer accepted D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider..

lg

May 30 2017, 8:07 AM · Restricted Project

May 24 2017

bkramer accepted D33416: [clangd] Allow to use vfs::FileSystem for file accesses..

Looks good. Make sure to watch the windows buildbots after submitting.

May 24 2017, 5:48 AM

May 23 2017

bkramer added inline comments to D33416: [clangd] Allow to use vfs::FileSystem for file accesses..
May 23 2017, 2:45 AM
bkramer accepted D33397: Allow to use vfs::FileSystem for file accesses inside ASTUnit..

lg

May 23 2017, 2:28 AM

May 22 2017

bkramer accepted D33395: [clangd] Split clangd into library+executable (mainly for unit tests)..

looks good to me

May 22 2017, 9:27 AM · Restricted Project

May 19 2017

bkramer edited reviewers for D33045: [libclang] Avoid more stats than necessary for reparse., added: ilya-biryukov; removed: cfe-commits.
May 19 2017, 7:07 AM
bkramer accepted D33042: [libclang] Allow to suspend a translation unit..

This makes sense to me.

May 19 2017, 7:05 AM
bkramer accepted D33350: [clangd] Switch to incomplete translation units.

lg

May 19 2017, 3:05 AM

May 17 2017

bkramer accepted D33270: [Frontend] Remove unused TemporaryFiles.

Kill it :)

May 17 2017, 7:58 AM
bkramer accepted D33273: Recommit "[include-fixer] Don't throw exception when parsing unknown ar… …guments in vim script.".

looks good, thanks!

May 17 2017, 5:50 AM

May 15 2017

bkramer accepted D33047: [ClangD] Refactor clangd into separate components.

I believe this is good enough now.

May 15 2017, 6:43 AM · Restricted Project

May 12 2017

bkramer accepted D33103: [clang-tidy] TwineLocalCheck: add param # checking.

looks good, thanks!

May 12 2017, 1:19 AM · Restricted Project

Apr 28 2017

bkramer added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Can you please run clang-format on this change? There are pieces that don't follow the style.

Apr 28 2017, 2:45 AM
bkramer added a reviewer for D30946: [ScopePrinting] Added support to print full scopes of types and declarations.: rsmith.
Apr 28 2017, 2:44 AM

Apr 21 2017

bkramer added a comment to D32234: [Clangd] Support Authority-less URIs.

Still looking good. Will commit this soon.

Apr 21 2017, 8:52 AM · Restricted Project
bkramer added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

lg from my side. It would be good to wait until Manuel is back though, I think he had plans for extending this interface at some point.

Apr 21 2017, 8:43 AM
bkramer accepted D32238: [Clangd] Failed to decode params using 1.x-compatible request message.

lg

Apr 21 2017, 7:10 AM · Restricted Project

Apr 19 2017

bkramer accepted D32234: [Clangd] Support Authority-less URIs.

This is fine. Test case would be nice though.

Apr 19 2017, 12:59 PM · Restricted Project