Page MenuHomePhabricator

bkramer (Benjamin Kramer)
Senior Procrastinator

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 1:37 PM (357 w, 6 d)

d0k

Recent Activity

Apr 18 2019

bkramer committed rG70857952844c: MinidumpYAML: Fix ambiguity between std::make_unique and llvm::make_unique (authored by bkramer).
MinidumpYAML: Fix ambiguity between std::make_unique and llvm::make_unique
Apr 18 2019, 8:08 AM

Apr 3 2019

bkramer accepted D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery.

lg

Apr 3 2019, 12:23 PM · Restricted Project

Apr 1 2019

bkramer accepted D60060: [X86] Fix a test from r357317.

lg

Apr 1 2019, 4:44 AM · Restricted Project

Mar 28 2019

bkramer committed rGba2ea93ad189: Make helper functions static. NFC. (authored by bkramer).
Make helper functions static. NFC.
Mar 28 2019, 10:18 AM

Mar 24 2019

bkramer accepted D59750: Rename directory housing clang-include-fixer to be eponymous.

lg. Is the reference from libclang still around? Might need an update.

Mar 24 2019, 3:36 PM · Restricted Project

Mar 15 2019

bkramer committed rGa65ec7eec8d1: Make getFullyQualifiedName qualify both the pointee and class type for member… (authored by bkramer).
Make getFullyQualifiedName qualify both the pointee and class type for member…
Mar 15 2019, 4:10 AM

Mar 14 2019

bkramer created D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types.
Mar 14 2019, 2:32 PM · Restricted Project, Restricted Project

Mar 11 2019

bkramer committed rG1b1d372b4234: Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC. (authored by bkramer).
Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC.
Mar 11 2019, 3:44 AM
bkramer committed rG6ff32e143a64: [MIPS GlobalISel] Silence uninitialized variable warning (authored by bkramer).
[MIPS GlobalISel] Silence uninitialized variable warning
Mar 11 2019, 3:39 AM
bkramer committed rG9318db0fa199: [Serialization] Add missing include (authored by bkramer).
[Serialization] Add missing include
Mar 11 2019, 3:30 AM

Mar 8 2019

bkramer committed rG93110c2fe46c: Make function definition in header inline (authored by bkramer).
Make function definition in header inline
Mar 8 2019, 2:44 AM

Feb 11 2019

bkramer committed rG711950c1161e: Move some classes into anonymous namespaces. NFC. (authored by bkramer).
Move some classes into anonymous namespaces. NFC.
Feb 11 2019, 7:17 AM
bkramer committed rG756ecb8e44dc: Make some helper functions static. NFC. (authored by bkramer).
Make some helper functions static. NFC.
Feb 11 2019, 6:52 AM
bkramer committed rG582c16013d26: [AMDGPU] Remove unused variable (authored by bkramer).
[AMDGPU] Remove unused variable
Feb 11 2019, 6:51 AM

Jan 30 2019

bkramer accepted D57442: [OpenGL] Fix test on PPC after r352540.

lg

Jan 30 2019, 3:22 AM

Jan 24 2019

bkramer accepted D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule()..
Jan 24 2019, 6:56 AM

Jan 14 2019

bkramer accepted D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes)..

This makes sense to me.

Jan 14 2019, 7:54 AM

Jan 10 2019

bkramer accepted D56521: Avoid use-after-free in ~LegacyRTDyldObjectLinkingLayer.

This is an obvious fix for a use-after-free. Looks good.

Jan 10 2019, 11:57 AM

Dec 9 2018

bkramer accepted D55415: Revert removal of tidy plugin support from libclang.

I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually.

Dec 9 2018, 9:57 PM
bkramer accepted D55484: ComputeLineNumbers: delete SSE2 vectorization.

The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on?

Dec 9 2018, 9:55 PM

Dec 7 2018

bkramer added a comment to D55415: Revert removal of tidy plugin support from libclang.

I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it because it slows down builds while not adding value.

Dec 7 2018, 7:06 AM

Nov 21 2018

bkramer accepted D54788: [TI removal] Leverage the fact that TerminatorInst is gone to create a normal base class that provides all common "call" functionality..

I like it.

Nov 21 2018, 7:58 AM

Nov 14 2018

bkramer accepted D54540: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable types.

Thanks. There's a bit of unused code that passes isPodLike through the layers, but this is the minimal fix. Looks good to me.

Nov 14 2018, 2:09 PM

Nov 6 2018

bkramer accepted D54160: [sanitizer] Expose getauxval as weak declaration to fix TSanitizer-x86_64-Test-Nolibc.

Thanks! This looks good to me, but I'd like someone from sanitizer team review it too.

Nov 6 2018, 10:25 AM

Nov 5 2018

bkramer updated the diff for D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
  • Add a comment to the test.
Nov 5 2018, 3:01 PM
bkramer added inline comments to D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
Nov 5 2018, 3:00 PM
bkramer added a comment to D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
In D54113#1287835, @kcc wrote:

Is a test possible here?

Nov 5 2018, 1:50 PM
bkramer updated the diff for D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.

Add test

Nov 5 2018, 1:50 PM
bkramer created D54113: [sanitizer] Use AT_EXECFN in ReExec() if available.
Nov 5 2018, 9:42 AM

Oct 25 2018

bkramer accepted D53689: IR: Optimize StructType::get to perform one hash lookup instead of two, NFCI.

lg

Oct 25 2018, 5:26 AM

Oct 24 2018

bkramer accepted D53471: IR: Optimize FunctionType::get to perform one hash lookup instead of two, NFCI.

lg

Oct 24 2018, 7:58 AM

Oct 22 2018

bkramer added a reviewer for D53470: [ELF] Don't warn on two legitimate cases when reading .llvm.call-graph-profile: Bigcheese.
Oct 22 2018, 2:54 AM

Sep 24 2018

bkramer accepted D52264: Deduplicate replacements from diagnostics..

lg

Sep 24 2018, 2:10 PM

Sep 14 2018

bkramer accepted D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status.

lg

Sep 14 2018, 1:36 AM

Sep 13 2018

bkramer accepted D52024: LSV: Fix adjust alloca alignment trick for AMDGPU.
Sep 13 2018, 6:13 AM
bkramer added inline comments to D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status.
Sep 13 2018, 5:42 AM

Sep 12 2018

bkramer added inline comments to D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status.
Sep 12 2018, 11:00 AM
bkramer accepted D51918: [Support] sys::fs::directory_entry includes the file_type..

lg

Sep 12 2018, 10:51 AM
bkramer accepted D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files.

I like it

Sep 12 2018, 10:49 AM

Aug 29 2018

bkramer accepted D51406: [MC] fix a clang-tidy warning, NFC.

meh

Aug 29 2018, 3:11 AM

Aug 27 2018

bkramer created D51306: [NVPTX] Implement isLegalToVectorizeLoadChain.
Aug 27 2018, 7:53 AM

Aug 21 2018

bkramer added a comment to D51042: [NVPTX] Remove ftz variants of cvt with rounding mode.
In D51042#1207769, @tra wrote:

This is a surprise. PTX ISA does not mention that .ftz is not applicable to cvt.*.f16.* instructions.
Is it only cvt that does not support .ftz or does it impact other instructions? PTX spec has add/sub/mul/fma/set/setp instructions that support f16 and have .ftz variant.

Aug 21 2018, 10:49 AM
bkramer created D51042: [NVPTX] Remove ftz variants of cvt with rounding mode.
Aug 21 2018, 8:31 AM

Aug 8 2018

bkramer accepted D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc.

lg

Aug 8 2018, 11:18 AM

Aug 7 2018

bkramer added a comment to D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc.

Test case?

Aug 7 2018, 2:02 PM

Aug 1 2018

bkramer accepted D50156: [test] Fix %hmaptool path for standalone builds.

lg, thanks

Aug 1 2018, 1:15 PM

Jul 23 2018

bkramer accepted D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt.

lg

Jul 23 2018, 5:11 AM · Restricted Project

Jul 20 2018

bkramer accepted D49582: [CUDA, test-suite] Added tests for integer SIMD functions..

I don't know much about cuda, but this looks fine to me.

Jul 20 2018, 3:08 AM
bkramer accepted D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2.

lg

Jul 20 2018, 2:58 AM

Jul 18 2018

bkramer added a comment to rL337262: [llvm-objcopy] Run not with any python, but the python configured in lit..

Thanks, this is only the 2nd time this has happened to me. Will fix :)

Jul 18 2018, 9:20 AM
bkramer requested changes to D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2.
Jul 18 2018, 8:05 AM
bkramer accepted D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2.
Jul 18 2018, 8:02 AM
bkramer accepted D49302: [AST] Various micro-optimizations in CXXInheritance.

cool

Jul 18 2018, 7:55 AM · Restricted Project
bkramer accepted D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result..

lg

Jul 18 2018, 7:53 AM

Jul 16 2018

bkramer accepted D49378: [x86/SLH] Completely rework how we sink post-load hardening past data invariant instructions to be both more correct and much more powerful..

This is fine, it's just that listing all of the instructions gives me a really bad feeling.

Jul 16 2018, 7:53 AM

Jul 5 2018

bkramer accepted D48962: Partially revert r336268 in address-offsets.ll.

sad

Jul 5 2018, 4:33 AM

Jun 22 2018

bkramer added a comment to rC335330: [hmaptool] Turn %hmaptool into a proper substitution.

@bkramer, this breaks the tests when the path to python contains spaces (which is why in the original change %python is surrounded by quotes). For example:

Command Output (stdout):
 --
$ ":" "RUN: at line 1"
$ "rm" "-f" "C:\agent1\_work\2\b\LLVMBuild\tools\clang\test\Preprocessor\Output\headermap-rel2.c.tmp.hmap"
$ ":" "RUN: at line 2"
$ "C:/Program" "Files" "(x86)/Microsoft" "Visual" "Studio/Shared/Python36_64/python.exe" "C:/agent1/_work/2/b/LLVMBuild/Release/bin\hmaptool" "write" "C:\agent1\_work\2\s\llvm\tools\clang\test\Preprocessor/Inputs/headermap-rel2/project-headers.hmap.json" "C:\agent1\_work\2\b\LLVMBuild\tools\clang\test\Preprocessor\Output\headermap-rel2.c.tmp.hmap"
# command stderr:
'C:/Program': command not found

You probably should add quotes around the python path in lit.cfg.py when you do the substitution. I can look into this on Monday if you don't have time to fix it beforehand.

Jun 22 2018, 1:08 PM

Jun 20 2018

bkramer added inline comments to D48392: [Dominators] Simplify child lists and make them deterministic.
Jun 20 2018, 2:08 PM
bkramer updated the diff for D48392: [Dominators] Simplify child lists and make them deterministic.

Address comments.

Jun 20 2018, 2:06 PM
bkramer added a comment to D48392: [Dominators] Simplify child lists and make them deterministic.

I always prefer deterministic execution (all other things being equal). Have you done any testing of performance impact to this change? The adding and erasing of Dominator elements may cost more with how the SmallVector type performs the operations.

Otherwise I think the patch looks good. However, @kuhar is the Dominator expert here and I'd recommend waiting for him to speak up before committing.

I didn't manage to get the 240 MB IR file reduced enough, triggering this bug requires a lot of jump threading, so landing this without a test case.

Did you try bugpoint? a 240MB IR fire is indeed huge but maybe letting it run over night can help reduce the problem space. Non-deterministic errors like these are very difficult to narrow down though.

Jun 20 2018, 1:44 PM
bkramer created D48392: [Dominators] Simplify child lists and make them deterministic.
Jun 20 2018, 1:11 PM

Jun 18 2018

bkramer accepted D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

I think this is fine to go in. It's not the most pretty API, but not really more unsafe than what's already there.

Jun 18 2018, 2:54 AM

Jun 11 2018

bkramer added inline comments to D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance..
Jun 11 2018, 4:29 AM

Jun 7 2018

bkramer added a reviewer for D47864: [python] Fix most Python binding unittests on Windows: jbcoe.
Jun 7 2018, 6:49 AM
bkramer added a reviewer for D47864: [python] Fix most Python binding unittests on Windows: wanders.
Jun 7 2018, 6:48 AM
bkramer accepted D47864: [python] Fix most Python binding unittests on Windows.

I don't know much about the python bindings, but this is probably fine.

Jun 7 2018, 6:48 AM

May 24 2018

bkramer accepted D47262: [VFS] Implement getRealPath in InMemoryFileSystem..

lg

May 24 2018, 3:11 AM

May 22 2018

bkramer added a comment to D47214: [InstCombine] Replace bcmp/bcopy with memcmp/memmove.

why?

May 22 2018, 1:50 PM
bkramer accepted D47059: [InstCombine] Calloc-ed strings optimizations.

lg

May 22 2018, 6:32 AM

May 21 2018

bkramer added inline comments to D47059: [InstCombine] Calloc-ed strings optimizations.
May 21 2018, 3:43 AM
bkramer added inline comments to D47059: [InstCombine] Calloc-ed strings optimizations.
May 21 2018, 3:04 AM

May 18 2018

bkramer accepted D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS.

lg

May 18 2018, 9:08 AM
bkramer added a comment to D47059: [InstCombine] Calloc-ed strings optimizations.

This looks overly specific. Can you teach GetStringLength about this instead? All of the transformations should already work if GetStringLength returns a length of zero.

May 18 2018, 6:26 AM
bkramer accepted D47060: [VFS] Implement getRealPath for OverlayFileSystem..

lg

May 18 2018, 6:05 AM

May 17 2018

bkramer accepted D46942: Add vfs::FileSystem::getRealPath.

Looks good. Please watch the windows buildbots carefully after landing this.

May 17 2018, 2:45 AM

May 9 2018

bkramer updated the diff for D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.

Add a FIXME for using the demanded mask of the udiv result.

May 9 2018, 2:42 PM
bkramer added inline comments to D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.
May 9 2018, 11:28 AM
bkramer created D46647: [InstCombine] Teach SimplifyDemandedBits that udiv doesn't demand low dividend bits that are zero in the divisor.
May 9 2018, 10:17 AM
bkramer accepted D46285: [InstCombine] snprintf optimizations.

lg

May 9 2018, 9:10 AM

Apr 28 2018

bkramer added a comment to D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..

Would it be possible to get rid of the flag entirely and make this controlled only by the data layout? That's defined on the module level.

Apr 28 2018, 2:09 AM

Apr 27 2018

bkramer accepted D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..

lgtm

Apr 27 2018, 2:01 PM
bkramer accepted D46148: [CUDA] Added -f[no-]cuda-short-ptr option.

lgtm

Apr 27 2018, 2:01 PM
bkramer added inline comments to D46147: [NVPTX] Added a feature to use short pointers for const/local/shared AS..
Apr 27 2018, 2:11 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 27 2018, 1:54 AM

Apr 26 2018

bkramer updated the diff for D46130: [NVPTX] Turn on Loop/SLP vectorization.

Extend getNumberOfRegisters comment.

Apr 26 2018, 11:45 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 11:26 AM
bkramer added inline comments to D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 10:52 AM
bkramer created D46130: [NVPTX] Turn on Loop/SLP vectorization.
Apr 26 2018, 9:19 AM
bkramer created D46116: [NVPTX] Make the legalizer expand shufflevector of <2 x half>.
Apr 26 2018, 5:41 AM

Apr 24 2018

bkramer added a comment to D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..

Would it be difficult to preserve the invariant if both loads are?

Apr 24 2018, 7:50 AM
bkramer updated the diff for D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..

Improve test by checking that the merged store is not marked as invariant.

Apr 24 2018, 7:43 AM
bkramer created D46011: [LoadStoreVectorize] Ignore interleaved invariant loads..
Apr 24 2018, 7:11 AM

Apr 14 2018

bkramer added reviewers for D45653: [X86] Enable sibling-call optimization for functions returning structs: craig.topper, RKSimon.
Apr 14 2018, 7:43 AM
bkramer accepted D45606: NFC: Move ObjectMemoryBuffer to support.

doing it later is fine with me.

Apr 14 2018, 2:44 AM

Apr 13 2018

bkramer added a comment to D45606: NFC: Move ObjectMemoryBuffer to support.

Thanks! I wonder if we can come up with a better name than ObjectMemoryBuffer though. Maybe SmallVectorMemoryBuffer?

Apr 13 2018, 5:42 AM
bkramer accepted D45603: Fix evaluation of `__has_include_next` during -frewrite-includes..

lg

Apr 13 2018, 5:42 AM
bkramer accepted D45545: [profile] Fix binary format reader error propagation..

lg

Apr 13 2018, 5:41 AM

Apr 4 2018

bkramer accepted D44855: [ARM] Change std::sort to llvm::sort in response to r327219.

this is trivially fine.

Apr 4 2018, 7:42 AM
bkramer accepted D45140: [Support] Change std::sort to llvm::sort in response to r327219.

this is trivially fine.

Apr 4 2018, 7:42 AM
bkramer accepted D44769: [Analysis] Support aligned new/delete functions..

lg

Apr 4 2018, 7:40 AM