Page MenuHomePhabricator

mtrofin (Mircea Trofin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 11:03 PM (214 w, 4 d)

Recent Activity

Fri, Mar 15

mtrofin committed rG2c3ab665393c: [llvm] Skip over empty line table entries. (authored by mtrofin).
[llvm] Skip over empty line table entries.
Fri, Mar 15, 8:01 AM
mtrofin committed rL356265: [llvm] Skip over empty line table entries..
[llvm] Skip over empty line table entries.
Fri, Mar 15, 8:01 AM
mtrofin closed D58952: [llvm] Skip over empty line table entries..
Fri, Mar 15, 8:01 AM · debug-info, Restricted Project
mtrofin added a comment to D58952: [llvm] Skip over empty line table entries..

Thanks a bunch - looks good to me.

I take it the added test coverage covers the case that was broken the firstn time this was committed? But were you also able to reproduce that original failure locally with compiler-rt or wherever it was? & have you verified that scenario (check-compiler-rt, or, again, whatever it was - I'm just guessing roughly from the emails I saw) is completely passing now with this change? (in case there were other "interesting" situations that scenario trips over)

Fri, Mar 15, 7:58 AM · debug-info, Restricted Project

Thu, Mar 14

mtrofin abandoned D59397: Revert "Revert "[llvm] Skip over empty line table entries."".
Thu, Mar 14, 4:50 PM · Restricted Project
mtrofin updated the diff for D58952: [llvm] Skip over empty line table entries..

Simplify code

Thu, Mar 14, 4:49 PM · debug-info, Restricted Project
mtrofin created D59397: Revert "Revert "[llvm] Skip over empty line table entries."".
Thu, Mar 14, 4:48 PM · Restricted Project

Wed, Mar 13

mtrofin updated the diff for D58952: [llvm] Skip over empty line table entries..
  • Revert "Revert "[llvm] Skip over empty line table entries.""
  • Handle cases when query address is between ranges.
Wed, Mar 13, 6:41 PM · debug-info, Restricted Project

Tue, Mar 12

mtrofin committed rG0c29402eb406: [llvm] Skip over empty line table entries. (authored by mtrofin).
[llvm] Skip over empty line table entries.
Tue, Mar 12, 1:50 PM
mtrofin committed rL355972: [llvm] Skip over empty line table entries..
[llvm] Skip over empty line table entries.
Tue, Mar 12, 1:50 PM
mtrofin closed D58952: [llvm] Skip over empty line table entries..
Tue, Mar 12, 1:50 PM · debug-info, Restricted Project

Mon, Mar 11

mtrofin updated the diff for D58952: [llvm] Skip over empty line table entries..
  • improved test
Mon, Mar 11, 6:47 PM · debug-info, Restricted Project
mtrofin updated the diff for D58952: [llvm] Skip over empty line table entries..
  • Fix search.
  • Empty ranges testcase
Mon, Mar 11, 1:19 PM · debug-info, Restricted Project

Tue, Mar 5

mtrofin added inline comments to D58832: [SampleFDO] add suffix elision control for fcn names.
Tue, Mar 5, 1:48 PM · Restricted Project

Mon, Mar 4

mtrofin updated the diff for D58952: [llvm] Skip over empty line table entries..
  • Fix search.
Mon, Mar 4, 10:37 PM · debug-info, Restricted Project
mtrofin created D58952: [llvm] Skip over empty line table entries..
Mon, Mar 4, 10:10 PM · debug-info, Restricted Project
mtrofin added a reviewer for D58952: [llvm] Skip over empty line table entries.: dblaikie.
Mon, Mar 4, 10:10 PM · debug-info, Restricted Project

Jan 25 2019

mtrofin committed rL352246: [llvm] Opt-in flag for X86DiscriminateMemOps.
[llvm] Opt-in flag for X86DiscriminateMemOps
Jan 25 2019, 1:50 PM
mtrofin closed D57257: [llvm] Opt-in flag for X86DiscriminateMemOps.
Jan 25 2019, 1:50 PM
mtrofin updated the diff for D57257: [llvm] Opt-in flag for X86DiscriminateMemOps.

git commit message update

Jan 25 2019, 1:17 PM
mtrofin retitled D57257: [llvm] Opt-in flag for X86DiscriminateMemOps from [llvm] Opt-in flag for X86DiscriminateMemOpsCurrently, if an instruction with a memory operand has no debug information, X86DiscriminateMemOps will generate one based on the first line of the enclosing function, or the last seen debug info. This... to [llvm] Opt-in flag for X86DiscriminateMemOps.
Jan 25 2019, 1:15 PM
mtrofin retitled D57257: [llvm] Opt-in flag for X86DiscriminateMemOps from [llvm] Opt-in flag for X86DiscriminateMemOps Currently, if an instruction with a memory operand has no debug information, X86DiscriminateMemOps will generate one based on the first line of the enclosing function, or the last seen debug info. This... to [llvm] Opt-in flag for X86DiscriminateMemOpsCurrently, if an instruction with a memory operand has no debug information, X86DiscriminateMemOps will generate one based on the first line of the enclosing function, or the last seen debug info. This....
Jan 25 2019, 1:15 PM
mtrofin created D57257: [llvm] Opt-in flag for X86DiscriminateMemOps.
Jan 25 2019, 1:11 PM

Jan 23 2019

mtrofin committed rL351996: [llvm] Clarify responsiblity of some of DILocation discriminator APIs.
[llvm] Clarify responsiblity of some of DILocation discriminator APIs
Jan 23 2019, 4:10 PM
mtrofin closed D56220: [llvm] Clarify responsiblity of some of DILocation discriminator APIs.
Jan 23 2019, 4:10 PM

Jan 2 2019

mtrofin added reviewers for D56220: [llvm] Clarify responsiblity of some of DILocation discriminator APIs: dblaikie, wmi.
Jan 2 2019, 1:29 PM
mtrofin created D56220: [llvm] Clarify responsiblity of some of DILocation discriminator APIs.
Jan 2 2019, 1:29 PM

Dec 21 2018

mtrofin committed rL349975: Silence warning in assert introduced in rL349973..
Silence warning in assert introduced in rL349973.
Dec 21 2018, 3:07 PM
mtrofin closed D56030: Silence warning in assert introduced in rL349973..
Dec 21 2018, 3:07 PM
mtrofin created D56030: Silence warning in assert introduced in rL349973..
Dec 21 2018, 3:01 PM
mtrofin committed rL349973: [llvm] API for encoding/decoding DWARF discriminators..
[llvm] API for encoding/decoding DWARF discriminators.
Dec 21 2018, 2:52 PM
mtrofin closed D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 21 2018, 2:52 PM
mtrofin added inline comments to D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 21 2018, 2:26 PM
mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Remove unrelated changes (clang-format)
  • Moved implementation of new APIs to DebugInfoMetadata.cpp.
  • Adjust includes
  • Improved comments.
  • Returning Optional<unsigned>
  • Feedback
Dec 21 2018, 2:25 PM
mtrofin added a comment to D55681: [llvm] API for encoding/decoding DWARF discriminators..

ptal - thanks!

Dec 21 2018, 8:15 AM

Dec 19 2018

mtrofin added inline comments to D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 19 2018, 9:12 PM
mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Returning Optional<unsigned>
Dec 19 2018, 9:11 PM
mtrofin updated the summary of D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 19 2018, 3:40 PM

Dec 17 2018

mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Improved comments.
Dec 17 2018, 11:29 AM
mtrofin added a comment to D55681: [llvm] API for encoding/decoding DWARF discriminators..

Gentle reminder - thanks!

Dec 17 2018, 8:38 AM

Dec 14 2018

mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Adjust includes
Dec 14 2018, 2:33 PM
mtrofin added inline comments to D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 14 2018, 8:51 AM
mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Moved implementation of new APIs to DebugInfoMetadata.cpp.
Dec 14 2018, 8:49 AM

Dec 13 2018

mtrofin updated the diff for D55681: [llvm] API for encoding/decoding DWARF discriminators..
  • Remove unrelated changes (clang-format)
Dec 13 2018, 3:45 PM
mtrofin added reviewers for D55681: [llvm] API for encoding/decoding DWARF discriminators.: davidxl, danielcdh, wmi.
Dec 13 2018, 3:39 PM
mtrofin created D55681: [llvm] API for encoding/decoding DWARF discriminators..
Dec 13 2018, 3:38 PM
mtrofin committed rL349075: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
[llvm] Address base discriminator overflow in X86DiscriminateMemOps
Dec 13 2018, 11:44 AM
mtrofin closed D55643: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
Dec 13 2018, 11:44 AM

Dec 12 2018

mtrofin updated the summary of D55643: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
Dec 12 2018, 8:58 PM
mtrofin created D55643: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
Dec 12 2018, 8:57 PM

Nov 29 2018

mtrofin committed rL347939: Fix build warnings introduced in rL347938.
Fix build warnings introduced in rL347938
Nov 29 2018, 5:56 PM
mtrofin closed D55100: Fix build warnings introduced in rL347938.
Nov 29 2018, 5:56 PM
mtrofin created D55100: Fix build warnings introduced in rL347938.
Nov 29 2018, 5:53 PM
mtrofin abandoned D55099: Fix build warnings introduced in rL347938.

Incorrect revision

Nov 29 2018, 5:49 PM
mtrofin created D55099: Fix build warnings introduced in rL347938.
Nov 29 2018, 5:49 PM
mtrofin updated the summary of D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
Nov 29 2018, 5:44 PM
mtrofin committed rL347938: Revert "Revert r347596 "Support for inserting profile-directed cache….
Revert "Revert r347596 "Support for inserting profile-directed cache…
Nov 29 2018, 5:04 PM
mtrofin closed D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
Nov 29 2018, 5:04 PM
mtrofin added a reviewer for D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"": wmi.
Nov 29 2018, 4:53 PM
mtrofin updated the summary of D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
Nov 29 2018, 4:35 PM
mtrofin added reviewers for D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"": davidxl, hans.
Nov 29 2018, 4:35 PM
mtrofin updated the diff for D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
  • Fix incorrect update of DenseMap in X86DiscriminateMemOps
Nov 29 2018, 4:34 PM
mtrofin created D55088: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
Nov 29 2018, 4:06 PM
mtrofin abandoned D55086: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".

should have split it into the revert diff and then the fix diff, for clarity. Re-doing.

Nov 29 2018, 4:05 PM
mtrofin added a reviewer for D55086: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"": hans.
Nov 29 2018, 3:57 PM
mtrofin created D55086: Revert "Revert r347596 "Support for inserting profile-directed cache prefetches"".
Nov 29 2018, 3:38 PM

Nov 27 2018

mtrofin committed rL347724: Do not insert prefetches with unsupported memory operands..
Do not insert prefetches with unsupported memory operands.
Nov 27 2018, 5:11 PM
mtrofin closed D54983: Do not insert prefetches with unsupported memory operands..
Nov 27 2018, 5:11 PM
mtrofin updated the diff for D54983: Do not insert prefetches with unsupported memory operands..
  • Remove unnecessary space.
Nov 27 2018, 4:51 PM
mtrofin updated the diff for D54983: Do not insert prefetches with unsupported memory operands..
  • More precise verification that the recommendation isn't inserted.
Nov 27 2018, 4:50 PM
mtrofin created D54983: Do not insert prefetches with unsupported memory operands..
Nov 27 2018, 4:35 PM

Nov 26 2018

mtrofin committed rL347607: Add new passes to X86 pipeline tests.
Add new passes to X86 pipeline tests
Nov 26 2018, 2:53 PM
mtrofin closed D54916: Add new passes to X86 pipeline tests.
Nov 26 2018, 2:53 PM
mtrofin created D54916: Add new passes to X86 pipeline tests.
Nov 26 2018, 2:14 PM
mtrofin committed rL347596: Support for inserting profile-directed cache prefetches.
Support for inserting profile-directed cache prefetches
Nov 26 2018, 1:40 PM
mtrofin closed D54052: Support for inserting profile-directed cache prefetches.
Nov 26 2018, 1:40 PM
mtrofin added a comment to D54052: Support for inserting profile-directed cache prefetches.

Weird. I thought I wrote some comments last week, but they obviously didn’t make it in here. Guess I’ll redo that today when I get to the office. One thing I remember is that this patch uses ‘auto’ more than llvm prefers https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable

Nov 26 2018, 10:21 AM

Nov 20 2018

mtrofin updated the diff for D54052: Support for inserting profile-directed cache prefetches.
  • Addressed first round of feedback.
  • Second round of feedback.
  • Avoiding using 'auto' except for iterators.
Nov 20 2018, 2:42 PM
mtrofin added a comment to D54052: Support for inserting profile-directed cache prefetches.

Gentle reminder - Craig, I'd love to hear your feedback. I'm planning to commit early next week (unless I hear otherwise, of course).

Nov 20 2018, 7:58 AM

Nov 7 2018

mtrofin added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 7 2018, 1:40 PM

Nov 6 2018

mtrofin updated the diff for D54052: Support for inserting profile-directed cache prefetches.
  • Second round of feedback.
Nov 6 2018, 2:23 PM

Nov 5 2018

mtrofin added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 5 2018, 12:01 PM
mtrofin updated the diff for D54052: Support for inserting profile-directed cache prefetches.
  • Addressed first round of feedback.
Nov 5 2018, 12:01 PM

Nov 2 2018

mtrofin created D54052: Support for inserting profile-directed cache prefetches.
Nov 2 2018, 2:52 PM

Oct 18 2018

mtrofin committed rL344754: Make Function::getInstructionCount const.
Make Function::getInstructionCount const
Oct 18 2018, 12:51 PM
mtrofin closed D53378: Make Function::getInstructionCount const.
Oct 18 2018, 12:51 PM

Oct 17 2018

mtrofin created D53378: Make Function::getInstructionCount const.
Oct 17 2018, 8:55 AM

Apr 13 2018

mtrofin committed rL330029: [profile] Fix binary format reader error propagation..
[profile] Fix binary format reader error propagation.
Apr 13 2018, 8:08 AM
mtrofin closed D45545: [profile] Fix binary format reader error propagation..
Apr 13 2018, 8:08 AM

Apr 11 2018

mtrofin created D45545: [profile] Fix binary format reader error propagation..
Apr 11 2018, 4:38 PM

Apr 6 2018

mtrofin committed rL329409: [GlobalOpt] Fix support for casts in ctors..
[GlobalOpt] Fix support for casts in ctors.
Apr 6 2018, 8:57 AM
mtrofin closed D45198: [GlobalOpt] Fix support for casts in ctors..
Apr 6 2018, 8:57 AM
mtrofin updated the diff for D45198: [GlobalOpt] Fix support for casts in ctors..
  • Reduced testcase
  • Using ternary operator.
Apr 6 2018, 8:54 AM

Apr 5 2018

mtrofin added inline comments to D45198: [GlobalOpt] Fix support for casts in ctors..
Apr 5 2018, 9:28 PM
mtrofin updated the diff for D45198: [GlobalOpt] Fix support for casts in ctors..
  • Reduced testcase
Apr 5 2018, 9:01 PM

Apr 2 2018

mtrofin added reviewers for D45198: [GlobalOpt] Fix support for casts in ctors.: davidxl, evgeny777.
Apr 2 2018, 10:02 PM
mtrofin created D45198: [GlobalOpt] Fix support for casts in ctors..
Apr 2 2018, 9:59 PM

Mar 26 2018

mtrofin committed rL328603: Revert "Revert "[lit] Generalized /dev/null support on Windows."".
Revert "Revert "[lit] Generalized /dev/null support on Windows.""
Mar 26 2018, 6:42 PM
mtrofin closed D44914: Revert "Revert "[lit] Generalized /dev/null support on Windows."".
Mar 26 2018, 6:42 PM
mtrofin updated the summary of D44914: Revert "Revert "[lit] Generalized /dev/null support on Windows."".
Mar 26 2018, 6:39 PM