Page MenuHomePhabricator

mtrofin (Mircea Trofin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 11:03 PM (380 w, 2 d)

Recent Activity

Today

mtrofin accepted D126453: [test-suite] Disable RSBench and XSBench running on CSKY.
Fri, May 27, 2:49 PM · Restricted Project

Yesterday

mtrofin committed rG6ddc4cd1c23f: Fix break introduced by D124306 (authored by mtrofin).
Fix break introduced by D124306
Thu, May 26, 11:55 AM · Restricted Project, Restricted Project
mtrofin added a comment to D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

This change is breaking the build for me: BooleanOptionalAction is only available in python 3.9!

Well not failing the build but failing various tests for the scripts.

Thu, May 26, 11:51 AM · Restricted Project, Restricted Project
mtrofin committed rGf15c60218d5c: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes (authored by mtrofin).
[UpdateTestChecks] Auto-generate stub bodies for unused prefixes
Thu, May 26, 10:34 AM · Restricted Project, Restricted Project
mtrofin closed D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.
Thu, May 26, 10:34 AM · Restricted Project, Restricted Project
mtrofin added inline comments to D126453: [test-suite] Disable RSBench and XSBench running on CSKY.
Thu, May 26, 8:10 AM · Restricted Project
mtrofin added inline comments to D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.
Thu, May 26, 8:07 AM · Restricted Project, Restricted Project
mtrofin updated the diff for D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

fix

Thu, May 26, 8:07 AM · Restricted Project, Restricted Project

Wed, May 25

mtrofin added inline comments to D125841: [mlgo] Incrementally update FunctionPropertiesInfo during inlining.
Wed, May 25, 1:57 PM · Restricted Project, Restricted Project
mtrofin updated the diff for D125841: [mlgo] Incrementally update FunctionPropertiesInfo during inlining.

feedback

Wed, May 25, 1:57 PM · Restricted Project, Restricted Project
mtrofin accepted D100926: [test-suite] Add C-SKY Support in benchmark 1.3.0.
Wed, May 25, 7:56 AM · Restricted Project

Tue, May 24

mtrofin added a comment to D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

I haven't checked the implementation, but conceptually this looks reasonable.

[UpdateTestChecks] Auto-generate stub bodies for conflicting outputs

Patch title seems unrelated though?

Tue, May 24, 5:27 PM · Restricted Project, Restricted Project
mtrofin retitled D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes from [UpdateTestChecks] Auto-generate stub bodies for conflicting outputs to [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.
Tue, May 24, 5:25 PM · Restricted Project, Restricted Project
mtrofin added inline comments to D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.
Tue, May 24, 10:35 AM · Restricted Project, Restricted Project
mtrofin updated the diff for D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

make sure 1) re-running tool doesn't repeat the unused note; and 2) adding a use for a previously unused label removes that label from the note list.

Tue, May 24, 10:34 AM · Restricted Project, Restricted Project
mtrofin added a comment to D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

@RKSimon @lebedev.ri @probinson @nikic @xbolva00 - any pushback to this patch, is it helping/hindering in any way? Thanks!

Tue, May 24, 8:07 AM · Restricted Project, Restricted Project
mtrofin added a comment to D100926: [test-suite] Add C-SKY Support in benchmark 1.3.0.

The same work has been upstreamed at https://github.com/google/benchmark/pull/1400.
And how is this patch going? we need pull latest code to upgrade benchmark or still commit this in llvm-test-suite?
@mtrofin

Tue, May 24, 7:38 AM · Restricted Project

Mon, May 23

mtrofin updated the diff for D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.

double-commenting the "NOTE", also fix in update_cc_test_checks

Mon, May 23, 4:24 PM · Restricted Project, Restricted Project

Thu, May 19

mtrofin added a reviewer for D125841: [mlgo] Incrementally update FunctionPropertiesInfo during inlining: phosek.
Thu, May 19, 12:22 PM · Restricted Project, Restricted Project

Tue, May 17

mtrofin requested review of D125841: [mlgo] Incrementally update FunctionPropertiesInfo during inlining.
Tue, May 17, 3:49 PM · Restricted Project, Restricted Project

Fri, May 13

mtrofin updated subscribers of D124565: [mlgo] Support exposing more features than those supported by models.

Hmm... there may be something else here. I did this, by looking at
https://lab.llvm.org/buildbot/#/builders/169/builds/8182/steps/7/logs/stdio

Fri, May 13, 2:54 PM · Restricted Project, Restricted Project

Wed, May 11

mtrofin committed rG0cc607345fa5: [mlgo] Fix test (authored by mtrofin).
[mlgo] Fix test
Wed, May 11, 10:08 AM · Restricted Project, Restricted Project
mtrofin accepted D125321: [InstCombine] Freeze other uses of frozen value.
Wed, May 11, 7:33 AM · Restricted Project, Restricted Project

Tue, May 10

mtrofin added a comment to D125248: [instcombine] Propagate freeze back to def.

I've put up https://reviews.llvm.org/D125321, which extends freezeDominatedUses() to move the freeze such that it dominates all uses (if possible).

Yup, thanks!. I'm not super sure why we'd want to insert the new freeze first (potentially) in the middle of the original's uses, then hoist it to dominate all uses (rather than place it "at the right place" upfront), but likely I'm missing some design nuance of this pass. I'm not hung up on this - asking to learn.

Hoisting the freeze insertion point in pushFreezeToPreventPoisonFromPropagating() fixes the problem for freeze instructions introduced by that transform -- but it does not fix the problem for freeze instructions introduced by other (likely non-InstCombine) transforms. For that reason this should be handled by two separate folds that can apply independently of each other (though they would usually work in tandem).

Tue, May 10, 12:49 PM · Restricted Project, Restricted Project
mtrofin abandoned D125248: [instcombine] Propagate freeze back to def.

I've put up https://reviews.llvm.org/D125321, which extends freezeDominatedUses() to move the freeze such that it dominates all uses (if possible).

Tue, May 10, 10:33 AM · Restricted Project, Restricted Project
mtrofin added a comment to D125321: [InstCombine] Freeze other uses of frozen value.

could you also add the test from D125248 - can't hurt to have more.

Tue, May 10, 10:26 AM · Restricted Project, Restricted Project

Mon, May 9

mtrofin committed rGc35ad9ee4f21: [mlgo] Support exposing more features than those supported by models (authored by mtrofin).
[mlgo] Support exposing more features than those supported by models
Mon, May 9, 6:02 PM · Restricted Project, Restricted Project
mtrofin closed D124565: [mlgo] Support exposing more features than those supported by models.
Mon, May 9, 6:01 PM · Restricted Project, Restricted Project
mtrofin added a comment to D125248: [instcombine] Propagate freeze back to def.

I don't think this is the right place to do this. You should either:

  1. Remove the one-use restriction on this fold, and replace other uses with the frozen variant as well. This is on the premise that pushing freeze higher is more worthwhile than having some un-frozen uses.
  1. Adjust the freezeDominatedUses() fold to freeze not only dominated uses. Basically canonicalize %x to freeze %x. This is on the premise that allowing more exploitation of value identity is more worthwhile than having un-frozen uses.

I think in either case the freeze %s def needs to dominate its uses.

Sure -- to be clear, the suggestion for the second approach is to move the freeze up so that it does dominate all uses and allows all of them to be replaced. This is basically what you're doing here, with the crucial difference that it happens for all freeze instructions, not just the ones produced by this particular transform.

There is a tradeoff here between leaving some uses to not use freeze (and possibly allowing additional optimizations for them, as freeze is usually an optimization-blocker) and allowing folds based on value-identity (which benefit from all uses being freeze(%x), not %x).

With that in mind, I would probably lean toward dropping the one-use check on this fold as a starting point -- it's more conservative, but should still cover your motivating case.

Mon, May 9, 3:56 PM · Restricted Project, Restricted Project
mtrofin added a comment to D125248: [instcombine] Propagate freeze back to def.

I don't think this is the right place to do this. You should either:

  1. Remove the one-use restriction on this fold, and replace other uses with the frozen variant as well. This is on the premise that pushing freeze higher is more worthwhile than having some un-frozen uses.
  1. Adjust the freezeDominatedUses() fold to freeze not only dominated uses. Basically canonicalize %x to freeze %x. This is on the premise that allowing more exploitation of value identity is more worthwhile than having un-frozen uses.
Mon, May 9, 2:15 PM · Restricted Project, Restricted Project
mtrofin added inline comments to D125248: [instcombine] Propagate freeze back to def.
Mon, May 9, 11:11 AM · Restricted Project, Restricted Project
mtrofin requested review of D125248: [instcombine] Propagate freeze back to def.
Mon, May 9, 11:09 AM · Restricted Project, Restricted Project

Mon, May 2

mtrofin updated the summary of D124565: [mlgo] Support exposing more features than those supported by models.
Mon, May 2, 1:09 PM · Restricted Project, Restricted Project
mtrofin added a comment to D124565: [mlgo] Support exposing more features than those supported by models.

what restricts that "the new features must be appended at the end of the list of features requested from the model"?

It's a requirement for development mode only (updated to clarify). To your question, see TFUtils.cpp, lines 303 and then the added lines 309 and below.

Mon, May 2, 1:08 PM · Restricted Project, Restricted Project
mtrofin updated the diff for D124565: [mlgo] Support exposing more features than those supported by models.

clarify "new features at the end" is a requirement for dev mode only

Mon, May 2, 1:07 PM · Restricted Project, Restricted Project

Thu, Apr 28

mtrofin added a comment to rG75881d8b023e: [NFC] const-ed the return type of FunctionPropertiesAnalysis.

That's a good question. I *think* that would be in the spirit of the
analysis manager, but i also think i tried that once and there were issues,
and punted to "when i have some time to look again" (so... not yet :) )

Thu, Apr 28, 6:35 PM · Restricted Project, Restricted Project
mtrofin committed rG49942d595f21: [NFC] remove const from FunctionPropertiesAnalysis::run, keep on Result (authored by mtrofin).
[NFC] remove const from FunctionPropertiesAnalysis::run, keep on Result
Thu, Apr 28, 3:14 PM · Restricted Project, Restricted Project
mtrofin updated subscribers of rG75881d8b023e: [NFC] const-ed the return type of FunctionPropertiesAnalysis.

Right - the return there would be silly in isolation. However, the Result
type is what the analysis manager's getResult returns:

Thu, Apr 28, 2:55 PM · Restricted Project, Restricted Project
mtrofin committed rG75881d8b023e: [NFC] const-ed the return type of FunctionPropertiesAnalysis (authored by mtrofin).
[NFC] const-ed the return type of FunctionPropertiesAnalysis
Thu, Apr 28, 12:42 PM · Restricted Project, Restricted Project

Apr 27 2022

mtrofin added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
Apr 27 2022, 4:25 PM · Restricted Project, Restricted Project
mtrofin requested review of D124565: [mlgo] Support exposing more features than those supported by models.
Apr 27 2022, 3:34 PM · Restricted Project, Restricted Project

Apr 25 2022

mtrofin committed rGb1fa5ac3ba34: [mlgo] Factor out TensorSpec (authored by mtrofin).
[mlgo] Factor out TensorSpec
Apr 25 2022, 6:46 PM · Restricted Project, Restricted Project
mtrofin closed D124417: [mlgo] Factor out TensorSpec.
Apr 25 2022, 6:45 PM · Restricted Project, Restricted Project
mtrofin updated the diff for D124417: [mlgo] Factor out TensorSpec.

forgot to remove some defs

Apr 25 2022, 1:55 PM · Restricted Project, Restricted Project
mtrofin requested review of D124417: [mlgo] Factor out TensorSpec.
Apr 25 2022, 1:53 PM · Restricted Project, Restricted Project

Apr 22 2022

mtrofin requested review of D124306: [UpdateTestChecks] Auto-generate stub bodies for unused prefixes.
Apr 22 2022, 3:06 PM · Restricted Project, Restricted Project
mtrofin added a comment to D121343: Update benchmarks.

As a workaround, what if we wrapped the check in an if(NOT APPLE)?

Apr 22 2022, 12:36 PM · Restricted Project
mtrofin accepted D124233: [InlineCost] Set LastCallToStaticBonus in ML inlining models..

lgtm, thanks!

Apr 22 2022, 9:28 AM · Restricted Project, Restricted Project

Apr 21 2022

mtrofin committed rGe4794ff5c685: [mlgo][nfc] Decouple TensorSpec from tensorflow. (authored by mtrofin).
[mlgo][nfc] Decouple TensorSpec from tensorflow.
Apr 21 2022, 3:37 PM · Restricted Project, Restricted Project
mtrofin closed D124045: [mlgo][nfc] Decouple TensorSpec from tensorflow..
Apr 21 2022, 3:37 PM · Restricted Project, Restricted Project
mtrofin added a comment to D122316: Guard visibility variables on AIX.

LGTM as an interm fix. We'll revert and replace this once we have a fix in Google Benchmark.

Apologies if I missed it, has the google/benchmarks PR been submitted? Thanks!

Hi, we are looking at fixing the visibility issue instead: https://discourse.llvm.org/t/rfc-adding-exported-visibility-style-to-the-ir-to-model-xcoff-exported-visibility/61853/4. Then we can revert this patch after.

Apr 21 2022, 8:28 AM · Restricted Project

Apr 19 2022

mtrofin requested review of D124045: [mlgo][nfc] Decouple TensorSpec from tensorflow..
Apr 19 2022, 2:29 PM · Restricted Project, Restricted Project

Apr 18 2022

mtrofin added a comment to D122316: Guard visibility variables on AIX.

LGTM as an interm fix. We'll revert and replace this once we have a fix in Google Benchmark.

Apr 18 2022, 11:24 AM · Restricted Project

Apr 16 2022

mtrofin added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Once again, let's cut on the bikeshedding here, please.
This is only affects X86 codegen tests, all of which should be autogenerated in the first place, so the check prefix can not be wrong in the first place.

Apr 16 2022, 11:08 AM · Restricted Project, Restricted Project
mtrofin added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Added David back - he had some concerns and a good (I think) suggestion. Could this patch do his “UTC_ARGS: —allow-unused-prefixes” suggestion instead? Seems it wouldn't be any bigger of a change, and I think everybody would have their concerns addressed.

Everybody except me? :)

My understanding is that his proposal will make any test generated with one of the auto-generators automatically enrolled into --allow-unused-prefixes. Wouldn't that address your scenario?

  1. It's a workaround for the case of unchanged default. I'm interested in fixing the default, not workarounding it.
Apr 16 2022, 11:00 AM · Restricted Project, Restricted Project
mtrofin added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Added David back - he had some concerns and a good (I think) suggestion. Could this patch do his “UTC_ARGS: —allow-unused-prefixes” suggestion instead? Seems it wouldn't be any bigger of a change, and I think everybody would have their concerns addressed.

Everybody except me? :)

Apr 16 2022, 10:27 AM · Restricted Project, Restricted Project
mtrofin added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Added David back - he had some concerns and a good (I think) suggestion. Could this patch do his “UTC_ARGS: —allow-unused-prefixes” suggestion instead? Seems it wouldn't be any bigger of a change, and I think everybody would have their concerns addressed.

Apr 16 2022, 9:56 AM · Restricted Project, Restricted Project
mtrofin added a reviewer for D123897: [X86] Unbreak LIT/FileCheck: xbolva00.
Apr 16 2022, 9:51 AM · Restricted Project, Restricted Project
mtrofin added a comment to D121343: Update benchmarks.

@mtrofin Everything these bots does is sets up a fresh environment each time, so there ought to be nothing left over from previous runs. Everything is done in a new directory each time IIRC, so we get a clean build every time.

Apr 16 2022, 8:58 AM · Restricted Project
mtrofin added a comment to D123897: [X86] Unbreak LIT/FileCheck.

If a new test needs, it can specify ‘ --allow-unused-prefixes’ explicitly, no? If we apply patch like this one to more and more folders, than original work was a wasted effort.

Apr 16 2022, 8:27 AM · Restricted Project, Restricted Project

Apr 15 2022

mtrofin added a comment to D121343: Update benchmarks.

This is also hitting the x86-64 macOS bots 😢

https://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-x86_64-O3/

I wonder if the issue is something to do with how we set up the Xcode SDK? Both the AArch64 + x86 test suite builders use this CMake cache:

https://github.com/llvm/llvm-zorg/blob/f785f4216432aa0d249ee3ad1f86515caf4c7b10/tasks/cmake/caches/util/xcode_sdk.cmake

Apr 15 2022, 7:03 AM · Restricted Project

Apr 14 2022

mtrofin added a comment to D121343: Update benchmarks.

This is also hitting the x86-64 macOS bots 😢

https://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-x86_64-O3/

I wonder if the issue is something to do with how we set up the Xcode SDK? Both the AArch64 + x86 test suite builders use this CMake cache:

https://github.com/llvm/llvm-zorg/blob/f785f4216432aa0d249ee3ad1f86515caf4c7b10/tasks/cmake/caches/util/xcode_sdk.cmake

@mtrofin, does anything stand out to you here?

Apr 14 2022, 7:17 PM · Restricted Project

Apr 2 2022

mtrofin added inline comments to D121343: Update benchmarks.
Apr 2 2022, 9:51 AM · Restricted Project
mtrofin added inline comments to D121343: Update benchmarks.
Apr 2 2022, 8:43 AM · Restricted Project

Mar 22 2022

mtrofin committed rZORG92909793448c: [mlgo] Add worker watch notification (authored by mtrofin).
[mlgo] Add worker watch notification
Mar 22 2022, 12:09 PM · Restricted Project
mtrofin closed D122235: [mlgo] Add worker watch notification.
Mar 22 2022, 12:09 PM · Restricted Project
mtrofin updated the diff for D122235: [mlgo] Add worker watch notification.

feedback

Mar 22 2022, 12:08 PM · Restricted Project
mtrofin added inline comments to D122235: [mlgo] Add worker watch notification.
Mar 22 2022, 12:08 PM · Restricted Project
mtrofin requested review of D122235: [mlgo] Add worker watch notification.
Mar 22 2022, 8:48 AM · Restricted Project

Mar 21 2022

mtrofin committed rGf658ca1abacc: [mlgo] Fix build breaks introduced by includes cleanups (authored by mtrofin).
[mlgo] Fix build breaks introduced by includes cleanups
Mar 21 2022, 1:50 PM · Restricted Project

Mar 14 2022

mtrofin committed rG294eca35a00f: [regalloc] Remove -consider-local-interval-cost (authored by mtrofin).
[regalloc] Remove -consider-local-interval-cost
Mar 14 2022, 10:49 AM · Restricted Project
mtrofin closed D121128: [regalloc] Remove -consider-local-interval-cost.
Mar 14 2022, 10:49 AM · Restricted Project, Restricted Project

Mar 10 2022

mtrofin committed rTb1854dff9165: Update benchmarks (authored by mtrofin).
Update benchmarks
Mar 10 2022, 12:11 PM · Restricted Project
mtrofin closed D121343: Update benchmarks.
Mar 10 2022, 12:11 PM · Restricted Project

Mar 9 2022

mtrofin requested review of D121343: Update benchmarks.
Mar 9 2022, 2:53 PM · Restricted Project

Mar 7 2022

Herald added a project to D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration: Restricted Project.
Mar 7 2022, 8:35 AM · Restricted Project, Restricted Project
mtrofin requested review of D121128: [regalloc] Remove -consider-local-interval-cost.
Mar 7 2022, 8:30 AM · Restricted Project, Restricted Project

Mar 3 2022

Herald added a project to D118090: [ScalarEvolution] Handle <= and >= in non infinite loops: Restricted Project.

I concur with @nikic

Mar 3 2022, 7:25 PM · Restricted Project, Restricted Project
mtrofin accepted D120752: [RegAlloc] Add a complexity limit in growRegion() to cap compilation time..

Nit: can you please rephrase the commit message, last statement: the patch (correctly) doesn't place a limit on time (which would be non-deterministic), rather, it places a limit on the number of Blocks visited (deterministic).

Mar 3 2022, 10:11 AM · Restricted Project, Restricted Project

Mar 1 2022

mtrofin committed rGcb2160760e67: [nfc][codegen] Move RegisterBank[Info].h under CodeGen (authored by mtrofin).
[nfc][codegen] Move RegisterBank[Info].h under CodeGen
Mar 1 2022, 9:53 PM · Restricted Project
mtrofin closed D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen.
Mar 1 2022, 9:53 PM · Restricted Project, Restricted Project, Restricted Project
mtrofin committed rG261419273a0a: Fix build breaks on ml-* bots introduced by include cleanups (authored by mtrofin).
Fix build breaks on ml-* bots introduced by include cleanups
Mar 1 2022, 11:29 AM
mtrofin added inline comments to D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen.
Mar 1 2022, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
mtrofin added a comment to D118090: [ScalarEvolution] Handle <= and >= in non infinite loops.

This change has the side-effect of making SCEVExpander::isHighCostExpansion return true and thus block loop unrolling, which is the root cause of the performance degradation that led to 7e3606f43c63.

Before, the expression was:

(1 + ((-2 + %1) /u 2))<nuw>

with this change, the expression becomes:

(1 + ((-3 + (4 smax (1 + %1)<nsw>))<nsw> /u 2))<nuw><nsw>

The Budget is always 4, but the second expression trips over it (the (4 smax (1 + %1)<nsw>) subexpression raises the cost to 5)

Could you please provide the input IR that is affected? We'd probably want to generate a better BECount than try to adjust cost modelling.

Mar 1 2022, 8:34 AM · Restricted Project, Restricted Project
mtrofin added a comment to D118090: [ScalarEvolution] Handle <= and >= in non infinite loops.

This change has the side-effect of making SCEVExpander::isHighCostExpansion return true and thus block loop unrolling, which is the root cause of the performance degradation that led to 7e3606f43c63.

Mar 1 2022, 8:12 AM · Restricted Project, Restricted Project
mtrofin added a comment to D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen.

As this is a follow-up of a refactoring, I assume I can just land it (short of file header comments, there was nothing really this patch did more intelligently)

Mar 1 2022, 7:59 AM · Restricted Project, Restricted Project, Restricted Project
mtrofin added a reviewer for D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline: kazu.
Mar 1 2022, 7:23 AM · Restricted Project, Restricted Project
mtrofin added a comment to D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline.

will fix the two failing tests if we like this patch

this does cause fewer instances of inlining on llvm-test-suite

I did some performance testing on some internal benchmarks, seeing mixed results

Mar 1 2022, 7:23 AM · Restricted Project, Restricted Project

Feb 25 2022

mtrofin committed rWa0b98b91fdab: [gsoc] fixed TOC links (authored by mtrofin).
[gsoc] fixed TOC links
Feb 25 2022, 2:08 PM
mtrofin committed rW5647d1d9db7e: Forgot discourse link for Module Inliner work (authored by mtrofin).
Forgot discourse link for Module Inliner work
Feb 25 2022, 2:01 PM
mtrofin committed rW1f63eefe2b78: [gsoc] Add Module Inliner project (authored by mtrofin).
[gsoc] Add Module Inliner project
Feb 25 2022, 2:00 PM
mtrofin committed rW9c173167bb62: [gsoc][mlgo] Add more data about projects (authored by mtrofin).
[gsoc][mlgo] Add more data about projects
Feb 25 2022, 1:40 PM

Feb 23 2022

mtrofin committed rG7e3606f43c63: [ScalarEvolution] Control flag for nonstrict inequalities in finite loops (authored by mtrofin).
[ScalarEvolution] Control flag for nonstrict inequalities in finite loops
Feb 23 2022, 5:57 PM

Feb 21 2022

mtrofin committed rWdc6c7a5c402d: [GSoC] Add 2 mlgo projects (authored by mtrofin).
[GSoC] Add 2 mlgo projects
Feb 21 2022, 10:15 PM

Feb 15 2022

mtrofin accepted D119882: [buildbot] Enable CCACHE for all stages of ThinLTO WPD worker.
Feb 15 2022, 12:16 PM
mtrofin added inline comments to D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen.
Feb 15 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
mtrofin requested review of D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen.
Feb 15 2022, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
mtrofin committed rGc62eefb8863e: [nfc][codegen] Move RegisterBank[Info].cpp under CodeGen (authored by mtrofin).
[nfc][codegen] Move RegisterBank[Info].cpp under CodeGen
Feb 15 2022, 11:28 AM
mtrofin closed D119053: [nfc][codegen] Move RegisterBank[Info].cpp under CodeGen.
Feb 15 2022, 11:27 AM · Restricted Project
mtrofin added a comment to D119053: [nfc][codegen] Move RegisterBank[Info].cpp under CodeGen.

Just want to double check: You have a (possibly downstream) use case that wants to leverage RegisterBank without linking GlobalISel, is that correct?

Yes, a subsequent change would do that: add bank-ness info as a feature to the ML eviction advisor.

Feb 15 2022, 10:14 AM · Restricted Project