Page MenuHomePhabricator

Adding sin op in the GLSL extension
ClosedPublic

Authored by NatashaKnk on Feb 6 2020, 11:46 AM.

Event Timeline

NatashaKnk created this revision.Feb 6 2020, 11:46 AM
mravishankar requested changes to this revision.Feb 6 2020, 2:26 PM

Thanks Natasha! This needs tests though.
See mlir/test/Dialect/SPIRV/glslops.mlir for similar ops. These are round-trip tests. It checks that mlir can parse the operation and print it out correctly
You also need "Serialization" tests, i.e. MLIR can generate valid SPIR-V binary for this operation. See mlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir

This revision now requires changes to proceed.Feb 6 2020, 2:26 PM
NatashaKnk updated this revision to Diff 243075.Feb 6 2020, 9:11 PM

Updating D74151: Adding sin op in the GLSL extension

Added tests for both Sin and Cos operation.

NatashaKnk updated this revision to Diff 243076.Feb 6 2020, 9:30 PM
  1. Updating D74151: Adding sin op in the GLSL extension #

Fixing accidentally added files

mravishankar accepted this revision.Feb 6 2020, 10:50 PM

THanks for adding the cosine tests too...

This revision is now accepted and ready to land.Feb 6 2020, 10:50 PM
This revision was automatically updated to reflect the committed changes.