Page MenuHomePhabricator

liufengdb (Feng Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2019, 8:01 PM (76 w, 4 d)

Recent Activity

Feb 9 2021

liufengdb abandoned D77521: Skip the op replacement if the returned results are empty.
Feb 9 2021, 9:30 AM · Restricted Project, Restricted Project

Nov 30 2020

liufengdb added a comment to D92116: Added one argument to the inline methods to collect all the inlined ops.

Let me try it out. Thanks for the suggestion!

Nov 30 2020, 2:12 PM · Restricted Project
liufengdb added a comment to D92005: Add attributes to the inlined operations.

I created a separate patch https://reviews.llvm.org/D92116. Can you take a look?

Nov 30 2020, 10:35 AM · Restricted Project

Nov 25 2020

liufengdb updated the diff for D92116: Added one argument to the inline methods to collect all the inlined ops.
  • fix the method
Nov 25 2020, 11:39 AM · Restricted Project
liufengdb updated the diff for D92116: Added one argument to the inline methods to collect all the inlined ops.
  • fix the method
Nov 25 2020, 10:57 AM · Restricted Project
liufengdb updated the diff for D92116: Added one argument to the inline methods to collect all the inlined ops.

include more

Nov 25 2020, 10:50 AM · Restricted Project
liufengdb updated the diff for D92116: Added one argument to the inline methods to collect all the inlined ops.

fix the compiling

Nov 25 2020, 10:49 AM · Restricted Project
liufengdb requested review of D92116: Added one argument to the inline methods to collect all the inlined ops.
Nov 25 2020, 10:42 AM · Restricted Project

Nov 24 2020

liufengdb committed rG760063267c46: Fix CalibratedQuantizedType's print function to match parser (authored by Tei Jeong <taeheej@google.com>).
Fix CalibratedQuantizedType's print function to match parser
Nov 24 2020, 9:36 AM
liufengdb closed D92034: Fix CalibratedQuantizedType's print function to match parser.
Nov 24 2020, 9:36 AM · Restricted Project
liufengdb accepted D92034: Fix CalibratedQuantizedType's print function to match parser.
Nov 24 2020, 9:32 AM · Restricted Project
liufengdb added a comment to D92005: Add attributes to the inlined operations.

This is to propagate the attributes, such as "device" and "_tpu_replicate", to the inlined operations. These attributes might be different at different call sites, so we couldn't set them in the src.
An alternative implementation is the inlineCall method returns all the new inlined operations, so the caller can set them.

Nov 24 2020, 9:26 AM · Restricted Project

Nov 23 2020

liufengdb updated the diff for D92005: Add attributes to the inlined operations.

removed the unused file

Nov 23 2020, 10:19 PM · Restricted Project
liufengdb requested review of D92005: Add attributes to the inlined operations.
Nov 23 2020, 10:17 PM · Restricted Project

Nov 17 2020

liufengdb committed rG94e4ec6499a2: Add CalibratedQuantizedType to quant dialect (authored by Tei Jeong <taeheej@google.com>).
Add CalibratedQuantizedType to quant dialect
Nov 17 2020, 10:17 PM
liufengdb closed D91584: Add CalibratedQuantizedType to quant dialect.
Nov 17 2020, 10:17 PM · Restricted Project
liufengdb added inline comments to D91584: Add CalibratedQuantizedType to quant dialect.
Nov 17 2020, 8:42 AM · Restricted Project

Aug 7 2020

liufengdb committed rG5c9c4ade9d12: Add the inline interface to the shape dialect (authored by liufengdb).
Add the inline interface to the shape dialect
Aug 7 2020, 11:30 PM
liufengdb closed D85556: Add the inline interface to the shape dialect.
Aug 7 2020, 11:30 PM · Restricted Project
liufengdb updated the diff for D85556: Add the inline interface to the shape dialect.

fix doc

Aug 7 2020, 7:24 PM · Restricted Project
liufengdb updated the diff for D85556: Add the inline interface to the shape dialect.

fix the test error

Aug 7 2020, 5:39 PM · Restricted Project
liufengdb updated the diff for D85556: Add the inline interface to the shape dialect.

add a test

Aug 7 2020, 5:18 PM · Restricted Project
liufengdb updated the diff for D85556: Add the inline interface to the shape dialect.

fix the lint

Aug 7 2020, 2:16 PM · Restricted Project
liufengdb requested review of D85556: Add the inline interface to the shape dialect.
Aug 7 2020, 2:15 PM · Restricted Project

Jun 23 2020

liufengdb added reviewers for D82406: [mlir] Support iterator arguments in the loop unrolling: rriddle, ftynse.
Jun 23 2020, 4:44 PM · Restricted Project
liufengdb updated the diff for D82406: [mlir] Support iterator arguments in the loop unrolling.

remove unused

Jun 23 2020, 4:43 PM · Restricted Project
liufengdb updated the diff for D82406: [mlir] Support iterator arguments in the loop unrolling.

remove the redundant comments

Jun 23 2020, 4:43 PM · Restricted Project
liufengdb updated the diff for D82406: [mlir] Support iterator arguments in the loop unrolling.

fix some test failures

Jun 23 2020, 4:43 PM · Restricted Project
liufengdb created D82406: [mlir] Support iterator arguments in the loop unrolling.
Jun 23 2020, 1:26 PM · Restricted Project
liufengdb committed rG5048933c4715: [mlir] Added the dialect inliner to the SCF dialect (authored by liufengdb).
[mlir] Added the dialect inliner to the SCF dialect
Jun 23 2020, 11:16 AM
liufengdb closed D82336: [mlir] Added the dialect inliner to the SCF dialect.
Jun 23 2020, 11:16 AM · Restricted Project
liufengdb updated the diff for D82336: [mlir] Added the dialect inliner to the SCF dialect.

fix the typo

Jun 23 2020, 10:43 AM · Restricted Project

Jun 22 2020

liufengdb updated the diff for D82336: [mlir] Added the dialect inliner to the SCF dialect.

Add the terminator op handling

Jun 22 2020, 9:29 PM · Restricted Project
liufengdb added reviewers for D82336: [mlir] Added the dialect inliner to the SCF dialect: rriddle, ftynse.
Jun 22 2020, 4:07 PM · Restricted Project
liufengdb created D82336: [mlir] Added the dialect inliner to the SCF dialect.
Jun 22 2020, 4:07 PM · Restricted Project

Apr 23 2020

liufengdb committed rGb578c92a9898: [mlir/Quant] Allows to use 32 bits storage type (authored by liufengdb).
[mlir/Quant] Allows to use 32 bits storage type
Apr 23 2020, 11:23 AM
liufengdb closed D78671: [mlir/Quant] Allows to use 32 bits storage type.
Apr 23 2020, 11:23 AM · Restricted Project

Apr 22 2020

liufengdb added a reviewer for D78671: [mlir/Quant] Allows to use 32 bits storage type: stellaraccident.
Apr 22 2020, 2:41 PM · Restricted Project
liufengdb added a reviewer for D78671: [mlir/Quant] Allows to use 32 bits storage type: antiagainst.
Apr 22 2020, 2:41 PM · Restricted Project
liufengdb created D78671: [mlir/Quant] Allows to use 32 bits storage type.
Apr 22 2020, 2:41 PM · Restricted Project

Apr 5 2020

liufengdb updated the diff for D77521: Skip the op replacement if the returned results are empty.

add the erase op

Apr 5 2020, 10:56 PM · Restricted Project, Restricted Project
liufengdb created D77521: Skip the op replacement if the returned results are empty.
Apr 5 2020, 10:25 PM · Restricted Project, Restricted Project

Mar 20 2020

liufengdb committed rG942afe0cb2ac: [mlir/quant] fix a small typo in the quant utility (authored by liufengdb).
[mlir/quant] fix a small typo in the quant utility
Mar 20 2020, 10:18 AM
liufengdb closed D76442: [mlir/quant] fix a small typo in the quant utility.
Mar 20 2020, 10:18 AM · Restricted Project

Mar 19 2020

liufengdb created D76442: [mlir/quant] fix a small typo in the quant utility.
Mar 19 2020, 11:59 AM · Restricted Project

Mar 16 2020

liufengdb committed rG166f83f43660: [QuantOps] Add the quant region definition (authored by liufengdb).
[QuantOps] Add the quant region definition
Mar 16 2020, 3:52 PM
liufengdb closed D75972: [QuantOps] Add the quant region definition.
Mar 16 2020, 3:52 PM · Restricted Project
liufengdb updated the diff for D75972: [QuantOps] Add the quant region definition.

fix comments

Mar 16 2020, 2:12 PM · Restricted Project

Mar 10 2020

liufengdb updated the diff for D75972: [QuantOps] Add the quant region definition.

fix a typo

Mar 10 2020, 11:00 PM · Restricted Project
liufengdb created D75972: [QuantOps] Add the quant region definition.
Mar 10 2020, 11:00 PM · Restricted Project
liufengdb added a reviewer for D75972: [QuantOps] Add the quant region definition: stellaraccident.
Mar 10 2020, 11:00 PM · Restricted Project

Feb 10 2020

liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

add a new line at the end

Feb 10 2020, 10:09 AM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

find out the first available file line loc in the fused loc

Feb 10 2020, 10:04 AM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

Use the first location in the fused location for diagnostic handler

Feb 10 2020, 9:46 AM · Restricted Project

Jan 6 2020

liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

fix

Jan 6 2020, 2:44 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

fix the rebase error

Jan 6 2020, 2:35 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

rebase

Jan 6 2020, 2:07 PM · Restricted Project

Dec 28 2019

liufengdb added inline comments to D71851: Use the first location in the fused location for diagnostic handler.
Dec 28 2019, 11:56 AM · Restricted Project
liufengdb added inline comments to D71851: Use the first location in the fused location for diagnostic handler.
Dec 28 2019, 10:25 AM · Restricted Project

Dec 27 2019

liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

create a test handler and add unit tests

Dec 27 2019, 5:41 AM · Restricted Project

Dec 26 2019

liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

remove unused include

Dec 26 2019, 10:34 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

Add unit test

Dec 26 2019, 10:25 PM · Restricted Project
liufengdb created D71918: fix river's comment and add the test.
Dec 26 2019, 10:24 PM · Restricted Project
liufengdb abandoned D71918: fix river's comment and add the test.
Dec 26 2019, 10:24 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.
  • fix the stack
  • fix the typo
  • fix river's comment
Dec 26 2019, 4:41 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.
  • fix river's comment
Dec 26 2019, 12:23 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.
  • fix river's comment
Dec 26 2019, 11:46 AM · Restricted Project

Dec 24 2019

liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.
  • fix river's comment
Dec 24 2019, 9:30 PM · Restricted Project

Dec 23 2019

liufengdb added a reviewer for D71851: Use the first location in the fused location for diagnostic handler: rriddle.
Dec 23 2019, 10:43 PM · Restricted Project
liufengdb updated the diff for D71851: Use the first location in the fused location for diagnostic handler.

Use the first location in the fused location for diagnostic handler

Dec 23 2019, 10:43 PM · Restricted Project
liufengdb created D71851: Use the first location in the fused location for diagnostic handler.
Dec 23 2019, 9:34 PM · Restricted Project
A. Unique TensorFlower <gardener@tensorflow.org> committed rG8c95223e3c95: Add `axis` attribute to the quant.stats op (authored by liufengdb).
Add `axis` attribute to the quant.stats op
Dec 23 2019, 9:05 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGc8961d408ee0: Quantize attribute values by per axis quantization parameters (authored by liufengdb).
Quantize attribute values by per axis quantization parameters
Dec 23 2019, 8:54 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGcf0a78233908: Remove the constraint that min / max should stride zero (authored by liufengdb).
Remove the constraint that min / max should stride zero
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGc68d5467d604: Convert ConstFakeQuantPerAxis to qcast and dcast pair (authored by liufengdb).
Convert ConstFakeQuantPerAxis to qcast and dcast pair
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf4ae4762bf7d: Add quant.const_fake_quant_per_axis op (authored by liufengdb).
Add quant.const_fake_quant_per_axis op
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd3a6dbc0b895: [NFC] Rename ExpressedToUniformQuantizedType to ExpressedToQuantizedType (authored by liufengdb).
[NFC] Rename ExpressedToUniformQuantizedType to ExpressedToQuantizedType
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG27d776fa6d04: Convert per channel fake quant attributes to type (authored by liufengdb).
Convert per channel fake quant attributes to type
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG6de6c2c13828: Add tests to verify 0.0 is quantized correctly (authored by liufengdb).
Add tests to verify 0.0 is quantized correctly
Dec 23 2019, 8:50 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG7dd5efdf2c21: Fix the equality check of two floating point values (authored by liufengdb).
Fix the equality check of two floating point values
Dec 23 2019, 8:50 PM