Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

NatashaKnk (Natasha Kononenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2020, 11:42 AM (190 w, 5 d)

Recent Activity

Wed, Sep 6

NatashaKnk requested review of D159473: [mlir][tosa]Create a check for i64 input in apply_scale lowering in TosaToArith.
Wed, Sep 6, 2:16 PM · Restricted Project, Restricted Project
NatashaKnk abandoned D159472: Add apply_scale check for a case where the input is i64 in TosaToArith.
Wed, Sep 6, 1:46 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D159472: Add apply_scale check for a case where the input is i64 in TosaToArith.

Fix test case

Wed, Sep 6, 1:46 PM · Restricted Project, Restricted Project
NatashaKnk added a reviewer for D159472: Add apply_scale check for a case where the input is i64 in TosaToArith: rsuderman.
Wed, Sep 6, 1:40 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D159472: Add apply_scale check for a case where the input is i64 in TosaToArith.

Fix test

Wed, Sep 6, 1:39 PM · Restricted Project, Restricted Project
NatashaKnk requested review of D159472: Add apply_scale check for a case where the input is i64 in TosaToArith.
Wed, Sep 6, 1:38 PM · Restricted Project, Restricted Project

Aug 17 2023

NatashaKnk accepted D158224: [mlir] Unneeded exports were added to the float utils.
Aug 17 2023, 3:15 PM · Restricted Project, Restricted Project

Apr 20 2023

NatashaKnk accepted D148820: [mlir] Expose Arith::ExpandOps options in constructor.
Apr 20 2023, 11:07 AM · Restricted Project, Restricted Project

Apr 7 2023

NatashaKnk accepted D147796: [mlir] Add tests accidentally removed from arith expand-ops.
Apr 7 2023, 11:09 AM · Restricted Project, Restricted Project

Apr 5 2023

NatashaKnk accepted D147289: [mlir][math] Update math arith expansions for vectorization.
Apr 5 2023, 11:39 AM · Restricted Project, Restricted Project

Mar 30 2023

NatashaKnk updated the diff for D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

Check for output type as well

Mar 30 2023, 10:51 AM · Restricted Project, Restricted Project
NatashaKnk updated the summary of D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.
Mar 30 2023, 10:05 AM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

Add comment in code

Mar 30 2023, 10:04 AM · Restricted Project, Restricted Project

Mar 29 2023

NatashaKnk updated the diff for D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

fixed ;

Mar 29 2023, 5:44 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

Fix formatting

Mar 29 2023, 5:41 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

Fix formatting

Mar 29 2023, 5:36 PM · Restricted Project, Restricted Project
NatashaKnk requested review of D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.
Mar 29 2023, 5:28 PM · Restricted Project, Restricted Project

Jan 10 2023

NatashaKnk accepted D141341: [mlir][tosa] Add uint16 to TOSA type support.
Jan 10 2023, 11:39 AM · Restricted Project, Restricted Project

Jan 4 2023

NatashaKnk accepted D140958: [mlir][tosa] Fix floating point offset for tosa.resize.
Jan 4 2023, 10:31 AM · Restricted Project, Restricted Project

Dec 22 2022

NatashaKnk accepted D140356: [mlir][tosa] Canonicalize tosa.transpose to tosa.reshape.
Dec 22 2022, 3:07 PM · Restricted Project, Restricted Project
NatashaKnk accepted D140503: [mlir][tosa] Fix tosa.transpose_conv2d decompositions for new version.
Dec 22 2022, 2:25 PM · Restricted Project, Restricted Project

Dec 15 2022

NatashaKnk accepted D139979: [mlir][tosa] Make tosa.resize to linalg avoid redundant loads for unit width.
Dec 15 2022, 12:18 PM · Restricted Project, Restricted Project

Dec 13 2022

NatashaKnk accepted D139500: [mlir][tosa] Fix padding for tosa.conv2d and tosa.depthwise_conv2d decomposition.
Dec 13 2022, 5:05 PM · Restricted Project, Restricted Project

Dec 9 2022

NatashaKnk abandoned D125815: [tosa][mlir] Add handling of more than one dynamic dimension for reshape lowering.
Dec 9 2022, 10:24 AM · Restricted Project, Restricted Project

Dec 6 2022

NatashaKnk accepted D139365: [mlir][tosa] Fix tosa.resize for i48 accumulator.
Dec 6 2022, 11:18 AM · Restricted Project, Restricted Project

Dec 2 2022

NatashaKnk added inline comments to D139190: mlir/TosaToLinalg: improve debugging during conversion.
Dec 2 2022, 10:25 AM · Restricted Project, Restricted Project
NatashaKnk accepted D139162: [mlir][tosa] Handle tosa.resize nearest rounding correctly.
Dec 2 2022, 10:15 AM · Restricted Project, Restricted Project

Nov 18 2022

NatashaKnk accepted D138314: [mlir][tosa] Fix tosa.slice shape inference for ShapedType:kDynamicShape.
Nov 18 2022, 11:42 AM · Restricted Project, Restricted Project

Sep 21 2022

NatashaKnk requested review of D134370: [mlir][tosa] Revert added support for dynamic height/weight for pooling in tosa-to-linalg.
Sep 21 2022, 9:01 AM · Restricted Project, Restricted Project

Sep 14 2022

NatashaKnk added a comment to D133389: [mlir][tosa] Add support for dynamic width and height for pooling operations in the tosa to linalg lowering.

Yes, AFAIK there shouldn't be issues in reverting this patch.

Sep 14 2022, 12:52 PM · Restricted Project, Restricted Project
NatashaKnk requested review of D133877: [mlir][tosa] Swap the reshape at the end of the reduce op for an expand_shape in tosa-to-linalg.
Sep 14 2022, 10:26 AM · Restricted Project, Restricted Project

Sep 7 2022

NatashaKnk added inline comments to D133389: [mlir][tosa] Add support for dynamic width and height for pooling operations in the tosa to linalg lowering.
Sep 7 2022, 1:36 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D133389: [mlir][tosa] Add support for dynamic width and height for pooling operations in the tosa to linalg lowering.

Remove template, small fixes

Sep 7 2022, 1:35 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D133389: [mlir][tosa] Add support for dynamic width and height for pooling operations in the tosa to linalg lowering.

Pull in most recent version

Sep 7 2022, 10:51 AM · Restricted Project, Restricted Project

Sep 6 2022

NatashaKnk requested review of D133389: [mlir][tosa] Add support for dynamic width and height for pooling operations in the tosa to linalg lowering.
Sep 6 2022, 5:18 PM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D133383: [mlir][tosa] Add support for non-batch dynamic dims for the rescale op in the tosa to linalg lowering.

Fix iteration to output dims instead of input

Sep 6 2022, 5:11 PM · Restricted Project, Restricted Project
NatashaKnk requested review of D133383: [mlir][tosa] Add support for non-batch dynamic dims for the rescale op in the tosa to linalg lowering.
Sep 6 2022, 4:33 PM · Restricted Project, Restricted Project

Sep 2 2022

NatashaKnk accepted D133208: [mlir][tosa] Fix dinamic shape inference in conv2d.

Good catch, thanks!

Sep 2 2022, 9:44 AM · Restricted Project, Restricted Project

Sep 1 2022

NatashaKnk accepted D133138: [mlir][tosa] Add remaining tosa comparison folders.
Sep 1 2022, 2:03 PM · Restricted Project, Restricted Project

Aug 31 2022

NatashaKnk accepted D133058: [mlir][tosa] Fix left shift that was implicitly converted to 64-bit.
Aug 31 2022, 2:55 PM · Restricted Project, Restricted Project

Aug 30 2022

NatashaKnk accepted D132969: [mlir][tosa] Fix windows build-bot error due to implicit i64 cast.
Aug 30 2022, 12:56 PM · Restricted Project, Restricted Project

Aug 29 2022

NatashaKnk accepted D132518: [mlir][tosa] Add folder for tosa.cast.
Aug 29 2022, 1:55 PM · Restricted Project, Restricted Project
NatashaKnk accepted D132618: [mlir][tosa] Added folders for tosa.sub.
Aug 29 2022, 1:50 PM · Restricted Project, Restricted Project
NatashaKnk accepted D132678: [mlir][tosa] Added folders for tosa.mul.
Aug 29 2022, 1:48 PM · Restricted Project, Restricted Project
NatashaKnk accepted D132693: [mlir][tosa] Added folders for tosa.div.
Aug 29 2022, 1:40 PM · Restricted Project, Restricted Project
NatashaKnk accepted D132760: [mlir][tosa] Fold tosa.reshape with splat values.
Aug 29 2022, 1:37 PM · Restricted Project, Restricted Project
NatashaKnk accepted D132707: [mlir][tosa] Added folders for tosa.greater.
Aug 29 2022, 10:31 AM · Restricted Project, Restricted Project

Aug 23 2022

NatashaKnk accepted D132499: [mlir][tosa] Add constant folding for tosa.slice.
Aug 23 2022, 2:49 PM · Restricted Project, Restricted Project

Jun 15 2022

NatashaKnk accepted D127704: [tosa] Lower tosa.slice to tensor.slice for dynamic case.
Jun 15 2022, 8:22 AM · Restricted Project, Restricted Project

May 30 2022

NatashaKnk accepted D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
May 30 2022, 8:18 AM · Restricted Project, Restricted Project

May 24 2022

NatashaKnk added inline comments to D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
May 24 2022, 8:12 AM · Restricted Project, Restricted Project

May 23 2022

NatashaKnk requested review of D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse..
May 23 2022, 8:25 AM · Restricted Project, Restricted Project

May 17 2022

NatashaKnk requested review of D125815: [tosa][mlir] Add handling of more than one dynamic dimension for reshape lowering.
May 17 2022, 10:31 AM · Restricted Project, Restricted Project

May 9 2022

NatashaKnk added a comment to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Their example contains dynamic shapes, so my assumption was that it's a valid use case. The issue might potentially come from more than one dynamic dimension, but I'm not entirely sure how to track that down.

May 9 2022, 4:43 AM · Restricted Project, Restricted Project

Apr 28 2022

NatashaKnk added inline comments to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..
Apr 28 2022, 9:27 AM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Small clarity fixes

Apr 28 2022, 9:27 AM · Restricted Project, Restricted Project

Apr 27 2022

NatashaKnk requested review of D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..
Apr 27 2022, 5:18 PM · Restricted Project, Restricted Project

Apr 20 2022

NatashaKnk accepted D124055: [mlir] Add shape.func.
Apr 20 2022, 7:41 AM · Restricted Project, Restricted Project

Apr 7 2022

NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Fix typos in documentation

Apr 7 2022, 7:09 AM · Restricted Project, Restricted Project

Apr 4 2022

NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Small additional cleanup

Apr 4 2022, 3:50 PM · Restricted Project, Restricted Project

Mar 23 2022

NatashaKnk added inline comments to D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Mar 23 2022, 10:11 AM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Add small clarity fixes

Mar 23 2022, 10:06 AM · Restricted Project, Restricted Project

Mar 16 2022

NatashaKnk requested review of D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Mar 16 2022, 5:45 PM · Restricted Project, Restricted Project

Feb 24 2022

NatashaKnk updated the diff for D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.

Small clarity updates

Feb 24 2022, 8:41 AM · Restricted Project, Restricted Project

Feb 16 2022

NatashaKnk requested review of D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.
Feb 16 2022, 2:09 PM · Restricted Project, Restricted Project

Jan 27 2022

NatashaKnk requested review of D118397: [tosa][mlir] Add dynamic shape support for remaining ops.
Jan 27 2022, 10:29 AM · Restricted Project

Jan 25 2022

NatashaKnk accepted D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..
Jan 25 2022, 3:51 PM · Restricted Project

Jan 21 2022

NatashaKnk accepted D115682: [mlir] Add polynomial approximation for atan and atan2.
Jan 21 2022, 11:05 AM · Restricted Project

Jan 19 2022

NatashaKnk requested review of D117691: [tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg.
Jan 19 2022, 8:56 AM · Restricted Project

Jan 12 2022

NatashaKnk accepted D117175: [mlir][tosa] Update default tosa-to-linalg passes.
Jan 12 2022, 6:37 PM · Restricted Project
NatashaKnk accepted D117080: [mlir][tosa] Expand tosa.apply_scale lowering for vectors.
Jan 12 2022, 11:01 AM · Restricted Project
NatashaKnk updated the diff for D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.

Fix typo

Jan 12 2022, 10:58 AM · Restricted Project

Jan 11 2022

NatashaKnk updated the diff for D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.

Moved header util file and created a .cpp file. Added a couple of fixes

Jan 11 2022, 2:34 PM · Restricted Project
NatashaKnk requested review of D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.
Jan 11 2022, 8:42 AM · Restricted Project

Jan 10 2022

NatashaKnk accepted D116232: [mlir][tosa] Add optimization pass to TOSA compilation pipeline.
Jan 10 2022, 6:54 PM · Restricted Project
NatashaKnk accepted D116981: [mlir][tosa] Relax tosa.apply_scale operations.
Jan 10 2022, 6:53 PM · Restricted Project

Dec 21 2021

NatashaKnk accepted D116057: [mlir][tosa] Split tosa-to-linalg named ops out of pass.
Dec 21 2021, 10:37 AM · Restricted Project

Dec 16 2021

NatashaKnk updated the diff for D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.

Add more llvm-style formatting, changed return type of checkForDynamicBatchOnly function

Dec 16 2021, 12:35 PM · Restricted Project

Dec 7 2021

NatashaKnk accepted D115264: [mlir][tosa] Disable tosa.depthwise_conv2d canonicalizer for quantized case.
Dec 7 2021, 10:00 AM · Restricted Project

Dec 6 2021

NatashaKnk requested review of D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.
Dec 6 2021, 3:46 PM · Restricted Project

Dec 3 2021

NatashaKnk added a reverting change for rG13bdb7ab4a7a: [mlir][tosa] Add tosa.conv2d as fully_connected canonicalization: D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM
NatashaKnk requested review of D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM · Restricted Project
NatashaKnk added a reverting change for D114757: [mlir][tosa] Add tosa.conv2d as fully_connected canonicalization: D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM · Restricted Project

Nov 23 2021

NatashaKnk accepted D114409: [mlir][tosa] Separate tosa.transpose_conv decomposition and added stride support.
Nov 23 2021, 9:40 AM · Restricted Project

Nov 16 2021

NatashaKnk accepted D114026: [mlir][tosa] Fixed shape inference for tosa.transpose_conv2d.
Nov 16 2021, 2:09 PM · Restricted Project

Nov 15 2021

NatashaKnk requested review of D113936: [tosa][mlir] Add refactor to the the tosa.reshape lowering to linalg and add handling of dynamic cases..
Nov 15 2021, 12:51 PM · Restricted Project

Nov 9 2021

NatashaKnk accepted D113515: [mlir][tosa] Add lowering for tosa.pad with explicit value.
Nov 9 2021, 2:20 PM · Restricted Project

Oct 26 2021

NatashaKnk accepted D112574: [tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case.
Oct 26 2021, 1:51 PM · Restricted Project

Oct 5 2021

NatashaKnk updated the diff for D111167: [mlir][tosa] Create basic dynamic shape support for several ops..

Add checks for unranked tensors

Oct 5 2021, 1:14 PM · Restricted Project
NatashaKnk requested review of D111167: [mlir][tosa] Create basic dynamic shape support for several ops..
Oct 5 2021, 9:20 AM · Restricted Project
NatashaKnk accepted D111102: [mlir][tosa] tosa.cast support for unsigned integers.
Oct 5 2021, 8:27 AM · Restricted Project

Sep 29 2021

NatashaKnk accepted D110674: [mlir][tosa] Ranked check for transpose was wrong..
Sep 29 2021, 2:46 AM · Restricted Project

Sep 28 2021

NatashaKnk accepted D110651: [mlir][tosa] Add i32 to supported quantized type.
Sep 28 2021, 1:04 PM · Restricted Project

Sep 20 2021

NatashaKnk updated the diff for D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..

Remove LogicalNotOp

Sep 20 2021, 2:43 PM · Restricted Project
NatashaKnk added a reviewer for D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops.: rsuderman.
Sep 20 2021, 2:22 PM · Restricted Project
NatashaKnk updated the summary of D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..
Sep 20 2021, 2:22 PM · Restricted Project
NatashaKnk updated the diff for D110095: [mlir][tosa] Remove the documentation requirement for elements of several binary elementwise ops to be of the same rank..

Revert accidentally deleted line

Sep 20 2021, 2:20 PM · Restricted Project
NatashaKnk requested review of D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..
Sep 20 2021, 12:14 PM · Restricted Project
NatashaKnk requested review of D110095: [mlir][tosa] Remove the documentation requirement for elements of several binary elementwise ops to be of the same rank..
Sep 20 2021, 12:12 PM · Restricted Project

Sep 15 2021

NatashaKnk accepted D109863: [mlir][tosa] Relax ranked constraint on quantization builder.
Sep 15 2021, 6:12 PM · Restricted Project