Page MenuHomePhabricator

NatashaKnk (Natasha Kononenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2020, 11:42 AM (125 w, 6 d)

Recent Activity

Wed, Jun 15

NatashaKnk accepted D127704: [tosa] Lower tosa.slice to tensor.slice for dynamic case.
Wed, Jun 15, 8:22 AM · Restricted Project, Restricted Project

May 30 2022

NatashaKnk accepted D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
May 30 2022, 8:18 AM · Restricted Project, Restricted Project

May 24 2022

NatashaKnk added inline comments to D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
May 24 2022, 8:12 AM · Restricted Project, Restricted Project

May 23 2022

NatashaKnk requested review of D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse..
May 23 2022, 8:25 AM · Restricted Project, Restricted Project

May 17 2022

NatashaKnk requested review of D125815: [tosa][mlir] Add handling of more than one dynamic dimension for reshape lowering.
May 17 2022, 10:31 AM · Restricted Project, Restricted Project

May 9 2022

NatashaKnk added a comment to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Their example contains dynamic shapes, so my assumption was that it's a valid use case. The issue might potentially come from more than one dynamic dimension, but I'm not entirely sure how to track that down.

May 9 2022, 4:43 AM · Restricted Project, Restricted Project

Apr 28 2022

NatashaKnk added inline comments to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..
Apr 28 2022, 9:27 AM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Small clarity fixes

Apr 28 2022, 9:27 AM · Restricted Project, Restricted Project

Apr 27 2022

NatashaKnk requested review of D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..
Apr 27 2022, 5:18 PM · Restricted Project, Restricted Project

Apr 20 2022

NatashaKnk accepted D124055: [mlir] Add shape.func.
Apr 20 2022, 7:41 AM · Restricted Project, Restricted Project

Apr 7 2022

NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Fix typos in documentation

Apr 7 2022, 7:09 AM · Restricted Project, Restricted Project

Apr 4 2022

NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Small additional cleanup

Apr 4 2022, 3:50 PM · Restricted Project, Restricted Project

Mar 23 2022

NatashaKnk added inline comments to D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Mar 23 2022, 10:11 AM · Restricted Project, Restricted Project
NatashaKnk updated the diff for D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.

Add small clarity fixes

Mar 23 2022, 10:06 AM · Restricted Project, Restricted Project

Mar 16 2022

NatashaKnk requested review of D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Mar 16 2022, 5:45 PM · Restricted Project, Restricted Project

Feb 24 2022

NatashaKnk updated the diff for D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.

Small clarity updates

Feb 24 2022, 8:41 AM · Restricted Project, Restricted Project

Feb 16 2022

NatashaKnk requested review of D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.
Feb 16 2022, 2:09 PM · Restricted Project, Restricted Project

Jan 27 2022

NatashaKnk requested review of D118397: [tosa][mlir] Add dynamic shape support for remaining ops.
Jan 27 2022, 10:29 AM · Restricted Project

Jan 25 2022

NatashaKnk accepted D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..
Jan 25 2022, 3:51 PM · Restricted Project

Jan 21 2022

NatashaKnk accepted D115682: [mlir] Add polynomial approximation for atan and atan2.
Jan 21 2022, 11:05 AM · Restricted Project

Jan 19 2022

NatashaKnk requested review of D117691: [tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg.
Jan 19 2022, 8:56 AM · Restricted Project

Jan 12 2022

NatashaKnk accepted D117175: [mlir][tosa] Update default tosa-to-linalg passes.
Jan 12 2022, 6:37 PM · Restricted Project
NatashaKnk accepted D117080: [mlir][tosa] Expand tosa.apply_scale lowering for vectors.
Jan 12 2022, 11:01 AM · Restricted Project
NatashaKnk updated the diff for D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.

Fix typo

Jan 12 2022, 10:58 AM · Restricted Project

Jan 11 2022

NatashaKnk updated the diff for D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.

Moved header util file and created a .cpp file. Added a couple of fixes

Jan 11 2022, 2:34 PM · Restricted Project
NatashaKnk requested review of D117031: [tosa][mlir] Support dynamic batch dimension for ops where the batch dim is explicit.
Jan 11 2022, 8:42 AM · Restricted Project

Jan 10 2022

NatashaKnk accepted D116232: [mlir][tosa] Add optimization pass to TOSA compilation pipeline.
Jan 10 2022, 6:54 PM · Restricted Project
NatashaKnk accepted D116981: [mlir][tosa] Relax tosa.apply_scale operations.
Jan 10 2022, 6:53 PM · Restricted Project

Dec 21 2021

NatashaKnk accepted D116057: [mlir][tosa] Split tosa-to-linalg named ops out of pass.
Dec 21 2021, 10:37 AM · Restricted Project

Dec 16 2021

NatashaKnk updated the diff for D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.

Add more llvm-style formatting, changed return type of checkForDynamicBatchOnly function

Dec 16 2021, 12:35 PM · Restricted Project

Dec 7 2021

NatashaKnk accepted D115264: [mlir][tosa] Disable tosa.depthwise_conv2d canonicalizer for quantized case.
Dec 7 2021, 10:00 AM · Restricted Project

Dec 6 2021

NatashaKnk requested review of D115196: [mlir][tosa] Support dynamic batch dimension for ops where the batch dim is explicit.
Dec 6 2021, 3:46 PM · Restricted Project

Dec 3 2021

NatashaKnk added a reverting change for rG13bdb7ab4a7a: [mlir][tosa] Add tosa.conv2d as fully_connected canonicalization: D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM
NatashaKnk requested review of D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM · Restricted Project
NatashaKnk added a reverting change for D114757: [mlir][tosa] Add tosa.conv2d as fully_connected canonicalization: D115079: Revert "[mlir][tosa] Add tosa.conv2d as fully_connected canonicalization".
Dec 3 2021, 2:06 PM · Restricted Project

Nov 23 2021

NatashaKnk accepted D114409: [mlir][tosa] Separate tosa.transpose_conv decomposition and added stride support.
Nov 23 2021, 9:40 AM · Restricted Project

Nov 16 2021

NatashaKnk accepted D114026: [mlir][tosa] Fixed shape inference for tosa.transpose_conv2d.
Nov 16 2021, 2:09 PM · Restricted Project

Nov 15 2021

NatashaKnk requested review of D113936: [tosa][mlir] Add refactor to the the tosa.reshape lowering to linalg and add handling of dynamic cases..
Nov 15 2021, 12:51 PM · Restricted Project

Nov 9 2021

NatashaKnk accepted D113515: [mlir][tosa] Add lowering for tosa.pad with explicit value.
Nov 9 2021, 2:20 PM · Restricted Project

Oct 26 2021

NatashaKnk accepted D112574: [tosa][mlir] Add bailout to TosaMakeBroadcastable for unranked case.
Oct 26 2021, 1:51 PM · Restricted Project

Oct 5 2021

NatashaKnk updated the diff for D111167: [mlir][tosa] Create basic dynamic shape support for several ops..

Add checks for unranked tensors

Oct 5 2021, 1:14 PM · Restricted Project
NatashaKnk requested review of D111167: [mlir][tosa] Create basic dynamic shape support for several ops..
Oct 5 2021, 9:20 AM · Restricted Project
NatashaKnk accepted D111102: [mlir][tosa] tosa.cast support for unsigned integers.
Oct 5 2021, 8:27 AM · Restricted Project

Sep 29 2021

NatashaKnk accepted D110674: [mlir][tosa] Ranked check for transpose was wrong..
Sep 29 2021, 2:46 AM · Restricted Project

Sep 28 2021

NatashaKnk accepted D110651: [mlir][tosa] Add i32 to supported quantized type.
Sep 28 2021, 1:04 PM · Restricted Project

Sep 20 2021

NatashaKnk updated the diff for D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..

Remove LogicalNotOp

Sep 20 2021, 2:43 PM · Restricted Project
NatashaKnk added a reviewer for D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops.: rsuderman.
Sep 20 2021, 2:22 PM · Restricted Project
NatashaKnk updated the summary of D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..
Sep 20 2021, 2:22 PM · Restricted Project
NatashaKnk updated the diff for D110095: [mlir][tosa] Remove the documentation requirement for elements of several binary elementwise ops to be of the same rank..

Revert accidentally deleted line

Sep 20 2021, 2:20 PM · Restricted Project
NatashaKnk requested review of D110096: [mlir][tosa] Add several binary elementwise to the list of broadcastable ops..
Sep 20 2021, 12:14 PM · Restricted Project
NatashaKnk requested review of D110095: [mlir][tosa] Remove the documentation requirement for elements of several binary elementwise ops to be of the same rank..
Sep 20 2021, 12:12 PM · Restricted Project

Sep 15 2021

NatashaKnk accepted D109863: [mlir][tosa] Relax ranked constraint on quantization builder.
Sep 15 2021, 6:12 PM · Restricted Project

Sep 9 2021

NatashaKnk requested review of D109540: [mlir][tosa] Add lowering for tosa.clz using scf::whileOp.
Sep 9 2021, 1:26 PM · Restricted Project

Aug 30 2021

NatashaKnk updated the diff for D108949: [mlir][tosa] Small refactor to the functionality of Depthwise_Conv2D to add the bias at the end of the convolution.

Rename variable to adhere to style guidelines

Aug 30 2021, 3:55 PM · Restricted Project
NatashaKnk requested review of D108949: [mlir][tosa] Small refactor to the functionality of Depthwise_Conv2D to add the bias at the end of the convolution.
Aug 30 2021, 2:21 PM · Restricted Project
NatashaKnk updated the diff for D108746: [mlir][tosa] Small refactor to the functionality of Conv2D and Fully_connected to add the bias at the end of the convolution.

Fixed test names, removed unneeded declarations

Aug 30 2021, 10:59 AM · Restricted Project

Aug 25 2021

NatashaKnk accepted D108744: [mlir][tosa] Tosa reverse to linalg supporting dynamic shapes.
Aug 25 2021, 6:52 PM · Restricted Project
NatashaKnk accepted D108730: [mlir][tosa] Elementwise operation dynamic shape support.
Aug 25 2021, 6:51 PM · Restricted Project
NatashaKnk requested review of D108746: [mlir][tosa] Small refactor to the functionality of Conv2D and Fully_connected to add the bias at the end of the convolution.
Aug 25 2021, 6:48 PM · Restricted Project

Aug 24 2021

NatashaKnk accepted D108436: [mlir][tosa] Table did not apply offset before extract on i8 input.
Aug 24 2021, 5:58 PM · Restricted Project
NatashaKnk accepted D108440: [mlir][tosa] Fix conv/depthwise conv padding for quantized values.
Aug 24 2021, 5:57 PM · Restricted Project
NatashaKnk accepted D108676: [mlir][tosa] Quantized tosa.avg_pool2d lowering to linalg.
Aug 24 2021, 5:55 PM · Restricted Project

Aug 19 2021

NatashaKnk accepted D108427: [mlir][tosa] Support UInt8 inputs and outputs for tosa.rescale.
Aug 19 2021, 5:14 PM · Restricted Project

Aug 18 2021

NatashaKnk accepted D108256: [mlir][tosa] Fix clamp to restrict only within valid bitwidth range.
Aug 18 2021, 12:11 PM · Restricted Project

Aug 17 2021

NatashaKnk accepted D108256: [mlir][tosa] Fix clamp to restrict only within valid bitwidth range.
Aug 17 2021, 5:14 PM · Restricted Project

Aug 16 2021

NatashaKnk accepted D108005: [mlir][tosa] Fixed depthwise conv parallel/reduction indices order.
Aug 16 2021, 1:44 PM · Restricted Project

Aug 12 2021

NatashaKnk requested review of D107997: [mlir][tosa] Fix depthwise_conv2D strides/dilation and name.
Aug 12 2021, 2:29 PM · Restricted Project

Aug 10 2021

NatashaKnk requested review of D107855: [mlir][tosa] Add quantized and unquantized versions for tosa.depthwise_conv2d lowering.
Aug 10 2021, 11:57 AM · Restricted Project
NatashaKnk accepted D107321: [mlir][tosa] Add folders for trivial tosa operation cases.
Aug 10 2021, 11:48 AM · Restricted Project
NatashaKnk accepted D107680: [mlir][tosa] Add dilation to tosa.transpose_conv2d lowering.
Aug 10 2021, 11:47 AM · Restricted Project

Jul 28 2021

NatashaKnk accepted D106846: [mlir][tosa] Fix tosa.reshape failures due to implicit broadcasting.
Jul 28 2021, 2:08 PM · Restricted Project

Jul 20 2021

NatashaKnk accepted D106389: [mlir][tosa] Added tosa to linalg lowering to unstrided transposed conv.
Jul 20 2021, 2:14 PM · Restricted Project

Jun 21 2021

NatashaKnk accepted D104157: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable.
Jun 21 2021, 11:51 AM · Restricted Project
NatashaKnk accepted D104493: [mlir][tosa] Add InferReturnTypes for N-ary operations.
Jun 21 2021, 11:50 AM · Restricted Project

Jun 4 2021

NatashaKnk accepted D102659: [mlir][tosa] Update tosa.rescale for i48 input type.
Jun 4 2021, 4:30 PM · Restricted Project

May 27 2021

NatashaKnk abandoned D103216: [mlir][Standard] Add unsigned integers to UIToFPOp and FPToUIOp cast-compatibility checks.

Oh, I completely missed that SItoFOp also checks for it to be signless, not signed. This makes sense. Thank you!

May 27 2021, 12:18 PM · Restricted Project

May 26 2021

NatashaKnk added a comment to D103216: [mlir][Standard] Add unsigned integers to UIToFPOp and FPToUIOp cast-compatibility checks.

I might be misunderstanding the situation, but if the Ops are signless why does SIToFOp exist? If we handle the explicitly signed case, why not the explicitly unsigned one?

May 26 2021, 6:10 PM · Restricted Project
NatashaKnk requested review of D103216: [mlir][Standard] Add unsigned integers to UIToFPOp and FPToUIOp cast-compatibility checks.
May 26 2021, 5:09 PM · Restricted Project

May 25 2021

NatashaKnk accepted D103110: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.index.
May 25 2021, 1:10 PM · Restricted Project

May 17 2021

NatashaKnk accepted D102651: [mlir][tosa] Cleanup of tosa.rescale lowering to linalg.
May 17 2021, 2:21 PM · Restricted Project

May 14 2021

NatashaKnk accepted D102540: [mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly.
May 14 2021, 4:49 PM · Restricted Project

May 13 2021

NatashaKnk accepted D101809: [mlir][tosa] Add lowering to tosa.abs for integer cases.
May 13 2021, 1:47 PM · Restricted Project
NatashaKnk requested review of D102430: [mlir][tosa] Add tosa.div integer lowering to linalg.generic..
May 13 2021, 11:53 AM · Restricted Project

May 3 2021

NatashaKnk requested review of D101804: [mlir][tosa] Add lowerings for tosa.equal and tosa.arithmetic_right_shift.
May 3 2021, 5:34 PM · Restricted Project

Apr 26 2021

NatashaKnk added a comment to D95836: [x86] introduce no_callee_saved_registers attribute.

This was created by mistake as a result of me messing some commands up while familiarizing myself with the review process. Not sure where the code came from, but it's not mine so please ignore this revision :)

Apr 26 2021, 1:39 PM · Restricted Project

Apr 23 2021

NatashaKnk requested review of D101200: [mlir][tosa] Add tosa.gather lowering to linalg.indexed_generic.
Apr 23 2021, 1:52 PM · Restricted Project

Mar 31 2021

NatashaKnk requested review of D99676: [mlir][tosa] Add tosa.reciprocal and tosa.sigmoid lowerings.
Mar 31 2021, 12:24 PM · Restricted Project

Mar 24 2021

NatashaKnk accepted D99221: [mlir][tosa] Add tosa.bitwise_not lowering to constant and xor.
Mar 24 2021, 11:23 AM · Restricted Project

Mar 23 2021

NatashaKnk requested review of D99211: [mlir][tosa] Add tosa.matmul and tosa.fully_connected lowering.
Mar 23 2021, 12:56 PM · Restricted Project

Mar 19 2021

NatashaKnk accepted D98910: [mlir][tosa] Add tosa.logical_* to linalg lowerings.
Mar 19 2021, 9:56 AM · Restricted Project

Mar 17 2021

NatashaKnk accepted D98825: [mlir][tosa] Add tosa.slice to std.subtensor lowering.
Mar 17 2021, 4:59 PM · Restricted Project

Feb 17 2021

NatashaKnk abandoned D96909: [MLIR][TOSA] Math-based and activation elementwie ops for tosa-to-linalg.
Feb 17 2021, 5:56 PM · Restricted Project
NatashaKnk requested review of D96924: [MLIR][TOSA] Add lowering from TOSA to Linalg for math-based and elementwise ops.
Feb 17 2021, 5:55 PM · Restricted Project
NatashaKnk updated the diff for D96909: [MLIR][TOSA] Math-based and activation elementwie ops for tosa-to-linalg.

Fixed typo in title

Feb 17 2021, 5:47 PM · Restricted Project
NatashaKnk updated the diff for D96909: [MLIR][TOSA] Math-based and activation elementwie ops for tosa-to-linalg.

Fixed lint issues

Feb 17 2021, 5:19 PM · Restricted Project
NatashaKnk requested review of D96909: [MLIR][TOSA] Math-based and activation elementwie ops for tosa-to-linalg.
Feb 17 2021, 3:23 PM · Restricted Project

Feb 1 2021

NatashaKnk added inline comments to D95839: [MLIR][TOSA] Comparison based elementwise operations for tosa-to-linalg.
Feb 1 2021, 5:56 PM · Restricted Project
NatashaKnk updated the diff for D95839: [MLIR][TOSA] Comparison based elementwise operations for tosa-to-linalg.

Changed to use operation->getResultTypes()

Feb 1 2021, 5:53 PM · Restricted Project
NatashaKnk requested review of D95839: [MLIR][TOSA] Comparison based elementwise operations for tosa-to-linalg.
Feb 1 2021, 5:24 PM · Restricted Project
NatashaKnk abandoned D95836: [x86] introduce no_callee_saved_registers attribute.
Feb 1 2021, 4:48 PM · Restricted Project