Page MenuHomePhabricator

mravishankar (Mahesh Ravishankar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2015, 1:11 PM (337 w, 2 d)

Recent Activity

Wed, Jun 16

mravishankar committed rG3ed3e438a75d: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to… (authored by mravishankar).
[mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to…
Wed, Jun 16, 10:13 PM
mravishankar closed D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..
Wed, Jun 16, 10:13 PM · Restricted Project
mravishankar added inline comments to D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..
Wed, Jun 16, 12:11 PM · Restricted Project
mravishankar updated the diff for D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..

Fix test error.

Wed, Jun 16, 12:10 PM · Restricted Project
mravishankar updated the diff for D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..

Rebase and address comments.

Wed, Jun 16, 11:43 AM · Restricted Project

Tue, Jun 15

mravishankar committed rG621d93d263f8: [mlir][SCF] Remove empty else blocks of `scf.if` operations. (authored by mravishankar).
[mlir][SCF] Remove empty else blocks of `scf.if` operations.
Tue, Jun 15, 3:07 PM
mravishankar closed D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..
Tue, Jun 15, 3:07 PM · Restricted Project
mravishankar updated the diff for D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..

Rebase and address comments

Tue, Jun 15, 2:18 PM · Restricted Project
mravishankar added a reviewer for D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass.: stellaraccident.
Tue, Jun 15, 2:09 PM · Restricted Project
mravishankar requested review of D104321: [mlir] Move `memref.dim` canonicalization using `InferShapedTypeOpInterface` to a separate pass..
Tue, Jun 15, 2:09 PM · Restricted Project
mravishankar requested changes to D104289: Implement an scf.for range folding optimization pass..

Please use clang-format on the patch. There seems to be a lot of linter errors.

Tue, Jun 15, 10:32 AM · Restricted Project

Mon, Jun 14

mravishankar added inline comments to D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..
Mon, Jun 14, 10:09 PM · Restricted Project
mravishankar added reviewers for D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations.: ftynse, herhut, hanchung.
Mon, Jun 14, 3:31 PM · Restricted Project
mravishankar requested review of D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..
Mon, Jun 14, 3:30 PM · Restricted Project
mravishankar accepted D104256: [mlir][Linalg] Make printer/parser have the same behavior..

Thanks!

Mon, Jun 14, 12:49 PM · Restricted Project

Fri, Jun 11

mravishankar accepted D103513: Support buffers in LinalgFoldUnitExtentDims.

LGTM-ing this. But needs to rebased on ToT before landing.

Fri, Jun 11, 12:49 PM · Restricted Project

Tue, Jun 8

mravishankar accepted D103889: [mlir][linalg] Prepare fusion on tensors for scalar operands..

So not related to this particular change, but does the fusion of operations where one of the operands was previously say a tensor<f32> and is now just f32 type work?

Tue, Jun 8, 10:32 AM · Restricted Project

Thu, Jun 3

mravishankar committed rGcfa9ae99408f: [mlir][SPIRV] Add lowering for math.log1p operation to SPIR-V dialect. (authored by mravishankar).
[mlir][SPIRV] Add lowering for math.log1p operation to SPIR-V dialect.
Thu, Jun 3, 4:28 PM
mravishankar closed D103635: [mlir][SPIRV] Add lowering for math.log1p operation to SPIR-V dialect..
Thu, Jun 3, 4:27 PM · Restricted Project
mravishankar requested review of D103635: [mlir][SPIRV] Add lowering for math.log1p operation to SPIR-V dialect..
Thu, Jun 3, 10:51 AM · Restricted Project

Wed, Jun 2

mravishankar requested changes to D103243: [mlir][linalg] Support tiling and fusing linalg.pad_tensor.

Ok, first initial skim of this patch. I actually didnt follow the core logic. Maybe we can chat offline about this.

Wed, Jun 2, 4:29 PM · Restricted Project
mravishankar requested changes to D103513: Support buffers in LinalgFoldUnitExtentDims.

Have a comment above (clicked enter early there). Will review more, but if we are going down this path, do we just replicate all the tests here for tensors with memrefs as well?

Wed, Jun 2, 4:03 PM · Restricted Project
mravishankar added a comment to D103513: Support buffers in LinalgFoldUnitExtentDims.

Interesting that this makes it work for memref types. A q

Wed, Jun 2, 4:01 PM · Restricted Project

Tue, Jun 1

mravishankar accepted D103471: [mlir][linalg] Cleanup LinalgOp usage in fusion on tensors (NFC)..

Had offline chat about resolving issues.

  1. Dropping the fusion at init_tensor will be done as a follow up.
  2. Use of pointer is the convention.
Tue, Jun 1, 11:56 AM · Restricted Project
mravishankar accepted D103397: [mlir][linalg] Update result position calculation in the Structured Op Interface (NFC)..
Tue, Jun 1, 11:07 AM · Restricted Project
mravishankar requested changes to D103471: [mlir][linalg] Cleanup LinalgOp usage in fusion on tensors (NFC)..

Overall looks ok to me. One comment in response to the question below.
Another minor nit: Why change signature from OpOperand & to OpOperand *. I prefer the former to the latter.

Tue, Jun 1, 11:06 AM · Restricted Project
mravishankar accepted D103265: [mlir][spirv] Use SingleBlock + NoTerminator for spv.module.
Tue, Jun 1, 10:27 AM · Restricted Project

May 18 2021

mravishankar committed rGe2b365948b36: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor. (authored by mravishankar).
[mlir][Linalg] Break unnecessary dependency through unused `outs` tensor.
May 18 2021, 10:32 PM
mravishankar closed D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor..
May 18 2021, 10:32 PM · Restricted Project
mravishankar added inline comments to D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor..
May 18 2021, 10:03 PM · Restricted Project

May 17 2021

mravishankar accepted D102528: [NVPTX] Fix lowering of frem for negative values.

Nice catch! Looks good to me. Maybe wait for Justin to take a look as well.

May 17 2021, 10:47 AM · Restricted Project
mravishankar added a comment to D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor..

I don't think this should be a blanket canonicalization as it will interact badly with the current work on bufferization post-linalg transforms.
Can you please make this an opt-in rewrite pattern that we may or may not want to apply depending on the case?

May 17 2021, 10:20 AM · Restricted Project
mravishankar updated the diff for D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor..

Moving pattern to elementwise fusion pass.

May 17 2021, 10:17 AM · Restricted Project

May 15 2021

mravishankar added a reviewer for D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor.: hanchung.
May 15 2021, 2:22 PM · Restricted Project
mravishankar requested review of D102561: [mlir][Linalg] Break unnecessary dependency through unused `outs` tensor..
May 15 2021, 2:21 PM · Restricted Project

May 12 2021

mravishankar committed rGb7911e80d692: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction (authored by mravishankar).
[mlir][Linalg] Add interface methods to get lhs and rhs of contraction
May 12 2021, 4:07 PM
mravishankar closed D102301: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction op..
May 12 2021, 4:07 PM · Restricted Project
mravishankar accepted D102163: [mlir][linalg] Remove IndexedGenericOp support from FusionOnTensors....
May 12 2021, 9:47 AM · Restricted Project

May 11 2021

mravishankar accepted D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.
May 11 2021, 8:23 PM · Restricted Project
mravishankar added a reviewer for D102301: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction op.: asaadaldien.
May 11 2021, 8:19 PM · Restricted Project
mravishankar requested review of D102301: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction op..
May 11 2021, 8:19 PM · Restricted Project
mravishankar requested changes to D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Sorry, found a good way to check for the case.

May 11 2021, 5:21 PM · Restricted Project
mravishankar added inline comments to D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.
May 11 2021, 5:18 PM · Restricted Project
mravishankar accepted D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Thanks. Thats what I thought. It was for the case where unit-dimensions are all folded away. I wish there was a way to assert that in the code. (I think it is provable that this is always the case based on reshape semantics, but still having an assert that currIndices (in the code above) correspond to all unit-dimensions would be good.

May 11 2021, 5:18 PM · Restricted Project
mravishankar requested changes to D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Is it possible to get a small repro for the issue. Basically looking for the example where you hit this. I know why this might have happened, but want to make sure it is the expected case.

May 11 2021, 3:40 PM · Restricted Project
mravishankar requested changes to D102163: [mlir][linalg] Remove IndexedGenericOp support from FusionOnTensors....
May 11 2021, 11:19 AM · Restricted Project

May 10 2021

mravishankar added a comment to D102163: [mlir][linalg] Remove IndexedGenericOp support from FusionOnTensors....

Mostly looks fine. Couple of minor comments about use of SmallVector<T>.

May 10 2021, 9:23 AM · Restricted Project
mravishankar requested changes to D102163: [mlir][linalg] Remove IndexedGenericOp support from FusionOnTensors....

Looking through this (will take me a bit), but just adding a "request change" till i finish my review.

May 10 2021, 9:10 AM · Restricted Project

May 7 2021

mravishankar accepted D102091: [mlir][vector] Extend pattern to trim lead unit dimension to Splat Op.
May 7 2021, 1:53 PM · Restricted Project
mravishankar accepted D102079: [mlir][linalg] Restrict distribution to parallel dims.

Actually, I take it back. I think this makes sense. Since the tile size is set to 0, the loop wont be generated. Then the non-parallel loops are filtered out.

May 7 2021, 1:52 PM · Restricted Project
mravishankar requested changes to D102079: [mlir][linalg] Restrict distribution to parallel dims.

I am not sure how this would interfact with the case where some loops are not tiled. Would be good to try out examples from here where some loops are not generated as scf.parallel when the tile size is set to 0. In the same way, if the tile size is set to 0, then then loop wont be tiled and therefore not distributed.

May 7 2021, 1:49 PM · Restricted Project

May 6 2021

mravishankar accepted D102041: [mlir][spirv] add support lowering of extract_slice to scalar type.
May 6 2021, 10:15 PM · Restricted Project
mravishankar accepted D102034: [mlir][vector] add pattern to cast away leading unit dim for elementwise op.

Just one minor typo (unrelated to this change, but good to fix)

May 6 2021, 10:14 PM · Restricted Project
mravishankar committed rG05a89312d812: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing… (authored by mravishankar).
[mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing…
May 6 2021, 7:04 PM
mravishankar closed D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors..
May 6 2021, 7:04 PM · Restricted Project
mravishankar added a comment to D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors..

Thanks

May 6 2021, 5:18 PM · Restricted Project
mravishankar updated the diff for D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors..

Address comments and rebase.

May 6 2021, 5:18 PM · Restricted Project
mravishankar accepted D101612: [mlir][linalg] Add IndexedGenericOp to GenericOp canonicalization..
May 6 2021, 9:04 AM · Restricted Project
mravishankar accepted D101917: [mlir][linalg] Make reshape folding control more fine grain.
May 6 2021, 9:01 AM · Restricted Project

May 5 2021

mravishankar added reviewers for D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors.: antiagainst, ThomasRaoux.
May 5 2021, 11:13 PM · Restricted Project
mravishankar accepted D101955: [mlir][vector] add pattern to cast away lead unit dimension for broadcast op.
May 5 2021, 11:12 PM · Restricted Project
mravishankar added inline comments to D101917: [mlir][linalg] Make reshape folding control more fine grain.
May 5 2021, 11:11 PM · Restricted Project
mravishankar requested changes to D101917: [mlir][linalg] Make reshape folding control more fine grain.

(clicked accept by mistake)

May 5 2021, 9:25 PM · Restricted Project
mravishankar accepted D101917: [mlir][linalg] Make reshape folding control more fine grain.

THanks Thomas. Just one last comment.

May 5 2021, 9:25 PM · Restricted Project
mravishankar added inline comments to D101917: [mlir][linalg] Make reshape folding control more fine grain.
May 5 2021, 4:35 PM · Restricted Project
mravishankar requested changes to D101955: [mlir][vector] add pattern to cast away lead unit dimension for broadcast op.
May 5 2021, 4:20 PM · Restricted Project
mravishankar requested changes to D101917: [mlir][linalg] Make reshape folding control more fine grain.
May 5 2021, 4:12 PM · Restricted Project
mravishankar committed rG4b2d7ef3ea81: [mlir][Linalg] Fix test to use new reshape op form. (authored by mravishankar).
[mlir][Linalg] Fix test to use new reshape op form.
May 5 2021, 4:07 PM
mravishankar closed D101956: [mlir][Linalg] Fix test to use new reshape op form..
May 5 2021, 4:07 PM · Restricted Project
mravishankar requested review of D101956: [mlir][Linalg] Fix test to use new reshape op form..
May 5 2021, 4:06 PM · Restricted Project
mravishankar committed rGb6060b76731d: [mlir][Linalg] Fix element type of results when folding reshapes. (authored by mravishankar).
[mlir][Linalg] Fix element type of results when folding reshapes.
May 5 2021, 3:41 PM
mravishankar closed D101942: [mlir][Linalg] Fix element type of results when folding reshapes..
May 5 2021, 3:41 PM · Restricted Project
mravishankar added reviewers for D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors.: hanchung, herhut.
May 5 2021, 3:08 PM · Restricted Project
mravishankar requested review of D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors..
May 5 2021, 3:05 PM · Restricted Project
mravishankar added a reviewer for D101942: [mlir][Linalg] Fix element type of results when folding reshapes.: ThomasRaoux.
May 5 2021, 1:55 PM · Restricted Project
mravishankar requested review of D101942: [mlir][Linalg] Fix element type of results when folding reshapes..
May 5 2021, 1:54 PM · Restricted Project
mravishankar accepted D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv.

It seems like some transposes are introduced to account for the variant of convolution seen in TOSA. Is the plan to eventually have that as a named op without having to do the transpose?

May 5 2021, 8:47 AM · Restricted Project

May 4 2021

mravishankar accepted D101848: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init.
May 4 2021, 1:43 PM · Restricted Project

May 3 2021

mravishankar committed rGa6e09391bbe7: [mlir][Linalg] Add a utility method to get reassociations maps for reshape. (authored by mravishankar).
[mlir][Linalg] Add a utility method to get reassociations maps for reshape.
May 3 2021, 2:40 PM
mravishankar closed D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..
May 3 2021, 2:40 PM · Restricted Project
mravishankar updated the diff for D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..

Address minor comments

May 3 2021, 2:39 PM · Restricted Project
mravishankar updated the diff for D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..

Rebase

May 3 2021, 1:38 PM · Restricted Project
mravishankar committed rGfd15e2b825f2: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when… (authored by mravishankar).
[mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when…
May 3 2021, 12:52 PM
mravishankar closed D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible..
May 3 2021, 12:51 PM · Restricted Project
mravishankar added inline comments to D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible..
May 3 2021, 12:50 PM · Restricted Project

Apr 28 2021

mravishankar added a comment to D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible..

THe changes to DropUnitDims.cpp (and the test file) are pulled out from https://reviews.llvm.org/D101258. Landing those changes required changes to the subview -> load folding needed for SPIR-V path to make it handle the rank-reducing case.

Apr 28 2021, 3:37 PM · Restricted Project
mravishankar added a reviewer for D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible.: antiagainst.
Apr 28 2021, 3:36 PM · Restricted Project
mravishankar accepted D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.

Nice!

Apr 28 2021, 3:36 PM · Restricted Project
mravishankar updated the diff for D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..

Rebase.

Apr 28 2021, 3:29 PM · Restricted Project
mravishankar requested review of D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible..
Apr 28 2021, 3:29 PM · Restricted Project
mravishankar committed rG41849a919567: [mlir][Linalg] Avoid changing the rank of the result in canonicalizations of… (authored by mravishankar).
[mlir][Linalg] Avoid changing the rank of the result in canonicalizations of…
Apr 28 2021, 11:33 AM
mravishankar closed D101258: [mlir][Linalg] Use rank-reduced versions of subtensor/subtensor_insert to drop unit-dims..
Apr 28 2021, 11:33 AM · Restricted Project
mravishankar updated the diff for D101258: [mlir][Linalg] Use rank-reduced versions of subtensor/subtensor_insert to drop unit-dims..

Fix comments.

Apr 28 2021, 11:01 AM · Restricted Project
mravishankar updated the diff for D101258: [mlir][Linalg] Use rank-reduced versions of subtensor/subtensor_insert to drop unit-dims..

Dropping the patterns that introduced rank-reduced versions of
subtensor and subtensor_insert. They need to be supported on the
SPIR-V backend.

Apr 28 2021, 9:47 AM · Restricted Project

Apr 27 2021

mravishankar accepted D101319: Handle the case of tile and pad a subset of the dimensions.

Seems like something that needs an interface. Anyway, this looks fine.

Apr 27 2021, 2:01 PM · Restricted Project
mravishankar added inline comments to D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..
Apr 27 2021, 10:00 AM · Restricted Project

Apr 26 2021

mravishankar updated the diff for D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..

Cleaup comments.

Apr 26 2021, 10:57 PM · Restricted Project
mravishankar added a reviewer for D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape.: hanchung.
Apr 26 2021, 10:44 PM · Restricted Project
mravishankar requested review of D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..
Apr 26 2021, 10:44 PM · Restricted Project
mravishankar updated the diff for D101258: [mlir][Linalg] Use rank-reduced versions of subtensor/subtensor_insert to drop unit-dims..

Rebase

Apr 26 2021, 10:44 PM · Restricted Project