User Details
- User Since
- Jan 6 2015, 1:11 PM (390 w, 1 d)
Tue, Jun 28
I am not sure introducing an allocation semantics op at this level makes sense for all use cases. AFAICS, the bufferization allocation op should only be introduced "close to bufferization" and that might not be the case for all use cases. Definitely is not the case for within IREE. At the very least it should be optional to use this op.
Mon, Jun 27
Rebase and adderss comments.
Thu, Jun 23
High level comment, could we use TilingInterface for this. The advantage is that you don't need to couple this to the looping construct. I hope to purge the implicit coupling of scf within the implementation of tiling in Linalg. I found that separating the looping constructs from the tiling implementation makes things much simpler. It might help here as well
Tue, Jun 21
@pengfei This commit seems to have caused a downstream correctness issue. See https://github.com/llvm/llvm-project/issues/56156. Could we revert this please.
Mon, Jun 20
Rebase and address comments.
Thu, Jun 16
Wed, Jun 15
Address comments.
Tue, Jun 14
Mon, Jun 13
Rebase.
Thu, Jun 9
Rebase and add convolution tests.
Address review comments.
Wed, Jun 8
Rebase and add bazel build files.
Tue, Jun 7
Adding more tests.
Move test out of test/Dialect/SCF into test/Interfaces/TilingInterface
Removing unnecessary include file.
Resolving some of the TODOs from earlier
Mon, Jun 6
Just a nit on the message with the patch. The use of rank-reducing subviews could from anywhere. The fact that this might/might-not have come from fold-unit-dims pass is orthogonal.
May 24 2022
Thanks!
May 19 2022
Nice! Thanks!
Looks fine to me apart from the errant printf.
May 16 2022
Removing my blocker, but I didnt check the math. Probably worth getting someone to review that.
May 15 2022
Rebase and address comments.
Dont have an opinion about the transformation itself, but more about expected usage.
May 11 2022
Fix a bug in the canonicalizer and add test that exercises that path.
May 10 2022
Rebase
So I went ahead and debugged to a successful outcome: https://reviews.llvm.org/D125309.
May 9 2022
Rebase.
Add patch dependency.
May 6 2022
Fix erroneous edit.
May 3 2022
Apr 22 2022
Small suggestion, otherwise looks good!
Awesome!
Apr 21 2022
Rebase
Just a small question.
Apr 20 2022
Apr 15 2022
Apr 14 2022
Use interface method to check if operands can be dropped while still being able to compute loop bounds.
Apr 13 2022
Address most comments.
Apr 12 2022
Address comments and disallow dropping of dead outputs when it is needed for loop dim computation.