Page MenuHomePhabricator

mravishankar (Mahesh Ravishankar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2015, 1:11 PM (390 w, 1 d)

Recent Activity

Tue, Jun 28

mravishankar requested changes to D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

I am not sure introducing an allocation semantics op at this level makes sense for all use cases. AFAICS, the bufferization allocation op should only be introduced "close to bufferization" and that might not be the case for all use cases. Definitely is not the case for within IREE. At the very least it should be optional to use this op.

Tue, Jun 28, 8:58 AM · Restricted Project, Restricted Project

Mon, Jun 27

mravishankar committed rGfa596c692115: [mlir][Vector] Fix reordering of floating point adds during lower of `vector. (authored by mravishankar).
[mlir][Vector] Fix reordering of floating point adds during lower of `vector.
Mon, Jun 27, 10:27 PM · Restricted Project, Restricted Project
mravishankar closed D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`..
Mon, Jun 27, 10:27 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`..
Mon, Jun 27, 4:18 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`..

Rebase and adderss comments.

Mon, Jun 27, 4:17 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`..
Mon, Jun 27, 12:16 PM · Restricted Project, Restricted Project
mravishankar added a reviewer for D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`.: ThomasRaoux.
Mon, Jun 27, 11:44 AM · Restricted Project, Restricted Project
mravishankar requested review of D128674: [mlir][Vector] Fix re-oredring of floating point adds during lower of `vector.contract`..
Mon, Jun 27, 11:44 AM · Restricted Project, Restricted Project

Thu, Jun 23

mravishankar added a comment to D128443: [mlir] introduce multi-sized tiling transformation.

High level comment, could we use TilingInterface for this. The advantage is that you don't need to couple this to the looping construct. I hope to purge the implicit coupling of scf within the implementation of tiling in Linalg. I found that separating the looping constructs from the tiling implementation makes things much simpler. It might help here as well

Thu, Jun 23, 5:40 PM · Restricted Project, Restricted Project
mravishankar committed rGbc07634b5a76: Adding a named op for grouped convolutions (authored by gpetters94).
Adding a named op for grouped convolutions
Thu, Jun 23, 9:32 AM · Restricted Project, Restricted Project

Tue, Jun 21

mravishankar added a comment to rG655ba9c8a1d2: Reland "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on….

@pengfei This commit seems to have caused a downstream correctness issue. See https://github.com/llvm/llvm-project/issues/56156. Could we revert this please.

Tue, Jun 21, 9:16 PM · Restricted Project, Restricted Project, Restricted Project
mravishankar committed rG2f637fe730a7: [mlir][TilingInterface] Enable tile and fuse using TilingInterface. (authored by mravishankar).
[mlir][TilingInterface] Enable tile and fuse using TilingInterface.
Tue, Jun 21, 10:23 AM · Restricted Project, Restricted Project
mravishankar added a reverting change for rGea75511319d9: [mlir][TilingInterface] Enable tile and fuse using TilingInterface.: rGc584771f54cf: Revert "[mlir][TilingInterface] Enable tile and fuse using TilingInterface.".
Tue, Jun 21, 9:57 AM · Restricted Project, Restricted Project
mravishankar committed rGc584771f54cf: Revert "[mlir][TilingInterface] Enable tile and fuse using TilingInterface." (authored by mravishankar).
Revert "[mlir][TilingInterface] Enable tile and fuse using TilingInterface."
Tue, Jun 21, 9:57 AM · Restricted Project, Restricted Project
mravishankar added a reverting change for D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface.: rGc584771f54cf: Revert "[mlir][TilingInterface] Enable tile and fuse using TilingInterface.".
Tue, Jun 21, 9:57 AM · Restricted Project, Restricted Project
mravishankar committed rGea75511319d9: [mlir][TilingInterface] Enable tile and fuse using TilingInterface. (authored by mravishankar).
[mlir][TilingInterface] Enable tile and fuse using TilingInterface.
Tue, Jun 21, 9:47 AM · Restricted Project, Restricted Project
mravishankar closed D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..
Tue, Jun 21, 9:47 AM · Restricted Project, Restricted Project

Mon, Jun 20

mravishankar updated the diff for D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..

Rebase and address comments.

Mon, Jun 20, 9:07 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..
Mon, Jun 20, 8:45 PM · Restricted Project, Restricted Project

Thu, Jun 16

mravishankar added inline comments to D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..
Thu, Jun 16, 9:55 AM · Restricted Project, Restricted Project

Wed, Jun 15

mravishankar updated the diff for D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..

Address comments.

Wed, Jun 15, 4:48 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..
Wed, Jun 15, 3:25 PM · Restricted Project, Restricted Project

Tue, Jun 14

mravishankar added reviewers for D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface.: ftynse, herhut, hanchung.
Tue, Jun 14, 4:38 PM · Restricted Project, Restricted Project
mravishankar requested review of D127809: [mlir][TilingInterface] Enable tile and fuse using TilingInterface..
Tue, Jun 14, 4:37 PM · Restricted Project, Restricted Project
mravishankar accepted D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.
Tue, Jun 14, 4:28 PM · Restricted Project, Restricted Project

Mon, Jun 13

mravishankar accepted D127225: Adding a named op for grouped convolutions.
Mon, Jun 13, 8:47 PM · Restricted Project, Restricted Project
mravishankar committed rGcf6a7c194793: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement… (authored by mravishankar).
[mlir][TilingInterface] Add pattern to tile using TilingInterface and implement…
Mon, Jun 13, 1:38 PM · Restricted Project, Restricted Project
mravishankar closed D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..
Mon, Jun 13, 1:38 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Rebase.

Mon, Jun 13, 12:13 PM · Restricted Project, Restricted Project

Thu, Jun 9

mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Rebase and add convolution tests.

Thu, Jun 9, 9:53 PM · Restricted Project, Restricted Project
mravishankar added a reviewer for D127449: [mlir] Support passing ostream as argument for the create function.: mehdi_amini.
Thu, Jun 9, 3:49 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..
Thu, Jun 9, 2:37 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Address review comments.

Thu, Jun 9, 2:36 PM · Restricted Project, Restricted Project

Wed, Jun 8

mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Rebase and add bazel build files.

Wed, Jun 8, 9:49 PM · Restricted Project, Restricted Project

Tue, Jun 7

mravishankar requested changes to D127225: Adding a named op for grouped convolutions.
Tue, Jun 7, 9:20 PM · Restricted Project, Restricted Project
mravishankar added reviewers for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops.: herhut, pifon2a, ftynse, hanchung.
Tue, Jun 7, 7:29 PM · Restricted Project, Restricted Project
mravishankar retitled D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops. from [WIP][mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops. to [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..
Tue, Jun 7, 7:28 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Adding more tests.

Tue, Jun 7, 7:28 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Move test out of test/Dialect/SCF into test/Interfaces/TilingInterface

Tue, Jun 7, 4:59 PM · Restricted Project, Restricted Project
mravishankar updated the summary of D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..
Tue, Jun 7, 4:50 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Removing unnecessary include file.

Tue, Jun 7, 4:49 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..

Resolving some of the TODOs from earlier

Tue, Jun 7, 4:45 PM · Restricted Project, Restricted Project

Mon, Jun 6

mravishankar added a reviewer for D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops.: silvas.
Mon, Jun 6, 11:23 AM · Restricted Project, Restricted Project
mravishankar requested review of D127133: [mlir][TilingInterface] Add pattern to tile using TilingInterface and implement TilingInterface for Linalg ops..
Mon, Jun 6, 10:56 AM · Restricted Project, Restricted Project
mravishankar accepted D127086: [mlir][linalg] fix crash when promoting rank-reducing memref.subviews.

Just a nit on the message with the patch. The use of rank-reducing subviews could from anywhere. The fact that this might/might-not have come from fold-unit-dims pass is orthogonal.

Mon, Jun 6, 9:45 AM · Restricted Project, Restricted Project

May 24 2022

mravishankar accepted D126264: [mlir] Fix Tensor_InsertSliceOp description.

Thanks!

May 24 2022, 10:09 PM · Restricted Project, Restricted Project

May 19 2022

mravishankar accepted D125984: [mlir][vector] Fix crash in DropInnerMostUnitDims pattern.

Nice! Thanks!

May 19 2022, 9:45 AM · Restricted Project, Restricted Project
mravishankar accepted D125972: [mlir][tensor] Add canonicalization for tensor.cast from extract_slice.

Looks fine to me apart from the errant printf.

May 19 2022, 9:45 AM · Restricted Project, Restricted Project

May 16 2022

mravishankar accepted D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Removing my blocker, but I didnt check the math. Probably worth getting someone to review that.

May 16 2022, 5:50 PM · Restricted Project, Restricted Project

May 15 2022

mravishankar added inline comments to D125274: [mlir][Linalg] Allow `tileConsumerAndFuseProducers` to return the values of the fused operations..
May 15 2022, 9:49 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D125274: [mlir][Linalg] Allow `tileConsumerAndFuseProducers` to return the values of the fused operations..

Rebase and address comments.

May 15 2022, 9:49 PM · Restricted Project, Restricted Project
mravishankar accepted D125592: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz.
May 15 2022, 9:04 PM · Restricted Project, Restricted Project
mravishankar requested changes to D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Dont have an opinion about the transformation itself, but more about expected usage.

May 15 2022, 9:03 PM · Restricted Project, Restricted Project

May 11 2022

mravishankar committed rG8be7e6f56ac0: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant… (authored by mravishankar).
[mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant…
May 11 2022, 10:23 PM · Restricted Project, Restricted Project
mravishankar closed D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
May 11 2022, 10:23 PM · Restricted Project, Restricted Project
mravishankar accepted D125358: [mlir][bufferize] Add helpers for templatized DENY filters.
May 11 2022, 10:14 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

Fix a bug in the canonicalizer and add test that exercises that path.

May 11 2022, 8:53 PM · Restricted Project, Restricted Project

May 10 2022

mravishankar committed rG1f23211cb1ee: [mlir][SCF] Retire `cloneWithNewYields` helper function. (authored by nicolasvasilache).
[mlir][SCF] Retire `cloneWithNewYields` helper function.
May 10 2022, 11:45 AM · Restricted Project, Restricted Project
mravishankar committed rG567fd523bf53: [mlir][SCF] Add utility method to add new yield values to a loop. (authored by mravishankar).
[mlir][SCF] Add utility method to add new yield values to a loop.
May 10 2022, 11:45 AM · Restricted Project, Restricted Project
mravishankar closed D125309: [mlir][SCF] Retire cloneWithNewYields helper function..
May 10 2022, 11:44 AM · Restricted Project, Restricted Project
mravishankar closed D125147: [mlir][SCF] Add utility method to add new yield values to a loop..
May 10 2022, 11:44 AM · Restricted Project, Restricted Project
mravishankar updated the diff for D125147: [mlir][SCF] Add utility method to add new yield values to a loop..

Rebase

May 10 2022, 11:20 AM · Restricted Project, Restricted Project
mravishankar added a comment to D125147: [mlir][SCF] Add utility method to add new yield values to a loop..
So I went ahead and debugged to a successful outcome: https://reviews.llvm.org/D125309.
May 10 2022, 10:22 AM · Restricted Project, Restricted Project
mravishankar resigned from D125244: [mlir][gpu] Move async copy ops to NVGPU and add caching hints.
May 10 2022, 9:02 AM · Restricted Project, Restricted Project
mravishankar resigned from D125227: [mlir][vector] NFC change to improve doc of vector distribution op.
May 10 2022, 9:02 AM · Restricted Project, Restricted Project

May 9 2022

mravishankar updated the diff for D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

Rebase.

May 9 2022, 6:05 PM · Restricted Project, Restricted Project
mravishankar resigned from D114384: Fix expand folder to avoid folding memref cast.
May 9 2022, 3:37 PM · Restricted Project, Restricted Project
mravishankar resigned from D114278: [mlir][linalg] Expose SwapSliceOfPad as strategy pass.
May 9 2022, 3:37 PM · Restricted Project, Restricted Project
mravishankar resigned from D119454: [mlir][tensor] Keep size-1 dim for non-rank-reducing extract_slice.
May 9 2022, 3:37 PM · Restricted Project, Restricted Project
mravishankar resigned from D117019: [mlir][scf] Add a pass to expand scf.if regions.
May 9 2022, 3:36 PM · Restricted Project, Restricted Project
mravishankar resigned from D106066: [mlir] Introduce `linalg.tiled_yield` terminator for `linalg.tiled_loop`..
May 9 2022, 3:36 PM · Restricted Project, Restricted Project
mravishankar resigned from D86567: [mlir] NFC: fix trivial typos under docs directory.
May 9 2022, 3:35 PM · Restricted Project, Restricted Project
mravishankar resigned from D98330: [MLIR][SPIRV] Towards a consistent assembly scheme: GlobalVariable..
May 9 2022, 3:35 PM · Restricted Project, Restricted Project
mravishankar updated the summary of D125274: [mlir][Linalg] Allow `tileConsumerAndFuseProducers` to return the values of the fused operations..
May 9 2022, 3:15 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D125274: [mlir][Linalg] Allow `tileConsumerAndFuseProducers` to return the values of the fused operations..

Add patch dependency.

May 9 2022, 3:15 PM · Restricted Project, Restricted Project
mravishankar requested review of D125274: [mlir][Linalg] Allow `tileConsumerAndFuseProducers` to return the values of the fused operations..
May 9 2022, 3:11 PM · Restricted Project, Restricted Project

May 6 2022

mravishankar updated the diff for D125147: [mlir][SCF] Add utility method to add new yield values to a loop..

Fix erroneous edit.

May 6 2022, 5:10 PM · Restricted Project, Restricted Project
mravishankar added reviewers for D125147: [mlir][SCF] Add utility method to add new yield values to a loop.: nicolasvasilache, ftynse, hanchung.
May 6 2022, 5:05 PM · Restricted Project, Restricted Project
mravishankar requested review of D125147: [mlir][SCF] Add utility method to add new yield values to a loop..
May 6 2022, 5:04 PM · Restricted Project, Restricted Project

May 3 2022

mravishankar accepted D124853: [mlir][linalg][bufferize][NFC] Make init_tensor elimination a separate pre-processing pass.
May 3 2022, 1:41 PM · Restricted Project, Restricted Project

Apr 22 2022

mravishankar removed a reviewer for D124283: [mlir] Does not bubble up extract slice when it is rank-reducing.: maheshkhanwalkar.
Apr 22 2022, 11:02 AM · Restricted Project, Restricted Project
mravishankar accepted D124283: [mlir] Does not bubble up extract slice when it is rank-reducing..

Small suggestion, otherwise looks good!

Apr 22 2022, 11:02 AM · Restricted Project, Restricted Project
mravishankar accepted D124129: [mlir][vector] Fold one-element reduction into extract.

Awesome!

Apr 22 2022, 9:27 AM · Restricted Project, Restricted Project

Apr 21 2022

mravishankar committed rG0c090dcc8a97: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns. (authored by mravishankar).
[mlir][Linalg] Deprecate legacy reshape + generic op folding patterns.
Apr 21 2022, 3:26 PM · Restricted Project, Restricted Project
mravishankar closed D124145: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns..
Apr 21 2022, 3:25 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D124145: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns..

Rebase

Apr 21 2022, 2:40 PM · Restricted Project, Restricted Project
mravishankar requested changes to D124129: [mlir][vector] Fold one-element reduction into extract.

Just a small question.

Apr 21 2022, 12:48 PM · Restricted Project, Restricted Project
mravishankar accepted D124094: [mlir][vector] Fold cancelling vector.shape_cast(vector.broadcast).
Apr 21 2022, 12:47 PM · Restricted Project, Restricted Project

Apr 20 2022

mravishankar added reviewers for D124145: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns.: gysit, okkwon.
Apr 20 2022, 9:54 PM · Restricted Project, Restricted Project
mravishankar requested review of D124145: [mlir][Linalg] Deprecate legacy reshape + generic op folding patterns..
Apr 20 2022, 9:54 PM · Restricted Project, Restricted Project

Apr 15 2022

mravishankar accepted D123867: [mlir][vector] Fix bug in extractFromBroadcast folding.
Apr 15 2022, 11:54 AM · Restricted Project, Restricted Project

Apr 14 2022

mravishankar updated the diff for D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

Use interface method to check if operands can be dropped while still being able to compute loop bounds.

Apr 14 2022, 3:29 PM · Restricted Project, Restricted Project

Apr 13 2022

mravishankar committed rGb40e901333b9: [mlir][Linalg] Allow collapsing subset of the reassociations when fusing by… (authored by mravishankar).
[mlir][Linalg] Allow collapsing subset of the reassociations when fusing by…
Apr 13 2022, 2:32 PM · Restricted Project, Restricted Project
mravishankar added inline comments to D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
Apr 13 2022, 1:52 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

Address most comments.

Apr 13 2022, 1:52 PM · Restricted Project, Restricted Project

Apr 12 2022

mravishankar added inline comments to D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..
Apr 12 2022, 9:19 PM · Restricted Project, Restricted Project
mravishankar updated the diff for D123632: [mlir][Linalg] Combine canonicalizers that deal with removing dead/redundant args..

Address comments and disallow dropping of dead outputs when it is needed for loop dim computation.

Apr 12 2022, 9:18 PM · Restricted Project, Restricted Project
mravishankar resigned from D123596: [mlir][vector] Reorder elementwise(transpose).
Apr 12 2022, 1:47 PM · Restricted Project, Restricted Project
mravishankar resigned from D123595: [mlir][vector] Fold splat constant transpose.
Apr 12 2022, 1:47 PM · Restricted Project, Restricted Project
mravishankar resigned from D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Apr 12 2022, 1:46 PM · Restricted Project, Restricted Project