Adding sin op in the GLSL extension

[mravishankar]

Thanks Natasha! This needs tests though.
See mlir/test/Dialect/SPIRV/glslops.mlir for similar ops. These are round-trip tests. It checks that mlir can parse the operation and print it out correctly
You also need "Serialization" tests, i.e. MLIR can generate valid SPIR-V binary for this operation. See mlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir

[NatashaKnk]

Updating D74151: Adding sin op in the GLSL extension

Added tests for both Sin and Cos operation.

[NatashaKnk]

1. Updating D74151: Adding sin op in the GLSL extension #

Fixing accidentally added files

[mravishankar]

THanks for adding the cosine tests too...

mlir/include/mlir/Dialect/SPIRV/SPIRVGLSLOps.td

let description = [{
     %2 = spv.GLSL.Cos %0 : f32
     %3 = spv.GLSL.Cos %1 : vector<3xf16>
     ```
   }];
 }
 
 // -----
 
+def SPV_GLSLSinOp : SPV_GLSLUnaryArithmeticOp<"Sin", 13, SPV_Float16or32> {
+  let summary = "Sine of operand in radians";
+
+  let description = [{
+    The standard trigonometric sine of x radians.
+
+    The operand x must be a scalar or vector whose component type is 16-bit or
+    32-bit floating-point.
+
+    Result Type and the type of x must be the same type. Results are computed
+    per component.
+
+    ### Custom assembly format
+    ```
+    restricted-float-scalar-type ::=  `f16` | `f32`
+    restricted-float-scalar-vector-type ::=
+      restricted-float-scalar-type |
+      `vector<` integer-literal `x` restricted-float-scalar-type `>`
+    sin-op ::= ssa-id `=` `spv.GLSL.Sin` ssa-use `:`
+               restricted-float-scalar-vector-type
+    ```
+    For example:
+
+    ```
+    %2 = spv.GLSL.Sin %0 : f32
+    %3 = spv.GLSL.Sin %1 : vector<3xf16>
+    ```
+  }];
+}
+
+// -----
+
 def SPV_GLSLExpOp : SPV_GLSLUnaryArithmeticOp<"Exp", 27, SPV_Float16or32> {
   let summary = "Exponentiation of Operand 1";
 
   let description = [{
     Result is the natural exponentiation of x; e^x.
 
     The operand x must be a scalar or vector whose component type is
     16-bit or 32-bit floating-point.

mlir/test/Dialect/SPIRV/Serialization/glsl-ops.mlir

 // RUN: mlir-translate -test-spirv-roundtrip %s | FileCheck %s
 
 spv.module "Logical" "GLSL450" {
   func @fmul(%arg0 : f32, %arg1 : f32) {
     // CHECK: {{%.*}} = spv.GLSL.Exp {{%.*}} : f32
     %0 = spv.GLSL.Exp %arg0 : f32
     // CHECK: {{%.*}} = spv.GLSL.FMax {{%.*}}, {{%.*}} : f32
     %1 = spv.GLSL.FMax %arg0, %arg1 : f32
     // CHECK: {{%.*}} = spv.GLSL.Sqrt {{%.*}} : f32
     %2 = spv.GLSL.Sqrt %arg0 : f32
+    // CHECK: {{%.*}} = spv.GLSL.Cos {{%.*}} : f32
+    %3 = spv.GLSL.Cos %arg0 : f32
+    // CHECK: {{%.*}} = spv.GLSL.Sin {{%.*}} : f32
+    %4 = spv.GLSL.Sin %arg0 : f32
     spv.Return
   }
 }

mlir/test/Dialect/SPIRV/glslops.mlir

func @sqrt(%arg0 : f32) -> () {
   return
 }
 
 func @sqrtvec(%arg0 : vector<3xf16>) -> () {
   // CHECK: spv.GLSL.Sqrt {{%.*}} : vector<3xf16>
   %2 = spv.GLSL.Sqrt %arg0 : vector<3xf16>
   return
 }
+
+//===----------------------------------------------------------------------===//
+// spv.GLSL.Cos
+//===----------------------------------------------------------------------===//
+
+func @cos(%arg0 : f32) -> () {
+  // CHECK: spv.GLSL.Cos {{%.*}} : f32
+  %2 = spv.GLSL.Cos %arg0 : f32
+  return
+}
+
+func @cosvec(%arg0 : vector<3xf16>) -> () {
+  // CHECK: spv.GLSL.Cos {{%.*}} : vector<3xf16>
+  %2 = spv.GLSL.Cos %arg0 : vector<3xf16>
+  return
+}
+
+//===----------------------------------------------------------------------===//
+// spv.GLSL.Sin
+//===----------------------------------------------------------------------===//
+
+func @sin(%arg0 : f32) -> () {
+  // CHECK: spv.GLSL.Sin {{%.*}} : f32
+  %2 = spv.GLSL.Sin %arg0 : f32
+  return
+}
+
+func @sinvec(%arg0 : vector<3xf16>) -> () {
+  // CHECK: spv.GLSL.Sin {{%.*}} : vector<3xf16>
+  %2 = spv.GLSL.Sin %arg0 : vector<3xf16>
+  return
+}