This is an archive of the discontinued LLVM Phabricator instance.

[XRay] Emit absolute address for versions less than 2
AbandonedPublic

Authored by SixWeining on Dec 28 2022, 5:20 AM.

Details

Summary

D78082 changed the absolute address to a PC-relative address if version
is not less than 2. But it didn't differentiate versions when emitting
the xray table in AsmPrinter. This patch handles it.

Diff Detail

Event Timeline

SixWeining created this revision.Dec 28 2022, 5:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 5:20 AM
SixWeining requested review of this revision.Dec 28 2022, 5:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 5:20 AM

We should not add more code for legacy version 1. I sent D140739 to remove the runtime side code.

SixWeining abandoned this revision.Dec 28 2022, 5:36 PM

We should not add more code for legacy version 1. I sent D140739 to remove the runtime side code.

Thanks. Let me abandon this change.