Page MenuHomePhabricator

dberris (Dean Michael Berris)
Software Engineer @ Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2014, 7:30 PM (250 w, 6 d)

Recent Activity

Tue, Dec 11

dberris accepted D55548: [XRay] Add a helper function sortByKey to simplify code.

LGTM -- Thanks @MaskRay!

Tue, Dec 11, 4:09 AM

Mon, Dec 10

dberris accepted D55542: [llvm-xray] Support for PIE.

LGTM -- Thanks @phosek!

Mon, Dec 10, 8:25 PM

Thu, Dec 6

dberris committed rCRT348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Thu, Dec 6, 10:26 PM
dberris committed rL348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Thu, Dec 6, 10:26 PM
dberris closed D55249: [XRay] Use preallocated memory for XRay profiling.
Thu, Dec 6, 10:26 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase again. This is now ready for another look.

Thu, Dec 6, 10:01 PM
dberris committed rCRT348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Thu, Dec 6, 7:22 PM
dberris committed rL348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Thu, Dec 6, 7:22 PM

Wed, Dec 5

dberris committed rCRT348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Wed, Dec 5, 7:32 PM
dberris committed rL348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Wed, Dec 5, 7:32 PM
dberris committed rL348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Wed, Dec 5, 6:58 PM
dberris committed rCRT348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Wed, Dec 5, 6:58 PM
dberris committed rCRT348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Wed, Dec 5, 5:59 PM
dberris committed rL348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Wed, Dec 5, 5:59 PM
dberris committed rCRT348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Wed, Dec 5, 4:29 PM
dberris committed rL348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Wed, Dec 5, 4:29 PM

Tue, Dec 4

dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase.

Tue, Dec 4, 11:29 PM
dberris committed rL348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Tue, Dec 4, 11:17 PM
dberris committed rCRT348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Tue, Dec 4, 11:17 PM
dberris committed rL348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Tue, Dec 4, 11:08 PM
dberris committed rCRT348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Tue, Dec 4, 11:08 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Addressing comment by @mboerger.

Tue, Dec 4, 10:57 PM
dberris committed rL348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Tue, Dec 4, 10:48 PM
dberris committed rCRT348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Tue, Dec 4, 10:47 PM
dberris closed D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Tue, Dec 4, 10:47 PM

Mon, Dec 3

dberris created D55249: [XRay] Use preallocated memory for XRay profiling.
Mon, Dec 3, 9:12 PM
dberris added a child revision for D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array: D55249: [XRay] Use preallocated memory for XRay profiling.
Mon, Dec 3, 9:12 PM

Wed, Nov 28

dberris added inline comments to D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Wed, Nov 28, 12:33 AM
dberris updated the diff for D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.

Addressing comments by @mboerger.

Wed, Nov 28, 12:32 AM

Tue, Nov 27

dberris created D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Tue, Nov 27, 9:36 PM

Wed, Nov 21

dberris accepted D54784: Use --push/pop-state with XRay link deps.

LGTM

Wed, Nov 21, 6:51 PM

Tue, Nov 20

dberris committed rCRT347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Tue, Nov 20, 4:33 PM
dberris committed rL347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Tue, Nov 20, 4:33 PM

Mon, Nov 19

dberris committed rCRT347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Mon, Nov 19, 7:58 PM
dberris committed rL347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Mon, Nov 19, 7:58 PM
dberris committed rCRT347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Mon, Nov 19, 5:05 PM
dberris committed rL347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Mon, Nov 19, 5:05 PM
dberris closed D54684: [XRay] Move buffer extents back to the heap.
Mon, Nov 19, 5:05 PM
dberris updated the diff for D54684: [XRay] Move buffer extents back to the heap.

clang-format with LLVM style

Mon, Nov 19, 3:38 PM
dberris added inline comments to D54684: [XRay] Move buffer extents back to the heap.
Mon, Nov 19, 2:00 PM

Sun, Nov 18

dberris created D54684: [XRay] Move buffer extents back to the heap.
Sun, Nov 18, 9:33 PM

Nov 8 2018

dberris committed rCRT346477: [XRay] Add a test for function id encoding/decoding (NFC).
[XRay] Add a test for function id encoding/decoding (NFC)
Nov 8 2018, 11:46 PM
dberris committed rL346477: [XRay] Add a test for function id encoding/decoding (NFC).
[XRay] Add a test for function id encoding/decoding (NFC)
Nov 8 2018, 11:46 PM
dberris committed rCRT346476: [XRay] Add a static assertion on size of metadata payload (NFC).
[XRay] Add a static assertion on size of metadata payload (NFC)
Nov 8 2018, 11:19 PM
dberris committed rL346476: [XRay] Add a static assertion on size of metadata payload (NFC).
[XRay] Add a static assertion on size of metadata payload (NFC)
Nov 8 2018, 11:19 PM
dberris committed rCRT346475: [XRay] Fix enter function tracing for record unwriting.
[XRay] Fix enter function tracing for record unwriting
Nov 8 2018, 10:51 PM
dberris committed rL346475: [XRay] Fix enter function tracing for record unwriting.
[XRay] Fix enter function tracing for record unwriting
Nov 8 2018, 10:51 PM
dberris closed D54292: [XRay] Fix enter function tracing for record unwriting.
Nov 8 2018, 10:51 PM
dberris committed rCRT346474: [XRay] Add atomic fences around non-atomic reads and writes.
[XRay] Add atomic fences around non-atomic reads and writes
Nov 8 2018, 10:42 PM
dberris committed rL346474: [XRay] Add atomic fences around non-atomic reads and writes.
[XRay] Add atomic fences around non-atomic reads and writes
Nov 8 2018, 10:42 PM
dberris closed D54291: [XRay] Add atomic fences around non-atomic reads and writes.
Nov 8 2018, 10:42 PM
dberris committed rCRT346473: [XRay] Improve FDR trace handling and error messaging.
[XRay] Improve FDR trace handling and error messaging
Nov 8 2018, 10:30 PM
dberris committed rL346473: [XRay] Improve FDR trace handling and error messaging.
[XRay] Improve FDR trace handling and error messaging
Nov 8 2018, 10:30 PM
dberris closed D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 8 2018, 10:30 PM
dberris created D54292: [XRay] Fix enter function tracing for record unwriting.
Nov 8 2018, 9:04 PM
dberris created D54291: [XRay] Add atomic fences around non-atomic reads and writes.
Nov 8 2018, 9:02 PM
dberris added inline comments to D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 8 2018, 8:33 PM
dberris updated the diff for D54201: [XRay] Improve FDR trace handling and error messaging.

Address some comments by @mboerger.

Nov 8 2018, 8:32 PM

Nov 7 2018

dberris committed rL346306: [XRay] Clean up more std::copy(...)'s.
[XRay] Clean up more std::copy(...)'s
Nov 7 2018, 3:55 AM
dberris committed rL346304: [XRay] Use explicit string conversion.
[XRay] Use explicit string conversion
Nov 7 2018, 3:47 AM
dberris created D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 7 2018, 2:08 AM

Nov 6 2018

dberris committed rCRT346293: [XRay] Use TSC delta encoding for custom/typed events.
[XRay] Use TSC delta encoding for custom/typed events
Nov 6 2018, 8:40 PM
dberris committed rL346293: [XRay] Use TSC delta encoding for custom/typed events.
[XRay] Use TSC delta encoding for custom/typed events
Nov 6 2018, 8:40 PM
dberris closed D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 6 2018, 8:40 PM
dberris added a comment to D49025: [XRay] basic mode PID and TID always fetch.

Aha! Right, I think the test is wrong indeed. We shouldn't be assuming that the tid == pid in the test, when recording the first argument for the thread id, and rather be calling the correct function for getting the thread id all the time.

Nov 6 2018, 2:42 PM
dberris added inline comments to D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 6 2018, 1:01 AM
dberris updated the diff for D54140: [XRay] Use TSC delta encoding for custom/typed events.

Address comments by @mboerger.

Nov 6 2018, 1:01 AM
dberris committed rCRT346214: [XRay] Update XRayRecord to support Custom/Typed Events.
[XRay] Update XRayRecord to support Custom/Typed Events
Nov 6 2018, 12:54 AM
dberris committed rL346214: [XRay] Update XRayRecord to support Custom/Typed Events.
[XRay] Update XRayRecord to support Custom/Typed Events
Nov 6 2018, 12:54 AM
dberris closed D54139: [XRay] Update XRayRecord to support Custom/Typed Events.
Nov 6 2018, 12:54 AM

Nov 5 2018

dberris updated the diff for D54139: [XRay] Update XRayRecord to support Custom/Typed Events.

Address comments, handle more cases where enum is used in tools.

Nov 5 2018, 11:38 PM
dberris created D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 5 2018, 11:23 PM
dberris added a child revision for D54139: [XRay] Update XRayRecord to support Custom/Typed Events: D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 5 2018, 11:23 PM
dberris created D54139: [XRay] Update XRayRecord to support Custom/Typed Events.
Nov 5 2018, 9:41 PM
dberris added a comment to D49025: [XRay] basic mode PID and TID always fetch.

This test seems to have a Linux assumption and I have concerns how to port it to NetBSD.

On NetBSD TIDs start from 1 to N in each process. Each process has a single distinct PID. TID numbers are not unique between processes (they are unique only within a process). PID numbers are unique.

On Linux TID is effectively PID and this is linuxism.

Nov 5 2018, 8:38 PM
dberris accepted D54136: Prioritize the constructor call of __local_xray_dyninit().

Has this been tested with GCC/Clang on other systems (like Linux)?

Nov 5 2018, 7:56 PM · Restricted Project

Nov 4 2018

dberris committed rCRT346116: [XRay] Update TSC math to handle wraparound.
[XRay] Update TSC math to handle wraparound
Nov 4 2018, 9:48 PM
dberris committed rL346116: [XRay] Update TSC math to handle wraparound.
[XRay] Update TSC math to handle wraparound
Nov 4 2018, 9:47 PM
dberris closed D54088: [XRay] Update TSC math to handle wraparound.
Nov 4 2018, 9:47 PM
dberris updated the diff for D54088: [XRay] Update TSC math to handle wraparound.

FIx typo in title.

Nov 4 2018, 9:29 PM
dberris created D54088: [XRay] Update TSC math to handle wraparound.
Nov 4 2018, 9:17 PM
dberris added a comment to D53742: [XRay] Use std::errc::invalid_argument instead of std::errc::bad_message.

LGTM -- just FTR, since I missed this the first time around.

Nov 4 2018, 6:50 PM

Nov 2 2018

dberris committed rL345955: [XRay] Fix tests with updated fdr-dump.
[XRay] Fix tests with updated fdr-dump
Nov 2 2018, 1:38 AM
dberris committed rCRT345954: [XRay] Update delta computations in runtime.
[XRay] Update delta computations in runtime
Nov 2 2018, 1:13 AM
dberris committed rL345954: [XRay] Update delta computations in runtime.
[XRay] Update delta computations in runtime
Nov 2 2018, 1:13 AM
dberris closed D54022: [XRay] Update delta computations in runtime.
Nov 2 2018, 1:12 AM

Nov 1 2018

dberris created D54022: [XRay] Update delta computations in runtime.
Nov 1 2018, 9:45 PM
dberris committed rCRT345905: [XRay] Fix TSC and atomic custom/typed event accounting.
[XRay] Fix TSC and atomic custom/typed event accounting
Nov 1 2018, 4:00 PM
dberris committed rL345905: [XRay] Fix TSC and atomic custom/typed event accounting.
[XRay] Fix TSC and atomic custom/typed event accounting
Nov 1 2018, 4:00 PM
dberris closed D53967: [XRay] Fix TSC and atomic custom/typed event accounting.
Nov 1 2018, 4:00 PM
dberris updated the diff for D53967: [XRay] Fix TSC and atomic custom/typed event accounting.

Address comments by @mboerger.

Nov 1 2018, 1:08 AM

Oct 31 2018

dberris updated the diff for D53967: [XRay] Fix TSC and atomic custom/typed event accounting.

Write down correct delta.

Oct 31 2018, 8:29 PM
dberris created D53967: [XRay] Fix TSC and atomic custom/typed event accounting.
Oct 31 2018, 8:23 PM
dberris committed rL345798: [XRay] Add CPU ID in Custom Event FDR Records.
[XRay] Add CPU ID in Custom Event FDR Records
Oct 31 2018, 5:21 PM
dberris committed rCRT345798: [XRay] Add CPU ID in Custom Event FDR Records.
[XRay] Add CPU ID in Custom Event FDR Records
Oct 31 2018, 5:21 PM
dberris closed D53920: [XRay] Add CPU ID in Custom Event FDR Records.
Oct 31 2018, 5:21 PM

Oct 30 2018

dberris created D53920: [XRay] Add CPU ID in Custom Event FDR Records.
Oct 30 2018, 11:36 PM

Oct 29 2018

dberris committed rL345568: [XRay] Migrate FDR runtime to use refactored controller.
[XRay] Migrate FDR runtime to use refactored controller
Oct 29 2018, 9:38 PM
dberris committed rCRT345568: [XRay] Migrate FDR runtime to use refactored controller.
[XRay] Migrate FDR runtime to use refactored controller
Oct 29 2018, 9:38 PM
dberris closed D53858: [XRay] Migrate FDR runtime to use refactored controller.
Oct 29 2018, 9:38 PM