dberris (Dean Michael Berris)
Software Engineer @ Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2014, 7:30 PM (239 w, 5 d)

Recent Activity

Mon, Sep 24

dberris committed rCRT342859: [XRay] Clean up XRay build configuration.
[XRay] Clean up XRay build configuration
Mon, Sep 24, 7:25 AM
dberris committed rL342859: [XRay] Clean up XRay build configuration.
[XRay] Clean up XRay build configuration
Mon, Sep 24, 7:23 AM
dberris closed D52349: [XRay] Clean up XRay build configuration.
Mon, Sep 24, 7:23 AM

Fri, Sep 21

dberris committed rCRT342745: [XRay][compiler-rt] Update use of internal_mmap.
[XRay][compiler-rt] Update use of internal_mmap
Fri, Sep 21, 9:36 AM
dberris committed rL342745: [XRay][compiler-rt] Update use of internal_mmap.
[XRay][compiler-rt] Update use of internal_mmap
Fri, Sep 21, 9:36 AM
dberris closed D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 9:36 AM
dberris added inline comments to D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:35 AM
dberris updated the diff for D52361: [XRay][compiler-rt] Update use of internal_mmap.

Remove another check for MAP_FAILED.

Fri, Sep 21, 8:35 AM
dberris updated the diff for D52361: [XRay][compiler-rt] Update use of internal_mmap.

Update error reporting in one path.

Fri, Sep 21, 8:23 AM
dberris created D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:21 AM
dberris updated the diff for D52349: [XRay] Clean up XRay build configuration.

Update LLVMBuild.txt header in llvm/lib/XRay/.

Fri, Sep 21, 3:41 AM
dberris updated the diff for D52349: [XRay] Clean up XRay build configuration.

Fixup description.

Fri, Sep 21, 3:37 AM
dberris created D52349: [XRay] Clean up XRay build configuration.
Fri, Sep 21, 3:35 AM
dberris committed rL342715: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.
[XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1
Fri, Sep 21, 1:34 AM
dberris committed rC342715: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.
[XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1
Fri, Sep 21, 1:34 AM
dberris closed D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.
Fri, Sep 21, 1:34 AM
dberris updated the diff for D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.

Move the test to the driver, more appropriate location.

Fri, Sep 21, 1:09 AM
dberris created D52342: [XRay][clang] Propagate -fxray-instrumentation-bundle to -cc1.
Fri, Sep 21, 12:16 AM

Thu, Sep 20

dberris committed rL342706: [MCA] Remove dependency on CodeGen..
[MCA] Remove dependency on CodeGen.
Thu, Sep 20, 6:55 PM
dberris closed D52288: [MCA] Remove dependency on CodeGen..
Thu, Sep 20, 6:55 PM

Wed, Sep 19

dberris committed rCRT342617: [XRay][compiler-rt] FDRLogWriter Abstraction.
[XRay][compiler-rt] FDRLogWriter Abstraction
Wed, Sep 19, 10:24 PM
dberris committed rL342617: [XRay][compiler-rt] FDRLogWriter Abstraction.
[XRay][compiler-rt] FDRLogWriter Abstraction
Wed, Sep 19, 10:24 PM
dberris committed rL342612: [unittests] Do not use llvm::sort in googlemock.
[unittests] Do not use llvm::sort in googlemock
Wed, Sep 19, 9:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Sep 19, 9:29 PM
dberris created D52287: [unittests] Do not use llvm::sort in googlemock.
Wed, Sep 19, 7:34 PM
dberris added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

I have published D52278 for disabling the test on Darwin. So far my investigation shows that __xray_log_select_mode("xray-fdr") returns 2 (aka XRAY_MODE_NOT_FOUND) and that's why we are calling std::abort.

if (__xray_log_select_mode("xray-fdr") !=
    XRayLogRegisterStatus::XRAY_REGISTRATION_OK)
  std::abort();

Any advices on how to troubleshoot this situation? I tried XRAY_OPTIONS="verbosity=1" and XRAY_FDR_OPTIONS="verbosity=1" but there is no extra logging. I am using clang version 8.0.0 (trunk 342513) and it has libclang_rt.xray-basic_osx.a, libclang_rt.xray-fdr_osx.a, libclang_rt.xray-profiling_osx.a, libclang_rt.xray_osx.a.

Wed, Sep 19, 5:02 PM
dberris accepted D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..

LGTM

Wed, Sep 19, 4:56 PM

Tue, Sep 18

dberris committed rCRT342523: [XRay] Detect terminfo library.
[XRay] Detect terminfo library
Tue, Sep 18, 6:37 PM
dberris committed rL342523: [XRay] Detect terminfo library.
[XRay] Detect terminfo library
Tue, Sep 18, 6:37 PM
dberris committed rCRT342518: [XRay][compiler-rt] FDRLogWriter Abstraction.
[XRay][compiler-rt] FDRLogWriter Abstraction
Tue, Sep 18, 5:01 PM
dberris committed rL342518: [XRay][compiler-rt] FDRLogWriter Abstraction.
[XRay][compiler-rt] FDRLogWriter Abstraction
Tue, Sep 18, 5:01 PM
dberris closed D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.
Tue, Sep 18, 5:01 PM
dberris updated subscribers of D51606: [XRay] Remove the deprecated __xray_log_init API.

Is this on Darwin? If it is, then @devnexen has been the one working on making that work. I'm not sure whether there's a way to exclude the XRay test from macOS/Darwin, but the most prudent thing should be to disable it there until the Darwin support is properly fixed.

Tue, Sep 18, 4:01 PM
dberris updated the diff for D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.

Update test to reflect usage in fdr logging runtime.

Tue, Sep 18, 5:58 AM
dberris added inline comments to D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.
Tue, Sep 18, 5:45 AM
dberris updated the diff for D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.

Address comments by @mboerger.

Tue, Sep 18, 5:45 AM
dberris updated the diff for D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.

Update the FDR logging implementation to use the FDRLogWriter implementation. This is ready for another look.

Tue, Sep 18, 3:19 AM
dberris created D52220: [XRay][compiler-rt] FDRLogWriter Abstraction.
Tue, Sep 18, 12:20 AM

Mon, Sep 17

dberris committed rT342426: [XRay] Remove use of deprecated options.
[XRay] Remove use of deprecated options
Mon, Sep 17, 5:31 PM
dberris accepted D52161: [XRay] Encapsulate all FD log related logic into a class.

LGTM

Mon, Sep 17, 4:38 PM
dberris added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

test-suite should be fixed by r342426.

Mon, Sep 17, 4:38 PM
dberris committed rL342426: [XRay] Remove use of deprecated options.
[XRay] Remove use of deprecated options
Mon, Sep 17, 4:35 PM
dberris added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

Who is responsible for updating the clients? Currently in the test suite MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc is failing to compile because it is using __xray::FDRLoggingOptions.

Can you please fix fdrmode-bench.cc to use correct API? Or if it is going to take a lot of time, revert this change?

Mon, Sep 17, 4:12 PM
dberris added inline comments to D52161: [XRay] Encapsulate all FD log related logic into a class.
Mon, Sep 17, 3:59 PM

Sun, Sep 16

dberris added inline comments to D52161: [XRay] Encapsulate all FD log related logic into a class.
Sun, Sep 16, 11:54 PM
dberris accepted D52162: [XRay] Support for Fuchsia.

LGTM -- while I think there might be an opportunity for further cleaning up and isolating the platform-specific bits into different files/directories, in the meantime I suspect adding these preprocessor directives is sufficient.

Sun, Sep 16, 11:50 PM
dberris accepted D52160: [Driver] Support XRay on Fuchsia.

LGTM

Sun, Sep 16, 11:44 PM
dberris committed rCRT342356: [XRay] Simplify FDR buffer management.
[XRay] Simplify FDR buffer management
Sun, Sep 16, 8:10 PM
dberris committed rL342356: [XRay] Simplify FDR buffer management.
[XRay] Simplify FDR buffer management
Sun, Sep 16, 8:10 PM
dberris closed D52077: [XRay] Simplify FDR buffer management.
Sun, Sep 16, 8:10 PM
dberris committed rCRT342355: [XRay] Fix FDR initialization.
[XRay] Fix FDR initialization
Sun, Sep 16, 7:54 PM
dberris accepted D52159: [Lexer] Add xray_instrument feature.
Sun, Sep 16, 7:54 PM
dberris committed rL342355: [XRay] Fix FDR initialization.
[XRay] Fix FDR initialization
Sun, Sep 16, 7:51 PM

Fri, Sep 14

dberris created D52077: [XRay] Simplify FDR buffer management.
Fri, Sep 14, 12:52 AM

Thu, Sep 13

dberris committed rCRT342200: [XRay][clang] Emit "never-instrument" attribute.
[XRay][clang] Emit "never-instrument" attribute
Thu, Sep 13, 7:01 PM
dberris committed rL342200: [XRay][clang] Emit "never-instrument" attribute.
[XRay][clang] Emit "never-instrument" attribute
Thu, Sep 13, 7:00 PM
dberris committed rC342200: [XRay][clang] Emit "never-instrument" attribute.
[XRay][clang] Emit "never-instrument" attribute
Thu, Sep 13, 7:00 PM
dberris closed D52015: [XRay][clang] Emit "never-instrument" attribute.
Thu, Sep 13, 7:00 PM
dberris updated the diff for D52015: [XRay][clang] Emit "never-instrument" attribute.

Retitle, add different test case for -fno-xray-instrument.

Thu, Sep 13, 6:49 PM
dberris committed rCRT342122: [XRay] Bug fixes for FDR custom event and arg-logging.
[XRay] Bug fixes for FDR custom event and arg-logging
Thu, Sep 13, 2:27 AM
dberris committed rL342122: [XRay] Bug fixes for FDR custom event and arg-logging.
[XRay] Bug fixes for FDR custom event and arg-logging
Thu, Sep 13, 2:27 AM
dberris closed D51965: [XRay] Bug fixes for FDR custom event and arg-logging.
Thu, Sep 13, 2:27 AM
dberris updated the diff for D52015: [XRay][clang] Emit "never-instrument" attribute.

Revise description.

Thu, Sep 13, 2:13 AM
dberris updated the diff for D52015: [XRay][clang] Emit "never-instrument" attribute.

Adding an end-to-end test in compiler-rt to ensure that we are not suddenly instrumenting functions that must not be instrumented. Making this a version-locked commit between compiler-rt and clang.

Thu, Sep 13, 2:13 AM
dberris planned changes to D52015: [XRay][clang] Emit "never-instrument" attribute.

This change is still incomplete -- we should really only convey that the 'never' attribute gets preserved. Otherwise we're going to have to invent a way to communicate to the XRay pass in LLVM that we should ignore the XRay attributes.

Thu, Sep 13, 1:29 AM
dberris created D52015: [XRay][clang] Emit "never-instrument" attribute.
Thu, Sep 13, 12:20 AM

Wed, Sep 12

dberris abandoned D50441: [XRay] FDR Trace Dump Tool (FDR Trace Loading Refactor).

All changes here have now landed in a series of patches. Abandoning this revision now.

Wed, Sep 12, 7:57 AM
dberris updated the diff for D51965: [XRay] Bug fixes for FDR custom event and arg-logging.

0xfff... -> 0x0fff...

Wed, Sep 12, 7:15 AM
dberris updated the diff for D51965: [XRay] Bug fixes for FDR custom event and arg-logging.

Address comments by @mboerger.

Wed, Sep 12, 6:38 AM
dberris updated the diff for D51965: [XRay] Bug fixes for FDR custom event and arg-logging.

Retitle, update.

Wed, Sep 12, 12:21 AM
dberris created D51965: [XRay] Bug fixes for FDR custom event and arg-logging.
Wed, Sep 12, 12:20 AM

Tue, Sep 11

dberris committed rL341912: [XRay] Ensure lambda outlives llvm::function_ref.
[XRay] Ensure lambda outlives llvm::function_ref
Tue, Sep 11, 1:08 AM
dberris committed rL341909: [XRay] Write the TSC along with CPUID.
[XRay] Write the TSC along with CPUID
Tue, Sep 11, 12:31 AM

Mon, Sep 10

dberris committed rL341906: [XRay] Use FDR Records+Visitors for Trace Loading.
[XRay] Use FDR Records+Visitors for Trace Loading
Mon, Sep 10, 11:47 PM
dberris closed D51912: [XRay] Use FDR Records+Visitors for Trace Loading.
Mon, Sep 10, 11:47 PM
dberris committed rL341905: [XRay] Add TSC to NewCPUId Records.
[XRay] Add TSC to NewCPUId Records
Mon, Sep 10, 11:41 PM
dberris closed D51911: [XRay] Add TSC to NewCPUId Records.
Mon, Sep 10, 11:41 PM
dberris updated the diff for D51911: [XRay] Add TSC to NewCPUId Records.

Remove explicit from constructor.

Mon, Sep 10, 11:35 PM
dberris added a dependent revision for D51911: [XRay] Add TSC to NewCPUId Records: D51912: [XRay] Use FDR Records+Visitors for Trace Loading.
Mon, Sep 10, 10:56 PM
dberris created D51912: [XRay] Use FDR Records+Visitors for Trace Loading.
Mon, Sep 10, 10:56 PM
dberris created D51911: [XRay] Add TSC to NewCPUId Records.
Mon, Sep 10, 10:45 PM
dberris committed rL341887: [XRay] Add the `llvm-xray fdr-dump` implementation.
[XRay] Add the `llvm-xray fdr-dump` implementation
Mon, Sep 10, 5:24 PM
dberris closed D51846: [XRay] Add the `llvm-xray fdr-dump` implementation.
Mon, Sep 10, 5:24 PM

Sun, Sep 9

dberris updated the diff for D51846: [XRay] Add the `llvm-xray fdr-dump` implementation.

Update description.

Sun, Sep 9, 11:13 PM
dberris created D51846: [XRay] Add the `llvm-xray fdr-dump` implementation.
Sun, Sep 9, 9:42 PM
dberris committed rL341771: [XRay] Remove unused reference.
[XRay] Remove unused reference
Sun, Sep 9, 7:58 PM
dberris committed rL341769: [XRay] Add a BlockVerifier visitor for FDR Records.
[XRay] Add a BlockVerifier visitor for FDR Records
Sun, Sep 9, 7:39 PM
dberris closed D51723: [XRay] Add a BlockVerifier visitor for FDR Records.
Sun, Sep 9, 7:38 PM

Fri, Sep 7

dberris committed rL341647: [XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators.
[XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators
Fri, Sep 7, 3:18 AM
dberris committed rCRT341647: [XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators.
[XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators
Fri, Sep 7, 3:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Sep 7, 3:18 AM
dberris created D51776: [XRay] XRAY_NEVER_INSTRUMENT more functions, consolidate allocators.
Fri, Sep 7, 2:28 AM
dberris updated the diff for D51723: [XRay] Add a BlockVerifier visitor for FDR Records.

Use a struct instead of a std::tuple<...> in the function-local static constexpr array.

Fri, Sep 7, 12:07 AM

Thu, Sep 6

dberris reopened D51723: [XRay] Add a BlockVerifier visitor for FDR Records.

Reverted in rL341631.

Thu, Sep 6, 8:44 PM
dberris added a comment to rL341628: [XRay] Add a BlockVerifier visitor for FDR Records.

Reverted in rL341631.

Thu, Sep 6, 8:40 PM
dberris committed rL341631: Revert "[XRay] Add a BlockVerifier visitor for FDR Records".
Revert "[XRay] Add a BlockVerifier visitor for FDR Records"
Thu, Sep 6, 8:39 PM
dberris committed rL341628: [XRay] Add a BlockVerifier visitor for FDR Records.
[XRay] Add a BlockVerifier visitor for FDR Records
Thu, Sep 6, 7:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Sep 6, 7:26 PM
dberris updated the diff for D51723: [XRay] Add a BlockVerifier visitor for FDR Records.

Rebase, remove unnecessary comments, reformat.

Thu, Sep 6, 7:25 PM
dberris added inline comments to D51723: [XRay] Add a BlockVerifier visitor for FDR Records.
Thu, Sep 6, 6:28 PM