Page MenuHomePhabricator

dberris (Dean Michael Berris)
Software Engineer @ Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2014, 7:30 PM (260 w, 5 d)

Recent Activity

Tue, Feb 12

dberris accepted D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS.

LGTM

Tue, Feb 12, 2:42 PM · Restricted Project, Restricted Project

Mon, Feb 11

dberris accepted D58086: [CMake][XRay] Silence llvm-config error when checking library support.

LGTM

Mon, Feb 11, 5:03 PM · Restricted Project, Restricted Project

Thu, Jan 31

dberris accepted D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests.

LGTM

Thu, Jan 31, 2:09 PM · Restricted Project, Restricted Project

Thu, Jan 24

dberris accepted D57181: Fix XRayTest link on FreeBSD (and likely NetBSD too).

LGTM

Thu, Jan 24, 4:57 PM

Jan 17 2019

dberris accepted D56797: xray: Add missing header to list of installed headers..

LGTM -- thanks! Yes, this should have been public all along.

Jan 17 2019, 1:43 AM

Jan 7 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

More updates to address some comments.

Jan 7 2019, 9:26 PM
dberris added inline comments to D56244: [XRay][docs] XRay Framework Usage Guide.
Jan 7 2019, 9:07 PM
dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Address comments by @greened.

Jan 7 2019, 9:07 PM
dberris created D56383: [XRay][tools] Use symbols instead of function id.
Jan 7 2019, 3:44 AM

Jan 3 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Update description.

Jan 3 2019, 6:46 PM

Jan 2 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Add link to new doc in index.

Jan 2 2019, 10:05 PM
dberris created D56244: [XRay][docs] XRay Framework Usage Guide.
Jan 2 2019, 10:03 PM

Dec 21 2018

dberris added inline comments to D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD.
Dec 21 2018, 4:10 PM

Dec 20 2018

dberris accepted D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

LGTM

Dec 20 2018, 6:59 PM

Dec 19 2018

dberris accepted D55842: Let TableGen write output only if it changed, instead of doing so in cmake, attempt 2.

LGTM -- cannot reproduce the original issue with this patch.

Dec 19 2018, 1:42 AM
dberris added a comment to D55842: Let TableGen write output only if it changed, instead of doing so in cmake, attempt 2.

Apologies for the delay, but I'm giving this a go now.

Dec 19 2018, 1:27 AM

Dec 13 2018

dberris accepted D55691: [Object] Rename getRelrRelocationType to getRelativeRelocationType.

LGTM

Dec 13 2018, 11:46 PM
dberris accepted D55689: [llvm-xray] Store offset pointers in temporaries.

LGTM

Dec 13 2018, 9:34 PM
dberris accepted D55542: [llvm-xray] Support for PIE.

LGTM still, thanks @phosek!

Dec 13 2018, 5:19 PM

Dec 11 2018

dberris accepted D55548: [XRay] Add a helper function sortByKey to simplify code.

LGTM -- Thanks @MaskRay!

Dec 11 2018, 4:09 AM

Dec 10 2018

dberris accepted D55542: [llvm-xray] Support for PIE.

LGTM -- Thanks @phosek!

Dec 10 2018, 8:25 PM

Dec 6 2018

dberris committed rCRT348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Dec 6 2018, 10:26 PM
dberris committed rL348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Dec 6 2018, 10:26 PM
dberris closed D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 6 2018, 10:26 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase again. This is now ready for another look.

Dec 6 2018, 10:01 PM
dberris committed rCRT348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 6 2018, 7:22 PM
dberris committed rL348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 6 2018, 7:22 PM

Dec 5 2018

dberris committed rCRT348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 7:32 PM
dberris committed rL348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 7:32 PM
dberris committed rL348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Dec 5 2018, 6:58 PM
dberris committed rCRT348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Dec 5 2018, 6:58 PM
dberris committed rCRT348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Dec 5 2018, 5:59 PM
dberris committed rL348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Dec 5 2018, 5:59 PM
dberris committed rCRT348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 4:29 PM
dberris committed rL348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 4:29 PM

Dec 4 2018

dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase.

Dec 4 2018, 11:29 PM
dberris committed rL348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Dec 4 2018, 11:17 PM
dberris committed rCRT348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Dec 4 2018, 11:17 PM
dberris committed rL348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Dec 4 2018, 11:08 PM
dberris committed rCRT348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Dec 4 2018, 11:08 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Addressing comment by @mboerger.

Dec 4 2018, 10:57 PM
dberris committed rL348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Dec 4 2018, 10:48 PM
dberris committed rCRT348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Dec 4 2018, 10:47 PM
dberris closed D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Dec 4 2018, 10:47 PM

Dec 3 2018

dberris created D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 3 2018, 9:12 PM
dberris added a child revision for D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array: D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 3 2018, 9:12 PM

Nov 28 2018

dberris added inline comments to D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Nov 28 2018, 12:33 AM
dberris updated the diff for D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.

Addressing comments by @mboerger.

Nov 28 2018, 12:32 AM

Nov 27 2018

dberris created D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Nov 27 2018, 9:36 PM

Nov 21 2018

dberris accepted D54784: Use --push/pop-state with XRay link deps.

LGTM

Nov 21 2018, 6:51 PM

Nov 20 2018

dberris committed rCRT347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Nov 20 2018, 4:33 PM
dberris committed rL347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Nov 20 2018, 4:33 PM

Nov 19 2018

dberris committed rCRT347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Nov 19 2018, 7:58 PM
dberris committed rL347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Nov 19 2018, 7:58 PM
dberris committed rCRT347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Nov 19 2018, 5:05 PM
dberris committed rL347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Nov 19 2018, 5:05 PM
dberris closed D54684: [XRay] Move buffer extents back to the heap.
Nov 19 2018, 5:05 PM
dberris updated the diff for D54684: [XRay] Move buffer extents back to the heap.

clang-format with LLVM style

Nov 19 2018, 3:38 PM
dberris added inline comments to D54684: [XRay] Move buffer extents back to the heap.
Nov 19 2018, 2:00 PM

Nov 18 2018

dberris created D54684: [XRay] Move buffer extents back to the heap.
Nov 18 2018, 9:33 PM

Nov 8 2018

dberris committed rCRT346477: [XRay] Add a test for function id encoding/decoding (NFC).
[XRay] Add a test for function id encoding/decoding (NFC)
Nov 8 2018, 11:46 PM
dberris committed rL346477: [XRay] Add a test for function id encoding/decoding (NFC).
[XRay] Add a test for function id encoding/decoding (NFC)
Nov 8 2018, 11:46 PM
dberris committed rCRT346476: [XRay] Add a static assertion on size of metadata payload (NFC).
[XRay] Add a static assertion on size of metadata payload (NFC)
Nov 8 2018, 11:19 PM
dberris committed rL346476: [XRay] Add a static assertion on size of metadata payload (NFC).
[XRay] Add a static assertion on size of metadata payload (NFC)
Nov 8 2018, 11:19 PM
dberris committed rCRT346475: [XRay] Fix enter function tracing for record unwriting.
[XRay] Fix enter function tracing for record unwriting
Nov 8 2018, 10:51 PM
dberris committed rL346475: [XRay] Fix enter function tracing for record unwriting.
[XRay] Fix enter function tracing for record unwriting
Nov 8 2018, 10:51 PM
dberris closed D54292: [XRay] Fix enter function tracing for record unwriting.
Nov 8 2018, 10:51 PM
dberris committed rCRT346474: [XRay] Add atomic fences around non-atomic reads and writes.
[XRay] Add atomic fences around non-atomic reads and writes
Nov 8 2018, 10:42 PM
dberris committed rL346474: [XRay] Add atomic fences around non-atomic reads and writes.
[XRay] Add atomic fences around non-atomic reads and writes
Nov 8 2018, 10:42 PM
dberris closed D54291: [XRay] Add atomic fences around non-atomic reads and writes.
Nov 8 2018, 10:42 PM
dberris committed rCRT346473: [XRay] Improve FDR trace handling and error messaging.
[XRay] Improve FDR trace handling and error messaging
Nov 8 2018, 10:30 PM
dberris committed rL346473: [XRay] Improve FDR trace handling and error messaging.
[XRay] Improve FDR trace handling and error messaging
Nov 8 2018, 10:30 PM
dberris closed D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 8 2018, 10:30 PM
dberris created D54292: [XRay] Fix enter function tracing for record unwriting.
Nov 8 2018, 9:04 PM
dberris created D54291: [XRay] Add atomic fences around non-atomic reads and writes.
Nov 8 2018, 9:02 PM
dberris added inline comments to D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 8 2018, 8:33 PM
dberris updated the diff for D54201: [XRay] Improve FDR trace handling and error messaging.

Address some comments by @mboerger.

Nov 8 2018, 8:32 PM

Nov 7 2018

dberris committed rL346306: [XRay] Clean up more std::copy(...)'s.
[XRay] Clean up more std::copy(...)'s
Nov 7 2018, 3:55 AM
dberris committed rL346304: [XRay] Use explicit string conversion.
[XRay] Use explicit string conversion
Nov 7 2018, 3:47 AM
dberris created D54201: [XRay] Improve FDR trace handling and error messaging.
Nov 7 2018, 2:08 AM

Nov 6 2018

dberris committed rCRT346293: [XRay] Use TSC delta encoding for custom/typed events.
[XRay] Use TSC delta encoding for custom/typed events
Nov 6 2018, 8:40 PM
dberris committed rL346293: [XRay] Use TSC delta encoding for custom/typed events.
[XRay] Use TSC delta encoding for custom/typed events
Nov 6 2018, 8:40 PM
dberris closed D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 6 2018, 8:40 PM
dberris added a comment to D49025: [XRay] basic mode PID and TID always fetch.

Aha! Right, I think the test is wrong indeed. We shouldn't be assuming that the tid == pid in the test, when recording the first argument for the thread id, and rather be calling the correct function for getting the thread id all the time.

Nov 6 2018, 2:42 PM
dberris added inline comments to D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 6 2018, 1:01 AM
dberris updated the diff for D54140: [XRay] Use TSC delta encoding for custom/typed events.

Address comments by @mboerger.

Nov 6 2018, 1:01 AM
dberris committed rCRT346214: [XRay] Update XRayRecord to support Custom/Typed Events.
[XRay] Update XRayRecord to support Custom/Typed Events
Nov 6 2018, 12:54 AM
dberris committed rL346214: [XRay] Update XRayRecord to support Custom/Typed Events.
[XRay] Update XRayRecord to support Custom/Typed Events
Nov 6 2018, 12:54 AM
dberris closed D54139: [XRay] Update XRayRecord to support Custom/Typed Events.
Nov 6 2018, 12:54 AM

Nov 5 2018

dberris updated the diff for D54139: [XRay] Update XRayRecord to support Custom/Typed Events.

Address comments, handle more cases where enum is used in tools.

Nov 5 2018, 11:38 PM
dberris created D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 5 2018, 11:23 PM
dberris added a child revision for D54139: [XRay] Update XRayRecord to support Custom/Typed Events: D54140: [XRay] Use TSC delta encoding for custom/typed events.
Nov 5 2018, 11:23 PM
dberris created D54139: [XRay] Update XRayRecord to support Custom/Typed Events.
Nov 5 2018, 9:41 PM
dberris added a comment to D49025: [XRay] basic mode PID and TID always fetch.

This test seems to have a Linux assumption and I have concerns how to port it to NetBSD.

On NetBSD TIDs start from 1 to N in each process. Each process has a single distinct PID. TID numbers are not unique between processes (they are unique only within a process). PID numbers are unique.

On Linux TID is effectively PID and this is linuxism.

Nov 5 2018, 8:38 PM
dberris accepted D54136: Prioritize the constructor call of __local_xray_dyninit().

Has this been tested with GCC/Clang on other systems (like Linux)?

Nov 5 2018, 7:56 PM · Restricted Project

Nov 4 2018

dberris committed rCRT346116: [XRay] Update TSC math to handle wraparound.
[XRay] Update TSC math to handle wraparound
Nov 4 2018, 9:48 PM
dberris committed rL346116: [XRay] Update TSC math to handle wraparound.
[XRay] Update TSC math to handle wraparound
Nov 4 2018, 9:47 PM
dberris closed D54088: [XRay] Update TSC math to handle wraparound.
Nov 4 2018, 9:47 PM
dberris updated the diff for D54088: [XRay] Update TSC math to handle wraparound.

FIx typo in title.

Nov 4 2018, 9:29 PM
dberris created D54088: [XRay] Update TSC math to handle wraparound.
Nov 4 2018, 9:17 PM