dberris (Dean Michael Berris)
Software Engineer @ Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2014, 7:30 PM (230 w, 3 d)

Recent Activity

Fri, Jul 20

dberris planned changes to D48370: [XRay][llvm] Load XRay Profiles.
Fri, Jul 20, 3:14 AM
dberris updated the diff for D48370: [XRay][llvm] Load XRay Profiles.
  • fixup: Handle profile loading better in llvm-xray
  • fixup: profileFromTrace(Trace) -> Expected<Profile>
  • fixup: Update some comments
  • fixup: FIXME markers, additional tests, rename path to expandPath
Fri, Jul 20, 3:14 AM

Thu, Jul 19

dberris accepted D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.

LGTM -- Thanks @Maknee!

Thu, Jul 19, 3:34 PM
dberris updated subscribers of rCRT337443: [XRay][compiler-rt] Profiling: No files when empty.
Thu, Jul 19, 6:06 AM
dberris added 2 auditor(s) for rCRT337441: [XRay][compiler-rt] FDR Mode: Add extents metadata to buffer: kpw, eizan.
Thu, Jul 19, 6:05 AM
dberris added 2 auditor(s) for rCRT337443: [XRay][compiler-rt] Profiling: No files when empty: kpw, eizan.
Thu, Jul 19, 6:04 AM
dberris committed rCRT337443: [XRay][compiler-rt] Profiling: No files when empty.
[XRay][compiler-rt] Profiling: No files when empty
Thu, Jul 19, 2:25 AM
dberris committed rL337443: [XRay][compiler-rt] Profiling: No files when empty.
[XRay][compiler-rt] Profiling: No files when empty
Thu, Jul 19, 2:25 AM

Wed, Jul 18

dberris committed rL337441: [XRay][compiler-rt] FDR Mode: Add extents metadata to buffer.
[XRay][compiler-rt] FDR Mode: Add extents metadata to buffer
Wed, Jul 18, 10:22 PM
dberris committed rCRT337441: [XRay][compiler-rt] FDR Mode: Add extents metadata to buffer.
[XRay][compiler-rt] FDR Mode: Add extents metadata to buffer
Wed, Jul 18, 10:22 PM
dberris accepted D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte).

LGTM -- +1 to @pcc's suggestion on wording of the comment.

Wed, Jul 18, 7:24 PM
dberris added a comment to D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.

Thanks for the review! Before I commit this, would it be possible to change the second part of the test (after line 82) to be scheduling independent?

Wed, Jul 18, 4:48 PM
dberris accepted D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.

I've been wondering the same with local failures but hadn't looked at it closely, thanks @ormris!

Wed, Jul 18, 4:31 PM
dberris added inline comments to D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte).
Wed, Jul 18, 4:26 PM

Tue, Jul 17

dberris committed rL337343: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
[XRay][compiler-rt] Segmented Array: Simplify and Optimise
Tue, Jul 17, 7:13 PM
dberris committed rCRT337343: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
[XRay][compiler-rt] Segmented Array: Simplify and Optimise
Tue, Jul 17, 7:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jul 17, 7:13 PM
dberris added inline comments to D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte).
Tue, Jul 17, 7:09 PM
dberris committed rCRT337342: [XRay][compiler-rt] Simplify Allocator Implementation.
[XRay][compiler-rt] Simplify Allocator Implementation
Tue, Jul 17, 6:58 PM
dberris committed rL337342: [XRay][compiler-rt] Simplify Allocator Implementation.
[XRay][compiler-rt] Simplify Allocator Implementation
Tue, Jul 17, 6:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jul 17, 6:58 PM
dberris committed rCRT337341: [XRay][compiler-rt] FDR Mode: Allow multiple runs.
[XRay][compiler-rt] FDR Mode: Allow multiple runs
Tue, Jul 17, 6:36 PM
dberris committed rL337341: [XRay][compiler-rt] FDR Mode: Allow multiple runs.
[XRay][compiler-rt] FDR Mode: Allow multiple runs
Tue, Jul 17, 6:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Jul 17, 6:36 PM

Mon, Jul 16

dberris added inline comments to D49363: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
Mon, Jul 16, 6:25 PM
dberris updated the diff for D49363: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
  • fixup: remove static assert on size and remove outdated comment
Mon, Jul 16, 6:24 PM
dberris added a comment to D49363: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.

For reference, here's one run of this:

Mon, Jul 16, 12:38 AM
dberris created D49363: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
Mon, Jul 16, 12:26 AM
dberris added a dependent revision for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation: D49363: [XRay][compiler-rt] Segmented Array: Simplify and Optimise.
Mon, Jul 16, 12:26 AM

Sun, Jul 15

dberris created D49359: [XRay][compiler-rt] FDR Mode: Allow multiple runs.
Sun, Jul 15, 8:39 PM
dberris committed rCRT337142: [XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests.
[XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests
Sun, Jul 15, 6:14 PM
dberris committed rL337142: [XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests.
[XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests
Sun, Jul 15, 6:14 PM
dberris closed D49358: [XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests.
Sun, Jul 15, 6:14 PM
dberris added a reviewer for D49358: [XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests: eizan.
Sun, Jul 15, 6:09 PM
dberris created D49358: [XRay][compiler-rt] Use `SANITIZER_CXX_ABI_LIBRARY` for XRay unit tests.
Sun, Jul 15, 6:08 PM
dberris added a comment to D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.

I'm not sure why these utilities are being added, is there some other patch that will be using this?

Sun, Jul 15, 5:38 PM
dberris added inline comments to D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Sun, Jul 15, 5:29 PM
dberris accepted D49346: [CMake] Use cxx-headers as a depedency for C++ headers.

LGTM on the XRay side.

Sun, Jul 15, 5:23 PM

Thu, Jul 12

dberris committed rL336974: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record….
[XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record…
Thu, Jul 12, 10:43 PM
dberris committed rCRT336974: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record….
[XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record…
Thu, Jul 12, 10:43 PM
dberris closed D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.
Thu, Jul 12, 10:43 PM
dberris committed rT336970: [XRay][test-suite] Benchmarks for profiling mode implementation.
[XRay][test-suite] Benchmarks for profiling mode implementation
Thu, Jul 12, 9:54 PM
dberris committed rL336970: [XRay][test-suite] Benchmarks for profiling mode implementation.
[XRay][test-suite] Benchmarks for profiling mode implementation
Thu, Jul 12, 9:53 PM
dberris closed D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
Thu, Jul 12, 9:53 PM
dberris updated the diff for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.

Add some documentation on the benchmarks, make all benchmarks consistent.

Thu, Jul 12, 9:39 PM
dberris committed rCRT336969: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
[XRay][compiler-rt] Profiling Mode: Flush logs on exit
Thu, Jul 12, 9:09 PM
dberris committed rL336969: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
[XRay][compiler-rt] Profiling Mode: Flush logs on exit
Thu, Jul 12, 9:09 PM
dberris closed D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
Thu, Jul 12, 9:09 PM
dberris accepted D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

One style comment, and I'm happy to land after that.

Thu, Jul 12, 4:29 PM
dberris added a comment to D49177: [CMake] Remove unnecesary list of source files for Xray unit tests..

LGTM -- @nglevin was working on getting the XRay unit tests at least build and run but got interrupted.

The original reason for doing this was to ensure that when any of the implementation files changed, that the unit tests would be built. As you've learned this only made sense for platforms where the tests are built and run.

In general, in CMake, the target for running a test is made to be dependent on the unit test being executed.. In turn the unit test is linked against the libraries it uses. If the source files for a library change that should trigger the library to be rebuilt. At the minimum this will cause the unit test to be relinked. If the unit test also depends on header files that have changed that should cause the unit test to be recompiled too.

Why is that not sufficient for us?

Thu, Jul 12, 6:54 AM
dberris added a comment to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Thanks @Maknee -- now if you look in llvm/test/tools/llvm-xray/X86 you'll find some tests for the llvm-xray tool. Also, in the Inputs sub-directory, you'll find sample XRay traces of the old versions. It would be great if you can add version 3 sample binary traces there and add more tests to ensure that we are getting the expected data from the tools handling the newer version(s) of the traces.

Okay, will do.

Thu, Jul 12, 1:22 AM
dberris added a comment to D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.

For reference, here's the benchmark run against the current state of head (deep-call-bench):

Thu, Jul 12, 12:30 AM
dberris created D49217: [XRay][compiler-rt] Simplify Allocator Implementation.
Thu, Jul 12, 12:06 AM
dberris added a dependent revision for D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit: D49217: [XRay][compiler-rt] Simplify Allocator Implementation.
Thu, Jul 12, 12:06 AM
dberris updated the diff for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.

Use thread real-time instead of CPU time in benchmarks and reduce depths to 64 max.

Thu, Jul 12, 12:03 AM

Wed, Jul 11

dberris updated the diff for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.

Update to add wide call-tree benchmarks.

Wed, Jul 11, 11:17 PM
dberris updated the diff for D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.

Rebase

Wed, Jul 11, 8:38 PM
dberris added inline comments to D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
Wed, Jul 11, 8:36 PM
dberris added a comment to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Thanks @Maknee -- now if you look in llvm/test/tools/llvm-xray/X86 you'll find some tests for the llvm-xray tool. Also, in the Inputs sub-directory, you'll find sample XRay traces of the old versions. It would be great if you can add version 3 sample binary traces there and add more tests to ensure that we are getting the expected data from the tools handling the newer version(s) of the traces.

Wed, Jul 11, 7:48 PM
dberris committed rCRT336878: [XRay][compiler-rt] Fixup: require x86_64 for profiling mode tests.
[XRay][compiler-rt] Fixup: require x86_64 for profiling mode tests
Wed, Jul 11, 6:59 PM
dberris committed rL336878: [XRay][compiler-rt] Fixup: require x86_64 for profiling mode tests.
[XRay][compiler-rt] Fixup: require x86_64 for profiling mode tests
Wed, Jul 11, 6:59 PM
dberris accepted D49187: [XRay] Fix machine verifier issues in X86.

This was my bad, as I was cargo-culting the definition from other pseudo-instructions. It hadn't occurred to me that these pseudo-instructions didn't need to have outputs defined.

Wed, Jul 11, 5:20 PM
dberris added inline comments to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.
Wed, Jul 11, 5:01 PM
dberris accepted D49177: [CMake] Remove unnecesary list of source files for Xray unit tests..

LGTM -- @nglevin was working on getting the XRay unit tests at least build and run but got interrupted.

Wed, Jul 11, 4:53 PM
dberris committed rL336769: [XRay] basic mode PID and TID always fetch.
[XRay] basic mode PID and TID always fetch
Wed, Jul 11, 12:19 AM
dberris committed rCRT336769: [XRay] basic mode PID and TID always fetch.
[XRay] basic mode PID and TID always fetch
Wed, Jul 11, 12:19 AM
dberris closed D49025: [XRay] basic mode PID and TID always fetch.
Wed, Jul 11, 12:19 AM
dberris added a comment to D49116: Setup clang-format as an Arcanist linter.

One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.

Wed, Jul 11, 12:09 AM

Tue, Jul 10

dberris requested changes to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

This is where we're going to need to update the log version, because the tool(s) need to handle older versions of the log which don't contain the PID records.

Tue, Jul 10, 4:27 PM
dberris added inline comments to D49116: Setup clang-format as an Arcanist linter.
Tue, Jul 10, 4:14 PM
dberris added a comment to D48370: [XRay][llvm] Load XRay Profiles.
In D48370#1157578, @kpw wrote:

Is this still a work in progress patch as noted? I'll make some time to look at this today.

Tue, Jul 10, 4:03 PM
dberris added inline comments to D49116: Setup clang-format as an Arcanist linter.
Tue, Jul 10, 8:15 AM
dberris committed rL336648: [XRay][compiler-rt] Fixup build breakage.
[XRay][compiler-rt] Fixup build breakage
Tue, Jul 10, 2:03 AM
dberris committed rCRT336648: [XRay][compiler-rt] Fixup build breakage.
[XRay][compiler-rt] Fixup build breakage
Tue, Jul 10, 2:03 AM
dberris committed rCRT336644: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
[XRay][compiler-rt] xray::Array Freelist and Iterator Updates
Tue, Jul 10, 1:31 AM
dberris committed rL336644: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
[XRay][compiler-rt] xray::Array Freelist and Iterator Updates
Tue, Jul 10, 1:30 AM
dberris closed D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
Tue, Jul 10, 1:30 AM
dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

Address comments, rebase, before landing.

Tue, Jul 10, 12:23 AM
dberris added a comment to D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
In D48653#1156953, @kpw wrote:

Seems like half of this change is DCHECKS. Much better coverage! Was that just a result of your strategy for diagnosing what actually caused the problems and leaving those in?

Tue, Jul 10, 12:22 AM

Mon, Jul 9

dberris accepted D49025: [XRay] basic mode PID and TID always fetch.

LGTM, with one minor comment.

Mon, Jul 9, 5:26 PM
dberris added inline comments to D49025: [XRay] basic mode PID and TID always fetch.
Mon, Jul 9, 1:35 AM
dberris requested changes to D49025: [XRay] basic mode PID and TID always fetch.

Thanks @Maknee -- can you remove the 'TID' from thread-local data for basic mode logging to ensure that we've removed all references to it?

Mon, Jul 9, 1:31 AM

Wed, Jul 4

dberris added a dependent revision for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates: D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
Wed, Jul 4, 9:00 PM
dberris created D48956: [XRay][compiler-rt] Profiling Mode: Flush logs on exit.
Wed, Jul 4, 9:00 PM
dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

Reverting change, restoring "good" state.

Wed, Jul 4, 6:04 PM
dberris updated the diff for D48370: [XRay][llvm] Load XRay Profiles.

Rebase, update description.

Wed, Jul 4, 6:03 PM
dberris added a dependent revision for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates: D48370: [XRay][llvm] Load XRay Profiles.
Wed, Jul 4, 6:03 PM
dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

Update description, rebase on top of bug-fix change in profiling mode.

Wed, Jul 4, 6:01 PM

Tue, Jul 3

dberris updated the summary of D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
Tue, Jul 3, 10:31 PM
dberris updated the diff for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
  • fixup: add a wide-call benchmark, recursion to simulate call depth
Tue, Jul 3, 10:29 PM
dberris updated the diff for D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
  • fixup: cleanup init/tear-down
Tue, Jul 3, 7:57 PM
dberris added a reviewer for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates: eizan.
Tue, Jul 3, 7:56 PM
dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
  • fixup: clean up some more, now ready for a look.
Tue, Jul 3, 7:55 PM
dberris added a comment to D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

This change is now bigger than the original posted, and I'm going to spend a bit more time cleaning it up. In particular I intend to:

  • Explore more edge cases in the unit tests for the segmented array.
Tue, Jul 3, 7:52 PM
dberris planned changes to D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.

Some initial numbers for context:

Tue, Jul 3, 6:55 AM
dberris created D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
Tue, Jul 3, 6:38 AM
dberris added a dependent revision for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates: D48879: [XRay][test-suite] Benchmarks for profiling mode implementation.
Tue, Jul 3, 6:38 AM
dberris planned changes to D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.

This change is now bigger than the original posted, and I'm going to spend a bit more time cleaning it up. In particular I intend to:

Tue, Jul 3, 6:20 AM
dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
  • Rebase to master.
    • fixup: Add a test to an additional edge-case; propagate extents into iterator
    • fixup: play with alignment, flags, and testing properly
    • fixup: fix bug in trim implementation in isolation
    • fixup: all changes to fix benchmark run
Tue, Jul 3, 2:44 AM

Thu, Jun 28

dberris updated the diff for D48653: [XRay][compiler-rt] xray::Array Freelist and Iterator Updates.
  • fixup: Add a test to an additional edge-case; propagate extents into iterator
Thu, Jun 28, 8:55 PM