User Details
- User Since
- Nov 1 2021, 11:53 PM (72 w, 5 d)
Thu, Mar 23
Tue, Mar 21
LGTM except a nit.
Thu, Mar 16
Wed, Mar 15
Mon, Mar 13
Wed, Mar 8
Address @DavidSpickett's comments.
Tue, Mar 7
Address @DavidSpickett's comments.
- Fix the && issue.
- Make the test more readable.
Mon, Mar 6
Feb 16 2023
Yes, I think the ISA's pseudo-code description is incorrect. Maybe it shoud be:
bytepick.w:
Feb 15 2023
LGTM. Thanks.
Feb 14 2023
Feb 12 2023
Thanks for the improvements. LGTM. What do others think?
Feb 10 2023
Feb 7 2023
Feb 6 2023
Feb 5 2023
Address @vzakhari's comments and add LoongArch to more target-rewrite tests.
Feb 1 2023
Jan 31 2023
LGTM. Thanks!
Jan 29 2023
Jan 28 2023
Thanks. Overall LGTM except the handling of FeatureBits (maybe can be handled in a seperate patch) and some nits.
Jan 22 2023
Verification result: llvm is successfully built/linked by clang/lld with this patch applied.
Jan 21 2023
I just verified the latest change, lld still fail to link llvm and report the error:
ld.lld: error: relocation R_LARCH_PCALA_HI20 cannot be used against symbol '__cxa_atexit'; recompile with -fPIC >>> defined in /usr/lib64/libc.so.6 >>> referenced by atexit.c:46 (../stdlib/atexit.c:46) >>> atexit.oS:(atexit) in archive /usr/lib64/libc_nonshared.a clang-16: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed.
Maybe should mention LLD in the title?
LGTM. Happy Chinese new year!
Jan 17 2023
Jan 15 2023
According to https://llvm.org/docs/HowToReleaseLLVM.html#release-patch-rules there might be 10 days (before RC1) for us. Hope we can finish it.
Does anyone know why patchable-function-entry is not documented in https://llvm.org/docs/LangRef.html#function-attributes?
Jan 14 2023
Fix the issue "Title underline too short" reported by sphinx-build.
Jan 13 2023
I'm not sure if there is any format issue. Is there any way to verify? e.g. how to generate .html like https://llvm.org/docs/ReleaseNotes.html?
Jan 12 2023
Seems that missing atest in llvm/test/Instrumentation/MemorySanitizer/.
LGTM. Is there any objection?
Jan 11 2023
Jan 10 2023
Expensive check fail https://lab.llvm.org/buildbot/#/builders/16/builds/41677. I will fix it as soon as possilbe or revert this change.
Thanks to all you guys to make things happen!
Jan 9 2023
This change failed the https://github.com/llvm/llvm-test-suite/blob/main/SingleSource/Regression/C/gcc-c-torture/execute/pr59747.c (-O2/-O3) on many platforms including x86-64.
Generally speaking ping is supposed to be once a week. But I ping now in order to have more time to resolve potential compiling or testing issues when the backend was exposed to other bots.
Jan 8 2023
rebase