This is an archive of the discontinued LLVM Phabricator instance.

[XRay] Unsupport version<2 sled entry
ClosedPublic

Authored by MaskRay on Dec 28 2022, 12:40 PM.

Details

Summary

For many features we expect clang and compiler-rt to have a version lock
relation, yet for XRaySledEntry we have kept version<2 compatibility for more
than 2 years (I migrated away the last user mips in 2020-09 (D87977)).
I think it's fair to call an end to version<2 now. This should discourage more
work on version<2 (e.g. D140725).

Diff Detail

Event Timeline

MaskRay created this revision.Dec 28 2022, 12:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 12:40 PM
MaskRay requested review of this revision.Dec 28 2022, 12:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2022, 12:40 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ianlevesque accepted this revision.Dec 28 2022, 1:16 PM

Makes sense to me

This revision is now accepted and ready to land.Dec 28 2022, 1:16 PM
This revision was automatically updated to reflect the committed changes.