Page MenuHomePhabricator

ianlevesque (Ian Levesque)
Software Engineer @ Facebook

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2019, 1:46 PM (15 w, 10 h)

Recent Activity

Tue, Feb 11

ianlevesque added a comment to D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

Is it worth adding a test that a function with an explicit xray-instrument attribute also has these other attributes applied?

Tue, Feb 11, 1:55 PM · Restricted Project
ianlevesque updated the diff for D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

Address code review feedback on the tests.

Tue, Feb 11, 1:36 PM · Restricted Project

Mon, Feb 10

ianlevesque updated the diff for D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

Now with 100% more tests.

Mon, Feb 10, 11:36 PM · Restricted Project

Thu, Feb 6

ianlevesque added a comment to D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

@hiraditya or @smeenai can i get a merge?

Thu, Feb 6, 12:56 AM · Restricted Project

Wed, Feb 5

ianlevesque updated the diff for D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

Address code review nits

Wed, Feb 5, 7:03 PM · Restricted Project

Mon, Feb 3

ianlevesque added inline comments to D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.
Mon, Feb 3, 11:29 AM · Restricted Project

Sat, Feb 1

ianlevesque created D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.
Sat, Feb 1, 2:59 PM · Restricted Project

Jan 17 2020

ianlevesque updated the diff for D72890: [xray] Allow instrumenting only function entry and/or only function exit.

Add x86 tests

Jan 17 2020, 12:57 PM · Restricted Project, Restricted Project
ianlevesque added inline comments to D72873: [clang][xray] Add -fxray-ignore-loops option.
Jan 17 2020, 10:22 AM · Restricted Project

Jan 16 2020

ianlevesque added reviewers for D72873: [clang][xray] Add -fxray-ignore-loops option: hiraditya, smeenai.
Jan 16 2020, 4:40 PM · Restricted Project
ianlevesque created D72890: [xray] Allow instrumenting only function entry and/or only function exit.
Jan 16 2020, 4:31 PM · Restricted Project, Restricted Project
ianlevesque updated the diff for D72873: [clang][xray] Add -fxray-ignore-loops option.

fix clang-format

Jan 16 2020, 1:36 PM · Restricted Project
ianlevesque created D72873: [clang][xray] Add -fxray-ignore-loops option.
Jan 16 2020, 1:35 PM · Restricted Project

Jan 14 2020

ianlevesque added a comment to D72659: [xray] Add xray-ignore-loops option.

I'm wondering how you're imbuing these attributes to the functions from the front-ends -- is this something you intend to support as a flag in Clang for example?

Jan 14 2020, 10:52 AM · Restricted Project

Jan 13 2020

ianlevesque updated the diff for D72659: [xray] Add xray-ignore-loops option.

Remove extraneous changes

Jan 13 2020, 3:35 PM · Restricted Project
ianlevesque created D72659: [xray] Add xray-ignore-loops option.
Jan 13 2020, 3:27 PM · Restricted Project

Dec 5 2019

ianlevesque updated subscribers of D69386: [xray] Remove cl::sub from alias options.

@smeenai or @hiraditya we could use this too, maybe one of you can merge?

Dec 5 2019, 6:16 PM · Restricted Project

Nov 7 2019

ianlevesque added a comment to D69967: [llvm-xray] Add AArch64 to llvm-xray extract.

I don't have commit access, can someone land it?

Nov 7 2019, 4:00 PM · Restricted Project
ianlevesque updated the diff for D69967: [llvm-xray] Add AArch64 to llvm-xray extract.

rename Supports

Nov 7 2019, 1:58 PM · Restricted Project
ianlevesque added reviewers for D69967: [llvm-xray] Add AArch64 to llvm-xray extract: phosek, dberris.
Nov 7 2019, 1:47 PM · Restricted Project
ianlevesque added reviewers for D69967: [llvm-xray] Add AArch64 to llvm-xray extract: tetsuo-cpp, smeenai.
Nov 7 2019, 1:47 PM · Restricted Project
ianlevesque created D69967: [llvm-xray] Add AArch64 to llvm-xray extract.
Nov 7 2019, 1:37 PM · Restricted Project