This is an archive of the discontinued LLVM Phabricator instance.

Lift EHPersonalities from Analysis to IR (NFC)
ClosedPublic

Authored by sgraenitz on Nov 16 2022, 5:02 AM.

Details

Summary

Computing EH-related information was only relevant for analysis passes so far. Lifting it to IR will allow the IR Verifier to calculate EH funclet coloring and validate funclet operand bundles in a follow-up step.

Diff Detail

Event Timeline

sgraenitz created this revision.Nov 16 2022, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2022, 5:02 AM
sgraenitz requested review of this revision.Nov 16 2022, 5:02 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 16 2022, 5:02 AM
rnk accepted this revision.Nov 16 2022, 12:49 PM

Sounds good to me. I think we just put it in Analysis in an attempt to keep IR small and focused, and particularly to avoid putting more target-specific logic in IR.

This revision is now accepted and ready to land.Nov 16 2022, 12:49 PM
compnerd accepted this revision.Nov 22 2022, 7:55 AM

Additional validation is never a bad thing :). Please do sort the headers before committing.

sgraenitz updated this revision to Diff 477433.Nov 23 2022, 2:45 AM

clang-format includes and sort clang-formatted-files.txt

This revision was landed with ongoing or failed builds.Jan 27 2023, 9:06 AM
This revision was automatically updated to reflect the committed changes.