Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (271 w, 5 d)

We may think in generalities, but weliveindetail

Recent Activity

Wed, Sep 13

sgraenitz added a comment to D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

https://github.com/llvm/llvm-project/commit/29f6c0fdfeb48f5f766d2ba02014358df69e8170 should avoid the issue

Wed, Sep 13, 2:41 PM · Restricted Project, Restricted Project
sgraenitz committed rG29f6c0fdfeb4: [JITLink][AArch32] Fix MSVC error on missing constexpr capture (authored by sgraenitz).
[JITLink][AArch32] Fix MSVC error on missing constexpr capture
Wed, Sep 13, 2:40 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

I can fix it now

Wed, Sep 13, 2:33 PM · Restricted Project, Restricted Project
sgraenitz committed rG8d99bf92b552: [JITLink][AArch32] Revisit descriptions for Call and Jump24 relocation types… (authored by sgraenitz).
[JITLink][AArch32] Revisit descriptions for Call and Jump24 relocation types…
Wed, Sep 13, 9:59 AM · Restricted Project, Restricted Project
sgraenitz committed rG21ee9e4b26a2: [JITLink][AArch32] Remove duplicate '0x' hex prefixes from formatv strings in… (authored by sgraenitz).
[JITLink][AArch32] Remove duplicate '0x' hex prefixes from formatv strings in…
Wed, Sep 13, 9:59 AM · Restricted Project, Restricted Project
sgraenitz committed rG1025189ea0bf: [JITLink][AArch32] Don't adjust Thumb bit in fixup code; it doesn't contribute… (authored by sgraenitz).
[JITLink][AArch32] Don't adjust Thumb bit in fixup code; it doesn't contribute…
Wed, Sep 13, 9:59 AM · Restricted Project, Restricted Project
sgraenitz committed rG142c89c381bc: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation (authored by Eymay).
[JITLink][AArch32] Implement ELF::R_ARM_CALL relocation
Wed, Sep 13, 8:17 AM · Restricted Project, Restricted Project
sgraenitz committed rG62f793ec9cac: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24 relocation (authored by Eymay).
[JITLink][AArch32] Implement ELF::R_ARM_JUMP24 relocation
Wed, Sep 13, 8:17 AM · Restricted Project, Restricted Project
sgraenitz closed D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24.
Wed, Sep 13, 8:17 AM · Restricted Project, Restricted Project
sgraenitz closed D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.
Wed, Sep 13, 8:17 AM · Restricted Project, Restricted Project
sgraenitz accepted D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24.
Wed, Sep 13, 7:33 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24.

Thanks LGTM! Let me double-check the tests on my machine and land this for you.

Wed, Sep 13, 7:33 AM · Restricted Project, Restricted Project
sgraenitz accepted D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

Thanks! Let me double-check the tests on my machine and land this for you.

Wed, Sep 13, 7:30 AM · Restricted Project, Restricted Project
sgraenitz accepted D157519: [JITLink][AArch32] Tests for ELF::R_ARM_ABS32 and ELF::R_ARM_REL32.

Thanks for the updates! Can we align the assembly in the test a little more with the (now) existing ELF_static_thumb_reloc.s? That may avoid future divergence. Otherwise, this looks good to me.

Wed, Sep 13, 6:33 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

Thanks for the updates! Please have a look at one last detail in the test.

Wed, Sep 13, 6:22 AM · Restricted Project, Restricted Project

Fri, Sep 8

sgraenitz added a comment to D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24.

I think this can land as soon as the test fits with the (now) existing ELF_static_arm_reloc.s and your previous patch is in.

Fri, Sep 8, 6:38 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

Can we align the test with the (now) existing ELF_static_arm_reloc.s please? The rest should be ready to land I think.

Fri, Sep 8, 6:35 AM · Restricted Project, Restricted Project
sgraenitz committed rG4b17c81d5a5d: [jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching… (authored by Eymay).
[jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching…
Fri, Sep 8, 12:07 AM · Restricted Project, Restricted Project
sgraenitz closed D158280: [jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching support.
Fri, Sep 8, 12:07 AM · Restricted Project, Restricted Project

Thu, Sep 7

sgraenitz accepted D158280: [jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching support.

Thanks for the fixes. This looks good to me! I assume all affected tests still pass. So, let's get this landed.

Thu, Sep 7, 6:32 AM · Restricted Project, Restricted Project

Wed, Sep 6

sgraenitz committed rG24f882287666: [JITLink][AArch32] Add initial test for R_ARM_THM_CALL and R_ARM_THM_JUMP24 (authored by sgraenitz).
[JITLink][AArch32] Add initial test for R_ARM_THM_CALL and R_ARM_THM_JUMP24
Wed, Sep 6, 8:50 AM · Restricted Project, Restricted Project
sgraenitz committed rG3e7cd5ea1e9b: [JITLink][AArch32] Fixes for initial AArch32 backend (authored by Eymay).
[JITLink][AArch32] Fixes for initial AArch32 backend
Wed, Sep 6, 4:11 AM · Restricted Project, Restricted Project
sgraenitz closed D157540: [JITLink][AArch32] Fixes for initial AArc32 backend.
Wed, Sep 6, 4:10 AM · Restricted Project, Restricted Project

Mon, Sep 4

sgraenitz added a comment to D157540: [JITLink][AArch32] Fixes for initial AArc32 backend.

So, the Thumb_Jump24 relocation is the one that supports conditional branches and Thumb_Call is the one that should have this check

Mon, Sep 4, 7:05 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D158280: [jitlink/rtdydl][checker] Add TargetFlag dependent disassembler switching support.

Sorry for being late at the party. I was too busy in the last weeks to approach non-trivial reviews. This is looking really good already. Thanks for your help @lhames!!
Here are my 2 cents. Unfortunately, I cannot make inline comments anymore.. might be due to the move from Pharicator to GitHub PRs. I will do my best to keep this readable.

Mon, Sep 4, 6:48 AM · Restricted Project, Restricted Project
sgraenitz accepted D157540: [JITLink][AArch32] Fixes for initial AArc32 backend.

Ok, I finally double-checked it and you are right. Bit 12 must be set and not clear! Can we rename the field to LoBitUnconditional and change the condition into if (!(R.Lo & FixupInfo<Thumb_Jump24>::LoBitUnconditional))?

Mon, Sep 4, 5:13 AM · Restricted Project, Restricted Project

Aug 18 2023

sgraenitz added a comment to D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime.

Backport for 17.x release: https://github.com/llvm/llvm-project/issues/64800

Aug 18 2023, 5:10 AM · Restricted Project, Restricted Project
sgraenitz committed rGaf2eb838309d: [lldb] Fix performance regression after adding GNUstep ObjC runtime (authored by sgraenitz).
[lldb] Fix performance regression after adding GNUstep ObjC runtime
Aug 18 2023, 4:59 AM · Restricted Project
sgraenitz closed D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime.
Aug 18 2023, 4:59 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime.

Thanks for your quick feedback everyone!

Aug 18 2023, 4:54 AM · Restricted Project, Restricted Project

Aug 17 2023

sgraenitz added a comment to D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime.

The issue was reported in https://github.com/llvm/llvm-project/issues/64582

Aug 17 2023, 12:27 PM · Restricted Project, Restricted Project
sgraenitz requested review of D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime.
Aug 17 2023, 12:24 PM · Restricted Project, Restricted Project
sgraenitz accepted D158073: [llvm-jitlink] Add target override option to cli.

Thanks! LGTM. Yes let's keep this on hold for now and attempt the RuntimeDyldChecker change first.

Aug 17 2023, 7:34 AM · Restricted Project, Restricted Project

Aug 13 2023

sgraenitz committed rG94239712eb17: Fix typos in comments of ExecutionEngine (NFC) (authored by Eymay).
Fix typos in comments of ExecutionEngine (NFC)
Aug 13 2023, 11:00 PM · Restricted Project, Restricted Project
sgraenitz closed D157226: Fix typos in comments of ExecutionEngine/.
Aug 13 2023, 11:00 PM · Restricted Project, Restricted Project

Aug 11 2023

sgraenitz accepted D157226: Fix typos in comments of ExecutionEngine/.

LGTM, thanks! Should I land it on your behalf?

Aug 11 2023, 6:35 AM · Restricted Project, Restricted Project

Aug 9 2023

sgraenitz added a comment to D157541: [JITLink][AArch32] Implement ELF::R_ARM_JUMP24.

Is the test actually working right now? Since we always use indirection stubs and we only have a Thumb implementation right now, my quick assumption was that the TargetSymbol should always have the ThumbSymbol flag set (and thus always bail out). Maybe I find the time in the next days to look into it myself and give some informed feedback.

Aug 9 2023, 12:44 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D157540: [JITLink][AArch32] Fixes for initial AArc32 backend.

Thanks, good catches! I will double-check the conditional bit change and let you know.

Aug 9 2023, 12:29 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D157533: [JITLink][AArch32] Implement ELF::R_ARM_CALL relocation.

Looks great, thanks! I think at some point we should add a .thumb section with .thumb_func functions to our tests, so we get coverage for the code that handles ARM-Thumb transitions. However, I guess we need ARM stubs for it first?

Aug 9 2023, 12:16 PM · Restricted Project, Restricted Project
sgraenitz added inline comments to D157519: [JITLink][AArch32] Tests for ELF::R_ARM_ABS32 and ELF::R_ARM_REL32.
Aug 9 2023, 12:02 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D157519: [JITLink][AArch32] Tests for ELF::R_ARM_ABS32 and ELF::R_ARM_REL32.

This is looking very good already! Nice idea to check ARM and Thumb in one test. I am not sure, however, if it's worth the effort. They both produce R_ARM_ABS32 and R_ARM_REL32. The only difference is the alignment and here Thumb alone would be sufficient:

➜ llvm-objdump -r ...
RELOCATION RECORDS FOR [.text]:                   RELOCATION RECORDS FOR [.text]:
OFFSET   TYPE                     VALUE           OFFSET   TYPE                     VALUE
00000004 R_ARM_ABS32              target          00000002 R_ARM_ABS32              target
00000008 R_ARM_REL32              target          00000006 R_ARM_REL32              target
       ^ ARM is on a 4-byte boundary                     ^ Thumb is 2-byte
Aug 9 2023, 11:56 AM · Restricted Project, Restricted Project

Aug 6 2023

sgraenitz added a reviewer for D157226: Fix typos in comments of ExecutionEngine/: sgraenitz.

Wow, that's a lot of typo fixes! Thanks!

Aug 6 2023, 8:34 AM · Restricted Project, Restricted Project

Jul 28 2023

sgraenitz resigned from D107087: Fix SectionMemoryManager deconstruction error with MSVC.

This review should be closed

Jul 28 2023, 7:03 AM · Restricted Project, Restricted Project
sgraenitz accepted D149995: [test] [MCJIT] Don't overwrite config.unsupported to False.

LGTM too. Is this still up-to-date?

Jul 28 2023, 7:02 AM · Restricted Project, Restricted Project

Jul 20 2023

sgraenitz accepted D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO.

Great! This LGTM. Let's keep the review open for a few days and see if there is more feedback.

Jul 20 2023, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz added a comment to D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO.

That's an excellent patch! I didn't expect it could be so compact. Thanks for working on this! Please find below 2 inline comments on details.
On July 25th release/17.x will branch away. It would be great to land this before and have it in the upcoming release.

Jul 20 2023, 3:33 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz added reviewers for D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO: lhames, nikic.
Jul 20 2023, 3:27 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2023

sgraenitz added a comment to D107087: Fix SectionMemoryManager deconstruction error with MSVC.

@sgraenitz, could we move forward with the patch as is?

Jul 6 2023, 1:09 AM · Restricted Project, Restricted Project

Jul 5 2023

sgraenitz added a comment to D107087: Fix SectionMemoryManager deconstruction error with MSVC.

@justice_adams The patch linked above fixes the issue for GCC. Does it work for you as well? Also, there is a ticket here that looks very similar: https://github.com/llvm/llvm-project/issues/63204

Jul 5 2023, 5:59 AM · Restricted Project, Restricted Project
sgraenitz committed rG9ce06411994e: [Kaleidoscope] Fix race condition in order-of-destruction between… (authored by sgraenitz).
[Kaleidoscope] Fix race condition in order-of-destruction between…
Jul 5 2023, 5:49 AM · Restricted Project, Restricted Project
sgraenitz closed D154338: Fix race condition in order-of-destruction between SectionMemoryManager and its MemoryMapper.
Jul 5 2023, 5:49 AM · Restricted Project, Restricted Project

Jul 3 2023

sgraenitz updated the summary of D154338: Fix race condition in order-of-destruction between SectionMemoryManager and its MemoryMapper.
Jul 3 2023, 6:05 AM · Restricted Project, Restricted Project
sgraenitz added reviewers for D154338: Fix race condition in order-of-destruction between SectionMemoryManager and its MemoryMapper: lhames, nikic, RKSimon.
Jul 3 2023, 6:03 AM · Restricted Project, Restricted Project
sgraenitz requested review of D154338: Fix race condition in order-of-destruction between SectionMemoryManager and its MemoryMapper.
Jul 3 2023, 6:01 AM · Restricted Project, Restricted Project

May 31 2023

sgraenitz abandoned D151801: [JITLink] Add missing vtable anchors.

Scratch that. It turned out to be some side-effect of link order. I still don't quite get it, but the anchors are not necessary. Sorry for the noise.

May 31 2023, 7:06 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D151801: [JITLink] Add missing vtable anchors.

All modified classes have out-of-line virtual methods (or at least dtors) already. Nevertheless, without these additional anchors the vtable symbols appear to be missing from libMyShared.so. Eventually, I am not certain why this is necessary. I don't see similar issues for libLLVMOrcJIT.a and they are built and linked the same way.

May 31 2023, 6:50 AM · Restricted Project, Restricted Project
sgraenitz requested review of D151801: [JITLink] Add missing vtable anchors.
May 31 2023, 6:29 AM · Restricted Project, Restricted Project

May 17 2023

sgraenitz requested changes to D107087: Fix SectionMemoryManager deconstruction error with MSVC.

This issues popped up with GCC 12 as well after https://github.com/llvm/llvm-project/commit/47f5c54f997a59bb2c65abe6b8b811f6e7553456

May 17 2023, 5:35 AM · Restricted Project, Restricted Project
sgraenitz added a reviewer for D107087: Fix SectionMemoryManager deconstruction error with MSVC: sgraenitz.
May 17 2023, 5:14 AM · Restricted Project, Restricted Project
sgraenitz committed rG0b6264738f3d: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on… (authored by sgraenitz).
[lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on…
May 17 2023, 4:57 AM · Restricted Project
sgraenitz closed D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.
May 17 2023, 4:56 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

Rebase

May 17 2023, 1:48 AM · Restricted Project, Restricted Project
sgraenitz committed rG4241ac542d69: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime (authored by sgraenitz).
[lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime
May 17 2023, 1:40 AM · Restricted Project
sgraenitz closed D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.
May 17 2023, 1:39 AM · Restricted Project, Restricted Project

May 16 2023

sgraenitz updated the diff for D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

Rebase and re-run pre-merge checks

May 16 2023, 6:26 AM · Restricted Project, Restricted Project

May 15 2023

sgraenitz added a reviewer for D146547: [lldb][gnustep][PDB] Add special handling for ObjC built-in types eBasicTypeObjCID and eBasicTypeObjCSel: Restricted Project.
May 15 2023, 5:19 AM · Restricted Project, Restricted Project

May 14 2023

sgraenitz added a comment to D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

This patch adds test coverage for existing functionality. It was ready to land 6 weeks ago. There was plenty of opportunity to raise concerns and discuss details over the last 2 months of review. I assume the topic is just too niche to attract a lot of attention.

May 14 2023, 8:25 AM · Restricted Project, Restricted Project
sgraenitz added a reviewer for D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime: Restricted Project.
May 14 2023, 8:02 AM · Restricted Project, Restricted Project

May 8 2023

sgraenitz added a comment to D141215: [clang-repl] Introduce Value to capture expression results.

using regular global variable instances to manage the storage on the executor side, an extended MemoryAccess interface to read/write the value from the REPL side when needed (e.g. for printing), and emitting glue functions to pass the variable's value in to callers.

May 8 2023, 1:57 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D149996: [test] [ExecutionEngine] Skip the ExecutionEngine tests on mingw targets.

One more guess: Could this function possibly reside in a runtime library for MinGW? lli has --orc-runtime but it's not in use implicitly. As far as I know, we only support MSVC. Would MinGW support be interesting? Do we have anything in place? Maybe @sunho knows more about it. Thanks!

May 8 2023, 1:26 AM · Restricted Project, Restricted Project
sgraenitz added a reviewer for D149996: [test] [ExecutionEngine] Skip the ExecutionEngine tests on mingw targets: sunho.
May 8 2023, 1:20 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D149996: [test] [ExecutionEngine] Skip the ExecutionEngine tests on mingw targets.

Conversely, an MSVC-built lli.exe runs the test just fine even

May 8 2023, 1:20 AM · Restricted Project, Restricted Project

Apr 29 2023

sgraenitz updated the diff for D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

Rebase and double-check default config: GNUstep disabled, objc-gnustep-print test unsupported

Apr 29 2023, 8:58 AM · Restricted Project, Restricted Project
sgraenitz committed rG64a2520bacb5: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations (authored by sgraenitz).
[lldb][ObjectFileELF] Support AArch32 in ApplyRelocations
Apr 29 2023, 8:35 AM · Restricted Project
sgraenitz closed D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.
Apr 29 2023, 8:35 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Address feedback and rebase

Apr 29 2023, 8:31 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

That's not entirely what I was referring to. What I fear is the following situation. A random developer makes a random patch that happens to break gnustep support. That developer cannot debug that issue locally (cannot or doesn't know how to build gnustep from source), so someone has to help him figure out the problem. I don't want to be the person doing that. :)

Apr 29 2023, 8:27 AM · Restricted Project, Restricted Project

Apr 28 2023

sgraenitz added a comment to D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Ping

Apr 28 2023, 1:32 AM · Restricted Project, Restricted Project

Apr 25 2023

sgraenitz accepted D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker.

Thanks. LGTM

Apr 25 2023, 3:48 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker.
Apr 25 2023, 1:59 AM · Restricted Project, Restricted Project

Apr 18 2023

sgraenitz added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

We should probably also address the lack of linker issue as well. Should we go for a precompiled dynamic library file? There seems to be some "precedent" of this in other tests.

Apr 18 2023, 6:41 AM · Restricted Project, Restricted Project

Apr 17 2023

sgraenitz accepted D148481: [clang-repl] Enable debugging of JIT-ed code..

LGTM

Apr 17 2023, 10:30 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D141824: [clang-repl] Add a command to load dynamic libraries.
Apr 17 2023, 9:24 AM · Restricted Project, Restricted Project

Apr 15 2023

sgraenitz accepted D148434: [clang-repl] JITTargetAddress --> ExecutorAddr.

Thanks. Maybe you can fix this one detail and add a description like "Most of Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr instead"? Otherwise LGTM.

Apr 15 2023, 2:51 PM · Restricted Project, Restricted Project

Apr 14 2023

sgraenitz accepted D147669: PECOFF: consume errors properly.

Great. Thanks!

Apr 14 2023, 10:13 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Double-checked and found source locations on Raspberry Pi 3b with this patch applied https://github.com/llvm/llvm-project/issues/61948#issuecomment-1508305542
Is there more feedback on this? It would be nice to land it soon, i.e. before EuroLLVM =)

Apr 14 2023, 3:52 AM · Restricted Project, Restricted Project

Apr 13 2023

sgraenitz added a comment to D141215: [clang-repl] Introduce Value to capture expression results.

This looks a lot better already than the implementation I know from Cling. Well done!

Apr 13 2023, 2:34 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D147669: PECOFF: consume errors properly.

I think it's a very good practice that objects in moved-from state will only ever get destroyed. While the move ctor itself has no preconditions and thus might be fine to call again, the implementation of consumeError() does inspect the object. This adds an unnecessary risk for UB. Please simply check the log state and call either fmt_consume() or consumeError(). Thanks.

Apr 13 2023, 1:07 PM · Restricted Project, Restricted Project
sgraenitz accepted D148192: [JITLink][ELF][PPC64] Add skeleton ppc64 support and ELF/ppc64 JITLink backend..

Thanks! LGTM

Apr 13 2023, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
sgraenitz committed rGcc6ab268d89b: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations (authored by sgraenitz).
[lldb][ObjectFileELF] Improve error output for unsupported arch/relocations
Apr 13 2023, 5:33 AM · Restricted Project
sgraenitz closed D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations.
Apr 13 2023, 5:33 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations.

Thanks for your feedback

Apr 13 2023, 5:30 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations.

Include R_386_NONE for error reporting

Apr 13 2023, 5:29 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Addressed feedback and added handling for R_ARM_REL32. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being.

Apr 13 2023, 5:17 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Add error reporting for R_ARM_REL32 relocations

Apr 13 2023, 5:12 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations.

Rename new function to ApplyELF32ABS32RelRelocation()

Apr 13 2023, 5:10 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D148192: [JITLink][ELF][PPC64] Add skeleton ppc64 support and ELF/ppc64 JITLink backend..

The plan sounds very reasonable. PowerPC support is one of the last missing pieces for feature parity with RuntimeDyld. Speaking for the JITLink code, this looks excellent of course.

Apr 13 2023, 4:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2023

sgraenitz added a comment to D141824: [clang-repl] Add a command to load dynamic libraries.

This seems to be the first clang test that involves actual linking.

Apr 6 2023, 3:38 PM · Restricted Project, Restricted Project
sgraenitz requested changes to D147669: PECOFF: consume errors properly.

First of all, yes the existing code is incorrect. Thanks for looking into this. However, I am afraid this isn't the right solution.

Apr 6 2023, 3:30 PM · Restricted Project, Restricted Project
sgraenitz updated subscribers of D147669: PECOFF: consume errors properly.
Apr 6 2023, 3:29 PM · Restricted Project, Restricted Project