Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (153 w, 2 d)

We may think in generalities, but weliveindetail

Recent Activity

Thu, Jun 10

sgraenitz added a comment to D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

However, while investigating I found the threading issue that this patch aims to fix. @lhames Might the unjoined thread have caused the assertion failure in SymbolStringPool?

Thu, Jun 10, 3:19 AM · Restricted Project
sgraenitz added a comment to D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

After commit 2f9ba6aa8b6d the test failure https://lab.llvm.org/buildbot/#/builders/61/builds/10796 occurred on one of the few build bots that include the examples. The patch doesn't affect any code exercised in this test and the bot turned green with the subsequent build. Thus, the test might be considered flaky. So far I failed to reproduce the exact error:

Thu, Jun 10, 2:54 AM · Restricted Project
sgraenitz requested review of D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.
Thu, Jun 10, 2:42 AM · Restricted Project

Fri, May 21

sgraenitz added a comment to D101835: [llvm] llvm-tapi-diff.

Hey, just a few notes on proper error handling.

Fri, May 21, 3:00 AM · Restricted Project

May 10 2021

sgraenitz updated subscribers of D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

We're already building runtime libraries, but in the tests it looks like we're building a parallel archive for the runtime and writing it to the test directory for the tests to link against. Is there a reason the tests can't just link against the built runtimes?

May 10 2021, 1:59 AM · Restricted Project

Apr 7 2021

sgraenitz committed rG792ee5be3692: [Orc][examples] Add missing FileCheck for lit test and polish output (authored by sgraenitz).
[Orc][examples] Add missing FileCheck for lit test and polish output
Apr 7 2021, 2:14 AM
sgraenitz committed rG030ac786d4ff: [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example (authored by sgraenitz).
[Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example
Apr 7 2021, 12:48 AM
sgraenitz closed D99931: [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example.
Apr 7 2021, 12:47 AM · Restricted Project

Apr 6 2021

sgraenitz requested review of D99931: [Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example.
Apr 6 2021, 1:54 AM · Restricted Project

Mar 31 2021

sgraenitz accepted D99604: [llvm-jitlink] Fix -Wunused-function on Windows.

LGTM. Thanks for fixing this!

Mar 31 2021, 1:54 AM · Restricted Project

Mar 30 2021

sgraenitz committed rG243fe0da9980: [lli] Leaving two EH frame tests with MCJIT only after PowerPC failure (authored by sgraenitz).
[lli] Leaving two EH frame tests with MCJIT only after PowerPC failure
Mar 30 2021, 3:29 AM
sgraenitz committed rGc42c67ad6044: Re-apply "[lli] Make -jit-kind=orc the default JIT engine" (authored by sgraenitz).
Re-apply "[lli] Make -jit-kind=orc the default JIT engine"
Mar 30 2021, 3:09 AM
sgraenitz closed D98931: [lli] Make -jit-kind=orc the default JIT engine.
Mar 30 2021, 3:08 AM · Restricted Project
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

Rebase patch

Mar 30 2021, 3:06 AM · Restricted Project
sgraenitz committed rGc352a2b8290b: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly (authored by sgraenitz).
[lli] Add option -lljit-platform=Inactive to disable platform support explicitly
Mar 30 2021, 12:30 AM
sgraenitz closed D99416: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly.
Mar 30 2021, 12:30 AM · Restricted Project

Mar 29 2021

sgraenitz committed rG66a8247eb6c0: [Orc][tests] Moving one MCJIT test over to Orc to make sure the PowerPC fix… (authored by sgraenitz).
[Orc][tests] Moving one MCJIT test over to Orc to make sure the PowerPC fix…
Mar 29 2021, 2:53 AM

Mar 28 2021

sgraenitz committed rG7b9df09e2050: [Orc][examples] Add missing dependency to OrcShared in LLJITWithRemoteDebugging (authored by sgraenitz).
[Orc][examples] Add missing dependency to OrcShared in LLJITWithRemoteDebugging
Mar 28 2021, 8:49 AM
sgraenitz committed rG258f055ed936: [Orc][examples] Add LLJITWithRemoteDebugging example (authored by sgraenitz).
[Orc][examples] Add LLJITWithRemoteDebugging example
Mar 28 2021, 8:26 AM

Mar 26 2021

sgraenitz committed rG571d5f92130b: [Orc][examples] Factor out make_error from parseExampleModule (NFC) (authored by sgraenitz).
[Orc][examples] Factor out make_error from parseExampleModule (NFC)
Mar 26 2021, 10:50 AM
sgraenitz committed rG719755313365: [Orc][examples] Fix copy/paste issues in comments and inclue guards (NFC) (authored by sgraenitz).
[Orc][examples] Fix copy/paste issues in comments and inclue guards (NFC)
Mar 26 2021, 10:50 AM
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

Don't apply lazy-MCJIT tests to the default (greedy) mode for Orc. They probably work well with OrcLazy, but that's a different story.

Mar 26 2021, 7:27 AM · Restricted Project
sgraenitz reopened D98931: [lli] Make -jit-kind=orc the default JIT engine.
Mar 26 2021, 7:26 AM · Restricted Project
sgraenitz updated the diff for D99416: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly.

Apply MCJIT small code-model tests to ORC in preparation for default JIT engine switch

Mar 26 2021, 7:21 AM · Restricted Project
sgraenitz added a comment to D99416: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly.

This can be used to fix test failures on Windows when re-applying D98931

Mar 26 2021, 6:56 AM · Restricted Project
sgraenitz requested review of D99416: [lli] Add option -lljit-platform=Inactive to disable platform support explicitly.
Mar 26 2021, 6:39 AM · Restricted Project

Mar 23 2021

sgraenitz committed rGd9069dd9b576: [lli] Workaround missing architecture support in LazyCallThroughManager for non… (authored by sgraenitz).
[lli] Workaround missing architecture support in LazyCallThroughManager for non…
Mar 23 2021, 8:37 AM
sgraenitz added a comment to D98931: [lli] Make -jit-kind=orc the default JIT engine.

I think 5949bd91253672ea8599a7a234b18e78972d3aa1 will fix the PowerPC bots

Mar 23 2021, 7:26 AM · Restricted Project
sgraenitz committed rG0ef51db5a45d: Revert "[Orc] Allow OrcGenericABI variant of LazyCallThroughManager" (authored by sgraenitz).
Revert "[Orc] Allow OrcGenericABI variant of LazyCallThroughManager"
Mar 23 2021, 7:24 AM
sgraenitz added a comment to D98931: [lli] Make -jit-kind=orc the default JIT engine.

Can we get it reverted and we can try to do what we can to help investigate the failures on PowerPC machines?

Mar 23 2021, 6:39 AM · Restricted Project
sgraenitz committed rG5949bd912536: [Orc] Allow OrcGenericABI variant of LazyCallThroughManager (authored by sgraenitz).
[Orc] Allow OrcGenericABI variant of LazyCallThroughManager
Mar 23 2021, 6:09 AM
sgraenitz added a reverting change for rGeaee4f269645: [lli] Make -jit-kind=orc the default JIT engine: rG581adb4f1a6e: Temporarily revert "[lli] Make -jit-kind=orc the default JIT engine".
Mar 23 2021, 4:02 AM
sgraenitz committed rG581adb4f1a6e: Temporarily revert "[lli] Make -jit-kind=orc the default JIT engine" (authored by sgraenitz).
Temporarily revert "[lli] Make -jit-kind=orc the default JIT engine"
Mar 23 2021, 4:02 AM
sgraenitz added a reverting change for D98931: [lli] Make -jit-kind=orc the default JIT engine: rG581adb4f1a6e: Temporarily revert "[lli] Make -jit-kind=orc the default JIT engine".
Mar 23 2021, 4:02 AM · Restricted Project
sgraenitz added a comment to D98931: [lli] Make -jit-kind=orc the default JIT engine.

Fix error No callback manager available on powerpc64le-unknown-linux-gnu with eccd7ae2fdb3

Mar 23 2021, 2:49 AM · Restricted Project
sgraenitz committed rGeccd7ae2fdb3: [lli] Fix ppc64le-clang-lnt-test bot: Keep test-call.ll a MCJIT-only test (authored by sgraenitz).
[lli] Fix ppc64le-clang-lnt-test bot: Keep test-call.ll a MCJIT-only test
Mar 23 2021, 2:48 AM
sgraenitz committed rGeaee4f269645: [lli] Make -jit-kind=orc the default JIT engine (authored by sgraenitz).
[lli] Make -jit-kind=orc the default JIT engine
Mar 23 2021, 2:23 AM
sgraenitz closed D98931: [lli] Make -jit-kind=orc the default JIT engine.
Mar 23 2021, 2:23 AM · Restricted Project

Mar 22 2021

sgraenitz committed rG50e499a56d66: [Orc] Fix copy elision warning in RPCUtils (authored by sgraenitz).
[Orc] Fix copy elision warning in RPCUtils
Mar 22 2021, 9:48 AM
sgraenitz committed rGc154cddabd71: [Orc] Fix tracking of pending debug objects in DebugObjectManagerPlugin (authored by sgraenitz).
[Orc] Fix tracking of pending debug objects in DebugObjectManagerPlugin
Mar 22 2021, 9:48 AM
sgraenitz committed rGcbcc1c9f8708: [Orc] Make usage of ResourceKeys thread-safe in DebugObjectManagerPlugin (authored by sgraenitz).
[Orc] Make usage of ResourceKeys thread-safe in DebugObjectManagerPlugin
Mar 22 2021, 9:48 AM
sgraenitz closed D98947: [Orc] Fix copy elision warning in RPCUtils.
Mar 22 2021, 9:48 AM · Restricted Project
sgraenitz closed D98863: [Orc] Make usage of ResourceKeys thread-safe in DebugObjectManagerPlugin.
Mar 22 2021, 9:48 AM · Restricted Project
sgraenitz closed D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin.
Mar 22 2021, 9:48 AM · Restricted Project
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

For now keep eh-lg-pic.ll a MCJIT-only test

Mar 22 2021, 8:24 AM · Restricted Project
sgraenitz committed rG9cdbdbea29ce: [llvm-jitlink] Fix Windows build after 4a8161fe40cc (authored by sgraenitz).
[llvm-jitlink] Fix Windows build after 4a8161fe40cc
Mar 22 2021, 3:42 AM
sgraenitz added a comment to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Alright fixed with 9cdbdbea29ce

Mar 22 2021, 3:42 AM · Restricted Project
sgraenitz added a comment to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

@thakis Thanks for the note. I guess it's D98579. Fix will be quick.

Mar 22 2021, 3:35 AM · Restricted Project
sgraenitz committed rGf21cc55fb8a2: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well (authored by sgraenitz).
[llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well
Mar 22 2021, 3:22 AM
sgraenitz committed rG4a8161fe40cc: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via… (authored by sgraenitz).
[llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via…
Mar 22 2021, 3:22 AM
sgraenitz closed D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.
Mar 22 2021, 3:21 AM · Restricted Project
sgraenitz closed D98579: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via TCP socket.
Mar 22 2021, 3:21 AM · Restricted Project

Mar 19 2021

sgraenitz added a comment to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Thanks for the confirmation. I will land this as soon as D98579 is done.

Mar 19 2021, 10:16 AM · Restricted Project
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

Patch 5 other tests that slipped through

Mar 19 2021, 10:12 AM · Restricted Project
sgraenitz updated the diff for D98947: [Orc] Fix copy elision warning in RPCUtils.

Make returnError() static (oops). Rename RTraits -> AltRetTraits. Turn some autos into concrete typenames to aid readability.

Mar 19 2021, 8:01 AM · Restricted Project
sgraenitz added a comment to D98947: [Orc] Fix copy elision warning in RPCUtils.

I actually didn't manage to reproduce the warning with GCC 10 on Debian, so I couldn't really test this. @thakis Do you want to run a pre-test? Otherwise, we could land it right away and see if it is effective.

Mar 19 2021, 7:16 AM · Restricted Project
sgraenitz requested review of D98947: [Orc] Fix copy elision warning in RPCUtils.
Mar 19 2021, 7:05 AM · Restricted Project
sgraenitz added inline comments to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.
Mar 19 2021, 4:20 AM · Restricted Project
sgraenitz updated the diff for D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Add special-case for calling accept(2) on AIX. I cannot test it here, @rzurob does this work for you?

Mar 19 2021, 4:19 AM · Restricted Project
sgraenitz updated subscribers of D98931: [lli] Make -jit-kind=orc the default JIT engine.
Mar 19 2021, 3:07 AM · Restricted Project
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

Patch tests for MCJIT-specific behavior

Mar 19 2021, 2:25 AM · Restricted Project
sgraenitz updated the diff for D98931: [lli] Make -jit-kind=orc the default JIT engine.

Run tests for common JIT tasks against both, MCJIT and Orc

Mar 19 2021, 2:23 AM · Restricted Project
sgraenitz requested review of D98931: [lli] Make -jit-kind=orc the default JIT engine.
Mar 19 2021, 2:20 AM · Restricted Project

Mar 18 2021

sgraenitz committed rGe1579894d205: [lli] Add Orc greedy mode as -jit-kind=orc (authored by sgraenitz).
[lli] Add Orc greedy mode as -jit-kind=orc
Mar 18 2021, 3:19 PM
sgraenitz added a comment to D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin.

Thanks for elaborating.

Mar 18 2021, 6:33 AM · Restricted Project
sgraenitz requested review of D98863: [Orc] Make usage of ResourceKeys thread-safe in DebugObjectManagerPlugin.
Mar 18 2021, 6:27 AM · Restricted Project
sgraenitz updated the diff for D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin.

Pending resources are irrelevant in both, notifyTransferringResources() and notifyRemovingResources(). They are guaranteed to be either finalizd in notifyEmitted() or discarded in notifyFailed().

Mar 18 2021, 6:07 AM · Restricted Project

Mar 17 2021

sgraenitz added a comment to D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin.

This is hard to reproduce with lli, because single-threaded execution with LLLazyJIT will implicitly sequence materialization. LLJIT instead materializes module dependencies recursively, which makes this issue easy to reproduce. Unfortunately, we have no LLJIT tool that I could use for a test. It's not the first time this limitation comes up for me and I wonder if it's worth adding an orc-greedy kind to lli. What do you think?

Mar 17 2021, 9:24 AM · Restricted Project
sgraenitz requested review of D98785: [Orc] Fix pending debug object tracking in DebugObjectManagerPlugin.
Mar 17 2021, 8:49 AM · Restricted Project

Mar 13 2021

sgraenitz updated the diff for D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Print 'Connection established' only when connecting via a TCP socket

Mar 13 2021, 9:45 AM · Restricted Project
sgraenitz committed rGb26c953f55d6: [Orc] Deallocate debug objects properly when removing resources from… (authored by sgraenitz).
[Orc] Deallocate debug objects properly when removing resources from…
Mar 13 2021, 7:36 AM
sgraenitz added a comment to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Some sample output for llvm-jitlink with various broken addresses:
Failed to connect TCP socket 'localhost:1': Connection refused (inactive)
Failed to connect TCP socket '8.8.8.8:1': Operation timed out (non-responding)
Failed to connect TCP socket '127.0.0.1:0': Can't assign requested address
Failed to connect TCP socket '127.0.0.1:-1': Address resolution failed (nodename nor servname provided, or not known)
Failed to connect TCP socket '127.0.0.1': Port for -oop-executor-connect can not be empty

Mar 13 2021, 7:16 AM · Restricted Project
sgraenitz added a comment to D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.

Follow-up patch that submits learnings from fixing D98579. The error it fixed would now print as:
Failed to connect TCP socket 'localhost:13921': Address resolution failed (Bad hints)

Mar 13 2021, 7:15 AM · Restricted Project
sgraenitz requested review of D98581: [llvm-jitlink] Add diagnostic output and port executor to getaddrinfo(3) as well.
Mar 13 2021, 7:12 AM · Restricted Project
sgraenitz added a comment to D98579: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via TCP socket.

Unfortunately, we seem to have no test coverage for this code. My last take was that LIT doesn't exactly make it easy to run client and server concurrently. Is that still the case or could we do it somehow differently?
I had to take a detailed look into this code now anyway, so I could just as well add a test case.

Mar 13 2021, 5:47 AM · Restricted Project
sgraenitz added a comment to D98579: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via TCP socket.

The patch proposed here is a minimal fix. I am eager to streamline the code and add better error messages in a follow-up commit.

Mar 13 2021, 5:47 AM · Restricted Project
sgraenitz requested review of D98579: [llvm-jitlink] Fix use of getaddrinfo(3) when connecting remote executor via TCP socket.
Mar 13 2021, 5:35 AM · Restricted Project

Mar 12 2021

sgraenitz accepted D96033: [clang-repl] Land initial infrastructure for incremental parsing.

Thanks. From my side this looks good now.

Mar 12 2021, 4:03 PM · Restricted Project
sgraenitz accepted D98305: [JITLink] Introduce generic x86-64 support by refactoring MachO/x86-64..

Thanks for elaborating. LGTM

Mar 12 2021, 3:59 PM · Restricted Project
sgraenitz committed rGff52121bba0c: [Orc] Fix race condition in DebugObjectManagerPlugin (authored by sgraenitz).
[Orc] Fix race condition in DebugObjectManagerPlugin
Mar 12 2021, 5:04 AM
sgraenitz closed D98417: [Orc] Fix race condition in DebugObjectManagerPlugin.
Mar 12 2021, 5:04 AM · Restricted Project
sgraenitz added a comment to D98417: [Orc] Fix race condition in DebugObjectManagerPlugin.

I think you're right, but rather than approach this through the plugin API I think the solution will come from rethinking "finalization" on the memory manager API

Mar 12 2021, 5:04 AM · Restricted Project
sgraenitz added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

I think this makes good progress. I found two details in the test code that need attention. The stdout issue might be done now or in a follow-up patch some time soon. Otherwise, this seems to get ready to land.

Mar 12 2021, 4:48 AM · Restricted Project

Mar 11 2021

sgraenitz added a comment to D98305: [JITLink] Introduce generic x86-64 support by refactoring MachO/x86-64..

Factoring out architecture specific code sounds like a reasonable approach to reduce code duplication across the JITLink backends. As far as I can see, the patch only ports the MachOJITLinker_x86_64 to use the generic functionality. The ELFJITLinker_x86_64 mostly remains unchanged. Is there a conceptual reason for it or would that be a rather straightforward next step?

Mar 11 2021, 9:06 AM · Restricted Project
sgraenitz committed rGee5e7a3a8561: [Orc] Deallocate debug objects explicitly when destroying the… (authored by sgraenitz).
[Orc] Deallocate debug objects explicitly when destroying the…
Mar 11 2021, 6:27 AM
sgraenitz added a comment to D98417: [Orc] Fix race condition in DebugObjectManagerPlugin.

This means that materialization is blocked until finalization of the debug object allocation is done, i.e.:

  • memory was copied over to the target
  • an entry was added to the JIT descriptor (locks a global mutex)
  • the executing process ran into the rendezvous breakpoint (1st process switch)
  • the debugger processed the debug object, read the symbol table and returned control back to the executor (2nd process switch)
Mar 11 2021, 6:07 AM · Restricted Project
sgraenitz requested review of D98417: [Orc] Fix race condition in DebugObjectManagerPlugin.
Mar 11 2021, 5:41 AM · Restricted Project

Mar 9 2021

sgraenitz added a comment to D97335: [Orc] Add JITLink debug support plugin for ELF x86-64.

Right. Probably the action was choosed previously in the drop-down list and I missed it. Sorry.

Mar 9 2021, 1:34 PM · Restricted Project
sgraenitz added a comment to D97335: [Orc] Add JITLink debug support plugin for ELF x86-64.

@ASDenysPetrov I guess you set the Needs Revision status accidentally?

Mar 9 2021, 10:43 AM · Restricted Project
sgraenitz accepted D97335: [Orc] Add JITLink debug support plugin for ELF x86-64.

Attempting to close the review after it was re-opened.

Mar 9 2021, 10:34 AM · Restricted Project
sgraenitz committed rG2ff533cba18a: [lldb][JITLoaderGDB] Test debug support in JITLink (authored by sgraenitz).
[lldb][JITLoaderGDB] Test debug support in JITLink
Mar 9 2021, 5:11 AM
sgraenitz closed D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink.
Mar 9 2021, 5:11 AM · Restricted Project
sgraenitz updated the diff for D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink.

For the entry point, prefer lli over llvm-jitlink. D97339 added debug support for JITLink in lli.

Mar 9 2021, 5:09 AM · Restricted Project
sgraenitz committed rG265bc5af7b3b: [Orc] Always check mapped sections for ELFDebugObject are in bounds of working… (authored by sgraenitz).
[Orc] Always check mapped sections for ELFDebugObject are in bounds of working…
Mar 9 2021, 5:03 AM
sgraenitz committed rG6a3a386c6fc4: [Orc] Test DebugObjectManagerPlugin fills in load-address for .text section of… (authored by sgraenitz).
[Orc] Test DebugObjectManagerPlugin fills in load-address for .text section of…
Mar 9 2021, 5:03 AM
sgraenitz committed rG7d18cd9394c3: [Orc] Fix working memory buffer for section mapping in ELFDebugObject (authored by sgraenitz).
[Orc] Fix working memory buffer for section mapping in ELFDebugObject
Mar 9 2021, 5:03 AM

Mar 8 2021

sgraenitz added a comment to D97335: [Orc] Add JITLink debug support plugin for ELF x86-64.

My build fails after hack to this patch https://reviews.llvm.org/rG900f076113302e26e1939541b546b0075e3e9721. Could you revise your solution?

Mar 8 2021, 6:58 AM · Restricted Project

Mar 3 2021

sgraenitz added a comment to D97339: [lli] Add --jit-linker command line argument.

@klausler Thanks for reporting this. lli was missing JITLink as a link component in CMake. I fixed it with https://reviews.llvm.org/rG295ea050ad594b8868b6dd944824ba9a16273f91. Sorry for the inconvenience.

Mar 3 2021, 2:17 PM · Restricted Project
sgraenitz committed rG295ea050ad59: [lli] Add JITLink link component after 99a6d003edbe (authored by sgraenitz).
[lli] Add JITLink link component after 99a6d003edbe
Mar 3 2021, 2:16 PM
sgraenitz added a comment to rGe984c2b06f0c: Revert "hack to unbreak check-llvm on win after D97335" in attempt for actual….

This fixes the symbol lookup issue on Windows that was discussed post-review in D97339. Sorry for the inconvenience.

Mar 3 2021, 2:08 PM