Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (66 w, 1 d)

We may think in generalities, but weliveindetail

Recent Activity

Tue, Sep 24

sgraenitz resigned from D57402: build: remove custom variables.
Tue, Sep 24, 6:04 AM · Restricted Project
sgraenitz resigned from D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib.
Tue, Sep 24, 6:04 AM · Restricted Project
sgraenitz resigned from D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist..
Tue, Sep 24, 6:04 AM · Restricted Project
sgraenitz resigned from D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK.
Tue, Sep 24, 6:04 AM · Restricted Project
sgraenitz resigned from D32597: Initiate loading of shared libraries in parallel.
Tue, Sep 24, 6:04 AM · Restricted Project
sgraenitz resigned from D29144: LLDB: fix for TestCallThatThrows.py test fail.
Tue, Sep 24, 6:03 AM
sgraenitz added a comment to D65934: [ORC] FIxed warning on Windows about deprecated ORCv1.

Right, this was a missing deprecation change. Thanks for posting! Lang fixed it the same day, so I guess we can abandon this review.

Tue, Sep 24, 5:58 AM · Restricted Project
sgraenitz added a comment to rG9e52d0576ab7: [ORC] Suppress an ORCv1 deprecation warning..

This change was proposed in review D65934

Tue, Sep 24, 5:54 AM

Wed, Sep 18

sgraenitz accepted D67175: [llvm] [cmake] Add possibility to use ChooseMSVCCRT.cmake when include LLVM library.

Did this land?

Wed, Sep 18, 4:08 AM · Restricted Project
sgraenitz committed rG2c72b4175756: [lldb][CMake] Build LLDB.framework with -Wdocumentation in Xcode (authored by sgraenitz).
[lldb][CMake] Build LLDB.framework with -Wdocumentation in Xcode
Wed, Sep 18, 3:41 AM
sgraenitz committed rGa206de8a0e6a: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly (authored by sgraenitz).
[lldb][CMake] Infer `Clang_DIR` if not passed explicitly
Wed, Sep 18, 3:20 AM

Aug 8 2019

sgraenitz updated the diff for D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.

Achieve the same via extra HINT to find_package(Clang ...)

Aug 8 2019, 6:45 AM · Restricted Project, Restricted Project
sgraenitz committed rGc822ab8f9acc: [lldb][CMake] Disable modules in Xcode projects (authored by sgraenitz).
[lldb][CMake] Disable modules in Xcode projects
Aug 8 2019, 6:40 AM
sgraenitz abandoned D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option.

So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work even in standalone builds...

Aug 8 2019, 6:34 AM · Restricted Project
sgraenitz added inline comments to D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option.
Aug 8 2019, 4:19 AM · Restricted Project
sgraenitz created D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option.
Aug 8 2019, 4:17 AM · Restricted Project

Aug 7 2019

sgraenitz created D65874: [lldb][CMake] Disable modules in Xcode projects.
Aug 7 2019, 7:46 AM · Restricted Project, Restricted Project
sgraenitz accepted D65862: Remove xcode-specific Config.h.

Right

Aug 7 2019, 5:24 AM · Restricted Project
sgraenitz added a comment to D65862: Remove xcode-specific Config.h.

Originally introduced with D31969. LGTM. Maybe we can remove even more?

Aug 7 2019, 5:13 AM · Restricted Project
sgraenitz added a comment to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.

Making it so that the clang is automatically found it if happens to be next to llvm seems like a reasonable thing to me. I have no idea what would be the canonical cmake way to do that...

Aug 7 2019, 4:46 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.

Update documentation to mention multiple provided build trees and the usage of Clang_DIR

Aug 7 2019, 4:23 AM · Restricted Project, Restricted Project
sgraenitz committed rGf24100179306: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode… (authored by sgraenitz).
[lldb][CMake] Workaround debugserver code-signing issue in generated Xcode…
Aug 7 2019, 4:04 AM
sgraenitz committed rGbefde45a6f60: [lldb][CMake] Fix one more detail in r368066 (authored by sgraenitz).
[lldb][CMake] Fix one more detail in r368066
Aug 7 2019, 3:48 AM
sgraenitz added a comment to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.

What do you think?

Aug 7 2019, 3:33 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Aug 7 2019, 3:33 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Aug 7 2019, 3:33 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.

Change comment and condition to only infer Clang_DIR if it exists.

Aug 7 2019, 3:29 AM · Restricted Project, Restricted Project
sgraenitz committed rGefd0e11b26de: [lldb][NFC] Fix typo in 368066 (authored by sgraenitz).
[lldb][NFC] Fix typo in 368066
Aug 7 2019, 3:04 AM

Aug 6 2019

sgraenitz added inline comments to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Aug 6 2019, 2:08 PM · Restricted Project, Restricted Project
sgraenitz committed rG7f34a3652e9c: [lldb][CMake] Generating Xcode projects (authored by sgraenitz).
[lldb][CMake] Generating Xcode projects
Aug 6 2019, 10:22 AM
sgraenitz added a comment to D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.

Solutions are clearly favorable over workarounds like this, but I couldn't find one. Xcode has a mechanism called sign on copy which seems to be the native way to avoid this problem, but I couldn't get it to work with LLDB, because I want to copy the build output of a target and this caused a cyclic dependency. I didn't find more information about it and there seems to be no way to generate this behavior with CMake. The only way around seems to be a custom script, but that is no better than the workaround here.

Aug 6 2019, 10:14 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D65797: [lldb][CMake] Generating Xcode projects.
Aug 6 2019, 9:19 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65797: [lldb][CMake] Generating Xcode projects.

Improve warning message

Aug 6 2019, 9:19 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Aug 6 2019, 8:42 AM · Restricted Project, Restricted Project
sgraenitz created D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Aug 6 2019, 3:34 AM · Restricted Project, Restricted Project
sgraenitz created D65797: [lldb][CMake] Generating Xcode projects.
Aug 6 2019, 3:25 AM · Restricted Project, Restricted Project

Aug 2 2019

sgraenitz abandoned D65436: [docs] Add note about git version to git-llvm section.
Aug 2 2019, 9:57 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.

Is there a way to use the debugserver in the framework instead?

Aug 2 2019, 5:02 AM · Restricted Project, Restricted Project

Aug 1 2019

sgraenitz committed rG3fe35299552b: [lldb][docs] Update landing page for monorepo (authored by sgraenitz).
[lldb][docs] Update landing page for monorepo
Aug 1 2019, 3:35 AM
sgraenitz committed rGed38be87fcea: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects (authored by sgraenitz).
[lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects
Aug 1 2019, 3:35 AM
sgraenitz added a comment to D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.

Checked with:

> xcodebuild -configuration Release -target debugserver
> codesign -dv Release/bin/LLDB.framework/Versions/A/Resources/debugserver
> codesign -dv Release/bin/debugserver
Aug 1 2019, 2:38 AM · Restricted Project, Restricted Project
sgraenitz updated subscribers of D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.
Aug 1 2019, 2:36 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.
Aug 1 2019, 2:34 AM · Restricted Project, Restricted Project
sgraenitz created D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project.
Aug 1 2019, 2:34 AM · Restricted Project, Restricted Project

Jul 31 2019

sgraenitz added a comment to D65438: [docs] Add cmake to Software requirements.

This broke the sphinx bot

Jul 31 2019, 1:28 PM · Restricted Project
sgraenitz created D65509: [lldb][CMake] Avoid 'Autogenerate scheme' dialogs in Xcode projects.
Jul 31 2019, 5:54 AM · Restricted Project, Restricted Project
sgraenitz committed rGa60966daa2ba: [lldb][docs] Add CMake version notes for -B flag (authored by sgraenitz).
[lldb][docs] Add CMake version notes for -B flag
Jul 31 2019, 3:33 AM

Jul 30 2019

sgraenitz abandoned D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake.

This was fixed quite some time ago.

Jul 30 2019, 8:00 AM
sgraenitz accepted D65438: [docs] Add cmake to Software requirements.

Yes, agree! Hopefully we will move on to a newer version (3.9?) some time soon, but that needs a broader discussion first.

Jul 30 2019, 7:44 AM · Restricted Project
sgraenitz retitled D65436: [docs] Add note about git version to git-llvm section from [docs] Add git to list of Software requirements to [docs] Add note about git version to git-llvm section.
Jul 30 2019, 7:41 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65436: [docs] Add note about git version to git-llvm section.

If we want to add git at all, we should probably mention it somewhere else. I'm not sure where that would be - I suppose somewhere where it makes sense to worry about the minimum version, e.g. where the git-llvm script is concerned.

Jul 30 2019, 7:38 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65436: [docs] Add note about git version to git-llvm section.

Undo Compiling -> Working with

Jul 30 2019, 7:35 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65436: [docs] Add note about git version to git-llvm section.

Remove lldb documentation updates I just added accidentally

Jul 30 2019, 7:29 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65436: [docs] Add note about git version to git-llvm section.

Move git version comment into a footnote in git-llvm section

Jul 30 2019, 7:29 AM · Restricted Project, Restricted Project
sgraenitz added a comment to rGa13cca41c5ce: [ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc..

Hi Lang, I am getting these warnings from ninja docs-llvm-html:

Jul 30 2019, 7:21 AM
sgraenitz added inline comments to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 30 2019, 4:52 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65437: [lldb][docs] Update landing page for monorepo.

@clayborg I added a direct link to Xcode project generation here. Is that fine?

Jul 30 2019, 3:50 AM · Restricted Project, Restricted Project
sgraenitz created D65437: [lldb][docs] Update landing page for monorepo.
Jul 30 2019, 3:45 AM · Restricted Project, Restricted Project
sgraenitz committed rG39fba29861f5: [lldb][docs] Update documentation for monorepo and CMake caches (authored by sgraenitz).
[lldb][docs] Update documentation for monorepo and CMake caches
Jul 30 2019, 3:22 AM
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Add lld note to Windows section

Jul 30 2019, 3:16 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D65436: [docs] Add note about git version to git-llvm section.
Jul 30 2019, 3:12 AM · Restricted Project, Restricted Project
sgraenitz created D65436: [docs] Add note about git version to git-llvm section.
Jul 30 2019, 3:12 AM · Restricted Project, Restricted Project

Jul 29 2019

sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Thanks for your feedback.

Jul 29 2019, 8:41 AM · Restricted Project, Restricted Project

Jul 27 2019

sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Feedback and polishing; latest rendered output here: http://tiny.cc/i5ncaz

Jul 27 2019, 6:16 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Hi Greg, thanks for your feedback.

Jul 27 2019, 6:14 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Address recent feedback

Jul 27 2019, 5:34 AM · Restricted Project, Restricted Project

Jul 26 2019

sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

On http://releases.llvm.org/, for some recent versions like 8.0.0, the "Documentation" column has separate versioned links for "llvm clang lld clang-extra libc++ polly", but lldb doesn't appear there.

Jul 26 2019, 10:20 AM · Restricted Project, Restricted Project
sgraenitz added a reviewer for D65330: [lldb][docs] Update documentation for monorepo and CMake caches: zturner.
Jul 26 2019, 10:20 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Hmm, are there the LLDB docs archived per release? [...] LLDB doesn't seem to appear in sub-project list of versioned docs

Jul 26 2019, 10:03 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

I added a few links to LLVM documentation here and wondered what to do with them, if this gets cherry-picked to release/9.x, e.g. https://llvm.org/docs/CMake.html
Ideally they would point to their 9.x counterparts, e.g. https://releases.llvm.org/9.0.0/docs/CMake.html and with 9.0.1 it should become https://releases.llvm.org/9.0.1/docs/CMake.html
Is there a way to do this in Sphinx?

Jul 26 2019, 9:24 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Since Visual Studio is the only section in Building LLDB with CMake and Other Generators now, ...

Yes, this sounds like a good plan.

Jul 26 2019, 9:07 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Merge Visual Studio build instructions into Common CMake options > Windows

Jul 26 2019, 8:53 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Polishing

Jul 26 2019, 8:46 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Since Visual Studio is the only section in Building LLDB with CMake and Other Generators now, I would like to:

Jul 26 2019, 7:03 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Updated rendered HTML: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html

Jul 26 2019, 7:03 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Polish section CMake caches

Jul 26 2019, 6:41 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Polish section Standalone builds

Jul 26 2019, 6:37 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Add links to sections

Jul 26 2019, 6:07 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

View rendered HTML output here: http://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html

Jul 26 2019, 5:36 AM · Restricted Project, Restricted Project
sgraenitz added reviewers for D65330: [lldb][docs] Update documentation for monorepo and CMake caches: xiaobai, compnerd.
Jul 26 2019, 5:24 AM · Restricted Project, Restricted Project
sgraenitz created D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 5:24 AM · Restricted Project, Restricted Project
sgraenitz updated subscribers of D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 5:24 AM · Restricted Project, Restricted Project
sgraenitz accepted D65230: [CMake] Loosen Python version check and ignore patch version.

LGTM

Jul 26 2019, 1:48 AM · Restricted Project, Restricted Project

Jul 25 2019

sgraenitz committed rGc8916258d5a9: [lldb][CMake] Fix framework-enabled build detail for Xcode (authored by sgraenitz).
[lldb][CMake] Fix framework-enabled build detail for Xcode
Jul 25 2019, 3:48 AM

Jul 24 2019

sgraenitz added a comment to D65230: [CMake] Loosen Python version check and ignore patch version.

Interesting way to get from version to list! :)

Jul 24 2019, 12:24 PM · Restricted Project, Restricted Project
sgraenitz committed rGe8bffd3ff028: [lldb] Configure debugserver_vers.c from CMake (authored by sgraenitz).
[lldb] Configure debugserver_vers.c from CMake
Jul 24 2019, 10:29 AM
sgraenitz added a comment to D65109: [LLDB] Remove the Xcode project.

We discussed this and came to an agreement only a few hours before in the team meeting

Jul 24 2019, 2:28 AM · Restricted Project, Restricted Project
sgraenitz committed rG7e6f355b3e4b: [lldb] Remove Xcode project legacy (authored by sgraenitz).
[lldb] Remove Xcode project legacy
Jul 24 2019, 2:23 AM

Jul 23 2019

sgraenitz added a comment to D65109: [LLDB] Remove the Xcode project.

[lldb] Remove Xcode project legacy: https://reviews.llvm.org/D65155

Jul 23 2019, 8:48 AM · Restricted Project, Restricted Project
sgraenitz created D65155: [lldb] Remove Xcode project legacy.
Jul 23 2019, 8:43 AM · Restricted Project, Restricted Project
sgraenitz resigned from D65114: [LLDB] Add utility to streamline Xcode project generation..

Can we just use the mono-repo style build and use "cmake -G Xcode"?

Jul 23 2019, 7:56 AM · Restricted Project
sgraenitz added a comment to D65109: [LLDB] Remove the Xcode project.

Seriously, discussion for changes like this should be open for more than 1h15min! I am in favor of the change in principle, but there's a number of things that have been rushed over here, e.g.:

cmake/XcodeHeaderGenerator/CMakeLists.txt
scripts/finish-swig-wrapper-classes.sh
scripts/Xcode/build-llvm.py
scripts/Xcode/lldbbuild.py
scripts/Xcode/package-clang-resource-headers.py
scripts/Xcode/prepare-gtest-run-dir.sh
scripts/Xcode/repo.py
scripts/Xcode/repos/FALLBACK
scripts/Xcode/repos/svn-trunk.json
Jul 23 2019, 7:44 AM · Restricted Project, Restricted Project

Jul 22 2019

sgraenitz committed rG3a52e50d7379: Add location of SVN staging dir to git-llvm error output (authored by sgraenitz).
Add location of SVN staging dir to git-llvm error output
Jul 22 2019, 2:50 AM

Jul 20 2019

sgraenitz created D65038: Add location of SVN staging dir to git-llvm error output.
Jul 20 2019, 4:48 AM · Restricted Project
sgraenitz committed rGfc0d766511e9: [CMake] Align debugserver with lldb-server on Darwin (authored by sgraenitz).
[CMake] Align debugserver with lldb-server on Darwin
Jul 20 2019, 4:19 AM

Jul 19 2019

sgraenitz added inline comments to D64994: [CMake] Align debugserver with lldb-server on Darwin.
Jul 19 2019, 8:06 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.
Jul 19 2019, 7:57 AM · Restricted Project, Restricted Project
sgraenitz created D64994: [CMake] Align debugserver with lldb-server on Darwin.
Jul 19 2019, 7:29 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.
Jul 19 2019, 3:47 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.
Jul 19 2019, 3:46 AM · Restricted Project, Restricted Project