Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (208 w, 20 h)

We may think in generalities, but weliveindetail

Recent Activity

Thu, Jun 30

sgraenitz added a comment to D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper.

Thanks for posting your patch! I will continue reviewing, but here is a first detail I found..

Thu, Jun 30, 2:29 PM · Restricted Project, Restricted Project

Sat, Jun 25

sgraenitz accepted D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..

Thanks, yes looks good to me!

Sat, Jun 25, 9:00 AM · Restricted Project, Restricted Project

Tue, Jun 21

sgraenitz committed rG79fbee3cc562: Re-apply "[JITLink][Orc] Add MemoryMapper interface with InProcess… (authored by argentite).
Re-apply "[JITLink][Orc] Add MemoryMapper interface with InProcess…
Tue, Jun 21, 2:53 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation.

Thanks for taking care of reverting.

Tue, Jun 21, 2:50 PM · Restricted Project, Restricted Project
sgraenitz committed rG6ede65205073: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation (authored by argentite).
[JITLink][Orc] Add MemoryMapper interface with InProcess implementation
Tue, Jun 21, 4:45 AM · Restricted Project, Restricted Project
sgraenitz closed D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation.
Tue, Jun 21, 4:45 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D128037: [ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport..

Thanks, that sounds reasonable. Maybe we can provide some more context on atexit vs. __cxa_atexit in the commit message?

Tue, Jun 21, 3:44 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation.
Tue, Jun 21, 3:32 AM · Restricted Project, Restricted Project

Mon, Jun 20

sgraenitz added a comment to D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls.

Running check-llvm and check-clang locally found no more failing tests. The issue is not limited to pre-ISel intrinsics (anymore) and I have to re-phrase a few comments. Apart from that, is there any more feedback? Thanks

Mon, Jun 20, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz updated the diff for D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls.

Add missing objc_sync_exit to fix failing test Transforms/PreISelIntrinsicLowering/objc-arc.ll

Mon, Jun 20, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz added a comment to D127962: [WinEHPrepare] Propagate funclet tokens when inlining into EH funclets.

Thanks for your feedback.

Mon, Jun 20, 5:51 AM · Restricted Project, Restricted Project
sgraenitz requested review of D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls.
Mon, Jun 20, 5:47 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz accepted D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation.

LGTM. Let's go and land this once Lang's two latest comment got addressed.

Mon, Jun 20, 1:37 AM · Restricted Project, Restricted Project

Thu, Jun 16

sgraenitz added a comment to D127962: [WinEHPrepare] Propagate funclet tokens when inlining into EH funclets.

This is the best solution I found so far. The funclet bundle operand (aka. token) of the inlinee function will be propagated to the set of intrinsics that is (as of today) subject to pre-ISel lowering. This only applies when targeting WinEH and only for functions inlined into EH funclets.

Thu, Jun 16, 8:16 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D127962: [WinEHPrepare] Propagate funclet tokens when inlining into EH funclets.

Limit explicit propagation to actual pre-ISel intrinsics

Thu, Jun 16, 8:00 AM · Restricted Project, Restricted Project
sgraenitz requested review of D127962: [WinEHPrepare] Propagate funclet tokens when inlining into EH funclets.
Thu, Jun 16, 6:38 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation.

Overall, I think this looks pretty good! I didn't follow the design discussions closely, so please bare with me in case some of my questions are dumb :-) In a way it makes sure other people will understand your code as well.

Thu, Jun 16, 2:24 AM · Restricted Project, Restricted Project

Wed, Jun 15

sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Drop GNUstep assertion from getBundlesForFunclet(). Indeed a similar issue was observed before. See: D44640

Wed, Jun 15, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Fix accidental functional change that failed Clang test CodeGenCXX/microsoft-abi-eh-inlineasm.cpp

Wed, Jun 15, 8:04 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Update LLVM CodeGen test for mainline opaque pointers

Tue, Jun 14, 3:41 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

sgraenitz accepted D127559: [JITLink][AArch64] Lift fixup functions from aarch64.cpp to aarch64.h. (NFC).

Just to add some context for other reviewers: We want this code in the header to make sure it's inlined into the backends.

Mon, Jun 13, 2:52 PM · Restricted Project, Restricted Project

Tue, Jun 7

sgraenitz added inline comments to D127058: [JITLink][ELF/AARCH64] Implement R_AARCH64_PREL32 and R_AARCH64_PREL64.
Tue, Jun 7, 7:01 AM · Restricted Project, Restricted Project
sgraenitz accepted D127059: [JITLink][ELF/AARCH64] Implement R_AARCH64_JUMP26.

LGTM

Tue, Jun 7, 5:07 AM · Restricted Project, Restricted Project

Jun 5 2022

sgraenitz accepted D126658: [JITLink][ELF/AARCH64] Implement R_AARCH64_ABS64 relocation type.

LGTM, thanks for working on this!

Jun 5 2022, 12:10 PM · Restricted Project, Restricted Project
sgraenitz accepted D126630: [JITLink][ELF/AARCH64] Implement R_AARCH64_LDST*_ABS_LO12_NC relocation types.

LGTM, thanks for working on this!

Jun 5 2022, 12:08 PM · Restricted Project, Restricted Project
sgraenitz accepted D126287: [JITLink][ELF/AARCH64] Implement R_AARCH64_ADR_PREL_PG_HI21 and R_AARCH64_ADD_ABS_LO12_NC.

LGTM, thanks for working on this!

Jun 5 2022, 12:04 PM · Restricted Project, Restricted Project
sgraenitz accepted D126286: [JITLink] [ELF/AARCH64] Generic aarch64 patch fixups.

LGTM, thanks for working on this!

Jun 5 2022, 12:03 PM · Restricted Project, Restricted Project

Jun 3 2022

sgraenitz added a comment to D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

For illustration, truncations look like this (left: old CodeGen, right: with this fix applied)

Jun 3 2022, 8:06 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz added a comment to D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

My follow-up got delayed, because I hit another bug, which appears to be a regression in release 14. This is why I wrote the tests for release/13.x and I still have to port them back to mainline, so this is *not yet ready to land*. As I don't expect it to cause big changes, however, I though it might be good to update the review anyway.

Jun 3 2022, 7:59 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Clang frontend: check that 'funclet' bundle operands are emitted for Pre-ISel intrinsics

Jun 3 2022, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

LLVM CodeGen: check that presence of bundle operands avoids truncation

Jun 3 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz updated the diff for D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Fix unchecked nullptr compiler crash and assertion

Jun 3 2022, 7:26 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

sgraenitz accepted D126628: [JITLink][AARCH64][NFC] Create isLoadStoreImm12 function by splitting getPageOffset12Shift.

LGTM!

Jun 1 2022, 12:18 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D126287: [JITLink][ELF/AARCH64] Implement R_AARCH64_ADR_PREL_PG_HI21 and R_AARCH64_ADD_ABS_LO12_NC.

Thanks for your patch. The tests look good and appear to work fine on my machine. Will have a closer look at it towards the end of the week.

Jun 1 2022, 5:49 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D126630: [JITLink][ELF/AARCH64] Implement R_AARCH64_LDST*_ABS_LO12_NC relocation types.

The difference between macho backend is that in ELF, the shift value is explicitly given by relocation type. lld generates the relocation type that matches with instruction bitwidth, so getting the shift value implicitly from instruction bytes should be fine in typical use cases.

Jun 1 2022, 5:14 AM · Restricted Project, Restricted Project

May 30 2022

sgraenitz added a comment to D126467: [JITLink][ELF/AARCH64][NFC] Add testcases for ELFCall26/ELFAdrPage21/ELFAddAbs12.

This is testing the functionality that's wired up in D126287 right? Can we add it there? Thanks

May 30 2022, 12:56 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D126629: [JITLink][ELF/AARCH64][NFC] Add testcases for gpr R_AARCH64_LDST*_ABS_LO12_NC.

If it's not too much effort, can we add this to the review for the implementation in D126630? Thanks

May 30 2022, 12:53 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D126659: [JITLink][ELF/AARCH64][NFC] Add a testcase for R_AARCH64_ABS64.

If it's not too much effort, can we abandon review and add it to the one with the implementation in D126658? You tracked the dependencies here in Phabricator nicely, but it's usually easier for people to see their relation in the git history if it's one commit. All functional changes need testing and so checking them in together is good practice. Thanks!

May 30 2022, 12:52 PM · Restricted Project, Restricted Project
sgraenitz accepted D126387: [JITLink][AARCH64] Fix overflow range of Page21.

Good catch!

May 30 2022, 12:10 AM · Restricted Project, Restricted Project

May 25 2022

sgraenitz added a comment to D126286: [JITLink] [ELF/AARCH64] Generic aarch64 patch fixups.

Kudos, this is a really good first patch. Thanks for working on this sunho! I think this is almost ready to land as is. Just pointing out a few minor details I encountered while reading through.

May 25 2022, 4:26 AM · Restricted Project, Restricted Project

May 3 2022

sgraenitz added a comment to D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

Thanks for your help! I will work on testing in calendar week 21.

May 3 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

sgraenitz added a comment to D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.

I guess testing must be split in two:

May 2 2022, 5:30 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz abandoned D124680: [WinEHPrepare] Fix accidental truncation of EH funclets with GNUstep ObjC runtime.

Thanks for your comments Reid, this was really helpful!

May 2 2022, 5:14 AM · Restricted Project, Restricted Project
sgraenitz requested review of D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime.
May 2 2022, 5:05 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

sgraenitz added a comment to D124680: [WinEHPrepare] Fix accidental truncation of EH funclets with GNUstep ObjC runtime.

There is a second attempt here, that I am more uncertain about: https://github.com/weliveindetail/llvm-project/commit/93e830eb1b9280d08e3f082b746a8d1343d413ac

Apr 29 2022, 12:52 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D124680: [WinEHPrepare] Fix accidental truncation of EH funclets with GNUstep ObjC runtime.

Added some more details here on Github:
https://github.com/weliveindetail/libobjc2/commit/cfd3ede57901fa1d294268d8ef2ab992fefa3fb1#r72508265

Apr 29 2022, 9:11 AM · Restricted Project, Restricted Project
sgraenitz requested review of D124680: [WinEHPrepare] Fix accidental truncation of EH funclets with GNUstep ObjC runtime.
Apr 29 2022, 9:01 AM · Restricted Project, Restricted Project

Jan 30 2022

sgraenitz added a comment to D118346: [ORC] Support ADR_PREL_PG_HI21 & ADD_ABS_LO12_NC for aarch64.

Thanks for the patch. I can't dig into the details deeper right now, but if the test issues remain I do so next week.

Jan 30 2022, 6:41 AM · Restricted Project, Restricted Project

Jan 26 2022

sgraenitz accepted D118231: [ORC][AArch64] use isInt<N> to replace fitsRangeSignedInt on aarch64.

This is from llvm/Support/MathExtras.h right? Can you add it as an explicit include please? Otherwise LGTM.

Jan 26 2022, 5:05 AM · Restricted Project

Jan 5 2022

sgraenitz abandoned D96039: [JITLink] Infer default value for -use-orc-runtime option from CMake.

This patch wasn't adopted. Instead, ORC opted for explicit runtime paths in https://reviews.llvm.org/rG13c8ec44e6385127f4aaba333dcad705dd5888c6

Jan 5 2022, 1:55 AM · Restricted Project
sgraenitz abandoned D110615: [ORC] SimpleRemoteEPCServer: exit gracefully when detecting invalid connection.

I can't reproduce the original error on mainline anymore. I guess one of the EPC refactors fixed the issue on the way. Thanks

Jan 5 2022, 1:46 AM · Restricted Project

Nov 11 2021

sgraenitz added inline comments to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.
Nov 11 2021, 9:50 AM · Restricted Project

Oct 25 2021

sgraenitz added inline comments to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.
Oct 25 2021, 12:11 PM · Restricted Project
sgraenitz added a comment to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.

it always fall into OutOfRangeError

Oct 25 2021, 12:07 PM · Restricted Project
sgraenitz committed rGcdb335ffaff2: [JITLink] Fix warning 'shift count exceeds width' in AArch64 backend (authored by sgraenitz).
[JITLink] Fix warning 'shift count exceeds width' in AArch64 backend
Oct 25 2021, 11:45 AM
sgraenitz added a comment to D112451: implemented R_AARCH64_ADR_PREL_PG_HI21, R_AARCH64_ADR_PREL_PG_HI21_NC, R_AARCH64_ADD_ABS_LO12_NC.

Hi Kelvin, thanks for working on this. I will run your patch through my pi tonight and see how I can help.

Oct 25 2021, 7:13 AM · Restricted Project

Oct 23 2021

sgraenitz abandoned D104016: [Orc][examples] Join ListenerThread on early exit in LLJITWithRemoteDebugging.

Eventually this should be fixed with 878060aaf965

Oct 23 2021, 1:19 PM · Restricted Project
sgraenitz committed rG878060aaf965: [Orc][examples] Re-enable test for LLJITWithRemoteDebugging (authored by sgraenitz).
[Orc][examples] Re-enable test for LLJITWithRemoteDebugging
Oct 23 2021, 8:01 AM
sgraenitz closed D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.
Oct 23 2021, 8:01 AM · Restricted Project

Oct 11 2021

sgraenitz committed rGa6c9506365fb: [Orc] Handle hangup messages in SimpleRemoteEPC (authored by sgraenitz).
[Orc] Handle hangup messages in SimpleRemoteEPC
Oct 11 2021, 12:05 PM
sgraenitz closed D111527: [Orc] Handle hangup messages in SimpleRemoteEPC.
Oct 11 2021, 12:05 PM · Restricted Project
sgraenitz abandoned D111528: [Orc] Allow in-band errors for runAsMain() via SPS.

Passing a valid function address is the responsibility of the user and laying out argv correctly is an ABI detail. If anything like this fails, we probably have to hang up anyway and send the error with that D111527.

Oct 11 2021, 11:33 AM · Restricted Project
sgraenitz requested review of D111528: [Orc] Allow in-band errors for runAsMain() via SPS.
Oct 11 2021, 1:39 AM · Restricted Project
sgraenitz requested review of D111527: [Orc] Handle hangup messages in SimpleRemoteEPC.
Oct 11 2021, 1:33 AM · Restricted Project

Sep 29 2021

sgraenitz abandoned D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.

Thanks for confirming the issue. Aiming for a more thorough solution is fine for me. I committed the SimpleRemoteEPC port for the LLJITWithRemnoteDebugging example with ac2daacb310cbb1732de1c139be7a0e8e982169e even though it's not fully functional yet, because it drops the last in-tree dependency to the old OrcRPC implementation. Once we have a fix for the threading issue here, I will re-enable the test for the example (see D110649).

Sep 29 2021, 2:56 AM · Restricted Project
sgraenitz added a comment to D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.

SimpleRemoteEPC port of the LLJITWithRemoteDebugging example landed with ac2daacb310cbb1732de1c139be7a0e8e982169e

Sep 29 2021, 1:26 AM · Restricted Project
sgraenitz committed rGac2daacb310c: [ORC][examples] Port LLJITWithRemoteDebugging to SimpleRemoteEPC (authored by sgraenitz).
[ORC][examples] Port LLJITWithRemoteDebugging to SimpleRemoteEPC
Sep 29 2021, 1:25 AM

Sep 28 2021

sgraenitz requested review of D110649: [ORC][examples] Re-enable test for LLJITWithRemoteDebugging.
Sep 28 2021, 12:38 PM · Restricted Project
sgraenitz requested review of D110615: [ORC] SimpleRemoteEPCServer: exit gracefully when detecting invalid connection.
Sep 28 2021, 2:25 AM · Restricted Project

Sep 27 2021

sgraenitz added a comment to D110484: [clang-repl] Allow loading of plugins in clang-repl..

Two minor comments. Otherwise LGTM.

Sep 27 2021, 6:23 AM · Restricted Project
sgraenitz added a comment to D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.

Using the plugin's very own DebugObject::finalizeAsync() is not sufficient

Sep 27 2021, 4:02 AM · Restricted Project
sgraenitz requested review of D110530: [ORC] Avoid deadlocks in ObjectLinkingLayer plugins with blocking finalize handlers.
Sep 27 2021, 3:58 AM · Restricted Project

Sep 23 2021

sgraenitz committed rG1286bbc85f42: [ORC][examples] Export exectuable symbols explicitly in… (authored by sgraenitz).
[ORC][examples] Export exectuable symbols explicitly in…
Sep 23 2021, 12:40 PM
sgraenitz closed D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.
Sep 23 2021, 12:40 PM · Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

FYI Included one more typo fix in ExecutorAddress.h

Sep 23 2021, 12:36 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.

FYI Included one more typo fix in ExecutorAddress.h (Edit: This was in the other review.)

Sep 23 2021, 12:34 PM · Restricted Project
sgraenitz committed rG767b328e506e: [ORC] Minor renaming and typo fixes (NFC) (authored by sgraenitz).
[ORC] Minor renaming and typo fixes (NFC)
Sep 23 2021, 12:34 PM
sgraenitz closed D110260: [ORC] Minor renaming and typo fixes (NFC).
Sep 23 2021, 12:34 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.

Issue reported during review D110260. With this fix, nm should return something like this now:

➜ nm bin/LLJITWithExecutorProcessControl | grep return1
0000000100004c10 T _return1
Sep 23 2021, 9:58 AM · Restricted Project
sgraenitz requested review of D110345: [ORC][examples] Export exectuable symbols explicitly in LLJITWithExecutorProcessControl.
Sep 23 2021, 9:56 AM · Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

Yeah we need testcases, now it says

JIT session error: Symbols not found: [ return1 ]
JIT session error: Failed to materialize symbols: { (main, { foo_body }) }
Unable to lazily compile function. Exiting.

Sep 23 2021, 9:42 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D110260: [ORC] Minor renaming and typo fixes (NFC).

Thanks @xgupta for your note! The parameter passed to EPCIndirectionUtils::Create() in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far.

Sep 23 2021, 7:38 AM · Restricted Project, Restricted Project
sgraenitz committed rG828422747d65: [ORC][examples] Fix segfault in LLJITWithTargetProcessControl (authored by sgraenitz).
[ORC][examples] Fix segfault in LLJITWithTargetProcessControl
Sep 23 2021, 7:34 AM

Sep 22 2021

sgraenitz committed rG2131eb696386: [ORC] DebugObjectManagerPlugin tests can use lli in ORC greedy mode (authored by sgraenitz).
[ORC] DebugObjectManagerPlugin tests can use lli in ORC greedy mode
Sep 22 2021, 9:28 AM
sgraenitz updated subscribers of rG506dbd88fe8f: [ORC] Re-enable ELF DebugObjectManagerPlugin tests.

@mgorny I hope it's not breaking your test suites again?

Sep 22 2021, 8:59 AM
sgraenitz committed rG506dbd88fe8f: [ORC] Re-enable ELF DebugObjectManagerPlugin tests (authored by sgraenitz).
[ORC] Re-enable ELF DebugObjectManagerPlugin tests
Sep 22 2021, 8:58 AM
sgraenitz requested review of D110260: [ORC] Minor renaming and typo fixes (NFC).
Sep 22 2021, 8:53 AM · Restricted Project, Restricted Project
sgraenitz committed rG9689c1b7bb77: [lldb] JITLoaderGDB tests can use lli in ORC greedy mode (authored by sgraenitz).
[lldb] JITLoaderGDB tests can use lli in ORC greedy mode
Sep 22 2021, 5:46 AM

Sep 20 2021

sgraenitz added a comment to D110066: Regression Fix : __jit_debug_descriptor bind on Windows O/S (updated - formatting).

Thanks for working on this. The formatting nits should be straightforward to fix. Apart from that, it would be really nice if the jit-loader_jitlink/rtdyld_elf.test tests could reflect this fix. Otherwise it might regress again any time.

Sep 20 2021, 1:29 PM
sgraenitz updated subscribers of rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

You're right, it's been a bad merge. In the meantime @GMNGeoffrey fixed it with 01b097afd0ea. Sorry for the inconvenience.

Sep 20 2021, 1:17 PM
sgraenitz added a comment to rG01b097afd0ea: Fix bad merge the removed switch case.

@GMNGeoffrey You'er right, thanks for the fix. I've been distracted the whole day.

Sep 20 2021, 1:13 PM
sgraenitz added a comment to D105429: [JITLink][RISCV] Initial Support RISCV64 in JITLink.

It think someone need to accept this revision now to close it.

Sep 20 2021, 6:54 AM · Restricted Project
sgraenitz committed rGe8d81d80f660: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC) (authored by sgraenitz).
[JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC)
Sep 20 2021, 6:47 AM
sgraenitz committed rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC) (authored by sgraenitz).
[JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)
Sep 20 2021, 6:47 AM
sgraenitz closed D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).
Sep 20 2021, 6:47 AM · Restricted Project
sgraenitz closed D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).
Sep 20 2021, 6:47 AM · Restricted Project

Sep 17 2021

sgraenitz added a comment to D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

Ping! I was hoping to land this together with D109522.

Sep 17 2021, 8:28 AM · Restricted Project

Sep 13 2021

sgraenitz added inline comments to D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).
Sep 13 2021, 6:48 AM · Restricted Project
sgraenitz updated the diff for D109522: [JITLink] Adopt forEachRelocation() helper in ELF RISCV backend (NFC).

Account for modifications in the underlying patch

Sep 13 2021, 6:47 AM · Restricted Project
sgraenitz updated the diff for D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).

Account for modifications in the underlying patch && address pre-merge checks

Sep 13 2021, 6:19 AM · Restricted Project