Page MenuHomePhabricator

sgraenitz (Stefan Gränitz)
dev

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 11:23 AM (50 w, 10 h)

We may think in generalities, but weliveindetail

Recent Activity

Today

sgraenitz added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

LGTM

Tue, Jun 25, 10:01 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

In D63745#1556941, @labath wrote:
This code should go to tools/debugserver/source/CMakeLists.txt

+1

Tue, Jun 25, 5:45 AM · Restricted Project, Restricted Project

Wed, Jun 19

sgraenitz committed rGf2ffa7320e25: Specify log level for CMake messages (less stderr) (authored by sgraenitz).
Specify log level for CMake messages (less stderr)
Wed, Jun 19, 8:23 AM

Tue, Jun 18

sgraenitz accepted D63370: Specify log level for CMake messages (less stderr).
Tue, Jun 18, 4:30 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 17

sgraenitz added a comment to D63370: Specify log level for CMake messages (less stderr).

Thanks for the initiative! Three inline comments for cosmetics.

Mon, Jun 17, 3:23 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 13

sgraenitz committed rGa0781b6e3a3a: [CMake] Fix generated Xcode-project ignoring output directory setting for LLDB. (authored by sgraenitz).
[CMake] Fix generated Xcode-project ignoring output directory setting for LLDB.
Thu, Jun 13, 10:34 AM
sgraenitz committed rG113320d3b691: [CMake] Fix lldb-dotest for single-config generators in standalone builds (authored by sgraenitz).
[CMake] Fix lldb-dotest for single-config generators in standalone builds
Thu, Jun 13, 10:33 AM
sgraenitz committed rG8f30e322abad: [CMake] Add fallbacks for copying clang-resource-headers to LLDB.framework in… (authored by sgraenitz).
[CMake] Add fallbacks for copying clang-resource-headers to LLDB.framework in…
Thu, Jun 13, 8:07 AM

Wed, Jun 12

sgraenitz committed rG61a7ab7fdb28: [lldb] Ignore null frames in lldb.macosx crashlog (authored by sgraenitz).
[lldb] Ignore null frames in lldb.macosx crashlog
Wed, Jun 12, 7:44 AM
sgraenitz committed rGa866d3b2eedd: [CMake] Two extra FOLDER properties for debugserver (authored by sgraenitz).
[CMake] Two extra FOLDER properties for debugserver
Wed, Jun 12, 7:44 AM

Fri, Jun 7

sgraenitz committed rG088410ffc6b8: [CMake] Add special case for processing LLDB_DOTEST_ARGS (authored by sgraenitz).
[CMake] Add special case for processing LLDB_DOTEST_ARGS
Fri, Jun 7, 7:32 AM

Wed, Jun 5

sgraenitz added a comment to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Wed, Jun 5, 6:52 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Polishing

Wed, Jun 5, 4:28 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Wed, Jun 5, 4:23 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Unfortunately lit is a little more complicated

Wed, Jun 5, 4:17 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Wed, Jun 5, 2:24 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Remove Xcode restriction and polish

Wed, Jun 5, 2:09 AM · Restricted Project, Restricted Project
sgraenitz committed rGc76946243836: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm… (authored by sgraenitz).
[CMake] Add configuration dirs as potential locations for llvm-lit and llvm…
Wed, Jun 5, 1:29 AM
sgraenitz committed rG3c850ca56035: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree (authored by sgraenitz).
[CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree
Wed, Jun 5, 1:27 AM

Tue, Jun 4

sgraenitz added inline comments to D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.
Tue, Jun 4, 2:47 PM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.

Add CMAKE_EXECUTABLE_SUFFIX when searching for llvm-tblgen

Tue, Jun 4, 2:46 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree.

That will be fine with post-commit review. Will submit tomorrow.

Tue, Jun 4, 2:17 PM · Restricted Project
sgraenitz added inline comments to D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.
Tue, Jun 4, 2:17 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

After figuring out D62879 that came up on the way, this wasn't too complicated indeed. I put the patch for exporting LLVM_CONFIGURATION_TYPES here: D62878

Tue, Jun 4, 2:13 PM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Patch the replacement logic also in lit/CMakeLists.txt

Tue, Jun 4, 2:06 PM · Restricted Project, Restricted Project
sgraenitz added a comment to D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.

IIUC Clang uses the same mechanism. Moving append_configuration_directories() to AddLLVM.cmake could help there too. We may consider it for the future once D62859 is through.

Tue, Jun 4, 2:00 PM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Chose the replacement for remaining matches of CMAKE_CFG_INTDIR depdending on LLVM_CONFIGURATION_TYPES

Tue, Jun 4, 1:54 PM · Restricted Project, Restricted Project
sgraenitz created D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds.
Tue, Jun 4, 1:49 PM · Restricted Project, Restricted Project
sgraenitz created D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree.
Tue, Jun 4, 1:39 PM · Restricted Project
sgraenitz added a reviewer for D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS: labath.
Tue, Jun 4, 11:42 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.

Thanks for your feedback. I should have mentioned that this is pretty much a draft. For now I was happy it works at all.

Tue, Jun 4, 11:42 AM · Restricted Project, Restricted Project
sgraenitz created D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS.
Tue, Jun 4, 7:51 AM · Restricted Project, Restricted Project
sgraenitz committed rGe4ad1b7bbedf: [CMake] Move and add settings to Apple-lldb-base cache script (authored by sgraenitz).
[CMake] Move and add settings to Apple-lldb-base cache script
Tue, Jun 4, 7:20 AM

Wed, May 29

sgraenitz committed rG72e05d0aa4ff: [CMake] Remove lldb-server from LLDB.framework (authored by sgraenitz).
[CMake] Remove lldb-server from LLDB.framework
Wed, May 29, 4:27 AM
sgraenitz committed rG5dc903674648: [CMake] LLDB.framework tools handling (authored by sgraenitz).
[CMake] LLDB.framework tools handling
Wed, May 29, 4:26 AM
sgraenitz updated the diff for D62472: [CMake] LLDB.framework tools handling.

Fixed debugserver; excluded changes in add_lldb_library() for now; result of this test looks as good as before:

Wed, May 29, 4:20 AM · Restricted Project, Restricted Project

Tue, May 28

sgraenitz added a comment to D62472: [CMake] LLDB.framework tools handling.

Thanks for having a look. I'd to focus on the mechanism here and keep the contents of the framework bundle unchanged. Happy to discuss this in separate reviews like D62474.

Tue, May 28, 11:16 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D62472: [CMake] LLDB.framework tools handling.

Fix copy/paste mistake for darwin-debug

Tue, May 28, 11:16 AM · Restricted Project, Restricted Project
sgraenitz committed rGa3388e5f9e1f: [CMake] Folder structure for generated Xcode project to cover more targets (authored by sgraenitz).
[CMake] Folder structure for generated Xcode project to cover more targets
Tue, May 28, 2:28 AM

Sun, May 26

sgraenitz created D62474: [CMake] Remove lldb-server from LLDB.framework.
Sun, May 26, 11:52 PM · Restricted Project
sgraenitz updated the diff for D62472: [CMake] LLDB.framework tools handling.

lldb-vscode is no fremwork tool, but instead it needs the RPATHs

Sun, May 26, 11:39 PM · Restricted Project, Restricted Project
sgraenitz abandoned D61952: [CMake] Stabilize install process for LLDB.framework.

Closing this in favor of the reduced proposal

Sun, May 26, 11:39 PM · Restricted Project
sgraenitz created D62472: [CMake] LLDB.framework tools handling.
Sun, May 26, 11:33 PM · Restricted Project, Restricted Project

May 17 2019

sgraenitz committed rGfd0779181f55: [CMake] Add first CMake cache files (authored by sgraenitz).
[CMake] Add first CMake cache files
May 17 2019, 12:18 PM
sgraenitz committed rGdcc477e38cc4: [CMake] Inline info plist in lldb driver (authored by sgraenitz).
[CMake] Inline info plist in lldb driver
May 17 2019, 12:18 PM
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

Ok thanks. I will be OOO next week, so no hurries.

May 17 2019, 12:09 PM · Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

How does this cleanup affect dependency tracking? Does the build dir become unusable after running ninja install?

In D61952#1504942, @sgraenitz wrote:
Actually, why not make the copy operations PRE_BUILD actions of the test suite instead of POST_BUILD actions of their executables?

In D61952#1505019, @sgraenitz wrote:
The solution to the "install -> test" issue would be having both I guess.

May 17 2019, 7:24 AM · Restricted Project
sgraenitz added a comment to D61956: [CMake] Add first CMake cache files.

I noticed you have lots of comments that say "Release has different values for these variables".

May 17 2019, 3:50 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61956: [CMake] Add first CMake cache files.

Fix default install locations and add comments on how to use DESTDIR

May 17 2019, 3:15 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

Sure, ideally CMake defined a global install order and this order would handle overlap. I think that's unlikely to happen. It took quite some time to find and fix an overlap case downstream and I think it's worth avoiding it in general in the future. OTOH I see that the solution shouldn't be too intrusive. For the swift resources: I am not familiar with the details; all I know is that tests fail if they are missing.

May 17 2019, 2:16 AM · Restricted Project

May 16 2019

sgraenitz added inline comments to D61956: [CMake] Add first CMake cache files.
May 16 2019, 10:57 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D61956: [CMake] Add first CMake cache files.
May 16 2019, 10:52 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61956: [CMake] Add first CMake cache files.

Add back CACHE STRING "" for CMAKE variables

May 16 2019, 10:38 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

Yet another option: we could install the framework tools to a fake location and copy them to their final destination (overwriting their build-tree pendants) in a manual install step at the very end of the install process. The problem here is, that there may be more things in the build-tree framework than we overwrite, and thus remain in the install-tree (thinking about Swift resources in swift-lldb for example).

May 16 2019, 10:22 AM · Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

I thought about one more option, but I don't think it's better than the current proposal: instead of deleting the build-tree resources in the very first install step, I could install the framework manually at this point and skip its regular install target. We would loose implicit stripping and RPATH replacement for the dylib though. Should be possible to do it manually, but if it breaks, we won't notice. So, it's not quite appealing.

May 16 2019, 10:10 AM · Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

Actually, why not make the copy operations PRE_BUILD actions of the test suite instead of POST_BUILD actions of their executables?

May 16 2019, 9:15 AM · Restricted Project
sgraenitz added a comment to D61952: [CMake] Stabilize install process for LLDB.framework.

I'm not very familiar with frameworks and complexities involved in creating them, but the fact that we need to delete stuff from the build tree in order to install properly makes me think that there is something fishy going on. Is there no way to arrange things so that this can be avoided?

May 16 2019, 9:12 AM · Restricted Project
sgraenitz added a comment to D61956: [CMake] Add first CMake cache files.

Thanks for your input.

May 16 2019, 7:09 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61956: [CMake] Add first CMake cache files.

Rename macOS specific cache file.
Add settings and comments.
Fix install destinations by appending Developer and SharedFrameworks respectively.

May 16 2019, 6:59 AM · Restricted Project, Restricted Project

May 15 2019

sgraenitz created D61956: [CMake] Add first CMake cache files.
May 15 2019, 11:04 AM · Restricted Project, Restricted Project
sgraenitz updated the summary of D61952: [CMake] Stabilize install process for LLDB.framework.
May 15 2019, 10:43 AM · Restricted Project
sgraenitz created D61952: [CMake] Stabilize install process for LLDB.framework.
May 15 2019, 9:32 AM · Restricted Project
sgraenitz added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Yes, sorry for that. I realized it after the commit was in. The commit I got from arc patch did have the original author information. It must have changed in git llvm push, probably because it's still going to SVN and then gets mirrored back to git. I missed this last detail.

May 15 2019, 5:13 AM · Restricted Project, Restricted Project
sgraenitz committed rGa5588c4583a7: [CMake] Add error to clarify that lldb requires libcxx (authored by sgraenitz).
[CMake] Add error to clarify that lldb requires libcxx
May 15 2019, 1:57 AM

May 14 2019

sgraenitz accepted D61877: [CMake] Add error to clarify that lldb requires libcxx.

Sure, will commit this on your behalf tomorrow. (If nothing else comes up.)

May 14 2019, 9:55 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

LGTM

May 14 2019, 8:38 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Thanks for adding this. Would it make sense to use LLVM_ENABLE_PROJECTS_USED? https://github.com/llvm/llvm-project/blob/a568222d/llvm/CMakeLists.txt#L128

May 14 2019, 2:50 AM · Restricted Project, Restricted Project

May 13 2019

sgraenitz added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

It looks like this test is flaky [...] what would you say to just deleting the "# CHECK: 1 location added to breakpoint 1" line from the test?

May 13 2019, 2:52 AM · Restricted Project, Restricted Project
sgraenitz committed rG7e8be135cf46: Fix flakiness in lldb lit test (authored by sgraenitz).
Fix flakiness in lldb lit test
May 13 2019, 2:49 AM

May 9 2019

sgraenitz committed rGf0ee69f75d61: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors (authored by sgraenitz).
[JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors
May 9 2019, 9:39 AM
sgraenitz added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

I can update config.py to create the right features, but we can also use UNSUPPORTED: system-windows, so I'll look into the best way to do this.

Perfect, thanks

May 9 2019, 9:38 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Add back test requirement target-x86_64

May 9 2019, 8:48 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Sorry for the drive-by... what is this REQUIRES: nowindows? I don't see where lit generates this property. I grepped all of llvm-project.git and I see it used in two tests, but not where it's produced. Which suggests that those tests don't actually run *anywhere*.

May 9 2019, 8:26 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.
  1. XFAIL: system-windows
May 9 2019, 8:18 AM · Restricted Project, Restricted Project
sgraenitz added inline comments to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.
May 9 2019, 8:18 AM · Restricted Project, Restricted Project
sgraenitz added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

@stella.stamenova Can you have a look at the lit test please? It works on macOS and Linux, but I didn't test Windows. Should I add something like # REQUIRES: nowindows or is it fine like this?

May 9 2019, 7:42 AM · Restricted Project, Restricted Project
sgraenitz added a reviewer for D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors: stella.stamenova.
May 9 2019, 7:36 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Generalize lit test

May 9 2019, 7:33 AM · Restricted Project, Restricted Project
sgraenitz abandoned D51546: [WIP] Fix parsing of OSO entries for LTO optimized compile units.
May 9 2019, 2:37 AM · Restricted Project
sgraenitz abandoned D51744: [WIP] Early ThinLTOLayer2 prototype.
May 9 2019, 2:37 AM · Restricted Project
sgraenitz abandoned D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap.
May 9 2019, 2:35 AM
sgraenitz abandoned D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support.
May 9 2019, 2:34 AM · Restricted Project
sgraenitz added a comment to D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support.

Ok, I went with MCJIT for now. Will leave this here for future reference.

May 9 2019, 2:34 AM · Restricted Project
sgraenitz abandoned D51128: [ORC] LLJITTest: API test and usage examples with actual codegen.
May 9 2019, 2:32 AM · Restricted Project
sgraenitz abandoned D51126: [ORC] LLJIT::Create() proposal: add flag to enable multithreaded codegen.
May 9 2019, 2:32 AM · Restricted Project

May 8 2019

sgraenitz added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
May 8 2019, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
sgraenitz added a comment to D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Thanks for your reply and thoughts about that.

May 8 2019, 10:34 AM · Restricted Project, Restricted Project
sgraenitz updated the diff for D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.

Add lit test

May 8 2019, 10:12 AM · Restricted Project, Restricted Project

May 6 2019

sgraenitz created D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors.
May 6 2019, 2:06 PM · Restricted Project, Restricted Project

May 4 2019

sgraenitz added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
May 4 2019, 6:50 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2019

sgraenitz updated the diff for D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support.

For illustration: pass ownership to ObjectLinkingLayer and hand out a MemBufferRef in NotifyLoaded

Apr 25 2019, 3:28 AM · Restricted Project
sgraenitz added a comment to D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support.

Ok I see, as long as the original MemoryBuffer exists, we can recreate an identical ObjectFile on the client side. Currently it gets deleted together with JITLinkContext when returning from jitLink().

Apr 25 2019, 3:21 AM · Restricted Project

Apr 24 2019

sgraenitz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Maybe not the most elegant solution, but this seems to work: https://reviews.llvm.org/D61065

Apr 24 2019, 6:31 AM · Restricted Project
sgraenitz created D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support.
Apr 24 2019, 6:29 AM · Restricted Project
sgraenitz added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

One crucial part that I found missing here is a way to connect JITEventListener (like GDBJITRegistration, PerfJITEvents, etc.), because the new ObjectLinkingLayer::NotifyLoaded function only provides the module key but no ObjectFile so we cannot create and pass over a LoadedObjectInfo as with RuntimeDyld. Please see my inline comments for some pointers.

Apr 24 2019, 5:27 AM · Restricted Project

Apr 23 2019

sgraenitz accepted D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK.

LGTM too. Did this land?

Apr 23 2019, 5:02 AM · Restricted Project

Apr 18 2019

sgraenitz added a comment to D60863: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM.

This was mostly to illustrate usage of the matching LLVM commit. Unlikely to break something. Post-commit review should be sufficient.

Apr 18 2019, 9:42 AM · Restricted Project
sgraenitz committed rG31d0ce005c80: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with… (authored by sgraenitz).
[CMake] Emit LLDB.framework.dSYM to avoid potential name collision with…
Apr 18 2019, 9:36 AM
sgraenitz committed rGab58268fdaf5: [CMake] Allow custom extensions for externalized debug info (authored by sgraenitz).
[CMake] Allow custom extensions for externalized debug info
Apr 18 2019, 9:36 AM
sgraenitz added a comment to D60862: [CMake] Allow custom extensions for externalized debug info.

Yes, scopes are per directory; macros operate on the caller's scope and functions add one.

Apr 18 2019, 9:21 AM · Restricted Project