compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (280 w, 6 h)

Recent Activity

Yesterday

compnerd accepted D31275: [lldb] Fix lldb build on musl.
Sun, Apr 22, 7:38 PM · Restricted Project
compnerd accepted D45935: Add dump method for selectors.

LGTM

Sun, Apr 22, 7:37 PM

Thu, Apr 19

compnerd added inline comments to D45319: [Atomics] warn about misaligned atomic accesses using libcalls.
Thu, Apr 19, 5:48 PM · Restricted Project
compnerd accepted D45771: [Driver] Support for -save-stats in AddGoldPlugin..

Some cleanup suggestions included, but I like the change overall.

Thu, Apr 19, 5:44 PM
compnerd committed rL330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Thu, Apr 19, 4:20 PM
compnerd committed rC330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Thu, Apr 19, 4:20 PM

Mon, Apr 16

compnerd committed rL330161: Revert "build: reserve `--color-diagnostics` for lld".
Revert "build: reserve `--color-diagnostics` for lld"
Mon, Apr 16, 3:00 PM
compnerd committed rL330158: build: reserve `--color-diagnostics` for lld.
build: reserve `--color-diagnostics` for lld
Mon, Apr 16, 2:09 PM

Sat, Apr 14

compnerd added a comment to D45639: [Driver] Support default libc++ library location on Darwin.

I'm not sure I understand this. The proper location for libc++ on the darwin layout is in the SDK, not relative to the driver. The default behaviour is similar to cross-compiling, and with a (derived) SDK. This definitely needs to be reviewed by @dexonsmith

Sat, Apr 14, 3:41 PM
compnerd added a comment to D45383: Limit types of builtins that can be redeclared..

Snipping bits from va_defs.h:

Sat, Apr 14, 3:39 PM · Restricted Project
compnerd accepted D45196: [libc++abi] Replace __sync_* functions with __libcpp_atomic_* functions..

I definitely like the clean up. Not sure I understand the motivation for the __libcpp_relaxed_store, but I suppose thats because its a copy from libc++ where it may be more useful.

Sat, Apr 14, 3:32 PM
compnerd accepted D45319: [Atomics] warn about misaligned atomic accesses using libcalls.

Sorry for the delay, didn't see the changes earlier.

Sat, Apr 14, 11:23 AM · Restricted Project

Fri, Apr 13

compnerd committed rCXX330045: support: add missing locale stubs for android L, M.
support: add missing locale stubs for android L, M
Fri, Apr 13, 11:18 AM
compnerd committed rL330045: support: add missing locale stubs for android L, M.
support: add missing locale stubs for android L, M
Fri, Apr 13, 11:18 AM

Thu, Apr 12

compnerd accepted D45590: [Support] Fix building for Windows on ARM.
Thu, Apr 12, 7:41 PM
compnerd added a comment to D45383: Limit types of builtins that can be redeclared..

I know that the Windows SDK definitely declares the __va_start function. Did you try building something like swift against the Windows SDK with this change?

Thu, Apr 12, 11:18 AM · Restricted Project

Wed, Apr 11

compnerd committed rL329866: Lex: make `clang::Preprocessor::macros` work on MSVC.
Lex: make `clang::Preprocessor::macros` work on MSVC
Wed, Apr 11, 4:50 PM
compnerd committed rC329866: Lex: make `clang::Preprocessor::macros` work on MSVC.
Lex: make `clang::Preprocessor::macros` work on MSVC
Wed, Apr 11, 4:50 PM

Thu, Apr 5

compnerd added inline comments to D44236: [llvm-objcopy] Switch over to using TableGen for parsing arguments.
Thu, Apr 5, 8:39 AM

Wed, Apr 4

compnerd accepted D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.
Wed, Apr 4, 8:06 PM · Restricted Project

Mon, Apr 2

compnerd committed rC329025: CodeGenCXX: support PreserveMostCC in MS ABI.
CodeGenCXX: support PreserveMostCC in MS ABI
Mon, Apr 2, 3:30 PM
compnerd committed rL329025: CodeGenCXX: support PreserveMostCC in MS ABI.
CodeGenCXX: support PreserveMostCC in MS ABI
Mon, Apr 2, 3:30 PM

Wed, Mar 28

compnerd requested changes to D44494: [libunwind] Support __register_frame with a full .eh_frame section.

I really don't like this approach. I think that we should introduce a different entry point for this behavior rather than saying that we go through the existing interface. Having a reference to the .eh_frame_hdr seems better, as it would be better to make use of that optimization and we already have handling for that in libunwind.

Wed, Mar 28, 1:39 PM

Mar 22 2018

compnerd committed rL328211: vim: rename `singlethread` to `syncscope`.
vim: rename `singlethread` to `syncscope`
Mar 22 2018, 9:43 AM

Mar 21 2018

compnerd added a comment to D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros.

I may be a bit biased but I agree with @bob.wilson and @steven_wu. The current names are better from the user’s perspective. GCC’s build is a very bad example as it has runtime components built as part of it (libgcc). When building any code, even in a Canadian cross-compile, the target will always be what you are running on. The preprocessor macros are part of the code that you are building for a given target. The association with the command line option makes it more obvious what it is going to use to determine the value. Having a pithy name should also be considered a design goal. Recreating new terminology only muddles the problem.

Mar 21 2018, 5:42 PM
compnerd committed rL328170: vim: add `dso_local` and `dso_preemptable` keywords.
vim: add `dso_local` and `dso_preemptable` keywords
Mar 21 2018, 4:49 PM

Mar 20 2018

compnerd added inline comments to D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.
Mar 20 2018, 3:56 PM · Restricted Project
compnerd added a reviewer for D44671: [libcxx] Enable static libcxxabi linking on Darwin: dexonsmith.

I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS.

Mar 20 2018, 3:40 PM
compnerd committed rL328007: Basic: support PreserveMost and PreserveAll on Windows ARM.
Basic: support PreserveMost and PreserveAll on Windows ARM
Mar 20 2018, 10:37 AM
compnerd committed rC328007: Basic: support PreserveMost and PreserveAll on Windows ARM.
Basic: support PreserveMost and PreserveAll on Windows ARM
Mar 20 2018, 10:36 AM

Mar 19 2018

compnerd added a comment to D44641: [ObjCARC] Add funclet token to ARC marker.

LGTM, I'd give @majnemer a day or so before committing.

Mar 19 2018, 2:30 PM
compnerd added a comment to D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.

What happens in the case that you have a variadic in C code marked with __forceinline? Does that also cause a warning with MSVC?

Mar 19 2018, 2:09 PM · Restricted Project

Mar 12 2018

compnerd closed D44327: ObjCARC: teach the cloner about funclets.

SVN r327336. Addressed comments in SVN r327351, because I forgot to incorporate them in the first try.

Mar 12 2018, 5:01 PM
compnerd committed rL327351: ObjCARC: address review comments from majnemer.
ObjCARC: address review comments from majnemer
Mar 12 2018, 4:51 PM
compnerd committed rL327336: ObjCARC: teach the cloner about funclets.
ObjCARC: teach the cloner about funclets
Mar 12 2018, 2:51 PM

Mar 9 2018

compnerd updated the diff for D44327: ObjCARC: teach the cloner about funclets.

Use the BB colorizer to detect the token. Fortunately, there is no BB removal/splitting happening here, so there is no state to maintain.

Mar 9 2018, 4:17 PM
compnerd committed rC327183: test: repair windows build after SVN r327105.
test: repair windows build after SVN r327105
Mar 9 2018, 3:03 PM
compnerd committed rL327183: test: repair windows build after SVN r327105.
test: repair windows build after SVN r327105
Mar 9 2018, 3:03 PM
compnerd accepted D43797: [CMake] Copy the generated __config header into build directory.
Mar 9 2018, 2:37 PM
compnerd added a reviewer for D44327: ObjCARC: teach the cloner about funclets: ahatanak.
Mar 9 2018, 2:08 PM
compnerd created D44327: ObjCARC: teach the cloner about funclets.
Mar 9 2018, 2:08 PM

Mar 8 2018

compnerd closed D44278: CodeGen: simplify and validate exception personalities.

SVN r327105

Mar 8 2018, 11:09 PM
compnerd committed rL327105: CodeGen: simplify and validate exception personalities.
CodeGen: simplify and validate exception personalities
Mar 8 2018, 11:09 PM
compnerd committed rC327105: CodeGen: simplify and validate exception personalities.
CodeGen: simplify and validate exception personalities
Mar 8 2018, 11:09 PM
compnerd closed D44240: utils: add a helper class to lit for captured substitutions.

SVN r327082

Mar 8 2018, 4:12 PM
compnerd committed rL327082: utils: add a helper class to lit for captured substitutions.
utils: add a helper class to lit for captured substitutions
Mar 8 2018, 4:08 PM
compnerd updated the diff for D44278: CodeGen: simplify and validate exception personalities.

add more context

Mar 8 2018, 3:54 PM
compnerd created D44278: CodeGen: simplify and validate exception personalities.
Mar 8 2018, 3:47 PM

Mar 7 2018

compnerd added inline comments to D44236: [llvm-objcopy] Switch over to using TableGen for parsing arguments.
Mar 7 2018, 9:39 PM
compnerd added a comment to D44225: Fix identification of COFF executable files.

@rnk, I like the idea of pushing the mapping behavior to the single use in llvm-pdbutil and removing this overload.

Mar 7 2018, 5:41 PM
compnerd created D44240: utils: add a helper class to lit for captured substitutions.
Mar 7 2018, 5:41 PM

Mar 1 2018

compnerd accepted D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC.

Awesome, thanks, this makes me feel much more comfortable.

Mar 1 2018, 11:25 AM
compnerd committed rL326469: Driver: hoist `-fno-rtti-data` to a driver flag.
Driver: hoist `-fno-rtti-data` to a driver flag
Mar 1 2018, 11:17 AM
compnerd committed rC326469: Driver: hoist `-fno-rtti-data` to a driver flag.
Driver: hoist `-fno-rtti-data` to a driver flag
Mar 1 2018, 11:17 AM

Feb 28 2018

compnerd accepted D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC.

Ugh, really not a fan of this change.

Feb 28 2018, 3:13 PM
compnerd added inline comments to D43913: Delay writing the PDB build id until just before file commit..
Feb 28 2018, 3:12 PM
compnerd committed rL326381: build: add the ability to create a symlink for dsymutil.
build: add the ability to create a symlink for dsymutil
Feb 28 2018, 3:05 PM
compnerd committed rC326362: CodeGenObjCXX: handle inalloca appropriately for msgSend variant.
CodeGenObjCXX: handle inalloca appropriately for msgSend variant
Feb 28 2018, 12:18 PM
compnerd closed D43842: CodeGenObjCXX: handle inalloca appropriately for msgSend variant.

SVN r326362

Feb 28 2018, 12:18 PM
compnerd committed rL326362: CodeGenObjCXX: handle inalloca appropriately for msgSend variant.
CodeGenObjCXX: handle inalloca appropriately for msgSend variant
Feb 28 2018, 12:18 PM
compnerd added a comment to D43842: CodeGenObjCXX: handle inalloca appropriately for msgSend variant.

Yeah, this is still an indirect return. I can see your point about the representation, nfortunately, I think that change is way out of scope for this. That would be a pretty large and invasive change to wire that through.

Feb 28 2018, 12:01 PM

Feb 27 2018

compnerd created D43842: CodeGenObjCXX: handle inalloca appropriately for msgSend variant.
Feb 27 2018, 4:42 PM

Feb 26 2018

compnerd accepted D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields.

If its easy enough to wire that through to the frontend as a proper diagnostic, that would be better with a test. Otherwise, this is good to continue to make progress.

Feb 26 2018, 12:12 PM

Feb 24 2018

compnerd added inline comments to D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields.
Feb 24 2018, 2:47 PM

Feb 21 2018

compnerd closed D43586: CodeGen: handle blocks correctly when inalloca'ed.

SVN r325724

Feb 21 2018, 1:52 PM
compnerd committed rC325724: CodeGen: handle blocks correctly when inalloca'ed.
CodeGen: handle blocks correctly when inalloca'ed
Feb 21 2018, 1:50 PM
compnerd committed rL325724: CodeGen: handle blocks correctly when inalloca'ed.
CodeGen: handle blocks correctly when inalloca'ed
Feb 21 2018, 1:50 PM
compnerd updated the diff for D43586: CodeGen: handle blocks correctly when inalloca'ed.

Update comment

Feb 21 2018, 11:40 AM
compnerd created D43586: CodeGen: handle blocks correctly when inalloca'ed.
Feb 21 2018, 10:20 AM

Feb 20 2018

compnerd added a comment to D43106: [RISCV] Force enable int128 for compiling long double routines.

Yeah, I think I would feel safer with this being limited to targets where we know that we have an explicit contract for __int128_t. Can you please limit this to the RISCV architecture for the time being?

Feb 20 2018, 6:51 PM
compnerd requested changes to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Please clang-format the conditional (we keep the operator on the previous line).

Feb 20 2018, 6:44 PM

Feb 19 2018

compnerd added a comment to D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

Is there a need for this given the changes for 6.0?

Feb 19 2018, 4:45 PM

Feb 17 2018

compnerd accepted D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Feb 17 2018, 1:00 PM

Feb 12 2018

compnerd accepted D43192: [GlobalMerge] Allow merging of dllexported variables.
Feb 12 2018, 10:56 AM

Feb 10 2018

compnerd closed D42614: AST: support ObjC lifetime qualifiers in MS ABI.

SVN r324701

Feb 10 2018, 10:31 AM

Feb 9 2018

compnerd accepted D42873: [llvm-objcopy] Adjust --strip-dwo behavior.
Feb 9 2018, 3:33 PM

Feb 8 2018

compnerd committed rC324701: AST: support ObjC lifetime qualifiers in MS ABI.
AST: support ObjC lifetime qualifiers in MS ABI
Feb 8 2018, 7:26 PM
compnerd committed rL324701: AST: support ObjC lifetime qualifiers in MS ABI.
AST: support ObjC lifetime qualifiers in MS ABI
Feb 8 2018, 7:26 PM

Feb 7 2018

compnerd added a comment to D42614: AST: support ObjC lifetime qualifiers in MS ABI.

@rjmccall, I've updated the approach and no longer abuse the existing decoration styles. This uses a custom namespace with artificial types to differentiate the types. I've also ensured that the parameter types do not encode the type information.

Feb 7 2018, 3:08 PM
compnerd updated the diff for D42614: AST: support ObjC lifetime qualifiers in MS ABI.

Address comments from @rjmccall

Feb 7 2018, 3:07 PM
compnerd added a comment to D43005: [ARM] Error out on .arm assembler directives on windows.

I think we should first clarify that currently the only Windows on ARM support is Windows ARM NT (Windows ARM CE still does have both modes of execution). The important thing to note here is that although the CPU supports both modes of execution, the Windows ARM NT kernel does not guarantee the current mode will be preserved (that is, if you trap into the kernel in ARM mode, you are probably going to come out in Thumb mode and fault). I agree that we should try to fix this generally rather than hardcode this to Windows ARM.

Feb 7 2018, 10:28 AM

Feb 6 2018

compnerd added inline comments to D43000: [Coroutines] Don't move stores for allocator args.
Feb 6 2018, 10:59 PM
compnerd added a comment to D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers.

@aaron.ballman, yeah, I believe that the warning is working as intended, it just so happens that at runtime things just happened to work out.

Feb 6 2018, 8:54 PM
compnerd committed rCTE324441: test: use target triple for the test.
test: use target triple for the test
Feb 6 2018, 6:30 PM
compnerd committed rL324441: test: use target triple for the test.
test: use target triple for the test
Feb 6 2018, 6:30 PM
compnerd committed rC324439: AST: support SwiftCC on MS ABI.
AST: support SwiftCC on MS ABI
Feb 6 2018, 5:57 PM
compnerd committed rL324439: AST: support SwiftCC on MS ABI.
AST: support SwiftCC on MS ABI
Feb 6 2018, 5:57 PM
compnerd closed D42768: AST: support SwiftCC on MS ABI.

SVN r324439

Feb 6 2018, 5:57 PM
compnerd closed D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.

SVN r324438

Feb 6 2018, 5:50 PM
compnerd committed rL324438: Support `#pragma comment(lib, "name")` in the frontend for ELF.
Support `#pragma comment(lib, "name")` in the frontend for ELF
Feb 6 2018, 5:49 PM
compnerd committed rC324438: Support `#pragma comment(lib, "name")` in the frontend for ELF.
Support `#pragma comment(lib, "name")` in the frontend for ELF
Feb 6 2018, 5:49 PM
compnerd added inline comments to D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.
Feb 6 2018, 4:54 PM
compnerd updated subscribers of D42768: AST: support SwiftCC on MS ABI.
Feb 6 2018, 4:52 PM
compnerd updated the diff for D42768: AST: support SwiftCC on MS ABI.

Update to what Microsoft has communicated offline

Feb 6 2018, 4:46 PM
compnerd updated the diff for D42768: AST: support SwiftCC on MS ABI.

address design changes

Feb 6 2018, 2:56 PM
compnerd updated the diff for D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.

Add additional test, update docs

Feb 6 2018, 9:30 AM
compnerd added a comment to D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.

@jhenderson I believe that the first one is what this is implementing. I believe that adding the last two as a patch following this one is preferable as that is specific to the needs for PS4, but, both of those should be possible to accommodate. I would love to see a single unified approach here, so Im happy to help get that implemented.

Feb 6 2018, 9:14 AM
compnerd accepted D42902: [compiler-rt] Workaround for endless recursion in ctzdi2.

I believe that the commit message needs to be updated for the change. This is a pretty distasteful patch IMO, but, I don't see a better solution here :-(.

Feb 6 2018, 9:09 AM

Feb 5 2018

compnerd requested changes to D42873: [llvm-objcopy] Adjust --strip-dwo behavior.

@jhenderson I believe that you are correct with the analysis of the behavior of binutils' objcopy. Definitely should have a test case for this.

Feb 5 2018, 5:11 PM
compnerd accepted D42569: [ARM] disable FPU features when using soft floating point..
Feb 5 2018, 5:08 PM