Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (341 w, 1 d)

Recent Activity

Today

compnerd committed rL364352: android: enable double-word CAS on x64.
android: enable double-word CAS on x64
Tue, Jun 25, 2:43 PM
compnerd closed D63774: android: enable double-word CAS on x86_64.

SVN r364352

Tue, Jun 25, 2:43 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.

Tue, Jun 25, 1:44 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

Move test case around

Tue, Jun 25, 1:21 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

add additional context and test case

Tue, Jun 25, 12:50 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus at it.

Tue, Jun 25, 12:47 PM · Restricted Project
compnerd created D63774: android: enable double-word CAS on x86_64.
Tue, Jun 25, 8:54 AM · Restricted Project

Sat, Jun 22

compnerd committed rG6281ccea02d3: Revert "builtins: relax __iso_volatile_{load,store}32" (authored by compnerd).
Revert "builtins: relax __iso_volatile_{load,store}32"
Sat, Jun 22, 7:57 PM
compnerd committed rL364147: Revert "builtins: relax __iso_volatile_{load,store}32".
Revert "builtins: relax __iso_volatile_{load,store}32"
Sat, Jun 22, 7:56 PM
compnerd committed rGebae85bc4a31: builtins: relax __iso_volatile_{load,store}32 (authored by compnerd).
builtins: relax __iso_volatile_{load,store}32
Sat, Jun 22, 11:57 AM
compnerd committed rL364137: builtins: relax __iso_volatile_{load,store}32.
builtins: relax __iso_volatile_{load,store}32
Sat, Jun 22, 11:57 AM

Fri, Jun 21

compnerd added inline comments to D63622: [Target] Hoist LanguageRuntime::GetDeclVendor.
Fri, Jun 21, 9:21 AM · Restricted Project

Wed, Jun 19

compnerd accepted D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..
Wed, Jun 19, 6:51 PM · Restricted Project, Restricted Project
compnerd accepted D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 11:21 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 10:19 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 8:57 AM · Restricted Project, Restricted Project

Mon, Jun 17

compnerd added a comment to D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.

Could you please add a test to ensure that Darwin defaults to the old behaviour?

Mon, Jun 17, 9:09 PM · Restricted Project
compnerd accepted D60974: Clang IFSO driver action..
Mon, Jun 17, 1:00 PM · Restricted Project, Restricted Project

Fri, Jun 14

compnerd accepted D63357: [Process] Remove unused field from HistoryThread.
Fri, Jun 14, 7:53 PM · Restricted Project
compnerd accepted D63368: [compiler-rt] Respect CMAKE_NM.
Fri, Jun 14, 7:47 PM · Restricted Project, Restricted Project
compnerd added inline comments to D63341: [llvm-lipo] Implement -thin.
Fri, Jun 14, 11:30 AM · Restricted Project
compnerd committed rG2b9f6caa71f7: build: extract LLVM distribution target handling (authored by compnerd).
build: extract LLVM distribution target handling
Fri, Jun 14, 11:27 AM
compnerd committed rL363440: build: extract LLVM distribution target handling.
build: extract LLVM distribution target handling
Fri, Jun 14, 11:25 AM
compnerd closed D62982: build: extract LLVM distribution target handling.

SVN r363440

Fri, Jun 14, 11:25 AM · Restricted Project
compnerd committed rG2874d285b9f3: build: don't attempt to run config.guess on Windows (authored by compnerd).
build: don't attempt to run config.guess on Windows
Fri, Jun 14, 9:45 AM
compnerd committed rL363420: build: don't attempt to run config.guess on Windows.
build: don't attempt to run config.guess on Windows
Fri, Jun 14, 9:44 AM

Wed, Jun 12

compnerd added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Wed, Jun 12, 7:26 PM · Restricted Project
compnerd accepted D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Wed, Jun 12, 7:23 PM · Restricted Project
compnerd added a comment to D62982: build: extract LLVM distribution target handling.

What I am imagining is basically having a variable which specifies the distribution targets, and having variables which will be constructed based upon those names (similar to how variables for the runtimes are passed today).

Wed, Jun 12, 7:21 PM · Restricted Project
compnerd added inline comments to D60974: Clang IFSO driver action..
Wed, Jun 12, 9:59 AM · Restricted Project, Restricted Project

Tue, Jun 11

compnerd added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Tue, Jun 11, 4:02 PM · Restricted Project

Mon, Jun 10

compnerd added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Mon, Jun 10, 2:53 PM · Restricted Project
compnerd accepted D63052: [Target] Remove Process::GetObjCLanguageRuntime.
Mon, Jun 10, 1:37 PM · Restricted Project
compnerd committed rG9aff1ddc14f3: ABI: reflow the table text (NFC) (authored by compnerd).
ABI: reflow the table text (NFC)
Mon, Jun 10, 9:30 AM
compnerd committed rL362961: ABI: reflow the table text (NFC).
ABI: reflow the table text (NFC)
Mon, Jun 10, 9:29 AM

Sun, Jun 9

compnerd added inline comments to D63052: [Target] Remove Process::GetObjCLanguageRuntime.
Sun, Jun 9, 12:49 PM · Restricted Project

Thu, Jun 6

compnerd created D62982: build: extract LLVM distribution target handling.
Thu, Jun 6, 2:32 PM · Restricted Project

Mon, Jun 3

compnerd accepted D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl.

Would be nice to get someone like @clayborg to chime in, but, I think that @labath also seems to think that this is fine.

Mon, Jun 3, 5:56 PM · Restricted Project
compnerd committed rG197a7c01e6bf: tools: add `llvm-nm` and `llvm-objcopy` to tools (authored by compnerd).
tools: add `llvm-nm` and `llvm-objcopy` to tools
Mon, Jun 3, 10:15 AM
compnerd committed rL362425: tools: add `llvm-nm` and `llvm-objcopy` to tools.
tools: add `llvm-nm` and `llvm-objcopy` to tools
Mon, Jun 3, 10:15 AM
compnerd closed D61082: llvm-nm and llvm-objcopy belong to toolchain.

SVN r362425

Mon, Jun 3, 10:15 AM · Restricted Project
compnerd accepted D61082: llvm-nm and llvm-objcopy belong to toolchain.
Mon, Jun 3, 10:06 AM · Restricted Project
compnerd committed rGaad5d518823b: builtins: correct function name for AEABI (authored by compnerd).
builtins: correct function name for AEABI
Mon, Jun 3, 10:06 AM
compnerd committed rL362424: builtins: correct function name for AEABI.
builtins: correct function name for AEABI
Mon, Jun 3, 10:06 AM
compnerd closed D62723: [compiler-rt][builtins] Fix typo in definition of __aeabi_fcmpun.

SVN r362424

Mon, Jun 3, 10:06 AM · Restricted Project, Restricted Project
compnerd added inline comments to D62812: [llvm] [CodeView] Move Triple::ArchType → CPUType mapping from LLDB.
Mon, Jun 3, 9:59 AM · Restricted Project

Sun, Jun 2

compnerd accepted D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.

This should get the build working again, so lets get this fixed, we can improve it later

Sun, Jun 2, 5:29 PM · Restricted Project, Restricted Project
compnerd added inline comments to D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl.
Sun, Jun 2, 5:28 PM · Restricted Project
compnerd requested changes to D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.
Sun, Jun 2, 10:47 AM · Restricted Project, Restricted Project
compnerd accepted D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.

Generally, clang-format the changes, it will catch the formatting things.

Sun, Jun 2, 10:46 AM · Restricted Project

Sat, Jun 1

compnerd added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
Sat, Jun 1, 10:02 AM · Restricted Project, Restricted Project

Fri, May 31

compnerd added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:13 PM · Restricted Project
compnerd accepted D62723: [compiler-rt][builtins] Fix typo in definition of __aeabi_fcmpun.

Oops! Nice catch. This matches the specification.

Fri, May 31, 2:55 PM · Restricted Project, Restricted Project
compnerd requested changes to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

Actually, I think that we should extend CompilerType and TypeSystem to expose Clang's knowledge of whether a type is passed in a register by means of using clang::RecordDecl::isPassInRegisters

Fri, May 31, 2:41 PM · Restricted Project, Restricted Project
compnerd accepted D62740: [MIR-Canon] Don't do vreg skip for independent instructions if there are none..
Fri, May 31, 10:10 AM · Restricted Project

Thu, May 30

compnerd accepted D62717: [MIR-Canon] Skip the first N vreg names lazily..
Thu, May 30, 10:37 PM · Restricted Project
compnerd accepted D62713: [MIR-Canon] Hardening propagateLocalCopies..

Thanks for adding the test case!

Thu, May 30, 9:31 PM · Restricted Project
compnerd accepted D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

Thanks, this looks much better.

Thu, May 30, 6:50 PM · Restricted Project, Restricted Project
compnerd added inline comments to D62713: [MIR-Canon] Hardening propagateLocalCopies..
Thu, May 30, 6:36 PM · Restricted Project
compnerd added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
Thu, May 30, 4:38 PM · Restricted Project, Restricted Project
compnerd added a reviewer for D62022: [lit] Improve globbing in Windows with long paths: thakis.
Thu, May 30, 4:38 PM · Restricted Project
compnerd added a reviewer for D62022: [lit] Improve globbing in Windows with long paths: rnk.
Thu, May 30, 4:38 PM · Restricted Project
compnerd added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Thu, May 30, 1:15 PM · Restricted Project

Wed, May 29

compnerd accepted D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode.

Sounds safe enough to me. I think that it would be nice to add a test that checks the hexagon flags as well.

Wed, May 29, 9:22 AM · Restricted Project

Tue, May 28

compnerd committed rG99e040b3c903: build: only search for the needed python type (authored by compnerd).
build: only search for the needed python type
Tue, May 28, 7:27 PM
compnerd committed rLLDB361915: build: only search for the needed python type.
build: only search for the needed python type
Tue, May 28, 7:27 PM
compnerd committed rL361915: build: only search for the needed python type.
build: only search for the needed python type
Tue, May 28, 7:27 PM
compnerd added inline comments to D62509: [Driver] Render target options (e.g. -fuse-init-array) for -fembed-bitcode.
Tue, May 28, 5:17 PM · Restricted Project
compnerd added inline comments to D62543: [MIR-Canon] Add support for rewriting VRegs that are typed but don't have an RC..
Tue, May 28, 12:00 PM · Restricted Project
compnerd accepted D62512: [X86] Fix x86-64 call *foo@tlsdesc(reg) and support R_386_TLSGOTDESC R_386_TLS_DESC_CALL.

This looks good

Tue, May 28, 11:48 AM · Restricted Project
compnerd committed rG09c2625108c8: Driver: support `/Zc:char8_t` and `/Zc:char8_t-` (authored by compnerd).
Driver: support `/Zc:char8_t` and `/Zc:char8_t-`
Tue, May 28, 11:24 AM
compnerd committed rL361859: Driver: support `/Zc:char8_t` and `/Zc:char8_t-`.
Driver: support `/Zc:char8_t` and `/Zc:char8_t-`
Tue, May 28, 11:23 AM
compnerd committed rC361859: Driver: support `/Zc:char8_t` and `/Zc:char8_t-`.
Driver: support `/Zc:char8_t` and `/Zc:char8_t-`
Tue, May 28, 11:23 AM

May 23 2019

compnerd committed rG7bbefb13ee52: Transforms: lower fadd and fsub atomicrmw instructions (authored by compnerd).
Transforms: lower fadd and fsub atomicrmw instructions
May 23 2019, 10:05 AM
compnerd closed D60679: [LowerAtomic] Lower fadd and fsub atomicrmw instructions.

SVN r361512

May 23 2019, 10:01 AM · Restricted Project
compnerd committed rL361512: Transforms: lower fadd and fsub atomicrmw instructions.
Transforms: lower fadd and fsub atomicrmw instructions
May 23 2019, 10:00 AM

May 22 2019

compnerd accepted D62155: [CMake] Copy C++ headers before configuring runtimes build.

I think that this makes sense - the one case that I had in mind is pretty convoluted and if it breaks, we can fix it then.

May 22 2019, 4:34 PM · Restricted Project, Restricted Project
compnerd accepted D62213: [ABI] Implement Windows ABI for x86_64.
May 22 2019, 4:33 PM · Restricted Project, Restricted Project
compnerd committed rG2956127f5b4e: Expression: correct relocation model for Windows (authored by compnerd).
Expression: correct relocation model for Windows
May 22 2019, 4:26 PM
compnerd closed D62273: Expression: correct relocation model for Windows.

SVN r361443

May 22 2019, 4:26 PM · Restricted Project
compnerd committed rLLDB361443: Expression: correct relocation model for Windows.
Expression: correct relocation model for Windows
May 22 2019, 4:21 PM
compnerd committed rL361443: Expression: correct relocation model for Windows.
Expression: correct relocation model for Windows
May 22 2019, 4:21 PM
compnerd created D62273: Expression: correct relocation model for Windows.
May 22 2019, 4:04 PM · Restricted Project
compnerd accepted D62269: [Runtimes] If LLVM_INCLUDE_TESTS=On depend on gtest.
May 22 2019, 2:36 PM · Restricted Project

May 21 2019

compnerd added inline comments to D62213: [ABI] Implement Windows ABI for x86_64.
May 21 2019, 2:55 PM · Restricted Project, Restricted Project
compnerd committed rGca5ed496b1ef: build: enable CMake policy 0077 (authored by compnerd).
build: enable CMake policy 0077
May 21 2019, 1:29 PM
compnerd committed rL361307: build: enable CMake policy 0077.
build: enable CMake policy 0077
May 21 2019, 1:28 PM
compnerd closed D62171: build: Enable CMake Policy 0077.

SVN r361307

May 21 2019, 1:28 PM · Restricted Project

May 20 2019

compnerd added a comment to D62171: build: Enable CMake Policy 0077.

@smeenai - not sure what you mean; you mean a clean configuration with the same set of parameters? I'll certainly do that test and expect no differences there. @hintonda - yeah, CACHE ... FORCE should do the trick for that.

May 20 2019, 9:43 PM · Restricted Project
compnerd updated the diff for D62171: build: Enable CMake Policy 0077.
May 20 2019, 9:43 PM · Restricted Project
compnerd created D62171: build: Enable CMake Policy 0077.
May 20 2019, 8:51 PM · Restricted Project
compnerd committed rGa5401e48ddc4: lldb-server: LLGS: support 32-bit on 64-bit hosts (authored by compnerd).
lldb-server: LLGS: support 32-bit on 64-bit hosts
May 20 2019, 6:24 PM
compnerd committed rLLDB361210: lldb-server: LLGS: support 32-bit on 64-bit hosts.
lldb-server: LLGS: support 32-bit on 64-bit hosts
May 20 2019, 6:23 PM
compnerd committed rL361210: lldb-server: LLGS: support 32-bit on 64-bit hosts.
lldb-server: LLGS: support 32-bit on 64-bit hosts
May 20 2019, 6:23 PM
compnerd closed D62159: LLGS: support 32-bit on 64-bit hosts.

SVN r361210

May 20 2019, 6:23 PM · Restricted Project
compnerd added a comment to D62155: [CMake] Copy C++ headers before configuring runtimes build.

The only thing that Im worried about is cross-compilation accidentally picking up the libc++ headers that are built here (e.g. building on Linux for Linux with the host libc++ headers and building libc++ as a runtime). The rest looks pretty much a substitution and addition of runtime-libcxx-headers target to the runtimes build which is fine.

May 20 2019, 4:29 PM · Restricted Project, Restricted Project
compnerd updated the diff for D62159: LLGS: support 32-bit on 64-bit hosts.

Fix inclusion

May 20 2019, 3:22 PM · Restricted Project
compnerd created D62159: LLGS: support 32-bit on 64-bit hosts.
May 20 2019, 1:39 PM · Restricted Project
compnerd added inline comments to D62155: [CMake] Copy C++ headers before configuring runtimes build.
May 20 2019, 1:36 PM · Restricted Project, Restricted Project

May 17 2019

compnerd committed rGdc1c41fb6f09: build: use clang-cl for runtimes when targeting Windows (authored by compnerd).
build: use clang-cl for runtimes when targeting Windows
May 17 2019, 1:08 PM