compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (292 w, 1 d)

Recent Activity

Fri, Jul 6

compnerd added a comment to D48993: [CMake] Give Python module install command a component name.

The install- target is created by add_llvm_install_targets, not by the component. The component is part of CMake itself, and is controlled by the CMAKE_INSTALL_DEFAULT_COMPONENT_NAME.

Fri, Jul 6, 9:54 AM

Thu, Jul 5

compnerd accepted D48568: objdump: Support newer ObjC image info flags.
Thu, Jul 5, 3:16 PM
compnerd added inline comments to D48702: objdump: Better handling of Mach-O universal binaries.
Thu, Jul 5, 3:15 PM
compnerd accepted D48861: Add OpenEmbedded vendor.
Thu, Jul 5, 3:04 PM
compnerd accepted D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp.
Thu, Jul 5, 3:03 PM
compnerd added inline comments to D48988: Debug prefix map for machine code emission.
Thu, Jul 5, 3:02 PM
compnerd accepted D48989: -fdebug-prefix-map option for cc1as.

This seems reasonable if you need the support in the assembler. However, please add a test to ensure that the paths are mapped when invoking the assembler rather than the compiler.

Thu, Jul 5, 2:52 PM
compnerd accepted D48993: [CMake] Give Python module install command a component name.
Thu, Jul 5, 2:50 PM

Mon, Jun 25

compnerd added a comment to D48568: objdump: Support newer ObjC image info flags.

Nice! I like the changes to the objdump, but, would it be possible to roundtrip the object files being added through obj2yaml and yaml2obj rather than checking in binaries?

Mon, Jun 25, 2:19 PM

Wed, Jun 20

compnerd accepted D48105: [llvm][Instrumentation] Add Call Graph Profile pass.

Thanks for the changes!

Wed, Jun 20, 9:36 PM

Tue, Jun 19

compnerd committed rL335058: docs: document CodeView directives.
docs: document CodeView directives
Tue, Jun 19, 9:52 AM

Jun 14 2018

compnerd accepted D48201: [cmake] Add linker detection for Apple platforms.

It really is unfortunate that linkers can spell version differently :-(. It would be really nice to be able to unify the linker version detection.

Jun 14 2018, 4:09 PM

Jun 13 2018

compnerd accepted D48105: [llvm][Instrumentation] Add Call Graph Profile pass.

I assume that there is/will be a different change to the frontend to enable this for users?

Jun 13 2018, 1:33 PM
compnerd committed rL334627: IR: fix documentation markup.
IR: fix documentation markup
Jun 13 2018, 10:55 AM

Jun 12 2018

compnerd added inline comments to D48105: [llvm][Instrumentation] Add Call Graph Profile pass.
Jun 12 2018, 8:32 PM
compnerd accepted D46971: [DWARF] Get RA from RA register even if it appears unused.

x86-Linux-only test is good. LG with the discussed changes.

Jun 12 2018, 8:05 PM
compnerd added inline comments to D48060: Introduce lldb-framework CMake target and centralize its logic.
Jun 12 2018, 4:30 PM
compnerd accepted D47873: [AArch64] Tighten up directives tests.

Nice cleanup! Thanks for doing this

Jun 12 2018, 4:22 PM

Jun 11 2018

compnerd accepted D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

This makes much more sense. Thanks @joerg

Jun 11 2018, 2:09 PM

Jun 7 2018

compnerd accepted D47897: Check for process_vm_readv using CheckSymbolExists.

This should be functionally identical and is much cleaner. Thanks!

Jun 7 2018, 12:56 PM

Jun 3 2018

compnerd committed rL333863: Python: adjust the include directories.
Python: adjust the include directories
Jun 3 2018, 7:12 PM
compnerd added inline comments to D46726: build: use cmake to find the libedit content.
Jun 3 2018, 6:06 PM

May 29 2018

compnerd added inline comments to D46791: Make -gsplit-dwarf generally available.
May 29 2018, 3:58 PM
compnerd added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

It would be nice if we had a test case added for this, but, seems correct to me.

May 29 2018, 3:54 PM
compnerd accepted D47381: [CMake] Use normalized Windows target triples.

@rnk - Id say something more stronger than on board for this change. I think that this is a great cleanup, makes everything much clearer and generally simplifies the model that you have to work with. I didn't look at the changes to the test very carefully (they should be mechanical in nature). The rest LGTM.

May 29 2018, 3:50 PM

May 23 2018

compnerd added a reviewer for D40221: [clang-format] Parse blocks in braced lists: benhamilton.
May 23 2018, 8:23 AM

May 22 2018

compnerd closed D46726: build: use cmake to find the libedit content.

SVN r333041

May 22 2018, 4:29 PM
compnerd committed rL333041: build: use cmake to find the libedit content.
build: use cmake to find the libedit content
May 22 2018, 4:28 PM

May 21 2018

compnerd updated the diff for D46726: build: use cmake to find the libedit content.

fix regex

May 21 2018, 2:31 PM
compnerd added inline comments to D46726: build: use cmake to find the libedit content.
May 21 2018, 2:29 PM

May 20 2018

compnerd committed rC332821: Sema: diagnose invalid catch parameter in ObjC.
Sema: diagnose invalid catch parameter in ObjC
May 20 2018, 12:32 PM
compnerd committed rL332821: Sema: diagnose invalid catch parameter in ObjC.
Sema: diagnose invalid catch parameter in ObjC
May 20 2018, 12:30 PM

May 11 2018

compnerd added inline comments to D46726: build: use cmake to find the libedit content.
May 11 2018, 11:47 AM

May 10 2018

compnerd created D46726: build: use cmake to find the libedit content.
May 10 2018, 2:12 PM

May 2 2018

compnerd committed rL331431: lit: flesh out `SubsituteCaptures` further.
lit: flesh out `SubsituteCaptures` further
May 2 2018, 9:50 PM

May 1 2018

compnerd closed D45814: Fix an assertion when -print-prog-name=.

SVN r331296

May 1 2018, 11:44 AM
compnerd committed rL331296: Driver: fix an assertion with `-print-prog-name=`.
Driver: fix an assertion with `-print-prog-name=`
May 1 2018, 11:44 AM
compnerd committed rC331296: Driver: fix an assertion with `-print-prog-name=`.
Driver: fix an assertion with `-print-prog-name=`
May 1 2018, 11:44 AM
compnerd committed rL331282: Support: assume `std::is_final` with MSVC.
Support: assume `std::is_final` with MSVC
May 1 2018, 9:50 AM
compnerd closed D46164: Support: assume `std::is_final` with MSVC.

SVN r331282

May 1 2018, 9:50 AM

Apr 27 2018

compnerd accepted D45814: Fix an assertion when -print-prog-name=.

Do you have commit access or do you need someone to commit this on your behalf?

Apr 27 2018, 9:09 AM

Apr 26 2018

compnerd created D46164: Support: assume `std::is_final` with MSVC.
Apr 26 2018, 5:58 PM
compnerd added a comment to D45814: Fix an assertion when -print-prog-name=.

I'm torn on this. The other -print options will perform the validation implicitly at the higher level before calling the inner functions. It is certainly reasonable to support that, but, for the common path, this check seems unnecessary (and this function is used elsewhere in clang). There is a similar problem that exists with -print-file-name=. We should probably fix both at the same time. Can you also please add a test case for this?

Apr 26 2018, 5:52 PM

Apr 22 2018

compnerd accepted D31275: [lldb] Fix lldb build on musl.
Apr 22 2018, 7:38 PM · Restricted Project
compnerd accepted D45935: Add dump method for selectors.

LGTM

Apr 22 2018, 7:37 PM

Apr 19 2018

compnerd added inline comments to D45319: [Atomics] warn about misaligned atomic accesses using libcalls.
Apr 19 2018, 5:48 PM · Restricted Project
compnerd accepted D45771: [Driver] Support for -save-stats in AddGoldPlugin..

Some cleanup suggestions included, but I like the change overall.

Apr 19 2018, 5:44 PM
compnerd committed rL330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Apr 19 2018, 4:20 PM
compnerd committed rC330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Apr 19 2018, 4:20 PM

Apr 16 2018

compnerd committed rL330161: Revert "build: reserve `--color-diagnostics` for lld".
Revert "build: reserve `--color-diagnostics` for lld"
Apr 16 2018, 3:00 PM
compnerd committed rL330158: build: reserve `--color-diagnostics` for lld.
build: reserve `--color-diagnostics` for lld
Apr 16 2018, 2:09 PM

Apr 14 2018

compnerd added a comment to D45639: [Driver] Support default libc++ library location on Darwin.

I'm not sure I understand this. The proper location for libc++ on the darwin layout is in the SDK, not relative to the driver. The default behaviour is similar to cross-compiling, and with a (derived) SDK. This definitely needs to be reviewed by @dexonsmith

Apr 14 2018, 3:41 PM
compnerd added a comment to D45383: Limit types of builtins that can be redeclared..

Snipping bits from va_defs.h:

Apr 14 2018, 3:39 PM · Restricted Project
compnerd accepted D45196: [libc++abi] Replace __sync_* functions with __libcpp_atomic_* functions..

I definitely like the clean up. Not sure I understand the motivation for the __libcpp_relaxed_store, but I suppose thats because its a copy from libc++ where it may be more useful.

Apr 14 2018, 3:32 PM
compnerd accepted D45319: [Atomics] warn about misaligned atomic accesses using libcalls.

Sorry for the delay, didn't see the changes earlier.

Apr 14 2018, 11:23 AM · Restricted Project

Apr 13 2018

compnerd committed rCXX330045: support: add missing locale stubs for android L, M.
support: add missing locale stubs for android L, M
Apr 13 2018, 11:18 AM
compnerd committed rL330045: support: add missing locale stubs for android L, M.
support: add missing locale stubs for android L, M
Apr 13 2018, 11:18 AM

Apr 12 2018

compnerd accepted D45590: [Support] Fix building for Windows on ARM.
Apr 12 2018, 7:41 PM
compnerd added a comment to D45383: Limit types of builtins that can be redeclared..

I know that the Windows SDK definitely declares the __va_start function. Did you try building something like swift against the Windows SDK with this change?

Apr 12 2018, 11:18 AM · Restricted Project

Apr 11 2018

compnerd committed rL329866: Lex: make `clang::Preprocessor::macros` work on MSVC.
Lex: make `clang::Preprocessor::macros` work on MSVC
Apr 11 2018, 4:50 PM
compnerd committed rC329866: Lex: make `clang::Preprocessor::macros` work on MSVC.
Lex: make `clang::Preprocessor::macros` work on MSVC
Apr 11 2018, 4:50 PM

Apr 5 2018

compnerd added inline comments to D44236: [llvm-objcopy] Switch over to using TableGen for parsing arguments.
Apr 5 2018, 8:39 AM

Apr 4 2018

compnerd accepted D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.
Apr 4 2018, 8:06 PM · Restricted Project

Apr 2 2018

compnerd committed rC329025: CodeGenCXX: support PreserveMostCC in MS ABI.
CodeGenCXX: support PreserveMostCC in MS ABI
Apr 2 2018, 3:30 PM
compnerd committed rL329025: CodeGenCXX: support PreserveMostCC in MS ABI.
CodeGenCXX: support PreserveMostCC in MS ABI
Apr 2 2018, 3:30 PM

Mar 28 2018

compnerd requested changes to D44494: [libunwind] Support __register_frame with a full .eh_frame section.

I really don't like this approach. I think that we should introduce a different entry point for this behavior rather than saying that we go through the existing interface. Having a reference to the .eh_frame_hdr seems better, as it would be better to make use of that optimization and we already have handling for that in libunwind.

Mar 28 2018, 1:39 PM

Mar 22 2018

compnerd committed rL328211: vim: rename `singlethread` to `syncscope`.
vim: rename `singlethread` to `syncscope`
Mar 22 2018, 9:43 AM

Mar 21 2018

compnerd added a comment to D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros.

I may be a bit biased but I agree with @bob.wilson and @steven_wu. The current names are better from the user’s perspective. GCC’s build is a very bad example as it has runtime components built as part of it (libgcc). When building any code, even in a Canadian cross-compile, the target will always be what you are running on. The preprocessor macros are part of the code that you are building for a given target. The association with the command line option makes it more obvious what it is going to use to determine the value. Having a pithy name should also be considered a design goal. Recreating new terminology only muddles the problem.

Mar 21 2018, 5:42 PM
compnerd committed rL328170: vim: add `dso_local` and `dso_preemptable` keywords.
vim: add `dso_local` and `dso_preemptable` keywords
Mar 21 2018, 4:49 PM

Mar 20 2018

compnerd added inline comments to D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.
Mar 20 2018, 3:56 PM · Restricted Project
compnerd added a reviewer for D44671: [libcxx] Enable static libcxxabi linking on Darwin: dexonsmith.

I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS.

Mar 20 2018, 3:40 PM
compnerd committed rL328007: Basic: support PreserveMost and PreserveAll on Windows ARM.
Basic: support PreserveMost and PreserveAll on Windows ARM
Mar 20 2018, 10:37 AM
compnerd committed rC328007: Basic: support PreserveMost and PreserveAll on Windows ARM.
Basic: support PreserveMost and PreserveAll on Windows ARM
Mar 20 2018, 10:36 AM

Mar 19 2018

compnerd added a comment to D44641: [ObjCARC] Add funclet token to ARC marker.

LGTM, I'd give @majnemer a day or so before committing.

Mar 19 2018, 2:30 PM
compnerd added a comment to D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics.

What happens in the case that you have a variadic in C code marked with __forceinline? Does that also cause a warning with MSVC?

Mar 19 2018, 2:09 PM · Restricted Project

Mar 12 2018

compnerd closed D44327: ObjCARC: teach the cloner about funclets.

SVN r327336. Addressed comments in SVN r327351, because I forgot to incorporate them in the first try.

Mar 12 2018, 5:01 PM
compnerd committed rL327351: ObjCARC: address review comments from majnemer.
ObjCARC: address review comments from majnemer
Mar 12 2018, 4:51 PM
compnerd committed rL327336: ObjCARC: teach the cloner about funclets.
ObjCARC: teach the cloner about funclets
Mar 12 2018, 2:51 PM

Mar 9 2018

compnerd updated the diff for D44327: ObjCARC: teach the cloner about funclets.

Use the BB colorizer to detect the token. Fortunately, there is no BB removal/splitting happening here, so there is no state to maintain.

Mar 9 2018, 4:17 PM
compnerd committed rC327183: test: repair windows build after SVN r327105.
test: repair windows build after SVN r327105
Mar 9 2018, 3:03 PM
compnerd committed rL327183: test: repair windows build after SVN r327105.
test: repair windows build after SVN r327105
Mar 9 2018, 3:03 PM
compnerd accepted D43797: [CMake] Copy the generated __config header into build directory.
Mar 9 2018, 2:37 PM
compnerd added a reviewer for D44327: ObjCARC: teach the cloner about funclets: ahatanak.
Mar 9 2018, 2:08 PM
compnerd created D44327: ObjCARC: teach the cloner about funclets.
Mar 9 2018, 2:08 PM

Mar 8 2018

compnerd closed D44278: CodeGen: simplify and validate exception personalities.

SVN r327105

Mar 8 2018, 11:09 PM
compnerd committed rL327105: CodeGen: simplify and validate exception personalities.
CodeGen: simplify and validate exception personalities
Mar 8 2018, 11:09 PM
compnerd committed rC327105: CodeGen: simplify and validate exception personalities.
CodeGen: simplify and validate exception personalities
Mar 8 2018, 11:09 PM
compnerd closed D44240: utils: add a helper class to lit for captured substitutions.

SVN r327082

Mar 8 2018, 4:12 PM
compnerd committed rL327082: utils: add a helper class to lit for captured substitutions.
utils: add a helper class to lit for captured substitutions
Mar 8 2018, 4:08 PM
compnerd updated the diff for D44278: CodeGen: simplify and validate exception personalities.

add more context

Mar 8 2018, 3:54 PM
compnerd created D44278: CodeGen: simplify and validate exception personalities.
Mar 8 2018, 3:47 PM

Mar 7 2018

compnerd added inline comments to D44236: [llvm-objcopy] Switch over to using TableGen for parsing arguments.
Mar 7 2018, 9:39 PM
compnerd added a comment to D44225: Fix identification of COFF executable files.

@rnk, I like the idea of pushing the mapping behavior to the single use in llvm-pdbutil and removing this overload.

Mar 7 2018, 5:41 PM
compnerd created D44240: utils: add a helper class to lit for captured substitutions.
Mar 7 2018, 5:41 PM

Mar 1 2018

compnerd accepted D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC.

Awesome, thanks, this makes me feel much more comfortable.

Mar 1 2018, 11:25 AM
compnerd committed rL326469: Driver: hoist `-fno-rtti-data` to a driver flag.
Driver: hoist `-fno-rtti-data` to a driver flag
Mar 1 2018, 11:17 AM
compnerd committed rC326469: Driver: hoist `-fno-rtti-data` to a driver flag.
Driver: hoist `-fno-rtti-data` to a driver flag
Mar 1 2018, 11:17 AM

Feb 28 2018

compnerd accepted D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC.

Ugh, really not a fan of this change.

Feb 28 2018, 3:13 PM
compnerd added inline comments to D43913: Delay writing the PDB build id until just before file commit..
Feb 28 2018, 3:12 PM
compnerd committed rL326381: build: add the ability to create a symlink for dsymutil.
build: add the ability to create a symlink for dsymutil
Feb 28 2018, 3:05 PM