compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (228 w, 6 d)

Recent Activity

Fri, Apr 28

compnerd committed rL301658: IR: fix some doxygen grammar (NFC).
IR: fix some doxygen grammar (NFC)
Fri, Apr 28, 10:31 AM
compnerd committed rL301657: COFF: actually synthesize CONST imports properly.
COFF: actually synthesize CONST imports properly
Fri, Apr 28, 10:19 AM

Thu, Apr 27

compnerd committed rL301614: COFF Import: expose both symbols.
COFF Import: expose both symbols
Thu, Apr 27, 9:42 PM
compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

@majnemer thats the idea :-). Passing either triple to clang would give the right behaviour (clang will normalize the triple before passing it to cc1).

Thu, Apr 27, 6:34 PM
compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

Yes, the idea is that the textual IR uses the correct triple, unless it is overidden at the command line.

Thu, Apr 27, 3:28 PM

Mon, Apr 24

compnerd requested changes to D32450: [libunwind] Add 64-bit SPARC support.
Mon, Apr 24, 5:52 PM
compnerd requested changes to D32109: [Driver] Limit .exe extension addition to Windows hosts.

Why not always replace the extension? Windows doesnt require the .exe suffix IIRC.

Mon, Apr 24, 5:42 PM
compnerd requested changes to D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple.

Is this to actually get the correct GCC search dir? Your test doesnt really test anything AFAICT, as it is just invoking clang with a target that it would accept anyways.

Mon, Apr 24, 5:40 PM
compnerd created D32460: ADT: handle special case of ARM environment for SuSE.
Mon, Apr 24, 5:37 PM
compnerd added a comment to D32427: Fix float abi for SUSE ARM triples.

I think that you should mutate the environment in the canonicalisation phase of the triple. That will allow you to use armv7-suse-linux-gnueabi and armv7-suse-linux-gnueabihf in the frontend, but have the backend always get armv7-suse-linux-gnueabihf.

Mon, Apr 24, 5:27 PM
compnerd committed rL301252: ProfileData: clean up some stale declarations (NFC).
ProfileData: clean up some stale declarations (NFC)
Mon, Apr 24, 2:18 PM
compnerd committed rL301237: Avoid unnecessary copies in some for loops.
Avoid unnecessary copies in some for loops
Mon, Apr 24, 1:14 PM

Fri, Apr 21

compnerd committed rL301013: COFF: add support for CONSTANT exports.
COFF: add support for CONSTANT exports
Fri, Apr 21, 11:18 AM

Thu, Apr 20

compnerd committed rL300909: Sema: protect against ObjC++ typo-correction failure.
Sema: protect against ObjC++ typo-correction failure
Thu, Apr 20, 3:36 PM
compnerd committed rL300908: Parse: cleanup some bleeding whitespace.
Parse: cleanup some bleeding whitespace
Thu, Apr 20, 3:36 PM
compnerd accepted D32192: Enable leak sanitizer builds for darwin.
Thu, Apr 20, 2:10 PM

Wed, Apr 19

compnerd accepted D18478: python bindings: expose the clang version string.

This would ideally wait for the change that @jbcoe has in the works to enable python 3, but the change itself is fine.

Wed, Apr 19, 6:19 PM
compnerd accepted D32160: [ARM] Rename HW div feature to HW div Thumb. NFCI..

Thanks for doing this cleanup!

Wed, Apr 19, 6:18 PM
compnerd accepted D31568: Add Python 3 support to clang.cindex.

I think it would've been nice to split this up into the changes for map/filter rather than group it together. But sure, this looks reasonable.

Wed, Apr 19, 6:16 PM · Restricted Project
compnerd accepted D32213: [Sema] Use MSVC inner class behavior on Itanium.
Wed, Apr 19, 6:13 PM
compnerd requested changes to D32192: Enable leak sanitizer builds for darwin.

Please add a test case. The change itself looks reasonable.

Wed, Apr 19, 6:12 PM

Tue, Apr 18

compnerd accepted D30904: Allow suppressing host and target info in VersionPrinter.

This is opt-out by default, so it shouldn't have any impact on users by default. When building for tooling, this should allow smaller builds for those.

Tue, Apr 18, 1:32 PM

Fri, Apr 14

compnerd accepted D32071: [CMake][libunwind] Fix the -target and -gcc-toolchain flag handling.
Fri, Apr 14, 10:00 AM

Thu, Apr 13

compnerd accepted D32005: [ARM] Check for correct HW div when lowering divmod.

Minor comments on the test, but LGTM otherwise.

Thu, Apr 13, 8:01 AM

Fri, Apr 7

compnerd committed rL299800: Toolchains: remove crtbegin on xwindows.
Toolchains: remove crtbegin on xwindows
Fri, Apr 7, 1:59 PM
compnerd committed rL299774: Sema: prevent __declspec(naked) use on x64.
Sema: prevent __declspec(naked) use on x64
Fri, Apr 7, 8:26 AM

Thu, Apr 6

compnerd committed rL299728: COFF: support the /appcontainer flag.
COFF: support the /appcontainer flag
Thu, Apr 6, 4:20 PM

Wed, Apr 5

compnerd accepted D31737: [libc++] Respect Windows Store app CRT restrictions.
Wed, Apr 5, 9:15 PM
compnerd accepted D31716: [Builtins] Fix div0 error in udivsi3.
Wed, Apr 5, 8:04 PM
compnerd committed rL299591: AddressSpace: fix DWARF based unwinding handling on Android.
AddressSpace: fix DWARF based unwinding handling on Android
Wed, Apr 5, 2:42 PM
compnerd committed rL299575: Fix invalid memory access on android x86.
Fix invalid memory access on android x86
Wed, Apr 5, 11:45 AM
compnerd accepted D31674: [AsmParser]Emit an error if a macro has two (or more) parameters sharing the same name.

Please address the issue that @rengolin pointed out. There is no reason to have an explicit triple here, as the test is agnostic. Just drop the nop in the macro.

Wed, Apr 5, 10:19 AM
compnerd requested changes to D31716: [Builtins] Fix div0 error in udivsi3.
Wed, Apr 5, 10:17 AM

Mon, Apr 3

compnerd accepted D31640: [CMake][libunwind] Use -nodefaultlibs for CMake checks.

Sure, using the same flags sounds reasonable.

Mon, Apr 3, 9:01 PM

Mar 29 2017

compnerd added inline comments to D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.
Mar 29 2017, 11:18 AM

Mar 28 2017

compnerd accepted D31448: [Builtin] Unxfail tests for armhf.
Mar 28 2017, 6:21 PM

Mar 26 2017

compnerd added a comment to D31372: Support Microsoft mangling of swift calling convention methods.

I think you misunderstood what I meant. I meant that you should change the mangling scheme to put the symbol into a C++ __Swift::swift_cc namespace since that is reserved. That would mean that this enumeration would not be touched at all.

Mar 26 2017, 4:47 PM
compnerd accepted D31362: [llvm-readobj] Prefer ILT to IAT for reading COFF imports.
Mar 26 2017, 9:27 AM
compnerd added a comment to D31375: Add docs for libunwind.

What happens when you try building it in tree?

Mar 26 2017, 9:24 AM
compnerd requested changes to D31372: Support Microsoft mangling of swift calling convention methods.

I've sent an email to Microsoft to add this to their scheme. In the mean time, if you want to support this, we should namespace the symbol to __swift::swift_cc:: instead of the usual mangling. That would be compatible with their tools and allow us to use the custom calling convention.

Mar 26 2017, 9:21 AM

Mar 24 2017

compnerd added inline comments to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.
Mar 24 2017, 10:20 AM

Mar 23 2017

compnerd added a comment to D26959: llvm-strings - dumping strings from LLVM bitcode.

As previously mentioned, if this absolutely requires that the file not be treated opaquely, then we should be putting this functionality into another tool. Perhaps llvm-bc would be a good home for this. I'd really rather LLVM-strings be kept simple and treat all input as opaque.

Mar 23 2017, 8:00 AM

Mar 22 2017

compnerd committed rL298550: c++filt: support COFF import thunks.
c++filt: support COFF import thunks
Mar 22 2017, 2:27 PM
compnerd requested changes to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.

Some of the implementations are not going to build in thumb1 mode, but would in thumb2, which is why we didnt do this uniformly. I think we need to preserve that, or rewrite the functions.

Mar 22 2017, 11:54 AM
compnerd accepted D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373).
Mar 22 2017, 11:51 AM
compnerd added a comment to D30904: Allow suppressing host and target info in VersionPrinter.

I think that @chandlerc is suggesting making it a CMake option (see the option function in CMake) to provide documentation for this for users. I think that is a pretty reasonable ask, as it aids in discoverability of this.

Mar 22 2017, 11:26 AM

Mar 21 2017

compnerd added a comment to D30904: Allow suppressing host and target info in VersionPrinter.

I think that the idea that you propose is good, however, I think that may be better to do as a follow up. This would get the immediate benefit for the tooling, and we can work out a nicer way to expose the information to the other users. Making it something which each app does means that we would need to change all the apps as well, which would be a much larger change.

Mar 21 2017, 1:01 PM

Mar 20 2017

compnerd added a reviewer for D30904: Allow suppressing host and target info in VersionPrinter: klimek.
Mar 20 2017, 4:20 PM
compnerd edited reviewers for D30904: Allow suppressing host and target info in VersionPrinter, added: chandlerc, compnerd; removed: mgorny.
Mar 20 2017, 4:18 PM

Mar 14 2017

compnerd requested changes to D30938: builtins: Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA..

I really think that we shouldnt introduce the USE_* macros, opting to re-organise the code (separate change) and then using the appropriate macros. It avoids the layer of indirection which makes it easier for others to follow what is going on.

Mar 14 2017, 11:10 AM
compnerd committed rL297744: DarwinParser: include limits.
DarwinParser: include limits
Mar 14 2017, 8:30 AM

Mar 8 2017

compnerd committed rL297291: DARWF: silence some warnings about conversions.
DARWF: silence some warnings about conversions
Mar 8 2017, 8:15 AM

Mar 7 2017

compnerd accepted D30696: Improve readability and correctness of the OS specific libunwind bits..

Not sure if I see the movement as being a real improvement. However, it is no worse than before, and not having the explicit list of targets is a huge win.

Mar 7 2017, 9:52 AM

Mar 2 2017

compnerd committed rL296769: Serialization: use the PCH chain to check PCH mode.
Serialization: use the PCH chain to check PCH mode
Mar 2 2017, 9:49 AM

Feb 20 2017

compnerd closed D29967: Get class property selectors from property decl if it exists.

SVN r295683

Feb 20 2017, 3:57 PM
compnerd committed rL295683: Sema: use PropertyDecl for property selector.
Sema: use PropertyDecl for property selector
Feb 20 2017, 3:57 PM

Feb 19 2017

compnerd committed rL295620: Driver: inline a single caller of a function (NFC).
Driver: inline a single caller of a function (NFC)
Feb 19 2017, 2:02 PM

Feb 18 2017

compnerd committed rL295561: Revert "threading_support: make __thread_sleep_for be alertable".
Revert "threading_support: make __thread_sleep_for be alertable"
Feb 18 2017, 11:40 AM
compnerd committed rL295560: test: silence warnings on clang under clang-cl.
test: silence warnings on clang under clang-cl
Feb 18 2017, 11:40 AM
compnerd committed rL295559: math: add type promoting template definition on MSVCRT.
math: add type promoting template definition on MSVCRT
Feb 18 2017, 11:40 AM
compnerd committed rL295558: test: explicitly size enumeration.
test: explicitly size enumeration
Feb 18 2017, 11:40 AM

Feb 17 2017

compnerd committed rL295510: math: fix typo in macro.
math: fix typo in macro
Feb 17 2017, 3:20 PM
compnerd committed rL295511: test: prevent incorrect quoting of paths.
test: prevent incorrect quoting of paths
Feb 17 2017, 3:20 PM
compnerd committed rL295509: cmath: Use c99 math on a new enough msvcrt.
cmath: Use c99 math on a new enough msvcrt
Feb 17 2017, 3:20 PM
compnerd accepted D29967: Get class property selectors from property decl if it exists.

Ah, I had missed the -verify option on the test. Yes, that makes sense. Ternary may have flowed the conditional code better. Do you need someone to commit this on your behalf?

Feb 17 2017, 9:01 AM

Feb 16 2017

compnerd added a comment to D29967: Get class property selectors from property decl if it exists.

I think Im misunderstanding something. How does the test actually test what you are changing?

Feb 16 2017, 6:21 PM
compnerd committed rL295330: math: correct the MSVCRT condition.
math: correct the MSVCRT condition
Feb 16 2017, 7:59 AM
compnerd committed rL295329: threading_support: make __thread_sleep_for be alertable.
threading_support: make __thread_sleep_for be alertable
Feb 16 2017, 7:59 AM

Feb 15 2017

compnerd accepted D29882: [Builtin][ARM] #ifdef ARM vfp tests and cpu_model_tests.
Feb 15 2017, 3:08 PM
compnerd requested changes to D29967: Get class property selectors from property decl if it exists.

Please add a test for this.

Feb 15 2017, 3:06 PM

Feb 13 2017

compnerd accepted D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 13 2017, 7:57 PM
compnerd committed rL294958: config: disable thread safety analysis on COFF.
config: disable thread safety analysis on COFF
Feb 13 2017, 7:38 AM
compnerd committed rL294957: math: actually pull the declarations/overloads into std.
math: actually pull the declarations/overloads into std
Feb 13 2017, 7:38 AM
compnerd committed rL294956: test: mark another test as requiring pthreads.
test: mark another test as requiring pthreads
Feb 13 2017, 7:38 AM

Feb 12 2017

compnerd added inline comments to D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 12 2017, 2:35 PM
compnerd committed rL294918: math: follow up to SVN r294902.
math: follow up to SVN r294902
Feb 12 2017, 1:54 PM
compnerd committed rL294917: test: use char32_t rather than wchar_t.
test: use char32_t rather than wchar_t
Feb 12 2017, 1:54 PM
compnerd committed rL294909: llvm-readobj: process FreeBSD core notes.
llvm-readobj: process FreeBSD core notes
Feb 12 2017, 11:07 AM
compnerd committed rL294902: math: pull more C functions from std.
math: pull more C functions from std
Feb 12 2017, 9:49 AM
compnerd committed rL294903: test: mark requirement for pthread test.
test: mark requirement for pthread test
Feb 12 2017, 9:49 AM
compnerd committed rL294901: test: squelch -Wreturn-type error.
test: squelch -Wreturn-type error
Feb 12 2017, 9:49 AM
compnerd committed rL294899: cmath: adjust math forwards for Windows.
cmath: adjust math forwards for Windows
Feb 12 2017, 8:55 AM

Feb 11 2017

compnerd accepted D29869: [Builtin][ARM] Fix subsf3vfp for non-HF target.

*sigh* Thanks for fixing this. Please ask @hans to cherry-pick this to 4.0 as well.

Feb 11 2017, 8:53 PM
compnerd added inline comments to D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 11 2017, 3:18 PM
compnerd committed rL294877: CodeGen: use # as the comment leader for ARC marker.
CodeGen: use # as the comment leader for ARC marker
Feb 11 2017, 3:14 PM
compnerd committed rL294872: CodeGen: annotate ObjC ARC functions with ABI constraints.
CodeGen: annotate ObjC ARC functions with ABI constraints
Feb 11 2017, 1:46 PM
compnerd committed rL294871: test: ignore some warnings in test code (NFC).
test: ignore some warnings in test code (NFC)
Feb 11 2017, 1:45 PM
compnerd committed rL294855: docs: update docs for objc_storeStrong behaviour.
docs: update docs for objc_storeStrong behaviour
Feb 11 2017, 9:35 AM
compnerd committed rL294854: CodeGen: rename variables to adhere to naming convention.
CodeGen: rename variables to adhere to naming convention
Feb 11 2017, 9:35 AM
compnerd committed rL294853: Sema: simplify conditional execution (NFC).
Sema: simplify conditional execution (NFC)
Feb 11 2017, 9:35 AM

Feb 10 2017

compnerd committed rL294808: vim: add `returned` keyword.
vim: add `returned` keyword
Feb 10 2017, 4:08 PM
compnerd closed D29648: Make NoLeadingAddr work on more than just MachO.

This was committed, sorry, dont have the revision off hand.

Feb 10 2017, 2:13 PM

Feb 9 2017

compnerd committed rL294720: test: XFAIL windows for non-portable test.
test: XFAIL windows for non-portable test
Feb 9 2017, 11:03 PM
compnerd committed rL294719: test: fix test under Windows.
test: fix test under Windows
Feb 9 2017, 11:02 PM
compnerd committed rL294716: test: allow -target usage on Windows.
test: allow -target usage on Windows
Feb 9 2017, 10:36 PM
compnerd committed rL294705: docs: add some documentation for building on Windows.
docs: add some documentation for building on Windows
Feb 9 2017, 8:09 PM
compnerd committed rL294698: __threading_support: fix windows build.
__threading_support: fix windows build
Feb 9 2017, 7:01 PM
compnerd added a reviewer for D26722: [WebAssembly] Add skeleton MC support for the Wasm container format: compnerd.
Feb 9 2017, 3:03 PM
compnerd committed rL294619: test: adjust the test for the BSD format.
test: adjust the test for the BSD format
Feb 9 2017, 12:18 PM
compnerd committed rL294615: Object: pad out BSD archive members to 8-bytes.
Object: pad out BSD archive members to 8-bytes
Feb 9 2017, 11:41 AM