Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (445 w, 18 h)

Recent Activity

Sat, Jun 19

compnerd added a reverting change for rGfb32de9e97af: Re-Revert "DirectoryWatcher: add an implementation for Windows": rGdecfad7d8e9b: Revert "Re-Revert "DirectoryWatcher: add an implementation for Windows"".
Sat, Jun 19, 9:20 AM
compnerd committed rGdecfad7d8e9b: Revert "Re-Revert "DirectoryWatcher: add an implementation for Windows"" (authored by compnerd).
Revert "Re-Revert "DirectoryWatcher: add an implementation for Windows""
Sat, Jun 19, 9:20 AM

Fri, Jun 18

compnerd requested review of D104557: X86: introduce a new `FrameBuilder` type.
Fri, Jun 18, 11:06 AM · Restricted Project

Thu, Jun 17

compnerd added a comment to D103539: RISCV: adjust handling of relocation emission for RISCV.

e70d4994ea9eb44ba5a86c5073ac83cf500aabdd should have the suggestions incorporated.

Thu, Jun 17, 11:33 AM · Restricted Project
compnerd abandoned D103174: RISCV: honour `.option relax` in assembly.
Thu, Jun 17, 11:31 AM · Restricted Project
compnerd added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

Interesting, are the logs from the runs available? I have run the test ~10000 times locally and its been stable. Perhaps the logs can show what is going on.

Thu, Jun 17, 11:29 AM · Restricted Project
compnerd updated the diff for D104473: RISCV: clean up target expression handling.

Address feedback from @MaskRay

Thu, Jun 17, 10:46 AM · Restricted Project
compnerd added inline comments to D104473: RISCV: clean up target expression handling.
Thu, Jun 17, 10:26 AM · Restricted Project
compnerd requested review of D104473: RISCV: clean up target expression handling.
Thu, Jun 17, 10:19 AM · Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Thu, Jun 17, 9:37 AM · Restricted Project
compnerd added a comment to D103539: RISCV: adjust handling of relocation emission for RISCV.

I'll address the clean ups in a follow up.

Thu, Jun 17, 9:33 AM · Restricted Project

Wed, Jun 16

compnerd added inline comments to D104328: [libc++] Always build libc++ and libc++abi with -fPIC.
Wed, Jun 16, 8:14 AM · Restricted Project, Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Wed, Jun 16, 8:08 AM · Restricted Project

Tue, Jun 15

compnerd committed rG17bdc0ff6f2e: X86: balance the frame prologue and epilogue on Win64 (authored by compnerd).
X86: balance the frame prologue and epilogue on Win64
Tue, Jun 15, 8:15 PM
compnerd closed D104246: X86: balance the frame prologue and epilogue on Win64.
Tue, Jun 15, 8:15 PM · Restricted Project
compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.
Tue, Jun 15, 3:03 PM · Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Tue, Jun 15, 3:02 PM · Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Tue, Jun 15, 10:10 AM · Restricted Project
compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.
Tue, Jun 15, 9:40 AM · Restricted Project
compnerd committed rGa6948da86ad7: DirectoryWatcher: close a possible window of race on Windows (authored by compnerd).
DirectoryWatcher: close a possible window of race on Windows
Tue, Jun 15, 9:16 AM

Mon, Jun 14

compnerd added inline comments to D104246: X86: balance the frame prologue and epilogue on Win64.
Mon, Jun 14, 8:23 PM · Restricted Project
compnerd updated the diff for D104246: X86: balance the frame prologue and epilogue on Win64.
Mon, Jun 14, 8:05 PM · Restricted Project
compnerd requested review of D104246: X86: balance the frame prologue and epilogue on Win64.
Mon, Jun 14, 11:07 AM · Restricted Project
compnerd committed rG8c8dbc10825c: X86: pass swift_async context in R14 on Win64 (authored by compnerd).
X86: pass swift_async context in R14 on Win64
Mon, Jun 14, 11:03 AM
compnerd updated subscribers of D103539: RISCV: adjust handling of relocation emission for RISCV.
Mon, Jun 14, 9:49 AM · Restricted Project
compnerd retitled D103539: RISCV: adjust handling of relocation emission for RISCV from WIP: try to repair RISCV handling of paired relocations to RISCV: adjust handling of relocation emission for RISCV.
Mon, Jun 14, 9:49 AM · Restricted Project
compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.
Mon, Jun 14, 9:48 AM · Restricted Project
compnerd committed rG5b5833b9e092: SelectionDAG: repair the Windows build (authored by compnerd).
SelectionDAG: repair the Windows build
Mon, Jun 14, 8:25 AM

Sun, Jun 13

compnerd committed rGe03be2efe564: unwind: allow building with GCC (authored by compnerd).
unwind: allow building with GCC
Sun, Jun 13, 2:46 PM
compnerd closed D104176: [libunwind] Define and use portable macro for checking for presence of ASAN.
Sun, Jun 13, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
compnerd accepted D104176: [libunwind] Define and use portable macro for checking for presence of ASAN.

LGTM; do you need someone to commit this on your behalf?

Sun, Jun 13, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
compnerd committed rG527a1821e6f8: DirectoryWatcher: also wait for the notifier thread (authored by compnerd).
DirectoryWatcher: also wait for the notifier thread
Sun, Jun 13, 10:59 AM

Sat, Jun 12

compnerd added a reverting change for rG0ec1cf13f2a4: Revert "DirectoryWatcher: add an implementation for Windows": rG76f1baa7875a: Revert "Revert "DirectoryWatcher: add an implementation for Windows"".
Sat, Jun 12, 9:42 AM
compnerd committed rG76f1baa7875a: Revert "Revert "DirectoryWatcher: add an implementation for Windows"" (authored by compnerd).
Revert "Revert "DirectoryWatcher: add an implementation for Windows""
Sat, Jun 12, 9:42 AM
compnerd added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

I was able to play around with this further yesterday evening. You are correct - the issue is the load preventing the watcher thread from spinning up. I was able to reproduce this issue and resolve it by adding in a synchronization point (boolean + mutex + condition variable) before returning the directory watcher to ensure that the RDC was setup. I looked through all the previous failure cases as well as the one that I was finally able to reproduce - it is always the initial notification that we missed (because the thread took too long to come up). In the process I did do a few minor alterations as well. I would like to get additional testing over the weekend on the bots so people aren't impacted if there turns out to be some other subtle threading issue. However, running this in a tight loop locally seemed to be pretty stable (switching the builds to a SSD locally did help uncover the flakiness) so I am confident that this should be safe. I'm happy to address any additional comments in post-commit review.

Sat, Jun 12, 9:37 AM · Restricted Project
compnerd added a comment to D104183: [compiler-rt] Do not force thumb mode directive in arm/sync-ops.h.

Some platforms (e.g. WoA) do require thumb-only compilation. Can we conditionalize this on whether we are building for ARMv6 or not?

Sat, Jun 12, 9:16 AM · Restricted Project
compnerd accepted D102763: [LLParser] Remove outdated deplibs.

Given the thread on the mailing list, I think that this is fine as long as there is an accompanying test to validate the bitcode deserialization continues to work. Id wait a few days more to see if @dexonsmith has an opinion.

Sat, Jun 12, 9:13 AM · Restricted Project, Restricted Project
compnerd requested changes to D104176: [libunwind] Define and use portable macro for checking for presence of ASAN.
Sat, Jun 12, 9:09 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 11

compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.

2 remaining failures KI:

  • debug_line encoding is not relaxable
Fri, Jun 11, 9:35 AM · Restricted Project

Thu, Jun 10

compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.

3 failures left now. KI:

  • 6B relocations are not implemented
  • debug_line references aren't correctly emitted
Thu, Jun 10, 9:37 AM · Restricted Project

Tue, Jun 8

compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.

Down to 6 failures to explore.

Tue, Jun 8, 10:27 AM · Restricted Project

Mon, Jun 7

compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.

7 failures to look into; need to still replace the use of RelaxAll which would also improve the test pass rate.

Mon, Jun 7, 1:26 PM · Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Mon, Jun 7, 8:37 AM · Restricted Project

Fri, Jun 4

compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Fri, Jun 4, 3:16 PM · Restricted Project
compnerd planned changes to D103174: RISCV: honour `.option relax` in assembly.
Fri, Jun 4, 3:09 PM · Restricted Project
compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.

Closer to passing tests (9 more failures to understand). It matches gas' behaviour better, is more uniformly behaved.

Fri, Jun 4, 10:59 AM · Restricted Project

Thu, Jun 3

compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Thu, Jun 3, 3:38 PM · Restricted Project
compnerd accepted D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

I’d say wait a day or so to make sure that @ldionne doesn’t have any concerns, but this seems like it should be safe. Rebasing a pointer seems like a useful enough thing and this don’t impact the public interfaces.

Thu, Jun 3, 9:14 AM · Restricted Project, Restricted Project
compnerd updated the diff for D103539: RISCV: adjust handling of relocation emission for RISCV.
Thu, Jun 3, 8:35 AM · Restricted Project
compnerd added inline comments to D103539: RISCV: adjust handling of relocation emission for RISCV.
Thu, Jun 3, 8:35 AM · Restricted Project

Wed, Jun 2

compnerd requested review of D103539: RISCV: adjust handling of relocation emission for RISCV.
Wed, Jun 2, 10:49 AM · Restricted Project
compnerd updated the diff for D103174: RISCV: honour `.option relax` in assembly.
Wed, Jun 2, 10:01 AM · Restricted Project
compnerd added inline comments to D103174: RISCV: honour `.option relax` in assembly.
Wed, Jun 2, 9:59 AM · Restricted Project
compnerd added a comment to D103174: RISCV: honour `.option relax` in assembly.

Shouldn't this be covered by option-relax.s already though? Is that test wrong?

Wed, Jun 2, 9:56 AM · Restricted Project

Wed, May 26

compnerd added a comment to D103174: RISCV: honour `.option relax` in assembly.

I don't understand the diff rendering on differential. The change is literally the 3 lines being added to RISCVTargetELFStreamer::emitDirectiveOptionRelax. The raw diff does not show any changes to the other lines around it.

Wed, May 26, 8:49 AM · Restricted Project
compnerd requested review of D103174: RISCV: honour `.option relax` in assembly.
Wed, May 26, 8:48 AM · Restricted Project
compnerd accepted D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.
Wed, May 26, 8:38 AM · Restricted Project, Restricted Project, Restricted Project
compnerd accepted D103002: [libunwind] Inform ASan that resumption is noreturn.

Thanks for adding that comment - I think that the cleanup routine may be confusing otherwise.

Wed, May 26, 8:37 AM · Restricted Project, Restricted Project

May 21 2021

compnerd committed rG6c6b3e3afe7c: RISCV: add a few deprecated aliases for CSRs (authored by compnerd).
RISCV: add a few deprecated aliases for CSRs
May 21 2021, 1:55 PM
compnerd closed D101919: RISCV: add a few deprecated aliases for CSRs.
May 21 2021, 1:55 PM · Restricted Project
compnerd added inline comments to D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.
May 21 2021, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2021

compnerd added inline comments to D101919: RISCV: add a few deprecated aliases for CSRs.
May 19 2021, 2:13 PM · Restricted Project
compnerd added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

Hmm, actually looking at gcc, it appears that this is actually matching semantics with gcc:
https://github.com/riscv/riscv-gcc/blob/03cb20e5433cd8e65af6a1a6baaf3fe4c72785f6/gcc/config/riscv/riscv.c#L4590-L4593

May 19 2021, 1:51 PM · Restricted Project
compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

Ping; it seems like there aren't any objections, can I get a final sign off on the change?

May 19 2021, 1:43 PM · Restricted Project
compnerd added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

If the user is passing along -mno-relax encoding that in the object file isn't expensive, and it doesn't harm anything. In fact, the user _could_ at a later point pass in -mrelax to the assembler to override the beahviour (with a warning). But what @raj.khem states about the non-IAS case should hold - -mno-relax should get passed along to the assembler along with the hint in the object file.

May 19 2021, 1:41 PM · Restricted Project
compnerd requested changes to D102763: [LLParser] Remove outdated deplibs.

While I can appreciate the removal of deprecated functionality, I think that some sort of mention of this on llvm-dev at least 2 weeks prior to the removal is warranted. It impacts any downstream projects which may still be relying on a feature.

May 19 2021, 9:13 AM · Restricted Project, Restricted Project

May 12 2021

compnerd accepted D99707: Remove "Rewrite Symbols" from codegen pipeline.
May 12 2021, 11:19 AM · Restricted Project

May 11 2021

compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

@jrtc27 ping

May 11 2021, 7:52 AM · Restricted Project

May 7 2021

compnerd committed rGd319005a3746: lit: revert 134b103fc0f3a995d76398bf4b029d72bebe8162 (authored by compnerd).
lit: revert 134b103fc0f3a995d76398bf4b029d72bebe8162
May 7 2021, 10:23 AM
compnerd added a reverting change for rG134b103fc0f3: lit: Limit number of processes on Windows to 32.: rGd319005a3746: lit: revert 134b103fc0f3a995d76398bf4b029d72bebe8162.
May 7 2021, 10:23 AM

May 6 2021

compnerd accepted D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.
May 6 2021, 10:05 AM · Restricted Project, Restricted Project

May 5 2021

compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

@jrtc27 - I'm open to improving the diagnostics, but this plumbs the functionality.

May 5 2021, 10:32 AM · Restricted Project
compnerd updated the diff for D101919: RISCV: add a few deprecated aliases for CSRs.
May 5 2021, 10:31 AM · Restricted Project
compnerd committed rGba5c122647c7: RISSCV: clang-format RISC-V AsmParser (NFC) (authored by compnerd).
RISSCV: clang-format RISC-V AsmParser (NFC)
May 5 2021, 10:17 AM
compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

I don't disagree about the ease of updating that code (and, in fact, I've created PRs #241, #242, #243 on the project). However, the issue here is more than just the single project.

May 5 2021, 9:44 AM · Restricted Project
compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

Sure, but even if they were to deprecate them, that would be years before code would really be even nudged towards removal. In the mean time, this prevents the use of the IAS for building software, which is rather unfortunate. I think that supporting the aliases and adding a deprecation warning on use seems to be better. That way, we can actually both encourage people to update the code as well as remain compatible.

May 5 2021, 9:39 AM · Restricted Project
compnerd added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

Hmm, perhaps we should be special casing these and adding diagnostics then. The thing is, that binutils still carries the aliases, and generally, LLVM has strived for compatibility with binutils so that it can remain a drop-in replacement.

May 5 2021, 9:27 AM · Restricted Project
compnerd requested review of D101919: RISCV: add a few deprecated aliases for CSRs.
May 5 2021, 9:19 AM · Restricted Project

Apr 27 2021

compnerd added a comment to D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

While I think that this is fine in general, I'm not sure why the shift operator needs to be replaced. Could you shed some light on that?

Apr 27 2021, 3:43 PM · Restricted Project, Restricted Project
compnerd accepted D99484: Use `GNUInstallDirs` to support custom installation dirs..

This is a pretty straightforward cleanup now, which adds additional functionality by deferring work to CMake. There are a couple of minor points about inconsistent quoting but this seems good otherwise.

Apr 27 2021, 3:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 1 2021

compnerd added inline comments to D99484: Use `GNUInstallDirs` to support custom installation dirs..
Apr 1 2021, 8:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 31 2021

compnerd accepted D99690: [builtins] Build for arm64_32 for watchOS (Darwin).

Thanks!

Mar 31 2021, 7:36 PM · Restricted Project
compnerd accepted D99697: [CMake] Remove {LIBCXX,LIBCXXABI,LIBUNWIND}_INSTALL_PREFIX.

Thanks @phosek; I've not accepted as libc++abi or libc++, as I want to ensure that @ldionne doesn't rely on this functionality.

Mar 31 2021, 7:36 PM · Restricted Project, Restricted Project, Restricted Project
compnerd added reviewers for D99484: Use `GNUInstallDirs` to support custom installation dirs.: compnerd, beanz.
Mar 31 2021, 8:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd added inline comments to D99484: Use `GNUInstallDirs` to support custom installation dirs..
Mar 31 2021, 8:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 30 2021

compnerd added inline comments to D99574: [ARM] [COFF] Properly produce cross-section relative relocations.
Mar 30 2021, 8:38 AM · Restricted Project
compnerd added inline comments to D99575: [ARM] Clarify a comment regarding AArch64. NFC..
Mar 30 2021, 8:31 AM · Restricted Project
compnerd added inline comments to D99484: Use `GNUInstallDirs` to support custom installation dirs..
Mar 30 2021, 8:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 13 2021

compnerd added inline comments to D98367: [libcxxabi] Use cxx-headers target to consume libcxx headers.
Mar 13 2021, 5:57 PM · Restricted Project
compnerd committed rGc9fce5f0c3a8: X86: adjust the windows 64 calling convention for Swift (authored by compnerd).
X86: adjust the windows 64 calling convention for Swift
Mar 13 2021, 4:59 PM
compnerd accepted D98586: [lld-macho][nfc] Move list of section names into InputSection.h.

I don't think that LC_FUNCTION_STARTS would create an actual section.

Mar 13 2021, 2:22 PM · Restricted Project, Restricted Project

Mar 9 2021

compnerd accepted D98205: [builtins] Fix ABI-incompatibility with GCC for floating-point compare.
Mar 9 2021, 8:42 AM · Restricted Project

Mar 8 2021

compnerd added a comment to D98129: [CMake][runtimes] Add file level dependency to merge_archives commands.

Im afraid I dont understand the purpose of this change. libunwind isn't meant to be merged into libc++/libc++abi. The reasoning for libc++ to support merging libc++abi doesn't really apply to libunwind IMO. Can you please elaborate what exactly the reasoning for this is?

Mar 8 2021, 10:43 AM · Restricted Project, Restricted Project

Mar 2 2021

compnerd accepted D97166: [libcxx] [docs] Update docs about how to build for Windows.

Thanks for the updates!

Mar 2 2021, 8:43 AM · Restricted Project
compnerd accepted D97762: [RISCV] fixes cross unwinding failure.

Ah right, the !RISCV -> RISCV case. This makes sense to commit to fix the immediate issue.

Mar 2 2021, 8:39 AM · Restricted Project, Restricted Project

Mar 1 2021

compnerd accepted D80690: [RISCV] Support libunwind for riscv32.

This is fine for now, but in the future, for such changes, please split this up into a series of patches. The clean ups for the named constants and clean up for floating point handling could have been separate changes which would have reduced the overall size of the changes and focused the patch specifically to adding support for rv32.

Mar 1 2021, 1:30 PM · Restricted Project, Restricted Project
compnerd added inline comments to D97166: [libcxx] [docs] Update docs about how to build for Windows.
Mar 1 2021, 1:23 PM · Restricted Project

Feb 22 2021

compnerd added inline comments to D97166: [libcxx] [docs] Update docs about how to build for Windows.
Feb 22 2021, 2:26 PM · Restricted Project
compnerd accepted D93003: [libunwind] unw_* alias fixes for ELF and Mach-O.
Feb 22 2021, 2:22 PM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2021

compnerd accepted D96130: Correct swift_bridge duplicate attribute warning logic.

Thanks!

Feb 10 2021, 3:36 PM · Restricted Project