Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (405 w, 6 d)

Recent Activity

Thu, Sep 17

compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address feedback

Thu, Sep 17, 9:52 AM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Thu, Sep 17, 9:30 AM · Restricted Project

Wed, Sep 16

compnerd accepted D87803: [lld-macho] Ignore `-mllvm` and its argument.
Wed, Sep 16, 4:33 PM · Restricted Project
compnerd accepted D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

Thanks!

Wed, Sep 16, 4:32 PM · Restricted Project, Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.
Wed, Sep 16, 4:20 PM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Change diagnostics for conflicting swift_name, add a test case

Wed, Sep 16, 4:18 PM · Restricted Project
compnerd updated subscribers of D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Wed, Sep 16, 2:38 PM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Wed, Sep 16, 1:47 PM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address everything but warning

Wed, Sep 16, 12:04 PM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Wed, Sep 16, 12:02 PM · Restricted Project
compnerd committed rG77a01d9498a7: Sema: add support for `__attribute__((__swift_bridge__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_bridge__))`
Wed, Sep 16, 10:56 AM
compnerd closed D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Wed, Sep 16, 10:56 AM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address feedback from @aaron.ballman

Wed, Sep 16, 9:29 AM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Wed, Sep 16, 8:43 AM · Restricted Project
compnerd requested changes to D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

I think that tracking the segment length should be okay. It’s a total overhead of 8 bytes, which is only allocated once, however, the naming here is egregiously bad. This is the segment length and not the DSO length nor the DSO mapped length (which may actually be larger or smaller based on the load segment layout).

Wed, Sep 16, 7:46 AM · Restricted Project, Restricted Project

Tue, Sep 15

compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Tue, Sep 15, 1:52 PM · Restricted Project
compnerd updated the diff for D87532: Sema: add support for `__attribute__((__swift_bridge__))`.

Address feedback

Tue, Sep 15, 1:48 PM · Restricted Project
compnerd added inline comments to D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Tue, Sep 15, 1:30 PM · Restricted Project
compnerd requested review of D87720: Sema: add support for `__attribute__((__swift_private__))`.
Tue, Sep 15, 1:27 PM · Restricted Project
compnerd committed rG7d26d6a1b062: Sema: add support for `__attribute__((__swift_bridged_typedef__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_bridged_typedef__))`
Tue, Sep 15, 1:16 PM
compnerd closed D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Tue, Sep 15, 1:16 PM · Restricted Project
compnerd added inline comments to D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Tue, Sep 15, 9:55 AM · Restricted Project

Mon, Sep 14

compnerd requested review of D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Mon, Sep 14, 4:19 PM · Restricted Project
compnerd updated the diff for D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
  • make the attribute inheritable
  • add a test case for inheritance
  • add a test case for C++ type alias
Mon, Sep 14, 2:32 PM · Restricted Project
compnerd added inline comments to D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Mon, Sep 14, 2:31 PM · Restricted Project
compnerd retitled D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))` from Sema: add support for `__attribute__((__swift_typedef_bridged__))` to Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Mon, Sep 14, 12:57 PM · Restricted Project
compnerd updated the diff for D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
  • Add additional test case that was requested
Mon, Sep 14, 11:06 AM · Restricted Project
compnerd updated the diff for D87532: Sema: add support for `__attribute__((__swift_bridge__))`.

Address some feedback from @aaron.ballman

Mon, Sep 14, 9:59 AM · Restricted Project
compnerd added inline comments to D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Mon, Sep 14, 9:58 AM · Restricted Project
compnerd updated the diff for D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.

Add additional test case

Mon, Sep 14, 9:04 AM · Restricted Project
compnerd committed rG916b43403588: Sema: add support for `__attribute__((__swift_objc_members__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_objc_members__))`
Mon, Sep 14, 8:37 AM
compnerd closed D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Mon, Sep 14, 8:37 AM · Restricted Project
compnerd added inline comments to D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Mon, Sep 14, 8:28 AM · Restricted Project
compnerd added inline comments to D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Mon, Sep 14, 8:12 AM · Restricted Project

Sun, Sep 13

compnerd accepted D87591: [docs] Document LLVM_EXTERNALIZE_DEBUGINFO CMake option.
Sun, Sep 13, 5:08 PM · Restricted Project

Fri, Sep 11

compnerd abandoned D4161: compiler-rt: add support for building for Windows.

The make based build was long ago deprecated.

Fri, Sep 11, 3:47 PM
compnerd committed rG43e6c59f1c1f: docs: add a newline to appease Sphinx (authored by compnerd).
docs: add a newline to appease Sphinx
Fri, Sep 11, 3:09 PM
compnerd updated the diff for D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.

Address feedback

Fri, Sep 11, 2:57 PM · Restricted Project
compnerd committed rGf5ab5b20fb2a: Sema: add support for `__attribute__((__swift_error__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_error__))`
Fri, Sep 11, 2:21 PM
compnerd closed D87331: Sema: add support for `__attribute__((__swift_error__))`.
Fri, Sep 11, 2:21 PM · Restricted Project
compnerd accepted D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

LGTM.

Fri, Sep 11, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Fri, Sep 11, 1:12 PM · Restricted Project
compnerd added reviewers for D87534: Sema: introduce `__attribute__((__swift_name__))`: rjmccall, doug.gregor.
Fri, Sep 11, 1:11 PM · Restricted Project
compnerd requested review of D87534: Sema: introduce `__attribute__((__swift_name__))`.
Fri, Sep 11, 11:05 AM · Restricted Project
compnerd requested review of D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Fri, Sep 11, 10:57 AM · Restricted Project
compnerd added inline comments to D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Fri, Sep 11, 10:52 AM · Restricted Project
compnerd updated the diff for D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.

address feedback from @aaron.ballman and @gribozavr2

Fri, Sep 11, 10:48 AM · Restricted Project
compnerd added a comment to D87331: Sema: add support for `__attribute__((__swift_error__))`.

Discussed this with @aaron.ballman offline; he is okay with this since this is not going to permit incorrect code through without a diagnostic, even if it is not the most clear and the attribute wont be accidentally ignored. We can add more diagnostics as a follow up if it is useful.

Fri, Sep 11, 10:27 AM · Restricted Project

Thu, Sep 10

compnerd added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 4:07 PM · Restricted Project
compnerd added inline comments to D87331: Sema: add support for `__attribute__((__swift_error__))`.
Thu, Sep 10, 1:41 PM · Restricted Project
compnerd updated the diff for D87331: Sema: add support for `__attribute__((__swift_error__))`.

Address @gribozavr2's comments

Thu, Sep 10, 8:48 AM · Restricted Project
compnerd added inline comments to D87331: Sema: add support for `__attribute__((__swift_error__))`.
Thu, Sep 10, 8:45 AM · Restricted Project

Wed, Sep 9

compnerd added inline comments to D87331: Sema: add support for `__attribute__((__swift_error__))`.
Wed, Sep 9, 12:35 PM · Restricted Project
compnerd updated the diff for D87331: Sema: add support for `__attribute__((__swift_error__))`.

Address feedback from @aaron.ballman

Wed, Sep 9, 10:45 AM · Restricted Project
compnerd added inline comments to D87331: Sema: add support for `__attribute__((__swift_error__))`.
Wed, Sep 9, 10:44 AM · Restricted Project
compnerd requested review of D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`.
Wed, Sep 9, 10:11 AM · Restricted Project
compnerd requested review of D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Wed, Sep 9, 10:07 AM · Restricted Project
compnerd accepted D86748: [libunwind] Bare-metal DWARF: set dso_base to 0.

Yes, sorry I wasn't clear about that, but you understood correctly. I was suggesting using -1 as the search all, since it doesn't make sense as a DSO base. Minor comment about a possible constexpr improvement, but doesn't require a re-review.

Wed, Sep 9, 10:01 AM · Restricted Project, Restricted Project
compnerd added a comment to D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode.

I was thinking more the SjLj backend. I am okay with an additional option, but this currently would force enable the SEH backend.

Wed, Sep 9, 9:59 AM · Restricted Project, Restricted Project

Tue, Sep 8

compnerd added a comment to D87199: [lld-macho] Implement support for PIC.

Is there a funnel point that we know that all the rebase entries will pass through to ensure that we catch them rather than adding them at a couple of sites?

Tue, Sep 8, 7:38 PM · Restricted Project
compnerd added a comment to D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode.

It is definitely possible to disable SEH via /EHs- though

Tue, Sep 8, 7:26 PM · Restricted Project, Restricted Project
compnerd added a comment to D86748: [libunwind] Bare-metal DWARF: set dso_base to 0.

Why not use -1 as the indicator instead of 0?

Tue, Sep 8, 7:21 PM · Restricted Project, Restricted Project
compnerd added a comment to D86766: [libunwind] Fix a few libunwind includes.

This seems relatively harmless, not sure if its valuable though.

Tue, Sep 8, 7:18 PM · Restricted Project, Restricted Project
compnerd updated the diff for D87331: Sema: add support for `__attribute__((__swift_error__))`.
  • correct typos
  • apply clang-format changes
  • const correct a few declarations.
Tue, Sep 8, 4:05 PM · Restricted Project
compnerd requested review of D87331: Sema: add support for `__attribute__((__swift_error__))`.
Tue, Sep 8, 2:49 PM · Restricted Project
compnerd committed rGf4ac79a364f2: Sema: extract a check for `isCFError` (NFC) (authored by compnerd).
Sema: extract a check for `isCFError` (NFC)
Tue, Sep 8, 1:27 PM
compnerd added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

The change itself is fine, but what about downstream projects which define the option? Will that trigger a warning?

Tue, Sep 8, 1:10 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 4

compnerd accepted D87099: fix symbol printing on windows.

LGTM with the name change.

Fri, Sep 4, 9:06 PM · Restricted Project

Thu, Aug 27

compnerd added a comment to D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode.

I don't think that this is entirely true. I believe it is possible to disable SEH with cl, so I think that it is better to conditionalize it as if defined(__SEH__) || defined(_SEH) since IIRC, _SEH is the define that cl uses.

Thu, Aug 27, 1:10 PM · Restricted Project, Restricted Project

Aug 21 2020

compnerd accepted D86041: RFC [libunwind] Convert the register restore functions to C functions.

Sounds good to me; LGTM with the rephrased commit message.

Aug 21 2020, 8:51 AM · Restricted Project, Restricted Project
compnerd accepted D86102: [libunwind] Ensure enough alignment for unw_cursor_t for SEH build configurations .
Aug 21 2020, 8:50 AM · Restricted Project, Restricted Project
compnerd accepted D86254: [libunwind] Minor fixes in libunwind.

Please ensure that the fix goes into 11 before release (CC: @hans), but the remainder of the change is fine.

Aug 21 2020, 8:50 AM · Restricted Project, Restricted Project

Aug 20 2020

compnerd accepted D86181: [lld-macho] Implement -ObjC.
Aug 20 2020, 10:20 AM · Restricted Project
compnerd accepted D86255: [libunwind] Factor out getInfoFromFdeCie. NFCI..
Aug 20 2020, 9:50 AM · Restricted Project, Restricted Project
compnerd added a comment to D86254: [libunwind] Minor fixes in libunwind.

Can you please verify that findUnwindSectionsByPhdr was not exposed previously? This seems like it could be an ABI break.

Aug 20 2020, 9:40 AM · Restricted Project, Restricted Project
compnerd added inline comments to D86102: [libunwind] Ensure enough alignment for unw_cursor_t for SEH build configurations .
Aug 20 2020, 9:38 AM · Restricted Project, Restricted Project
compnerd added a comment to D86041: RFC [libunwind] Convert the register restore functions to C functions.

I think that the confusing part is that it is not that they are C functions, they are still assembly, but with C calling convention. I think that you should state that in the description as it currently reads as though they are written in C, which they are not.

Aug 20 2020, 9:35 AM · Restricted Project, Restricted Project

Aug 17 2020

compnerd added a comment to D86041: RFC [libunwind] Convert the register restore functions to C functions.

The idea itself is reasonable. The summary description is very confusing would you mind reworking that? Could you check what happens for the jumpto member? Ideally it would just be an alias for the function to avoid a frame setup and unnecessary jump. I think that is the only thing that really stands out of needing work in the implementation.

Aug 17 2020, 11:18 AM · Restricted Project, Restricted Project

Aug 11 2020

compnerd accepted D85701: [lld-macho] Support -rpath.

LGTM with the renaming of the local variable. Thanks for implementing this (it was the next item I wanted to add)!

Aug 11 2020, 8:32 PM · Restricted Project

Aug 10 2020

compnerd added inline comments to D85550: [lld-macho] Implement -force_load.
Aug 10 2020, 9:08 AM · Restricted Project

Aug 6 2020

compnerd added inline comments to D85081: [lld-macho] Support dynamic linking of thread-locals.
Aug 6 2020, 10:11 AM · Restricted Project
compnerd added inline comments to D85255: [lld-macho] Generate ObjC symbols from .tbd files.
Aug 6 2020, 10:09 AM · Restricted Project
compnerd accepted D85402: [lld-macho] Avoid unnecessary shared_ptr in DylibFile ctor.
Aug 6 2020, 10:02 AM · Restricted Project
compnerd accepted D85403: [lld-macho] Add error handling for malformed TBD files.

Good idea

Aug 6 2020, 10:00 AM · Restricted Project

Aug 5 2020

compnerd accepted D85080: [lld-macho] Support static linking of thread-locals.
Aug 5 2020, 12:00 PM · Restricted Project
compnerd accepted D85153: [lld-macho] Add .tbd support for frameworks.
Aug 5 2020, 8:51 AM · Restricted Project
compnerd added inline comments to D85255: [lld-macho] Generate ObjC symbols from .tbd files.
Aug 5 2020, 8:47 AM · Restricted Project
compnerd committed rG0ccda7c2326e: MachO: support `-syslibroot` (authored by compnerd).
MachO: support `-syslibroot`
Aug 5 2020, 8:42 AM
compnerd closed D82252: MachO: support `-syslibroot`.
Aug 5 2020, 8:42 AM · Restricted Project, Restricted Project, lld
compnerd accepted D85242: [AArch64] [Windows] Error out on unsupported symbol locations.

This looks fantastic! I'm really liking the better diagnostics. The only thing I'd change is the "symbol kind %0 unsupported on COFF targets". I think that "relocation variant" is more precise than "symbol kind". Thanks for improving this.

Aug 5 2020, 8:40 AM · Restricted Project

Aug 4 2020

compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Aug 4 2020, 1:28 PM · Restricted Project, Restricted Project, lld
compnerd updated the diff for D82252: MachO: support `-syslibroot`.
Aug 4 2020, 9:41 AM · Restricted Project, Restricted Project, lld

Aug 3 2020

compnerd accepted D85172: Teach SROA to handle allocas with more than one dbg.declare..
Aug 3 2020, 5:47 PM · Restricted Project, debug-info
compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Aug 3 2020, 5:41 PM · Restricted Project, Restricted Project, lld
compnerd abandoned D77697: libc++: adjust modulemap for non-modular C.

Given that the original motivation here was to help with NetBSD, and the submodule visibility flag handling unblocks NetBSD, I think that I will hold off on this unless some other motivation arises.

Aug 3 2020, 9:58 AM · Restricted Project
compnerd added inline comments to D85080: [lld-macho] Support static linking of thread-locals.
Aug 3 2020, 9:40 AM · Restricted Project
compnerd accepted D85079: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled.
Aug 3 2020, 9:24 AM · Restricted Project

Aug 1 2020

compnerd requested review of D82252: MachO: support `-syslibroot`.
Aug 1 2020, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd planned changes to D82252: MachO: support `-syslibroot`.
Aug 1 2020, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd updated the diff for D82252: MachO: support `-syslibroot`.

Address review feedback

Aug 1 2020, 9:37 AM · Restricted Project, Restricted Project, lld