Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (493 w, 4 d)

Tue, May 24

compnerd committed rGb159108bc5eb: Sema: adjust assertion to account for deduced types (authored by compnerd).
Sema: adjust assertion to account for deduced types
Tue, May 24, 10:50 AM · Restricted Project, Restricted Project
Tue, May 24, 10:50 AM · Restricted Project, Restricted Project

Fri, May 20

compnerd updated the diff for D126093: Sema: adjust assertion to account for deduced types.

git-clang-format

Fri, May 20, 3:56 PM · Restricted Project, Restricted Project
compnerd requested review of D126093: Sema: adjust assertion to account for deduced types.
Fri, May 20, 2:39 PM · Restricted Project, Restricted Project
Herald added a project to D111199: [Clang][LLVM][Attr] support btf_type_tag attribute: Restricted Project.

The sema portions of this change are still causing an issue. Although the revert (rGf95bd18b5faa6a5af4b5786312c373c5b2dce687) and the subsequent re-application in rG3466e00716e12e32fdb100e3fcfca5c2b3e8d784 addressed the debug info issue, the Sema issue remains.

Fri, May 20, 11:53 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

This seems reasonable to me. I think that a bit more exposition in the commit message is warranted though: explain why/how they are useful (i.e. they can be useful to validating the driver behaviour for path handling).

Thu, May 12, 1:49 PM · Restricted Project, Restricted Project

Wed, May 4

compnerd added a comment to D124895: [Object] Fix updating darwin archives.

I wonder if we can just pay a penalty and simplify this to always just check the first member unconditionally.

Wed, May 4, 10:24 AM · Restricted Project, Restricted Project

Thanks!

Wed, May 4, 10:22 AM · Restricted Project, Restricted Project

Sun, May 1

Sun, May 1, 2:34 PM · Restricted Project, Restricted Project
Sun, May 1, 2:34 PM · Restricted Project, Restricted Project

Sat, Apr 30

compnerd committed rG24ba1302b38b: AArch64: modify Swift async frame record storage on Windows (authored by compnerd).
AArch64: modify Swift async frame record storage on Windows
Sat, Apr 30, 9:24 AM · Restricted Project, Restricted Project
Sat, Apr 30, 9:24 AM · Restricted Project, Restricted Project

Apr 26 2022

compnerd requested review of D124498: AArch64: change the location of the Swift async frame record.
Apr 26 2022, 8:16 PM · Restricted Project, Restricted Project

Apr 25 2022

compnerd committed rG07513605b223: CODE_OWNERS: update information for builtins (authored by compnerd).
CODE_OWNERS: update information for builtins
Apr 25 2022, 8:38 AM · Restricted Project, Restricted Project
Apr 25 2022, 8:38 AM · Restricted Project, Restricted Project
compnerd added a comment to D124263: CODE_OWNERS: update information for builtins.

Happy to help, thanks to Howard for the many years of stewardship!

Apr 25 2022, 8:17 AM · Restricted Project, Restricted Project

Apr 23 2022

Sure, the argument of the cache hits is definitely reasonable - I'm not a fan of the naming, but can understand the desire to not rename all the variables across all the projects.

Apr 23 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

compnerd requested review of D124263: CODE_OWNERS: update information for builtins.
Apr 22 2022, 7:50 AM · Restricted Project, Restricted Project

Apr 21 2022

My apologies for missing that. I will be creating a patch to remove this then and other references.

I believe that the comment may be referring to the algorithm rather than the implementation itself as the book provides assembly listings for PPC.

The LLVM Foundation legal counsel has advised us that it violates copyright.

Apr 21 2022, 3:48 PM · Restricted Project, Restricted Project

Unfortunately, this patch violates copyright of the The PowerPC Compiler Writer's Guide. Please revert this patch, remove the copyrighted code, and you can submit a new patch for the other changes. For future patches that use guides with copyright, please consult with the LLVM Foundation board before committing. Thank you!

If this request is related to "// Translated from Figure 3-40 of The PowerPC Compiler Writer's Guide" in the code, then I think it should apply to the very first commit
fd089990f76ec6392dbd0138ab874d90c632d2a4 (2009) by @ddunbar .

This patch merely copied this old comment. I don't think I am the appropriate one to take any action here.

My apologies for missing that. I will be creating a patch to remove this then and other references.

Apr 21 2022, 2:24 PM · Restricted Project, Restricted Project

Apr 16 2022

compnerd committed rG2696d82fa0c3: Windows: correct iteration of additional search paths (authored by compnerd).
Windows: correct iteration of additional search paths
Apr 16 2022, 6:01 PM · Restricted Project

Mar 16 2022

compnerd added a comment to D121497: Lex: add support for `{,u}i128` Microsoft extension.

I don't have an example module sadly. It was something that I ran into with Swift code import the WinSDK module defined in https://github.com/apple/swift/blob/main/stdlib/public/Platform/winsdk.modulemap.

Mar 16 2022, 6:34 PM · Restricted Project, Restricted Project

Mar 15 2022

compnerd added a comment to D121497: Lex: add support for `{,u}i128` Microsoft extension.

This was something that I was hitting an issue with. In particular, it was a module build for a module which pulled in intsafe.h. Now, given that it is a preprocessor macro, it would stand to reason that it will normally be dropped and thus won't matter if the frontend doesn't actually support a 128-bit type. However, with a module, we would attempt to process the expression. I do admit it is on a slightly more tenuous ground as Microsoft may somehow do something different.

Mar 15 2022, 2:30 PM · Restricted Project, Restricted Project

Mar 14 2022

Mar 14 2022, 4:32 PM · Restricted Project, Restricted Project

Seems reasonable, though I'm not a fan of the variable names - they seem a bit difficult to read due to no separation (e.g., %fs-src-root or %fs_src_root vs %fssrcroot)

Mar 14 2022, 4:30 PM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2022

@compnerd the windows bot says

```[110/8000] Building ASM object lib\Support\CMakeFiles\LLVMSupport.dir\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm.obj
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30136 for x64

cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
cl : Command line warning D9024 : unrecognized source file type 'C:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\Support\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm', object file assumed
cl : Command line warning D9027 : source file 'C:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\Support\BLAKE3\blake3_avx512_x86-64_windows_msvc.asm' ignored
cl : Command line warning D9021 : no action performed```

Do you have a hint what is going wrong, is the .asm file extension not correct for passing them to the compiler?

Mar 12 2022, 11:45 AM · Restricted Project, Restricted Project

Mar 11 2022

compnerd requested review of D121497: Lex: add support for `{,u}i128` Microsoft extension.
Mar 11 2022, 3:03 PM · Restricted Project, Restricted Project

Mar 10 2022

lldb/ObjectFile,Disassembler: read some state from the executable
Mar 10 2022, 1:43 PM · Restricted Project

Mar 9 2022

compnerd committed rGf52b5a852a4b: lldb/ObjectFile: reflow a comment (NFC) (authored by compnerd).
lldb/ObjectFile: reflow a comment (NFC)
Mar 9 2022, 10:48 AM · Restricted Project
compnerd committed rGc31f0a00503a: AArch64: correct epilogue/prologue emission for swift async (authored by compnerd).
AArch64: correct epilogue/prologue emission for swift async
Mar 9 2022, 10:42 AM · Restricted Project

Mar 4 2022

compnerd committed rGb5491dd30792: ObjectFile: add a case for `EM_RISCV` (authored by compnerd).
ObjectFile: add a case for `EM_RISCV`
Mar 4 2022, 1:55 PM · Restricted Project

Feb 15 2022

I believe that the break after ( in CMake is counter the style of the rest of the project. I'd recommend against it.

Feb 15 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

I'd like to see at least https://reviews.llvm.org/D108416#inline-1146215, https://reviews.llvm.org/D108416#inline-1146214, and https://reviews.llvm.org/D108416#inline-1146209 addressed pre-commit. Would be nice to have the other ones resolved as well, but they are more stylistic.

Feb 15 2022, 8:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Feb 15 2022, 8:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 7 2022

compnerd requested changes to D108416: [llvm-libgcc] initial commit.
Feb 7 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 31 2022

Jan 31 2022, 10:07 AM · Restricted Project
Jan 31 2022, 10:07 AM · Restricted Project
compnerd added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jan 31 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2022

Jan 10 2022, 3:22 PM · Restricted Project
Jan 10 2022, 8:44 AM · Restricted Project, Restricted Project

Jan 7 2022

compnerd added inline comments to D116722: [clang] Verify ssp buffer size is a valid integer.
Jan 7 2022, 10:19 AM · Restricted Project

Jan 5 2022

compnerd added a comment to D116689: [libunwind][libcxxabi] Use object libraries in the build.

Using the TARGET_OBJECTS: generator seems better. However, I also have concerns over using the shared library objects. At least for Windows, reuse of the objects meant for a shared object is not really correct. This is non-portable at best, and incorrect at worse. I would rather that we just introduce a proper target that we use can for embedding into another library (which may or may not expose its interfaces from the library that integrates it).

Jan 5 2022, 1:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 4 2022

compnerd requested changes to D111457: [test] Add lit helper for windows paths.
Jan 4 2022, 7:56 AM · Restricted Project, Restricted Project, Restricted Project

Dec 28 2021

Dec 28 2021, 11:09 AM · Restricted Project

Dec 21 2021

Dec 21 2021, 4:11 PM · Restricted Project

Dec 13 2021

Thanks @thakis - 906e60b9f923464cba0f71a9205846550752162f should have addressed that from a few days ago (sorry about not mentioning that here)

Dec 13 2021, 2:40 PM · Restricted Project

Dec 8 2021

compnerd committed rG906e60b9f923: lldb: silence a warning on the Windows error path (NFCI) (authored by compnerd).
lldb: silence a warning on the Windows error path (NFCI)

Dec 4 2021

compnerd requested changes to D113030: Add a new tool for parallel safe bisection, "llvm-bisectd"..
Dec 4 2021, 11:54 AM · Restricted Project
Dec 4 2021, 11:46 AM · Restricted Project

I think that this is almost correct now. While this will generate the binaries correctly, this is still a problem for tests. Without the absolute path, we now run the risk of the DT_NEEDED being correct but without a DT_RPATH/DR_RUNPATH, this could pick up the wrong library still at runtime. While the link time issue is resolved, the runtime portion is still a problem.

Dec 4 2021, 11:31 AM · Restricted Project
Dec 4 2021, 11:28 AM · Restricted Project, Restricted Project
compnerd committed rGf1585a4b47cc: Windows: support `DoLoadImage` (authored by compnerd).
Dec 4 2021, 11:12 AM · Restricted Project

Nov 29 2021

compnerd added inline comments to D114639: Raise the minimum Visual Studio version to VS2019.
Nov 29 2021, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
Nov 29 2021, 9:59 AM · Restricted Project

Nov 28 2021

compnerd updated the diff for D77287: Windows: support `DoLoadImage`.

Nov 28 2021, 9:43 PM · Restricted Project
compnerd updated the diff for D77287: Windows: support `DoLoadImage`.

Fix build rules

Nov 28 2021, 8:20 PM · Restricted Project
compnerd updated the diff for D77287: Windows: support `DoLoadImage`.

This is a more complete implementation that allows for error reporting and use of UCS-2 as that is needed for the search path alteration.

Nov 28 2021, 8:10 PM · Restricted Project
compnerd committed rG6488bd1d5171: test: add a lit configuration for Windows subdirectory (authored by compnerd).
test: add a lit configuration for Windows subdirectory

I'm not sure that this is a good idea. This now means that you can link against two different versions of this library - one when building LLVMSupport and one that any user linking against LLVMSupport happens to find in the library search path. Consider someone explicitly providing a path to the terminfo library when configuring. At the very least, the library search path should be propagated to ensure that the right version is used.

Nov 28 2021, 11:05 AM · Restricted Project

Nov 24 2021

compnerd committed rG1ad7de9e92bc: Headers: exclude `#include_next <stdatomic.h>` on MSVC (authored by compnerd).
Headers: exclude `#include_next <stdatomic.h>` on MSVC

Nov 9 2021

compnerd committed rGc17d9b4b125e: headers: optionalise some generated resource headers (authored by compnerd).
Nov 9 2021, 2:31 PM · Restricted Project

Nov 8 2021

@craig.topper - ping

Nov 8 2021, 9:55 AM · Restricted Project

Nov 1 2021

Nov 1 2021, 7:37 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 31 2021

If I understand you correctly, I would need to pass something ala -target riscv-xx to enable __riscv_vector. However, this is impossible because the risk target is disabled. So I thing it is save what you are doing.

Oct 31 2021, 4:45 PM · Restricted Project

I am undecided between this may break something and I cannot use the risc-v headers on an x86 machine.

Oct 31 2021, 2:07 PM · Restricted Project
Oct 31 2021, 11:34 AM · Restricted Project

Oct 26 2021

@mstorsjo I think that it might be interesting to consider a wrapper for enable_languages and to split that out from project.

Oct 26 2021, 11:14 AM · Restricted Project, Restricted Project

I think that as long as the builders remain green, this is fine. Yes, this is very likely to break users. We should announce this change on llvm-dev at the very least, and you *could* possibly add a transition helper in the form of:

Oct 26 2021, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 16 2021

compnerd requested changes to D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library.

I think that we might really want to subsequently rework the compiler-rt handling to use target_compile_options. This munging of flags manually is really rather onerous, but that is beyond the scope of this change.

Oct 16 2021, 10:44 AM · Restricted Project

Sep 20 2021

compnerd requested changes to D110005: [runtimes] [CMake] Unify variable names.

While I think that the direction of this change is amazing, I'm less enthusiastic about the naming. I think that it is particularly confusing for the flags to use C and CXX as the prefixes for the flags as we have llvm-libc (aka "c") and libc++ (aka "c++", "cxx"). Using a more verbose name of COMPILER_ or C_COMPILER_, CXX_COMPILER_ would allow the flags to be easily attributed to the compiler or the runtime. However, the C standard flags definitely should be dropped.

Sep 20 2021, 3:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rG96d3319d6f02: Sema: relax va_start checking further for Windows AArch64 (authored by compnerd).
Sema: relax va_start checking further for Windows AArch64

Sep 16 2021

compnerd committed rGf1e8ceb3054a: docs: correct SPHNIX document reference (authored by compnerd).
docs: correct SPHNIX document reference

Sep 14 2021

@thakis - thanks, seems that I had a part of the change sitting in my stash ... I had added a -NOT to verify the behaviour, and forgot to remove it. I'll revert the revert with the fix.

Sep 14 2021, 10:44 AM · Restricted Project

@Eugene.Zelenko - sorry, I didn't see the additional comments before the commit. I'm happy to do a follow up depending on the resolution.

Sep 14 2021, 8:15 AM · Restricted Project
Sep 14 2021, 8:12 AM · Restricted Project

Sep 13 2021

Sep 13 2021, 1:14 PM · Restricted Project
compnerd added inline comments to D109192: [WIP/DNM] Support: introduce public API annotation support.
Sep 13 2021, 10:15 AM · Restricted Project
compnerd updated the diff for D108893: clang-tidy: introduce readability-containter-data-pointer check.

Sep 13 2021, 9:59 AM · Restricted Project
Sep 13 2021, 9:58 AM · Restricted Project

Sep 8 2021

compnerd added a comment to D109192: [WIP/DNM] Support: introduce public API annotation support.

Hi Saleem,

I think I understand where you're going, but I think this deserves a writeup and consideration on llvm-dev with your desired endpoint for the source base and what changes to both current and future development will need to happen with some benefits and costs outlined. Might want to include a "support story" for the project along these lines as well - or at least be clear that this doesn't change or affect what long term APIs we are willing to support.

Thoughts?

Sep 8 2021, 11:29 AM · Restricted Project

As to the comment on the consistency - there are a number of different layouts that are inconsistent with each other :-(. This is messy, and therefore forcing the user to specify the paths seems like a good compromise.

Sep 8 2021, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
compnerd committed rGc189ec2e3f33: Support: hoist `extern template` declarations (authored by compnerd).
Support: hoist `extern template` declarations

I really would prefer to avoid adding bin/<TRIPLE> to the default installation path. This doesn't match the defaults for most platforms (e.g. exherbo uses /usr/<triple>/bin - which would be a default value of \${LLVM_DEFAULT_TARGET_TRIPLE}/bin. On Windows, it seems that bin, bin64, bin64a is the style that Microsoft uses. Having to have different defaults seems unfortunate. Defaulting to bin and letting the user override it seems reasonable to me.

Sep 8 2021, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
Analysis: move declaration of variables to a more suitable location
Sep 8 2021, 9:19 AM · Restricted Project
compnerd committed rG480a5a2d96c5: IR: move the declaration of `VerifyDomInfo` (NFC) (authored by compnerd).
IR: move the declaration of `VerifyDomInfo` (NFC)
Sep 8 2021, 8:36 AM · Restricted Project

Sep 7 2021

Sep 7 2021, 2:48 PM · Restricted Project
compnerd added a reviewer for D109395: IR: move the declaration of `VerifyDomInfo` (NFC): mehdi_amini.
Sep 7 2021, 2:47 PM · Restricted Project
compnerd requested review of D109395: IR: move the declaration of `VerifyDomInfo` (NFC).
Sep 7 2021, 2:46 PM · Restricted Project
Sep 7 2021, 2:44 PM · Restricted Project, Restricted Project

Sep 6 2021

compnerd requested changes to D109342: [libcxx][libcxxabi] CMAKE_REQUIRED_FLAGS is a string, not a list.
Sep 6 2021, 8:34 PM · Restricted Project, Restricted Project