Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (370 w, 5 d)

Recent Activity

Mon, Jan 13

compnerd added a comment to D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility.

Do we need to worry about compatibility? What happens if there is a mix between an old binary and a new binary?

Mon, Jan 13, 11:59 AM · Restricted Project
compnerd accepted D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Mon, Jan 13, 11:50 AM · Restricted Project
compnerd requested changes to D72490: Fix cmake for zlib.

I'm not sure I understand the motivation for this change. Can you please expand on that? How are you using it that it doesn't work for you? Additionally, z is definitely the wrong name, please compute that by using get_file_name_component, CMAKE_SHARED_LIBRARY_PREFIX, and string(REGEX...)

Mon, Jan 13, 11:50 AM · Restricted Project

Tue, Jan 7

compnerd added inline comments to D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2.
Tue, Jan 7, 4:39 PM · Restricted Project

Thu, Jan 2

compnerd committed rGa2ca1c2d5668: build: disable zlib by default on Windows (authored by compnerd).
build: disable zlib by default on Windows
Thu, Jan 2, 12:59 PM
Saleem Abdulrasool <abdulras@google.com> committed rGabb007530695: build: reduce CMake handling for zlib (authored by compnerd).
build: reduce CMake handling for zlib
Thu, Jan 2, 11:24 AM

Wed, Jan 1

compnerd committed rZORG0184c5c5188c: disable ZLib on the LLDB builder (authored by compnerd).
disable ZLib on the LLDB builder
Wed, Jan 1, 10:43 PM
compnerd committed rGe6c7ed6d2164: build: make `LLVM_ENABLE_ZLIB` a tri-bool for users (authored by compnerd).
build: make `LLVM_ENABLE_ZLIB` a tri-bool for users
Wed, Jan 1, 5:06 PM
compnerd added a comment to D70590: [Examples] Add add_llvm_example_library macro and use it for IR example..

Hmm, I see, yes, that would change the behavior where we would not create the targets for it. In that case, using EXCLUDE_FROM_ALL is fine, but set it as a target property rather than passing global variables like this. But, even better would be to understand if we even need this.

Wed, Jan 1, 4:47 PM · Restricted Project
compnerd committed rG68a235d07f9e: build: reduce CMake handling for zlib (authored by compnerd).
build: reduce CMake handling for zlib
Wed, Jan 1, 4:38 PM
compnerd closed D70764: build: reduce CMake handling for zlib.

GIT 68a235d07f9

Wed, Jan 1, 4:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rGfb170fd652bf: tests: XFAIL/UNSUPPORTED tests on Windows (authored by compnerd).
tests: XFAIL/UNSUPPORTED tests on Windows
Wed, Jan 1, 2:30 PM

Tue, Dec 24

compnerd committed rG64c6bb37832c: test: ensure that we dead-strip in the linker (authored by compnerd).
test: ensure that we dead-strip in the linker
Tue, Dec 24, 10:20 AM

Mon, Dec 23

compnerd committed rG4b0563f89f93: test: correct flags for Windows (authored by compnerd).
test: correct flags for Windows
Mon, Dec 23, 9:28 PM

Sun, Dec 22

compnerd committed rGb449d19e5588: build: use `find_package(Python3)` rather than `PYTHON_HOME` (authored by compnerd).
build: use `find_package(Python3)` rather than `PYTHON_HOME`
Sun, Dec 22, 8:51 PM
compnerd committed rG2046d72e9167: build: improve python checks for Windows (authored by compnerd).
build: improve python checks for Windows
Sun, Dec 22, 2:03 PM
compnerd closed D69535: build: improve python check for Windows.

GIT 2046d72e916

Sun, Dec 22, 2:03 PM · Restricted Project

Dec 16 2019

compnerd added inline comments to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 16 2019, 8:36 PM · Restricted Project

Dec 12 2019

GitHub <noreply@github.com> committed rG8d1ae5128204: Merge pull request #61 from compnerd/flang-fix (authored by compnerd).
Merge pull request #61 from compnerd/flang-fix
Dec 12 2019, 3:29 PM
compnerd committed rG0a1b1118cfd0: Rename a flang test case (authored by jmorse).
Rename a flang test case
Dec 12 2019, 3:29 PM
GitHub <noreply@github.com> committed rG14f41cb73c90: Merge pull request #343 from plotfi/upstream-with-swift2 (authored by compnerd).
Merge pull request #343 from plotfi/upstream-with-swift2
Dec 12 2019, 2:15 PM
GitHub <noreply@github.com> committed rG7d1a07226ad7: Merge pull request #342 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #342 from plotfi/upstream-with-swift
Dec 12 2019, 2:15 PM
GitHub <noreply@github.com> committed rG03b4816054de: Merge pull request #326 from smeenai/ast-test-fix (authored by compnerd).
Merge pull request #326 from smeenai/ast-test-fix
Dec 12 2019, 1:50 PM
GitHub <noreply@github.com> committed rGc49aea584d54: Merge pull request #317 from smeenai/fix-class-stubs-test (authored by compnerd).
Merge pull request #317 from smeenai/fix-class-stubs-test
Dec 12 2019, 1:41 PM
GitHub <noreply@github.com> committed rGa3e94101c4f9: Merge pull request #302 from compnerd/diagnostic-count (authored by compnerd).
Merge pull request #302 from compnerd/diagnostic-count
Dec 12 2019, 1:30 PM
GitHub <noreply@github.com> committed rG77e8aa6fbded: Merge pull request #298 from compnerd/diagnostics (authored by compnerd).
Merge pull request #298 from compnerd/diagnostics
Dec 12 2019, 1:26 PM
GitHub <noreply@github.com> committed rG50763a26b5b1: Merge pull request #296 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #296 from plotfi/upstream-with-swift
Dec 12 2019, 1:25 PM
GitHub <noreply@github.com> committed rG6205a38d152f: Merge pull request #295 from plotfi/upstream-with-swift-2 (authored by compnerd).
Merge pull request #295 from plotfi/upstream-with-swift-2
Dec 12 2019, 1:25 PM
GitHub <noreply@github.com> committed rGca6573ea5c05: Merge pull request #294 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #294 from plotfi/upstream-with-swift
Dec 12 2019, 1:24 PM
compnerd committed rG6152f711e9cd: Edit: adjust for SVN r347417 (authored by compnerd).
Edit: adjust for SVN r347417
Dec 12 2019, 12:09 PM

Dec 10 2019

compnerd added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Should probably add a check for __block variables.

Dec 10 2019, 7:13 PM · Restricted Project

Dec 9 2019

compnerd added a comment to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

The std::transform better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.

Dec 9 2019, 1:02 PM · Restricted Project
compnerd added a comment to D69535: build: improve python check for Windows.

@stella.stamenova ping

Dec 9 2019, 1:02 PM · Restricted Project
compnerd added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 7:47 AM · Restricted Project
compnerd added inline comments to D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting.
Dec 9 2019, 7:47 AM · Restricted Project

Dec 7 2019

compnerd committed rG4ec7bb42aa67: Symbol: use elaborated types for `DataExtractor` (authored by compnerd).
Symbol: use elaborated types for `DataExtractor`
Dec 7 2019, 11:27 AM

Dec 6 2019

compnerd added inline comments to D70026: [cmake] Always build the libLLVM shared library.
Dec 6 2019, 3:21 PM · Restricted Project
compnerd accepted D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 6 2019, 3:21 PM · Restricted Project

Dec 4 2019

compnerd accepted D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

LGTM with the additional test for the size/type mismatch validation.

Dec 4 2019, 9:12 PM · Restricted Project
compnerd added reviewers for D70764: build: reduce CMake handling for zlib: ldionne, tstellar.
Dec 4 2019, 11:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 3 2019

compnerd added a comment to D70764: build: reduce CMake handling for zlib.

Having one canonical variable controlling zlib support seems indeed desirable.

With this patch, what is the output of llvm-config --system-libs ?

@compnerd What's the answer to this for this patch?

Dec 3 2019, 10:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rGabe8de29c4ae: Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name"" (authored by compnerd).
Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name""
Dec 3 2019, 9:37 AM
compnerd added a reverting change for rG2e75681b55ab: Temporarily revert "build: avoid hardcoding the libxml2 library name" as it…: rGabe8de29c4ae: Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name"".
Dec 3 2019, 9:37 AM
compnerd added a comment to D69412: build: avoid hardcoding the libxml2 library name.

There isn't a workaround for this, its just a bug in our CMake. I've fixed the issue with our CMake logic in GIT 372ad32734ecb455f9fb4d0601229ca2dfc78b66.

Dec 3 2019, 9:28 AM · Restricted Project
compnerd committed rG372ad32734ec: llvm-config: do not link absolute paths with `-l` (authored by compnerd).
llvm-config: do not link absolute paths with `-l`
Dec 3 2019, 9:00 AM

Nov 29 2019

compnerd requested changes to D70026: [cmake] Always build the libLLVM shared library.
Nov 29 2019, 10:59 AM · Restricted Project
compnerd accepted D70728: [clang][IFS] Adding support for new clang interface stubs decl types..
Nov 29 2019, 10:48 AM · Restricted Project
compnerd added a comment to D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used..

The commit message doesn't really explain much. Why simply consume the argument? Why not actually halt the build since this clearly is conflicting, and its unclear what the user intended.

Nov 29 2019, 10:48 AM · Restricted Project
compnerd accepted D70815: Enable `-funwind-tables` flag when building libunwind.
Nov 29 2019, 10:48 AM · Restricted Project
compnerd added inline comments to D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..
Nov 29 2019, 10:38 AM · Restricted Project
compnerd accepted D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now..

Could you please provide a proper commit message before committing this? Also -Xifs is actually the inverse of what you want - that would be a set of arguments designed to be passed to llvm-ifs.

Nov 29 2019, 10:28 AM · Restricted Project

Nov 27 2019

compnerd committed rGcfcfd8a056eb: build: avoid cached literals being linked against (authored by compnerd).
build: avoid cached literals being linked against
Nov 27 2019, 1:00 PM
compnerd added a comment to D70764: build: reduce CMake handling for zlib.

@labath I think you are misunderstanding the patch. This is not autoselecting the dependencies. It is simply doing that based on an existing option that we have - LLVM_ENABLE_ZLIB. We could always search for zlib and override the results with LLVM_ENABLE_ZLIB as well. The current build will continue to just work - zlib is used only for the compressed debug sections (which requires the user to opt-in).

Nov 27 2019, 12:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rG340e7c0b77a7: build: avoid hardcoding the libxml2 library name (authored by compnerd).
build: avoid hardcoding the libxml2 library name
Nov 27 2019, 12:37 PM
compnerd closed D69412: build: avoid hardcoding the libxml2 library name.

GIT 340e7c0b77a

Nov 27 2019, 12:37 PM · Restricted Project

Nov 26 2019

compnerd created D70764: build: reduce CMake handling for zlib.
Nov 26 2019, 9:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 23 2019

compnerd requested changes to D70590: [Examples] Add add_llvm_example_library macro and use it for IR example..

I think that rather than adding more wrapping macros, we should fix the structure. We can mark the examples directory from ALL at the add_subdirectory level and only add the subdirectory when examples are enabled. This avoids the need for the new macro. I think that we want to move towards a more standard cmake build rather than a more specialized one.

Nov 23 2019, 5:10 PM · Restricted Project

Nov 22 2019

compnerd updated the diff for D69535: build: improve python check for Windows.

Use @labath's suggestion of bumping minimum required version for Windows

Nov 22 2019, 8:37 AM · Restricted Project

Nov 21 2019

compnerd accepted D70522: [llvm-lipo] Implement -extract.
Nov 21 2019, 8:43 AM · Restricted Project

Nov 18 2019

compnerd accepted D70250: [llvm-cxxfilt] Improve strip-underscore behavior.

Sorry about the delay on the review!

Nov 18 2019, 2:47 PM · Restricted Project
compnerd accepted D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline..
Nov 18 2019, 2:37 PM · Restricted Project
compnerd requested changes to D70306: clang: Exherbo multiarch ajustments.

The test adjustments are incorrect. They should optionally accept the triple in the path.

Nov 18 2019, 2:28 PM · Restricted Project

Nov 17 2019

compnerd added inline comments to D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline..
Nov 17 2019, 3:36 PM · Restricted Project

Nov 16 2019

compnerd added inline comments to D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline..
Nov 16 2019, 4:46 PM · Restricted Project

Nov 12 2019

compnerd added inline comments to D70112: [llvm-readobj] - Improve dumping of the SHT_LLVM_LINKER_OPTIONS sections..
Nov 12 2019, 2:21 PM · Restricted Project

Nov 11 2019

compnerd added a comment to D70026: [cmake] Always build the libLLVM shared library.

I'm kinda torn on this. Although this simplifies the build, linking the DSO on Linux is painful unless you externalise the debug info (i.e. build with fission). On the other hand, people should be encouraged to setup the distributions and use that to build the full set that they need. I think that marking libLLVM as EXCLUDE_FROM_ALL is a decent compromise.

Nov 11 2019, 9:26 AM · Restricted Project

Nov 8 2019

compnerd committed rGb314414570c0: Basic: fix FileManager invalidation issue for file redirect (authored by asuhan).
Basic: fix FileManager invalidation issue for file redirect
Nov 8 2019, 2:06 PM
compnerd closed D69525: Fix FileManager invalidation issue for file redirect.

GIT rb314414570c

Nov 8 2019, 2:06 PM · Restricted Project
compnerd accepted D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs..
Nov 8 2019, 9:22 AM · Restricted Project

Nov 6 2019

compnerd added a comment to D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary.

I agree with @efriedma that it sounds odd, could you explain that please?

Nov 6 2019, 7:01 PM · Restricted Project
compnerd committed rGe74e61ff297e: unwind: restore the LINKER_LANGUAGE (authored by compnerd).
unwind: restore the LINKER_LANGUAGE
Nov 6 2019, 3:43 PM
compnerd committed rGaa582e3648cc: unwind: reflow some of the build rules (NFC) (authored by compnerd).
unwind: reflow some of the build rules (NFC)
Nov 6 2019, 3:43 PM
compnerd accepted D69877: [cmake] Remove LLVM_{BUILD,LINK}_LLVM_DYLIB options on Windows.
Nov 6 2019, 12:02 PM · Restricted Project
compnerd committed rGcbc872a63f81: unwind: disable RTTI during the build of libunwind (authored by compnerd).
unwind: disable RTTI during the build of libunwind
Nov 6 2019, 10:55 AM
Herald added a reviewer for D69902: [libunwind] Drop -Wl,-z,defs for SHARED builds.: mclow.lists.

Can you please write a more complete commit message explaining the need for this.

Nov 6 2019, 9:22 AM · Restricted Project
compnerd committed rG049f94af487f: Revert "build: explicitly set the linker language for unwind" (authored by compnerd).
Revert "build: explicitly set the linker language for unwind"
Nov 6 2019, 8:36 AM
compnerd added a reverting change for rG6db7a5cd7c80: build: explicitly set the linker language for unwind: rG049f94af487f: Revert "build: explicitly set the linker language for unwind".
Nov 6 2019, 8:36 AM

Nov 4 2019

compnerd committed rG6db7a5cd7c80: build: explicitly set the linker language for unwind (authored by compnerd).
build: explicitly set the linker language for unwind
Nov 4 2019, 5:06 PM
compnerd accepted D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link".

Seems like a good idea since lld link2 has been made into lld link for a while now.

Nov 4 2019, 2:08 PM · Restricted Project

Nov 2 2019

compnerd committed rG5ce2c6d2db88: build: avoid custom handling for C++ standard (authored by compnerd).
build: avoid custom handling for C++ standard
Nov 2 2019, 12:11 PM

Nov 1 2019

compnerd committed rG7a25de6d2073: llvm-config: emit the C++ standard flag into CXXFLAGS (authored by compnerd).
llvm-config: emit the C++ standard flag into CXXFLAGS
Nov 1 2019, 9:20 AM

Oct 30 2019

compnerd added inline comments to D69013: [AArch64][X86] Don't assume __powidf2 is available on Windows..
Oct 30 2019, 1:53 PM · Restricted Project
compnerd committed rG5e029c4cfd7b: DebugServer: be more lenient about the target triple (authored by compnerd).
DebugServer: be more lenient about the target triple
Oct 30 2019, 12:10 PM

Oct 29 2019

compnerd added a comment to D69535: build: improve python check for Windows.

Yeah, doing an incremental rollout makes sense.

Oct 29 2019, 6:52 PM · Restricted Project
GitHub <noreply@github.com> committed rGb6fa91ee4c76: Merge pull request #211 from compnerd/visibility-storage (authored by compnerd).
Merge pull request #211 from compnerd/visibility-storage
Oct 29 2019, 5:23 PM
GitHub <noreply@github.com> committed rGcc7676309881: Merge pull request #209 from compnerd/IndexStore (authored by compnerd).
Merge pull request #209 from compnerd/IndexStore
Oct 29 2019, 5:13 PM
compnerd committed rG0e070c2743aa: upstream-update: adjust for SVN r331155 (authored by compnerd).
upstream-update: adjust for SVN r331155
Oct 29 2019, 4:14 PM
compnerd committed rG317db3844f77: APINotes: adjust for upstream SVN r326091 (authored by compnerd).
APINotes: adjust for upstream SVN r326091
Oct 29 2019, 3:51 PM
compnerd committed rG5ef9bc55ef7f: Tooling: use /bigobj when building a file (authored by compnerd).
Tooling: use /bigobj when building a file
Oct 29 2019, 3:51 PM
GitHub <noreply@github.com> committed rG8ee2052ec06c: Merge pull request #161 from compnerd/bigobj (authored by compnerd).
Merge pull request #161 from compnerd/bigobj
Oct 29 2019, 3:51 PM
GitHub <noreply@github.com> committed rG128a700c905e: Merge pull request #159 from compnerd/libclang-warnings (authored by compnerd).
Merge pull request #159 from compnerd/libclang-warnings
Oct 29 2019, 3:44 PM
compnerd committed rGa9b7cfa55d84: libclang: silence -Wreturn-type warning (authored by compnerd).
libclang: silence -Wreturn-type warning
Oct 29 2019, 3:44 PM
GitHub <noreply@github.com> committed rGebefc1dfdea1: Merge pull request #158 from compnerd/linkage (authored by compnerd).
Merge pull request #158 from compnerd/linkage
Oct 29 2019, 3:44 PM
compnerd committed rGaebcd8be0d70: clang-c: indicate correct linkage (authored by compnerd).
clang-c: indicate correct linkage
Oct 29 2019, 3:44 PM
compnerd committed rG8a28b8423f27: Tooling: fix -fpermissive warning from gcc (authored by compnerd).
Tooling: fix -fpermissive warning from gcc
Oct 29 2019, 3:43 PM
GitHub <noreply@github.com> committed rG3e2901856e44: Merge pull request #157 from compnerd/tooling-namespace (authored by compnerd).
Merge pull request #157 from compnerd/tooling-namespace
Oct 29 2019, 3:43 PM
GitHub <noreply@github.com> committed rGf105b6587139: Merge pull request #155 from compnerd/refactor-unreachable (authored by compnerd).
Merge pull request #155 from compnerd/refactor-unreachable
Oct 29 2019, 3:43 PM
compnerd committed rGe56ba3743bcc: build: make standalone builds work again (authored by compnerd).
build: make standalone builds work again
Oct 29 2019, 8:30 AM
compnerd committed rG55eec2ba96bd: build: workaround stale caches (NFC) (authored by compnerd).
build: workaround stale caches (NFC)
Oct 29 2019, 8:25 AM

Oct 28 2019

compnerd added a comment to D69535: build: improve python check for Windows.

The reason for bringing this back up as a Windows specific thing is that currently, there is no good way to build LLDB with python support without having to specify additional details on *just* windows because the windows path is doing something special. This is trying to bring the windows path to parity with the Linux path.

Oct 28 2019, 8:06 PM · Restricted Project