Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (382 w, 2 d)

Recent Activity

Today

compnerd added a comment to D77697: libc++: adjust modulemap for non-modular C.

I think that a clang-pcm like tool would be incredible. Working with modules is somewhat frustrating because there is no good supported way to see what the module structure that clang actually sees. But that goes well beyond an attempt to repair the NetBSD builds.

Wed, Apr 8, 5:24 PM · Restricted Project
compnerd added a comment to D76250: [llvm-objdump] Only reject -long-option in objdump mode.

@jhenderson Traditionally, the long options all must come after the short options. Doing a prefix match seems reasonable way to handle this. Honestly, all the arguments have been "we like the GNU options because that's what we are used to" rather than any real technical issue. I don't think that is a valid justification for breaking existing users of these options.

Wed, Apr 8, 4:19 PM · Restricted Project
compnerd added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

Ok, let's go step by step to make sure we don't talk past each other. Here's some facts (feel free to correct me if you see a mistake):

  1. CMake builds shared libraries with POSITION_INDEPENDENT_CODE=ON by default.
  2. CMake builds static libraries with POSITION_INDEPENDENT_CODE=OFF by default.
  3. Setting CMAKE_POSITION_INDEPENDENT_CODE=ON on the command-line or in a cache will cause CMake to build both shared libraries and static libraries with POSITION_INDEPENDENT_CODE=ON.
Wed, Apr 8, 11:57 AM · Restricted Project, Restricted Project
compnerd added a comment to D77697: libc++: adjust modulemap for non-modular C.

@dexonsmith - yeah, sadly I dont think that there is a good way to audit that - any change to the public headers can cause issues. Furthermore, the libc headers themselves also influence this.

Wed, Apr 8, 11:24 AM · Restricted Project
compnerd added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

@ldionne - "hard coding" is the right solution. If the user specifies a value on the command line or through a cache file, that will be the value used. What I suggested works as a default value.

Wed, Apr 8, 9:13 AM · Restricted Project, Restricted Project

Yesterday

compnerd created D77697: libc++: adjust modulemap for non-modular C.
Tue, Apr 7, 6:00 PM · Restricted Project
compnerd added a comment to D77433: PowerPCSPE: Stop libunwind from complaining about SPE registers.

The tests that I was requesting were for clang/LLVM. Testing libunwind is challenging as it requires runtime tests, and that means that in order to test it effectively, you need each type of machine. I suppose that in theory, you could build a VM based on LLVM's JIT, cross-compile the library, binary translate the code and test it - but that seems incredibly fragile.

Tue, Apr 7, 10:18 AM · Restricted Project, Restricted Project

Mon, Apr 6

compnerd updated the diff for D77287: Windows: add very basic support for `DoLoadImage`.
Mon, Apr 6, 9:48 PM · Restricted Project
compnerd updated the diff for D77287: Windows: add very basic support for `DoLoadImage`.
Mon, Apr 6, 9:16 PM · Restricted Project
compnerd committed rG3775be2d8e17: Target: correct the return value for `GetImageAddrFromToken` (authored by compnerd).
Target: correct the return value for `GetImageAddrFromToken`
Mon, Apr 6, 6:02 PM
compnerd added a comment to D77287: Windows: add very basic support for `DoLoadImage`.

I think that the basic test is sufficient for this.

That test does not seem to be exercising the "unload" part of this patch. It would also be nice to run some basic command like "image list" to verify that the loaded binary is indeed listed.

(I don't really have a hard objection to this being a lit test, but it does sound to me like at that point, this will be reimplementing TestLoadUnload.py)

I think that the path sanitizing and conversion should be a subsequent change.

Why is that? The need for sanitation is a direct consequence of how you've chosen to implement this patch -- the posix version of this function does not do sanitation, but it does not need to, as it does not embed the library name into the compiled expression. I can see how the support for wide strings might be considered a separate feature, but given that supporting that is a matter of adding a single L to the compiled expression, I don't see a problem with including that here.

Mon, Apr 6, 9:11 AM · Restricted Project
compnerd added a comment to D77287: Windows: add very basic support for `DoLoadImage`.
Mon, Apr 6, 9:11 AM · Restricted Project

Fri, Apr 3

compnerd added a comment to D77433: PowerPCSPE: Stop libunwind from complaining about SPE registers.

Im surprised that no tests need changing here. Could you please add a clang/llvm test to validate that the generated information matches what libunwind will start looking for?

Fri, Apr 3, 6:26 PM · Restricted Project, Restricted Project
compnerd added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

@ldionne yeah, thats why I would prefer that we just do the following in the top level CMakeLists.txt for libunwind:

Fri, Apr 3, 12:57 PM · Restricted Project, Restricted Project
compnerd added inline comments to D77287: Windows: add very basic support for `DoLoadImage`.
Fri, Apr 3, 12:57 PM · Restricted Project
compnerd updated the diff for D77287: Windows: add very basic support for `DoLoadImage`.
Fri, Apr 3, 12:25 PM · Restricted Project
compnerd added a comment to D77287: Windows: add very basic support for `DoLoadImage`.

Okay, thanks to some help from @JDevlieghere I was able to get a test going for this. I think that the basic test is sufficient for this. I think that the path sanitizing and conversion should be a subsequent change.

Fri, Apr 3, 12:25 PM · Restricted Project
compnerd added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.

Fri, Apr 3, 12:25 PM · Restricted Project, Restricted Project

Thu, Apr 2

compnerd added a comment to D76250: [llvm-objdump] Only reject -long-option in objdump mode.

The precedent for behaviour based on the name is long standing and not being introduced here. In fact the archiver already does this. clang also does this (clang vs clang++). This is not at all uncommon I think. The target triple prefixed tools should be treated as the tool that they specify and implicitly passing -target ... which is derived from the prefix.

Thu, Apr 2, 4:50 PM · Restricted Project
compnerd added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

I think that @ldionne should chime in on this change. Mechanically, sure, I don't see any problems with the change.

Thu, Apr 2, 4:17 PM · Restricted Project
compnerd updated the diff for D77287: Windows: add very basic support for `DoLoadImage`.
Thu, Apr 2, 3:44 PM · Restricted Project
compnerd added a reviewer for D77287: Windows: add very basic support for `DoLoadImage`: davide.
Thu, Apr 2, 11:55 AM · Restricted Project
compnerd added a comment to D77287: Windows: add very basic support for `DoLoadImage`.

Thanks for the hint about the string conversion, however, I think that it's going to complicate things as the string is going to be a mixture of UTF-8 and UTF-16 content.

Thu, Apr 2, 9:44 AM · Restricted Project

Wed, Apr 1

compnerd created D77287: Windows: add very basic support for `DoLoadImage`.
Wed, Apr 1, 10:18 PM · Restricted Project
compnerd accepted D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

This should be safe, if pc is ever 0, we don't have any chance of recovery.

Wed, Apr 1, 10:18 PM · Restricted Project, Restricted Project
compnerd added a comment to D76250: [llvm-objdump] Only reject -long-option in objdump mode.

@jhenderson - accepting GNU options in GNU mode makes sense. This tool is *not* GNU - objdump is the GNU driver, llvm-objdump is the LLVM driver and accepts SUN style arguments.

Wed, Apr 1, 10:18 PM · Restricted Project
compnerd requested changes to D75453: [Driver][ARM] fix undefined behaviour when checking architecture version.

Seems reasonable, though this isn't UB, its just use of an uninitialized variable.

Wed, Apr 1, 10:18 PM · Restricted Project
compnerd added inline comments to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Wed, Apr 1, 9:46 PM · Restricted Project

Sat, Mar 28

compnerd added a comment to D76979: [clang][llvm] Interface Stubs new yaml file format changes..

Please address the linter warnings. I think that adding an additional test to demonstrate that the experimental-ifs-version-v1 is properly diagnosed is a good idea. LGTM other than that.

Sat, Mar 28, 11:17 AM · Restricted Project

Tue, Mar 10

compnerd accepted D75907: [compiler-rt] Define ElfW() macro if it's not defined.

*sigh* ELF, couldn't you just add that macro to the standard? (We have something similar in libunwind to deal with this). LGTM

Tue, Mar 10, 8:39 AM · Restricted Project, Restricted Project

Mon, Mar 9

compnerd accepted D75884: [RuntimeDyld][COFF] Build stubs for COFF dllimport symbols..

LGTM, and tested with Swift as well that it does resolve the issue. Thanks for fixing this!

Mon, Mar 9, 11:25 PM · Restricted Project

Mar 5 2020

compnerd accepted D75015: [ARM] Rewrite ARMAttributeParser.
Mar 5 2020, 10:57 AM · Restricted Project

Feb 27 2020

compnerd committed rGc3595d106927: build: process the libxml2 library path for embedding (authored by compnerd).
build: process the libxml2 library path for embedding
Feb 27 2020, 10:03 PM

Feb 19 2020

compnerd added a comment to D74176: [CMake] Link against ZLIB::ZLIB.

@smeenai I agree that -lz is less than idea, however, for llvm-config, I think that is fine. In general, I think that we will want to phase out llvm-config in the longer term in favor of pkgconfig and CMake.

Feb 19 2020, 12:05 PM · Restricted Project

Feb 12 2020

compnerd accepted D74458: [runtimes] Add umbrella targets for runtimes.

Sure, seems reasonable.

Feb 12 2020, 9:28 AM · Restricted Project

Feb 10 2020

compnerd committed rG14798b44658c: unwind: rename `__personality_routine` to `_Unwind_Personality_Fn` (authored by compnerd).
unwind: rename `__personality_routine` to `_Unwind_Personality_Fn`
Feb 10 2020, 8:56 AM
compnerd closed D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

rG14798b44658

Feb 10 2020, 8:56 AM · Restricted Project
compnerd accepted D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.
Feb 10 2020, 8:52 AM · Restricted Project

Feb 7 2020

compnerd added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

I hope we are not renaming everything because it add complexity on compatibility.

Rename only the refs from libunwind is not enough since there are refs from clang header and libc++abi as well. unwind.h and corresponding header from clang are both shipping products which add compatibility problem.

Git grepping for __ personality_routine after the patch yields only three results. One is the typedef inside of the clang Headers, Two are inside of tests of llvm that I am not sure are relevant here. libc++abi uses the name _Unwind_Personality_Fn instead of __personality_routine that libunwind has used prior to this patch. _Unwind_Personality_Fn is also what GCC calls it. So this patch actually makes it possible to compile libc++abi with libunwind (Build errors only show up on windows since only windows has actually used _Unwind_Personality_Fn ).

Regarding compatibility I am not sure, but I thought users are expected to include unwind.h from clang Headers anyways.

Won't the typedef in clang header turns into an error? That is also the compatibility problem. If you have a mismatch between clang header and libunwind header, it is going to break one way or the other.

Feb 7 2020, 8:36 AM · Restricted Project

Feb 5 2020

compnerd added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

I think that we should switch everything to just _Unwind_Personality_Fn and remove __personality_routine.

Feb 5 2020, 10:18 PM · Restricted Project
compnerd added a comment to rG00b3d49d3a86: [CMake] Link against ZLIB::ZLIB.

Ugh, I forgot about one thing. Could you please ensure that the path is still embedded into the output of llvm-config --libs?

Feb 5 2020, 10:17 PM
compnerd accepted D74102: [CMake] Link against ZLIB::ZLIB.

Linking against the imported target should do the right thing and add interface headers too.

Feb 5 2020, 6:08 PM · Restricted Project

Feb 2 2020

compnerd added a comment to D73858: Fix CMake config breakage in COMPILE_LANGUAGE generator.

Already committed in a43bf8078861ae816b45d94f7012a7ea01a2e5eb

Feb 2 2020, 6:25 PM · Restricted Project
compnerd committed rGa43bf8078861: build: attempt to repair the build (authored by compnerd).
build: attempt to repair the build
Feb 2 2020, 4:20 PM
compnerd committed rG9b84dabc5f36: build: only pass -UNDEBUG when compiling C/C++ (authored by compnerd).
build: only pass -UNDEBUG when compiling C/C++
Feb 2 2020, 1:25 PM
compnerd closed D73830: Only pass -UNDEBUG when compiling C/C++.

GIT 9b84dabc5f3

Feb 2 2020, 1:25 PM · Restricted Project
compnerd added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

I think that we would want to retain the ability to build libc++abi against libgcc_s. If that also vends a __personality_routine type, then this would definitely be preferable.

Feb 2 2020, 10:53 AM · Restricted Project

Feb 1 2020

compnerd accepted D73830: Only pass -UNDEBUG when compiling C/C++.
Feb 1 2020, 9:42 AM · Restricted Project

Jan 31 2020

compnerd added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Why not rename __personality_routine to _Unwind_Personality_Fn? I don't think that _Unwind_Personality_Fn is part of either the ABI-EH, gABI, or PSABI, but, it is acceptable for GCC compatibility.

Jan 31 2020, 11:01 PM · Restricted Project

Jan 28 2020

compnerd accepted D73512: [runtimes] Fix passing lists to runtimes configures.
Jan 28 2020, 9:17 AM · Restricted Project

Jan 27 2020

compnerd accepted D73440: [llvm] Fix broken cases of 'CHECK[^:]*$' in tests.

Thanks for fixing this

Jan 27 2020, 7:48 PM · Restricted Project

Jan 23 2020

compnerd accepted D73253: [llvm] Fix file ignoring inside directories.

I think that removing the nested layout is something which should be removed separately from this change. That would move us closer to declaring the nested layout as being unsupported. While I think that the move towards that makes sense, it should be brought up on llvm-dev first I think.

Jan 23 2020, 3:01 PM · Restricted Project
compnerd accepted D73289: [lldb/Test] Disallow using substituted binaries in shell test..
Jan 23 2020, 2:20 PM · Restricted Project

Jan 20 2020

compnerd added a comment to D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin.

Do we need to worry about ordering of the plugins?

Jan 20 2020, 4:18 PM · Restricted Project

Jan 13 2020

compnerd added a comment to D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility.

Do we need to worry about compatibility? What happens if there is a mix between an old binary and a new binary?

Jan 13 2020, 11:59 AM · Restricted Project
compnerd accepted D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Jan 13 2020, 11:50 AM · Restricted Project
compnerd requested changes to D72490: Fix cmake for zlib.

I'm not sure I understand the motivation for this change. Can you please expand on that? How are you using it that it doesn't work for you? Additionally, z is definitely the wrong name, please compute that by using get_file_name_component, CMAKE_SHARED_LIBRARY_PREFIX, and string(REGEX...)

Jan 13 2020, 11:50 AM · Restricted Project

Jan 7 2020

compnerd added inline comments to D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2.
Jan 7 2020, 4:39 PM · Restricted Project

Jan 2 2020

compnerd committed rGa2ca1c2d5668: build: disable zlib by default on Windows (authored by compnerd).
build: disable zlib by default on Windows
Jan 2 2020, 12:59 PM
Saleem Abdulrasool <abdulras@google.com> committed rGabb007530695: build: reduce CMake handling for zlib (authored by compnerd).
build: reduce CMake handling for zlib
Jan 2 2020, 11:24 AM

Jan 1 2020

compnerd committed rZORG0184c5c5188c: disable ZLib on the LLDB builder (authored by compnerd).
disable ZLib on the LLDB builder
Jan 1 2020, 10:43 PM
compnerd committed rGe6c7ed6d2164: build: make `LLVM_ENABLE_ZLIB` a tri-bool for users (authored by compnerd).
build: make `LLVM_ENABLE_ZLIB` a tri-bool for users
Jan 1 2020, 5:06 PM
compnerd added a comment to D70590: [Examples] Add add_llvm_example_library macro and use it for IR example..

Hmm, I see, yes, that would change the behavior where we would not create the targets for it. In that case, using EXCLUDE_FROM_ALL is fine, but set it as a target property rather than passing global variables like this. But, even better would be to understand if we even need this.

Jan 1 2020, 4:47 PM · Restricted Project
compnerd committed rG68a235d07f9e: build: reduce CMake handling for zlib (authored by compnerd).
build: reduce CMake handling for zlib
Jan 1 2020, 4:38 PM
compnerd closed D70764: build: reduce CMake handling for zlib.

GIT 68a235d07f9

Jan 1 2020, 4:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rGfb170fd652bf: tests: XFAIL/UNSUPPORTED tests on Windows (authored by compnerd).
tests: XFAIL/UNSUPPORTED tests on Windows
Jan 1 2020, 2:30 PM

Dec 24 2019

compnerd committed rG64c6bb37832c: test: ensure that we dead-strip in the linker (authored by compnerd).
test: ensure that we dead-strip in the linker
Dec 24 2019, 10:20 AM

Dec 23 2019

compnerd committed rG4b0563f89f93: test: correct flags for Windows (authored by compnerd).
test: correct flags for Windows
Dec 23 2019, 9:28 PM

Dec 22 2019

compnerd committed rGb449d19e5588: build: use `find_package(Python3)` rather than `PYTHON_HOME` (authored by compnerd).
build: use `find_package(Python3)` rather than `PYTHON_HOME`
Dec 22 2019, 8:51 PM
compnerd committed rG2046d72e9167: build: improve python checks for Windows (authored by compnerd).
build: improve python checks for Windows
Dec 22 2019, 2:03 PM
compnerd closed D69535: build: improve python check for Windows.

GIT 2046d72e916

Dec 22 2019, 2:03 PM · Restricted Project

Dec 16 2019

compnerd added inline comments to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..
Dec 16 2019, 8:36 PM · Restricted Project

Dec 12 2019

GitHub <noreply@github.com> committed rG8d1ae5128204: Merge pull request #61 from compnerd/flang-fix (authored by compnerd).
Merge pull request #61 from compnerd/flang-fix
Dec 12 2019, 3:29 PM
compnerd committed rG0a1b1118cfd0: Rename a flang test case (authored by jmorse).
Rename a flang test case
Dec 12 2019, 3:29 PM
GitHub <noreply@github.com> committed rG14f41cb73c90: Merge pull request #343 from plotfi/upstream-with-swift2 (authored by compnerd).
Merge pull request #343 from plotfi/upstream-with-swift2
Dec 12 2019, 2:15 PM
GitHub <noreply@github.com> committed rG7d1a07226ad7: Merge pull request #342 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #342 from plotfi/upstream-with-swift
Dec 12 2019, 2:15 PM
GitHub <noreply@github.com> committed rG03b4816054de: Merge pull request #326 from smeenai/ast-test-fix (authored by compnerd).
Merge pull request #326 from smeenai/ast-test-fix
Dec 12 2019, 1:50 PM
GitHub <noreply@github.com> committed rGc49aea584d54: Merge pull request #317 from smeenai/fix-class-stubs-test (authored by compnerd).
Merge pull request #317 from smeenai/fix-class-stubs-test
Dec 12 2019, 1:41 PM
GitHub <noreply@github.com> committed rGa3e94101c4f9: Merge pull request #302 from compnerd/diagnostic-count (authored by compnerd).
Merge pull request #302 from compnerd/diagnostic-count
Dec 12 2019, 1:30 PM
GitHub <noreply@github.com> committed rG77e8aa6fbded: Merge pull request #298 from compnerd/diagnostics (authored by compnerd).
Merge pull request #298 from compnerd/diagnostics
Dec 12 2019, 1:26 PM
GitHub <noreply@github.com> committed rG50763a26b5b1: Merge pull request #296 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #296 from plotfi/upstream-with-swift
Dec 12 2019, 1:25 PM
GitHub <noreply@github.com> committed rG6205a38d152f: Merge pull request #295 from plotfi/upstream-with-swift-2 (authored by compnerd).
Merge pull request #295 from plotfi/upstream-with-swift-2
Dec 12 2019, 1:25 PM
GitHub <noreply@github.com> committed rGca6573ea5c05: Merge pull request #294 from plotfi/upstream-with-swift (authored by compnerd).
Merge pull request #294 from plotfi/upstream-with-swift
Dec 12 2019, 1:24 PM
compnerd committed rG6152f711e9cd: Edit: adjust for SVN r347417 (authored by compnerd).
Edit: adjust for SVN r347417
Dec 12 2019, 12:09 PM

Dec 10 2019

compnerd added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Should probably add a check for __block variables.

Dec 10 2019, 7:13 PM · Restricted Project

Dec 9 2019

compnerd added a comment to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.

The std::transform better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.

Dec 9 2019, 1:02 PM · Restricted Project
compnerd added a comment to D69535: build: improve python check for Windows.

@stella.stamenova ping

Dec 9 2019, 1:02 PM · Restricted Project
compnerd added inline comments to D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp.
Dec 9 2019, 7:47 AM · Restricted Project
compnerd added inline comments to D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting.
Dec 9 2019, 7:47 AM · Restricted Project

Dec 7 2019

compnerd committed rG4ec7bb42aa67: Symbol: use elaborated types for `DataExtractor` (authored by compnerd).
Symbol: use elaborated types for `DataExtractor`
Dec 7 2019, 11:27 AM

Dec 6 2019

compnerd added inline comments to D70026: [cmake] Always build the libLLVM shared library.
Dec 6 2019, 3:21 PM · Restricted Project
compnerd accepted D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs..
Dec 6 2019, 3:21 PM · Restricted Project

Dec 4 2019

compnerd accepted D70834: [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols..

LGTM with the additional test for the size/type mismatch validation.

Dec 4 2019, 9:12 PM · Restricted Project
compnerd added reviewers for D70764: build: reduce CMake handling for zlib: ldionne, tstellar.
Dec 4 2019, 11:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 3 2019

compnerd added a comment to D70764: build: reduce CMake handling for zlib.

Having one canonical variable controlling zlib support seems indeed desirable.

With this patch, what is the output of llvm-config --system-libs ?

@compnerd What's the answer to this for this patch?

Dec 3 2019, 10:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
compnerd committed rGabe8de29c4ae: Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name"" (authored by compnerd).
Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name""
Dec 3 2019, 9:37 AM
compnerd added a reverting change for rG2e75681b55ab: Temporarily revert "build: avoid hardcoding the libxml2 library name" as it…: rGabe8de29c4ae: Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name"".
Dec 3 2019, 9:37 AM
compnerd added a comment to D69412: build: avoid hardcoding the libxml2 library name.

There isn't a workaround for this, its just a bug in our CMake. I've fixed the issue with our CMake logic in GIT 372ad32734ecb455f9fb4d0601229ca2dfc78b66.

Dec 3 2019, 9:28 AM · Restricted Project
compnerd committed rG372ad32734ec: llvm-config: do not link absolute paths with `-l` (authored by compnerd).
llvm-config: do not link absolute paths with `-l`
Dec 3 2019, 9:00 AM

Nov 29 2019

compnerd requested changes to D70026: [cmake] Always build the libLLVM shared library.
Nov 29 2019, 10:59 AM · Restricted Project