compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (302 w, 1 d)

Recent Activity

Today

compnerd requested changes to D52210: [LLVM-C] Add C APIs to access DebugLoc info.
Tue, Sep 25, 10:33 AM

Yesterday

compnerd closed D52252: Driver: render arguments for the embedded bitcode correctly.

SVN r342929 (with tests)

Mon, Sep 24, 10:50 PM
compnerd accepted D52252: Driver: render arguments for the embedded bitcode correctly.
Mon, Sep 24, 10:50 PM
compnerd committed rL342929: Driver: render arguments for the embedded bitcode correctly.
Driver: render arguments for the embedded bitcode correctly
Mon, Sep 24, 4:52 PM
compnerd committed rC342929: Driver: render arguments for the embedded bitcode correctly.
Driver: render arguments for the embedded bitcode correctly
Mon, Sep 24, 4:52 PM

Sat, Sep 22

compnerd added a comment to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..

This seems reasonable to me, however, I would want to give @scanon a few (work) days to see if he has any comments on the actual implementation of logb.

Sat, Sep 22, 10:11 PM

Fri, Sep 21

compnerd added inline comments to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
Fri, Sep 21, 1:20 PM
compnerd accepted D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`..

This looks fine to me, but this definitely should have an accompanying test.

Fri, Sep 21, 11:38 AM
compnerd accepted D51999: build: add libedit to include paths.

LGTM, thanks!

Fri, Sep 21, 11:29 AM

Thu, Sep 20

compnerd added a comment to D51999: build: add libedit to include paths.

It definitely shouldn't be PUBLIC, PRIVATE makes sense for this inclusion. Is there a library that pulls in the dependency (that is, do the other libraries need it due to lldbHost? If so, just adding it as INTERFACE on that library should be sufficient).

Thu, Sep 20, 4:21 PM

Wed, Sep 19

compnerd committed rL342581: test: actually fix the condition properly.
test: actually fix the condition properly
Wed, Sep 19, 12:22 PM
compnerd committed rC342581: test: actually fix the condition properly.
test: actually fix the condition properly
Wed, Sep 19, 12:21 PM
compnerd committed rL342569: test: improve condition for the check.
test: improve condition for the check
Wed, Sep 19, 11:42 AM
compnerd committed rC342569: test: improve condition for the check.
test: improve condition for the check
Wed, Sep 19, 11:42 AM
compnerd committed rC342565: Sema: handle `wint_t` more carefully for printf checking.
Sema: handle `wint_t` more carefully for printf checking
Wed, Sep 19, 11:15 AM
compnerd committed rL342565: Sema: handle `wint_t` more carefully for printf checking.
Sema: handle `wint_t` more carefully for printf checking
Wed, Sep 19, 11:14 AM
compnerd committed rC342557: Basic: correct `__WINT_TYPE__` on Windows.
Basic: correct `__WINT_TYPE__` on Windows
Wed, Sep 19, 9:21 AM
compnerd committed rL342557: Basic: correct `__WINT_TYPE__` on Windows.
Basic: correct `__WINT_TYPE__` on Windows
Wed, Sep 19, 9:20 AM
compnerd added inline comments to D52266: [clang-cl] Provide separate flags for all the /O variants.
Wed, Sep 19, 8:04 AM

Tue, Sep 18

compnerd created D52252: Driver: render arguments for the embedded bitcode correctly.
Tue, Sep 18, 3:48 PM
compnerd added inline comments to D51868: [libcxx] Build and test fixes for Windows.
Tue, Sep 18, 3:31 PM
compnerd requested changes to D51999: build: add libedit to include paths.

Can you use target_include_directories instead and do this only on lldbHost instead please? That restricts the inclusion to just that target, which would help prevent accidental inclusion of the headers. That is the change should be to source/Host/CMakeLists.txt.

Tue, Sep 18, 3:29 PM
compnerd committed rC342515: Driver: extract a local variable for the Toolchain (NFC).
Driver: extract a local variable for the Toolchain (NFC)
Tue, Sep 18, 3:17 PM
compnerd committed rL342515: Driver: extract a local variable for the Toolchain (NFC).
Driver: extract a local variable for the Toolchain (NFC)
Tue, Sep 18, 3:17 PM
compnerd committed rC342512: Driver: hoist `-mlimit-float-precision` (NFC).
Driver: hoist `-mlimit-float-precision` (NFC)
Tue, Sep 18, 2:14 PM
compnerd committed rL342512: Driver: hoist `-mlimit-float-precision` (NFC).
Driver: hoist `-mlimit-float-precision` (NFC)
Tue, Sep 18, 2:14 PM
compnerd committed rCRT342511: build: clean up some unnecessary cached variables.
build: clean up some unnecessary cached variables
Tue, Sep 18, 1:34 PM
compnerd committed rL342511: build: clean up some unnecessary cached variables.
build: clean up some unnecessary cached variables
Tue, Sep 18, 1:34 PM

Mon, Sep 17

compnerd committed rL342425: build: fix standalone builds for compiler-rt on Darwin.
build: fix standalone builds for compiler-rt on Darwin
Mon, Sep 17, 4:27 PM
compnerd committed rCRT342425: build: fix standalone builds for compiler-rt on Darwin.
build: fix standalone builds for compiler-rt on Darwin
Mon, Sep 17, 4:26 PM

Wed, Sep 12

compnerd committed rL342109: ARM: correct the relocation type for `bl` on WoA.
ARM: correct the relocation type for `bl` on WoA
Wed, Sep 12, 9:58 PM

Tue, Sep 11

compnerd accepted D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Sure, I think I can live with this.

Tue, Sep 11, 9:11 AM

Mon, Sep 10

compnerd committed rL341877: clang-check: rename the local FixItAction.
clang-check: rename the local FixItAction
Mon, Sep 10, 3:58 PM
compnerd committed rC341877: clang-check: rename the local FixItAction.
clang-check: rename the local FixItAction
Mon, Sep 10, 3:58 PM

Aug 20 2018

compnerd committed rC340228: libclang: add install/distribution targets for python.
libclang: add install/distribution targets for python
Aug 20 2018, 3:51 PM
compnerd committed rL340228: libclang: add install/distribution targets for python.
libclang: add install/distribution targets for python
Aug 20 2018, 3:51 PM

Aug 14 2018

compnerd added inline comments to D50144: Add Windows support for the GNUstep Objective-C ABI V2..
Aug 14 2018, 10:54 AM

Jul 31 2018

compnerd accepted D49929: [AArch64] Disallow the MachO specific .loh directive for windows.

@t.p.northover - okay, in that case, we can leave it here. I suppose that this is caused by the pair-wise split relocations à la IMAGE_REL_ARM_MOV32T for PE/COFF?

Jul 31 2018, 3:32 PM

Jul 30 2018

compnerd added a comment to D49936: [ARM] Support the .isnt directive for MachO and COFF targets.

@peter.smith, yeah, I think that sharing this might make it more complex. This looks fine to me, any other concerns?

Jul 30 2018, 1:19 PM
compnerd accepted D49937: [ARM] Allow automatically deducing the thumb instruction size for .inst.
Jul 30 2018, 1:12 PM
compnerd accepted D49935: [AArch64] Support the .inst directive for MachO and COFF targets.
Jul 30 2018, 1:10 PM
compnerd requested changes to D49929: [AArch64] Disallow the MachO specific .loh directive for windows.

Can you move the LOH handling into the DarwinAsmParser rather than adding the MachO specific check here please?

Jul 30 2018, 1:08 PM

Jul 20 2018

compnerd accepted D48702: objdump: Better handling of Mach-O universal binaries.
Jul 20 2018, 9:44 AM
compnerd added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Ah, I see. I think I had overlooked the .incbin.

Jul 20 2018, 9:38 AM

Jul 18 2018

compnerd added inline comments to D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Jul 18 2018, 10:52 AM
compnerd accepted D49314: [OpenEmbedded] Add a unittest for aarch64-oe-linux.
Jul 18 2018, 10:48 AM

Jul 17 2018

compnerd accepted D49055: [compiler-rt] [builtins] Implement the __chkstk function for ARM for MinGW.

Seems fine with the adjusted comment

Jul 17 2018, 11:57 AM

Jul 6 2018

compnerd added a comment to D48993: [CMake] Give Python module install command a component name.

The install- target is created by add_llvm_install_targets, not by the component. The component is part of CMake itself, and is controlled by the CMAKE_INSTALL_DEFAULT_COMPONENT_NAME.

Jul 6 2018, 9:54 AM

Jul 5 2018

compnerd accepted D48568: objdump: Support newer ObjC image info flags.
Jul 5 2018, 3:16 PM
compnerd added inline comments to D48702: objdump: Better handling of Mach-O universal binaries.
Jul 5 2018, 3:15 PM
compnerd accepted D48861: Add OpenEmbedded vendor.
Jul 5 2018, 3:04 PM
compnerd accepted D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp.
Jul 5 2018, 3:03 PM
compnerd added inline comments to D48988: Debug prefix map for machine code emission.
Jul 5 2018, 3:02 PM
compnerd accepted D48989: -fdebug-prefix-map option for cc1as.

This seems reasonable if you need the support in the assembler. However, please add a test to ensure that the paths are mapped when invoking the assembler rather than the compiler.

Jul 5 2018, 2:52 PM
compnerd accepted D48993: [CMake] Give Python module install command a component name.
Jul 5 2018, 2:50 PM

Jun 25 2018

compnerd added a comment to D48568: objdump: Support newer ObjC image info flags.

Nice! I like the changes to the objdump, but, would it be possible to roundtrip the object files being added through obj2yaml and yaml2obj rather than checking in binaries?

Jun 25 2018, 2:19 PM

Jun 20 2018

compnerd accepted D48105: [llvm][Instrumentation] Add Call Graph Profile pass.

Thanks for the changes!

Jun 20 2018, 9:36 PM

Jun 19 2018

compnerd committed rL335058: docs: document CodeView directives.
docs: document CodeView directives
Jun 19 2018, 9:52 AM

Jun 14 2018

compnerd accepted D48201: [cmake] Add linker detection for Apple platforms.

It really is unfortunate that linkers can spell version differently :-(. It would be really nice to be able to unify the linker version detection.

Jun 14 2018, 4:09 PM

Jun 13 2018

compnerd accepted D48105: [llvm][Instrumentation] Add Call Graph Profile pass.

I assume that there is/will be a different change to the frontend to enable this for users?

Jun 13 2018, 1:33 PM
compnerd committed rL334627: IR: fix documentation markup.
IR: fix documentation markup
Jun 13 2018, 10:55 AM

Jun 12 2018

compnerd added inline comments to D48105: [llvm][Instrumentation] Add Call Graph Profile pass.
Jun 12 2018, 8:32 PM
compnerd accepted D46971: [DWARF] Get RA from RA register even if it appears unused.

x86-Linux-only test is good. LG with the discussed changes.

Jun 12 2018, 8:05 PM
compnerd added inline comments to D48060: Introduce lldb-framework CMake target and centralize its logic.
Jun 12 2018, 4:30 PM
compnerd accepted D47873: [AArch64] Tighten up directives tests.

Nice cleanup! Thanks for doing this

Jun 12 2018, 4:22 PM

Jun 11 2018

compnerd accepted D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

This makes much more sense. Thanks @joerg

Jun 11 2018, 2:09 PM

Jun 7 2018

compnerd accepted D47897: Check for process_vm_readv using CheckSymbolExists.

This should be functionally identical and is much cleaner. Thanks!

Jun 7 2018, 12:56 PM

Jun 3 2018

compnerd committed rL333863: Python: adjust the include directories.
Python: adjust the include directories
Jun 3 2018, 7:12 PM
compnerd added inline comments to D46726: build: use cmake to find the libedit content.
Jun 3 2018, 6:06 PM

May 29 2018

compnerd added inline comments to D46791: Make -gsplit-dwarf generally available.
May 29 2018, 3:58 PM
compnerd added a comment to D46971: [DWARF] Get RA from RA register even if it appears unused.

It would be nice if we had a test case added for this, but, seems correct to me.

May 29 2018, 3:54 PM
compnerd accepted D47381: [CMake] Use normalized Windows target triples.

@rnk - Id say something more stronger than on board for this change. I think that this is a great cleanup, makes everything much clearer and generally simplifies the model that you have to work with. I didn't look at the changes to the test very carefully (they should be mechanical in nature). The rest LGTM.

May 29 2018, 3:50 PM

May 23 2018

compnerd added a reviewer for D40221: [clang-format] Parse blocks in braced lists: benhamilton.
May 23 2018, 8:23 AM

May 22 2018

compnerd closed D46726: build: use cmake to find the libedit content.

SVN r333041

May 22 2018, 4:29 PM
compnerd committed rL333041: build: use cmake to find the libedit content.
build: use cmake to find the libedit content
May 22 2018, 4:28 PM

May 21 2018

compnerd updated the diff for D46726: build: use cmake to find the libedit content.

fix regex

May 21 2018, 2:31 PM
compnerd added inline comments to D46726: build: use cmake to find the libedit content.
May 21 2018, 2:29 PM

May 20 2018

compnerd committed rC332821: Sema: diagnose invalid catch parameter in ObjC.
Sema: diagnose invalid catch parameter in ObjC
May 20 2018, 12:32 PM
compnerd committed rL332821: Sema: diagnose invalid catch parameter in ObjC.
Sema: diagnose invalid catch parameter in ObjC
May 20 2018, 12:30 PM

May 11 2018

compnerd added inline comments to D46726: build: use cmake to find the libedit content.
May 11 2018, 11:47 AM

May 10 2018

compnerd created D46726: build: use cmake to find the libedit content.
May 10 2018, 2:12 PM

May 2 2018

compnerd committed rL331431: lit: flesh out `SubsituteCaptures` further.
lit: flesh out `SubsituteCaptures` further
May 2 2018, 9:50 PM

May 1 2018

compnerd closed D45814: Fix an assertion when -print-prog-name=.

SVN r331296

May 1 2018, 11:44 AM
compnerd committed rL331296: Driver: fix an assertion with `-print-prog-name=`.
Driver: fix an assertion with `-print-prog-name=`
May 1 2018, 11:44 AM
compnerd committed rC331296: Driver: fix an assertion with `-print-prog-name=`.
Driver: fix an assertion with `-print-prog-name=`
May 1 2018, 11:44 AM
compnerd committed rL331282: Support: assume `std::is_final` with MSVC.
Support: assume `std::is_final` with MSVC
May 1 2018, 9:50 AM
compnerd closed D46164: Support: assume `std::is_final` with MSVC.

SVN r331282

May 1 2018, 9:50 AM

Apr 27 2018

compnerd accepted D45814: Fix an assertion when -print-prog-name=.

Do you have commit access or do you need someone to commit this on your behalf?

Apr 27 2018, 9:09 AM

Apr 26 2018

compnerd created D46164: Support: assume `std::is_final` with MSVC.
Apr 26 2018, 5:58 PM
compnerd added a comment to D45814: Fix an assertion when -print-prog-name=.

I'm torn on this. The other -print options will perform the validation implicitly at the higher level before calling the inner functions. It is certainly reasonable to support that, but, for the common path, this check seems unnecessary (and this function is used elsewhere in clang). There is a similar problem that exists with -print-file-name=. We should probably fix both at the same time. Can you also please add a test case for this?

Apr 26 2018, 5:52 PM

Apr 22 2018

compnerd accepted D31275: [lldb] Fix lldb build on musl.
Apr 22 2018, 7:38 PM · Restricted Project
compnerd accepted D45935: Add dump method for selectors.

LGTM

Apr 22 2018, 7:37 PM

Apr 19 2018

compnerd added inline comments to D45319: [Atomics] warn about misaligned atomic accesses using libcalls.
Apr 19 2018, 5:48 PM · Restricted Project
compnerd accepted D45771: [Driver] Support for -save-stats in AddGoldPlugin..

Some cleanup suggestions included, but I like the change overall.

Apr 19 2018, 5:44 PM
compnerd committed rL330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Apr 19 2018, 4:20 PM
compnerd committed rC330378: Implement proper support for `-falign-functions`.
Implement proper support for `-falign-functions`
Apr 19 2018, 4:20 PM

Apr 16 2018

compnerd committed rL330161: Revert "build: reserve `--color-diagnostics` for lld".
Revert "build: reserve `--color-diagnostics` for lld"
Apr 16 2018, 3:00 PM
compnerd committed rL330158: build: reserve `--color-diagnostics` for lld.
build: reserve `--color-diagnostics` for lld
Apr 16 2018, 2:09 PM

Apr 14 2018

compnerd added a comment to D45639: [Driver] Support default libc++ library location on Darwin.

I'm not sure I understand this. The proper location for libc++ on the darwin layout is in the SDK, not relative to the driver. The default behaviour is similar to cross-compiling, and with a (derived) SDK. This definitely needs to be reviewed by @dexonsmith

Apr 14 2018, 3:41 PM
compnerd added a comment to D45383: Limit types of builtins that can be redeclared..

Snipping bits from va_defs.h:

Apr 14 2018, 3:39 PM · Restricted Project