- User Since
- Dec 9 2012, 11:41 PM (537 w, 1 d)
Wed, Mar 22
Tue, Mar 21
Update to include additional behaviour and reference INCLUDE and LIB.
Mon, Mar 20
Looks reasonable I guess - but I think it would be good to mention the env variables INCLUDE and LIB too, for alternative ways of finding the same things - even if it's not strictly the same as what this new section talks about.
Wed, Mar 15
Tue, Mar 14
Yeah, I think that we will have to slowly erode the differences, the model for the pair-wise relocations here is a challenge.
Mon, Mar 13
Thu, Mar 9
Sure thing, I can try to write up some details about that @hans!
Wed, Mar 8
Tue, Mar 7
Mon, Mar 6
Just a friendly reminder, I'd like to get this merged to do a follow up change to improve some of the usability of these flags.
Wed, Mar 1
Yeah, I suspect that would be difficult. Additionally, these are aliases, so they should already have testing coverage through the existing tests.
Tue, Feb 28
Feb 16 2023
We do have other examples of ternary state options., and making this ternary for the sake of compatibility is an intriguing idea. However, I also ascribe to POLA/POLS. Mapping LLVM_ENABLE_UNWIND_TABLES to -funwind-tables seems pretty reasonable to me. The only time that you would want to disable these is if it is an embedded context where you do not care about debugging or crash analytics, where you should pretty quickly see the size impact. If this plays out to be a problem to be enabled by default we can always revisit the ternary state.
Feb 3 2023
Jan 5 2023
I think that the current release note should be sufficient. This is handling the same scenario in a different path.
Jan 4 2023
Jan 3 2023
Dec 23 2022
Dec 22 2022
Dec 21 2022
Dec 20 2022
Further reduce the test case. We create the splat and shuffle, offset it by vlenb and return the generated splat. This reduces down to the minimal assembly sequence that would exhibit the issue. If we were to accidentally truncate the scale, we would drop the read of vlenb and the adjustment for the shuffle.
Further reduce test case by creating a hand written synthetic test case. We can get away with a 2-iteration unrolled loop avoiding any phi branches. The previous overflow would improperly remove the increment in between the two iterations.
Partially address feedback from Craig, address feedback from Jessica.
Dec 19 2022
Given the UB and potential miscompile, reverted in 9b92f70d4758f75903ce93feaba5098130820d40.
I'm seeing a potential miscompilation on RISCV64 with this particular change: https://github.com/llvm/llvm-project/issues/59594
Dec 15 2022
Thanks @fsb4000 (and @CaseyCarter)! I think that due to the shipped version, it makes sense to do this still. Using standard semantics in general I think is preferable, since nothing prevents another compiler implementation to still do something similar.
Dec 14 2022
Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further.
Dec 13 2022
@fsb4000 is my reading correct that MSVC will look into trying to handle static inline even though it is a GNUism? I wonder if we should consider limiting the use of static inline to C mode rather than including C++. I also wonder if I can loosen it similarly to avoid the issue I'm running into (which @STL_MSFT correctly identified - modules).
Dec 11 2022
Thanks! This looks good. Personally, I'd use 0x8 instead of 8, which might make it more obvious that this is intentional (and that it is a bitmask).
Dec 9 2022
Could you please also add a test case for .rodata.suffix as that is added as a case as well.
(Accepting Revision for Closing)
I missed the trailing number of the differential revision, and it failed to tie it to this. The commit is at https://github.com/llvm/llvm-project/commit/707cc06e1570b5966efcd6a9124191c80fa7a754
@rnk is going to be out for a while, so any concerns can be addressed in a follow up.
Dec 8 2022
Might be useful to add a reference to https://developer.arm.com/documentation/dht0008/a/ch01s02s01 in the commit message.
Seems like a straightforward change for the tests to repair them on Android.
Dec 6 2022
This is definitely a nice cleanup. There is a way to use .irp to have it count, but this is fine for now.
Update to avoid use of the -0 trick.
Add a test case for member data.
Dec 3 2022
Dec 2 2022
Address feedback from review