Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (348 w, 5 d)

Recent Activity

Yesterday

compnerd added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

Python eggs may be another option which might be an easier way forward.

Fri, Aug 16, 3:44 PM · Restricted Project
compnerd added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

At least for the from-source distribution, where the destination of the image is the build host, Python_EXECUTABLE is definitely preferable (e.g. #!@Python_EXECUTABLE@). Furthermore, there is no reason to assume that /usr/bin/env python3 will give you the same python 3 as what was given to cmake (you can control that with -DPython_EXECUTABLE=...). I think that requiring the user to specify the tool is possibly the best option - that is completely remove the shebang as that ensures that shifts the burden of selection to the user. Another option may be to use something like p2exe and create self-contained tools.

Fri, Aug 16, 3:42 PM · Restricted Project

Tue, Aug 13

compnerd added a comment to D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments..

Ugh, this is still not the most structured handling of the arguments. But, yeah, this seems like it should be equivalent. Fine by me if @aaron.ballman has no more comments.

Tue, Aug 13, 2:59 PM · Restricted Project, Restricted Project
compnerd added a comment to D63978: Clang Interface Stubs merger plumbing for Driver.

Tests?

Tue, Aug 13, 2:49 PM · Restricted Project

Sat, Aug 10

compnerd added inline comments to D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases.
Sat, Aug 10, 9:35 PM · Restricted Project, Restricted Project

Fri, Aug 9

compnerd committed rGa5af238343e7: CodeGen: ensure 8-byte aligned String Swift CF ABI (authored by compnerd).
CodeGen: ensure 8-byte aligned String Swift CF ABI
Fri, Aug 9, 12:30 PM
compnerd committed rL368471: CodeGen: ensure 8-byte aligned String Swift CF ABI.
CodeGen: ensure 8-byte aligned String Swift CF ABI
Fri, Aug 9, 12:28 PM

Thu, Aug 8

compnerd accepted D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions.

Seems like it should be equivalent.

Thu, Aug 8, 2:16 PM · Restricted Project, Restricted Project

Wed, Aug 7

compnerd added inline comments to D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints.
Wed, Aug 7, 3:19 PM · Restricted Project, Restricted Project
compnerd added a comment to D65831: libc++: add `-include` or `/FI` to the interface compile definitions.

Hmm, yes, it is for use from the build tree. I don't see how INTERFACE_INCLUDE_DIRECTORIES can do a -include though. It has to be INTERFACE_COMPILE_OPTIONS or INTERFACE_COMPILE_DEFINITIONS.

Wed, Aug 7, 1:29 PM

Tue, Aug 6

compnerd added inline comments to D65839: [Driver] Add verbatim dry run option.
Tue, Aug 6, 8:37 PM · Restricted Project
compnerd created D65831: libc++: add `-include` or `/FI` to the interface compile definitions.
Tue, Aug 6, 3:07 PM
compnerd added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

@lhames - I like the logAllUnhandledErrors!

Tue, Aug 6, 2:55 PM · Restricted Project, Restricted Project
compnerd added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

@gribozavr I think that this usage here is actually useful because it
a) tests the actual behaviour
b) provides example code for other users

Tue, Aug 6, 2:44 PM · Restricted Project, Restricted Project
compnerd accepted D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.
Tue, Aug 6, 1:22 PM · Restricted Project
compnerd added inline comments to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Tue, Aug 6, 1:08 PM · Restricted Project
compnerd added inline comments to D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly.
Tue, Aug 6, 8:26 AM · Restricted Project

Mon, Aug 5

compnerd added inline comments to D65704: DirectoryWatcher::create: Adding better error handling..
Mon, Aug 5, 9:43 PM · Restricted Project, Restricted Project

Sun, Aug 4

compnerd added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

-ldl doesn't work on all platforms (e.g. android, FreeBSD, etc). -lpthread is wrong - if you want to add that, I think that we need to improve the -thread-model flag in clang first (it currently just always passes posix, which is ignored; but would identify the threading model). -lpthread is wrong - consider building on Solaris with Solaris threads rather than POSIX threads, or on Windows with the Win32 threading. This really is inline with the work that needs to be finished up with having library link dependencies for static libraries (i.e. #pragma comment(lib, …)).

Sun, Aug 4, 11:20 AM · Restricted Project

Sat, Aug 3

compnerd added a comment to D65704: DirectoryWatcher::create: Adding better error handling..

BTW, I think that we should add a test case to ensure that we see the error in the case that the inotify fds are exhausted. We should be able to create a process and set the limit for that process to 0/1 and use that to trigger the failure.

Sat, Aug 3, 5:34 PM · Restricted Project, Restricted Project
compnerd added a comment to D65704: DirectoryWatcher::create: Adding better error handling..

Rather than silently ignoring tests when the DirectoryWatcher isn't created, can you please print an error message and exit with an error code to indicate the test failed?

Sat, Aug 3, 5:31 PM · Restricted Project, Restricted Project

Mon, Jul 29

compnerd added inline comments to D65409: [ProcessWindows] Choose a register context file by prepocessor.
Mon, Jul 29, 2:05 PM · Restricted Project, Restricted Project

Fri, Jul 26

compnerd accepted D65307: Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray.
Fri, Jul 26, 4:27 PM · Restricted Project, Restricted Project

Thu, Jul 25

compnerd added inline comments to D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3..
Thu, Jul 25, 4:41 PM · Restricted Project, Restricted Project
compnerd added inline comments to D65307: Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray.
Thu, Jul 25, 4:27 PM · Restricted Project, Restricted Project
compnerd committed rG3bdb7a904413: Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created"" (authored by compnerd).
Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created""
Thu, Jul 25, 2:01 PM
compnerd committed rL367055: Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created"".
Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created""
Thu, Jul 25, 2:00 PM
compnerd committed rG930df11a0d00: CodeGen: ensure placeholder instruction for cleanup is created (authored by compnerd).
CodeGen: ensure placeholder instruction for cleanup is created
Thu, Jul 25, 11:02 AM
compnerd committed rL367042: CodeGen: ensure placeholder instruction for cleanup is created.
CodeGen: ensure placeholder instruction for cleanup is created
Thu, Jul 25, 11:01 AM
compnerd closed D64656: Ensure placeholder instruction for cleanup is created.

SVN r367042

Thu, Jul 25, 11:01 AM · Restricted Project

Wed, Jul 24

compnerd added inline comments to D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2..
Wed, Jul 24, 8:29 AM · Restricted Project, Restricted Project

Tue, Jul 23

compnerd added a comment to D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2..

This looks good to me generally. I don't fully understand the reason for u being kept, is that something you intend to clean up in a subsequent patch?

Tue, Jul 23, 9:22 PM · Restricted Project, Restricted Project
compnerd accepted D64871: [llvm-lipo] Implement alignment function in -create.
Tue, Jul 23, 9:19 PM · Restricted Project

Sat, Jul 20

compnerd added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Sat, Jul 20, 12:10 PM · Restricted Project
compnerd committed rGe97f2f33e757: build: allow the user to specify `llvm-tblgen` (authored by compnerd).
build: allow the user to specify `llvm-tblgen`
Sat, Jul 20, 11:00 AM
compnerd committed rL366639: build: allow the user to specify `llvm-tblgen`.
build: allow the user to specify `llvm-tblgen`
Sat, Jul 20, 10:58 AM

Jul 17 2019

compnerd added inline comments to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.
Jul 17 2019, 2:16 PM · Restricted Project, Restricted Project

Jul 16 2019

compnerd added a comment to D64837: [cmake] Convert the NATIVE llvm build process to be project agnostic.

I'm pretty sure that this doesn't work for Visual Studio (where you do not have a cross-compiler).

Jul 16 2019, 5:56 PM · Restricted Project
compnerd accepted D64781: Silence backend complaints on x86 Android.

That is indeed a typo. I somehow ended up copying the driver flag instead of the feature flag. Thanks for fixing this!

Jul 16 2019, 8:50 AM · Restricted Project

Jul 15 2019

compnerd accepted D64772: Allow for vendor prefixes in a list test.

Yeah, that makes sense, the common path uses {{.*}} as the value itself is uninteresting.

Jul 15 2019, 4:36 PM · Restricted Project, Restricted Project
compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 10:45 AM · Restricted Project
compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 10:31 AM · Restricted Project
compnerd added a comment to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

Thats what I get for not having coffee before responding. objdump is used quite a bit in tests as well (objdump -t | grep ..., objdump -h | grep ..., etc).

Jul 15 2019, 10:13 AM · Restricted Project
compnerd added a comment to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

objcopy is often used in autotools to run tests of what the compiler is doing. I'm afraid that changing that behaviour will break the autoconf tests which rely on the behaviour (a.out is what the compiler generates by default, and that is why the tool defaults to that filename). So, if you have something like the following:

Jul 15 2019, 8:49 AM · Restricted Project

Jul 14 2019

compnerd accepted D64641: PDB HashTable: Make iterator type const.

Yeah, mutations of the hashtable during iteration would be bad. LGTM.

Jul 14 2019, 6:46 PM · Restricted Project
compnerd requested changes to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

This breaks compatibility with objdump. Please ensure that the original behavior is preserved when invoked as objdump rather than llvm-objdump.

Jul 14 2019, 6:46 PM · Restricted Project
compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 14 2019, 6:42 PM · Restricted Project

Jul 12 2019

compnerd accepted D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType.

Seems that all the comments have been addressed and this is purely code motion. LGTM

Jul 12 2019, 10:12 AM · Restricted Project

Jul 11 2019

compnerd added inline comments to D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin.
Jul 11 2019, 2:32 PM · Restricted Project
compnerd added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Jul 11 2019, 9:51 AM · Restricted Project

Jul 9 2019

compnerd added a comment to D64380: Add 'require_designated_init' and 'required' attribute to clang.

I don't see any cases where [[clang::required]] is tested, am I missing something?

Jul 9 2019, 5:07 PM · Restricted Project
compnerd committed rG97d6fcce4ec6: build: use multiple `install` rather than building up a list (authored by compnerd).
build: use multiple `install` rather than building up a list
Jul 9 2019, 2:48 PM
compnerd committed rL365562: build: use multiple `install` rather than building up a list.
build: use multiple `install` rather than building up a list
Jul 9 2019, 2:43 PM
compnerd closed D64383: build: use multiple `install` rather than building up a list.

SVN r365562

Jul 9 2019, 2:43 PM
compnerd added a comment to D64383: build: use multiple `install` rather than building up a list.

@ldionne - that was exactly the motivation for this change - it always takes me a couple of reads to figure out what we are trying to do here.

Jul 9 2019, 8:02 AM

Jul 8 2019

compnerd created D64383: build: use multiple `install` rather than building up a list.
Jul 8 2019, 6:10 PM
compnerd added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Jul 8 2019, 6:00 PM · Restricted Project
compnerd added reviewers for D64380: Add 'require_designated_init' and 'required' attribute to clang: aaron.ballman, rsmith.
Jul 8 2019, 5:41 PM · Restricted Project

Jul 7 2019

compnerd committed rG842f55f3efe4: Process: generalise Windows thread setup (authored by compnerd).
Process: generalise Windows thread setup
Jul 7 2019, 11:01 AM
compnerd committed rL365282: Process: generalise Windows thread setup.
Process: generalise Windows thread setup
Jul 7 2019, 11:00 AM

Jul 6 2019

compnerd accepted D64292: [ARM] Add support for MSVC stack cookie checking.
Jul 6 2019, 7:46 PM · Restricted Project

Jul 5 2019

compnerd accepted D64109: Standardize on MSVC behavior for triples with no environment.

I'm happy to see this finally happening, it makes much more sense.

Jul 5 2019, 9:17 AM · Restricted Project

Jul 4 2019

compnerd committed rG1522073fedc2: Plugins: permit building on Windows ARM64 (authored by compnerd).
Plugins: permit building on Windows ARM64
Jul 4 2019, 12:29 PM
compnerd committed rL365155: Plugins: permit building on Windows ARM64.
Plugins: permit building on Windows ARM64
Jul 4 2019, 12:29 PM
compnerd committed rGbce9d8b138ca: docs: add documentation for `LIBCXX_INCLUDE_TESTS` (authored by compnerd).
docs: add documentation for `LIBCXX_INCLUDE_TESTS`
Jul 4 2019, 12:09 PM
compnerd committed rL365154: docs: add documentation for `LIBCXX_INCLUDE_TESTS`.
docs: add documentation for `LIBCXX_INCLUDE_TESTS`
Jul 4 2019, 12:08 PM
compnerd closed D64214: Add documentation for LIBCXX_INCLUDE_TESTS option.

SVN r365154

Jul 4 2019, 12:08 PM
compnerd accepted D64214: Add documentation for LIBCXX_INCLUDE_TESTS option.

Generally, it is nicer to have some more context in the uploaded diff, although, in this case, it doesn't really matter.

Jul 4 2019, 11:47 AM

Jul 2 2019

compnerd added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 2 2019, 2:45 PM · Restricted Project
compnerd added inline comments to D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..
Jul 2 2019, 2:23 PM · Restricted Project, Restricted Project
compnerd added reviewers for D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.: rsmith, aaron.ballman.
Jul 2 2019, 2:06 PM · Restricted Project, Restricted Project
compnerd added a comment to D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..

The explicit list I think is way better for readability, this is a nice starting point for cleaning this up.

Jul 2 2019, 2:06 PM · Restricted Project, Restricted Project

Jun 27 2019

compnerd added a comment to D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

I don't understand the change for the PRIVATE to PUBLIC. That doesn't make a different to the import library handling, which is baked right into CMake, so that will always be handled properly irrespective of the link dependency's visibility. I think the only thing that may be needed is the Core dependency on the TestPlugin.

Jun 27 2019, 10:10 AM · Restricted Project
compnerd added inline comments to D63735: [MachOObjectFile]Added Valid Architecture Function.
Jun 27 2019, 10:03 AM · Restricted Project

Jun 26 2019

compnerd accepted D63834: [cmake] Allow config.guess to be run with MSYS on Windows.
Jun 26 2019, 2:39 PM · Restricted Project

Jun 25 2019

compnerd committed rG06036dbc6e91: MC: correct the emission of weak aliases in COFF (authored by compnerd).
MC: correct the emission of weak aliases in COFF
Jun 25 2019, 6:11 PM
compnerd committed rL364370: MC: correct the emission of weak aliases in COFF.
MC: correct the emission of weak aliases in COFF
Jun 25 2019, 6:10 PM
compnerd committed rGc32d307a49f5: android: enable double-word CAS on x64 (authored by compnerd).
android: enable double-word CAS on x64
Jun 25 2019, 2:45 PM
compnerd committed rL364352: android: enable double-word CAS on x64.
android: enable double-word CAS on x64
Jun 25 2019, 2:43 PM
compnerd closed D63774: android: enable double-word CAS on x86_64.

SVN r364352

Jun 25 2019, 2:43 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.

Jun 25 2019, 1:44 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

Move test case around

Jun 25 2019, 1:21 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

add additional context and test case

Jun 25 2019, 12:50 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus at it.

Jun 25 2019, 12:47 PM · Restricted Project
compnerd created D63774: android: enable double-word CAS on x86_64.
Jun 25 2019, 8:54 AM · Restricted Project

Jun 22 2019

compnerd committed rG6281ccea02d3: Revert "builtins: relax __iso_volatile_{load,store}32" (authored by compnerd).
Revert "builtins: relax __iso_volatile_{load,store}32"
Jun 22 2019, 7:57 PM
compnerd committed rL364147: Revert "builtins: relax __iso_volatile_{load,store}32".
Revert "builtins: relax __iso_volatile_{load,store}32"
Jun 22 2019, 7:56 PM
compnerd committed rGebae85bc4a31: builtins: relax __iso_volatile_{load,store}32 (authored by compnerd).
builtins: relax __iso_volatile_{load,store}32
Jun 22 2019, 11:57 AM
compnerd committed rL364137: builtins: relax __iso_volatile_{load,store}32.
builtins: relax __iso_volatile_{load,store}32
Jun 22 2019, 11:57 AM

Jun 21 2019

compnerd added inline comments to D63622: [Target] Hoist LanguageRuntime::GetDeclVendor.
Jun 21 2019, 9:21 AM · Restricted Project

Jun 19 2019

compnerd accepted D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..
Jun 19 2019, 6:51 PM · Restricted Project, Restricted Project
compnerd accepted D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Jun 19 2019, 11:21 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Jun 19 2019, 10:19 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Jun 19 2019, 8:57 AM · Restricted Project, Restricted Project

Jun 17 2019

compnerd added a comment to D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.

Could you please add a test to ensure that Darwin defaults to the old behaviour?

Jun 17 2019, 9:09 PM · Restricted Project
compnerd accepted D60974: Clang IFSO driver action..
Jun 17 2019, 1:00 PM · Restricted Project, Restricted Project

Jun 14 2019

compnerd accepted D63357: [Process] Remove unused field from HistoryThread.
Jun 14 2019, 7:53 PM · Restricted Project
compnerd accepted D63368: [compiler-rt] Respect CMAKE_NM.
Jun 14 2019, 7:47 PM · Restricted Project, Restricted Project
compnerd added inline comments to D63341: [llvm-lipo] Implement -thin.
Jun 14 2019, 11:30 AM · Restricted Project
compnerd committed rG2b9f6caa71f7: build: extract LLVM distribution target handling (authored by compnerd).
build: extract LLVM distribution target handling
Jun 14 2019, 11:27 AM