compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.
User Since
Dec 9 2012, 11:41 PM (223 w, 6 d)

Recent Activity

Fri, Mar 24

compnerd added inline comments to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.
Fri, Mar 24, 10:20 AM

Thu, Mar 23

compnerd added a comment to D26959: llvm-strings - dumping strings from LLVM bitcode.

As previously mentioned, if this absolutely requires that the file not be treated opaquely, then we should be putting this functionality into another tool. Perhaps llvm-bc would be a good home for this. I'd really rather LLVM-strings be kept simple and treat all input as opaque.

Thu, Mar 23, 8:00 AM

Wed, Mar 22

compnerd committed rL298550: c++filt: support COFF import thunks.
c++filt: support COFF import thunks
Wed, Mar 22, 2:27 PM
compnerd requested changes to D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.

Some of the implementations are not going to build in thumb1 mode, but would in thumb2, which is why we didnt do this uniformly. I think we need to preserve that, or rewrite the functions.

Wed, Mar 22, 11:54 AM
compnerd accepted D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373).
Wed, Mar 22, 11:51 AM
compnerd added a comment to D30904: Allow suppressing host and target info in VersionPrinter.

I think that @chandlerc is suggesting making it a CMake option (see the option function in CMake) to provide documentation for this for users. I think that is a pretty reasonable ask, as it aids in discoverability of this.

Wed, Mar 22, 11:26 AM

Tue, Mar 21

compnerd added a comment to D30904: Allow suppressing host and target info in VersionPrinter.

I think that the idea that you propose is good, however, I think that may be better to do as a follow up. This would get the immediate benefit for the tooling, and we can work out a nicer way to expose the information to the other users. Making it something which each app does means that we would need to change all the apps as well, which would be a much larger change.

Tue, Mar 21, 1:01 PM

Mon, Mar 20

compnerd added a reviewer for D30904: Allow suppressing host and target info in VersionPrinter: klimek.
Mon, Mar 20, 4:20 PM
compnerd edited reviewers for D30904: Allow suppressing host and target info in VersionPrinter, added: chandlerc, compnerd; removed: mgorny.
Mon, Mar 20, 4:18 PM

Tue, Mar 14

compnerd requested changes to D30938: builtins: Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA..

I really think that we shouldnt introduce the USE_* macros, opting to re-organise the code (separate change) and then using the appropriate macros. It avoids the layer of indirection which makes it easier for others to follow what is going on.

Tue, Mar 14, 11:10 AM
compnerd committed rL297744: DarwinParser: include limits.
DarwinParser: include limits
Tue, Mar 14, 8:30 AM

Wed, Mar 8

compnerd committed rL297291: DARWF: silence some warnings about conversions.
DARWF: silence some warnings about conversions
Wed, Mar 8, 8:15 AM

Tue, Mar 7

compnerd accepted D30696: Improve readability and correctness of the OS specific libunwind bits..

Not sure if I see the movement as being a real improvement. However, it is no worse than before, and not having the explicit list of targets is a huge win.

Tue, Mar 7, 9:52 AM

Thu, Mar 2

compnerd committed rL296769: Serialization: use the PCH chain to check PCH mode.
Serialization: use the PCH chain to check PCH mode
Thu, Mar 2, 9:49 AM

Feb 20 2017

compnerd closed D29967: Get class property selectors from property decl if it exists.

SVN r295683

Feb 20 2017, 3:57 PM
compnerd committed rL295683: Sema: use PropertyDecl for property selector.
Sema: use PropertyDecl for property selector
Feb 20 2017, 3:57 PM

Feb 19 2017

compnerd committed rL295620: Driver: inline a single caller of a function (NFC).
Driver: inline a single caller of a function (NFC)
Feb 19 2017, 2:02 PM

Feb 18 2017

compnerd committed rL295561: Revert "threading_support: make __thread_sleep_for be alertable".
Revert "threading_support: make __thread_sleep_for be alertable"
Feb 18 2017, 11:40 AM
compnerd committed rL295560: test: silence warnings on clang under clang-cl.
test: silence warnings on clang under clang-cl
Feb 18 2017, 11:40 AM
compnerd committed rL295559: math: add type promoting template definition on MSVCRT.
math: add type promoting template definition on MSVCRT
Feb 18 2017, 11:40 AM
compnerd committed rL295558: test: explicitly size enumeration.
test: explicitly size enumeration
Feb 18 2017, 11:40 AM

Feb 17 2017

compnerd committed rL295510: math: fix typo in macro.
math: fix typo in macro
Feb 17 2017, 3:20 PM
compnerd committed rL295511: test: prevent incorrect quoting of paths.
test: prevent incorrect quoting of paths
Feb 17 2017, 3:20 PM
compnerd committed rL295509: cmath: Use c99 math on a new enough msvcrt.
cmath: Use c99 math on a new enough msvcrt
Feb 17 2017, 3:20 PM
compnerd accepted D29967: Get class property selectors from property decl if it exists.

Ah, I had missed the -verify option on the test. Yes, that makes sense. Ternary may have flowed the conditional code better. Do you need someone to commit this on your behalf?

Feb 17 2017, 9:01 AM

Feb 16 2017

compnerd added a comment to D29967: Get class property selectors from property decl if it exists.

I think Im misunderstanding something. How does the test actually test what you are changing?

Feb 16 2017, 6:21 PM
compnerd committed rL295330: math: correct the MSVCRT condition.
math: correct the MSVCRT condition
Feb 16 2017, 7:59 AM
compnerd committed rL295329: threading_support: make __thread_sleep_for be alertable.
threading_support: make __thread_sleep_for be alertable
Feb 16 2017, 7:59 AM

Feb 15 2017

compnerd accepted D29882: [Builtin][ARM] #ifdef ARM vfp tests and cpu_model_tests.
Feb 15 2017, 3:08 PM
compnerd requested changes to D29967: Get class property selectors from property decl if it exists.

Please add a test for this.

Feb 15 2017, 3:06 PM

Feb 13 2017

compnerd accepted D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 13 2017, 7:57 PM
compnerd committed rL294958: config: disable thread safety analysis on COFF.
config: disable thread safety analysis on COFF
Feb 13 2017, 7:38 AM
compnerd committed rL294957: math: actually pull the declarations/overloads into std.
math: actually pull the declarations/overloads into std
Feb 13 2017, 7:38 AM
compnerd committed rL294956: test: mark another test as requiring pthreads.
test: mark another test as requiring pthreads
Feb 13 2017, 7:38 AM

Feb 12 2017

compnerd added inline comments to D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 12 2017, 2:35 PM
compnerd committed rL294918: math: follow up to SVN r294902.
math: follow up to SVN r294902
Feb 12 2017, 1:54 PM
compnerd committed rL294917: test: use char32_t rather than wchar_t.
test: use char32_t rather than wchar_t
Feb 12 2017, 1:54 PM
compnerd committed rL294909: llvm-readobj: process FreeBSD core notes.
llvm-readobj: process FreeBSD core notes
Feb 12 2017, 11:07 AM
compnerd committed rL294902: math: pull more C functions from std.
math: pull more C functions from std
Feb 12 2017, 9:49 AM
compnerd committed rL294903: test: mark requirement for pthread test.
test: mark requirement for pthread test
Feb 12 2017, 9:49 AM
compnerd committed rL294901: test: squelch -Wreturn-type error.
test: squelch -Wreturn-type error
Feb 12 2017, 9:49 AM
compnerd committed rL294899: cmath: adjust math forwards for Windows.
cmath: adjust math forwards for Windows
Feb 12 2017, 8:55 AM

Feb 11 2017

compnerd accepted D29869: [Builtin][ARM] Fix subsf3vfp for non-HF target.

*sigh* Thanks for fixing this. Please ask @hans to cherry-pick this to 4.0 as well.

Feb 11 2017, 8:53 PM
compnerd added inline comments to D29868: Recover more gracefully when __declspec is not supported as a keyword.
Feb 11 2017, 3:18 PM
compnerd committed rL294877: CodeGen: use # as the comment leader for ARC marker.
CodeGen: use # as the comment leader for ARC marker
Feb 11 2017, 3:14 PM
compnerd committed rL294872: CodeGen: annotate ObjC ARC functions with ABI constraints.
CodeGen: annotate ObjC ARC functions with ABI constraints
Feb 11 2017, 1:46 PM
compnerd committed rL294871: test: ignore some warnings in test code (NFC).
test: ignore some warnings in test code (NFC)
Feb 11 2017, 1:45 PM
compnerd committed rL294855: docs: update docs for objc_storeStrong behaviour.
docs: update docs for objc_storeStrong behaviour
Feb 11 2017, 9:35 AM
compnerd committed rL294854: CodeGen: rename variables to adhere to naming convention.
CodeGen: rename variables to adhere to naming convention
Feb 11 2017, 9:35 AM
compnerd committed rL294853: Sema: simplify conditional execution (NFC).
Sema: simplify conditional execution (NFC)
Feb 11 2017, 9:35 AM

Feb 10 2017

compnerd committed rL294808: vim: add `returned` keyword.
vim: add `returned` keyword
Feb 10 2017, 4:08 PM
compnerd closed D29648: Make NoLeadingAddr work on more than just MachO.

This was committed, sorry, dont have the revision off hand.

Feb 10 2017, 2:13 PM

Feb 9 2017

compnerd committed rL294720: test: XFAIL windows for non-portable test.
test: XFAIL windows for non-portable test
Feb 9 2017, 11:03 PM
compnerd committed rL294719: test: fix test under Windows.
test: fix test under Windows
Feb 9 2017, 11:02 PM
compnerd committed rL294716: test: allow -target usage on Windows.
test: allow -target usage on Windows
Feb 9 2017, 10:36 PM
compnerd committed rL294705: docs: add some documentation for building on Windows.
docs: add some documentation for building on Windows
Feb 9 2017, 8:09 PM
compnerd committed rL294698: __threading_support: fix windows build.
__threading_support: fix windows build
Feb 9 2017, 7:01 PM
compnerd added a reviewer for D26722: [WebAssembly] Add skeleton MC support for the Wasm container format: compnerd.
Feb 9 2017, 3:03 PM
compnerd committed rL294619: test: adjust the test for the BSD format.
test: adjust the test for the BSD format
Feb 9 2017, 12:18 PM
compnerd committed rL294615: Object: pad out BSD archive members to 8-bytes.
Object: pad out BSD archive members to 8-bytes
Feb 9 2017, 11:41 AM
compnerd committed rL294594: Object: add a comment explaining a divergence.
Object: add a comment explaining a divergence
Feb 9 2017, 7:59 AM

Feb 8 2017

compnerd committed rL294557: Object: pad BSD ar string table to 4-bytes.
Object: pad BSD ar string table to 4-bytes
Feb 8 2017, 8:37 PM
compnerd committed rL294510: build: repair cross-compilation with clang.
build: repair cross-compilation with clang
Feb 8 2017, 12:55 PM
compnerd committed rL294495: llvm-objdump: make NoLeadingAddr work on more than just MachO.
llvm-objdump: make NoLeadingAddr work on more than just MachO
Feb 8 2017, 10:23 AM
compnerd added a comment to D29648: Make NoLeadingAddr work on more than just MachO.

Will do :-)

Feb 8 2017, 8:28 AM
compnerd added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

As I mentioned before, and as @nbjoerg stated, this really belongs in your libc implementation. Since you stated that this is specifically for fuschia and you don't intend to account for the myriad of libc implementations and hosts, wouldn't it male sense to keep this in the fuschia repositories?

Feb 8 2017, 7:48 AM

Feb 7 2017

compnerd committed rL294401: Sema: add warning for c++ member variable shadowing.
Sema: add warning for c++ member variable shadowing
Feb 7 2017, 7:41 PM
compnerd accepted D29648: Make NoLeadingAddr work on more than just MachO.
Feb 7 2017, 1:10 PM
compnerd committed rL294332: Revert "Basic: match GCC behaviour for SuS macro".
Revert "Basic: match GCC behaviour for SuS macro"
Feb 7 2017, 11:11 AM

Feb 6 2017

compnerd committed rL294279: COFF: prevent nullptr dereference.
COFF: prevent nullptr dereference
Feb 6 2017, 8:39 PM
compnerd committed rL294280: COFF: ensure that we handle bad arguments.
COFF: ensure that we handle bad arguments
Feb 6 2017, 8:39 PM
compnerd committed rL294270: filesystem: return the constructed object.
filesystem: return the constructed object
Feb 6 2017, 6:58 PM

Feb 5 2017

compnerd committed rL294171: Refer to _LIBCPP_MSVC macro where applicable.
Refer to _LIBCPP_MSVC macro where applicable
Feb 5 2017, 9:38 PM
compnerd closed D28407: Refer to _LIBCPP_MSVC macro where applicable.

SVN r294171

Feb 5 2017, 9:38 PM
compnerd committed rL294148: Basic: match GCC behaviour for SuS macro.
Basic: match GCC behaviour for SuS macro
Feb 5 2017, 2:29 PM
compnerd committed rL294127: filesystem: fix n4100 conformance for `temp_directory_path`.
filesystem: fix n4100 conformance for `temp_directory_path`
Feb 5 2017, 9:33 AM

Feb 1 2017

compnerd committed rL293867: CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC).
CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC)
Feb 1 2017, 9:57 PM
compnerd accepted D29131: llvm-readobj: fix next note entry calculation and print unknown note types.
Feb 1 2017, 7:15 PM
compnerd requested changes to D29409: [Assembler] Allow buffer id to be passed to MCAsmParser.

The inline assembly uses a local buffer (which is the "main" buffer). The SLoc is tracked for where the inline assembly was instantiated for provenance. This seems conflicting with the description. Furthermore, a test case is absolutely needed.

Feb 1 2017, 7:06 PM

Jan 30 2017

compnerd accepted D28750: [lld] [cmake] Support running tests in stand-alone builds.

LG beyond the few nits.

Jan 30 2017, 6:58 PM
compnerd committed rL293577: TableGen: use fully qualified name for StringLiteral.
TableGen: use fully qualified name for StringLiteral
Jan 30 2017, 4:56 PM
compnerd committed rL293556: Serialization: use range based for loop (NFC).
Serialization: use range based for loop (NFC)
Jan 30 2017, 2:36 PM
compnerd committed rL293543: experimental: avoid using raw _WIN32 in filesystem.
experimental: avoid using raw _WIN32 in filesystem
Jan 30 2017, 12:08 PM
compnerd committed rL293531: experimental: port directory_iterator to Windows.
experimental: port directory_iterator to Windows
Jan 30 2017, 11:01 AM
compnerd committed rL293530: experimental: add missing file header.
experimental: add missing file header
Jan 30 2017, 11:01 AM

Jan 29 2017

compnerd committed rL293454: experimental: remove some extraneous _LIBCPP_FUNC_VIS.
experimental: remove some extraneous _LIBCPP_FUNC_VIS
Jan 29 2017, 8:09 PM
compnerd committed rL293450: experimental: inline single use of a typedef.
experimental: inline single use of a typedef
Jan 29 2017, 4:27 PM
compnerd committed rL293449: experimental: tolerate the existence of a `__deref` macro.
experimental: tolerate the existence of a `__deref` macro
Jan 29 2017, 4:27 PM
compnerd committed rL293445: experimental: remove dead function.
experimental: remove dead function
Jan 29 2017, 2:42 PM
compnerd committed rL293439: config: prevent the re-definition of a macro.
config: prevent the re-definition of a macro
Jan 29 2017, 10:27 AM
compnerd committed rL293433: ARM: support `-mlong-calls` with AEABI TLS on ELF.
ARM: support `-mlong-calls` with AEABI TLS on ELF
Jan 29 2017, 8:57 AM

Jan 26 2017

compnerd committed rL293259: ARM: fix vectorized division on WoA.
ARM: fix vectorized division on WoA
Jan 26 2017, 7:53 PM
compnerd requested changes to D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux.

This really needs a new driver flag (-unwinder?) similar to -rtlib, as there are multiple unwinders, and it is unclear which unwinder is the proper one on a given target. This has been something on my TODO list for a while. Mixing and matching undwinders is not really possible, and it is perfectly valid to use compiler-rt with the gcc unwinder on Linux.

Jan 26 2017, 6:42 PM
compnerd committed rL293257: Revert "DWARF: convert error logs to _LIBUNWIND_LOG".
Revert "DWARF: convert error logs to _LIBUNWIND_LOG"
Jan 26 2017, 6:38 PM
compnerd accepted D29198: clang-cl: Warn about /U flags that look like filenames (PR31662).

Thanks for adding this, diagnosing what was going on here the first time around took a little bit of thinking.

Jan 26 2017, 6:24 PM

Jan 25 2017

compnerd committed rL293120: builtins: remove an errant ':'.
builtins: remove an errant ':'
Jan 25 2017, 4:49 PM
compnerd accepted D29099: [lld] [cmake] Fix -rpath-link in stand-alone build.
Jan 25 2017, 7:31 AM · lld

Jan 24 2017

compnerd closed D29101: Ignore -f(no)objc-arc-exception when -fno-objc-arc set.

SVN r293014.

Jan 24 2017, 7:48 PM
compnerd committed rL293014: Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set.
Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set
Jan 24 2017, 7:47 PM
compnerd committed rL293008: DWARF: fix -Asserts builds.
DWARF: fix -Asserts builds
Jan 24 2017, 6:39 PM