Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (331 w, 3 d)

Recent Activity

Fri, Apr 12

compnerd added inline comments to D60274: [ELF] Implement Dependent Libraries Feature.
Fri, Apr 12, 9:17 AM · Restricted Project

Wed, Apr 10

compnerd committed rGa73936a50f03: clangd-fuzzer: repair the build (authored by compnerd).
clangd-fuzzer: repair the build
Wed, Apr 10, 12:16 PM
compnerd committed rCTE358127: clangd-fuzzer: repair the build.
clangd-fuzzer: repair the build
Wed, Apr 10, 12:16 PM
compnerd committed rL358127: clangd-fuzzer: repair the build.
clangd-fuzzer: repair the build
Wed, Apr 10, 12:15 PM
compnerd committed rG6e84a09ee9b3: build: add binary dir to the unittests (authored by compnerd).
build: add binary dir to the unittests
Wed, Apr 10, 10:25 AM
compnerd committed rL358107: build: add binary dir to the unittests.
build: add binary dir to the unittests
Wed, Apr 10, 10:24 AM
compnerd committed rCTE358107: build: add binary dir to the unittests.
build: add binary dir to the unittests
Wed, Apr 10, 10:24 AM
compnerd committed rGe1b9b9dc15cf: clangd: fix the build with XPC (authored by compnerd).
clangd: fix the build with XPC
Wed, Apr 10, 9:48 AM
compnerd committed rCTE358103: clangd: fix the build with XPC.
clangd: fix the build with XPC
Wed, Apr 10, 9:47 AM
compnerd committed rL358103: clangd: fix the build with XPC.
clangd: fix the build with XPC
Wed, Apr 10, 9:47 AM
compnerd committed rGaef7247adbf2: clangd: repair the build after SVN r358091 (authored by compnerd).
clangd: repair the build after SVN r358091
Wed, Apr 10, 8:47 AM
compnerd committed rL358093: clangd: repair the build after SVN r358091.
clangd: repair the build after SVN r358091
Wed, Apr 10, 8:47 AM
compnerd committed rCTE358093: clangd: repair the build after SVN r358091.
clangd: repair the build after SVN r358091
Wed, Apr 10, 8:47 AM

Mon, Apr 8

compnerd added a comment to D60292: [AMDGPU] predicate and feature refactoring.

@arsenm - could write a bitcode upgrade path to deal with the breakage

Mon, Apr 8, 9:13 AM · Restricted Project

Fri, Apr 5

compnerd committed rG50e609611c9c: lit: make rm python 3 friendly (NFC) (authored by compnerd).
lit: make rm python 3 friendly (NFC)
Fri, Apr 5, 11:00 AM
compnerd committed rL357789: lit: make rm python 3 friendly (NFC).
lit: make rm python 3 friendly (NFC)
Fri, Apr 5, 10:59 AM
compnerd added a comment to D60274: [ELF] Implement Dependent Libraries Feature.

The early check for ELF is the problem. I care very little about .linker-options itself as long as the ability to ensure that framework linkage is provided (i.e. -framework ..., and '-L ...` can be passed along as options to the linker).

Fri, Apr 5, 10:14 AM · Restricted Project
compnerd committed rGd3a85a26b6f0: lit: support long paths on Windows (authored by compnerd).
lit: support long paths on Windows
Fri, Apr 5, 9:47 AM
compnerd closed D57533: lit: support long paths on Windows.

SVN r357778

Fri, Apr 5, 9:46 AM · Restricted Project
compnerd committed rL357778: lit: support long paths on Windows.
lit: support long paths on Windows
Fri, Apr 5, 9:46 AM
compnerd added a comment to D60274: [ELF] Implement Dependent Libraries Feature.

Am I mistaken in that this effectively prevents the use of options to handle frameworks? That really is a strong requirement and should be part of this patch.

Fri, Apr 5, 9:08 AM · Restricted Project

Tue, Apr 2

compnerd accepted D60024: [cmake] Add function for building native tool.

Took a couple of reads to make sure that nothing was really being changed, but seems so. LGTM.

Tue, Apr 2, 8:38 AM · Restricted Project

Mon, Apr 1

compnerd accepted D59866: Fork PDBASTParser to a base class and create PDBASTParserClang.
Mon, Apr 1, 12:24 PM
compnerd added inline comments to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Mon, Apr 1, 12:23 PM

Thu, Mar 28

compnerd accepted D59964: [yaml2obj] Fixing opening empty yaml files..

Please check the error message is printed in the case the YAML is empty.

Thu, Mar 28, 3:03 PM · Restricted Project
compnerd accepted D59904: Convert PDBASTParser::GetDCContainingSymbol to be non-clang specific.
Thu, Mar 28, 8:34 AM

Wed, Mar 27

compnerd added inline comments to D59862: Add a function for mapping PDBSymbol index IDs to lldb::LangTypes.
Wed, Mar 27, 3:33 PM
compnerd accepted D59864: Teach TypeSystem about PDBASTParser.
Wed, Mar 27, 3:26 PM

Mon, Mar 25

compnerd added a reviewer for D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS: ruiu.
Mon, Mar 25, 9:42 PM · Restricted Project
compnerd accepted D59805: Get the lang from the CompileUnit for ParseCompileUnitFunctionForPDBFunc.
Mon, Mar 25, 9:42 PM
compnerd accepted D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB.
Mon, Mar 25, 9:40 PM · Restricted Project
compnerd accepted D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir.

Please add a comment about verify being only for tests.

Mon, Mar 25, 1:28 PM · Restricted Project
compnerd added inline comments to D59728: [PDB] Refactor PDBASTParser to a base class and add PDBASTParserClang.
Mon, Mar 25, 1:16 PM

Sun, Mar 24

compnerd added a comment to D59745: [NFC] Move writeFuncOrVarName out of class CodegenNameGenerator so that it can be reused more easily. .

Hmm, what exactly does the libclang interfaces not give you or what exactly did you intend to have this be used as. Perhaps with some more details we can find a good solution for the specific case that you have in mind.

Sun, Mar 24, 2:48 PM · Restricted Project

Fri, Mar 22

compnerd added inline comments to D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir.
Fri, Mar 22, 2:27 PM · Restricted Project
compnerd accepted D59694: [PPC64][libunwind] Fix r2 not properly restored.

LG with the minor changes requested.

Fri, Mar 22, 2:19 PM · Restricted Project

Thu, Mar 21

compnerd added a comment to D57533: lit: support long paths on Windows.

@rnk, @zturner, @thakis - why don't we merge this for the time being, and once we have setup lit such that it auto-locates git for windows and sets up the path (removing the dependency on GnuWin32), we can remove this entirely?

Thu, Mar 21, 3:36 PM · Restricted Project

Mar 11 2019

compnerd accepted D59229: Add Swift enumerator value for CodeView::SourceLanguage.

Please add a test case for this (flowing from IR -> Obj -> llvm-pdbutil)

Mar 11 2019, 2:28 PM · Restricted Project
compnerd accepted D59230: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift.

CC: @zturner

Mar 11 2019, 2:26 PM · Restricted Project
compnerd accepted D59070: [builtins] Divide shouldn't underflow if rounded result would be normal..

Would be nice if @scanon would also take a look, but, this seems like a good thing to fix.

Mar 11 2019, 10:35 AM · Restricted Project, Restricted Project

Mar 6 2019

compnerd accepted D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
Mar 6 2019, 2:47 PM · Restricted Project

Feb 26 2019

compnerd committed rGb67342e7cb08: Support: enable backtraces on Windows (authored by compnerd).
Support: enable backtraces on Windows
Feb 26 2019, 7:23 PM
compnerd committed rL354951: Support: enable backtraces on Windows.
Support: enable backtraces on Windows
Feb 26 2019, 7:23 PM
compnerd closed D58702: Enabled Backtraces with just ENABLE_BACKTRACES.

SVN r354951

Feb 26 2019, 7:22 PM · Restricted Project
compnerd accepted D58702: Enabled Backtraces with just ENABLE_BACKTRACES.

This seems right, the Unix side will provide the same interfaces that do nothing in the case that the target doesn't support the backtrace API, and on Windows we provide the same interfaces using DbgHelp if we have access to it.

Feb 26 2019, 6:34 PM · Restricted Project
compnerd accepted D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 26 2019, 4:24 PM · Restricted Project
compnerd accepted D58649: Fix inline assembler constraint validation.

Nice find!

Feb 26 2019, 4:24 PM · Restricted Project
compnerd committed rG427aeb3ad230: vim: `swiftself` is an attribute (authored by compnerd).
vim: `swiftself` is an attribute
Feb 26 2019, 4:12 PM
compnerd committed rL354934: vim: `swiftself` is an attribute.
vim: `swiftself` is an attribute
Feb 26 2019, 4:11 PM
compnerd added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.

Shouldn't there be an accompanying change to readobj to display the values for the object files?

Feb 26 2019, 8:23 AM · Restricted Project

Feb 22 2019

compnerd committed rG896289277da5: CodeGen: use COMDAT for block copy/destroy helpers (authored by compnerd).
CodeGen: use COMDAT for block copy/destroy helpers
Feb 22 2019, 8:31 AM
compnerd committed rC354678: CodeGen: use COMDAT for block copy/destroy helpers.
CodeGen: use COMDAT for block copy/destroy helpers
Feb 22 2019, 8:30 AM
compnerd committed rL354678: CodeGen: use COMDAT for block copy/destroy helpers.
CodeGen: use COMDAT for block copy/destroy helpers
Feb 22 2019, 8:30 AM

Feb 21 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

@rnk - okay, that seems reasonable - can you please update the documentation on how to setup the Visual Studio Developer command prompt such that you can use the tools (assuming that Git is setup by the Visual Studio Installer) then?

Feb 21 2019, 4:20 PM · Restricted Project

Feb 19 2019

compnerd added a comment to D58405: Merge target triple into module triple when constructing module from memory.

Probably just a replay of GDB protocol packets connected to a testing server would work. But, I don't know if there is infrastructure for that yet.

Feb 19 2019, 4:41 PM · Restricted Project
compnerd added inline comments to D58415: Add Swift enumerator value for CodeView::SourceLanguage.
Feb 19 2019, 4:35 PM · Restricted Project
compnerd added a comment to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..

Previously we would have emitted Foo [[:space:]] . right?

Feb 19 2019, 4:34 PM · Restricted Project
compnerd accepted D58398: Add Facebook Minidump directory streams and options to dump them..

Would be nice to change the filecheck prefixes to CHECK-... to separate the CHECK and the item being checked.

Feb 19 2019, 11:29 AM · Restricted Project
compnerd accepted D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them..

Actually, I'm not sure if that is a bug in libstackunwind, but rather in LLVM. I think that this is the behaviour that GCC has specifically for the eh_frame section. This constraint is not part of the DWARF spec, but eh_frame even though it is similar to debug_frame, is not part of the DWARF spec, it just uses a similar encoding. The change itself looks good, but, please wait for the discussion to complete before committing this.

Feb 19 2019, 8:47 AM · Restricted Project
compnerd accepted D58298: [libObject][NFC] Use sys::path::convert_to_slash..

Thanks!

Feb 19 2019, 8:43 AM · Restricted Project

Feb 14 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

@rnk @zturner @ruiu - can we come to a decision here?

Feb 14 2019, 2:48 PM · Restricted Project
compnerd committed rGcb914cf68310: Support: use internal `call_once` on PPC64le (authored by compnerd).
Support: use internal `call_once` on PPC64le
Feb 14 2019, 10:40 AM
compnerd committed rL354045: Support: use internal `call_once` on PPC64le.
Support: use internal `call_once` on PPC64le
Feb 14 2019, 10:40 AM
compnerd closed D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

SVN r354045

Feb 14 2019, 10:40 AM · Restricted Project
compnerd added a comment to D58193: Do not explicitly depend on llvm tools during standalone build.

@sgraenitz - not really ... the find_package will load the LLVMConfig.cmake that is generated. We only have what we keep in there.

Feb 14 2019, 10:29 AM · Restricted Project

Feb 13 2019

compnerd updated the diff for D57402: build: remove custom variables.

Add HINTS

Feb 13 2019, 5:36 PM · Restricted Project
compnerd added a comment to D57402: build: remove custom variables.

@labath - absolutely, that I don't have a problem with. I think that having the additional LLDB specific paths with LLDB_PATH_TO_* is better done by using the standard CMake mechanisms.

Feb 13 2019, 11:10 AM · Restricted Project

Feb 12 2019

compnerd accepted D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments.
Feb 12 2019, 2:09 PM · Restricted Project, Restricted Project
compnerd added a comment to D57402: build: remove custom variables.

Yes, both paths currently work since the LLDB_PATH_TO_* variables are just hints to where to look. It just seems unnecessary to have the custom variables when CMake has a mechanism for directing the build to look for packages in a certain location.

Feb 12 2019, 2:09 PM · Restricted Project

Feb 11 2019

compnerd accepted D57350: [llvm-cxxfilt] Split and demangle stdin input.

LG with the additional test suggestion

Feb 11 2019, 10:49 AM · Restricted Project
compnerd added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Feb 11 2019, 10:08 AM · Restricted Project

Feb 10 2019

compnerd added inline comments to D57533: lit: support long paths on Windows.
Feb 10 2019, 11:32 AM · Restricted Project

Feb 8 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

@zturner I think that moving to the integrated lit shell is a great idea, as it really does lower the barrier to entry and makes testing stuff on Windows much easier.

Feb 8 2019, 3:07 PM · Restricted Project
compnerd added a comment to D57406: build: remove use of llvm-config.

Which version of the patch did you use? L13 in the current version sets LLVM_MAIN_INCLUDE_DIR specifically for that case.

Feb 8 2019, 2:14 PM · Restricted Project

Feb 7 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

@zturner, to your point, I'd like to add the fact that it took a bit of effort to even figure out that the problem was so nicely tucked away in the corner of lit because the failure scenario is pretty absurd (-ENOENT). IMO, this makes this even more insidious because it will cause a lot of people to get confused or possibly give up. But, perhaps I just am holding on to tightly to my idea that things should just work and the testing infrastructure should encourage people to add tests rather than demotivate them.

Feb 7 2019, 5:53 PM · Restricted Project

Feb 6 2019

compnerd added a comment to D57402: build: remove custom variables.

@sgraenitz yeah, I passed LLVM_DIR and Clang_DIR, but, this is for a standalone build, so I think that it is pretty reasonable to ask that the user tell us where LLVM and Clang are built. Although, if you install LLVM and Clang to your root (like on Linux), you do not need to specify that because it will search the system by default.

Feb 6 2019, 11:55 AM · Restricted Project
compnerd requested changes to D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows.
Feb 6 2019, 11:38 AM
compnerd added a comment to D57533: lit: support long paths on Windows.

@ruiu - to your point of "it being better in the future" I think is false hope. The backwards API compatibility will prevent Microsoft from changing the behaviour of the APIs without an explicit opt-in. Otherwise, applications need to be rewritten, which has long been the case, you can use the NT style paths all the way back to Windows XP I believe, but applications aren't being rebuilt and redistributed.

Feb 6 2019, 8:38 AM · Restricted Project

Feb 5 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

@ruiu it is only "removed" if you opt into it by modifying the registry on a per program basis. I don't think that is really a reasonable approach.

Feb 5 2019, 5:35 PM · Restricted Project
compnerd added inline comments to D57533: lit: support long paths on Windows.
Feb 5 2019, 9:13 AM · Restricted Project

Feb 3 2019

compnerd accepted D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@kastiglione - bleh, seems that this got lost. This seems like a good fix that we should get in.

Feb 3 2019, 4:16 PM · Restricted Project
compnerd committed rG764727d92e52: tests: loosen restriction (authored by compnerd).
tests: loosen restriction
Feb 3 2019, 4:10 PM
compnerd committed rL353012: tests: loosen restriction.
tests: loosen restriction
Feb 3 2019, 4:10 PM

Feb 2 2019

compnerd added a reviewer for D57533: lit: support long paths on Windows: zturner.
Feb 2 2019, 10:29 AM · Restricted Project
compnerd updated the diff for D57533: lit: support long paths on Windows.

Switch to SHFileOperationW for the recursive removal. Refactor lit.util.mkdir_p to expose lit.utl.mkdir and update that to support long file paths. This makes lit more robust on Windows against creating long path temporary directories.

Feb 2 2019, 10:28 AM · Restricted Project

Feb 1 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

Okay, seems like the way to handle this is to switch to SHFileOperationW using ctypes. I believe that the win32py support that is needed for this should be part of the default python installation on windows (at least it is part of the Visual Studio python distribution).

Feb 1 2019, 4:46 PM · Restricted Project

Jan 31 2019

compnerd added a comment to D57533: lit: support long paths on Windows.

Ugh, right ... I think that I had tested it against an empty directory! It was run early in the test. I'll flesh this out with @zturner's idea of extract it into a helper.

Jan 31 2019, 6:01 PM · Restricted Project
compnerd added a comment to D57533: lit: support long paths on Windows.

@ruiu, no unfortunately, not all the paths can be shortened in the swift test suite since it is such a heavy user of the clang modules, modules cache paths and module naming structure in clang is a problem

Jan 31 2019, 12:32 PM · Restricted Project
compnerd updated the diff for D57533: lit: support long paths on Windows.

comments, error handling, context

Jan 31 2019, 12:20 PM · Restricted Project
compnerd added a comment to D57533: lit: support long paths on Windows.

That doesn't work with python 2.7 as that uses RemoveDirectoryA, which does not support it.

Jan 31 2019, 12:12 PM · Restricted Project
compnerd added a reviewer for D57533: lit: support long paths on Windows: thakis.
Jan 31 2019, 12:01 PM · Restricted Project
compnerd created D57533: lit: support long paths on Windows.
Jan 31 2019, 11:59 AM · Restricted Project
compnerd updated the diff for D57406: build: remove use of llvm-config.

Fixes

Jan 31 2019, 10:34 AM · Restricted Project

Jan 30 2019

compnerd updated the diff for D57406: build: remove use of llvm-config.

Restore LLVM_MAIN_SRC_DIR cache variable

Jan 30 2019, 2:24 PM · Restricted Project
compnerd added a comment to D57406: build: remove use of llvm-config.

This doesn't break the build, we check that the path exists, and find_program will not error out. You can still specify LLVM_LIT_EXE to specify the lit.py to use. Is that not sufficient for your needs?

Jan 30 2019, 1:12 PM · Restricted Project

Jan 29 2019

compnerd added a comment to D57404: build: remove use of llvm-config.

@mgorny, no, you should specify -DLLVM_DIR=/path/to/where/the/config/lives instead.

Jan 29 2019, 12:36 PM · Restricted Project
compnerd created D57406: build: remove use of llvm-config.
Jan 29 2019, 11:26 AM · Restricted Project
compnerd created D57404: build: remove use of llvm-config.
Jan 29 2019, 11:13 AM · Restricted Project
compnerd created D57402: build: remove custom variables.
Jan 29 2019, 10:53 AM · Restricted Project
compnerd requested changes to D57350: [llvm-cxxfilt] Split and demangle stdin input.

This actually breaks the compatibility with the existing tools. The quoted string is supposed to be interpreted as a *single* entry. I think that if you want to support something like this, it should be a separate flag for this behaviour.

Jan 29 2019, 8:41 AM · Restricted Project