- User Since
- Dec 9 2012, 11:41 PM (341 w, 1 d)
@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.
Move test case around
add additional context and test case
@lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus at it.
Sat, Jun 22
Fri, Jun 21
Wed, Jun 19
Mon, Jun 17
Could you please add a test to ensure that Darwin defaults to the old behaviour?
Fri, Jun 14
Wed, Jun 12
What I am imagining is basically having a variable which specifies the distribution targets, and having variables which will be constructed based upon those names (similar to how variables for the runtimes are passed today).
Tue, Jun 11
Mon, Jun 10
Sun, Jun 9
Thu, Jun 6
Mon, Jun 3
Sun, Jun 2
This should get the build working again, so lets get this fixed, we can improve it later
Generally, clang-format the changes, it will catch the formatting things.
Sat, Jun 1
Fri, May 31
Oops! Nice catch. This matches the specification.
Actually, I think that we should extend CompilerType and TypeSystem to expose Clang's knowledge of whether a type is passed in a register by means of using clang::RecordDecl::isPassInRegisters
Thu, May 30
Thanks for adding the test case!
Thanks, this looks much better.
Wed, May 29
Sounds safe enough to me. I think that it would be nice to add a test that checks the hexagon flags as well.
Tue, May 28
This looks good
May 23 2019
May 22 2019
I think that this makes sense - the one case that I had in mind is pretty convoluted and if it breaks, we can fix it then.
May 21 2019
May 20 2019
@smeenai - not sure what you mean; you mean a clean configuration with the same set of parameters? I'll certainly do that test and expect no differences there. @hintonda - yeah, CACHE ... FORCE should do the trick for that.
The only thing that Im worried about is cross-compilation accidentally picking up the libc++ headers that are built here (e.g. building on Linux for Linux with the host libc++ headers and building libc++ as a runtime). The rest looks pretty much a substitution and addition of runtime-libcxx-headers target to the runtimes build which is fine.