Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (312 w, 6 d)

Recent Activity

Thu, Dec 6

compnerd committed rLLDB348556: Host: remove Yield on Windows.
Host: remove Yield on Windows
Thu, Dec 6, 4:34 PM
compnerd committed rL348556: Host: remove Yield on Windows.
Host: remove Yield on Windows
Thu, Dec 6, 4:34 PM

Wed, Dec 5

compnerd committed rC348454: ARM, AArch64: support `__attribute__((__swiftcall__))`.
ARM, AArch64: support `__attribute__((__swiftcall__))`
Wed, Dec 5, 7:31 PM
compnerd committed rL348454: ARM, AArch64: support `__attribute__((__swiftcall__))`.
ARM, AArch64: support `__attribute__((__swiftcall__))`
Wed, Dec 5, 7:31 PM

Tue, Dec 4

compnerd committed rL348337: AArch64: support funclets in fastcall and swift_call.
AArch64: support funclets in fastcall and swift_call
Tue, Dec 4, 11:12 PM
compnerd committed rLLDB348332: gdb-remote: use elaborated type specifier for `Module`.
gdb-remote: use elaborated type specifier for `Module`
Tue, Dec 4, 8:07 PM
compnerd committed rL348332: gdb-remote: use elaborated type specifier for `Module`.
gdb-remote: use elaborated type specifier for `Module`
Tue, Dec 4, 8:07 PM
compnerd committed rL348310: AArch64: clean up some whitespace in Windows CC (NFC).
AArch64: clean up some whitespace in Windows CC (NFC)
Tue, Dec 4, 2:22 PM

Fri, Nov 30

compnerd committed rL348042: Support: use std::is_trivially_copyable on MSVC.
Support: use std::is_trivially_copyable on MSVC
Fri, Nov 30, 2:17 PM

Oct 31 2018

compnerd added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Oct 31 2018, 12:40 PM
compnerd accepted D37820: [BinaryFormat] Teach identify_magic about Tapi files..

Unfortunately, the TAPI releases are in the wild, so we need to support the old files. It would be nice to have some sort of marker on the file (similar to a shebang) to indicate that it is a TAPI file.

Oct 31 2018, 12:34 PM

Oct 30 2018

compnerd committed rL345675: DWARFVerifier: make the verifier more comprehensive for objects.
DWARFVerifier: make the verifier more comprehensive for objects
Oct 30 2018, 4:47 PM

Oct 29 2018

compnerd committed rL345569: Utility: fix cross-compilation from Linux to Windows.
Utility: fix cross-compilation from Linux to Windows
Oct 29 2018, 11:32 PM
compnerd committed rLLDB345569: Utility: fix cross-compilation from Linux to Windows.
Utility: fix cross-compilation from Linux to Windows
Oct 29 2018, 11:31 PM

Oct 28 2018

compnerd committed rL345482: Revert "Revert "DebugInfo: reduce DIE range verification on object files"".
Revert "Revert "DebugInfo: reduce DIE range verification on object files""
Oct 28 2018, 3:33 PM
compnerd committed rC345479: AST: extend MS decoration handling for extended vectors.
AST: extend MS decoration handling for extended vectors
Oct 28 2018, 11:07 AM
compnerd committed rL345479: AST: extend MS decoration handling for extended vectors.
AST: extend MS decoration handling for extended vectors
Oct 28 2018, 11:07 AM

Oct 26 2018

compnerd committed rC345449: AST: fix a typo in a comment (NFC).
AST: fix a typo in a comment (NFC)
Oct 26 2018, 11:15 PM
compnerd committed rL345449: AST: fix a typo in a comment (NFC).
AST: fix a typo in a comment (NFC)
Oct 26 2018, 11:15 PM
compnerd committed rL345444: test: add missing -triple.
test: add missing -triple
Oct 26 2018, 7:29 PM
compnerd committed rL345441: DebugInfo: reduce DIE range verification on object files.
DebugInfo: reduce DIE range verification on object files
Oct 26 2018, 5:53 PM

Oct 25 2018

compnerd added a comment to D53051: [llvm-tapi] initial commit, supports ELF text stubs.

I'd actually like to echo @ruiu's comment here. I don't think that ELF has much to gain from the textual representation (unlike MachO). ELF doesn't have the fat binary support, so you cannot really collapse multiple slices into a single slice and only mark differences in the slices from a common base. Furthermore, by exploiting the fact that ELF is extremely flexible in terms of what it considers a valid object, we can actually limit a stub to just the symbol table and the ELF header I believe. This is going to be a few extra bytes for the fields in the ELF header that we don't care about (e.g. magic). Since the majority of the binary will be the string table, I expect it to compress pretty well and be roughly in the same area as a textual representation. One added benefit of such an approach is that it is retroactively compatible with existing linkers. They should accept the output even though the binary would not be usable to run!

Oct 25 2018, 8:41 PM
compnerd committed rC345360: CodeGen: correct the case for swift 4.2, 5.0.
CodeGen: correct the case for swift 4.2, 5.0
Oct 25 2018, 8:18 PM
compnerd committed rL345360: CodeGen: correct the case for swift 4.2, 5.0.
CodeGen: correct the case for swift 4.2, 5.0
Oct 25 2018, 8:18 PM
compnerd committed rL345291: CodeGen: alter CFConstantString class name for swift 5.0.
CodeGen: alter CFConstantString class name for swift 5.0
Oct 25 2018, 10:54 AM
compnerd committed rC345291: CodeGen: alter CFConstantString class name for swift 5.0.
CodeGen: alter CFConstantString class name for swift 5.0
Oct 25 2018, 10:54 AM

Oct 24 2018

compnerd accepted D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`.

Yeah, this seems right. The builtins currently have some dependencies on libm, so you won't be able to build with -z defs.

Oct 24 2018, 8:18 PM
compnerd committed rL345222: Driver,CodeGen: introduce support for Swift CFString layout.
Driver,CodeGen: introduce support for Swift CFString layout
Oct 24 2018, 4:31 PM
compnerd committed rC345222: Driver,CodeGen: introduce support for Swift CFString layout.
Driver,CodeGen: introduce support for Swift CFString layout
Oct 24 2018, 4:31 PM
compnerd accepted D53614: ARM: Use BKPT instead of TRAP to implement llvm.debugtrap..

LGTM. WRT the test case, is the DI needed? If not, I would strip the debug info for the test.

Oct 24 2018, 10:32 AM
compnerd committed rL345160: CodeGen: extract some local variables in CFConstantString creation (NFC).
CodeGen: extract some local variables in CFConstantString creation (NFC)
Oct 24 2018, 9:58 AM
compnerd committed rC345160: CodeGen: extract some local variables in CFConstantString creation (NFC).
CodeGen: extract some local variables in CFConstantString creation (NFC)
Oct 24 2018, 9:58 AM
compnerd committed rC345159: AST: unindent CFConstantStringDecl by inverting condition (NFC).
AST: unindent CFConstantStringDecl by inverting condition (NFC)
Oct 24 2018, 9:41 AM
compnerd committed rL345159: AST: unindent CFConstantStringDecl by inverting condition (NFC).
AST: unindent CFConstantStringDecl by inverting condition (NFC)
Oct 24 2018, 9:41 AM

Oct 23 2018

compnerd committed rL345107: ARM: handle checking aliases with out-of-bounds GEPs.
ARM: handle checking aliases with out-of-bounds GEPs
Oct 23 2018, 5:03 PM

Oct 22 2018

compnerd committed rL344973: X86: fix a comment copy-paste issue (NFC).
X86: fix a comment copy-paste issue (NFC)
Oct 22 2018, 4:36 PM

Oct 14 2018

compnerd added inline comments to D52821: [Disassembler][llvm-readobj] ELF note dumper abstraction.
Oct 14 2018, 10:33 AM
compnerd added a comment to D53127: Fix missing defines in libc++abi when compiled against libgcc's arm unwind (follow-up of D42242).

I'm not sure I understand this patch. Building libc++abi with libsupc++ doesn't make sense. They are both providing the same API. Are you trying to build against libgcc? The GNU Savannah libunwind as well as the LLVM libunwind provide the definitions AFAICT. libgcc has the definition in unwind-common.h.

Oct 14 2018, 10:28 AM

Oct 10 2018

compnerd closed D52210: [LLVM-C] Add C APIs to access DebugLoc info.

SVN r344202

Oct 10 2018, 4:55 PM
compnerd committed rL344202: llvm-c: Add C APIs to access DebugLoc info.
llvm-c: Add C APIs to access DebugLoc info
Oct 10 2018, 4:55 PM
compnerd accepted D52210: [LLVM-C] Add C APIs to access DebugLoc info.

This seems reasonable to me. @whitequark, are you okay with them too? To @whitequark's original point, I think that the dispatching the type based on a query is pretty cool (you can do an enumeration + union output), but, I think API-wise, this is safer and easier to work with, not to mention also simplifies the implementation.

Oct 10 2018, 8:53 AM

Oct 9 2018

compnerd added inline comments to D52210: [LLVM-C] Add C APIs to access DebugLoc info.
Oct 9 2018, 4:44 PM
compnerd added inline comments to D52821: [Disassembler][llvm-readobj] ELF note dumper abstraction.
Oct 9 2018, 9:38 AM

Oct 5 2018

compnerd added inline comments to D52821: [Disassembler][llvm-readobj] ELF note dumper abstraction.
Oct 5 2018, 9:58 AM

Oct 4 2018

compnerd requested changes to D52821: [Disassembler][llvm-readobj] ELF note dumper abstraction.
Oct 4 2018, 10:24 AM

Sep 28 2018

compnerd committed rC343338: AST: add missing ObjC extensions to MS style name decoration.
AST: add missing ObjC extensions to MS style name decoration
Sep 28 2018, 9:50 AM
compnerd committed rL343338: AST: add missing ObjC extensions to MS style name decoration.
AST: add missing ObjC extensions to MS style name decoration
Sep 28 2018, 9:50 AM

Sep 27 2018

compnerd added a comment to D52144: use __ARM_FP instead of __VFP_FP__.

Wow, thanks for fixing this. I believe that @peter.smith is right and that the behaviour is something new.

Sep 27 2018, 9:24 AM

Sep 25 2018

compnerd requested changes to D52210: [LLVM-C] Add C APIs to access DebugLoc info.
Sep 25 2018, 10:33 AM

Sep 24 2018

compnerd closed D52252: Driver: render arguments for the embedded bitcode correctly.

SVN r342929 (with tests)

Sep 24 2018, 10:50 PM
compnerd accepted D52252: Driver: render arguments for the embedded bitcode correctly.
Sep 24 2018, 10:50 PM
compnerd committed rL342929: Driver: render arguments for the embedded bitcode correctly.
Driver: render arguments for the embedded bitcode correctly
Sep 24 2018, 4:52 PM
compnerd committed rC342929: Driver: render arguments for the embedded bitcode correctly.
Driver: render arguments for the embedded bitcode correctly
Sep 24 2018, 4:52 PM

Sep 22 2018

compnerd added a comment to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..

This seems reasonable to me, however, I would want to give @scanon a few (work) days to see if he has any comments on the actual implementation of logb.

Sep 22 2018, 10:11 PM

Sep 21 2018

compnerd added inline comments to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
Sep 21 2018, 1:20 PM
compnerd accepted D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`..

This looks fine to me, but this definitely should have an accompanying test.

Sep 21 2018, 11:38 AM
compnerd accepted D51999: build: add libedit to include paths.

LGTM, thanks!

Sep 21 2018, 11:29 AM

Sep 20 2018

compnerd added a comment to D51999: build: add libedit to include paths.

It definitely shouldn't be PUBLIC, PRIVATE makes sense for this inclusion. Is there a library that pulls in the dependency (that is, do the other libraries need it due to lldbHost? If so, just adding it as INTERFACE on that library should be sufficient).

Sep 20 2018, 4:21 PM

Sep 19 2018

compnerd committed rL342581: test: actually fix the condition properly.
test: actually fix the condition properly
Sep 19 2018, 12:22 PM
compnerd committed rC342581: test: actually fix the condition properly.
test: actually fix the condition properly
Sep 19 2018, 12:21 PM
compnerd committed rL342569: test: improve condition for the check.
test: improve condition for the check
Sep 19 2018, 11:42 AM
compnerd committed rC342569: test: improve condition for the check.
test: improve condition for the check
Sep 19 2018, 11:42 AM
compnerd committed rC342565: Sema: handle `wint_t` more carefully for printf checking.
Sema: handle `wint_t` more carefully for printf checking
Sep 19 2018, 11:15 AM
compnerd committed rL342565: Sema: handle `wint_t` more carefully for printf checking.
Sema: handle `wint_t` more carefully for printf checking
Sep 19 2018, 11:14 AM
compnerd committed rC342557: Basic: correct `__WINT_TYPE__` on Windows.
Basic: correct `__WINT_TYPE__` on Windows
Sep 19 2018, 9:21 AM
compnerd committed rL342557: Basic: correct `__WINT_TYPE__` on Windows.
Basic: correct `__WINT_TYPE__` on Windows
Sep 19 2018, 9:20 AM
compnerd added inline comments to D52266: [clang-cl] Provide separate flags for all the /O variants.
Sep 19 2018, 8:04 AM

Sep 18 2018

compnerd created D52252: Driver: render arguments for the embedded bitcode correctly.
Sep 18 2018, 3:48 PM
compnerd added inline comments to D51868: [libcxx] Build and test fixes for Windows.
Sep 18 2018, 3:31 PM
compnerd requested changes to D51999: build: add libedit to include paths.

Can you use target_include_directories instead and do this only on lldbHost instead please? That restricts the inclusion to just that target, which would help prevent accidental inclusion of the headers. That is the change should be to source/Host/CMakeLists.txt.

Sep 18 2018, 3:29 PM
compnerd committed rC342515: Driver: extract a local variable for the Toolchain (NFC).
Driver: extract a local variable for the Toolchain (NFC)
Sep 18 2018, 3:17 PM
compnerd committed rL342515: Driver: extract a local variable for the Toolchain (NFC).
Driver: extract a local variable for the Toolchain (NFC)
Sep 18 2018, 3:17 PM
compnerd committed rC342512: Driver: hoist `-mlimit-float-precision` (NFC).
Driver: hoist `-mlimit-float-precision` (NFC)
Sep 18 2018, 2:14 PM
compnerd committed rL342512: Driver: hoist `-mlimit-float-precision` (NFC).
Driver: hoist `-mlimit-float-precision` (NFC)
Sep 18 2018, 2:14 PM
compnerd committed rCRT342511: build: clean up some unnecessary cached variables.
build: clean up some unnecessary cached variables
Sep 18 2018, 1:34 PM
compnerd committed rL342511: build: clean up some unnecessary cached variables.
build: clean up some unnecessary cached variables
Sep 18 2018, 1:34 PM

Sep 17 2018

compnerd committed rL342425: build: fix standalone builds for compiler-rt on Darwin.
build: fix standalone builds for compiler-rt on Darwin
Sep 17 2018, 4:27 PM
compnerd committed rCRT342425: build: fix standalone builds for compiler-rt on Darwin.
build: fix standalone builds for compiler-rt on Darwin
Sep 17 2018, 4:26 PM

Sep 12 2018

compnerd committed rL342109: ARM: correct the relocation type for `bl` on WoA.
ARM: correct the relocation type for `bl` on WoA
Sep 12 2018, 9:58 PM

Sep 11 2018

compnerd accepted D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Sure, I think I can live with this.

Sep 11 2018, 9:11 AM

Sep 10 2018

compnerd committed rL341877: clang-check: rename the local FixItAction.
clang-check: rename the local FixItAction
Sep 10 2018, 3:58 PM
compnerd committed rC341877: clang-check: rename the local FixItAction.
clang-check: rename the local FixItAction
Sep 10 2018, 3:58 PM

Aug 20 2018

compnerd committed rC340228: libclang: add install/distribution targets for python.
libclang: add install/distribution targets for python
Aug 20 2018, 3:51 PM
compnerd committed rL340228: libclang: add install/distribution targets for python.
libclang: add install/distribution targets for python
Aug 20 2018, 3:51 PM

Aug 14 2018

compnerd added inline comments to D50144: Add Windows support for the GNUstep Objective-C ABI V2..
Aug 14 2018, 10:54 AM

Jul 31 2018

compnerd accepted D49929: [AArch64] Disallow the MachO specific .loh directive for windows.

@t.p.northover - okay, in that case, we can leave it here. I suppose that this is caused by the pair-wise split relocations à la IMAGE_REL_ARM_MOV32T for PE/COFF?

Jul 31 2018, 3:32 PM

Jul 30 2018

compnerd added a comment to D49936: [ARM] Support the .isnt directive for MachO and COFF targets.

@peter.smith, yeah, I think that sharing this might make it more complex. This looks fine to me, any other concerns?

Jul 30 2018, 1:19 PM
compnerd accepted D49937: [ARM] Allow automatically deducing the thumb instruction size for .inst.
Jul 30 2018, 1:12 PM
compnerd accepted D49935: [AArch64] Support the .inst directive for MachO and COFF targets.
Jul 30 2018, 1:10 PM
compnerd requested changes to D49929: [AArch64] Disallow the MachO specific .loh directive for windows.

Can you move the LOH handling into the DarwinAsmParser rather than adding the MachO specific check here please?

Jul 30 2018, 1:08 PM

Jul 20 2018

compnerd accepted D48702: objdump: Better handling of Mach-O universal binaries.
Jul 20 2018, 9:44 AM
compnerd added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Ah, I see. I think I had overlooked the .incbin.

Jul 20 2018, 9:38 AM

Jul 18 2018

compnerd added inline comments to D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Jul 18 2018, 10:52 AM
compnerd accepted D49314: [OpenEmbedded] Add a unittest for aarch64-oe-linux.
Jul 18 2018, 10:48 AM

Jul 17 2018

compnerd accepted D49055: [compiler-rt] [builtins] Implement the __chkstk function for ARM for MinGW.

Seems fine with the adjusted comment

Jul 17 2018, 11:57 AM

Jul 6 2018

compnerd added a comment to D48993: [CMake] Give Python module install command a component name.

The install- target is created by add_llvm_install_targets, not by the component. The component is part of CMake itself, and is controlled by the CMAKE_INSTALL_DEFAULT_COMPONENT_NAME.

Jul 6 2018, 9:54 AM

Jul 5 2018

compnerd accepted D48568: objdump: Support newer ObjC image info flags.
Jul 5 2018, 3:16 PM
compnerd added inline comments to D48702: objdump: Better handling of Mach-O universal binaries.
Jul 5 2018, 3:15 PM
compnerd accepted D48861: Add OpenEmbedded vendor.
Jul 5 2018, 3:04 PM
compnerd accepted D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp.
Jul 5 2018, 3:03 PM