compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (236 w, 6 d)

Recent Activity

Yesterday

compnerd added inline comments to D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.
Sat, Jun 24, 4:10 PM
compnerd updated the diff for D34523: AST: mangle BlockDecls under MS ABI.

Address feedback. Also fix the case that was previously not working. This now covers all the various cases that have been discussed.

Sat, Jun 24, 10:43 AM · Restricted Project

Fri, Jun 23

compnerd added a comment to D34523: AST: mangle BlockDecls under MS ABI.

Ah, thanks for the explanation @efriedma.

Fri, Jun 23, 4:43 PM · Restricted Project
compnerd updated the diff for D34523: AST: mangle BlockDecls under MS ABI.

This is a step in the right direction. Although the NSDMI cases and default parameter value cases are not yet handled, they break due to tracking of the global mangling number tracking, not due to the scheme.

Fri, Jun 23, 4:13 PM · Restricted Project
compnerd added a comment to D34523: AST: mangle BlockDecls under MS ABI.

@efriedma I think that Im still not understanding the case that you are trying to point out. How do we end up in a state where the block invocation function is referenced external to the TU? The block would be referenced to by name of the block, no? AFAICT, this is for local storage in a block, which is scoped to the block invocation function, which is TU local, and will be referenced by the block_literal (which contains the block invocation function and is dispatched via the BlocksRuntime).

Fri, Jun 23, 2:48 PM · Restricted Project
compnerd added a comment to D34523: AST: mangle BlockDecls under MS ABI.

@efriedma which bit of the Itanium mangling should I be looking at? A BlockDecl does not have visibility associated with them, so Im not sure what I should be checking to see if the block is visible or not. What is the best way forward for finishing this up?

Fri, Jun 23, 2:02 PM · Restricted Project
compnerd updated the diff for D34523: AST: mangle BlockDecls under MS ABI.

Add additional test cases, improve coverage and mangling.

Fri, Jun 23, 1:51 PM · Restricted Project
compnerd committed rL306123: test: fix negative test case.
test: fix negative test case
Fri, Jun 23, 9:53 AM
compnerd committed rL306115: Revert "Revert r305164/5/7.".
Revert "Revert r305164/5/7."
Fri, Jun 23, 8:35 AM

Thu, Jun 22

compnerd added a comment to D34523: AST: mangle BlockDecls under MS ABI.

@efriedma hmm...using getBlockManglingNumber causes the name to be duplicated. Ill look into that. However, wouldn't all the block invocation functions be defined and COMDAT'ed?

Thu, Jun 22, 1:56 PM · Restricted Project
compnerd added a reviewer for D34523: AST: mangle BlockDecls under MS ABI: eli.friedman.
Thu, Jun 22, 11:47 AM · Restricted Project
compnerd created D34523: AST: mangle BlockDecls under MS ABI.
Thu, Jun 22, 11:45 AM · Restricted Project

Tue, Jun 20

compnerd committed rL305846: Support: chunk writing on Linux.
Support: chunk writing on Linux
Tue, Jun 20, 1:52 PM
compnerd added inline comments to D34377: Support MS builtins using 'long' on LP64.
Tue, Jun 20, 9:44 AM

Sat, Jun 17

compnerd committed rL305638: CodeGen: make the type match the comment for a libcall.
CodeGen: make the type match the comment for a libcall
Sat, Jun 17, 10:31 AM

Thu, Jun 15

compnerd committed rL305502: COFF: add support for lib mode usage.
COFF: add support for lib mode usage
Thu, Jun 15, 1:40 PM

Sun, Jun 11

compnerd committed rL305175: build: use cmake to pass -std=c++11.
build: use cmake to pass -std=c++11
Sun, Jun 11, 5:00 PM
compnerd committed rL305174: build: use POSITION_INDEPENDENT_CODE CMake property.
build: use POSITION_INDEPENDENT_CODE CMake property
Sun, Jun 11, 5:00 PM
compnerd committed rL305173: cxa_demangle: fix -Wimplicit-fallthrough for GCC:7.
cxa_demangle: fix -Wimplicit-fallthrough for GCC:7
Sun, Jun 11, 3:58 PM
compnerd committed rL305172: private_typeinfo: add missing field initializers.
private_typeinfo: add missing field initializers
Sun, Jun 11, 3:58 PM
compnerd committed rL305167: test: attempt to repair build bots.
test: attempt to repair build bots
Sun, Jun 11, 11:55 AM
compnerd committed rL305165: Driver: add support for `-gz` and `-gz=`.
Driver: add support for `-gz` and `-gz=`
Sun, Jun 11, 10:50 AM
compnerd committed rL305164: Driver: pass along [-]-[no]compress-debug-sections unfiltered.
Driver: pass along [-]-[no]compress-debug-sections unfiltered
Sun, Jun 11, 10:50 AM

Fri, Jun 9

compnerd accepted D34075: [compiler-rt][builtins] Better Fuchsia support.
Fri, Jun 9, 9:40 PM

Thu, Jun 8

compnerd committed rL305039: Represent debug information compression type fully.
Represent debug information compression type fully
Thu, Jun 8, 5:41 PM
compnerd committed rL305038: sink DebugCompressionType into MC for exposing to clang.
sink DebugCompressionType into MC for exposing to clang
Thu, Jun 8, 5:41 PM

Mon, Jun 5

compnerd committed rL304739: test: fix hexagon build.
test: fix hexagon build
Mon, Jun 5, 2:45 PM
compnerd committed rL304736: CodeGen: add support for emitting ObjC image info.
CodeGen: add support for emitting ObjC image info
Mon, Jun 5, 2:27 PM

Sat, Jun 3

compnerd closed D32460: ADT: handle special case of ARM environment for SuSE.

SVN r304670

Sat, Jun 3, 3:31 PM
compnerd committed rL304670: ADT: handle special case of ARM environment for SUSE.
ADT: handle special case of ARM environment for SUSE
Sat, Jun 3, 3:31 PM
compnerd requested changes to D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF.
Sat, Jun 3, 3:04 PM
compnerd committed rL304662: tests: silence -Wobjc-root-class warnings.
tests: silence -Wobjc-root-class warnings
Sat, Jun 3, 9:18 AM
compnerd committed rL304661: CodeGen: fix section names for different file formats.
CodeGen: fix section names for different file formats
Sat, Jun 3, 9:18 AM

Thu, Jun 1

compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

@ismail the current version of the patch should have those requested changes :-).

Thu, Jun 1, 8:01 PM
compnerd added inline comments to D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple.
Thu, Jun 1, 7:58 PM
compnerd accepted D33811: Revert r304117 - WebAssembly object format isn't ready to be the default.
Thu, Jun 1, 5:17 PM

Wed, May 31

compnerd requested changes to D33601: libunwind: fix building on mingw-w64.

Im not sure that this is a reasonable patch. I think that specializing a AddressSpace for _WIN32 is more likely what we want. Furthermore, this actually should be more restrictive, since the unwind library cannot be used for Windows -- the unwinding model on Windows is completely different. This only makes sense for MinGW and cygwin, and so we should ensure that the environment matches that.

Wed, May 31, 9:17 PM

Sun, May 28

compnerd committed rL304117: Support: adjust the default obj format for wasm.
Support: adjust the default obj format for wasm
Sun, May 28, 5:15 PM
compnerd accepted D33637: [libcxxabi][demangler] Fix a exponential string copying bug.

Thanks for looking into this, its been on my list for a while now.

Sun, May 28, 3:17 PM

May 24 2017

compnerd accepted D33516: Add generic __bswap[ds]i2 implementations.

Please clang-format before committing this.

May 24 2017, 7:20 PM
compnerd accepted D33259: Don't defer to the GCC driver for linking arm-baremetal.
May 24 2017, 7:16 PM
compnerd committed rL303804: Basic: fix whitespace in file header (NFC).
Basic: fix whitespace in file header (NFC)
May 24 2017, 1:27 PM

May 23 2017

compnerd accepted D33368: [libcxxabi][demangler] Fix a crash in the demangler.
May 23 2017, 5:45 PM
compnerd added a comment to D33259: Don't defer to the GCC driver for linking arm-baremetal.

Looks generally pretty good. This is going to be a pretty cool addition!

May 23 2017, 5:34 PM
compnerd accepted D33459: Allow armv{7,7s,7k,7m,7em} builds.

Modulo the IT block macros, LGTM.

May 23 2017, 5:26 PM

May 22 2017

compnerd added inline comments to D33368: [libcxxabi][demangler] Fix a crash in the demangler.
May 22 2017, 9:17 PM
compnerd added inline comments to D33259: Don't defer to the GCC driver for linking arm-baremetal.
May 22 2017, 9:12 PM

May 21 2017

compnerd added inline comments to D33259: Don't defer to the GCC driver for linking arm-baremetal.
May 21 2017, 8:59 PM
compnerd requested changes to D33368: [libcxxabi][demangler] Fix a crash in the demangler.
May 21 2017, 8:27 PM
compnerd added a comment to D33385: __cxa_demangle: Fix constructor cv qualifier handling.

Can you please ensure that you cross-port this into llvm/lib/Demangle/ItaniumDemangle.cpp?

May 21 2017, 8:09 PM
compnerd accepted D33385: __cxa_demangle: Fix constructor cv qualifier handling.
May 21 2017, 8:06 PM

May 16 2017

compnerd requested changes to D33259: Don't defer to the GCC driver for linking arm-baremetal.
May 16 2017, 6:30 PM
compnerd committed rL303207: builtins: fix guard __AEABI__ -> __ARM_EABI__.
builtins: fix guard __AEABI__ -> __ARM_EABI__
May 16 2017, 1:38 PM
compnerd committed rL303195: builtins: one more case of a missing header.
builtins: one more case of a missing header
May 16 2017, 11:33 AM
compnerd committed rL303190: builtins: add missing includes.
builtins: add missing includes
May 16 2017, 10:20 AM
compnerd committed rL303188: builtins: expand out the AEABI function stubs.
builtins: expand out the AEABI function stubs
May 16 2017, 9:55 AM

May 15 2017

compnerd committed rL303138: builtins: use reserved spelling (NFC).
builtins: use reserved spelling (NFC)
May 15 2017, 9:30 PM
compnerd committed rL303103: builtins: fix filtering aliased targets.
builtins: fix filtering aliased targets
May 15 2017, 12:22 PM

May 14 2017

compnerd added a comment to D33082: Fix Libc++ build with MinGW64.

Sure, a _LIBCPP_MSVCRT_LIKE WFM. I just want to make sure that we don''t conflate the underlying libc implementation with the Win32 API set.

May 14 2017, 2:29 PM
compnerd requested changes to D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows.

I think that we should sink the min/max checks into __undef_macros. I don't like the idea of littering that check everywhere.

May 14 2017, 12:38 PM
compnerd requested changes to D33082: Fix Libc++ build with MinGW64.
May 14 2017, 12:33 PM

May 9 2017

compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

@majnemer thats the idea - passing either triple to clang would give the right behaviour (clang will normalize the triple before passing it to cc1).
@ismail Im waiting on you to accept the change

May 9 2017, 4:37 PM
compnerd requested changes to D32988: [libc++] Refactor Windows support headers..
May 9 2017, 4:33 PM

May 6 2017

compnerd committed rL302365: COFF: add ARM64 relocation types.
COFF: add ARM64 relocation types
May 6 2017, 5:01 PM

May 5 2017

compnerd committed rL302270: CodeGen: avoid use of @clang.arc.use intrinsic at O0.
CodeGen: avoid use of @clang.arc.use intrinsic at O0
May 5 2017, 11:52 AM

May 4 2017

compnerd committed rL302184: Driver: only inject libstdc++ paths when needed on CrossWindows.
Driver: only inject libstdc++ paths when needed on CrossWindows
May 4 2017, 12:31 PM

May 3 2017

compnerd committed rL302085: DebugInfo: elide type index entries for synthetic types.
DebugInfo: elide type index entries for synthetic types
May 3 2017, 2:52 PM

May 1 2017

compnerd added a comment to D32681: [builtins] Enabled emulated TLS on WOA..

@mstorsjo Yeah, clang supports proper TLS on Windows on ARM. This is only needed if you are explicitly going out of your way to use the emulated TLS (via -femulated-tls). Otherwise, this code path shouldn't be hit.

May 1 2017, 5:41 PM
compnerd abandoned D275: llvm-strings tool .
May 1 2017, 5:35 PM
compnerd commandeered D275: llvm-strings tool .

All of this functionality is in the current tool AFAIK. Furthermore, this has been out of date for so long that it's not particularly useful anymore. Commandeering to close the differential.

May 1 2017, 5:35 PM

Apr 30 2017

compnerd added a comment to D32681: [builtins] Enabled emulated TLS on WOA..

Doing this on just the MinGW build seems reasonable. Most of the library shouldn't be needed for Windows.

Apr 30 2017, 6:49 PM
compnerd committed rL301783: utils: Silence -Wpedantic warning.
utils: Silence -Wpedantic warning
Apr 30 2017, 5:40 PM

Apr 28 2017

compnerd committed rL301658: IR: fix some doxygen grammar (NFC).
IR: fix some doxygen grammar (NFC)
Apr 28 2017, 10:31 AM
compnerd committed rL301657: COFF: actually synthesize CONST imports properly.
COFF: actually synthesize CONST imports properly
Apr 28 2017, 10:19 AM

Apr 27 2017

compnerd committed rL301614: COFF Import: expose both symbols.
COFF Import: expose both symbols
Apr 27 2017, 9:42 PM
compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

@majnemer thats the idea :-). Passing either triple to clang would give the right behaviour (clang will normalize the triple before passing it to cc1).

Apr 27 2017, 6:34 PM
compnerd added a comment to D32460: ADT: handle special case of ARM environment for SuSE.

Yes, the idea is that the textual IR uses the correct triple, unless it is overidden at the command line.

Apr 27 2017, 3:28 PM

Apr 24 2017

compnerd requested changes to D32450: [libunwind] Add 64-bit SPARC support.
Apr 24 2017, 5:52 PM
compnerd requested changes to D32109: [Driver] Limit .exe extension addition to Windows hosts.

Why not always replace the extension? Windows doesnt require the .exe suffix IIRC.

Apr 24 2017, 5:42 PM
compnerd requested changes to D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple.

Is this to actually get the correct GCC search dir? Your test doesnt really test anything AFAICT, as it is just invoking clang with a target that it would accept anyways.

Apr 24 2017, 5:40 PM
compnerd created D32460: ADT: handle special case of ARM environment for SuSE.
Apr 24 2017, 5:37 PM
compnerd added a comment to D32427: Fix float abi for SUSE ARM triples.

I think that you should mutate the environment in the canonicalisation phase of the triple. That will allow you to use armv7-suse-linux-gnueabi and armv7-suse-linux-gnueabihf in the frontend, but have the backend always get armv7-suse-linux-gnueabihf.

Apr 24 2017, 5:27 PM
compnerd committed rL301252: ProfileData: clean up some stale declarations (NFC).
ProfileData: clean up some stale declarations (NFC)
Apr 24 2017, 2:18 PM
compnerd committed rL301237: Avoid unnecessary copies in some for loops.
Avoid unnecessary copies in some for loops
Apr 24 2017, 1:14 PM

Apr 21 2017

compnerd committed rL301013: COFF: add support for CONSTANT exports.
COFF: add support for CONSTANT exports
Apr 21 2017, 11:18 AM

Apr 20 2017

compnerd committed rL300909: Sema: protect against ObjC++ typo-correction failure.
Sema: protect against ObjC++ typo-correction failure
Apr 20 2017, 3:36 PM
compnerd committed rL300908: Parse: cleanup some bleeding whitespace.
Parse: cleanup some bleeding whitespace
Apr 20 2017, 3:36 PM
compnerd accepted D32192: Enable leak sanitizer builds for darwin.
Apr 20 2017, 2:10 PM

Apr 19 2017

compnerd accepted D18478: python bindings: expose the clang version string.

This would ideally wait for the change that @jbcoe has in the works to enable python 3, but the change itself is fine.

Apr 19 2017, 6:19 PM
compnerd accepted D32160: [ARM] Rename HW div feature to HW div Thumb. NFCI..

Thanks for doing this cleanup!

Apr 19 2017, 6:18 PM
compnerd accepted D31568: Add Python 3 support to clang.cindex.

I think it would've been nice to split this up into the changes for map/filter rather than group it together. But sure, this looks reasonable.

Apr 19 2017, 6:16 PM · Restricted Project
compnerd accepted D32213: [Sema] Use MSVC inner class behavior on Itanium.
Apr 19 2017, 6:13 PM
compnerd requested changes to D32192: Enable leak sanitizer builds for darwin.

Please add a test case. The change itself looks reasonable.

Apr 19 2017, 6:12 PM

Apr 18 2017

compnerd accepted D30904: Allow suppressing host and target info in VersionPrinter.

This is opt-out by default, so it shouldn't have any impact on users by default. When building for tooling, this should allow smaller builds for those.

Apr 18 2017, 1:32 PM

Apr 14 2017

compnerd accepted D32071: [CMake][libunwind] Fix the -target and -gcc-toolchain flag handling.
Apr 14 2017, 10:00 AM

Apr 13 2017

compnerd accepted D32005: [ARM] Check for correct HW div when lowering divmod.

Minor comments on the test, but LGTM otherwise.

Apr 13 2017, 8:01 AM

Apr 7 2017

compnerd committed rL299800: Toolchains: remove crtbegin on xwindows.
Toolchains: remove crtbegin on xwindows
Apr 7 2017, 1:59 PM
compnerd committed rL299774: Sema: prevent __declspec(naked) use on x64.
Sema: prevent __declspec(naked) use on x64
Apr 7 2017, 8:26 AM

Apr 6 2017

compnerd committed rL299728: COFF: support the /appcontainer flag.
COFF: support the /appcontainer flag
Apr 6 2017, 4:20 PM

Apr 5 2017

compnerd accepted D31737: [libc++] Respect Windows Store app CRT restrictions.
Apr 5 2017, 9:15 PM