This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add SME2.1 target feature for Armv9-A 2022 Architecture Extension
ClosedPublic

Authored by david-arm on Nov 4 2022, 4:58 AM.

Details

Summary

First patch in a series adding MC layer support for SME2.1.

This patch adds the following feature:

sme2p1

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2022-09

Diff Detail

Event Timeline

david-arm created this revision.Nov 4 2022, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 4:58 AM
david-arm requested review of this revision.Nov 4 2022, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 4:58 AM
david-arm added inline comments.Nov 4 2022, 4:59 AM
llvm/test/MC/AArch64/SME2p1/directive-arch.s
6

There aren't currently any SME2.1 instructions upstream yet so I can only test for SME2 instructions.

paulwalker-arm added inline comments.Nov 4 2022, 6:34 AM
llvm/lib/Target/AArch64/AArch64InstrInfo.td
169

Can this be AssemblerPredicateWithAll? Is this a convent time to fix the other SVE2p1 related instances where we erroneously use AssemblerPredicate?

Matt added a subscriber: Matt.Nov 5 2022, 8:34 PM
david-arm updated this revision to Diff 473565.Nov 6 2022, 10:40 PM
  • Changed the HasSVE2p1-type flags to be AssemblerPredicateWithAll, which also meant changing all the existing SVE2p1 tests.
david-arm marked an inline comment as done.Nov 6 2022, 10:41 PM
david-arm added inline comments.
llvm/lib/Target/AArch64/AArch64InstrInfo.td
169

I guess it's never a convenient time to be honest. :) I've changed this, but as a consequence the patch now includes changes to all the existing SVE2p1 tests too to fix up the RUN lines.

paulwalker-arm accepted this revision.Nov 7 2022, 3:20 AM
This revision is now accepted and ready to land.Nov 7 2022, 3:20 AM
This revision was landed with ongoing or failed builds.Nov 7 2022, 6:38 AM
This revision was automatically updated to reflect the committed changes.
david-arm marked an inline comment as done.