This is an archive of the discontinued LLVM Phabricator instance.

[AArch64]SME2 single-multi and multi-multi INT dot product instructions[part1]
AbandonedPublic

Authored by CarolineConcatto on Oct 12 2022, 3:00 AM.

Details

Reviewers
None
Summary

This patch adds the assembly/disassembly for the following instructions:

SDOT (2-way, multiple and single vector): Multi-vector signed integer dot-product by vector.
     (2-way, multiple vectors): Multi-vector signed integer dot-product.
UDOT (2-way, multiple and single vector): Multi-vector unsigned integer dot-product by vector.
     (2-way, multiple vectors): Multi-vector unsigned integer dot-product.
SUDOT (multiple and indexed vector): Multi-vector signed by unsigned integer dot-product by indexed elements.
      (multiple and single vector): Multi-vector signed by unsigned integer dot-product by vector.
USDOT (multiple and single vector): Multi-vector unsigned by signed integer dot-product by vector.
      (multiple vectors): Multi-vector unsigned by signed integer dot-product.

for groups of 2 and 4 ZA registers

The reference can be found here:

https://developer.arm.com/documentation/ddi0602/2022-09

Depends on:D135455

Diff Detail

Unit TestsFailed

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 3:00 AM
CarolineConcatto requested review of this revision.Oct 12 2022, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2022, 3:00 AM
Matt added a subscriber: Matt.Oct 12 2022, 9:10 AM

Are there any *-diagnostics.s tests for these instructions?

llvm/lib/Target/AArch64/AArch64RegisterInfo.td
1037 ↗(On Diff #467075)

This can be removed in favour of ZZ_b since you've landed D135952 ?

llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td
507

nit: unnecessary whitespace changes

llvm/lib/Target/AArch64/SMEInstrFormats.td
2359

Can this suffix be moved to the instantiation of this class? i.e. def SDOT_VG2_M2ZZ_HtoS : sme2_int_dot_array_vg2_single_2way<...>

CarolineConcatto marked an inline comment as done.
CarolineConcatto edited the summary of this revision. (Show Details)

-Rebase

CarolineConcatto abandoned this revision.Oct 24 2022, 5:54 PM

These instructions are in D135683