Page MenuHomePhabricator

DavidSpickett (David Spickett)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 3:51 AM (143 w, 3 d)

Recent Activity

Today

DavidSpickett committed rG31f9960c3852: [lldb][AArch64] Add "memory tag read" command (authored by DavidSpickett).
[lldb][AArch64] Add "memory tag read" command
Thu, Jun 24, 9:36 AM
DavidSpickett closed D97285: [lldb][AArch64] Add "memory tag read" command.
Thu, Jun 24, 9:35 AM · Restricted Project
DavidSpickett committed rG5d3436200147: [lldb][AArch64] Add MTE memory tag reading to lldb (authored by DavidSpickett).
[lldb][AArch64] Add MTE memory tag reading to lldb
Thu, Jun 24, 9:17 AM
DavidSpickett closed D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.
Thu, Jun 24, 9:17 AM · Restricted Project
DavidSpickett committed rGda2e614f56b1: [lldb][AArch64] Add memory tag reading to lldb-server (authored by DavidSpickett).
[lldb][AArch64] Add memory tag reading to lldb-server
Thu, Jun 24, 9:03 AM
DavidSpickett closed D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Thu, Jun 24, 9:03 AM · Restricted Project
DavidSpickett committed rGcc05418d98f3: [lldb][AArch64] Fix unpack tags test case (authored by DavidSpickett).
[lldb][AArch64] Fix unpack tags test case
Thu, Jun 24, 7:53 AM
DavidSpickett committed rG8d58fbd09efb: [lldb][AArch64] Add memory-tagging qSupported feature (authored by DavidSpickett).
[lldb][AArch64] Add memory-tagging qSupported feature
Thu, Jun 24, 7:43 AM
DavidSpickett closed D97282: [lldb][AArch64] Add memory-tagging qSupported feature.
Thu, Jun 24, 7:43 AM · Restricted Project
DavidSpickett committed rGe0f2744a115c: [lldb][AArch64] Add class for managing memory tags (authored by DavidSpickett).
[lldb][AArch64] Add class for managing memory tags
Thu, Jun 24, 7:10 AM
DavidSpickett closed D97281: [lldb][AArch64] Add class for managing memory tags.
Thu, Jun 24, 7:10 AM · Restricted Project

Yesterday

DavidSpickett updated the diff for D104776: [llvm][ARM] Treat xscale arch as an alias of armv5te.

Rebase on main.

Wed, Jun 23, 6:17 AM · Restricted Project
DavidSpickett added a comment to D104776: [llvm][ARM] Treat xscale arch as an alias of armv5te.

I'm not sure if xscale should enable iwmmxt, the best "docs" seem to be the wiki (https://en.wikipedia.org/wiki/XScale). Which says there were some xscale with this feature (v1 or v2 not sure).

Wed, Jun 23, 6:16 AM · Restricted Project
DavidSpickett committed rGfe63db25bcc0: [lldb] Remove asserts in CommandReturnObject SetError and AppendError (authored by DavidSpickett).
[lldb] Remove asserts in CommandReturnObject SetError and AppendError
Wed, Jun 23, 6:11 AM
DavidSpickett closed D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError.
Wed, Jun 23, 6:11 AM · Restricted Project
DavidSpickett added a comment to D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError.

LGTM, I'll add them in my patch. Thanks for the quick turnaround!

Wed, Jun 23, 4:49 AM · Restricted Project
DavidSpickett added a comment to D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError.

As noted, the assert in AppendRawError remains. It has two internal callers and no API definition.

Wed, Jun 23, 4:39 AM · Restricted Project
DavidSpickett requested review of D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError.
Wed, Jun 23, 4:38 AM · Restricted Project
DavidSpickett committed rG1b1c8e4a984c: [lldb] Remove CommandReturnObject's SetError(StringRef) (authored by DavidSpickett).
[lldb] Remove CommandReturnObject's SetError(StringRef)
Wed, Jun 23, 4:25 AM
DavidSpickett closed D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).
Wed, Jun 23, 4:25 AM · Restricted Project
DavidSpickett updated the summary of D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).
Wed, Jun 23, 4:23 AM · Restricted Project
DavidSpickett added reviewers for D104776: [llvm][ARM] Treat xscale arch as an alias of armv5te: nickdesaulniers, jcai19.

For https://github.com/ClangBuiltLinux/linux/issues/1276

Wed, Jun 23, 4:21 AM · Restricted Project
DavidSpickett requested review of D104776: [llvm][ARM] Treat xscale arch as an alias of armv5te.
Wed, Jun 23, 4:17 AM · Restricted Project
DavidSpickett updated the diff for D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).

Don't change the API, just have SetError call underlying
AppendError.

Wed, Jun 23, 3:51 AM · Restricted Project
DavidSpickett added a comment to D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).

I was going to say we only would need to remove the assert for this one:

void CommandReturnObject::SetError(const Status &error,
                                   const char *fallback_error_cstr) {

Since SetError checks that the char * is not null in the API layer before calling SetError proper. However, the assert is that the string is not empty. You could pass in a non null ptr, to an empty string. So you're right, those need to be removed.

Wed, Jun 23, 3:29 AM · Restricted Project
DavidSpickett added a comment to D104525: [lldb] Assert that CommandResultObject error messages are not empty.
Wed, Jun 23, 3:29 AM · Restricted Project
DavidSpickett added a reviewer for D104768: [lldb] Remove CommandReturnObject's SetError(StringRef): teemperor.
Wed, Jun 23, 2:08 AM · Restricted Project
DavidSpickett added a comment to D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).

I'm not totally sure about adding AppendError to the API.

Wed, Jun 23, 2:08 AM · Restricted Project
DavidSpickett requested review of D104768: [lldb] Remove CommandReturnObject's SetError(StringRef).
Wed, Jun 23, 2:03 AM · Restricted Project

Tue, Jun 22

DavidSpickett committed rGa8dd7094d364: [lldb] Remove more redundant SetStatus(eReturnStatusFailed) (authored by DavidSpickett).
[lldb] Remove more redundant SetStatus(eReturnStatusFailed)
Tue, Jun 22, 8:28 AM
DavidSpickett closed D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed).
Tue, Jun 22, 8:28 AM · Restricted Project
DavidSpickett updated the diff for D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed).

Remove c_str() in Reproducer.

Tue, Jun 22, 4:01 AM · Restricted Project
DavidSpickett requested review of D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed).
Tue, Jun 22, 3:35 AM · Restricted Project

Mon, Jun 21

DavidSpickett added a comment to D104525: [lldb] Assert that CommandResultObject error messages are not empty.

Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it.

Mon, Jun 21, 3:02 AM · Restricted Project
DavidSpickett committed rG12ae3cb7ba53: [lldb] Assert that CommandResultObject error messages are not empty (authored by DavidSpickett).
[lldb] Assert that CommandResultObject error messages are not empty
Mon, Jun 21, 2:45 AM
DavidSpickett closed D104525: [lldb] Assert that CommandResultObject error messages are not empty.
Mon, Jun 21, 2:44 AM · Restricted Project
DavidSpickett updated the diff for D104525: [lldb] Assert that CommandResultObject error messages are not empty.

Use !empty instead of size. All tests passing on X86 and AArch64.

Mon, Jun 21, 2:43 AM · Restricted Project

Fri, Jun 18

DavidSpickett added reviewers for D104525: [lldb] Assert that CommandResultObject error messages are not empty: teemperor, dblaikie.
Fri, Jun 18, 5:31 AM · Restricted Project
DavidSpickett requested review of D104525: [lldb] Assert that CommandResultObject error messages are not empty.
Fri, Jun 18, 5:30 AM · Restricted Project
DavidSpickett added inline comments to D103626: [lldb][AArch64] Remove non address bits from memory read arguments.
Fri, Jun 18, 3:36 AM · Restricted Project
DavidSpickett updated the diff for D103626: [lldb][AArch64] Remove non address bits from memory read arguments.
  • Add missing include
  • Rename test
Fri, Jun 18, 3:34 AM · Restricted Project
DavidSpickett added a comment to D102757: [lldb] Remove non address bits when looking up memory regions.

Do you think this needs a test with a core file as well?

Fri, Jun 18, 3:26 AM · Restricted Project
DavidSpickett updated the summary of D102757: [lldb] Remove non address bits when looking up memory regions.
Fri, Jun 18, 3:20 AM · Restricted Project
DavidSpickett updated the diff for D102757: [lldb] Remove non address bits when looking up memory regions.
  • Move DoGetMemoryRegionInfo into protected section, GetMemoryRegionInfo is the public part.
  • Fix a comment typo.
Fri, Jun 18, 3:19 AM · Restricted Project
DavidSpickett updated the diff for D102757: [lldb] Remove non address bits when looking up memory regions.

Remove TODO.

Fri, Jun 18, 3:01 AM · Restricted Project
DavidSpickett added a comment to D104380: [lldb] Set return object failed status even if error string is empty.

This change would have been part of https://reviews.llvm.org/D103701 if I had realised that this was in fact how it worked. I separated it from the follow ons because of that and to not bury 3 lines of change that apply to all callers of these functions, in 300 lines of change to callers of SetStatus(eReturnStatusFailed). If I were bisecting a failure caused by these changes I'd appreciate the separation but there's probably not much difference.

Fri, Jun 18, 2:14 AM · Restricted Project
DavidSpickett added inline comments to D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.
Fri, Jun 18, 1:58 AM · Restricted Project
DavidSpickett added a reviewer for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines: DavidSpickett.

LGTM

Fri, Jun 18, 1:57 AM · Restricted Project

Thu, Jun 17

DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.

Rebase. Remove result.SetStatus(eReturnStatusFailed) which
is now implicitly done when you add an error.

Thu, Jun 17, 8:40 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Rebase, now ready to land.

Thu, Jun 17, 8:30 AM · Restricted Project
DavidSpickett updated the summary of D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Thu, Jun 17, 8:14 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

Rebase, this is now ready to land.

Thu, Jun 17, 8:13 AM · Restricted Project
DavidSpickett updated the diff for D97282: [lldb][AArch64] Add memory-tagging qSupported feature.

Rebase, this is good to land as is.

Thu, Jun 17, 7:42 AM · Restricted Project
DavidSpickett added a comment to D97281: [lldb][AArch64] Add class for managing memory tags.

@omjavaid As it stands, RemoveNonAddressBits here removes the top byte unconditionally.

Thu, Jun 17, 7:41 AM · Restricted Project
DavidSpickett updated the diff for D97281: [lldb][AArch64] Add class for managing memory tags.

Rebase onto main.

Thu, Jun 17, 7:40 AM · Restricted Project
DavidSpickett committed rGeaf60a4411f7: [lldb] Remove redundant calls to set eReturnStatusFailed (authored by DavidSpickett).
[lldb] Remove redundant calls to set eReturnStatusFailed
Thu, Jun 17, 6:39 AM
DavidSpickett closed D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.
Thu, Jun 17, 6:39 AM · Restricted Project
DavidSpickett updated the diff for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

Good catch, the newline is also not needed.

Thu, Jun 17, 6:37 AM · Restricted Project
DavidSpickett added a reviewer for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed: teemperor.
Thu, Jun 17, 6:19 AM · Restricted Project
DavidSpickett removed a reviewer for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed: teemperor.
Thu, Jun 17, 6:19 AM · Restricted Project
DavidSpickett updated the diff for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

Convert GetErrorStream().Printf to AppendError in CommandObjectWatchpoint.cpp.

Thu, Jun 17, 6:18 AM · Restricted Project
DavidSpickett requested review of D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.
Thu, Jun 17, 4:53 AM · Restricted Project
DavidSpickett committed rG7a580f3c28cf: [lldb] Remove redundant calls to set eReturnStatusFailed (authored by DavidSpickett).
[lldb] Remove redundant calls to set eReturnStatusFailed
Thu, Jun 17, 4:22 AM
DavidSpickett closed D104379: [lldb] Remove redundant calls to set eReturnStatusFailed.
Thu, Jun 17, 4:22 AM · Restricted Project
DavidSpickett committed rG983ed1b58ef9: [lldb] Set return object failed status even if error string is empty (authored by DavidSpickett).
[lldb] Set return object failed status even if error string is empty
Thu, Jun 17, 4:21 AM
DavidSpickett closed D104380: [lldb] Set return object failed status even if error string is empty.
Thu, Jun 17, 4:20 AM · Restricted Project
DavidSpickett added a comment to D97281: [lldb][AArch64] Add class for managing memory tags.

I am going to go over them this afternoon. I'm about to land some lldb patches that allow some easy refactoring, and your ABI patch might be useable too. If using the ABI method is better as a follow up then we can get started landing them.

Thu, Jun 17, 3:32 AM · Restricted Project
DavidSpickett added a comment to D103626: [lldb][AArch64] Remove non address bits from memory read arguments.

Maybe this is something worth considering for LLDB memory dumps?

Thu, Jun 17, 2:41 AM · Restricted Project
DavidSpickett added inline comments to D102757: [lldb] Remove non address bits when looking up memory regions.
Thu, Jun 17, 1:47 AM · Restricted Project

Wed, Jun 16

DavidSpickett committed rGe4ecd83fe969: [llvm][AArch64] Handle arrays of struct properly (from IR) (authored by DavidSpickett).
[llvm][AArch64] Handle arrays of struct properly (from IR)
Wed, Jun 16, 6:56 AM
DavidSpickett closed D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Wed, Jun 16, 6:56 AM · Restricted Project
DavidSpickett added inline comments to D104379: [lldb] Remove redundant calls to set eReturnStatusFailed.
Wed, Jun 16, 6:46 AM · Restricted Project
DavidSpickett added a reviewer for D104380: [lldb] Set return object failed status even if error string is empty: teemperor.
Wed, Jun 16, 6:45 AM · Restricted Project
DavidSpickett requested review of D104380: [lldb] Set return object failed status even if error string is empty.
Wed, Jun 16, 6:44 AM · Restricted Project
DavidSpickett added a reviewer for D104379: [lldb] Remove redundant calls to set eReturnStatusFailed: teemperor.

There'll be a part 2 once this has passed the bots, which will cover all the CommandObject* files.

Wed, Jun 16, 6:36 AM · Restricted Project
DavidSpickett requested review of D104379: [lldb] Remove redundant calls to set eReturnStatusFailed.
Wed, Jun 16, 6:35 AM · Restricted Project
DavidSpickett added a comment to D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses.

Since you landed the underlying ABI patch, looking at this again.

Wed, Jun 16, 6:22 AM
DavidSpickett added inline comments to D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Wed, Jun 16, 2:51 AM · Restricted Project
DavidSpickett updated the diff for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).

Remove unused Optional include

Wed, Jun 16, 2:50 AM · Restricted Project
DavidSpickett updated the diff for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).

Pass the data layout to functionArgumentNeedsConsecutiveRegisters
instead of getting a new copy for every call.

Wed, Jun 16, 2:48 AM · Restricted Project
DavidSpickett added inline comments to D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Wed, Jun 16, 2:20 AM · Restricted Project
DavidSpickett accepted D104312: [zorg] Rename Linaro-maintained 2-stage bots.

LGTM

Wed, Jun 16, 1:59 AM

Tue, Jun 15

DavidSpickett updated the diff for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).

Use ComputeValueVTs instead of recursing manually.

Tue, Jun 15, 3:09 AM · Restricted Project

Mon, Jun 14

DavidSpickett updated the diff for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
  • Fix clang-tidy warnings
  • Add caller/callee tests. For passing as a block, in memory and in normal registers.
Mon, Jun 14, 6:46 AM · Restricted Project
DavidSpickett added a reverting change for rGac031c8db2ce: Revert "[lldb] Set return status to failed when adding a command error" (and…: rG31b9acaec579: Reland "[lldb] Set return status to failed when adding a command error".
Mon, Jun 14, 6:27 AM
DavidSpickett committed rG31b9acaec579: Reland "[lldb] Set return status to failed when adding a command error" (authored by DavidSpickett).
Reland "[lldb] Set return status to failed when adding a command error"
Mon, Jun 14, 6:27 AM
DavidSpickett accepted D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses.

LGTM

Mon, Jun 14, 6:08 AM · Restricted Project
DavidSpickett added a reverting change for rGa2363c0cf9b6: Reland "[lldb] Set return status to failed when adding a command error": rGac031c8db2ce: Revert "[lldb] Set return status to failed when adding a command error" (and….
Mon, Jun 14, 5:11 AM
DavidSpickett added a reverting change for rG0f94d68a2e15: [lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b: rGac031c8db2ce: Revert "[lldb] Set return status to failed when adding a command error" (and….
Mon, Jun 14, 5:11 AM
DavidSpickett added a reverting change for rGf583029da3d6: [lldb] Correct "else if" to "elif" in TestRegisters: rGac031c8db2ce: Revert "[lldb] Set return status to failed when adding a command error" (and….
Mon, Jun 14, 5:11 AM
DavidSpickett committed rGac031c8db2ce: Revert "[lldb] Set return status to failed when adding a command error" (and… (authored by DavidSpickett).
Revert "[lldb] Set return status to failed when adding a command error" (and…
Mon, Jun 14, 5:11 AM
DavidSpickett committed rGf583029da3d6: [lldb] Correct "else if" to "elif" in TestRegisters (authored by DavidSpickett).
[lldb] Correct "else if" to "elif" in TestRegisters
Mon, Jun 14, 2:36 AM
DavidSpickett added a comment to D103701: [lldb] Set return status to failed when adding a command error.

Relanded in https://reviews.llvm.org/rGa2363c0cf9b6 / https://reviews.llvm.org/rG0f94d68a2e15 (because I have a case of the Monday Mornings). If this does the trick there are 2/3 other tests that use this tactic to check for AVX so I can update those too.

Mon, Jun 14, 2:31 AM · Restricted Project
DavidSpickett committed rG0f94d68a2e15: [lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b (authored by DavidSpickett).
[lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b
Mon, Jun 14, 2:24 AM
DavidSpickett added a reverting change for rGdb93e4e70aa4: Revert "[lldb] Set return status to failed when adding a command error": rGa2363c0cf9b6: Reland "[lldb] Set return status to failed when adding a command error".
Mon, Jun 14, 2:22 AM
DavidSpickett committed rGa2363c0cf9b6: Reland "[lldb] Set return status to failed when adding a command error" (authored by DavidSpickett).
Reland "[lldb] Set return status to failed when adding a command error"
Mon, Jun 14, 2:22 AM

Fri, Jun 11

DavidSpickett added a reviewer for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR): momchil.velikov.

Momchil this is the patch to fix what we were talking about. Walking the whole type might be a bit much but it should exit early 99% of the time.

Fri, Jun 11, 8:18 AM · Restricted Project
DavidSpickett added a comment to D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).

Though globalisel doesn't crash with the reported snippet, it does crash on the added tests when we spill to memory. I still need to look into that but I don't think it should block this. (unless the bug reporter turns out to be using globalisel)

Fri, Jun 11, 8:17 AM · Restricted Project
DavidSpickett updated the summary of D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Fri, Jun 11, 8:14 AM · Restricted Project
DavidSpickett requested review of D104123: [llvm][AArch64] Handle arrays of struct properly (from IR).
Fri, Jun 11, 8:13 AM · Restricted Project