Rebase on main.

I'm not sure if xscale should enable iwmmxt, the best "docs" seem to be the wiki (https://en.wikipedia.org/wiki/XScale). Which says there were some xscale with this feature (v1 or v2 not sure).

LGTM, I'll add them in my patch. Thanks for the quick turnaround!

As noted, the assert in AppendRawError remains. It has two internal callers and no API definition.

For https://github.com/ClangBuiltLinux/linux/issues/1276

Don't change the API, just have SetError call underlying
AppendError.

I was going to say we only would need to remove the assert for this one:

void CommandReturnObject::SetError(const Status &error,
                                   const char *fallback_error_cstr) {

Since SetError checks that the char * is not null in the API layer before calling SetError proper. However, the assert is that the string is not empty. You could pass in a non null ptr, to an empty string. So you're right, those need to be removed.

I'm not totally sure about adding AppendError to the API.

Remove c_str() in Reproducer.

Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it.

Use !empty instead of size. All tests passing on X86 and AArch64.

• Add missing include
• Rename test

Do you think this needs a test with a core file as well?

• Move DoGetMemoryRegionInfo into protected section, GetMemoryRegionInfo is the public part.
• Fix a comment typo.

Remove TODO.

This change would have been part of https://reviews.llvm.org/D103701 if I had realised that this was in fact how it worked. I separated it from the follow ons because of that and to not bury 3 lines of change that apply to all callers of these functions, in 300 lines of change to callers of SetStatus(eReturnStatusFailed). If I were bisecting a failure caused by these changes I'd appreciate the separation but there's probably not much difference.

LGTM

Rebase. Remove result.SetStatus(eReturnStatusFailed) which
is now implicitly done when you add an error.

Rebase, now ready to land.

Rebase, this is now ready to land.

Rebase, this is good to land as is.

@omjavaid As it stands, RemoveNonAddressBits here removes the top byte unconditionally.

Rebase onto main.

Good catch, the newline is also not needed.

Convert GetErrorStream().Printf to AppendError in CommandObjectWatchpoint.cpp.

I am going to go over them this afternoon. I'm about to land some lldb patches that allow some easy refactoring, and your ABI patch might be useable too. If using the ABI method is better as a follow up then we can get started landing them.

Maybe this is something worth considering for LLDB memory dumps?

There'll be a part 2 once this has passed the bots, which will cover all the CommandObject* files.

Since you landed the underlying ABI patch, looking at this again.

Remove unused Optional include

Pass the data layout to functionArgumentNeedsConsecutiveRegisters
instead of getting a new copy for every call.

LGTM

Use ComputeValueVTs instead of recursing manually.

• Fix clang-tidy warnings
• Add caller/callee tests. For passing as a block, in memory and in normal registers.

LGTM

Relanded in https://reviews.llvm.org/rGa2363c0cf9b6 / https://reviews.llvm.org/rG0f94d68a2e15 (because I have a case of the Monday Mornings). If this does the trick there are 2/3 other tests that use this tactic to check for AVX so I can update those too.

Momchil this is the patch to fix what we were talking about. Walking the whole type might be a bit much but it should exit early 99% of the time.

Though globalisel doesn't crash with the reported snippet, it does crash on the added tests when we spill to memory. I still need to look into that but I don't think it should block this. (unless the bug reporter turns out to be using globalisel)