Page MenuHomePhabricator

DavidSpickett (David Spickett)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 3:51 AM (234 w, 5 d)

Recent Activity

Fri, Mar 24

DavidSpickett added a comment to D142888: [compiler-rt] Fix building GWPASAN on ARM.

Do you have CMake commands that scudo causes build breakage on Armv7?

Fri, Mar 24, 2:43 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime.

No issues with the patch. If you want to get it enabled on Linaro's lldb bots, email linaro-toolchain@lists.linaro.org and one of us will set it up for you.

Fri, Mar 24, 2:26 AM · Restricted Project, Restricted Project

Thu, Mar 23

DavidSpickett committed rG5193c4a8b38c: [lldb][AArch64] Fix run-qemu.sh when only MTE is enabled. (authored by DavidSpickett).
[lldb][AArch64] Fix run-qemu.sh when only MTE is enabled.
Thu, Mar 23, 6:49 AM · Restricted Project
DavidSpickett committed rG61b0a492ccb1: [llvm][ARM] Refactor isMnemonicVPTPredicable (authored by DavidSpickett).
[llvm][ARM] Refactor isMnemonicVPTPredicable
Thu, Mar 23, 2:39 AM · Restricted Project, Restricted Project
DavidSpickett closed D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.
Thu, Mar 23, 2:39 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145580: [lldb] Show register fields using bitfield struct types.

So the better solution may be along the lines of a register formatting plugin that depends on TypeSystemClang.

Thu, Mar 23, 2:37 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs.

I suppose it just depends on what you're trying to do, which I realize may not be the most helpful advice but I hope that with enough examples it becomes at least a little more clear how things in lldb are currently done...

Thu, Mar 23, 2:33 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs.

But the command interpreter doesn't "depend" on these plugin commands, it

just vends them.

Thu, Mar 23, 2:31 AM · Restricted Project, Restricted Project

Wed, Mar 22

DavidSpickett added a comment to D146532: [m68k] Change compiler-rt settings.

Landed as https://github.com/llvm/llvm-zorg/commit/04492075e696a126bf69967df3489f83eb77bd50.

Wed, Mar 22, 9:54 AM · Restricted Project
DavidSpickett committed rZORG04492075e696: [m68k] Change compiler-rt settings (authored by DavidSpickett).
[m68k] Change compiler-rt settings
Wed, Mar 22, 9:53 AM · Restricted Project
DavidSpickett closed D146532: [m68k] Change compiler-rt settings.
Wed, Mar 22, 9:53 AM · Restricted Project
DavidSpickett added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D146521: [solaris] Explicitly opt out of the runtimes build.

Landed as https://github.com/llvm/llvm-zorg/commit/bb4152335dd9f16b0f679856bafed8434134a70b.

Wed, Mar 22, 7:28 AM · Restricted Project
DavidSpickett committed rZORGbb4152335dd9: [solaris] Explicitly opt out of the runtimes build (authored by DavidSpickett).
[solaris] Explicitly opt out of the runtimes build
Wed, Mar 22, 7:28 AM · Restricted Project
DavidSpickett closed D146521: [solaris] Explicitly opt out of the runtimes build.
Wed, Mar 22, 7:28 AM · Restricted Project
DavidSpickett added a comment to D146212: [AArch64] Use NEON's tbl1 for 16xi8 and 8xi8 build vector with mask..

@dmgreen Okay, I rebased onto main and submited via arc. I hope this did the right thing, but it doesn't look broken. I guess my mistake in the other patch was to create a merge commit instead of rebasing. For future reference, I'll just always squash into in commit.

Wed, Mar 22, 7:26 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.

Use std::any_of.

Wed, Mar 22, 6:36 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.

Put back isVPTPredicableCDEInstr that I didn't move over.

Wed, Mar 22, 3:35 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.

This will perform probably slightly worse than repeated calls but that wasn't a concern in the first place, and is much easier to scan by eye if we needed to audit this function.

Wed, Mar 22, 3:32 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable: dmgreen.
Wed, Mar 22, 3:31 AM · Restricted Project, Restricted Project
DavidSpickett retitled D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable from [llvm][ARM] Sort and dedupe names in isMnemonicVPTPredicable to [llvm][ARM] Refactor isMnemonicVPTPredicable.
Wed, Mar 22, 3:30 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.

On second thought, let's refactor a bit.

Wed, Mar 22, 3:30 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D146619: [llvm][ARM] Refactor isMnemonicVPTPredicable.
Wed, Mar 22, 3:13 AM · Restricted Project, Restricted Project
DavidSpickett committed rGb7165fdc7eca: [llvm][ARM] Fix bounds check after use in ARMAsmParser (authored by DavidSpickett).
[llvm][ARM] Fix bounds check after use in ARMAsmParser
Wed, Mar 22, 2:53 AM · Restricted Project, Restricted Project
DavidSpickett committed rGeb78886246da: [lldb] Add test for unavailable registers (authored by DavidSpickett).
[lldb] Add test for unavailable registers
Wed, Mar 22, 2:42 AM · Restricted Project
DavidSpickett closed D145940: [lldb] Add test for unavailable registers.
Wed, Mar 22, 2:42 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D145940: [lldb] Add test for unavailable registers.
Wed, Mar 22, 2:41 AM · Restricted Project, Restricted Project
DavidSpickett committed rZORG3c82b20c7168: [avr] Opt out of runtimes build (authored by DavidSpickett).
[avr] Opt out of runtimes build
Wed, Mar 22, 2:36 AM · Restricted Project
DavidSpickett added a comment to D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs.

Is this policy documented anywhere? Perhaps you can update one of the design pages if it isn't already there.

Wed, Mar 22, 2:15 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 2:08 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 21

DavidSpickett updated the diff for D145940: [lldb] Add test for unavailable registers.

Remove the need for regex, with the tradeoff that you need
the X86 backend which is pretty common to have.

Tue, Mar 21, 10:19 AM · Restricted Project, Restricted Project
DavidSpickett planned changes to D145940: [lldb] Add test for unavailable registers.

On second thought I think you can do this without XML, I'll figure that out.

Tue, Mar 21, 10:00 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145940: [lldb] Add test for unavailable registers.

The non XML way to do this is just reading bogus register names (and is already tested). However that's all or nothing so it doesn't prove that when there is a mix of available and unavailable registers the command works correctly.

Tue, Mar 21, 9:36 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145940: [lldb] Add test for unavailable registers.

It's not in that dir because it's testing how the register command handles missing registers, rather than how the gdb client does. It assumes that the gdb client is correctly doing its job.

Tue, Mar 21, 9:34 AM · Restricted Project, Restricted Project
DavidSpickett committed rGe73dd6254e31: [lldb] Fix a 32 bit warning in ScriptedProcessInterface (authored by DavidSpickett).
[lldb] Fix a 32 bit warning in ScriptedProcessInterface
Tue, Mar 21, 8:34 AM · Restricted Project
DavidSpickett closed D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface.
Tue, Mar 21, 8:34 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D146532: [m68k] Change compiler-rt settings: glaubitz, myhsu.
Tue, Mar 21, 8:24 AM · Restricted Project
DavidSpickett requested review of D146532: [m68k] Change compiler-rt settings.
Tue, Mar 21, 8:23 AM · Restricted Project
DavidSpickett added a comment to D145940: [lldb] Add test for unavailable registers.

ping!

Tue, Mar 21, 7:35 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface: JDevlieghere.
Tue, Mar 21, 7:34 AM · Restricted Project, Restricted Project
DavidSpickett committed rG392d9eb03af5: [lldb] For native compiles, check signal numbers are correct when adding codes (authored by DavidSpickett).
[lldb] For native compiles, check signal numbers are correct when adding codes
Tue, Mar 21, 7:31 AM · Restricted Project
DavidSpickett closed D146285: [lldb] For native compiles, check signal numbers are correct when adding codes.
Tue, Mar 21, 7:31 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145580: [lldb] Show register fields using bitfield struct types.

On the subject of not using TypeSystemClang, looking around it seems like TypeSystem is purely used to look up basic types, never to make new ones. When new types are made the code asks the TypeSystem for its TypeSystemClang and then uses that to do it.

Tue, Mar 21, 7:27 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146521: [solaris] Explicitly opt out of the runtimes build: ro.

If anyone needs to figure out why these opt out, I hope a git blame and reading the commit message will be enough info. Let me know if I should include anything else.

Tue, Mar 21, 5:59 AM · Restricted Project
DavidSpickett requested review of D146521: [solaris] Explicitly opt out of the runtimes build.
Tue, Mar 21, 5:57 AM · Restricted Project
DavidSpickett committed rGc8af0d3cea8c: [lldb] Add compile time checks for signal codes when on the matching platform (authored by DavidSpickett).
[lldb] Add compile time checks for signal codes when on the matching platform
Tue, Mar 21, 4:45 AM · Restricted Project
DavidSpickett closed D146222: [lldb] Add compile time checks for signal codes when on the matching platform.
Tue, Mar 21, 4:45 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D145574: [lldb] Read register fields from target XML.

Use LOG instead of LOGF.

Tue, Mar 21, 4:02 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D145566: [lldb] Add RegisterFlags class.

Use LOG instead of LOGF.

Tue, Mar 21, 4:01 AM · Restricted Project, Restricted Project
DavidSpickett committed rZORGcf2edff0be68: [s390x] Put compiler-rt in runtimes (authored by DavidSpickett).
[s390x] Put compiler-rt in runtimes
Tue, Mar 21, 3:51 AM · Restricted Project
DavidSpickett added a comment to D146505: [s390x] Put compiler-rt in runtimes.

Landed as https://github.com/llvm/llvm-zorg/commit/cf2edff0be6811e1d33aada3f17523429b1fda92

Tue, Mar 21, 3:51 AM · Restricted Project
DavidSpickett closed D146505: [s390x] Put compiler-rt in runtimes.
Tue, Mar 21, 3:51 AM · Restricted Project
DavidSpickett added inline comments to D145574: [lldb] Read register fields from target XML.
Tue, Mar 21, 3:21 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D145568: [lldb] Add dummy field to RegisterInfo for register flags use later.

Rebase

Tue, Mar 21, 2:44 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D145568: [lldb] Add dummy field to RegisterInfo for register flags use later.
Tue, Mar 21, 2:43 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D145566: [lldb] Add RegisterFlags class.

Address review comments.

Tue, Mar 21, 2:27 AM · Restricted Project, Restricted Project
DavidSpickett committed rG85bc498826d4: [LLDB] Show sub type of signals when debugging a core file (authored by DavidSpickett).
[LLDB] Show sub type of signals when debugging a core file
Tue, Mar 21, 2:10 AM · Restricted Project, Restricted Project
DavidSpickett closed D146045: [LLDB] Show sub type of signals when debugging a core file.
Tue, Mar 21, 2:10 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146505: [s390x] Put compiler-rt in runtimes: uweigand.
Tue, Mar 21, 1:53 AM · Restricted Project
DavidSpickett requested review of D146505: [s390x] Put compiler-rt in runtimes.
Tue, Mar 21, 1:53 AM · Restricted Project

Mon, Mar 20

DavidSpickett added a comment to D142514: [OpenMP][libomptarget] Notify the plugins regarding new mapping/unmappings.

This is probably a very late report but I happened to be looking at openmp bots for a different reason, some of the error returns in this change are failing to compile:
https://lab.llvm.org/buildbot/#/builders/4/builds/32052/steps/5/logs/stdio

Mon, Mar 20, 9:30 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D146432: [Test suite builder] Make enable_runtimes="auto" the default.
Mon, Mar 20, 8:57 AM · Restricted Project
DavidSpickett added inline comments to D137085: [LLVM][TableGen] Add first tutorial notebook.
Mon, Mar 20, 8:14 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D137085: [LLVM][TableGen] Add first tutorial notebook.

Address review comments.

Mon, Mar 20, 8:13 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145574: [lldb] Read register fields from target XML.

The big assumption here is that the GDB process lasts longer than the higher level debug session does. I am keeping a map of register name to unique pointer in the GDB process, then giving out raw pointers to the higher level commands. The higher level is destroyed first, then the GDB process which frees all the unique pointers. This means that the register info struct remains trivial, it wouldn't be if we stored the registerfields type directly in it.

Mon, Mar 20, 4:57 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D145580: [lldb] Show register fields using bitfield struct types.

The shakiest aspect here is probably my use of the scratch type system. It works but I'm not 100% that there isn't a better choice.

Mon, Mar 20, 4:54 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett committed rG0107513fe79d: [lldb] Implement CrashReason using UnixSignals (authored by DavidSpickett).
[lldb] Implement CrashReason using UnixSignals
Mon, Mar 20, 4:40 AM · Restricted Project
DavidSpickett closed D146044: [lldb] Implement CrashReason using UnixSignals.
Mon, Mar 20, 4:39 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D146044: [lldb] Implement CrashReason using UnixSignals.
Mon, Mar 20, 4:32 AM · Restricted Project, Restricted Project

Fri, Mar 17

DavidSpickett accepted D146221: [CodeView] Add source languages ObjC and ObjC++.

LGTM

Fri, Mar 17, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D146204: [flang] Fix build error caused by missing llvm-readelf.

https://github.com/llvm/llvm-project/commit/9f93b71f20eaa0e480ce1a184c40b27dd86576d9

Fri, Mar 17, 8:52 AM · Restricted Project, Restricted Project
DavidSpickett committed rG9f93b71f20ea: [flang] Use llvm-readobj instead of llvm-readelf in rv64 test (authored by DavidSpickett).
[flang] Use llvm-readobj instead of llvm-readelf in rv64 test
Fri, Mar 17, 8:47 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D146204: [flang] Fix build error caused by missing llvm-readelf.

Likely the symlink isn't present, somehow. I did worry that this might happen.

Fri, Mar 17, 8:42 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D146221: [CodeView] Add source languages ObjC and ObjC++.
Fri, Mar 17, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added inline comments to D146221: [CodeView] Add source languages ObjC and ObjC++.
Fri, Mar 17, 8:36 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type.

I don't know anything about Objective C internals, perhaps you can provide some reference that talks about this?

Fri, Mar 17, 7:53 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D146221: [CodeView] Add source languages ObjC and ObjC++.
Fri, Mar 17, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett accepted D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl().
Fri, Mar 17, 4:57 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl(): DavidSpickett.

Agreed, the original name sounds like a const method.

Fri, Mar 17, 4:57 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D146285: [lldb] For native compiles, check signal numbers are correct when adding codes: arichardson, emaste.
Fri, Mar 17, 4:07 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D146285: [lldb] For native compiles, check signal numbers are correct when adding codes.
Fri, Mar 17, 4:05 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146222: [lldb] Add compile time checks for signal codes when on the matching platform.

Correct Linux macro definition when not on Linux.

Fri, Mar 17, 3:21 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D146222: [lldb] Add compile time checks for signal codes when on the matching platform.
Fri, Mar 17, 3:14 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146222: [lldb] Add compile time checks for signal codes when on the matching platform.

Remove SEGV_BNDERR defines from FreeBSD and NetBSD. I cargo culted these from CrashReason
but on checking the latest sources, they are not in either.

Fri, Mar 17, 3:13 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D146045: [LLDB] Show sub type of signals when debugging a core file.

Rebase

Fri, Mar 17, 2:56 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett updated the diff for D146044: [lldb] Implement CrashReason using UnixSignals.

Rebase

Fri, Mar 17, 2:38 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to rG88eb4cbbfe7d: Remove #if guards from AppendBounds to fix compile on old POSIX..

Thanks for the fix!

Fri, Mar 17, 2:14 AM · Restricted Project

Thu, Mar 16

DavidSpickett added a comment to D146204: [flang] Fix build error caused by missing llvm-readelf.

The standalone build didn't like this, https://github.com/llvm/llvm-project/commit/0b958fe41182c9040499e629e24cbdd250d73bf7 fixes that.

Thu, Mar 16, 9:43 AM · Restricted Project, Restricted Project
DavidSpickett committed rG0b958fe41182: [flang] Make tests depend on llvm-readobj not llvm-readelf (authored by DavidSpickett).
[flang] Make tests depend on llvm-readobj not llvm-readelf
Thu, Mar 16, 9:40 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D146222: [lldb] Add compile time checks for signal codes when on the matching platform: arichardson.
Thu, Mar 16, 5:47 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D146044: [lldb] Implement CrashReason using UnixSignals.
Thu, Mar 16, 5:47 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D146222: [lldb] Add compile time checks for signal codes when on the matching platform.
Thu, Mar 16, 5:46 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D146143: [gcc-c-torture] Disable frame-address.c test due to incorrect tail call prevention.

After talking to a colleague, yes, it does make sense. I've updated the comment https://github.com/llvm/llvm-test-suite/commit/099d3c1617e0bf30723c26de3fdb24df3fe797f1.

Thu, Mar 16, 4:05 AM · Restricted Project
DavidSpickett committed rT099d3c1617e0: [gcc-c-torture] Note undefined behaviour in frame-address.c (authored by DavidSpickett).
[gcc-c-torture] Note undefined behaviour in frame-address.c
Thu, Mar 16, 4:04 AM · Restricted Project
DavidSpickett updated the diff for D146045: [LLDB] Show sub type of signals when debugging a core file.

Update GetSignalDescription function name.

Thu, Mar 16, 3:33 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D146143: [gcc-c-torture] Disable frame-address.c test due to incorrect tail call prevention.

Thinking about it more, the test may also be using UB. Which would explain why a change to not require noundef would have caused this. Perhaps clang has always been able to create a tail call here, if the called function did not have UB. That restriction is now gone.

Thu, Mar 16, 2:34 AM · Restricted Project

Wed, Mar 15

DavidSpickett committed rT259fcdabfd84: [gcc-c-torture] Disable frame-address.c test due to incorrect tail call… (authored by DavidSpickett).
[gcc-c-torture] Disable frame-address.c test due to incorrect tail call…
Wed, Mar 15, 9:28 AM · Restricted Project
DavidSpickett closed D146143: [gcc-c-torture] Disable frame-address.c test due to incorrect tail call prevention.
Wed, Mar 15, 9:28 AM · Restricted Project
DavidSpickett added a comment to D146143: [gcc-c-torture] Disable frame-address.c test due to incorrect tail call prevention.

A colleague suggests that maybe there are other reasons clang shouldn't tail call here, but in the interests of getting the bot green I will land this.

Wed, Mar 15, 9:27 AM · Restricted Project