Page MenuHomePhabricator

DavidSpickett (David Spickett)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 3:51 AM (197 w, 3 d)

Recent Activity

Today

DavidSpickett updated the summary of D129272: [lldb][Windows] Fix memory region base addresses when a range is split.
Thu, Jul 7, 6:50 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D129272: [lldb][Windows] Fix memory region base addresses when a range is split.
  • Use self.process()
  • Check for overlapping regions instead of just the base addresses.
Thu, Jul 7, 6:50 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld.
Thu, Jul 7, 6:29 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D129272: [lldb][Windows] Fix memory region base addresses when a range is split: labath.

Follow up to https://discourse.llvm.org/t/unexplained-memory-regions-on-windows/62662.

Thu, Jul 7, 3:59 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D129272: [lldb][Windows] Fix memory region base addresses when a range is split.
Thu, Jul 7, 3:59 AM · Restricted Project, Restricted Project

Yesterday

DavidSpickett committed rGe5fdcfac1bbe: [lldb][AArch64] Use "+all" feature for the disassembler (authored by DavidSpickett).
[lldb][AArch64] Use "+all" feature for the disassembler
Wed, Jul 6, 5:15 AM · Restricted Project
DavidSpickett closed D129177: [lldb][AArch64] Use "+all" feature for the disassembler.
Wed, Jul 6, 5:15 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D129177: [lldb][AArch64] Use "+all" feature for the disassembler: labath.
Wed, Jul 6, 2:07 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D129177: [lldb][AArch64] Use "+all" feature for the disassembler.
Wed, Jul 6, 2:06 AM · Restricted Project, Restricted Project
DavidSpickett committed rG20741c74c501: [llvm][AArch64] Fix "+all" feature for sysreg aliases (authored by DavidSpickett).
[llvm][AArch64] Fix "+all" feature for sysreg aliases
Wed, Jul 6, 1:42 AM · Restricted Project, Restricted Project
DavidSpickett closed D129147: [llvm][AArch64] Fix "+all" feature for sysreg aliases.
Wed, Jul 6, 1:42 AM · Restricted Project, Restricted Project

Tue, Jul 5

DavidSpickett added a comment to D128029: [AArch64] Add target feature "all".

Turns out there was a much simpler soloution: https://reviews.llvm.org/D129147

Tue, Jul 5, 9:20 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D129147: [llvm][AArch64] Fix "+all" feature for sysreg aliases: MaskRay.
Tue, Jul 5, 9:19 AM · Restricted Project, Restricted Project
DavidSpickett updated the diff for D129147: [llvm][AArch64] Fix "+all" feature for sysreg aliases.

clang-format

Tue, Jul 5, 9:19 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D129147: [llvm][AArch64] Fix "+all" feature for sysreg aliases.
Tue, Jul 5, 9:17 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128029: [AArch64] Add target feature "all".

Thanks for implementing this!

Tue, Jul 5, 8:55 AM · Restricted Project, Restricted Project
DavidSpickett accepted D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.

LGTM

Tue, Jul 5, 3:56 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.

My intent was to express that the issue is present where it's the 9th or later arguments.

Tue, Jul 5, 3:39 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.

From reading the release note my understanding is that before this fix the caller of a function would store z0-z7 in situations where it did not need to. Which seems low impact unless you were doing something that read the previous stack frame (but nevertheless a difference from the AAPCS).

Tue, Jul 5, 2:44 AM · Restricted Project, Restricted Project

Mon, Jul 4

DavidSpickett added a comment to D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld.

Some random comments.

Mon, Jul 4, 4:05 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128250: [LLDB][RISCV]Add initial support for lldb-server..

I currently don't quite understand how to configure the build bot, and how to set the test configuration, I went through this article but didn't find useful information for me, could someone help me.

Mon, Jul 4, 1:41 AM · Restricted Project, Restricted Project

Wed, Jun 29

DavidSpickett added a reviewer for D128832: [lldb-server] Skip shared regions for memory allocation: DavidSpickett.
Wed, Jun 29, 9:18 AM · Restricted Project, Restricted Project
DavidSpickett accepted D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping.

LGTM

Wed, Jun 29, 1:28 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128250: [LLDB][RISCV]Add initial support for lldb-server..

FWIW I do get the same error in a clean directory without this patch applied:

-- LLDB version: 15.0.0git
CMake Error at /home/david.spickett/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:289 (message):
  Expected directory for clang-resource headers not found:
Call Stack (most recent call first):
  /home/david.spickett/llvm-project/lldb/CMakeLists.txt:28 (include)
Wed, Jun 29, 1:23 AM · Restricted Project, Restricted Project

Mon, Jun 27

DavidSpickett added inline comments to D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping.
Mon, Jun 27, 3:08 AM · Restricted Project, Restricted Project

Fri, Jun 24

DavidSpickett added a comment to D128250: [LLDB][RISCV]Add initial support for lldb-server..

I tried to fix this error with gdb, but the debugging process was too slow, so I'm sorry for not being able to provide a test patch for verification of my commit.

Fri, Jun 24, 7:08 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128250: [LLDB][RISCV]Add initial support for lldb-server..

Overall this looks fine. Without the ability to test it I don't think we would accept it yet, so I didn't look into the details too much.

Fri, Jun 24, 7:07 AM · Restricted Project, Restricted Project

Thu, Jun 23

DavidSpickett added a comment to D128437: [fastregalloc] Fix bug when there is no register class..

I can confirm this fixes the reproducer I posted on https://reviews.llvm.org/D126771.

Thu, Jun 23, 6:12 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

The reproducer:

Thu, Jun 23, 6:05 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

I also bisected an lldb failure down to this: https://lab.llvm.org/buildbot/#/builders/96/builds/25038/steps/6/logs/stdio

Thu, Jun 23, 5:19 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges.

I've reverted this due to failures on our bots: https://lab.llvm.org/buildbot/#/builders/96/builds/25032/steps/6/logs/stdio

Thu, Jun 23, 3:44 AM · Restricted Project, Restricted Project
DavidSpickett committed rG5e7ddb0ddfe8: Revert "[LLDB] Handle DIE with DW_AT_low_pc and empty ranges" (authored by DavidSpickett).
Revert "[LLDB] Handle DIE with DW_AT_low_pc and empty ranges"
Thu, Jun 23, 3:42 AM · Restricted Project

Wed, Jun 22

DavidSpickett accepted D128268: [lldb] Fix reading i686-windows executables with GNU environment.

LGTM. I like the ifs the way I suggested but up to you, either way it's not the easiest logic to parse.

Wed, Jun 22, 2:09 AM · Restricted Project, Restricted Project
DavidSpickett accepted D127436: [lldb] Resolve exe location for `target create`.

LGTM

Wed, Jun 22, 1:51 AM · Restricted Project, Restricted Project
DavidSpickett accepted D127234: [lldb] Add setting to override PE/COFF ABI by module name.

LGTM

Wed, Jun 22, 1:49 AM · Restricted Project, Restricted Project

Tue, Jun 21

DavidSpickett added a comment to D128268: [lldb] Fix reading i686-windows executables with GNU environment.

Now since the addition of the new setting in 25c8a061c5739677d2fc0af29a8cc9520207b923, ObjectFile::GetModuleSpecifications can return i386-pc-windows-gnu and i686-pc-windows-gnu, while PlatformWindows provides a list containing i386-pc-windows (which is normalized to i386-pc-windows-msvc) and i686-pc-windows (...-msvc). Due to the differing environments, these are deemed incompatible, and LLDB flat out refuses to load the file, with the error message error: no matching platforms found for this file.

Tue, Jun 21, 7:49 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128268: [lldb] Fix reading i686-windows executables with GNU environment.

However, after this commit, if the object file is advertised with the different environment (either when built in a mingw environment, or if that setting is set), the fat binary validation won't accept the file any longer.

Tue, Jun 21, 6:58 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

Having this on by default in some configs on linux and off on others seems like it'd be very confusing. Let's please either have it on or off uniformly per OS?

Tue, Jun 21, 6:17 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a reverting change for rG311f78396023: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux: rG90c9d41c8acc: Revert "[CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux".
Tue, Jun 21, 6:15 AM · Restricted Project, Restricted Project
DavidSpickett committed rG90c9d41c8acc: Revert "[CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux" (authored by DavidSpickett).
Revert "[CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux"
Tue, Jun 21, 6:14 AM · Restricted Project, Restricted Project
DavidSpickett added a reverting change for D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux: rG90c9d41c8acc: Revert "[CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux".
Tue, Jun 21, 6:14 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett committed rG716e27bc9ad4: [llvm] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR for Arm Linux (authored by DavidSpickett).
[llvm] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR for Arm Linux
Tue, Jun 21, 4:52 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D128250: [LLDB][RISCV]Add initial support for lldb-server..

I'll give this a more thorough read later just one comment for now.

Tue, Jun 21, 1:31 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping: DavidSpickett.

Are there public docs for these numbers?

Tue, Jun 21, 1:00 AM · Restricted Project, Restricted Project
DavidSpickett accepted D128226: [lldb] Remove an outdated comment. NFC..

LGTM

Tue, Jun 21, 12:56 AM · Restricted Project, Restricted Project
DavidSpickett accepted D128201: [lldb][windows] Fix crash on getting nested exception.

LGTM

Tue, Jun 21, 12:52 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D127234: [lldb] Add setting to override PE/COFF ABI by module name.
Tue, Jun 21, 12:48 AM · Restricted Project, Restricted Project

Mon, Jun 20

DavidSpickett added a reviewer for D128201: [lldb][windows] Fix crash on getting nested exception: DavidSpickett.

Any reason to #if 0 this instead of just removing it and maybe adding a one line comment like "nested exceptions are not supported"? So that someone can git blame that and find this commit with the removal.

Mon, Jun 20, 7:08 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D127234: [lldb] Add setting to override PE/COFF ABI by module name: DavidSpickett.
Mon, Jun 20, 7:00 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

FYI this broke our armv7 and v8 bots https://lab.llvm.org/buildbot/#/builders/178/builds/2293 (as it did last time it landed).

Mon, Jun 20, 1:51 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

DavidSpickett added a comment to D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64.

Why not use objdump? If we only check that instructions get disassembled, it will work fine.

Wed, Jun 15, 2:32 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

DavidSpickett added a comment to D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64.

Now I think about it, tests could do something like "-mattr=-all" to remove it, right?

Tue, Jun 14, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a reviewer for D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64: DavidSpickett.

conflicting instructions with the same encoding in different extensions, but it doesn't seem possible within one archeticture

Tue, Jun 14, 3:40 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

DavidSpickett added a comment to D127436: [lldb] Resolve exe location for `target create`.

Is it easy to test this?

Fri, Jun 10, 10:08 AM · Restricted Project, Restricted Project

Jun 7 2022

DavidSpickett accepted D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF.

This LGTM.

Jun 7 2022, 1:32 AM · Restricted Project, Restricted Project

Jun 6 2022

DavidSpickett added a comment to D126382: [GVN] Enable enable-split-backedge-in-load-pre option by default.

This exposed a failure on our (Linaro's) test suite bot for Armv7. I've opened an issue for it: https://github.com/llvm/llvm-project/issues/55899

Jun 6 2022, 9:14 AM · Restricted Project, Restricted Project
DavidSpickett added inline comments to D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF.
Jun 6 2022, 8:57 AM · Restricted Project, Restricted Project
DavidSpickett resigned from D127118: [AArch64] Autogenerate sve-fixed-length tests. NFC.

Generating test output seems like a good change but I have no experience with it myself.

Jun 6 2022, 8:40 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D127048: [lldb] Set COFF module ABI from default triple and make it an option: omjavaid.

I won't have time to comment much more but Omair might be able to help.

Jun 6 2022, 6:47 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF: omjavaid.

Can you include some links to documentation of the debuglink feature in the commit message? I assume https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html is what you'd want.

Jun 6 2022, 6:45 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D127048: [lldb] Set COFF module ABI from default triple and make it an option.

There is an arch setting to target create but I doubt passing the whole triple there will make a difference (truncated to arch only at best).

Jun 6 2022, 6:18 AM · Restricted Project, Restricted Project
DavidSpickett accepted D127094: [flang][driver] Remove references to the `flang` bash script.

LGTM

Jun 6 2022, 5:53 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D127048: [lldb] Set COFF module ABI from default triple and make it an option.

This changes the PE/COFF and PDB plugins to set the module triple according to the default target triple used to build LLDB.

Jun 6 2022, 3:58 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D127094: [flang][driver] Remove references to the `flang` bash script.

Is it worth updating flang/docs/ReleaseNotes.md ? Though it seems to have been abandoned.

Jun 6 2022, 3:38 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D127093: [clang][pseudo] Add missing Support lib to cxx.

DBUILD_SHARED_LIBS being the key setting in the config that causes the issue.

Jun 6 2022, 3:04 AM · Restricted Project, Restricted Project
DavidSpickett added reviewers for D127093: [clang][pseudo] Add missing Support lib to cxx: sammccall, MaskRay.

I'm basing this on what psuedo/lib/grammar does, so I'm not totally sure this is the place to fix it.

Jun 6 2022, 3:03 AM · Restricted Project, Restricted Project
DavidSpickett updated the summary of D127093: [clang][pseudo] Add missing Support lib to cxx.
Jun 6 2022, 3:02 AM · Restricted Project, Restricted Project
DavidSpickett requested review of D127093: [clang][pseudo] Add missing Support lib to cxx.
Jun 6 2022, 3:01 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D125796: [fortran] Use flang-to-external-fc instead of flang.

This is now present on the bots:

2022-06-06 05:50:50 INFO:   CMAKE_Fortran_COMPILER: '/home/tcwg-buildbot/worker/clang-aarch64-full-2stage/stage2.install/bin/flang-to-external-fc'
Jun 6 2022, 2:08 AM · Restricted Project
DavidSpickett added a reverting change for rGd4220af52723: [libcxx] Temporarily skip Arm configs: rGc8db4061275d: Revert "[libcxx] Temporarily skip Arm configs".
Jun 6 2022, 1:27 AM · Restricted Project, Restricted Project
DavidSpickett committed rGc8db4061275d: Revert "[libcxx] Temporarily skip Arm configs" (authored by DavidSpickett).
Revert "[libcxx] Temporarily skip Arm configs"
Jun 6 2022, 1:27 AM · Restricted Project, Restricted Project
DavidSpickett added a reverting change for D126688: [libcxx] Temporarily skip Arm configs: rGc8db4061275d: Revert "[libcxx] Temporarily skip Arm configs".
Jun 6 2022, 1:27 AM · Restricted Project, Restricted Project

Jun 1 2022

DavidSpickett committed rZORG6a33c8666f61: [fortran] Use flang-to-external-fc instead of flang (authored by DavidSpickett).
[fortran] Use flang-to-external-fc instead of flang
Jun 1 2022, 6:39 AM · Restricted Project
DavidSpickett closed D125796: [fortran] Use flang-to-external-fc instead of flang.

Pushed: https://github.com/llvm/llvm-zorg/commit/6a33c8666f619103a5b733a0e9f73001cfea8f59

Jun 1 2022, 6:25 AM · Restricted Project
DavidSpickett added a comment to D125796: [fortran] Use flang-to-external-fc instead of flang.

If I'm not around to land this myself, go ahead then email Galina (address on this page https://llvm.org/docs/HowToAddABuilder.html) to ask for a buildbot restart to include the change.

Jun 1 2022, 1:53 AM · Restricted Project
DavidSpickett accepted D126760: [flang] Make sure that `flang` is also installed.

LGTM

Jun 1 2022, 1:49 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D126688: [libcxx] Temporarily skip Arm configs.

I'm a bit early landing this but I'll forget otherwise.

Jun 1 2022, 1:38 AM · Restricted Project, Restricted Project
DavidSpickett committed rGd4220af52723: [libcxx] Temporarily skip Arm configs (authored by DavidSpickett).
[libcxx] Temporarily skip Arm configs
Jun 1 2022, 1:37 AM · Restricted Project, Restricted Project
DavidSpickett closed D126688: [libcxx] Temporarily skip Arm configs.
Jun 1 2022, 1:37 AM · Restricted Project, Restricted Project

May 31 2022

DavidSpickett requested review of D126688: [libcxx] Temporarily skip Arm configs.
May 31 2022, 3:17 AM · Restricted Project, Restricted Project

May 30 2022

DavidSpickett added a comment to D124731: [lldb] Consider binary as module of last resort.

(I also keep an eye on the bots Omair was referring to) You can just reland this change as is (revert your revert) and if something else goes wrong you'll either get a failure email or we'll let you know.

May 30 2022, 1:39 AM · Restricted Project, Restricted Project
DavidSpickett accepted D126451: [Clang][CSKY] Add support about CSKYABIInfo.

LGTM

May 30 2022, 1:31 AM · Restricted Project, Restricted Project

May 26 2022

DavidSpickett added a comment to D126451: [Clang][CSKY] Add support about CSKYABIInfo.

Looks good to me. Can you just clarify how the tests are split? My guess is that one is stuff that doesn't vary with hard/soft float and the other is the bits that change when hardfloat is enabled. If so is it worth checking those situations with soft float too or have you already done that.

May 26 2022, 5:41 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D126451: [Clang][CSKY] Add support about CSKYABIInfo.

Can you reupload with more context? See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

May 26 2022, 2:37 AM · Restricted Project, Restricted Project
DavidSpickett added a comment to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..

In https://reviews.llvm.org/rG38eb4fe74b38 I moved the generic test into the X86 folder as it uses an X86 triple. You could think of the folder names there having 2 meanings, 1: the tests look at things specific to that arch and 2: they use that arch's triple (I think X86 is usually the one people choose if they want to test something generic anyway).

May 26 2022, 2:35 AM · Restricted Project, Restricted Project
DavidSpickett committed rG38eb4fe74b38: [llvm][DWARF] Move test using X86 triple into X86 tests (authored by DavidSpickett).
[llvm][DWARF] Move test using X86 triple into X86 tests
May 26 2022, 2:30 AM · Restricted Project, Restricted Project

May 25 2022

DavidSpickett added a reviewer for D126359: [LLDB] Add basic floating point ops to IR interpreter: DavidSpickett.

I know very little about the interpreter so someone else can comment there.

May 25 2022, 3:40 AM · Restricted Project, Restricted Project

May 24 2022

DavidSpickett accepted D126109: [lldb] Fix broken bad-address-breakpoint test.

Much clearer now, thanks. LGTM with the one nit fixed.

May 24 2022, 3:00 AM · Restricted Project, Restricted Project

May 23 2022

DavidSpickett added inline comments to D126109: [lldb] Fix broken bad-address-breakpoint test.
May 23 2022, 1:41 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D126109: [lldb] Fix broken bad-address-breakpoint test: DavidSpickett.
May 23 2022, 1:23 AM · Restricted Project, Restricted Project

May 19 2022

DavidSpickett committed rGa136a00eae06: [lldb] Add non-address bit improvements to release notes (authored by DavidSpickett).
[lldb] Add non-address bit improvements to release notes
May 19 2022, 8:40 AM · Restricted Project, Restricted Project
DavidSpickett committed rG068f14f1e4ec: [lldb] Add --show-tags option to "memory find" (authored by DavidSpickett).
[lldb] Add --show-tags option to "memory find"
May 19 2022, 6:40 AM · Restricted Project, Restricted Project
DavidSpickett closed D125090: [lldb] Add --show-tags option to "memory find".
May 19 2022, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett added a comment to D111791: [lldb] Add --all option to "memory region".

Relanded in https://reviews.llvm.org/rG13e1cf806567bc4987817e14a774198c3e3f2709.

May 19 2022, 5:18 AM · Restricted Project, Restricted Project, Restricted Project
DavidSpickett committed rG13e1cf806567: Reland "[lldb] Add --all option to "memory region"" (authored by DavidSpickett).
Reland "[lldb] Add --all option to "memory region""
May 19 2022, 5:17 AM · Restricted Project, Restricted Project
DavidSpickett added a reverting change for rG3e928c4b9dfb: Revert "[lldb] Add --all option to "memory region"": rG13e1cf806567: Reland "[lldb] Add --all option to "memory region"".
May 19 2022, 5:17 AM · Restricted Project, Restricted Project

May 18 2022

DavidSpickett committed rG29e556fc2ba9: [lldb] Change implementation of memory read --show-tags option (authored by DavidSpickett).
[lldb] Change implementation of memory read --show-tags option
May 18 2022, 8:49 AM · Restricted Project
DavidSpickett closed D125089: [lldb] Change implementation of memory read --show-tags option.
May 18 2022, 8:49 AM · Restricted Project, Restricted Project
DavidSpickett retitled D125796: [fortran] Use flang-to-external-fc instead of flang from [fortran] Use flang-to-gfortran instead of flang to [fortran] Use flang-to-external-fc instead of flang.
May 18 2022, 7:57 AM · Restricted Project
DavidSpickett updated the diff for D125796: [fortran] Use flang-to-external-fc instead of flang.

Use the new name.

May 18 2022, 7:57 AM · Restricted Project