Page MenuHomePhabricator

kmclaughlin (Kerry McLaughlin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2019, 8:51 AM (28 w, 6 d)

Recent Activity

Today

kmclaughlin added a child revision for D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations: D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations.
Tue, Jan 28, 6:59 AM · Restricted Project
kmclaughlin added a parent revision for D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations: D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations.
Tue, Jan 28, 6:59 AM · Restricted Project
kmclaughlin created D73551: [AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations.
Tue, Jan 28, 6:59 AM · Restricted Project
kmclaughlin added a parent revision for D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations: D73347: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic.
Tue, Jan 28, 1:56 AM · Restricted Project
kmclaughlin added a child revision for D73347: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic: D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations.
Tue, Jan 28, 1:56 AM · Restricted Project

Yesterday

kmclaughlin created D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations.
Mon, Jan 27, 10:00 AM · Restricted Project

Fri, Jan 24

kmclaughlin created D73347: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic.
Fri, Jan 24, 5:37 AM · Restricted Project
kmclaughlin committed rG4c4861b577cb: [AArch64][SVE] Add intrinsics for FFR manipulation (authored by kmclaughlin).
[AArch64][SVE] Add intrinsics for FFR manipulation
Fri, Jan 24, 3:04 AM
kmclaughlin closed D73097: [AArch64][SVE] Add intrinsics for FFR manipulation.
Fri, Jan 24, 3:04 AM · Restricted Project
kmclaughlin added a comment to D73097: [AArch64][SVE] Add intrinsics for FFR manipulation.

Thanks for your input on this @efriedma, I will submit this patch for now and we will revisit the modelling of the FFR as also discussed in D71698

Fri, Jan 24, 3:01 AM · Restricted Project

Thu, Jan 23

kmclaughlin committed rGaa0f37e14a87: [AArch64][SVE] Add first-faulting load intrinsic (authored by kmclaughlin).
[AArch64][SVE] Add first-faulting load intrinsic
Thu, Jan 23, 4:14 AM
kmclaughlin closed D73025: [AArch64][SVE] Add first-faulting load intrinsic.
Thu, Jan 23, 4:14 AM · Restricted Project

Wed, Jan 22

kmclaughlin committed rGcdcc4f2a44b5: [AArch64][SVE] Add intrinsic for non-faulting loads (authored by kmclaughlin).
[AArch64][SVE] Add intrinsic for non-faulting loads
Wed, Jan 22, 3:40 AM
kmclaughlin closed D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
Wed, Jan 22, 3:40 AM · Restricted Project

Tue, Jan 21

kmclaughlin updated the diff for D73025: [AArch64][SVE] Add first-faulting load intrinsic.
  • Rebased patch after changes made to parent revision
Tue, Jan 21, 6:39 AM · Restricted Project
kmclaughlin created D73097: [AArch64][SVE] Add intrinsics for FFR manipulation.
Tue, Jan 21, 5:54 AM · Restricted Project

Mon, Jan 20

kmclaughlin updated the diff for D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
  • Some minor changes to performSignExtendInRegCombine to address comments from @sdesmalen
Mon, Jan 20, 8:42 AM · Restricted Project
kmclaughlin added a parent revision for D73025: [AArch64][SVE] Add first-faulting load intrinsic: D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
Mon, Jan 20, 3:30 AM · Restricted Project
kmclaughlin added a child revision for D71698: [AArch64][SVE] Add intrinsic for non-faulting loads: D73025: [AArch64][SVE] Add first-faulting load intrinsic.
Mon, Jan 20, 3:30 AM · Restricted Project
kmclaughlin created D73025: [AArch64][SVE] Add first-faulting load intrinsic.
Mon, Jan 20, 3:30 AM · Restricted Project

Fri, Jan 17

kmclaughlin committed rGfe3bb8ec9683: [AArch64][SVE] Add ImmArg property to intrinsics with immediates (authored by kmclaughlin).
[AArch64][SVE] Add ImmArg property to intrinsics with immediates
Fri, Jan 17, 3:02 AM
kmclaughlin closed D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates.
Fri, Jan 17, 3:02 AM · Restricted Project

Thu, Jan 16

kmclaughlin added inline comments to D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates.
Thu, Jan 16, 3:31 AM · Restricted Project
kmclaughlin updated the diff for D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates.
  • Replace PatLeaf with ImmLeaf & TImmLeaf in the VectorIndex multiclass
Thu, Jan 16, 3:31 AM · Restricted Project

Wed, Jan 15

kmclaughlin updated the diff for D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates.
  • Removed shiftimm patterns and reused tvecshiftR8, etc
  • Removed complex patterns used by AsmVectorIndexOpnd and instead created a multiclass (VectorIndex) to create a PatLeaf with timm if "_timm" is appended
Wed, Jan 15, 2:37 AM · Restricted Project

Tue, Jan 14

kmclaughlin added a comment to D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.

Thanks for your suggestions, @andwar!

Tue, Jan 14, 3:11 AM · Restricted Project
kmclaughlin updated the diff for D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
  • Rebased patch
  • Updated comments and extended getSVEContainerType to handle nxv8i16 & nxv16i8
Tue, Jan 14, 3:05 AM · Restricted Project

Mon, Jan 13

kmclaughlin created D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates.
Mon, Jan 13, 5:57 AM · Restricted Project

Dec 20 2019

kmclaughlin added inline comments to D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
Dec 20 2019, 9:19 AM · Restricted Project

Dec 19 2019

kmclaughlin planned changes to D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads.

Thanks for the feedback on this patch, @efriedma & @sdesmalen!
I think there is still value in adding a NonFaulting flag to MachineMemOperand so that we can benefit from legalisation, but as this is not a requirement for the ACLE I have created a new patch which implements the non-faulting load intrinsic explicitly: https://reviews.llvm.org/D71698
I will leave this patch in the 'plan changes' state so that it can be referred to in future discussions on the mailing list.

Dec 19 2019, 4:21 AM · Restricted Project
kmclaughlin created D71698: [AArch64][SVE] Add intrinsic for non-faulting loads.
Dec 19 2019, 4:21 AM · Restricted Project

Dec 16 2019

kmclaughlin created D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads.
Dec 16 2019, 9:20 AM · Restricted Project

Dec 13 2019

kmclaughlin committed rG4194ca8e5abf: Recommit "[AArch64][SVE] Implement intrinsics for non-temporal loads & stores" (authored by kmclaughlin).
Recommit "[AArch64][SVE] Implement intrinsics for non-temporal loads & stores"
Dec 13 2019, 2:21 AM

Dec 11 2019

kmclaughlin committed rGc0a3ab365514: Revert "[AArch64][SVE] Implement intrinsics for non-temporal loads & stores" (authored by kmclaughlin).
Revert "[AArch64][SVE] Implement intrinsics for non-temporal loads & stores"
Dec 11 2019, 6:03 AM
kmclaughlin added a reverting change for rG3f5bf35f868d: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores: rGc0a3ab365514: Revert "[AArch64][SVE] Implement intrinsics for non-temporal loads & stores".
Dec 11 2019, 6:03 AM
kmclaughlin committed rG3f5bf35f868d: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores (authored by kmclaughlin).
[AArch64][SVE] Implement intrinsics for non-temporal loads & stores
Dec 11 2019, 3:23 AM
kmclaughlin closed D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
Dec 11 2019, 3:23 AM · Restricted Project
kmclaughlin updated the diff for D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
  • Changed 'Offset' value used by getMaskedLoad & getMaskedStore to scalar type
Dec 11 2019, 3:03 AM · Restricted Project

Dec 9 2019

kmclaughlin added inline comments to D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
Dec 9 2019, 8:52 AM · Restricted Project
kmclaughlin updated the diff for D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
  • Set 'Size' to MemoryLocation::UnknownSize for scalable vectors in getMemIntrinsicNode
  • Ensure MLOAD zeroes inactive lanes by using a zero value for the PassThru in getMaskedLoad
Dec 9 2019, 8:42 AM · Restricted Project

Dec 4 2019

kmclaughlin updated the diff for D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
  • Removed AArch64 specific ISDNodes for MLOAD & MSTORE
Dec 4 2019, 3:21 AM · Restricted Project
kmclaughlin created D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores.
Dec 4 2019, 2:26 AM · Restricted Project

Dec 3 2019

kmclaughlin committed rG8881ac9c3986: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics (authored by kmclaughlin).
[AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics
Dec 3 2019, 5:45 AM
kmclaughlin closed D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics.
Dec 3 2019, 5:45 AM · Restricted Project
kmclaughlin committed rG7483eb656fd2: [AArch64][SVE] Implement shift intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement shift intrinsics
Dec 3 2019, 3:55 AM
kmclaughlin closed D70437: [AArch64][SVE] Implement shift intrinsics.
Dec 3 2019, 3:55 AM · Restricted Project

Dec 2 2019

kmclaughlin updated the diff for D70437: [AArch64][SVE] Implement shift intrinsics.
  • Removed re-ordering of integer arithmetic & logical op intrinsic definitions in IntrinsicsAArch64.td
Dec 2 2019, 6:19 AM · Restricted Project
kmclaughlin updated the diff for D70437: [AArch64][SVE] Implement shift intrinsics.
  • Rebased & enclosed additional setOperationAction calls within check for Subtarget->isSVE()
Dec 2 2019, 3:27 AM · Restricted Project
kmclaughlin added inline comments to D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics.
Dec 2 2019, 3:18 AM · Restricted Project

Nov 27 2019

kmclaughlin added inline comments to D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics.
Nov 27 2019, 10:18 AM · Restricted Project

Nov 26 2019

kmclaughlin committed rG4a649ad21aa2: [AArch64][SVE] Implement floating-point conversion intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement floating-point conversion intrinsics
Nov 26 2019, 2:44 AM
kmclaughlin closed D70180: [AArch64][SVE] Implement floating-point conversion intrinsics.
Nov 26 2019, 2:44 AM · Restricted Project

Nov 19 2019

kmclaughlin created D70437: [AArch64][SVE] Implement shift intrinsics.
Nov 19 2019, 5:53 AM · Restricted Project

Nov 14 2019

kmclaughlin created D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics.
Nov 14 2019, 10:06 AM · Restricted Project
kmclaughlin committed rGf9dd03b135d7: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement floating-point comparison & reduction intrinsics
Nov 14 2019, 5:59 AM
kmclaughlin closed D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics.
Nov 14 2019, 5:59 AM · Restricted Project
kmclaughlin committed rGcd83d9ff5c90: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement remaining floating-point arithmetic intrinsics
Nov 14 2019, 4:15 AM
kmclaughlin closed D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics.
Nov 14 2019, 4:15 AM · Restricted Project
kmclaughlin committed rGf7848fd8f7b5: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement additional floating-point arithmetic intrinsics
Nov 14 2019, 3:47 AM
kmclaughlin closed D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics.
Nov 14 2019, 3:47 AM · Restricted Project

Nov 13 2019

kmclaughlin updated the diff for D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics.
  • Rebased & removed unused llvm.aarch64.sve.fcmla.lane.nxv2f64 from sve-intrinsics-fp-arith.ll
Nov 13 2019, 10:13 AM · Restricted Project
kmclaughlin created D70180: [AArch64][SVE] Implement floating-point conversion intrinsics.
Nov 13 2019, 6:53 AM · Restricted Project

Nov 11 2019

kmclaughlin updated the diff for D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics.
  • Changed target constant to MVT::i32 in complexrotateop & complexrotateopodd definitions
Nov 11 2019, 3:40 AM · Restricted Project

Nov 8 2019

kmclaughlin added inline comments to D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics.
Nov 8 2019, 3:49 AM · Restricted Project

Nov 5 2019

kmclaughlin created D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics.
Nov 5 2019, 10:29 AM · Restricted Project

Nov 4 2019

kmclaughlin created D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics.
Nov 4 2019, 4:12 AM · Restricted Project

Nov 1 2019

kmclaughlin created D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics.
Nov 1 2019, 5:12 AM · Restricted Project
kmclaughlin committed rG5ec34dfdf733: [AArch64][SVE] Implement several floating-point arithmetic intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement several floating-point arithmetic intrinsics
Nov 1 2019, 3:56 AM
kmclaughlin closed D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics.
Nov 1 2019, 3:56 AM · Restricted Project

Oct 31 2019

kmclaughlin updated the diff for D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics.
  • Removed duplicate AdvSIMD_Pred2VectorArg_Intrinsic class after rebase
Oct 31 2019, 10:01 AM · Restricted Project
kmclaughlin created D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics.
Oct 31 2019, 3:26 AM · Restricted Project

Oct 30 2019

kmclaughlin committed rG5c2c94648e42: [AArch64][SVE] Implement masked store intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement masked store intrinsics
Oct 30 2019, 5:09 AM
kmclaughlin closed D69378: [AArch64][SVE] Implement masked store intrinsics.
Oct 30 2019, 5:09 AM · Restricted Project
kmclaughlin committed rGe128c2086489: [AArch64][SVE] Implement additional integer arithmetic intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement additional integer arithmetic intrinsics
Oct 30 2019, 4:41 AM
kmclaughlin closed D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics.
Oct 30 2019, 4:41 AM · Restricted Project
kmclaughlin updated the diff for D69378: [AArch64][SVE] Implement masked store intrinsics.
  • Improve CHECK lines used in sve-masked-ldst-nonext.ll & sve-masked-ldst-trunc.ll
Oct 30 2019, 3:54 AM · Restricted Project

Oct 29 2019

kmclaughlin added a reviewer for D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics: dancgr.
Oct 29 2019, 9:02 AM · Restricted Project
kmclaughlin created D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics.
Oct 29 2019, 8:16 AM · Restricted Project
kmclaughlin updated the diff for D69378: [AArch64][SVE] Implement masked store intrinsics.
  • Removed masked load tests from sve-masked-ldst-trunc.ll
Oct 29 2019, 6:25 AM · Restricted Project

Oct 28 2019

kmclaughlin updated the diff for D69378: [AArch64][SVE] Implement masked store intrinsics.
  • Split functions in sve-masked-ldst-nonext.ll into separate load & store tests
Oct 28 2019, 5:00 AM · Restricted Project
kmclaughlin committed rGda720a38b9f2: [AArch64][SVE] Implement masked load intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement masked load intrinsics
Oct 28 2019, 3:28 AM
kmclaughlin closed D68877: [AArch64][SVE] Implement masked load intrinsics.
Oct 28 2019, 3:28 AM · Restricted Project

Oct 24 2019

kmclaughlin added a parent revision for D69378: [AArch64][SVE] Implement masked store intrinsics: D68877: [AArch64][SVE] Implement masked load intrinsics.
Oct 24 2019, 5:51 AM · Restricted Project
kmclaughlin added a child revision for D68877: [AArch64][SVE] Implement masked load intrinsics: D69378: [AArch64][SVE] Implement masked store intrinsics.
Oct 24 2019, 5:51 AM · Restricted Project
kmclaughlin created D69378: [AArch64][SVE] Implement masked store intrinsics.
Oct 24 2019, 5:39 AM · Restricted Project

Oct 23 2019

kmclaughlin added a comment to D68877: [AArch64][SVE] Implement masked load intrinsics.

I'm not sure if there is support yet for vector selects in the SVE codegen?

Oct 23 2019, 5:56 AM · Restricted Project
kmclaughlin updated the diff for D68877: [AArch64][SVE] Implement masked load intrinsics.
  • Removed unnecessary pseudo from SVEInstrFormats.td
Oct 23 2019, 5:47 AM · Restricted Project

Oct 21 2019

kmclaughlin added a comment to D68877: [AArch64][SVE] Implement masked load intrinsics.

Thanks for reviewing this, @dmgreen! I have updated the patch to make use of the changes to DAGCombine introduced by D68337.

Oct 21 2019, 9:30 AM · Restricted Project
kmclaughlin updated the diff for D68877: [AArch64][SVE] Implement masked load intrinsics.
  • Rebased patch, removed extra sext & zext combine from DAGCombine which are no longer necessary
  • Added isVectorLoadExtDesirable to AArch64ISelLowering
  • Added more checks to isLegalMaskedLoad
  • Changed SVEUndef to SVEDup0Undef, handling undef or all zeros
  • Changed SelectionDAG::getConstant to return SPLAT_VECTOR instead of BUILD_VECTOR for scalable types
Oct 21 2019, 9:20 AM · Restricted Project

Oct 18 2019

kmclaughlin committed rG0c7cc383e5b8: [AArch64][SVE] Implement unpack intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement unpack intrinsics
Oct 18 2019, 2:40 AM
kmclaughlin committed rL375210: [AArch64][SVE] Implement unpack intrinsics.
[AArch64][SVE] Implement unpack intrinsics
Oct 18 2019, 2:40 AM
kmclaughlin closed D67550: [AArch64][SVE] Implement unpack intrinsics.
Oct 18 2019, 2:40 AM · Restricted Project

Oct 11 2019

kmclaughlin created D68877: [AArch64][SVE] Implement masked load intrinsics.
Oct 11 2019, 10:05 AM · Restricted Project
kmclaughlin added a parent revision for D68877: [AArch64][SVE] Implement masked load intrinsics: D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node.
Oct 11 2019, 10:05 AM · Restricted Project
kmclaughlin added a child revision for D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node: D68877: [AArch64][SVE] Implement masked load intrinsics.
Oct 11 2019, 10:05 AM · Restricted Project
kmclaughlin committed rGee0a0a34646f: [AArch64][SVE] Implement sdot and udot (lane) intrinsics (authored by kmclaughlin).
[AArch64][SVE] Implement sdot and udot (lane) intrinsics
Oct 11 2019, 9:01 AM
kmclaughlin closed D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics.
Oct 11 2019, 9:01 AM · Restricted Project
kmclaughlin committed rL374566: [AArch64][SVE] Implement sdot and udot (lane) intrinsics.
[AArch64][SVE] Implement sdot and udot (lane) intrinsics
Oct 11 2019, 8:51 AM
kmclaughlin added inline comments to D67550: [AArch64][SVE] Implement unpack intrinsics.
Oct 11 2019, 4:09 AM · Restricted Project
kmclaughlin updated the diff for D67550: [AArch64][SVE] Implement unpack intrinsics.

Removed unused SDPatternOperator op from sve_int_perm_unpk class

Oct 11 2019, 3:52 AM · Restricted Project